RE: [log4net][log4php] Xml Config file

[Domínguez Moraleja , Jose Luis]

That is not correct because your base "is what typically happens" is not 
really/fully true.
We have the two system running in the same machine (not matter if they are 
separate, just take care) and also they are related.
The difference between them is the business that they cover.
One of them is used for configuration and the other is for the business itself.

The more we spread configuration the more difficult to maintain. (This two 
systems are the base unit of lot of systems.)

And that's why we want to use just one file, and XML support this very well, 
and also in log4net you can see that they thought about it and you can embed 
your configuration following the example I gave, but php does not allow it as 
it doesn't manage  tag. Well I think this is the problem, but 
not quite sure. That's why I ask how can I do this, I have a solution but I 
don't think it is the right way to do things.



Saludos,
Jose

-Mensaje original-
De: Dominik Psenner [mailto:dpsen...@gmail.com]
Enviado el: lunes, 7 de agosto de 2017 21:16
Para: dev@logging.apache.org
Asunto: Re: [log4net][log4php] Xml Config file

To me this sounds rather strange because it sounds like a mix-up of unrelated 
applications. Let me explain my reasoning..

Typically, log4net would run on an entirely different machine than where 
log4php runs (i.e. apache2). At least it would not coexist within an
apache2 process since apache2 would not run dotnet assemblies as far as I am 
aware of. So there are at least two completely unrelated processes sourcing one 
and the same configuration file. It's like apache2 reading the postfix 
configuration, isn't it?

2017-08-07 17:09 GMT+02:00 Matt Sicker :

> I'm guessing that there are two separate applications running that
> want to use the same configuration. Such an idea wouldn't allow for
> logging to the same file all that well (synchronization issues), but
> being able to use the same config file across different languages would be 
> nice.
>
> On 7 August 2017 at 07:59, Dominik Psenner  wrote:
>
> > You have an application that both runs log4net AND log4php in the
> > same process?
> >
> > On 7 Aug 2017 12:51 p.m., "Domínguez Moraleja, Jose Luis" <
> > jldomingue...@sice.com> wrote:
> >
> > > I'm working in a project and we want to use this two libraries
> > > log4php
> > and
> > > log4net.
> > >
> > > We want to use just one configuration file, is there any way to do
> > > it
> > like
> > > this?:
> > >
> > >  
> > >
> > >   
> > > 
> > > 
> > >   
> > >
> > >   
> > >  > > type="log4net.Appender.ConsoleAppender">
> > >
> > >   
> > > 
> > > 
> > >   
> > > 
> > >
> > > 
> > >   
> > >   
> > >   
> > >   
> > >   
> > >   
> > > 
> > >  
> > > 
> > >
> > > 
> > >   
> > >   
> > >   
> > > 
> > >
> > >   
> > >
> > > 
> > >   
> > > 
> > >   
> > >   
> > > 
> > >   
> > >
> > >   
> > > 
> > > 
> > > 
> > > 
> > > 
> > >   
> > > 
> > >   
> > >
> > >   
> > > 
> > > 
> > > 
> > >   
> > > 
> > >
> > > 
> > >
> > > Saludos,
> > > Jose
> > >
> > >
> > >
> > > 
> > > Este mensaje va dirigido, de manera exclusiva, a su destinatario y
> > > contiene información confidencial y sujeta a secreto profesional,
> > > cuya divulgación no está permitida por la ley. En caso de haber
> > > recibido
> este
> > > mensaje por error, le rogamos que, de forma inmediata, nos lo
> > > comunique mediante correo electrónico remitido a nuestra atención
> > > o a través del teléfono (+34) 91 623 22 00 y proceda a su
> > > eliminación, así como a la
> de
> > > cualquier documento adjunto al mismo. Así mismo, le comunicamos
> > > que la distribución, copia o utilización de este mensaje, o de
> > > cualquier
> > documento
> > > adjunto al mismo, cualquiera que fuera su finalidad, están
> > > prohibidas
> por
> > > ley.  El correo electrónico vía Internet no permite asegurar la
> > > confidencialidad de los mensajes que se transmiten ni su
> > > integridad o correcta recepción. GRUPO SICE TECNOLOGIA Y SISTEMAS
> > > no asume responsabilidad por estas circunstancias. Si el
> > > destinatario de este mensaje no consintiera la utilización del
> > > correo electrónico vía
> > Internet y
> > > la grabación de los mensajes, rogamos lo ponga en nuestro
> > > conocimiento
> de
> > > forma inmediata. En cumplimiento de la normativa de protección de
> datos,
> > le
> > > informamos de que sus datos personales forman parte de un fichero
> > propiedad
> > > de GRUPO SICE TECNOLOGIA Y SISTEMAS y son tratados con la
> > > finalidad de mantenimiento de la relación adquirida con usted.
> > > Puede ejercitar los derechos de acceso, rectificación, cancelación
> > > y oposición dirigiéndose
> > por
> > > escrito a la dirección arriba indicada.
> > >
> > > This message is intended exclusively for its addressee and
> > > contains confidential informatio

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117855#comment-16117855
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user kpm1985 closed the pull request at:

https://github.com/apache/logging-log4j2/pull/106


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117854#comment-16117854
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user kpm1985 commented on the issue:

https://github.com/apache/logging-log4j2/pull/106
  
And thanks for your input, but I think my time would be better served 
somewhere else where people don't refer the COD for calling out some childish 
commenting and capital letters. Take care!


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[Matt Sicker]

It says that wildcard static imports are fine in unit tests specifically
for things like JUnit, Hamcrest, and Mockito.

On 7 August 2017 at 23:40, kenneth mcfarland 
wrote:

> Can you be more specific as your own style guide forbids wildcards..
>
> Thanks Matt!
>
> On Aug 7, 2017 9:13 PM, "Matt Sicker"  wrote:
>
> > Did you even look at the style guide before going through with this?
> >
> > http://logging.apache.org/log4j/2.x/javastyle.html
> >
> > We use a code formatter, too, which gets you most of the way there. If
> you
> > want to help fix up style issues, contributing a better checkstyle
> > configuration and fixing the errors would be more useful IMO.
> >
> > And I think you should really take a look through the code of conduct:
> >
> > http://apache.org/foundation/policies/conduct.html
> >
> > On 7 August 2017 at 22:20, kenneth mcfarland <
> kennethpmcfarl...@gmail.com>
> > wrote:
> >
> > > The comment " this would look so cool using lambdas " is in my opinion
> > > childish.
> > >
> > > I did not know the order of static imports was incorrect, I'm used to
> > > seeing them at top almost every other project but a simple copy paste
> is
> > > fine. Even the Oracle examples do it but I really don't think it's
> worth
> > > analyzing, I'll change it.
> > >
> > > Other capitalization fixes were made, so logs to console had consistent
> > > casing, again based off the majority of existing classes and the test
> > class
> > > itself.
> > >
> > > The other comments simply add a more robust output.
> > >
> > > Respectful yours,
> > > Kenneth
> > >
> > >
> > >
> > > On Aug 7, 2017 5:49 PM, "rgoers"  wrote:
> > >
> > > > Github user rgoers commented on a diff in the pull request:
> > > >
> > > > https://github.com/apache/logging-log4j2/pull/106#
> > > > discussion_r131797894
> > > >
> > > > --- Diff: log4j-core/src/test/java/org/
> apache/logging/log4j/core/
> > > LogEventFactoryTest.java
> > > > ---
> > > > @@ -87,7 +88,7 @@ public void before() {
> > > >  @Test
> > > >  public void testEvent() {
> > > >  final org.apache.logging.log4j.Logger logger =
> > > > context.getLogger("org.apache.test.LogEventFactory");
> > > > -logger.error("error message");
> > > > +logger.error("Error message");
> > > > --- End diff --
> > > >
> > > > Why does this message need to be changed?
> > > >
> > > >
> > > > ---
> > > > If your project is set up for it, you can reply to this email and
> have
> > > your
> > > > reply appear on GitHub as well. If your project does not have this
> > > feature
> > > > enabled and wishes so, or if the feature is enabled but not working,
> > > please
> > > > contact infrastructure at infrastruct...@apache.org or file a JIRA
> > > ticket
> > > > with INFRA.
> > > > ---
> > > >
> > >
> >
> >
> >
> > --
> > Matt Sicker 
> >
>



-- 
Matt Sicker 

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[kpm1985]

Github user kpm1985 closed the pull request at:

https://github.com/apache/logging-log4j2/pull/106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 issue #106: LOG4J2-1997 This cleans up the entire test packag...

[kpm1985]

Github user kpm1985 commented on the issue:

https://github.com/apache/logging-log4j2/pull/106
  
And thanks for your input, but I think my time would be better served 
somewhere else where people don't refer the COD for calling out some childish 
commenting and capital letters. Take care!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[kenneth mcfarland (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

kenneth mcfarland closed LOG4J2-1997.
-
Resolution: Fixed

Someone else can fix this mess.

> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[kenneth mcfarland]

Can you be more specific as your own style guide forbids wildcards..

Thanks Matt!

On Aug 7, 2017 9:13 PM, "Matt Sicker"  wrote:

> Did you even look at the style guide before going through with this?
>
> http://logging.apache.org/log4j/2.x/javastyle.html
>
> We use a code formatter, too, which gets you most of the way there. If you
> want to help fix up style issues, contributing a better checkstyle
> configuration and fixing the errors would be more useful IMO.
>
> And I think you should really take a look through the code of conduct:
>
> http://apache.org/foundation/policies/conduct.html
>
> On 7 August 2017 at 22:20, kenneth mcfarland 
> wrote:
>
> > The comment " this would look so cool using lambdas " is in my opinion
> > childish.
> >
> > I did not know the order of static imports was incorrect, I'm used to
> > seeing them at top almost every other project but a simple copy paste is
> > fine. Even the Oracle examples do it but I really don't think it's worth
> > analyzing, I'll change it.
> >
> > Other capitalization fixes were made, so logs to console had consistent
> > casing, again based off the majority of existing classes and the test
> class
> > itself.
> >
> > The other comments simply add a more robust output.
> >
> > Respectful yours,
> > Kenneth
> >
> >
> >
> > On Aug 7, 2017 5:49 PM, "rgoers"  wrote:
> >
> > > Github user rgoers commented on a diff in the pull request:
> > >
> > > https://github.com/apache/logging-log4j2/pull/106#
> > > discussion_r131797894
> > >
> > > --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/
> > LogEventFactoryTest.java
> > > ---
> > > @@ -87,7 +88,7 @@ public void before() {
> > >  @Test
> > >  public void testEvent() {
> > >  final org.apache.logging.log4j.Logger logger =
> > > context.getLogger("org.apache.test.LogEventFactory");
> > > -logger.error("error message");
> > > +logger.error("Error message");
> > > --- End diff --
> > >
> > > Why does this message need to be changed?
> > >
> > >
> > > ---
> > > If your project is set up for it, you can reply to this email and have
> > your
> > > reply appear on GitHub as well. If your project does not have this
> > feature
> > > enabled and wishes so, or if the feature is enabled but not working,
> > please
> > > contact infrastructure at infrastruct...@apache.org or file a JIRA
> > ticket
> > > with INFRA.
> > > ---
> > >
> >
>
>
>
> --
> Matt Sicker 
>

Re: [GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[Matt Sicker]

Did you even look at the style guide before going through with this?

http://logging.apache.org/log4j/2.x/javastyle.html

We use a code formatter, too, which gets you most of the way there. If you
want to help fix up style issues, contributing a better checkstyle
configuration and fixing the errors would be more useful IMO.

And I think you should really take a look through the code of conduct:

http://apache.org/foundation/policies/conduct.html

On 7 August 2017 at 22:20, kenneth mcfarland 
wrote:

> The comment " this would look so cool using lambdas " is in my opinion
> childish.
>
> I did not know the order of static imports was incorrect, I'm used to
> seeing them at top almost every other project but a simple copy paste is
> fine. Even the Oracle examples do it but I really don't think it's worth
> analyzing, I'll change it.
>
> Other capitalization fixes were made, so logs to console had consistent
> casing, again based off the majority of existing classes and the test class
> itself.
>
> The other comments simply add a more robust output.
>
> Respectful yours,
> Kenneth
>
>
>
> On Aug 7, 2017 5:49 PM, "rgoers"  wrote:
>
> > Github user rgoers commented on a diff in the pull request:
> >
> > https://github.com/apache/logging-log4j2/pull/106#
> > discussion_r131797894
> >
> > --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/
> LogEventFactoryTest.java
> > ---
> > @@ -87,7 +88,7 @@ public void before() {
> >  @Test
> >  public void testEvent() {
> >  final org.apache.logging.log4j.Logger logger =
> > context.getLogger("org.apache.test.LogEventFactory");
> > -logger.error("error message");
> > +logger.error("Error message");
> > --- End diff --
> >
> > Why does this message need to be changed?
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastruct...@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
> >
>



-- 
Matt Sicker 

Re: [GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[kenneth mcfarland]

The comment " this would look so cool using lambdas " is in my opinion
childish.

I did not know the order of static imports was incorrect, I'm used to
seeing them at top almost every other project but a simple copy paste is
fine. Even the Oracle examples do it but I really don't think it's worth
analyzing, I'll change it.

Other capitalization fixes were made, so logs to console had consistent
casing, again based off the majority of existing classes and the test class
itself.

The other comments simply add a more robust output.

Respectful yours,
Kenneth



On Aug 7, 2017 5:49 PM, "rgoers"  wrote:

> Github user rgoers commented on a diff in the pull request:
>
> https://github.com/apache/logging-log4j2/pull/106#
> discussion_r131797894
>
> --- Diff: 
> log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java
> ---
> @@ -87,7 +88,7 @@ public void before() {
>  @Test
>  public void testEvent() {
>  final org.apache.logging.log4j.Logger logger =
> context.getLogger("org.apache.test.LogEventFactory");
> -logger.error("error message");
> +logger.error("Error message");
> --- End diff --
>
> Why does this message need to be changed?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117665#comment-16117665
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797686
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/HostNameTest.java ---
@@ -16,21 +16,24 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.hamcrest.Matchers.endsWith;
+import static org.hamcrest.Matchers.hasSize;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertThat;
+
 import java.util.List;
 
 import org.apache.logging.log4j.core.appender.RollingFileAppender;
 import org.apache.logging.log4j.core.util.NetUtils;
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.test.appender.ListAppender;
 import org.apache.logging.log4j.util.Strings;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117654#comment-16117654
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798431
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/ShutdownTimeoutConfigurationTest.java
 ---
@@ -16,13 +16,14 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797743
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LevelTest.java ---
@@ -16,6 +16,12 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.hamcrest.Matchers.hasSize;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertThat;
+
--- End diff --

We allow wildcards on static imports so this change isn't necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117648#comment-16117648
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797278
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/GcFreeAsynchronousLoggingTest.java
 ---
@@ -18,6 +18,7 @@
 
 import org.apache.logging.log4j.categories.AsyncLoggers;
 import org.apache.logging.log4j.core.async.AsyncLoggerContextSelector;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117646#comment-16117646
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797459
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/HostNameTest.java ---
@@ -16,21 +16,24 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.hamcrest.Matchers.endsWith;
+import static org.hamcrest.Matchers.hasSize;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertThat;
+
--- End diff --

static imports go last. We also allow wildcard imports of static imports so 
this change isn't required.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117639#comment-16117639
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797094
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/DeadlockTest.java ---
@@ -17,6 +17,7 @@
 package org.apache.logging.log4j.core;
 
 import org.apache.logging.log4j.junit.LoggerContextRule;
+
--- End diff --

We don't require whitespace here.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798431
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/ShutdownTimeoutConfigurationTest.java
 ---
@@ -16,13 +16,14 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117643#comment-16117643
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797043
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsOverrideTest.java
 ---
@@ -83,9 +83,9 @@ public void testLog() {
 final Logger logger = context.getLogger();
 final List events = listAppender.getEvents();
 assertThat(events, hasSize(0));
-logger.debug("Hello, {}", "World");
+logger.debug("Hello, {}", "World Debug");
--- End diff --

Why is the message being changed?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797459
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/HostNameTest.java ---
@@ -16,21 +16,24 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.hamcrest.Matchers.endsWith;
+import static org.hamcrest.Matchers.hasSize;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertThat;
+
--- End diff --

static imports go last. We also allow wildcard imports of static imports so 
this change isn't required.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798543
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/XmlEvents.java ---
@@ -23,6 +23,7 @@
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.message.AsynchronouslyFormattable;
 import org.apache.logging.log4j.message.StructuredDataMessage;
+
--- End diff --

We don't require whitespace here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117645#comment-16117645
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797698
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LateConfigTest.java ---
@@ -26,6 +26,7 @@
 import org.apache.logging.log4j.core.config.DefaultConfiguration;
 import org.apache.logging.log4j.core.config.xml.XmlConfiguration;
 import org.apache.logging.log4j.status.StatusLogger;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117659#comment-16117659
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797863
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java 
---
@@ -52,7 +53,7 @@
 
 private ListAppender app;
 
-// this would look so cool using lambdas
+// consider using lambdas
--- End diff --

Why is this change required?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797863
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java 
---
@@ -52,7 +53,7 @@
 
 private ListAppender app;
 
-// this would look so cool using lambdas
+// consider using lambdas
--- End diff --

Why is this change required?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117649#comment-16117649
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797604
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CollectionLoggingTest.java
 ---
@@ -26,6 +26,7 @@
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.message.StringMapMessage;
 import org.apache.logging.log4j.test.appender.ListAppender;
+
--- End diff --

We don't require whitespace here.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798408
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/PropertiesFileConfigTest.java
 ---
@@ -52,7 +53,7 @@ public void testReconfiguration() throws Exception {
 final File file = new File(CONFIG);
 final long orig = file.lastModified();
 final long newTime = orig + 1;
-assertTrue("setLastModified should have succeeded.", 
file.setLastModified(newTime));
+assertTrue("setLastModified() should have succeeded.", 
file.setLastModified(newTime));
--- End diff --

why do we need the parens?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117652#comment-16117652
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797908
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventTest.java ---
@@ -27,6 +27,7 @@
 import org.apache.logging.log4j.core.impl.Log4jLogEvent;
 import org.apache.logging.log4j.message.Message;
 import org.apache.logging.log4j.message.SimpleMessage;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798474
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/TimestampMessageTest.java
 ---
@@ -16,6 +16,9 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797094
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/DeadlockTest.java ---
@@ -17,6 +17,7 @@
 package org.apache.logging.log4j.core;
 
 import org.apache.logging.log4j.junit.LoggerContextRule;
+
--- End diff --

We don't require whitespace here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798273
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LoggerUpdateTest.java ---
@@ -16,11 +16,15 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertSame;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797604
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CollectionLoggingTest.java
 ---
@@ -26,6 +26,7 @@
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.message.StringMapMessage;
 import org.apache.logging.log4j.test.appender.ListAppender;
+
--- End diff --

We don't require whitespace here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797698
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LateConfigTest.java ---
@@ -26,6 +26,7 @@
 import org.apache.logging.log4j.core.config.DefaultConfiguration;
 import org.apache.logging.log4j.core.config.xml.XmlConfiguration;
 import org.apache.logging.log4j.status.StatusLogger;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117666#comment-16117666
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798474
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/TimestampMessageTest.java
 ---
@@ -16,6 +16,9 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117651#comment-16117651
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797263
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/ExtendedLevelTest.java 
---
@@ -22,6 +22,7 @@
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.test.ExtendedLevels;
 import org.apache.logging.log4j.test.appender.ListAppender;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797908
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventTest.java ---
@@ -27,6 +27,7 @@
 import org.apache.logging.log4j.core.impl.Log4jLogEvent;
 import org.apache.logging.log4j.message.Message;
 import org.apache.logging.log4j.message.SimpleMessage;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117640#comment-16117640
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131796906
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/BasicLoggingTest.java ---
@@ -28,7 +29,7 @@
 @Test
 public void test1() {
 final Logger logger = 
LogManager.getLogger(BasicLoggingTest.class.getName());
-logger.debug("debug not set");
+logger.debug("Debug not set");
--- End diff --

Why is the message being changed?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117664#comment-16117664
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798273
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LoggerUpdateTest.java ---
@@ -16,11 +16,15 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertSame;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797263
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/ExtendedLevelTest.java 
---
@@ -22,6 +22,7 @@
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.test.ExtendedLevels;
 import org.apache.logging.log4j.test.appender.ListAppender;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117656#comment-16117656
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798101
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LoggerDateTest.java ---
@@ -16,6 +16,8 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertTrue;
--- End diff --

static imports go last. We allow wildcard imports so this change isn't 
necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798421
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/ShutdownDisabledTest.java
 ---
@@ -16,13 +16,14 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117658#comment-16117658
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798450
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/StrictXmlConfigTest.java 
---
@@ -16,6 +16,8 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117650#comment-16117650
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797060
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsOverrideTest.java
 ---
@@ -83,9 +83,9 @@ public void testLog() {
 final Logger logger = context.getLogger();
 final List events = listAppender.getEvents();
 assertThat(events, hasSize(0));
-logger.debug("Hello, {}", "World");
+logger.debug("Hello, {}", "World Debug");
 assertThat(events, hasSize(1));
-logger.log(warnLevel, "Hello DIAG");
+logger.log(warnLevel, "Hello World Warn");
--- End diff --

Why is the message being changed?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798101
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LoggerDateTest.java ---
@@ -16,6 +16,8 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertTrue;
--- End diff --

static imports go last. We allow wildcard imports so this change isn't 
necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117660#comment-16117660
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798324
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/PatternSelectorTest.java 
---
@@ -16,6 +16,10 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117668#comment-16117668
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797894
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java 
---
@@ -87,7 +88,7 @@ public void before() {
 @Test
 public void testEvent() {
 final org.apache.logging.log4j.Logger logger = 
context.getLogger("org.apache.test.LogEventFactory");
-logger.error("error message");
+logger.error("Error message");
--- End diff --

Why does this message need to be changed?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798369
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/PropertiesFileConfigTest.java
 ---
@@ -24,6 +24,7 @@
 
 import org.apache.logging.log4j.core.config.Configuration;
 import org.apache.logging.log4j.junit.LoggerContextRule;
+
--- End diff --

We don't require whitespace here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797278
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/GcFreeAsynchronousLoggingTest.java
 ---
@@ -18,6 +18,7 @@
 
 import org.apache.logging.log4j.categories.AsyncLoggers;
 import org.apache.logging.log4j.core.async.AsyncLoggerContextSelector;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797686
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/HostNameTest.java ---
@@ -16,21 +16,24 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.hamcrest.Matchers.endsWith;
+import static org.hamcrest.Matchers.hasSize;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertThat;
+
 import java.util.List;
 
 import org.apache.logging.log4j.core.appender.RollingFileAppender;
 import org.apache.logging.log4j.core.util.NetUtils;
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.test.appender.ListAppender;
 import org.apache.logging.log4j.util.Strings;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r13179
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java 
---
@@ -34,6 +34,7 @@
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.message.Message;
 import org.apache.logging.log4j.test.appender.ListAppender;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117637#comment-16117637
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131796799
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/AppenderRefLevelJsonTest.java
 ---
@@ -16,19 +16,20 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.hamcrest.Matchers.hasSize;
+import static org.junit.Assert.assertThat;
--- End diff --

Static imports go last. This fix is incorrect.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117638#comment-16117638
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131796844
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/AppenderRefLevelTest.java
 ---
@@ -16,6 +16,8 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+
--- End diff --

Static imports go last. This fix is incorrect. We also allow wildcard 
static imports so this change isn't required.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117661#comment-16117661
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798408
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/PropertiesFileConfigTest.java
 ---
@@ -52,7 +53,7 @@ public void testReconfiguration() throws Exception {
 final File file = new File(CONFIG);
 final long orig = file.lastModified();
 final long newTime = orig + 1;
-assertTrue("setLastModified should have succeeded.", 
file.setLastModified(newTime));
+assertTrue("setLastModified() should have succeeded.", 
file.setLastModified(newTime));
--- End diff --

why do we need the parens?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797060
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsOverrideTest.java
 ---
@@ -83,9 +83,9 @@ public void testLog() {
 final Logger logger = context.getLogger();
 final List events = listAppender.getEvents();
 assertThat(events, hasSize(0));
-logger.debug("Hello, {}", "World");
+logger.debug("Hello, {}", "World Debug");
 assertThat(events, hasSize(1));
-logger.log(warnLevel, "Hello DIAG");
+logger.log(warnLevel, "Hello World Warn");
--- End diff --

Why is the message being changed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797963
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventTest.java ---
@@ -99,20 +100,20 @@ public void testNanoTimeIsNotSerialized1() throws 
Exception {
 final LogEvent actual = (LogEvent) ois.readObject();
 assertNotEquals("Different event: nanoTime", copy, actual);
 assertNotEquals("Different nanoTime", copy.getNanoTime(), 
actual.getNanoTime());
-assertEquals("deserialized nanoTime is zero", 0, 
actual.getNanoTime());
+assertEquals("Deserialized nanoTime is zero", 0, 
actual.getNanoTime());
--- End diff --

Why does this message need to be changed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117663#comment-16117663
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798421
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/ShutdownDisabledTest.java
 ---
@@ -16,13 +16,14 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798450
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/StrictXmlConfigTest.java 
---
@@ -16,6 +16,8 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117641#comment-16117641
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797196
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsWithFiltersTest.java
 ---
@@ -25,6 +25,7 @@
 import org.apache.logging.log4j.core.filter.CompositeFilter;
 import org.apache.logging.log4j.core.filter.ThresholdFilter;
 import org.apache.logging.log4j.junit.LoggerContextRule;
+
--- End diff --

We don't require whitespace here. We don't disallow it either.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117662#comment-16117662
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797963
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventTest.java ---
@@ -99,20 +100,20 @@ public void testNanoTimeIsNotSerialized1() throws 
Exception {
 final LogEvent actual = (LogEvent) ois.readObject();
 assertNotEquals("Different event: nanoTime", copy, actual);
 assertNotEquals("Different nanoTime", copy.getNanoTime(), 
actual.getNanoTime());
-assertEquals("deserialized nanoTime is zero", 0, 
actual.getNanoTime());
+assertEquals("Deserialized nanoTime is zero", 0, 
actual.getNanoTime());
--- End diff --

Why does this message need to be changed?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117667#comment-16117667
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798543
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/XmlEvents.java ---
@@ -23,6 +23,7 @@
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.message.AsynchronouslyFormattable;
 import org.apache.logging.log4j.message.StructuredDataMessage;
+
--- End diff --

We don't require whitespace here.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797360
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/GcFreeSynchronousLoggingTest.java
 ---
@@ -32,6 +32,7 @@ public void testNoAllocationDuringSteadyStateLogging() 
throws Throwable {
 
 /**
  * This code runs in a separate process, instrumented with the Google 
Allocation Instrumenter.
+ * First is the above spelled correctly, secondly where is the import 
then? (KM)
--- End diff --

Why is this in the patch? It should be a question on the dev list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117647#comment-16117647
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r13179
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java 
---
@@ -34,6 +34,7 @@
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.message.Message;
 import org.apache.logging.log4j.test.appender.ListAppender;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117655#comment-16117655
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798314
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LookupTest.java ---
@@ -16,14 +16,15 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798324
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/PatternSelectorTest.java 
---
@@ -16,6 +16,10 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797217
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsTest.java ---
@@ -26,6 +26,7 @@
 import org.apache.logging.log4j.Level;
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.test.appender.ListAppender;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798314
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LookupTest.java ---
@@ -16,14 +16,15 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797196
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsWithFiltersTest.java
 ---
@@ -25,6 +25,7 @@
 import org.apache.logging.log4j.core.filter.CompositeFilter;
 import org.apache.logging.log4j.core.filter.ThresholdFilter;
 import org.apache.logging.log4j.junit.LoggerContextRule;
+
--- End diff --

We don't require whitespace here. We don't disallow it either.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117644#comment-16117644
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797217
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsTest.java ---
@@ -26,6 +26,7 @@
 import org.apache.logging.log4j.Level;
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.test.appender.ListAppender;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797043
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsOverrideTest.java
 ---
@@ -83,9 +83,9 @@ public void testLog() {
 final Logger logger = context.getLogger();
 final List events = listAppender.getEvents();
 assertThat(events, hasSize(0));
-logger.debug("Hello, {}", "World");
+logger.debug("Hello, {}", "World Debug");
--- End diff --

Why is the message being changed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117642#comment-16117642
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797360
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/GcFreeSynchronousLoggingTest.java
 ---
@@ -32,6 +32,7 @@ public void testNoAllocationDuringSteadyStateLogging() 
throws Throwable {
 
 /**
  * This code runs in a separate process, instrumented with the Google 
Allocation Instrumenter.
+ * First is the above spelled correctly, secondly where is the import 
then? (KM)
--- End diff --

Why is this in the patch? It should be a question on the dev list.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117657#comment-16117657
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798369
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/PropertiesFileConfigTest.java
 ---
@@ -24,6 +24,7 @@
 
 import org.apache.logging.log4j.core.config.Configuration;
 import org.apache.logging.log4j.junit.LoggerContextRule;
+
--- End diff --

We don't require whitespace here.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797894
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java 
---
@@ -87,7 +88,7 @@ public void before() {
 @Test
 public void testEvent() {
 final org.apache.logging.log4j.Logger logger = 
context.getLogger("org.apache.test.LogEventFactory");
-logger.error("error message");
+logger.error("Error message");
--- End diff --

Why does this message need to be changed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131796906
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/BasicLoggingTest.java ---
@@ -28,7 +29,7 @@
 @Test
 public void test1() {
 final Logger logger = 
LogManager.getLogger(BasicLoggingTest.class.getName());
-logger.debug("debug not set");
+logger.debug("Debug not set");
--- End diff --

Why is the message being changed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117653#comment-16117653
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797743
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LevelTest.java ---
@@ -16,6 +16,12 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.hamcrest.Matchers.hasSize;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertThat;
+
--- End diff --

We allow wildcards on static imports so this change isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117636#comment-16117636
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797005
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CronRolloverApp.java ---
@@ -20,7 +20,7 @@
 import org.apache.logging.log4j.Logger;
 
 /**
- * Created by rgoers on 1/1/17.
+ * Created by Ralph Goers on 1/1/17.
--- End diff --

This line should be removed entirely. 


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131796799
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/AppenderRefLevelJsonTest.java
 ---
@@ -16,19 +16,20 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.hamcrest.Matchers.hasSize;
+import static org.junit.Assert.assertThat;
--- End diff --

Static imports go last. This fix is incorrect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131796844
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/AppenderRefLevelTest.java
 ---
@@ -16,6 +16,8 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+
--- End diff --

Static imports go last. This fix is incorrect. We also allow wildcard 
static imports so this change isn't required.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

[rgoers]

Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797005
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CronRolloverApp.java ---
@@ -20,7 +20,7 @@
 import org.apache.logging.log4j.Logger;
 
 /**
- * Created by rgoers on 1/1/17.
+ * Created by Ralph Goers on 1/1/17.
--- End diff --

This line should be removed entirely. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 issue #29: Property log4j.skipJansi should have a default of ...

[rgoers]

Github user rgoers commented on the issue:

https://github.com/apache/logging-log4j2/pull/29
  
Jansi requires native code? That sucks. That means that Jansi can only be 
loaded by a single class loader and has to be in Tomcat's classpath. Given 
that, Jansi should default to being disabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Simple Patch Log4j2-1997

[kenneth mcfarland]

https://github.com/apache/logging-log4j2/pull/106

[GitHub] logging-log4j2 issue #29: Property log4j.skipJansi should have a default of ...

[jcetkov]

Github user jcetkov commented on the issue:

https://github.com/apache/logging-log4j2/pull/29
  
@mikaelstaldal I'm not able to reproduce as I'm not running windows - I've 
seen it in stacktrace from another user where the (TomEE) startup died with the 
following error
```
java.lang.UnsatisfiedLinkError: Could not load library. Reasons: [no 
jansi64-1.8 in java.library.path, no jansi-1.8 in java.library.path, no jansi 
in java.library.path, Native Library 
C:\Users\user\AppData\Local\Temp\jansi-64-1.8.dll already loaded in another 
classloader]
 at org.fusesource.hawtjni.runtime.Library.doLoad(Library.java:184)
 at org.fusesource.hawtjni.runtime.Library.load(Library.java:142)
 at org.fusesource.jansi.internal.Kernel32.(Kernel32.java:37)
 at 
org.fusesource.jansi.WindowsAnsiOutputStream.(WindowsAnsiOutputStream.java:52)
 at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
 at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [log4net][log4php] Xml Config file

[Dominik Psenner]

To me this sounds rather strange because it sounds like a mix-up of
unrelated applications. Let me explain my reasoning..

Typically, log4net would run on an entirely different machine than where
log4php runs (i.e. apache2). At least it would not coexist within an
apache2 process since apache2 would not run dotnet assemblies as far as I
am aware of. So there are at least two completely unrelated processes
sourcing one and the same configuration file. It's like apache2 reading the
postfix configuration, isn't it?

2017-08-07 17:09 GMT+02:00 Matt Sicker :

> I'm guessing that there are two separate applications running that want to
> use the same configuration. Such an idea wouldn't allow for logging to the
> same file all that well (synchronization issues), but being able to use the
> same config file across different languages would be nice.
>
> On 7 August 2017 at 07:59, Dominik Psenner  wrote:
>
> > You have an application that both runs log4net AND log4php in the same
> > process?
> >
> > On 7 Aug 2017 12:51 p.m., "Domínguez Moraleja, Jose Luis" <
> > jldomingue...@sice.com> wrote:
> >
> > > I'm working in a project and we want to use this two libraries log4php
> > and
> > > log4net.
> > >
> > > We want to use just one configuration file, is there any way to do it
> > like
> > > this?:
> > >
> > > 
> > > 
> > >
> > >   
> > > 
> > > 
> > >   
> > >
> > >   
> > > 
> > >
> > >   
> > > 
> > > 
> > >   
> > > 
> > >
> > > 
> > >   
> > >   
> > >   
> > >   
> > >   
> > >   
> > > 
> > >  
> > > 
> > >
> > > 
> > >   
> > >   
> > >   
> > > 
> > >
> > >   
> > >
> > > 
> > >   
> > > 
> > >   
> > >   
> > > 
> > >   
> > >
> > >   
> > > 
> > > 
> > > 
> > > 
> > > 
> > >   
> > > 
> > >   
> > >
> > >   
> > > 
> > > 
> > > 
> > >   
> > > 
> > >
> > > 
> > >
> > > Saludos,
> > > Jose
> > >
> > >
> > >
> > > 
> > > Este mensaje va dirigido, de manera exclusiva, a su destinatario y
> > > contiene información confidencial y sujeta a secreto profesional, cuya
> > > divulgación no está permitida por la ley. En caso de haber recibido
> este
> > > mensaje por error, le rogamos que, de forma inmediata, nos lo comunique
> > > mediante correo electrónico remitido a nuestra atención o a través del
> > > teléfono (+34) 91 623 22 00 y proceda a su eliminación, así como a la
> de
> > > cualquier documento adjunto al mismo. Así mismo, le comunicamos que la
> > > distribución, copia o utilización de este mensaje, o de cualquier
> > documento
> > > adjunto al mismo, cualquiera que fuera su finalidad, están prohibidas
> por
> > > ley.  El correo electrónico vía Internet no permite asegurar la
> > > confidencialidad de los mensajes que se transmiten ni su integridad o
> > > correcta recepción. GRUPO SICE TECNOLOGIA Y SISTEMAS no asume
> > > responsabilidad por estas circunstancias. Si el destinatario de este
> > > mensaje no consintiera la utilización del correo electrónico vía
> > Internet y
> > > la grabación de los mensajes, rogamos lo ponga en nuestro conocimiento
> de
> > > forma inmediata. En cumplimiento de la normativa de protección de
> datos,
> > le
> > > informamos de que sus datos personales forman parte de un fichero
> > propiedad
> > > de GRUPO SICE TECNOLOGIA Y SISTEMAS y son tratados con la finalidad de
> > > mantenimiento de la relación adquirida con usted. Puede ejercitar los
> > > derechos de acceso, rectificación, cancelación y oposición dirigiéndose
> > por
> > > escrito a la dirección arriba indicada.
> > >
> > > This message is intended exclusively for its addressee and contains
> > > confidential information and subject to professional secrecy, the
> > > disclosure of which is not permitted by law. If you have received this
> > > message in error, please immediately notify us by e-mail sent to our
> > > attention or via telephone (+34) 91 623 22 00 and proceed to its
> > > elimination, as well as any document attached to it. Likewise, we
> inform
> > > you that the distribution, copying or use of this message, or any
> > document
> > > attached to the same, whatever its purpose, are prohibited by law. The
> > > Internet e-mail does not ensure the confidentiality of messages that
> are
> > > transmitted or its integrity or proper reception. GRUPO SICE
> TECNOLOGIA Y
> > > SISTEMAS assumes no responsibility for these circumstances. If the
> > > recipient of this message does not consent to the use of e-mail via the
> > > Internet and the recording of the messages, please put it in our
> > knowledge
> > > immediately. In compliance with the regulations of data protection, we
> > > inform you that your personal data are part of a file property of GRUPO
> > > SICE TECNOLOGIA Y SISTEMAS and are treated with the aim of maintaining
> > the
> > > relationship gained with you. You can exercise your rights of access,

Re: picocli in log4j

[Matt Sicker]

JCommander is in use mainly for the log4j-server stuff.

On 7 August 2017 at 10:21, Chandra 
wrote:

> +1 for picocli, I looked into it some time ago and looked pretty good.
> In-fact, I wanted to use it for my own project for `JvmTop`.
>
> btw, where are we using `Jcommander` in log4j2?
>
>
> thanks,
> Chandra
>
> On 7 Aug 2017, 8:32 PM +0530, Matt Sicker , wrote:
> > I have no objections. I do like your library, though I haven't used it
> for
> > any of my own projects yet (since most of what I've been working on for
> the
> > past several months have all been Mesos-managed containers, so startup
> has
> > been mostly delegated to environment variables for configuration).
> >
> > The autocomplete feature sounds pretty sweet.
> >
> > On 4 August 2017 at 13:59, Remko Popma  wrote:
> >
> > > Thanks all for your positive feedback on picocli  > > back
> > > in April.
> > > There have been multiple releases since then and I am confident about
> its
> > > stability now.
> > >
> > > Any objections if I replace our current usage of JCommander
> > >  with picocli?
> > >
> > > Main benefits:
> > >
> > > - Customizable usage help
> > > - Usage help with ANSI colors
> > >  > > - Better support for positional parameters
> > > - POSIX short options (like -xvrf)
> > > - Can be included as source to reduce external dependencies
> > > - Coming soon: autocomplete
> > >  autocomplete-(work-in-
> > > progress)
> > >
> >
> >
> >
> > --
> > Matt Sicker 



-- 
Matt Sicker 

Re: picocli in log4j

[Chandra]

+1 for picocli, I looked into it some time ago and looked pretty good.
In-fact, I wanted to use it for my own project for `JvmTop`.

btw, where are we using `Jcommander` in log4j2?


thanks,
Chandra

On 7 Aug 2017, 8:32 PM +0530, Matt Sicker , wrote:
> I have no objections. I do like your library, though I haven't used it for
> any of my own projects yet (since most of what I've been working on for the
> past several months have all been Mesos-managed containers, so startup has
> been mostly delegated to environment variables for configuration).
>
> The autocomplete feature sounds pretty sweet.
>
> On 4 August 2017 at 13:59, Remko Popma  wrote:
>
> > Thanks all for your positive feedback on picocli  > back
> > in April.
> > There have been multiple releases since then and I am confident about its
> > stability now.
> >
> > Any objections if I replace our current usage of JCommander
> >  with picocli?
> >
> > Main benefits:
> >
> > - Customizable usage help
> > - Usage help with ANSI colors
> >  > - Better support for positional parameters
> > - POSIX short options (like -xvrf)
> > - Can be included as source to reduce external dependencies
> > - Coming soon: autocomplete
> >  > progress)
> >
>
>
>
> --
> Matt Sicker 

Re: [log4net][log4php] Xml Config file

[Matt Sicker]

I'm guessing that there are two separate applications running that want to
use the same configuration. Such an idea wouldn't allow for logging to the
same file all that well (synchronization issues), but being able to use the
same config file across different languages would be nice.

On 7 August 2017 at 07:59, Dominik Psenner  wrote:

> You have an application that both runs log4net AND log4php in the same
> process?
>
> On 7 Aug 2017 12:51 p.m., "Domínguez Moraleja, Jose Luis" <
> jldomingue...@sice.com> wrote:
>
> > I'm working in a project and we want to use this two libraries log4php
> and
> > log4net.
> >
> > We want to use just one configuration file, is there any way to do it
> like
> > this?:
> >
> > 
> > 
> >
> >   
> > 
> > 
> >   
> >
> >   
> > 
> >
> >   
> > 
> > 
> >   
> > 
> >
> > 
> >   
> >   
> >   
> >   
> >   
> >   
> > 
> >  
> > 
> >
> > 
> >   
> >   
> >   
> > 
> >
> >   
> >
> > 
> >   
> > 
> >   
> >   
> > 
> >   
> >
> >   
> > 
> > 
> > 
> > 
> > 
> >   
> > 
> >   
> >
> >   
> > 
> > 
> > 
> >   
> > 
> >
> > 
> >
> > Saludos,
> > Jose
> >
> >
> >
> > 
> > Este mensaje va dirigido, de manera exclusiva, a su destinatario y
> > contiene información confidencial y sujeta a secreto profesional, cuya
> > divulgación no está permitida por la ley. En caso de haber recibido este
> > mensaje por error, le rogamos que, de forma inmediata, nos lo comunique
> > mediante correo electrónico remitido a nuestra atención o a través del
> > teléfono (+34) 91 623 22 00 y proceda a su eliminación, así como a la de
> > cualquier documento adjunto al mismo. Así mismo, le comunicamos que la
> > distribución, copia o utilización de este mensaje, o de cualquier
> documento
> > adjunto al mismo, cualquiera que fuera su finalidad, están prohibidas por
> > ley.  El correo electrónico vía Internet no permite asegurar la
> > confidencialidad de los mensajes que se transmiten ni su integridad o
> > correcta recepción. GRUPO SICE TECNOLOGIA Y SISTEMAS no asume
> > responsabilidad por estas circunstancias. Si el destinatario de este
> > mensaje no consintiera la utilización del correo electrónico vía
> Internet y
> > la grabación de los mensajes, rogamos lo ponga en nuestro conocimiento de
> > forma inmediata. En cumplimiento de la normativa de protección de datos,
> le
> > informamos de que sus datos personales forman parte de un fichero
> propiedad
> > de GRUPO SICE TECNOLOGIA Y SISTEMAS y son tratados con la finalidad de
> > mantenimiento de la relación adquirida con usted. Puede ejercitar los
> > derechos de acceso, rectificación, cancelación y oposición dirigiéndose
> por
> > escrito a la dirección arriba indicada.
> >
> > This message is intended exclusively for its addressee and contains
> > confidential information and subject to professional secrecy, the
> > disclosure of which is not permitted by law. If you have received this
> > message in error, please immediately notify us by e-mail sent to our
> > attention or via telephone (+34) 91 623 22 00 and proceed to its
> > elimination, as well as any document attached to it. Likewise, we inform
> > you that the distribution, copying or use of this message, or any
> document
> > attached to the same, whatever its purpose, are prohibited by law. The
> > Internet e-mail does not ensure the confidentiality of messages that are
> > transmitted or its integrity or proper reception. GRUPO SICE TECNOLOGIA Y
> > SISTEMAS assumes no responsibility for these circumstances. If the
> > recipient of this message does not consent to the use of e-mail via the
> > Internet and the recording of the messages, please put it in our
> knowledge
> > immediately. In compliance with the regulations of data protection, we
> > inform you that your personal data are part of a file property of GRUPO
> > SICE TECNOLOGIA Y SISTEMAS and are treated with the aim of maintaining
> the
> > relationship gained with you. You can exercise your rights of access,
> > rectification, cancellation and opposition by writing to the address
> > indicated above.
> > 
> > 
> > 
> > _
> >
>



-- 
Matt Sicker 

Re: picocli in log4j

[Matt Sicker]

I have no objections. I do like your library, though I haven't used it for
any of my own projects yet (since most of what I've been working on for the
past several months have all been Mesos-managed containers, so startup has
been mostly delegated to environment variables for configuration).

The autocomplete feature sounds pretty sweet.

On 4 August 2017 at 13:59, Remko Popma  wrote:

> Thanks all for your positive feedback on picocli 
> back
> in April.
> There have been multiple releases since then and I am confident about its
> stability now.
>
> Any objections if I replace our current usage of JCommander
>  with picocli?
>
> Main benefits:
>
>- Customizable usage help
>- Usage help with ANSI colors
>
>- Better support for positional parameters
>- POSIX short options (like -xvrf)
>- Can be included as source to reduce external dependencies
>- Coming soon: autocomplete
> progress)>
>



-- 
Matt Sicker 

Re: [log4net][log4php] Xml Config file

[Dominik Psenner]

You have an application that both runs log4net AND log4php in the same
process?

On 7 Aug 2017 12:51 p.m., "Domínguez Moraleja, Jose Luis" <
jldomingue...@sice.com> wrote:

> I'm working in a project and we want to use this two libraries log4php and
> log4net.
>
> We want to use just one configuration file, is there any way to do it like
> this?:
>
> 
> 
>
>   
> 
> 
>   
>
>   
> 
>
>   
> 
> 
>   
> 
>
> 
>   
>   
>   
>   
>   
>   
> 
>  
> 
>
> 
>   
>   
>   
> 
>
>   
>
> 
>   
> 
>   
>   
> 
>   
>
>   
> 
> 
> 
> 
> 
>   
> 
>   
>
>   
> 
> 
> 
>   
> 
>
> 
>
> Saludos,
> Jose
>
>
>
> 
> Este mensaje va dirigido, de manera exclusiva, a su destinatario y
> contiene información confidencial y sujeta a secreto profesional, cuya
> divulgación no está permitida por la ley. En caso de haber recibido este
> mensaje por error, le rogamos que, de forma inmediata, nos lo comunique
> mediante correo electrónico remitido a nuestra atención o a través del
> teléfono (+34) 91 623 22 00 y proceda a su eliminación, así como a la de
> cualquier documento adjunto al mismo. Así mismo, le comunicamos que la
> distribución, copia o utilización de este mensaje, o de cualquier documento
> adjunto al mismo, cualquiera que fuera su finalidad, están prohibidas por
> ley.  El correo electrónico vía Internet no permite asegurar la
> confidencialidad de los mensajes que se transmiten ni su integridad o
> correcta recepción. GRUPO SICE TECNOLOGIA Y SISTEMAS no asume
> responsabilidad por estas circunstancias. Si el destinatario de este
> mensaje no consintiera la utilización del correo electrónico vía Internet y
> la grabación de los mensajes, rogamos lo ponga en nuestro conocimiento de
> forma inmediata. En cumplimiento de la normativa de protección de datos, le
> informamos de que sus datos personales forman parte de un fichero propiedad
> de GRUPO SICE TECNOLOGIA Y SISTEMAS y son tratados con la finalidad de
> mantenimiento de la relación adquirida con usted. Puede ejercitar los
> derechos de acceso, rectificación, cancelación y oposición dirigiéndose por
> escrito a la dirección arriba indicada.
>
> This message is intended exclusively for its addressee and contains
> confidential information and subject to professional secrecy, the
> disclosure of which is not permitted by law. If you have received this
> message in error, please immediately notify us by e-mail sent to our
> attention or via telephone (+34) 91 623 22 00 and proceed to its
> elimination, as well as any document attached to it. Likewise, we inform
> you that the distribution, copying or use of this message, or any document
> attached to the same, whatever its purpose, are prohibited by law. The
> Internet e-mail does not ensure the confidentiality of messages that are
> transmitted or its integrity or proper reception. GRUPO SICE TECNOLOGIA Y
> SISTEMAS assumes no responsibility for these circumstances. If the
> recipient of this message does not consent to the use of e-mail via the
> Internet and the recording of the messages, please put it in our knowledge
> immediately. In compliance with the regulations of data protection, we
> inform you that your personal data are part of a file property of GRUPO
> SICE TECNOLOGIA Y SISTEMAS and are treated with the aim of maintaining the
> relationship gained with you. You can exercise your rights of access,
> rectification, cancellation and opposition by writing to the address
> indicated above.
> 
> 
> 
> _
>

[log4net][log4php] Xml Config file

[Domínguez Moraleja , Jose Luis]

I'm working in a project and we want to use this two libraries log4php and 
log4net.

We want to use just one configuration file, is there any way to do it like 
this?:




  


  

  


  


  



  
  
  
  
  
  

 



  
  
  


  


  

  
  

  

  





  

  

  



  




Saludos,
Jose




Este mensaje va dirigido, de manera exclusiva, a su destinatario y contiene 
información confidencial y sujeta a secreto profesional, cuya divulgación no 
está permitida por la ley. En caso de haber recibido este mensaje por error, le 
rogamos que, de forma inmediata, nos lo comunique mediante correo electrónico 
remitido a nuestra atención o a través del teléfono (+34) 91 623 22 00 y 
proceda a su eliminación, así como a la de cualquier documento adjunto al 
mismo. Así mismo, le comunicamos que la distribución, copia o utilización de 
este mensaje, o de cualquier documento adjunto al mismo, cualquiera que fuera 
su finalidad, están prohibidas por ley.  El correo electrónico vía Internet no 
permite asegurar la confidencialidad de los mensajes que se transmiten ni su 
integridad o correcta recepción. GRUPO SICE TECNOLOGIA Y SISTEMAS no asume 
responsabilidad por estas circunstancias. Si el destinatario de este mensaje no 
consintiera la utilización del correo electrónico vía Internet y la grabación 
de los mensajes, rogamos lo ponga en nuestro conocimiento de forma inmediata. 
En cumplimiento de la normativa de protección de datos, le informamos de que 
sus datos personales forman parte de un fichero propiedad de GRUPO SICE 
TECNOLOGIA Y SISTEMAS y son tratados con la finalidad de mantenimiento de la 
relación adquirida con usted. Puede ejercitar los derechos de acceso, 
rectificación, cancelación y oposición dirigiéndose por escrito a la dirección 
arriba indicada.

This message is intended exclusively for its addressee and contains 
confidential information and subject to professional secrecy, the disclosure of 
which is not permitted by law. If you have received this message in error, 
please immediately notify us by e-mail sent to our attention or via telephone 
(+34) 91 623 22 00 and proceed to its elimination, as well as any document 
attached to it. Likewise, we inform you that the distribution, copying or use 
of this message, or any document attached to the same, whatever its purpose, 
are prohibited by law. The Internet e-mail does not ensure the confidentiality 
of messages that are transmitted or its integrity or proper reception. GRUPO 
SICE TECNOLOGIA Y SISTEMAS assumes no responsibility for these circumstances. 
If the recipient of this message does not consent to the use of e-mail via the 
Internet and the recording of the messages, please put it in our knowledge 
immediately. In compliance with the regulations of data protection, we inform 
you that your personal data are part of a file property of GRUPO SICE 
TECNOLOGIA Y SISTEMAS and are treated with the aim of maintaining the 
relationship gained with you. You can exercise your rights of access, 
rectification, cancellation and opposition by writing to the address indicated 
above.
_