Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Volkan Yazıcı]

I am not able to follow: 88 LoC with ad-hoc exclusions

.

> Maven Assembly Plugin has reproducible builds. :-)

You got me there.
`git ls-tree | zip` requires an extra line to make it reproducible.

bash two-liner vs. 88 LoC

On Tue, May 2, 2023 at 11:06 PM Piotr P. Karwasz 
wrote:

> Hi Volkan,
>
> On Tue, 2 May 2023 at 22:22, Volkan Yazıcı  wrote:
> > Regarding `maven-assembly-plugin`... I simply don't get the motivation
> > behind replacing `git ls-files | zip` with hundreds of lines of XML
> > containing ad-hoc include/exclude statements in a module that needs to be
> > excluded in various other `pom.xml` files of the project.
>
> Now I have the exact line count: 55 lines (comments included) in the
> main pom.xml of `l-l-transform`. 30 lines of assembly descriptor.
> No inclusions and exclusions are needed.
>
> > Not to mention
> > its configuration needs to be maintained manually and there have been
> > occasions in the past where certain modules were forgotten to be added
> and
> > got noticed at the last minute. Mind sharing advantages of this
> > sophistication over a bash one-liner?
>
> Maven Assembly Plugin has reproducible builds. :-)
>
> Piotr
>

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Piotr P. Karwasz]

Hi Volkan,

On Tue, 2 May 2023 at 22:22, Volkan Yazıcı  wrote:
> Regarding `maven-assembly-plugin`... I simply don't get the motivation
> behind replacing `git ls-files | zip` with hundreds of lines of XML
> containing ad-hoc include/exclude statements in a module that needs to be
> excluded in various other `pom.xml` files of the project.

Now I have the exact line count: 55 lines (comments included) in the
main pom.xml of `l-l-transform`. 30 lines of assembly descriptor.
No inclusions and exclusions are needed.

> Not to mention
> its configuration needs to be maintained manually and there have been
> occasions in the past where certain modules were forgotten to be added and
> got noticed at the last minute. Mind sharing advantages of this
> sophistication over a bash one-liner?

Maven Assembly Plugin has reproducible builds. :-)

Piotr

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Volkan Yazıcı]

What is the thing exactly cluttering here? It is as transparent as it can
possibly get.

Regarding `maven-assembly-plugin`... I simply don't get the motivation
behind replacing `git ls-files | zip` with hundreds of lines of XML
containing ad-hoc include/exclude statements in a module that needs to be
excluded in various other `pom.xml` files of the project. Not to mention
its configuration needs to be maintained manually and there have been
occasions in the past where certain modules were forgotten to be added and
got noticed at the last minute. Mind sharing advantages of this
sophistication over a bash one-liner?

On Tue, May 2, 2023 at 9:44 PM Gary Gregory  wrote:

> Uh? It should NOT contain an exact copy of a git repository, what do I need
> a ".github" folder for in order to build the project?  I don't, it just
> clutter things up for no good reason. None of the Apache projects I've seen
> do this. It sounds like a convenience because it's easy as opposed to using
> a proper Maven assembly plugin configuration with a bin.xml file and a
> src.xml file.
>
> Gary
>
> On Tue, May 2, 2023, 15:12 Volkan Yazıcı  wrote:
>
> > I completely disagree. Generated ZIP archive contains _an exact copy_ of
> > the repository snapshot used to generate the release. (In a nutshell, it
> is
> > `git ls-files | zip` output.)
> >
> > Contrast this with Log4j, which bundles everything out there using the
> > provided configuration composed of dozens of lines of exclude statements.
> >
> > On Tue, May 2, 2023 at 5:17 PM Gary D. Gregory 
> > wrote:
> >
> > > Another needed clean-up (not a blocker): The zip file has all sorts of
> > git
> > > junk: a .github folder, a .gitignore file, and a .mvn folder (I
> certainly
> > > don't want extra maven junk either but that's just me)? There should
> only
> > > _sources_, not a snapshot of all files in the github repo. For example,
> > see
> > >
> >
> https://dlcdn.apache.org/logging/log4j/2.20.0/apache-log4j-2.20.0-bin.zip
> > >
> > > Gary
> > >
> > >
> > > On 2023/05/01 19:09:37 "Piotr P. Karwasz" wrote:
> > > > The Apache Log4j Transformation Tools 0.1.0 release is now available
> > for
> > > voting.
> > > >
> > > > This is the first release and it contains two modules:
> > > >
> > > > * [LOG4J2-3638]: Adds a bytecode transformation tool to provide
> > > > location information without reflection.
> > > > * [LOG4J2-673]: Adds a resource transformer for the Maven Shade
> Plugin
> > > > to merge `Log4j2Plugins.dat` plugin caches. Thanks to Eduard
> > > > Gizatullin.
> > > >
> > > > Source repository: https://github.com/apache/logging-log4j-transform
> > > > Tag: rel/0.1.0-rc2
> > > > Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae
> > > > Artifacts:
> > > https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0
> > > > Nexus repository:
> > > >
> > https://repository.apache.org/content/repositories/orgapachelogging-1104
> > > > CI job run:
> > >
> >
> https://github.com/apache/logging-log4j-transform/actions/runs/4853722893
> > > > Signing key:
> > >
> >
> https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index
> > > >
> > > > Please download, test, and cast your votes on the Log4j developers
> > list.
> > > >
> > > > [ ] +1, release the artifacts
> > > > [ ] -1, don't release, because...
> > > >
> > > > The vote will remain open for 72 hours All votes are welcome and we
> > > > encourage everyone to test the release, but only the Logging Services
> > > > PMC votes are officially counted. At least 3 +1 votes and more
> > > > positive than negative votes are required.
> > > >
> > > > Countdown:
> > >
> >
> https://www.timeanddate.com/countdown/launch?iso=20230504T2115=4162=cursive
> > > >
> > > > Piotr
> > > >
> > >
> >
>

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Gary Gregory]

Uh? It should NOT contain an exact copy of a git repository, what do I need
a ".github" folder for in order to build the project?  I don't, it just
clutter things up for no good reason. None of the Apache projects I've seen
do this. It sounds like a convenience because it's easy as opposed to using
a proper Maven assembly plugin configuration with a bin.xml file and a
src.xml file.

Gary

On Tue, May 2, 2023, 15:12 Volkan Yazıcı  wrote:

> I completely disagree. Generated ZIP archive contains _an exact copy_ of
> the repository snapshot used to generate the release. (In a nutshell, it is
> `git ls-files | zip` output.)
>
> Contrast this with Log4j, which bundles everything out there using the
> provided configuration composed of dozens of lines of exclude statements.
>
> On Tue, May 2, 2023 at 5:17 PM Gary D. Gregory 
> wrote:
>
> > Another needed clean-up (not a blocker): The zip file has all sorts of
> git
> > junk: a .github folder, a .gitignore file, and a .mvn folder (I certainly
> > don't want extra maven junk either but that's just me)? There should only
> > _sources_, not a snapshot of all files in the github repo. For example,
> see
> >
> https://dlcdn.apache.org/logging/log4j/2.20.0/apache-log4j-2.20.0-bin.zip
> >
> > Gary
> >
> >
> > On 2023/05/01 19:09:37 "Piotr P. Karwasz" wrote:
> > > The Apache Log4j Transformation Tools 0.1.0 release is now available
> for
> > voting.
> > >
> > > This is the first release and it contains two modules:
> > >
> > > * [LOG4J2-3638]: Adds a bytecode transformation tool to provide
> > > location information without reflection.
> > > * [LOG4J2-673]: Adds a resource transformer for the Maven Shade Plugin
> > > to merge `Log4j2Plugins.dat` plugin caches. Thanks to Eduard
> > > Gizatullin.
> > >
> > > Source repository: https://github.com/apache/logging-log4j-transform
> > > Tag: rel/0.1.0-rc2
> > > Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae
> > > Artifacts:
> > https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0
> > > Nexus repository:
> > >
> https://repository.apache.org/content/repositories/orgapachelogging-1104
> > > CI job run:
> >
> https://github.com/apache/logging-log4j-transform/actions/runs/4853722893
> > > Signing key:
> >
> https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index
> > >
> > > Please download, test, and cast your votes on the Log4j developers
> list.
> > >
> > > [ ] +1, release the artifacts
> > > [ ] -1, don't release, because...
> > >
> > > The vote will remain open for 72 hours All votes are welcome and we
> > > encourage everyone to test the release, but only the Logging Services
> > > PMC votes are officially counted. At least 3 +1 votes and more
> > > positive than negative votes are required.
> > >
> > > Countdown:
> >
> https://www.timeanddate.com/countdown/launch?iso=20230504T2115=4162=cursive
> > >
> > > Piotr
> > >
> >
>

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Volkan Yazıcı]

I completely disagree. Generated ZIP archive contains _an exact copy_ of
the repository snapshot used to generate the release. (In a nutshell, it is
`git ls-files | zip` output.)

Contrast this with Log4j, which bundles everything out there using the
provided configuration composed of dozens of lines of exclude statements.

On Tue, May 2, 2023 at 5:17 PM Gary D. Gregory  wrote:

> Another needed clean-up (not a blocker): The zip file has all sorts of git
> junk: a .github folder, a .gitignore file, and a .mvn folder (I certainly
> don't want extra maven junk either but that's just me)? There should only
> _sources_, not a snapshot of all files in the github repo. For example, see
> https://dlcdn.apache.org/logging/log4j/2.20.0/apache-log4j-2.20.0-bin.zip
>
> Gary
>
>
> On 2023/05/01 19:09:37 "Piotr P. Karwasz" wrote:
> > The Apache Log4j Transformation Tools 0.1.0 release is now available for
> voting.
> >
> > This is the first release and it contains two modules:
> >
> > * [LOG4J2-3638]: Adds a bytecode transformation tool to provide
> > location information without reflection.
> > * [LOG4J2-673]: Adds a resource transformer for the Maven Shade Plugin
> > to merge `Log4j2Plugins.dat` plugin caches. Thanks to Eduard
> > Gizatullin.
> >
> > Source repository: https://github.com/apache/logging-log4j-transform
> > Tag: rel/0.1.0-rc2
> > Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae
> > Artifacts:
> https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0
> > Nexus repository:
> > https://repository.apache.org/content/repositories/orgapachelogging-1104
> > CI job run:
> https://github.com/apache/logging-log4j-transform/actions/runs/4853722893
> > Signing key:
> https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index
> >
> > Please download, test, and cast your votes on the Log4j developers list.
> >
> > [ ] +1, release the artifacts
> > [ ] -1, don't release, because...
> >
> > The vote will remain open for 72 hours All votes are welcome and we
> > encourage everyone to test the release, but only the Logging Services
> > PMC votes are officially counted. At least 3 +1 votes and more
> > positive than negative votes are required.
> >
> > Countdown:
> https://www.timeanddate.com/countdown/launch?iso=20230504T2115=4162=cursive
> >
> > Piotr
> >
>

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Volkan Yazıcı]

I agree that we should share the link to the `KEYS` file, granted that we
also share the signing key's public ID.

As a side note, the shared link is not a random one; it is the one used by
Nexus to verify the signatures. (Yes, I am aware that Nexus is not
recognized as an official distribution mechanism by the ASF.)

On Tue, May 2, 2023 at 5:08 PM Gary D. Gregory  wrote:

> Note:
>
> > Signing key:
> https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index
>
> A random link on the internet is irrelevant, what matters is what is in
> our KEYS file at:
> https://downloads.apache.org/logging/KEYS
>
> Gary
>
> On 2023/05/01 19:09:37 "Piotr P. Karwasz" wrote:
> > The Apache Log4j Transformation Tools 0.1.0 release is now available for
> voting.
> >
> > This is the first release and it contains two modules:
> >
> > * [LOG4J2-3638]: Adds a bytecode transformation tool to provide
> > location information without reflection.
> > * [LOG4J2-673]: Adds a resource transformer for the Maven Shade Plugin
> > to merge `Log4j2Plugins.dat` plugin caches. Thanks to Eduard
> > Gizatullin.
> >
> > Source repository: https://github.com/apache/logging-log4j-transform
> > Tag: rel/0.1.0-rc2
> > Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae
> > Artifacts:
> https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0
> > Nexus repository:
> > https://repository.apache.org/content/repositories/orgapachelogging-1104
> > CI job run:
> https://github.com/apache/logging-log4j-transform/actions/runs/4853722893
> > Signing key:
> https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index
> >
> > Please download, test, and cast your votes on the Log4j developers list.
> >
> > [ ] +1, release the artifacts
> > [ ] -1, don't release, because...
> >
> > The vote will remain open for 72 hours All votes are welcome and we
> > encourage everyone to test the release, but only the Logging Services
> > PMC votes are officially counted. At least 3 +1 votes and more
> > positive than negative votes are required.
> >
> > Countdown:
> https://www.timeanddate.com/countdown/launch?iso=20230504T2115=4162=cursive
> >
> > Piotr
> >
>

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Ralph Goers]

I don’t see release notes or a download link at that site.  Personally, I think 
the side nav link should be under a new “related projects” heading rather than 
making it appear that it is a component of Log4j2 itself.

FWIW, I am leaving this under the vote thread since it sounds like you are 
going to create another release candidate and start a new vote. (The subject in 
the email really should reference the rc to avoid confusion on multiple votes 
for the same release).

Ralph

> On May 1, 2023, at 9:53 PM, Piotr P. Karwasz  wrote:
> 
> Hi,
> 
> On Mon, 1 May 2023 at 21:09, Piotr P. Karwasz  wrote:
>> Source repository: https://github.com/apache/logging-log4j-transform
>> Tag: rel/0.1.0-rc2
>> Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae
>> Artifacts: 
>> https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0
>> Nexus repository:
>> https://repository.apache.org/content/repositories/orgapachelogging-1104
>> CI job run: 
>> https://github.com/apache/logging-log4j-transform/actions/runs/4853722893
>> Signing key: 
>> https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index
> 
> I forgot to add a link to the website:
> 
> Website: https://logging.staged.apache.org/log4j/2.x/log4j-transform
> 
> Piotr

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Gary D. Gregory]

+1

Tests the src zip, asc and SHA file OK despite the SHA file being broken as 
Ralph noted (there should not be a target folder in the name).

mvn clean verify OK with:

Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
Maven home: C:\java\apache-maven-3.9.1
Java version: 17.0.7, vendor: Eclipse Adoptium, runtime: C:\Program 
Files\Eclipse Adoptium\jdk-17.0.7.7-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Gary

On 2023/05/02 04:29:22 Ralph Goers wrote:
> +1
> 
> I checked out the tag and built the transformer and then ran it against one 
> of my projects at work and verified it generated some Log4j2Cache classes.
> 
> I verified the signature.
> I verified the checksum. While it is a good checksum the file name included 
> in the .sha512 file is target/apache-log4j-transform-0.1.0-src.zip which 
> causes "shasum -a 512 check” to fail. This should be fixed for the next 
> release.
> 
> Ralph
> 
> > On May 1, 2023, at 12:09 PM, Piotr P. Karwasz  
> > wrote:
> > 
> > The Apache Log4j Transformation Tools 0.1.0 release is now available for 
> > voting.
> > 
> > This is the first release and it contains two modules:
> > 
> > * [LOG4J2-3638]: Adds a bytecode transformation tool to provide
> > location information without reflection.
> > * [LOG4J2-673]: Adds a resource transformer for the Maven Shade Plugin
> > to merge `Log4j2Plugins.dat` plugin caches. Thanks to Eduard
> > Gizatullin.
> > 
> > Source repository: https://github.com/apache/logging-log4j-transform
> > Tag: rel/0.1.0-rc2
> > Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae
> > Artifacts: 
> > https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0
> > Nexus repository:
> > https://repository.apache.org/content/repositories/orgapachelogging-1104
> > CI job run: 
> > https://github.com/apache/logging-log4j-transform/actions/runs/4853722893
> > Signing key: 
> > https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index
> > 
> > Please download, test, and cast your votes on the Log4j developers list.
> > 
> > [ ] +1, release the artifacts
> > [ ] -1, don't release, because...
> > 
> > The vote will remain open for 72 hours All votes are welcome and we
> > encourage everyone to test the release, but only the Logging Services
> > PMC votes are officially counted. At least 3 +1 votes and more
> > positive than negative votes are required.
> > 
> > Countdown: 
> > https://www.timeanddate.com/countdown/launch?iso=20230504T2115=4162=cursive
> > 
> > Piotr
> 
> 

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Gary D. Gregory]

HI Ralph: Nitpicking: I'm pretty sure you're supposed to test the src zip, not 
the repo. In theory these two are different because the zip should not contain 
extra non-source junk like the .github folder.

Gary

On 2023/05/02 04:29:22 Ralph Goers wrote:
> +1
> 
> I checked out the tag and built the transformer and then ran it against one 
> of my projects at work and verified it generated some Log4j2Cache classes.
> 
> I verified the signature.
> I verified the checksum. While it is a good checksum the file name included 
> in the .sha512 file is target/apache-log4j-transform-0.1.0-src.zip which 
> causes "shasum -a 512 check” to fail. This should be fixed for the next 
> release.
> 
> Ralph
> 
> > On May 1, 2023, at 12:09 PM, Piotr P. Karwasz  
> > wrote:
> > 
> > The Apache Log4j Transformation Tools 0.1.0 release is now available for 
> > voting.
> > 
> > This is the first release and it contains two modules:
> > 
> > * [LOG4J2-3638]: Adds a bytecode transformation tool to provide
> > location information without reflection.
> > * [LOG4J2-673]: Adds a resource transformer for the Maven Shade Plugin
> > to merge `Log4j2Plugins.dat` plugin caches. Thanks to Eduard
> > Gizatullin.
> > 
> > Source repository: https://github.com/apache/logging-log4j-transform
> > Tag: rel/0.1.0-rc2
> > Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae
> > Artifacts: 
> > https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0
> > Nexus repository:
> > https://repository.apache.org/content/repositories/orgapachelogging-1104
> > CI job run: 
> > https://github.com/apache/logging-log4j-transform/actions/runs/4853722893
> > Signing key: 
> > https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index
> > 
> > Please download, test, and cast your votes on the Log4j developers list.
> > 
> > [ ] +1, release the artifacts
> > [ ] -1, don't release, because...
> > 
> > The vote will remain open for 72 hours All votes are welcome and we
> > encourage everyone to test the release, but only the Logging Services
> > PMC votes are officially counted. At least 3 +1 votes and more
> > positive than negative votes are required.
> > 
> > Countdown: 
> > https://www.timeanddate.com/countdown/launch?iso=20230504T2115=4162=cursive
> > 
> > Piotr
> 
> 

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Gary D. Gregory]

Another needed clean-up (not a blocker): The zip file has all sorts of git 
junk: a .github folder, a .gitignore file, and a .mvn folder (I certainly don't 
want extra maven junk either but that's just me)? There should only _sources_, 
not a snapshot of all files in the github repo. For example, see 
https://dlcdn.apache.org/logging/log4j/2.20.0/apache-log4j-2.20.0-bin.zip

Gary


On 2023/05/01 19:09:37 "Piotr P. Karwasz" wrote:
> The Apache Log4j Transformation Tools 0.1.0 release is now available for 
> voting.
> 
> This is the first release and it contains two modules:
> 
> * [LOG4J2-3638]: Adds a bytecode transformation tool to provide
> location information without reflection.
> * [LOG4J2-673]: Adds a resource transformer for the Maven Shade Plugin
> to merge `Log4j2Plugins.dat` plugin caches. Thanks to Eduard
> Gizatullin.
> 
> Source repository: https://github.com/apache/logging-log4j-transform
> Tag: rel/0.1.0-rc2
> Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae
> Artifacts: 
> https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0
> Nexus repository:
> https://repository.apache.org/content/repositories/orgapachelogging-1104
> CI job run: 
> https://github.com/apache/logging-log4j-transform/actions/runs/4853722893
> Signing key: 
> https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index
> 
> Please download, test, and cast your votes on the Log4j developers list.
> 
> [ ] +1, release the artifacts
> [ ] -1, don't release, because...
> 
> The vote will remain open for 72 hours All votes are welcome and we
> encourage everyone to test the release, but only the Logging Services
> PMC votes are officially counted. At least 3 +1 votes and more
> positive than negative votes are required.
> 
> Countdown: 
> https://www.timeanddate.com/countdown/launch?iso=20230504T2115=4162=cursive
> 
> Piotr
> 

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Gary D. Gregory]

Note:

> Signing key: 
> https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index

A random link on the internet is irrelevant, what matters is what is in our 
KEYS file at:
https://downloads.apache.org/logging/KEYS

Gary

On 2023/05/01 19:09:37 "Piotr P. Karwasz" wrote:
> The Apache Log4j Transformation Tools 0.1.0 release is now available for 
> voting.
> 
> This is the first release and it contains two modules:
> 
> * [LOG4J2-3638]: Adds a bytecode transformation tool to provide
> location information without reflection.
> * [LOG4J2-673]: Adds a resource transformer for the Maven Shade Plugin
> to merge `Log4j2Plugins.dat` plugin caches. Thanks to Eduard
> Gizatullin.
> 
> Source repository: https://github.com/apache/logging-log4j-transform
> Tag: rel/0.1.0-rc2
> Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae
> Artifacts: 
> https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0
> Nexus repository:
> https://repository.apache.org/content/repositories/orgapachelogging-1104
> CI job run: 
> https://github.com/apache/logging-log4j-transform/actions/runs/4853722893
> Signing key: 
> https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index
> 
> Please download, test, and cast your votes on the Log4j developers list.
> 
> [ ] +1, release the artifacts
> [ ] -1, don't release, because...
> 
> The vote will remain open for 72 hours All votes are welcome and we
> encourage everyone to test the release, but only the Logging Services
> PMC votes are officially counted. At least 3 +1 votes and more
> positive than negative votes are required.
> 
> Countdown: 
> https://www.timeanddate.com/countdown/launch?iso=20230504T2115=4162=cursive
> 
> Piotr
> 

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Piotr P. Karwasz]

Hi,

On Mon, 1 May 2023 at 21:09, Piotr P. Karwasz  wrote:
> * [LOG4J2-3638]: Adds a bytecode transformation tool to provide
> location information without reflection.

There is a small but pesky restriction in the Maven plugin: there is
no includes/excludes setting. While not a problem for the general
user, it prevents me to write a benchmark comparing woven and unwoven
classes.

Therefore I *withdraw* this release candidate and I'll release RC3 tonight.


Piotr

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Piotr P. Karwasz]

Hi,

On Mon, 1 May 2023 at 21:09, Piotr P. Karwasz  wrote:
> Source repository: https://github.com/apache/logging-log4j-transform
> Tag: rel/0.1.0-rc2
> Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae
> Artifacts: 
> https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0
> Nexus repository:
> https://repository.apache.org/content/repositories/orgapachelogging-1104
> CI job run: 
> https://github.com/apache/logging-log4j-transform/actions/runs/4853722893
> Signing key: 
> https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index

I forgot to add a link to the website:

Website: https://logging.staged.apache.org/log4j/2.x/log4j-transform

Piotr

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

[Ralph Goers]

+1

I checked out the tag and built the transformer and then ran it against one of 
my projects at work and verified it generated some Log4j2Cache classes.

I verified the signature.
I verified the checksum. While it is a good checksum the file name included in 
the .sha512 file is target/apache-log4j-transform-0.1.0-src.zip which causes 
"shasum -a 512 check” to fail. This should be fixed for the next release.

Ralph

> On May 1, 2023, at 12:09 PM, Piotr P. Karwasz  wrote:
> 
> The Apache Log4j Transformation Tools 0.1.0 release is now available for 
> voting.
> 
> This is the first release and it contains two modules:
> 
> * [LOG4J2-3638]: Adds a bytecode transformation tool to provide
> location information without reflection.
> * [LOG4J2-673]: Adds a resource transformer for the Maven Shade Plugin
> to merge `Log4j2Plugins.dat` plugin caches. Thanks to Eduard
> Gizatullin.
> 
> Source repository: https://github.com/apache/logging-log4j-transform
> Tag: rel/0.1.0-rc2
> Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae
> Artifacts: 
> https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0
> Nexus repository:
> https://repository.apache.org/content/repositories/orgapachelogging-1104
> CI job run: 
> https://github.com/apache/logging-log4j-transform/actions/runs/4853722893
> Signing key: 
> https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index
> 
> Please download, test, and cast your votes on the Log4j developers list.
> 
> [ ] +1, release the artifacts
> [ ] -1, don't release, because...
> 
> The vote will remain open for 72 hours All votes are welcome and we
> encourage everyone to test the release, but only the Logging Services
> PMC votes are officially counted. At least 3 +1 votes and more
> positive than negative votes are required.
> 
> Countdown: 
> https://www.timeanddate.com/countdown/launch?iso=20230504T2115=4162=cursive
> 
> Piotr