Re: terms filter in json.facet
Sure Michael. I have created issue
https://issues.apache.org/jira/browse/SOLR-14921
Thanks
Gopi
On Fri, Oct 9, 2020 at 9:31 AM Michael Gibney
wrote:
> Hi Gopi,
>
> This sounds useful. I was thinking about it this morning, and about
> more general ways in which this could be implemented. If you're going
> to work on this, would you be willing to open an issue before doing
> significant work on an implementation, to provide a place to discuss
> the high-level approach?
>
> So as to not be too cryptic, here's what I was thinking:
> The behavior you're seeking is already achievable by creating multiple
> json.facet queries (q="{!term f=field v='Some term'}", and sorting
> them client-side (if applicable). This works nicely because you're
> inherently dealing with a limited number of values; but it's
> relatively verbose, and in order to logically group related facet
> queries, I've ended up as a workaround nesting them all under a dummy
> parent facet query (q='*:*') -- not ideal. What I'm considering as a
> potential solution could be more generally thought of as "templated
> bucketed facet query", and would probably be more based on the
> FacetQueryProcessor, and could work for cases other than an explicit
> term list.
>
> Hoping to continue this discussion on a Jira issue; thanks!
>
> Michael
>
> On Thu, Oct 8, 2020 at 1:52 PM David Smiley wrote:
> >>
> >> Can I raise a JIRA and work on the code change to support it?
> >
> >
> > Of course. Search for an existing JIRA first, just in case someone
> reported this already.
> >
> > ~ David Smiley
> > Apache Lucene/Solr Search Developer
> > http://www.linkedin.com/in/davidwsmiley
> >
> >
> > On Thu, Oct 8, 2020 at 12:35 PM gopikannan wrote:
> >>
> >> Hi David,
> >>Thanks for replying. I know that it is not supported. Can I raise a
> JIRA and work on the code change to support it? FacetField class needs to
> be modified and probably a new FacetFieldProcessor needs to be added.
> >>
> >> Thanks
> >> Gopi
> >>
> >> On Wed, Oct 7, 2020 at 3:56 PM David Smiley wrote:
> >>>
> >>> Please ask on the solr-user list. I think the answer is "no" but I'm
> not sure.
> >>>
> >>> ~ David Smiley
> >>> Apache Lucene/Solr Search Developer
> >>> http://www.linkedin.com/in/davidwsmiley
> >>>
> >>>
> >>> On Mon, Oct 5, 2020 at 9:10 PM gopikannan wrote:
> >>>>
> >>>> Hi,
> >>>> In normal facet request below can be used to filter the facet
> terms. I am not able to do the same using json.facet. Please let me know
> whether I can raise a JIRA for this. Checked the code and I think I can
> work on the changes to support this.
> >>>>
> >>>> facet.field={!terms='alfa,betta,with\,with\',with space'}symbol
> >>>>
> >>>> https://lucene.apache.org/solr/guide/6_6/faceting.html
> >>>>
> >>>> Thanks
> >>>> Gopi
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
>
Re: terms filter in json.facet
Hi David,
Thanks for replying. I know that it is not supported. Can I raise a JIRA
and work on the code change to support it? FacetField class needs to be
modified and probably a new FacetFieldProcessor needs to be added.
Thanks
Gopi
On Wed, Oct 7, 2020 at 3:56 PM David Smiley wrote:
> Please ask on the solr-user list. I think the answer is "no" but I'm not
> sure.
>
> ~ David Smiley
> Apache Lucene/Solr Search Developer
> http://www.linkedin.com/in/davidwsmiley
>
>
> On Mon, Oct 5, 2020 at 9:10 PM gopikannan wrote:
>
>> Hi,
>> In normal facet request below can be used to filter the facet terms. I
>> am not able to do the same using json.facet. Please let me know whether I
>> can raise a JIRA for this. Checked the code and I think I can work on the
>> changes to support this.
>>
>> facet.field={!terms='alfa,betta,with\,with\',with space'}symbol
>>
>> https://lucene.apache.org/solr/guide/6_6/faceting.html
>>
>> Thanks
>> Gopi
>>
>
terms filter in json.facet
Hi,
In normal facet request below can be used to filter the facet terms. I am
not able to do the same using json.facet. Please let me know whether I can
raise a JIRA for this. Checked the code and I think I can work on the
changes to support this.
facet.field={!terms='alfa,betta,with\,with\',with space'}symbol
https://lucene.apache.org/solr/guide/6_6/faceting.html
Thanks
Gopi
Re: SolrCloud - "[not a shard request]" is returned when search request is short circuited
Thanks David, Submitted https://issues.apache.org/jira/browse/SOLR-13595. On Wed, Jul 3, 2019 at 3:11 PM David Smiley wrote: > Sounds like a bug to me; please do file an issue. > > ~ David Smiley > Apache Lucene/Solr Search Developer > http://www.linkedin.com/in/davidwsmiley > > > On Fri, Jun 28, 2019 at 7:24 PM gopikannan wrote: > >> Hello, >>If the collection has only one shard/replica or in case when _route_ >> param points to the hosted core, [shard] field in response is set to >> "[not a shard request]". >> >> When short-circuiting in below code "shard.url" is not populated in >> request param. >> Please let me know if I submit a JIRA. >> >> >> https://github.com/apache/lucene-solr/blob/301ea0e4624c2bd693fc034a801c4abb91cba299/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java#L405 >> >> http://localhost:8983/solr/collection1/selct?q=*:*=[shard] >> >> Thanks >> Gopi >> >
[jira] [Created] (SOLR-13595) SolrCloud - "[not a shard request]" is returned when search request is short circuited
gopikannan venugopalsamy created SOLR-13595: --- Summary: SolrCloud - "[not a shard request]" is returned when search request is short circuited Key: SOLR-13595 URL: https://issues.apache.org/jira/browse/SOLR-13595 Project: Solr Issue Type: Bug Security Level: Public (Default Security Level. Issues are Public) Reporter: gopikannan venugopalsamy If the collection has only one shard/replica or in case when _route_ param points to the hosted core, [shard] field in response is set to "[not a shard request]". When short-circuiting in below code "shard.url" is not populated in request param. [https://github.com/apache/lucene-solr/blob/301ea0e4624c2bd693fc034a801c4abb91cba299/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java#L405] [http://localhost:8983/solr/collection1/selct?q=*:*=[shard]] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
SolrCloud - "[not a shard request]" is returned when search request is short circuited
Hello, If the collection has only one shard/replica or in case when _route_ param points to the hosted core, [shard] field in response is set to "[not a shard request]". When short-circuiting in below code "shard.url" is not populated in request param. Please let me know if I submit a JIRA. https://github.com/apache/lucene-solr/blob/301ea0e4624c2bd693fc034a801c4abb91cba299/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java#L405 http://localhost:8983/solr/collection1/selct?q=*:*=[shard] Thanks Gopi
Fwd: Solr 7.2.1 Stream API throws null pointer execption when used with collapse filter query
Hi,
I am getting null pointer exception when streaming search is done with
collapse filter query. When debugged the last element in FixedBitSet array
is null. Please let me know if I can raise an issue.
https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java#L232
http://localhost:8983/stream/?expr=search(coll_a ,sort="field_a
asc",fl="field_a,field_b,field_c,field_d",qt="/export",q="*:*",fq="(filed_b:x)",fq="{!collapse
field=field_c sort='field_d desc'}")
org.apache.solr.servlet.HttpSolrCall null:java.lang.NullPointerException
at org.apache.lucene.util.BitSetIterator.(BitSetIterator.java:61)
at org.apache.solr.handler.ExportWriter.writeDocs(ExportWriter.java:243)
at org.apache.solr.handler.ExportWriter.lambda$null$1(ExportWriter.java:222)
at
org.apache.solr.response.JSONWriter.writeIterator(JSONResponseWriter.java:523)
at
org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:180)
at org.apache.solr.response.JSONWriter$2.put(JSONResponseWriter.java:559)
at org.apache.solr.handler.ExportWriter.lambda$null$2(ExportWriter.java:222)
at org.apache.solr.response.JSONWriter.writeMap(JSONResponseWriter.java:547)
at
org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:198)
at org.apache.solr.response.JSONWriter$2.put(JSONResponseWriter.java:559)
at
org.apache.solr.handler.ExportWriter.lambda$write$3(ExportWriter.java:220)
at org.apache.solr.response.JSONWriter.writeMap(JSONResponseWriter.java:547)
at org.apache.solr.handler.ExportWriter.write(ExportWriter.java:218)
at org.apache.solr.core.SolrCore$3.write(SolrCore.java:2627)
at
org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:49)
[jira] [Commented] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037286#comment-16037286 ] gopikannan venugopalsamy commented on SOLR-8762: [~mkhludnev] Great, Thanks. > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > Fix For: master (7.0), 6.7 > > Attachments: SOLR-8762.patch, SOLR-8762.patch, SOLR-8762.patch > > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035418#comment-16035418 ] gopikannan venugopalsamy commented on SOLR-8762: [~mkhludnev] No problem. > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > Attachments: SOLR-8762.patch, SOLR-8762.patch > > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997152#comment-15997152 ] gopikannan venugopalsamy commented on SOLR-8762: [~mkhludnev] Did you get a chance to check the patch? > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > Attachments: SOLR-8762.patch, SOLR-8762.patch > > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989192#comment-15989192 ] gopikannan venugopalsamy commented on SOLR-8762: [~mkhludnev] Is the patch ok? > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > Attachments: SOLR-8762.patch, SOLR-8762.patch > > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gopikannan venugopalsamy updated SOLR-8762: --- Attachment: SOLR-8762.patch [~mkhludnev], Understood, Please check this patch. > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > Attachments: SOLR-8762.patch, SOLR-8762.patch > > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gopikannan venugopalsamy updated SOLR-8762: --- Attachment: (was: SOLR-8762.patch) > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > Attachments: SOLR-8762.patch > > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gopikannan venugopalsamy updated SOLR-8762: --- Attachment: SOLR-8762.patch [~mkhludnev] last patch was incomplete, Please check this. > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > Attachments: SOLR-8762.patch, SOLR-8762.patch > > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gopikannan venugopalsamy updated SOLR-8762: --- Attachment: (was: SOLR-8762.patch) > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > Attachments: SOLR-8762.patch > > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gopikannan venugopalsamy updated SOLR-8762: --- Attachment: SOLR-8762.patch [~mkhludnev], Please check this patch, Added assert. > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > Attachments: SOLR-8762.patch > > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971424#comment-15971424 ] gopikannan venugopalsamy commented on SOLR-8762: [~mkhludnev] Did you get a chance to check out the pach? > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > Attachments: SOLR-8762.patch > > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gopikannan venugopalsamy updated SOLR-8762: --- Attachment: SOLR-8762.patch > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > Attachments: SOLR-8762.patch > > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gopikannan venugopalsamy updated SOLR-8762: --- Attachment: (was: SOLR-8762.patch) > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gopikannan venugopalsamy updated SOLR-8762: --- Attachment: SOLR-8762.patch [~mkhludnev] Makes sense, Attached patch with suggested fix. Thanks. If document has child documents they are written in response. I am parent!!I am child1!!I am child2!! > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > Attachments: SOLR-8762.patch > > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964686#comment-15964686 ] gopikannan venugopalsamy edited comment on SOLR-8762 at 4/11/17 6:09 PM: - [~mkhludnev] Derivatives of TextResponseWriter like JSONResponseWriter, XMLWriter, PHPSerializedResponseWriter, ... similar to method public abstract void writeSolrDocument(String name, SolrDocument doc, ReturnFields fields, int idx) throws IOException; was (Author: gopikannan): Derivatives of TextResponseWriter like JSONResponseWriter, XMLWriter, PHPSerializedResponseWriter, ... similar to method public abstract void writeSolrDocument(String name, SolrDocument doc, ReturnFields fields, int idx) throws IOException; > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[ https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964686#comment-15964686 ] gopikannan venugopalsamy commented on SOLR-8762: Derivatives of TextResponseWriter like JSONResponseWriter, XMLWriter, PHPSerializedResponseWriter, ... similar to method public abstract void writeSolrDocument(String name, SolrDocument doc, ReturnFields fields, int idx) throws IOException; > DIH entity child=true should respond nested documents on debug > -- > > Key: SOLR-8762 > URL: https://issues.apache.org/jira/browse/SOLR-8762 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler >Reporter: Mikhail Khludnev >Priority: Minor > Labels: newbie, newdev > > Problem is described in > [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852] > of SOLR-5147 -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-8762) DIH entity child=true should respond nested documents on debug
[
https://issues.apache.org/jira/browse/SOLR-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964669#comment-15964669
]
gopikannan venugopalsamy commented on SOLR-8762:
[~mkhludnev] Would it be better to write a routine in writer classes to write
solrInputDocument similar to writeSolrDocument?
public void writeSolrDocument(String name, SolrDocument doc, ReturnFields
returnFields, int idx ) throws IOException {
> DIH entity child=true should respond nested documents on debug
> --
>
> Key: SOLR-8762
> URL: https://issues.apache.org/jira/browse/SOLR-8762
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
>Reporter: Mikhail Khludnev
>Priority: Minor
> Labels: newbie, newdev
>
> Problem is described in
> [comment|https://issues.apache.org/jira/browse/SOLR-5147?focusedCommentId=14744852=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744852]
> of SOLR-5147
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-9217) {!join score=..}.. should delay join to createWeight
[
https://issues.apache.org/jira/browse/SOLR-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961387#comment-15961387
]
gopikannan venugopalsamy edited comment on SOLR-9217 at 4/7/17 8:28 PM:
[~mkhludnev] Thanks again, I understood the inefficiency.
[~werder] your patch works. Thanks.
Attached patch [SOLR-9217.patch]
was (Author: gopikannan):
[~mkhludnev] Thanks again, I understood the inefficiency.
[~werder] your patch works. Thanks.
Attached patch.
> {!join score=..}.. should delay join to createWeight
>
>
> Key: SOLR-9217
> URL: https://issues.apache.org/jira/browse/SOLR-9217
> Project: Solr
> Issue Type: Improvement
> Components: query parsers
>Affects Versions: 6.1
>Reporter: Mikhail Khludnev
>Priority: Minor
> Labels: newbie, newdev
> Attachments: SOLR_9217.patch, SOLR-9217.patch
>
>
> {{ScoreJoinQParserPlugin.XxxCoreJoinQuery}} executes
> {{JoinUtil.createJoinQuery}} on {{rewrite()}}, but it's inefficient in
> {{filter(...)}} syntax -or fq- (!) I suppose it's {{filter()}} only problem,
> not fq. It's better to do that in {{createWeigh()}} as it's done in classic
> Solr {{JoinQuery}}, {{JoinQParserPlugin}}.
> All existing tests is enough, we just need to assert rewrite behavior - it
> should rewrite on enclosing range query or so, and doesn't on plain term
> query.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9217) {!join score=..}.. should delay join to createWeight
[
https://issues.apache.org/jira/browse/SOLR-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
gopikannan venugopalsamy updated SOLR-9217:
---
Attachment: SOLR-9217.patch
[~mkhludnev] Thanks again, I understood the inefficiency.
[~werder] your patch works. Thanks.
Attached patch.
> {!join score=..}.. should delay join to createWeight
>
>
> Key: SOLR-9217
> URL: https://issues.apache.org/jira/browse/SOLR-9217
> Project: Solr
> Issue Type: Improvement
> Components: query parsers
>Affects Versions: 6.1
>Reporter: Mikhail Khludnev
>Priority: Minor
> Labels: newbie, newdev
> Attachments: SOLR_9217.patch, SOLR-9217.patch
>
>
> {{ScoreJoinQParserPlugin.XxxCoreJoinQuery}} executes
> {{JoinUtil.createJoinQuery}} on {{rewrite()}}, but it's inefficient in
> {{filter(...)}} syntax -or fq- (!) I suppose it's {{filter()}} only problem,
> not fq. It's better to do that in {{createWeigh()}} as it's done in classic
> Solr {{JoinQuery}}, {{JoinQParserPlugin}}.
> All existing tests is enough, we just need to assert rewrite behavior - it
> should rewrite on enclosing range query or so, and doesn't on plain term
> query.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9217) {!join score=..}.. should delay join to createWeight
[
https://issues.apache.org/jira/browse/SOLR-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957751#comment-15957751
]
gopikannan venugopalsamy commented on SOLR-9217:
[~mkhludnev], Thanks for the explanation, I was trying to assert behavior of
join with range query in filter() but it fails during parsing, The same join
query works with out filter. Is this known?
http://localhost:8983/solr/techproducts/select?q=filter({!join%20from=id%20to=id}id:[1%20TO%205])
org.apache.solr.search.SyntaxError: Cannot parse 'id:[1': Encountered ""
at line 1, column 5. Was expecting one of: "TO" ... ...
...
This works
http://localhost:8983/solr/techproducts/select?q={!join%20from=id%20to=id}id:[1%20TO%205]
> {!join score=..}.. should delay join to createWeight
>
>
> Key: SOLR-9217
> URL: https://issues.apache.org/jira/browse/SOLR-9217
> Project: Solr
> Issue Type: Improvement
> Components: query parsers
>Affects Versions: 6.1
>Reporter: Mikhail Khludnev
>Priority: Minor
> Labels: newbie, newdev
>
> {{ScoreJoinQParserPlugin.XxxCoreJoinQuery}} executes
> {{JoinUtil.createJoinQuery}} on {{rewrite()}}, but it's inefficient in
> {{filter(...)}} syntax -or fq- (!) I suppose it's {{filter()}} only problem,
> not fq. It's better to do that in {{createWeigh()}} as it's done in classic
> Solr {{JoinQuery}}, {{JoinQParserPlugin}}.
> All existing tests is enough, we just need to assert rewrite behavior - it
> should rewrite on enclosing range query or so, and doesn't on plain term
> query.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9217) {!join score=..}.. should delay join to createWeight
[
https://issues.apache.org/jira/browse/SOLR-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954612#comment-15954612
]
gopikannan venugopalsamy commented on SOLR-9217:
[~mkhludnev]
fromSearcher.search(fromQuery, collector) gets executed inside rewrite, Is
this the inefficiency?
[JoinUtil.java]
private static Query createJoinQuery(boolean multipleValuesPerDocument,
String toField, Query fromQuery,
IndexSearcher fromSearcher, ScoreMode scoreMode, final
GenericTermsCollector collector)
throws IOException {
fromSearcher.search(fromQuery, collector);
> {!join score=..}.. should delay join to createWeight
>
>
> Key: SOLR-9217
> URL: https://issues.apache.org/jira/browse/SOLR-9217
> Project: Solr
> Issue Type: Improvement
> Components: query parsers
>Affects Versions: 6.1
>Reporter: Mikhail Khludnev
>Priority: Minor
> Labels: newbie, newdev
>
> {{ScoreJoinQParserPlugin.XxxCoreJoinQuery}} executes
> {{JoinUtil.createJoinQuery}} on {{rewrite()}}, but it's inefficient in
> {{filter(...)}} syntax or fq. It's better to do that in {{createWeigh()}} as
> it's done in classic Solr {{JoinQuery}}, {{JoinQParserPlugin}}.
> All existing tests is enough, we just need to assert rewrite behavior - it
> should rewrite on enclosing range query or so, and doesn't on plain term
> query.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9745) SolrCLI swallows errors from solr.cmd
[ https://issues.apache.org/jira/browse/SOLR-9745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954605#comment-15954605 ] gopikannan venugopalsamy commented on SOLR-9745: My bad, I saw this failure in my setup and assumed that it is unrelated. Thanks > SolrCLI swallows errors from solr.cmd > - > > Key: SOLR-9745 > URL: https://issues.apache.org/jira/browse/SOLR-9745 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Server >Affects Versions: 6.3, master (7.0) >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev > Labels: newbie, newdev > Attachments: SOLR-9745.patch, SOLR-9745.patch > > > It occurs on mad scenario in LUCENE-7534: > * solr.cmd weren't granted +x (it happens under cygwin, yes) > * coolhacker worked it around with cmd /C solr.cmd start -e .. > * but when SolrCLI runs solr instances with the same solr.cmd, it just > silently fails > I think we can just pass ExecuteResultHandler which will dump exception to > console. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9217) {!join score=..}.. should delay join to createWeight
[
https://issues.apache.org/jira/browse/SOLR-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954201#comment-15954201
]
gopikannan venugopalsamy commented on SOLR-9217:
Great
Mikhail,
I am unable to understand from code what exactly is inefficient here,
Rewrite and createWeight are called one after another from
createNormalizedWeight {IndexSearcher.java}, Could you please shed some more
light at the inefficiency part?
I debugged below queries, The inefficiency is when join is part of filter
query(fq) right?
http://localhost:8983/solr/techproducts/select?q=*:*={!join%20from=id%20to=id%20score=max}*:*=score,price
http://localhost:8983/solr/techproducts/select?q={!join%20from=id%20to=id%20score=max}*:*=score,price
> {!join score=..}.. should delay join to createWeight
>
>
> Key: SOLR-9217
> URL: https://issues.apache.org/jira/browse/SOLR-9217
> Project: Solr
> Issue Type: Improvement
> Components: query parsers
>Affects Versions: 6.1
>Reporter: Mikhail Khludnev
>Priority: Minor
> Labels: newbie, newdev
>
> {{ScoreJoinQParserPlugin.XxxCoreJoinQuery}} executes
> {{JoinUtil.createJoinQuery}} on {{rewrite()}}, but it's inefficient in
> {{filter(...)}} syntax or fq. It's better to do that in {{createWeigh()}} as
> it's done in classic Solr {{JoinQuery}}, {{JoinQParserPlugin}}.
> All existing tests is enough, we just need to assert rewrite behavior - it
> should rewrite on enclosing range query or so, and doesn't on plain term
> query.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9217) {!join score=..}.. should delay join to createWeight
[
https://issues.apache.org/jira/browse/SOLR-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954183#comment-15954183
]
gopikannan venugopalsamy commented on SOLR-9217:
Can I work on this?
> {!join score=..}.. should delay join to createWeight
>
>
> Key: SOLR-9217
> URL: https://issues.apache.org/jira/browse/SOLR-9217
> Project: Solr
> Issue Type: Improvement
> Components: query parsers
>Affects Versions: 6.1
>Reporter: Mikhail Khludnev
>Priority: Minor
> Labels: newbie, newdev
>
> {{ScoreJoinQParserPlugin.XxxCoreJoinQuery}} executes
> {{JoinUtil.createJoinQuery}} on {{rewrite()}}, but it's inefficient in
> {{filter(...)}} syntax or fq. It's better to do that in {{createWeigh()}} as
> it's done in classic Solr {{JoinQuery}}, {{JoinQParserPlugin}}.
> All existing tests is enough, we just need to assert rewrite behavior - it
> should rewrite on enclosing range query or so, and doesn't on plain term
> query.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Closed] (SOLR-10387) zkTransfer normalizes destination path incorrectly if source is a windows directory
[
https://issues.apache.org/jira/browse/SOLR-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
gopikannan venugopalsamy closed SOLR-10387.
---
> zkTransfer normalizes destination path incorrectly if source is a windows
> directory
>
>
> Key: SOLR-10387
> URL: https://issues.apache.org/jira/browse/SOLR-10387
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: gopikannan venugopalsamy
>Assignee: Erick Erickson
> Fix For: trunk, 6.6
>
> Attachments: SOLR-10387.patch, SOLR-10387.patch, SOLR-10387.patch,
> SOLR-10387.patch, SOLR-10387.patch
>
>
> While normalizing dest it is looking only for '/' in source path but this
> will not work for windows style delimiter.
> /lucene-solr/solr/solrj/src/java/org/apache/solr/common/cloud/ZkMaintenanceUtils.java
> private static String normalizeDest(String srcName, String dstName) {
> if (dstName.endsWith("/")) { // Dest is a directory.
> int pos = srcName.lastIndexOf("/");
> if (pos < 0) {
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9745) bin/solr* swallows errors from running example instances at least
[ https://issues.apache.org/jira/browse/SOLR-9745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gopikannan venugopalsamy updated SOLR-9745: --- Attachment: SOLR-9745.patch Please check this patch, Added a test case to check if SolrCLI returns failure on unable to execute script. > bin/solr* swallows errors from running example instances at least > - > > Key: SOLR-9745 > URL: https://issues.apache.org/jira/browse/SOLR-9745 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Server >Affects Versions: 6.3, master (7.0) >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev > Labels: newbie, newdev > Attachments: SOLR-9745.patch, SOLR-9745.patch > > > It occurs on mad scenario in LUCENE-7534: > * solr.cmd weren't granted +x (it happens under cygwin, yes) > * coolhacker worked it around with cmd /C solr.cmd start -e .. > * but when SolrCLI runs solr instances with the same solr.cmd, it just > silently fails > I think we can just pass ExecuteResultHandler which will dump exception to > console. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10387) zkTransfer normalizes destination path incorrectly if source is a windows directory
[
https://issues.apache.org/jira/browse/SOLR-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948255#comment-15948255
]
gopikannan venugopalsamy commented on SOLR-10387:
-
:) Agreed, Tried the last patch, Tests went through. Thanks.
> zkTransfer normalizes destination path incorrectly if source is a windows
> directory
>
>
> Key: SOLR-10387
> URL: https://issues.apache.org/jira/browse/SOLR-10387
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: gopikannan venugopalsamy
>Assignee: Erick Erickson
> Attachments: SOLR-10387.patch, SOLR-10387.patch, SOLR-10387.patch,
> SOLR-10387.patch
>
>
> While normalizing dest it is looking only for '/' in source path but this
> will not work for windows style delimiter.
> /lucene-solr/solr/solrj/src/java/org/apache/solr/common/cloud/ZkMaintenanceUtils.java
> private static String normalizeDest(String srcName, String dstName) {
> if (dstName.endsWith("/")) { // Dest is a directory.
> int pos = srcName.lastIndexOf("/");
> if (pos < 0) {
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10387) zkTransfer normalizes destination path incorrectly if source is a windows directory
[
https://issues.apache.org/jira/browse/SOLR-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948190#comment-15948190
]
gopikannan venugopalsamy commented on SOLR-10387:
-
Did you check the second patch I attached ? Tests passed with it.
> zkTransfer normalizes destination path incorrectly if source is a windows
> directory
>
>
> Key: SOLR-10387
> URL: https://issues.apache.org/jira/browse/SOLR-10387
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: gopikannan venugopalsamy
>Assignee: Erick Erickson
> Attachments: SOLR-10387.patch, SOLR-10387.patch, SOLR-10387.patch
>
>
> While normalizing dest it is looking only for '/' in source path but this
> will not work for windows style delimiter.
> /lucene-solr/solr/solrj/src/java/org/apache/solr/common/cloud/ZkMaintenanceUtils.java
> private static String normalizeDest(String srcName, String dstName) {
> if (dstName.endsWith("/")) { // Dest is a directory.
> int pos = srcName.lastIndexOf("/");
> if (pos < 0) {
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-10387) zkTransfer normalizes destination path incorrectly if source is a windows directory
[
https://issues.apache.org/jira/browse/SOLR-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948137#comment-15948137
]
gopikannan venugopalsamy edited comment on SOLR-10387 at 3/30/17 12:17 AM:
---
Please check the patch I have attached, Tests succeed with it.
If dest ends with separator or '/' depending on whether it is zk or local path,
last component of source (again separator of source is '/' if is zk else local
delimiter) is appended to dest.
was (Author: gopikannan):
Test succeeds with this patch.
If dest ends with separator or '/' depending on whether it is zk or local path,
last component of source (again separator of source is '/' if is zk else local
delimiter) is appended to dest.
> zkTransfer normalizes destination path incorrectly if source is a windows
> directory
>
>
> Key: SOLR-10387
> URL: https://issues.apache.org/jira/browse/SOLR-10387
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: gopikannan venugopalsamy
>Assignee: Erick Erickson
> Attachments: SOLR-10387.patch, SOLR-10387.patch
>
>
> While normalizing dest it is looking only for '/' in source path but this
> will not work for windows style delimiter.
> /lucene-solr/solr/solrj/src/java/org/apache/solr/common/cloud/ZkMaintenanceUtils.java
> private static String normalizeDest(String srcName, String dstName) {
> if (dstName.endsWith("/")) { // Dest is a directory.
> int pos = srcName.lastIndexOf("/");
> if (pos < 0) {
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9745) bin/solr* swallows errors from running example instances at least
[ https://issues.apache.org/jira/browse/SOLR-9745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gopikannan venugopalsamy updated SOLR-9745: --- Attachment: (was: SOLR-9745.patch) > bin/solr* swallows errors from running example instances at least > - > > Key: SOLR-9745 > URL: https://issues.apache.org/jira/browse/SOLR-9745 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Server >Affects Versions: 6.3, master (7.0) >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev > Labels: newbie, newdev > Attachments: SOLR-9745.patch > > > It occurs on mad scenario in LUCENE-7534: > * solr.cmd weren't granted +x (it happens under cygwin, yes) > * coolhacker worked it around with cmd /C solr.cmd start -e .. > * but when SolrCLI runs solr instances with the same solr.cmd, it just > silently fails > I think we can just pass ExecuteResultHandler which will dump exception to > console. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-10387) zkTransfer normalizes destination path incorrectly if source is a windows directory
[
https://issues.apache.org/jira/browse/SOLR-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
gopikannan venugopalsamy updated SOLR-10387:
Attachment: SOLR-10387.patch
Test succeeds with this patch.
If dest ends with separator or '/' depending on whether it is zk or local path,
last component of source (again separator of source is '/' if is zk else local
delimiter) is appended to dest.
> zkTransfer normalizes destination path incorrectly if source is a windows
> directory
>
>
> Key: SOLR-10387
> URL: https://issues.apache.org/jira/browse/SOLR-10387
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: gopikannan venugopalsamy
>Assignee: Erick Erickson
> Attachments: SOLR-10387.patch, SOLR-10387.patch
>
>
> While normalizing dest it is looking only for '/' in source path but this
> will not work for windows style delimiter.
> /lucene-solr/solr/solrj/src/java/org/apache/solr/common/cloud/ZkMaintenanceUtils.java
> private static String normalizeDest(String srcName, String dstName) {
> if (dstName.endsWith("/")) { // Dest is a directory.
> int pos = srcName.lastIndexOf("/");
> if (pos < 0) {
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Issue Comment Deleted] (SOLR-9745) bin/solr* swallows errors from running example instances at least
[
https://issues.apache.org/jira/browse/SOLR-9745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
gopikannan venugopalsamy updated SOLR-9745:
---
Comment: was deleted
(was: No, That did not work. The comment and code is not matching, As per
comment we have to make checks on src not dest. Which one is right?
// Pull the last element of the src path and add it to the dst if the src
does NOT end in a slash
// If the source ends in a slash, do not append the last segment to the dest
if (dstName.endsWith("/")) { // Dest is a directory.)
> bin/solr* swallows errors from running example instances at least
> -
>
> Key: SOLR-9745
> URL: https://issues.apache.org/jira/browse/SOLR-9745
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Server
>Affects Versions: 6.3, master (7.0)
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
> Labels: newbie, newdev
> Attachments: SOLR-9745.patch, SOLR-9745.patch
>
>
> It occurs on mad scenario in LUCENE-7534:
> * solr.cmd weren't granted +x (it happens under cygwin, yes)
> * coolhacker worked it around with cmd /C solr.cmd start -e ..
> * but when SolrCLI runs solr instances with the same solr.cmd, it just
> silently fails
> I think we can just pass ExecuteResultHandler which will dump exception to
> console.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10387) zkTransfer normalizes destination path incorrectly if source is a windows directory
[
https://issues.apache.org/jira/browse/SOLR-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948075#comment-15948075
]
gopikannan venugopalsamy commented on SOLR-10387:
-
No, That did not work. The comment and code is not matching, As per comment we
have to make checks on src not dest. Which one is right?
// Pull the last element of the src path and add it to the dst if the src does
NOT end in a slash
// If the source ends in a slash, do not append the last segment to the dest
if (dstName.endsWith("/")) { // Dest is a directory.
> zkTransfer normalizes destination path incorrectly if source is a windows
> directory
>
>
> Key: SOLR-10387
> URL: https://issues.apache.org/jira/browse/SOLR-10387
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: gopikannan venugopalsamy
>Assignee: Erick Erickson
> Attachments: SOLR-10387.patch
>
>
> While normalizing dest it is looking only for '/' in source path but this
> will not work for windows style delimiter.
> /lucene-solr/solr/solrj/src/java/org/apache/solr/common/cloud/ZkMaintenanceUtils.java
> private static String normalizeDest(String srcName, String dstName) {
> if (dstName.endsWith("/")) { // Dest is a directory.
> int pos = srcName.lastIndexOf("/");
> if (pos < 0) {
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9745) bin/solr* swallows errors from running example instances at least
[
https://issues.apache.org/jira/browse/SOLR-9745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948074#comment-15948074
]
gopikannan venugopalsamy commented on SOLR-9745:
No, That did not work. The comment and code is not matching, As per comment we
have to make checks on src not dest. Which one is right?
// Pull the last element of the src path and add it to the dst if the src
does NOT end in a slash
// If the source ends in a slash, do not append the last segment to the dest
if (dstName.endsWith("/")) { // Dest is a directory.
> bin/solr* swallows errors from running example instances at least
> -
>
> Key: SOLR-9745
> URL: https://issues.apache.org/jira/browse/SOLR-9745
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Server
>Affects Versions: 6.3, master (7.0)
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
> Labels: newbie, newdev
> Attachments: SOLR-9745.patch, SOLR-9745.patch
>
>
> It occurs on mad scenario in LUCENE-7534:
> * solr.cmd weren't granted +x (it happens under cygwin, yes)
> * coolhacker worked it around with cmd /C solr.cmd start -e ..
> * but when SolrCLI runs solr instances with the same solr.cmd, it just
> silently fails
> I think we can just pass ExecuteResultHandler which will dump exception to
> console.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9745) bin/solr* swallows errors from running example instances at least
[ https://issues.apache.org/jira/browse/SOLR-9745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gopikannan venugopalsamy updated SOLR-9745: --- Attachment: SOLR-9745.patch patch, Sorry for multiple patches, first time :) > bin/solr* swallows errors from running example instances at least > - > > Key: SOLR-9745 > URL: https://issues.apache.org/jira/browse/SOLR-9745 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Server >Affects Versions: 6.3, master (7.0) >Reporter: Mikhail Khludnev >Assignee: Mikhail Khludnev > Labels: newbie, newdev > Attachments: SOLR-9745.patch, SOLR-9745.patch > > > It occurs on mad scenario in LUCENE-7534: > * solr.cmd weren't granted +x (it happens under cygwin, yes) > * coolhacker worked it around with cmd /C solr.cmd start -e .. > * but when SolrCLI runs solr instances with the same solr.cmd, it just > silently fails > I think we can just pass ExecuteResultHandler which will dump exception to > console. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9745) bin/solr* swallows errors from running example instances at least
[ https://issues.apache.org/jira/browse/SOLR-9745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gopikannan venugopalsamy updated SOLR-9745: --- Attachment: SOLR-9745.patch patch > bin/solr* swallows errors from running example instances at least > - > > Key: SOLR-9745 > URL: https://issues.apache.org/jira/browse/SOLR-9745 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Server >Affects Versions: 6.3, master (7.0) >Reporter: Mikhail Khludnev > Labels: newbie, newdev > Attachments: SOLR-9745.patch > > > It occurs on mad scenario in LUCENE-7534: > * solr.cmd weren't granted +x (it happens under cygwin, yes) > * coolhacker worked it around with cmd /C solr.cmd start -e .. > * but when SolrCLI runs solr instances with the same solr.cmd, it just > silently fails > I think we can just pass ExecuteResultHandler which will dump exception to > console. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-10387) zkTransfer normalizes destination path incorrectly if source is a windows directory
gopikannan venugopalsamy created SOLR-10387:
---
Summary: zkTransfer normalizes destination path incorrectly if
source is a windows directory
Key: SOLR-10387
URL: https://issues.apache.org/jira/browse/SOLR-10387
Project: Solr
Issue Type: Bug
Security Level: Public (Default Security Level. Issues are Public)
Reporter: gopikannan venugopalsamy
While normalizing dest it is looking only for '/' in source path but this will
not work for windows style delimiter.
/lucene-solr/solr/solrj/src/java/org/apache/solr/common/cloud/ZkMaintenanceUtils.java
private static String normalizeDest(String srcName, String dstName) {
if (dstName.endsWith("/")) { // Dest is a directory.
int pos = srcName.lastIndexOf("/");
if (pos < 0) {
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9745) bin/solr* swallows errors from running example instances at least
[ https://issues.apache.org/jira/browse/SOLR-9745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945791#comment-15945791 ] gopikannan venugopalsamy commented on SOLR-9745: Hi, Shall I create a patch with this fix? > bin/solr* swallows errors from running example instances at least > - > > Key: SOLR-9745 > URL: https://issues.apache.org/jira/browse/SOLR-9745 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Server >Affects Versions: 6.3, master (7.0) >Reporter: Mikhail Khludnev > Labels: newbie, newdev > > It occurs on mad scenario in LUCENE-7534: > * solr.cmd weren't granted +x (it happens under cygwin, yes) > * coolhacker worked it around with cmd /C solr.cmd start -e .. > * but when SolrCLI runs solr instances with the same solr.cmd, it just > silently fails > I think we can just pass ExecuteResultHandler which will dump exception to > console. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
