[jira] [Commented] (LUCENE-3232) Move MutableValues to Common Module
[ https://issues.apache.org/jira/browse/LUCENE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054350#comment-13054350 ] Michael McCandless commented on LUCENE-3232: OK this sounds like a good plan... if we can get FQs factored out soonish then we can simply fix grouping module to use that (ie, we don't need common module to hold the ValueSource, etc.). I guess we keep the name common for now. Maybe as we slurp in more stuff from Solr I'll like the name better :) Move MutableValues to Common Module --- Key: LUCENE-3232 URL: https://issues.apache.org/jira/browse/LUCENE-3232 Project: Lucene - Java Issue Type: Sub-task Components: core/search Reporter: Chris Male Fix For: 4.0 Attachments: LUCENE-3232.patch, LUCENE-3232.patch Solr makes use of the MutableValue* series of classes to improve performance of grouping by FunctionQuery (I think). As such they are used in ValueSource implementations. Consequently we need to move these classes in order to move the ValueSources. As Yonik pointed out, these classes have use beyond just FunctionQuerys and might be used by both Solr and other modules. However I don't think they belong in Lucene core, since they aren't really related to search functionality. Therefore I think we should put them into a Common module, which can serve as a dependency to Solr and any module. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3232) Move MutableValues to Common Module
[ https://issues.apache.org/jira/browse/LUCENE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054395#comment-13054395 ] Chris Male commented on LUCENE-3232: bq. if we can get FQs factored out soonish This is the last issue preventing me from doing just that :) bq. I guess we keep the name common for now. Awesome. I find it fairly common (ha) in projects to have a common module. If it doesn't pan out, then we can either rename it or slurp it into another module. Move MutableValues to Common Module --- Key: LUCENE-3232 URL: https://issues.apache.org/jira/browse/LUCENE-3232 Project: Lucene - Java Issue Type: Sub-task Components: core/search Reporter: Chris Male Fix For: 4.0 Attachments: LUCENE-3232.patch, LUCENE-3232.patch Solr makes use of the MutableValue* series of classes to improve performance of grouping by FunctionQuery (I think). As such they are used in ValueSource implementations. Consequently we need to move these classes in order to move the ValueSources. As Yonik pointed out, these classes have use beyond just FunctionQuerys and might be used by both Solr and other modules. However I don't think they belong in Lucene core, since they aren't really related to search functionality. Therefore I think we should put them into a Common module, which can serve as a dependency to Solr and any module. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3232) Move MutableValues to Common Module
[ https://issues.apache.org/jira/browse/LUCENE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053826#comment-13053826 ] Michael McCandless commented on LUCENE-3232: Patch looks great! I wonder if we should name this module something more specific, eg docvalues? values? Should we also move over ValueSource, *DocValues, FieldCacheSource? I think, then, Solr 3.x grouping could cutover and then group by other field types. Move MutableValues to Common Module --- Key: LUCENE-3232 URL: https://issues.apache.org/jira/browse/LUCENE-3232 Project: Lucene - Java Issue Type: Sub-task Components: core/search Reporter: Chris Male Fix For: 4.0 Attachments: LUCENE-3232.patch, LUCENE-3232.patch Solr makes use of the MutableValue* series of classes to improve performance of grouping by FunctionQuery (I think). As such they are used in ValueSource implementations. Consequently we need to move these classes in order to move the ValueSources. As Yonik pointed out, these classes have use beyond just FunctionQuerys and might be used by both Solr and other modules. However I don't think they belong in Lucene core, since they aren't really related to search functionality. Therefore I think we should put them into a Common module, which can serve as a dependency to Solr and any module. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3232) Move MutableValues to Common Module
[ https://issues.apache.org/jira/browse/LUCENE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053876#comment-13053876 ] Simon Willnauer commented on LUCENE-3232: - bq. I wonder if we should name this module something more specific, eg docvalues? values? dude! no! :) Move MutableValues to Common Module --- Key: LUCENE-3232 URL: https://issues.apache.org/jira/browse/LUCENE-3232 Project: Lucene - Java Issue Type: Sub-task Components: core/search Reporter: Chris Male Fix For: 4.0 Attachments: LUCENE-3232.patch, LUCENE-3232.patch Solr makes use of the MutableValue* series of classes to improve performance of grouping by FunctionQuery (I think). As such they are used in ValueSource implementations. Consequently we need to move these classes in order to move the ValueSources. As Yonik pointed out, these classes have use beyond just FunctionQuerys and might be used by both Solr and other modules. However I don't think they belong in Lucene core, since they aren't really related to search functionality. Therefore I think we should put them into a Common module, which can serve as a dependency to Solr and any module. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3232) Move MutableValues to Common Module
[
https://issues.apache.org/jira/browse/LUCENE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054110#comment-13054110
]
Chris Male commented on LUCENE-3232:
{quote}
I wonder if we should name this module something more specific, eg docvalues?
values?
Should we also move over ValueSource, *DocValues, FieldCacheSource? I think,
then, Solr 3.x grouping could cutover and then group by other field types.
{quote}
To be honest, that wasn't my plan :D
My plan is to first move these to a Common module which will serve basically as
a utility module for other modules. The MutableValue classes are useful in a
number of places (or will be in the future). I envisage other useful utility
like classes going into this module in the future too. Solr for example has a
number of very useful utilities that might be of benefit.
As such, it doesn't really relate to FunctionQuerys or ValueSources.
The next step once this is complete is to do what I originally intended and
make a Queries module and push FunctionQuery and all the ValueSources /
DocValues into that.
In the end you get the following structure:
modules/
common/
(MutableValue*)
queries/
(FunctionQuery, *DocValues, *ValueSource, Queries from contrib/queries)
Seem reasonable?
Move MutableValues to Common Module
---
Key: LUCENE-3232
URL: https://issues.apache.org/jira/browse/LUCENE-3232
Project: Lucene - Java
Issue Type: Sub-task
Components: core/search
Reporter: Chris Male
Fix For: 4.0
Attachments: LUCENE-3232.patch, LUCENE-3232.patch
Solr makes use of the MutableValue* series of classes to improve performance
of grouping by FunctionQuery (I think). As such they are used in ValueSource
implementations. Consequently we need to move these classes in order to move
the ValueSources.
As Yonik pointed out, these classes have use beyond just FunctionQuerys and
might be used by both Solr and other modules. However I don't think they
belong in Lucene core, since they aren't really related to search
functionality. Therefore I think we should put them into a Common module,
which can serve as a dependency to Solr and any module.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3232) Move MutableValues to Common Module
[
https://issues.apache.org/jira/browse/LUCENE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053642#comment-13053642
]
Chris Male commented on LUCENE-3232:
New code to execute with patch:
{code}svn mkdir --parents
modules/common/src/java/org/apache/lucene/common/mutable
svn move solr/src/java/org/apache/solr/search/MutableValue.java
modules/common/src/java/org/apache/lucene/common/mutable/MutableValue.java
svn move solr/src/java/org/apache/solr/search/MutableValueFloat.java
modules/common/src/java/org/apache/lucene/common/mutable/MutableValueFloat.java
svn move solr/src/java/org/apache/solr/search/MutableValueBool.java
modules/common/src/java/org/apache/lucene/common/mutable/MutableValueBool.java
svn move solr/src/java/org/apache/solr/search/MutableValueDate.java
modules/common/src/java/org/apache/lucene/common/mutable/MutableValueDate.java
svn move solr/src/java/org/apache/solr/search/MutableValueDouble.java
modules/common/src/java/org/apache/lucene/common/mutable/MutableValueDouble.java
svn move solr/src/java/org/apache/solr/search/MutableValueInt.java
modules/common/src/java/org/apache/lucene/common/mutable/MutableValueInt.java
svn move solr/src/java/org/apache/solr/search/MutableValueLong.java
modules/common/src/java/org/apache/lucene/common/mutable/MutableValueLong.java
svn move solr/src/java/org/apache/solr/search/MutableValueStr.java
modules/common/src/java/org/apache/lucene/common/mutable/MutableValueStr.java
svn move dev-tools/idea/modules/analysis/common/common.iml
dev-tools/idea/modules/analysis/common/analysis-common.iml
{code}
This code includes a change to the common.iml file used by IntelliJ for the
Analysis Common module, since this name clashed.
Move MutableValues to Common Module
---
Key: LUCENE-3232
URL: https://issues.apache.org/jira/browse/LUCENE-3232
Project: Lucene - Java
Issue Type: Sub-task
Components: core/search
Reporter: Chris Male
Fix For: 4.0
Attachments: LUCENE-3232.patch, LUCENE-3232.patch
Solr makes use of the MutableValue* series of classes to improve performance
of grouping by FunctionQuery (I think). As such they are used in ValueSource
implementations. Consequently we need to move these classes in order to move
the ValueSources.
As Yonik pointed out, these classes have use beyond just FunctionQuerys and
might be used by both Solr and other modules. However I don't think they
belong in Lucene core, since they aren't really related to search
functionality. Therefore I think we should put them into a Common module,
which can serve as a dependency to Solr and any module.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
