[jira] [Commented] (SOLR-12045) Move Analytics Component from contrib to core
[ https://issues.apache.org/jira/browse/SOLR-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445364#comment-16445364 ] Shawn Heisey commented on SOLR-12045: - bq. The solution to class loader problems is not to move everything into a big fat core In truth, I don't really care where analytics lives. Moving it would fix the classloader issue, but fixing the visibility issues is probably the best idea. An alternate (but similar) idea would be to install the jar into the webapp instead of putting it in contrib. I've cooked up a patch that changes all of the fields in ResponseBuilder to private and adds getters/setters as appropriate. A lot of getters/setters were already in the class, so this is not a major paradigm shift. The patch touches a lot of code. I will attach it momentarily. I'll leave the decision about whether to take that approach to the ones who understand the ramifications better than I do. > Move Analytics Component from contrib to core > - > > Key: SOLR-12045 > URL: https://issues.apache.org/jira/browse/SOLR-12045 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: master (8.0) >Reporter: Houston Putman >Priority: Major > Fix For: master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > The Analytics Component currently lives in contrib. Since it includes no > external dependencies, there is no harm in moving it into core solr. > The analytics component would be included as a default search component and > the analytics handler (currently only used for analytics shard requests, > might be transitioned to handle user requests in the future) would be > included as an implicit handler. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12045) Move Analytics Component from contrib to core
[ https://issues.apache.org/jira/browse/SOLR-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444829#comment-16444829 ] Jan Høydahl commented on SOLR-12045: The solution to class loader problems is not to move everything into a big fat core, but to solve the class loader issues :) > Move Analytics Component from contrib to core > - > > Key: SOLR-12045 > URL: https://issues.apache.org/jira/browse/SOLR-12045 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: master (8.0) >Reporter: Houston Putman >Priority: Major > Fix For: master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > The Analytics Component currently lives in contrib. Since it includes no > external dependencies, there is no harm in moving it into core solr. > The analytics component would be included as a default search component and > the analytics handler (currently only used for analytics shard requests, > might be transitioned to handle user requests in the future) would be > included as an implicit handler. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12045) Move Analytics Component from contrib to core
[ https://issues.apache.org/jira/browse/SOLR-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440032#comment-16440032 ] Shawn Heisey commented on SOLR-12045: - Moving this component into core would solve another issue that a couple of people have encountered: IllegalAccessError: tried to access field org.apache.solr.handler.component. ResponseBuilder._isOlapAnalytics from class org.apache.solr.handler. component.AnalyticsComponent at org.apache.solr.handler.component. AnalyticsComponent.prepare(AnalyticsComponent.java:46) I've confirmed with one user that this is fixed by moving the jar to WEB-INF/lib. Looks like loading Solr with one classloader and analytics with another classloader (using config) breaks package visibility on the field in ResponseBuilder. > Move Analytics Component from contrib to core > - > > Key: SOLR-12045 > URL: https://issues.apache.org/jira/browse/SOLR-12045 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: master (8.0) >Reporter: Houston Putman >Priority: Major > Fix For: master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > The Analytics Component currently lives in contrib. Since it includes no > external dependencies, there is no harm in moving it into core solr. > The analytics component would be included as a default search component and > the analytics handler (currently only used for analytics shard requests, > might be transitioned to handle user requests in the future) would be > included as an implicit handler. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12045) Move Analytics Component from contrib to core
[ https://issues.apache.org/jira/browse/SOLR-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437754#comment-16437754 ] David Smiley commented on SOLR-12045: - I'm not sure where best to bring this up but I'm concerned about all the ways there are to compute facets in Solr. Each needs to be maintained, documented, and then in the end Solr is more complex -- albeit maybe more capable though i really don't know right now where the gaps are. It would love to see some particular use-cases compared in terms of syntax and performance, and of course a better understanding of extra capabilities unique to each. The primary contenders are the JSON-Facets module & this Analytics module. Of course this is wishful thinking; I can't implore anyone to do anything. Well except for my kids but they are not up to this task yet LOL :-) I've seen presentations on both individually that made each out to be awesome but at no times were they compared. > Move Analytics Component from contrib to core > - > > Key: SOLR-12045 > URL: https://issues.apache.org/jira/browse/SOLR-12045 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: master (8.0) >Reporter: Houston Putman >Priority: Major > Fix For: master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > The Analytics Component currently lives in contrib. Since it includes no > external dependencies, there is no harm in moving it into core solr. > The analytics component would be included as a default search component and > the analytics handler (currently only used for analytics shard requests, > might be transitioned to handle user requests in the future) would be > included as an implicit handler. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12045) Move Analytics Component from contrib to core
[
https://issues.apache.org/jira/browse/SOLR-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388233#comment-16388233
]
Houston Putman commented on SOLR-12045:
---
Thanks for the link.
I think everything should be fine then, since:
# the {{/analytics}} handler isn't user facing yet. (It is called for shard
requests from the AnalyticsComponent)
# There are no implicit params that it needs.
> Move Analytics Component from contrib to core
> -
>
> Key: SOLR-12045
> URL: https://issues.apache.org/jira/browse/SOLR-12045
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: master (8.0)
>Reporter: Houston Putman
>Priority: Major
> Fix For: master (8.0)
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The Analytics Component currently lives in contrib. Since it includes no
> external dependencies, there is no harm in moving it into core solr.
> The analytics component would be included as a default search component and
> the analytics handler (currently only used for analytics shard requests,
> might be transitioned to handle user requests in the future) would be
> included as an implicit handler.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12045) Move Analytics Component from contrib to core
[ https://issues.apache.org/jira/browse/SOLR-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388111#comment-16388111 ] David Smiley commented on SOLR-12045: - +1 (haven't reviewed patch yet) The implicit "useParams" is explained here: SOLR-9557 > Move Analytics Component from contrib to core > - > > Key: SOLR-12045 > URL: https://issues.apache.org/jira/browse/SOLR-12045 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: master (8.0) >Reporter: Houston Putman >Priority: Major > Fix For: master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > The Analytics Component currently lives in contrib. Since it includes no > external dependencies, there is no harm in moving it into core solr. > The analytics component would be included as a default search component and > the analytics handler (currently only used for analytics shard requests, > might be transitioned to handle user requests in the future) would be > included as an implicit handler. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12045) Move Analytics Component from contrib to core
[ https://issues.apache.org/jira/browse/SOLR-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380497#comment-16380497 ] Houston Putman commented on SOLR-12045: --- I ran into some confusion when adding the `/analytics` handler as an implicit handler. In `ImplicitPlugins.json` each handler has a `useParams` option. I can't tell where this option is used, so I just followed the convention of the other handlers and put `"_ANALYTICS"` for the `/analytics` handler. If I need to actually add a param set somewhere, I'd be happy to. I just don't know where it would go. > Move Analytics Component from contrib to core > - > > Key: SOLR-12045 > URL: https://issues.apache.org/jira/browse/SOLR-12045 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: master (8.0) >Reporter: Houston Putman >Priority: Major > Fix For: master (8.0) > > Time Spent: 10m > Remaining Estimate: 0h > > The Analytics Component currently lives in contrib. Since it includes no > external dependencies, there is no harm in moving it into core solr. > The analytics component would be included as a default search component and > the analytics handler (currently only used for analytics shard requests, > might be transitioned to handle user requests in the future) would be > included as an implicit handler. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
