[jira] [Updated] (SOLR-4208) Refactor edismax query parser
[ https://issues.apache.org/jira/browse/SOLR-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomás Fernández Löbbe updated SOLR-4208: Attachment: SOLR-4208.patch Other minor change, the decision on whether to use the stopwords filter or not is extracted to a new method so that it can be overridden. Refactor edismax query parser - Key: SOLR-4208 URL: https://issues.apache.org/jira/browse/SOLR-4208 Project: Solr Issue Type: Improvement Reporter: Tomás Fernández Löbbe Priority: Minor Fix For: 4.2, 5.0 Attachments: qParserDiff.txt, SOLR-4208.patch, SOLR-4208.patch, SOLR-4208.patch With successive changes, the edismax query parser has become more complex. It would be nice to refactor it to reduce code complexity, also to allow better extension and code reuse. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4208) Refactor edismax query parser
[ https://issues.apache.org/jira/browse/SOLR-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-4208: --- Attachment: SOLR-4208.patch reading through things, i think this is definitely an improvement over what we have currently in terms of making things extensible in subclasses, and the test look great. adding sub-plugins seems like overkill at this point, probably best left for a future issue. i've improved tomas's latest patch slightly, by moving the ASL to the top of ExtendedDismaxQParser.java and setting up proper exception ignoring for those expected Field aliases lead to a cycle errors that were getting logged (the test already trie to make them ignored by using the ignored_exception magic string in the query, but these errors don't include the q in the exception message so it wasn't doing anything. I'm running tests precommit now ... but the one thing i'd really like to do before committing is make sure all of these new/existing methods have decent javadocs ... if we're making these changes to make subclassing easier, we should make sure the jdocs are their for people who write subclasses so they understand what each method does. Refactor edismax query parser - Key: SOLR-4208 URL: https://issues.apache.org/jira/browse/SOLR-4208 Project: Solr Issue Type: Improvement Reporter: Tomás Fernández Löbbe Priority: Minor Fix For: 4.2, 5.0 Attachments: qParserDiff.txt, SOLR-4208.patch, SOLR-4208.patch, SOLR-4208.patch, SOLR-4208.patch With successive changes, the edismax query parser has become more complex. It would be nice to refactor it to reduce code complexity, also to allow better extension and code reuse. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4208) Refactor edismax query parser
[ https://issues.apache.org/jira/browse/SOLR-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-4208: --- Fix Version/s: (was: 4.2) 4.1 going to try to get this into 4.1. Refactor edismax query parser - Key: SOLR-4208 URL: https://issues.apache.org/jira/browse/SOLR-4208 Project: Solr Issue Type: Improvement Reporter: Tomás Fernández Löbbe Assignee: Hoss Man Priority: Minor Fix For: 4.1, 5.0 Attachments: qParserDiff.txt, SOLR-4208.patch, SOLR-4208.patch, SOLR-4208.patch, SOLR-4208.patch With successive changes, the edismax query parser has become more complex. It would be nice to refactor it to reduce code complexity, also to allow better extension and code reuse. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4208) Refactor edismax query parser
[ https://issues.apache.org/jira/browse/SOLR-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man updated SOLR-4208: --- Attachment: SOLR-4208.patch updated patch: * fixed test to not use forbidden api (new String(byte[]) is a no-no and wasn't needed anyway) * added some javadocs to a few methods based on stuff that was obvious to me tomas folks: can you take a look at the javadocs in the patch and let me know if i made in obvious mistakes or if you have suggestions for additional javadoc improvements? Refactor edismax query parser - Key: SOLR-4208 URL: https://issues.apache.org/jira/browse/SOLR-4208 Project: Solr Issue Type: Improvement Reporter: Tomás Fernández Löbbe Assignee: Hoss Man Priority: Minor Fix For: 4.1, 5.0 Attachments: qParserDiff.txt, SOLR-4208.patch, SOLR-4208.patch, SOLR-4208.patch, SOLR-4208.patch, SOLR-4208.patch With successive changes, the edismax query parser has become more complex. It would be nice to refactor it to reduce code complexity, also to allow better extension and code reuse. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4208) Refactor edismax query parser
[ https://issues.apache.org/jira/browse/SOLR-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomás Fernández Löbbe updated SOLR-4208: Attachment: SOLR-4208.patch qParserDiff.txt Refactor edismax query parser - Key: SOLR-4208 URL: https://issues.apache.org/jira/browse/SOLR-4208 Project: Solr Issue Type: Improvement Reporter: Tomás Fernández Löbbe Priority: Minor Fix For: 4.1, 5.0 Attachments: qParserDiff.txt, SOLR-4208.patch, SOLR-4208.patch With successive changes, the edismax query parser has become more complex. It would be nice to refactor it to reduce code complexity, also to allow better extension and code reuse. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-4208) Refactor edismax query parser
[ https://issues.apache.org/jira/browse/SOLR-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomás Fernández Löbbe updated SOLR-4208: Attachment: SOLR-4208.patch A possible refactor: * I separated the ExtendedDismaxQParser so it can be extended. * I broke the parse method into smaller methods, easier to read. * Separated the configuration (parsing and all the actual fields) to a different class. DismaxQParser has too many configuration options, I think it's going to be clear if we keep those separately. * Using factory methods for the configuration and the ExtendedSolrQueryParser so that an extending class could change the implementation of those classes. * other minor changes. Thoughts? Refactor edismax query parser - Key: SOLR-4208 URL: https://issues.apache.org/jira/browse/SOLR-4208 Project: Solr Issue Type: Improvement Reporter: Tomás Fernández Löbbe Priority: Minor Fix For: 4.1, 5.0 Attachments: SOLR-4208.patch With successive changes, the edismax query parser has become more complex. It would be nice to refactor it to reduce code complexity, also to allow better extension and code reuse. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
