Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Nah, here's my alter ego: http://www.redstate.com/ Anyway, the address I try to use for all this is erick.erick...@gmail.com, thanks for straightening this out, I just assigned this one to myself. I'll attach a patch shortly. Erick On Wed, Sep 5, 2012 at 11:39 AM, Dawid Weiss dawid.we...@cs.put.poznan.pl wrote: erick.erick...@gmail.com (that one had permissions), but that either It's probably Erick's dark side alter ego: http://goo.gl/orGMC Dawid - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Java files matching anything ending in .jj or .jflex, right?
Yep, I changed one of the java files once, I think McCandless rescued me
I'll make it so, but just to verify that I'm not going off the deep
end again, the process will be to modify the .jj or .jflex files to
remove tabs, regenerate the java and check _both_ back in?
Erick
On Thu, Sep 6, 2012 at 9:05 AM, Erick Erickson (JIRA) j...@apache.org wrote:
[
https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449766#comment-13449766
]
Erick Erickson commented on LUCENE-4362:
OK, my test failures apparently related to this patch, I'm getting the same
thing after rolling it all back. I'll post on the dev list.
ban tab-indented source
---
Key: LUCENE-4362
URL: https://issues.apache.org/jira/browse/LUCENE-4362
Project: Lucene - Core
Issue Type: Task
Reporter: Robert Muir
Assignee: Erick Erickson
Attachments: LUCENE-4362_core.patch, LUCENE-4362.patch,
LUCENE-4362.patch
This makes code really difficult to read and work with.
Its easy enough to prevent.
{noformat}
Index: build.xml
===
--- build.xml (revision 1380979)
+++ build.xml (working copy)
@@ -77,11 +77,12 @@
or
containsregexp expression=@author\b casesensitive=yes/
containsregexp expression=\bno(n|)commit\b casesensitive=no/
+ containsregexp expression=\t casesensitive=no/
/or
/fileset
map from=${validate.currDir}${file.separator} to=* /
/pathconvert
-fail if=validate.patternsFoundThe following files contain @author
tags or nocommits:${line.separator}${validate.patternsFound}/fail
+fail if=validate.patternsFoundThe following files contain @author
tags, tabs or nocommits:${line.separator}${validate.patternsFound}/fail
/target
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
On Thu, Sep 6, 2012 at 12:18 PM, Erick Erickson erickerick...@gmail.com wrote: Java files matching anything ending in .jj or .jflex, right? Yep, I changed one of the java files once, I think McCandless rescued me I'll make it so, but just to verify that I'm not going off the deep end again, the process will be to modify the .jj or .jflex files to remove tabs, regenerate the java and check _both_ back in? I don't think so. I think just ignore the problems in the jflex/javacc generated code for now, so this means we cannot yet enable the ant check. I think the generators themselves are making these tabs, we need to deal with that separately. -- lucidworks.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Interestingly, this check missed the FrenchStemFilter.java (and I
don't know what others)
that found tabs by doing a quick search of the Lucene source tree.
Does the ant task
skip deprecated classes?
I like the check, I'll see about doing something about the tabs anyway, that's
gruntwork after all...
On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) j...@apache.org wrote:
[
https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448621#comment-13448621
]
Uwe Schindler commented on LUCENE-4362:
---
Yeah, and with the ANT check, so it is enforced!
If somebody wants to use a tab, e.g. in a string, he can always do \t
ban tab-indented source
---
Key: LUCENE-4362
URL: https://issues.apache.org/jira/browse/LUCENE-4362
Project: Lucene - Core
Issue Type: Task
Reporter: Robert Muir
Attachments: LUCENE-4362_core.patch
This makes code really difficult to read and work with.
Its easy enough to prevent.
{noformat}
Index: build.xml
===
--- build.xml (revision 1380979)
+++ build.xml (working copy)
@@ -77,11 +77,12 @@
or
containsregexp expression=@author\b casesensitive=yes/
containsregexp expression=\bno(n|)commit\b casesensitive=no/
+ containsregexp expression=\t casesensitive=no/
/or
/fileset
map from=${validate.currDir}${file.separator} to=* /
/pathconvert
-fail if=validate.patternsFoundThe following files contain @author
tags or nocommits:${line.separator}${validate.patternsFound}/fail
+fail if=validate.patternsFoundThe following files contain @author
tags, tabs or nocommits:${line.separator}${validate.patternsFound}/fail
/target
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
I'm claiming that fixing tabs isn't worth patch files, although maybe
a JIRA to track progress, agree?
On Wed, Sep 5, 2012 at 8:37 AM, Erick Erickson erickerick...@gmail.com wrote:
Interestingly, this check missed the FrenchStemFilter.java (and I
don't know what others)
that found tabs by doing a quick search of the Lucene source tree.
Does the ant task
skip deprecated classes?
I like the check, I'll see about doing something about the tabs anyway, that's
gruntwork after all...
On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) j...@apache.org wrote:
[
https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448621#comment-13448621
]
Uwe Schindler commented on LUCENE-4362:
---
Yeah, and with the ANT check, so it is enforced!
If somebody wants to use a tab, e.g. in a string, he can always do \t
ban tab-indented source
---
Key: LUCENE-4362
URL: https://issues.apache.org/jira/browse/LUCENE-4362
Project: Lucene - Core
Issue Type: Task
Reporter: Robert Muir
Attachments: LUCENE-4362_core.patch
This makes code really difficult to read and work with.
Its easy enough to prevent.
{noformat}
Index: build.xml
===
--- build.xml (revision 1380979)
+++ build.xml (working copy)
@@ -77,11 +77,12 @@
or
containsregexp expression=@author\b casesensitive=yes/
containsregexp expression=\bno(n|)commit\b
casesensitive=no/
+ containsregexp expression=\t casesensitive=no/
/or
/fileset
map from=${validate.currDir}${file.separator} to=* /
/pathconvert
-fail if=validate.patternsFoundThe following files contain @author
tags or nocommits:${line.separator}${validate.patternsFound}/fail
+fail if=validate.patternsFoundThe following files contain @author
tags, tabs or nocommits:${line.separator}${validate.patternsFound}/fail
/target
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
OK, through the miracles of modern IDEs I can make all the
changes (for tabs only) in just a few minutes, running tests now...
NOTE: this is just the java files, and a really stupid substitution
of two spaces for each and every tab. No, I didn't just reformat
the whole source tree, though it was tempting I'll admitG...
BUT. The freaking patch is 900K for 4x, and it touches 190 java
files. I'll be happy to check all this in, but there's a lot of code out
in branches, Git, what have you, and I want to give it a couple of
days for people to object before possibly introducing a reconciliation
nightmare.
If nobody objects by the weekend, I'll just commit (I'll create a JIRA)
both for 4x and trunk.
So a patch is indicated after all I think?
Let me know
On Wed, Sep 5, 2012 at 8:39 AM, Erick Erickson erickerick...@gmail.com wrote:
I'm claiming that fixing tabs isn't worth patch files, although maybe
a JIRA to track progress, agree?
On Wed, Sep 5, 2012 at 8:37 AM, Erick Erickson erickerick...@gmail.com
wrote:
Interestingly, this check missed the FrenchStemFilter.java (and I
don't know what others)
that found tabs by doing a quick search of the Lucene source tree.
Does the ant task
skip deprecated classes?
I like the check, I'll see about doing something about the tabs anyway,
that's
gruntwork after all...
On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) j...@apache.org wrote:
[
https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448621#comment-13448621
]
Uwe Schindler commented on LUCENE-4362:
---
Yeah, and with the ANT check, so it is enforced!
If somebody wants to use a tab, e.g. in a string, he can always do \t
ban tab-indented source
---
Key: LUCENE-4362
URL: https://issues.apache.org/jira/browse/LUCENE-4362
Project: Lucene - Core
Issue Type: Task
Reporter: Robert Muir
Attachments: LUCENE-4362_core.patch
This makes code really difficult to read and work with.
Its easy enough to prevent.
{noformat}
Index: build.xml
===
--- build.xml (revision 1380979)
+++ build.xml (working copy)
@@ -77,11 +77,12 @@
or
containsregexp expression=@author\b casesensitive=yes/
containsregexp expression=\bno(n|)commit\b
casesensitive=no/
+ containsregexp expression=\t casesensitive=no/
/or
/fileset
map from=${validate.currDir}${file.separator} to=* /
/pathconvert
-fail if=validate.patternsFoundThe following files contain @author
tags or nocommits:${line.separator}${validate.patternsFound}/fail
+fail if=validate.patternsFoundThe following files contain @author
tags, tabs or nocommits:${line.separator}${validate.patternsFound}/fail
/target
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
RE: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Erick: There is an issue about this:
https://issues.apache.org/jira/browse/LUCENE-4362
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
-Original Message-
From: Erick Erickson [mailto:erickerick...@gmail.com]
Sent: Wednesday, September 05, 2012 3:03 PM
To: dev@lucene.apache.org
Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
OK, through the miracles of modern IDEs I can make all the changes (for tabs
only) in just a few minutes, running tests now...
NOTE: this is just the java files, and a really stupid substitution of two
spaces for
each and every tab. No, I didn't just reformat the whole source tree, though
it
was tempting I'll admitG...
BUT. The freaking patch is 900K for 4x, and it touches 190 java files. I'll be
happy to check all this in, but there's a lot of code out in branches, Git,
what
have you, and I want to give it a couple of days for people to object before
possibly introducing a reconciliation nightmare.
If nobody objects by the weekend, I'll just commit (I'll create a JIRA) both
for 4x
and trunk.
So a patch is indicated after all I think?
Let me know
On Wed, Sep 5, 2012 at 8:39 AM, Erick Erickson erickerick...@gmail.com
wrote:
I'm claiming that fixing tabs isn't worth patch files, although maybe
a JIRA to track progress, agree?
On Wed, Sep 5, 2012 at 8:37 AM, Erick Erickson erickerick...@gmail.com
wrote:
Interestingly, this check missed the FrenchStemFilter.java (and I
don't know what others) that found tabs by doing a quick search of
the Lucene source tree.
Does the ant task
skip deprecated classes?
I like the check, I'll see about doing something about the tabs
anyway, that's gruntwork after all...
On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) j...@apache.org
wrote:
[
https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian
.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId
=13448621#comment-13448621 ]
Uwe Schindler commented on LUCENE-4362:
---
Yeah, and with the ANT check, so it is enforced!
If somebody wants to use a tab, e.g. in a string, he can always do
\t
ban tab-indented source
---
Key: LUCENE-4362
URL: https://issues.apache.org/jira/browse/LUCENE-4362
Project: Lucene - Core
Issue Type: Task
Reporter: Robert Muir
Attachments: LUCENE-4362_core.patch
This makes code really difficult to read and work with.
Its easy enough to prevent.
{noformat}
Index: build.xml
===
--- build.xml (revision 1380979)
+++ build.xml (working copy)
@@ -77,11 +77,12 @@
or
containsregexp expression=@author\b casesensitive=yes/
containsregexp expression=\bno(n|)commit\b
casesensitive=no/
+ containsregexp expression=\t casesensitive=no/
/or
/fileset
map from=${validate.currDir}${file.separator} to=* /
/pathconvert
-fail if=validate.patternsFoundThe following files contain
@author
tags or nocommits:${line.separator}${validate.patternsFound}/fail
+fail if=validate.patternsFoundThe following files contain
+ @author tags, tabs or
+ nocommits:${line.separator}${validate.patternsFound}/fail
/target
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators For more information on JIRA, see:
http://www.atlassian.com/software/jira
- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For
additional commands, e-mail: dev-h...@lucene.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional
commands, e-mail: dev-h...@lucene.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
On Wed, Sep 5, 2012 at 9:03 AM, Erick Erickson erickerick...@gmail.com wrote: OK, through the miracles of modern IDEs I can make all the changes (for tabs only) in just a few minutes, running tests now... NOTE: this is just the java files, and a really stupid substitution of two spaces for each and every tab. No, I didn't just reformat the whole source tree, though it was tempting I'll admitG... BUT. The freaking patch is 900K for 4x, and it touches 190 java files. I'll be happy to check all this in, but there's a lot of code out in branches, Git, what have you, and I want to give it a couple of days for people to object before possibly introducing a reconciliation nightmare. If nobody objects by the weekend, I'll just commit (I'll create a JIRA) both for 4x and trunk. get rid of the tabs please! My only concern is that some of this is generated files: e.g. jflex generated. we shouldnt do anything to this generated code directly. -- lucidworks.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
No it didnt. these classes do not exist in trunk.
On Wed, Sep 5, 2012 at 8:37 AM, Erick Erickson erickerick...@gmail.com wrote:
Interestingly, this check missed the FrenchStemFilter.java (and I
don't know what others)
that found tabs by doing a quick search of the Lucene source tree.
Does the ant task
skip deprecated classes?
I like the check, I'll see about doing something about the tabs anyway, that's
gruntwork after all...
On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) j...@apache.org wrote:
[
https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448621#comment-13448621
]
Uwe Schindler commented on LUCENE-4362:
---
Yeah, and with the ANT check, so it is enforced!
If somebody wants to use a tab, e.g. in a string, he can always do \t
ban tab-indented source
---
Key: LUCENE-4362
URL: https://issues.apache.org/jira/browse/LUCENE-4362
Project: Lucene - Core
Issue Type: Task
Reporter: Robert Muir
Attachments: LUCENE-4362_core.patch
This makes code really difficult to read and work with.
Its easy enough to prevent.
{noformat}
Index: build.xml
===
--- build.xml (revision 1380979)
+++ build.xml (working copy)
@@ -77,11 +77,12 @@
or
containsregexp expression=@author\b casesensitive=yes/
containsregexp expression=\bno(n|)commit\b
casesensitive=no/
+ containsregexp expression=\t casesensitive=no/
/or
/fileset
map from=${validate.currDir}${file.separator} to=* /
/pathconvert
-fail if=validate.patternsFoundThe following files contain @author
tags or nocommits:${line.separator}${validate.patternsFound}/fail
+fail if=validate.patternsFoundThe following files contain @author
tags, tabs or nocommits:${line.separator}${validate.patternsFound}/fail
/target
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
--
lucidworks.com
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
@Uwe: Right, wasn't thinking, a fairly common happening.
Note that this is fairly ugly in that the simple-minded substitution
I did isn't totally right. You get diff lines like:
return new FloatDocValues(this) {
@Override
public float floatVal(int doc) {
- return func(doc, vals);
+ return func(doc, vals);
}
@Override
public String toString(int doc) {
- return name() + '(' + vals.toString(doc) + ')';
+ return name() + '(' + vals.toString(doc) + ')';
}
};
}
where the tab stops were other than 2 spaces. Unfortunately, I think the
alternative is to reformat all the files where this substitution was done
or go through by hand and do them all. And I'm really reluctant to volunteer
to fix over 8,000 of these by hand.
I'd _like_ to reformat all the files, but we all know the problems
there. I propose
that if nobody (or not enough people) object, I'll check them in with the
ugly indentation and the bad indents can be fixed when people are working
on the specific sections of code. At least it's progress.
Or if the consensus is to reformat the offending files I can do that. Tedious
but not that time-consuming.
Let me know...
On Wed, Sep 5, 2012 at 9:50 AM, Robert Muir rcm...@gmail.com wrote:
No it didnt. these classes do not exist in trunk.
On Wed, Sep 5, 2012 at 8:37 AM, Erick Erickson erickerick...@gmail.com
wrote:
Interestingly, this check missed the FrenchStemFilter.java (and I
don't know what others)
that found tabs by doing a quick search of the Lucene source tree.
Does the ant task
skip deprecated classes?
I like the check, I'll see about doing something about the tabs anyway,
that's
gruntwork after all...
On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) j...@apache.org wrote:
[
https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448621#comment-13448621
]
Uwe Schindler commented on LUCENE-4362:
---
Yeah, and with the ANT check, so it is enforced!
If somebody wants to use a tab, e.g. in a string, he can always do \t
ban tab-indented source
---
Key: LUCENE-4362
URL: https://issues.apache.org/jira/browse/LUCENE-4362
Project: Lucene - Core
Issue Type: Task
Reporter: Robert Muir
Attachments: LUCENE-4362_core.patch
This makes code really difficult to read and work with.
Its easy enough to prevent.
{noformat}
Index: build.xml
===
--- build.xml (revision 1380979)
+++ build.xml (working copy)
@@ -77,11 +77,12 @@
or
containsregexp expression=@author\b casesensitive=yes/
containsregexp expression=\bno(n|)commit\b
casesensitive=no/
+ containsregexp expression=\t casesensitive=no/
/or
/fileset
map from=${validate.currDir}${file.separator} to=* /
/pathconvert
-fail if=validate.patternsFoundThe following files contain @author
tags or nocommits:${line.separator}${validate.patternsFound}/fail
+fail if=validate.patternsFoundThe following files contain @author
tags, tabs or nocommits:${line.separator}${validate.patternsFound}/fail
/target
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
--
lucidworks.com
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson erickerick...@gmail.com wrote: @Uwe: Right, wasn't thinking, a fairly common happening. Note that this is fairly ugly in that the simple-minded substitution I did isn't totally right. You get diff lines like: I think the automatic 2-space replacement is fine for hopeless files. I updated the patch on LUCENE-4362 with fixes for files that aren't hopeless, just have a few stray tabs. If you want, just assign the issue, but maybe apply that patch before doing anything automatic? I was careful with those files (some had tables etc that should be aligned). -- lucidworks.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
I'll be happy to. I got the patches and applied them, but I can't assign the JIRA to myself. I can in Solr, but in Lucene I don't have the assign tab displayed. Who do I talk to? Erick On Wed, Sep 5, 2012 at 11:57 AM, Robert Muir rcm...@gmail.com wrote: On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson erickerick...@gmail.com wrote: @Uwe: Right, wasn't thinking, a fairly common happening. Note that this is fairly ugly in that the simple-minded substitution I did isn't totally right. You get diff lines like: I think the automatic 2-space replacement is fine for hopeless files. I updated the patch on LUCENE-4362 with fixes for files that aren't hopeless, just have a few stray tabs. If you want, just assign the issue, but maybe apply that patch before doing anything automatic? I was careful with those files (some had tables etc that should be aligned). -- lucidworks.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
RE: [jira] [Commented] (LUCENE-4362) ban tab-indented source
Hi Erick, I think I can add you to the appropriate group. Trying now. Steve -Original Message- From: Erick Erickson [mailto:erickerick...@gmail.com] Sent: Wednesday, September 05, 2012 12:56 PM To: dev@lucene.apache.org Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source I'll be happy to. I got the patches and applied them, but I can't assign the JIRA to myself. I can in Solr, but in Lucene I don't have the assign tab displayed. Who do I talk to? Erick On Wed, Sep 5, 2012 at 11:57 AM, Robert Muir rcm...@gmail.com wrote: On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson erickerick...@gmail.com wrote: @Uwe: Right, wasn't thinking, a fairly common happening. Note that this is fairly ugly in that the simple-minded substitution I did isn't totally right. You get diff lines like: I think the automatic 2-space replacement is fine for hopeless files. I updated the patch on LUCENE-4362 with fixes for files that aren't hopeless, just have a few stray tabs. If you want, just assign the issue, but maybe apply that patch before doing anything automatic? I was careful with those files (some had tables etc that should be aligned). -- lucidworks.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
I took care of it. THe problem was 2 Erick Ericksons. one was erick.erick...@gmail.com (that one had permissions), but that either isn't you, or was an old address. I put your new one in there and disabled access for the other one On Wed, Sep 5, 2012 at 12:59 PM, Steven A Rowe sar...@syr.edu wrote: Hi Erick, I think I can add you to the appropriate group. Trying now. Steve -Original Message- From: Erick Erickson [mailto:erickerick...@gmail.com] Sent: Wednesday, September 05, 2012 12:56 PM To: dev@lucene.apache.org Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source I'll be happy to. I got the patches and applied them, but I can't assign the JIRA to myself. I can in Solr, but in Lucene I don't have the assign tab displayed. Who do I talk to? Erick On Wed, Sep 5, 2012 at 11:57 AM, Robert Muir rcm...@gmail.com wrote: On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson erickerick...@gmail.com wrote: @Uwe: Right, wasn't thinking, a fairly common happening. Note that this is fairly ugly in that the simple-minded substitution I did isn't totally right. You get diff lines like: I think the automatic 2-space replacement is fine for hopeless files. I updated the patch on LUCENE-4362 with fixes for files that aren't hopeless, just have a few stray tabs. If you want, just assign the issue, but maybe apply that patch before doing anything automatic? I was careful with those files (some had tables etc that should be aligned). -- lucidworks.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org -- lucidworks.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
RE: [jira] [Commented] (LUCENE-4362) ban tab-indented source
I was wondering why Erick's name was already in the Administrators group... Thanks Robert. -Original Message- From: Robert Muir [mailto:rcm...@gmail.com] Sent: Wednesday, September 05, 2012 1:02 PM To: dev@lucene.apache.org Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source I took care of it. THe problem was 2 Erick Ericksons. one was erick.erick...@gmail.com (that one had permissions), but that either isn't you, or was an old address. I put your new one in there and disabled access for the other one On Wed, Sep 5, 2012 at 12:59 PM, Steven A Rowe sar...@syr.edu wrote: Hi Erick, I think I can add you to the appropriate group. Trying now. Steve -Original Message- From: Erick Erickson [mailto:erickerick...@gmail.com] Sent: Wednesday, September 05, 2012 12:56 PM To: dev@lucene.apache.org Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source I'll be happy to. I got the patches and applied them, but I can't assign the JIRA to myself. I can in Solr, but in Lucene I don't have the assign tab displayed. Who do I talk to? Erick On Wed, Sep 5, 2012 at 11:57 AM, Robert Muir rcm...@gmail.com wrote: On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson erickerick...@gmail.com wrote: @Uwe: Right, wasn't thinking, a fairly common happening. Note that this is fairly ugly in that the simple-minded substitution I did isn't totally right. You get diff lines like: I think the automatic 2-space replacement is fine for hopeless files. I updated the patch on LUCENE-4362 with fixes for files that aren't hopeless, just have a few stray tabs. If you want, just assign the issue, but maybe apply that patch before doing anything automatic? I was careful with those files (some had tables etc that should be aligned). -- lucidworks.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org -- lucidworks.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
RE: [jira] [Commented] (LUCENE-4362) ban tab-indented source
I added you also to Lucene! - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de -Original Message- From: Erick Erickson [mailto:erickerick...@gmail.com] Sent: Wednesday, September 05, 2012 6:56 PM To: dev@lucene.apache.org Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source I'll be happy to. I got the patches and applied them, but I can't assign the JIRA to myself. I can in Solr, but in Lucene I don't have the assign tab displayed. Who do I talk to? Erick On Wed, Sep 5, 2012 at 11:57 AM, Robert Muir rcm...@gmail.com wrote: On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson erickerick...@gmail.com wrote: @Uwe: Right, wasn't thinking, a fairly common happening. Note that this is fairly ugly in that the simple-minded substitution I did isn't totally right. You get diff lines like: I think the automatic 2-space replacement is fine for hopeless files. I updated the patch on LUCENE-4362 with fixes for files that aren't hopeless, just have a few stray tabs. If you want, just assign the issue, but maybe apply that patch before doing anything automatic? I was careful with those files (some had tables etc that should be aligned). -- lucidworks.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
RE: [jira] [Commented] (LUCENE-4362) ban tab-indented source
LOL: I added that one because this was the Solr one. Erick: Just to be sure: what is your account name and eMail address in JIRA? - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de -Original Message- From: Robert Muir [mailto:rcm...@gmail.com] Sent: Wednesday, September 05, 2012 7:02 PM To: dev@lucene.apache.org Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source I took care of it. THe problem was 2 Erick Ericksons. one was erick.erick...@gmail.com (that one had permissions), but that either isn't you, or was an old address. I put your new one in there and disabled access for the other one On Wed, Sep 5, 2012 at 12:59 PM, Steven A Rowe sar...@syr.edu wrote: Hi Erick, I think I can add you to the appropriate group. Trying now. Steve -Original Message- From: Erick Erickson [mailto:erickerick...@gmail.com] Sent: Wednesday, September 05, 2012 12:56 PM To: dev@lucene.apache.org Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source I'll be happy to. I got the patches and applied them, but I can't assign the JIRA to myself. I can in Solr, but in Lucene I don't have the assign tab displayed. Who do I talk to? Erick On Wed, Sep 5, 2012 at 11:57 AM, Robert Muir rcm...@gmail.com wrote: On Wed, Sep 5, 2012 at 11:04 AM, Erick Erickson erickerick...@gmail.com wrote: @Uwe: Right, wasn't thinking, a fairly common happening. Note that this is fairly ugly in that the simple-minded substitution I did isn't totally right. You get diff lines like: I think the automatic 2-space replacement is fine for hopeless files. I updated the patch on LUCENE-4362 with fixes for files that aren't hopeless, just have a few stray tabs. If you want, just assign the issue, but maybe apply that patch before doing anything automatic? I was careful with those files (some had tables etc that should be aligned). -- lucidworks.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org -- lucidworks.com - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source
erick.erick...@gmail.com (that one had permissions), but that either It's probably Erick's dark side alter ego: http://goo.gl/orGMC Dawid - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
