[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/153#discussion_r121260270
--- Diff:
surefire-integration-tests/src/test/resources/junit-plattform/src/test/java/junitplattform/BasicTest.java
---
@@ -0,0 +1,65 @@
+package junitplattform;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+public class BasicTest
+{
+
+private boolean setUpCalled = false;
--- End diff --
Default value `false` not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/153#discussion_r121256322
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -1399,12 +1400,22 @@ private static void checkThreadCountEntity( int
count, String entity )
private boolean isJunit47Compatible( Artifact artifact )
{
-return dependencyResolver.isWithinVersionSpec( artifact, "[4.7,)"
);
+return dependencyResolver.isWithinVersionSpec( artifact,
"[4.7,4.12.0)" );
}
private boolean isAnyJunit4( Artifact artifact )
{
-return dependencyResolver.isWithinVersionSpec( artifact, "[4.0,)"
);
+return dependencyResolver.isWithinVersionSpec( artifact,
"[4.0,4.12.0)" );
--- End diff --
Same here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/153#discussion_r121256320
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -1399,12 +1400,22 @@ private static void checkThreadCountEntity( int
count, String entity )
private boolean isJunit47Compatible( Artifact artifact )
{
-return dependencyResolver.isWithinVersionSpec( artifact, "[4.7,)"
);
+return dependencyResolver.isWithinVersionSpec( artifact,
"[4.7,4.12.0)" );
--- End diff --
JUnit 5 has another groupId so there is no reason to limit the version.
JUnit 5 is just another artifact.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #141: SUREFIRE-1331: Bump version number for 3.0.0 rele...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/141 @britter I think the version is not mandatory right now. I have to anyway replay each commit and squash in one on the top of future origin master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #141: SUREFIRE-1331: Bump version number for 3.0.0 rele...
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/141
No worries about the commit if it is messy.
I will pick up every single commit, make a patch and apply to master.
On Mon, Jun 5, 2017 at 10:30 AM, Benedikt Ritter <notificati...@github.com>
wrote:
> @Tibor17 <https://github.com/tibor17> this and #146
> <https://github.com/apache/maven-surefire/pull/146> a targeted at the
> 3.0-rc1 branch. So they won't interfere with the release of 2.20.1.
>
> Regarding junit5 support: it is currently pretty messy and I'm to blame
> for this. I'll write something together for the ML and will outline a plan
> on how to get things going again.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/maven-surefire/pull/141#issuecomment-306132862>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AA_yR4FOxkI-ACEA-ydfUaJ6q30D-a_6ks5sA7yTgaJpZM4L4H48>
> .
>
--
Cheers
Tibor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/146 @britter @mgreau Done. https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=70c8843e935882b0a78916894cb9f042964f2717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/146 @mgreau @britter Hey guys, let's utilize your power and complete `AbstractSurefireMojo` with `ProviderInfo`, some tests are still in progress. Meanwhile Apache Maven will complete 2.20.1. The reason is the stability of this plugin. It is more important to release 2.20.1. Maybe 2.20.1 would split again as it was with 2.20 and the release will get faster with faster user response. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #141: SUREFIRE-1331: Bump version number for 3.0.0 rele...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/141 @britter We have to finish 2.20.1 but we can finish the junit5 provider. Where did we finish last time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #152: [SUREFIRE-1378] Nice to have systemPropertiesFile...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/152 @michaldo Version 3.0 will have configurable via Java interface in pom.xml. This way you can turn the behavior to file system. Please check Jira [1] with version 3.0. Maybe we already have this request. [1]: https://issues.apache.org/jira/browse/SUREFIRE --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #151: Fixing build on Windows cmd.exe.
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/151 Thx for contributing. Pls close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #151: Fixing build on Windows cmd.exe.
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/151 @Tunaki Good catch. Would you create Jira ticket in https://issues.apache.org/jira/browse/SUREFIRE ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #149: Add a doctype to the StatelessXmlReporter output
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/149 DOCTYPE is old. Do you mean report XML e.g. `surefire-reports/TEST-MyTest.xml`? ``` http://www.w3.org/2001/XMLSchema-instance; xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd; name="MyTest" time="0.36" tests="8" errors="0" skipped="0" failures="0"> ``` It is a typical XML. Why should I use two types of metadata? Did Eclipse have any statement to this issue? The issues originated with error in Eclipse so I would expect them to do the best effort first. Would it be possible? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 IIYC you mean test-methods by "children". The classes and suites are under our control mean ParallelComputer only? Is it under Spock control as well? On Wed, May 10, 2017 at 6:40 AM, Fedor Bobin <notificati...@github.com> wrote: > Is that true that at least some runners still have some children since the > beginning when parallel computer (PC) has recognized them? > > In general case I can not garantee that. > > I cannot guarantee that these addons would run in parallel. > > JUnit's ParallelComputer sets scheduler to ParentRunner. Spock uses this > scheduler to run children. Everything should just work. > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/maven-surefire/pull/114#issuecomment-300371834>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA_yR079Y1Bk-3NkdWMgpkLDtNtWpvu9ks5r4T_AgaJpZM4JKVF6> > . > -- Cheers Tibor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 hm, I am not sure creating runners is possible and even if it is how this could work with us because we create JUnitCore instance and put PC in to if and intercept JUnit builder and handle all runners before runtime. If you say you create runners at runtime means that Junit must know it and PC would not. On Fri, May 5, 2017 at 12:54 PM, Fedor Bobin <notificati...@github.com> wrote: > Because Spock can't (do not want) generate runners at test object creation > time. Parametrized runners are generated at runtime and therefore not known > at init time. > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/maven-surefire/pull/114#issuecomment-299436059>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA_yRzpZrl4KiPigI_QNdcRzWES0k8_Qks5r2v_YgaJpZM4JKVF6> > . > -- Cheers Tibor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 @Fuud Makes sense. Why, what is the purpose in your f/w to schedule empty runner? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 There is one occasion when you set Filter to ParentRunner all children could be filtered out. On Fri, May 5, 2017 at 9:52 AM, Fedor Bobin <notificati...@github.com> wrote: > With pure JUnit it is not possible. > You can only place @Test <https://github.com/Test> annotation on method > => there will be at least one test in TestClass. > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/maven-surefire/pull/114#issuecomment-299403911>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA_yR-v0c-4AyptE9r__nA6gET6b0bdiks5r2tUtgaJpZM4JKVF6> > . > -- Cheers Tibor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 Question. Could it happen that a runner has no children, as e.g. JUnit's runner builder creates runners? It does not make sense to allocate a thread for empty runner because this is the waste of Threads and such Thread is allocated permanently for no reason. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
The release would not be that fast. Maybe next month. There is quite a lot
to do.
I need to find spare time to see if the changes in
ParallelComputerBuilder.java
<https://github.com/apache/maven-surefire/pull/114/commits/cde2d2df7f773f86f8b00220b2e350ea356b0ecd#diff-0e5423affd3755b8fd92f5f85886934a>
make logical sense and do not affect testing. If it is ok I will create a
Jira issue for this change from Fuud to have it documented in release notes.
So far we spent a lot of time on massive number of files changes and code
review. The code review is what we are stepping to right now.
I am facing two big tickets and some little which will improve stability of
the plugins.
On Thu, May 4, 2017 at 2:59 AM, Jezorko <notificati...@github.com> wrote:
> @Tibor17 <https://github.com/Tibor17> I see the current GIT version is
> 2.21-SNAPSHOT
>
<https://github.com/apache/maven-surefire/blob/b54e33e68e9c3e13f8fca4b66dbb5c89a0a30715/pom.xml#L32>,
> when a release is expected?
>
> Also a little off-topic, @Fuud <https://github.com/Fuud> is the code for
> your concurrent spock fork available anywhere? I cannot seem to find it.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/maven-surefire/pull/114#issuecomment-299075507>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AA_yR-8k8JAjzFIznh9yQZkY6VeDoitQks5r2SLigaJpZM4JKVF6>
> .
>
--
Cheers
Tibor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #147: Reporters use buffers to reduce number of I/O ope...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/147 I hope we will release 2.20.1 soon, EO April - BO May. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #147: Reporters use buffers to reduce number of I/O ope...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/147 @jerrinot Thx for contributing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #147: Reporters use buffers to reduce number of I/O ope...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/147 @jerrinot Pls close this PR. I created a branch https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=9c0025ed53d70c06279fef6c0fc30a54aeeab27b --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #147: Reporters use buffers to reduce number of I/O ope...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/147 I am just discussing with ASF colleagues rewriting `StatelessXmlReporter` to JAXB. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #147: Reporters use buffers to reduce number of ...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/147#discussion_r111644325
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
---
@@ -292,15 +293,15 @@ private FileOutputStream getOutputStream(
WrappedReportEntry testSetReportEntry
try
{
-return new FileOutputStream( reportFile );
+return new BufferedOutputStream( new FileOutputStream(
reportFile ), 16 * 1024 );
--- End diff --
I think we have problem.
`FileOutputStream outputStream = getOutputStream( testSetReportEntry );`
`OutputStreamWriter fw = getWriter( outputStream );`
Both variables are in use which is bad and the only one should be used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #147: Reporters use buffers to reduce number of ...
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/147#discussion_r111643377 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java --- @@ -91,7 +93,7 @@ public void writeTestOutput( byte[] buf, int off, int len, boolean stdout ) reportsDirectory.mkdirs(); } File file = getReportFile( reportsDirectory, reportEntryName, reportNameSuffix, "-output.txt" ); -fileOutputStream = new FileOutputStream( file ); +fileOutputStream = new BufferedOutputStream( new FileOutputStream( file ), 16 * 1024 ); --- End diff -- Sorry, I mean this in `FileReporter.java`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #147: Reporters use buffers to reduce number of ...
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/147#discussion_r111643120 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java --- @@ -91,7 +93,7 @@ public void writeTestOutput( byte[] buf, int off, int len, boolean stdout ) reportsDirectory.mkdirs(); } File file = getReportFile( reportsDirectory, reportEntryName, reportNameSuffix, "-output.txt" ); -fileOutputStream = new FileOutputStream( file ); +fileOutputStream = new BufferedOutputStream( new FileOutputStream( file ), 16 * 1024 ); --- End diff -- Can you please override (git amend) this commit and add Writer.close() in finally block? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/146 Not on the same version. It's not legal to introduce incomplete feature. The acceptable way would be to introduce junit5 in 3.0-alpha-1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/146 @mgreau The time has not yet come for 3.0 and junit5. We are in progress. Both branches are not mergable. I should cherry pick changes and fix a failing IT in 3.0-rc1. First of all we have to wait for the current Vote in mailing list until Version 2.20 is ready to go out. Then we will integrate support for Jigsaw Java 9 and fixes for blocker issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #145: Close reportSets tag
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/145 @flungo Thank You for the fix and let them coming more. Your fix has been merged to master. Please close this pull request. https://issues.apache.org/jira/browse/SUREFIRE-1355 https://github.com/apache/maven-surefire/commit/a1d224a8e75dcf64252d3374c9db43fc752082cd --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #143: maven-surefire-parser: add new method isEr...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/143#discussion_r108780826
--- Diff:
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java
---
@@ -196,7 +196,8 @@ else if ( "failure".equals( qName ) )
}
else if ( "error".equals( qName ) )
{
-testCase.setFailure( attributes.getValue( "message" ),
attributes.getValue( "type" ) );
+testCase.setFailure( attributes.getValue( "message" ),
attributes.getValue( "type" ) )
--- End diff --
If having an error, then failure and error are set both. Why?
See Line 235. Maybe you should introduce `setErrorDetail` similar to what
is `setFailureDetail`, and show the detail in HTML report and thus distinguish
between these two.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #143: maven-surefire-parser: add new method isEr...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/143#discussion_r108779823
--- Diff:
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java
---
@@ -156,6 +158,15 @@ public boolean hasFailure()
return hasFailure;
}
+public boolean isError() {
--- End diff --
You are not calling the getter in `SurefireReportGenerator`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #144: Resource leaks.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/144
But most of these changes are not related to communication between JVMs.
I spoke with Michael-O and we know the root cause. The problem is that the
JVM does not receive data via std/in in forked JVM. Therefore the forked
JVM is still waiting for class to test. It is not related to
System.out.close(); in ForkedBooter.
On Sun, Feb 26, 2017 at 6:14 PM, Stephen Connolly <notificati...@github.com>
wrote:
> *@stephenc* commented on this pull request.
> --
>
> In maven-surefire-common/src/main/java/org/apache/maven/
> plugin/surefire/report/ConsoleOutputFileReporter.java
> <https://github.com/apache/maven-surefire/pull/144#discussion_r103110391>:
>
> > @@ -69,8 +69,8 @@ public void close()
> {
> try
> {
> -fileOutputStream.flush();
> -fileOutputStream.close();
> +// fileOutputStream.flush(); Will not call close on
exception!
> +fileOutputStream.close(); // Will implicitly flush.
>
> Then the correct way to do that is wrap the flush in another layer of try
> catch (and leave a todo to use addSuppressed once baseline JVM for the
code
> is Java 7)
>
> â
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-surefire/pull/144#discussion_r103110391>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AA_yR4iQ5XcirBYLEhH3UZ9ue48U_3mnks5rgbMAgaJpZM4MFSQu>
> .
>
--
Cheers
Tibor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #144: Resource leaks.
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/144#discussion_r103107177
--- Diff:
surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
---
@@ -236,13 +236,17 @@ private static void exit( int returnCode, Shutdown
shutdownType, CommandReader r
switch ( shutdownType )
{
case KILL:
+System.out.close();
--- End diff --
The logs show me that `Process.exec()` is blocked with maybe read() method
in another Thread, and maybe a kind of deadlock which means using error stream
might be a good try.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #144: Resource leaks.
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/144#discussion_r103107040
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java
---
@@ -69,8 +69,8 @@ public void close()
{
try
{
-fileOutputStream.flush();
-fileOutputStream.close();
+// fileOutputStream.flush(); Will not call close on
exception!
+fileOutputStream.close(); // Will implicitly flush.
--- End diff --
Writer needs close() without flush() but FileOutputStream does not have
implicit flush while closing. Javadoc does not mention it. Implementation in
Oracle JDK is maybe different and probably flushes on close but that's this JVM
vendor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #144: Resource leaks.
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/144#discussion_r103106957
--- Diff:
surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
---
@@ -236,13 +236,17 @@ private static void exit( int returnCode, Shutdown
shutdownType, CommandReader r
switch ( shutdownType )
{
case KILL:
+System.out.close();
--- End diff --
@ChristianSchulte
This is executed right before JVM exit.
But our problem is in the beginning of life time of JVM.
This means the `InputStream.read()` and (`Process.waitFor()` or
`Process.exec()`) are mutual exclusive on FreeBSD according to logs.
It seems std/err will be tested instead of std/out.
Additionally ACK before shutdown needs to be added as StephenC mentioned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #144: Resource leaks.
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/144#discussion_r103106853
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
---
@@ -240,6 +240,10 @@ public void testSetCompleted( WrappedReportEntry
testSetReportEntry, TestSetStat
}
ppw.endElement(); // TestSuite
}
+catch ( final IOException e )
+{
+throw new ReporterException( "Failure generating XML report.",
e );
--- End diff --
@ChristianSchulte
Pls do not commit. I have stash with explanation.
Later. First of all is to test freebasd.
I have fixed testng system properties in a branch but have not commit it to
the branch. We will test it. But later in the evening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/142 @sbrannen It looks like we will rename 2.19.2 to 2.20.0, but this is not official yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/142 @britter @marcphilipp Done. We are preparing a new release version of Maven and Surefire was examined last days. We still investigate some issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/142 @britter Sure I will do it, no problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/142 @britter LGTM We have to wait for release 2.19.2. After that I will squash previous changes into one and commit to master which will be 3.0 RC1. Meanwhile we can continue on both branches, means this 3.0-rc1 and junit5 integration tests. I am pushed two other branches which were reverted before and one more is pending. So I am in progress as well and I hope the Maven colleagues would give me go-ahead and finalize release 2.19.2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/110 @jonenst you can have a look in this branch if you want to * [new branch]SUREFIRE-1322 -> apache/SUREFIRE-1322 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/110 @jonenst I am still recovering the plugin. I would like to invite you to make code review if you like. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/110 @jonenst I was about to finish the last one and suddenly we had internal collision and now we reverted 11 commits. I am going to fix them but the procedure will be that we have to create branch for each cherry pick, make code review and then merge with master. I don't want to blame anyone in ASF so I will rather work now and make you happy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 @Fuud We had an internal collision and I tried to recover from this and reverted 11 commits and now trying to fix them and add the last jira fix and then cut the release version. Please try to be patient. We want to continue on this project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #140: 退回2.19.1
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/140 Sorry but what you mean by this PR? On Wed, Jan 18, 2017 at 3:37 AM, xiaoguangma <notificati...@github.com> wrote: > éå2.19.1 > -- > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/maven-surefire/pull/140 > Commit Summary > >- éå2.19.1 > > File Changes > >- *A* README.TXT ><https://github.com/apache/maven-surefire/pull/140/files#diff-0> (11) >- *D* README.md ><https://github.com/apache/maven-surefire/pull/140/files#diff-1> (43) >- *M* maven-failsafe-plugin/pom.xml ><https://github.com/apache/maven-surefire/pull/140/files#diff-2> (91) >- *M* maven-failsafe-plugin/src/main/java/org/apache/maven/ >plugin/failsafe/IntegrationTestMojo.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-3> (120) >- *M* maven-failsafe-plugin/src/main/java/org/apache/maven/ >plugin/failsafe/VerifyMojo.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-4> (100) >- *D* maven-failsafe-plugin/src/main/java/org/apache/maven/ >plugin/failsafe/xmlsummary/ErrorType.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-5> (1) >- *D* maven-failsafe-plugin/src/main/java/org/apache/maven/ >plugin/failsafe/xmlsummary/FailsafeSummary.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-6> (1) >- *D* maven-failsafe-plugin/src/main/java/org/apache/maven/ >plugin/failsafe/xmlsummary/FailsafeSummaryXmlUtils.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-7> (1) >- *D* maven-failsafe-plugin/src/main/java/org/apache/maven/ >plugin/failsafe/xmlsummary/JAXB.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-8> (1) >- *D* maven-failsafe-plugin/src/main/java/org/apache/maven/ >plugin/failsafe/xmlsummary/ObjectFactory.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-9> (1) >- *D* maven-failsafe-plugin/src/test/java/org/apache/maven/ >plugin/failsafe/IntegrationTestMojoTest.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-10> (1) >- *D* maven-failsafe-plugin/src/test/java/org/apache/maven/ >plugin/failsafe/MarshallerUnmarshallerTest.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-11> (1) >- *D* maven-failsafe-plugin/src/test/java/org/apache/maven/ >plugin/failsafe/RunResultTest.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-12> (1) >- *D* maven-failsafe-plugin/src/test/resources/org/apache/ >maven/plugin/failsafe/failsafe-summary.xml ><https://github.com/apache/maven-surefire/pull/140/files#diff-13> (1) >- *M* maven-surefire-common/pom.xml ><https://github.com/apache/maven-surefire/pull/140/files#diff-14> (51) >- *M* maven-surefire-common/src/main/java/org/apache/maven/ >plugin/surefire/AbstractSurefireMojo.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-15> >(303) >- *M* maven-surefire-common/src/main/java/org/apache/maven/ >plugin/surefire/CommonReflector.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-16> (40) >- *M* maven-surefire-common/src/main/java/org/apache/maven/ >plugin/surefire/InPluginVMSurefireStarter.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-17> (41) >- *M* maven-surefire-common/src/main/java/org/apache/maven/ >plugin/surefire/StartupReportConfiguration.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-18> (84) >- *M* maven-surefire-common/src/main/java/org/apache/maven/ >plugin/surefire/SurefireDependencyResolver.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-19> (7) >- *M* maven-surefire-common/src/main/java/org/apache/maven/ >plugin/surefire/SurefireExecutionParameters.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-20> (4) >- *M* maven-surefire-common/src/main/java/org/apache/maven/ >plugin/surefire/SurefireHelper.java ><https://github.com/apache/maven-surefire/pull/140/files#diff-21> >(138) >- *M* maven-surefire-comm
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
I have this PR in my mind, do not worry. The problem is that we may cleanup
our codeline and I do not want to loose your path in master after we
revert. Pls wait few days.
On Sun, Jan 8, 2017 at 12:33 AM, Marcin ZajÄ
czkowski <
notificati...@github.com> wrote:
> @Tibor17 <https://github.com/Tibor17> Is there something else that
> prevent that PR from being merged?
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/maven-surefire/pull/114#issuecomment-271117788>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AA_yR6sSEkJR4g8Q_w-jFJyV_Guxut6Yks5rQCCygaJpZM4JKVF6>
> .
>
--
Cheers
Tibor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #139: [SUREFIRE-1324] Surefire incorrectly suppr...
Github user Tibor17 closed the pull request at: https://github.com/apache/maven-surefire/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #139: [SUREFIRE-1324] Surefire incorrectly suppresses e...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/139 @britter @ChristianSchulte If you have no objections to this I will push it to master. Thx. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #139: [SUREFIRE-1324] Surefire incorrectly suppr...
GitHub user Tibor17 opened a pull request: https://github.com/apache/maven-surefire/pull/139 [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Tibor17/maven-surefire SUREFIRE-1324 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/139.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #139 commit 2cf58708f6798f04d0314dce5df4c0ed5c2a09d3 Author: Tibor17 <tibo...@lycos.com> Date: 2017-01-07T02:55:07Z [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #137: Fix SUREFIRE-1239
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/137 @jsdima Thx for contributing. Pls close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #137: Fix SUREFIRE-1239
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/137 @jsdima Long time I was thinking about deleting the class `ThreadedStreamConsumer`. It looks like old mechanism where data was populated from multiple `ForkStarter`s but this is no longer valid. Each method `ForkStarter#fork()` L532 already uses single Thread started by `executeCommandLineAsCallable()`. It means that `ThreadedStreamConsumer` the plugin does not benefit from the pumper and the blocking queue. WDYT? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #137: Fix SUREFIRE-1239
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/137 @jsdima The constructor of `BlockingQueue` takes capacity of 2xE09 which practically means no limitation. The only operation which can block is `queue.take()`. What call sequences may cause that the `ForkClient` hangs? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #137: Fix SUREFIRE-1239
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/137 @jsdima I am interested in this problem because as you said the plugin hangs. Why the plugin hanged, do you have explanation? Did you run the build with your patch? It means `mvn -P run-its install`. The issue [1] you pointed out happens after your fix or without it? [1] `[ERROR] Failed to execute goal...` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #138: SUREFIRE-1309: Clarifying use of regular expressi...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/138 @sverhagen Thx for contributing. This PR was merged. Pls close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 @Fuud You mean this PR does not pass on Win or the master origin? Please see our Jenkins on Windows. It passed https://builds.apache.org/job/maven-surefire-windows --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/114#discussion_r91498487 --- Diff: surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilderTest.java --- @@ -32,15 +32,13 @@ import org.junit.runner.JUnitCore; import org.junit.runner.Result; import org.junit.runner.RunWith; +import org.junit.runner.notification.RunListener; +import org.junit.runner.notification.RunNotifier; +import org.junit.runners.ParentRunner; import org.junit.runners.Suite; +import org.junit.runners.model.InitializationError; -import java.util.ArrayList; --- End diff -- Pls do not use wildcard `import java.util.*;` and revert this section back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 @szpak @Fuud Pls post the test result `mvn install -P run-its`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/114#discussion_r91397951
--- Diff:
surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilder.java
---
@@ -428,10 +428,10 @@ private void determineThreadCounts( long suites, long
classes, long methods )
{
int children = countChildren( runner );
childrenCounter += children;
-if ( children != 0 )
-{
+//if ( children != 0 )
--- End diff --
Pls remove the comments in code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/110 @jonenst Next week on Friday it should be already in Maven Central. See the raod map [1]. We have last issue in good progress with 100% coverage of stream encoder and the only decoder is missing. I can push a new pull request to see the progress or commit directly. [1] https://issues.apache.org/jira/browse/SUREFIRE/?selectedTab=com.atlassian.jira.jira-projects-plugin:roadmap-panel --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/135 @britter I will push it to the branch junit5. Afterwards can you provide one more PR to merge junit5 branch from origin/master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #130: [SUREFIRE-1295] Attribute JVM crashes to tests
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/130 @michaeltandy Thx for contributing. I committed your sources and included you github name in the IT class. Please close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/135 @britter I think no user would like to specify `` in plugin in POM and he would not specify whether junit4 or junit5 as a duplicate to provider dependency. Basically all we need to have is a mapping between bunch of classes and specific provider. We can do it by lookup of `package-info.java` and some annotations in it which is quite fast, or another option would be to read tests bytecode as a text and search `"org/junit/Test"` which will be slow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/135 @britter It is not the right way to detect the presents of the JUnit annotations in classpath because the test classes may initialize static context yet in Maven process like we do right now which should be avoided in the future. The Maven and this plugin resolved dependencies. I think this is the way to go and we should detect the presents of JUnit artifacts and run the appropriate engine or provider. It already works like this with JUnit 4+ or 4.7+ and TestNG versions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #135: SUREFIRE-1307: Provide a convenient way to run te...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/135 @britter Yes, Let's use profiles for our testing purposes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #132: SUREFIRE-1306: JUnit4RerunFailingTestsIT does not...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/132 @britter Done. Thx. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #132: SUREFIRE-1306: JUnit4RerunFailingTestsIT does not...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/132 @britter I have fixed the issue but it is JUnit 4.7 issue. This is useless `.addGoal( "-Dprovider=surefire-junit4" )` and `.setJUnitVersion( "4.7" )` ditto because it's always the same in every test. WDYT? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #134: [SUREFIRE-1308] Move Surefire1179IT to jiras pack...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/134 @britter Done. Thx. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #136: [SUREFIRE-1295] Attribute JVM crashes to tests
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/136 @michaeltandy I will use your test but meanwhile I would like to avoid channelId used in ForckClient because channelId is obsolete and ForkClient is used per for/thread and therefore cannot use more than one channel. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #130: [SUREFIRE-1295] Attribute JVM crashes to tests
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/130 @michaeltandy I was inspired by your PR. Can you make a code review https://github.com/apache/maven-surefire/pull/136? I would like to run all IT tests and include yours. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #136: [SUREFIRE-1295] Attribute JVM crashes to t...
GitHub user Tibor17 opened a pull request:
https://github.com/apache/maven-surefire/pull/136
[SUREFIRE-1295] Attribute JVM crashes to tests
I have 4 tests ATest.java .. DTest.java, and CTest fails like this:
```
@Test
public void x() {
Runtime.getRuntime().halt( 0 );
}
```
Here is the result, see "Crashed tests".
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.19.2-SNAPSHOT:test
(default-test) on project b: Execution default-test of goal
org.apache.maven.plugins:maven-surefire-plugin:2.19.2-SNAPSHOT:test failed: The
forked VM terminated without properly saying goodbye. VM crash or System.exit
called?
[ERROR] Command was cmd.exe /X /C ""D:\Program
Files\Java\jdk1.8.0_112\jre\bin\java" -jar
D:\vcs\zmaz6\target\surefire\surefirebooter8109843199172464014.jar
D:\vcs\zmaz6\target\surefire\surefire4550764212193522341tmp
D:\vcs\zmaz6\target\surefire\surefire_07316673656092271862tmp"
[ERROR] Process Exit Code: 0
[ERROR] Crashed tests:
[ERROR] pkg.CTest
[ERROR] -> [Help 1]
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Tibor17/maven-surefire SUREFIRE-1295
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/136.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #136
commit 364b0c9e8ae56916f0b9aead2a26f07ed57befca
Author: Tibor17 <tibo...@lycos.com>
Date: 2016-11-28T22:16:20Z
[SUREFIRE-1295] Attribute JVM crashes to tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/110 @justinharringa Yes fixing the critical issues is never ending story. I will release 2.19.2 and 2.19.3 later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #133: SUREFIRE-1307: Provide a convenient way to run te...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/133 @britter >If this i going into the right direction, we can create a parent pom file with the profiles and adopt this to more of the existing tests. Activating Maven profiles in IT was my also my idea. We can go for it if you agree. In reality the user would use only one dependency and not the profiles. WDYT ? Do you think it may happen that some user would like to use both dependencies Jupiter and Vintage and so that the plugin would have to be configured in POM and filter dependencies? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #133: SUREFIRE-1307: Provide a convenient way to run te...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/133 @britter Here in GitHub are a lots of commits. Which one should I have a look? It seems you merged origin/master from junit5 branch to master again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #132: SUREFIRE-1306: JUnit4RerunFailingTestsIT does not...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/132 @britter The JUnit should be stable. Do you see in stacktrace why it fails with 4.7? Is it our problem or JUnit problem? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #112: Adding support for externally passed random seed ...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/112 @cardil `-DrunOrder=random:123456` I meant as well. The enums are only some model representation of real world but it does not mean that we cannot change it. What we should not do is adding a new parameter, especially if we could reuse existing parameter and altering it's behavior and extendig the format of param value. We have ambition in Surefire 3 to add parameters but in different way than this approach. Maybe you was too fast and spent time on this code instead of asking for visions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...
Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/94 @michael-o I will merge it no problem. The only problem on IT is my spare time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...
Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/94 @michael-o Any objections to merget this or do we need to test it with specific use case? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...
Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/94 @rpatrick00 LGTM I have tested the change on Win7 and Fedora23. I will merge your PR with master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #122: Specify surefire temp directory for run in multip...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/122 @vaimr I had to change more things. See this diff and close the issue. Thx for contributing. https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commitdiff;h=fb9b699e27dae905393a5bc4d5c6ae39606c3172 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #122: Specify surefire temp directory for run in multip...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/122 @vaimr Pls create Jira ticket [1] for this issue with the same title. [1] https://issues.apache.org/jira/browse/SUREFIRE --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #122: Specify surefire temp directory for run in multip...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/122 @vaimr I would prefer a single commit. You was too fast :) Are you able to squash the commits finally? Pls update the project and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #122: Specify surefire temp directory for run in...
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/122#discussion_r85649207 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java --- @@ -70,33 +54,25 @@ import org.apache.maven.shared.artifact.filter.PatternIncludesArtifactFilter; import org.apache.maven.shared.utils.StringUtils; import org.apache.maven.shared.utils.io.FileUtils; -import org.apache.maven.surefire.booter.ClassLoaderConfiguration; -import org.apache.maven.surefire.booter.Classpath; -import org.apache.maven.surefire.booter.ClasspathConfiguration; -import org.apache.maven.surefire.booter.KeyValueSource; -import org.apache.maven.surefire.booter.ProviderConfiguration; -import org.apache.maven.surefire.booter.ProviderParameterNames; +import org.apache.maven.surefire.booter.*; import org.apache.maven.surefire.booter.Shutdown; -import org.apache.maven.surefire.booter.StartupConfiguration; -import org.apache.maven.surefire.booter.SurefireBooterForkException; -import org.apache.maven.surefire.booter.SurefireExecutionException; import org.apache.maven.surefire.cli.CommandLineOption; import org.apache.maven.surefire.providerapi.SurefireProvider; -import org.apache.maven.plugin.surefire.log.api.ConsoleLogger; import org.apache.maven.surefire.report.ReporterConfiguration; import org.apache.maven.surefire.suite.RunResult; -import org.apache.maven.surefire.testset.DirectoryScannerParameters; -import org.apache.maven.surefire.testset.RunOrderParameters; -import org.apache.maven.surefire.testset.TestArtifactInfo; -import org.apache.maven.surefire.testset.TestListResolver; -import org.apache.maven.surefire.testset.TestRequest; -import org.apache.maven.surefire.testset.TestSetFailedException; +import org.apache.maven.surefire.testset.*; --- End diff -- Pls do not change the imports. Pls configure IDEA to not to use star (import org.apache.maven.surefire.testset.*;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #122: Specify surefire temp directory for run in...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/122#discussion_r85649125
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -2014,7 +2022,7 @@ private Artifact getSurefireBooterArtifact()
*/
private File getSurefireTempDir()
{
-return new File( getReportsDirectory().getParentFile(), "surefire"
);
+return new File( getReportsDirectory().getParentFile(),
getTempDir() );
--- End diff --
Pull the changes from origin/master. This line has changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #129: Merge master to junit5 branch
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/129 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #122: Specify surefire temp directory for run in multip...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/122 We have such feature in Surefire. It is called "runorder". Makes sense since the second run. On Thu, Oct 13, 2016 at 9:04 AM, Denis Saponenko <notificati...@github.com> wrote: > The problem is that no surefire stores information about the test > execution time. I build tests in Jenkins pipeline script. He balances the > tests by run-time, breaks it into several blocks and runs in parallel. This > significantly speeds up the test run time. > > https://jenkins.io/blog/2016/06/16/parallel-test-executor-plugin/ - not > quite correct setting example. But he describes the concept. > > â > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/maven-surefire/pull/122#issuecomment-253431047>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA_yR5fFrl4ycLXOCds304a1PmJHI_15ks5qzdfkgaJpZM4KCxjL> > . > -- Cheers Tibor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 @britter No big problem. Can you always run build locally? AFAIK your PC is running the build two hours. Normally 45 minutes in Jenkins and my PC Intel i7 4Core 3GHz SSD disk. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/126 @britter Finally please merge master to junit5 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #122: Specify surefire temp directory for run in multip...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/122 @vaimr How it could happen that several parallel Surefire plugins run in parallel within the same Maven module? Maven does not allow this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 I fixed this issue where I removed [1]. The reason behind is the `IsolatedClassLoader` in plugin process which did not have shaded `commons-lang3` in original jar file of `surefire-common`. Because of one method in `commons-lang3` we should not pass such a big library. Instead I created `ObjectUtils` which has only few method and most of them is already in Java 7 utility class `java.util.Objects`. In Surefire on the top of Java 7 I will delete them and use Java 7 facilities. [1] import static org.apache.commons.lang3.ObjectUtils.defaultIfNull; --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 @britter After using one integration tests only `org/apache/**/JUnit47ParallelIT.java` I got same errors as in Jenkins. I think the dependency `commons-lang3` is not propagated to the forked jvm. Maybe somewhere some scope but not in our code. If you run the test and go to `target/surefire` you will see a jar file. Download it and lookup `commons` in manifest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/127
Try to clone Surefire master and just run "mvn test"
Caused by: java.lang.NoClassDefFoundError:
org/apache/commons/lang3/ObjectUtils
at
org.apache.maven.plugin.surefire.report.DefaultReporterFactory.createFileReporter(DefaultReporterFactory.java:111)
at
org.apache.maven.plugin.surefire.report.DefaultReporterFactory.createReporter(DefaultReporterFactory.java:92)
at
org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:102)
On Wed, Oct 12, 2016 at 2:57 PM, Benedikt Ritter <notificati...@github.com>
wrote:
> @Tibor17 <https://github.com/Tibor17> I don't understand. mvn clean
> compile works. Why does this fail on Jenkins?
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/maven-surefire/pull/127#issuecomment-253205875>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AA_yR1I15EmeNcuXoehEwBCwAB3Al1vwks5qzNk6gaJpZM4KSBgs>
> .
>
--
Cheers
Tibor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 @britter It seems you forgot to add `ASF commons` dependency. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 @britter The build failed [1]. Did you run a local build on your side? [1] https://builds.apache.org/job/maven-surefire/1638/console --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 @britter Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #125: Consistently rename JUnit 4.x integration tests
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/125 @britter Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 After we are done with all commits, would you be able to safely squash them in one single commit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #127: [SUREFIRE-1293] Simplify org.apache.maven....
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/127#discussion_r82700832
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
---
@@ -76,7 +76,7 @@ public TestSetRunListener( ConsoleReporter
consoleReporter, FileReporter fileRep
StatisticsReporter statisticsReporter,
boolean trimStackTrace,
boolean isPlainFormat, boolean
briefOrPlainFormat )
{
-this.consoleReporter = consoleReporter;
+this.consoleReporter = consoleReporter != null ? consoleReporter :
new NullConsoleReporter();
--- End diff --
@britter
>>does this belong into DefaultReporterFactory.createReporter()
If you mean this code:
`ConsoleReporter consoleReporter = shouldReportToConsole() ? new
ConsoleReporter( consoleLogger ) : null;`
Then I would keep the responsibility of creating anew reporter yet in the
method `createReporter()`. I am going to fix a bug exactly in this part of code
after you. We can still improve the code by small incremental changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #127: [SUREFIRE-1293] Simplify org.apache.maven....
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/127#discussion_r82699845
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
---
@@ -76,7 +76,7 @@ public TestSetRunListener( ConsoleReporter
consoleReporter, FileReporter fileRep
StatisticsReporter statisticsReporter,
boolean trimStackTrace,
boolean isPlainFormat, boolean
briefOrPlainFormat )
{
-this.consoleReporter = consoleReporter;
+this.consoleReporter = consoleReporter != null ? consoleReporter :
new NullConsoleReporter();
--- End diff --
no no, I meant only the scope of this PR. Not whole Surefire of course.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #127: [SUREFIRE-1293] Simplify org.apache.maven....
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/127#discussion_r82699554
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullConsoleReporter.java
---
@@ -33,7 +33,10 @@
class NullConsoleReporter
extends ConsoleReporter
{
-NullConsoleReporter() {
+
+static final NullConsoleReporter INSTANCE = new NullConsoleReporter();
+
+private NullConsoleReporter() {
--- End diff --
here as well
pls run the build. it explores checkstyle erros.
Did you get your IntelliJ Idea now working with our Maven checkstyle?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #127: [SUREFIRE-1293] Simplify org.apache.maven....
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/127#discussion_r82699403
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/NullConsoleOutputReceiver.java
---
@@ -31,7 +31,13 @@
implements TestcycleConsoleOutputReceiver
{
-public void testSetStarting( ReportEntry reportEntry )
+static final NullConsoleOutputReceiver INSTANCE = new
NullConsoleOutputReceiver();
+
+private NullConsoleOutputReceiver()
+{
+}
+
+public void testSetStarting(ReportEntry reportEntry )
--- End diff --
here is checkstyle error
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/126 @britter The only problem is with workspace for the `Junit4VersionsIT` which is `/target/Junit4VersionsIT_testJunit` same for all parameters. Therefore we should not take the only single parameter for `unpack( "/junit4" );`. There should be used a suffix as the second parameter which segregates the workspaces by parameterized runner. You may fix it in a new PR. This would be helpful in order we want to download a zip of workspaces in Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
