[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983710755 > The choice for `script` was because in general we don't want binaries in the SCM. There's no real damage if the file is committed anyway. making script the default is not sufficient, because if .mvn/wrapper/maven-wrapper.jar or *.jar is not in .gitignore, the jar will inevitably come into future Git commit, not by the guy who did `mvn wrapper:wrapper`, by the user who will do `./mvnw` and commit everything without remarking that `wrapper.jar` was downloaded then forcing `mvn wrapper:wrapper` not to download `maven-wrapper.jar` just adds an additional friction (= `mvnw` needs to be able to download the jar, without the help of Maven settings) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-983699652 ok, code pushed in MWRPPER-14 branch in maven-studies https://github.com/apache/maven-studies/tree/MWRAPPER-14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980644191 thinking at default type more in depth, I think that I now understand the logic = making `script` the default is not sufficient, because if `.mvn/wrapper/maven-wrapper.jar` or `*.jar` is not in `.gitignore`, the jar will inevitably come into future Git commit then the logic is to have `bin` by default when installing maven-wrapper, and the `.gitignore` configuration will trigger if the jar is stored or not (and if not stored, the consequence in network access) thinking like this, I now feel that yes, `bin` should be default... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980641749 but for sure, there is the question: what should be the default? current `script`or `bin`? I kept the `script` default value that Robert chose previously, changing is easy, it's really just a choice to do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980639933 the issue you have is only with SNAPSHOTs or maven-wrapper, that are obvioulsy not published to central But with releases, there won't be any problem for normal users using default during development with SNAPSHOT maven-wrapper, see last section of https://maven.apache.org/wrapper-archives/wrapper-LATEST/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980543639 last try: - code = https://github.com/hboutemy/maven-wrapper = the initial wrapper donation with 4 commits to switch to Apache, replace provisio to assembly, add maven-wrapper-plugin and document - site: https://maven.apache.org/wrapper-archives/wrapper-LATEST/ This approach of wrapper does not need any releases when new Maven versions are released, and can work with any version from the past (like the original donation), and any SNAPSHOT Getting identical features of installed mvnw in a project Git vs downloaded Maven distribution will be part of MWRAPPER-16 = stop trying to re-implement mvn logic to launch a JVM and Maven core, but call mvn = the only solution to get consistency all, please review: in the end, I expect to create a maven-wrapper.git repository containing my initial work (that contains initial donation), and we'll track future features an release normally in MWRAPPER Jira -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974609919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974664732 wrong logic: not merging MWRAPPER-14 (and not releasing a usable wrapper) does not help on evolving with MWRAPPER-16 please think again: scripts released as part of Maven core do not work as a way to have consistency between wrapper scripts copied to project Git and scripts from downloaded maven distribution. It just helps a little bit their maintenance, at the cost of a confusion release cycle and limitation on possible target Maven version (future Maven 4 only) but at least, I can create MWRAPPER-16 branch to be merged to MWRAPPER-14: it's just sad to not be able to work in a constructive way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-974609919 ok, so no objection to merge this PR? please approve it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-962566868 I created https://issues.apache.org/jira/browse/MWRAPPER-16 to track this very good idea on `mvnw` launching `mvn` scripts: I hope we'll find a solution some day -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-952594433 oh, yes, sorry, please forget my previous comment: morning coffe took more time than I expected to warm up my brain :) Yes, having `mvnw` script (stored in source control) call downloaded `mvn` from the Maven distribution is the only solution to be sure that exact features are available to implement it, we'll need to have `mvnw`script know where the Maven distribution has been unpacked (by `maven-wrapper.jar`): any idea how to do that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-952568787 yes, instead of copying by hand partial scripts from https://github.com/apache/maven/tree/master/apache-maven/src/assembly/shared to current project source https://github.com/apache/maven-wrapper-plugin/tree/MWRAPPER-14/maven-wrapper-distribution/src/assembly/maven , it can be automated => I'll add this soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951301704 I completely value the work done to sync mvn and mvnw: syncing is just about copying the 6 partial scripts. on releasing, there is only 1 simultaneous release for the 3 artifacts: wrapper, wrapper distribution and wrapper-plugin = the full wrapper, clearly separate from the Maven distribution. It is really simple and logical. with the latest commits, the new wrapper is working well with whatever Maven version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
