Re: [DISCUSS] Add ngrx to handle state management in Angular

[James Sirota]

I found a helpful article here:
https://brianflove.com/2018/01/08/ngrx-the-basics/

A lot of this goes over my head, but in a nutshell, it's a tree-based state 
management object for JS.  Its main drawback seems to be added complexity, but 
if the guys who are more familiar with UI say we would benefit from it I am 
inclined to take them at their word. 

26.11.2018, 13:09, "Michael Miklavcic" :
> Shane, thanks for sharing this. Can you perhaps describe a sample use case
> in the UI currently and explain for us how it currently works (or doesn't,
> ha) versus how it would be modified and improved with using NgRx?
>
> Thanks,
> Mike
>
> On Fri, Nov 23, 2018 at 7:44 AM Shane Ardell 
> wrote:
>
>>  What I'm referring to is roughly the entire contents of the UI
>>  application's memory.
>>
>>  On Thu, Nov 22, 2018 at 6:29 PM Otto Fowler 
>>  wrote:
>>
>>  > Can you describe what you mean by “state” in a little more detail? Not a
>>  > complete description, maybe just a crib list.
>>  >
>>  >
>>  > On November 22, 2018 at 07:21:43, Shane Ardell (shane.m.ard...@gmail.com
>>  )
>>  > wrote:
>>  >
>>  > As both the Management and Alerts UI grow in size, managing application
>>  > state continues to become more and more complex. To help us deal with
>>  > managing all of this state and ensuring our application derives state
>>  from
>>  > a single source of truth, I suggest we start using NgRx, a state
>>  > management
>>  > library based on the Redux pattern but built for Angular. It is by far
>>  the
>>  > most popular library of this type for Angular. As you can see in the
>>  > project's GitHub Insights tab ,
>>  > it's quite actively worked on and releases are pretty frequent. The
>>  > project
>>  > is licensed under MIT.
>>  >
>>  > As far as an approach to integration, I don't think we necessarily need a
>>  > big refactoring right off the bat. I feel something like this can be done
>>  > in a piecemeal approach over time. I think we can start by introducing it
>>  > into the project the next time we have a new application feature.
>>  >
>>  > What are everyone's thoughts around this?
>>  >
>>  > Cheers,
>>  > Shane
>>  >
>>  >

--- 
Thank you,

James Sirota
PMC- Apache Metron
jsirota AT apache DOT org

Re: [DISCUSS] Add ngrx to handle state management in Angular

[Michael Miklavcic]

Shane, thanks for sharing this. Can you perhaps describe a sample use case
in the UI currently and explain for us how it currently works (or doesn't,
ha) versus how it would be modified and improved with using NgRx?

Thanks,
Mike

On Fri, Nov 23, 2018 at 7:44 AM Shane Ardell 
wrote:

> What I'm referring to is roughly the entire contents of the UI
> application's memory.
>
> On Thu, Nov 22, 2018 at 6:29 PM Otto Fowler 
> wrote:
>
> > Can you describe what you mean by “state” in a little more detail?  Not a
> > complete description, maybe just a crib list.
> >
> >
> > On November 22, 2018 at 07:21:43, Shane Ardell (shane.m.ard...@gmail.com
> )
> > wrote:
> >
> > As both the Management and Alerts UI grow in size, managing application
> > state continues to become more and more complex. To help us deal with
> > managing all of this state and ensuring our application derives state
> from
> > a single source of truth, I suggest we start using NgRx, a state
> > management
> > library based on the Redux pattern but built for Angular. It is by far
> the
> > most popular library of this type for Angular. As you can see in the
> > project's GitHub Insights tab ,
> > it's quite actively worked on and releases are pretty frequent. The
> > project
> > is licensed under MIT.
> >
> > As far as an approach to integration, I don't think we necessarily need a
> > big refactoring right off the bat. I feel something like this can be done
> > in a piecemeal approach over time. I think we can start by introducing it
> > into the project the next time we have a new application feature.
> >
> > What are everyone's thoughts around this?
> >
> > Cheers,
> > Shane
> >
> >
>

Re: [DISCUSS] Add ngrx to handle state management in Angular

[Michael Miklavcic]

Just an fyi for newer members of the dev community - we are very open to
and appreciative of all community involvement and feedback - for
non-committers, as a general rule please make a small note next to any
votes (-1's, +1's, etc.) indicating "(non-binding)".

On Mon, Nov 26, 2018 at 7:04 AM Tamás Fodor  wrote:

> That is a great idea!
>
> +1
>
> On Mon, Nov 26, 2018 at 10:19 AM Tibor Meller 
> wrote:
>
> > Shane, Thanks for gathering the information and raising this.
> > I also feel that our UIs reached a level of complexity what makes this
> to a
> > reasonable next step.
> > This complexity on the client side will grow in the future and I believe
> it
> > is better to prepare instead of trying to make huge refactorings later.
> > NgRx/Redux is quiet the industry standard architectural library in both
> > React and Angular realm. Pretty well known in the community.
> > I would be happy to move forward with NgRx.
> >
> > On Fri, Nov 23, 2018 at 3:44 PM Shane Ardell 
> > wrote:
> >
> > > What I'm referring to is roughly the entire contents of the UI
> > > application's memory.
> > >
> > > On Thu, Nov 22, 2018 at 6:29 PM Otto Fowler 
> > > wrote:
> > >
> > > > Can you describe what you mean by “state” in a little more detail?
> > Not a
> > > > complete description, maybe just a crib list.
> > > >
> > > >
> > > > On November 22, 2018 at 07:21:43, Shane Ardell (
> > shane.m.ard...@gmail.com
> > > )
> > > > wrote:
> > > >
> > > > As both the Management and Alerts UI grow in size, managing
> application
> > > > state continues to become more and more complex. To help us deal with
> > > > managing all of this state and ensuring our application derives state
> > > from
> > > > a single source of truth, I suggest we start using NgRx, a state
> > > > management
> > > > library based on the Redux pattern but built for Angular. It is by
> far
> > > the
> > > > most popular library of this type for Angular. As you can see in the
> > > > project's GitHub Insights tab <
> https://github.com/ngrx/platform/pulse
> > >,
> > > > it's quite actively worked on and releases are pretty frequent. The
> > > > project
> > > > is licensed under MIT.
> > > >
> > > > As far as an approach to integration, I don't think we necessarily
> > need a
> > > > big refactoring right off the bat. I feel something like this can be
> > done
> > > > in a piecemeal approach over time. I think we can start by
> introducing
> > it
> > > > into the project the next time we have a new application feature.
> > > >
> > > > What are everyone's thoughts around this?
> > > >
> > > > Cheers,
> > > > Shane
> > > >
> > > >
> > >
> >
>

Re: Unzipping Cypress

[Shane Ardell]

It seems we can pretty easily configure the .travis.yml config file to
cache our npm modules:
https://docs.cypress.io/guides/guides/continuous-integration.html#Caching-the-Cypress-binary

It also looks like we are already trying to cache our npm modules in the
Travis config, but, obviously, it's not working as intended. I can take a
look into why tomorrow.

On Mon, Nov 26, 2018 at 5:33 PM Michael Miklavcic <
michael.miklav...@gmail.com> wrote:

> Shane, Tibor - Can you guys chime in on this?
>
> On Mon, Nov 26, 2018 at 9:13 AM Otto Fowler 
> wrote:
>
> > Isn’t there a way we can cache it?
> >
> >
> > On November 26, 2018 at 10:59:20, Nick Allen (n...@nickallen.org) wrote:
> >
> > Yes, I have noticed that too. If not a way to reduce the time, we should
> > not be logging the unzipping process percentile-by-percentile in the
> Travis
> > CI builds.
> >
> > On Sat, Nov 24, 2018 at 9:49 AM Otto Fowler 
> > wrote:
> >
> > > Anyone else seeing a lot of time taken downloading and unzipping
> Cypress
> > on
> > > builds?
> > > What is up with that?™
> > >
> > > ottO
> > >
> >
>

Re: Unzipping Cypress

[Michael Miklavcic]

Shane, Tibor - Can you guys chime in on this?

On Mon, Nov 26, 2018 at 9:13 AM Otto Fowler  wrote:

> Isn’t there a way we can cache it?
>
>
> On November 26, 2018 at 10:59:20, Nick Allen (n...@nickallen.org) wrote:
>
> Yes, I have noticed that too. If not a way to reduce the time, we should
> not be logging the unzipping process percentile-by-percentile in the Travis
> CI builds.
>
> On Sat, Nov 24, 2018 at 9:49 AM Otto Fowler 
> wrote:
>
> > Anyone else seeing a lot of time taken downloading and unzipping Cypress
> on
> > builds?
> > What is up with that?™
> >
> > ottO
> >
>

Re: Unzipping Cypress

[Otto Fowler]

Isn’t there a way we can cache it?


On November 26, 2018 at 10:59:20, Nick Allen (n...@nickallen.org) wrote:

Yes, I have noticed that too. If not a way to reduce the time, we should
not be logging the unzipping process percentile-by-percentile in the Travis
CI builds.

On Sat, Nov 24, 2018 at 9:49 AM Otto Fowler 
wrote:

> Anyone else seeing a lot of time taken downloading and unzipping Cypress
on
> builds?
> What is up with that?™
>
> ottO
>

Re: Unzipping Cypress

[Nick Allen]

Yes, I have noticed that too.  If not a way to reduce the time, we should
not be logging the unzipping process percentile-by-percentile in the Travis
CI builds.

On Sat, Nov 24, 2018 at 9:49 AM Otto Fowler  wrote:

> Anyone else seeing a lot of time taken downloading and unzipping Cypress on
> builds?
> What is up with that?™
>
> ottO
>

Re: [DISCUSS] Add ngrx to handle state management in Angular

[Tamás Fodor]

That is a great idea!

+1

On Mon, Nov 26, 2018 at 10:19 AM Tibor Meller 
wrote:

> Shane, Thanks for gathering the information and raising this.
> I also feel that our UIs reached a level of complexity what makes this to a
> reasonable next step.
> This complexity on the client side will grow in the future and I believe it
> is better to prepare instead of trying to make huge refactorings later.
> NgRx/Redux is quiet the industry standard architectural library in both
> React and Angular realm. Pretty well known in the community.
> I would be happy to move forward with NgRx.
>
> On Fri, Nov 23, 2018 at 3:44 PM Shane Ardell 
> wrote:
>
> > What I'm referring to is roughly the entire contents of the UI
> > application's memory.
> >
> > On Thu, Nov 22, 2018 at 6:29 PM Otto Fowler 
> > wrote:
> >
> > > Can you describe what you mean by “state” in a little more detail?
> Not a
> > > complete description, maybe just a crib list.
> > >
> > >
> > > On November 22, 2018 at 07:21:43, Shane Ardell (
> shane.m.ard...@gmail.com
> > )
> > > wrote:
> > >
> > > As both the Management and Alerts UI grow in size, managing application
> > > state continues to become more and more complex. To help us deal with
> > > managing all of this state and ensuring our application derives state
> > from
> > > a single source of truth, I suggest we start using NgRx, a state
> > > management
> > > library based on the Redux pattern but built for Angular. It is by far
> > the
> > > most popular library of this type for Angular. As you can see in the
> > > project's GitHub Insights tab  >,
> > > it's quite actively worked on and releases are pretty frequent. The
> > > project
> > > is licensed under MIT.
> > >
> > > As far as an approach to integration, I don't think we necessarily
> need a
> > > big refactoring right off the bat. I feel something like this can be
> done
> > > in a piecemeal approach over time. I think we can start by introducing
> it
> > > into the project the next time we have a new application feature.
> > >
> > > What are everyone's thoughts around this?
> > >
> > > Cheers,
> > > Shane
> > >
> > >
> >
>

Re: [DISCUSS] Add ngrx to handle state management in Angular

[Tibor Meller]

Shane, Thanks for gathering the information and raising this.
I also feel that our UIs reached a level of complexity what makes this to a
reasonable next step.
This complexity on the client side will grow in the future and I believe it
is better to prepare instead of trying to make huge refactorings later.
NgRx/Redux is quiet the industry standard architectural library in both
React and Angular realm. Pretty well known in the community.
I would be happy to move forward with NgRx.

On Fri, Nov 23, 2018 at 3:44 PM Shane Ardell 
wrote:

> What I'm referring to is roughly the entire contents of the UI
> application's memory.
>
> On Thu, Nov 22, 2018 at 6:29 PM Otto Fowler 
> wrote:
>
> > Can you describe what you mean by “state” in a little more detail?  Not a
> > complete description, maybe just a crib list.
> >
> >
> > On November 22, 2018 at 07:21:43, Shane Ardell (shane.m.ard...@gmail.com
> )
> > wrote:
> >
> > As both the Management and Alerts UI grow in size, managing application
> > state continues to become more and more complex. To help us deal with
> > managing all of this state and ensuring our application derives state
> from
> > a single source of truth, I suggest we start using NgRx, a state
> > management
> > library based on the Redux pattern but built for Angular. It is by far
> the
> > most popular library of this type for Angular. As you can see in the
> > project's GitHub Insights tab ,
> > it's quite actively worked on and releases are pretty frequent. The
> > project
> > is licensed under MIT.
> >
> > As far as an approach to integration, I don't think we necessarily need a
> > big refactoring right off the bat. I feel something like this can be done
> > in a piecemeal approach over time. I think we can start by introducing it
> > into the project the next time we have a new application feature.
> >
> > What are everyone's thoughts around this?
> >
> > Cheers,
> > Shane
> >
> >
>