date:20160615


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7357:

Description: We can start preparing demo data for implementation and 
testing purpose based on requirement and design details shared over OFBIZ-7355 
& OFBIZ-7356

> OFBIZ-6964: Prepare Demo Data based on the propsed design to support 
> replenishment planning through any inter-company facility
> --
>
> Key: OFBIZ-7357
> URL: https://issues.apache.org/jira/browse/OFBIZ-7357
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Fix For: Upcoming Branch
>
>
> We can start preparing demo data for implementation and testing purpose based 
> on requirement and design details shared over OFBIZ-7355 & OFBIZ-7356



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7357) OFBIZ-6964: Prepare Demo Data based on the propsed design to support replenishment planning through any inter-company facility


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7357:
---

Assignee: Divesh Dutta

> OFBIZ-6964: Prepare Demo Data based on the propsed design to support 
> replenishment planning through any inter-company facility
> --
>
> Key: OFBIZ-7357
> URL: https://issues.apache.org/jira/browse/OFBIZ-7357
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7357) OFBIZ-6964: Prepare Demo Data based on the propsed design to support replenishment planning through any inter-company facility

Swapnil Shah created OFBIZ-7357:
---

 Summary: OFBIZ-6964: Prepare Demo Data based on the propsed design 
to support replenishment planning through any inter-company facility
 Key: OFBIZ-7357
 URL: https://issues.apache.org/jira/browse/OFBIZ-7357
 Project: OFBiz
  Issue Type: Sub-task
  Components: manufacturing, order, product
Affects Versions: 15.12.01
Reporter: Swapnil Shah






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7356) OFBIZ-6964: Document finalized design to support replenishment planning through any inter-company facility


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah closed OFBIZ-7356.
---
   Resolution: Fixed
Fix Version/s: (was: 15.12.01)

Shared the high level design proposal based on requirements specified under 
OFBIZ-7355

> OFBIZ-6964: Document finalized design to support replenishment planning 
> through any inter-company facility
> --
>
> Key: OFBIZ-7356
> URL: https://issues.apache.org/jira/browse/OFBIZ-7356
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>
> Here are high level design notes to based on the requirement specified under 
> OFBIZ-7355 to support the product level replenishment from any inter-company 
> facility before raising the ordering from an outside vendor.
> * We could extend the MRP logic (MrpEvent,Requirenent) to honor these new 
> types and create corresponding event & requirement for Stock transfer between 
> facilities.
> * Introduce two new entities ProductFacilityAssoc & FacilityAssocType and use 
> them in conjunction with MrpEventType and corresponding RequirementType to 
> serve the requirement for replenishing the store's via Inter-facility 
> transfers mode.  The data model & UI could be extended as follows:
> {code}
> 
>  title="Define associations between Product facilities">
> 
> 
> 
> 
> 
> 
>  
> 
> 
> 
> 
> 
> 
> 
> 
>  rel-entity-name="Facility">
> 
> 
>  rel-entity-name="Facility">
> 
> 
>  rel-entity-name="FacilityAssocType">
> 
> 
> 
> 
>  title="Define associations between facilities">
> 
> 
>  
> 
> 
>  
> 
> 
>  
> 
> 
>  description="Facility that serves another facility in terms of inventory"/>
> 
>  facilityIdTo="StoreWarehouse_01" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="01" fromDate="2001-01-01 12:00:00"/>
>  facilityIdTo="StoreWarehouse_01" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="02" fromDate="2001-01-01 12:00:00"/>
>  facilityIdTo="StoreWarehouse_01" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="03" fromDate="2001-01-01 12:00:00"/>
>  facilityIdTo="RegionalWarehouse_01" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="01" fromDate="2001-01-01 12:00:00"/>
>  facilityIdTo="RegionalWarehouse_02" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="01" fromDate="2001-01-01 12:00:00"/>
> 
> 
> 
> 
>  requirementTypeId="TRANSFER_REQUIREMENT"/>
> 
>  enumTypeId="PROD_REQ_METHOD"/>
> 
>  checkInventory="N" oneInventoryFacility="N" requireInventory="N" 
> reserveInventory="Y" reserveOrderEnumId="INVRO_FIFO_REC" /> 
> 
>  requirementMethodEnumId="XFERRQM_STOCK_ATP" fromDate="2001-04-13 12:00:00"/>
> 
>  lastInventoryCount="20.00" minimumStock="100.00" productId="GZ-8544"/>
>  lastInventoryCount="40.00" minimumStock="200.00" productId="GZ-8544"/>
>  lastInventoryCount="60.00" minimumStock="200.00" productId="GZ-8544"/>
>  lastInventoryCount="200.00" minimumStock="300.00" 
> productId="GZ-8544"/>
> {code}
> MRP engine would start creating event beginning with store's primary facility 
> based on set RMEI under ProductStoreFacility e.g, XFERRQM_STOCK_ATP for 
> StoreWarehouse_01, In other words if MinStock < ATP , then MRP algorithm 
> would: 
> # Look up and consume the respective ATP from all the eligible "facilityIdTo" 
> (based on ProductFacilityAssoc), from where given product is transferable. 
> Based on their priorities start allocating ATP unless it meet the 
> (MinStock-ATP) requirement for a given store e.g., 'StoreWarehouse_01' .
> # Create new MRP Event with Event type "PROP_ATP_STOCK_TRANSFER" with 
> Proposed Quantity = MINIMUM STOCK - ATP from the facility (with highest 
> priority i.e.,RegionalWarehouse_01) to the destination facility.
> ## If demand for (MinStock-ATP) is still not fully met by any facility with 
> higher priority then repeat step#1 for all the associated facilities in 
> descending order of priority unless ATP from all eligible facilities is 
> exhausted.
> # Based on above MRP Event Type and proposed quantity, In turn create the new 
> Requirement with type TRANSFER_REQUIREMENT between originating and 
> destination facility.
> # Over Requirement screen (UI) we can provide the "Transfer" button against 
> all the requirement with type TRANSFER_REQUIREMENT
> # On hitting the "Transfer" button, The new 'Stock Transfer' requests could 
> be created for a product between eligible facilities based on above step. 
> # The created Stock Transfer request can be completed by shipping and 
> receiving given product from originating facility and destination facility 
> respectively.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7356) OFBIZ-6964: Document finalized design to support replenishment planning through any inter-company facility


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7356:

Description: 
Here are high level design notes to based on the requirement specified under 
OFBIZ-7355 to support the product level replenishment from any inter-company 
facility before raising the ordering from an outside vendor.

* We could extend the MRP logic (MrpEvent,Requirenent) to honor these new types 
and create corresponding event & requirement for Stock transfer between 
facilities.
* Introduce two new entities ProductFacilityAssoc & FacilityAssocType and use 
them in conjunction with MrpEventType and corresponding RequirementType to 
serve the requirement for replenishing the store's via Inter-facility transfers 
mode.  The data model & UI could be extended as follows:

{code}








 
























 































 









{code}

MRP engine would start creating event beginning with store's primary facility 
based on set RMEI under ProductStoreFacility e.g, XFERRQM_STOCK_ATP for 
StoreWarehouse_01, In other words if MinStock < ATP , then MRP algorithm would: 
# Look up and consume the respective ATP from all the eligible "facilityIdTo" 
(based on ProductFacilityAssoc), from where given product is transferable. 
Based on their priorities start allocating ATP unless it meet the 
(MinStock-ATP) requirement for a given store e.g., 'StoreWarehouse_01' .
# Create new MRP Event with Event type "PROP_ATP_STOCK_TRANSFER" with Proposed 
Quantity = MINIMUM STOCK - ATP from the facility (with highest priority 
i.e.,RegionalWarehouse_01) to the destination facility.
## If demand for (MinStock-ATP) is still not fully met by any facility with 
higher priority then repeat step#1 for all the associated facilities in 
descending order of priority unless ATP from all eligible facilities is 
exhausted.
# Based on above MRP Event Type and proposed quantity, In turn create the new 
Requirement with type TRANSFER_REQUIREMENT between originating and destination 
facility.
# Over Requirement screen (UI) we can provide the "Transfer" button against all 
the requirement with type TRANSFER_REQUIREMENT
# On hitting the "Transfer" button, The new 'Stock Transfer' requests could be 
created for a product between eligible facilities based on above step. 
# The created Stock Transfer request can be completed by shipping and receiving 
given product from originating facility and destination facility respectively.


  was:Let's use this ticket to post the concluded design notes to support the 
product level replenishment from any inter-company facility before raising the 
ordering from an outside vendor.


> OFBIZ-6964: Document finalized design to support replenishment planning 
> through any inter-company facility
> --
>
> Key: OFBIZ-7356
> URL: https://issues.apache.org/jira/browse/OFBIZ-7356
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: 15.12.01
>
>
> Here are high level design notes to based on the requirement specified under 
> OFBIZ-7355 to support the product level replenishment from any inter-company 
> facility before raising the ordering from an outside vendor.
> * We could extend the MRP logic (MrpEvent,Requirenent) to honor these new 
> types and create corresponding event & requirement for Stock transfer between 
> facilities.
> * Introduce two new entities ProductFacilityAssoc & FacilityAssocType and use 
> them in conjunction with MrpEventType and corresponding RequirementType to 
> serve the requirement for replenishing the store's via Inter-facility 
> transfers mode.  The data model & UI could be extended as follows:
> {code}
> 
>  title="Define associations between Product facilities">
> 
> 
> 
> 
> 
> 
>  
> 
> 
> 
> 
> 
> 
> 
> 
>  rel-entity-name="Facility">
> 
> 
>  rel-entity-name="Facility">
> 
> 
>  rel-entity-name="FacilityAssocType">
> 
> 
> 
> 
>  title="Define associations between facilities">
> 
> 
>  
> 
> 
>  
> 
> 
>  
> 
> 
>  description="Facility that serves another facility in terms of inventory"/>
> 
>  facilityIdTo="StoreWarehouse_01" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="01" fromDate="2001-01-01 12:00:00"/>
>  facilityIdTo="StoreWarehouse_01" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="02" fromDate="2001-01-01 12:00:00"/>
>  facilityIdTo="StoreWarehouse_01" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="03" fromDate="2001-01-01 12:00:00"/>
>  facilityIdTo="RegionalWarehouse_01" facilityAssocTypeId="BACKUP_WAREHOUSE" 
> sequenceNum="01" fromDate="2001-01-01 12:00:00"/>
>  facilityIdTo="RegionalWarehouse_02"

[jira] [Closed] (OFBIZ-7355) OFBIZ-6964: Document finalized business requirements to support replenishment planning through any inter-company facility


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah closed OFBIZ-7355.
---
   Resolution: Fixed
Fix Version/s: (was: Upcoming Branch)

Shared the business requirement to proceed on design and implementation

> OFBIZ-6964: Document finalized business requirements to support replenishment 
> planning through any inter-company facility
> -
>
> Key: OFBIZ-7355
> URL: https://issues.apache.org/jira/browse/OFBIZ-7355
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Attachments: screenshot-1.png
>
>
> Here are the most common set of business requirement to support product level 
> replenishment within a given facility(store/warehouse) via any inter-company 
> facility (preferred warehouse/stocking facility) before raising the purchase 
> order from an outside vendors/suppliers.
> In current standard OFbiz workflow there are essentially two basic types of 
> material requirements generated at product-facility level. Both of these can 
> be created manually or could be suggested by MRP engine:
> * First, is "Product Requirement" which suggests that the given product is 
> going to be low or out of stock within any given facility in a given time 
> frame based on upstream demand signals within the supply chain and hence can 
> more commonly be treated as Purchase Requirement that need to be eventually 
> transformed as Purchase Orders to be raised from a given vendor/supplier
> * Second, is "Internal Requirement" which suggests that the given product is 
> going to be low or out of stock within any given facility in a given time 
> frame based on upstream demand within the supply chain. But such products can 
> be internally manufactured(produced) and hence can more commonly be treated 
> as Production Requirement that need to be eventually transformed as 
> Production Order (Production Run).
> *Gap*
> Currently the OFbiz planning algorithm (aka MRP) generate the requirement by 
> only considering the supply available within the given facility. But there is 
> no planning logic built into the system which can support and look up the 
> supply availability in a complex supply chain setup where business could be 
> run using multiple facilities spread geographically. A more common examples 
> could be brick and mortar retail stores chain having multiple stores spread 
> across geographically. Or any manufacturing business that own multiple 
> production facilities and warehouse spread across geographically. 
> *Requirement*
> There are many instances, where material visibility in a multi-facility setup 
> within an organization or company is not very accurately gauged. We would 
> need to start building an intelligent planning system that could gauge such 
> material availability across facilities and honor them while furnishing the 
> requirements around any product within any given facility. 
> Let's consider following use case (Please refer to attached screenshot for 
> reference)
> !screenshot-1.png|width=800px!
> :
> * A retail chain has multiple stores and say a given physical store 
> 'Store_01' and is strategically located near two warehouse in the region say 
> Whse_01 & Whse_02, 
> * One centralized warehouse(Main/buffer) say 'Backup_Whse' that supplies 
> material to all the stores and regional warehouse 
> * Any retails store e.g. Store_01 shouldn't raise purchase order from any 
> outside vendor directly.
> * As Store_01 is strategically located near Whse_01 & Whse_02, so system 
> should always suggest to replenish any product shortfall by first looking up 
> and pulling up available supply from Whse_01 & Whse_02 and then from 
> Backup_Whse in that order of priority.
> * Banckup_Whse mostly works on push system and supplies the products to all 
> regional warehouse and physical stores.
> Now we could design an OFbiz based replenishment planning that :
> * Could allow to associate and rank the facilities(physical store/warehouse) 
> that could replenish the material at any other facility (physical 
> store/warehouse)
> * Could suggest the "*Transfer Requirement*" by gauging the product shortfall 
> within any given facility product-facility at any given point of time by
> * Could allow to configure and manage the setting at facility(ProductStore or 
> ProductFacility) level, to let planning engine know whether given facility 
> could replenish stock via Transfer Requirement from any other facility. If 
> not then it could take normal route of replenishment via Purchase Order or 
> Production Order route.



--
This message was sent by Atlassian JIRA

[jira] [Updated] (OFBIZ-7355) OFBIZ-6964: Document finalized business requirements to support replenishment planning through any inter-company facility


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7355:

Description: 
Here are the most common set of business requirement to support product level 
replenishment within a given facility(store/warehouse) via any inter-company 
facility (preferred warehouse/stocking facility) before raising the purchase 
order from an outside vendors/suppliers.

In current standard OFbiz workflow there are essentially two basic types of 
material requirements generated at product-facility level. Both of these can be 
created manually or could be suggested by MRP engine:
* First, is "Product Requirement" which suggests that the given product is 
going to be low or out of stock within any given facility in a given time frame 
based on upstream demand signals within the supply chain and hence can more 
commonly be treated as Purchase Requirement that need to be eventually 
transformed as Purchase Orders to be raised from a given vendor/supplier
* Second, is "Internal Requirement" which suggests that the given product is 
going to be low or out of stock within any given facility in a given time frame 
based on upstream demand within the supply chain. But such products can be 
internally manufactured(produced) and hence can more commonly be treated as 
Production Requirement that need to be eventually transformed as Production 
Order (Production Run).

*Gap*
Currently the OFbiz planning algorithm (aka MRP) generate the requirement by 
only considering the supply available within the given facility. But there is 
no planning logic built into the system which can support and look up the 
supply availability in a complex supply chain setup where business could be run 
using multiple facilities spread geographically. A more common examples could 
be brick and mortar retail stores chain having multiple stores spread across 
geographically. Or any manufacturing business that own multiple production 
facilities and warehouse spread across geographically. 

*Requirement*
There are many instances, where material visibility in a multi-facility setup 
within an organization or company is not very accurately gauged. We would need 
to start building an intelligent planning system that could gauge such material 
availability across facilities and honor them while furnishing the requirements 
around any product within any given facility. 
Let's consider following use case (Please refer to attached screenshot for 
reference)

!screenshot-1.png|width=800px!
:
* A retail chain has multiple stores and say a given physical store 'Store_01' 
and is strategically located near two warehouse in the region say Whse_01 & 
Whse_02, 
* One centralized warehouse(Main/buffer) say 'Backup_Whse' that supplies 
material to all the stores and regional warehouse 
* Any retails store e.g. Store_01 shouldn't raise purchase order from any 
outside vendor directly.
* As Store_01 is strategically located near Whse_01 & Whse_02, so system should 
always suggest to replenish any product shortfall by first looking up and 
pulling up available supply from Whse_01 & Whse_02 and then from Backup_Whse in 
that order of priority.
* Banckup_Whse mostly works on push system and supplies the products to all 
regional warehouse and physical stores.

Now we could design an OFbiz based replenishment planning that :
* Could allow to associate and rank the facilities(physical store/warehouse) 
that could replenish the material at any other facility (physical 
store/warehouse)
* Could suggest the "*Transfer Requirement*" by gauging the product shortfall 
within any given facility product-facility at any given point of time by
* Could allow to configure and manage the setting at facility(ProductStore or 
ProductFacility) level, to let planning engine know whether given facility 
could replenish stock via Transfer Requirement from any other facility. If not 
then it could take normal route of replenishment via Purchase Order or 
Production Order route.


  was:
Here are the most common set of business requirement to support product level 
replenishment within a given facility(store/warehouse) via any inter-company 
facility (preferred warehouse/stocking facility) before raising the purchase 
order from an outside vendors/suppliers.

In current standard OFbiz workflow there are essentially two basic types of 
material requirements generated at product-facility level. Both of these can be 
created manually or could be suggested by MRP engine:
* First, is "Product Requirement" which suggests that the given product is 
going to be low or out of stock within any given facility in a given time frame 
based on upstream demand signals within the supply chain and hence can more 
commonly be treated as Purchase Requirement that need to be eventually 
transformed as Purchase Orders to be raised from a given vendor/supplier
* Second, is "Internal

[jira] [Updated] (OFBIZ-7355) OFBIZ-6964: Document finalized business requirements to support replenishment planning through any inter-company facility


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7355:

Attachment: screenshot-1.png

> OFBIZ-6964: Document finalized business requirements to support replenishment 
> planning through any inter-company facility
> -
>
> Key: OFBIZ-7355
> URL: https://issues.apache.org/jira/browse/OFBIZ-7355
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: Upcoming Branch
>
> Attachments: screenshot-1.png
>
>
> Here are the most common set of business requirement to support product level 
> replenishment within a given facility(store/warehouse) via any inter-company 
> facility (preferred warehouse/stocking facility) before raising the purchase 
> order from an outside vendors/suppliers.
> In current standard OFbiz workflow there are essentially two basic types of 
> material requirements generated at product-facility level. Both of these can 
> be created manually or could be suggested by MRP engine:
> * First, is "Product Requirement" which suggests that the given product is 
> going to be low or out of stock within any given facility in a given time 
> frame based on upstream demand signals within the supply chain and hence can 
> more commonly be treated as Purchase Requirement that need to be eventually 
> transformed as Purchase Orders to be raised from a given vendor/supplier
> * Second, is "Internal Requirement" which suggests that the given product is 
> going to be low or out of stock within any given facility in a given time 
> frame based on upstream demand within the supply chain. But such products can 
> be internally manufactured(produced) and hence can more commonly be treated 
> as Production Requirement that need to be eventually transformed as 
> Production Order (Production Run).
> *Gap*
> Currently the OFbiz planning algorithm (aka MRP) generate the requirement by 
> only considering the supply available within the given facility. But there is 
> no planning logic built into the system which can support and look up the 
> supply availability in a complex supply chain setup where business could be 
> run using multiple facilities spread geographically. A more common examples 
> could be brick and mortar retail stores chain having multiple stores spread 
> across geographically. Or any manufacturing business that own multiple 
> production facilities and warehouse spread across geographically. 
> *Requirement*
> There are many instances, where material visibility in a multi-facility setup 
> within an organization or company is not very accurately gauged. We would 
> need to start building an intelligent planning system that could gauge such 
> material availability across facilities and honor them while furnishing the 
> requirements around any product within any given facility. 
> Let's consider following use case (Please refer to attached screenshot for 
> reference):
> * A retail chain has multiple stores and say a given physical store 
> 'Store_01' and is strategically located near two warehouse in the region say 
> Whse_01 & Whse_02, 
> * One centralized warehouse(Main/buffer) say 'Backup_Whse' that supplies 
> material to all the stores and regional warehouse 
> * Any retails store e.g. Store_01 shouldn't raise purchase order from any 
> outside vendor directly.
> * As Store_01 is strategically located near Whse_01 & Whse_02, so system 
> should always suggest to replenish any product shortfall by first looking up 
> and pulling up available supply from Whse_01 & Whse_02 and then from 
> Backup_Whse in that order of priority.
> * Banckup_Whse mostly works on push system and supplies the products to all 
> regional warehouse and physical stores.
> Now we could design an OFbiz based replenishment planning that :
> * Could allow to associate and rank the facilities(physical store/warehouse) 
> that could replenish the material at any other facility (physical 
> store/warehouse)
> * Could suggest the "*Transfer Requirement*" by gauging the product shortfall 
> within any given facility product-facility at any given point of time by
> * Could allow to configure and manage the setting at facility(ProductStore or 
> ProductFacility) level, to let planning engine know whether given facility 
> could replenish stock via Transfer Requirement from any other facility. If 
> not then it could take normal route of replenishment via Purchase Order or 
> Production Order route.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7355) OFBIZ-6964: Document finalized business requirements to support replenishment planning through any inter-company facility


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7355:

Description: 
Here are the most common set of business requirement to support product level 
replenishment within a given facility(store/warehouse) via any inter-company 
facility (preferred warehouse/stocking facility) before raising the purchase 
order from an outside vendors/suppliers.

In current standard OFbiz workflow there are essentially two basic types of 
material requirements generated at product-facility level. Both of these can be 
created manually or could be suggested by MRP engine:
* First, is "Product Requirement" which suggests that the given product is 
going to be low or out of stock within any given facility in a given time frame 
based on upstream demand signals within the supply chain and hence can more 
commonly be treated as Purchase Requirement that need to be eventually 
transformed as Purchase Orders to be raised from a given vendor/supplier
* Second, is "Internal Requirement" which suggests that the given product is 
going to be low or out of stock within any given facility in a given time frame 
based on upstream demand within the supply chain. But such products can be 
internally manufactured(produced) and hence can more commonly be treated as 
Production Requirement that need to be eventually transformed as Production 
Order (Production Run).

*Gap*
Currently the OFbiz planning algorithm (aka MRP) generate the requirement by 
only considering the supply available within the given facility. But there is 
no planning logic built into the system which can support and look up the 
supply availability in a complex supply chain setup where business could be run 
using multiple facilities spread geographically. A more common examples could 
be brick and mortar retail stores chain having multiple stores spread across 
geographically. Or any manufacturing business that own multiple production 
facilities and warehouse spread across geographically. 

*Requirement*
There are many instances, where material visibility in a multi-facility setup 
within an organization or company is not very accurately gauged. We would need 
to start building an intelligent planning system that could gauge such material 
availability across facilities and honor them while furnishing the requirements 
around any product within any given facility. 
Let's consider following use case (Please refer to attached screenshot for 
reference):
* A retail chain has multiple stores and say a given physical store 'Store_01' 
and is strategically located near two warehouse in the region say Whse_01 & 
Whse_02, 
* One centralized warehouse(Main/buffer) say 'Backup_Whse' that supplies 
material to all the stores and regional warehouse 
* Any retails store e.g. Store_01 shouldn't raise purchase order from any 
outside vendor directly.
* As Store_01 is strategically located near Whse_01 & Whse_02, so system should 
always suggest to replenish any product shortfall by first looking up and 
pulling up available supply from Whse_01 & Whse_02 and then from Backup_Whse in 
that order of priority.
* Banckup_Whse mostly works on push system and supplies the products to all 
regional warehouse and physical stores.

Now we could design an OFbiz based replenishment planning that :
* Could allow to associate and rank the facilities(physical store/warehouse) 
that could replenish the material at any other facility (physical 
store/warehouse)
* Could suggest the "*Transfer Requirement*" by gauging the product shortfall 
within any given facility product-facility at any given point of time by
* Could allow to configure and manage the setting at facility(ProductStore or 
ProductFacility) level, to let planning engine know whether given facility 
could replenish stock via Transfer Requirement from any other facility. If not 
then it could take normal route of replenishment via Purchase Order or 
Production Order route.


  was:
Here are the most common set of business requirement to support product level 
replenishment within a given facility(store/warehouse) via any inter-company 
facility (preferred warehouse/stocking facility) before raising the purchase 
order from an outside vendors/suppliers.

In current standard OFbiz workflow there are essentially two basic types of 
material requirements generated at product-facility level. Both of these can be 
created manually or could be suggested by MRP engine:
* First, is "Product Requirement" which suggests that the given product is 
going to be low or out of stock within any given facility in a given time frame 
based on upstream demand signals within the supply chain and hence can more 
commonly be treated as Purchase Requirement that need to be eventually 
transformed as Purchase Orders to be raised from a given vendor/supplier
* Second, is "Internal Requirement" which suggests that the given

[jira] [Assigned] (OFBIZ-7339) Replace EntityUtilProperties getPropertyValue method with correct method calls

2016-06-15 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7339:
---

Assignee: Arun Patidar

> Replace EntityUtilProperties getPropertyValue method with correct method calls
> --
>
> Key: OFBIZ-7339
> URL: https://issues.apache.org/jira/browse/OFBIZ-7339
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, framework, manufacturing, party, product, 
> securityext, specialpurpose/ecommerce, specialpurpose/lucene, 
> specialpurpose/passport, workeffort
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
> Attachments: EntityUtilProperties.patch
>
>
> In current OFBiz system at many places many methods implemented but not used 
> as per their purpose. One example is in EntityUtilProperties we have 
> getPropertyAsInteger() and getPropertyAsBigDecimal() and other methods which 
> returns specific type data. But at most places system uses getPropertyValue() 
> which returns string and then do explicit conversions.
> System should use proper methods for which they have been implemented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7354) TimeSheet list has editable fields, it should be display fields


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey reassigned OFBIZ-7354:


Assignee: Pranay Pandey  (was: Amardeep Singh Jhajj)

> TimeSheet list has editable fields, it should be display fields
> ---
>
> Key: OFBIZ-7354
> URL: https://issues.apache.org/jira/browse/OFBIZ-7354
> Project: OFBiz
>  Issue Type: Improvement
>  Components: workeffort
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
>Priority: Minor
> Attachments: OFBIZ-7354-Screen-Shot.png, OFBIZ-7354.patch
>
>
> TimeSheet list has editable fields, it should be display fields. This list is 
> intended to display information about timesheets and any timesheet can be 
> edited from their view page.
> Please find attached screenshot
> Steps to regenerate:
> 1. Go to https://localhost:8443/workeffort/control/FindTimesheet
> 2. Find timesheet, list with editable fields will display.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7132) cmssite Demo Data Upgrade to Demonstrate Usage of WebSitePathAlias


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey reassigned OFBIZ-7132:


Assignee: Pranay Pandey  (was: Chandan Khandelwal)

> cmssite Demo Data Upgrade to Demonstrate Usage of WebSitePathAlias 
> ---
>
> Key: OFBIZ-7132
> URL: https://issues.apache.org/jira/browse/OFBIZ-7132
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/cmssite
>Reporter: Pranay Pandey
>Assignee: Pranay Pandey
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7132.patch
>
>
> cmssite Demo Data to be Upgraded to Demonstrate Usage of WebSitePathAlias. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7355) OFBIZ-6964: Document finalized business requirements to support replenishment planning through any inter-company facility


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7355:

Description: 
Here are the most common set of business requirement to support product level 
replenishment within a given facility(store/warehouse) via any inter-company 
facility (preferred warehouse/stocking facility) before raising the purchase 
order from an outside vendors/suppliers.

In current standard OFbiz workflow there are essentially two basic types of 
material requirements generated at product-facility level. Both of these can be 
created manually or could be suggested by MRP engine:
* First, is "Product Requirement" which suggests that the given product is 
going to be low or out of stock within any given facility in a given time frame 
based on upstream demand signals within the supply chain and hence can more 
commonly be treated as Purchase Requirement that need to be eventually 
transformed as Purchase Orders to be raised from a given vendor/supplier
* Second, is "Internal Requirement" which suggests that the given product is 
going to be low or out of stock within any given facility in a given time frame 
based on upstream demand within the supply chain. But such products can be 
internally manufactured(produced) and hence can more commonly be treated as 
Production Requirement that need to be eventually transformed as Production 
Order (Production Run).

*Gap*
Currently the OFbiz planning algorithm (aka MRP) generate the requirement by 
only considering the supply available within the given facility. But there is 
no planning logic built into the system which can support and look up the 
supply availability in a complex supply chain setup where business could be run 
using multiple facilities spread geographically. A more common examples could 
be brick and mortar retail stores chain having multiple stores spread across 
geographically. Or any manufacturing business that own multiple production 
facilities and warehouse spread across geographically. 

*Requirement*
There are many instances, where material visibility in a multi-facility setup 
within an organization or company is not very accurately gauged. We would need 
to start building an intelligent planning system that could gauge such material 
availability across facilities and honor them while furnishing the requirements 
around any product within any given facility. 
Let's consider a simple use case as follows:



  was:Let's use this ticket to post the finalized business requirement to 
support product level replenishment within a given facility(store/warehouse) 
via any inter-company facility (preferred warehouse/stocking facility) before 
raising the purchase order from an outside vendors/suppliers.


> OFBIZ-6964: Document finalized business requirements to support replenishment 
> planning through any inter-company facility
> -
>
> Key: OFBIZ-7355
> URL: https://issues.apache.org/jira/browse/OFBIZ-7355
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: Upcoming Branch
>
>
> Here are the most common set of business requirement to support product level 
> replenishment within a given facility(store/warehouse) via any inter-company 
> facility (preferred warehouse/stocking facility) before raising the purchase 
> order from an outside vendors/suppliers.
> In current standard OFbiz workflow there are essentially two basic types of 
> material requirements generated at product-facility level. Both of these can 
> be created manually or could be suggested by MRP engine:
> * First, is "Product Requirement" which suggests that the given product is 
> going to be low or out of stock within any given facility in a given time 
> frame based on upstream demand signals within the supply chain and hence can 
> more commonly be treated as Purchase Requirement that need to be eventually 
> transformed as Purchase Orders to be raised from a given vendor/supplier
> * Second, is "Internal Requirement" which suggests that the given product is 
> going to be low or out of stock within any given facility in a given time 
> frame based on upstream demand within the supply chain. But such products can 
> be internally manufactured(produced) and hence can more commonly be treated 
> as Production Requirement that need to be eventually transformed as 
> Production Order (Production Run).
> *Gap*
> Currently the OFbiz planning algorithm (aka MRP) generate the requirement by 
> only considering the supply available within the given facility. But there is 
> no planning logic built into the system which can support and

[jira] [Updated] (OFBIZ-7249) Error on removing scrum members

2016-06-15 Thread Anurag Chandak (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anurag Chandak updated OFBIZ-7249:
--
Affects Version/s: (was: Release Branch 13.07)

> Error on removing scrum members
> ---
>
> Key: OFBIZ-7249
> URL: https://issues.apache.org/jira/browse/OFBIZ-7249
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/scrum
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Anurag Chandak
>Assignee: Anurag Chandak
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7249.patch
>
>
> Steps to regenerate:
> - Go to Scrum --> Administration --> Scrum Members
> - Try to remove only those scrum members whose party and role type are 
> similar to product members
> - The following error is shown:
> {code}
> The Following Errors Occurred:
> Error:Error doing entity-auto operation for entity PartyRole in service 
> deletePartyRole: org.ofbiz.entity.GenericEntityException: 
> org.ofbiz.entity.GenericDataSourceException: Exception while deleting the 
> following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)) (Exception 
> while deleting the following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)))
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7355) OFBIZ-6964: Document finalized business requirements to support replenishment planning through any inter-company facility


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7355:

Summary: OFBIZ-6964: Document finalized business requirements to support 
replenishment planning through any inter-company facility  (was: OFBIZ-6964: 
Finalize business requirements to support replenishment planning through any 
inter-company facility)

> OFBIZ-6964: Document finalized business requirements to support replenishment 
> planning through any inter-company facility
> -
>
> Key: OFBIZ-7355
> URL: https://issues.apache.org/jira/browse/OFBIZ-7355
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: Upcoming Branch
>
>
> Let's use this ticket to post the finalized business requirement to support 
> product level replenishment within a given facility(store/warehouse) via any 
> inter-company facility (preferred warehouse/stocking facility) before raising 
> the purchase order from an outside vendors/suppliers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7356) OFBIZ-6964: Document finalized design to support replenishment planning through any inter-company facility


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7356:

Summary: OFBIZ-6964: Document finalized design to support replenishment 
planning through any inter-company facility  (was: OFBIZ-6964: Finalize Design 
to support replenishment planning through any inter-company facility)

> OFBIZ-6964: Document finalized design to support replenishment planning 
> through any inter-company facility
> --
>
> Key: OFBIZ-7356
> URL: https://issues.apache.org/jira/browse/OFBIZ-7356
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: 15.12.01
>
>
> Let's use this ticket to post the concluded design notes to support the 
> product level replenishment from any inter-company facility before raising 
> the ordering from an outside vendor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7356) OFBIZ-6964: Finalize Design to support replenishment planning through any inter-company facility

Swapnil Shah created OFBIZ-7356:
---

 Summary: OFBIZ-6964: Finalize Design to support replenishment 
planning through any inter-company facility
 Key: OFBIZ-7356
 URL: https://issues.apache.org/jira/browse/OFBIZ-7356
 Project: OFBiz
  Issue Type: Sub-task
  Components: manufacturing, order, product
Reporter: Swapnil Shah
Assignee: Swapnil Shah
 Fix For: 15.12.01


Let's use this ticket to post the concluded design notes to support the product 
level replenishment from any inter-company facility before raising the ordering 
from an outside vendor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7355) OFBIZ-6964: Finalize business requirements to support replenishment planning through any inter-company facility


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7355:

Description: Let's use this ticket to post the finalized business 
requirement to support product level replenishment within a given 
facility(store/warehouse) via any inter-company facility (preferred 
warehouse/stocking facility) before raising the purchase order from an outside 
vendors/suppliers.  (was: Let's use this ticket to post the finalized business 
requirement to support product level replenishment via secondary/buffer 
warehouse before raising the purchase order from any outside vendors/suppliers.)

> OFBIZ-6964: Finalize business requirements to support replenishment planning 
> through any inter-company facility
> ---
>
> Key: OFBIZ-7355
> URL: https://issues.apache.org/jira/browse/OFBIZ-7355
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: Upcoming Branch
>
>
> Let's use this ticket to post the finalized business requirement to support 
> product level replenishment within a given facility(store/warehouse) via any 
> inter-company facility (preferred warehouse/stocking facility) before raising 
> the purchase order from an outside vendors/suppliers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7355) OFBIZ-6964: Finalize business requirements to support replenishment planning through any inter-company facility


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7355:

Summary: OFBIZ-6964: Finalize business requirements to support 
replenishment planning through any inter-company facility  (was: Finalized 
business requirements)

> OFBIZ-6964: Finalize business requirements to support replenishment planning 
> through any inter-company facility
> ---
>
> Key: OFBIZ-7355
> URL: https://issues.apache.org/jira/browse/OFBIZ-7355
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
> Fix For: Upcoming Branch
>
>
> Let's use this ticket to post the finalized business requirement to support 
> product level replenishment via secondary/buffer warehouse before raising the 
> purchase order from any outside vendors/suppliers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7355) Finalized business requirements

Swapnil Shah created OFBIZ-7355:
---

 Summary: Finalized business requirements
 Key: OFBIZ-7355
 URL: https://issues.apache.org/jira/browse/OFBIZ-7355
 Project: OFBiz
  Issue Type: Sub-task
  Components: manufacturing, order, product
Affects Versions: 15.12.01
Reporter: Swapnil Shah
Assignee: Swapnil Shah


Let's use this ticket to post the finalized business requirement to support 
product level replenishment via secondary/buffer warehouse before raising the 
purchase order from any outside vendors/suppliers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6947) Inventory report throws an error

2016-06-15 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332717#comment-15332717
 ] 

Pierre Smits commented on OFBIZ-6947:
-

You must be mistaken. This issue was created well before the upgrade to FOP2.1 
and its stricter validation.

> Inventory report throws an error
> 
>
> Key: OFBIZ-6947
> URL: https://issues.apache.org/jira/browse/OFBIZ-6947
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: facility, inventory, pdf
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6947_trunk.patch, OFBIZ-6947_trunk_2.patch
>
>
> When executing the print pdf function in 
> https://demo-trunk-ofbiz.apache.org/facility/control/ViewFacilityInventoryByProduct
> the following error is thrown:
> {code}
> The Following Errors Occurred:
> Unable to transform FO file: org.apache.fop.apps.FOPException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115) javax.xml.transform.TransformerException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6947) Inventory report throws an error


[ 
https://issues.apache.org/jira/browse/OFBIZ-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332706#comment-15332706
 ] 

Jacques Le Roux commented on OFBIZ-6947:


It's not really broken by OFBIZ-7141 but we decided to block on errors

> Inventory report throws an error
> 
>
> Key: OFBIZ-6947
> URL: https://issues.apache.org/jira/browse/OFBIZ-6947
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: facility, inventory, pdf
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6947_trunk.patch, OFBIZ-6947_trunk_2.patch
>
>
> When executing the print pdf function in 
> https://demo-trunk-ofbiz.apache.org/facility/control/ViewFacilityInventoryByProduct
> the following error is thrown:
> {code}
> The Following Errors Occurred:
> Unable to transform FO file: org.apache.fop.apps.FOPException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115) javax.xml.transform.TransformerException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-6947) Inventory report throws an error


[ 
https://issues.apache.org/jira/browse/OFBIZ-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332589#comment-15332589
 ] 

Jacques Le Roux edited comment on OFBIZ-6947 at 6/15/16 9:20 PM:
-

Thanks  Arvind Singh Tomar.

Your patch is in trunk at revision: 1748628, only trunk was concerned after 
OFBIZ-7141



was (Author: jacques.le.roux):
Thanks

Your patch is in trunk at revision: 1748628, only trunk was concerned after 
OFBIZ-7141


> Inventory report throws an error
> 
>
> Key: OFBIZ-6947
> URL: https://issues.apache.org/jira/browse/OFBIZ-6947
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: facility, inventory, pdf
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6947_trunk.patch, OFBIZ-6947_trunk_2.patch
>
>
> When executing the print pdf function in 
> https://demo-trunk-ofbiz.apache.org/facility/control/ViewFacilityInventoryByProduct
> the following error is thrown:
> {code}
> The Following Errors Occurred:
> Unable to transform FO file: org.apache.fop.apps.FOPException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115) javax.xml.transform.TransformerException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-6947) Inventory report throws an error


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6947.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks

Your patch is in trunk at revision: 1748628, only trunk was concerned after 
OFBIZ-7141


> Inventory report throws an error
> 
>
> Key: OFBIZ-6947
> URL: https://issues.apache.org/jira/browse/OFBIZ-6947
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: facility, inventory, pdf
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6947_trunk.patch, OFBIZ-6947_trunk_2.patch
>
>
> When executing the print pdf function in 
> https://demo-trunk-ofbiz.apache.org/facility/control/ViewFacilityInventoryByProduct
> the following error is thrown:
> {code}
> The Following Errors Occurred:
> Unable to transform FO file: org.apache.fop.apps.FOPException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115) javax.xml.transform.TransformerException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7318) Order By Referrer is not working

2016-06-15 Thread Rohit Koushal (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332174#comment-15332174
 ] 

Rohit Koushal commented on OFBIZ-7318:
--

On rev [#886743|http://svn.apache.org/viewvc?rev=886743=rev] 
SalesOrderItemFact extended with visitId and initialReferrer and on rev   
[#1055774|http://svn.apache.org/viewvc?rev=1055774=rev] these field has 
been removed. So I think we need to clean references visitId and 
initialReferrer form the report and if we removed these fields then report will 
not make any sense. So in my opinion  it is better to remove this report from 
OFBIZ.


> Order By Referrer is not working
> 
>
> Key: OFBIZ-7318
> URL: https://issues.apache.org/jira/browse/OFBIZ-7318
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order, specialpurpose/birt
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>
> Order By Referrer is not working
> Screen : 
> https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions
> Section : Order By Referrer



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-6947) Inventory report throws an error


[ 
https://issues.apache.org/jira/browse/OFBIZ-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331853#comment-15331853
 ] 

Jacques Le Roux edited comment on OFBIZ-6947 at 6/15/16 4:41 PM:
-

Hello [~jacques.le.roux]

The issue was due to missing child element which is failing on validation. 
Earlier we were using fop-1.1.jar and now it is updated to fop-2.0.jar which by 
default validates the markup. 
It is same as OFBIZ-7090

I have added the missing child elements in the macro which were causing the 
validation to fail and providing the updated patch.



was (Author: arvind.singh):
Hello [~jacques.le.roux]

The issue was due to missing child element which is failing on validation. 
Earlier we were using fop-1.1.jar and now it is updated to fop-2.0.jar which by 
default validates the markup. 
It is same as https://issues.apache.org/jira/browse/OFBIZ-7090

I have added the missing child elements in the macro which were causing the 
validation to fail and providing the updated patch.


> Inventory report throws an error
> 
>
> Key: OFBIZ-6947
> URL: https://issues.apache.org/jira/browse/OFBIZ-6947
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: facility, inventory, pdf
> Attachments: OFBIZ-6947_trunk.patch, OFBIZ-6947_trunk_2.patch
>
>
> When executing the print pdf function in 
> https://demo-trunk-ofbiz.apache.org/facility/control/ViewFacilityInventoryByProduct
> the following error is thrown:
> {code}
> The Following Errors Occurred:
> Unable to transform FO file: org.apache.fop.apps.FOPException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115) javax.xml.transform.TransformerException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Product base promotion calculation

2016-06-15 Thread jler...@apache.org

At 99.99% you have no chances that an image get through ANY ASF ML. If you need to share you must find another way, easiest are Jira (if you need to 
create an issue anyway), then Nabble, else a lot of other options ;)

Jacques

Le 15/06/2016 à 15:59, Arvind singh tomar a écrit :

Hi Mridul

I have attached the screenshots but it seems like attachments are being omitted on the mailing list. Sending them again as inline images in case if 
it works.

On 15 June 2016 at 19:19, Mridul Pathak > wrote:

Hi Arvind,

Seems like you missed attaching the screenshot.

--
Thanks & Regards,
Mridul Pathak
Senior Manager
HotWax Systems
http://www.hotwaxsystems.com

> On Jun 15, 2016, at 7:16 PM, Arvind singh tomar > wrote:
>
> Hi Everyone,
>
> I found the behavior of product base promotion calculation a bit strange. 
Need your advice on whether it is correct behaviour or need some
improvement in promotion calculation.
>
> The promotion which I used was to give 30% discount for the item (i.e. 
RAM1GB_BRAND). I created a sales order with 10 quantity of the product.
During the promotion calculation, OFBiz created 10 OrderAdjustments, one 
for each quantity for the same promotion type.
>
> I was expecting that in the case if same Promotion is applicable for more 
than one quantity of a product then a single OrderAdjustment should
be created instead of creating one for each quantity. It is also messing up 
the UI.
>
> Attached the screenshots for the same.
>
>
> Thanks and Regards
> --
> Arvind Singh Tomar

[jira] [Assigned] (OFBIZ-6947) Inventory report throws an error


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-6947:
--

Assignee: Jacques Le Roux

> Inventory report throws an error
> 
>
> Key: OFBIZ-6947
> URL: https://issues.apache.org/jira/browse/OFBIZ-6947
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: facility, inventory, pdf
> Attachments: OFBIZ-6947_trunk.patch, OFBIZ-6947_trunk_2.patch
>
>
> When executing the print pdf function in 
> https://demo-trunk-ofbiz.apache.org/facility/control/ViewFacilityInventoryByProduct
> the following error is thrown:
> {code}
> The Following Errors Occurred:
> Unable to transform FO file: org.apache.fop.apps.FOPException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115) javax.xml.transform.TransformerException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6947) Inventory report throws an error

2016-06-15 Thread Arvind Singh Tomar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331853#comment-15331853
 ] 

Arvind Singh Tomar commented on OFBIZ-6947:
---

Hello [~jacques.le.roux]

The issue was due to missing child element which is failing on validation. 
Earlier we were using fop-1.1.jar and now it is updated to fop-2.0.jar which by 
default validates the markup. 
It is same as https://issues.apache.org/jira/browse/OFBIZ-7090

I have added the missing child elements in the macro which were causing the 
validation to fail and providing the updated patch.


> Inventory report throws an error
> 
>
> Key: OFBIZ-6947
> URL: https://issues.apache.org/jira/browse/OFBIZ-6947
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: facility, inventory, pdf
> Attachments: OFBIZ-6947_trunk.patch, OFBIZ-6947_trunk_2.patch
>
>
> When executing the print pdf function in 
> https://demo-trunk-ofbiz.apache.org/facility/control/ViewFacilityInventoryByProduct
> the following error is thrown:
> {code}
> The Following Errors Occurred:
> Unable to transform FO file: org.apache.fop.apps.FOPException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115) javax.xml.transform.TransformerException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6947) Inventory report throws an error

2016-06-15 Thread Arvind Singh Tomar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arvind Singh Tomar updated OFBIZ-6947:
--
Attachment: OFBIZ-6947_trunk_2.patch

> Inventory report throws an error
> 
>
> Key: OFBIZ-6947
> URL: https://issues.apache.org/jira/browse/OFBIZ-6947
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: facility, inventory, pdf
> Attachments: OFBIZ-6947_trunk.patch, OFBIZ-6947_trunk_2.patch
>
>
> When executing the print pdf function in 
> https://demo-trunk-ofbiz.apache.org/facility/control/ViewFacilityInventoryByProduct
> the following error is thrown:
> {code}
> The Following Errors Occurred:
> Unable to transform FO file: org.apache.fop.apps.FOPException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115) javax.xml.transform.TransformerException: 
> org.apache.fop.fo.ValidationException: null:80:115: "fo:table-cell" is 
> missing child elements. Required content model: marker* (%block;)+ (See 
> position 80:115)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7350) Manage filters in lookup auto completion


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-7350:
---

Assignee: Deepak Dixit

> Manage filters in lookup auto completion
> 
>
> Key: OFBIZ-7350
> URL: https://issues.apache.org/jira/browse/OFBIZ-7350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Charles STELTZLEN
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-7350.13.07.patch, OFBIZ-7350.patch
>
>
> On form lookup, we can specify target parameters to pass them to the lookup 
> screen and do filtered searches with these parameters. It works fine when you 
> click on lookup button. But when you start to write something in lookup 
> input, these parameters are not passed to the ajax auto-complete system. So, 
> the results are not filtered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Product base promotion calculation

2016-06-15 Thread Arvind singh tomar

Hi Mridul

I have attached the screenshots but it seems like attachments are being
omitted on the mailing list. Sending them again as inline images in case if
it works.





On 15 June 2016 at 19:19, Mridul Pathak 
wrote:

> Hi Arvind,
>
> Seems like you missed attaching the screenshot.
>
> --
> Thanks & Regards,
> Mridul Pathak
> Senior Manager
> HotWax Systems
> http://www.hotwaxsystems.com
>
> > On Jun 15, 2016, at 7:16 PM, Arvind singh tomar <
> arvindtomar1...@gmail.com> wrote:
> >
> > Hi Everyone,
> >
> > I found the behavior of product base promotion calculation a bit
> strange. Need your advice on whether it is correct behaviour or need some
> improvement in promotion calculation.
> >
> > The promotion which I used was to give 30% discount for the item (i.e.
> RAM1GB_BRAND). I created a sales order with 10 quantity of the product.
> During the promotion calculation, OFBiz created 10 OrderAdjustments, one
> for each quantity for the same promotion type.
> >
> > I was expecting that in the case if same Promotion is applicable for
> more than one quantity of a product then a single OrderAdjustment should be
> created instead of creating one for each quantity. It is also messing up
> the UI.
> >
> > Attached the screenshots for the same.
> >
> >
> > Thanks and Regards
> > --
> > Arvind Singh Tomar
>
>

Re: Product base promotion calculation

Hi Arvind,

Seems like you missed attaching the screenshot.

--
Thanks & Regards,
Mridul Pathak
Senior Manager
HotWax Systems
http://www.hotwaxsystems.com

> On Jun 15, 2016, at 7:16 PM, Arvind singh tomar  
> wrote:
> 
> Hi Everyone,
> 
> I found the behavior of product base promotion calculation a bit strange. 
> Need your advice on whether it is correct behaviour or need some improvement 
> in promotion calculation.
> 
> The promotion which I used was to give 30% discount for the item (i.e. 
> RAM1GB_BRAND). I created a sales order with 10 quantity of the product. 
> During the promotion calculation, OFBiz created 10 OrderAdjustments, one for 
> each quantity for the same promotion type.
> 
> I was expecting that in the case if same Promotion is applicable for more 
> than one quantity of a product then a single OrderAdjustment should be 
> created instead of creating one for each quantity. It is also messing up the 
> UI.
> 
> Attached the screenshots for the same.
> 
> 
> Thanks and Regards
> --
> Arvind Singh Tomar

Product base promotion calculation

2016-06-15 Thread Arvind singh tomar

Hi Everyone,

I found the behavior of product base promotion calculation a bit strange.
Need your advice on whether it is correct behaviour or need some
improvement in promotion calculation.

The promotion which I used was to give 30% discount for the item (i.e.
RAM1GB_BRAND). I created a sales order with 10 quantity of the product.
During the promotion calculation, OFBiz created 10 OrderAdjustments, one
for each quantity for the same promotion type.

I was expecting that in the case if same Promotion is applicable for more
than one quantity of a product then a single OrderAdjustment should be
created instead of creating one for each quantity. It is also messing up
the UI.

Attached the screenshots for the same.


Thanks and Regards
--
Arvind Singh Tomar

[jira] [Closed] (OFBIZ-7112) EntityUtilProperties


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7112.
--
Resolution: Implemented

> EntityUtilProperties
> 
>
> Key: OFBIZ-7112
> URL: https://issues.apache.org/jira/browse/OFBIZ-7112
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7112.patch, OFBIZ-7112.patch, OFBIZ-7112.patch, 
> OFBIZ-7112.patch
>
>
> Ofbiz reads properties from either a properties file or the 
> entity:SystemProperty. The way it works previously is that ofbiz reads from 
> the entity:SystemProperty first and if there is no value associated with the 
> target propertyname, it would then locate the value from the relevant 
> properties file.
> In other words, if there is a database entry for a property, the database 
> entry should override the associated properties file.
> The issue is that if a database entry exist but the value is empty, it would 
> look for a value from the properties file.  It should not do so.  If a 
> database entry exists for the propertyname of interest, the value should be 
> taken from the database even if it holds an empty value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7339) Replace EntityUtilProperties getPropertyValue method with correct method calls


[ 
https://issues.apache.org/jira/browse/OFBIZ-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331753#comment-15331753
 ] 

Jacques Le Roux commented on OFBIZ-7339:


 OFBIZ-7112 is done :)

> Replace EntityUtilProperties getPropertyValue method with correct method calls
> --
>
> Key: OFBIZ-7339
> URL: https://issues.apache.org/jira/browse/OFBIZ-7339
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, framework, manufacturing, party, product, 
> securityext, specialpurpose/ecommerce, specialpurpose/lucene, 
> specialpurpose/passport, workeffort
>Affects Versions: Trunk
>Reporter: Rishi Solanki
> Attachments: EntityUtilProperties.patch
>
>
> In current OFBiz system at many places many methods implemented but not used 
> as per their purpose. One example is in EntityUtilProperties we have 
> getPropertyAsInteger() and getPropertyAsBigDecimal() and other methods which 
> returns specific type data. But at most places system uses getPropertyValue() 
> which returns string and then do explicit conversions.
> System should use proper methods for which they have been implemented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7132) cmssite Demo Data Upgrade to Demonstrate Usage of WebSitePathAlias

2016-06-15 Thread Chandan Khandelwal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandan Khandelwal updated OFBIZ-7132:
--
Assignee: Chandan Khandelwal

> cmssite Demo Data Upgrade to Demonstrate Usage of WebSitePathAlias 
> ---
>
> Key: OFBIZ-7132
> URL: https://issues.apache.org/jira/browse/OFBIZ-7132
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/cmssite
>Reporter: Pranay Pandey
>Assignee: Chandan Khandelwal
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7132.patch
>
>
> cmssite Demo Data to be Upgraded to Demonstrate Usage of WebSitePathAlias. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7132) cmssite Demo Data Upgrade to Demonstrate Usage of WebSitePathAlias

2016-06-15 Thread Chandan Khandelwal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandan Khandelwal updated OFBIZ-7132:
--
Assignee: (was: Pranay Pandey)

> cmssite Demo Data Upgrade to Demonstrate Usage of WebSitePathAlias 
> ---
>
> Key: OFBIZ-7132
> URL: https://issues.apache.org/jira/browse/OFBIZ-7132
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/cmssite
>Reporter: Pranay Pandey
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7132.patch
>
>
> cmssite Demo Data to be Upgraded to Demonstrate Usage of WebSitePathAlias. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7132) cmssite Demo Data Upgrade to Demonstrate Usage of WebSitePathAlias

2016-06-15 Thread Chandan Khandelwal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandan Khandelwal updated OFBIZ-7132:
--
Attachment: OFBIZ-7132.patch

Added Patch for WebSitePathAlias demo data for the cmssite.

> cmssite Demo Data Upgrade to Demonstrate Usage of WebSitePathAlias 
> ---
>
> Key: OFBIZ-7132
> URL: https://issues.apache.org/jira/browse/OFBIZ-7132
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/cmssite
>Reporter: Pranay Pandey
>Assignee: Pranay Pandey
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7132.patch
>
>
> cmssite Demo Data to be Upgraded to Demonstrate Usage of WebSitePathAlias. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7317) Net Before Overhead Report is not working

2016-06-15 Thread Rohit Koushal (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331674#comment-15331674
 ] 

Rohit Koushal edited comment on OFBIZ-7317 at 6/15/16 1:23 PM:
---

Found various problem  under this report
1. Type miss-match between parameter defined in the report and  the passed 
parameters. Just because of that we are getting an exception like  The type of 
parameter "DateYear" is expected as "integer", not "java.lang.String".
2. This report totally depends on demo data provided under the SalesOrderItems 
applications/order/data/SalesOrderDemoData.xml.
3. This report has lots of hard coded check and values based on 
SalesOrderDemoData.xml data .
4. There are too many non-existing fields(like eBay, RRC, OtherFree and NBO  
etc) which we tried to get from entity SalesOrderItemStarSchema.

I didn't find any documentation  of this report over the confluence, In my 
opinion, we need to remove this report as its foundation totally depends on the 
demo data.


was (Author: rohit.koushal):
Found out various problem  under this report
1. This report depends on demo data provided under the SalesOrderItems 
applications/order/data/SalesOrderDemoData.xml.
2. This report have lots of hard coded check and values.

>  Net Before Overhead Report is not working
> --
>
> Key: OFBIZ-7317
> URL: https://issues.apache.org/jira/browse/OFBIZ-7317
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order, specialpurpose/birt
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>
>  Net Before Overhead Report is not working
> Screen : 
> https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions
> Section : Net Before Overhead Report 
> Getting error like 
> {code}
>[java] 
> org.eclipse.birt.report.engine.api.impl.ParameterValidationException: The 
> type of parameter "DateYear" is expected as "integer", not "java.lang.String".
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.validateParameterValueType(EngineTask.java:940)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.validateAbstractScalarParameter(EngineTask.java:862)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.access$0(EngineTask.java:789)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask$ParameterValidationVisitor.visitScalarParameter(EngineTask.java:706)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask$ParameterVisitor.visit(EngineTask.java:1531)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.doValidateParameters(EngineTask.java:692)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.RunAndRenderTask.doRun(RunAndRenderTask.java:95)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.RunAndRenderTask.run(RunAndRenderTask.java:77)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at org.ofbiz.birt.BirtWorker.exportReport(BirtWorker.java:143) 
> ~[ofbiz-birt.jar:?]
>  [java]   at 
> org.ofbiz.birt.webapp.view.BirtViewHandler.render(BirtViewHandler.java:118) 
> ~[ofbiz-birt.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:1001) 
> ~[ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:653) 
> ~[ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) 
> [ofbiz-webapp.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:622) 
> [servlet-api-3.1.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) 
> [servlet-api-3.1.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:323) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
>

[jira] [Updated] (OFBIZ-7354) TimeSheet list has editable fields, it should be display fields

2016-06-15 Thread Amardeep Singh Jhajj (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amardeep Singh Jhajj updated OFBIZ-7354:

Attachment: OFBIZ-7354.patch
OFBIZ-7354-Screen-Shot.png

> TimeSheet list has editable fields, it should be display fields
> ---
>
> Key: OFBIZ-7354
> URL: https://issues.apache.org/jira/browse/OFBIZ-7354
> Project: OFBiz
>  Issue Type: Improvement
>  Components: workeffort
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
>Priority: Minor
> Attachments: OFBIZ-7354-Screen-Shot.png, OFBIZ-7354.patch
>
>
> TimeSheet list has editable fields, it should be display fields. This list is 
> intended to display information about timesheets and any timesheet can be 
> edited from their view page.
> Please find attached screenshot
> Steps to regenerate:
> 1. Go to https://localhost:8443/workeffort/control/FindTimesheet
> 2. Find timesheet, list with editable fields will display.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7354) TimeSheet list has editable fields, it should be display fields

2016-06-15 Thread Amardeep Singh Jhajj (JIRA)

Amardeep Singh Jhajj created OFBIZ-7354:
---

 Summary: TimeSheet list has editable fields, it should be display 
fields
 Key: OFBIZ-7354
 URL: https://issues.apache.org/jira/browse/OFBIZ-7354
 Project: OFBiz
  Issue Type: Improvement
  Components: workeffort
Affects Versions: Release Branch 15.12, Trunk, Release Branch 14.12, 
Release Branch 13.07
Reporter: Amardeep Singh Jhajj
Assignee: Amardeep Singh Jhajj
Priority: Minor


TimeSheet list has editable fields, it should be display fields. This list is 
intended to display information about timesheets and any timesheet can be 
edited from their view page.

Please find attached screenshot

Steps to regenerate:

1. Go to https://localhost:8443/workeffort/control/FindTimesheet
2. Find timesheet, list with editable fields will display.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7353) Party : Arrange UI Labels in alphabetic order according to best practice.

2016-06-15 Thread Shivangi Tanwar (JIRA)

Shivangi Tanwar created OFBIZ-7353:
--

 Summary: Party : Arrange UI Labels in alphabetic order according 
to best practice.
 Key: OFBIZ-7353
 URL: https://issues.apache.org/jira/browse/OFBIZ-7353
 Project: OFBiz
  Issue Type: Sub-task
  Components: party
Affects Versions: Trunk
Reporter: Shivangi Tanwar
Assignee: Shivangi Tanwar
Priority: Minor
 Fix For: Trunk






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7317) Net Before Overhead Report is not working

2016-06-15 Thread Rohit Koushal (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331674#comment-15331674
 ] 

Rohit Koushal commented on OFBIZ-7317:
--

Found out various problem  under this report
1. This report depends on demo data provided under the SalesOrderItems 
applications/order/data/SalesOrderDemoData.xml.
2. This report have lots of hard coded check and values.

>  Net Before Overhead Report is not working
> --
>
> Key: OFBIZ-7317
> URL: https://issues.apache.org/jira/browse/OFBIZ-7317
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order, specialpurpose/birt
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>
>  Net Before Overhead Report is not working
> Screen : 
> https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions
> Section : Net Before Overhead Report 
> Getting error like 
> {code}
>[java] 
> org.eclipse.birt.report.engine.api.impl.ParameterValidationException: The 
> type of parameter "DateYear" is expected as "integer", not "java.lang.String".
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.validateParameterValueType(EngineTask.java:940)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.validateAbstractScalarParameter(EngineTask.java:862)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.access$0(EngineTask.java:789)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask$ParameterValidationVisitor.visitScalarParameter(EngineTask.java:706)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask$ParameterVisitor.visit(EngineTask.java:1531)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.doValidateParameters(EngineTask.java:692)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.RunAndRenderTask.doRun(RunAndRenderTask.java:95)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.RunAndRenderTask.run(RunAndRenderTask.java:77)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at org.ofbiz.birt.BirtWorker.exportReport(BirtWorker.java:143) 
> ~[ofbiz-birt.jar:?]
>  [java]   at 
> org.ofbiz.birt.webapp.view.BirtViewHandler.render(BirtViewHandler.java:118) 
> ~[ofbiz-birt.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:1001) 
> ~[ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:653) 
> ~[ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) 
> [ofbiz-webapp.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:622) 
> [servlet-api-3.1.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) 
> [servlet-api-3.1.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:323) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:212)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:106)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:141) 
> [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79) 
> [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:88)
>

[jira] [Commented] (OFBIZ-7339) Replace EntityUtilProperties getPropertyValue method with correct method calls

2016-06-15 Thread Rishi Solanki (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331671#comment-15331671
 ] 

Rishi Solanki commented on OFBIZ-7339:
--

I would say to be safer side we will check it just after your commit.

> Replace EntityUtilProperties getPropertyValue method with correct method calls
> --
>
> Key: OFBIZ-7339
> URL: https://issues.apache.org/jira/browse/OFBIZ-7339
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, framework, manufacturing, party, product, 
> securityext, specialpurpose/ecommerce, specialpurpose/lucene, 
> specialpurpose/passport, workeffort
>Affects Versions: Trunk
>Reporter: Rishi Solanki
> Attachments: EntityUtilProperties.patch
>
>
> In current OFBiz system at many places many methods implemented but not used 
> as per their purpose. One example is in EntityUtilProperties we have 
> getPropertyAsInteger() and getPropertyAsBigDecimal() and other methods which 
> returns specific type data. But at most places system uses getPropertyValue() 
> which returns string and then do explicit conversions.
> System should use proper methods for which they have been implemented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6386) compareBigDecimals in org.ofbiz.minilang.method.conditional.Compare does not compare certain values correctly


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6386:
---
Description: 
Moving the conversation from OFBIZ-6291 to this issue.

compareBigDecimals scales down and rounds up meaning you lose information and 
the comparison result is not as expected

  was:
Moving the conversation from https://issues.apache.org/jira/browse/OFBIZ-6291 
to this issue.

compareBigDecimals scales down and rounds up meaning you lose information and 
the comparison result is not as expected


> compareBigDecimals in org.ofbiz.minilang.method.conditional.Compare does not 
> compare certain values correctly
> -
>
> Key: OFBIZ-6386
> URL: https://issues.apache.org/jira/browse/OFBIZ-6386
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Mridul Pathak
>Priority: Minor
> Attachments: compareBigDecimals.png, v1.patch, v2.patch
>
>
> Moving the conversation from OFBIZ-6291 to this issue.
> compareBigDecimals scales down and rounds up meaning you lose information and 
> the comparison result is not as expected



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7346) connection pooling not working


[ 
https://issues.apache.org/jira/browse/OFBIZ-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331648#comment-15331648
 ] 

Jacques Le Roux commented on OFBIZ-7346:


Thanks Gareth,

I can confirm I see this behaviour (connection pooling not working, ie 
connections not being reused and dissapearing) while using the 
bq. Select * from pg_stat_activity  where usename='ofbiz'
request in Postgres.

With the patch applied I was able to generate 10 used pooled connections using 
OWAS Zap running against ecommerce and catalog, and simultaneously JMeter on 
catalog. After shutting them, the connections stay visible and IDLE, so ready 
to be reused. So the patch clearly fixes this issue which is at least 
reproductible in Postgres (version 9.1 with last driver loaded with Ant+Ivy) 
and easily visible in pdAdmin III (I use 1.18.1)

So far I see no reasons to not commit, but as Gareth is cautious I'll be so and 
check that no issues could creep in.

Ah, I also noticed that contrary what I saw before applying the patch, when I 
run the
bq. Select * from pg_stat_activity  where usename='ofbiz'
query, before running any request against OFBiz, I see 2 connections ready to 
use. Before applying the patch (and after OFBIZ-7344 beind fixed) nothing 
appears and this does not respect the *pool-minsize="2"* parameter of the 
* connection pooling not working
> --
>
> Key: OFBIZ-7346
> URL: https://issues.apache.org/jira/browse/OFBIZ-7346
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: DBCPConnectionFactory.patch
>
>
> Connection pooling does not seem to work. Connections are created fine but as 
> the close() method is called (outside of transaction) or the transaction is 
> committed the connections are closed to the db server and not returned to the 
> pool.
> I believe the issue is with 
> org.apache.commons.dbcp2.PoolableConnectionFactory passivateObject method. 
> This will call rollback() when rollbackOnReturn is set to true even if the 
> transaction is committed. This is because any connection wrappers extending 
> org.apache.commons.dbcp2.DelegatingConnection cache autoCommit status. At 
> some point, this cached autoCommit is different from the underlying 
> connection autoCommit. The rollback() method will throw an exception and the 
> connection is destroyed rather than put back to the pool
> Environment this has been tested on:
> ofbiz: rev 1725574 and latest trunk (as of 2016-06-14)
> db: postgresql 9.1
> jdbc driver: postgresql-9.3-1101.jdbc4
> os: linux and windows
> I have asked dev ml for others to check this with other dbs. Jacques has test 
> with postgres but could not see this behaviour



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7346) connection pooling not working


[ 
https://issues.apache.org/jira/browse/OFBIZ-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331646#comment-15331646
 ] 

Jacques Le Roux commented on OFBIZ-7346:


Thanks Gareth,

I can confirm I see this behaviour (connection pooling not working, ie 
connections not being reused and dissapearing) while using the 
bq. Select * from pg_stat_activity  where usename='ofbiz'
request in Postgres.

With the patch applied I was able to generate 10 used pooled connections using 
OWAS Zap running against ecommerce and catalog, and simultaneously JMeter on 
catalog. After shutting them, the connections stay visible and IDLE, so ready 
to be reused. So the patch clearly fixes this issue which is at least 
reproductible in Postgres (version 9.1 with last driver loaded with Ant+Ivy) 
and easily visible in pdAdmin III (I use 1.18.1)

So far I see no reasons to not commit, but as Gareth is cautious I'll be so and 
check that no issues could creep in.

Ah, I also noticed that contrary what I saw before applying the patch, when I 
run the
bq. Select * from pg_stat_activity  where usename='ofbiz'
query, before running any request against OFBiz, I see 2 connections ready to 
use. Before applying the patch (and after OFBIZ-7344 beind fixed) nothing 
appears and this does not respect the *pool-minsize="2"* parameter of the 
* connection pooling not working
> --
>
> Key: OFBIZ-7346
> URL: https://issues.apache.org/jira/browse/OFBIZ-7346
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: DBCPConnectionFactory.patch
>
>
> Connection pooling does not seem to work. Connections are created fine but as 
> the close() method is called (outside of transaction) or the transaction is 
> committed the connections are closed to the db server and not returned to the 
> pool.
> I believe the issue is with 
> org.apache.commons.dbcp2.PoolableConnectionFactory passivateObject method. 
> This will call rollback() when rollbackOnReturn is set to true even if the 
> transaction is committed. This is because any connection wrappers extending 
> org.apache.commons.dbcp2.DelegatingConnection cache autoCommit status. At 
> some point, this cached autoCommit is different from the underlying 
> connection autoCommit. The rollback() method will throw an exception and the 
> connection is destroyed rather than put back to the pool
> Environment this has been tested on:
> ofbiz: rev 1725574 and latest trunk (as of 2016-06-14)
> db: postgresql 9.1
> jdbc driver: postgresql-9.3-1101.jdbc4
> os: linux and windows
> I have asked dev ml for others to check this with other dbs. Jacques has test 
> with postgres but could not see this behaviour



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7344) db connections remain open and unused on startup


[ 
https://issues.apache.org/jira/browse/OFBIZ-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331644#comment-15331644
 ] 

Jacques Le Roux commented on OFBIZ-7344:


I checked this issue exists in R13.07, as I said not a biggie

> db connections remain open and unused on startup
> 
>
> Key: OFBIZ-7344
> URL: https://issues.apache.org/jira/browse/OFBIZ-7344
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
> Attachments: DatabaseUtil.patch
>
>
> When ofbiz starts and checks the database, it will leave open connections and 
> will not get reused.
> If you run Check/Update database from webtools, you can see a new connection 
> is created for your selected group
> As far as I can tell, the problem lies in DatabaseUtil.getDatabaseMetaData. 
> If the parameter connection is null, a new connection object is created but 
> not closed (like any resource should be!)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7180) Completed Service Order Items are being allowed to be edited over Approved PO


[ 
https://issues.apache.org/jira/browse/OFBIZ-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331636#comment-15331636
 ] 

Divesh Dutta commented on OFBIZ-7180:
-

[~swash78] , you can test this issue and close it. I am assigning it to you for 
closure. 

> Completed Service Order Items are being allowed to be edited over Approved PO 
> --
>
> Key: OFBIZ-7180
> URL: https://issues.apache.org/jira/browse/OFBIZ-7180
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>Priority: Critical
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7180.patch, SV_1.png, SV_2.png, SV_3.png
>
>
> Currently PO line items having service type products are completed on 
> Approval itself. But system still allows the Completed service items to be 
> edited over any Approved PO (e.g. if PO has both service and finished good 
> items that still need to be received). This lead to difference in invoice and 
> order valuation.
> We could possibly restrict the editing for any completed order items via Edit 
> Items option over Order view.
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7180) Completed Service Order Items are being allowed to be edited over Approved PO


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7180:

Assignee: Swapnil Shah  (was: Divesh Dutta)

> Completed Service Order Items are being allowed to be edited over Approved PO 
> --
>
> Key: OFBIZ-7180
> URL: https://issues.apache.org/jira/browse/OFBIZ-7180
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>Priority: Critical
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7180.patch, SV_1.png, SV_2.png, SV_3.png
>
>
> Currently PO line items having service type products are completed on 
> Approval itself. But system still allows the Completed service items to be 
> edited over any Approved PO (e.g. if PO has both service and finished good 
> items that still need to be received). This lead to difference in invoice and 
> order valuation.
> We could possibly restrict the editing for any completed order items via Edit 
> Items option over Order view.
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7180) Completed Service Order Items are being allowed to be edited over Approved PO


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7180:

Fix Version/s: 15.12.01
   14.12.01

> Completed Service Order Items are being allowed to be edited over Approved PO 
> --
>
> Key: OFBIZ-7180
> URL: https://issues.apache.org/jira/browse/OFBIZ-7180
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
>Priority: Critical
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7180.patch, SV_1.png, SV_2.png, SV_3.png
>
>
> Currently PO line items having service type products are completed on 
> Approval itself. But system still allows the Completed service items to be 
> edited over any Approved PO (e.g. if PO has both service and finished good 
> items that still need to be received). This lead to difference in invoice and 
> order valuation.
> We could possibly restrict the editing for any completed order items via Edit 
> Items option over Order view.
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (OFBIZ-7180) Completed Service Order Items are being allowed to be edited over Approved PO


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta resolved OFBIZ-7180.
-
Resolution: Fixed

> Completed Service Order Items are being allowed to be edited over Approved PO 
> --
>
> Key: OFBIZ-7180
> URL: https://issues.apache.org/jira/browse/OFBIZ-7180
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
>Priority: Critical
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7180.patch, SV_1.png, SV_2.png, SV_3.png
>
>
> Currently PO line items having service type products are completed on 
> Approval itself. But system still allows the Completed service items to be 
> edited over any Approved PO (e.g. if PO has both service and finished good 
> items that still need to be received). This lead to difference in invoice and 
> order valuation.
> We could possibly restrict the editing for any completed order items via Edit 
> Items option over Order view.
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7180) Completed Service Order Items are being allowed to be edited over Approved PO


[ 
https://issues.apache.org/jira/browse/OFBIZ-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331633#comment-15331633
 ] 

Divesh Dutta commented on OFBIZ-7180:
-

Thanks [~upadhyay.ratnesh] for your patch . Its in trunk: r1748567
branch15.12 : r1748570
branch14.12 : r1748573


> Completed Service Order Items are being allowed to be edited over Approved PO 
> --
>
> Key: OFBIZ-7180
> URL: https://issues.apache.org/jira/browse/OFBIZ-7180
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
>Priority: Critical
> Attachments: OFBIZ-7180.patch, SV_1.png, SV_2.png, SV_3.png
>
>
> Currently PO line items having service type products are completed on 
> Approval itself. But system still allows the Completed service items to be 
> edited over any Approved PO (e.g. if PO has both service and finished good 
> items that still need to be received). This lead to difference in invoice and 
> order valuation.
> We could possibly restrict the editing for any completed order items via Edit 
> Items option over Order view.
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6386) compareBigDecimals in org.ofbiz.minilang.method.conditional.Compare does not compare certain values correctly

2016-06-15 Thread Jacopo Cappellato (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331624#comment-15331624
 ] 

Jacopo Cappellato commented on OFBIZ-6386:
--

I have reviewed the comments, the code and the patches provided by 
[~gareth.carter] and I agree with him and with [~mridul.pathak] that we should 
commit the first patch.


> compareBigDecimals in org.ofbiz.minilang.method.conditional.Compare does not 
> compare certain values correctly
> -
>
> Key: OFBIZ-6386
> URL: https://issues.apache.org/jira/browse/OFBIZ-6386
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Mridul Pathak
>Priority: Minor
> Attachments: compareBigDecimals.png, v1.patch, v2.patch
>
>
> Moving the conversation from https://issues.apache.org/jira/browse/OFBIZ-6291 
> to this issue.
> compareBigDecimals scales down and rounds up meaning you lose information and 
> the comparison result is not as expected



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7352) Do my sales invoice will print along with Barcode at bottom


[ 
https://issues.apache.org/jira/browse/OFBIZ-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331625#comment-15331625
 ] 

Jacques Le Roux commented on OFBIZ-7352:


We know you Deepak, we know you are not this kind of man :)

> Do my sales invoice will print along with Barcode at bottom
> ---
>
> Key: OFBIZ-7352
> URL: https://issues.apache.org/jira/browse/OFBIZ-7352
> Project: OFBiz
>  Issue Type: Task
>  Components: order
>Reporter: COTATEX
>Priority: Minor
>
> Dear Support,
> I would need to print a sales invoice along with Barcode EPN-13 format or QR 
> Code in the paper. Do it will be possible without customization any standard 
> functionality exists?
> Thanks.
> Sathish



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7180) Completed Service Order Items are being allowed to be edited over Approved PO


[ 
https://issues.apache.org/jira/browse/OFBIZ-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331605#comment-15331605
 ] 

Divesh Dutta commented on OFBIZ-7180:
-

Okay, I looked more at code and it seems that we cannot use itemStatusOkay as 
value of this flag is dependent on values of orderItemShipGroupAssoc record 
which is inside the iterator. And itemStatusOkay is not available when we are 
checking condition for price change. So patch looks good to me.  

> Completed Service Order Items are being allowed to be edited over Approved PO 
> --
>
> Key: OFBIZ-7180
> URL: https://issues.apache.org/jira/browse/OFBIZ-7180
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
>Priority: Critical
> Attachments: OFBIZ-7180.patch, SV_1.png, SV_2.png, SV_3.png
>
>
> Currently PO line items having service type products are completed on 
> Approval itself. But system still allows the Completed service items to be 
> edited over any Approved PO (e.g. if PO has both service and finished good 
> items that still need to be received). This lead to difference in invoice and 
> order valuation.
> We could possibly restrict the editing for any completed order items via Edit 
> Items option over Order view.
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7180) Completed Service Order Items are being allowed to be edited over Approved PO


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7180:

Affects Version/s: (was: Release Branch 14.12)

> Completed Service Order Items are being allowed to be edited over Approved PO 
> --
>
> Key: OFBIZ-7180
> URL: https://issues.apache.org/jira/browse/OFBIZ-7180
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
>Priority: Critical
> Attachments: OFBIZ-7180.patch, SV_1.png, SV_2.png, SV_3.png
>
>
> Currently PO line items having service type products are completed on 
> Approval itself. But system still allows the Completed service items to be 
> edited over any Approved PO (e.g. if PO has both service and finished good 
> items that still need to be received). This lead to difference in invoice and 
> order valuation.
> We could possibly restrict the editing for any completed order items via Edit 
> Items option over Order view.
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7352) Do my sales invoice will print along with Barcode at bottom


[ 
https://issues.apache.org/jira/browse/OFBIZ-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331584#comment-15331584
 ] 

Deepak Dixit edited comment on OFBIZ-7352 at 6/15/16 12:04 PM:
---

Thanks Jacques for details, 
I wrote too short it looks like too rude but its not true :)


was (Author: deepak.dixit):
Thanks Jacques for details, 
I wrote too short it looks like too rude buts its not true :)

> Do my sales invoice will print along with Barcode at bottom
> ---
>
> Key: OFBIZ-7352
> URL: https://issues.apache.org/jira/browse/OFBIZ-7352
> Project: OFBiz
>  Issue Type: Task
>  Components: order
>Reporter: COTATEX
>Priority: Minor
>
> Dear Support,
> I would need to print a sales invoice along with Barcode EPN-13 format or QR 
> Code in the paper. Do it will be possible without customization any standard 
> functionality exists?
> Thanks.
> Sathish



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7350) Manage filters in lookup auto completion


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles STELTZLEN updated OFBIZ-7350:
-
Attachment: OFBIZ-7350.patch
OFBIZ-7350.13.07.patch

> Manage filters in lookup auto completion
> 
>
> Key: OFBIZ-7350
> URL: https://issues.apache.org/jira/browse/OFBIZ-7350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Charles STELTZLEN
>Priority: Minor
> Attachments: OFBIZ-7350.13.07.patch, OFBIZ-7350.patch
>
>
> On form lookup, we can specify target parameters to pass them to the lookup 
> screen and do filtered searches with these parameters. It works fine when you 
> click on lookup button. But when you start to write something in lookup 
> input, these parameters are not passed to the ajax auto-complete system. So, 
> the results are not filtered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7350) Manage filters in lookup auto completion


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles STELTZLEN updated OFBIZ-7350:
-
Attachment: (was: lookup-improvement_13.07.patch)

> Manage filters in lookup auto completion
> 
>
> Key: OFBIZ-7350
> URL: https://issues.apache.org/jira/browse/OFBIZ-7350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Charles STELTZLEN
>Priority: Minor
> Attachments: OFBIZ-7350.13.07.patch, OFBIZ-7350.patch
>
>
> On form lookup, we can specify target parameters to pass them to the lookup 
> screen and do filtered searches with these parameters. It works fine when you 
> click on lookup button. But when you start to write something in lookup 
> input, these parameters are not passed to the ajax auto-complete system. So, 
> the results are not filtered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7180) Completed Service Order Items are being allowed to be edited over Approved PO


[ 
https://issues.apache.org/jira/browse/OFBIZ-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331588#comment-15331588
 ] 

Divesh Dutta commented on OFBIZ-7180:
-

I have tested this for sales order and purchase order both, and its working 
fine. One minor improvement in patch is that you have added new condition for 
price change option:

{code}
 !(orderItem.statusId == "ITEM_CANCELLED" || orderItem.statusId == 
"ITEM_COMPLETED")
{code}

we can use itemStatusOkay flag available in same file for this condition. Rest 
all looks good. Once you make these change, I can commit the code. 

> Completed Service Order Items are being allowed to be edited over Approved PO 
> --
>
> Key: OFBIZ-7180
> URL: https://issues.apache.org/jira/browse/OFBIZ-7180
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 14.12
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
>Priority: Critical
> Attachments: OFBIZ-7180.patch, SV_1.png, SV_2.png, SV_3.png
>
>
> Currently PO line items having service type products are completed on 
> Approval itself. But system still allows the Completed service items to be 
> edited over any Approved PO (e.g. if PO has both service and finished good 
> items that still need to be received). This lead to difference in invoice and 
> order valuation.
> We could possibly restrict the editing for any completed order items via Edit 
> Items option over Order view.
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7352) Do my sales invoice will print along with Barcode at bottom


[ 
https://issues.apache.org/jira/browse/OFBIZ-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331584#comment-15331584
 ] 

Deepak Dixit commented on OFBIZ-7352:
-

Thanks Jacques for details, 
I wrote too short it looks like too rude buts its not true :)

> Do my sales invoice will print along with Barcode at bottom
> ---
>
> Key: OFBIZ-7352
> URL: https://issues.apache.org/jira/browse/OFBIZ-7352
> Project: OFBiz
>  Issue Type: Task
>  Components: order
>Reporter: COTATEX
>Priority: Minor
>
> Dear Support,
> I would need to print a sales invoice along with Barcode EPN-13 format or QR 
> Code in the paper. Do it will be possible without customization any standard 
> functionality exists?
> Thanks.
> Sathish



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7352) Do my sales invoice will print along with Barcode at bottom


[ 
https://issues.apache.org/jira/browse/OFBIZ-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331577#comment-15331577
 ] 

Jacques Le Roux commented on OFBIZ-7352:


Yes please use rather user ML for such questions, see why with link above 
(thanks Deepak)

You will get a better support and it's more fair to share with everybody
The wider the audience the better the answers you might get

Thanks

Jacques


> Do my sales invoice will print along with Barcode at bottom
> ---
>
> Key: OFBIZ-7352
> URL: https://issues.apache.org/jira/browse/OFBIZ-7352
> Project: OFBiz
>  Issue Type: Task
>  Components: order
>Reporter: COTATEX
>Priority: Minor
>
> Dear Support,
> I would need to print a sales invoice along with Barcode EPN-13 format or QR 
> Code in the paper. Do it will be possible without customization any standard 
> functionality exists?
> Thanks.
> Sathish



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7349) Not able to add agreement term just after adding new or updating existing agreement's term


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey closed OFBIZ-7349.


> Not able to add agreement term just after adding new or updating existing 
> agreement's term
> --
>
> Key: OFBIZ-7349
> URL: https://issues.apache.org/jira/browse/OFBIZ-7349
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
> Fix For: 15.12.01
>
> Attachments: OFBIZ-7349.patch
>
>
> Steps to regenerate:
> 1. Go to Agreement term page- 
> https://localhost:8443/accounting/control/EditAgreementTerms?agreementId=8000
> 2. Add one agreement term or update already present term.
> 3. Now again try to add new agreement term, error occurs "Value found with 
> Ids, cannot create new".
> This error should not occur as i was trying to add new term, agreement term 
> should create with new sequence. This works when we refresh the page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7112) EntityUtilProperties


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7112:
---
Fix Version/s: Upcoming Branch
   Issue Type: Improvement  (was: Bug)

Thanks Wai,

Your patch is in trunk at revision: 1748560 .

I don't consider this a bug but an improvement. I have changed the issue 
description accordingly and did not backport


> EntityUtilProperties
> 
>
> Key: OFBIZ-7112
> URL: https://issues.apache.org/jira/browse/OFBIZ-7112
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7112.patch, OFBIZ-7112.patch, OFBIZ-7112.patch, 
> OFBIZ-7112.patch
>
>
> Ofbiz reads properties from either a properties file or the 
> entity:SystemProperty. The way it works previously is that ofbiz reads from 
> the entity:SystemProperty first and if there is no value associated with the 
> target propertyname, it would then locate the value from the relevant 
> properties file.
> In other words, if there is a database entry for a property, the database 
> entry should override the associated properties file.
> The issue is that if a database entry exist but the value is empty, it would 
> look for a value from the properties file.  It should not do so.  If a 
> database entry exists for the propertyname of interest, the value should be 
> taken from the database even if it holds an empty value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (OFBIZ-7349) Not able to add agreement term just after adding new or updating existing agreement's term


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey resolved OFBIZ-7349.
--
   Resolution: Fixed
Fix Version/s: 15.12.01

Thanks [~amardeepsj] for the contribution. 
Patch committed to trunk r1748559 and R15.12 r1748562.
R14.12 and R13.07 not concerned.

> Not able to add agreement term just after adding new or updating existing 
> agreement's term
> --
>
> Key: OFBIZ-7349
> URL: https://issues.apache.org/jira/browse/OFBIZ-7349
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
> Fix For: 15.12.01
>
> Attachments: OFBIZ-7349.patch
>
>
> Steps to regenerate:
> 1. Go to Agreement term page- 
> https://localhost:8443/accounting/control/EditAgreementTerms?agreementId=8000
> 2. Add one agreement term or update already present term.
> 3. Now again try to add new agreement term, error occurs "Value found with 
> Ids, cannot create new".
> This error should not occur as i was trying to add new term, agreement term 
> should create with new sequence. This works when we refresh the page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

RE: Proposal to delete stale java files

2016-06-15 Thread Taher Alkhateeb

Hi Mridul,

Ahh I see that makes sense. Yeah sure we put non-compiling stuff regardless of 
origin in specialpurpose/reference and the rest in their own components.

Regards,

-Original Message-
From: Mridul Pathak [mailto:mridul.pat...@hotwaxsystems.com] 
Sent: 15 June 2016 14:19
To: dev@ofbiz.apache.org
Cc: Mridul Pathak
Subject: Re: Proposal to delete stale java files

Hi Taher,

I would like to make sure that I am understanding your proposal correctly.

Are you proposing to create a specialpurpose component named “reference” which 
would have all the code that can be referenced but not compiled, no matter what 
domain it is?

If that is the case, we have discussed about moving shipping integrations to 
specialpurpose component as well, and that code doesn’t have the compilation or 
library reference issues as listed in this thread, so I think that should go in 
it's own component.

--
Thanks & Regards,
Mridul Pathak
Senior Manager
HotWax Systems
http://www.hotwaxsystems.com

> On Jun 15, 2016, at 3:01 PM, Taher Alkhateeb  
> wrote:
> 
> Hi Mridul,
> 
> How about reference/paymentext and reference/whatever-else-you-want? 
> So the top level directory is called reference to indicate to people 
> that this is just for reference and will not compile. Also, this way 
> we keep all reference material under one directory to avoid polluting 
> the directory tree. My 2 cents.
> 
> Regards,
> 
> Taher Alkhateeb
> 
> On Wed, Jun 15, 2016 at 12:27 PM, Mridul Pathak < 
> mridul.pat...@hotwaxsystems.com > 
> wrote:
> 
>> Hi Taher,
>> 
>> Sure, I’ll take care of deleting rest of the files as well.
>> 
>> Also, we could name these specialpurpose component(s) as paymentext, etc.
>> and mention in README file that these are extensions to OFBiz and 
>> does not compile directly.
>> 
>> --
>> Thanks & Regards,
>> Mridul Pathak
>> HotWax Systems
>> http://www.hotwaxsystems.com
>> 
>>> On Jun 15, 2016, at 2:37 PM, Taher Alkhateeb 
>>> 
>> wrote:
>>> 
>>> Hi Mridul and everyone,
>>> 
>>> Thank you all for your inputs. May I also ask you Mridul while you 
>>> are
>> at it to delete the rest of the files so the whole task resides with 
>> you to avoid crossing any wires.
>>> 
>>> Also, I suggest to name that component into something like archives 
>>> or
>> reference and put a README file that says this component does not 
>> compile and it holds this stuff. This way it is easy to isolate that 
>> component from the build system.
>>> 
>>> Thank you all again for your contributions.
>>> 
>>> Taher Alkhateeb
>>> 
>>> -Original Message-
>>> From: Mridul Pathak [mailto:mridul.pat...@hotwaxsystems.com 
>>>  > mridul.pat...@hotwaxsystems.com 
>> >]
>>> Sent: 15 June 2016 11:09
>>> To: dev@ofbiz.apache.org  
>>> >
>>> Cc: Mridul Pathak
>>> Subject: Re: Proposal to delete stale java files
>>> 
>>> I would like to volunteer for this change (moving payment, shipping 
>>> and
>> tax integrations to specialpurpose).
>>> 
>>> --
>>> Mridul Pathak
>>> 
>>> On Wednesday 15 June 2016, Jacopo Cappellato <
>> jacopo.cappell...@hotwaxsystems.com 
>> > wrote:
>>> 
 Based on the new comments it seems like that we could isolate the 
 shipment, payment and tax integration classes (and artifacts that 
 use
 them) into their own specialpurpose components (waiting for a 
 better pluggable components architecture); they will not be 
 compiled by default but each component will have its own readme 
 file containing instructions about how to deploy and use them.
 As regards the JasperReports*, JRE* and openoffice ones I think 
 they can go to Attic since they are old and unmaintained.
 
 Does it make sense? Any volunteers to create the new specialpurpose 
 components and upgrade/isolate the shipment/payment/tax integration 
 classes into them?
 
 Jacopo
 
 On Wed, Jun 15, 2016 at 9:32 AM, Hans Bakker 
  
 >
>> >
 wrote:
 
> +1
> 
> 
> On 15/06/16 13:30, Ashish Vijaywargiya wrote:
> 
>> I would prefer to keep Tax and Third Party Payment gateway 
>> files(The
 files
>> that does exists inside cybersource, ideal, orbital, paypal, 
>> securepay, verisign etc). If you see some problems in those code 
>> base, like code
 base
>> is not updated based on latest changes then we can update those files.
>> Those files might have been used by so many users that we can't 
>> know because we are doing this conversation on Dev mailing list. 
>> We should

Re: Proposal to delete stale java files

Hi Taher,

I would like to make sure that I am understanding your proposal correctly.

Are you proposing to create a specialpurpose component named “reference” which 
would have all the code that can be referenced but not compiled, no matter what 
domain it is?

If that is the case, we have discussed about moving shipping integrations to 
specialpurpose component as well, and that code doesn’t have the compilation or 
library reference issues as listed in this thread, so I think that should go in 
it's own component.

--
Thanks & Regards,
Mridul Pathak
Senior Manager
HotWax Systems
http://www.hotwaxsystems.com

> On Jun 15, 2016, at 3:01 PM, Taher Alkhateeb  
> wrote:
> 
> Hi Mridul,
> 
> How about reference/paymentext and reference/whatever-else-you-want? So the
> top level directory is called reference to indicate to people that this is
> just for reference and will not compile. Also, this way we keep all
> reference material under one directory to avoid polluting the directory
> tree. My 2 cents.
> 
> Regards,
> 
> Taher Alkhateeb
> 
> On Wed, Jun 15, 2016 at 12:27 PM, Mridul Pathak <
> mridul.pat...@hotwaxsystems.com > 
> wrote:
> 
>> Hi Taher,
>> 
>> Sure, I’ll take care of deleting rest of the files as well.
>> 
>> Also, we could name these specialpurpose component(s) as paymentext, etc.
>> and mention in README file that these are extensions to OFBiz and does not
>> compile directly.
>> 
>> --
>> Thanks & Regards,
>> Mridul Pathak
>> HotWax Systems
>> http://www.hotwaxsystems.com
>> 
>>> On Jun 15, 2016, at 2:37 PM, Taher Alkhateeb 
>> wrote:
>>> 
>>> Hi Mridul and everyone,
>>> 
>>> Thank you all for your inputs. May I also ask you Mridul while you are
>> at it to delete the rest of the files so the whole task resides with you to
>> avoid crossing any wires.
>>> 
>>> Also, I suggest to name that component into something like archives or
>> reference and put a README file that says this component does not compile
>> and it holds this stuff. This way it is easy to isolate that component from
>> the build system.
>>> 
>>> Thank you all again for your contributions.
>>> 
>>> Taher Alkhateeb
>>> 
>>> -Original Message-
>>> From: Mridul Pathak [mailto:mridul.pat...@hotwaxsystems.com 
>>>  > mridul.pat...@hotwaxsystems.com >]
>>> Sent: 15 June 2016 11:09
>>> To: dev@ofbiz.apache.org  
>>> >
>>> Cc: Mridul Pathak
>>> Subject: Re: Proposal to delete stale java files
>>> 
>>> I would like to volunteer for this change (moving payment, shipping and
>> tax integrations to specialpurpose).
>>> 
>>> --
>>> Mridul Pathak
>>> 
>>> On Wednesday 15 June 2016, Jacopo Cappellato <
>> jacopo.cappell...@hotwaxsystems.com 
>> > wrote:
>>> 
 Based on the new comments it seems like that we could isolate the
 shipment, payment and tax integration classes (and artifacts that use
 them) into their own specialpurpose components (waiting for a better
 pluggable components architecture); they will not be compiled by
 default but each component will have its own readme file containing
 instructions about how to deploy and use them.
 As regards the JasperReports*, JRE* and openoffice ones I think they
 can go to Attic since they are old and unmaintained.
 
 Does it make sense? Any volunteers to create the new specialpurpose
 components and upgrade/isolate the shipment/payment/tax integration
 classes into them?
 
 Jacopo
 
 On Wed, Jun 15, 2016 at 9:32 AM, Hans Bakker
  
 >
>> >
 wrote:
 
> +1
> 
> 
> On 15/06/16 13:30, Ashish Vijaywargiya wrote:
> 
>> I would prefer to keep Tax and Third Party Payment gateway
>> files(The
 files
>> that does exists inside cybersource, ideal, orbital, paypal,
>> securepay, verisign etc). If you see some problems in those code
>> base, like code
 base
>> is not updated based on latest changes then we can update those files.
>> Those files might have been used by so many users that we can't
>> know because we are doing this conversation on Dev mailing list. We
>> should
 not
>> remove those files.
>> 
>> --
>> Kind Regards
>> Ashish Vijaywargiya
>> HotWax Systems - est. 1997
>> 
>> On Tue, Jun 14, 2016 at 7:40 PM, Taher Alkhateeb <
>> slidingfilame...@gmail.com 
>> 
>>> wrote:
>>> 
>> 
>> Hi Everyone,
>>> 
>>> I cannot actually believe it but while I was working on a project
>>> (I
 will
>>> announce later) I

[jira] [Closed] (OFBIZ-7341) Contents are not rendered on view profile screen


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey closed OFBIZ-7341.


> Contents are not rendered on view profile screen
> 
>
> Key: OFBIZ-7341
> URL: https://issues.apache.org/jira/browse/OFBIZ-7341
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Mohammed Rehan Khan
>Assignee: Pranay Pandey
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7341-Release-13.07.patch, 
> OFBIZ-7341-Release-14.12.patch, OFBIZ-7341-Release-15.12.patch, 
> OFBIZ-7341.patch
>
>
> Steps to reproduce:
> 1) Go to eCommerce
> 2) Click on view profile screen
> 3) Add image or text type content for party in file manager section.
> 4) click on contenId or view link
> Result : 404 Not Found
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7344) db connections remain open and unused on startup

2016-06-15 Thread Gareth Carter (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331543#comment-15331543
 ] 

Gareth Carter edited comment on OFBIZ-7344 at 6/15/16 11:13 AM:


I tested again. Without the patch, the connections stayed idle even after a 
long period of time (~1 hour). With the patch, these disappear after ~10 mins. 
It may not be obvious that the connections stay idle and not reused after 
startup. But different environments could cause different behaviours. 

Atleast the patch fixes bad practice (not closing resources after use!)

Also, I would note I only noticed this issue because running the query 'select 
* from pg_stat_activity' showed idle connections established days before and 
query_start roughly the same as backend_start.

But anyway, thanks Jacques for committing and for testing as well


was (Author: gareth.carter):
I tested again. Without the patch, the connections stayed idle even after a 
long period of time (~1 hour). With the patch, these disappear after ~10 mins. 
It may not be obvious that the connections stay idle and not reused after 
startup. But different environments could cause different behaviours. 

Atleast the patch fixes bad practice (not closing resources after use!)

Also, I would note I only noticed this issue because running the query 'select 
* from pg_stat_activity' showed idle connections established days before and 
query_start roughly the same as backend_start.

> db connections remain open and unused on startup
> 
>
> Key: OFBIZ-7344
> URL: https://issues.apache.org/jira/browse/OFBIZ-7344
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
> Attachments: DatabaseUtil.patch
>
>
> When ofbiz starts and checks the database, it will leave open connections and 
> will not get reused.
> If you run Check/Update database from webtools, you can see a new connection 
> is created for your selected group
> As far as I can tell, the problem lies in DatabaseUtil.getDatabaseMetaData. 
> If the parameter connection is null, a new connection object is created but 
> not closed (like any resource should be!)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7349) Not able to add agreement term just after adding new or updating existing agreement's term


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey reassigned OFBIZ-7349:


Assignee: Pranay Pandey  (was: Amardeep Singh Jhajj)

> Not able to add agreement term just after adding new or updating existing 
> agreement's term
> --
>
> Key: OFBIZ-7349
> URL: https://issues.apache.org/jira/browse/OFBIZ-7349
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
> Attachments: OFBIZ-7349.patch
>
>
> Steps to regenerate:
> 1. Go to Agreement term page- 
> https://localhost:8443/accounting/control/EditAgreementTerms?agreementId=8000
> 2. Add one agreement term or update already present term.
> 3. Now again try to add new agreement term, error occurs "Value found with 
> Ids, cannot create new".
> This error should not occur as i was trying to add new term, agreement term 
> should create with new sequence. This works when we refresh the page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7344) db connections remain open and unused on startup

2016-06-15 Thread Gareth Carter (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331543#comment-15331543
 ] 

Gareth Carter commented on OFBIZ-7344:
--

I tested again. Without the patch, the connections stayed idle even after a 
long period of time (~1 hour). With the patch, these disappear after ~10 mins. 
It may not be obvious that the connections stay idle and not reused after 
startup. But different environments could cause different behaviours. 

Atleast the patch fixes bad practice (not closing resources after use!)

Also, I would note I only noticed this issue because running the query 'select 
* from pg_stat_activity' showed idle connections established days before and 
query_start roughly the same as backend_start.

> db connections remain open and unused on startup
> 
>
> Key: OFBIZ-7344
> URL: https://issues.apache.org/jira/browse/OFBIZ-7344
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
> Attachments: DatabaseUtil.patch
>
>
> When ofbiz starts and checks the database, it will leave open connections and 
> will not get reused.
> If you run Check/Update database from webtools, you can see a new connection 
> is created for your selected group
> As far as I can tell, the problem lies in DatabaseUtil.getDatabaseMetaData. 
> If the parameter connection is null, a new connection object is created but 
> not closed (like any resource should be!)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7352) Do my sales invoice will print along with Barcode at bottom


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-7352.
---
Resolution: Invalid

> Do my sales invoice will print along with Barcode at bottom
> ---
>
> Key: OFBIZ-7352
> URL: https://issues.apache.org/jira/browse/OFBIZ-7352
> Project: OFBiz
>  Issue Type: Task
>  Components: order
>Reporter: COTATEX
>Priority: Minor
>
> Dear Support,
> I would need to print a sales invoice along with Barcode EPN-13 format or QR 
> Code in the paper. Do it will be possible without customization any standard 
> functionality exists?
> Thanks.
> Sathish



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7352) Do my sales invoice will print along with Barcode at bottom


[ 
https://issues.apache.org/jira/browse/OFBIZ-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331530#comment-15331530
 ] 

Deepak Dixit commented on OFBIZ-7352:
-

Hi [~COTATEX]

Please ask question on user mailing list.
http://ofbiz.apache.org/mailing-lists.html


> Do my sales invoice will print along with Barcode at bottom
> ---
>
> Key: OFBIZ-7352
> URL: https://issues.apache.org/jira/browse/OFBIZ-7352
> Project: OFBiz
>  Issue Type: Task
>  Components: order
>Reporter: COTATEX
>Priority: Minor
>
> Dear Support,
> I would need to print a sales invoice along with Barcode EPN-13 format or QR 
> Code in the paper. Do it will be possible without customization any standard 
> functionality exists?
> Thanks.
> Sathish



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7344) db connections remain open and unused on startup


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7344.
--
   Resolution: Fixed
Fix Version/s: 15.12.01
   14.12.01

Thanks Gareth,

I was unable to "see a new connection is created for your selected group" when 
running "Check/Update database from webtools". But I tested with Postgres while 
and after discussing with you about this. I can confirm it works. After a 
review it's obvious that, when the connection is null, a finally for closing 
the new created connection was needed.

Your patch is in
trunk r1748543  
R15.12  r1748544
R14.12  r1748545
R13.07 since this is not a biggie and it's hard to backport by hand I let him 
as is



> db connections remain open and unused on startup
> 
>
> Key: OFBIZ-7344
> URL: https://issues.apache.org/jira/browse/OFBIZ-7344
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
> Attachments: DatabaseUtil.patch
>
>
> When ofbiz starts and checks the database, it will leave open connections and 
> will not get reused.
> If you run Check/Update database from webtools, you can see a new connection 
> is created for your selected group
> As far as I can tell, the problem lies in DatabaseUtil.getDatabaseMetaData. 
> If the parameter connection is null, a new connection object is created but 
> not closed (like any resource should be!)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7350) Manage filters in lookup auto completion


[ 
https://issues.apache.org/jira/browse/OFBIZ-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331498#comment-15331498
 ] 

Charles STELTZLEN commented on OFBIZ-7350:
--

Thanks Jacques. I'm working on it ;). I have some issues with git and svn 
patches. I will propose both patches.

> Manage filters in lookup auto completion
> 
>
> Key: OFBIZ-7350
> URL: https://issues.apache.org/jira/browse/OFBIZ-7350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Charles STELTZLEN
>Priority: Minor
> Attachments: lookup-improvement_13.07.patch
>
>
> On form lookup, we can specify target parameters to pass them to the lookup 
> screen and do filtered searches with these parameters. It works fine when you 
> click on lookup button. But when you start to write something in lookup 
> input, these parameters are not passed to the ajax auto-complete system. So, 
> the results are not filtered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7339) Replace EntityUtilProperties getPropertyValue method with correct method calls


[ 
https://issues.apache.org/jira/browse/OFBIZ-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331493#comment-15331493
 ] 

Jacques Le Roux commented on OFBIZ-7339:


Rishi,

Thanks for you answer, Wai just updated OFBIZ-7112, I'll check and I guess 
commit very soon...

> Replace EntityUtilProperties getPropertyValue method with correct method calls
> --
>
> Key: OFBIZ-7339
> URL: https://issues.apache.org/jira/browse/OFBIZ-7339
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, framework, manufacturing, party, product, 
> securityext, specialpurpose/ecommerce, specialpurpose/lucene, 
> specialpurpose/passport, workeffort
>Affects Versions: Trunk
>Reporter: Rishi Solanki
> Attachments: EntityUtilProperties.patch
>
>
> In current OFBiz system at many places many methods implemented but not used 
> as per their purpose. One example is in EntityUtilProperties we have 
> getPropertyAsInteger() and getPropertyAsBigDecimal() and other methods which 
> returns specific type data. But at most places system uses getPropertyValue() 
> which returns string and then do explicit conversions.
> System should use proper methods for which they have been implemented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7350) Manage filters in lookup auto completion


[ 
https://issues.apache.org/jira/browse/OFBIZ-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331495#comment-15331495
 ] 

Jacques Le Roux commented on OFBIZ-7350:


Why only a patch for R13.07? We normally patch the trunk and backport, thanks.

> Manage filters in lookup auto completion
> 
>
> Key: OFBIZ-7350
> URL: https://issues.apache.org/jira/browse/OFBIZ-7350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Charles STELTZLEN
>Priority: Minor
> Attachments: lookup-improvement_13.07.patch
>
>
> On form lookup, we can specify target parameters to pass them to the lookup 
> screen and do filtered searches with these parameters. It works fine when you 
> click on lookup button. But when you start to write something in lookup 
> input, these parameters are not passed to the ajax auto-complete system. So, 
> the results are not filtered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to delete stale java files

2016-06-15 Thread Jacques Le Roux

Nicely said, thanks Sharan :)

Jacques

Le 15/06/2016 à 09:14, Sharan Foga a écrit :

Hi Everyone

If we don't compromise on this then we are going to make the re-factoring effort that Taher is driving even harder. If we want to clean the code
base (and I really think we do) then we need to take the some hard decisions. I'm sure that this won't be the last discussion over code removal so
let's start getting used to it.

The framework*must *have none of these dependencies (reverse or otherwise) so if we want to improve the quality of our code then the truth is - it
really needs to go. In fact, for me these type of integrations fall into the addons category so that is what I think we should be looking at. If we
need it then someone please re-write it as an OFBiz addon.

We are going to totally transform our current trunk and when we are finished it will be totally different to what it is today. In the meantime –
please remember that we currently have 2 un-released OFBiz versions 14.12 and 15.12 where the code we are talking about will remain as it is. This
will give us time to complete our transformation work and also time for our user base time to adjust to what will come.

Thanks
Sharan

On 15/06/16 09:01, Mridul Pathak wrote:
Yes, accounting/thirdparty has all the third party payment integrations supported by OFBiz. And, order/thridparty seems to have third party tax
integration. We should not be deleting these files. I think we should refactor these third party integration files, and move these integrations to
specialpurpose rather than keeping them with main applications. A bit off topic but shipping integrations reside with main application code as
well, so that again is a candidate to be moved to specialpurpose. Any of such third party application integrations should be maintained separately.

--
Thanks & Regards,
Mridul Pathak
Senior Manager
HotWax Systems
http://www.hotwaxsystems.com

On Jun 15, 2016, at 12:00 PM, Ashish Vijaywargiya
wrote:

I would prefer to keep Tax and Third Party Payment gateway files(The files
that does exists inside cybersource, ideal, orbital, paypal, securepay,
verisign etc). If you see some problems in those code base, like code base
is not updated based on latest changes then we can update those files.
Those files might have been used by so many users that we can't know
because we are doing this conversation on Dev mailing list. We should not
remove those files.

--
Kind Regards
Ashish Vijaywargiya
HotWax Systems - est. 1997

On Tue, Jun 14, 2016 at 7:40 PM, Taher Alkhateeb

[jira] [Created] (OFBIZ-7352) Do my sales invoice will print along with Barcode at bottom

2016-06-15 Thread COTATEX (JIRA)

COTATEX created OFBIZ-7352:
--

 Summary: Do my sales invoice will print along with Barcode at 
bottom
 Key: OFBIZ-7352
 URL: https://issues.apache.org/jira/browse/OFBIZ-7352
 Project: OFBiz
  Issue Type: Task
  Components: order
Reporter: COTATEX
Priority: Minor


Dear Support,

I would need to print a sales invoice along with Barcode EPN-13 format or QR 
Code in the paper. Do it will be possible without customization any standard 
functionality exists?

Thanks.
Sathish



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7351) Missing UiLabel on Product Inventory Summary page

2016-06-15 Thread Ashish Vijaywargiya (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya reassigned OFBIZ-7351:
--

Assignee: Ashish Vijaywargiya  (was: Aman Agrawal)

> Missing UiLabel on Product Inventory Summary page
> -
>
> Key: OFBIZ-7351
> URL: https://issues.apache.org/jira/browse/OFBIZ-7351
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Attachments: OFBIZ-7351.patch
>
>
> Steps to regenerate:
> Catalog --> Products --> Find Products --> Select any productId --> Inventory 
> --> Select any productId --> Show all Facilities ui label is missing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7277) Date time field is not working properly in case of multiple parent category rollup

2016-06-15 Thread Ashish Vijaywargiya (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7277.
--
   Resolution: Fixed
Fix Version/s: 13.07.04
   15.12.01
   14.12.01

Thanks Ravi for the contribution. Your changes are committed at following 
revisions:

trunk - r1748532
R1512 - r1748533
R1412 - r1748534
R1307 - r1748535

> Date time field is not working properly in case of multiple parent category 
> rollup
> --
>
> Key: OFBIZ-7277
> URL: https://issues.apache.org/jira/browse/OFBIZ-7277
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7277_1307.patch, OFBIZ-7277_1512.patch, 
> OFBIZ-7277_trunk.patch
>
>
> Steps to regenerate:
> 1) Go to Catalog -> Categories
> 2) Find a category and go to rollup screen.
> 3) If there are multiple parent categories under "Category Rollup : Parent 
> Categories" date  time field doesn't display calendar icon.
> Root Cause:
> Multiple date time field with the same id.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7351) Missing UiLabel on Product Inventory Summary page

2016-06-15 Thread Rahul bhammarker (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul bhammarker updated OFBIZ-7351:

Attachment: OFBIZ-7351.patch

Here is the patch for ProductUiLabel. 

> Missing UiLabel on Product Inventory Summary page
> -
>
> Key: OFBIZ-7351
> URL: https://issues.apache.org/jira/browse/OFBIZ-7351
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>Assignee: Aman Agrawal
>Priority: Minor
> Attachments: OFBIZ-7351.patch
>
>
> Steps to regenerate:
> Catalog --> Products --> Find Products --> Select any productId --> Inventory 
> --> Select any productId --> Show all Facilities ui label is missing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7351) Missing UiLabel on Product Inventory Summary page

2016-06-15 Thread Rahul bhammarker (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331463#comment-15331463
 ] 

Rahul bhammarker commented on OFBIZ-7351:
-

The UiLabel for "ProductShowAllFacilities" do exist but the value of UiLable 
for language "en" is incorrect and it should be "Show All Facilities".

> Missing UiLabel on Product Inventory Summary page
> -
>
> Key: OFBIZ-7351
> URL: https://issues.apache.org/jira/browse/OFBIZ-7351
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>Assignee: Aman Agrawal
>Priority: Minor
>
> Steps to regenerate:
> Catalog --> Products --> Find Products --> Select any productId --> Inventory 
> --> Select any productId --> Show all Facilities ui label is missing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7351) Missing UiLabel on Product Inventory Summary page

2016-06-15 Thread Aman Agrawal (JIRA)

Aman Agrawal created OFBIZ-7351:
---

 Summary: Missing UiLabel on Product Inventory Summary page
 Key: OFBIZ-7351
 URL: https://issues.apache.org/jira/browse/OFBIZ-7351
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: Trunk
Reporter: Aman Agrawal
Assignee: Aman Agrawal
Priority: Minor


Steps to regenerate:
Catalog --> Products --> Find Products --> Select any productId --> Inventory 
--> Select any productId --> Show all Facilities ui label is missing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to delete stale java files

2016-06-15 Thread Taher Alkhateeb

Hi Mridul,

How about reference/paymentext and reference/whatever-else-you-want? So the
top level directory is called reference to indicate to people that this is
just for reference and will not compile. Also, this way we keep all
reference material under one directory to avoid polluting the directory
tree. My 2 cents.

Regards,

Taher Alkhateeb

On Wed, Jun 15, 2016 at 12:27 PM, Mridul Pathak <
mridul.pat...@hotwaxsystems.com> wrote:

> Hi Taher,
>
> Sure, I’ll take care of deleting rest of the files as well.
>
> Also, we could name these specialpurpose component(s) as paymentext, etc.
> and mention in README file that these are extensions to OFBiz and does not
> compile directly.
>
> --
> Thanks & Regards,
> Mridul Pathak
> HotWax Systems
> http://www.hotwaxsystems.com
>
> > On Jun 15, 2016, at 2:37 PM, Taher Alkhateeb 
> wrote:
> >
> > Hi Mridul and everyone,
> >
> > Thank you all for your inputs. May I also ask you Mridul while you are
> at it to delete the rest of the files so the whole task resides with you to
> avoid crossing any wires.
> >
> > Also, I suggest to name that component into something like archives or
> reference and put a README file that says this component does not compile
> and it holds this stuff. This way it is easy to isolate that component from
> the build system.
> >
> > Thank you all again for your contributions.
> >
> > Taher Alkhateeb
> >
> > -Original Message-
> > From: Mridul Pathak [mailto:mridul.pat...@hotwaxsystems.com  mridul.pat...@hotwaxsystems.com>]
> > Sent: 15 June 2016 11:09
> > To: dev@ofbiz.apache.org 
> > Cc: Mridul Pathak
> > Subject: Re: Proposal to delete stale java files
> >
> > I would like to volunteer for this change (moving payment, shipping and
> tax integrations to specialpurpose).
> >
> > --
> > Mridul Pathak
> >
> > On Wednesday 15 June 2016, Jacopo Cappellato <
> jacopo.cappell...@hotwaxsystems.com> wrote:
> >
> >> Based on the new comments it seems like that we could isolate the
> >> shipment, payment and tax integration classes (and artifacts that use
> >> them) into their own specialpurpose components (waiting for a better
> >> pluggable components architecture); they will not be compiled by
> >> default but each component will have its own readme file containing
> >> instructions about how to deploy and use them.
> >> As regards the JasperReports*, JRE* and openoffice ones I think they
> >> can go to Attic since they are old and unmaintained.
> >>
> >> Does it make sense? Any volunteers to create the new specialpurpose
> >> components and upgrade/isolate the shipment/payment/tax integration
> >> classes into them?
> >>
> >> Jacopo
> >>
> >> On Wed, Jun 15, 2016 at 9:32 AM, Hans Bakker
> >> 
> >
> >> wrote:
> >>
> >>> +1
> >>>
> >>>
> >>> On 15/06/16 13:30, Ashish Vijaywargiya wrote:
> >>>
>  I would prefer to keep Tax and Third Party Payment gateway
>  files(The
> >> files
>  that does exists inside cybersource, ideal, orbital, paypal,
>  securepay, verisign etc). If you see some problems in those code
>  base, like code
> >> base
>  is not updated based on latest changes then we can update those files.
>  Those files might have been used by so many users that we can't
>  know because we are doing this conversation on Dev mailing list. We
>  should
> >> not
>  remove those files.
> 
>  --
>  Kind Regards
>  Ashish Vijaywargiya
>  HotWax Systems - est. 1997
> 
>  On Tue, Jun 14, 2016 at 7:40 PM, Taher Alkhateeb <
>  slidingfilame...@gmail.com 
> 
> > wrote:
> >
> 
>  Hi Everyone,
> >
> > I cannot actually believe it but while I was working on a project
> > (I
> >> will
> > announce later) I discovered in the process that the below files
> > cannot compile!!! They existed for years in the code base without
> > even being able to compile. They reference non existent libraries
> > or they have faulty code (e.g. not importing used code)
> >
> > I propose to delete them immediately from trunk
> >
> >
> >
> >
> >> applications/accounting/src/org/ofbiz/accounting/thirdparty/cybersourc
> >> e/IcsPaymentServices.java
> >
> >
> >
> >> applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/Idea
> >> lEvents.java
> >
> >
> >
> >> applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/Idea
> >> lPaymentServiceTest.java
> >
> >
> >
> >> applications/accounting/src/org/ofbiz/accounting/thirdparty/orbital/Or
> >> bitalPaymentServices.java
> >
> >
> >
> >> applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/Pay
> >> PalServices.java
> >
> >
> >
> >> applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/
> >> SecurePayPaymentServices.java
> >
> >
>

[jira] [Updated] (OFBIZ-7350) Manage filters in lookup auto completion


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles STELTZLEN updated OFBIZ-7350:
-
Attachment: lookup-improvement_13.07.patch

Patch for branch 13.07

> Manage filters in lookup auto completion
> 
>
> Key: OFBIZ-7350
> URL: https://issues.apache.org/jira/browse/OFBIZ-7350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Charles STELTZLEN
>Priority: Minor
> Attachments: lookup-improvement_13.07.patch
>
>
> On form lookup, we can specify target parameters to pass them to the lookup 
> screen and do filtered searches with these parameters. It works fine when you 
> click on lookup button. But when you start to write something in lookup 
> input, these parameters are not passed to the ajax auto-complete system. So, 
> the results are not filtered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to delete stale java files

Hi Taher,

Sure, I’ll take care of deleting rest of the files as well.

Also, we could name these specialpurpose component(s) as paymentext, etc. and 
mention in README file that these are extensions to OFBiz and does not compile 
directly.

--
Thanks & Regards,
Mridul Pathak
HotWax Systems
http://www.hotwaxsystems.com

> On Jun 15, 2016, at 2:37 PM, Taher Alkhateeb  
> wrote:
> 
> Hi Mridul and everyone,
> 
> Thank you all for your inputs. May I also ask you Mridul while you are at it 
> to delete the rest of the files so the whole task resides with you to avoid 
> crossing any wires.
> 
> Also, I suggest to name that component into something like archives or 
> reference and put a README file that says this component does not compile and 
> it holds this stuff. This way it is easy to isolate that component from the 
> build system.
> 
> Thank you all again for your contributions.
> 
> Taher Alkhateeb
> 
> -Original Message-
> From: Mridul Pathak [mailto:mridul.pat...@hotwaxsystems.com 
> ] 
> Sent: 15 June 2016 11:09
> To: dev@ofbiz.apache.org 
> Cc: Mridul Pathak
> Subject: Re: Proposal to delete stale java files
> 
> I would like to volunteer for this change (moving payment, shipping and tax 
> integrations to specialpurpose).
> 
> --
> Mridul Pathak
> 
> On Wednesday 15 June 2016, Jacopo Cappellato < 
> jacopo.cappell...@hotwaxsystems.com> wrote:
> 
>> Based on the new comments it seems like that we could isolate the 
>> shipment, payment and tax integration classes (and artifacts that use 
>> them) into their own specialpurpose components (waiting for a better 
>> pluggable components architecture); they will not be compiled by 
>> default but each component will have its own readme file containing 
>> instructions about how to deploy and use them.
>> As regards the JasperReports*, JRE* and openoffice ones I think they 
>> can go to Attic since they are old and unmaintained.
>> 
>> Does it make sense? Any volunteers to create the new specialpurpose 
>> components and upgrade/isolate the shipment/payment/tax integration 
>> classes into them?
>> 
>> Jacopo
>> 
>> On Wed, Jun 15, 2016 at 9:32 AM, Hans Bakker 
>>  
>> >
>> wrote:
>> 
>>> +1
>>> 
>>> 
>>> On 15/06/16 13:30, Ashish Vijaywargiya wrote:
>>> 
 I would prefer to keep Tax and Third Party Payment gateway 
 files(The
>> files
 that does exists inside cybersource, ideal, orbital, paypal, 
 securepay, verisign etc). If you see some problems in those code 
 base, like code
>> base
 is not updated based on latest changes then we can update those files.
 Those files might have been used by so many users that we can't 
 know because we are doing this conversation on Dev mailing list. We 
 should
>> not
 remove those files.
 
 --
 Kind Regards
 Ashish Vijaywargiya
 HotWax Systems - est. 1997
 
 On Tue, Jun 14, 2016 at 7:40 PM, Taher Alkhateeb < 
 slidingfilame...@gmail.com 
 
> wrote:
> 
 
 Hi Everyone,
> 
> I cannot actually believe it but while I was working on a project 
> (I
>> will
> announce later) I discovered in the process that the below files 
> cannot compile!!! They existed for years in the code base without 
> even being able to compile. They reference non existent libraries 
> or they have faulty code (e.g. not importing used code)
> 
> I propose to delete them immediately from trunk
> 
> 
> 
> 
>> applications/accounting/src/org/ofbiz/accounting/thirdparty/cybersourc
>> e/IcsPaymentServices.java
> 
> 
> 
>> applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/Idea
>> lEvents.java
> 
> 
> 
>> applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/Idea
>> lPaymentServiceTest.java
> 
> 
> 
>> applications/accounting/src/org/ofbiz/accounting/thirdparty/orbital/Or
>> bitalPaymentServices.java
> 
> 
> 
>> applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/Pay
>> PalServices.java
> 
> 
> 
>> applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/
>> SecurePayPaymentServices.java
> 
> 
> 
>> applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/
>> SecurePayServiceTest.java
> 
> 
> 
>> applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/P
>> ayflowPro.java
> 
> 
> 
>> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteAr
>> rayInputStream.java
> 
> 
> 
>> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteAr
>> rayOutputStream.java
> 
> 
> 
>> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServic
>> es.java
> 
> 
>>

RE: Proposal to delete stale java files

2016-06-15 Thread Taher Alkhateeb

Hi Mridul and everyone,

Thank you all for your inputs. May I also ask you Mridul while you are at it to 
delete the rest of the files so the whole task resides with you to avoid 
crossing any wires.

Also, I suggest to name that component into something like archives or 
reference and put a README file that says this component does not compile and 
it holds this stuff. This way it is easy to isolate that component from the 
build system.

Thank you all again for your contributions.

Taher Alkhateeb

-Original Message-
From: Mridul Pathak [mailto:mridul.pat...@hotwaxsystems.com] 
Sent: 15 June 2016 11:09
To: dev@ofbiz.apache.org
Cc: Mridul Pathak
Subject: Re: Proposal to delete stale java files

I would like to volunteer for this change (moving payment, shipping and tax 
integrations to specialpurpose).

--
Mridul Pathak

On Wednesday 15 June 2016, Jacopo Cappellato < 
jacopo.cappell...@hotwaxsystems.com> wrote:

> Based on the new comments it seems like that we could isolate the 
> shipment, payment and tax integration classes (and artifacts that use 
> them) into their own specialpurpose components (waiting for a better 
> pluggable components architecture); they will not be compiled by 
> default but each component will have its own readme file containing 
> instructions about how to deploy and use them.
> As regards the JasperReports*, JRE* and openoffice ones I think they 
> can go to Attic since they are old and unmaintained.
>
> Does it make sense? Any volunteers to create the new specialpurpose 
> components and upgrade/isolate the shipment/payment/tax integration 
> classes into them?
>
> Jacopo
>
> On Wed, Jun 15, 2016 at 9:32 AM, Hans Bakker 
> >
> wrote:
>
> > +1
> >
> >
> > On 15/06/16 13:30, Ashish Vijaywargiya wrote:
> >
> >> I would prefer to keep Tax and Third Party Payment gateway 
> >> files(The
> files
> >> that does exists inside cybersource, ideal, orbital, paypal, 
> >> securepay, verisign etc). If you see some problems in those code 
> >> base, like code
> base
> >> is not updated based on latest changes then we can update those files.
> >> Those files might have been used by so many users that we can't 
> >> know because we are doing this conversation on Dev mailing list. We 
> >> should
> not
> >> remove those files.
> >>
> >> --
> >> Kind Regards
> >> Ashish Vijaywargiya
> >> HotWax Systems - est. 1997
> >>
> >> On Tue, Jun 14, 2016 at 7:40 PM, Taher Alkhateeb < 
> >> slidingfilame...@gmail.com 
> >>
> >>> wrote:
> >>>
> >>
> >> Hi Everyone,
> >>>
> >>> I cannot actually believe it but while I was working on a project 
> >>> (I
> will
> >>> announce later) I discovered in the process that the below files 
> >>> cannot compile!!! They existed for years in the code base without 
> >>> even being able to compile. They reference non existent libraries 
> >>> or they have faulty code (e.g. not importing used code)
> >>>
> >>> I propose to delete them immediately from trunk
> >>>
> >>>
> >>>
> >>>
> applications/accounting/src/org/ofbiz/accounting/thirdparty/cybersourc
> e/IcsPaymentServices.java
> >>>
> >>>
> >>>
> applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/Idea
> lEvents.java
> >>>
> >>>
> >>>
> applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/Idea
> lPaymentServiceTest.java
> >>>
> >>>
> >>>
> applications/accounting/src/org/ofbiz/accounting/thirdparty/orbital/Or
> bitalPaymentServices.java
> >>>
> >>>
> >>>
> applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/Pay
> PalServices.java
> >>>
> >>>
> >>>
> applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/
> SecurePayPaymentServices.java
> >>>
> >>>
> >>>
> applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/
> SecurePayServiceTest.java
> >>>
> >>>
> >>>
> applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/P
> ayflowPro.java
> >>>
> >>>
> >>>
> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteAr
> rayInputStream.java
> >>>
> >>>
> >>>
> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteAr
> rayOutputStream.java
> >>>
> >>>
> >>>
> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServic
> es.java
> >>>
> >>>
> applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker
> .java
> >>> applications/content/src/org/ofbiz/content/report
> >>>
> >>>
> >>>
> applications/content/src/org/ofbiz/content/report/JREntityListIterator
> DataSource.java
> >>>
> >>>
> >>>
> applications/content/src/org/ofbiz/content/report/JRMapCollectionDataS
> ource.java
> >>> applications/order/src/org/ofbiz/order/thirdparty/taxware
> >>>
> >>>
> >>>
> applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareExcep
> tion.java
> >>>
> >>>
> >>>
> applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareServi
> ces.java
> >>>
> applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareUTL.j
> ava
> >>>

is not working as expected in Form Widget

2016-06-15 Thread Pritam Kute

Hello OFBiz Developers,

While working on the issue OFBIZ-7252
, I found one problem in
Form Widgets. When we use  attribute in child form, the system
should consider overridden  in child form. This is default
expected behaviour. But in this case, it is always considering the
 of the parent form.

For example:

**
*   *
*  *
**

* *
*  *
**

In above example, expectation is 'executeChildTarget' target should get
executed but actually 'executeParentTarget' is getting executed.

When we looked into framework level code of Form Widgets, we got the
following code snippets:

*ModelForm.java* (Line: 380-388)

*ArrayList altTargets = new ArrayList();*
*if (parentModel != null) {*
*altTargets.addAll(parentModel.altTargets);*
*}*
*for (Element altTargetElement : UtilXml.childElementList(formElement,
"alt-target")) {*
*altTargets.add(new AltTarget(altTargetElement));*
*}*
*altTargets.trimToSize();*
*this.altTargets = Collections.unmodifiableList(altTargets);*

Here we can see that all alt-targets present in parent form are added to
the list first and then all alt-targets present in child form are added.

This causes a problem as method getTarget() of ModelForm.java (Line:
1352-1384) returns the first element in the list as alt-target.

Is this is intentionally done or we are missing something?

Thanks & Regards,
--
*Pritam Kute*
*HotWax Systems* | www.hotwaxsystems.com

[jira] [Updated] (OFBIZ-7112) EntityUtilProperties

2016-06-15 Thread Wai (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wai updated OFBIZ-7112:
---
Attachment: OFBIZ-7112.patch

bug fix and update seed data

> EntityUtilProperties
> 
>
> Key: OFBIZ-7112
> URL: https://issues.apache.org/jira/browse/OFBIZ-7112
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7112.patch, OFBIZ-7112.patch, OFBIZ-7112.patch, 
> OFBIZ-7112.patch
>
>
> Ofbiz reads properties from either a properties file or the 
> entity:SystemProperty. The way it works previously is that ofbiz reads from 
> the entity:SystemProperty first and if there is no value associated with the 
> target propertyname, it would then locate the value from the relevant 
> properties file.
> In other words, if there is a database entry for a property, the database 
> entry should override the associated properties file.
> The issue is that if a database entry exist but the value is empty, it would 
> look for a value from the properties file.  It should not do so.  If a 
> database entry exists for the propertyname of interest, the value should be 
> taken from the database even if it holds an empty value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7350) Manage filters in lookup auto completion

Charles STELTZLEN created OFBIZ-7350:


 Summary: Manage filters in lookup auto completion
 Key: OFBIZ-7350
 URL: https://issues.apache.org/jira/browse/OFBIZ-7350
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Release Branch 15.12, Trunk, Release Branch 14.12, 
Release Branch 13.07, Release Branch 12.04
Reporter: Charles STELTZLEN
Priority: Minor


On form lookup, we can specify target parameters to pass them to the lookup 
screen and do filtered searches with these parameters. It works fine when you 
click on lookup button. But when you start to write something in lookup input, 
these parameters are not passed to the ajax auto-complete system. So, the 
results are not filtered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7339) Replace EntityUtilProperties getPropertyValue method with correct method calls

2016-06-15 Thread Rishi Solanki (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331354#comment-15331354
 ] 

Rishi Solanki edited comment on OFBIZ-7339 at 6/15/16 8:13 AM:
---

Yes [~jacques.le.roux] we have seen your discussion on it with Wai on dev list. 
Here we are trying to address the practice we should follow while using the 
OFBiz API. Generally one method solves all purpose and users start using that 
method everywhere with custom conversions. I see Wai's patch on OFBIZ-7112 
check for db values and override the property values. Here we have only made 
changes in method call, so I think we are good as changed methods call 
signature doesn't changed in that work. Also checked that no dependency of both 
improvements as we are just changing the calls.

Thank you for your help!


was (Author: rishisolankii):
Yes [~jacques.le.roux] we have seen your discussion on it with Wai on dev list. 
Here we are trying to address the practice we should follow while using the 
OFBiz API. Generally one method solves all purpose and users start using that 
method everywhere with custom conversions. I see Wai's patch on OFBIZ-7112 
check for db values and override the property values. Here we have only made 
changes in method call, so I think we are good as changed methods call 
signature doesn't changed in that work.

Thank you for your help!

> Replace EntityUtilProperties getPropertyValue method with correct method calls
> --
>
> Key: OFBIZ-7339
> URL: https://issues.apache.org/jira/browse/OFBIZ-7339
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, framework, manufacturing, party, product, 
> securityext, specialpurpose/ecommerce, specialpurpose/lucene, 
> specialpurpose/passport, workeffort
>Affects Versions: Trunk
>Reporter: Rishi Solanki
> Attachments: EntityUtilProperties.patch
>
>
> In current OFBiz system at many places many methods implemented but not used 
> as per their purpose. One example is in EntityUtilProperties we have 
> getPropertyAsInteger() and getPropertyAsBigDecimal() and other methods which 
> returns specific type data. But at most places system uses getPropertyValue() 
> which returns string and then do explicit conversions.
> System should use proper methods for which they have been implemented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7339) Replace EntityUtilProperties getPropertyValue method with correct method calls

2016-06-15 Thread Rishi Solanki (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331354#comment-15331354
 ] 

Rishi Solanki commented on OFBIZ-7339:
--

Yes [~jacques.le.roux] we have seen your discussion on it with Wai on dev list. 
Here we are trying to address the practice we should follow while using the 
OFBiz API. Generally one method solves all purpose and users start using that 
method everywhere with custom conversions. I see Wai's patch on OFBIZ-7112 
check for db values and override the property values. Here we have only made 
changes in method call, so I think we are good as changed methods call 
signature doesn't changed in that work.

Thank you for your help!

> Replace EntityUtilProperties getPropertyValue method with correct method calls
> --
>
> Key: OFBIZ-7339
> URL: https://issues.apache.org/jira/browse/OFBIZ-7339
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, framework, manufacturing, party, product, 
> securityext, specialpurpose/ecommerce, specialpurpose/lucene, 
> specialpurpose/passport, workeffort
>Affects Versions: Trunk
>Reporter: Rishi Solanki
> Attachments: EntityUtilProperties.patch
>
>
> In current OFBiz system at many places many methods implemented but not used 
> as per their purpose. One example is in EntityUtilProperties we have 
> getPropertyAsInteger() and getPropertyAsBigDecimal() and other methods which 
> returns specific type data. But at most places system uses getPropertyValue() 
> which returns string and then do explicit conversions.
> System should use proper methods for which they have been implemented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to delete stale java files