from:"BJ Freeman"


what is the goal?
How will mounting Resources independent effect the operation of Ofbiz?
why not stick with Content with a Resources Webapp?
DataResourceType dataResourceTypeId=IMAGE_OBJECT description=Image 
hasTable=Y parentTypeId=/


on the second part as long as the reference to resources in done by 
content method, instead of absolute location, then where it is located 
is a matter of changing the Content record.


Jacopo Cappellato sent the following on 7/16/2012 2:40 AM:

As a first step in the review/cleanup of the images component I am proposing to move its content, 
i.e. the images webapp, to the framework/resources, transforming it into a component that will 
mount the images application.
This is a trivial change but in my opinion resources is a more appropriate component 
name than images.
The next steps for the future will be to move out of the framework the folders in the 
images application that are specific to applications (somewhere under runtime 
seems a good approach).

What do you think?

Jacopo

Re: Discussion: Application Metrics Feature


What would be great is if we had a Dev map that showed a design plan
The Goal, Scope, and effect on the current design.
having all these in one place on the wiki would help in over all design.
my 2 cents.

Adrian Crum sent the following on 7/14/2012 3:38 AM:

I have an application metrics feature working on my local copy and I was
wondering if there would be any interest in including it in the project.

A metric is a measure of average execution time. Each metric is given a
unique name.

I modified the control servlet and service dispatcher to use metrics. To
add a metric to a request, just include an XML element:

metric name=URL: webtools/main /

to the request map and the average response time for the URL will be
maintained. Likewise, to add a metric to a service, just include an XML
element:

metric name=Service: createMaintsFromTimeInterval /

to the service definition and the average execution time for the service
will be maintained.

Metrics are kept in memory. There is a service to retrieve all metrics.
There is also a Web Tools page to view all metrics.

A heartbeat server could retrieve the metrics to check on server load or
to provide histograms.

The metric element has an optional threshold attribute, so some action
could be taken when the metric crosses a threshold. For example, in the
following request map:

request-map uri=ViewMetrics
security https=true auth=true/
metric name=URL: webtools/ViewMetrics threshold=1000/
response name=success type=view value=ViewMetrics/
response name=threshold-exceeded type=view value=ServerBusy/!--
displays a friendly 'server busy' page --
/request-map

the ServerBusy view would be rendered if the average response time
exceeded 1000 mS. This can be useful for providing a lively web
experience on a heavy-traffic web page.

The service dispatcher does not use the threshold. I could not think of
a use case where service behavior should be modified based on average
execution time.

The metrics code is very small - two java files. Also, the modifications
to the webapp component and service component are very small.

What do you think?

-Adrian

Re: Discussion: Application Metrics Feature

that is true, however a month from now it will be lost and will have to 
be searched.
So you start by putting you proposal on the wiki then link in the email 
for discussion.
once the discussion is completed it is put on the wiki with a link to a 
page of the discussion. and a synopsis of the result of the discussion.


Adrian Crum sent the following on 7/16/2012 3:45 AM:

Having a Wiki page that describes the new feature would be great, but it
needs to be created after the commit and some review. Creating a Wiki
page before there is any interest expressed in the proposal could be a
waste of time. So, I cover the goal, scope, and effect on the current
design in the emailed proposal.

-Adrian

On 7/16/2012 11:32 AM, BJ Freeman wrote:

What would be great is if we had a Dev map that showed a design plan
The Goal, Scope, and effect on the current design.
having all these in one place on the wiki would help in over all design.
my 2 cents.

Adrian Crum sent the following on 7/14/2012 3:38 AM:

I have an application metrics feature working on my local copy and I was
wondering if there would be any interest in including it in the project.

A metric is a measure of average execution time. Each metric is given a
unique name.

I modified the control servlet and service dispatcher to use metrics. To
add a metric to a request, just include an XML element:

metric name=URL: webtools/main /

to the request map and the average response time for the URL will be
maintained. Likewise, to add a metric to a service, just include an XML
element:

metric name=Service: createMaintsFromTimeInterval /

to the service definition and the average execution time for the service
will be maintained.

Metrics are kept in memory. There is a service to retrieve all metrics.
There is also a Web Tools page to view all metrics.

A heartbeat server could retrieve the metrics to check on server load or
to provide histograms.

The metric element has an optional threshold attribute, so some action
could be taken when the metric crosses a threshold. For example, in the
following request map:

request-map uri=ViewMetrics
security https=true auth=true/
metric name=URL: webtools/ViewMetrics threshold=1000/
response name=success type=view value=ViewMetrics/
response name=threshold-exceeded type=view value=ServerBusy/!--
displays a friendly 'server busy' page --
/request-map

the ServerBusy view would be rendered if the average response time
exceeded 1000 mS. This can be useful for providing a lively web
experience on a heavy-traffic web page.

The service dispatcher does not use the threshold. I could not think of
a use case where service behavior should be modified based on average
execution time.

The metrics code is very small - two java files. Also, the modifications
to the webapp component and service component are very small.

What do you think?

-Adrian

Re: Discussion: Application Metrics Feature

just for clarification this is not a new features map, but a Dev 
consideration map. so people can see what has been considered and the 
outcome.


BJ Freeman sent the following on 7/16/2012 3:54 AM:

that is true, however a month from now it will be lost and will have to
be searched.
So you start by putting you proposal on the wiki then link in the email
for discussion.
once the discussion is completed it is put on the wiki with a link to a
page of the discussion. and a synopsis of the result of the discussion.

Adrian Crum sent the following on 7/16/2012 3:45 AM:

Having a Wiki page that describes the new feature would be great, but it
needs to be created after the commit and some review. Creating a Wiki
page before there is any interest expressed in the proposal could be a
waste of time. So, I cover the goal, scope, and effect on the current
design in the emailed proposal.

-Adrian

On 7/16/2012 11:32 AM, BJ Freeman wrote:

What would be great is if we had a Dev map that showed a design plan
The Goal, Scope, and effect on the current design.
having all these in one place on the wiki would help in over all design.
my 2 cents.

Adrian Crum sent the following on 7/14/2012 3:38 AM:

I have an application metrics feature working on my local copy and I
was
wondering if there would be any interest in including it in the
project.

A metric is a measure of average execution time. Each metric is given a
unique name.

I modified the control servlet and service dispatcher to use
metrics. To
add a metric to a request, just include an XML element:

metric name=URL: webtools/main /

to the request map and the average response time for the URL will be
maintained. Likewise, to add a metric to a service, just include an XML
element:

metric name=Service: createMaintsFromTimeInterval /

to the service definition and the average execution time for the
service
will be maintained.

Metrics are kept in memory. There is a service to retrieve all metrics.
There is also a Web Tools page to view all metrics.

A heartbeat server could retrieve the metrics to check on server
load or
to provide histograms.

The metric element has an optional threshold attribute, so some action
could be taken when the metric crosses a threshold. For example, in the
following request map:

request-map uri=ViewMetrics
security https=true auth=true/
metric name=URL: webtools/ViewMetrics threshold=1000/
response name=success type=view value=ViewMetrics/
response name=threshold-exceeded type=view
value=ServerBusy/!--
displays a friendly 'server busy' page --
/request-map

the ServerBusy view would be rendered if the average response time
exceeded 1000 mS. This can be useful for providing a lively web
experience on a heavy-traffic web page.

The service dispatcher does not use the threshold. I could not think of
a use case where service behavior should be modified based on average
execution time.

The metrics code is very small - two java files. Also, the
modifications
to the webapp component and service component are very small.

What do you think?

-Adrian

Re: Discussion: Application Metrics Feature

I am using this one since it is a long thread and I don't want to read 
it all.
This is a great opportunity for someone, like yourself, to take on the 
task of informing the user list of activity of the Dev list.
Those that think it of interest on the user list can join or read the 
archive of the dev list.


Pierre Smits sent the following on 7/16/2012 2:11 AM:

You mean excluding parts of the community from participating in the
decision-taking processes?

2012/7/16 Adrian Crumadrian.c...@sandglass-software.com


No, it smells like the current goal of moving things we don't want in the
main project to external projects. This type of decision-making has been
going on for years.

-Adrian


On 7/16/2012 9:45 AM, Pierre Smits wrote:


I agree with Ruth. This sounds like a user requirement. And the community
should decide on this.

Furthermore, the remark 'users might like a new feature, but that doesn't
mean the dev community wants it in the project' smells like measuring with
double standards; as if the meritocratic principle doesn't apply when the
committers don't want it in. Or as if changes always get in, when only the
committers want it.

2012/7/15 Adrian 
Crumadrian.crum@sandglass-**software.comadrian.c...@sandglass-software.com




  Ruth,


I understand your viewpoint. Personally, I prefer to present my ideas to
the dev list to see if it is something the dev community wants included
in
the project. Users might like a new feature, but that doesn't mean the
dev
community wants it in the project. If there was no interest from the dev
community, then I would offer it as an add-on product and announce it on
the user list.

I am also a user, and the design was based on the requirement to monitor
and control server performance. I suppose I could go to the user list for
more ideas, but the code I'm planning to commit is pretty basic, and
users
will be free to enhance it in whatever way they please.

-Adrian


On 7/15/2012 12:13 PM, Ruth Hoffman wrote:

  Hi Adrian:

Shouldn't this be discussed on the user list? IMHO Words like
applications and stats about services and entities...those are all
indicative of user requirements, not developer requirements.

Users should be driving requirements gathering and analysis for OFBiz
and
not developers.
Just my 2 cents.
Regards,
Ruth

Re: Discussion: Application Metrics Feature


there must be a language barrier here.
it was a suggestion and as I prefaced, I used Pierre's since I did not 
want to find the original. I could have used yours just as well.

It was if you want to get something done, do it yourself type of suggestion.
You add to the drama Ruth.
Not something I enjoy.

Ruth Hoffman sent the following on 7/16/2012 9:25 AM:

You guys are a hoot! I love reading this list.
Com'on BJ...this is silly. Don't be so pretentious. Adrian already
explained his point of view.
So now I wanna know: What makes you think you can assign opportunities
to Pierre? Or is that also part of the meritocracy that comes with
being a member of this community?
Best Regards,
Ruth
On 7/16/12 11:49 AM, BJ Freeman wrote:

I am using this one since it is a long thread and I don't want to read
it all.
This is a great opportunity for someone, like yourself, to take on the
task of informing the user list of activity of the Dev list.
Those that think it of interest on the user list can join or read the
archive of the dev list.

Pierre Smits sent the following on 7/16/2012 2:11 AM:

You mean excluding parts of the community from participating in the
decision-taking processes?

2012/7/16 Adrian Crumadrian.c...@sandglass-software.com


No, it smells like the current goal of moving things we don't want
in the
main project to external projects. This type of decision-making has
been
going on for years.

-Adrian


On 7/16/2012 9:45 AM, Pierre Smits wrote:


I agree with Ruth. This sounds like a user requirement. And the
community
should decide on this.

Furthermore, the remark 'users might like a new feature, but that
doesn't
mean the dev community wants it in the project' smells like
measuring with
double standards; as if the meritocratic principle doesn't apply
when the
committers don't want it in. Or as if changes always get in, when
only the
committers want it.

2012/7/15 Adrian
Crumadrian.crum@sandglass-**software.comadrian.c...@sandglass-software.com





Ruth,


I understand your viewpoint. Personally, I prefer to present my
ideas to
the dev list to see if it is something the dev community wants
included
in
the project. Users might like a new feature, but that doesn't mean
the
dev
community wants it in the project. If there was no interest from
the dev
community, then I would offer it as an add-on product and announce
it on
the user list.

I am also a user, and the design was based on the requirement to
monitor
and control server performance. I suppose I could go to the user
list for
more ideas, but the code I'm planning to commit is pretty basic, and
users
will be free to enhance it in whatever way they please.

-Adrian


On 7/15/2012 12:13 PM, Ruth Hoffman wrote:

Hi Adrian:

Shouldn't this be discussed on the user list? IMHO Words like
applications and stats about services and entities...those
are all
indicative of user requirements, not developer requirements.

Users should be driving requirements gathering and analysis for
OFBiz
and
not developers.
Just my 2 cents.
Regards,
Ruth

Re: Discussion: Move Scripting Code To A Script Component

2012-07-12 Thread BJ Freeman


so how would this work with a new scripting , like business basic.

Adrian Crum sent the following on 7/12/2012 2:56 AM:

That is true for now, but I was thinking farther down the road. For now
we could just consolidate the code in base, common, and minilang.

-Adrian

On 7/12/2012 10:40 AM, Jacopo Cappellato wrote:

Adrian,

it is an interesting proposal.
If I well understand your proposal then the new scripting component
will depend on (mostly) all the 4 components... let me try to explain
with an example.

A) in theory with the current setup you could enable the service
component and that will give you access to all the scripting engines
implemented under it; if not interested in web events you could
disable the webapp component (ok, I guess this is not really possible
at the moment... but it could be a goal for a future refactoring)
B) after your change you will need the service and scripting
component, but the scripting component will depend on webapps etc..
(because in it there are also the implementation of a few scripting
events)

So the risk is that the change will not really make the framework more
modular.

Jacopo

On Jul 12, 2012, at 11:06 AM, Adrian Crum wrote:


Mini-language could be moved to the script component or it could
remain its own component.

Some of the things that would be moved are:

ScriptHelper.java, Scriptlet.java, ScriptUtil.java, GroovyUtil.java,
BshUtil.java, javax.script.ScriptEngineFactory, ContextHelper.java,
ScriptHelperFactoryImpl.java, ScriptHelperImpl.java,
BeanShellEngine.java, GroovyBaseScript.groovy, GroovyEngine.java,
ScriptEngine.java, GroovyService.java, GroovyShellService.java,
GroovyShellThread.java, GroovyShellContainer.java, and
GroovyEventHandler.java.

Those files are scattered across 4 components.

Some of the things that could be removed are:

org.ofbiz.base.util.ScriptHelperFactory

-Adrian

On 7/11/2012 8:09 PM, BJ Freeman wrote:

are you thinking of just mini, or js, grouvy or what ever?

Adrian Crum sent the following on 7/11/2012 7:16 AM:

The code for scripting support is scattered across several different
components. I would like to move all scripting-related code to a
separate component called script or scripting. I believe this will
help make things more modular and independent.

What do you think?

-Adrian

Re: Discussion: Move Scripting Code To A Script Component

2012-07-12 Thread BJ Freeman


would a new scripting language be in the same component.

Adrian Crum sent the following on 7/12/2012 5:57 AM:

I don't understand the question, sorry.

-Adrian

On 7/12/2012 1:55 PM, BJ Freeman wrote:

so how would this work with a new scripting , like business basic.

Adrian Crum sent the following on 7/12/2012 2:56 AM:

That is true for now, but I was thinking farther down the road. For now
we could just consolidate the code in base, common, and minilang.

-Adrian

On 7/12/2012 10:40 AM, Jacopo Cappellato wrote:

Adrian,

it is an interesting proposal.
If I well understand your proposal then the new scripting component
will depend on (mostly) all the 4 components... let me try to explain
with an example.

A) in theory with the current setup you could enable the service
component and that will give you access to all the scripting engines
implemented under it; if not interested in web events you could
disable the webapp component (ok, I guess this is not really possible
at the moment... but it could be a goal for a future refactoring)
B) after your change you will need the service and scripting
component, but the scripting component will depend on webapps etc..
(because in it there are also the implementation of a few scripting
events)

So the risk is that the change will not really make the framework more
modular.

Jacopo

On Jul 12, 2012, at 11:06 AM, Adrian Crum wrote:


Mini-language could be moved to the script component or it could
remain its own component.

Some of the things that would be moved are:

ScriptHelper.java, Scriptlet.java, ScriptUtil.java, GroovyUtil.java,
BshUtil.java, javax.script.ScriptEngineFactory, ContextHelper.java,
ScriptHelperFactoryImpl.java, ScriptHelperImpl.java,
BeanShellEngine.java, GroovyBaseScript.groovy, GroovyEngine.java,
ScriptEngine.java, GroovyService.java, GroovyShellService.java,
GroovyShellThread.java, GroovyShellContainer.java, and
GroovyEventHandler.java.

Those files are scattered across 4 components.

Some of the things that could be removed are:

org.ofbiz.base.util.ScriptHelperFactory

-Adrian

On 7/11/2012 8:09 PM, BJ Freeman wrote:

are you thinking of just mini, or js, grouvy or what ever?

Adrian Crum sent the following on 7/11/2012 7:16 AM:

The code for scripting support is scattered across several different
components. I would like to move all scripting-related code to a
separate component called script or scripting. I believe this
will
help make things more modular and independent.

What do you think?

-Adrian

Re: Discussion: Move Scripting Code To A Script Component

2012-07-11 Thread BJ Freeman


are you thinking of just mini, or js, grouvy or what ever?

Adrian Crum sent the following on 7/11/2012 7:16 AM:

The code for scripting support is scattered across several different
components. I would like to move all scripting-related code to a
separate component called script or scripting. I believe this will
help make things more modular and independent.

What do you think?

-Adrian

Re: [PROPOSAL] from specialpurpose to extras

2012-07-10 Thread BJ Freeman

So the concerns, as I read the thread, is review of code for release 
needs to be minimized.

Instead of shrinking the SVN Image, I present the following.
1) expand the tests to verify each component/folder. This would reduce 
release review.
2) expand the ant script or create seperate one for Distribution, where 
folders are copied to a new root folder, and appropriate changes to the 
files are done. this would save a lot of documentation. Short of like 
the hot-deploy new component script. Each component/folder would have a 
script to handle it specific requirement.


If every committer took what they are familiar with and covered #1 and 
#2 this should not be any more effort than changing the schema of the SVN


To me this would make Ofbiz something a not so technical person deploy a 
OFbiz image specific to their concerns.


For those that hold this was a project to create cash flow, I put to you 
that there is plenty consulting opportunities in doing the business 
setup, that is more lucrative than coding.


At least that is what I have found with my customers.



Jacopo Cappellato sent the following on 7/9/2012 3:21 AM:

A few months ago we discussed about moving out of OFBiz some components from framework 
and specialpurpose and introduce the concept of OFBiz Extras projects, 
managed out of the ASF infrastructure.
I still think it is a good way to go, especially because it will help to grow 
an ecosystem of projects not necessarily licensed under the same license.
However I understand that this will take time to adjust and a lot of work to setup communities 
etc... this is the main reason I have prepared this proposal for an intermediate step: instead of 
moving out the components we can move them to the specialpurpose folder, rename it into 
extras and exclude the folder from the ootb build/deployment and from releases.

Some more details:
* the extras folder will not be included in build scripts, test runs, 
deployments; in order to build/run/test an extras component, it will have to be 
dropped into the hot-deploy folder
* extras components are not deployed on our demo instances, or included in 
automated builds; no dependency on them (links, documentation etc...) will 
exist in the OFBiz codebase
* some of the components in the extras folder could be experimental; each 
component should contain a README file with all the information required to 
deploy it successfully
* a separate LICENSE file will be maintained in the extras folder
* extras folder will not be part of the future OFBiz releases; we will instead release 
all the extras components in one package as Apache OFBiz Extras let's say 
every year
* we may consider to move back ecommerce from specialpurpose/extras to 
applications, at least the core ecommerce features

Considering that the components are either experimental or very specific, it will be easier to get commit 
rights for one or more of the extras components; new committers will be formally OFBiz 
committers (i.e. in theory they will have right to change all code in svn, including ofbiz code) but 
they will be asked to limit their field of action to the components they have been voted for; it will be 
based on trust rather than commit rights; a formal vote will be still required to authorize the committer to 
other components; the fact that a committer will still have the ability to change all code could be an 
advantage if we allow them to commit code under the explicit permission of another senior committer on 
specific case; for example a senior committer could say I have committed r123456 and this should be 
backported to 12.04 and 11.04 but I don't have time; is there a committer available to help to backport and 
test the feature?
This strategy, to have committers that are asked to not commit out of specific 
components, or areas (we could, for example, have a committer allowed to only 
work on ui labels), could even be considered for old committers (whose commit 
history shows lack of quality)... but this is probably topic for another day.

In short, this approach should help in a few areas: smaller core code base, 
greater community of specialized committers, less load on existing committers.

What do you think?

Jacopo

committers

2012-07-09 Thread BJ Freeman


since I have not seen this email yet I thought I would put in my two cents.
I see a couple of ways new committers could earn their wings(avaitors), 
so to speak.

1) by showing they understand ofbiz in their patches
2) by given limited rights to say specialpurpose to bring up to day one 
of the folders in their.

3) next they are give rights to applications to maintina a folder
4) through proposals that are accepted by the PMC, they gain rights to 
the frame work.


as a general overview they must show they are interested in expanding or 
enhancing ofbiz, not getting their code accepted just for the code.






Jacques Le Roux sent the following on 7/9/2012 4:58 AM:
 The real problem is finding capable new committers and we all know it
 is not easy; the proposal I have in mind (I will send it in
 a separate email) may help in lowering the entry bar by asking (new or
 old) committers to limit their commits to specific areas of
 the project.

[jira] [Commented] (OFBIZ-3490) Create theme build script

2012-04-13 Thread BJ Freeman (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253943#comment-13253943
 ] 

BJ Freeman commented on OFBIZ-3490:
---

Rely on wiki, since I DON'T follow ofbiz any more.

 Create theme build script
 -

 Key: OFBIZ-3490
 URL: https://issues.apache.org/jira/browse/OFBIZ-3490
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: Release Branch 09.04, SVN trunk
 Environment: ant build
Reporter: BJ Freeman
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: 3490-themebutild.patch


 I liked the build script for a new component, so I decided to make one for 
 themes.
 unfortunately I am not able to do a patch so included the script.
 I made it so you can pick a  theme as the template and copy the files over to 
 the new theme.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Data files in ofbiz

2011-12-08 Thread BJ Freeman

there are threads both on dev and user mailing list
https://cwiki.apache.org/confluence/display/OFBENDUSER/OFBiz%27s+Data+File+Tools

viswanath sent the following on 12/7/2011 11:28 PM:
 Hi All,
 
  Can any one help me  in importing csv files into ofbiz database as same
 like xml import in ofbiz-10.04
 it there any way to import csv directly into database or the csv should
 convert into xml, also help me hw to use work with data files in ofbiz
 
 
 
 
 
 
 
 Thanks in advance
 
 --
 View this message in context: 
 http://ofbiz.135035.n4.nabble.com/Data-files-in-ofbiz-tp4171814p4171814.html
 Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Re: Tax calculation for all order adjustments

2011-12-06 Thread BJ Freeman

Thanks. I am trying to pinpoint how to approach this.
If your doing it for yourself then you have more latitude not to take
into considerations like the US Tax authority.
The next consideration is when you upgrade you will have to make sure
your changes are not overwritten with the SVN image.

If you plan to submit a patch then the design has to be reviewed to make
sure it does not effect other Tax authority uses.
You also have a migration to setup for productions systems.

biletnikov sent the following on 12/5/2011 10:35 PM:
 Firstly, for myself. But I think this solution is useful not only for me,
 especial for VAT users and if all is ok, it would be grateful to contribute
 to SVN.
 The most tricky question for me is what I should do with Tax shipping and
 Tax promotion in the TaxAuthorityRateProduct? Actually, they will be
 retired, and should not be used anymore, because all tax rate adjustments
 will be setup in a separate tab.
 
 -
 Kind regards,
 Sergei
 --
 View this message in context: 
 http://ofbiz.135035.n4.nabble.com/Tax-calculation-for-all-order-adjustments-tp4153757p4163677.html
 Sent from the OFBiz - Dev mailing list archive at Nabble.com.

[jira] [Commented] (OFBIZ-3894) Refactor Email handling

2011-12-05 Thread BJ Freeman (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162892#comment-13162892
 ] 

BJ Freeman commented on OFBIZ-3894:
---

My lack of the merge process prompts me to ask if the migration process will 
still be intact


 Refactor Email handling
 ---

 Key: OFBIZ-3894
 URL: https://issues.apache.org/jira/browse/OFBIZ-3894
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: BJ Freeman
Assignee: Erwan de FERRIERES
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-3894.patch, OFBIZ-3894.patch, OFBIZ-3894.patch

   Original Estimate: 1,344h
  Remaining Estimate: 1,344h

 with the addition of the Website for each component 
 1) create product store for Order entry, or use the B2C product store.
 2) move the email  widgets from ecommerce to order compontent.
 3) modify the seed data so that Order entry has it own emails from order 
 component.this would be to add emails to 
 note: as I go through the different items  this is turning out to be a bigger 
 project than I first anticipated.
 so consider this so far just ideas.
 Maybe break down in to small tasks as I have time to do something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Tax calculation for all order adjustments

2011-12-05 Thread BJ Freeman

are you planning to add this to the svn or just for yourself?

biletnikov sent the following on 12/5/2011 12:41 AM:
 Hello Jacques,
 thanks for the links.
 It is a good idea to keep all tax things in one wiki page.
 However, these articles can not answer my questions.
 
 -
 Kind regards,
 Sergei
 --
 View this message in context: 
 http://ofbiz.135035.n4.nabble.com/Tax-calculation-for-all-order-adjustments-tp4153757p4159696.html
 Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Re: Tax calculation for all order adjustments

2011-12-04 Thread BJ Freeman

I am not familiar with VAT so I can not comment on the best way to
approach this for
VAT.
For USA our Tax Authority is based on Government (IRS) which I guess is
similar to VAT But not on Items but gross profit at the end of the
fiscal year. In manufacturing you can not charge off the deduction of
the piece manufactured till the piece is sold. Under this senario the
calculations are done durring the manufaturing process and is additive,
then assigned to IRIS ledger..

The Tax authority for Sales is based on Geo with separate Tax
authorities. Like State, County, city. These are compounded So
Adjustments are complex in computations.

 I bring this up so that the model that is used will accommodate all Tax
Authority scenarios.

This was not a simple effort when we did it so I don't think a
discussion would be simple.
Maybe a Wiki page would be appropriate to come up with a viable design.



biletnikov sent the following on 12/3/2011 8:16 AM:
 *Current problem:*
 we manage tax calculation for products by setting up a tax authority.
 The tax rate for products is set with TaxAuthorityRateProduct.
 In addition, tax setting for shipping and promotions adjustments can be set
 as special flags to each TaxAuthorityRateProduct (tax shipping/promotion Y
 or N). However, these 2 adjustments are taxed only if productCategoryId is
 empty, and these 2 adjustments look like a hack or temp solution here...
 I faced with a problem, where all adjustments must be taxed (very common
 case for VAT tax system) and it is very unhandy when you have to control the
 tax amount manually. In our case, the system taxes the shipping and
 promotion adjustments, but we have to add Sales tax to all another
 adjustments manually. 
 In addition, OFBiz has tax amount correction logic, which compensates the
 tax difference automatically, example:
 Prdouct 100 euro   
 Sales tax (VAT 19%) = 100 * 0.19 = 19 euro
 Shipping charge 10 euro
 Sales tax (VAT 19%) = 10 * 0.19 = 1.90 euro
 Other adjustment 20 euro
 Sales tax (VAT 19%) = 3.80 euro (we have to add it manually)
 *Sales tax (VAT 19%) = - 3.80 euro * (it is automatically added difference
 to correct the sales tax amount, because the sales tax for other adjustment
 is not taken into account.)
 and we have to delete the last tax adjustment manually.
 
 *Solution:*
 As we have TaxAuthorityRateProduct in OFBiz to manage the taxing of
 products, so why not to have the same mechanism for all adjustments?
 I propose the solution to have the TaxAuthorityRateAdjustment entity.
 TaxAuthorityRateAdjustment will have the following fields:
 
 *Tax type*   (Sales Tax, etc)
 *Store ID*
 *Adjustment Type or (All adjustments)*
 Title Transfer   ???  (I do not know, what can you suggest?)
 *Tax Percentage *
 *From Date *
 *Thru Date*
 *Description*
 
 The settings will be placed in the separate Adjustment rates tab, near to
 Product rates (Tax Authority settings).
 The UI should be very similar!
 
 RE: TaxAuthorityRateProduct
 we should retire 
 *Tax Shipping*
 *Tax Promotions*
 
 The tax calculation service must be reworked,
 
 service name=calcTax engine=java
 location=org.ofbiz.accounting.tax.TaxAuthorityServices
 invoke=rateProductTaxCalc
descriptionTax Authority Rate Product Calc Service/description
implements service=calcTaxInterface/
 /service
 
service name=calcTaxInterface engine=interface location=
 invoke=
descriptionTax Calc Service Interface/description
attribute name=productStoreId type=String mode=IN
 optional=true/attribute
attribute name=facilityId type=String mode=IN
 optional=true/attribute
attribute name=payToPartyId type=String mode=IN
 optional=true/
attribute name=billToPartyId type=String mode=IN
 optional=true/attribute
attribute name=itemProductList type=java.util.List mode=IN
 optional=false/attribute
attribute name=itemAmountList type=java.util.List mode=IN
 optional=false/attribute
attribute name=itemPriceList type=java.util.List mode=IN
 optional=false/attribute
attribute name=itemQuantityList type=java.util.List mode=IN
 optional=true/attribute
attribute name=itemShippingList type=java.util.List mode=IN
 optional=true/attribute
 *   attribute name=orderShippingAmount type=BigDecimal mode=IN
 optional=true/
attribute name=orderPromotionsAmount type=BigDecimal mode=IN
 optional=true/
 *   attribute name=shippingAddress
 type=org.ofbiz.entity.GenericValue mode=IN optional=true/
attribute name=orderAdjustments type=java.util.List mode=OUT
 optional=false/attribute
attribute name=itemAdjustments type=java.util.List mode=OUT
 optional=false/attribute
/service
 
 This interface must have /OrderAdjustment/ list as IN parameter. 
 
 That is my draft solution.
 Any ideas? What is your opinion?
 
 --
 View this message in context: 
 http://ofbiz.135035.n4.nabble.com/Tax-calculation-for-all-order-adjustments-tp4153757p4153757.html
 Sent from the

Re: Tax calculation for all order adjustments

2011-12-04 Thread BJ Freeman

thanks Jacques

Jacques Le Roux sent the following on 12/4/2011 11:03 AM:
 From: BJ Freeman bjf...@free-man.net
 I am not familiar with VAT so I can not comment on the best way to
 approach this for
 VAT.
 For USA our Tax Authority is based on Government (IRS) which I guess is
 similar to VAT But not on Items but gross profit at the end of the
 fiscal year. In manufacturing you can not charge off the deduction of
 the piece manufactured till the piece is sold. Under this senario the
 calculations are done durring the manufaturing process and is additive,
 then assigned to IRIS ledger..

 The Tax authority for Sales is based on Geo with separate Tax
 authorities. Like State, County, city. These are compounded So
 Adjustments are complex in computations.

 I bring this up so that the model that is used will accommodate all Tax
 Authority scenarios.

 This was not a simple effort when we did it so I don't think a
 discussion would be simple.
 Maybe a Wiki page would be appropriate to come up with a viable design.

 There is already a page with some points
 https://cwiki.apache.org/confluence/display/OFBIZ/VAT
 
 Ha , and I forgot the
 https://cwiki.apache.org/confluence/display/OFBTECH/OFBiz%27s+Tax+Authority+Data+Model
 which is maybe not up to date...
 
 Jacques
 
 Jacques



 biletnikov sent the following on 12/3/2011 8:16 AM:
 *Current problem:*
 we manage tax calculation for products by setting up a tax authority.
 The tax rate for products is set with TaxAuthorityRateProduct.
 In addition, tax setting for shipping and promotions adjustments can
 be set
 as special flags to each TaxAuthorityRateProduct (tax
 shipping/promotion Y
 or N). However, these 2 adjustments are taxed only if
 productCategoryId is
 empty, and these 2 adjustments look like a hack or temp solution
 here...
 I faced with a problem, where all adjustments must be taxed (very
 common
 case for VAT tax system) and it is very unhandy when you have to
 control the
 tax amount manually. In our case, the system taxes the shipping and
 promotion adjustments, but we have to add Sales tax to all another
 adjustments manually. In addition, OFBiz has tax amount correction
 logic, which compensates the
 tax difference automatically, example:
 Prdouct 100 euro   Sales tax (VAT 19%) = 100 * 0.19 = 19 euro
 Shipping charge 10 euro
 Sales tax (VAT 19%) = 10 * 0.19 = 1.90 euro
 Other adjustment 20 euro
 Sales tax (VAT 19%) = 3.80 euro (we have to add it manually)
 *Sales tax (VAT 19%) = - 3.80 euro * (it is automatically added
 difference
 to correct the sales tax amount, because the sales tax for other
 adjustment
 is not taken into account.)
 and we have to delete the last tax adjustment manually.

 *Solution:*
 As we have TaxAuthorityRateProduct in OFBiz to manage the taxing of
 products, so why not to have the same mechanism for all adjustments?
 I propose the solution to have the TaxAuthorityRateAdjustment entity.
 TaxAuthorityRateAdjustment will have the following fields:

 *Tax type*   (Sales Tax, etc)
 *Store ID*
 *Adjustment Type or (All adjustments)*
 Title Transfer   ???  (I do not know, what can you suggest?)
 *Tax Percentage *
 *From Date *
 *Thru Date*
 *Description*

 The settings will be placed in the separate Adjustment rates tab,
 near to
 Product rates (Tax Authority settings).
 The UI should be very similar!

 RE: TaxAuthorityRateProduct
 we should retire *Tax Shipping*
 *Tax Promotions*

 The tax calculation service must be reworked,

 service name=calcTax engine=java
 location=org.ofbiz.accounting.tax.TaxAuthorityServices
 invoke=rateProductTaxCalc
descriptionTax Authority Rate Product Calc
 Service/description
implements service=calcTaxInterface/
 /service

service name=calcTaxInterface engine=interface location=
 invoke=
descriptionTax Calc Service Interface/description
attribute name=productStoreId type=String mode=IN
 optional=true/attribute
attribute name=facilityId type=String mode=IN
 optional=true/attribute
attribute name=payToPartyId type=String mode=IN
 optional=true/
attribute name=billToPartyId type=String mode=IN
 optional=true/attribute
attribute name=itemProductList type=java.util.List
 mode=IN
 optional=false/attribute
attribute name=itemAmountList type=java.util.List mode=IN
 optional=false/attribute
attribute name=itemPriceList type=java.util.List mode=IN
 optional=false/attribute
attribute name=itemQuantityList type=java.util.List
 mode=IN
 optional=true/attribute
attribute name=itemShippingList type=java.util.List
 mode=IN
 optional=true/attribute
 *   attribute name=orderShippingAmount type=BigDecimal
 mode=IN
 optional=true/
attribute name=orderPromotionsAmount type=BigDecimal
 mode=IN
 optional=true/
 *   attribute name=shippingAddress
 type=org.ofbiz.entity.GenericValue mode=IN optional=true/
attribute name=orderAdjustments type=java.util.List
 mode=OUT
 optional=false

Re: multiflex theme

2011-11-24 Thread BJ Freeman

those that upgrade and have use that will be left in the dark.
suggest you zip and archive then put a text message in te multiflex
folder telling them where to pull it down and how to install it

Hans Bakker sent the following on 11/24/2011 7:14 PM:
 Can we delete the themes/multiflex directory?
 
 This theme is not in the theme selection list..
 
 Regards,
 Hans

Re: Why not overcome minlang's weakness.....attract new developers instead of letting something so easily fixed scare them off

2011-11-21 Thread BJ Freeman

I am not sure how you first paragraph relates to minilang and jumping.
Minilang is defines as events (not ECA) or Service in other places. This
is the same for Java and would require the same tracing. ECA are keyed
off of ENtities changes and Service, whether Minilang or Java.

Simple has nothing to do with the length of code but making a line of
code that takes multiple java code lines to accomplish.

I do agree that all mini code should be reviewed and take repetitive
code and break it out as a re-factor. That is a major effort and based
on the way people code and add to the SVN without reviewing what code is
available, I doubt it would stay clean.




ki...@objectedge.com sent the following on 11/20/2011 8:21 AM:
 I agree that minilang is easy understand as long as the methods are truly 
 simple. i.e: you don't have to jump between other methods/services, eca 
 rules, etc.
 
 Take an example of createCustomermethod in ecommerce. This simple-method 
 is over 400 lines. How is that simple :-) Now whether you write it java or 
 minilang it will be difficult for the reader to understand. But I feel it 
 is better to write such methods in Java. Of course, even in Java it should 
 be made more modular (using refactoring tools). Then you can use find 
 references or implementation. Selecting variable highlights it across 
 entire method/class. You can use debugging tools: set breakpoint, view 
 variables, step in/over, drop to frame, etc. 
 
 Ideally the simple-method shouldn't grow beyond scrollable window in 
 Eclipse say 40 lines.
 
 Regards,
 Kiran Gawde
 
 Senior Software Architect
 Object Edge Inc
 (925) 943 5558 x108
 
 There are two kind of people: Those who do the work and those who take 
 the credit. Try to be in the first group because there is less competition 
 there.
 Never give up on what you really want to do. The person with big dreams 
 is more powerful than one with all the facts.
 
 
 
 
 From:   BJ Freeman bjf...@free-man.net
 To: dev@ofbiz.apache.org
 Date:   11/19/2011 06:07 PM
 Subject:Re: Why not overcome minlang's weakness.attract new 
 developers instead of letting something so easily fixed scare them off
 
 
 
 short answer is to add to webtools artifacts. Have you investigated that
 section of ofbiz?
 The basics is Java increases bloat by creating classes.
 I find the concept the ofbiz is java based is what throws a lot of
 people. The frame of mind that Ofbiz was made to work in a java
 environment is more accurate in my opinion.
 It takes more lines of code in Java to accomplish the same n minilang.
 However a happy medium is to use Grovvy.
 
 I shy away from Opentaps because they broke the design rules that
 brought me to ofbiz.
 
 Justin Robinson sent the following on 11/19/2011 4:57 AM:
 But Minilang would be the better option because with Minilang, the
 developers time is much reduced as it is used to implement simple and
 repetitive tasks - from the article  OFBiz Framework: An Innovative
 Approach to E-commerce
 http://www.dotcominfoway.com/blog/ofbiz-framework-an-innovative-approach-to-e-commerce


 Why not overcome minlang's weakness.

 Minilang seems to be one of the reasons for the branch in projects (well
 that's entirely speculation on my part)it seems a bone of contention
 and I've seen posts where people complain about how difficult it is to
 debug, how they've had to get rid of developers who refused to learn it.
 On the wiki of one of the main down stream projects Opentaps it says: 
 don't
 ever write one in
 minilang!http://www.opentaps.org/docs/index.php/Danc_-_temp#Services


 I personally don't enjoy working in minilang, scanning hundreds of lines 
 of
 minilang   then using 'simple method' names together with search  
 find
 to move between files to trace a path of execution looking for a bug or
 that one small operation somewhere in the service chain I need to 
 disable,
 gives me a headache.

 However a couple of months ago I decided to rewrite a minilang method in
 java so that I could alter it's functionality, it had to do with 
 processing
 returns, anyway by the end of it I had a better understanding of the 
 *upside
 to minlang*, because all it does is move data around by calling other
 simple methods, *to write that in java takes a lot more code then it 
 does
 in minilang*...

 Grouping business logic into modular scripts called simple methods and
 then using what has be already been defined as building blocks to weave
 into the already existing web of simple methods, your new customised 
 higher
 level service seems a good idea to me.

 The problem as I see it is there is no tool or framework to quickly get
 information about what services exist, how would they'd effect the data 
 and
 what their IN's and OUT's are, in other words how they'd best fit 
 together;
 in order to define a new one that will fit the specific needs for the
 service I'm writing.
 When I use words like weave and web, anyone who has worked

Re: Why not overcome minlang's weakness.....attract new developers instead of letting something so easily fixed scare them off

2011-11-19 Thread BJ Freeman

short answer is to add to webtools artifacts. Have you investigated that
section of ofbiz?
The basics is Java increases bloat by creating classes.
I find the concept the ofbiz is java based is what throws a lot of
people. The frame of mind that Ofbiz was made to work in a java
environment is more accurate in my opinion.
It takes more lines of code in Java to accomplish the same n minilang.
However a happy medium is to use Grovvy.

I shy away from Opentaps because they broke the design rules that
brought me to ofbiz.

Justin Robinson sent the following on 11/19/2011 4:57 AM:
 But Minilang would be the better option because with Minilang, the
 developers time is much reduced as it is used to implement simple and
 repetitive tasks - from the article  OFBiz Framework: An Innovative
 Approach to 
 E-commercehttp://www.dotcominfoway.com/blog/ofbiz-framework-an-innovative-approach-to-e-commerce
 
 Why not overcome minlang's weakness.
 
 Minilang seems to be one of the reasons for the branch in projects (well
 that's entirely speculation on my part)it seems a bone of contention
 and I've seen posts where people complain about how difficult it is to
 debug, how they've had to get rid of developers who refused to learn it.
 On the wiki of one of the main down stream projects Opentaps it says: don't
 ever write one in
 minilang!http://www.opentaps.org/docs/index.php/Danc_-_temp#Services
 
 
 I personally don't enjoy working in minilang, scanning hundreds of lines of
 minilang   then using 'simple method' names together with search  find
 to move between files to trace a path of execution looking for a bug or
 that one small operation somewhere in the service chain I need to disable,
 gives me a headache.
 
 However a couple of months ago I decided to rewrite a minilang method in
 java so that I could alter it's functionality, it had to do with processing
 returns, anyway by the end of it I had a better understanding of the *upside
 to minlang*, because all it does is move data around by calling other
 simple methods, *to write that in java takes a lot more code then it does
 in minilang*...
 
 Grouping business logic into modular scripts called simple methods and
 then using what has be already been defined as building blocks to weave
 into the already existing web of simple methods, your new customised higher
 level service seems a good idea to me.
 
 The problem as I see it is there is no tool or framework to quickly get
 information about what services exist, how would they'd effect the data and
 what their IN's and OUT's are, in other words how they'd best fit together;
 in order to define a new one that will fit the specific needs for the
 service I'm writing.
 When I use words like weave and web, anyone who has worked in minilang
 knows what I mean. But how many GUI development tools exist to deal with
 just that exact same problem in other frameworks? I can think of a few open
 source eclipse plug-ins that would act as a good starting template, to
 create such a tool.
 
 In some ofbiz supported enterprises I suspect that they, even have their
 team set-up to get get around these problems, with say a master weaver who
 facilitates the integration of new simple methods.
 
 Meta-programming definitely has it's advantages, but for places where it's
 gained the most *popularity*, it usually comes with a tool which supports
 it's use.
 *Then every one ruled by reason can create service solutions in ofbiz, not
 just the programmers willing to learn minilang!*
 
 I'd be more then happy to donate some time to such an undertaking if anyone
 else thinks it's worth the effort?

Re: verification email

2011-11-19 Thread BJ Freeman

all submits have been changed to  POst and will note accept gets.
Yes my email client converts all HTML to text, so if the link produced
is not supported then can not use the link.

I change the verification page generates a code with the link goes to a
new form what they paste the verification code in.


ki...@objectedge.com sent the following on 11/17/2011 5:48 PM:
 Additional info:
 
 Looks like around Sept 09, newcustomer and viewprofile screen were 
 reengineered. Not sure, if during that time it was decided to drop the 
 contact list from view profile page. Also, seems like there is no place to 
 view and edit credit card information. Here are few other screens that 
 were included in original viewprofile.ftl. Seems like we lost lot of 
 functionality during this reengineering!!
 
 ${screens.render(
 component://ecommerce/widget/CustomerScreens.xml#messagelist-include)}
 
 ${screens.render(
 component://ecommerce/widget/CustomerScreens.xml#FinAccountList-include
 )}
 
 #-- Serialized Inventory Summary --
 ${screens.render(
 'component://ecommerce/widget/CustomerScreens.xml#SerializedInventorySummary'
 )}
 
 #-- Subscription Summary --
 ${screens.render(
 'component://ecommerce/widget/CustomerScreens.xml#SubscriptionSummary')}
 
 Also, ManageAddress.ftl refers to ViewProfile.groovy only for 
 partyContactMechValueMaps. Remaining values retrieved from db are not 
 used. May be we should create separate groovy file with just that. 
 
 Regards,
 Kiran Gawde
 
 Senior Software Architect
 Object Edge Inc
 (925) 943 5558 x108
 
 There are two kind of people: Those who do the work and those who take 
 the credit. Try to be in the first group because there is less competition 
 there.
 Never give up on what you really want to do. The person with big dreams 
 is more powerful than one with all the facts.
 
 
 
 
 From:   ki...@objectedge.com
 To: dev@ofbiz.apache.org
 Date:   11/17/2011 04:44 PM
 Subject:Re: verification email
 
 
 
 Additional info:
 
 There is viewprofile link in the email. But I think, it is going to wrong 
 page.
 
 i.e: there are two viewprofile.ftl
 component://ecommerce/webapp/ecommerce/customer/profile/ViewProfile.ftl
 component://ecommerce/webapp/ecommerce/customer/viewProfile.ftl
 
 I believe, view profile link in email is suppose to point to second ftl. 
 If I get the confirmation, I will do the change and submit the patch.
 
 Regards,
 Kiran Gawde
 
 Senior Software Architect
 Object Edge Inc
 (925) 943 5558 x108
 
 There are two kind of people: Those who do the work and those who take 
 the credit. Try to be in the first group because there is less competition 
 
 there.
 Never give up on what you really want to do. The person with big dreams 
 is more powerful than one with all the facts.
 
 
 
 
 From:   ki...@objectedge.com
 To: dev@ofbiz.apache.org
 Date:   11/17/2011 04:18 PM
 Subject:verification email
 
 
 
 Hi,
 
 When user registers for newsletter on ecommerce site, ofbiz sends the 
 verification email. The email has form and submit button. Some email 
 client won't allow the form submit.
 
 Hence, I tried changing it to hyperlink but it gives following error. Does 
 
 
 anyone have better idea?
 
 Request updateContactListPartyNoUserLogin caused an error with the 
 following message: Error calling event: 
 org.ofbiz.webapp.event.EventHandlerException: Found URL parameter 
 [contactListId] passed to secure (https) request-map with uri 
 [updateContactListPartyNoUserLogin] with an event that calls service 
 [updateContactListPartyNoUserLogin]; this is not allowed for security 
 reasons! The data should be encrypted by making it part of the request 
 body (a form field) instead of the request URL. Moreover it would be kind 
 if you could create a Jira sub-task of 
 https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a 
 sub-task for this error does not exist). If you are not sure how to create 
 
 
 a Jira issue please have a look before at 
 http://cwiki.apache.org/confluence/x/JIB2 Thank you in advance for your 
 help.
 
 Regards,
 Kiran Gawde
 
 Senior Software Architect
 Object Edge Inc
 (925) 943 5558 x108
 
 There are two kind of people: Those who do the work and those who take 
 the credit. Try to be in the first group because there is less competition 
 
 
 there.
 Never give up on what you really want to do. The person with big dreams 
 is more powerful than one with all the facts.

[jira] [Commented] (OFBIZ-3894) Refactor Email handling

2011-11-14 Thread BJ Freeman (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149757#comment-13149757
 ] 

BJ Freeman commented on OFBIZ-3894:
---

Interested in helping where I can.
Since I have branched, I have on test bed to use.


 Refactor Email handling
 ---

 Key: OFBIZ-3894
 URL: https://issues.apache.org/jira/browse/OFBIZ-3894
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: BJ Freeman
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-3894.patch, OFBIZ-3894.patch, OFBIZ-3894.patch

   Original Estimate: 1,344h
  Remaining Estimate: 1,344h

 with the addition of the Website for each component 
 1) create product store for Order entry, or use the B2C product store.
 2) move the email  widgets from ecommerce to order compontent.
 3) modify the seed data so that Order entry has it own emails from order 
 component.this would be to add emails to 
 note: as I go through the different items  this is turning out to be a bigger 
 project than I first anticipated.
 so consider this so far just ideas.
 Maybe break down in to small tasks as I have time to do something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (OFBIZ-3894) Refactor Email handling

2011-11-14 Thread BJ Freeman (Issue Comment Edited) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149757#comment-13149757
]

BJ Freeman edited comment on OFBIZ-3894 at 11/14/11 5:31 PM:
-

Interested in helping where I can.
Since I have branched, I have no test bed to use.

was (Author: bjfreeman):
Interested in helping where I can.
Since I have branched, I have on test bed to use.

Refactor Email handling
---

Key: OFBIZ-3894
URL: https://issues.apache.org/jira/browse/OFBIZ-3894
Project: OFBiz
Issue Type: Improvement
Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: BJ Freeman
Priority: Minor
Fix For: SVN trunk

Attachments: OFBIZ-3894.patch, OFBIZ-3894.patch, OFBIZ-3894.patch

Original Estimate: 1,344h
Remaining Estimate: 1,344h

with the addition of the Website for each component
1) create product store for Order entry, or use the B2C product store.
2) move the email widgets from ecommerce to order compontent.
3) modify the seed data so that Order entry has it own emails from order
component.this would be to add emails to
note: as I go through the different items this is turning out to be a bigger
project than I first anticipated.
so consider this so far just ideas.
Maybe break down in to small tasks as I have time to do something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Incorrect use of eca for create/updateShipment

2011-11-08 Thread BJ Freeman

we actually have two levels.
you have the entity level, similar to the Triggered procedures used in
Databases where any action of the data is evaluated, even at creation
time. the Difference is that most validation is Done the thing is
Validation can be done at the Entity engine level, So most EECA are used
after the creation of the data.

The other level is business flow. the decision to use SOA and/or ECA is
a Design call and will very with the Designer background. I have brokend
it down that porcesses that over many business flows will not change are
SOA. what was one defined as hooks in C code would the the ECA

Jacques Le Roux sent the following on 11/4/2011 2:59 PM:
I think that if we want to discuss this seriously we need to have 1st a
clear and complete workflow of ECA use in OFBiz.

IMO, the Event Driven Architecture (EDA)
http://en.wikipedia.org/wiki/Event-driven_architecture, is well adapted
to complete SOA
(Service Oriented Architecture). But one Criticism of Event Driven
Programming
(http://en.wikipedia.org/wiki/Event-driven_programming#Criticism_and_best_practice)
apply: it can lead programmers to create
difficult to extend and, especially, excessively complex application
code. So it's rather a matter of use and abuse.

In other words, I'd be ok to remove abuse but not use. In some cases
it's very convenient...

Jacques

J. Eckard wrote:
I spend a great deal of time reading through existing OFBiz codebases
to get a handle on process implementations, an experience
that feels much more tedious and frustrating than it should.

One of the things that contributes to the difficulty is the practice
of using EECAs and / or SECAs to orchestrate a basic process
with smaller, specialized services.

I was hesitant to bring this up because I don't have any concrete
suggestions or guidelines for improvements - its more of a
nagging feeling I get when I see ECAs that are not very generic or
used outside of the orchestration, or ECAs that perform
crucial tasks that you would never want to disable or remove.

Joe

On Nov 3, 2011, at 2:12 PM, Adrian Crum wrote:

Actually, what I recommended was a discussion on using/removing ECAs
in general - not this specific case.

-Adrian

On 11/3/2011 5:15 PM, ki...@objectedge.com wrote:
Hello Friends,

In case of createShipment, during commit, eca rules are fired. These
invoke updateShipment(i.e: even before commit on createShipment is
complete). Update Shipment is called multiple times (You can view
the log
during quickShipOrder/quickDropShipOrder). Also, these rules are
fired in
incorrect order. These rules are updating the same shipment that is
being
committed by the original method. I believe this is incorrect.

I have verified the functionality of quickShipOrder/quickDropShipOrder
after the changes. Let me know if there are any testcases that I
need to
run. Please take a look at email thread for more details. Let me
know if
you have questions and concerns. If we integrate the change sooner,
we can
avoid merge conflicts.

PS: Thanks Adrian and Anil for your vote of confidence. As per your
recommendation, I am posting this to dev mailing list.

Regards,
Kiran Gawde

Senior Software Architect
Object Edge Inc
(925) 943 5558 x108

There are two kind of people: Those who do the work and those who take
the credit. Try to be in the first group because there is less
competition
there.
Never give up on what you really want to do. The person with big
dreams
is more powerful than one with all the facts.

From: Adrian Crum (Commented) (JIRA)j...@apache.org
To: ki...@objectedge.com
Date: 11/03/2011 02:04 AM
Subject:[jira] [Commented] (OFBIZ-4501) Incorrect use of eca
for
create/updateShipment

[
https://issues.apache.org/jira/browse/OFBIZ-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142972#comment-13142972

]

Adrian Crum commented on OFBIZ-4501:

Kiran,

Thank you for working on this. I agree that the overuse of ECAs causes
problems and makes the services difficult to troubleshoot. But removing
them is going to be a tough sell because many in the community see
it as a
feature - they see it as a crude form of a workflow implementation.
I have
added my vote to this issue because I believe a lot of the ECAs
should go
away. It might help your cause to start a discussion on the dev mailing
list and see if you can rally some more support for ECA removal.

Incorrect use of eca for create/updateShipment
--

Key: OFBIZ-4501
URL: https://issues.apache.org/jira/browse/OFBIZ-4501
Project: OFBiz
Issue Type: Bug
Components: product
Affects Versions: Release Branch 11.04, SVN trunk
Reporter: Kiran Gawde
Attachments:

[jira] [Commented] (OFBIZ-1286) configuable emails for Purchase orders

2011-10-20 Thread BJ Freeman (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131839#comment-13131839
 ] 

BJ Freeman commented on OFBIZ-1286:
---

see https://issues.apache.org/jira/browse/OFBIZ-3894


 configuable emails for Purchase orders
 --

 Key: OFBIZ-1286
 URL: https://issues.apache.org/jira/browse/OFBIZ-1286
 Project: OFBiz
  Issue Type: New Feature
  Components: order
Affects Versions: SVN trunk
Reporter: BJ Freeman

 Like in the products store have a configurable email for sending to suppliers.
 This is the first step to setting up different communication to a supplier.
 eventually you will be able to add in services that send via different forms.
 See emails like Orinal PO
 followup on order
 followup on item
 returnAuthoriationRequest
 I see putting the form in the Facility module like is in the productsStore
 So just like productstore,  the Emails can be configured per supplier.
 any other input welcome

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4489) username cannot be assign security permission

2011-10-20 Thread BJ Freeman (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131908#comment-13131908
]

BJ Freeman commented on OFBIZ-4489:
---

#2 you can create a defualt Party or PartyGroup that all logins you might
created ths way.
The usng the drop down or lookup for partyID that would be added you can select
that partyID.
This then allows the login to appear in the Selected ParrtyID, and you can then
modify/add security and roles..
This also make it easier to maintain the login for a particular function.

username cannot be assign security permission
-

Key: OFBIZ-4489
URL: https://issues.apache.org/jira/browse/OFBIZ-4489
Project: OFBiz
Issue Type: Bug
Components: party
Affects Versions: SVN trunk
Reporter: Wai

PartyMgr permits the creation of a new username(or userLogin) without being
associated with a party/partygroup. As a result, the new username cannot be
assign to a securitygroup and hence cannot be used to access the system.
Possible solution:
1. Fix code to allow a party-less username to be assigned to a securitygroup.
2. All created username must be associated with a party.
Reference discussion about this issue:
http://ofbiz.135035.n4.nabble.com/creating-a-new-user-login-td3905814.html

[jira] [Commented] (OFBIZ-4489) username cannot be assign security permission

2011-10-19 Thread BJ Freeman (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13130502#comment-13130502
 ] 

BJ Freeman commented on OFBIZ-4489:
---

#1 can be simulated with the Ant command to create an admin.
It will not show up on any UI except Webtools viewing the Userlogin entity. 
This is the only way presently to add security and a partyID.
I am trying to think of a business case this would be needed.


 username cannot be assign security permission
 -

 Key: OFBIZ-4489
 URL: https://issues.apache.org/jira/browse/OFBIZ-4489
 Project: OFBiz
  Issue Type: Bug
  Components: party
Affects Versions: SVN trunk
Reporter: Wai

 PartyMgr permits the creation of a new username(or userLogin) without being 
 associated with a party/partygroup.  As a result, the new username cannot be 
 assign to a securitygroup and hence cannot be used to access the system.
 Possible solution:
 1. Fix code to allow a party-less username to be assigned to a securitygroup.
 2. All created username must be associated with a party.
 Reference discussion about this issue:
 http://ofbiz.135035.n4.nabble.com/creating-a-new-user-login-td3905814.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: ServiceName vs CustomMethod

2011-10-13 Thread BJ Freeman

the modeling for CustomMethod  has been like a Hook in C lanquage.
this allows future addition and selection to performs an operation, to
achieve a particular outcome.
so if you want to have multiple services available for a Template, then
use CustomMethod, otherwise specify the service.

Nicolas Malin sent the following on 10/12/2011 12:42 PM:
 No opinion ?
 
 Le 07/10/2011 18:18, Nicolas Malin a écrit :
 Hi,

 I continue my analysis to use EmailTemplateSetting with Content. My
 idea is to use a service to retrieve information needed to merge with
 template content before sending the email. The system  already use
 Content entity, great ! But to manage template, the field
 Content.serviceName isn't really useful for user's screen.

 Do a reason exist to use serviceName instead of a relation with
 CustomMethod entity ? Historical ?

 With the CustomMethod and CustomMethodType, it's easier to show
 available services to advanced user.
 Any suggest ?

 Nicolas

Re: Multi-tenant ecommerce

2011-10-11 Thread BJ Freeman

https://issues.apache.org/jira/browse/OFBIZ-3579
if you add something.
tenant was designed to get ID from login.
so for ecommerce you need to have separated webapps like eccomerclone,
and put the tenantID in the web.xml.
the problems I believe is how do you select which webapplication is
selected for which URL.
mysubdomain.domain.com
www.mydoamin.com
There is a patch I believe where the virtualhost is put in the web.xml
as well.
I took a difference approach using Website entity.

Gareth O'Brien sent the following on 10/9/2011 6:47 AM:
 Ofbiz looks like exactly what I need for an upcoming project (thanks all for
 that) and I will need multi-tenant behaviour to the ecommerce side if it's
 not there.
 
  
 
 https://cwiki.apache.org/OFBIZ/multitenancy-support.html states that:
 Currently the Ecommerce for Tenants is not supported.
 
  
 
 Question:
 
 Is this still correct?
 
  
 
 Assuming yes can anyone give an indication of how big a job it would be to
 make the ecommerce portion multi-tenant on exactly the same basis as the
 backend application is already? i.e. individual database per tenant but a
 single web application.
 
  
 
 It looks like I will need this if the project goes ahead, so I'd like to get
 my head around how massive a job it might be.
 
  
 
 Thanks,
 
  
 
 Gareth.

[jira] [Commented] (OFBIZ-4396) Project Manager Gantt chart does not display correctly using any of the visual themes

2011-10-04 Thread BJ Freeman (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120310#comment-13120310
 ] 

BJ Freeman commented on OFBIZ-4396:
---

Either change the Flat Grey or Create a New theme that has all the bells an 
whistles you want an Give you the support for the Gnatt  and submit a patch to 
this Jira

 Project Manager Gantt chart does not display correctly using any of the 
 visual themes
 -

 Key: OFBIZ-4396
 URL: https://issues.apache.org/jira/browse/OFBIZ-4396
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Affects Versions: Release 10.04
 Environment: RHEL 5.5 
 JDK 1.6 
 MySQL 5
Reporter: Tolulope Aganga-Williams
Priority: Minor
  Labels: jsgantt, projectmgr

 The Gannt chart displays incorrectly in every browser and using any visual 
 theme. The chart does not align the task on the left to the progress bar on 
 the right. The problem is bad to severe depending on which visual theme you 
 have enabled. I have even updated to the latest JSGantt some improvement but 
 does not fix it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4396) Project Manager Gantt chart does not display correctly using any of the visual themes

2011-10-04 Thread BJ Freeman (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120374#comment-13120374
 ] 

BJ Freeman commented on OFBIZ-4396:
---

https://issues.apache.org/jira/browse/OFBIZ-3490
may be helpful

 Project Manager Gantt chart does not display correctly using any of the 
 visual themes
 -

 Key: OFBIZ-4396
 URL: https://issues.apache.org/jira/browse/OFBIZ-4396
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Affects Versions: Release 10.04
 Environment: RHEL 5.5 
 JDK 1.6 
 MySQL 5
Reporter: Tolulope Aganga-Williams
Priority: Minor
  Labels: jsgantt, projectmgr

 The Gannt chart displays incorrectly in every browser and using any visual 
 theme. The chart does not align the task on the left to the progress bar on 
 the right. The problem is bad to severe depending on which visual theme you 
 have enabled. I have even updated to the latest JSGantt some improvement but 
 does not fix it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4396) Project Manager Gantt chart does not display correctly using any of the visual themes

2011-10-03 Thread BJ Freeman (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119431#comment-13119431
 ] 

BJ Freeman commented on OFBIZ-4396:
---

The Link I gave shows a css just for gnatt chart.
So I would look if this css is loaded after the Themes or before.
Then look to see if any css in themes has any thing related tot he gnatt chart.
Due to my time, I don't have time to do this.

 Project Manager Gantt chart does not display correctly using any of the 
 visual themes
 -

 Key: OFBIZ-4396
 URL: https://issues.apache.org/jira/browse/OFBIZ-4396
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Affects Versions: Release 10.04
 Environment: RHEL 5.5 
 JDK 1.6 
 MySQL 5
Reporter: Tolulope Aganga-Williams
Priority: Minor
  Labels: jsgantt, projectmgr

 The Gannt chart displays incorrectly in every browser and using any visual 
 theme. The chart does not align the task on the left to the progress bar on 
 the right. The problem is bad to severe depending on which visual theme you 
 have enabled. I have even updated to the latest JSGantt some improvement but 
 does not fix it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Java 7

2011-10-03 Thread BJ Freeman

I think a branch would be appropriate

Jacques Le Roux sent the following on 10/3/2011 3:50 AM:
 Hi,
 
 One day or another we will have to move to Java 7, I believe.
 http://www.eclipse.org/jdt/ui/r3_8/Java7news/whats-new-java-7.html
 
 Opinions?
 
 Jacques

[jira] [Commented] (OFBIZ-4396) Project Manager Gantt chart does not display correctly using any of the visual themes

2011-10-02 Thread BJ Freeman (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119095#comment-13119095
 ] 

BJ Freeman commented on OFBIZ-4396:
---

Suggest you directly contact the author
http://svn.apache.org/viewvc?view=revisionrevision=931925

 Project Manager Gantt chart does not display correctly using any of the 
 visual themes
 -

 Key: OFBIZ-4396
 URL: https://issues.apache.org/jira/browse/OFBIZ-4396
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Affects Versions: Release 10.04
 Environment: RHEL 5.5 
 JDK 1.6 
 MySQL 5
Reporter: Tolulope Aganga-Williams
Priority: Minor
  Labels: jsgantt, projectmgr

 The Gannt chart displays incorrectly in every browser and using any visual 
 theme. The chart does not align the task on the left to the progress bar on 
 the right. The problem is bad to severe depending on which visual theme you 
 have enabled. I have even updated to the latest JSGantt some improvement but 
 does not fix it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: discussion: party preference and user(loginId) preference

2011-09-30 Thread BJ Freeman

I was more showing how this model would allow easier expansion.
was not suggesting that preferences were to be proliferated.

Jacques Le Roux sent the following on 9/29/2011 11:57 PM:
 I don't see anyh other types of preferences, but I'm sure reality can
 come with few. So yes, it looks like a good idea to me to have that
 
 Jacques
 
 From: BJ Freeman bjf...@free-man.net
 sorry if I was not clear
 add preferenceID to Party, partyGroup, and change the userlogin to
 preferenceID. this is a one to one. So each one can have preference
 independent and specific to that level.
 So the Party Group would be first, then add the Party that is Associated
 then lookup the userlogin if there is one logged in, but this is not
 reqired, just one way to structure veiws and code.
 if you access a party then you can find the preferences by looking up
 the Preferennce through preferenceID or do a view PartyPreference.
 for migration you can have a view UserPreference for userlogin

 you can further have preferences with partyreltionship and roles. By
 Just Adding a preferenceID


 Hans Bakker sent the following on 9/29/2011 6:27 AM:
 Hi BJ,
 Is an interesting solution, however only one problem...how about a party
 without a userlogin?

 Regards,Hans

 On Thu, 2011-09-29 at 05:53 -0700, BJ Freeman wrote:
 guess I should address you orginal requirement.
 you would link to preference from party or login with either Pary or
 user type. So add the preference ID to party.
 then have a preference Item with one to many to preference

 BJ Freeman sent the following on 9/29/2011 4:54 AM:
 #3. rename to Preferences with a TypeID added.
 However use the logniID to find the Preference with the type Party.
 since we now have the login tied to the partryID already.


 Hans Bakker sent the following on 9/29/2011 3:11 AM:
 Thanks BJ for the comment.

 In order to keep the framework (login preference) and party
 preference
 separated i would like to suggest to either:

 1. extend the UserPreference entity and adding the field partyId
 to the
 key, override the related services and make the PartyId mandatory.
 2. copy the UserPreference and call it PartyPreference and replace
 the
 userLogin with the partyId and create similar services in the party
 component.

 anybody any comments?

 Regards,
 Hans

 On Mon, 2011-09-26 at 21:24 -0700, BJ Freeman wrote:
 I can see the case for both
 I have taken the approach to start with
 partyrelations.rollup.roles (not
 as defined by ofbiz, but the datamodel book) that a userloginId has,
 against the PartyID info available.
 that is a lot more detailed than I think you looking for.


 Hans Bakker sent the following on 9/26/2011 7:12 PM:
 Currently we have a userLoginId preference. What is fine for
 preferences
 in screens etc.

 However we would would like to have preferences on a party
 level, like
 email notification preferences. This is rather difficult at the
 moment
 because if you specify these at the userLogin level and there are 5
 userlogins for a user what to do? If you only know the partyId?

 System messages or orders are an example, there only partyId is
 known
 and not the specific userloginId. We would also like to send
 notifications when an email comes is, where also only partyId is
 known.

 Any opinions here?

 Regards,
 Hans

[jira] [Commented] (OFBIZ-4453) Refactoring JMS Handling

2011-09-30 Thread BJ Freeman (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118293#comment-13118293
 ] 

BJ Freeman commented on OFBIZ-4453:
---

Since JMSservice is commented out could you give a reason you see this 
important.
More for my edification

 Refactoring JMS Handling
 

 Key: OFBIZ-4453
 URL: https://issues.apache.org/jira/browse/OFBIZ-4453
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Dimitri Unruh
 Attachments: JMS-keep-connection.patch


 This is the main ticket for the JMS refactoring tasks.
 I would like to start here some concept discussion ant the create sub-tasks...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: discussion: party preference and user(loginId) preference

#3. rename to Preferences with a TypeID added.
However use the logniID to find the Preference with the type Party.
since we now have the login tied to the partryID already.


Hans Bakker sent the following on 9/29/2011 3:11 AM:
 Thanks BJ for the comment.
 
 In order to keep the framework (login preference) and party preference
 separated i would like to suggest to either:
 
 1. extend the UserPreference entity and adding the field partyId to the
 key, override the related services and make the PartyId mandatory.
 2. copy the UserPreference and call it PartyPreference and replace the
 userLogin with the partyId and create similar services in the party
 component.
 
 anybody any comments?
 
 Regards,
 Hans
 
 On Mon, 2011-09-26 at 21:24 -0700, BJ Freeman wrote:
 I can see the case for both
 I have taken the approach to start with partyrelations.rollup.roles (not
 as defined by ofbiz, but the datamodel book) that a userloginId has,
 against the PartyID info available.
 that is a lot more detailed than I think you looking for.


 Hans Bakker sent the following on 9/26/2011 7:12 PM:
 Currently we have a userLoginId preference. What is fine for preferences
 in screens etc.

 However we would would like to have preferences on a party level, like
 email notification preferences. This is rather difficult at the moment
 because if you specify these at the userLogin level and there are 5
 userlogins for a user what to do? If you only know the partyId?

 System messages or orders are an example, there only partyId is known
 and not the specific userloginId. We would also like to send
 notifications when an email comes is, where also only partyId is known.

 Any opinions here?

 Regards,
 Hans

Re: discussion: party preference and user(loginId) preference

I like to see the item model used in orders and agreements.
this lets preferences to expand in the futures without redesign

Nicolas Malin sent the following on 9/29/2011 4:21 AM:
 I also agree with Adrian, on beautyfull world PartyPreference just
 contains only functionnal preference while UserPreference embeds
 navigation information (or useful information) to work with OFBiz IHM
 
 Nicolas
 
 Jacques Le Roux a écrit :
 I agree with Adrian. But then we will not have the possibility to have
 preferences by logins, only parties. Not sure it's a big deal, maybe
 should be considered? (Why it was done that way...?)

 Jacques

 From: Adrian Crum adrian.c...@sandglass-software.com
 I would prefer #2.

 The distinction between users and parties is already blurred enough,
 and relating User Preferences to a party will just make that worse.

 -Adrian

 On 9/29/2011 11:11 AM, Hans Bakker wrote:
 Thanks BJ for the comment.

 In order to keep the framework (login preference) and party preference
 separated i would like to suggest to either:

 1. extend the UserPreference entity and adding the field partyId to the
 key, override the related services and make the PartyId mandatory.
 2. copy the UserPreference and call it PartyPreference and replace the
 userLogin with the partyId and create similar services in the party
 component.

 anybody any comments?

 Regards,
 Hans

 On Mon, 2011-09-26 at 21:24 -0700, BJ Freeman wrote:
 I can see the case for both
 I have taken the approach to start with partyrelations.rollup.roles
 (not
 as defined by ofbiz, but the datamodel book) that a userloginId has,
 against the PartyID info available.
 that is a lot more detailed than I think you looking for.


 Hans Bakker sent the following on 9/26/2011 7:12 PM:
 Currently we have a userLoginId preference. What is fine for
 preferences
 in screens etc.

 However we would would like to have preferences on a party level,
 like
 email notification preferences. This is rather difficult at the
 moment
 because if you specify these at the userLogin level and there are 5
 userlogins for a user what to do? If you only know the partyId?

 System messages or orders are an example, there only partyId is known
 and not the specific userloginId. We would also like to send
 notifications when an email comes is, where also only partyId is
 known.

 Any opinions here?

 Regards,
 Hans

Re: discussion: party preference and user(loginId) preference

guess I should address you orginal requirement.
you would link to preference from party or login with either Pary or
user type. So add the preference ID to party.
then have a preference Item with one to many to preference

BJ Freeman sent the following on 9/29/2011 4:54 AM:
 #3. rename to Preferences with a TypeID added.
 However use the logniID to find the Preference with the type Party.
 since we now have the login tied to the partryID already.
 
 
 Hans Bakker sent the following on 9/29/2011 3:11 AM:
 Thanks BJ for the comment.

 In order to keep the framework (login preference) and party preference
 separated i would like to suggest to either:

 1. extend the UserPreference entity and adding the field partyId to the
 key, override the related services and make the PartyId mandatory.
 2. copy the UserPreference and call it PartyPreference and replace the
 userLogin with the partyId and create similar services in the party
 component.

 anybody any comments?

 Regards,
 Hans

 On Mon, 2011-09-26 at 21:24 -0700, BJ Freeman wrote:
 I can see the case for both
 I have taken the approach to start with partyrelations.rollup.roles (not
 as defined by ofbiz, but the datamodel book) that a userloginId has,
 against the PartyID info available.
 that is a lot more detailed than I think you looking for.


 Hans Bakker sent the following on 9/26/2011 7:12 PM:
 Currently we have a userLoginId preference. What is fine for preferences
 in screens etc.

 However we would would like to have preferences on a party level, like
 email notification preferences. This is rather difficult at the moment
 because if you specify these at the userLogin level and there are 5
 userlogins for a user what to do? If you only know the partyId?

 System messages or orders are an example, there only partyId is known
 and not the specific userloginId. We would also like to send
 notifications when an email comes is, where also only partyId is known.

 Any opinions here?

 Regards,
 Hans

Re: discussion: party preference and user(loginId) preference

sorry if I was not clear
add preferenceID to Party, partyGroup, and change the userlogin to
preferenceID. this is a one to one. So each one can have preference
independent and specific to that level.
So the Party Group would be first, then add the Party that is Associated
then lookup the userlogin if there is one logged in, but this is not
reqired, just one way to structure veiws and code.
if you access a party then you can find the preferences by looking up
the Preferennce through preferenceID or do a view PartyPreference.
for migration you can have a view UserPreference for userlogin

you can further have preferences with partyreltionship and roles. By
Just Adding a preferenceID


Hans Bakker sent the following on 9/29/2011 6:27 AM:
 Hi BJ,
 Is an interesting solution, however only one problem...how about a party
 without a userlogin?
 
 Regards,Hans
 
 On Thu, 2011-09-29 at 05:53 -0700, BJ Freeman wrote:
 guess I should address you orginal requirement.
 you would link to preference from party or login with either Pary or
 user type. So add the preference ID to party.
 then have a preference Item with one to many to preference

 BJ Freeman sent the following on 9/29/2011 4:54 AM:
 #3. rename to Preferences with a TypeID added.
 However use the logniID to find the Preference with the type Party.
 since we now have the login tied to the partryID already.


 Hans Bakker sent the following on 9/29/2011 3:11 AM:
 Thanks BJ for the comment.

 In order to keep the framework (login preference) and party preference
 separated i would like to suggest to either:

 1. extend the UserPreference entity and adding the field partyId to the
 key, override the related services and make the PartyId mandatory.
 2. copy the UserPreference and call it PartyPreference and replace the
 userLogin with the partyId and create similar services in the party
 component.

 anybody any comments?

 Regards,
 Hans

 On Mon, 2011-09-26 at 21:24 -0700, BJ Freeman wrote:
 I can see the case for both
 I have taken the approach to start with partyrelations.rollup.roles (not
 as defined by ofbiz, but the datamodel book) that a userloginId has,
 against the PartyID info available.
 that is a lot more detailed than I think you looking for.


 Hans Bakker sent the following on 9/26/2011 7:12 PM:
 Currently we have a userLoginId preference. What is fine for preferences
 in screens etc.

 However we would would like to have preferences on a party level, like
 email notification preferences. This is rather difficult at the moment
 because if you specify these at the userLogin level and there are 5
 userlogins for a user what to do? If you only know the partyId?

 System messages or orders are an example, there only partyId is known
 and not the specific userloginId. We would also like to send
 notifications when an email comes is, where also only partyId is known.

 Any opinions here?

 Regards,
 Hans

Re: XUI is dead, long life to ARIA

2011-09-28 Thread BJ Freeman

in doing research for my project I was tracing down XUI.
I found this thread but also see ARIA as not had much activity.
the project is to have a swing UI that will develop Widget code with a
WYSIWYG. it will generate ofbiz specific, java/groovy as well.
This is ofbiz Framework Specific though I will leave hooks for future
expansion.

So is there a library that would work in ofbiz?


Jacques Le Roux sent the following on 7/3/2008 2:58 PM:
 Thanks for advice Jacopo,
 
 I will relay
 
 Jacques
 
 From: Jacopo Cappellato jacopo.cappell...@gmail.com
 In the meantime, they should really start to do the license switch to 
 ASL2.0
 That will simplify everything... and it is much easier to do now that 
 the community is still small.

 Jacopo

 On Jul 3, 2008, at 9:40 PM, Jacques Le Roux wrote:

 Hi,

 FYI, we agreed today with Luan, that he will try to increase ARIA 
 community size before being a candidate for poddling. He will then
 come back to us and we will then reallly begin to help them to get 
 through the incubator process.

 Jacques

 From: Jacques Le Roux jacques.le.r...@les7arts.com
 Typo
 Should I ask for a Sponsor somewhere ? Is somebody interested to 
 me a mentor for ARIA ?
 is
 Should I ask for a Sponsor somewhere ? Is somebody interested to 
 *be* a mentor for ARIA ?

 Jacques

 From: Jacques Le Roux jacques.le.r...@les7arts.com
 Hi PMC mermbers,

 You certainly know that ARIA will replace XUI. And Luan O'Carrol 
 is willing to make ARIA a candidate for a TLP project through
 Incubator.
 I would like to help him on this way and I wonder if you may give 
 me some help too :o)

 I already gave these links
 Asking officialy on incubator ML gene...@incubator.apache.org 
 should help. Mentionning XUI (now ARIA) is used by OFBiz should
 help
 also. You may be interested by OFBiz experience :
 http://incubator.apache.org/projects/ofbiz.html  notably
 http://incubator.apache.org/projects/ofbiz.html. But the main 
 resource to begin with is certainly
 http://incubator.apache.org/guides/index.html. This one is 
 important too :
 http://incubator.apache.org/incubation/Incubation_Policy.html

 Should I ask for a Sponsor somewhere ? Is somebody interested to 
 me a mentor for ARIA ?

 Thanks

 Jacques

 From: Jacques Le Roux jacques.le.r...@les7arts.com
 Hi Luan,

 I was pretty busy these last days, and I must confess I did 
 nothing yet but asking some help on Dev ML. I will now ask more
 formerly
 on the private PMC list. If I get any responses, I will begin to 
 dot it alone...

 Asking officialy on incubator ML gene...@incubator.apache.org 
 should help. Mentionning XUI (now ARIA) is used by OFBiz should
 help
 also. You may be interested by OFBiz experience :
 http://incubator.apache.org/projects/ofbiz.html  notably
 http://incubator.apache.org/projects/ofbiz.html. But the main 
 resource to begin with is certainly
 http://incubator.apache.org/guides/index.html. This one is 
 important too :
 http://incubator.apache.org/incubation/Incubation_Policy.html

 Spring RCP make sense indeed, we will see what happens...

 Cheers

 Jacques

 From: Luan O'Carroll luan.ocarr...@gmail.com
 Hi Jacques,

 Is there anything I can do to support this or lobby in any way?

 The Spring RCP community is also interested in the project, 
 although
 they are quite slow to react. I don't know if they would be 
 willing to
 come on board an Apache project, although they do use lots of 
 Apache
 libraries.

 Regards

 Luan

 2008/6/27 Jacques Le Roux jacques.le.r...@les7arts.com:
 Hi,

 I want to let you know that the XUI project is officially dead. 
 XUI was
 licenced under the XPL licence which was a derivation from MPL, 
 hence
 compatible with our licence. There is a new project which aims 
 to replace
 XUI : ARIA http://sourceforge.net/projects/aria/. It was 
 created by one of
 the XUI founders : Luan O'Carrol. Unfortunately there was a 
 couple of issue

 Bad news
 1. The licence has changed, it's now under a GPL/LGPL license (on
 SourceForge it's even less clear)
 2. There will be some tools to migrate from XUI to ARIA but it 
 is not
 directly compatible.

 Good news
 1. As I have exchanged a bit with Luan before when working on 
 the POS, I
 asked him about the licence. He said it should no be a big deal 
 as his
 intention is to open ARIA more than XUI was. So in a 1st time 
 he will change
 the licence to MPL (or MP like) has it was before for XUI.
 2. I'm sure the ARIA team will help us if ever we need to 
 migrate from XUI
 to ARIA.

 We discussed a bit more and it happens that Luan would like to 
 have ARIA
 under the ASL2. And even that he would like to see ARIA becomes 
 an Apache
 Project. I explained him roughly the procedure (Candidate, 
 Champion,
 Sponsor, Mentor, Incubator, TLP). I think I qualify for being a 
 Mentor. But
 I will need some help from our community (OFBiz) to find the 
 Champion,
 Sponsor and at least another Mentor. I think that OFBiz can't 
 be a Sponsor.
 Else ARIA will later (when

[jira] [Commented] (OFBIZ-1560) Promotion rule for quantity discount not working

2011-09-27 Thread BJ Freeman (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115908#comment-13115908
 ] 

BJ Freeman commented on OFBIZ-1560:
---

Ping

 Promotion rule for quantity discount not working
 

 Key: OFBIZ-1560
 URL: https://issues.apache.org/jira/browse/OFBIZ-1560
 Project: OFBiz
  Issue Type: Bug
  Components: product, specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: Firefox 2.0, Ubuntu 7.10
Reporter: Raj Saini
Assignee: Jacques Le Roux
Priority: Minor
 Attachments: OFBIZ-1560.patch, OFBIZ-1560.patch


 Promotion rule for quantity discount does not work properly. For example if 
 the X product in shopping cart has Qty = Y, apply  Z% discount to all the 
 quantities in the shopping cart. 
 I have created the following action to achieve the above:
 X Product for Y% discount - Can get the discounted price but this promotion 
 applies to every item i.e. it does not consider the minimum quantity limit.
 If I create the following condition:
 X quantity of Product  - It does apply the minimum quantity condition but 
 applies discount to the item above X. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: demos reboot

2011-09-26 Thread BJ Freeman

I am not interested since my demos are becoming different enough they
are not good ofbiz demos.

Jacques Le Roux sent the following on 9/25/2011 11:40 PM:
Mmm, I remember now: at that time we put a link from main page under the
demo links. Anyway, I don't feel it's needed anymore. Else feel free to
create a page in wiki with link(s) to other demo systems.

Jacques

From: BJ Freeman bjf...@free-man.net
this one
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Source+Repository+and+Access

and this one would work
https://cwiki.apache.org/confluence/display/OFBTECH/Apache+OFBiz+Technical+Production+Setup+Guide

Jacques Le Roux sent the following on 9/25/2011 9:43 AM:
Yes, at some point we had a page for that in wiki. I removed it because
it seemed superfluous: this happens now very rarely so people don't know
where the page is, etc.

KISS principle...

Jacques

From: BJ Freeman bjf...@free-man.net
I think that since the demo is the only thing ofbiz supports, online,
that ofbiz just take them all down an give instructions how someone can
run it on their own platform, we already have.
They can select from the page which one they want do download and run.

Jacques Le Roux sent the following on 9/25/2011 1:53 AM:
Actually I was a bit too ambitious about this aspect. It happens
rarely
that the OFBiz demo VMs is rebooted. And even then, it's not
production, only demo, people can wait. So it is simply not worth the
effort.

Also we will see later which releases to run. This question will arise
in 2012 anyway. By then, I hope to have written few lines
about our release policy, with this aspect included

Jacques

From: BJ Freeman bjf...@free-man.net
I get the distinct impression you have.
I think everyone depends on you too much.
Thanks for what you have done.

Jacques Le Roux sent the following on 9/24/2011 3:02 PM:
Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com
Hi,

I noticed this morning that, when infra stops the VMs, OFBiz is not
reloading when they restart. I guess we have to install
rc.ofbiz.for.debian (I created it sometimes ago should be still ok)
in etc. But I have no time to take care about it right now.
If someone get a chance to look at it before me (not sure when)
remember that we have specific settings for memory and especially
for using SDK 6.0_23, see startofbiz.sh as a reference. For both
trunk
and stable and also R10.04 (Christian worked on that last
one).

I think I will never do that, who cares :o)

Jacques

BTW we still have to decide if we run only R10.04 or keep R9.04.
I'd
prefer to have them all. Of course only 3 will be
possible (to be tested) and next year R11.04 will push R9.04 out...

Jacques

Re: discussion: party preference and user(loginId) preference

2011-09-26 Thread BJ Freeman

I can see the case for both
I have taken the approach to start with partyrelations.rollup.roles (not
as defined by ofbiz, but the datamodel book) that a userloginId has,
against the PartyID info available.
that is a lot more detailed than I think you looking for.


Hans Bakker sent the following on 9/26/2011 7:12 PM:
 Currently we have a userLoginId preference. What is fine for preferences
 in screens etc.
 
 However we would would like to have preferences on a party level, like
 email notification preferences. This is rather difficult at the moment
 because if you specify these at the userLogin level and there are 5
 userlogins for a user what to do? If you only know the partyId?
 
 System messages or orders are an example, there only partyId is known
 and not the specific userloginId. We would also like to send
 notifications when an email comes is, where also only partyId is known.
 
 Any opinions here?
 
 Regards,
 Hans

Re: demos reboot

2011-09-25 Thread BJ Freeman

I think that since the demo is the only thing ofbiz supports, online,
that ofbiz just take them all down an give instructions how someone can
run it on their own platform, we already have.
They can select from the page which one they want do download and run.



Jacques Le Roux sent the following on 9/25/2011 1:53 AM:
 Actually I was a bit too ambitious about this aspect. It happens rarely
 that the OFBiz demo VMs is rebooted. And even then, it's not
 production, only demo, people can wait. So it is simply not worth the
 effort.
 
 Also we will see later which releases to run. This question will arise
 in 2012 anyway. By then, I hope to have written few lines
 about our release policy, with this aspect included
 
 Jacques
 
 From: BJ Freeman bjf...@free-man.net
 I get the distinct impression you have.
 I think everyone depends on you too much.
 Thanks for what you have done.

 Jacques Le Roux sent the following on 9/24/2011 3:02 PM:
 Jacques

 From: Jacques Le Roux jacques.le.r...@les7arts.com
 Hi,

 I noticed this morning that, when infra stops the VMs, OFBiz is not
 reloading when they restart. I guess we have to install
 rc.ofbiz.for.debian (I created it sometimes ago should be still ok)
 in etc. But I have no time to take care about it right now.
 If someone get a chance to look at it before me (not sure when)
 remember that we have specific settings for memory and especially
 for using SDK 6.0_23, see startofbiz.sh as a reference. For both trunk
 and stable and also R10.04 (Christian worked on that last
 one).

 I think I will never do that, who cares :o)

 Jacques

 BTW we still have to decide if we run only R10.04 or keep R9.04. I'd
 prefer to have them all. Of course only 3 will be
 possible (to be tested) and next year R11.04 will push R9.04 out...

 Jacques

Re: demos reboot

2011-09-25 Thread BJ Freeman

this one
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Source+Repository+and+Access
and this one would work
https://cwiki.apache.org/confluence/display/OFBTECH/Apache+OFBiz+Technical+Production+Setup+Guide

KISS principle...

Jacques

Jacques Le Roux sent the following on 9/25/2011 1:53 AM:
Actually I was a bit too ambitious about this aspect. It happens rarely
that the OFBiz demo VMs is rebooted. And even then, it's not
production, only demo, people can wait. So it is simply not worth the
effort.

Also we will see later which releases to run. This question will arise
in 2012 anyway. By then, I hope to have written few lines
about our release policy, with this aspect included

Jacques

From: BJ Freeman bjf...@free-man.net
I get the distinct impression you have.
I think everyone depends on you too much.
Thanks for what you have done.

Jacques Le Roux sent the following on 9/24/2011 3:02 PM:
Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com
Hi,

I think I will never do that, who cares :o)

Jacques

BTW we still have to decide if we run only R10.04 or keep R9.04. I'd
prefer to have them all. Of course only 3 will be
possible (to be tested) and next year R11.04 will push R9.04 out...

Jacques

Re: demos reboot

2011-09-24 Thread BJ Freeman

I get the distinct impression you have.
I think everyone depends on you too much.
Thanks for what you have done.

Jacques Le Roux sent the following on 9/24/2011 3:02 PM:
 Jacques
 
 From: Jacques Le Roux jacques.le.r...@les7arts.com
 Hi,

 I noticed this morning that, when infra stops the VMs, OFBiz is not
 reloading when they restart. I guess we have to install
 rc.ofbiz.for.debian (I created it sometimes ago should be still ok) 
 in etc. But I have no time to take care about it right now.
 If someone get a chance to look at it before me (not sure when)
 remember that we have specific settings for memory and especially
 for using SDK 6.0_23, see startofbiz.sh as a reference. For both trunk
 and stable and also R10.04 (Christian worked on that last
 one). 
 
 I think I will never do that, who cares :o)
 
 Jacques
 
 BTW we still have to decide if we run only R10.04 or keep R9.04. I'd
 prefer to have them all. Of course only 3 will be
 possible (to be tested) and next year R11.04 will push R9.04 out...

 Jacques

[jira] [Commented] (OFBIZ-4430) Replace OFBiz HttpClient either by org.apache.commons.httpclient.HttpClient or rewrite it using NIO

2011-09-21 Thread BJ Freeman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13109640#comment-13109640
 ] 

BJ Freeman commented on OFBIZ-4430:
---

LOL punctuation does make a difference
Not a working solution. Working on a working solution.

 Replace OFBiz HttpClient either by org.apache.commons.httpclient.HttpClient 
 or rewrite it using NIO
 ---

 Key: OFBIZ-4430
 URL: https://issues.apache.org/jira/browse/OFBIZ-4430
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
 Fix For: SVN trunk


 The main problem with current implementation is that it does not handle 
 connections release. You must rely on the SO to release them (timeout).
 Related thread: http://markmail.org/message/qgmdgqqxakio6fja

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4430) Replace OFBiz HttpClient either by org.apache.commons.httpclient.HttpClient or rewrite it using NIO

2011-09-21 Thread BJ Freeman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13109817#comment-13109817
 ] 

BJ Freeman commented on OFBIZ-4430:
---

Found the Apache HttpClient has been in SVN in 8/2009 last upated by Adrian 
this year.
So I will bow out since I have already converted my SVN to nio and my code will 
not work on the Ofbiz SVN

 Replace OFBiz HttpClient either by org.apache.commons.httpclient.HttpClient 
 or rewrite it using NIO
 ---

 Key: OFBIZ-4430
 URL: https://issues.apache.org/jira/browse/OFBIZ-4430
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
 Fix For: SVN trunk


 The main problem with current implementation is that it does not handle 
 connections release. You must rely on the SO to release them (timeout).
 Related thread: http://markmail.org/message/qgmdgqqxakio6fja

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: discussion: database dependent display of backend screens, forms, fields and menus

2011-09-20 Thread BJ Freeman

if by volume you are speaking of the number of rows, I would have few
suggestions
implement the Partyrelationship so it pulls less records (Iknow it is a
database specific).
allow the customer to select which fields they see and default queries.
with the default queries, you can shrink the find windows.

have a wrap format for output that fit the screen width they are using.

Hans Bakker sent the following on 9/20/2011 1:37 AM:
 I know this has come up before and every once in a while a customer is
 asking how the reduce the display volume of the back-end.
 
 How about change the screen, form and menu renderer to check for every
 field in a database if it should be displayed or not.
 
 The system should be able to start in config or normal mode. Config mode
 will enable the user the click on check boxes next to each field or
 menuitem on a screen if the fields and menu items should be displayed or
 not.
 
 the result is stored in an entity which is interrogated when the system
 is in normal mode.
 
 
 any thoughts?
 
 
 Regards,
 Hans

[jira] [Commented] (OFBIZ-4430) Replace OFBiz HttpClient either by org.apache.commons.httpclient.HttpClient or rewrite it using NIO

2011-09-20 Thread BJ Freeman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13109034#comment-13109034
 ] 

BJ Freeman commented on OFBIZ-4430:
---

yup that was to easy working on solution

 Replace OFBiz HttpClient either by org.apache.commons.httpclient.HttpClient 
 or rewrite it using NIO
 ---

 Key: OFBIZ-4430
 URL: https://issues.apache.org/jira/browse/OFBIZ-4430
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
 Fix For: SVN trunk


 The main problem with current implementation is that it does not handle 
 connections release. You must rely on the SO to release them (timeout).
 Related thread: http://markmail.org/message/qgmdgqqxakio6fja

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: widgetVerbose

+1
KISS
one place to turn off and on. common sense says you use for development
then you turn it off so there are no comments in the ouput.
So there is not need to have the comments turned off at component level.


Hans Bakker sent the following on 9/19/2011 2:14 AM:
 If i use the widget comments option i want it to be generally applied
 and taken away depending on the properties setting. I do not want to
 find out that somewhere it is not following the setting, then have to
 dig in the code and find out that is, because somebody put an
 undocumented override somewhere by default as happened the first time.
 Bird and google checkout is fine.
 
 I think how it is implemented now is fine. I hope i commented now
 enough?
 
 Regards,
 Hans
 
 On Mon, 2011-09-19 at 10:03 +0100, Adrian Crum wrote:
 Hans,

 Jacques gave some examples of where an override is currently used and 
 why it is needed. Could you give us another reason besides i think an 
 override is an overkill - like a reason based on a design issue or a 
 real-world problem?

 -Adrian

 On 9/19/2011 7:55 AM, Hans Bakker wrote:
 I as sorry i do not see the problem here.

 as long as the properties setting in the trunk will show or hide all
 widget comments (so in the trunk NO override) then it is fine.

 why? because i think an override is an overkill anyway

 Regards,
 Hans


 On Mon, 2011-09-19 at 08:43 +0200, Jacques Le Roux wrote:
 Yes, but I guess we will set widget.verbose in the properties file to true 
 (as we do for all defaults to be dev friendly). Will that
 suit Hans? Else why do you Hans ask for now overriding in web.xml? For 
 instance what for Birt by defaut? Why not keeping the example
 in example component commented out? Waht for testtools? Not sure why it's 
 false in googlecheckout but I guess there is a reason..

 In other word I guess Hans expect widget.verbose in the properties file to 
 be false...

 Jacques

 From: Adrian Crumadrian.c...@sandglass-software.com
 Let's see if we can bring this to a happy ending.

 If the widget.verbose setting in the properties file is false, then it 
 overrides any other setting and all boundary comments are
 shut off.

 If the widget.verbose setting in the properties file is true, then it 
 follows the previous pattern, where true is the default, but
 it can be overridden in web.xml and in the context Map.

 Will that work for everyone?

 -Adrian

 On 9/15/2011 5:01 PM, Jacopo Cappellato wrote:
 I am going to feel bad if I don't add my 2 cents to this thread :-)
 I agree with Jacques that the formatting of boundary comments should be 
 output specific (i.e no output for CSV etc...) instead of
 always rendering as html comments.
 As regards the logic to determine if comments should be enabled or not, 
 I don't have a strong opinion because I have always used
 this feature in a very rough way (enable all or disable all); however I 
 can understand the we may want to avoid that (when
 widget.properties.enableBoundaryComments == false) the comments are 
 enabled by passing a URL parameter to the screen.

 Kind regards,

 Jacopo

 On Sep 15, 2011, at 4:18 PM, Jacques Le Roux wrote:

 Someone I work with suggested:

 I have to point out though that I kind of agree with the way David put 
 it in that the false setting could have a priority,
 i.e. it's like in security permissions where deny has precedence over 
 allow, so if you set it in widget.properties to false
 then you're sure comments will never be enabled anywhere... 
 security-wise it makes sense despite the comment about qc...

 Maybe something like this? (compromise between the two)

 if (widget.properties.enableBoundaryComments == false
 || web.xml.enableBoundaryComments == false
 || context.enableBoundaryComments == false) {
 return false;
 } else { // This is the solution Scott wrote, but use overriding 
 settings only for null and true values
 if (context.enableBoundaryComments != null) return 
 context.enableBoundaryComments;
 if (web.xml.enableBoundaryComments != null) return 
 web.xml.enableBoundaryComments;
 if (widget.properties.enableBoundaryComments != null) return 
 widget.properties.enableBoundaryComments;
 return false;
 }

 Could probably rewrite that to be less redundant but you get the idea...

 jleroux: I quickly reformated my own way ;o), It seems a good idea to 
 me, what do you think?

 Also my colleague also wrote:
 Only thing I have to add is that I didn't see anyone address the issue 
 that HTML comments are outputted for CSV (because there's
 nocsv   element and you have to usehtml) element. No matter what 
 widget.verbose is set to, there should never be HTmL
 comments outputted for csv. so this only addresses half the bugs...

 We have no patches so far...

 Jacques



 Dimitri Unruh wrote:
 +1


 Dimitri Unruh
 Consultant AEW
 Lynx-Consulting GmbH
 Johanniskirchplatz 6
 33615 Bielefeld
 Deutschland
 Fon: +49 521 5247-0
 Fax: +49 521 5247-250
 Mobil: +49 160 90 57 55 13

Re: ofbiz HttpClient versus org.apache.commons.httpclient.HttpClient;

actually I was suggesting that ofbiz as a whole would be re-factored to NIO
My underlying motivation is to stop expanding libraries and start only
having what ofbiz is really using.
and that is a harder effort but well worth it.
But I am willing to work with the jira.

Jacques Le Roux sent the following on 9/18/2011 11:51 PM:
 1) This is what I mean:
 http://hc.apache.org/httpclient-3.x/performance.html#Connection_persistence
 In other words, not relying on the SO to release connections. Most of
 the time it's not a big deal, but in some cases this can be annoying
 2) You are welcome https://issues.apache.org/jira/browse/OFBIZ-4430.
 Maybe it's not harder indeed...
 
 Jacques
 
 From: BJ Freeman bjf...@free-man.net
 Ok a longer version of my terse reply.
 there are two concerns in this thread you brought up.
 1) TIMENOUT
 2) implementing a different package that does not support the newer
 java.nio.channel like the APJ does.
 #1 is something than if you set to long it will waste response time, on
 a bad connection, if to short will have the effect in the Email.
 when I started in 96 the latency of the internet was uder 100 ms max.
 Now the latency of the net is upwards of what used to be considered
 intoloralbe latency (200 ms).
 On top of that you have the Server response time which during the
 Holidays gets really long so you will time out before the server
 responds causing resends that only bog down the server more.
 the above is a long winded way of saying your time out has to change
 with the conditions.
 #2 in looking at the http library they are still using the java.net for
 connection. So in my estimation, we do a re-factor of ofbiz to java.nio
 and fix the httpclient we have.


 Jacques Le Roux sent the following on 9/17/2011 9:13 AM:
 I'm resurrecting this thread because, as outlined by this other thread
 http://markmail.org/message/j4s6tq2ccit3wtbf, unlike Apache
 HttpClient, OFBiz's is not closing connections.
 I have not the time at the moment to replace it, but I'd like to do so
 in October or November. I will open a Jira then (this message
 more as a self reminder...)

 Interesting link also
 http://hc.apache.org/httpcomponents-client-ga/tutorial/html/connmgmt.html


 Jacques

 From: BJ Freeman bjf...@free-man.net
 I have done more investigation, and found the methods I depend on in
 the
 jar come from java 1.31. in looking at the current httpclient, it does
 not support the code I have.
 I am not sure what I will do at this point but for the trunk it
 would be
 best to use the current httpclient.
 I am still going thru the current httpclient class in ofbiz to figure
 out how is would be used, mostly in communication with third parties.

 Adrian Crum sent the following on 10/23/2008 2:39 PM:
 I was thinking we could deprecate the constructors, and point
 people to
 the new class.

 -Adrian

 BJ Freeman wrote:
 just as a note there are methods in the ofbiz one that work with
 ofbiz
 structure. I would like to review those to see if they can be used
 I guess the proper steps is to depreciate those.

 BJ Freeman sent the following on 10/23/2008 1:47 PM:
 works for me.
 it has been moved around
 found it under
 http://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk/module-client/





 Adrian Crum sent the following on 10/23/2008 1:37 PM:
 I'd rather switch to the commons one and eliminate the OFBiz one.
 It's
 only used in one or two places, so it wouldn't be a difficult
 change to
 make.

 -Adrian

 BJ Freeman wrote:
 I have been looking at HTMLUnit since our last conversation, for
 implementing user test screens.
 this is more that there are two HttpClient classes and the ofbiz
 one is
 used in the framework.
 it seemed the simplest solution would be to use implements to
 append the
  apache one to the ofbiz one thus making the ofbiz one more
 versatile.

 Adrian Crum sent the following on 10/23/2008 1:06 PM:
 I would recommend using any suitable replacement for the OFBiz
 HttpClient - it is very rudimentary.

 If you need an HTTP client that handles cookies and JavaScript,
 then
 take a look at HTMLUnit - http://htmlunit.sourceforge.net. I used
 it in
 my mashup POC code -
 https://issues.apache.org/jira/browse/OFBIZ-1873.

 -Adrian

 BJ Freeman wrote:
 while working with yahoo API
 I came accross the org.apache.commons.httpclient.HttpClient;
 which has more functionality than the ofbiz HttpClient
 is there any problem with making the ofbiz an HttpClient
 implementation
 of the apache?

Re: widgetVerbose

yes I understand. but a simple turn off all comments lets you work with
that. but if you want to see what is generating that, then turn them all on.
Like Hans said, I really don't want to have to go through code to find
where it is turned off or on.

Adrian Crum sent the following on 9/19/2011 8:56 AM:
 BJ,
 
 The original message of this thread points out why that approach does
 not work. If comments are defaulted to on, then there MUST be a way to
 turn them off for things like CSV output.
 
 -Adrian
 
 On 9/19/2011 4:39 PM, BJ Freeman wrote:
 +1
 KISS
 one place to turn off and on. common sense says you use for development
 then you turn it off so there are no comments in the ouput.
 So there is not need to have the comments turned off at component level.


 Hans Bakker sent the following on 9/19/2011 2:14 AM:
 If i use the widget comments option i want it to be generally applied
 and taken away depending on the properties setting. I do not want to
 find out that somewhere it is not following the setting, then have to
 dig in the code and find out that is, because somebody put an
 undocumented override somewhere by default as happened the first time.
 Bird and google checkout is fine.

 I think how it is implemented now is fine. I hope i commented now
 enough?

 Regards,
 Hans

 On Mon, 2011-09-19 at 10:03 +0100, Adrian Crum wrote:
 Hans,

 Jacques gave some examples of where an override is currently used and
 why it is needed. Could you give us another reason besides i think an
 override is an overkill - like a reason based on a design issue or a
 real-world problem?

 -Adrian

 On 9/19/2011 7:55 AM, Hans Bakker wrote:
 I as sorry i do not see the problem here.

 as long as the properties setting in the trunk will show or hide all
 widget comments (so in the trunk NO override) then it is fine.

 why? because i think an override is an overkill anyway

 Regards,
 Hans


 On Mon, 2011-09-19 at 08:43 +0200, Jacques Le Roux wrote:
 Yes, but I guess we will set widget.verbose in the properties file
 to true (as we do for all defaults to be dev friendly). Will that
 suit Hans? Else why do you Hans ask for now overriding in web.xml?
 For instance what for Birt by defaut? Why not keeping the example
 in example component commented out? Waht for testtools? Not sure
 why it's false in googlecheckout but I guess there is a reason..

 In other word I guess Hans expect widget.verbose in the properties
 file to be false...

 Jacques

 From: Adrian Crumadrian.c...@sandglass-software.com
 Let's see if we can bring this to a happy ending.

 If the widget.verbose setting in the properties file is false,
 then it overrides any other setting and all boundary comments are
 shut off.

 If the widget.verbose setting in the properties file is true,
 then it follows the previous pattern, where true is the default, but
 it can be overridden in web.xml and in the context Map.

 Will that work for everyone?

 -Adrian

 On 9/15/2011 5:01 PM, Jacopo Cappellato wrote:
 I am going to feel bad if I don't add my 2 cents to this thread :-)
 I agree with Jacques that the formatting of boundary comments
 should be output specific (i.e no output for CSV etc...) instead of
 always rendering as html comments.
 As regards the logic to determine if comments should be enabled
 or not, I don't have a strong opinion because I have always used
 this feature in a very rough way (enable all or disable all);
 however I can understand the we may want to avoid that (when
 widget.properties.enableBoundaryComments == false) the comments
 are enabled by passing a URL parameter to the screen.

 Kind regards,

 Jacopo

 On Sep 15, 2011, at 4:18 PM, Jacques Le Roux wrote:

 Someone I work with suggested:

 I have to point out though that I kind of agree with the way
 David put it in that the false setting could have a priority,
 i.e. it's like in security permissions where deny has
 precedence over allow, so if you set it in widget.properties to
 false
 then you're sure comments will never be enabled anywhere...
 security-wise it makes sense despite the comment about qc...

 Maybe something like this? (compromise between the two)

 if (widget.properties.enableBoundaryComments == false
  || web.xml.enableBoundaryComments == false
  || context.enableBoundaryComments == false) {
  return false;
 } else { // This is the solution Scott wrote, but use
 overriding settings only for null and true values
  if (context.enableBoundaryComments != null) return
 context.enableBoundaryComments;
  if (web.xml.enableBoundaryComments != null) return
 web.xml.enableBoundaryComments;
  if (widget.properties.enableBoundaryComments != null)
 return widget.properties.enableBoundaryComments;
  return false;
 }

 Could probably rewrite that to be less redundant but you get
 the idea...

 jleroux: I quickly reformated my own way ;o), It seems a good
 idea to me, what do you think?

 Also my colleague also wrote:
 Only thing I have to add

Re: widgetVerbose

Then I suggest a vote, though mine is none binding.

Adrian Crum sent the following on 9/19/2011 9:06 AM:
 And there are others who don't like the all-or-nothing approach. Please,
 unless you have something new to add, can we stop talking in circles?
 
 -Adrian
 
 On 9/19/2011 5:02 PM, BJ Freeman wrote:
 yes I understand. but a simple turn off all comments lets you work with
 that. but if you want to see what is generating that, then turn them
 all on.
 Like Hans said, I really don't want to have to go through code to find
 where it is turned off or on.

 Adrian Crum sent the following on 9/19/2011 8:56 AM:
 BJ,

 The original message of this thread points out why that approach does
 not work. If comments are defaulted to on, then there MUST be a way to
 turn them off for things like CSV output.

 -Adrian

 On 9/19/2011 4:39 PM, BJ Freeman wrote:
 +1
 KISS
 one place to turn off and on. common sense says you use for development
 then you turn it off so there are no comments in the ouput.
 So there is not need to have the comments turned off at component
 level.


 Hans Bakker sent the following on 9/19/2011 2:14 AM:
 If i use the widget comments option i want it to be generally applied
 and taken away depending on the properties setting. I do not want to
 find out that somewhere it is not following the setting, then have to
 dig in the code and find out that is, because somebody put an
 undocumented override somewhere by default as happened the first time.
 Bird and google checkout is fine.

 I think how it is implemented now is fine. I hope i commented now
 enough?

 Regards,
 Hans

 On Mon, 2011-09-19 at 10:03 +0100, Adrian Crum wrote:
 Hans,

 Jacques gave some examples of where an override is currently used and
 why it is needed. Could you give us another reason besides i
 think an
 override is an overkill - like a reason based on a design issue or a
 real-world problem?

 -Adrian

 On 9/19/2011 7:55 AM, Hans Bakker wrote:
 I as sorry i do not see the problem here.

 as long as the properties setting in the trunk will show or hide all
 widget comments (so in the trunk NO override) then it is fine.

 why? because i think an override is an overkill anyway

 Regards,
 Hans


 On Mon, 2011-09-19 at 08:43 +0200, Jacques Le Roux wrote:
 Yes, but I guess we will set widget.verbose in the properties file
 to true (as we do for all defaults to be dev friendly). Will that
 suit Hans? Else why do you Hans ask for now overriding in web.xml?
 For instance what for Birt by defaut? Why not keeping the example
 in example component commented out? Waht for testtools? Not sure
 why it's false in googlecheckout but I guess there is a reason..

 In other word I guess Hans expect widget.verbose in the properties
 file to be false...

 Jacques

 From: Adrian Crumadrian.c...@sandglass-software.com
 Let's see if we can bring this to a happy ending.

 If the widget.verbose setting in the properties file is false,
 then it overrides any other setting and all boundary comments are
 shut off.

 If the widget.verbose setting in the properties file is true,
 then it follows the previous pattern, where true is the
 default, but
 it can be overridden in web.xml and in the context Map.

 Will that work for everyone?

 -Adrian

 On 9/15/2011 5:01 PM, Jacopo Cappellato wrote:
 I am going to feel bad if I don't add my 2 cents to this
 thread :-)
 I agree with Jacques that the formatting of boundary comments
 should be output specific (i.e no output for CSV etc...)
 instead of
 always rendering as html comments.
 As regards the logic to determine if comments should be enabled
 or not, I don't have a strong opinion because I have always used
 this feature in a very rough way (enable all or disable all);
 however I can understand the we may want to avoid that (when
 widget.properties.enableBoundaryComments == false) the comments
 are enabled by passing a URL parameter to the screen.

 Kind regards,

 Jacopo

 On Sep 15, 2011, at 4:18 PM, Jacques Le Roux wrote:

 Someone I work with suggested:

 I have to point out though that I kind of agree with the way
 David put it in that the false setting could have a priority,
 i.e. it's like in security permissions where deny has
 precedence over allow, so if you set it in widget.properties to
 false
 then you're sure comments will never be enabled anywhere...
 security-wise it makes sense despite the comment about qc...

 Maybe something like this? (compromise between the two)

 if (widget.properties.enableBoundaryComments == false
   || web.xml.enableBoundaryComments == false
   || context.enableBoundaryComments == false) {
   return false;
 } else { // This is the solution Scott wrote, but use
 overriding settings only for null and true values
   if (context.enableBoundaryComments != null) return
 context.enableBoundaryComments;
   if (web.xml.enableBoundaryComments != null) return
 web.xml.enableBoundaryComments

[jira] [Commented] (OFBIZ-4430) Replace OFBiz HttpClient either by org.apache.commons.httpclient.HttpClient or rewrite it using NIO

2011-09-19 Thread BJ Freeman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107984#comment-13107984
 ] 

BJ Freeman commented on OFBIZ-4430:
---

My suggestion to use NIO was more for all of Ofbiz.
I don't see adding another package that has the same basic function as the 
java.net just for HttpClient.
So will review the commons package to see what can be down with current 
httpClient.

 Replace OFBiz HttpClient either by org.apache.commons.httpclient.HttpClient 
 or rewrite it using NIO
 ---

 Key: OFBIZ-4430
 URL: https://issues.apache.org/jira/browse/OFBIZ-4430
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
 Fix For: SVN trunk


 The main problem with current implementation is that it does not handle 
 connections release. You must rely on the SO to release them (timeout).
 Related thread: http://markmail.org/message/qgmdgqqxakio6fja

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4430) Replace OFBiz HttpClient either by org.apache.commons.httpclient.HttpClient or rewrite it using NIO

2011-09-19 Thread BJ Freeman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13108006#comment-13108006
 ] 

BJ Freeman commented on OFBIZ-4430:
---

Quick review there are two possible solutions with current code.
1)modify  org.ofbiz.base.util.URLConnector to handle the close automatically.
2)Call org.ofbiz.base.util.URLConnector.close in HttpClient. 
The way Commons does this is when the stream is closed the connector is closed.
will look at it again shortly to see if I agree with what I just wrote.

 Replace OFBiz HttpClient either by org.apache.commons.httpclient.HttpClient 
 or rewrite it using NIO
 ---

 Key: OFBIZ-4430
 URL: https://issues.apache.org/jira/browse/OFBIZ-4430
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
 Fix For: SVN trunk


 The main problem with current implementation is that it does not handle 
 connections release. You must rely on the SO to release them (timeout).
 Related thread: http://markmail.org/message/qgmdgqqxakio6fja

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4430) Replace OFBiz HttpClient either by org.apache.commons.httpclient.HttpClient or rewrite it using NIO

2011-09-19 Thread BJ Freeman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13108329#comment-13108329
 ] 

BJ Freeman commented on OFBIZ-4430:
---

in current httpClient.sendHttpRequest()
   while ((line = post.readLine()) != null) {
if (Debug.verboseOn() || debug) Debug.log([HttpClient] :  + 
line, module);
buf.append(line);
if (lineFeed) {
buf.append(\n);
}
}
//have to set org.ofbiz.base.util.URLConnector.close() to protected.
//add the following line. 
con.close();//sent request got back response so close connection.


 Replace OFBiz HttpClient either by org.apache.commons.httpclient.HttpClient 
 or rewrite it using NIO
 ---

 Key: OFBIZ-4430
 URL: https://issues.apache.org/jira/browse/OFBIZ-4430
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
 Fix For: SVN trunk


 The main problem with current implementation is that it does not handle 
 connections release. You must rely on the SO to release them (timeout).
 Related thread: http://markmail.org/message/qgmdgqqxakio6fja

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: ofbiz HttpClient versus org.apache.commons.httpclient.HttpClient;

2011-09-17 Thread BJ Freeman

Just as a note I believe a major redactor using the java.nio.channels
library, would solve a lot of problems.  connecion are manage internally.

http://download.oracle.com/javase/6/docs/api/java/nio/channels/package-summary.html

Jacques Le Roux sent the following on 9/17/2011 9:13 AM:
 I'm resurrecting this thread because, as outlined by this other thread 
 http://markmail.org/message/j4s6tq2ccit3wtbf, unlike Apache
 HttpClient, OFBiz's is not closing connections.
 I have not the time at the moment to replace it, but I'd like to do so
 in October or November. I will open a Jira then (this message
 more as a self reminder...)
 
 Interesting link also
 http://hc.apache.org/httpcomponents-client-ga/tutorial/html/connmgmt.html
 
 Jacques
 
 From: BJ Freeman bjf...@free-man.net
 I have done more investigation, and found the methods I depend on in the
 jar come from java 1.31. in looking at the current httpclient, it does
 not support the code I have.
 I am not sure what I will do at this point but for the trunk it would be
 best to use the current httpclient.
 I am still going thru the current httpclient class in ofbiz to figure
 out how is would be used, mostly in communication with third parties.

 Adrian Crum sent the following on 10/23/2008 2:39 PM:
 I was thinking we could deprecate the constructors, and point people to
 the new class.

 -Adrian

 BJ Freeman wrote:
 just as a note there are methods in the ofbiz one that work with ofbiz
 structure. I would like to review those to see if they can be used
 I guess the proper steps is to depreciate those.

 BJ Freeman sent the following on 10/23/2008 1:47 PM:
 works for me.
 it has been moved around
 found it under
 http://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk/module-client/




 Adrian Crum sent the following on 10/23/2008 1:37 PM:
 I'd rather switch to the commons one and eliminate the OFBiz one.
 It's
 only used in one or two places, so it wouldn't be a difficult
 change to
 make.

 -Adrian

 BJ Freeman wrote:
 I have been looking at HTMLUnit since our last conversation, for
 implementing user test screens.
 this is more that there are two HttpClient classes and the ofbiz
 one is
 used in the framework.
 it seemed the simplest solution would be to use implements to
 append the
  apache one to the ofbiz one thus making the ofbiz one more
 versatile.

 Adrian Crum sent the following on 10/23/2008 1:06 PM:
 I would recommend using any suitable replacement for the OFBiz
 HttpClient - it is very rudimentary.

 If you need an HTTP client that handles cookies and JavaScript,
 then
 take a look at HTMLUnit - http://htmlunit.sourceforge.net. I used
 it in
 my mashup POC code -
 https://issues.apache.org/jira/browse/OFBIZ-1873.

 -Adrian

 BJ Freeman wrote:
 while working with yahoo API
 I came accross the org.apache.commons.httpclient.HttpClient;
 which has more functionality than the ofbiz HttpClient
 is there any problem with making the ofbiz an HttpClient
 implementation
 of the apache?

Re: ofbiz HttpClient versus org.apache.commons.httpclient.HttpClient;

2011-09-17 Thread BJ Freeman

Ok a longer version of my terse reply.
there are two concerns in this thread you brought up.
1) TIMENOUT
2) implementing a different package that does not support the newer
java.nio.channel like the APJ does.
#1 is something than if you set to long it will waste response time, on
a bad connection, if to short will have the effect in the Email.
when I started in 96 the latency of the internet was uder 100 ms max.
Now the latency of the net is upwards of what used to be considered
intoloralbe latency (200 ms).
On top of that you have the Server response time which during the
Holidays gets really long so you will time out before the server
responds causing resends that only bog down the server more.
the above is a long winded way of saying your time out has to change
with the conditions.
#2 in looking at the http library they are still using the java.net for
connection. So in my estimation, we do a re-factor of ofbiz to java.nio
and fix the httpclient we have.


Jacques Le Roux sent the following on 9/17/2011 9:13 AM:
 I'm resurrecting this thread because, as outlined by this other thread 
 http://markmail.org/message/j4s6tq2ccit3wtbf, unlike Apache
 HttpClient, OFBiz's is not closing connections.
 I have not the time at the moment to replace it, but I'd like to do so
 in October or November. I will open a Jira then (this message
 more as a self reminder...)
 
 Interesting link also
 http://hc.apache.org/httpcomponents-client-ga/tutorial/html/connmgmt.html
 
 Jacques
 
 From: BJ Freeman bjf...@free-man.net
 I have done more investigation, and found the methods I depend on in the
 jar come from java 1.31. in looking at the current httpclient, it does
 not support the code I have.
 I am not sure what I will do at this point but for the trunk it would be
 best to use the current httpclient.
 I am still going thru the current httpclient class in ofbiz to figure
 out how is would be used, mostly in communication with third parties.

 Adrian Crum sent the following on 10/23/2008 2:39 PM:
 I was thinking we could deprecate the constructors, and point people to
 the new class.

 -Adrian

 BJ Freeman wrote:
 just as a note there are methods in the ofbiz one that work with ofbiz
 structure. I would like to review those to see if they can be used
 I guess the proper steps is to depreciate those.

 BJ Freeman sent the following on 10/23/2008 1:47 PM:
 works for me.
 it has been moved around
 found it under
 http://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk/module-client/




 Adrian Crum sent the following on 10/23/2008 1:37 PM:
 I'd rather switch to the commons one and eliminate the OFBiz one.
 It's
 only used in one or two places, so it wouldn't be a difficult
 change to
 make.

 -Adrian

 BJ Freeman wrote:
 I have been looking at HTMLUnit since our last conversation, for
 implementing user test screens.
 this is more that there are two HttpClient classes and the ofbiz
 one is
 used in the framework.
 it seemed the simplest solution would be to use implements to
 append the
  apache one to the ofbiz one thus making the ofbiz one more
 versatile.

 Adrian Crum sent the following on 10/23/2008 1:06 PM:
 I would recommend using any suitable replacement for the OFBiz
 HttpClient - it is very rudimentary.

 If you need an HTTP client that handles cookies and JavaScript,
 then
 take a look at HTMLUnit - http://htmlunit.sourceforge.net. I used
 it in
 my mashup POC code -
 https://issues.apache.org/jira/browse/OFBIZ-1873.

 -Adrian

 BJ Freeman wrote:
 while working with yahoo API
 I came accross the org.apache.commons.httpclient.HttpClient;
 which has more functionality than the ofbiz HttpClient
 is there any problem with making the ofbiz an HttpClient
 implementation
 of the apache?

[jira] [Commented] (OFBIZ-3403) webtools xml data export to browser not working

2011-09-16 Thread BJ Freeman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106553#comment-13106553
 ] 

BJ Freeman commented on OFBIZ-3403:
---

Firefox will not show xml have to do view source.

I suggest an option to create a zip file and download.

 webtools xml data export to browser not working
 ---

 Key: OFBIZ-3403
 URL: https://issues.apache.org/jira/browse/OFBIZ-3403
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: chris snow
Assignee: Jacques Le Roux

 Assumption, demo data is installed.
 Steps:
 1) Select webtools
 2) Select XML Data Export
 3) Select OR to Browser
 4) Select an entity
 5) Click export
 6) Click Click Here to Get Data (or save to file)
 Empty screen is shown.
 In the console, the following is seen:
 2010-01-10 08:31:08,437 (TP-Processor8) [ RequestHandler.java:733:INFO ] 
 Rendering View [xmldsrawdump], sessionId=6B8CA710E0CBF49D7E0ED5169918187F.jvm1
 2010-01-10 08:31:08,467 (TP-Processor8) [TransactionUtil.java:269:WARN ] 
 [TransactionUtil.commit] Not committing transaction, status is No Transaction 
 (6)
 2010-01-10 08:31:08,482 (TP-Processor8) [ ControlServlet.java:321:INFO ] 
 [[[xmldsrawdump] Request Done- total:0.183,since last([xmldsrawdump] 
 Re...):0.183]]

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Why was this done?

did a search of the commits
http://svn.apache.org/viewvc?view=revisionrevision=821391

Ruth Hoffman sent the following on 9/16/2011 1:42 PM:
 Could someone explain to me - and ignorant OFBiz committer wannabe - why
 the following method in version 9.04:
 
 public static GenericDelegator getGenericDelegator(String
 delegatorName) { ... }
 
 No longer exists in the DelegatorFactory class in the most recent trunk
 version?
 
 In its place I see:
 
 public static Delegator getDelegator(String delegatorName) {...}
 
 Is there a reason this was changed or taken out? Should I be calling a
 different method to get my 9.04 code to work with the current trunk
 version?
 
 Thanks much.
 Ruth

Re: Why was this done?

one of the reasons I stuck with the minilang

Ruth Hoffman sent the following on 9/16/2011 2:21 PM:
 Thanks BJ.
 
 I guess OFBiz is not too backward compatible. Oh well, too bad. This
 breaks all kinds of things in 9.04 that I'd like to carry over to 10.x.
 
 Best Regards,
 Ruth
 
 On 9/16/11 5:14 PM, BJ Freeman wrote:
 did a search of the commits
 http://svn.apache.org/viewvc?view=revisionrevision=821391

 Ruth Hoffman sent the following on 9/16/2011 1:42 PM:
 Could someone explain to me - and ignorant OFBiz committer wannabe - why
 the following method in version 9.04:

  public static GenericDelegator getGenericDelegator(String
 delegatorName) { ... }

 No longer exists in the DelegatorFactory class in the most recent trunk
 version?

 In its place I see:

  public static Delegator getDelegator(String delegatorName) {...}

 Is there a reason this was changed or taken out? Should I be calling a
 different method to get my 9.04 code to work with the current trunk
 version?

 Thanks much.
 Ruth

Re: Why was this done?

I don't remember any problems. been a few years since I did it.
I don't believe there is any different calls in minilang at the minilang
syntax.
http://svn.apache.org/viewvc?view=revisionrevision=672898
see the first three
Most my java code went though a layer that interfaced to ofbiz
so all I had to-do is change the interface.
did this to protect me from the way ofbiz kept being changed from 4.0

Ruth Hoffman sent the following on 9/16/2011 2:41 PM:
 Hi BJ:
 
 This could still be a problem with minilang if whoever didn't upgrade
 that. Have you tried moving some custom minilang from 9.04 to 10.x? Just
 curious.
 
 Anyhow, I haven't figured out a way to use minilang when writing new
 servlets - which is were this problem is most annoying.
 
 Best Regards,
 Ruth
 On 9/16/11 5:29 PM, BJ Freeman wrote:
 one of the reasons I stuck with the minilang

 Ruth Hoffman sent the following on 9/16/2011 2:21 PM:
 Thanks BJ.

 I guess OFBiz is not too backward compatible. Oh well, too bad. This
 breaks all kinds of things in 9.04 that I'd like to carry over to 10.x.

 Best Regards,
 Ruth

 On 9/16/11 5:14 PM, BJ Freeman wrote:
 did a search of the commits
 http://svn.apache.org/viewvc?view=revisionrevision=821391

 Ruth Hoffman sent the following on 9/16/2011 1:42 PM:
 Could someone explain to me - and ignorant OFBiz committer wannabe
 - why
 the following method in version 9.04:

   public static GenericDelegator getGenericDelegator(String
 delegatorName) { ... }

 No longer exists in the DelegatorFactory class in the most recent
 trunk
 version?

 In its place I see:

   public static Delegator getDelegator(String delegatorName) {...}

 Is there a reason this was changed or taken out? Should I be calling a
 different method to get my 9.04 code to work with the current trunk
 version?

 Thanks much.
 Ruth

Re: Why was this done?

are you speaking as in a Class or has the uses of Httpservlet?

Ruth Hoffman sent the following on 9/16/2011 2:41 PM:
 Anyhow, I haven't figured out a way to use minilang when writing new
 servlets - which is were this problem is most annoying.

Re: Why was this done?

there are many exmaples of events that are minilanq.
look at
specialpurpose\googlecheckout\script\org\ofbiz\googleCheckout\PrepareXMLTemplate.xml
chris gives a lot of examples

Ruth Hoffman sent the following on 9/16/2011 3:17 PM:
 Both. For example EventHandler implementations and some custom servlets
 that extend HttpServlet.
 Ruth
 On 9/16/11 6:00 PM, BJ Freeman wrote:
 are you speaking as in a Class or has the uses of Httpservlet?

 Ruth Hoffman sent the following on 9/16/2011 2:41 PM:
 Anyhow, I haven't figured out a way to use minilang when writing new
 servlets - which is were this problem is most annoying.

Re: Why was this done?

if you talking about java events and listeners then do a java class then
use run to call minilang as a service.

Ruth Hoffman sent the following on 9/16/2011 3:44 PM:
 Hi BJ:
 
 Not sure I follow. These don't look like EventHandlers to me. (I mean a
 class that implements EventHandler) . These look like events. Even so,
 a closer look shows that within some of these events, the Bean Shell is
 being called. That seems pretty crazy to me. The same problems can
 occur. OK, lets not go there...I use minilang when I feel it is
 appropriate.
 
 Anyhow, thanks.
 
 Appreciate your help in understanding this.
 
 Best Regards,
 Ruth
 
 On 9/16/11 6:27 PM, BJ Freeman wrote:
 there are many exmaples of events that are minilanq.
 look at
 specialpurpose\googlecheckout\script\org\ofbiz\googleCheckout\PrepareXMLTemplate.xml

 chris gives a lot of examples

 Ruth Hoffman sent the following on 9/16/2011 3:17 PM:
 Both. For example EventHandler implementations and some custom servlets
 that extend HttpServlet.
 Ruth
 On 9/16/11 6:00 PM, BJ Freeman wrote:
 are you speaking as in a Class or has the uses of Httpservlet?

 Ruth Hoffman sent the following on 9/16/2011 2:41 PM:
 Anyhow, I haven't figured out a way to use minilang when writing new
 servlets - which is were this problem is most annoying.

Re: New link between communication event and sales opportunity

2011-09-15 Thread BJ Freeman

even if it is done automatically, all efforts cost time which is what
workeffort is about. This feed back to budgets.
and since this system is about business, tracking cost is very important.

on a coding level I think the Model for SFA is sprawl and could have
been developed with in the frame work we have alreary.

Using PartyRleationships the way the datamodel book implemented it would
have made the dealing with things a lot easier and a lot less data handled.



Hans Bakker sent the following on 9/14/2011 11:10 PM:
 Sure I am all in favor to use the existing datamodel, this means however
 that every communication event will have a workeffort connected to it
 because somebody has to handle it? sounds  a it bureaucratic?, 
 
 then as a result of the creation of the opportunity more emails are sent
 from the opportunity, we need a workeffort to create another
 communication event? What kind of information the workeffort adds?
 
 Regards,
 Hans
 
 
 On Thu, 2011-09-15 at 17:37 +1200, Scott Gray wrote:
 It is possible to have a link between CommunicationEvent and 
 SalesOpportunity via SalesOpportunityWorkEffort - WorkEffort - 
 CommunicationEventWorkEffort.

 The business case could be redescribed as:
 - Email Received (CommunicationEvent)
 - WorkEffort created to handle the communication
 - Communication deemed to be a sales opportunity and record is created

 Regards
 Scott

 On 15/09/2011, at 4:13 PM, Hans Bakker wrote:

 Business case:
 An email is received requesting more information about certain services
 where the originator could be interested in.
 The support person receives the email and creates an opportunity in SFA
 for the sales people.

 Problem:
 currently it is not possible to have a link between CommunicationEvent
 and SalesOpportunity entity.

 Proposal:
 create a new entity:
 SalesOpportCommEvent:
 key: salesOpportunityId, communicationEventId

 comments please?

 Regards,
 Hans


 -- 
 Ofbiz on twitter: http://twitter.com/apache_ofbiz
 Alternative ofbiz website: http://www.ofbiz.info
 http://www.antwebsystems.com : Quality services for competitive rates.

Re: widgetVerbose

2011-09-15 Thread BJ Freeman

Some time ago there was a discussion about coding pattern if not true it
is false.
it was WidgetVerbose which says it had to be true to be verbose.
I don't see changing widget.properties. to enableBoundaryComments
it means those that have production have to become familiar with new.
this goes along it if ain't broke don't fix it.
As far as flow the property ==true should override all other setting
since it is a design function.
The default Should be not true. This means is can be blank or false.
Then all other setting would be in effect.

Jacques Le Roux sent the following on 9/15/2011 7:18 AM:
 Someone I work with suggested:
 
 I have to point out though that I kind of agree with the way David put
 it in that the false setting could have a priority, i.e. it's like in
 security permissions where deny has precedence over allow, so if you
 set it in widget.properties to false then you're sure comments will
 never be enabled anywhere... security-wise it makes sense despite the
 comment about qc...
 
 Maybe something like this? (compromise between the two)
 
 if (widget.properties.enableBoundaryComments == false
|| web.xml.enableBoundaryComments == false
|| context.enableBoundaryComments == false) {
return false;
 } else { // This is the solution Scott wrote, but use overriding
 settings only for null and true values
if (context.enableBoundaryComments != null) return
 context.enableBoundaryComments;
if (web.xml.enableBoundaryComments != null) return
 web.xml.enableBoundaryComments;
if (widget.properties.enableBoundaryComments != null) return
 widget.properties.enableBoundaryComments;
return false;
 }
 
 Could probably rewrite that to be less redundant but you get the idea...
 
 jleroux: I quickly reformated my own way ;o), It seems a good idea to
 me, what do you think?
 
 Also my colleague also wrote:
 Only thing I have to add is that I didn't see anyone address the issue
 that HTML comments are outputted for CSV (because there's no csv
 element and you have to use html) element. No matter what
 widget.verbose is set to, there should never be HTmL comments outputted
 for csv. so this only addresses half the bugs...
 
 We have no patches so far...
 
 Jacques
 
 
 
 Dimitri Unruh wrote:
 +1


 Dimitri Unruh
 Consultant AEW
 Lynx-Consulting GmbH
 Johanniskirchplatz 6
 33615 Bielefeld
 Deutschland
 Fon: +49 521 5247-0
 Fax: +49 521 5247-250
 Mobil: +49 160 90 57 55 13


 Company and Management Headquarters:
 Lynx-Consulting GmbH, Johanniskirchplatz 6, 33615 Bielefeld, Deutschland
 Fon: +49 521 5247-0, Fax: +49 521 5247-250, www.lynx.de

 Court Registration: Amtsgericht Bielefeld HRB 35946
 Chief Executive Officers: Karsten Noss, Dirk Osterkamp


 http://www.lynx.de/haftungsausschluss


 Wir laden Sie herzlich ein:
 DSAG-Jahreskongress
 Datum: 11. - 13. Oktover 2011, Congress Center Leipzig, Halle 2 Stand B01

 Besuchen Sie uns an unserem Stand und freuen Sie sich auf einen
 intensiven Informations- und Erfahrungsaustausch rund um das
 Thema Mobility!


 Am 13.09.2011 um 14:35 schrieb Bilgin Ibryam bibr...@gmail.com:

 On Tue, Sep 13, 2011 at 9:54 AM, Adrian Crum
 adrian.c...@sandglass-software.com wrote:
 Thanks Scott - those are my feelings exactly.

 I like the way the design worked previously, and changing it because
 a user
 might accidentally leave the comments enabled in production seems
 silly.
 That is a user's QC problem, not a widget comment design problem.

 -Adrian


 + 1

  Bilgin

[jira] [Commented] (OFBIZ-4412) Set initial ecommerce Locale/Currency based on mount point specified in specialpurpose/ecommerce/ofbiz-component.xm

2011-09-14 Thread BJ Freeman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105058#comment-13105058
 ] 

BJ Freeman commented on OFBIZ-4412:
---

Goggle search is pretty intelligent
from my logs it looks like it changes the locale before reading the page.

 Set initial ecommerce Locale/Currency based on mount point specified in 
 specialpurpose/ecommerce/ofbiz-component.xm
 ---

 Key: OFBIZ-4412
 URL: https://issues.apache.org/jira/browse/OFBIZ-4412
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/ecommerce
Affects Versions: Release Branch 10.04, Release Branch 11.04, SVN trunk
 Environment: Not specific
Reporter: mz4wheeler
Priority: Trivial
  Labels: patch
 Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk

 Attachments: OFBIZ-4412.patch

   Original Estimate: 2h
  Remaining Estimate: 2h

 Using the specified patch, it is now possible to set a users initial Locale 
 (and even currency) based on the webapp mount point.  This works with a 
 single store, and does not require the use virtual hosts.  This is especially 
 useful when setting up sitemap.xml, which allows crawlers (like google) to 
 correctly locate and traverse products and services in multiple languages.
 Here is an example where ecomclone has been modified to Locale=fr with a 
 mount point of /fr.
 specialpurpose/ecommerce/ofbiz-component.xml:
 !--  init-param name=Currency value=EUR/ --
 webapp name=ecommerce
 title=eCommerce
 server=default-server
 location=webapp/ecommerce
 mount-point=/ecommerce
 app-bar-display=false
 /webapp
 webapp name=ecomclone
 title=eCommerce Clone
 server=default-server
 location=webapp/ecomclone
 mount-point=/fr--- SPECIFY MOUNT
 app-bar-display=false
 init-param name=Locale value=fr/  --- SPECIFY LOCALE
 /webapp
 The below sitemap.xml would allow products with the /fr path to be indexed 
 in french.
 ?xml version=1.0 encoding=UTF-8?
 urlset xmlns=http://www.sitemaps.org/schemas/sitemap/0.9;
 urllochttp://ofbizsite.com/ecommerce/products/10002/p_1001TANGRAMPUZ/loc/url
 urllochttp://ofbizsite.com/fr/products/10002/p_1001TANGRAMPUZ/loc/url
 /urlset
 The patch:
 The attached patch modifies setDefaultStoreSettings in ProductEvents.java, 
 which is called once during the initial session creation.  
 After a user enters the URL, they are still free to modify the language, as 
 long as the page supports it (like the default demo store).  The patch also 
 allows the Currency to be forced as well, and it does appear to work, but 
 should be more throughly tested.
 Although this patch bypasses the requirement for multiple stores, there may 
 be issues with other aspects of the store, like emails.  However, it is no 
 different than a user who enters your English-based ecommerce store, selects 
 french, and attempts a checkout.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-3169) Implementation of Budget functionality.

2011-09-12 Thread BJ Freeman (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102959#comment-13102959
]

BJ Freeman commented on OFBIZ-3169:
---

What is the progress on this?

Implementation of Budget functionality.
---

Key: OFBIZ-3169
URL: https://issues.apache.org/jira/browse/OFBIZ-3169
Project: OFBiz
Issue Type: New Feature
Components: accounting
Affects Versions: SVN trunk
Reporter: ashish tiwari
Priority: Minor
Fix For: SVN trunk

This is regarding Budget functionality implementation in OFBiz. I have found
that enitities related to budget functionality are present in OFbiz but I
was not able to find the functional implementation for the same. So I needed
to confirm is this functionality implemented or not.
In case it is not I am interested in implementing the same in OFbiz. I have
found a general flow of the budget process and i am mentioning the steps in
this mail. So please go throurgh the steps and you are requested to give in
your comments regarding the same.
1. Request for the budget is generated by the Deptartment.
2. Budget request is submitted to board of directors/higher officials for
approval.
3. Budget request is either approved or rejected.
4. If the budget is approved it is created as annual budget(Total cost in the
budget is alloted to Department).
5. Now item wise budget is allocated to different items by Department Head.
6. Profits achieved can be calculated on the basis of fiscal years for a
budget by compairing the proposed budget and the actual budget.
7. All the data regarding the budgets created are maintained.
Waiting for your comments.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-3169) Implementation of Budget functionality.

2011-09-12 Thread BJ Freeman (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102994#comment-13102994
]

BJ Freeman commented on OFBIZ-3169:
---

EmplPosition rel EMPL_POS_BGTITM
is uses to Authorize the position when the BudgetStatus for the Budget is set
to approved.
This is done with a BudgetType =OPERATING_BUDGET
Though the Logic for this is in HR, the logic for the when the Budget is
approved an ECA is triggered that would Call the HR logic.

Implementation of Budget functionality.
---

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: widgetVerbose

2011-09-12 Thread BJ Freeman

I have notice quite different coding styles that just does not fit one
person committing code from Hans account. Maybe getting each an account
would better clarify who is committing what.

Jacques Le Roux sent the following on 9/12/2011 1:03 PM:
 I don't think you should feel disqualified because you wrote the right
 code intially!
 Hans has an explanation, but democracy is majority. And Apache way is
 vote and majority in such cases. Unfortunately there are no
 other best ways than a vote. Now, as David remarked, last time we felt
 like the United Nations in some conflicts: you need a
 respected police or army to make the law respected...
 
 What I don't understand is why Hans can't keep his changes for himself
 to let all the others happy (at least Adrian, Scott, David and I so far...)
 
 Jacques
 
 From: Adrian Crum adrian.c...@sandglass-software.com
 Maybe a vote is in order. I am not going to initiate one because I am
 the author of the original code, so I feel like I am
 disqualified.

 -Adrian

 On 9/12/2011 8:13 PM, David E Jones wrote:
 Thanks Adrian, I understand what you're getting at exactly now.

 Yes, this is frustrating isn't it, and this pattern seems to come up
 over and over. That's why I like the moderated community
 approach better (as opposed to the Apache way), and I guess you know
 my thoughts and approach on that based on my recent efforts…

 Still, I suppose that by the Apache way we should vote on this and
 consider the results binding, and make the corresponding
 changes. If someone goes against that vote result, then I'm not sure
 what the Apache way is… i.e. what do you do about a commit
 war?

 I don't know.

 -David



 On Sep 12, 2011, at 12:02 PM, Adrian Crum wrote:

 David,

 Keep in mind that the original design is one that you participated
 in. The agreement on the setting precedence in the original
 Jira issue was this:

 widget.properties -  web.xml -  URL parameters

 where widget.properties is the global default, which can be
 overridden by a setting in web.xml, which can be overridden by
 screen widgets or scripts or whatever (via the current context Map).

 The design worked great. Then Hans changed it due to a
 misunderstanding of how the design works. Despite repeated explanations
 of how the design works, and requests from three PMC members to
 revert his change, he refused to change it and threatened the
 community with a commit war. Since then we have had a number of
 issues reported on the mailing list describing how his change
 makes the setting unusable.

 It amazes me that a single -1 vote vetoes a change in the Apache
 community, but three -1 votes from PMC members can't revert
 this obvious break in software design.

 -Adrian

 On 9/12/2011 7:24 PM, Adrian Crum wrote:
 No. The approach suggested by (and committed by) Hans is that the
 setting in the widget.properties file overrides any other
 setting.

 -Adrian

 On 9/12/2011 6:19 PM, David E Jones wrote:
 No one agrees with which approach? The approach that if you pass a
 widgetVerbose=true HTTP parameter that it should override
 the widget.properties setting? I agree with that approach…

 -David


 On Sep 12, 2011, at 6:59 AM, Adrian Crum wrote:

 That's the problem - no one agrees with that approach.

 -Adrian

 On 9/12/2011 1:53 PM, Jacques Le Roux wrote:
 I think I forgot to forward Hans's answer

 Jacques

 Hans Bakker wrote:
 On Wed, 2011-08-31 at 05:15 +0200, Jacques Le Roux wrote:
 widget.properties's widget.verbose setting has precedence over
 web.xml's widgetVerbose setting. So you can't use
 parameters.widgetVerbose to override widget.verbose to false.
 Is ModelWidget.widgetBoundaryCommentsEnabled() written this
 way for
 some reasons?
 there was a lengthly discussion of this. As long as by default the
 properties file is not overridden in web.xml is fine either way.


 Another issue is that these HTML boundary comments get
 outputted even though the view handler is set to screencsv. In
 the
 widget-screen.xsd, the only way to invoke a template to
 produce CSV is usinghtmlhtml-template /, but this always adds
 HTML
 comments even if the output is CSV (see HtmlWidget class).
 Maybe we could introduce acsv   element or something like
 that?

 Anyway, both of those problems combined mean that there are no
 apparent clean ways to remove the HTML template begin/end
 boundary comments from the CSV output if you try to draw it
 with an *.ftl template. A workaround  kludge for now is to
 invoke
 the FTL manually through a Groovy script.

 Thanks

 Jacques

[jira] [Commented] (OFBIZ-3894) Refactor Email handling

2011-09-12 Thread BJ Freeman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13103019#comment-13103019
 ] 

BJ Freeman commented on OFBIZ-3894:
---

the patterned used to date is to rename the old entity create a new entity with 
the new fields or without previous fields, the use simple-methods or java with 
delegate to migrate the data.

 Refactor Email handling
 ---

 Key: OFBIZ-3894
 URL: https://issues.apache.org/jira/browse/OFBIZ-3894
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: BJ Freeman
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ-3894.patch

   Original Estimate: 1,344h
  Remaining Estimate: 1,344h

 with the addition of the Website for each component 
 1) create product store for Order entry, or use the B2C product store.
 2) move the email  widgets from ecommerce to order compontent.
 3) modify the seed data so that Order entry has it own emails from order 
 component.this would be to add emails to 
 note: as I go through the different items  this is turning out to be a bigger 
 project than I first anticipated.
 so consider this so far just ideas.
 Maybe break down in to small tasks as I have time to do something.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: widgetVerbose

2011-09-12 Thread BJ Freeman

I personally am aware of how hard it is to reviews everyone code before
being accepted for a commit.
So I adopted a design review from the complete team. Everyone had to
review and sign off n the code before it is committed.
I know that is not possible in ofbiz commit framework, however in a
private company it is and takes care of all that you expressed.


Jacques Le Roux sent the following on 9/12/2011 1:59 PM:
 There is an Apache way for that also:
 http://www.apache.org/dev/committers.html. And a related OFBiz way
 https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices
 
 
 Hans is simply committing work from his team. As long as he reviews and
 amend/fix the code, there is nothing we can say about it.
 Some complain that code quality has lowered for some time. But this is
 not only due to Hans's commits (committing contibutions is
 not an easy job). My opinion on this is as long as you improve your
 code, there is nothing wrong in committing lower quality code
 (not bad or wrong code of course). Of course it should not break and
 make wrong logic/business asumptions... Everybody has the right
 to learn... Sometimes it's the hard way... Are we not here to share?
 
 This is my own opinion, not the PMC of course...
 
 Jacques
 
 From: BJ Freeman bjf...@free-man.net
 I have notice quite different coding styles that just does not fit one
 person committing code from Hans account. Maybe getting each an account
 would better clarify who is committing what.

 Jacques Le Roux sent the following on 9/12/2011 1:03 PM:
 I don't think you should feel disqualified because you wrote the right
 code intially!
 Hans has an explanation, but democracy is majority. And Apache way is
 vote and majority in such cases. Unfortunately there are no
 other best ways than a vote. Now, as David remarked, last time we felt
 like the United Nations in some conflicts: you need a
 respected police or army to make the law respected...

 What I don't understand is why Hans can't keep his changes for himself
 to let all the others happy (at least Adrian, Scott, David and I so
 far...)

 Jacques

 From: Adrian Crum adrian.c...@sandglass-software.com
 Maybe a vote is in order. I am not going to initiate one because I am
 the author of the original code, so I feel like I am
 disqualified.

 -Adrian

 On 9/12/2011 8:13 PM, David E Jones wrote:
 Thanks Adrian, I understand what you're getting at exactly now.

 Yes, this is frustrating isn't it, and this pattern seems to come up
 over and over. That's why I like the moderated community
 approach better (as opposed to the Apache way), and I guess you know
 my thoughts and approach on that based on my recent efforts…

 Still, I suppose that by the Apache way we should vote on this and
 consider the results binding, and make the corresponding
 changes. If someone goes against that vote result, then I'm not sure
 what the Apache way is… i.e. what do you do about a commit
 war?

 I don't know.

 -David



 On Sep 12, 2011, at 12:02 PM, Adrian Crum wrote:

 David,

 Keep in mind that the original design is one that you participated
 in. The agreement on the setting precedence in the original
 Jira issue was this:

 widget.properties -  web.xml -  URL parameters

 where widget.properties is the global default, which can be
 overridden by a setting in web.xml, which can be overridden by
 screen widgets or scripts or whatever (via the current context Map).

 The design worked great. Then Hans changed it due to a
 misunderstanding of how the design works. Despite repeated
 explanations
 of how the design works, and requests from three PMC members to
 revert his change, he refused to change it and threatened the
 community with a commit war. Since then we have had a number of
 issues reported on the mailing list describing how his change
 makes the setting unusable.

 It amazes me that a single -1 vote vetoes a change in the Apache
 community, but three -1 votes from PMC members can't revert
 this obvious break in software design.

 -Adrian

 On 9/12/2011 7:24 PM, Adrian Crum wrote:
 No. The approach suggested by (and committed by) Hans is that the
 setting in the widget.properties file overrides any other
 setting.

 -Adrian

 On 9/12/2011 6:19 PM, David E Jones wrote:
 No one agrees with which approach? The approach that if you pass a
 widgetVerbose=true HTTP parameter that it should override
 the widget.properties setting? I agree with that approach…

 -David


 On Sep 12, 2011, at 6:59 AM, Adrian Crum wrote:

 That's the problem - no one agrees with that approach.

 -Adrian

 On 9/12/2011 1:53 PM, Jacques Le Roux wrote:
 I think I forgot to forward Hans's answer

 Jacques

 Hans Bakker wrote:
 On Wed, 2011-08-31 at 05:15 +0200, Jacques Le Roux wrote:
 widget.properties's widget.verbose setting has precedence over
 web.xml's widgetVerbose setting. So you can't use
 parameters.widgetVerbose to override widget.verbose to false

Re: widgetVerbose

2011-09-12 Thread BJ Freeman

the way I read Davids post was
if
(widgetVerbose property == true) then the control is in the web.xml or
parramtters. if non of them turn it off then then the comments will show.
if
(widgetVerbose property == false) then no matter what the web.xml or
paramters are set there is no comments.

Adrian Crum sent the following on 9/12/2011 6:45 PM:
 So we would do away with the ability to specify that boundary comments
 are always on?
 
 Having them on by default during development is very helpful - I use
 them all the time. I can view the page source of any screen to see where
 the widget XML file is located that generated the screen. It seems to me
 with the method you proposed, I will not be able to do that - because
 comments will be off. I would have to hack the URL and add a parameter
 to see them, or I would have to modify the application's web.xml file
 and restart the server.
 
 -Adrian
 
 On 9/13/2011 2:22 AM, David E Jones wrote:
 Based on this I'm actually reconsidering my position, however the
 current implementation is still not adequate.

 It sounds like the goal for the widget.properties is to make it easy
 to go into production and make sure that no boundary comments/etc are
 added anywhere in the system. To do that effectively you need a single
 setting for the whole system, and that setting should override
 everything else (i.e. not even allow for a parameter to be manually
 added which may expose implementation details that you want to keep
 hidden).

 For that purpose a property would make sense, but the logic has to be
 carefully done (not the shallow logic that has been discussed so far).
 It would need to be something like: if (widgetVerbose property ==
 false) then don't show else if (widgetVerbose parameter (using default
 OFBiz parameters Map, takes into account both URL parameters and
 web.xml context parameters) == true) then show else don't show.

 In other words, if the widget.properties setting is false, then never
 show boundary comments. Otherwise, ignore it and use the parameters
 value if true, and overall default to false.

 Wow, is this really that hard?

 -David



 On Sep 12, 2011, at 5:03 PM, Hans Bakker wrote:

 As i wrote before i am fine with this if in the trunk the setting of
 widget.properties is not overridden by default in web.xml for some
 component what was the case originally.

 Regards,
 Hans

 On Mon, 2011-09-12 at 20:02 +0100, Adrian Crum wrote:
 David,

 Keep in mind that the original design is one that you participated in.
 The agreement on the setting precedence in the original Jira issue
 was this:

 widget.properties -  web.xml -  URL parameters

 where widget.properties is the global default, which can be overridden
 by a setting in web.xml, which can be overridden by screen widgets or
 scripts or whatever (via the current context Map).

 The design worked great. Then Hans changed it due to a misunderstanding
 of how the design works. Despite repeated explanations of how the
 design
 works, and requests from three PMC members to revert his change, he
 refused to change it and threatened the community with a commit war.
 Since then we have had a number of issues reported on the mailing list
 describing how his change makes the setting unusable.

 It amazes me that a single -1 vote vetoes a change in the Apache
 community, but three -1 votes from PMC members can't revert this
 obvious
 break in software design.

 -Adrian

 On 9/12/2011 7:24 PM, Adrian Crum wrote:
 No. The approach suggested by (and committed by) Hans is that the
 setting in the widget.properties file overrides any other setting.

 -Adrian

 On 9/12/2011 6:19 PM, David E Jones wrote:
 No one agrees with which approach? The approach that if you pass a
 widgetVerbose=true HTTP parameter that it should override the
 widget.properties setting? I agree with that approach…

 -David


 On Sep 12, 2011, at 6:59 AM, Adrian Crum wrote:

 That's the problem - no one agrees with that approach.

 -Adrian

 On 9/12/2011 1:53 PM, Jacques Le Roux wrote:
 I think I forgot to forward Hans's answer

 Jacques

 Hans Bakker wrote:
 On Wed, 2011-08-31 at 05:15 +0200, Jacques Le Roux wrote:
 widget.properties's widget.verbose setting has precedence over
 web.xml's widgetVerbose setting. So you can't use
 parameters.widgetVerbose to override widget.verbose to false. Is
 ModelWidget.widgetBoundaryCommentsEnabled() written this way for
 some reasons?
 there was a lengthly discussion of this. As long as by default the
 properties file is not overridden in web.xml is fine either way.


 Another issue is that these HTML boundary comments get outputted
 even though the view handler is set to screencsv. In the
 widget-screen.xsd, the only way to invoke a template to produce
 CSV is usinghtmlhtml-template /, but this always adds HTML
 comments even if the output is CSV (see HtmlWidget class). Maybe
 we could introduce acsv   element or something like that?

 Anyway, both of those problems combined mean that there are

[jira] [Commented] (OFBIZ-4396) Project Manager Gantt chart does not display correctly using any of the visual themes


[ 
https://issues.apache.org/jira/browse/OFBIZ-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13100377#comment-13100377
 ] 

BJ Freeman commented on OFBIZ-4396:
---

I suggest you either upgrade to trunk or go through the commits to see what has 
been added that fixed this.
I also use eclipse and view the SVN history for a component, this helps in 
tracking down the commit(s) that I need.

 Project Manager Gantt chart does not display correctly using any of the 
 visual themes
 -

 Key: OFBIZ-4396
 URL: https://issues.apache.org/jira/browse/OFBIZ-4396
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Affects Versions: Release 10.04
 Environment: RHEL 5.5 
 JDK 1.6 
 MySQL 5
Reporter: Tolulope Aganga-Williams
Priority: Minor
  Labels: jsgantt, projectmgr

 The Gannt chart displays incorrectly in every browser and using any visual 
 theme. The chart does not align the task on the left to the progress bar on 
 the right. The problem is bad to severe depending on which visual theme you 
 have enabled. I have even updated to the latest JSGantt some improvement but 
 does not fix it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4400) Minor code style improvement


[ 
https://issues.apache.org/jira/browse/OFBIZ-4400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13100445#comment-13100445
 ] 

BJ Freeman commented on OFBIZ-4400:
---

I am out of my league here but can be make the UTF-8 a variable that is passed 
down from the view-map?
If it is null then Defualt to UTF-8

 Minor code style improvement
 

 Key: OFBIZ-4400
 URL: https://issues.apache.org/jira/browse/OFBIZ-4400
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Dimitri Unruh
Priority: Minor
 Attachments: OFBIZ-4400.patch


 In the createJsLanguageFileMapping service, the catch blocks have assigns to 
 a local variable in a return statement.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4396) Project Manager Gantt chart does not display correctly using any of the visual themes


[ 
https://issues.apache.org/jira/browse/OFBIZ-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13100630#comment-13100630
 ] 

BJ Freeman commented on OFBIZ-4396:
---

component://projectmgr/webapp/projectmgr/project/gantChart.ftl
div style=position:relative class=gantt id=GanttChartDIV/div
is where I would start.
Look in the CSS file to see what is being used.

 Project Manager Gantt chart does not display correctly using any of the 
 visual themes
 -

 Key: OFBIZ-4396
 URL: https://issues.apache.org/jira/browse/OFBIZ-4396
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Affects Versions: Release 10.04
 Environment: RHEL 5.5 
 JDK 1.6 
 MySQL 5
Reporter: Tolulope Aganga-Williams
Priority: Minor
  Labels: jsgantt, projectmgr

 The Gannt chart displays incorrectly in every browser and using any visual 
 theme. The chart does not align the task on the left to the progress bar on 
 the right. The problem is bad to severe depending on which visual theme you 
 have enabled. I have even updated to the latest JSGantt some improvement but 
 does not fix it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4396) Project Manager Gantt chart does not display correctly using any of the visual themes


[ 
https://issues.apache.org/jira/browse/OFBIZ-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13100760#comment-13100760
 ] 

BJ Freeman commented on OFBIZ-4396:
---

I use 
http://sourceforge.net/projects/openproj/
so i will not be much more help.

 Project Manager Gantt chart does not display correctly using any of the 
 visual themes
 -

 Key: OFBIZ-4396
 URL: https://issues.apache.org/jira/browse/OFBIZ-4396
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Affects Versions: Release 10.04
 Environment: RHEL 5.5 
 JDK 1.6 
 MySQL 5
Reporter: Tolulope Aganga-Williams
Priority: Minor
  Labels: jsgantt, projectmgr

 The Gannt chart displays incorrectly in every browser and using any visual 
 theme. The chart does not align the task on the left to the progress bar on 
 the right. The problem is bad to severe depending on which visual theme you 
 have enabled. I have even updated to the latest JSGantt some improvement but 
 does not fix it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4396) Project Manager Gantt chart does not display correctly using any of the visual themes


[ 
https://issues.apache.org/jira/browse/OFBIZ-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13100887#comment-13100887
 ] 

BJ Freeman commented on OFBIZ-4396:
---

Yes, and I integrated it in my version that is based on ofbiz Architecture and 
modeling.
Most of my UI is SWT. And like the GNATT.JS used a ftl to pass data to the JS I 
use widgets to pass data to the SWT client.


 Project Manager Gantt chart does not display correctly using any of the 
 visual themes
 -

 Key: OFBIZ-4396
 URL: https://issues.apache.org/jira/browse/OFBIZ-4396
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Affects Versions: Release 10.04
 Environment: RHEL 5.5 
 JDK 1.6 
 MySQL 5
Reporter: Tolulope Aganga-Williams
Priority: Minor
  Labels: jsgantt, projectmgr

 The Gannt chart displays incorrectly in every browser and using any visual 
 theme. The chart does not align the task on the left to the progress bar on 
 the right. The problem is bad to severe depending on which visual theme you 
 have enabled. I have even updated to the latest JSGantt some improvement but 
 does not fix it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4396) Project Manager Gantt chart does not display correctly using any of the visual themes

2011-09-07 Thread BJ Freeman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13099751#comment-13099751
 ] 

BJ Freeman commented on OFBIZ-4396:
---

does what you see look like:
https://demo-trunk.ofbiz.apache.org:8443/projectmgr/control/ganttChart?projectId=9000



 Project Manager Gantt chart does not display correctly using any of the 
 visual themes
 -

 Key: OFBIZ-4396
 URL: https://issues.apache.org/jira/browse/OFBIZ-4396
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/projectmgr
Affects Versions: Release 10.04
 Environment: RHEL 5.5 
 JDK 1.6 
 MySQL 5
Reporter: Tolulope Aganga-Williams
Priority: Minor
  Labels: jsgantt, projectmgr

 The Gannt chart displays incorrectly in every browser and using any visual 
 theme. The chart does not align the task on the left to the progress bar on 
 the right. The problem is bad to severe depending on which visual theme you 
 have enabled. I have even updated to the latest JSGantt some improvement but 
 does not fix it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

2011-09-04 Thread BJ Freeman (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13096886#comment-13096886
]

BJ Freeman commented on OFBIZ-4120:
---

For sometime I have been promoting ofbiz to a larger Company.
it is National with headquarters in One City and Multiple manufacturing
and Assembly Plants in multiple States.
They use VPN to tie all together.

My contact was impressed in ofbiz I showed him on the Demo site, while
he was at home. He went to show others at work and it did not work well.
His Company has a security rule that does not allow any JavaScript into
their computers, as well all their internal websites can not use javascript.

You can See the results by disabling JavaScript in your browser and look
at the Ofbiz Demo.

I have been given to the end of Sept to come up with a proposal on
delivering the functionality but without JavaScript.
The staffing for doing this is an additional 10-20 positions for 1-5 years.

My problem is I have not found enough people that:
1)Understand the Design of Ofbiz
2)Understand the Modeling used based on the videos David did
3)willing to work with the tools that was developed in Ofbiz.
4)Know Ofbiz well enough to reuse code already available.
5)be able to develop code that will do the what is done in JavaScript
but no use javascript.

This project is worth 100's thousand US dollars. Of that, I am willing
of use 10% to fund those working on the project to augment ofbiz in the
same spirit.

The focus of this email is maybe the ofbiz team should re-think the
direction OFbiz is going.

Umbrella task for features which use javascript to degrade gracefully
--

Key: OFBIZ-4120
URL: https://issues.apache.org/jira/browse/OFBIZ-4120
Project: OFBiz
Issue Type: Bug
Components: ALL APPLICATIONS
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux

By using more an more javascript we forget sometimes that it may not
available and OFBiz features should continue to work even it's not as easier
for users than wih javascript.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Refactoring HR

In researching PartyRelationships I reviewed HR and found it is not
following good practices. It also deviates from the model book.
for instance there is No entity Employment, which is
PartyRelationship.PartyRelationshiptype=Employment.
PartyRelationshipType seed data is also not implemented correctly.

PartyRelationship is not implemented properly so has crippled the
ability to do expand coding.
I can only assume that all the rest of the module has more problems
since the key is the PartyRelationship

Re: Party Classification Data Modeling

PartyClassificationType description=Minority hasTable=N
parentTypeId= partyClassificationTypeId=MINORITY_CLASSIFICAT/
PartyClassificationType description=Hispanic hasTable=N
parentTypeId=MINORITY_CLASSIFICA
partyClassificationTypeId=HISPANIC_CLASSIFICAT/


Adrian Crum sent the following on 1/10/2011 4:27 PM:
 I spent some time in Party Manager trying to make sense of the Party 
 Classification feature, and I can't seem to make it do anything meaningful. 
 Maybe I'm not understanding something, so I'll provide an example and see if 
 anyone knows how to implement it in the current code.
 
 In table 2.3 of the Data Model Resource Book, there is a party named Marc 
 Martinez who has been classified as Hispanic. I will use him for my example.
 
 In Party Manager I create a person named Marc Martinez and I want to classify 
 him as Hispanic. I would also like to include the Hispanic classification in 
 two classification groups: US Minorities and Non-White. I go to the 
 Classifications tab - where I can create classification groups from a list of 
 pre-defined group types. I choose the Minority type, type US Minorities in 
 the Description field, and save the group. I want to add the Hispanic 
 classification to this group, but I don't see any way to add classifications. 
 I go to Marc's profile page and try to assign him a classification, but I can 
 only assign him to a classification group. If I assign him to the US 
 Minorities group that still doesn't classify him as Hispanic. 
 
 As far as I can tell, Party Classification doesn't work.
 
 Any ideas?
 
 -Adrian
 
 
 --- On Mon, 1/3/11, Adrian Crum adrian.c...@yahoo.com wrote:
 Understood. If we wanted to create
 entities to avoid the sub-types mentioned in the book
 (Organization Classification, Person Classisfication, etc)
 then I think we could have done that in a simpler way and
 still keep the book's model:

 PartyClassificationGroupType
 
 *groupTypeId
 description
 parentGroupTypeId

 PartyClassificationGroup
 
 *groupTypeId
 *partyTypeId

 Anyways, I have come up with a workaround. I'll just use
 the existing PartyClassificationGroup the way the book uses
 PartyType.

 -Adrian


 --- On Mon, 1/3/11, David E Jones d...@me.com
 wrote:
 Every single *Type entity in OFBiz is a deviation from
 the
 book (ie the *Type entities are an OFBiz pattern to
 avoid
 redundant entities and keep track of entity extensions
 like
 the Party - PartyGroup,Person thingy), as are
 dozens of
 other entities and hundreds of fields. That book is
 valuable
 for general concepts and patterns, and is not an
 actual data
 model to be used as-is.

 -David


 On Jan 3, 2011, at 5:57 PM, Adrian Crum wrote:

 I don't think I'm generalizing anything. The book
 is
 pretty specific and clear: Party Classification is an
 intersection entity that sets up a many-to-many
 relationship
 between the Party entity and the Party Type entity.

 I understand OFBiz deviates from the book here
 and
 there, and if this is one of those cases, then I'll
 ask
 again: Why was it done that way?

 I'm trying to make sense of the OFBiz Party
 Classification model, and so far it doesn't make
 sense. The
 way it is set up, I can't give a party a
 classification
 without first creating a classification group, assign
 a
 classification type to it, and then assign the party
 to the
 classification group using party classification.

 In the book it's much simpler - I just assign a
 party
 type to a party using a party classification.
 Classification
 groups are Party Classification sub-types and they
 aren't
 necessary unless I want to group things a certain
 way.

 -Adrian

 --- On Mon, 1/3/11, David E Jones d...@me.com
 wrote:
 I think you may be taking the specific term
 type
 and
 generalizing it. Consider that *Type entities
 in
 OFBiz mean
 something very specific, and it is different
 from
 the more
 general use of the term in the book.

 -David


 On Jan 3, 2011, at 3:24 PM, Adrian Crum
 wrote:

 That's not what the book shows. There is
 a
 simple
 relationship:

 Party - PartyClassification -
 PartyType

 If you want to group classifications,
 give
 them
 parent/child relationships, etc then you do
 it
 with
 PartyType, not PartyClassification. Look at
 table
 2.3 on
 page 32.

 -Adrian

 --- On Mon, 1/3/11, BJ Freeman bjf...@free-man.net
 wrote:
 how about a pattern of parent child
 for PartyClassification of supertype

 and the sub types then use a
 table for the
 attributess of the subtype.
 this would allow walking the parnent
 child
 relationships.
 PartyClassification 



 ---organizationClassificationminorityClassification

   

  

  
industryclassification

 =
 BJ Freeman
 Strategic Power Office with Supplier
 Automation 
 http://www.businessesnetwork.com/automation/viewforum.php?f=52
 Specialtymarket.com  http://www.specialtymarket.com/
 Systems Integrator-- Glad

Re: Party Classification Data Modeling

Parent child is the same as grouping in my view.
it even gives you a hierarchy
so if you point to Hispanic you can find it under Minorities.
if you want to further define Hispanic, Like Castillian or Mexican they
can be child of Hispanic

Adrian Crum sent the following on 9/4/2011 11:10 AM:
 And your point is? That doesn't assign Hispanic to a classification
 group, it only makes Hispanic a child classification of the Minority
 Classification.
 
 At any rate, I have implemented the pattern I needed locally, and I have
 given up trying to make the case for an improved Party Classification
 data model.
 
 -Adrian
 
 On 9/4/2011 7:04 PM, BJ Freeman wrote:
  PartyClassificationType description=Minority hasTable=N
 parentTypeId= partyClassificationTypeId=MINORITY_CLASSIFICAT/
  PartyClassificationType description=Hispanic hasTable=N
 parentTypeId=MINORITY_CLASSIFICA
 partyClassificationTypeId=HISPANIC_CLASSIFICAT/


 Adrian Crum sent the following on 1/10/2011 4:27 PM:
 I spent some time in Party Manager trying to make sense of the Party
 Classification feature, and I can't seem to make it do anything
 meaningful. Maybe I'm not understanding something, so I'll provide an
 example and see if anyone knows how to implement it in the current code.

 In table 2.3 of the Data Model Resource Book, there is a party named
 Marc Martinez who has been classified as Hispanic. I will use him for
 my example.

 In Party Manager I create a person named Marc Martinez and I want to
 classify him as Hispanic. I would also like to include the Hispanic
 classification in two classification groups: US Minorities and
 Non-White. I go to the Classifications tab - where I can create
 classification groups from a list of pre-defined group types. I
 choose the Minority type, type US Minorities in the Description
 field, and save the group. I want to add the Hispanic classification
 to this group, but I don't see any way to add classifications. I go
 to Marc's profile page and try to assign him a classification, but I
 can only assign him to a classification group. If I assign him to the
 US Minorities group that still doesn't classify him as Hispanic.

 As far as I can tell, Party Classification doesn't work.

 Any ideas?

 -Adrian


 --- On Mon, 1/3/11, Adrian Crumadrian.c...@yahoo.com  wrote:
 Understood. If we wanted to create
 entities to avoid the sub-types mentioned in the book
 (Organization Classification, Person Classisfication, etc)
 then I think we could have done that in a simpler way and
 still keep the book's model:

 PartyClassificationGroupType
 
 *groupTypeId
 description
 parentGroupTypeId

 PartyClassificationGroup
 
 *groupTypeId
 *partyTypeId

 Anyways, I have come up with a workaround. I'll just use
 the existing PartyClassificationGroup the way the book uses
 PartyType.

 -Adrian


 --- On Mon, 1/3/11, David E Jonesd...@me.com
 wrote:
 Every single *Type entity in OFBiz is a deviation from
 the
 book (ie the *Type entities are an OFBiz pattern to
 avoid
 redundant entities and keep track of entity extensions
 like
 the Party -  PartyGroup,Person thingy), as are
 dozens of
 other entities and hundreds of fields. That book is
 valuable
 for general concepts and patterns, and is not an
 actual data
 model to be used as-is.

 -David


 On Jan 3, 2011, at 5:57 PM, Adrian Crum wrote:

 I don't think I'm generalizing anything. The book
 is
 pretty specific and clear: Party Classification is an
 intersection entity that sets up a many-to-many
 relationship
 between the Party entity and the Party Type entity.
 I understand OFBiz deviates from the book here
 and
 there, and if this is one of those cases, then I'll
 ask
 again: Why was it done that way?
 I'm trying to make sense of the OFBiz Party
 Classification model, and so far it doesn't make
 sense. The
 way it is set up, I can't give a party a
 classification
 without first creating a classification group, assign
 a
 classification type to it, and then assign the party
 to the
 classification group using party classification.
 In the book it's much simpler - I just assign a
 party
 type to a party using a party classification.
 Classification
 groups are Party Classification sub-types and they
 aren't
 necessary unless I want to group things a certain
 way.
 -Adrian

 --- On Mon, 1/3/11, David E Jonesd...@me.com
 wrote:
 I think you may be taking the specific term
 type
 and
 generalizing it. Consider that *Type entities
 in
 OFBiz mean
 something very specific, and it is different
 from
 the more
 general use of the term in the book.

 -David


 On Jan 3, 2011, at 3:24 PM, Adrian Crum
 wrote:
 That's not what the book shows. There is
 a
 simple
 relationship:
 Party -  PartyClassification -
 PartyType
 If you want to group classifications,
 give
 them
 parent/child relationships, etc then you do
 it
 with
 PartyType, not PartyClassification. Look at
 table
 2.3 on
 page 32.
 -Adrian

 --- On Mon, 1/3/11, BJ

Re: Party Classification Data Modeling

Looks like I missed an important part of you thinking.

Adrian Crum sent the following on 9/4/2011 11:36 AM:
 No, I want Hispanic to be a member of an arbitrary number of groups.
 
 -Adrian
 
 On 9/4/2011 7:34 PM, BJ Freeman wrote:
 Parent child is the same as grouping in my view.
 it even gives you a hierarchy
 so if you point to Hispanic you can find it under Minorities.
 if you want to further define Hispanic, Like Castillian or Mexican they
 can be child of Hispanic

 Adrian Crum sent the following on 9/4/2011 11:10 AM:
 And your point is? That doesn't assign Hispanic to a classification
 group, it only makes Hispanic a child classification of the Minority
 Classification.

 At any rate, I have implemented the pattern I needed locally, and I have
 given up trying to make the case for an improved Party Classification
 data model.

 -Adrian

 On 9/4/2011 7:04 PM, BJ Freeman wrote:
   PartyClassificationType description=Minority hasTable=N
 parentTypeId= partyClassificationTypeId=MINORITY_CLASSIFICAT/
   PartyClassificationType description=Hispanic hasTable=N
 parentTypeId=MINORITY_CLASSIFICA
 partyClassificationTypeId=HISPANIC_CLASSIFICAT/


 Adrian Crum sent the following on 1/10/2011 4:27 PM:
 I spent some time in Party Manager trying to make sense of the Party
 Classification feature, and I can't seem to make it do anything
 meaningful. Maybe I'm not understanding something, so I'll provide an
 example and see if anyone knows how to implement it in the current
 code.

 In table 2.3 of the Data Model Resource Book, there is a party named
 Marc Martinez who has been classified as Hispanic. I will use him for
 my example.

 In Party Manager I create a person named Marc Martinez and I want to
 classify him as Hispanic. I would also like to include the Hispanic
 classification in two classification groups: US Minorities and
 Non-White. I go to the Classifications tab - where I can create
 classification groups from a list of pre-defined group types. I
 choose the Minority type, type US Minorities in the Description
 field, and save the group. I want to add the Hispanic classification
 to this group, but I don't see any way to add classifications. I go
 to Marc's profile page and try to assign him a classification, but I
 can only assign him to a classification group. If I assign him to the
 US Minorities group that still doesn't classify him as Hispanic.

 As far as I can tell, Party Classification doesn't work.

 Any ideas?

 -Adrian


 --- On Mon, 1/3/11, Adrian Crumadrian.c...@yahoo.com   wrote:
 Understood. If we wanted to create
 entities to avoid the sub-types mentioned in the book
 (Organization Classification, Person Classisfication, etc)
 then I think we could have done that in a simpler way and
 still keep the book's model:

 PartyClassificationGroupType
 
 *groupTypeId
 description
 parentGroupTypeId

 PartyClassificationGroup
 
 *groupTypeId
 *partyTypeId

 Anyways, I have come up with a workaround. I'll just use
 the existing PartyClassificationGroup the way the book uses
 PartyType.

 -Adrian


 --- On Mon, 1/3/11, David E Jonesd...@me.com
 wrote:
 Every single *Type entity in OFBiz is a deviation from
 the
 book (ie the *Type entities are an OFBiz pattern to
 avoid
 redundant entities and keep track of entity extensions
 like
 the Party -   PartyGroup,Person thingy), as are
 dozens of
 other entities and hundreds of fields. That book is
 valuable
 for general concepts and patterns, and is not an
 actual data
 model to be used as-is.

 -David


 On Jan 3, 2011, at 5:57 PM, Adrian Crum wrote:

 I don't think I'm generalizing anything. The book
 is
 pretty specific and clear: Party Classification is an
 intersection entity that sets up a many-to-many
 relationship
 between the Party entity and the Party Type entity.
 I understand OFBiz deviates from the book here
 and
 there, and if this is one of those cases, then I'll
 ask
 again: Why was it done that way?
 I'm trying to make sense of the OFBiz Party
 Classification model, and so far it doesn't make
 sense. The
 way it is set up, I can't give a party a
 classification
 without first creating a classification group, assign
 a
 classification type to it, and then assign the party
 to the
 classification group using party classification.
 In the book it's much simpler - I just assign a
 party
 type to a party using a party classification.
 Classification
 groups are Party Classification sub-types and they
 aren't
 necessary unless I want to group things a certain
 way.
 -Adrian

 --- On Mon, 1/3/11, David E Jonesd...@me.com
 wrote:
 I think you may be taking the specific term
 type
 and
 generalizing it. Consider that *Type entities
 in
 OFBiz mean
 something very specific, and it is different
 from
 the more
 general use of the term in the book.

 -David


 On Jan 3, 2011, at 3:24 PM, Adrian Crum
 wrote:
 That's not what the book shows. There is
 a
 simple
 relationship:
 Party

Re: Party Classification Data Modeling

Thanks once i get some other stuff out of the way will try to evaluate
what this means.

Adrian Crum sent the following on 9/4/2011 11:54 AM:
 The marketing department will want to group party classifications one
 way. The human resources department will want to group party
 classifications another way. A department head might want to group
 subordinates a certain way. How is each party classification grouping
 handled without redundant and potentially stale data? By grouping party
 classifications instead of grouping parties. When a party's
 classification changes, their membership in the various party
 classification groups changes automatically.
 
 It's simple and flexible.
 
 -Adrian
 
 
 On 9/4/2011 7:47 PM, BJ Freeman wrote:
 Looks like I missed an important part of you thinking.

 Adrian Crum sent the following on 9/4/2011 11:36 AM:
 No, I want Hispanic to be a member of an arbitrary number of groups.

 -Adrian

 On 9/4/2011 7:34 PM, BJ Freeman wrote:
 Parent child is the same as grouping in my view.
 it even gives you a hierarchy
 so if you point to Hispanic you can find it under Minorities.
 if you want to further define Hispanic, Like Castillian or Mexican they
 can be child of Hispanic

 Adrian Crum sent the following on 9/4/2011 11:10 AM:
 And your point is? That doesn't assign Hispanic to a classification
 group, it only makes Hispanic a child classification of the Minority
 Classification.

 At any rate, I have implemented the pattern I needed locally, and I
 have
 given up trying to make the case for an improved Party Classification
 data model.

 -Adrian

 On 9/4/2011 7:04 PM, BJ Freeman wrote:
PartyClassificationType description=Minority hasTable=N
 parentTypeId= partyClassificationTypeId=MINORITY_CLASSIFICAT/
PartyClassificationType description=Hispanic hasTable=N
 parentTypeId=MINORITY_CLASSIFICA
 partyClassificationTypeId=HISPANIC_CLASSIFICAT/


 Adrian Crum sent the following on 1/10/2011 4:27 PM:
 I spent some time in Party Manager trying to make sense of the Party
 Classification feature, and I can't seem to make it do anything
 meaningful. Maybe I'm not understanding something, so I'll
 provide an
 example and see if anyone knows how to implement it in the current
 code.

 In table 2.3 of the Data Model Resource Book, there is a party named
 Marc Martinez who has been classified as Hispanic. I will use him
 for
 my example.

 In Party Manager I create a person named Marc Martinez and I want to
 classify him as Hispanic. I would also like to include the Hispanic
 classification in two classification groups: US Minorities and
 Non-White. I go to the Classifications tab - where I can create
 classification groups from a list of pre-defined group types. I
 choose the Minority type, type US Minorities in the Description
 field, and save the group. I want to add the Hispanic classification
 to this group, but I don't see any way to add classifications. I go
 to Marc's profile page and try to assign him a classification, but I
 can only assign him to a classification group. If I assign him to
 the
 US Minorities group that still doesn't classify him as Hispanic.

 As far as I can tell, Party Classification doesn't work.

 Any ideas?

 -Adrian


 --- On Mon, 1/3/11, Adrian Crumadrian.c...@yahoo.comwrote:
 Understood. If we wanted to create
 entities to avoid the sub-types mentioned in the book
 (Organization Classification, Person Classisfication, etc)
 then I think we could have done that in a simpler way and
 still keep the book's model:

 PartyClassificationGroupType
 
 *groupTypeId
 description
 parentGroupTypeId

 PartyClassificationGroup
 
 *groupTypeId
 *partyTypeId

 Anyways, I have come up with a workaround. I'll just use
 the existing PartyClassificationGroup the way the book uses
 PartyType.

 -Adrian


 --- On Mon, 1/3/11, David E Jonesd...@me.com
 wrote:
 Every single *Type entity in OFBiz is a deviation from
 the
 book (ie the *Type entities are an OFBiz pattern to
 avoid
 redundant entities and keep track of entity extensions
 like
 the Party -PartyGroup,Person thingy), as are
 dozens of
 other entities and hundreds of fields. That book is
 valuable
 for general concepts and patterns, and is not an
 actual data
 model to be used as-is.

 -David


 On Jan 3, 2011, at 5:57 PM, Adrian Crum wrote:

 I don't think I'm generalizing anything. The book
 is
 pretty specific and clear: Party Classification is an
 intersection entity that sets up a many-to-many
 relationship
 between the Party entity and the Party Type entity.
 I understand OFBiz deviates from the book here
 and
 there, and if this is one of those cases, then I'll
 ask
 again: Why was it done that way?
 I'm trying to make sense of the OFBiz Party
 Classification model, and so far it doesn't make
 sense. The
 way it is set up, I can't give a party a
 classification
 without first creating a classification group, assign
 a
 classification type

[jira] [Commented] (OFBIZ-3406) Adding party relationship roles - error message is confusing.

2011-09-04 Thread BJ Freeman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13096953#comment-13096953
 ] 

BJ Freeman commented on OFBIZ-3406:
---

Ok, seems that once the PartyRelationshipType is specified that the 
PartyRelationshipType.roleTypeIdValidFrom and 
PartyRelationshipType.roleTypeIdValidto can be done with a EECA
Then the only Screen that is available is the PartyRelationshipType 

 Adding party relationship roles - error message is confusing.
 -

 Key: OFBIZ-3406
 URL: https://issues.apache.org/jira/browse/OFBIZ-3406
 Project: OFBiz
  Issue Type: Improvement
  Components: party
Affects Versions: SVN trunk
Reporter: chris snow
Assignee: Jacques Le Roux

 On a few occasions I have tried to add party relationships, but have failed 
 with an error message similar to the following.  The error message provided 
 no help in identifying the problem:
 {code}
 Error trying to begin transaction, could not process method: The current 
 transaction is marked for rollback, not beginning a new transaction and 
 aborting 
 current operation; the rollbackOnly was caused by: Failure in create 
 operation for entity [PartyRole]: org.ofbiz.entity.GenericEntityException: 
 Error while 
 inserting: [GenericEntity:PartyRole][createdStamp,2010-01-11 
 14:04:02.002(java.sql.Timestamp)][createdTxStamp,2010-01-11 
 14:04:01.966(java.sql.Timestamp)][lastUpdatedStamp,2010-01-11 
 14:04:02.002(java.sql.Timestamp)][lastUpdatedTxStamp,2010-01-11 
 14:04:01.966(java.sql.Timestamp)][partyId,11(java.lang.String)][roleTypeId,_NA_(java.lang.String)]
  (SQL Exception while executing the 
 following:INSERT INTO OFBIZ.PARTY_ROLE (PARTY_ID, ROLE_TYPE_ID, 
 LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
 CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?) (INSERT on table 'PARTY_ROLE' 
 caused a violation of foreign key constraint 'PARTY_RLE_PARTY' for 
 key (11). The statement has been rolled back.)). Rolling back 
 transaction.org.ofbiz.entity.GenericEntityException: Error while inserting: 
 [GenericEntity:PartyRole][createdStamp,2010-01-11 
 14:04:02.002(java.sql.Timestamp)][createdTxStamp,2010-01-11 
 14:04:01.966(java.sql.Timestamp)]
 [lastUpdatedStamp,2010-01-11 
 14:04:02.002(java.sql.Timestamp)][lastUpdatedTxStamp,2010-01-11 
 14:04:01.966(java.sql.Timestamp)]
 [partyId,11(java.lang.String)][roleTypeId,_NA_(java.lang.String)] (SQL 
 Exception while executing the following:INSERT INTO OFBIZ.PARTY_ROLE 
 (PARTY_ID, ROLE_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, 
 CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, 
 ?, ?) (INSERT on table 'PARTY_ROLE' caused a violation of foreign key 
 constraint 'PARTY_RLE_PARTY' for key (11). The statement has been rolled 
 back.)) (Error while inserting: 
 [GenericEntity:PartyRole][createdStamp,2010-01-11 
 14:04:02.002(java.sql.Timestamp)][createdTxStamp,2010-01-11 
 14:04:01.966(java.sql.Timestamp)][lastUpdatedStamp,2010-01-11 
 14:04:02.002(java.sql.Timestamp)][lastUpdatedTxStamp,2010-01-11 
 14:04:01.966(java.sql.Timestamp)][partyId,11(java.lang.String)][roleTypeId,_NA_(java.lang.String)]
  (SQL Exception while executing the 
 following:INSERT INTO OFBIZ.PARTY_ROLE (PARTY_ID, ROLE_TYPE_ID, 
 LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
 CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?) (INSERT on table 'PARTY_ROLE' 
 caused a violation of foreign key constraint 'PARTY_RLE_PARTY' for 
 key (11). The statement has been rolled back.)))
 {code}
 If validation code was put into the createPartyRelationship service, a more 
 friendly error message could be returned to the user:
 {code}
 simple-method method-name=createPartyRelationship 
 short-description=createPartyRelationship
 if-empty field=parameters.roleTypeIdFromset 
 field=parameters.roleTypeIdFrom value=_NA_//if-empty
 if-empty field=parameters.roleTypeIdToset 
 field=parameters.roleTypeIdTo value=_NA_//if-empty
 if-empty field=parameters.partyIdFromset 
 field=parameters.partyIdFrom from-field=userLogin.partyId//if-empty
 if-empty field=parameters.fromDatenow-timestamp 
 field=parameters.fromDate//if-empty
 !-- check if not already exist --
 entity-and entity-name=PartyRelationship list=partyRels 
 filter-by-date=true
 field-map field-name=partyIdFrom 
 from-field=parameters.partyIdFrom/
 field-map field-name=roleTypeIdFrom 
 from-field=parameters.roleTypeIdFrom/
 field-map field-name=partyIdTo 
 from-field=parameters.partyIdTo/
 field-map field-name=roleTypeIdTo 
 from-field=parameters.roleTypeIdTo/
 /entity-and
 !-- MORE HELPFUL ERROR MESSAGE START --
   if-compare field=parameters.roleTypeIdTo 
 operator=not-equals value

[jira] [Commented] (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

2011-09-04 Thread BJ Freeman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13096958#comment-13096958
 ] 

BJ Freeman commented on OFBIZ-4120:
---

What I think best fits this and other UI requirments is to use multiple 
view-maps and let the renderer select which one.
this would allow many types. I am still investigating this.
Another Ideas is to tie it into the Themes so they specify the type of output 
they use.
I don't see changing the current pages, since they work fine for those that 
want to use JS.


 Umbrella task for features which use javascript to degrade gracefully 
 --

 Key: OFBIZ-4120
 URL: https://issues.apache.org/jira/browse/OFBIZ-4120
 Project: OFBiz
  Issue Type: Bug
  Components: ALL APPLICATIONS
Affects Versions: SVN trunk
Reporter: Jacques Le Roux

 By using more an more javascript we forget sometimes that it may not 
 available and OFBiz features should continue to work even it's not as easier 
 for users than wih javascript.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Party Classification Data Modeling