from:"Christian Geisert"


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert resolved OFBIZ-5514.
--

   Resolution: Fixed
Fix Version/s: Upcoming Branch

Fix committed in r1619098. Thanks for reporting!

 EntitySyncServices.cleanSyncRemoveInfo() takes minutes as seconds
 -

 Key: OFBIZ-5514
 URL: https://issues.apache.org/jira/browse/OFBIZ-5514
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 11.04, Release Branch 12.04, Trunk
Reporter: Roberto Benítez Monje
Assignee: Christian Geisert
  Labels: entityext, entitysync, framework
 Fix For: Upcoming Branch

   Original Estimate: 1h
  Remaining Estimate: 1h

 The method EntitySyncServices.cleanSyncRemoveInfo() takes minutes as seconds 
 when calculate the value of keepSeconds.
 Instead of multiply by 3600, its does by 60



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5514) EntitySyncServices.cleanSyncRemoveInfo() takes minutes as seconds


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5514:
-

Fix Version/s: 13.07.01
   12.04.05
   11.04.06

 EntitySyncServices.cleanSyncRemoveInfo() takes minutes as seconds
 -

 Key: OFBIZ-5514
 URL: https://issues.apache.org/jira/browse/OFBIZ-5514
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 11.04, Release Branch 12.04, Trunk
Reporter: Roberto Benítez Monje
Assignee: Christian Geisert
  Labels: entityext, entitysync, framework
 Fix For: 11.04.06, 12.04.05, 13.07.01, Upcoming Branch

   Original Estimate: 1h
  Remaining Estimate: 1h

 The method EntitySyncServices.cleanSyncRemoveInfo() takes minutes as seconds 
 when calculate the value of keepSeconds.
 Instead of multiply by 3600, its does by 60



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Closed] (OFBIZ-5514) EntitySyncServices.cleanSyncRemoveInfo() takes minutes as seconds


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert closed OFBIZ-5514.



 EntitySyncServices.cleanSyncRemoveInfo() takes minutes as seconds
 -

 Key: OFBIZ-5514
 URL: https://issues.apache.org/jira/browse/OFBIZ-5514
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 11.04, Release Branch 12.04, Trunk
Reporter: Roberto Benítez Monje
Assignee: Christian Geisert
  Labels: entityext, entitysync, framework
 Fix For: 11.04.06, 12.04.05, 13.07.01, Upcoming Branch

   Original Estimate: 1h
  Remaining Estimate: 1h

 The method EntitySyncServices.cleanSyncRemoveInfo() takes minutes as seconds 
 when calculate the value of keepSeconds.
 Instead of multiply by 3600, its does by 60



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (OFBIZ-4769) Editing of product suppliers is not working for the Germany locale


[ 
https://issues.apache.org/jira/browse/OFBIZ-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14104096#comment-14104096
 ] 

Christian Geisert commented on OFBIZ-4769:
--

First quick test (with german locale): updating works but deleting doesn't.

Clicking on delete throws the following error:
[java] java.lang.Exception: Error in simple-method [Remove a Supplier Product 
record 
[file:/home/chrisg/oss/commit/ofbiz/trunk/applications/product/script/org/ofbiz/product/supplier/SupplierProductServices.xml#removeSupplierProduct]]:
 Fehler beim Ausführen der simple-method: Entity value not found with name: 
sprod Method = removeSupplierProduct, File = 
file:/home/chrisg/oss/commit/ofbiz/trunk/applications/product/script/org/ofbiz/product/supplier/SupplierProductServices.xml,
 Element = remove-value, Line 60null

 Editing of product suppliers is not working for the Germany locale
 --

 Key: OFBIZ-4769
 URL: https://issues.apache.org/jira/browse/OFBIZ-4769
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: Release 10.04, Release Branch 11.04, Trunk
Reporter: Sergei Biletnikov
Assignee: Jacques Le Roux
 Attachments: JIRA-4769-EditProductSuppliers-20121213.diff, 
 JIRA-4769EditProductSuppliers-20121222.patch, 
 JIRA-4769EditProductSuppliers-20121222.patch, 
 JIRA-4769EditProductSuppliers-20121222.patch, OFBIZ-4769-20121227.patch, 
 OFBIZ-4769-Updated.patch, OFBIZ-4769.patch, WidgetWorker.patch


 Please, open any product and add to it a supplier (SupplierProduct), than try 
 to edit it (/catalog/control/EditProductSuppliers?productId=xxx). 
 It works for English locale, but it does not work for German, I have the 
 following error:
 =-=-=-=-=-=-=-=-= Database type warning GenericEntity.set =-=-=-=-=-=-=-=-= 
 In entity field [SupplierProduct.minimumOrderQuantity] set the value passed 
 in [java.lang.String] is not compatible with the Java type of the field 
 [java.math.BigDecimal]
 Exception: java.lang.Exception
 Message: Location of database type warning
  stack trace 
 ---
 java.lang.Exception: Location of database type warning
 org.ofbiz.entity.GenericEntity.set(GenericEntity.java:426)
 org.ofbiz.entity.GenericEntity.set(GenericEntity.java:372)
 org.ofbiz.entity.GenericEntity.setAllFields(GenericEntity.java:887)
 
  exception report 
 --
 =-=-=-=-=-=-=-=-= Database type warning GenericEntity.set =-=-=-=-=-=-=-=-= 
 In entity field [SupplierProduct.availableFromDate] set the value passed in 
 [java.lang.String] is not compatible with the Java type of the field 
 [java.sql.Timestamp]
 Exception: java.lang.Exception
 Message: Location of database type warning
  stack trace 
 ---
 java.lang.Exception: Location of database type warning
 org.ofbiz.entity.GenericEntity.set(GenericEntity.java:426)
 org.ofbiz.entity.GenericEntity.set(GenericEntity.java:372)
 org.ofbiz.entity.GenericEntity.setAllFields(GenericEntity.java:887)
 org.ofbiz.entity.finder.PrimaryKeyFinder.runFind(PrimaryKeyFinder.java:106)
 ..
 the investigation says me the following:
screen name=EditSupplierProduct
 section
 actions
 set field=titleProperty 
 value=PageTitleEditSupplierProduct/
 set field=tabButtonItem value=EditSupplierProduct/
 set field=labelTitleProperty value=ProductSuppliers/
 !-- default currency in 
 framework/common/config/general.properties --
 property-to-field field=defaultCurrencyUomId 
 resource=general property=currency.uom.id.default default=USD/
 set field=productId from-field=parameters.productId/
 set field=orderBy from-field=parameters.orderBy 
 default-value=partyId/
 entity-and entity-name=SupplierProduct 
 list=productSuppliers
 field-map field-name=productId/
 order-by field-name=${orderBy}/
 /entity-and
 entity-one entity-name=SupplierProduct 
 value-field=supplierProduct auto-field-map=true/
 /actions
 ...
 where entity-one entity-name=SupplierProduct value-field=supplierProduct 
 auto-field-map=true/  can not be done.
 I suppose that the problem depends on the German locale, where BigDecimal and 
 Date has another format than we have in the parameters via URL.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Assigned] (OFBIZ-5514) EntitySyncServices.cleanSyncRemoveInfo() takes minutes as seconds

2014-06-30 Thread Christian Geisert (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert reassigned OFBIZ-5514:


Assignee: Christian Geisert

 EntitySyncServices.cleanSyncRemoveInfo() takes minutes as seconds
 -

 Key: OFBIZ-5514
 URL: https://issues.apache.org/jira/browse/OFBIZ-5514
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 11.04, SVN trunk, Release Branch 12.04
Reporter: Roberto Benítez Monje
Assignee: Christian Geisert
  Labels: entityext, entitysync, framework
   Original Estimate: 1h
  Remaining Estimate: 1h

 The method EntitySyncServices.cleanSyncRemoveInfo() takes minutes as seconds 
 when calculate the value of keepSeconds.
 Instead of multiply by 3600, its does by 60



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5396) Add ability to set drop-down, radio, check form widget field key values manually


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5396:
-

Component/s: framework

 Add ability to set drop-down, radio, check form widget field key values 
 manually
 --

 Key: OFBIZ-5396
 URL: https://issues.apache.org/jira/browse/OFBIZ-5396
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: SVN trunk
Reporter: Christian Carlow

 OFBiz should allow for the ability set drop-down, radio, and check form 
 widget fields key values manually for list-options and entity-options.  
 Currently the key-field-name attribute of entity-options and list-options 
 is the only way it can be set and the value must be set to the name of a 
 single entity or list field.  
 I am trying to improve the order entry shipment settings forms and wanted to 
 create a drop-down form widget field to replace the list of radio options 
 with values {code}${shipmentMethodTypeId}@${partyId}{code} on the Ship 
 Options page of Order Entry.  The problem is that the key-field-name 
 attribute mentioned above is insufficient for handling such a multi-key 
 value.
 Adding something such as a key-value attribute could allow for manual 
 assignment of the option value attributes.  
 Lookup fields are also weak when it comes to multi-key entities.  A while 
 back I posted about not being able to create a lookup for order items because 
 of the OrderId, OrderItemSeqId multi-key: OFBIZ-5356
 As work around to this problem I create a view-entity of an entity with the 
 primary key being set to a concatenated string of the primary keys.  For 
 example, to allow for a lookup field that provides a list of OrderItems I 
 would create:
 {code}
 view-entity entity-name=OrderItemOnePrimKey 
 package-name=org.ofbiz.order.order
 member-entity entity-alias=OI entity-name=OrderItem/member-entity
 alias-all entity-alias=OI /
 alias name=orderItemId prim-key=orderItemId
 complex-alias operator=||
complex-alias-field entity-alias=OI field=orderId /
complex-alias-field value='_pk_'/
complex-alias-field entity-alias=OI field=orderItemSeqId/
 /complex-alias
 /alias
 /view-entity 
 {code}
 Having to do this for every entity with more than one key is redundant.  The 
 keys should be able to be set manually if need be.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5387) Improve to allow purchase order ship method options


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5387:
-

Component/s: order

 Improve to allow purchase order ship method options
 ---

 Key: OFBIZ-5387
 URL: https://issues.apache.org/jira/browse/OFBIZ-5387
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Reporter: Christian Carlow
Assignee: Jacques Le Roux
 Fix For: SVN trunk

 Attachments: OFBIZ-5387 -  Improve to allow purchase order ship 
 method options.patch, OFBIZ-5387-0.patch, 
 OFBIZ-5387-SupplierProductServices.patch


 OFBiz should be improved to allow shipment methods to be selected for a 
 purchase order from a supplier.  Currently optionsettings.ftl sets the 
 shipping method as a hidden field with value STANDARD@_NA for purchase 
 orders.  I have the need to keep track of the shipping methods as well as due 
 dates of purchase order items.
 The shipment methods will have to somehow be related back to the supplier.  
 Currently the shipment methods are determined by those related to the store 
 but no store is associated with a cart for purchase orders.  
 Stores could be created for all suppliers specifically for associating 
 carriers and shipment methods and the order creation form could be updated so 
 that the supplier store is selected instead of the supplier party.  The 
 ProductStore payToPartyId field could be used to identify the supplier that 
 is supposed to be associated with the store.
 Anyone else have some ideas?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5377) Add ability to join entitites with parameterized conditions to other entities


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5377:
-

Component/s: framework

 Add ability to join entitites with parameterized conditions to other entities
 -

 Key: OFBIZ-5377
 URL: https://issues.apache.org/jira/browse/OFBIZ-5377
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Christian Carlow

 OFBiz should be improved to allow entities with parameterized conditions to 
 be joined with other entities.
 I need to be able to apply a condition to the OrderShipment entity where 
 OrderShipment.shipmentId = parameters.shipmentId which might produce this 
 query:
 SELECT * ORDER_SHIPMENT WHERE SHIPMENT_ID = '1';
 Then I need to be able to take that query and join it to the 
 OrderItemShipGroupAssoc entity to product a query such as this:
 SELECT * FROM ORDER_ITEM_SHIP_GROUP_ASSOC OISGA LEFT JOIN (SELECT * FROM 
 ORDER_SHIPMENT WHERE SHIPMENT_ID = '1') OS ON OISGA.ORDER_ID = 
 OS.ORDER_ID AND OISGA.ORDER_ITEM_SEQ_ID = OS.ORDER_ITEM_SEQ_ID AND 
 OISGA.SHIP_GROUP_SEQ_ID = OS.SHIP_GROUP_SEQ_ID



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5485) Improve induceFieldType() of ModelUtil.java to handle MSSQL NVARCHAR types


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5485:
-

Component/s: framework

 Improve induceFieldType() of ModelUtil.java to handle MSSQL NVARCHAR types
 --

 Key: OFBIZ-5485
 URL: https://issues.apache.org/jira/browse/OFBIZ-5485
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Christian Carlow
 Attachments: OFBIZ-5485.patch


 When using the ModelInduceFromDb.jsp to import MSSQL data many of the fields 
 were assigned to types like invalid-nvarchar:0:50.  This is because the 
 induceFieldType() of ModelUtil.java does not handle NVARCHAR.  The function 
 should be changed to allow NVARCHAR type.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5487) Improve induceFieldType() of ModelUtil.java to handle MSSQL FLOAT types


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5487:
-

Component/s: framework

 Improve induceFieldType() of ModelUtil.java to handle MSSQL FLOAT types
 ---

 Key: OFBIZ-5487
 URL: https://issues.apache.org/jira/browse/OFBIZ-5487
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Christian Carlow

 When using the ModelInduceFromDb.jsp to import MSSQL data many of the fields 
 were assigned to types like invalid-float:0:50. This is because the 
 induceFieldType() of ModelUtil.java does not handle FLOAT The function 
 should be changed to allow FLOAT type.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5486) ModelInduceFromDb.jsp entitymodel.xml output saved to hot-deploy component causes start to fail


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5486:
-

Component/s: framework

 ModelInduceFromDb.jsp entitymodel.xml output saved to hot-deploy component 
 causes start to fail
 ---

 Key: OFBIZ-5486
 URL: https://issues.apache.org/jira/browse/OFBIZ-5486
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Christian Carlow

 I get this error when I paste the results of ModelInduceFromDb.jsp 
 entitymodel.xml output to the corresponding hot-deploy component:
 code
 2014-01-14 10:58:24,066 (main) [DelegatorFactoryImpl.java:30 :INFO ] Creating 
 new delegator [default] (main)
 2014-01-14 10:58:25,728 (main) [UtilXml.java:1047:WARN ] 
 [UtilXml.LocalResolver.resolveEntity] could not find LOCAL DTD/Schema with 
 publicId [-//OFBiz//DTD Entity Model//EN] and the file/resource is 
 [entitymodel.dtd]
 2014-01-14 10:58:25,934 (main) [DelegatorFactoryImpl.java:35 :ERROR] 
  exception report 
 --
 Error creating delegator
 Exception: org.ofbiz.entity.GenericEntityConfException
 Message: Error getting document from resource handler (Error reading 
 ComponentResourceHandler from XML file [legacydb] with loaderName [main] and 
 location [entitydef/entitymodel.xml] 
 (http://ofbiz.apache.org/dtds/entitymodel.dtd))
  cause 
 -
 Exception: org.ofbiz.base.config.GenericConfigException
 Message: Error reading ComponentResourceHandler from XML file [legacydb] with 
 loaderName [main] and location [entitydef/entitymodel.xml] 
 (http://ofbiz.apache.org/dtds/entitymodel.dtd)
  cause 
 -
 Exception: java.io.FileNotFoundException
 Message: http://ofbiz.apache.org/dtds/entitymodel.dtd
 /code



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: Help required to assign components to Jira tickets

2014-04-23 Thread Christian Geisert

Am 23.04.2014 06:45, schrieb Deepak Dixit:
 Hi Jacopo,
 
 I am also not able to edit the task meta deta. Is this related to jira user 
 group permission?
 
 Thanks  Regards
 

I just tried it. Log in, click on Edit, then select component and click
on Update works for me.

Christian

[jira] [Updated] (OFBIZ-5622) Incorrect creation logic for ShipmentItemBilling records


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5622:
-

Attachment: Invoice-ShipmentItemBilling-trunk.diff

Yes, I think you are reading this correct, i.e. this is a bug.I'll attach a 
patch (is on my todo list for quite some time)

 Incorrect creation logic for ShipmentItemBilling records
 

 Key: OFBIZ-5622
 URL: https://issues.apache.org/jira/browse/OFBIZ-5622
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: SVN trunk
Reporter: Jacopo Cappellato
Priority: Minor
 Attachments: Invoice-ShipmentItemBilling-trunk.diff


 When invoice is created the following code is run for each invoice item:
 {code}
 if (ItemIssuance.equals(currentValue.getEntityName())) {
   ListGenericValue shipmentItemBillings = 
 delegator.findByAnd(ShipmentItemBilling, UtilMisc.toMap(shipmentId, 
 currentValue.get(shipmentId)), null, false);
   if (UtilValidate.isEmpty(shipmentItemBillings)) {
 // create the ShipmentItemBilling record
 GenericValue shipmentItemBilling = 
 delegator.makeValue(ShipmentItemBilling, UtilMisc.toMap(invoiceId, 
 invoiceId, invoiceItemSeqId, invoiceItemSeqId));
 shipmentItemBilling.put(shipmentId, currentValue.get(shipmentId));
 shipmentItemBilling.put(shipmentItemSeqId, 
 currentValue.get(shipmentItemSeqId));
 shipmentItemBilling.create();
   }
 }
 {code}
 If I read it correctly, this will only create one ShipmentItemBilling for the 
 first InvoiceItem only, i.e. 
 one ShipmentItemBilling record for each invoiceId and shipmentId and several 
 invoiceItemSeqId will be missing it
 The good news is that ShipmentItemBilling is not used much currently but 
 until the bug is fixed the ShipmentItemBilling entity will not contain 
 reliable information.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5196) TemporalExpressions$DayOfWeekRange: copy+paste logic errors


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5196:
-

Component/s: framework

 TemporalExpressions$DayOfWeekRange: copy+paste logic errors
 ---

 Key: OFBIZ-5196
 URL: https://issues.apache.org/jira/browse/OFBIZ-5196
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Russell Morrisey

 TemporalExpressions$DayOfWeekRange contains incorrect code which appears to 
 be copied-and-pasted from DayOfMonthRange. It adds months to the calendar 
 object, where weeks or days should be used.
 Example (TemporalExpressions.java, 412-419):
 @Override
 public Calendar first(Calendar cal) {
 Calendar first = (Calendar) cal.clone();
 while (!includesDate(first)) {
 first.add(Calendar.DAY_OF_MONTH, 1); //This is wrong
 }
 return first;
 }
 This problem appears in several places throughout this inner class.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5567) Unit Tests Are Failing Under Java 7


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5567:
-

Component/s: framework

 Unit Tests Are Failing Under Java 7
 ---

 Key: OFBIZ-5567
 URL: https://issues.apache.org/jira/browse/OFBIZ-5567
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 11.04, SVN trunk, Release Branch 12.04, 
 Release Branch 13.07
Reporter: Adrian Crum

 See dev mailing list discussion:
 http://ofbiz.135035.n4.nabble.com/Discussion-Moving-to-Java-7-tt4646117.html#none



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-4082) Adding a Print this form icon to the top frame bar


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-4082:
-

Component/s: framework

 Adding a Print this form icon to the top frame bar
 

 Key: OFBIZ-4082
 URL: https://issues.apache.org/jira/browse/OFBIZ-4082
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Reporter: Bruno Busco

 There should be a new frame tag attribute that would specify that a Print 
 this form icon should be displayed in the top frame bar. This icon should 
 allow the user to print the actual frame in a consistent way (all frame will 
 have the same icon).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-4086) Adding a download CSV file button icon for list forms


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-4086:
-

Component/s: framework

 Adding a download CSV file button icon for list forms
 -

 Key: OFBIZ-4086
 URL: https://issues.apache.org/jira/browse/OFBIZ-4086
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Reporter: Bruno Busco





--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-4870) Multithreading in GenericDAO / Delegator


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-4870:
-

Component/s: framework

 Multithreading in GenericDAO / Delegator
 

 Key: OFBIZ-4870
 URL: https://issues.apache.org/jira/browse/OFBIZ-4870
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Mirko Vogelsmeier

 Hey there,
 some time ago there were some commits of Adam that brought in first ideas of 
 multi threaded delegator useage (r1139700).
 Depending on how intense the data useage or data size is, there are 
 performance issues we cannot scale by pure hardware and/or configuration as 
 there is just one Delegator object per datasource.
 I wanted to check on the progress of this very helpfull feature. Are there 
 any further thoughts to work on this?
 Greetings,
 Mirko



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-4773) Migrate to JACOCO for code coverage analysis


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-4773:
-

Component/s: framework

 Migrate to JACOCO for code coverage analysis
 

 Key: OFBIZ-4773
 URL: https://issues.apache.org/jira/browse/OFBIZ-4773
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Pierre Smits

 It appears that development of cobertura has stopped since 2010-03-03. And 
 Jacoco (the other open source code coverage analysis tool) seem to be well 
 received by development communities and can also be integrated with jenkins 
 for automated builds and sonar for managing code quality.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-4763) create and use startup profiles


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-4763:
-

Component/s: framework

 create and use startup profiles
 ---

 Key: OFBIZ-4763
 URL: https://issues.apache.org/jira/browse/OFBIZ-4763
 Project: OFBiz
  Issue Type: New Feature
  Components: framework
Affects Versions: SVN trunk
Reporter: Erwan de FERRIERES
 Fix For: SVN trunk


 from this thread 
 http://ofbiz.135035.n4.nabble.com/OFBiz-integration-in-Apache-sonar-instance-td4484597.html
 we should be able to choose a profile when starting OFBiz, which will 
 configure at least the ports used.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-3867) JobManager.poll() enters an endless loop when it can't get a connection


 [ 
https://issues.apache.org/jira/browse/OFBIZ-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-3867:
-

Component/s: framework

 JobManager.poll() enters an endless loop when it can't get a connection
 ---

 Key: OFBIZ-3867
 URL: https://issues.apache.org/jira/browse/OFBIZ-3867
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Reporter: Adam Heath
Assignee: Adam Heath

 JobManager.poll(), line 157, where it calls storeByCondition, can fail when 
 there is no connection available from the database(due to a connection leak, 
 or just load, or whatever).  An exception then gets thrown by 
 storeByCondition(deep inside ofbiz/commons-dbcp/postgres).  The 
 catch(Throwable) then logs the error, and the loop tries again.  Since 
 pollDone never gets set to true, this loop is *very* tight, and the log file 
 starts to fill up *very* fast, each each thread of JobPoller tries the same 
 thing over and over.
 I'm filing this bug mainly to see if anyone else works on it, but if not, 
 it's a reminder for me.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-1621) Demo data for travel entities(related to OFBiz-1590)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-1621:
-

Component/s: product
 order
 accounting

 Demo data for travel entities(related to OFBiz-1590)
 

 Key: OFBIZ-1621
 URL: https://issues.apache.org/jira/browse/OFBIZ-1621
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting, order, product
Affects Versions: SVN trunk
Reporter: Valentina Sirkova
 Fix For: SVN trunk


 Prepare demo data for reservation entities in OFBiz-1590. The following 
 recommendations(point 4) should be considered:
 http://www.nabble.com/Re%3A-new-accomodation-map-entities-Jira-OFBIZ-1590-%28was-on-the-user-mailing-list%29-to15128518.html



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-3485) Error in updating party postal address if party has an EftAccount


 [ 
https://issues.apache.org/jira/browse/OFBIZ-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-3485:
-

Component/s: party

 Error in updating party postal address  if party has an EftAccount
 --

 Key: OFBIZ-3485
 URL: https://issues.apache.org/jira/browse/OFBIZ-3485
 Project: OFBiz
  Issue Type: Bug
  Components: party
Reporter: Abdullah Shaikh

 Try to update the party Postal Address, which have an EftAccount, using the 
 Update button in Profile's Contact Information section, you get the below 
 error,
 The Following Errors Occurred:
 Error trying to begin transaction, could not process method: The current 
 transaction is marked for rollback, not beginning a new transaction and 
 aborting current operation; the rollbackOnly was caused by: Service 
 [updateEftAccount] threw an unexpected 
 exception/errororg.ofbiz.service.ServiceValidationException: The following 
 required parameter is missing: [updateEftAccount.nameOnAccount] (The 
 following required parameter is missing: [updateEftAccount.nameOnAccount])



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-3479) create category through Ofbiz setup throws truncation error

[
https://issues.apache.org/jira/browse/OFBIZ-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Christian Geisert updated OFBIZ-3479:
-

Component/s: commonext/setup

create category through Ofbiz setup throws truncation error
---

Key: OFBIZ-3479
URL: https://issues.apache.org/jira/browse/OFBIZ-3479
Project: OFBiz
Issue Type: Bug
Components: commonext/setup
Affects Versions: SVN trunk
Reporter: Babu Sreekanth
Attachments: screenshot.1.png

Please find the description from the maiing list message:
I found an issue with create category. The screen shot is attached. The
scenario is.
1. Through the setup application (ofbiz setup), created an organization
2. Added Facility, Product store etc. and came to the last section 'First
product
3. Created a product catalog , then tried to create a category. It throws the
below exception.
A TRUNCATION ERROR WAS ENCOUNTERED TRYING TO SHRINK VARCHAR
'ABJ_CATALOG_PROMOTIONS' TO LENGTH 20.
CALLING SERVICE CREATEPRODUCTCATEGORY IN
CREATEPRODUCTCATEGORYANDADDTOPRODCATALOG
The issue was on SVN trun, retrieved on 02/12/2010 (Yesterday).
Well the error seems to occur when it try to shrink to fit into the 20 char
table name. In the setup UI, there is no place to give the name for catalog
promotion table.
Also, it is possible to create the same category through catalog manager. I
assume it may not create promotion category like it does with ofbizsetup.
According to Bilgin Ibryam, this should be fixed by suffixing a shorted text
while creating a promotion category. See
http://n4.nabble.com/Issue-with-create-category-Raising-Jira-issue-tt1554760.html#a1554760

--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-2143) payrol entities and payrolinvoiceItemtype


 [ 
https://issues.apache.org/jira/browse/OFBIZ-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-2143:
-

Component/s: humanres

 payrol entities and payrolinvoiceItemtype
 -

 Key: OFBIZ-2143
 URL: https://issues.apache.org/jira/browse/OFBIZ-2143
 Project: OFBiz
  Issue Type: Improvement
  Components: humanres
Reporter: Hans Bakker

 Just a reminder to not forget.
 Currently it is possible to create apayrolslip inludinbg check. The maojor 
 items on a payslip are:
 1.salary/hourly wages
 2.Deductions
 3. Tax
 now it appears there are other tables in the system which are very similar or 
 even duplicate information:
 1. BenefitType
 2. DeductionType
 3. TaxAuthorityRateType
 we could consider using the field hasTable=y for these payrol invoice item 
 types



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-2534) Datafile converts string decimal input to another number.in xml output


 [ 
https://issues.apache.org/jira/browse/OFBIZ-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-2534:
-

Component/s: framework
Description: 
datafile conversion to entity file take a string with a decimal and added a lot 
of numbers to it
this is the Product entity and the field is weight.
the orginal string was 9.15
the output was 9.146185

there were no errors in any of the logs.

  was:

datafile conversion to entity file take a string with a decimal and added a lot 
of numbers to it
this is the Product entity and the field is weight.
the orginal string was 9.15
the output was 9.146185

there were no errors in any of the logs.


 Datafile  converts string decimal input to another number.in xml output
 ---

 Key: OFBIZ-2534
 URL: https://issues.apache.org/jira/browse/OFBIZ-2534
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 09.04
 Environment: 9.04  framework/datafile
Reporter: BJ Freeman
 Fix For: Release Branch 09.04

 Attachments: Product_Data_327496_1.tab, importTablesexample.xml


 datafile conversion to entity file take a string with a decimal and added a 
 lot of numbers to it
 this is the Product entity and the field is weight.
 the orginal string was 9.15
 the output was 9.146185
 there were no errors in any of the logs.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-2602) Main storefront page, Featured Products (middle column) overwrites right column. Should just crop column, but not overwrite right column.


 [ 
https://issues.apache.org/jira/browse/OFBIZ-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-2602:
-

Component/s: specialpurpose/ecommerce

 Main storefront page, Featured Products (middle column) overwrites right 
 column. Should just crop column, but not overwrite right column.
 -

 Key: OFBIZ-2602
 URL: https://issues.apache.org/jira/browse/OFBIZ-2602
 Project: OFBiz
  Issue Type: Sub-task
  Components: specialpurpose/ecommerce
Affects Versions: Release Branch 09.04, SVN trunk
 Environment: Note: when using a table inside a div as is done 
 w/matrix category layout, the table expands past the div in all but the 
 largest browser windows (with the smallest font settings) and overwrites the 
 right column. Very messy.  At a minimum, the middle column should just be 
 cropped - this will force the user to expand the browser if they want to see 
 all that is in the middle column. [Better fix is to make the whole thing 
 fluid - but that would require a major CSS  possibly widget redo.]
Reporter: Ruth Hoffman
Assignee: Scott Gray
 Fix For: Release Branch 09.04, SVN trunk

 Attachments: ProductGrid.patch, ecommain.css.patch


 To fix this, add the following line to the ecommain.css:
 OLD version:
 #ecom-mainarea .center {
 margin-left:201px;
 margin-right:261px;   
 voice-family:inherit;
 }
 NEW version
 #ecom-mainarea .center {
 margin-left:201px;
 margin-right:261px; 
 overflow:hidden;  
 voice-family:inherit;
 }
 This will force any overflow to be cropped.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-4761) Adding some translations for French


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-4761:
-

Component/s: ALL APPLICATIONS

 Adding some translations for French
 ---

 Key: OFBIZ-4761
 URL: https://issues.apache.org/jira/browse/OFBIZ-4761
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS
Affects Versions: SVN trunk
Reporter: Francis ANDRE
 Attachments: ofbiz.patch


 Hi
 Here a pacth for adding some translations for French. The patch is in U8-DOS 
 encoding.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-2976) view-entity with condition-expr joined with another view-entity as rel-optional=true is treated as rel-optional=false


 [ 
https://issues.apache.org/jira/browse/OFBIZ-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-2976:
-

Component/s: framework

 view-entity with condition-expr joined with another view-entity as 
 rel-optional=true is treated as rel-optional=false
 -

 Key: OFBIZ-2976
 URL: https://issues.apache.org/jira/browse/OFBIZ-2976
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
 Environment: Java v1.5.0_19-b02-298 MacOS X 10.5.8
Reporter: Jennifer Weston
Priority: Minor
 Fix For: SVN trunk

 Attachments: JIRA-Issue2976.patch


 If a view-entity is defined with condition-exprs and used as a member-entity 
 in a second view-entity and the view-link is rel-optional=true, the link is 
 treated as rel-optional=false.
 In the following example, the view-entity PPRMinQty is a list of all 
 PriceBreakRules that have a minimum quantity defined. The view-entity 
 ProductPriceBreakMinQty uses PPRMinQty with ProductCategoryMember and 
 ProductPriceCond (this time used for product categories) to create a list of 
 productIds with their productPriceRuleIds and their minimum quantities (if 
 any). The rel-optional=true should mean that even productPriceRuleids that 
 don't have a minimum quantity defined should be included in the result set.
 view-entity entity-name=PPRMinQty
 package-name=com.mavericklabel
 title=Minimum qty for a product price rule
 member-entity entity-alias=PPC entity-name=ProductPriceCond/
 alias name=productPriceRuleId entity-alias=PPC 
 field=productPriceRuleId/
 alias name=minQty entity-alias=PPC field=condValue/
 alias name=inputParamEnumId entity-alias=PPC 
 field=inputParamEnumId/
 alias name=operatorEnumId entity-alias=PPC field=operatorEnumId/
 entity-condition
 condition-list
 condition-expr entity-alias=PPC field-name=inputParamEnumId 
 operator=equals value=PRIP_QUANTITY/
 condition-expr entity-alias=PPC field-name=operatorEnumId 
 operator=equals value=PRC_GTE/
 /condition-list
 /entity-condition
 /view-entity
 view-entity entity-name=ProductPriceBreakMinQty
 package-name=com.mavericklabel
 title=Price breaks for each product with their minimum quantity (min 
 qty is optional)
 member-entity entity-alias=PPRCAT entity-name=ProductPriceCond/
 member-entity entity-alias=PCM entity-name=ProductCategoryMember/
 member-entity entity-alias=MINQTY entity-name=PPRMinQty/
 alias name=productId entity-alias=PCM field=productId/
 alias name=productPriceRuleId entity-alias=PPRCAT 
 field=productPriceRuleId/
 alias name=minQty entity-alias=MINQTY field=minQty/
 alias name=inputParamEnumId entity-alias=PPRCAT 
 field=inputParamEnumId/
 alias name=operatorEnumId entity-alias=PPRCAT 
 field=operatorEnumId/
 view-link entity-alias=PPRCAT rel-entity-alias=PCM
 key-map field-name=condValue rel-field-name=productCategoryId/
 /view-link
 view-link entity-alias=PPRCAT rel-entity-alias=MINQTY 
 rel-optional=true
 key-map field-name=productPriceRuleId/
 /view-link
 entity-condition
 condition-list
 condition-expr entity-alias=PPRCAT 
 field-name=inputParamEnumId operator=equals value=PRIP_PROD_CAT_ID/
 condition-expr entity-alias=PPRCAT field-name=operatorEnumId 
 operator=equals value=PRC_EQ/
 /condition-list
 /entity-condition
 /view-entity
 The resulting SQL looks like this:
 SELECT PCM.PRODUCT_ID, PPRCAT.PRODUCT_PRICE_RULE_ID, MINQTY.PPC_COND_VALUE, 
 PPRCAT.INPUT_PARAM_ENUM_ID, PPRCAT.OPERATOR_ENUM_ID FROM 
 (OFBIZ.PRODUCT_PRICE_COND PPRCAT INNER JOIN OFBIZ.PRODUCT_CATEGORY_MEMBER PCM 
 ON PPRCAT.COND_VALUE = PCM.PRODUCT_CATEGORY_ID) LEFT OUTER JOIN (SELECT 
 PPC.PRODUCT_PRICE_RULE_ID AS PPC_PRODUCT_PRICE_RULE_ID, PPC.COND_VALUE AS 
 PPC_COND_VALUE, PPC.INPUT_PARAM_ENUM_ID AS PPC_INPUT_PARAM_ENUM_ID, 
 PPC.OPERATOR_ENUM_ID AS PPC_OPERATOR_ENUM_ID FROM OFBIZ.PRODUCT_PRICE_COND 
 PPC) MINQTY ON PPRCAT.PRODUCT_PRICE_RULE_ID = 
 MINQTY.PPC_PRODUCT_PRICE_RULE_ID WHERE ((PPRCAT.INPUT_PARAM_ENUM_ID = 
 'PRIP_PROD_CAT_ID' AND PPRCAT.OPERATOR_ENUM_ID = 'PRC_EQ') AND 
 (PPC.INPUT_PARAM_ENUM_ID = 'PRIP_QUANTITY' AND PPC.OPERATOR_ENUM_ID = 
 'PRC_GTE'))
 instead of 
 SELECT PCM.PRODUCT_ID, PPRCAT.PRODUCT_PRICE_RULE_ID, MINQTY.PPC_COND_VALUE, 
 PPRCAT.INPUT_PARAM_ENUM_ID, PPRCAT.OPERATOR_ENUM_ID FROM 
 (OFBIZ.PRODUCT_PRICE_COND PPRCAT INNER JOIN OFBIZ.PRODUCT_CATEGORY_MEMBER PCM 
 ON PPRCAT.COND_VALUE = PCM.PRODUCT_CATEGORY_ID) LEFT OUTER JOIN (SELECT 
 PPC.PRODUCT_PRICE_RULE_ID AS PPC_PRODUCT_PRICE_RULE_ID, PPC.COND_VALUE AS 
 PPC_COND_VALUE

[jira] [Updated] (OFBIZ-1867) Tasks To Be Completed for Framework-only Release


 [ 
https://issues.apache.org/jira/browse/OFBIZ-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-1867:
-

Component/s: framework

 Tasks To Be Completed for Framework-only Release
 

 Key: OFBIZ-1867
 URL: https://issues.apache.org/jira/browse/OFBIZ-1867
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Adrian Crum
Priority: Minor

 This is an umbrella issue intended for discussion on work that needs to be 
 completed on the framework before its release. Individual efforts can be made 
 sub tasks of this issue.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5410) External File Import/Export: A New Design


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5410:
-

Component/s: framework

 External File Import/Export: A New Design
 -

 Key: OFBIZ-5410
 URL: https://issues.apache.org/jira/browse/OFBIZ-5410
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Adrian Crum
Priority: Minor
 Attachments: OFBIZ-5410-schema.patch, OFBIZ-5410.patch


 Redesign the datafile component to make external file import/export easier 
 and more reliable. Details are in the comments.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5470) List Price gets reset to zero after updating default/base price of existing order items


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5470:
-

Component/s: order

 List Price gets reset to zero after updating default/base price of existing 
 order items
 ---

 Key: OFBIZ-5470
 URL: https://issues.apache.org/jira/browse/OFBIZ-5470
 Project: OFBiz
  Issue Type: Bug
  Components: order
Reporter: Christian Carlow
Priority: Minor

 To reproduce:
 1.  Click Edit Items for orderId DEMO10090
 2.  Change the price of GZ-2644 from 38.40 to 30.41 and click Update 
 Selected Items
 3.  Click Edit Items again and then click Update Selected Items again
 After step 3 the list price gets set to 0.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5424) OrderStatus with status ITEM_CREATED not created for auto-added promo items and items appended after order creation


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5424:
-

Component/s: order

 OrderStatus with status ITEM_CREATED not created for auto-added promo items 
 and items appended after order creation
 ---

 Key: OFBIZ-5424
 URL: https://issues.apache.org/jira/browse/OFBIZ-5424
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: Christian Carlow
Priority: Minor

 To reproduce promo items issue:
 1.  Create an order for DemoCustCompany
 2.  Add 1 GZ-BASKET
 3.  Finalize and Complete the order
 4.  Notice that promo items do not have a status creation time on the order 
 view page
 To reproduce order item append issue:
 1.  Click Edit Items button on order view page of order created above
 2.  Add GZ-1000 to the order
 3.  Notice that the appended item does not have a status creation time on the 
 order view page



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5086) Wrong order confirmation email template


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5086:
-

Component/s: order

 Wrong order confirmation email template
 ---

 Key: OFBIZ-5086
 URL: https://issues.apache.org/jira/browse/OFBIZ-5086
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 10.04
Reporter: Sergei Biletnikov
Priority: Minor

 Install release 10.04 from the branch with demo data,
 open any order and click Send a confirmation email (button).
 for example:
 https://localhost:8443/ordermgr/control/confirmationmailedit?orderId=DEMO_B2B_IT02partyId=DemoCustomersendTo=ofbizt...@yahoo.com
 Look at the generated html template, you will see the following :
 Method public java.lang.String 
 org.ofbiz.widget.screen.ScreenRenderer.render(java.lang.String) throws 
 org.ofbiz.base.util.GeneralException,java.io.IOException,org.xml.sax.SAXException,javax.xml.parsers.ParserConfigurationException
  threw an exception when invoked on 
 org.ofbiz.widget.screen.ScreenRenderer@1d829e59 with arguments of types 
 [java.lang.String,]
 The problematic instruction:
 --
 == 
 ${screens.render(productStoreEmailSetting.bodyScreenLocation?default())} 
 [on line 82, column 63 in 
 component://order/webapp/ordermgr/order/sendconfirmationemail.ftl]
 --
 Java backtrace for programmers:
 --
 freemarker.template.TemplateModelException: Method public java.lang.String 
 org.ofbiz.widget.screen.ScreenRenderer.render(java.lang.String) throws 
 org.ofbiz.base.util.GeneralException,java.io.IOException,org.xml.sax.SAXException,javax.xml.parsers.ParserConfigurationException
  threw an exception when invoked on 
 org.ofbiz.widget.screen.ScreenRenderer@1d829e59 with arguments of types 
 [java.lang.String,]
   at 
 freemarker.ext.beans.OverloadedMethodModel.exec(OverloadedMethodModel.java:134)
   at freemarker.core.MethodCall._getAsTemplateModel(MethodCall.java:93)
   at freemarker.core.Expression.getAsTemplateModel(Expression.java:89)
 ..



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-3920) HtmlFormRenderer : with attribute skip-start, lookup fields are broken


 [ 
https://issues.apache.org/jira/browse/OFBIZ-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-3920:
-

Component/s: framework

 HtmlFormRenderer : with attribute skip-start, lookup fields are broken
 --

 Key: OFBIZ-3920
 URL: https://issues.apache.org/jira/browse/OFBIZ-3920
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Nicolas Malin
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: skipStartWithLookup.patch


 When you want to merge to form and use skip-start=true on the second form, 
 all contained lookup are broken. In this case, the javascript used to call 
 Lookup screen are using the form name eg : 'a 
 href=javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', 
 ...)', but with skip-start, the form name isn't present.
 A possible solution is to force lookup field id, but it's not managed on 
 htmlFormMacroLibrary.ftl. I will submit a patch to make this possible. 
 I don't manage problem on descriptionField, this would need to change 
 ModelFormRender and it's a little bit more complicated ;)
 Nicolas



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5436) ShoppingCart does not show survey page after invalid information is entered


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5436:
-

Component/s: order

 ShoppingCart does not show survey page after invalid information is entered
 -

 Key: OFBIZ-5436
 URL: https://issues.apache.org/jira/browse/OFBIZ-5436
 Project: OFBiz
  Issue Type: Bug
  Components: order
Reporter: Christian Carlow
Priority: Minor

 To reproduce this error:
 1.  Create a new order for DemoCustCompany
 2.  Add GC-001 to the Cart
 3.  Select a style and amount and click Add to Cart
 4.  Click the Submit button without entering any information in the survey 
 fields.
 After step 4 is completed the showcart page appears with errors.  It seems 
 like the survey page should appear with the errors until valid information 
 has been submitted.  The same problem occurs when an invalid email is entered 
 also.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5363) Add Support For Tomcat JDBC Connection Pool


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5363:
-

Component/s: framework

 Add Support For Tomcat JDBC Connection Pool
 ---

 Key: OFBIZ-5363
 URL: https://issues.apache.org/jira/browse/OFBIZ-5363
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Priority: Minor
 Attachments: OFBIZ-5363.patch, tomcat-7.0.42-tomcat-jdbc.jar


 According to Tomcat, their JDBC connection pool is a better implementation 
 than DBCP (http://tomcat.apache.org/tomcat-7.0-doc/jdbc-pool.html). This 
 issue adds the Tomcat JDBC Connection Pool as an option.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-2583) datafile Import support for mapping categories


 [ 
https://issues.apache.org/jira/browse/OFBIZ-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-2583:
-

Component/s: product

 datafile Import support for mapping categories
 --

 Key: OFBIZ-2583
 URL: https://issues.apache.org/jira/browse/OFBIZ-2583
 Project: OFBiz
  Issue Type: New Feature
  Components: product
Affects Versions: SVN trunk
Reporter: BJ Freeman
Priority: Minor
 Attachments: OFBIZ-2583ProdImportCategoryMatchEntity.patch


 when  importing data using the datafile code, the data may have different 
 categories or a hierachy of categories that need to be translated to ofbiz 
 categories.
 this will augment the datafile code to match data catagories to the ofbiz 
 categories.
 first one will use a datafile record to create the ProdImportCategoryMatch 
 entity from the datafile with a default auto for the prodCategory field.
 when the data record is read, the service will see the auto and parse the 
 category string and create categories, not already created with the rollup. 
 as the last operation it will add the string with the last category as in the 
 string as the prodCategory field in the entity.
 next when the data is read in, it will look for the category string in the 
 ProdImportCategoryMatch entity and replace the ImportCategoryString with the 
 prodCategory  field 
 if there is more than one entry in the ProdImportCategoryMatch  it will walk 
 down the sequence and add the product to each category.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (OFBIZ-5177) Cleanup UI Labels for languages which aren't well supported

2014-03-26 Thread Christian Geisert (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947694#comment-13947694
 ] 

Christian Geisert commented on OFBIZ-5177:
--

No, it isn't that simple ;-)
The first two changes of the have been handled.
The question if we should remove Frisian language is still open.
And the change from hyphen to underscore (see Adrian's comment) is wrong, it 
should be the other way round (but would cause a huge diff).
So let's decide if we should keep or remove Frisian language and then we can 
close this issue.

 Cleanup UI Labels for languages which aren't well supported
 ---

 Key: OFBIZ-5177
 URL: https://issues.apache.org/jira/browse/OFBIZ-5177
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS
Reporter: Atul Vani
Assignee: Christian Geisert
Priority: Minor
 Attachments: OFBIZ-5177.patch


 This issue is derived from the email thread with subject Cosmetic patch for 
 specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl on user 
 mailing list.
 Below are the stats of UI Labels present in OFBiz:
  index lang count
  0 en 12132
  1 it 10893
  2 zh 10245
  3 fr 9821
  4 zh_TW 8804
  5 th 8063
  6 de 7916
  7 es 6655
  8 ro 6075
  9 ru 5283
  10 nl 4553
  11 pt_BR 4226
  12 hi_IN 3275
  13 pt 3014
  14 vi 1674
  15 ar 1243
  16 da 803
  17 zh_CN 795
  18 pt_PT 623
  19 ja 596
  20 cs 441
  21 de_CH 71
  22 en_GB 62
  23 fy 3
  24 hi-IN 2
  26 FR 1
  27 in 1
  28 pt-PT 1
  29 zh-CN 1
  30 zh-TW 1
 The stats are gathered with the help of Google Refine.
 I suggest we remove support for some of the languages which have failed to 
 gain enough contribution over these many years.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Comment Edited] (OFBIZ-5177) Cleanup UI Labels for languages which aren't well supported

2014-03-26 Thread Christian Geisert (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947694#comment-13947694
 ] 

Christian Geisert edited comment on OFBIZ-5177 at 3/26/14 9:19 AM:
---

No, it isn't that simple ;-)
The first two changes of the patch have been handled.
The question if we should remove Frisian language is still open.
And the change from hyphen to underscore (see Adrian's comment) is wrong, it 
should be the other way round (but would cause a huge diff).
So let's decide if we should keep or remove Frisian language and then we can 
close this issue.


was (Author: chrisg):
No, it isn't that simple ;-)
The first two changes of the have been handled.
The question if we should remove Frisian language is still open.
And the change from hyphen to underscore (see Adrian's comment) is wrong, it 
should be the other way round (but would cause a huge diff).
So let's decide if we should keep or remove Frisian language and then we can 
close this issue.

 Cleanup UI Labels for languages which aren't well supported
 ---

 Key: OFBIZ-5177
 URL: https://issues.apache.org/jira/browse/OFBIZ-5177
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS
Reporter: Atul Vani
Assignee: Christian Geisert
Priority: Minor
 Attachments: OFBIZ-5177.patch


 This issue is derived from the email thread with subject Cosmetic patch for 
 specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl on user 
 mailing list.
 Below are the stats of UI Labels present in OFBiz:
  index lang count
  0 en 12132
  1 it 10893
  2 zh 10245
  3 fr 9821
  4 zh_TW 8804
  5 th 8063
  6 de 7916
  7 es 6655
  8 ro 6075
  9 ru 5283
  10 nl 4553
  11 pt_BR 4226
  12 hi_IN 3275
  13 pt 3014
  14 vi 1674
  15 ar 1243
  16 da 803
  17 zh_CN 795
  18 pt_PT 623
  19 ja 596
  20 cs 441
  21 de_CH 71
  22 en_GB 62
  23 fy 3
  24 hi-IN 2
  26 FR 1
  27 in 1
  28 pt-PT 1
  29 zh-CN 1
  30 zh-TW 1
 The stats are gathered with the help of Google Refine.
 I suggest we remove support for some of the languages which have failed to 
 gain enough contribution over these many years.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (OFBIZ-5177) Cleanup UI Labels for languages which aren't well supported

2014-03-26 Thread Christian Geisert (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947852#comment-13947852
 ] 

Christian Geisert commented on OFBIZ-5177:
--

Ok, I'll remove Frysian labels.

In the current state (only three labels) it doesn't make sense and if there 
will be a contribution in the future we can bring it back.


 Cleanup UI Labels for languages which aren't well supported
 ---

 Key: OFBIZ-5177
 URL: https://issues.apache.org/jira/browse/OFBIZ-5177
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS
Reporter: Atul Vani
Assignee: Christian Geisert
Priority: Minor
 Attachments: OFBIZ-5177.patch


 This issue is derived from the email thread with subject Cosmetic patch for 
 specialpurpose/ecommerce/webapp/ecommerce/cart/minipromotext.ftl on user 
 mailing list.
 Below are the stats of UI Labels present in OFBiz:
  index lang count
  0 en 12132
  1 it 10893
  2 zh 10245
  3 fr 9821
  4 zh_TW 8804
  5 th 8063
  6 de 7916
  7 es 6655
  8 ro 6075
  9 ru 5283
  10 nl 4553
  11 pt_BR 4226
  12 hi_IN 3275
  13 pt 3014
  14 vi 1674
  15 ar 1243
  16 da 803
  17 zh_CN 795
  18 pt_PT 623
  19 ja 596
  20 cs 441
  21 de_CH 71
  22 en_GB 62
  23 fy 3
  24 hi-IN 2
  26 FR 1
  27 in 1
  28 pt-PT 1
  29 zh-CN 1
  30 zh-TW 1
 The stats are gathered with the help of Google Refine.
 I suggest we remove support for some of the languages which have failed to 
 gain enough contribution over these many years.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (OFBIZ-5591) ofbizCurrency transform does not honor the rounding passed in ofbizCurrency macro.

2014-03-24 Thread Christian Geisert (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944842#comment-13944842
 ] 

Christian Geisert commented on OFBIZ-5591:
--

Hi Deepak,

I didn't mean to imply that you should use the patch from me. I can't remember 
the details and won't have time at the moment to have a closer look. So just go 
on with your patch ;-)

 ofbizCurrency transform does not honor the rounding passed in ofbizCurrency 
 macro.
 --

 Key: OFBIZ-5591
 URL: https://issues.apache.org/jira/browse/OFBIZ-5591
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk, Release Branch 12.04, Release Branch 13.07
Reporter: Deepak Dixit
Assignee: Ashish Vijaywargiya
Priority: Minor
 Fix For: SVN trunk, Release Branch 12.04, Release Branch 13.07

 Attachments: OFBIZ-5591-alternative-rounding-fix-svn.diff, 
 OFBIZ-5591.patch


 ofbizCurrency transform does not honor the rounding passed in ofbizCurrency 
 macro. OfbizCurrency transform always used the default rounding set in 
 general.properties file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (OFBIZ-5591) ofbizCurrency transform does not honor the rounding passed in ofbizCurrency macro.

2014-03-23 Thread Christian Geisert (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944593#comment-13944593
 ] 

Christian Geisert commented on OFBIZ-5591:
--

I can confirm that there's an issue. I'll attach an alternative patch which is 
working for us.

 ofbizCurrency transform does not honor the rounding passed in ofbizCurrency 
 macro.
 --

 Key: OFBIZ-5591
 URL: https://issues.apache.org/jira/browse/OFBIZ-5591
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk, Release Branch 12.04, Release Branch 13.07
Reporter: Deepak Dixit
Assignee: Ashish Vijaywargiya
Priority: Minor
 Fix For: SVN trunk, Release Branch 12.04, Release Branch 13.07

 Attachments: OFBIZ-5591.patch


 ofbizCurrency transform does not honor the rounding passed in ofbizCurrency 
 macro. OfbizCurrency transform always used the default rounding set in 
 general.properties file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (OFBIZ-5591) ofbizCurrency transform does not honor the rounding passed in ofbizCurrency macro.

2014-03-23 Thread Christian Geisert (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5591:
-

Attachment: OFBIZ-5591-alternative-rounding-fix-svn.diff

 ofbizCurrency transform does not honor the rounding passed in ofbizCurrency 
 macro.
 --

 Key: OFBIZ-5591
 URL: https://issues.apache.org/jira/browse/OFBIZ-5591
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk, Release Branch 12.04, Release Branch 13.07
Reporter: Deepak Dixit
Assignee: Ashish Vijaywargiya
Priority: Minor
 Fix For: SVN trunk, Release Branch 12.04, Release Branch 13.07

 Attachments: OFBIZ-5591-alternative-rounding-fix-svn.diff, 
 OFBIZ-5591.patch


 ofbizCurrency transform does not honor the rounding passed in ofbizCurrency 
 macro. OfbizCurrency transform always used the default rounding set in 
 general.properties file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: [VOTE] [RELEASE] Apache OFBiz 13.07.01

2014-03-22 Thread Christian Geisert

Am 22.03.2014 20:48, schrieb Jacques Le Roux:
 +0 (miss below ;)
 
 MD5 OK
 
 Failure in run tests in Windows 7
 
 production-run-tests.testProductionRunDateChangeFailure Assertion
 failed: ([taskTimeDifference=-360.0] equals 0.0 as Double OR
 [taskTimeDifference=-360.0] equals 1.0 as Double OR
 [taskTimeDifference=-360.0] equals -1.0 as Double OR )
 
 junit.framework.AssertionFailedError: Assertion failed:
 ([taskTimeDifference=-360.0] equals 0.0 as Double OR
 [taskTimeDifference=-360.0] equals 1.0 as Double OR
 [taskTimeDifference=-360.0] equals -1.0 as Double OR )
 at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
 at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:147)
 at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:238)
 at org.ofbiz.base.start.Start.startStartLoaders(Start.java:340)
 at org.ofbiz.base.start.Start.start(Start.java:382)
 at org.ofbiz.base.start.Start.main(Start.java:122)
 
 Same failure in Ubuntu 13.10 running in virtualbox on Windows7

I can confirm this failure (Java 1.6.0_38 under Ubuntu) - changing
Locale to en doesn't help. Same problem with trunk.

I'll try to have a closer look later (insert $RANT about Minilang)

Apart from that I didn't notice any issues (signature/md5 ok, creating
orders from backend and shop etc.)

Christian

Re: [VOTE] [RELEASE] Apache OFBiz 13.07.01

2014-03-22 Thread Christian Geisert

Am 23.03.2014 00:09, schrieb Christian Geisert:
 Am 22.03.2014 20:48, schrieb Jacques Le Roux:
 +0 (miss below ;)

 MD5 OK

 Failure in run tests in Windows 7

 production-run-tests.testProductionRunDateChangeFailure Assertion
 failed: ([taskTimeDifference=-360.0] equals 0.0 as Double OR
 [taskTimeDifference=-360.0] equals 1.0 as Double OR
 [taskTimeDifference=-360.0] equals -1.0 as Double OR )

 junit.framework.AssertionFailedError: Assertion failed:
 ([taskTimeDifference=-360.0] equals 0.0 as Double OR
 [taskTimeDifference=-360.0] equals 1.0 as Double OR
 [taskTimeDifference=-360.0] equals -1.0 as Double OR )
 at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
 at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:147)
 at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:238)
 at org.ofbiz.base.start.Start.startStartLoaders(Start.java:340)
 at org.ofbiz.base.start.Start.start(Start.java:382)
 at org.ofbiz.base.start.Start.main(Start.java:122)

 Same failure in Ubuntu 13.10 running in virtualbox on Windows7
 
 I can confirm this failure (Java 1.6.0_38 under Ubuntu) - changing
 Locale to en doesn't help. Same problem with trunk.
 
 I'll try to have a closer look later (insert $RANT about Minilang)

Wow, that was fun ;-)

There's actually a hint inside the code:
!-- a difference of +1 or -1 is accepted because it could be caused by
DST change happening in one of the two time periods --

And there is a DST next week here in Germany...

But the difference is calculated in millisecs and not in hours so the
allowed difference should be +/- 60 * 60 * 1000 ms

I don't think this is a showstopper for the release (the actual
calculating is right, just a bug in the test - and it will last for just
one week...)

So +1 for the release

Christian

Re: Discussion: Moving to Java 7

2013-12-16 Thread Christian Geisert

With Java 1.6.0_38-b05 the tests are running successful on my Ubuntu 12.10.

Under OpenJDK 1.7.0_25 I get 5 Failures and 2 error (errors are
testRemoveValue and testEntityCache in entitytests)

But what does the subject Moving to Java 7 mean? Just that OFBiz
should run on Java7 without problems or does is mean to drop support for
Java6?

Christian

Am 15.12.2013 10:22, schrieb Jacques Le Roux:
 Using Ubuntu 13.10 with last Oracle Java 7 (45) in a VirtualBox on Win7, I 
 still get 4 failures and 1 errors
 Error: a NPE on testDeposit
 Failures: 
 testWithdraw
 testForeignKeyRemove
 testStoreByCondition
 testRemoveByCondition
 
 Not sure what to think...
 
 Jacques
 
 On Friday, December 13, 2013 5:59 PM Jacques Le Roux 
 jacques.le.r...@les7arts.com wrote:
 I got 5 errors, 7 failures here on Win7 as I found on XP. I will soon 
 install a VM and Debian...

 Jacques


 On Friday, December 13, 2013 11:52 AM Jacopo Cappellato 
 jacopo.cappell...@hotwaxmedia.com wrote:
 All the tests are successful in the release 13.07

 Jacopo

 On Dec 11, 2013, at 12:15 PM, Jacques Le Roux 
 jacques.le.r...@les7arts.com wrote:

 Yes here also, running
 ant clean clean-data build load-demo run-tests

 I got 3 errors
accountingtests
testWithdraw
testDeposit
servicetests
entitytests
testSOAPSimpleService (this one fails sometimes here even with 
 Java 6)

 and 4 failures
entitytests
testFindDistinct
testForeignKeyRemove
testStoreByCondition
testRemoveByCondition

 Jacques

 On Wednesday, December 11, 2013 10:03 AM Adrian Crum 
 adrian.c...@sandglass-software.com wrote:
 The tests are not passing on Java 7. I have tried it on three different
 computers. Does anyone else have that problem?

 Adrian Crum
 Sandglass Software
 www.sandglass-software.com

 On 12/7/2013 7:33 AM, Adrian Crum wrote:
 Support for Java 6 is fading:

 http://java.com/en/download/faq/java_6.xml

 We need to discuss moving OFBiz over to Java 7.

 I have been building and running OFBiz R13 on Oracle Java 7 for over a
 month, and there were some minor compilation problems, but they were
 easy to fix.

 What do you think?

Re: Renaming .project release names

2013-11-13 Thread Christian Geisert

I think it's a convention to use only lowercase and no spaces for a
project name, actually I renamed my local copy to ofbiz-release12.04 ...

Christian

Am 13.11.2013 12:18, schrieb Jacopo Cappellato:
 +1
 
 I would prefer a name pattern like OFBiz Release 13.07
 
 Jacopo
 
 On Nov 13, 2013, at 11:23 AM, Jacques Le Roux jacques.le.r...@les7arts.com 
 wrote:
 
 Hi,

 Do you mind if I rename releases .project inside names?
 ie from
 nameofbiz/name
 to eg 
 namerelease13.07/name

 This to reflect the real releases branch names and allow easier global 
 importing in Eclipse.

 Jacques

Re: Cleaning up Ant build.xml files

2013-09-09 Thread Christian Geisert

Am 09.09.2013 11:15, schrieb Jacopo Cappellato:
 Thank you Christian; it is a good improvement, even if the runtime/indexes 
 folder is in svn and if you update your project you should always have it.

Ah, I'm using git-svn mirror and git doesn't support empty directories...

Christian

Re: svn commit: r1500424 - in /ofbiz/trunk/framework/webtools: config/WebtoolsUiLabels.xml webapp/webtools/WEB-INF/controller.xml webapp/webtools/XsdToJava.ftl webapp/webtools/main.ftl widget/MiscForm

2013-07-11 Thread Christian Geisert


Jacopo,

even if I agree with your statement, I think your tone is too rude for 
this mailing list.


Pierre: Please re-read the mail from Scott and think about it.

Christian

Am 09.07.2013 10:31, schrieb Jacopo Cappellato:

This is ridiculous, shut up, Pierre!

Jacopo

On Jul 9, 2013, at 9:13 AM, Pierre Smits pierre.sm...@gmail.com wrote:


if this is how you intend to interact with OFBiz users  then I'd strongly
encourage you to resign from the OFBiz PMC.  It's really not the type of
project management we need.

Pierre Smits

Re: svn commit: r1502093 - in /ofbiz/trunk: ./ applications/accounting/config/ applications/accounting/data/ applications/accounting/entitydef/ applications/accounting/servicedef/ applications/account

2013-07-11 Thread Christian Geisert


Am 11.07.2013 05:14, schrieb hans...@apache.org:

Author: hansbak
Date: Thu Jul 11 03:14:30 2013
New Revision: 1502093

URL: http://svn.apache.org/r1502093
Log:
add a csv import/export invoices at an organizational level with partyid and 
productid translation functions, more imports/exports will follow

Added:
 ofbiz/trunk/framework/base/lib/commons/commons-csv-1.0.jar   (with props)


Hans,

I much as I like this new feature, pushing it to the repository without 
any discussion is not the way to go.


And btw, you still haven't addressed Adrians concerns regarding the 
usage of screenlets...


Christian

[jira] [Commented] (OFBIZ-4953) Order item status change issue.

2013-07-04 Thread Christian Geisert (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699825#comment-13699825
]

Christian Geisert commented on OFBIZ-4953:
--

I can confirm the problem and the patch fixes the issue but a simpler fix would
be to change order items only with status ITEM_APPROVED. This would also cover
the case when an order item has the status ITEM_REJECTED

Thinking more about it, we shouldn't change the order item states when an order
is released from hold because (to my surprise) there is no ITEM_HOLD status and
therefore order item states don't change at all when an order is put on hold.

Order item status change issue.
---

Key: OFBIZ-4953
URL: https://issues.apache.org/jira/browse/OFBIZ-4953
Project: OFBiz
Issue Type: Bug
Components: order
Reporter: Deepak Dixit
Fix For: Release 10.04, Release Branch 11.04, SVN trunk, Release
Branch 12.04

Attachments: OFBIZ-4953-R10.04.patch, OFBIZ-4953-R11.04-R12.04.patch,
OFBIZ-4953-Trunk.patch

Steps to regenerate issue:
- Crate an SO/PO with more then one line item.
- Partially ship/received any one order item.
- After partial ship/receive order should be in approve status, one order
item in in completed status and another one is in Approved status.
- Change order status to hold.
- Now again approve order.
- After approve all order order except Completed/cancelled item should go in
Approved status.
But as per the current behavior completed order item also change to approved
status.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Idea/proposal: merging the Confluence spaces EndUsers, Technical, Requirements into the public wiki

2013-07-04 Thread Christian Geisert


Am 04.07.2013 12:24, schrieb Jacopo Cappellato:

Hi all,

in order to start the process of cleaning up the mess in our Confluence spaces, 
as a very first step I would like you to consider the idea of merging the 
spaces:

https://cwiki.apache.org/confluence/display/OFBENDUSER/OFBiz+End+User+Docs+Home
https://cwiki.apache.org/confluence/display/OFBTECH/Home
https://cwiki.apache.org/confluence/display/OFBREQDES/Home

into

https://cwiki.apache.org/confluence/display/OFBIZ/Home

[..]

What do you think?


+1 (I thought we already voted on this...)

What about links to the old spaces?

Christian

Re: svn commit: r1497817 - in /ofbiz/trunk/applications/product: servicedef/services_facility.xml src/org/ofbiz/product/inventory/InventoryServices.java webapp/facility/WEB-INF/actions/facility/ViewFa

2013-07-03 Thread Christian Geisert

Hmmh, I'm not sure about this one -  I think changing an api is bad 
(even if it's probably not widely used), but within a minor release it's 
even worser. I'll change the (wrong) field name on the form for the 
release branches.


Christian

Am 28.06.2013 22:33, schrieb Jacques Le Roux:

Should we not backport those fixes?

Jacques

From: chr...@apache.org

Author: chrisg
Date: Fri Jun 28 15:35:58 2013
New Revision: 1497817

URL: http://svn.apache.org/r1497817
Log:
Fixed problem with default price on inventory report (parameter name typo)

Modified:
ofbiz/trunk/applications/product/servicedef/services_facility.xml

ofbiz/trunk/applications/product/src/org/ofbiz/product/inventory/InventoryServices.java

ofbiz/trunk/applications/product/webapp/facility/WEB-INF/actions/facility/ViewFacilityInventoryByProduct.groovy

Re: svn commit: r1497822 - in /ofbiz/trunk/applications/manufacturing/data/helpdata: EN/ NL/

2013-07-03 Thread Christian Geisert

Well, it's a minor issue (for xml validation and code completion) - 
let's give it a try with mergefromtrunk.sh ;-)


Christian


Am 28.06.2013 22:33, schrieb Jacques Le Roux:

Should we not backport those fixes?

Jacques

From: chr...@apache.org

Author: chrisg
Date: Fri Jun 28 15:57:00 2013
New Revision: 1497822

URL: http://svn.apache.org/r1497822
Log:
Fixed wrong schemaLocation for manufacturing help files, see OFBIZ-5076

Modified:
ofbiz/trunk/applications/manufacturing/data/helpdata/EN/Help_MFG.xml

[..]

[jira] [Created] (OFBIZ-5250) Support for assigning a sales representative to a custome/order

Christian Geisert created OFBIZ-5250:


 Summary: Support for assigning a sales representative to a 
custome/order
 Key: OFBIZ-5250
 URL: https://issues.apache.org/jira/browse/OFBIZ-5250
 Project: OFBiz
  Issue Type: New Feature
  Components: order, party
Affects Versions: SVN trunk
Reporter: Christian Geisert


This change adds a new partyRelationshipTypeId SALES_REP:

{{{PartyRelationshipType description= hasTable=N parentTypeId= 
partyRelationshipName=Sales Representative 
partyRelationshipTypeId=SALES_REP roleTypeIdValidFrom= 
roleTypeIdValidTo=SALES_REP/}}}

When creating an order the sales rep will be added as additional party role to 
the shopping cart and then could be changed/removed on the Additional Party 
Entry screen while finalizing the order.

You can use DemoCustCompany for testing (added as Demodata)

I'd like to have a review before committing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-5250) Support for assigning a sales representative to a custome/order


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5250:
-

Description: 
This change adds a new PartyRelationshipType SALES_REP:

{{PartyRelationshipType description= hasTable=N parentTypeId= 
partyRelationshipName=Sales Representative 
partyRelationshipTypeId=SALES_REP roleTypeIdValidFrom= 
roleTypeIdValidTo=SALES_REP/}}

When creating an order the sales rep will be added as additional party role to 
the shopping cart and then could be changed/removed on the Additional Party 
Entry screen while finalizing the order.

You can use DemoCustCompany for testing (added as Demodata)

I'd like to have a review before committing.

  was:
This change adds a new partyRelationshipTypeId SALES_REP:

{{{PartyRelationshipType description= hasTable=N parentTypeId= 
partyRelationshipName=Sales Representative 
partyRelationshipTypeId=SALES_REP roleTypeIdValidFrom= 
roleTypeIdValidTo=SALES_REP/}}}

When creating an order the sales rep will be added as additional party role to 
the shopping cart and then could be changed/removed on the Additional Party 
Entry screen while finalizing the order.

You can use DemoCustCompany for testing (added as Demodata)

I'd like to have a review before committing.


 Support for assigning a sales representative to a custome/order
 ---

 Key: OFBIZ-5250
 URL: https://issues.apache.org/jira/browse/OFBIZ-5250
 Project: OFBiz
  Issue Type: New Feature
  Components: order, party
Affects Versions: SVN trunk
Reporter: Christian Geisert

 This change adds a new PartyRelationshipType SALES_REP:
 {{PartyRelationshipType description= hasTable=N parentTypeId= 
 partyRelationshipName=Sales Representative 
 partyRelationshipTypeId=SALES_REP roleTypeIdValidFrom= 
 roleTypeIdValidTo=SALES_REP/}}
 When creating an order the sales rep will be added as additional party role 
 to the shopping cart and then could be changed/removed on the Additional 
 Party Entry screen while finalizing the order.
 You can use DemoCustCompany for testing (added as Demodata)
 I'd like to have a review before committing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-5250) Support for assigning a sales representative to a custome/order


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert updated OFBIZ-5250:
-

Attachment: ofbiz_sales_rep_order-20130628.diff

 Support for assigning a sales representative to a custome/order
 ---

 Key: OFBIZ-5250
 URL: https://issues.apache.org/jira/browse/OFBIZ-5250
 Project: OFBiz
  Issue Type: New Feature
  Components: order, party
Affects Versions: SVN trunk
Reporter: Christian Geisert
 Attachments: ofbiz_sales_rep_order-20130628.diff


 This change adds a new PartyRelationshipType SALES_REP:
 {{PartyRelationshipType description= hasTable=N parentTypeId= 
 partyRelationshipName=Sales Representative 
 partyRelationshipTypeId=SALES_REP roleTypeIdValidFrom= 
 roleTypeIdValidTo=SALES_REP/}}
 When creating an order the sales rep will be added as additional party role 
 to the shopping cart and then could be changed/removed on the Additional 
 Party Entry screen while finalizing the order.
 You can use DemoCustCompany for testing (added as Demodata)
 I'd like to have a review before committing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (OFBIZ-5190) Missing UI Label translations to de Locale for Tags


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Geisert reassigned OFBIZ-5190:


Assignee: Christian Geisert

 Missing UI Label translations to de Locale for Tags
 ---

 Key: OFBIZ-5190
 URL: https://issues.apache.org/jira/browse/OFBIZ-5190
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
 Environment: xml config
Reporter: Carsten Schinzer
Assignee: Christian Geisert
Priority: Trivial
 Fix For: SVN trunk

 Attachments: 
 OFBIZ-5190_Missing_UI_Label_translations_to_de_Locale_for_Tags.patch

   Original Estimate: 0.5h
  Remaining Estimate: 0.5h

 UI Label translations are missing for the PriductTag UI elements on the 
 EcommerceUiLabels.xml for Locale de.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-5208) Missing de UI Labels for Product Comparison


[ 
https://issues.apache.org/jira/browse/OFBIZ-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13695435#comment-13695435
 ] 

Christian Geisert commented on OFBIZ-5208:
--

Will you provide a patch?

 Missing de UI Labels for Product Comparison
 ---

 Key: OFBIZ-5208
 URL: https://issues.apache.org/jira/browse/OFBIZ-5208
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: SVN trunk
 Environment: xml conifguration file   
Reporter: Carsten Schinzer
Priority: Trivial
 Fix For: SVN trunk

   Original Estimate: 0.5h
  Remaining Estimate: 0.5h

 UI Labels for Product COmparison screenlet are not available in de Locale

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-5050) Some additions and changes to manufacturing UI Labels locale de