[jira] [Assigned] (OOZIE-3207) Update ASF root pom version

2019-02-20 Thread Andras Salamon (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Salamon reassigned OOZIE-3207:
-

Assignee: Andras Salamon  (was: Artem Ervits)

> Update ASF root pom version
> ---
>
> Key: OOZIE-3207
> URL: https://issues.apache.org/jira/browse/OOZIE-3207
> Project: Oozie
>  Issue Type: Bug
>  Components: build
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Andras Salamon
>Priority: Blocker
> Fix For: 5.2.0
>
>
> The Oozie root pom uses the ASF root pom as it's parent (as required by ASF 
> rules).  We're currently using version 17, which is from 2015.  The current 
> version is 19, from earlier this year (2018).  We should update this.  
> You can see more details about the ASF root pom, including diffs between each 
> version here:
> https://maven.apache.org/pom/asf/index.html
> This may require some testing or at least looking into because the ASF root 
> pom defines the versions of some things, especially maven plugins, and so 
> things may break or be incompatible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3207) Update ASF root pom version

2019-02-20 Thread Andras Salamon (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773781#comment-16773781
 ] 

Andras Salamon commented on OOZIE-3207:
---

Thanks [~dbist13].

> Update ASF root pom version
> ---
>
> Key: OOZIE-3207
> URL: https://issues.apache.org/jira/browse/OOZIE-3207
> Project: Oozie
>  Issue Type: Bug
>  Components: build
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Artem Ervits
>Priority: Blocker
> Fix For: 5.2.0
>
>
> The Oozie root pom uses the ASF root pom as it's parent (as required by ASF 
> rules).  We're currently using version 17, which is from 2015.  The current 
> version is 19, from earlier this year (2018).  We should update this.  
> You can see more details about the ASF root pom, including diffs between each 
> version here:
> https://maven.apache.org/pom/asf/index.html
> This may require some testing or at least looking into because the ASF root 
> pom defines the versions of some things, especially maven plugins, and so 
> things may break or be incompatible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] Subscription: Oozie Patch Available

2019-02-20 Thread jira 
Issue Subscription
Filter: Oozie Patch Available (94 issues)

Subscriber: ooziedaily

Key Summary
OOZIE-3438  Copy only apache-jsp server dependencies to distro
https://issues.apache.org/jira/browse/OOZIE-3438
OOZIE-3437  Missing README from distro
https://issues.apache.org/jira/browse/OOZIE-3437
OOZIE-3432  When use configuration oozie.service.ProxyUserService.root.hosts, 
oozie-error.log shows Invalid configuration defined
https://issues.apache.org/jira/browse/OOZIE-3432
OOZIE-3418  Upgrade to Guava 27
https://issues.apache.org/jira/browse/OOZIE-3418
OOZIE-3409  Oozie Server : Memory leak in EL evaluation
https://issues.apache.org/jira/browse/OOZIE-3409
OOZIE-3404  The env variable of SPARK_HOME needs to be set when running pySpark
https://issues.apache.org/jira/browse/OOZIE-3404
OOZIE-3395  Findbugs is no longer maintained
https://issues.apache.org/jira/browse/OOZIE-3395
OOZIE-3375  Can't use empty  in coordinator
https://issues.apache.org/jira/browse/OOZIE-3375
OOZIE-3367  Using && in EL expressions in oozie bundle.xml files generates 
parse errors
https://issues.apache.org/jira/browse/OOZIE-3367
OOZIE-3366  Update workflow status and subworkflow status on suspend command
https://issues.apache.org/jira/browse/OOZIE-3366
OOZIE-3364  Rerunning Oozie bundle jobs starts the coordinators in 
indeterminate order
https://issues.apache.org/jira/browse/OOZIE-3364
OOZIE-3362  When killed, SSH action should kill the spawned processes on target 
host
https://issues.apache.org/jira/browse/OOZIE-3362
OOZIE-3326  Sqoop Action should support tez delegation tokens for hive-import
https://issues.apache.org/jira/browse/OOZIE-3326
OOZIE-3320  Oozie ShellAction should support absolute bash file path
https://issues.apache.org/jira/browse/OOZIE-3320
OOZIE-3319  Log SSH action callback error output
https://issues.apache.org/jira/browse/OOZIE-3319
OOZIE-3301  Update NOTICE file
https://issues.apache.org/jira/browse/OOZIE-3301
OOZIE-3274  Remove slf4j
https://issues.apache.org/jira/browse/OOZIE-3274
OOZIE-3266  Coord action rerun support RERUN_SKIP_NODES option
https://issues.apache.org/jira/browse/OOZIE-3266
OOZIE-3265  properties RERUN_FAIL_NODES and RERUN_SKIP_NODES should be able to 
appear together
https://issues.apache.org/jira/browse/OOZIE-3265
OOZIE-3256  refactor OozieCLI class
https://issues.apache.org/jira/browse/OOZIE-3256
OOZIE-3249  [tools] Instrumentation log parser
https://issues.apache.org/jira/browse/OOZIE-3249
OOZIE-3199  Let system property restriction configurable
https://issues.apache.org/jira/browse/OOZIE-3199
OOZIE-3196  Authorization: restrict world readability by user
https://issues.apache.org/jira/browse/OOZIE-3196
OOZIE-3179  Adding a configurable config-default.xml location to a workflow
https://issues.apache.org/jira/browse/OOZIE-3179
OOZIE-3170  Oozie Diagnostic Bundle tool fails with NPE due to missing service 
class
https://issues.apache.org/jira/browse/OOZIE-3170
OOZIE-3137  Add support for log4j2 in HiveMain
https://issues.apache.org/jira/browse/OOZIE-3137
OOZIE-3135  Configure log4j2 in SqoopMain
https://issues.apache.org/jira/browse/OOZIE-3135
OOZIE-3091  Oozie Sqoop Avro Import fails with "java.lang.NoClassDefFoundError: 
org/apache/avro/mapred/AvroWrapper"
https://issues.apache.org/jira/browse/OOZIE-3091
OOZIE-3071  Oozie 4.3 Spark sharelib ueses a different version of commons-lang3 
than Spark 2.2.0
https://issues.apache.org/jira/browse/OOZIE-3071
OOZIE-3063  Sanitizing variables that are part of openjpa.ConnectionProperties
https://issues.apache.org/jira/browse/OOZIE-3063
OOZIE-3062  Set HADOOP_CONF_DIR for spark action
https://issues.apache.org/jira/browse/OOZIE-3062
OOZIE-2952  Fix Findbugs warnings in oozie-sharelib-oozie
https://issues.apache.org/jira/browse/OOZIE-2952
OOZIE-2927  Append new line character for Hive2 query using query tag
https://issues.apache.org/jira/browse/OOZIE-2927
OOZIE-2834  ParameterVerifier logging non-useful warning for workflow definition
https://issues.apache.org/jira/browse/OOZIE-2834
OOZIE-2833  when using uber mode the regex pattern used in the 
extractHeapSizeMB method does not allow heap sizes specified in bytes.
https://issues.apache.org/jira/browse/OOZIE-2833
OOZIE-2812  SparkConfigurationService should support loading configurations 
from multiple Spark versions
https://issues.apache.org/jira/browse/OOZIE-2812
OOZIE-2795  Create lib directory or symlink for Oozie CLI during packaging
https://issues.apache.org/jira/browse/OOZIE-2795
OOZIE-2784  Include WEEK as a parameter in the Coordinator Expression Lang

[jira] [Commented] (OOZIE-2338) Invalid configuration defined reported for some valid configs

2019-02-20 Thread duan xiong (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773697#comment-16773697
 ] 

duan xiong commented on OOZIE-2338:
---

I will to take over it.

> Invalid configuration defined reported for some valid configs
> -
>
> Key: OOZIE-2338
> URL: https://issues.apache.org/jira/browse/OOZIE-2338
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.2.0
>Reporter: Robert Kanter
>Assignee: duan xiong
>Priority: Major
> Attachments: OOZIE-2338.001.patch, OOZIE-2338.002.patch
>
>
> OOZIE-1890 moved all default config values from the code and oozie-site into 
> oozie-default; it also added a WARN message on startup when a config is found 
> in oozie-site that's not defined in oozie-default.  
> However, this can produce some false positives.  In particular, we observed 
> these:
> {noformat}
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, [oozie.email.smtp.auth]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, [oozie.email.smtp.host]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, 
> [oozie.service.HCatAccessorService.hcat.configuration]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, [oozie.email.from.address]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, 
> [oozie.service.ProxyUserService.proxyuser.hue.hosts]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, 
> [oozie.service.GroupsService.hadoop.security.group.mapping]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, [oozie.email.smtp.port]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, 
> [oozie.service.ProxyUserService.proxyuser.hue.groups]
> {noformat}
> While harmful, these messages may be concerning or confusing for users.
> Some of these are simply missing from oozie-default (because they have no 
> default value?), while others such as the ProxyUserService configs, will 
> require special handling because the property name can vary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (OOZIE-2338) Invalid configuration defined reported for some valid configs

2019-02-20 Thread duan xiong (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

duan xiong reassigned OOZIE-2338:
-

 Assignee: duan xiong  (was: Robert Kanter)
Fix Version/s: (was: trunk)

> Invalid configuration defined reported for some valid configs
> -
>
> Key: OOZIE-2338
> URL: https://issues.apache.org/jira/browse/OOZIE-2338
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.2.0
>Reporter: Robert Kanter
>Assignee: duan xiong
>Priority: Major
> Attachments: OOZIE-2338.001.patch, OOZIE-2338.002.patch
>
>
> OOZIE-1890 moved all default config values from the code and oozie-site into 
> oozie-default; it also added a WARN message on startup when a config is found 
> in oozie-site that's not defined in oozie-default.  
> However, this can produce some false positives.  In particular, we observed 
> these:
> {noformat}
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, [oozie.email.smtp.auth]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, [oozie.email.smtp.host]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, 
> [oozie.service.HCatAccessorService.hcat.configuration]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, [oozie.email.from.address]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, 
> [oozie.service.ProxyUserService.proxyuser.hue.hosts]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, 
> [oozie.service.GroupsService.hadoop.security.group.mapping]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, [oozie.email.smtp.port]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, 
> [oozie.service.ProxyUserService.proxyuser.hue.groups]
> {noformat}
> While harmful, these messages may be concerning or confusing for users.
> Some of these are simply missing from oozie-default (because they have no 
> default value?), while others such as the ProxyUserService configs, will 
> require special handling because the property name can vary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3395) Findbugs is no longer maintained

2019-02-20 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773316#comment-16773316
 ] 

Hadoop QA commented on OOZIE-3395:
--


Testing JIRA OOZIE-3395

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:red}-1{color} the patch contains 6 line(s) longer than 132 
characters
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3135
.{color:orange}Tests failed at first run:{color}
TestPurgeXCommand#testPurgeableBundleUnpurgeableCoordinatorUnpurgeableWorkflow
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/1015/



> Findbugs is no longer maintained
> 
>
> Key: OOZIE-3395
> URL: https://issues.apache.org/jira/browse/OOZIE-3395
> Project: Oozie
>  Issue Type: Task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Minor
> Attachments: OOZIE-3395-001.patch, OOZIE-3395-002.patch
>
>
> https://gleclaire.github.io/findbugs-maven-plugin/
> {quote}
> Status: Since Findbugs is no longer maintained, please use Spotbugs which has 
> a Maven plugin.
> {quote}
> The plugin author recommends to migrate to Spotbugs: 
> https://spotbugs.github.io/
> It might  worth to investigate this plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: OOZIE-3395 PreCommit Build #1015

2019-02-20 Thread Apache Jenkins Server 
Jira: https://issues.apache.org/jira/browse/OOZIE-3395
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/1015/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.23 MB...]
[INFO] Apache Oozie Share Lib Oozie ... SUCCESS [  3.333 s]
[INFO] Apache Oozie Share Lib HCatalog  SUCCESS [  2.055 s]
[INFO] Apache Oozie Share Lib Distcp .. SUCCESS [  0.313 s]
[INFO] Apache Oozie Core .. SUCCESS [ 45.339 s]
[INFO] Apache Oozie Share Lib Streaming ... SUCCESS [  4.160 s]
[INFO] Apache Oozie Share Lib Pig . SUCCESS [  3.744 s]
[INFO] Apache Oozie Share Lib Git . SUCCESS [  5.985 s]
[INFO] Apache Oozie Share Lib Hive  SUCCESS [  2.423 s]
[INFO] Apache Oozie Share Lib Hive 2 .. SUCCESS [  3.590 s]
[INFO] Apache Oozie Share Lib Sqoop ... SUCCESS [  1.682 s]
[INFO] Apache Oozie Examples .. SUCCESS [  1.732 s]
[INFO] Apache Oozie Share Lib Spark ... SUCCESS [  5.094 s]
[INFO] Apache Oozie Share Lib . SUCCESS [ 27.301 s]
[INFO] Apache Oozie Docs .. SUCCESS [  7.627 s]
[INFO] Apache Oozie WebApp  SUCCESS [ 35.105 s]
[INFO] Apache Oozie Tools . SUCCESS [  2.159 s]
[INFO] Apache Oozie MiniOozie . SUCCESS [  1.337 s]
[INFO] Apache Oozie Fluent Job Client . SUCCESS [  0.438 s]
[INFO] Apache Oozie Server  SUCCESS [  3.687 s]
[INFO] Apache Oozie Distro  SUCCESS [ 36.358 s]
[INFO] Apache Oozie ZooKeeper Security Tests .. SUCCESS [  2.654 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time:  03:54 min
[INFO] Finished at: 2019-02-20T19:34:58Z
[INFO] 

Reports
  Running test-patch task CLEAN
  Running test-patch task RAW_PATCH_ANALYSIS
  Running test-patch task RAT
  Running test-patch task JAVADOC
  Running test-patch task COMPILE
bash: bin/test-patch-11-findbugs-diff: No such file or directory
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3395

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any star imports
-1 the patch contains 6 line(s) longer than 132 characters
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 Javadoc generation succeeded with the patch
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 3135
Tests failed at first run:
TestPurgeXCommand#testPurgeableBundleUnpurgeableCoordinatorUnpurgeableWorkflow
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/1015/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
 21220 0  100  2122  0   1787  0:00:01  0:00:01 --:--:--  1787100  
56200  3498  100  2122   2946   1787  0:00:01  0:00:01 --:--:--  2944
{"self":"https://issues.apache.org/jira/rest/api/2/issue/13201284/comment/16773316","id":"16773316","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=1

[jira] [Commented] (OOZIE-3207) Update ASF root pom version

2019-02-20 Thread Artem Ervits (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773240#comment-16773240
 ] 

Artem Ervits commented on OOZIE-3207:
-

[~asalamon74] please go ahead

> Update ASF root pom version
> ---
>
> Key: OOZIE-3207
> URL: https://issues.apache.org/jira/browse/OOZIE-3207
> Project: Oozie
>  Issue Type: Bug
>  Components: build
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Artem Ervits
>Priority: Blocker
> Fix For: 5.2.0
>
>
> The Oozie root pom uses the ASF root pom as it's parent (as required by ASF 
> rules).  We're currently using version 17, which is from 2015.  The current 
> version is 19, from earlier this year (2018).  We should update this.  
> You can see more details about the ASF root pom, including diffs between each 
> version here:
> https://maven.apache.org/pom/asf/index.html
> This may require some testing or at least looking into because the ASF root 
> pom defines the versions of some things, especially maven plugins, and so 
> things may break or be incompatible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OOZIE-3395) Findbugs is no longer maintained

2019-02-20 Thread Julia Kinga Marton (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julia Kinga Marton updated OOZIE-3395:
--
Attachment: OOZIE-3395-002.patch

> Findbugs is no longer maintained
> 
>
> Key: OOZIE-3395
> URL: https://issues.apache.org/jira/browse/OOZIE-3395
> Project: Oozie
>  Issue Type: Task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Minor
> Attachments: OOZIE-3395-001.patch, OOZIE-3395-002.patch
>
>
> https://gleclaire.github.io/findbugs-maven-plugin/
> {quote}
> Status: Since Findbugs is no longer maintained, please use Spotbugs which has 
> a Maven plugin.
> {quote}
> The plugin author recommends to migrate to Spotbugs: 
> https://spotbugs.github.io/
> It might  worth to investigate this plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3395) Findbugs is no longer maintained

2019-02-20 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773239#comment-16773239
 ] 

Hadoop QA commented on OOZIE-3395:
--

PreCommit-OOZIE-Build started


> Findbugs is no longer maintained
> 
>
> Key: OOZIE-3395
> URL: https://issues.apache.org/jira/browse/OOZIE-3395
> Project: Oozie
>  Issue Type: Task
>Reporter: Attila Sasvari
>Assignee: Julia Kinga Marton
>Priority: Minor
> Attachments: OOZIE-3395-001.patch, OOZIE-3395-002.patch
>
>
> https://gleclaire.github.io/findbugs-maven-plugin/
> {quote}
> Status: Since Findbugs is no longer maintained, please use Spotbugs which has 
> a Maven plugin.
> {quote}
> The plugin author recommends to migrate to Spotbugs: 
> https://spotbugs.github.io/
> It might  worth to investigate this plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 69988: OOZIE-3395 Findbugs is no longer maintained

2019-02-20 Thread Kinga Marton via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69988/
---

(Updated Feb. 20, 2019, 5:47 p.m.)


Review request for oozie and Andras Salamon.


Repository: oozie-git


Description
---

https://gleclaire.github.io/findbugs-maven-plugin/

Status: Since Findbugs is no longer maintained, please use Spotbugs which has a 
Maven plugin.

The plugin author recommends to migrate to Spotbugs: https://spotbugs.github.io/
It might worth to investigate this plugin.


Diffs (updated)
-

  bin/test-patch-11-findbugs-diff c884daaa3 
  client/pom.xml f0f6a1b13 
  core/pom.xml b6c07d345 
  fluent-job/fluent-job-api/findbugs-filter.xml  
  fluent-job/fluent-job-api/pom.xml f303b4583 
  fluent-job/pom.xml bb8861d59 
  pom.xml d817140f1 
  sharelib/git/pom.xml 1c17e48ba 
  sharelib/oozie/pom.xml a53d335f9 
  sharelib/spark/pom.xml 76f69034e 
  tools/pom.xml 72a6c283a 


Diff: https://reviews.apache.org/r/69988/diff/3/

Changes: https://reviews.apache.org/r/69988/diff/2-3/


Testing
---

Tested manually


Thanks,

Kinga Marton

Failed: OOZIE-3437 PreCommit Build #1014

2019-02-20 Thread Apache Jenkins Server 
Jira: https://issues.apache.org/jira/browse/OOZIE-3437
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/1014/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.91 MB...]
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/hcatalog].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [examples].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [tools].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [client].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [webapp].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2561 bytes
[TRACE] Full summary file size is 1471 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build@2/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3437

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any star imports
+1 the patch does not introduce any line longer than 132
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 Javadoc generation succeeded with the patch
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [fluent-job/fluent-job-api].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/git].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [webapp].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 3135
Tests failed at first run:
TestCoordActionInputCheckXCommand#testNone
For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/1014/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  34530 0  100  3453  0   2887  0:00:01  0:00:01 --:--:--  
2889{"self":"https://issues.apache.org/jira/rest/api/2/issue/13216859/comment/16773120","id":"16773120","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=hadoopqa&avatarId=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=hadoopqa&avatarId=10393"},"displayName":"Hadoop
 QA","active":true,"ti

[jira] [Commented] (OOZIE-3437) Missing README from distro

2019-02-20 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773120#comment-16773120
 ] 

Hadoop QA commented on OOZIE-3437:
--


Testing JIRA OOZIE-3437

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [webapp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3135
.{color:orange}Tests failed at first run:{color}
TestCoordActionInputCheckXCommand#testNone
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/1014/



> Missing README from distro
> --
>
> Key: OOZIE-3437
> URL: https://issues.apache.org/jira/browse/OOZIE-3437
> Project: Oozie
>  Issue Type: Bug
>Reporter: Andras Salamon
>Assignee: duan xiong
>Priority: Minor
> Attachments: oozie-3437-001.patch
>
>
> OOZIE-2734 renamed {{README.txt}} to {{README.md}} but {{distro.xml}} still 
> [refers|https://github.com/apache/oozie/blob/branch-5.1/src/main/assemblies/distro.xml#L42]
>  to {{README.txt}}. We should use {{README.md}} instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 69988: OOZIE-3395 Findbugs is no longer maintained

2019-02-20 Thread Andras Salamon 


> On Feb. 15, 2019, 10:02 a.m., Andras Salamon wrote:
> > fluent-job/fluent-job-api/pom.xml
> > Line 80 (original), 80 (patched)
> > 
> >
> > Should we keep this filename?
> 
> Kinga Marton wrote:
> I have renamed it, but we should convert the content of the file into 
> annotations. I will create an issue for it.

That would be great, but we generate those files so it might be difficult.


- Andras


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69988/#review212832
---


On Feb. 20, 2019, 2:20 p.m., Kinga Marton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69988/
> ---
> 
> (Updated Feb. 20, 2019, 2:20 p.m.)
> 
> 
> Review request for oozie and Andras Salamon.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> https://gleclaire.github.io/findbugs-maven-plugin/
> 
> Status: Since Findbugs is no longer maintained, please use Spotbugs which has 
> a Maven plugin.
> 
> The plugin author recommends to migrate to Spotbugs: 
> https://spotbugs.github.io/
> It might worth to investigate this plugin.
> 
> 
> Diffs
> -
> 
>   bin/test-patch-11-findbugs-diff c884daaa3 
>   client/pom.xml f0f6a1b13 
>   core/pom.xml b6c07d345 
>   fluent-job/fluent-job-api/findbugs-filter.xml  
>   fluent-job/fluent-job-api/pom.xml f303b4583 
>   fluent-job/pom.xml bb8861d59 
>   pom.xml d817140f1 
>   sharelib/git/pom.xml 1c17e48ba 
>   sharelib/oozie/pom.xml a53d335f9 
>   sharelib/spark/pom.xml 76f69034e 
>   tools/pom.xml 72a6c283a 
> 
> 
> Diff: https://reviews.apache.org/r/69988/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Kinga Marton
> 
>

Failed: OOZIE-3438 PreCommit Build #1013

2019-02-20 Thread Apache Jenkins Server 
Jira: https://issues.apache.org/jira/browse/OOZIE-3438
Build: https://builds.apache.org/job/PreCommit-OOZIE-Build/1013/

###
## LAST 100 LINES OF THE CONSOLE 
###
[...truncated 1.91 MB...]
[DEBUG] There are no new bugs found in [sharelib/pig].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/streaming].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [sharelib/hcatalog].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [examples].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [tools].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [client].
[TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts
[DEBUG] There are no new bugs found in [webapp].
[INFO] There are no new bugs found totally].
[TRACE] FindBugs diffs checked and reports created
[TRACE] Summary file size is 2561 bytes
[TRACE] Full summary file size is 1471 bytes
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]
 removed
[TRACE] File 
[/home/jenkins/jenkins-slave/workspace/PreCommit-OOZIE-Build/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]
 removed
  Running test-patch task BACKWARDS_COMPATIBILITY
  Running test-patch task TESTS
  Running test-patch task DISTRO


Testing JIRA OOZIE-3438

Cleaning local git workspace



+1 PATCH_APPLIES
+1 CLEAN
-1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any star imports
+1 the patch does not introduce any line longer than 132
-1 the patch does not add/modify any testcase
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 Javadoc generation succeeded with the patch
+1 the patch does not seem to introduce new Javadoc warning(s)
WARNING: the current HEAD has 100 Javadoc warning(s)
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 There are no new bugs found in total.
 +1 There are no new bugs found in [fluent-job/fluent-job-api].
 +1 There are no new bugs found in [docs].
 +1 There are no new bugs found in [core].
 +1 There are no new bugs found in [server].
 +1 There are no new bugs found in [sharelib/distcp].
 +1 There are no new bugs found in [sharelib/oozie].
 +1 There are no new bugs found in [sharelib/hive].
 +1 There are no new bugs found in [sharelib/hive2].
 +1 There are no new bugs found in [sharelib/git].
 +1 There are no new bugs found in [sharelib/spark].
 +1 There are no new bugs found in [sharelib/sqoop].
 +1 There are no new bugs found in [sharelib/pig].
 +1 There are no new bugs found in [sharelib/streaming].
 +1 There are no new bugs found in [sharelib/hcatalog].
 +1 There are no new bugs found in [examples].
 +1 There are no new bugs found in [tools].
 +1 There are no new bugs found in [client].
 +1 There are no new bugs found in [webapp].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 3135
+1 DISTRO
+1 distro tarball builds with the patch 


-1 Overall result, please check the reported -1(s)

 There is at least one warning, please check

The full output of the test-patch run is available at

 https://builds.apache.org/job/PreCommit-OOZIE-Build/1013/

Adding comment to JIRA
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100  32820 0  100  3282  0   3081  0:00:01  0:00:01 --:--:--  
3081{"self":"https://issues.apache.org/jira/rest/api/2/issue/13216878/comment/16773110","id":"16773110","author":{"self":"https://issues.apache.org/jira/rest/api/2/user?username=hadoopqa","name":"hadoopqa","key":"hadoopqa","avatarUrls":{"48x48":"https://issues.apache.org/jira/secure/useravatar?ownerId=hadoopqa&avatarId=10393","24x24":"https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=hadoopqa&avatarId=10393","16x16":"https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=hadoopqa&avatarId=10393","32x32":"https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=hadoopqa&avatarId=1039

[jira] [Commented] (OOZIE-3438) Copy only apache-jsp server dependencies to distro

2019-02-20 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773110#comment-16773110
 ] 

Hadoop QA commented on OOZIE-3438:
--


Testing JIRA OOZIE-3438

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in 
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [webapp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3135
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/1013/



> Copy only apache-jsp server dependencies to distro
> --
>
> Key: OOZIE-3438
> URL: https://issues.apache.org/jira/browse/OOZIE-3438
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3438-01.patch
>
>
> {{distro.xml}} defines the jars which will be copied into 
> {{embedded-oozie-server/dependency/}} directory. To copy the apache-jsp jar 
> files the following 
> [rule|https://github.com/apache/oozie/blob/branch-5.1/src/main/assemblies/distro.xml#L86]
>  is used
> {noformat}**/*jsp*.jar
> {noformat}
> In the current upstream Oozie it copies the following two files:
> {noformat}apache-jsp-8.0.33.jar
> apache-jsp-9.3.20.v20170531.jar{noformat}
> In a different environment it might also include other jars, for instance 
> {{javax.servlet.jsp-2.3.2.jar}}. There are several duplicate classes in 
> {{javax.servlet.jsp-2.3.2.jar}} and {{apache-jsp-8.0.33.jar}} which might 
> cause classpath issues.
> Instead, we should only include the apache-jsp jars.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 69988: OOZIE-3395 Findbugs is no longer maintained

2019-02-20 Thread Kinga Marton via Review Board 


> On Feb. 15, 2019, 10:02 a.m., Andras Salamon wrote:
> > bin/test-patch-11-findbugs-diff
> > Line 1 (original), 1 (patched)
> > 
> >
> > Can you please check the script with shellcheck

I have left a few warnings, because I wasn't sure that the shellcheck was right.


> On Feb. 15, 2019, 10:02 a.m., Andras Salamon wrote:
> > bin/test-patch-11-findbugs-diff
> > Line 275 (original), 275 (patched)
> > 
> >
> > Can we change the name to spotbugs-new.xml? Or maybe it's hardwired 
> > somewhere else?

This findbugs-new.xml is generated by findbugs-diff-0.1.0-all.jar, and 
unfortunately this value is hard-coded: 
https://github.com/AndersDJohnson/findbugs-diff/search?q=findbugs-new.xml&unscoped_q=findbugs-new.xml


> On Feb. 15, 2019, 10:02 a.m., Andras Salamon wrote:
> > fluent-job/fluent-job-api/pom.xml
> > Line 80 (original), 80 (patched)
> > 
> >
> > Should we keep this filename?

I have renamed it, but we should convert the content of the file into 
annotations. I will create an issue for it.


> On Feb. 15, 2019, 10:02 a.m., Andras Salamon wrote:
> > pom.xml
> > Line 1865 (original), 1871 (patched)
> > 
> >
> > Why is it called findbug? Compatibility reasons?

findbug is a general name, even if the tool behind the check is changed, what 
we are actually doing is searching for bugs, so I think that this id is a valid 
one enem if now the spotbugs is doing the job.


- Kinga


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69988/#review212832
---


On Feb. 20, 2019, 2:20 p.m., Kinga Marton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69988/
> ---
> 
> (Updated Feb. 20, 2019, 2:20 p.m.)
> 
> 
> Review request for oozie and Andras Salamon.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> https://gleclaire.github.io/findbugs-maven-plugin/
> 
> Status: Since Findbugs is no longer maintained, please use Spotbugs which has 
> a Maven plugin.
> 
> The plugin author recommends to migrate to Spotbugs: 
> https://spotbugs.github.io/
> It might worth to investigate this plugin.
> 
> 
> Diffs
> -
> 
>   bin/test-patch-11-findbugs-diff c884daaa3 
>   client/pom.xml f0f6a1b13 
>   core/pom.xml b6c07d345 
>   fluent-job/fluent-job-api/findbugs-filter.xml  
>   fluent-job/fluent-job-api/pom.xml f303b4583 
>   fluent-job/pom.xml bb8861d59 
>   pom.xml d817140f1 
>   sharelib/git/pom.xml 1c17e48ba 
>   sharelib/oozie/pom.xml a53d335f9 
>   sharelib/spark/pom.xml 76f69034e 
>   tools/pom.xml 72a6c283a 
> 
> 
> Diff: https://reviews.apache.org/r/69988/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Kinga Marton
> 
>

Re: Review Request 69988: OOZIE-3395 Findbugs is no longer maintained

2019-02-20 Thread Kinga Marton via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69988/
---

(Updated Feb. 20, 2019, 2:20 p.m.)


Review request for oozie and Andras Salamon.


Repository: oozie-git


Description
---

https://gleclaire.github.io/findbugs-maven-plugin/

Status: Since Findbugs is no longer maintained, please use Spotbugs which has a 
Maven plugin.

The plugin author recommends to migrate to Spotbugs: https://spotbugs.github.io/
It might worth to investigate this plugin.


Diffs (updated)
-

  bin/test-patch-11-findbugs-diff c884daaa3 
  client/pom.xml f0f6a1b13 
  core/pom.xml b6c07d345 
  fluent-job/fluent-job-api/findbugs-filter.xml  
  fluent-job/fluent-job-api/pom.xml f303b4583 
  fluent-job/pom.xml bb8861d59 
  pom.xml d817140f1 
  sharelib/git/pom.xml 1c17e48ba 
  sharelib/oozie/pom.xml a53d335f9 
  sharelib/spark/pom.xml 76f69034e 
  tools/pom.xml 72a6c283a 


Diff: https://reviews.apache.org/r/69988/diff/2/

Changes: https://reviews.apache.org/r/69988/diff/1-2/


Testing
---

Tested manually


Thanks,

Kinga Marton

[jira] [Commented] (OOZIE-2338) Invalid configuration defined reported for some valid configs

2019-02-20 Thread duan xiong (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773042#comment-16773042
 ] 

duan xiong commented on OOZIE-2338:
---

Hi,[~abhishekbafna], I think should add : endWith() . make log more accuracy.

> Invalid configuration defined reported for some valid configs
> -
>
> Key: OOZIE-2338
> URL: https://issues.apache.org/jira/browse/OOZIE-2338
> Project: Oozie
>  Issue Type: Bug
>  Components: core
>Affects Versions: 4.2.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
>Priority: Major
> Fix For: trunk
>
> Attachments: OOZIE-2338.001.patch, OOZIE-2338.002.patch
>
>
> OOZIE-1890 moved all default config values from the code and oozie-site into 
> oozie-default; it also added a WARN message on startup when a config is found 
> in oozie-site that's not defined in oozie-default.  
> However, this can produce some false positives.  In particular, we observed 
> these:
> {noformat}
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, [oozie.email.smtp.auth]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, [oozie.email.smtp.host]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, 
> [oozie.service.HCatAccessorService.hcat.configuration]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, [oozie.email.from.address]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, 
> [oozie.service.ProxyUserService.proxyuser.hue.hosts]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, 
> [oozie.service.GroupsService.hadoop.security.group.mapping]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, [oozie.email.smtp.port]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: 
> SERVER[] Invalid configuration defined, 
> [oozie.service.ProxyUserService.proxyuser.hue.groups]
> {noformat}
> While harmful, these messages may be concerning or confusing for users.
> Some of these are simply missing from oozie-default (because they have no 
> default value?), while others such as the ProxyUserService configs, will 
> require special handling because the property name can vary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3437) Missing README from distro

2019-02-20 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773036#comment-16773036
 ] 

Hadoop QA commented on OOZIE-3437:
--

PreCommit-OOZIE-Build started


> Missing README from distro
> --
>
> Key: OOZIE-3437
> URL: https://issues.apache.org/jira/browse/OOZIE-3437
> Project: Oozie
>  Issue Type: Bug
>Reporter: Andras Salamon
>Assignee: duan xiong
>Priority: Minor
> Attachments: oozie-3437-001.patch
>
>
> OOZIE-2734 renamed {{README.txt}} to {{README.md}} but {{distro.xml}} still 
> [refers|https://github.com/apache/oozie/blob/branch-5.1/src/main/assemblies/distro.xml#L42]
>  to {{README.txt}}. We should use {{README.md}} instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3207) Update ASF root pom version

2019-02-20 Thread Andras Salamon (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773028#comment-16773028
 ] 

Andras Salamon commented on OOZIE-3207:
---

[~dbist13] Do you mind if I take it over?

> Update ASF root pom version
> ---
>
> Key: OOZIE-3207
> URL: https://issues.apache.org/jira/browse/OOZIE-3207
> Project: Oozie
>  Issue Type: Bug
>  Components: build
>Affects Versions: 5.0.0
>Reporter: Robert Kanter
>Assignee: Artem Ervits
>Priority: Blocker
> Fix For: 5.2.0
>
>
> The Oozie root pom uses the ASF root pom as it's parent (as required by ASF 
> rules).  We're currently using version 17, which is from 2015.  The current 
> version is 19, from earlier this year (2018).  We should update this.  
> You can see more details about the ASF root pom, including diffs between each 
> version here:
> https://maven.apache.org/pom/asf/index.html
> This may require some testing or at least looking into because the ASF root 
> pom defines the versions of some things, especially maven plugins, and so 
> things may break or be incompatible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3438) Copy only apache-jsp server dependencies to distro

2019-02-20 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773022#comment-16773022
 ] 

Hadoop QA commented on OOZIE-3438:
--

PreCommit-OOZIE-Build started


> Copy only apache-jsp server dependencies to distro
> --
>
> Key: OOZIE-3438
> URL: https://issues.apache.org/jira/browse/OOZIE-3438
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Major
> Fix For: 5.2.0
>
> Attachments: OOZIE-3438-01.patch
>
>
> {{distro.xml}} defines the jars which will be copied into 
> {{embedded-oozie-server/dependency/}} directory. To copy the apache-jsp jar 
> files the following 
> [rule|https://github.com/apache/oozie/blob/branch-5.1/src/main/assemblies/distro.xml#L86]
>  is used
> {noformat}**/*jsp*.jar
> {noformat}
> In the current upstream Oozie it copies the following two files:
> {noformat}apache-jsp-8.0.33.jar
> apache-jsp-9.3.20.v20170531.jar{noformat}
> In a different environment it might also include other jars, for instance 
> {{javax.servlet.jsp-2.3.2.jar}}. There are several duplicate classes in 
> {{javax.servlet.jsp-2.3.2.jar}} and {{apache-jsp-8.0.33.jar}} which might 
> cause classpath issues.
> Instead, we should only include the apache-jsp jars.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3438) Copy only apache-jsp server dependencies to distro

2019-02-20 Thread Andras Salamon (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772974#comment-16772974
 ] 

Andras Salamon commented on OOZIE-3438:
---

[~nobigo] Yes, I'm already working on it.

> Copy only apache-jsp server dependencies to distro
> --
>
> Key: OOZIE-3438
> URL: https://issues.apache.org/jira/browse/OOZIE-3438
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Major
> Fix For: 5.2.0
>
>
> {{distro.xml}} defines the jars which will be copied into 
> {{embedded-oozie-server/dependency/}} directory. To copy the apache-jsp jar 
> files the following 
> [rule|https://github.com/apache/oozie/blob/branch-5.1/src/main/assemblies/distro.xml#L86]
>  is used
> {noformat}**/*jsp*.jar
> {noformat}
> In the current upstream Oozie it copies the following two files:
> {noformat}apache-jsp-8.0.33.jar
> apache-jsp-9.3.20.v20170531.jar{noformat}
> In a different environment it might also include other jars, for instance 
> {{javax.servlet.jsp-2.3.2.jar}}. There are several duplicate classes in 
> {{javax.servlet.jsp-2.3.2.jar}} and {{apache-jsp-8.0.33.jar}} which might 
> cause classpath issues.
> Instead, we should only include the apache-jsp jars.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OOZIE-3438) Copy only apache-jsp server dependencies to distro

2019-02-20 Thread duan xiong (JIRA) 


[ 
https://issues.apache.org/jira/browse/OOZIE-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772900#comment-16772900
 ] 

duan xiong commented on OOZIE-3438:
---

Hi,[~asalamon74]，I have read the distro.xml:

apache-jsp-8.0.33.jar

apache-jsp-9.3.20.v20170531.jar

can copy by

**/apache*.jar

so we can delete this **/*jsp*.jar directly?

> Copy only apache-jsp server dependencies to distro
> --
>
> Key: OOZIE-3438
> URL: https://issues.apache.org/jira/browse/OOZIE-3438
> Project: Oozie
>  Issue Type: Bug
>Affects Versions: trunk
>Reporter: Andras Salamon
>Assignee: Andras Salamon
>Priority: Major
> Fix For: 5.2.0
>
>
> {{distro.xml}} defines the jars which will be copied into 
> {{embedded-oozie-server/dependency/}} directory. To copy the apache-jsp jar 
> files the following 
> [rule|https://github.com/apache/oozie/blob/branch-5.1/src/main/assemblies/distro.xml#L86]
>  is used
> {noformat}**/*jsp*.jar
> {noformat}
> In the current upstream Oozie it copies the following two files:
> {noformat}apache-jsp-8.0.33.jar
> apache-jsp-9.3.20.v20170531.jar{noformat}
> In a different environment it might also include other jars, for instance 
> {{javax.servlet.jsp-2.3.2.jar}}. There are several duplicate classes in 
> {{javax.servlet.jsp-2.3.2.jar}} and {{apache-jsp-8.0.33.jar}} which might 
> cause classpath issues.
> Instead, we should only include the apache-jsp jars.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (OOZIE-3437) Missing README from distro

2019-02-20 Thread duan xiong (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OOZIE-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

duan xiong reassigned OOZIE-3437:
-

Assignee: duan xiong

> Missing README from distro
> --
>
> Key: OOZIE-3437
> URL: https://issues.apache.org/jira/browse/OOZIE-3437
> Project: Oozie
>  Issue Type: Bug
>Reporter: Andras Salamon
>Assignee: duan xiong
>Priority: Minor
>
> OOZIE-2734 renamed {{README.txt}} to {{README.md}} but {{distro.xml}} still 
> [refers|https://github.com/apache/oozie/blob/branch-5.1/src/main/assemblies/distro.xml#L42]
>  to {{README.txt}}. We should use {{README.md}} instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (OOZIE-3438) Copy only apache-jsp server dependencies to distro

2019-02-20 Thread Andras Salamon (JIRA) 
Andras Salamon created OOZIE-3438:
-

 Summary: Copy only apache-jsp server dependencies to distro
 Key: OOZIE-3438
 URL: https://issues.apache.org/jira/browse/OOZIE-3438
 Project: Oozie
  Issue Type: Bug
Affects Versions: trunk
Reporter: Andras Salamon
Assignee: Andras Salamon
 Fix For: 5.2.0


{{distro.xml}} defines the jars which will be copied into 
{{embedded-oozie-server/dependency/}} directory. To copy the apache-jsp jar 
files the following 
[rule|https://github.com/apache/oozie/blob/branch-5.1/src/main/assemblies/distro.xml#L86]
 is used

{noformat}**/*jsp*.jar
{noformat}

In the current upstream Oozie it copies the following two files:

{noformat}apache-jsp-8.0.33.jar
apache-jsp-9.3.20.v20170531.jar{noformat}

In a different environment it might also include other jars, for instance 
{{javax.servlet.jsp-2.3.2.jar}}. There are several duplicate classes in 
{{javax.servlet.jsp-2.3.2.jar}} and {{apache-jsp-8.0.33.jar}} which might cause 
classpath issues.

Instead, we should only include the apache-jsp jars.





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (OOZIE-3437) Missing README from distro

2019-02-20 Thread Andras Salamon (JIRA) 
Andras Salamon created OOZIE-3437:
-

 Summary: Missing README from distro
 Key: OOZIE-3437
 URL: https://issues.apache.org/jira/browse/OOZIE-3437
 Project: Oozie
  Issue Type: Bug
Reporter: Andras Salamon


OOZIE-2734 renamed {{README.txt}} to {{README.md}} but {{distro.xml}} still 
[refers|https://github.com/apache/oozie/blob/branch-5.1/src/main/assemblies/distro.xml#L42]
 to {{README.txt}}. We should use {{README.md}} instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)