> On Feb. 15, 2019, 10:02 a.m., Andras Salamon wrote: > > bin/test-patch-11-findbugs-diff > > Line 1 (original), 1 (patched) > > <https://reviews.apache.org/r/69988/diff/1/?file=2125364#file2125364line1> > > > > Can you please check the script with shellcheck
I have left a few warnings, because I wasn't sure that the shellcheck was right. > On Feb. 15, 2019, 10:02 a.m., Andras Salamon wrote: > > bin/test-patch-11-findbugs-diff > > Line 275 (original), 275 (patched) > > <https://reviews.apache.org/r/69988/diff/1/?file=2125364#file2125364line275> > > > > Can we change the name to spotbugs-new.xml? Or maybe it's hardwired > > somewhere else? This findbugs-new.xml is generated by findbugs-diff-0.1.0-all.jar, and unfortunately this value is hard-coded: https://github.com/AndersDJohnson/findbugs-diff/search?q=findbugs-new.xml&unscoped_q=findbugs-new.xml > On Feb. 15, 2019, 10:02 a.m., Andras Salamon wrote: > > fluent-job/fluent-job-api/pom.xml > > Line 80 (original), 80 (patched) > > <https://reviews.apache.org/r/69988/diff/1/?file=2125367#file2125367line80> > > > > Should we keep this filename? I have renamed it, but we should convert the content of the file into annotations. I will create an issue for it. > On Feb. 15, 2019, 10:02 a.m., Andras Salamon wrote: > > pom.xml > > Line 1865 (original), 1871 (patched) > > <https://reviews.apache.org/r/69988/diff/1/?file=2125369#file2125369line1872> > > > > Why is it called findbug? Compatibility reasons? findbug is a general name, even if the tool behind the check is changed, what we are actually doing is searching for bugs, so I think that this id is a valid one enem if now the spotbugs is doing the job. - Kinga ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69988/#review212832 ----------------------------------------------------------- On Feb. 20, 2019, 2:20 p.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69988/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2019, 2:20 p.m.) > > > Review request for oozie and Andras Salamon. > > > Repository: oozie-git > > > Description > ------- > > https://gleclaire.github.io/findbugs-maven-plugin/ > > Status: Since Findbugs is no longer maintained, please use Spotbugs which has > a Maven plugin. > > The plugin author recommends to migrate to Spotbugs: > https://spotbugs.github.io/ > It might worth to investigate this plugin. > > > Diffs > ----- > > bin/test-patch-11-findbugs-diff c884daaa3 > client/pom.xml f0f6a1b13 > core/pom.xml b6c07d345 > fluent-job/fluent-job-api/findbugs-filter.xml > fluent-job/fluent-job-api/pom.xml f303b4583 > fluent-job/pom.xml bb8861d59 > pom.xml d817140f1 > sharelib/git/pom.xml 1c17e48ba > sharelib/oozie/pom.xml a53d335f9 > sharelib/spark/pom.xml 76f69034e > tools/pom.xml 72a6c283a > > > Diff: https://reviews.apache.org/r/69988/diff/2/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Kinga Marton > >
