> On Feb. 15, 2019, 10:02 a.m., Andras Salamon wrote: > > fluent-job/fluent-job-api/pom.xml > > Line 80 (original), 80 (patched) > > <https://reviews.apache.org/r/69988/diff/1/?file=2125367#file2125367line80> > > > > Should we keep this filename? > > Kinga Marton wrote: > I have renamed it, but we should convert the content of the file into > annotations. I will create an issue for it.
That would be great, but we generate those files so it might be difficult. - Andras ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69988/#review212832 ----------------------------------------------------------- On Feb. 20, 2019, 2:20 p.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69988/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2019, 2:20 p.m.) > > > Review request for oozie and Andras Salamon. > > > Repository: oozie-git > > > Description > ------- > > https://gleclaire.github.io/findbugs-maven-plugin/ > > Status: Since Findbugs is no longer maintained, please use Spotbugs which has > a Maven plugin. > > The plugin author recommends to migrate to Spotbugs: > https://spotbugs.github.io/ > It might worth to investigate this plugin. > > > Diffs > ----- > > bin/test-patch-11-findbugs-diff c884daaa3 > client/pom.xml f0f6a1b13 > core/pom.xml b6c07d345 > fluent-job/fluent-job-api/findbugs-filter.xml > fluent-job/fluent-job-api/pom.xml f303b4583 > fluent-job/pom.xml bb8861d59 > pom.xml d817140f1 > sharelib/git/pom.xml 1c17e48ba > sharelib/oozie/pom.xml a53d335f9 > sharelib/spark/pom.xml 76f69034e > tools/pom.xml 72a6c283a > > > Diff: https://reviews.apache.org/r/69988/diff/2/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Kinga Marton > >
