Re: Review Request 52824: OOZIE-2644 Skip queuing Notification Commands when there's nothing to notify
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52824/ --- (Updated Oct. 13, 2016, 3:56 p.m.) Review request for oozie and Robert Kanter. Changes --- Fix test failures. Bugs: OOZIE-2644 https://issues.apache.org/jira/browse/OOZIE-2644 Repository: oozie-git Description --- Skip queing Notification Command if the notification url is not configured. And this patch fix the NullPointerException when CoordActionNotification executed from CoordActionKillXCommand. This is caused the runConf of actionBean is not set. Diffs (updated) - core/src/main/java/org/apache/oozie/CoordinatorActionBean.java b1be7c9 core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 3a3120d core/src/main/java/org/apache/oozie/command/NotificationXCommand.java 68359aa core/src/main/java/org/apache/oozie/command/XCommand.java bdf13f6 core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java ef0fc2d core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 45abe5a core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 958194d core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d4c98c8 core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java f6c1782 core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java f1509e6 core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java d0551ff core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 740b8d3 core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java ac096cc core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java edfac48 core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 836e5d4 core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 40b93d3 core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java edbd767 core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java e95a60a core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java ef97990 core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java bc80dfe core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java c0e6c19 core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 432f075 core/src/main/java/org/apache/oozie/local/LocalOozie.java bf1b0db core/src/main/resources/oozie-default.xml e71ebe3 core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java 8ca404f core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java c9b2f28 core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java ef342a4 core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java a0012fb core/src/test/java/org/apache/oozie/test/XDataTestCase.java ea778bd Diff: https://reviews.apache.org/r/52824/diff/ Testing --- Unit test. Thanks, Azrael Seoeun Park
Review Request 52824: OOZIE-2644 Skip queuing Notification Commands when there's nothing to notify
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52824/ --- Review request for oozie and Robert Kanter. Bugs: OOZIE-2644 https://issues.apache.org/jira/browse/OOZIE-2644 Repository: oozie-git Description --- Skip queing Notification Command if the notification url is not configured. And this patch fix the NullPointerException when CoordActionNotification executed from CoordActionKillXCommand. This is caused the runConf of actionBean is not set. Diffs - core/src/main/java/org/apache/oozie/CoordinatorActionBean.java b1be7c9 core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 3a3120d core/src/main/java/org/apache/oozie/command/NotificationXCommand.java 68359aa core/src/main/java/org/apache/oozie/command/TransitionXCommand.java 6024138 core/src/main/java/org/apache/oozie/command/XCommand.java bdf13f6 core/src/main/java/org/apache/oozie/command/coord/CoordActionSkipXCommand.java ef0fc2d core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 45abe5a core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 958194d core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java d4c98c8 core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java f6c1782 core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java f1509e6 core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java d0551ff core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 740b8d3 core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java ac096cc core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java edfac48 core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 836e5d4 core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 40b93d3 core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java edbd767 core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java e95a60a core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java ef97990 core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java bc80dfe core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java c0e6c19 core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 432f075 core/src/main/java/org/apache/oozie/local/LocalOozie.java bf1b0db core/src/main/resources/oozie-default.xml e71ebe3 core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java 8ca404f core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java c9b2f28 core/src/test/java/org/apache/oozie/command/wf/TestWorkflowNotificationXCommand.java ef342a4 core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java a0012fb core/src/test/java/org/apache/oozie/test/XDataTestCase.java ea778bd Diff: https://reviews.apache.org/r/52824/diff/ Testing --- Unit test. Thanks, Azrael Seoeun Park
Re: Review Request 31103: OOZIE-2134 Remove references to Services.get().getConf() in code
/TestActionService.java 5b5ac93 core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java ce461c1 core/src/test/java/org/apache/oozie/service/TestConfigurationService.java f18a8c0 core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 53b7f62 core/src/test/java/org/apache/oozie/service/TestGroupsService.java d1abc6e core/src/test/java/org/apache/oozie/service/TestHAPartitionDependencyManagerEhCache.java 24ff36b core/src/test/java/org/apache/oozie/service/TestHAPartitionDependencyManagerService.java d681d42 core/src/test/java/org/apache/oozie/service/TestHASLAService.java 3af263e core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java 791f568 core/src/test/java/org/apache/oozie/service/TestHCatAccessorService.java b195fb7 core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java bbe2594 core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 505049d core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java 383e53e core/src/test/java/org/apache/oozie/service/TestJobsConcurrencyService.java 011a574 core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 560fedb core/src/test/java/org/apache/oozie/service/TestMetricsInstrumentationService.java 59945a7 core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java b844145 core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java a5d2ed9 core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 677a360 core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 47affc2 core/src/test/java/org/apache/oozie/service/TestPurgeService.java 74d34cc core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 8fd0c2d core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 0bcbce0 core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java ce731a1 core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 04fde73 core/src/test/java/org/apache/oozie/servlet/TestBulkMonitorWebServiceAPI.java b4054b0 core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 7e1921e core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 06f54f2 core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 7d40e31 core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1e19923 core/src/test/java/org/apache/oozie/test/XDataTestCase.java ea778bd core/src/test/java/org/apache/oozie/test/XTestCase.java 8ce44f3 core/src/test/java/org/apache/oozie/test/ZKXTestCase.java dfbea88 core/src/test/java/org/apache/oozie/util/TestConfigUtils.java 6904881 core/src/test/java/org/apache/oozie/util/TestXLogUserFilterParam.java 46f273f sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 2713526 tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 8ada2e4 tools/src/main/java/org/apache/oozie/tools/OozieDBExportCLI.java 740a48b tools/src/main/java/org/apache/oozie/tools/OozieDBImportCLI.java 0e14a30 tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java 9aa4cb6 tools/src/test/java/org/apache/oozie/tools/TestOozieSharelibCLI.java 7fff802 zookeeper-security-tests/src/test/java/org/apache/oozie/test/ZKXTestCaseWithSecurity.java f9f3e88 zookeeper-security-tests/src/test/java/org/apache/oozie/util/TestZKUtilsWithSecurity.java ffced02 Diff: https://reviews.apache.org/r/31103/diff/ Testing --- Unit Test. Manual Test. Thanks, Azrael Seoeun Park
Re: Review Request 23301: OOZIE-1918 ActionXCommand refactoring
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23301/ --- (Updated July 6, 2015, 3:36 a.m.) Review request for oozie. Changes --- Addressed comments. Rebased on the lates branch. Bugs: OOZIE-1918 https://issues.apache.org/jira/browse/OOZIE-1918 Repository: oozie-git Description --- Subclasses of ActionXCommand have some duplicated code. Refactoring make it more neat. This patch contain: * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending ActionXCommand * Moving some variables and methods to ActionXCommand and making it protected * More meaningful log message : On exeucte(), actionId is duplicated so removed * Adding handleExecutionFail() to handle ActionExcutionException during execute() Diffs (updated) - core/src/main/java/org/apache/oozie/DagEngine.java 9061d17 core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 5827387 core/src/main/java/org/apache/oozie/command/wf/ActionCompletedXCommand.java PRE-CREATION core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 4006441 core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 33498bf core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java e06649c core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 2616d32 core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java bc39bce core/src/test/java/org/apache/oozie/ForTestingActionExecutor.java a70dc02 core/src/test/java/org/apache/oozie/command/wf/TestCompletedActionXCommand.java a4f0e83 core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 14f5294 Diff: https://reviews.apache.org/r/23301/diff/ Testing --- No added new testcase. Done manual test. Thanks, Azrael Seoeun Park
Re: Review Request 23301: OOZIE-1918 ActionXCommand refactoring
On June 17, 2015, 1:08 p.m., Jaydeep Vishwakarma wrote:
core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java,
line 168
https://reviews.apache.org/r/23301/diff/3/?file=877400#file877400line168
Action id is missing in all loging
I removed actionId because the log prefix contain the action Id.
{quote}
015-07-05 00:21:07,814 DEBUG ActionStartXCommand:526 [pool-5-thread-9] -
USER[seoeun] GROUP[staff] TOKEN[] APP[test]
JOB[000-150705001901308-oozie-seoe-W]
ACTION[000-150705001901308-oozie-seoe-W@shell-2] ...
{quote}
Though, we need actionId for the text search on logfilter (OOZIE-1802), so I
revert it.
- Azrael Seoeun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23301/#review74731
---
On July 6, 2015, 3:36 a.m., Azrael Seoeun Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23301/
---
(Updated July 6, 2015, 3:36 a.m.)
Review request for oozie.
Bugs: OOZIE-1918
https://issues.apache.org/jira/browse/OOZIE-1918
Repository: oozie-git
Description
---
Subclasses of ActionXCommand have some duplicated code. Refactoring make it
more neat.
This patch contain:
* Renaming CompletedActionXCommand to ActionCompletedXCommand and extending
ActionXCommand
* Moving some variables and methods to ActionXCommand and making it protected
* More meaningful log message : On exeucte(), actionId is duplicated so
removed
* Adding handleExecutionFail() to handle ActionExcutionException during
execute()
Diffs
-
core/src/main/java/org/apache/oozie/DagEngine.java 9061d17
core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java
5827387
core/src/main/java/org/apache/oozie/command/wf/ActionCompletedXCommand.java
PRE-CREATION
core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java
4006441
core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java
33498bf
core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java
e06649c
core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 2616d32
core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java
bc39bce
core/src/test/java/org/apache/oozie/ForTestingActionExecutor.java a70dc02
core/src/test/java/org/apache/oozie/command/wf/TestCompletedActionXCommand.java
a4f0e83
core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 14f5294
Diff: https://reviews.apache.org/r/23301/diff/
Testing
---
No added new testcase.
Done manual test.
Thanks,
Azrael Seoeun Park
