[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936459#comment-15936459
]
Abhishek Bafna commented on OOZIE-2041:
---
Sure. Thanks for let me know. I will keep in mind until we fix this. :)
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch,
> OOZIE-2041-08.patch, OOZIE-2041-09.patch, OOZIE-2041-10.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936448#comment-15936448
]
Peter Cseh commented on OOZIE-2041:
---
It's because OOZIE-2817.
If you check the logs:
https://builds.apache.org/job/oozie-trunk-precommit-build/3716/consoleFull
...
Rerunning failed tests: org.apache.oozie.jms.TestJMSJobEventListener,
...
And it succeeded after rerun.
The reporting is broken though so I'll have to improve on that.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch,
> OOZIE-2041-08.patch, OOZIE-2041-09.patch, OOZIE-2041-10.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936439#comment-15936439
]
Abhishek Bafna commented on OOZIE-2041:
---
Committed to master. Thanks [~gezapeti] and others for review.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch,
> OOZIE-2041-08.patch, OOZIE-2041-09.patch, OOZIE-2041-10.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936432#comment-15936432
]
Abhishek Bafna commented on OOZIE-2041:
---
Did not find any test failure in the Jenkins job, though here it say one.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch,
> OOZIE-2041-08.patch, OOZIE-2041-09.patch, OOZIE-2041-10.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936386#comment-15936386
]
Hadoop QA commented on OOZIE-2041:
--
Testing JIRA OOZIE-2041
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:orange}0{color} There are [1] new bugs found in total that would be nice
to have fixed.
.{color:orange}0{color} There are [1] new bugs found in [client] that would
be nice to have fixed.
.You can find the FindBugs diff here: client/findbugs-new.html
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1901
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
.
.Tests failing with errors:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3716/
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch,
> OOZIE-2041-08.patch, OOZIE-2041-09.patch, OOZIE-2041-10.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936207#comment-15936207
]
Peter Cseh commented on OOZIE-2041:
---
Thanks for the rebase [~abhishekbafna]!
+1
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch,
> OOZIE-2041-08.patch, OOZIE-2041-09.patch, OOZIE-2041-10.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936148#comment-15936148
]
Peter Cseh commented on OOZIE-2041:
---
[~abhishekbafna], could you rebase the patch?
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch,
> OOZIE-2041-08.patch, OOZIE-2041-09.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852896#comment-15852896
]
Hadoop QA commented on OOZIE-2041:
--
Testing JIRA OOZIE-2041
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
.{color:red}WARNING: the current HEAD has 1 RAT warning(s), they should be
addressed ASAP{color}
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:orange}0{color} There are [1] new bugs found in total that would be nice
to have fixed.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:orange}0{color} There are [1] new bugs found in [client] that would
be nice to have fixed.
.You can find the FindBugs diff here: client/findbugs-new.html
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1873
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3616/
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch,
> OOZIE-2041-08.patch, OOZIE-2041-09.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837221#comment-15837221
]
Abhishek Bafna commented on OOZIE-2041:
---
[~rohini] Can you please take a look? Thanks.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch,
> OOZIE-2041-08.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834775#comment-15834775
]
Abhishek Bafna commented on OOZIE-2041:
---
[~gezapeti] :) I got your point and typo. Thanks a lot.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834705#comment-15834705
]
Peter Cseh commented on OOZIE-2041:
---
I think I don't understand the documentation.
If I want to purge all my wfs, coord jobs and bundles older that 7 days, which
one of the following commands is the correct?
#{{oozie admin purge wf=7,bundle=7,coord=7 }}
#{{oozie admin purge wf=7,bundle=6,coord=7 }}
1 or 2?
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834696#comment-15834696
]
Abhishek Bafna commented on OOZIE-2041:
---
Thanks [~asasvari] for looking into the patch.
For the typo, It should be {{"bundle records (bundle=6) older than 7 days."}},
which was correct in earlier patches I think.
For the validation, I will create a ValidationUtil class into oozie-client
module, oozie-core have access to it and then will reuse the same. This class
can be used in future for adding more validation checks.
Thanks.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834672#comment-15834672
]
Attila Sasvari commented on OOZIE-2041:
---
[~abhishekbafna] thanks for reuploading the patch
Regarding the typo
{quote}
Purge command will delete the workflow records (wf=30) older than 30 days,
coordinator records (coord=7) older than 7 days and
bundle records (bundle=6) older then 7 days. The limit (limit=10) defines,
number of records to be fetch at a time. Turn
(oldCoordAction=true/false) =on/off= coordinator action record purging for long
running coordinators. If any of the parameter is
{quote}
Look at the description
* "workflow records (wf=30) older than 30 days" ,
* "(coord=7) older than 7 days",
* "(bundle=6) older then 7 days"
The last two are not consistent. That's why I think you wanted to write
"(bundle=*7*) older then 7 days"
Regarding validation
* in my opinion, doing the validation at the client side (using CLI) would
provide faster feedback to the user and put less pressure on the server (i.e.
it is not needed to send over the request to the server in case of an invalid
input). Sure, the request is validated on server side, but I only see
advantages to do this validation redundantly. Anyway, it is just a suggestion,
we can create a follow up jira or something.
Regarding CLI - I did not face issues.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832896#comment-15832896
]
Hadoop QA commented on OOZIE-2041:
--
Testing JIRA OOZIE-2041
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:orange}0{color} There are [1] new bugs found in total that would be nice
to have fixed.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:orange}0{color} There are [1] new bugs found in [client] that would
be nice to have fixed.
.You can find the FindBugs diff here: client/findbugs-new.html
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1842
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3562/
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch, OOZIE-2041-07.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828494#comment-15828494
]
Hadoop QA commented on OOZIE-2041:
--
Testing JIRA OOZIE-2041
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:orange}0{color} There are [1] new bugs found in total that would be nice
to have fixed.
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:orange}0{color} There are [1] new bugs found in [client] that would
be nice to have fixed.
.You can find the FindBugs diff here: client/findbugs-new.html
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1842
.Tests failed: 5
.Tests errors: 0
.The patch failed the following testcases:
.
testMemoryUsageAndSpeed(org.apache.oozie.service.TestPartitionDependencyManagerEhcache)
.
testNone(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommand)
.
testCoordActionRecoveryServiceForWaiting(org.apache.oozie.service.TestRecoveryService)
.
testNone(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommandNonUTC)
.
testBundleStatusTransitWithLock(org.apache.oozie.service.TestStatusTransitService)
.Tests failing with errors:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3553/
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823294#comment-15823294
]
Attila Sasvari commented on OOZIE-2041:
---
[~abhishekbafna] Thanks for the updated patch! Could you please re-upload the
patch to re-trigger jenkins QA job?
Some "Nit" comments:
* In {{schedulePurgeCommand}} you do not the {{else}} clause if you throw an
exception in the {{if}} part.
* Typo in the documentation: "bundle records (bundle=6) older than 7 days."
* In {{OozieClient}}, you could add some parameter validation like this
{code}
Integer wf = Ints.tryParse(workflowAge);
checkArgument( wf != null && wf.intValue() > 0, "wf must be a positive
number, found: '%s'.", workflowAge);
{code}
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch, OOZIE-2041-06.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818382#comment-15818382
]
Attila Sasvari commented on OOZIE-2041:
---
Thanks [~abhishekbafna].
Some comments (most of them are minor):
In {{OozieCLI}}
- mention that parameters for the purge command are in days
In {{public String purgeCommand(String purgeOptions) throws
OozieClientException}}
- you could use {{Preconditions.checkNotNull}} from
{{com.google.common.base.Preconditions}} instead of the null check as a first
step.
- I believe using empty strings would better than using null Strings.
- Can you remove the commented out code in {{doPut}} {{setOozieMode}}
//Services.get().setSafeMode(safeMode);
- It would make sense to do some more validation here. For example we could
catch at the client side if invalid option is given (not a positive integer).
In {{schedulePurgeCommand}}
- I would start with
{code}
if (!ConfigurationService.getBoolean(PurgeService.PURGE_COMMAND_ENABLED) {
LOG.warn(purgeCmdDisabledMsg);
throw new XServletException(HttpServletResponse.SC_BAD_REQUEST,
ErrorCode.E0307, purgeCmdDisabledMsg);
}
...
String wfAgeStr = request.getParameter(RestConstants.PURGE_WF_AGE);
{code}
This would make cleaner i believe. If it is not an option please move
purgeCmdDisabledMsg declaration and initialization closer to where it is used.
- purgeCmdDisabledMsg could be a constant
In {{BaseAdminServlet}}
- update javadoc for {{doPut}} as it is not only used to "Change safemode
state." anymore.
I also plan to play a bit with the oozie cli command.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817955#comment-15817955
]
Peter Cseh commented on OOZIE-2041:
---
At second look, the code in {{V0AdminServlet}} was there earlier too.
Can you remove parts like
{code}System.out.println(modeTag + " " + sysMode);
{code}
Also, why is the change in {{setOozieMode}} methods necessary? I shouldn't be
called with new parameters as far as I can see.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817309#comment-15817309
]
Abhishek Bafna commented on OOZIE-2041:
---
Ping [~satishsaley] [~gezapeti] [~asasvari] [~andras.piros] [~pbacsko]. Can you
please take a look. Thanks.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762016#comment-15762016
]
Hadoop QA commented on OOZIE-2041:
--
Testing JIRA OOZIE-2041
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:orange}0{color} There are [1] new bugs found in total that would be nice
to have fixed.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:orange}0{color} There are [1] new bugs found in [client] that would
be nice to have fixed.
.You can find the FindBugs diff here: client/findbugs-new.html
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1835
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3518/
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch,
> OOZIE-2041-05.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761668#comment-15761668
]
Abhishek Bafna commented on OOZIE-2041:
---
bq. The most important FindBugs errors are: At OozieClient.java:[line 2216]:
Found reliance on default encoding in
org.apache.oozie.client.OozieClient$PurgeCommand.call(HttpURLConnection): new
java.io.InputStreamReader(InputStream)
This is for the code:
{code}
Reader reader = new InputStreamReader(conn.getInputStream());
{code}
should be:
{code}
Reader reader = new InputStreamReader(conn.getInputStream(),
StandardCharsets.UTF_8);
{code}
Same should be done at many places in the class. Thanks.
cc: [~rkanter]
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761484#comment-15761484
]
Hadoop QA commented on OOZIE-2041:
--
Testing JIRA OOZIE-2041
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that
must be fixed.
.{color:green}+1{color} There are no new bugs found in [server].
.{color:red}-1{color} There are [1] new bugs found below threshold in
[client] that must be fixed.
.You can find the FindBugs diff here (look for the red and orange ones):
client/findbugs-new.html
.The most important FindBugs errors are:
.At OozieClient.java:[line 2216]: Found reliance on default encoding in
org.apache.oozie.client.OozieClient$PurgeCommand.call(HttpURLConnection): new
java.io.InputStreamReader(InputStream)
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1835
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3517/
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch, OOZIE-2041-04.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517970#comment-15517970
]
Hadoop QA commented on OOZIE-2041:
--
Testing JIRA OOZIE-2041
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1812
.Tests failed: 0
.Tests errors: 1
.The patch failed the following testcases:
.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3326/
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517417#comment-15517417
]
Abhishek Bafna commented on OOZIE-2041:
---
Yes [~rkanter]. The first option should work out of the box in a Oozie HA
setup. As we configure ZK related extras services like {{ZKLocksService}}.
{{ZKLocksService}} extends {{MemoryLocksService}} and only
{{MemoryLocksService}} have the implementation for {{Class
getInterface();}}. Removed the extra leader check. Also, added the
documentation for REST API. Thanks for your feedback.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch, OOZIE-2041-03.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507857#comment-15507857
]
Robert Kanter commented on OOZIE-2041:
--
I haven't looked through the patch yet, but I think for HA, we shouldn't put
the burden on the user to pick the current leader server because we don't
currently disclose which server is the leader. Even if they knew the leader
address, they'd have to temporarily change their Oozie client from the load
balancer address to the leader address, which is annoying.
I think we should do one of the following:
# Any Oozie Server can run the purge command when triggered from the CLI. The
{{PurgeXCommand}} should be acquiring a ZK-based lock, so that doesn't seem
like it should be problematic. The only reason we currently have only the
leader run the recurring purge is so that we don't run it more often than
expected.
# The Oozie Server receiving the call from the CLI will forward it to the
leader.
I like option 1 better than option 2.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500607#comment-15500607
]
Abhishek Bafna commented on OOZIE-2041:
---
[~gezapeti] Thanks for the feedback. Updated the patch with your suggestions.
I will fix the below error.
{code}
-1 the patch contains 1 line(s) longer than 132 characters
{code}
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500598#comment-15500598
]
Hadoop QA commented on OOZIE-2041:
--
Testing JIRA OOZIE-2041
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1808
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3290/
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch,
> OOZIE-2041-02.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499834#comment-15499834
]
Hadoop QA commented on OOZIE-2041:
--
Testing JIRA OOZIE-2041
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1808
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
.
testCoord_throwException(org.apache.oozie.command.coord.TestCoordChangeXCommand)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3289/
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499798#comment-15499798
]
Peter Cseh commented on OOZIE-2041:
---
Thank you for working on this [~abhishekbafna]! I've left some minor comments
on RB.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Attachments: OOZIE-2041-00.patch, OOZIE-2041-01.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439324#comment-15439324
]
Hadoop QA commented on OOZIE-2041:
--
Testing JIRA OOZIE-2041
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1802
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3245/
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
> Attachments: OOZIE-2041-00.patch
>
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438942#comment-15438942
]
Abhishek Bafna commented on OOZIE-2041:
---
By default {{PurgeService}} executes every hour to clean up old oozie
workflows, coordinators and bundles from Oozie DB. With the new {{oozie admin
-purge wf=1\;coord=2\;bundle=3\;limit=100\;oldCoordAction=true/false>}}
command, users (admin users) can execute {{PurgeService}} on demand.
# Allow users to specify older than values for (workflow, coordinator and
bundle) in {{days}}, limit and turn {{on/off}} for old coordinator actions. At
least one parameter needs to be specified.
# If user does not specify one of parameter than {{PurgeService}} will use the
default value of it from {{oozie-default.xml}} or {{oozie-site.xml}}.
# The execution of the Purge Command will require a lock for execution, so at
the same time two {{PurgeXCommand}} will not execute. In the case, when lock is
not acquired, it will queue the command.
# Currently purge command is implemented as blocking command. Users will need
to wait until command execution completes.
# In the HA mode, purge command can be executed only on the leader Oozie server.
# purge command can be enabled/disabled using
{{oozie.service.PurgeService.enable.command.line}} property. By default it is
enabled.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>Assignee: Abhishek Bafna
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437107#comment-15437107
]
Robert Kanter commented on OOZIE-2041:
--
Sure. It's currently Unassigned. Go ahead.
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2041) Add an admin command to run the PurgeXCommand
[
https://issues.apache.org/jira/browse/OOZIE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436684#comment-15436684
]
Abhishek Bafna commented on OOZIE-2041:
---
[~rkanter] Can I take up this issue?
> Add an admin command to run the PurgeXCommand
> -
>
> Key: OOZIE-2041
> URL: https://issues.apache.org/jira/browse/OOZIE-2041
> Project: Oozie
> Issue Type: New Feature
> Components: core
>Affects Versions: trunk
>Reporter: Robert Kanter
>
> Some users may find it useful to be able to run the PurgeXCommand on-demand.
> We can add a new admin command to run this. e.g.
> {noformat}
> oozie admin -purge
> {noformat}
> With no args, it can use the "older than" values from oozie-site, but we
> could have it take some arguments to override those for the command.
> Another thing to worry about is making sure that we don't run this if either
> it's already running (i.e. the user sent it twice) or if the scheduled
> PurgeService is already running it. On top of that, we may need extra
> consideration for HA setups where we currently only run it on the leader.
> We should probably also have a to not schedule the PurgeService in ooize-site
> for users who only want to run it manually.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
