Re: Very simple first patch
On 14/11/2014 Michal Hriň wrote: http://people.apache.org/~hrin/dejavu/ Thanks! I tried to avoid to download whole trunk. I tried this on release because I want to know if the build is my problem or others. svn diff can't be made without svn co, right? But this is my problem. Yes, you need an svn checkout to make a svn diff (or git equivalent). Yop, :) sorry. I overseen the same file, but in .zip archive. I may change it. Well, let's get your patch in. Just attach it to an issue, assign the issue to me (so that I don't overlook it) and I can take care of testing that OpenOffice still builds and works fine with the patch (and I definitely expect it to work without problems). Regards, Andrea. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Very simple first patch
On 14.11.2014 01:04, Kay Schenk wrote: On 11/13/2014 03:10 PM, Andrea Pescetti wrote: On 13/11/2014 Michal Hriň wrote: [...] It is a update of external package :) And here is a problem, but it doesn't depend on you. Policy so far has been: we download build-time dependencies from the Extensions site and from Apache Extras. Can we get a memory refresher on why we can't use the svn versions of these external sources directly? David Fisher wrote in [1] that he removed them because fallback urls to svn are now removed as per Infra policy. I guess the revision control server that is so very critical to so many ASF projects should not be impeded by the download of such large third-party tarballs. [1] http://svn.apache.org/viewvc?view=revisionrevision=r1377529 [...] It seems like the testing from the new SourceForge are is going pretty well... http://markmail.org/message/4p3klhqkkvszmwav Maybe time for some additional testing from: http://sourceforge.net/projects/oooextras.mirror/files/ I'll make local changes and test with this as new OOO_EXTRAS area. Who would have rights to update these files on SF? The sourceforge ooextras.mirror project currently has only one administrator [2]. [2] https://sourceforge.net/u/sf-editor1/ Herbert - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Very simple first patch
Dňa 14.11.2014 o 00:10 Andrea Pescetti napísal(a): On 13/11/2014 Michal Hriň wrote: I made very simple patch. http://people.apache.org/~hrin/dejavu/ Looks quite correct. The normal way would be to open an issue of type PATCH and attach your patch. Make just one .patch file, obtained with svn diff or git diff. And don't forget to send the link here to connect it to this discussion. Thanks! I tried to avoid to download whole trunk. I tried this on release because I want to know if the build is my problem or others. svn diff can't be made without svn co, right? But this is my problem. Please review, and feel free to add it to trunk if it will be good. And add comments if I'm doing something wrong. I didn't test it yet, but I would only double-check that replacing the ZIP file with a tar.gz archive does not require other changes. The rest looks good. Yop, :) sorry. I overseen the same file, but in .zip archive. I may change it. It is a update of external package :) And here is a problem, but it doesn't depend on you. Policy so far has been: we download build-time dependencies from the Extensions site and from Apache Extras. If Apache Extras (currently part of Google Code) do not allow us to upload files any longer, then this is the first occurrence of a problem that we have largely anticipated but not solved yet. This shouldn't stop us from updating libraries, but for sure we (the entire Apache Foundation, not OpenOffice only) must find a viable replacement before the next release. Regards, Andrea. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Very simple first patch
On Fri, Nov 14, 2014 at 12:08 AM, Herbert Duerr h...@apache.org wrote: On 14.11.2014 01:04, Kay Schenk wrote: On 11/13/2014 03:10 PM, Andrea Pescetti wrote: On 13/11/2014 Michal Hriň wrote: [...] It is a update of external package :) And here is a problem, but it doesn't depend on you. Policy so far has been: we download build-time dependencies from the Extensions site and from Apache Extras. Can we get a memory refresher on why we can't use the svn versions of these external sources directly? David Fisher wrote in [1] that he removed them because fallback urls to svn are now removed as per Infra policy. I guess the revision control server that is so very critical to so many ASF projects should not be impeded by the download of such large third-party tarballs. [1] http://svn.apache.org/viewvc?view=revisionrevision=r1377529 [...] It seems like the testing from the new SourceForge are is going pretty well... http://markmail.org/message/4p3klhqkkvszmwav Maybe time for some additional testing from: http://sourceforge.net/projects/oooextras.mirror/files/ I'll make local changes and test with this as new OOO_EXTRAS area. Who would have rights to update these files on SF? The sourceforge ooextras.mirror project currently has only one administrator [2]. [2] https://sourceforge.net/u/sf-editor1/ Herbert Thanks for the info... -- - MzK One must still have chaos in oneself to be able to give birth to a dancing star. -- Friedrich Nietzsche
Very simple first patch
Hi, I made very simple patch. http://people.apache.org/~hrin/dejavu/ Please review, and feel free to add it to trunk if it will be good. And add comments if I'm doing something wrong. It is a update of external package :) Regards, Hriň - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Very simple first patch
On 13/11/2014 Michal Hriň wrote: I made very simple patch. http://people.apache.org/~hrin/dejavu/ Looks quite correct. The normal way would be to open an issue of type PATCH and attach your patch. Make just one .patch file, obtained with svn diff or git diff. And don't forget to send the link here to connect it to this discussion. Please review, and feel free to add it to trunk if it will be good. And add comments if I'm doing something wrong. I didn't test it yet, but I would only double-check that replacing the ZIP file with a tar.gz archive does not require other changes. The rest looks good. It is a update of external package :) And here is a problem, but it doesn't depend on you. Policy so far has been: we download build-time dependencies from the Extensions site and from Apache Extras. If Apache Extras (currently part of Google Code) do not allow us to upload files any longer, then this is the first occurrence of a problem that we have largely anticipated but not solved yet. This shouldn't stop us from updating libraries, but for sure we (the entire Apache Foundation, not OpenOffice only) must find a viable replacement before the next release. Regards, Andrea. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Very simple first patch
On 11/13/2014 03:10 PM, Andrea Pescetti wrote: On 13/11/2014 Michal Hriň wrote: I made very simple patch. http://people.apache.org/~hrin/dejavu/ Looks quite correct. The normal way would be to open an issue of type PATCH and attach your patch. Make just one .patch file, obtained with svn diff or git diff. And don't forget to send the link here to connect it to this discussion. Please review, and feel free to add it to trunk if it will be good. And add comments if I'm doing something wrong. I didn't test it yet, but I would only double-check that replacing the ZIP file with a tar.gz archive does not require other changes. The rest looks good. It is a update of external package :) And here is a problem, but it doesn't depend on you. Policy so far has been: we download build-time dependencies from the Extensions site and from Apache Extras. Can we get a memory refresher on why we can't use the svn versions of these external sources directly? See: http://svn.apache.org/viewvc/openoffice/trunk/ext_sources/ There's this message in /main/external_deps.lst ... # Must not fallback to svn # SVN_TRUNK=http://svn.apache.org/repos/asf/!svn/bc/1336449/incubator/ooo/trunk/ext_sources/ If Apache Extras (currently part of Google Code) do not allow us to upload files any longer, then this is the first occurrence of a problem that we have largely anticipated but not solved yet. This shouldn't stop us from updating libraries, but for sure we (the entire Apache Foundation, not OpenOffice only) must find a viable replacement before the next release. Regards, Andrea. It seems like the testing from the new SourceForge are is going pretty well... http://markmail.org/message/4p3klhqkkvszmwav Maybe time for some additional testing from: http://sourceforge.net/projects/oooextras.mirror/files/ I'll make local changes and test with this as new OOO_EXTRAS area. Who would have rights to update these files on SF? -- - MzK One must still have chaos in oneself to be able to give birth to a dancing star. -- Friedrich Nietzsche - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
