[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394675#comment-16394675
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826471 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826471 ]

PDFBOX-4071: remove @throws declaration where exception will not be thrown

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to normal : PDFBox-trunk » Apache PDFBox #3903

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to normal : PDFBox-trunk #3903

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394672#comment-16394672
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826470 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826470 ]

PDFBOX-4071: handle SecurityException for FileWriter too

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[JIRA]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394660#comment-16394660
 ] 

Andreas Lehmkühler commented on PDFBOX-4071:


bq. Shouldn't the line File file = getDiskCacheFile(); be within the try as 
getDiskCacheFile() is the method which might throw a SecurityException
Yes, but the other line has to remain within try/catch as  {{new FileWriter}} 
might throw that exception as well

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[Maruan Sahyoun (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394653#comment-16394653
 ] 

Maruan Sahyoun commented on PDFBOX-4071:


I've reinstated the {{throws IOException}} declaration as other parts depend on 
that specially {{preflight}}. We should review if the conditions are really 
ever met.

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394651#comment-16394651
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826463 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826463 ]

PDFBOX-4071: reinstate @throws declaration because of dependencies; needs review

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Build failed in Jenkins: PDFBox-trunk #3902

[Apache Jenkins Server]

See 


Changes:

[msahyoun] PDFBOX-4071: remove @throws declaration where exception will not be 
thrown

[msahyoun] PDFBOX-4071: remove @throws declaration where exception will not be 
thrown

[msahyoun] PDFBOX-4071, PDFBOX-4134: use Float.compare, use BigDecimal.valueOf

--
[...truncated 37.01 KB...]
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec - in 
org.apache.xmpbox.type.TestVersionType
Running org.apache.xmpbox.type.TestAbstractStructuredType
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in 
org.apache.xmpbox.type.TestAbstractStructuredType
Running org.apache.xmpbox.type.TestResourceEventType
Tests run: 42, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.062 sec - in 
org.apache.xmpbox.type.TestResourceEventType
Running org.apache.xmpbox.type.AttributeTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in 
org.apache.xmpbox.type.AttributeTest
Running org.apache.xmpbox.type.TestDerivedType
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec - in 
org.apache.xmpbox.type.TestDerivedType
Running org.apache.xmpbox.type.TestThumbnailType
Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.035 sec - in 
org.apache.xmpbox.type.TestThumbnailType
Running org.apache.xmpbox.SaveMetadataHelperTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in 
org.apache.xmpbox.SaveMetadataHelperTest
Running org.apache.xmpbox.parser.DeserializationTest
Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.061 sec - in 
org.apache.xmpbox.parser.DeserializationTest
Running org.apache.xmpbox.schema.PDFAIdentificationTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in 
org.apache.xmpbox.schema.PDFAIdentificationTest
Running org.apache.xmpbox.schema.XMPMediaManagementTest
Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 sec - in 
org.apache.xmpbox.schema.XMPMediaManagementTest
Running org.apache.xmpbox.schema.XMPBasicTest
Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec - in 
org.apache.xmpbox.schema.XMPBasicTest
Running org.apache.xmpbox.schema.PDFAIdentificationOthersTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in 
org.apache.xmpbox.schema.PDFAIdentificationOthersTest
Running org.apache.xmpbox.schema.XmpRightsSchemaTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec - in 
org.apache.xmpbox.schema.XmpRightsSchemaTest
Running org.apache.xmpbox.schema.BasicJobTicketSchemaTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.033 sec - in 
org.apache.xmpbox.schema.BasicJobTicketSchemaTest
Running org.apache.xmpbox.schema.AdobePDFTest
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in 
org.apache.xmpbox.schema.AdobePDFTest
Running org.apache.xmpbox.schema.XMPSchemaTest
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in 
org.apache.xmpbox.schema.XMPSchemaTest
Running org.apache.xmpbox.schema.PhotoshopSchemaTest
Tests run: 162, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.177 sec - 
in org.apache.xmpbox.schema.PhotoshopSchemaTest
Running org.apache.xmpbox.schema.AdobePDFErrorsTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in 
org.apache.xmpbox.schema.AdobePDFErrorsTest
Running org.apache.xmpbox.schema.DublinCoreTest
Tests run: 108, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.104 sec - 
in org.apache.xmpbox.schema.DublinCoreTest
Running org.apache.xmpbox.schema.TestExifXmp
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in 
org.apache.xmpbox.schema.TestExifXmp
Running org.apache.xmpbox.XMPMetaDataTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec - in 
org.apache.xmpbox.XMPMetaDataTest
Running org.apache.xmpbox.TestValidatePermitedMetadata
Tests run: 167, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.098 sec - 
in org.apache.xmpbox.TestValidatePermitedMetadata
Running org.apache.xmpbox.DateConverterTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in 
org.apache.xmpbox.DateConverterTest

Results :

Tests run: 810, Failures: 0, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] --- animal-sniffer-maven-plugin:1.15:check (check-java-version) @ xmpbox 
---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java17:1.0
[INFO] 
[INFO] --- maven-bundle-plugin:3.5.0:bundle (default-bundle) @ xmpbox ---
[INFO] 
[INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ xmpbox 
---
[INFO] 
[INFO] >>> maven-source-plugin:2.3:jar (attach-sources) > generate-sources @ 
xmpbox >>>
[WARNING] Failed to getClass for org.apache.maven.plugin.source.SourceJarMojo
[INFO] 
[INFO] 

Build failed in Jenkins: PDFBox-trunk » Apache PDFBox #3902

[Apache Jenkins Server]

See 


Changes:

[msahyoun] PDFBOX-4071: remove @throws declaration where exception will not be 
thrown

[msahyoun] PDFBOX-4071: remove @throws declaration where exception will not be 
thrown

[msahyoun] PDFBOX-4071, PDFBOX-4134: use Float.compare, use BigDecimal.valueOf

--
[INFO] 
[INFO] 
[INFO] Building Apache PDFBox 3.0.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ pdfbox ---
[TASKS] Scanning folder 
' for 
files matching the pattern '**/*.java' - excludes: 
[TASKS] Found 691 files to scan for tasks
Found 232 open tasks.
[TASKS] Computing warning deltas based on reference build #3901
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ pdfbox ---
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ pdfbox ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 21 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ pdfbox ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 592 source files to 

[INFO] -
[WARNING] COMPILATION WARNING : 
[INFO] -
[WARNING] bootstrap class path not set in conjunction with -source 1.7
[WARNING] 
:[310,27]
 getHeight(int) in org.apache.pdfbox.pdmodel.font.PDFontLike has been deprecated
[WARNING] 
:[297,27]
 getHeight(int) in org.apache.pdfbox.pdmodel.font.PDFontLike has been deprecated
[WARNING] 
:[100,19]
 getUnicodeCmap() in org.apache.fontbox.ttf.TrueTypeFont has been deprecated
[WARNING] 
:
 Some input files use unchecked or unsafe operations.
[WARNING] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 6 warnings 
[INFO] -
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
:[284,7]
 exception java.io.IOException is never thrown in body of corresponding try 
statement
[INFO] 1 error
[INFO] -

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394647#comment-16394647
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826460 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826460 ]

PDFBOX-4071: remove @throws declaration where exception will not be thrown

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394644#comment-16394644
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826459 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826459 ]

PDFBOX-4071: remove @throws declaration where exception will not be thrown

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4134) Resolve floating point comparisons flagged by Sonar

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394635#comment-16394635
 ] 

ASF subversion and git services commented on PDFBOX-4134:
-

Commit 1826458 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826458 ]

PDFBOX-4071, PDFBOX-4134: use Float.compare, use BigDecimal.valueOf

> Resolve floating point comparisons flagged by Sonar
> ---
>
> Key: PDFBOX-4134
> URL: https://issues.apache.org/jira/browse/PDFBOX-4134
> Project: PDFBox
>  Issue Type: Sub-task
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Fix For: 3.0.0 PDFBox
>
>
> Sonar is flagging floating point comparisons which are done using comparison 
> operators. Using {{Float.compare}} this can be done in a standards way. In 
> addition some comparisons might be done using a distance between two values.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394633#comment-16394633
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826458 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826458 ]

PDFBOX-4071, PDFBOX-4134: use Float.compare, use BigDecimal.valueOf

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4134) Resolve floating point comparisons flagged by Sonar

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394621#comment-16394621
 ] 

ASF subversion and git services commented on PDFBOX-4134:
-

Commit 1826457 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826457 ]

PDFBOX-4134: use Float.compare

> Resolve floating point comparisons flagged by Sonar
> ---
>
> Key: PDFBOX-4134
> URL: https://issues.apache.org/jira/browse/PDFBOX-4134
> Project: PDFBox
>  Issue Type: Sub-task
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Fix For: 3.0.0 PDFBox
>
>
> Sonar is flagging floating point comparisons which are done using comparison 
> operators. Using {{Float.compare}} this can be done in a standards way. In 
> addition some comparisons might be done using a distance between two values.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394614#comment-16394614
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826456 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826456 ]

PDFBOX-4071: use try-with

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to normal : PDFBox-trunk » Apache PDFBox examples #3900

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to normal : PDFBox-trunk #3900

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to stable : PDFBox-Trunk-jdk9 #360

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to stable : PDFBox-Trunk-jdk9 » Apache PDFBox examples #360

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394606#comment-16394606
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826453 from [~msahyoun] in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1826453 ]

PDFBOX-4071: move getDiskCacheFile into try statement as this will potentially 
cause the SecurityException

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394604#comment-16394604
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826452 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826452 ]

PDFBOX-4071: move getDiskCacheFile into try statement as this will potentially 
cause the SecurityException

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394599#comment-16394599
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826449 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826449 ]

PDFBOX-4071: revert use of JDK7 try-with; doesn't work well with detached 
signature and others

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build became unstable: PDFBox-Trunk-jdk9 #359

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build became unstable: PDFBox-Trunk-jdk9 » Apache PDFBox examples #359

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Build failed in Jenkins: PDFBox-trunk » Apache PDFBox examples #3898

[Apache Jenkins Server]

See 


--
Established TCP socket on 35302
maven35-agent.jar already up to date
maven35-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=300m; 
support was removed in 8.0
<===[JENKINS REMOTING CAPACITY]===>   channel started
Executing Maven:  -N -B 
-Dmaven.repo.local=/home/jenkins/jenkins-slave/maven-repositories/1 -f 

 clean deploy -Ppedantic -Dskip-bavaria=false
java.lang.NullPointerException
at jenkins.maven3.agent.Maven33Main.launch(Maven33Main.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:139)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Started by user tilman
Finished: ABORTED
FATAL: java.lang.reflect.InvocationTargetException
java.lang.NullPointerException
at jenkins.maven3.agent.Maven33Main.launch(Maven33Main.java:176)
Caused: java.lang.Exception
at jenkins.maven3.agent.Maven33Main.launch(Maven33Main.java:179)
Caused: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:139)
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to Channel to 
Maven [/home/jenkins/tools/java/jdk1.8.0_66-unlimited-security/bin/java, 
-Xmx1g, -XX:MaxPermSize=300m, -cp, 
/home/jenkins/jenkins-slave/maven35-agent.jar:/home/jenkins/tools/maven/apache-maven-3.5.0/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.5.0/conf/logging,
 jenkins.maven3.agent.Maven35Main, 
/home/jenkins/tools/maven/apache-maven-3.5.0, 
/home/jenkins/jenkins-slave/slave.jar, 
/home/jenkins/jenkins-slave/maven35-interceptor.jar, 
/home/jenkins/jenkins-slave/maven3-interceptor-commons.jar, 35302]
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at 
hudson.maven.ProcessCache$MavenProcess.call(ProcessCache.java:161)
at 
hudson.maven.MavenBuild$MavenBuildExecution.doRun(MavenBuild.java:912)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:504)
at hudson.model.Run.execute(Run.java:1724)
at hudson.maven.MavenBuild.run(MavenBuild.java:275)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused: java.io.IOException
at hudson.maven.Maven3Builder.call(Maven3Builder.java:179)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[Tilman Hausherr (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394590#comment-16394590
 ] 

Tilman Hausherr commented on PDFBOX-4071:
-

I agree that {{getDiscCacheFile()}} might throw a {{SecurityException}}. I 
wonder why Simon didn't get hit by it in PDFBOX-3520. Yeah, change it.

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build became unstable: PDFBox-trunk #3897

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build became unstable: PDFBox-trunk » Apache PDFBox examples #3897

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Comment Edited] (PDFBOX-4071) Improve code quality (3)

[Maruan Sahyoun (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394589#comment-16394589
 ] 

Maruan Sahyoun edited comment on PDFBOX-4071 at 3/11/18 6:08 PM:
-

[~tilman] [~lehmi] Could you take a look at the following code from 
{{FileSystemProvide}} L296

{code}
File file = getDiskCacheFile();
try
{
writer = new BufferedWriter(new FileWriter(file));
}
catch (SecurityException e)
{
LOG.debug("Couldn't create writer for " + 
file.getAbsolutePath(), e);
return;
}
{code}

Shouldn't the line {{File file = getDiskCacheFile();}} be within the {{try}} as 
{{getDiskCacheFile()}} is the method which might throw a {{SecurityException}}

Would change it and also use {{try-with}} but haven't dealt with this part of 
the code before.  If you agree we should add that to {{2.0.9}} (without the 
{{try-with}} part obviously).

There is another call to {{getDiscCacheFile()}} at L381 which will be affected 
too


was (Author: msahyoun):
[~tilman] [~lehmi] Could you take a look at the following code from 
{{FileSystemProvide}} L296

{code}
File file = getDiskCacheFile();
try
{
writer = new BufferedWriter(new FileWriter(file));
}
catch (SecurityException e)
{
LOG.debug("Couldn't create writer for " + 
file.getAbsolutePath(), e);
return;
}
{code}

Shouldn't the line {{File file = getDiskCacheFile();}} be within the {{try}} as 
{{getDiskCacheFile()}} is the method which might throw a {{SecurityException}}

Would change it and also use {{try-with}} but haven't dealt with this part of 
the code before.  If you agree we should add that to {{2.0.9}} (without the 
{{try-with}} part obviously)

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[Maruan Sahyoun (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394589#comment-16394589
 ] 

Maruan Sahyoun commented on PDFBOX-4071:


[~tilman] [~lehmi] Could you take a look at the following code from 
{{FileSystemProvide}} L296

{code}
File file = getDiskCacheFile();
try
{
writer = new BufferedWriter(new FileWriter(file));
}
catch (SecurityException e)
{
LOG.debug("Couldn't create writer for " + 
file.getAbsolutePath(), e);
return;
}
{code}

Shouldn't the line {{File file = getDiskCacheFile();}} be within the {{try}} as 
{{getDiskCacheFile()}} is the method which might throw a {{SecurityException}}

Would change it and also use {{try-with}} but haven't dealt with this part of 
the code before.  If you agree we should add that to {{2.0.9}} (without the 
{{try-with}} part obviously)

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394586#comment-16394586
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826447 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826447 ]

PDFBOX-4071: use JDK7 try-with

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Comment Edited] (PDFBOX-4149) PDF consisting on one page with 5 MB renders until the end of time using renderImageWithDPI

[Tilman Hausherr (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394573#comment-16394573
 ] 

Tilman Hausherr edited comment on PDFBOX-4149 at 3/11/18 5:05 PM:
--

There is some hope to get the total time down a bit... tests with the profiler 
show that the time is lost in several areas. One thing I noticed is that the 
colorspaces are all based on the same ICC colorspace, yet this colorspace is 
created again and again.


was (Author: tilman):
There is some hope to get the total time down a bit... tests with the profiler 
show that the time is lost in several areas. One Thing I noticed is that the 
colorspaces are all based on the same ICC colorspace, yet this colorspace is 
created again and again.

> PDF consisting on one page with 5 MB renders until the end of time using 
> renderImageWithDPI
> ---
>
> Key: PDFBOX-4149
> URL: https://issues.apache.org/jira/browse/PDFBOX-4149
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.8
>Reporter: Christian
>Priority: Major
> Attachments: SB_Flyer_SpargelPromo_03-062018.pdf
>
>
> I am using PDFBOX 2.0.8 on a Java VM 1.8.0_151
> The attached and valid pdf should be rendered by calling
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> But the rendering never ends - the only thing I see is this line repeating 
> very often in the console:
> [Finalizer] DEBUG org.apache.pdfbox.io.ScratchFileBuffer - ScratchFileBuffer 
> not closed!
> Here is the code that is used to open the document and then start the 
> rendering:
> {code:java}
> PDDocument document = PDDocument.load(file, 
> MemoryUsageSetting.setupTempFileOnly());
> try  {
>PDFRenderer pdfRenderer = new PDFRenderer(document);
>int numberOfPages = document.getPages().getCount();
>for (int i = 0; i < numberOfPages; i++) {
>   BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> [...]
> {code}
> The line 
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50); 
> is never passed. I ran a test and have wait for 30 minutes to let it pass, 
> but nothing happens. 
> Please advise what to do and how to solve the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4149) PDF consisting on one page with 5 MB renders until the end of time using renderImageWithDPI

[Tilman Hausherr (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394573#comment-16394573
 ] 

Tilman Hausherr commented on PDFBOX-4149:
-

There is some hope to get the total time down a bit... tests with the profiler 
show that the time is lost in several areas. One Thing I noticed is that the 
colorspaces are all based on the same ICC colorspace, yet this colorspace is 
created again and again.

> PDF consisting on one page with 5 MB renders until the end of time using 
> renderImageWithDPI
> ---
>
> Key: PDFBOX-4149
> URL: https://issues.apache.org/jira/browse/PDFBOX-4149
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.8
>Reporter: Christian
>Priority: Major
> Attachments: SB_Flyer_SpargelPromo_03-062018.pdf
>
>
> I am using PDFBOX 2.0.8 on a Java VM 1.8.0_151
> The attached and valid pdf should be rendered by calling
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> But the rendering never ends - the only thing I see is this line repeating 
> very often in the console:
> [Finalizer] DEBUG org.apache.pdfbox.io.ScratchFileBuffer - ScratchFileBuffer 
> not closed!
> Here is the code that is used to open the document and then start the 
> rendering:
> {code:java}
> PDDocument document = PDDocument.load(file, 
> MemoryUsageSetting.setupTempFileOnly());
> try  {
>PDFRenderer pdfRenderer = new PDFRenderer(document);
>int numberOfPages = document.getPages().getCount();
>for (int i = 0; i < numberOfPages; i++) {
>   BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> [...]
> {code}
> The line 
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50); 
> is never passed. I ran a test and have wait for 30 minutes to let it pass, 
> but nothing happens. 
> Please advise what to do and how to solve the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4146) Patch: Fix for appearance of visible signature

[Martin Mancuska (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394564#comment-16394564
 ] 

Martin Mancuska commented on PDFBOX-4146:
-

Thanks for info. IMHO this patch affects only annotations for visible digital 
signatures. Appearances of other signatures remain untouched.

> Patch: Fix for appearance of visible signature
> --
>
> Key: PDFBOX-4146
> URL: https://issues.apache.org/jira/browse/PDFBOX-4146
> Project: PDFBox
>  Issue Type: Bug
>  Components: Signing
>Affects Versions: 2.0.8
>Reporter: Martin Mancuska
>Priority: Minor
>  Labels: Signature, patch
> Fix For: 2.0.9
>
> Attachments: visible_signature.patch
>
>
> We're using PDFBox (as backend used by Esig DSS) for digital signing of 
> documents. We've found out  that visible signature has different look on Mac 
> Preview app than other PDF viewers. After some investigation we suspect that 
> BBox-es for appearance of signature is not filled correctly by PDFBox. The 
> values are hard coded as [0, 0, 100, 50]. Also transformation matrix for 
> translating from form XObject coordinate system into default one has value 
> (1, 0, 0, 1, 0, 0) -> no scaling between default user coordinate system and 
> form XObject coordinate system.
> Therefore I think that the Mac Preview App draws signature with dimensions 
> 100x50 because no transformation were done.
> I've attached patch which solves this issue for us. The signature is shown 
> correctly in all PDF viewers now. Maybe you can take a look on it and 
> integrate it into your code base, or propose better solution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: PDFBox 2.0.9 release?

[Tilman Hausherr]

Am 11.03.2018 um 16:28 schrieb Andreas Lehmkuehler:

On 03/11/2018 03:54 PM, Tilman Hausherr wrote:

Am 09.03.2018 um 20:09 schrieb Allison, Timothy B.:
I'm happy to run the regression tests again when all final changes 
for 2.0.9-RC1 are made.  I'm really excited to be able to include 
jbig2.  We'll start the Tika release process for 1.18 as soon as 
PDFBox 2.0.9 is available.


I'm done with all changes for 2.0.9 except one that doesn't have 
anything to do with text extraction or parsing.


Andreas, are you working on any issue related to these?
I'm recently working o PDFBOX-4097, it's abouzt repairing encrypted 
object streams, but we don't have to wait for that.
PDFBOX-4084 includes some changes to the parser. Maybe we should run 
the regression test again although I don't expect any issues here.


ok => Tim, please start again

Thanks

Tilman



Andreas


Tilman


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: PDFBox 2.0.9 release?

[Andreas Lehmkuehler]

On 03/11/2018 03:54 PM, Tilman Hausherr wrote:

Am 09.03.2018 um 20:09 schrieb Allison, Timothy B.:
I'm happy to run the regression tests again when all final changes for 
2.0.9-RC1 are made.  I'm really excited to be able to include jbig2.  We'll 
start the Tika release process for 1.18 as soon as PDFBox 2.0.9 is available.


I'm done with all changes for 2.0.9 except one that doesn't have anything to do 
with text extraction or parsing.


Andreas, are you working on any issue related to these?
I'm recently working o PDFBOX-4097, it's abouzt repairing encrypted object 
streams, but we don't have to wait for that.
PDFBOX-4084 includes some changes to the parser. Maybe we should run the 
regression test again although I don't expect any issues here.


Andreas


Tilman


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: PDFBox 2.0.9 release?

[Tilman Hausherr]

Am 09.03.2018 um 20:09 schrieb Allison, Timothy B.:

I'm happy to run the regression tests again when all final changes for 
2.0.9-RC1 are made.  I'm really excited to be able to include jbig2.  We'll 
start the Tika release process for 1.18 as soon as PDFBox 2.0.9 is available.


I'm done with all changes for 2.0.9 except one that doesn't have 
anything to do with text extraction or parsing.


Andreas, are you working on any issue related to these?

Tilman


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394513#comment-16394513
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826443 from [~tilman] in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1826443 ]

PDFBOX-4071: use base class

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394512#comment-16394512
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826442 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826442 ]

PDFBOX-4071: use base class

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394511#comment-16394511
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826441 from [~tilman] in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1826441 ]

PDFBOX-4071: improve javadoc

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394510#comment-16394510
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826440 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826440 ]

PDFBOX-4071: improve javadoc

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394508#comment-16394508
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826439 from [~tilman] in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1826439 ]

PDFBOX-4071: improve javadoc

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4071) Improve code quality (3)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394507#comment-16394507
 ] 

ASF subversion and git services commented on PDFBOX-4071:
-

Commit 1826438 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1826438 ]

PDFBOX-4071: improve javadoc

> Improve code quality (3)
> 
>
> Key: PDFBOX-4071
> URL: https://issues.apache.org/jira/browse/PDFBOX-4071
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.8
>Reporter: Tilman Hausherr
>Priority: Major
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2852, which was getting too long.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4146) Patch: Fix for appearance of visible signature

[Tilman Hausherr (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394503#comment-16394503
 ] 

Tilman Hausherr commented on PDFBOX-4146:
-

This looks good and I tested it with two different images and the resulting PDF 
is shown identically in Adobe Reader and PDFBox than the "created before the 
change" PDF. IMHO it is a bug in Mac Preview. There are some transformations to 
be done when showing annotations and it isn't easy. However I'd like to sleep 
one more night before deciding whether to commit.

> Patch: Fix for appearance of visible signature
> --
>
> Key: PDFBOX-4146
> URL: https://issues.apache.org/jira/browse/PDFBOX-4146
> Project: PDFBox
>  Issue Type: Bug
>  Components: Signing
>Affects Versions: 2.0.8
>Reporter: Martin Mancuska
>Priority: Minor
>  Labels: Signature, patch
> Fix For: 2.0.9
>
> Attachments: visible_signature.patch
>
>
> We're using PDFBox (as backend used by Esig DSS) for digital signing of 
> documents. We've found out  that visible signature has different look on Mac 
> Preview app than other PDF viewers. After some investigation we suspect that 
> BBox-es for appearance of signature is not filled correctly by PDFBox. The 
> values are hard coded as [0, 0, 100, 50]. Also transformation matrix for 
> translating from form XObject coordinate system into default one has value 
> (1, 0, 0, 1, 0, 0) -> no scaling between default user coordinate system and 
> form XObject coordinate system.
> Therefore I think that the Mac Preview App draws signature with dimensions 
> 100x50 because no transformation were done.
> I've attached patch which solves this issue for us. The signature is shown 
> correctly in all PDF viewers now. Maybe you can take a look on it and 
> integrate it into your code base, or propose better solution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: PDFBox 2.0.9 release?

[Andreas Lehmkuehler]

On 03/11/2018 12:31 PM, Tilman Hausherr wrote:

Am 04.03.2018 um 12:50 schrieb Andreas Lehmkuehler:


now that we got the JBIG2 ImageIO out of the door it's time to release a new 
2.0.x version of PDFBox. 


Hello Andreas,

Could you please configure a 2.0.10 target? We might need it.

Done, and btw I made you admin so that I'm no longer the bottle neck

Andreas


Tilman


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: PDFBox 2.0.9 release?

[Tilman Hausherr]

Am 04.03.2018 um 12:50 schrieb Andreas Lehmkuehler:


now that we got the JBIG2 ImageIO out of the door it's time to release 
a new 2.0.x version of PDFBox. 


Hello Andreas,

Could you please configure a 2.0.10 target? We might need it.

Tilman


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Comment Edited] (PDFBOX-4149) PDF consisting on one page with 5 MB renders until the end of time using renderImageWithDPI

[Tilman Hausherr (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394478#comment-16394478
 ] 

Tilman Hausherr edited comment on PDFBOX-4149 at 3/11/18 11:12 AM:
---

165 seconds with the KCMS option on 
[https://pdfbox.apache.org/2.0/getting-started.html] . 136 seconds when using 
the CMYK option. The file has 5223 Images and 3233 colorspaces.


was (Author: tilman):
165 seconds with the KCMS option on 
[https://pdfbox.apache.org/2.0/getting-started.html] . 136 seconds when using 
the CMYK option. The file has 5223 images.

> PDF consisting on one page with 5 MB renders until the end of time using 
> renderImageWithDPI
> ---
>
> Key: PDFBOX-4149
> URL: https://issues.apache.org/jira/browse/PDFBOX-4149
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.8
>Reporter: Christian
>Priority: Major
> Attachments: SB_Flyer_SpargelPromo_03-062018.pdf
>
>
> I am using PDFBOX 2.0.8 on a Java VM 1.8.0_151
> The attached and valid pdf should be rendered by calling
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> But the rendering never ends - the only thing I see is this line repeating 
> very often in the console:
> [Finalizer] DEBUG org.apache.pdfbox.io.ScratchFileBuffer - ScratchFileBuffer 
> not closed!
> Here is the code that is used to open the document and then start the 
> rendering:
> {code:java}
> PDDocument document = PDDocument.load(file, 
> MemoryUsageSetting.setupTempFileOnly());
> try  {
>PDFRenderer pdfRenderer = new PDFRenderer(document);
>int numberOfPages = document.getPages().getCount();
>for (int i = 0; i < numberOfPages; i++) {
>   BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> [...]
> {code}
> The line 
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50); 
> is never passed. I ran a test and have wait for 30 minutes to let it pass, 
> but nothing happens. 
> Please advise what to do and how to solve the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4149) PDF consisting on one page with 5 MB renders until the end of time using renderImageWithDPI

[Tilman Hausherr (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394478#comment-16394478
 ] 

Tilman Hausherr commented on PDFBOX-4149:
-

165 seconds with the KCMS option on 
[https://pdfbox.apache.org/2.0/getting-started.html] . 136 seconds when using 
the CMYK option. The file has 5223 images.

> PDF consisting on one page with 5 MB renders until the end of time using 
> renderImageWithDPI
> ---
>
> Key: PDFBOX-4149
> URL: https://issues.apache.org/jira/browse/PDFBOX-4149
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.8
>Reporter: Christian
>Priority: Major
> Attachments: SB_Flyer_SpargelPromo_03-062018.pdf
>
>
> I am using PDFBOX 2.0.8 on a Java VM 1.8.0_151
> The attached and valid pdf should be rendered by calling
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> But the rendering never ends - the only thing I see is this line repeating 
> very often in the console:
> [Finalizer] DEBUG org.apache.pdfbox.io.ScratchFileBuffer - ScratchFileBuffer 
> not closed!
> Here is the code that is used to open the document and then start the 
> rendering:
> {code:java}
> PDDocument document = PDDocument.load(file, 
> MemoryUsageSetting.setupTempFileOnly());
> try  {
>PDFRenderer pdfRenderer = new PDFRenderer(document);
>int numberOfPages = document.getPages().getCount();
>for (int i = 0; i < numberOfPages; i++) {
>   BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
> [...]
> {code}
> The line 
> BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50); 
> is never passed. I ran a test and have wait for 30 minutes to let it pass, 
> but nothing happens. 
> Please advise what to do and how to solve the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Resolved] (PDFBOX-4084) Can't draw PDFs while ANNOTS is COSStream instead of COSArray

[JIRA]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Lehmkühler resolved PDFBOX-4084.

Resolution: Fixed

> Can't draw PDFs while ANNOTS is COSStream instead of COSArray
> -
>
> Key: PDFBOX-4084
> URL: https://issues.apache.org/jira/browse/PDFBOX-4084
> Project: PDFBox
>  Issue Type: Bug
>  Components: PDModel
>Affects Versions: 2.0.8
>Reporter: Cheng Zhong
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 2.0.9, 3.0.0 PDFBox
>
> Attachments: Benelux Equity Daily-20110321.pdf, TELECOM EQUIPMENT 
> DAILY - 12 AUG 2009.pdf
>
>
> PDFBox would failed to draw the attached document , error logs are below:
> {code:java}
> java.lang.ClassCastException: org.apache.pdfbox.cos.COSStream cannot be cast 
> to org.apache.pdfbox.cos.COSArray
> at org.apache.pdfbox.pdmodel.PDPage.getAnnotations(PDPage.java:661) 
> ~[classes/:?]
> at org.apache.pdfbox.rendering.PageDrawer.drawPage(PageDrawer.java:202) 
> ~[classes/:?]{code}
> This PDF put COSStream as the page's ANNOTS object, and caused the failure.
> Simply do type checks in PDPage.getAnnotations might avoid this issue, but 
> the annotations would lost.
>  
> This PDF show correctly (I mean annotation works) in:
>  * Chrome 63.0.3239.132
>  * Adobe Reader 11.0.23
> This PDF doesn't work perfectly in:
>  * Microsoft Edge
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Issue Comment Deleted] (PDFBOX-4084) Can't draw PDFs while ANNOTS is COSStream instead of COSArray

[JIRA]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Lehmkühler updated PDFBOX-4084:
---
Comment: was deleted

(was: I obviously missed something and got a NPE with PDFBOX-4121. I'm on it)

> Can't draw PDFs while ANNOTS is COSStream instead of COSArray
> -
>
> Key: PDFBOX-4084
> URL: https://issues.apache.org/jira/browse/PDFBOX-4084
> Project: PDFBox
>  Issue Type: Bug
>  Components: PDModel
>Affects Versions: 2.0.8
>Reporter: Cheng Zhong
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 2.0.9, 3.0.0 PDFBox
>
> Attachments: Benelux Equity Daily-20110321.pdf, TELECOM EQUIPMENT 
> DAILY - 12 AUG 2009.pdf
>
>
> PDFBox would failed to draw the attached document , error logs are below:
> {code:java}
> java.lang.ClassCastException: org.apache.pdfbox.cos.COSStream cannot be cast 
> to org.apache.pdfbox.cos.COSArray
> at org.apache.pdfbox.pdmodel.PDPage.getAnnotations(PDPage.java:661) 
> ~[classes/:?]
> at org.apache.pdfbox.rendering.PageDrawer.drawPage(PageDrawer.java:202) 
> ~[classes/:?]{code}
> This PDF put COSStream as the page's ANNOTS object, and caused the failure.
> Simply do type checks in PDPage.getAnnotations might avoid this issue, but 
> the annotations would lost.
>  
> This PDF show correctly (I mean annotation works) in:
>  * Chrome 63.0.3239.132
>  * Adobe Reader 11.0.23
> This PDF doesn't work perfectly in:
>  * Microsoft Edge
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Reopened] (PDFBOX-4084) Can't draw PDFs while ANNOTS is COSStream instead of COSArray

[JIRA]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Lehmkühler reopened PDFBOX-4084:


I obviously missed something and got a NPE with PDFBOX-4121. I'm on it

> Can't draw PDFs while ANNOTS is COSStream instead of COSArray
> -
>
> Key: PDFBOX-4084
> URL: https://issues.apache.org/jira/browse/PDFBOX-4084
> Project: PDFBox
>  Issue Type: Bug
>  Components: PDModel
>Affects Versions: 2.0.8
>Reporter: Cheng Zhong
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 2.0.9, 3.0.0 PDFBox
>
> Attachments: Benelux Equity Daily-20110321.pdf, TELECOM EQUIPMENT 
> DAILY - 12 AUG 2009.pdf
>
>
> PDFBox would failed to draw the attached document , error logs are below:
> {code:java}
> java.lang.ClassCastException: org.apache.pdfbox.cos.COSStream cannot be cast 
> to org.apache.pdfbox.cos.COSArray
> at org.apache.pdfbox.pdmodel.PDPage.getAnnotations(PDPage.java:661) 
> ~[classes/:?]
> at org.apache.pdfbox.rendering.PageDrawer.drawPage(PageDrawer.java:202) 
> ~[classes/:?]{code}
> This PDF put COSStream as the page's ANNOTS object, and caused the failure.
> Simply do type checks in PDPage.getAnnotations might avoid this issue, but 
> the annotations would lost.
>  
> This PDF show correctly (I mean annotation works) in:
>  * Chrome 63.0.3239.132
>  * Adobe Reader 11.0.23
> This PDF doesn't work perfectly in:
>  * Microsoft Edge
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Created] (PDFBOX-4149) PDF consisting on one page with 5 MB renders until the end of time using renderImageWithDPI

[Christian (JIRA)]

Christian created PDFBOX-4149:
-

 Summary: PDF consisting on one page with 5 MB renders until the 
end of time using renderImageWithDPI
 Key: PDFBOX-4149
 URL: https://issues.apache.org/jira/browse/PDFBOX-4149
 Project: PDFBox
  Issue Type: Bug
  Components: Rendering
Affects Versions: 2.0.8
Reporter: Christian
 Attachments: SB_Flyer_SpargelPromo_03-062018.pdf

I am using PDFBOX 2.0.8 on a Java VM 1.8.0_151

The attached and valid pdf should be rendered by calling

BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);

But the rendering never ends - the only thing I see is this line repeating very 
often in the console:

[Finalizer] DEBUG org.apache.pdfbox.io.ScratchFileBuffer - ScratchFileBuffer 
not closed!

Here is the code that is used to open the document and then start the rendering:
{code:java}
PDDocument document = PDDocument.load(file, 
MemoryUsageSetting.setupTempFileOnly());
try  {
   PDFRenderer pdfRenderer = new PDFRenderer(document);
   int numberOfPages = document.getPages().getCount();
   for (int i = 0; i < numberOfPages; i++) {
  BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50);
[...]
{code}

The line 

BufferedImage bim = pdfRenderer.renderImageWithDPI(i, 50); 

is never passed. I ran a test and have wait for 30 minutes to let it pass, but 
nothing happens. 

Please advise what to do and how to solve the issue.





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org