[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[ https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035191#comment-16035191 ] Hudson commented on PHOENIX-2885: - FAILURE: Integrated in Jenkins build Phoenix-master #1637 (See [https://builds.apache.org/job/Phoenix-master/1637/]) PHOENIX-2885 Set default value for UPDATE_CACHE_FREQUENCY (Maddineni (jamestaylor: rev b1d0a8cb14c3055df0c9c9e73bcd473dd7a2b6d4) * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/CreateTableIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java > Set default value for UPDATE_CACHE_FREQUENCY > > > Key: PHOENIX-2885 > URL: https://issues.apache.org/jira/browse/PHOENIX-2885 > Project: Phoenix > Issue Type: Sub-task >Reporter: James Taylor >Assignee: Maddineni Sukumar > Fix For: 4.11.0 > > Attachments: PHOENIX-2885.4.10-HBase-0.98.patch, > PHOENIX-2885.v2.patch, PHOENIX-2885.v3.patch > > > We have the ability currently to tell Phoenix how stale we're will to have > the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when > a table is created, unless explicitly specified, there is no > UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration > parameter to specify a default value when a CREATE TABLE statement is > executed. In addition, when a VIEW is created, we should inherit the > UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly > specified) and then fallback to the new default config value. > [1] https://phoenix.apache.org/language/index.html#options -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[
https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034232#comment-16034232
]
Hadoop QA commented on PHOENIX-2885:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12870922/PHOENIX-2885.v3.patch
against master branch at commit 5fe660537ff28de1738c3e82b65f9a2aac8fc80b.
ATTACHMENT ID: 12870922
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
45 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+props.put(QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
""+defaultUpdateCacheFrequency);
+public static final String DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB =
"phoenix.default.update.cache.frequency";
+QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY);
+QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ClientTimeArithmeticQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SaltedViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RowValueConstructorIT
{color:red}-1 core zombie tests{color}. There are 5 zombie test(s):
at
org.apache.hadoop.hbase.master.TestRollingRestart.testBasicRollingRestart(TestRollingRestart.java:171)
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/976//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/976//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/976//console
This message is automatically generated.
> Set default value for UPDATE_CACHE_FREQUENCY
>
>
> Key: PHOENIX-2885
> URL: https://issues.apache.org/jira/browse/PHOENIX-2885
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Maddineni Sukumar
> Fix For: 4.11.0
>
> Attachments: PHOENIX-2885.4.10-HBase-0.98.patch,
> PHOENIX-2885.v2.patch, PHOENIX-2885.v3.patch
>
>
> We have the ability currently to tell Phoenix how stale we're will to have
> the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when
> a table is created, unless explicitly specified, there is no
> UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration
> parameter to specify a default value when a CREATE TABLE statement is
> executed. In addition, when a VIEW is created, we should inherit the
> UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly
> specified) and then fallback to the new default config value.
> [1] https://phoenix.apache.org/language/index.html#options
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[ https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034129#comment-16034129 ] Maddineni Sukumar commented on PHOENIX-2885: Created patch v3 against latest master. > Set default value for UPDATE_CACHE_FREQUENCY > > > Key: PHOENIX-2885 > URL: https://issues.apache.org/jira/browse/PHOENIX-2885 > Project: Phoenix > Issue Type: Sub-task >Reporter: James Taylor >Assignee: Maddineni Sukumar > Fix For: 4.11.0 > > Attachments: PHOENIX-2885.4.10-HBase-0.98.patch, > PHOENIX-2885.v2.patch, PHOENIX-2885.v3.patch > > > We have the ability currently to tell Phoenix how stale we're will to have > the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when > a table is created, unless explicitly specified, there is no > UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration > parameter to specify a default value when a CREATE TABLE statement is > executed. In addition, when a VIEW is created, we should inherit the > UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly > specified) and then fallback to the new default config value. > [1] https://phoenix.apache.org/language/index.html#options -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[ https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007115#comment-16007115 ] James Taylor commented on PHOENIX-2885: --- Thanks, [~sukuna...@gmail.com] - sorry I missed that priority order in your patch. FWIW, a few good candidates to parameterize would be UpsertValues*IT and UpsertSelect*IT. Probably makes sense to check this patch in *after* PHOENIX-3823, PHOENIX-3209, and PHOENIX-3841, right? > Set default value for UPDATE_CACHE_FREQUENCY > > > Key: PHOENIX-2885 > URL: https://issues.apache.org/jira/browse/PHOENIX-2885 > Project: Phoenix > Issue Type: Sub-task >Reporter: James Taylor >Assignee: Maddineni Sukumar > Fix For: 4.11.0 > > Attachments: PHOENIX-2885.4.10-HBase-0.98.patch, PHOENIX-2885.v2.patch > > > We have the ability currently to tell Phoenix how stale we're will to have > the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when > a table is created, unless explicitly specified, there is no > UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration > parameter to specify a default value when a CREATE TABLE statement is > executed. In addition, when a VIEW is created, we should inherit the > UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly > specified) and then fallback to the new default config value. > [1] https://phoenix.apache.org/language/index.html#options -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[ https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007084#comment-16007084 ] Andrew Purtell commented on PHOENIX-2885: - bq. we have UpdateCacheIT which verifies how many RPCs are made with and without an UPDATE_CACHE_FREQUENCY being set Thanks, no concerns then > Set default value for UPDATE_CACHE_FREQUENCY > > > Key: PHOENIX-2885 > URL: https://issues.apache.org/jira/browse/PHOENIX-2885 > Project: Phoenix > Issue Type: Sub-task >Reporter: James Taylor >Assignee: Maddineni Sukumar > Fix For: 4.11.0 > > Attachments: PHOENIX-2885.4.10-HBase-0.98.patch, PHOENIX-2885.v2.patch > > > We have the ability currently to tell Phoenix how stale we're will to have > the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when > a table is created, unless explicitly specified, there is no > UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration > parameter to specify a default value when a CREATE TABLE statement is > executed. In addition, when a VIEW is created, we should inherit the > UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly > specified) and then fallback to the new default config value. > [1] https://phoenix.apache.org/language/index.html#options -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[ https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007053#comment-16007053 ] Maddineni Sukumar commented on PHOENIX-2885: 1. I will look into parameterizing some tests with default update_cache_frequency param. 2. Regarding priority as of now it is something like below. long updateCacheFrequency = defaultValue!=null?defaultValue:0 if(tableProps.updateCacheFrequency!=null) updateCacheFrequency = tableProps.updateCacheFrequency else if (parentTable!=null) updateCacheFrequency = parentTable.updateCacheFrequency So first priority is to current table specific property if exists, if not then we consider parent table property, if parent table does not exists then only we consider global default configured value. If global default value does not exists then it is zero which is default behavior. So it is same as [~jamestaylor] mentioned above, so I am not changing anything there. > Set default value for UPDATE_CACHE_FREQUENCY > > > Key: PHOENIX-2885 > URL: https://issues.apache.org/jira/browse/PHOENIX-2885 > Project: Phoenix > Issue Type: Sub-task >Reporter: James Taylor >Assignee: Maddineni Sukumar > Fix For: 4.11.0 > > Attachments: PHOENIX-2885.4.10-HBase-0.98.patch, PHOENIX-2885.v2.patch > > > We have the ability currently to tell Phoenix how stale we're will to have > the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when > a table is created, unless explicitly specified, there is no > UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration > parameter to specify a default value when a CREATE TABLE statement is > executed. In addition, when a VIEW is created, we should inherit the > UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly > specified) and then fallback to the new default config value. > [1] https://phoenix.apache.org/language/index.html#options -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[
https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007052#comment-16007052
]
Hadoop QA commented on PHOENIX-2885:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12867632/PHOENIX-2885.v2.patch
against master branch at commit f6fbb0dc9ef308eb747993c92a6895c7d460d4b7.
ATTACHMENT ID: 12867632
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+props.put(QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
""+defaultUpdateCacheFrequency);
+public static final String DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB =
"phoenix.default.update.cache.frequency";
+QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY);
+QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY);
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/859//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/859//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/859//console
This message is automatically generated.
> Set default value for UPDATE_CACHE_FREQUENCY
>
>
> Key: PHOENIX-2885
> URL: https://issues.apache.org/jira/browse/PHOENIX-2885
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Maddineni Sukumar
> Fix For: 4.11.0
>
> Attachments: PHOENIX-2885.4.10-HBase-0.98.patch, PHOENIX-2885.v2.patch
>
>
> We have the ability currently to tell Phoenix how stale we're will to have
> the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when
> a table is created, unless explicitly specified, there is no
> UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration
> parameter to specify a default value when a CREATE TABLE statement is
> executed. In addition, when a VIEW is created, we should inherit the
> UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly
> specified) and then fallback to the new default config value.
> [1] https://phoenix.apache.org/language/index.html#options
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[
https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007019#comment-16007019
]
James Taylor commented on PHOENIX-2885:
---
[~apurtell] - FYI, we have UpdateCacheIT which verifies how many RPCs are made
with and without an UPDATE_CACHE_FREQUENCY being set.
Same question as Andrew on the test failures, [~sukuna...@gmail.com]. Couple of
other comments:
* We'll need a good way of getting better test coverage when we have a default
update cache frequency specified. One issue you already found was PHOENIX-3841
which is good, but we'll want to make sure there aren't other bugs lurking when
we turn this on. Where you thinking to add more unit tests with PHOENIX-3823?
Another possible way would be to parameterize some tests so that they run with
a default update cache frequency - we'd have to think about which sets of tests
this would make the most sense for.
* For the MetaDataClient changes, you'll want to get the parent update cache
frequency and use that if there's no update cache frequency specified on the
table directly and then only use the default update cache frequency if there's
no parent (that way, a view will have the same cache frequency update as it's
parent and an index will have the same cache frequency as the table it is on).
The precedence should work like this:
** first use value of update cache frequency specified directly on the table
{code}
Long ucfProp = (Long) TableProperty.UPDATE_CACHE_FREQUENCY.getValue(tableProps);
{code}
** second, {{if (ucfProp == null && parent != null)}} then should use the value
on the parent
{code}
ucfProp = parent.getUpdateCacheFrequency();
{code}
** otherwise, use the new default update cache frequency value
> Set default value for UPDATE_CACHE_FREQUENCY
>
>
> Key: PHOENIX-2885
> URL: https://issues.apache.org/jira/browse/PHOENIX-2885
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Maddineni Sukumar
> Fix For: 4.11.0
>
> Attachments: PHOENIX-2885.4.10-HBase-0.98.patch, PHOENIX-2885.v2.patch
>
>
> We have the ability currently to tell Phoenix how stale we're will to have
> the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when
> a table is created, unless explicitly specified, there is no
> UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration
> parameter to specify a default value when a CREATE TABLE statement is
> executed. In addition, when a VIEW is created, we should inherit the
> UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly
> specified) and then fallback to the new default config value.
> [1] https://phoenix.apache.org/language/index.html#options
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[ https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007017#comment-16007017 ] Maddineni Sukumar commented on PHOENIX-2885: Thanks [~apurtell] , my eye didn't catch that. Updated new patch with variable name change. And regarding test failures, I ran them multiple times and they are passing passing locally, and I am sure this patch wont change anything related to above failed tests. This patch is to have configured default value and this unit tests covers all three scenarios related to configuring value. 1. No configured default value which means update_cache_frequency=zero, create table and assert update_cache_frequency=0 2. configure default value to some x and create table and assert table value to x 3. With default value x create a table with table specific property update_cache_frequency=y and assert table is created with value y. I didn't add test to verify behavior of update_cache_frequency as that is already tested code. And some of failures related to that are being fixed in PHOENIX-3823 . > Set default value for UPDATE_CACHE_FREQUENCY > > > Key: PHOENIX-2885 > URL: https://issues.apache.org/jira/browse/PHOENIX-2885 > Project: Phoenix > Issue Type: Sub-task >Reporter: James Taylor >Assignee: Maddineni Sukumar > Fix For: 4.11.0 > > Attachments: PHOENIX-2885.4.10-HBase-0.98.patch, PHOENIX-2885.v2.patch > > > We have the ability currently to tell Phoenix how stale we're will to have > the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when > a table is created, unless explicitly specified, there is no > UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration > parameter to specify a default value when a CREATE TABLE statement is > executed. In addition, when a VIEW is created, we should inherit the > UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly > specified) and then fallback to the new default config value. > [1] https://phoenix.apache.org/language/index.html#options -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[
https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006819#comment-16006819
]
Andrew Purtell commented on PHOENIX-2885:
-
Please fix typo. FREQUENCY, not FERQUENCY
{code}
public static final int DEFAULT_UPDATE_CACHE_FERQUENCY = 0;
{code}
Are the test failures related?
The new test case checks that the setting can be updated, but do we know if
updating it will actually have the intended effect?
> Set default value for UPDATE_CACHE_FREQUENCY
>
>
> Key: PHOENIX-2885
> URL: https://issues.apache.org/jira/browse/PHOENIX-2885
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Maddineni Sukumar
> Fix For: 4.11.0
>
> Attachments: PHOENIX-2885.4.10-HBase-0.98.patch
>
>
> We have the ability currently to tell Phoenix how stale we're will to have
> the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when
> a table is created, unless explicitly specified, there is no
> UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration
> parameter to specify a default value when a CREATE TABLE statement is
> executed. In addition, when a VIEW is created, we should inherit the
> UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly
> specified) and then fallback to the new default config value.
> [1] https://phoenix.apache.org/language/index.html#options
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[ https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006718#comment-16006718 ] Maddineni Sukumar commented on PHOENIX-2885: [~jamestaylor] / [~mujtabachohan] / [~samarthjain] could you please review the patch. Thanks. > Set default value for UPDATE_CACHE_FREQUENCY > > > Key: PHOENIX-2885 > URL: https://issues.apache.org/jira/browse/PHOENIX-2885 > Project: Phoenix > Issue Type: Sub-task >Reporter: James Taylor >Assignee: Maddineni Sukumar > Fix For: 4.11.0 > > Attachments: PHOENIX-2885.4.10-HBase-0.98.patch > > > We have the ability currently to tell Phoenix how stale we're will to have > the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when > a table is created, unless explicitly specified, there is no > UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration > parameter to specify a default value when a CREATE TABLE statement is > executed. In addition, when a VIEW is created, we should inherit the > UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly > specified) and then fallback to the new default config value. > [1] https://phoenix.apache.org/language/index.html#options -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[
https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003036#comment-16003036
]
Hadoop QA commented on PHOENIX-2885:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12866937/PHOENIX-2885.4.10-HBase-0.98.patch
against master branch at commit 37d0a4a038c1f843db2a1d68cfc3b3cfa8c8d537.
ATTACHMENT ID: 12866937
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+"select TABLE_NAME,UPDATE_CACHE_FREQUENCY from SYSTEM.CATALOG
where TABLE_NAME = '"+TABLE_NAME+"' AND TABLE_TYPE='u'";
+props.put(QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
""+defaultUpdateCacheFrequency);
+ "select TABLE_NAME,UPDATE_CACHE_FREQUENCY from SYSTEM.CATALOG where
TABLE_NAME = '"+TABLE_NAME+"' AND TABLE_TYPE='u'");
+public static final String DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB =
"phoenix.default.update.cache.frequency";
+getLong(QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
QueryServicesOptions.DEFAULT_UPDATE_CACHE_FERQUENCY);
+getLong(QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
QueryServicesOptions.DEFAULT_UPDATE_CACHE_FERQUENCY);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CreateTableIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/850//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/850//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/850//console
This message is automatically generated.
> Set default value for UPDATE_CACHE_FREQUENCY
>
>
> Key: PHOENIX-2885
> URL: https://issues.apache.org/jira/browse/PHOENIX-2885
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Maddineni Sukumar
> Fix For: 4.11.0
>
> Attachments: PHOENIX-2885.4.10-HBase-0.98.patch
>
>
> We have the ability currently to tell Phoenix how stale we're will to have
> the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when
> a table is created, unless explicitly specified, there is no
> UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration
> parameter to specify a default value when a CREATE TABLE statement is
> executed. In addition, when a VIEW is created, we should inherit the
> UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly
> specified) and then fallback to the new default config value.
> [1] https://phoenix.apache.org/language/index.html#options
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[ https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001248#comment-16001248 ] Maddineni Sukumar commented on PHOENIX-2885: And I don't know how to submit patch to update apache phoenix website with this config option here - "https://phoenix.apache.org/language/index.html#options";. Could you please guide me on this. > Set default value for UPDATE_CACHE_FREQUENCY > > > Key: PHOENIX-2885 > URL: https://issues.apache.org/jira/browse/PHOENIX-2885 > Project: Phoenix > Issue Type: Sub-task >Reporter: James Taylor >Assignee: Maddineni Sukumar > Fix For: 4.11.0 > > Attachments: PHOENIX-2885.4.10-HBase-0.98.patch > > > We have the ability currently to tell Phoenix how stale we're will to have > the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when > a table is created, unless explicitly specified, there is no > UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration > parameter to specify a default value when a CREATE TABLE statement is > executed. In addition, when a VIEW is created, we should inherit the > UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly > specified) and then fallback to the new default config value. > [1] https://phoenix.apache.org/language/index.html#options -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[ https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001243#comment-16001243 ] Maddineni Sukumar commented on PHOENIX-2885: Hi [~jamestaylor] , submitted patch for default config. Please review it and let me know if there is anything I have to modify. > Set default value for UPDATE_CACHE_FREQUENCY > > > Key: PHOENIX-2885 > URL: https://issues.apache.org/jira/browse/PHOENIX-2885 > Project: Phoenix > Issue Type: Sub-task >Reporter: James Taylor >Assignee: Maddineni Sukumar > Fix For: 4.11.0 > > Attachments: PHOENIX-2885.4.10-HBase-0.98.patch > > > We have the ability currently to tell Phoenix how stale we're will to have > the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when > a table is created, unless explicitly specified, there is no > UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration > parameter to specify a default value when a CREATE TABLE statement is > executed. In addition, when a VIEW is created, we should inherit the > UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly > specified) and then fallback to the new default config value. > [1] https://phoenix.apache.org/language/index.html#options -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[
https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993469#comment-15993469
]
James Taylor commented on PHOENIX-2885:
---
This JIRA can be broken down into the following steps:
- Define new constant in QueryServices.java for default config parameter.
Something like {{phoenix.default.update.cache.frequency}}.
- Define a default value in QueryServicesOptions.java for the new config
parameter.
- Modify MetaDataClient.createTableInternal() to use a) parent
UPDATE_CACHE_FREQUENCY when creating a VIEW, and b) the default config value
for UPDATE_CACHE_FREQUENCY.
> Set default value for UPDATE_CACHE_FREQUENCY
>
>
> Key: PHOENIX-2885
> URL: https://issues.apache.org/jira/browse/PHOENIX-2885
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Maddineni Sukumar
> Fix For: 4.11.0
>
>
> We have the ability currently to tell Phoenix how stale we're will to have
> the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when
> a table is created, unless explicitly specified, there is no
> UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration
> parameter to specify a default value when a CREATE TABLE statement is
> executed. In addition, when a VIEW is created, we should inherit the
> UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly
> specified) and then fallback to the new default config value.
> [1] https://phoenix.apache.org/language/index.html#options
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[ https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993417#comment-15993417 ] James Taylor commented on PHOENIX-2885: --- [~sukuna...@gmail.com] - I've created a separate JIRA for the handling of an entity (table/column) not being found with PHOENIX-3823. Let's discuss over there instead. > Set default value for UPDATE_CACHE_FREQUENCY > > > Key: PHOENIX-2885 > URL: https://issues.apache.org/jira/browse/PHOENIX-2885 > Project: Phoenix > Issue Type: Sub-task >Reporter: James Taylor >Assignee: Maddineni Sukumar > Fix For: 4.11.0 > > > Instead of by default doing an extra RPC per query, we should have a default > value for UPDATE_CACHE_FREQUENCY. Instead of throwing when an entity > (table/column/column family, etc) is not found, we can force an update of the > client-side cache and retry the statement once. This works well for > references to entities that don't yet exist. However, we won't detect when > some entities are referred to which no longer exists until the cache expires. > An exception is if a physical table is dropped which would be detected > immediately. Worst-case, we may allow queries and updates to columns which > have been dropped. In addition, we won't start using indexes on tables until > the cache expires. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY
[ https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993363#comment-15993363 ] Maddineni Sukumar commented on PHOENIX-2885: I am thinking below are the scenarios we need to consider(correct me if below list is wrong). Will check current behavior after making default to 10 sec. 1)Table modify like add/remove column 2)Table drop 3)Index add 4)Index modify? is it possible? 5)Index drop Above for both Local index and secondary index 6)View create 7)View modify? is it possible 8)View drop Thanks > Set default value for UPDATE_CACHE_FREQUENCY > > > Key: PHOENIX-2885 > URL: https://issues.apache.org/jira/browse/PHOENIX-2885 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: Maddineni Sukumar > Fix For: 4.11.0 > > > Instead of by default doing an extra RPC per query, we should have a default > value for UPDATE_CACHE_FREQUENCY. Instead of throwing when an entity > (table/column/column family, etc) is not found, we can force an update of the > client-side cache and retry the statement once. This works well for > references to entities that don't yet exist. However, we won't detect when > some entities are referred to which no longer exists until the cache expires. > An exception is if a physical table is dropped which would be detected > immediately. Worst-case, we may allow queries and updates to columns which > have been dropped. In addition, we won't start using indexes on tables until > the cache expires. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
