[GUMP@vmgump]: Project ooxml-schemas (in module poi) failed

2016-10-15 Thread Gump [HEAD] :-( 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project ooxml-schemas has an issue affecting its community integration.
This issue affects 5 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Timed Out'.
For reference only, the following projects are affected by this:
- ooxml-schemas :  POI
- org.apache.poi :  POI
- poi :  POI
- poi-ooxml-schemas :  POI
- poi-test :  POI


Full details are available at:
http://vmgump.apache.org/gump/public/poi/ooxml-schemas/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [ooxml-schemas-[0-9]*[0-9T].jar] identifier set to 
project name
 -INFO- Failed with reason build timed out
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/poi/ooxml-schemas/gump_work/build_poi_ooxml-schemas.html
Work Name: build_poi_ooxml-schemas (Type: Build)
Work ended in a state of : Failed
Elapsed: 1 hour 6 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dant.build.clonevm=true org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml compile-ooxml-xsds 
[Working Directory: /srv/gump/public/workspace/poi]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/poi/ooxml-lib/curvesapi-1.04.jar:/srv/gump/public/workspace/poi/ooxml-lib/xmlbeans-2.6.0.jar.orig:/srv/gump/public/workspace/poi/compile-lib/bcpkix-jdk15on-1.54.jar:/srv/gump/public/workspace/poi/compile-lib/bcprov-ext-jdk15on-1.54.jar:/srv/gump/public/workspace/poi/compile-lib/slf4j-api-1.7.12.jar
-
Buildfile: /srv/gump/public/workspace/poi/build.xml

check-jars:

fetch-jars:

check-ooxml-jars:

fetch-ooxml-jars:

init:
 [echo] Using Ant: Apache Ant(TM) version 1.10.0alpha compiled on October 
16 2016 from ${ant.home}, Ant detected Java 1.8 (may be different than actual 
Java sometimes...)
 [echo] Using Java: 1.8.0_60/1.8.0_60-b27/25.60-b23/Java HotSpot(TM) 64-Bit 
Server VM from Oracle Corporation on Linux: 3.13.0-66-generic
 [echo] Using Findbugs: 3.0.1 for Java 1.8.0_60

check-ooxml-xsds:

fetch-ooxml-xsds:
  [get] Getting: 
http://www.ecma-international.org/publications/files/ECMA-ST/Office%20Open%20XML%201st%20edition%20Part%204%20(PDF).zip
  [get] To: /srv/gump/public/workspace/poi/ooxml-lib/OfficeOpenXML-Part4.zip
  [get] Getting: 
http://www.ecma-international.org/publications/files/ECMA-ST/Office%20Open%20XML%201st%20edition%20Part%202%20(PDF).zip
  [get] To: /srv/gump/public/workspace/poi/ooxml-lib/OfficeOpenXML-Part2.zip
  [get] Getting: 
https://www.w3.org/TR/2002/REC-xmldsig-core-20020212/xmldsig-core-schema.xsd
  [get] To: /srv/gump/public/workspace/poi/ooxml-lib/xmldsig-core-schema.xsd
  [get] Getting: http://uri.etsi.org/01903/v1.3.2/XAdES.xsd
  [get] To: /srv/gump/public/workspace/poi/ooxml-lib/XAdES.xsd
  [get] Getting: http://uri.etsi.org/01903/v1.4.1/XAdESv141.xsd
  [get] To: /srv/gump/public/workspace/poi/ooxml-lib/XAdESv141.xsd
[unzip] Expanding: 
/srv/gump/public/workspace/poi/ooxml-lib/OfficeOpenXML-Part4.zip into 
/srv/gump/public/workspace/poi/ooxml-lib
[unzip] Expanding: 
/srv/gump/public/workspace/poi/ooxml-lib/OfficeOpenXML-Part2.zip into 
/srv/gump/public/workspace/poi/ooxml-lib
[unzip] Expanding: 
/srv/gump/public/workspace/poi/ooxml-lib/OfficeOpenXML-Part4.zip into 
/srv/gump/public/workspace/poi/ooxml-lib

check-compiled-ooxml-xsds:

compile-ooxml-xsds:
[mkdir] Created dir: /srv/gump/public/workspace/poi/build/xmlbean-xsds
[mkdir] Created dir: /srv/gump/public/workspace/poi/build/xmlbean-sources
[mkdir] Created dir: /srv/gump/public/workspace/poi/build/xmlbean-classes
 [copy] Copying 2 files to /srv/gump/public/workspace/poi/build/xmlbean-xsds
 [copy] Copying 87 resources to 
/srv/gump/public/workspace/poi/build/xmlbean-xsds
  [xmlbean] Time to build schema type system: 6.353 seconds
  [xmlbean] Time to generate code: 10.44 seconds
 [copy] Copying 7 files to

Functionality injection technique for XWPF

2016-10-15 Thread Mark Murphy 
In working through the XWPF API I see a lot of notation concerning
duplicated code. This is because there are a lot of places which need the
same functionality, but they are not related in a way that can easily be
sub-classed. For example a Document Body can contain Comments, Paragraphs
and Tables. So can Headers, Footers, Footnotes, and Table Cells. In
addition, Tables can contain Comments, but not Paragraphs or other Tables.
Same for Table Rows. The content functionality can be sub-classed by
itself, but  many of the objects that need to use that functionality
already have a place in the class structure, and cannot extend another
class. So I need another way to inject that functionality. I have an idea,
but would like some validation from others who are more versed in Java than
I, so here is the thought.

I would create two base content classes: Markup which would contain the
implementation for comments, bookmarks, custom XML, and a few other things
which are used universally throughout the various content parts; and
Content which would extend Markup and add Paragraphs and Tables, and
anything else that is used exclusively where paragraphs and tables can be
added. Both of these would have associated interfaces which would be
implemented in the parts that need this functionality. The part I am not
totally certain about is injecting this functionality into XWPFDocument,
XWPFTable, XWPFTableCell, XWPFHeaderFooter, etc. My thought is to have each
of these objects implement one of the two base content interfaces, and
contain a reference to its associated implementation class. Then to
complete the implementation, it would forward requests associated with
these interfaces to the implementation class.

So XWPFDocument would include something like this:

XWPFDocument extends POIXMLDocument implements IContent

...
private Content _content;
...

public XWPFParagraph createParagraph() {
  return _content.createParagraph();
}
...

I know there are other things I would need to do because the XWPFDocument
class keeps a list of paragraphs and tables, and I would have to update
those lists, but this is the gist of how I would remove the duplication of
implementation details from all the places where it currently exists. A lot
of objects can create paragraphs and tables, and even more can create
comment and bookmark artifacts.

What do you think? Workable? Any cons to this approach?

[Bug 59734] Named range creation & lookup are linear in the number of ranges

2016-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

Dominik Stadler  changed:

   What|Removed |Added

 CC||cgh_c...@126.com

--- Comment #8 from Dominik Stadler  ---
*** Bug 59432 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59432] createName is slow when there are many Names (10000)

2016-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59432

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Dominik Stadler  ---
It seems this was actually fixed already in POI 3.15 via r1754521 and bug
59734, there we changed the access pattern to fetch by name from a
ArrayListValuedHashMap from commons-collections4.

*** This bug has been marked as a duplicate of bug 59734 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60219] [PATCH] FormulaParser can't parse external references when sheet name is quoted

2016-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60219

Javen O'Neal  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #8 from Javen O'Neal  ---
Are these external references saved in the xls or xlsx file? If so, then you
are correct that the HSSFWorkbook and XSSFWorkbook need a method to add a link
to an external workbook (I'm assuming it would also be valid to remove a link,
in which case we would need an add, remove and get external links methods).

If only the FormulaEvaluator needs to know about external references (if this
information is not saved in the workbook or is always auto-created when an
external reference is found), then there is no need to complicate the API with
multiple ways to link workbooks for evaluation.

Relevant: https://poi.apache.org/spreadsheet/eval.html#external

FWIW, I tested attachment 34354 and it passes with the current test suite.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60259] [PATCH] dispose temp file in test code

2016-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60259

Dominik Stadler  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #3 from Dominik Stadler  ---
Thanks, I have applied this via r1765100, although the file was cleaned up by
the TempFile implementation automatically as well and thus no file was left
over, but it is a bit cleaner this way.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60259] [PATCH] dispose temp file in test code

2016-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60259

Dominik Stadler  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #2 from Dominik Stadler  ---
Oh wait, I will take another look, maybe this is something else.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60259] [PATCH] dispose temp file in test code

2016-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60259

Dominik Stadler  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Dominik Stadler  ---
Thanks for the patch, we already fixed this via r1765019, albeit in a different
way, maybe you can take a look if our approach is valid as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60255] createDrawingPatriarch does not take next correct next drawing index number

2016-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60255

Javen O'Neal  changed:

   What|Removed |Added

 CC||manfred.mueh...@rimaone.com

--- Comment #11 from Javen O'Neal  ---
*** Bug 55516 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 55516] createDrawingPatriarch does not take drawingml.chartshapes+xml into account for calculation of drawingNumber

2016-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=55516

Javen O'Neal  changed:

   What|Removed |Added

 Resolution|FIXED   |DUPLICATE

--- Comment #5 from Javen O'Neal  ---


*** This bug has been marked as a duplicate of bug 60255 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: Build Fails on OOXML Test, just on my system though

2016-10-15 Thread Mark Murphy 
That fixed it, thanks.

On Sat, Oct 15, 2016 at 2:56 AM, Dominik Stadler 
wrote:

> There was one leftover file-handle:
>
> 1 descriptors are open
> #1 /tmp/poifiles/poi-sxssf-sheet1825736082761654274.xml by thread:main on
> Sat Oct 15 08:09:20 CEST 2016
> at java.io.FileInputStream.(FileInputStream.java:121)
> at
> org.apache.poi.xssf.streaming.TestSXSSFWorkbookWithCustomZipEntrySource.
> validateTempFilesAreEncrypted(TestSXSSFWorkbookWithCustomZip
> EntrySource.java:136)
>
> I have fixed this one now via r1765019, please try if tests succeed on
> Windows now as well.
>
> I plan to integrate the file-leak-detection functionality that I use
> locally to find such issues easily.
>
> We also should re-enable running tests on Window-CI-slaves again to catch
> such issues in the CI-builds, unfortunately these slaves were rather
> unstable in the past, maybe this has improved now.
>
> Dominik.
>
>
> On Sat, Oct 15, 2016 at 6:29 AM, Mark Murphy 
> wrote:
>
> > Windows 7
> >
> > svn status contains forrest.properties and src/documentation, svn status
> on
> > src/documentation is blank.
> >
> > ant clean jenkins returns the same failure.
> >
> > thing is it worked a couple days ago.
> >
> > On Fri, Oct 14, 2016 at 9:59 PM, Javen O'Neal  wrote:
> >
> > > Windows, Linux, or Mac?
> > >
> > > I know Windows keeps open file handles open, preventing the file from
> > being
> > > deleted or moved.
> > >
> > > Does it still break with "ant clean jenkins"?
> > >
> > > Is "svn status" blank just before running "ant clean jenkins"?
> > >
> > > On Oct 14, 2016 6:50 PM, "Mark Murphy"  wrote:
> > >
> > > > :ooxml:test
> > > >
> > > > org.apache.poi.xssf.streaming.TestSXSSFWorkbookWithCustomZip
> > EntrySource
> > > >
> > > > validateTempFilesAreEncrypted FAILED
> > > > java.lang.AssertionError at
> > > > TestSXSSFWorkbookWithCustomZipEntrySource.java:141
> > > >
> > > > I think this is just me because I am using a clean download of the
> > > project,
> > > > and jenkins build is passing.
> > > >
> > > > So when I debug the junit that is failing, I find that the test that
> is
> > > > failing is validateTempFilesAreEncrypted, and the failure is that
> > > > workbook.dispose is unable to delete the temporary file backing the
> > XML.
> > > > The only reason that could be is that the test still has the file
> open
> > at
> > > > the time it is attempting to delete it. I tried to delete the file
> > > manually
> > > > while the program is at the breakpoint, and I cannot. But once the
> test
> > > has
> > > > completed, I am able to manually delete the file. Maybe the close on
> > the
> > > > Writer is failing silently, or something else has the file open. I
> > don't
> > > > understand why this would be happening though as the jenkins build
> does
> > > not
> > > > detect this (on the server).
> > > >
> > > > It did work for me a couple days ago when I was preparing to commit
> my
> > > > patch. I have nothing else in the works right now though since I
> can't
> > > even
> > > > build the project with a clean install.
> > > >
> > >
> >
>

[GUMP@vmgump]: Project ooxml-schemas (in module poi) failed

2016-10-15 Thread Gump [HEAD] :-( 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project ooxml-schemas has an issue affecting its community integration.
This issue affects 5 projects.
The current state of this project is 'Failed', with reason 'Build Timed Out'.
For reference only, the following projects are affected by this:
- ooxml-schemas :  POI
- org.apache.poi :  POI
- poi :  POI
- poi-ooxml-schemas :  POI
- poi-test :  POI


Full details are available at:
http://vmgump.apache.org/gump/public/poi/ooxml-schemas/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [ooxml-schemas-[0-9]*[0-9T].jar] identifier set to 
project name
 -INFO- Failed with reason build timed out
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/poi/ooxml-schemas/gump_work/build_poi_ooxml-schemas.html
Work Name: build_poi_ooxml-schemas (Type: Build)
Work ended in a state of : Failed
Elapsed: 1 hour 4 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dant.build.clonevm=true org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml compile-ooxml-xsds 
[Working Directory: /srv/gump/public/workspace/poi]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/poi/ooxml-lib/curvesapi-1.04.jar:/srv/gump/public/workspace/poi/ooxml-lib/xmlbeans-2.6.0.jar.orig:/srv/gump/public/workspace/poi/compile-lib/bcpkix-jdk15on-1.54.jar:/srv/gump/public/workspace/poi/compile-lib/bcprov-ext-jdk15on-1.54.jar:/srv/gump/public/workspace/poi/compile-lib/slf4j-api-1.7.12.jar
-
Buildfile: /srv/gump/public/workspace/poi/build.xml

check-jars:

fetch-jars:

check-ooxml-jars:

fetch-ooxml-jars:

init:
 [echo] Using Ant: Apache Ant(TM) version 1.10.0alpha compiled on October 
15 2016 from ${ant.home}, Ant detected Java 1.8 (may be different than actual 
Java sometimes...)
 [echo] Using Java: 1.8.0_60/1.8.0_60-b27/25.60-b23/Java HotSpot(TM) 64-Bit 
Server VM from Oracle Corporation on Linux: 3.13.0-66-generic
 [echo] Using Findbugs: 3.0.1 for Java 1.8.0_60

check-ooxml-xsds:

fetch-ooxml-xsds:
  [get] Getting: 
http://www.ecma-international.org/publications/files/ECMA-ST/Office%20Open%20XML%201st%20edition%20Part%204%20(PDF).zip
  [get] To: /srv/gump/public/workspace/poi/ooxml-lib/OfficeOpenXML-Part4.zip
  [get] Getting: 
http://www.ecma-international.org/publications/files/ECMA-ST/Office%20Open%20XML%201st%20edition%20Part%202%20(PDF).zip
  [get] To: /srv/gump/public/workspace/poi/ooxml-lib/OfficeOpenXML-Part2.zip
  [get] Getting: 
https://www.w3.org/TR/2002/REC-xmldsig-core-20020212/xmldsig-core-schema.xsd
  [get] To: /srv/gump/public/workspace/poi/ooxml-lib/xmldsig-core-schema.xsd
  [get] Getting: http://uri.etsi.org/01903/v1.3.2/XAdES.xsd
  [get] To: /srv/gump/public/workspace/poi/ooxml-lib/XAdES.xsd
  [get] Getting: http://uri.etsi.org/01903/v1.4.1/XAdESv141.xsd
  [get] To: /srv/gump/public/workspace/poi/ooxml-lib/XAdESv141.xsd
[unzip] Expanding: 
/srv/gump/public/workspace/poi/ooxml-lib/OfficeOpenXML-Part4.zip into 
/srv/gump/public/workspace/poi/ooxml-lib
[unzip] Expanding: 
/srv/gump/public/workspace/poi/ooxml-lib/OfficeOpenXML-Part2.zip into 
/srv/gump/public/workspace/poi/ooxml-lib
[unzip] Expanding: 
/srv/gump/public/workspace/poi/ooxml-lib/OfficeOpenXML-Part4.zip into 
/srv/gump/public/workspace/poi/ooxml-lib

check-compiled-ooxml-xsds:

compile-ooxml-xsds:
[mkdir] Created dir: /srv/gump/public/workspace/poi/build/xmlbean-xsds
[mkdir] Created dir: /srv/gump/public/workspace/poi/build/xmlbean-sources
[mkdir] Created dir: /srv/gump/public/workspace/poi/build/xmlbean-classes
 [copy] Copying 2 files to /srv/gump/public/workspace/poi/build/xmlbean-xsds
 [copy] Copying 87 resources to 
/srv/gump/public/workspace/poi/build/xmlbean-xsds
  [xmlbean] Time to build schema type system: 6.64 seconds
  [xmlbean] Time to generate code: 12.057 seconds
 [copy] Copying 7 files to 
/srv/gump/public/workspace/poi/build/xmlbean-sources
[javac] Compiling 4575 source

Jenkins build is back to normal : POI-OpenJDK #238

2016-10-15 Thread Apache Jenkins Server 
See 


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 55516] createDrawingPatriarch does not take drawingml.chartshapes+xml into account for calculation of drawingNumber

2016-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=55516

--- Comment #4 from Zero  ---
same my problem at https://bz.apache.org/bugzilla/show_bug.cgi?id=60255

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 55516] createDrawingPatriarch does not take drawingml.chartshapes+xml into account for calculation of drawingNumber

2016-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=55516

Zero  changed:

   What|Removed |Added

 Resolution|WONTFIX |FIXED

--- Comment #3 from Zero  ---
fixed in https://svn.apache.org/viewvc?view=rev=1764863 by Nick Burch

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60259] New: [PATCH] dispose temp file in test code

2016-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60259

Bug ID: 60259
   Summary: [PATCH] dispose temp file in test code
   Product: POI
   Version: 3.15-FINAL
  Hardware: PC
OS: Mac OS X 10.1
Status: NEW
  Severity: normal
  Priority: P2
 Component: SXSSF
  Assignee: dev@poi.apache.org
  Reporter: fannin...@yahoo.com

Created attachment 34375
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34375=edit
[PATCH] dispose temp file in test code

A small issue in TestSXSSFWorkbookWithCustomZipEntrySource. As the inner
classes in the test could be used as the basis of writing a custom version of
SXSSFWorkbook, it would be nice to ensure that those classes close all the temp
resources they create.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60029] Problem with Days360 method for the month of february

2016-10-15 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60029

Dominik Stadler  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #6 from Dominik Stadler  ---
Fixed via r1765018 with some additional adjustments to reduce the size of the
code and fix IDE warnings. Also some more tests added.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: Build Fails on OOXML Test, just on my system though

2016-10-15 Thread Dominik Stadler 
There was one leftover file-handle:

1 descriptors are open
#1 /tmp/poifiles/poi-sxssf-sheet1825736082761654274.xml by thread:main on
Sat Oct 15 08:09:20 CEST 2016
at java.io.FileInputStream.(FileInputStream.java:121)
at
org.apache.poi.xssf.streaming.TestSXSSFWorkbookWithCustomZipEntrySource.validateTempFilesAreEncrypted(TestSXSSFWorkbookWithCustomZipEntrySource.java:136)

I have fixed this one now via r1765019, please try if tests succeed on
Windows now as well.

I plan to integrate the file-leak-detection functionality that I use
locally to find such issues easily.

We also should re-enable running tests on Window-CI-slaves again to catch
such issues in the CI-builds, unfortunately these slaves were rather
unstable in the past, maybe this has improved now.

Dominik.


On Sat, Oct 15, 2016 at 6:29 AM, Mark Murphy  wrote:

> Windows 7
>
> svn status contains forrest.properties and src/documentation, svn status on
> src/documentation is blank.
>
> ant clean jenkins returns the same failure.
>
> thing is it worked a couple days ago.
>
> On Fri, Oct 14, 2016 at 9:59 PM, Javen O'Neal  wrote:
>
> > Windows, Linux, or Mac?
> >
> > I know Windows keeps open file handles open, preventing the file from
> being
> > deleted or moved.
> >
> > Does it still break with "ant clean jenkins"?
> >
> > Is "svn status" blank just before running "ant clean jenkins"?
> >
> > On Oct 14, 2016 6:50 PM, "Mark Murphy"  wrote:
> >
> > > :ooxml:test
> > >
> > > org.apache.poi.xssf.streaming.TestSXSSFWorkbookWithCustomZip
> EntrySource
> > >
> > > validateTempFilesAreEncrypted FAILED
> > > java.lang.AssertionError at
> > > TestSXSSFWorkbookWithCustomZipEntrySource.java:141
> > >
> > > I think this is just me because I am using a clean download of the
> > project,
> > > and jenkins build is passing.
> > >
> > > So when I debug the junit that is failing, I find that the test that is
> > > failing is validateTempFilesAreEncrypted, and the failure is that
> > > workbook.dispose is unable to delete the temporary file backing the
> XML.
> > > The only reason that could be is that the test still has the file open
> at
> > > the time it is attempting to delete it. I tried to delete the file
> > manually
> > > while the program is at the breakpoint, and I cannot. But once the test
> > has
> > > completed, I am able to manually delete the file. Maybe the close on
> the
> > > Writer is failing silently, or something else has the file open. I
> don't
> > > understand why this would be happening though as the jenkins build does
> > not
> > > detect this (on the server).
> > >
> > > It did work for me a couple days ago when I was preparing to commit my
> > > patch. I have nothing else in the works right now though since I can't
> > even
> > > build the project with a clean install.
> > >
> >
>