Re: XMLBeans in 4.0.0 release

2018-01-09 Thread Andreas Beeker
Hi,

we had this discussion already before [1].

- at 1) ... -1, we should get rid of the known errors

- at 2) ... if we get something with apache/poi in its name, I would +1 it. I 
still don't get it, why we can't have it as a module in our codebase - keeping 
everything apart the maven group id.
if we would switch to jaxb, we probably need to have something similar - 
although the last result was, that a jaxb fork should be imported, i.e. not 
provided by the project itself. [2]
How about opening a github contrib project?

- at 3) ... -1, a xml/model/writer replacement would take too long

Andi

[1] 
http://apache-poi.1045710.n5.nabble.com/DISCUSS-Getting-a-fixed-version-of-XMLBeans-td5729378.html

[2] https://issues.apache.org/jira/browse/LEGAL-264




signature.asc
Description: OpenPGP digital signature


Re: XMLBeans in 4.0.0 release

2018-01-09 Thread Dave Fisher
Hi -

I think that releasing a package with right XMLbean path in Maven Central might 
be best for our users. Finding that they have issues with old XMLbeans might be 
subtly difficult. I could be wrong.

Regards,
Dave

Sent from my iPhone

> On Jan 9, 2018, at 12:28 AM, Nick Burch  wrote:
> 
>> On Mon, 8 Jan 2018, pj.fanning wrote:
>> I understand the desire to replace XMLBeans altogether but I don't think we 
>> have enough developer time available to do this in the 4.0.0 time frame.
> 
> Given the amount of work that'd take, and a desire for other features and 
> bugs to be worked on in the mean time, I'd agree!
> 
> 
>> 1. Keep Apache XMLBeans 2.6.0 dependency - if users run into issues with
>> XMLBeans, they can choose to configure their own project builds to swap in
>> https://github.com/pjfanning/xmlbeans instead.
> 
> I don't think that's a good new-user experience (nor upgrading user 
> experience), the "default" they're pushed towards is known to have problems 
> and they'll likely struggle with them for a while before discovering the fix
> 
>> 2. Make https://github.com/pjfanning/xmlbeans the default dependency
>> 3. Delay POI 4.0.0 release until we can get an adequate replacement for
>> XMLBeans.
> 
> I'd suggest we either go back to the Attic PMC and do a fixed release of 
> XMLBeans there (based on your fixed github fork), or fork XMLBeans within POI 
> (based on your fixed fork) and release a fixed release ourselves.
> 
> Either way, we then have POI depend on a known-fixed rather than known-broken 
> jar by default!
> 
> Nick
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 61981] New: DataFormatter.formatCellValue(cell) throws IllegalArgumentException when the format is ""ddd,mmm dd OR ""dddd, mmmm dd, yyyy

2018-01-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61981

Bug ID: 61981
   Summary: DataFormatter.formatCellValue(cell) throws
IllegalArgumentException when the format is ""ddd,mmm
dd OR "",  dd, 
   Product: POI
   Version: 3.17-FINAL
  Hardware: PC
OS: Mac OS X 10.1
Status: NEW
  Severity: normal
  Priority: P2
 Component: HSSF
  Assignee: dev@poi.apache.org
  Reporter: vinaysubscr...@gmail.com
  Target Milestone: ---

Created attachment 35663
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35663=edit
Sample test file with one sheet, and two cells.

https://issues.apache.org/jira/browse/TIKA-2196

This seems to be happening when a cell is set to custom format with double
quotes, for example:

""ddd,mmm dd
or
"",  dd, 

As per,
https://bz.apache.org/bugzilla/show_bug.cgi?id=54786

the double double quotes are replaced by a single single quote.

However in this case, there is no closing single quote.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #91: Adding chart in Document of MS-Word File without readi...

2018-01-09 Thread sandeeptiwari32
GitHub user sandeeptiwari32 opened a pull request:

https://github.com/apache/poi/pull/91

Adding chart in Document of MS-Word File without reading Temp MS-Word File

Bug 61972 - Adding chart in Document of MS-Word File without reading Temp 
MS-Word File
this patch contains changes for creating XWPFChart object in XWPFDocument 
object without reading Temp ms-Word File which contains chart and then 
modifying them.
Changes Done as suggested

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sandeeptiwari32/poi trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/poi/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #91


commit 8d312b982368332a96ae9c623b1798d45c70b7d9
Author: sandeep tiwari 
Date:   2018-01-08T19:31:48Z

Adding support to create chart in ms-word

commit 7425ad80c71062b4286eb4ff8892eff0fd148977
Author: sandeep tiwari 
Date:   2018-01-08T19:33:54Z

adding support of creating chart in ms-word

commit c4fdb497c4da199cfec40c24b9b8fce6fb2519bf
Author: sandeep tiwari 
Date:   2018-01-09T18:38:32Z

updated Required changes

updated Required changes

commit 950531f4c46e0caee76f03b89db7cd0a0e3149fb
Author: sandeep tiwari 
Date:   2018-01-09T19:09:38Z

updated changes as suggested 

updated changes as suggested for Bug 61972 - Adding chart in Document of 
MS-Word File without reading Temp MS-Word File
this patch contains changes for creating XWPFChart object in XWPFDocument 
object without reading Temp ms-Word File which contains chart and then 
modifying them.

commit ec13d69006e1872b43c0ebce59d0a3ca3a16d7f2
Author: sandeep tiwari 
Date:   2018-01-09T19:17:56Z

updated changes as suggested

updated changes as suggested

commit f76c807beb7563af851fb848c555022b00b4b6a1
Author: sandeep tiwari 
Date:   2018-01-09T19:22:53Z

update changes as suggested

update changes as suggested




---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request #89: Adding chart in Document of MS-Word File without readi...

2018-01-09 Thread sandeeptiwari32
Github user sandeeptiwari32 closed the pull request at:

https://github.com/apache/poi/pull/89


---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: XMLBeans in 4.0.0 release

2018-01-09 Thread Greg Woolsey
+1 for either of those options resulting in 4.0.0 depending on an updated
and fixed XML Beans. I don't care which.  An updated attic release is
slightly preferable to me, but if that's troublesome to pull off then a POI
fork is fine.

On Tue, Jan 9, 2018, 00:28 Nick Burch  wrote:

> On Mon, 8 Jan 2018, pj.fanning wrote:
> > I understand the desire to replace XMLBeans altogether but I don't think
> > we have enough developer time available to do this in the 4.0.0 time
> > frame.
>
> Given the amount of work that'd take, and a desire for other features and
> bugs to be worked on in the mean time, I'd agree!
>
>
> > 1. Keep Apache XMLBeans 2.6.0 dependency - if users run into issues with
> > XMLBeans, they can choose to configure their own project builds to swap
> in
> > https://github.com/pjfanning/xmlbeans instead.
>
> I don't think that's a good new-user experience (nor upgrading user
> experience), the "default" they're pushed towards is known to have
> problems and they'll likely struggle with them for a while before
> discovering the fix
>
> > 2. Make https://github.com/pjfanning/xmlbeans the default dependency
> > 3. Delay POI 4.0.0 release until we can get an adequate replacement for
> > XMLBeans.
>
> I'd suggest we either go back to the Attic PMC and do a fixed release of
> XMLBeans there (based on your fixed github fork), or fork XMLBeans within
> POI (based on your fixed fork) and release a fixed release ourselves.
>
> Either way, we then have POI depend on a known-fixed rather than
> known-broken jar by default!
>
> Nick
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>


Re: XMLBeans in 4.0.0 release

2018-01-09 Thread Nick Burch

On Mon, 8 Jan 2018, pj.fanning wrote:
I understand the desire to replace XMLBeans altogether but I don't think 
we have enough developer time available to do this in the 4.0.0 time 
frame.


Given the amount of work that'd take, and a desire for other features and 
bugs to be worked on in the mean time, I'd agree!




1. Keep Apache XMLBeans 2.6.0 dependency - if users run into issues with
XMLBeans, they can choose to configure their own project builds to swap in
https://github.com/pjfanning/xmlbeans instead.


I don't think that's a good new-user experience (nor upgrading user 
experience), the "default" they're pushed towards is known to have 
problems and they'll likely struggle with them for a while before 
discovering the fix



2. Make https://github.com/pjfanning/xmlbeans the default dependency
3. Delay POI 4.0.0 release until we can get an adequate replacement for
XMLBeans.


I'd suggest we either go back to the Attic PMC and do a fixed release of 
XMLBeans there (based on your fixed github fork), or fork XMLBeans within 
POI (based on your fixed fork) and release a fixed release ourselves.


Either way, we then have POI depend on a known-fixed rather than 
known-broken jar by default!


Nick

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org