[jira] [Commented] (DISPATCH-1144) Improve overview and getting started doc
[ https://issues.apache.org/jira/browse/DISPATCH-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650902#comment-16650902 ] ASF GitHub Bot commented on DISPATCH-1144: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/391 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=h1) Report > Merging [#391](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/94be97fa5ab2742a05e3d3f9a245cb1588f7a3c4?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=tree) ```diff @@Coverage Diff @@ ## master #391 +/- ## == - Coverage85.1% 85.07% -0.03% == Files 76 76 Lines 1668816688 == - Hits1420214197 -5 - Misses 2486 2491 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.3% <0%> (-0.72%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.07% <0%> (-0.46%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `92.85% <0%> (-0.3%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.01% <0%> (-0.22%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.39% <0%> (-0.13%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `76.96% <0%> (+0.19%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `85.52% <0%> (+0.26%)` | :arrow_up: | | [...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==) | `90.9% <0%> (+1.36%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=footer). Last update [94be97f...29b3a7c](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > Improve overview and getting started doc > > > Key: DISPATCH-1144 > URL: https://issues.apache.org/jira/browse/DISPATCH-1144 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Assignee: Ben Hardesty >Priority: Major > > Improve the Dispatch Router doc so that a user can quickly get up to speed > and get started with the router. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #391: DISPATCH-1144: Improve overview and getting starte...
Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/391 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=h1) Report > Merging [#391](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/94be97fa5ab2742a05e3d3f9a245cb1588f7a3c4?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=tree) ```diff @@Coverage Diff @@ ## master #391 +/- ## == - Coverage85.1% 85.07% -0.03% == Files 76 76 Lines 1668816688 == - Hits1420214197 -5 - Misses 2486 2491 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=tree) | Coverage Π| | |---|---|---| | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.3% <0%> (-0.72%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.07% <0%> (-0.46%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `92.85% <0%> (-0.3%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.01% <0%> (-0.22%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.39% <0%> (-0.13%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `76.96% <0%> (+0.19%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `85.52% <0%> (+0.26%)` | :arrow_up: | | [...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/391/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==) | `90.9% <0%> (+1.36%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=footer). Last update [94be97f...29b3a7c](https://codecov.io/gh/apache/qpid-dispatch/pull/391?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1145) Edge Router - Implement address proxy component
[ https://issues.apache.org/jira/browse/DISPATCH-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650680#comment-16650680 ] ASF subversion and git services commented on DISPATCH-1145: --- Commit 94be97fa5ab2742a05e3d3f9a245cb1588f7a3c4 in qpid-dispatch's branch refs/heads/master from [~tr...@redhat.com] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=94be97f ] DISPATCH-1145 - Added mobile address tests for edge router > Edge Router - Implement address proxy component > --- > > Key: DISPATCH-1145 > URL: https://issues.apache.org/jira/browse/DISPATCH-1145 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.5.0 > > > The Address Proxy is a component of the Edge Router module. It runs only on > an edge router. It has two main responsibilities: > Address Proxy has three main responsibilities: > # When an uplink becomes active, the "_uplink" address is properly linked to > an outgoing anonymous link on the active uplink connection. > # When an uplink becomes active, an incoming link is established over the > uplink connection that is used to transfer deliveries to topological > (dynamic) addresses on the edge router. > # Ensure that if there is an active uplink, that uplink should have one > incoming link for every address for which there is at least one local > consumer. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1957) [OSX] re-enable python tests in Travis CI for xcode7.3
[ https://issues.apache.org/jira/browse/PROTON-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650619#comment-16650619 ] ASF GitHub Bot commented on PROTON-1957: GitHub user RoddieKieley opened a pull request: https://github.com/apache/qpid-proton/pull/162 PROTON-1957: Re-enabling the install of python 3.6.4_4 for travis mac… …OS build via specific commit of the forumla. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RoddieKieley/qpid-proton travis-python-reenable Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/162.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #162 commit 3b2e93c8161ceeab570770af8d2cf248a83061c7 Author: Roddie Kieley Date: 2018-10-12T17:31:25Z PROTON-1957: Re-enabling the install of python 3.6.4_4 for travis macOS build via specific commit of the forumla. > [OSX] re-enable python tests in Travis CI for xcode7.3 > -- > > Key: PROTON-1957 > URL: https://issues.apache.org/jira/browse/PROTON-1957 > Project: Qpid Proton > Issue Type: Task > Components: build >Affects Versions: proton-c-0.26.0 > Environment: Travis CI > xcode7.3 image >Reporter: Roddie Kieley >Priority: Minor > > Looking at the logs for the macOS Travis CI job covering [Xcode > 7.3|https://travis-ci.org/apache/qpid-proton/jobs/440387457] we see that the > python tests do not execute at the moment. > This occurred due to removing the brew python upgrade which installed a > non-functional python 3.7.0 installation. Removal resulted in a successful > build and test, minus other issues, but did disable the python tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton pull request #162: PROTON-1957: Re-enabling the install of pytho...
GitHub user RoddieKieley opened a pull request: https://github.com/apache/qpid-proton/pull/162 PROTON-1957: Re-enabling the install of python 3.6.4_4 for travis mac⦠â¦OS build via specific commit of the forumla. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RoddieKieley/qpid-proton travis-python-reenable Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/162.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #162 commit 3b2e93c8161ceeab570770af8d2cf248a83061c7 Author: Roddie Kieley Date: 2018-10-12T17:31:25Z PROTON-1957: Re-enabling the install of python 3.6.4_4 for travis macOS build via specific commit of the forumla. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1957) [OSX] re-enable python tests in Travis CI for xcode7.3
Roddie Kieley created PROTON-1957: - Summary: [OSX] re-enable python tests in Travis CI for xcode7.3 Key: PROTON-1957 URL: https://issues.apache.org/jira/browse/PROTON-1957 Project: Qpid Proton Issue Type: Task Components: build Affects Versions: proton-c-0.26.0 Environment: Travis CI xcode7.3 image Reporter: Roddie Kieley Looking at the logs for the macOS Travis CI job covering [Xcode 7.3|https://travis-ci.org/apache/qpid-proton/jobs/440387457] we see that the python tests do not execute at the moment. This occurred due to removing the brew python upgrade which installed a non-functional python 3.7.0 installation. Removal resulted in a successful build and test, minus other issues, but did disable the python tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton-j pull request #18: NO-JIRA fix use of AtomicInteger and other v...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/qpid-proton-j/pull/18#discussion_r225266894
--- Diff:
examples/reactor/src/main/java/org/apache/qpid/proton/example/reactor/EchoInputStreamWrapper.java
---
@@ -31,11 +31,12 @@
public class EchoInputStreamWrapper extends Thread {
+private static final AtomicInteger idCounter = new AtomicInteger();
--- End diff --
Since this is an example, it should show the "best practices". I do not
know what the best practices are, though. Inspiring people to use static
variables does not to be the right thing. What is there now is not right
either...
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton-j pull request #18: NO-JIRA fix use of AtomicInteger and other v...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/qpid-proton-j/pull/18#discussion_r225265610
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/reactor/impl/TaskImpl.java ---
@@ -29,10 +29,12 @@
import org.apache.qpid.proton.reactor.Task;
public class TaskImpl implements Task, Comparable {
+
+private static final AtomicInteger count = new AtomicInteger();
--- End diff --
Ok, I will create a Jira and send the PR. Will rename to `COUNT`
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton-j issue #18: NO-JIRA fix use of AtomicInteger and other various ...
Github user jdanekrh commented on the issue: https://github.com/apache/qpid-proton-j/pull/18 About the granular commits, that is all due to @zkraus ' influence :P I figure squashing is much easier than splitting commits, so it sort of makes sense to start with granular commits... If I 'd gotten the `AtomicInteger` commit right, I could've directly cherrypicked it into the new PR for the Jira I'll create... --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton-j pull request #18: NO-JIRA fix use of AtomicInteger and other v...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/qpid-proton-j/pull/18#discussion_r225263746
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/ssl/DefaultSslEngineFacade.java
---
@@ -36,7 +36,7 @@
/**
* Our testing has shown that application buffers need to be a bit
larger
* than that provided by {@link SSLSession#getApplicationBufferSize()}
otherwise
- * {@link Status#BUFFER_OVERFLOW} will result on {@link
SSLEngine#unwrap()}.
+ * {@link Status#BUFFER_OVERFLOW} will result on {@link
SSLEngine#unwrap)}.
--- End diff --
typo on my part. I meant to delete both of the parens from the `()`, that
was my intention (because there is not a parameterless overload of the function)
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1146) Core-endpoint can't receive deliveries on core-initiated links
[ https://issues.apache.org/jira/browse/DISPATCH-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross resolved DISPATCH-1146. Resolution: Fixed > Core-endpoint can't receive deliveries on core-initiated links > -- > > Key: DISPATCH-1146 > URL: https://issues.apache.org/jira/browse/DISPATCH-1146 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.5.0 > > > Links that are initiated from within a core module have no associated > address. The AMQP_rx_handler therefore treats the link as an anonymous link. > If a delivery arrives for which there is no address, the rx_handler treats > the message as a no-address delivery on an anonymous link and rejects it. > Links originated in the core should be treated as a routed link as far as > rx-handler is concerned. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1146) Core-endpoint can't receive deliveries on core-initiated links
[ https://issues.apache.org/jira/browse/DISPATCH-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650545#comment-16650545 ] ASF subversion and git services commented on DISPATCH-1146: --- Commit d6544153eaeffe860f3f1e7d12ee5e67ca0007f0 in qpid-dispatch's branch refs/heads/master from [~tr...@redhat.com] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=d654415 ] DISPATCH-1146 - Treat edge links originating from within the core as routed-links to prevent AMQP_rx_handler from rejecting them. > Core-endpoint can't receive deliveries on core-initiated links > -- > > Key: DISPATCH-1146 > URL: https://issues.apache.org/jira/browse/DISPATCH-1146 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.5.0 > > > Links that are initiated from within a core module have no associated > address. The AMQP_rx_handler therefore treats the link as an anonymous link. > If a delivery arrives for which there is no address, the rx_handler treats > the message as a no-address delivery on an anonymous link and rejects it. > Links originated in the core should be treated as a routed link as far as > rx-handler is concerned. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1146) Core-endpoint can't receive deliveries on core-initiated links
Ted Ross created DISPATCH-1146: -- Summary: Core-endpoint can't receive deliveries on core-initiated links Key: DISPATCH-1146 URL: https://issues.apache.org/jira/browse/DISPATCH-1146 Project: Qpid Dispatch Issue Type: Bug Components: Router Node Reporter: Ted Ross Assignee: Ted Ross Fix For: 1.5.0 Links that are initiated from within a core module have no associated address. The AMQP_rx_handler therefore treats the link as an anonymous link. If a delivery arrives for which there is no address, the rx_handler treats the message as a no-address delivery on an anonymous link and rejects it. Links originated in the core should be treated as a routed link as far as rx-handler is concerned. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton-j pull request #18: NO-JIRA fix use of AtomicInteger and other v...
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton-j/pull/18#discussion_r225224724
--- Diff:
examples/reactor/src/main/java/org/apache/qpid/proton/example/reactor/EchoInputStreamWrapper.java
---
@@ -31,11 +31,12 @@
public class EchoInputStreamWrapper extends Thread {
+private static final AtomicInteger idCounter = new AtomicInteger();
--- End diff --
I don't think this really needed fixed and would have just left it as is.
Its only an example, likely to count to 1. Typically having a static shared
between reactors would often be incorrect.
If it were to change the variable name would be of the wrong syntax.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton-j pull request #18: NO-JIRA fix use of AtomicInteger and other v...
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton-j/pull/18#discussion_r225236948
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/reactor/impl/TaskImpl.java ---
@@ -29,10 +29,12 @@
import org.apache.qpid.proton.reactor.Task;
public class TaskImpl implements Task, Comparable {
+
+private static final AtomicInteger count = new AtomicInteger();
--- End diff --
This seems like an actual bug, so it deserves a JIRA. Variable name syntax
is now wrong.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton-j pull request #18: NO-JIRA fix use of AtomicInteger and other v...
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton-j/pull/18#discussion_r225223601
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/ssl/DefaultSslEngineFacade.java
---
@@ -36,7 +36,7 @@
/**
* Our testing has shown that application buffers need to be a bit
larger
* than that provided by {@link SSLSession#getApplicationBufferSize()}
otherwise
- * {@link Status#BUFFER_OVERFLOW} will result on {@link
SSLEngine#unwrap()}.
+ * {@link Status#BUFFER_OVERFLOW} will result on {@link
SSLEngine#unwrap)}.
--- End diff --
Seems to me like this change breaks the javadoc rather than fixing anything.
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Review Request 69025: fix checking of sasl setup dependent tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69025/ --- Review request for qpid. Repository: qpid-cpp Description --- acl and sasl tests rely on sasldb being setup, however this is not done if the saslpasswd2 utility is not found Diffs - src/tests/CMakeLists.txt 0c843b20e Diff: https://reviews.apache.org/r/69025/diff/1/ Testing --- Thanks, Gordon Sim
[jira] [Updated] (QPIDJMS-412) when using failover [re]connection attempts should stop upon non-temporary SASL failure
[ https://issues.apache.org/jira/browse/QPIDJMS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPIDJMS-412: --- Summary: when using failover [re]connection attempts should stop upon non-temporary SASL failure (was: when using failover [re]connection attemps should stop upon non-temporary SASL failure) > when using failover [re]connection attempts should stop upon non-temporary > SASL failure > --- > > Key: QPIDJMS-412 > URL: https://issues.apache.org/jira/browse/QPIDJMS-412 > Project: Qpid JMS > Issue Type: Bug > Components: qpid-jms-client >Affects Versions: 0.36.0 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 0.37.0 > > > When using a failover URI, the client continues to try and [re]connect upon > encountering SASL failure for a given server. Realistically different servers > in the failover list should behave similarly here, so continuing to attempt > connection is likely to be futile and lead to a delay signalling the issue > when the allowed attempts run out. When the SASL process fails with an > outcome other than sys-temp, further [re]connection attempts should stop. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton-j pull request #18: NO-JIRA fix use of AtomicInteger and other v...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/qpid-proton-j/pull/18#discussion_r225101483
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/ssl/SslEngineFacadeFactory.java
---
@@ -256,7 +256,7 @@ private static void removeSSLv3Support(final SSLEngine
engine)
{
List allowedProtocols = new
ArrayList(enabledProtocols);
allowedProtocols.remove(SSLV3_PROTOCOL);
-engine.setEnabledProtocols(allowedProtocols.toArray(new
String[allowedProtocols.size()]));
+engine.setEnabledProtocols(allowedProtocols.toArray(new
String[0]));
--- End diff --
ok, this is not really helpful...
---
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton-j pull request #18: NO-JIRA fix use of AtomicInteger and other v...
GitHub user jdanekrh opened a pull request: https://github.com/apache/qpid-proton-j/pull/18 NO-JIRA fix use of AtomicInteger and other various small fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/qpid-proton-j jd_various_small_fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton-j/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit b9c373861159499e999a5d33695cc7f3c1a03ad7 Author: Jiri Danek Date: 2018-10-15T09:29:08Z NO-JIRA fix minor typos (semicolons and javadoc @links) commit 77d9bc43c3d90e328bcf6baca68e02817fcd8a34 Author: Jiri Danek Date: 2018-10-15T09:30:43Z NO-JIRA fix use of AtomicInteger for class instance IDs It seems to me the field has to be static, for the code to make sense. commit 75801e6e003b2db5a97bb07c8da8ddc6f4e32b9b Author: Jiri Danek Date: 2018-10-15T09:34:21Z NO-JIRA apply IntelliJ suggested fixes where they seem helpful --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-576) proton-j: codec support for UTF-8 encoding and decoding appears broken?
[
https://issues.apache.org/jira/browse/PROTON-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649960#comment-16649960
]
ASF GitHub Bot commented on PROTON-576:
---
GitHub user jdanekrh opened a pull request:
https://github.com/apache/qpid-proton-j/pull/17
NO-JIRA: Undo PROTON-576: update test to make it compile on Java 6
Since PROTON-1913, the Java version required by proton-j is 8+.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdanekrh/qpid-proton-j jd_java8
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton-j/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
commit a3ad70767d295cdf343d13a86cee431f510b2134
Author: Jiri Danek
Date: 2018-10-13T11:30:33Z
NO-JIRA: Undo PROTON-576: update test to make it compile on Java 6
Since PROTON-1913, the Java version required by proton-j is 8+.
> proton-j: codec support for UTF-8 encoding and decoding appears broken?
> ---
>
> Key: PROTON-576
> URL: https://issues.apache.org/jira/browse/PROTON-576
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
>Affects Versions: 0.7
>Reporter: Dominic Evans
>Priority: Major
> Fix For: 0.8
>
> Attachments: 02_fix_stringtype_encode_decode.patch, PROTON-576.patch
>
>
> It seems like Proton-J has its own custom UTF-8 encoder, but relies on Java
> String's built-in UTF-8 decoder. However, the code doesn't seem quite right
> and complex double byte UTF-8 like emoji ('') can quite easily fail to
> parse:
> | | Cause:1 :- java.lang.IllegalArgumentException: Cannot parse
> String
> | | Message:1 :- Cannot parse String
> | | StackTrace:1 :- java.lang.IllegalArgumentException: Cannot parse
> String
> | | at
> org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:48)
> | | at
> org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:36)
> | | at
> org.apache.qpid.proton.codec.DecoderImpl.readRaw(DecoderImpl.java:945)
> | | at
> org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:172)
> | | at
> org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:124)
> | | at
> org.apache.qpid.proton.codec.DynamicTypeConstructor.readValue(DynamicTypeConstructor.java:39)
> | | at
> org.apache.qpid.proton.codec.DecoderImpl.readObject(DecoderImpl.java:885)
> | | at
> org.apache.qpid.proton.message.impl.MessageImpl.decode(MessageImpl.java:629)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-proton-j pull request #17: NO-JIRA: Undo PROTON-576: update test to mak...
GitHub user jdanekrh opened a pull request: https://github.com/apache/qpid-proton-j/pull/17 NO-JIRA: Undo PROTON-576: update test to make it compile on Java 6 Since PROTON-1913, the Java version required by proton-j is 8+. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/qpid-proton-j jd_java8 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton-j/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit a3ad70767d295cdf343d13a86cee431f510b2134 Author: Jiri Danek Date: 2018-10-13T11:30:33Z NO-JIRA: Undo PROTON-576: update test to make it compile on Java 6 Since PROTON-1913, the Java version required by proton-j is 8+. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
