[jira] [Commented] (DISPATCH-1463) Detect deliveries that are stuck in the router for a long time
[ https://issues.apache.org/jira/browse/DISPATCH-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961453#comment-16961453 ] ASF GitHub Bot commented on DISPATCH-1463: -- codecov-io commented on issue #600: DISPATCH-1463 - Add detection for stuck deliveries URL: https://github.com/apache/qpid-dispatch/pull/600#issuecomment-546504990 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=h1) Report > Merging [#600](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/d37ee8c3ae0344e462d816c90db8a915588c2b1d?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `97.7%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=tree) ```diff @@Coverage Diff @@ ## master #600 +/- ## == + Coverage 86.39% 86.44% +0.05% == Files 90 91 +1 Lines 2049520579 +84 == + Hits1770717790 +83 - Misses 2788 2789 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.88% <100%> (+0.15%)` | :arrow_up: | | [src/router\_core/router\_core\_thread.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlX3RocmVhZC5j) | `100% <100%> (ø)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `88.53% <100%> (+0.06%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `67.16% <100%> (+0.33%)` | :arrow_up: | | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `90.58% <100%> (+0.22%)` | :arrow_up: | | [...odules/stuck\_delivery\_detection/delivery\_tracker.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvc3R1Y2tfZGVsaXZlcnlfZGV0ZWN0aW9uL2RlbGl2ZXJ5X3RyYWNrZXIuYw==) | `96.61% <96.61%> (ø)` | | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.99% <0%> (-0.4%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.09% <0%> (-0.12%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.02%)` | :arrow_down: | | ... and [2 more](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=footer). Last update [d37ee8c...711172c](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Detect deliveries that are stuck in the router for a long time > -- > > Key: DISPATCH-1463 > URL: https://issues.apache.org/jira/browse/DISPATCH-1463 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.10.0 > > > The delayed-delivery counts are limited in that they only count deliveries > that have been settled. These counters do not count deliveries
[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #600: DISPATCH-1463 - Add detection for stuck deliveries
codecov-io edited a comment on issue #600: DISPATCH-1463 - Add detection for stuck deliveries URL: https://github.com/apache/qpid-dispatch/pull/600#issuecomment-546504990 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=h1) Report > Merging [#600](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/d37ee8c3ae0344e462d816c90db8a915588c2b1d?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `97.7%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=tree) ```diff @@Coverage Diff @@ ## master #600 +/- ## == + Coverage 86.39% 86.44% +0.05% == Files 90 91 +1 Lines 2049520579 +84 == + Hits1770717790 +83 - Misses 2788 2789 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.88% <100%> (+0.15%)` | :arrow_up: | | [src/router\_core/router\_core\_thread.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlX3RocmVhZC5j) | `100% <100%> (ø)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `88.53% <100%> (+0.06%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `67.16% <100%> (+0.33%)` | :arrow_up: | | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `90.58% <100%> (+0.22%)` | :arrow_up: | | [...odules/stuck\_delivery\_detection/delivery\_tracker.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvc3R1Y2tfZGVsaXZlcnlfZGV0ZWN0aW9uL2RlbGl2ZXJ5X3RyYWNrZXIuYw==) | `96.61% <96.61%> (ø)` | | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.99% <0%> (-0.4%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.09% <0%> (-0.12%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.02%)` | :arrow_down: | | ... and [2 more](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=footer). Last update [d37ee8c...711172c](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1453) Adding "defaultDistribution: unavailable" overrides the regular handling of transaction coordinator link refusal
[ https://issues.apache.org/jira/browse/DISPATCH-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961439#comment-16961439 ] ASF GitHub Bot commented on DISPATCH-1453: -- codecov-io commented on issue #602: DISPATCH-1453 - Fix the code so the correct error message shows up wh… URL: https://github.com/apache/qpid-dispatch/pull/602#issuecomment-547126348 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=h1) Report > Merging [#602](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/d37ee8c3ae0344e462d816c90db8a915588c2b1d?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=tree) ```diff @@Coverage Diff @@ ## master #602 +/- ## == - Coverage 86.39% 86.38% -0.01% == Files 90 90 Lines 2049520496 +1 == - Hits1770717706 -1 - Misses 2788 2790 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/modules/address\_lookup\_client/lookup\_client.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvYWRkcmVzc19sb29rdXBfY2xpZW50L2xvb2t1cF9jbGllbnQuYw==) | `92.38% <100%> (+1.09%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.99% <0%> (-0.4%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.86% <0%> (-0.35%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.53% <0%> (-0.2%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `81.19% <0%> (-0.19%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.02%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `87.86% <0%> (+0.22%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.89% <0%> (+0.7%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=footer). Last update [d37ee8c...e825f66](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Adding "defaultDistribution: unavailable" overrides the regular handling of > transaction coordinator link refusal > > > Key: DISPATCH-1453 > URL: https://issues.apache.org/jira/browse/DISPATCH-1453 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.9.0 >Reporter: Robbie Gemmell >Assignee: Ganesh Murthy >Priority: Minor > > DISPATCH-802 added handling to refuse links to the transaction coordinator > (which has no address, but is a specific target) if a link route to e.g a > broker isnt configured (using DISPATCH-195), and help clarify the reasons for > the refusal. > DISPATCH-803 was added to provide a way for links to adressses that are > otherwise unknown to be refused rather than message routed, by setting > "defaultDistribution: unavailable". This
[GitHub] [qpid-dispatch] codecov-io commented on issue #602: DISPATCH-1453 - Fix the code so the correct error message shows up wh…
codecov-io commented on issue #602: DISPATCH-1453 - Fix the code so the correct error message shows up wh… URL: https://github.com/apache/qpid-dispatch/pull/602#issuecomment-547126348 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=h1) Report > Merging [#602](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/d37ee8c3ae0344e462d816c90db8a915588c2b1d?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=tree) ```diff @@Coverage Diff @@ ## master #602 +/- ## == - Coverage 86.39% 86.38% -0.01% == Files 90 90 Lines 2049520496 +1 == - Hits1770717706 -1 - Misses 2788 2790 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/modules/address\_lookup\_client/lookup\_client.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvYWRkcmVzc19sb29rdXBfY2xpZW50L2xvb2t1cF9jbGllbnQuYw==) | `92.38% <100%> (+1.09%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.99% <0%> (-0.4%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.86% <0%> (-0.35%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.53% <0%> (-0.2%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `81.19% <0%> (-0.19%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.02%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL3BhcnNlLmM=) | `87.86% <0%> (+0.22%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.89% <0%> (+0.7%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=footer). Last update [d37ee8c...e825f66](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1453) Adding "defaultDistribution: unavailable" overrides the regular handling of transaction coordinator link refusal
[
https://issues.apache.org/jira/browse/DISPATCH-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961362#comment-16961362
]
ASF GitHub Bot commented on DISPATCH-1453:
--
ganeshmurthy commented on issue #602: DISPATCH-1453 - Fix the code so the
correct error message shows up wh…
URL: https://github.com/apache/qpid-dispatch/pull/602#issuecomment-547096045
@gemmellr Please take a look and approve if this works and you are
satisfied. Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Adding "defaultDistribution: unavailable" overrides the regular handling of
> transaction coordinator link refusal
>
>
> Key: DISPATCH-1453
> URL: https://issues.apache.org/jira/browse/DISPATCH-1453
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
>Priority: Minor
>
> DISPATCH-802 added handling to refuse links to the transaction coordinator
> (which has no address, but is a specific target) if a link route to e.g a
> broker isnt configured (using DISPATCH-195), and help clarify the reasons for
> the refusal.
> DISPATCH-803 was added to provide a way for links to adressses that are
> otherwise unknown to be refused rather than message routed, by setting
> "defaultDistribution: unavailable". This functionality overrides the
> behaviour from DISPATCH-802, making it less clear again why a transaction
> usage attempt has failed.
> From a JMS client trying to create a transacted session, the failure with
> "defaultDistribution: unavailable" config present looks like:
> {noformat}
> javax.jms.JMSException: No route to the destination node [condition =
> qd:no-route-to-dest]
> at
> org.apache.qpid.jms.provider.ProviderException.toJMSException(ProviderException.java:34)
> at
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:80)
> at
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:112)
> at org.apache.qpid.jms.JmsConnection.createResource(JmsConnection.java:698)
> at
> org.apache.qpid.jms.JmsLocalTransactionContext.begin(JmsLocalTransactionContext.java:140)
> at org.apache.qpid.jms.JmsSession.(JmsSession.java:172)
> at org.apache.qpid.jms.JmsConnection.createSession(JmsConnection.java:316)
> at org.apache.qpid.jms.example.HelloWorld.main(HelloWorld.java:52)
> {noformat}
> While without it,the router sends a more specific error condition, and so the
> failure normally looks like:
> {noformat}
> javax.jms.JMSException: The router can't coordinate transactions by itself, a
> linkRoute to a coordinator must be configured to use transactions. [condition
> = amqp:precondition-failed]
> at
> org.apache.qpid.jms.provider.ProviderException.toJMSException(ProviderException.java:34)
> at
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:80)
> at
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:112)
> at org.apache.qpid.jms.JmsConnection.createResource(JmsConnection.java:698)
> at
> org.apache.qpid.jms.JmsLocalTransactionContext.begin(JmsLocalTransactionContext.java:140)
> at org.apache.qpid.jms.JmsSession.(JmsSession.java:172)
> at org.apache.qpid.jms.JmsConnection.createSession(JmsConnection.java:316)
> at org.apache.qpid.jms.example.HelloWorld.main(HelloWorld.java:52)
> {noformat}
> It would be nicer if the regular coordinator refusal error condition was sent
> in both cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #602: DISPATCH-1453 - Fix the code so the correct error message shows up wh…
ganeshmurthy commented on issue #602: DISPATCH-1453 - Fix the code so the correct error message shows up wh… URL: https://github.com/apache/qpid-dispatch/pull/602#issuecomment-547096045 @gemmellr Please take a look and approve if this works and you are satisfied. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1453) Adding "defaultDistribution: unavailable" overrides the regular handling of transaction coordinator link refusal
[
https://issues.apache.org/jira/browse/DISPATCH-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961360#comment-16961360
]
ASF GitHub Bot commented on DISPATCH-1453:
--
ganeshmurthy commented on pull request #602: DISPATCH-1453 - Fix the code so
the correct error message shows up wh…
URL: https://github.com/apache/qpid-dispatch/pull/602
…en a tx sender attaches in the absence of a coordinated link route
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Adding "defaultDistribution: unavailable" overrides the regular handling of
> transaction coordinator link refusal
>
>
> Key: DISPATCH-1453
> URL: https://issues.apache.org/jira/browse/DISPATCH-1453
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
>Priority: Minor
>
> DISPATCH-802 added handling to refuse links to the transaction coordinator
> (which has no address, but is a specific target) if a link route to e.g a
> broker isnt configured (using DISPATCH-195), and help clarify the reasons for
> the refusal.
> DISPATCH-803 was added to provide a way for links to adressses that are
> otherwise unknown to be refused rather than message routed, by setting
> "defaultDistribution: unavailable". This functionality overrides the
> behaviour from DISPATCH-802, making it less clear again why a transaction
> usage attempt has failed.
> From a JMS client trying to create a transacted session, the failure with
> "defaultDistribution: unavailable" config present looks like:
> {noformat}
> javax.jms.JMSException: No route to the destination node [condition =
> qd:no-route-to-dest]
> at
> org.apache.qpid.jms.provider.ProviderException.toJMSException(ProviderException.java:34)
> at
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:80)
> at
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:112)
> at org.apache.qpid.jms.JmsConnection.createResource(JmsConnection.java:698)
> at
> org.apache.qpid.jms.JmsLocalTransactionContext.begin(JmsLocalTransactionContext.java:140)
> at org.apache.qpid.jms.JmsSession.(JmsSession.java:172)
> at org.apache.qpid.jms.JmsConnection.createSession(JmsConnection.java:316)
> at org.apache.qpid.jms.example.HelloWorld.main(HelloWorld.java:52)
> {noformat}
> While without it,the router sends a more specific error condition, and so the
> failure normally looks like:
> {noformat}
> javax.jms.JMSException: The router can't coordinate transactions by itself, a
> linkRoute to a coordinator must be configured to use transactions. [condition
> = amqp:precondition-failed]
> at
> org.apache.qpid.jms.provider.ProviderException.toJMSException(ProviderException.java:34)
> at
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:80)
> at
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:112)
> at org.apache.qpid.jms.JmsConnection.createResource(JmsConnection.java:698)
> at
> org.apache.qpid.jms.JmsLocalTransactionContext.begin(JmsLocalTransactionContext.java:140)
> at org.apache.qpid.jms.JmsSession.(JmsSession.java:172)
> at org.apache.qpid.jms.JmsConnection.createSession(JmsConnection.java:316)
> at org.apache.qpid.jms.example.HelloWorld.main(HelloWorld.java:52)
> {noformat}
> It would be nicer if the regular coordinator refusal error condition was sent
> in both cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1463) Detect deliveries that are stuck in the router for a long time
[
https://issues.apache.org/jira/browse/DISPATCH-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961358#comment-16961358
]
ASF GitHub Bot commented on DISPATCH-1463:
--
ChugR commented on pull request #600: DISPATCH-1463 - Add detection for stuck
deliveries
URL: https://github.com/apache/qpid-dispatch/pull/600#discussion_r339736259
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -570,6 +570,11 @@
"graph": true,
"description": "The total number of settled deliveries
that were held in the router for more than 10 seconds."
},
+"deliveriesStuck": {
+"type": "integer",
+"graph": true,
+"description": "The current number of deliveries that are
unsettled and have been held in the router for more than 10 seconds."
+},
Review comment:
Would you consider a 'peakDeliveriesStuck' stat?
Picture a network where some clients go down and zillions of deliveries get
stuck. Then those clients come back and the stuck number goes to zero. This
would provide some indication of an issue even though the current state is fine.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Detect deliveries that are stuck in the router for a long time
> --
>
> Key: DISPATCH-1463
> URL: https://issues.apache.org/jira/browse/DISPATCH-1463
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
>Reporter: Ted Ross
>Assignee: Ted Ross
>Priority: Major
> Fix For: 1.10.0
>
>
> The delayed-delivery counts are limited in that they only count deliveries
> that have been settled. These counters do not count deliveries that are
> currently "stuck" and have not been settled.
> This feature provides visibility into the number of stuck deliveries per link
> and per router.
> A new counter "deliveriesStuck" shall be added to the link and router
> entities for per-link and aggregated-per-router respectively.
> A delivery is considered "stuck" when it has been in the undelivered or
> unsettled lists for more than ten seconds and is still not settled. Once a
> stuck delivery is settled or otherwise removed, it is no longer considered
> stuck.
> When a link transitions from zero to one stuck delivery, an INFO log message
> shall be emitted indicating that at least one delivery is stuck on that link.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #602: DISPATCH-1453 - Fix the code so the correct error message shows up wh…
ganeshmurthy opened a new pull request #602: DISPATCH-1453 - Fix the code so the correct error message shows up wh… URL: https://github.com/apache/qpid-dispatch/pull/602 …en a tx sender attaches in the absence of a coordinated link route This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #600: DISPATCH-1463 - Add detection for stuck deliveries
ChugR commented on a change in pull request #600: DISPATCH-1463 - Add detection
for stuck deliveries
URL: https://github.com/apache/qpid-dispatch/pull/600#discussion_r339736259
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -570,6 +570,11 @@
"graph": true,
"description": "The total number of settled deliveries
that were held in the router for more than 10 seconds."
},
+"deliveriesStuck": {
+"type": "integer",
+"graph": true,
+"description": "The current number of deliveries that are
unsettled and have been held in the router for more than 10 seconds."
+},
Review comment:
Would you consider a 'peakDeliveriesStuck' stat?
Picture a network where some clients go down and zillions of deliveries get
stuck. Then those clients come back and the stuck number goes to zero. This
would provide some indication of an issue even though the current state is fine.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross reassigned DISPATCH-1409: -- Assignee: Ted Ross > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Assignee: Ted Ross >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #600: DISPATCH-1463 - Add detection for stuck deliveries
codecov-io edited a comment on issue #600: DISPATCH-1463 - Add detection for stuck deliveries URL: https://github.com/apache/qpid-dispatch/pull/600#issuecomment-546504990 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=h1) Report > Merging [#600](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/d37ee8c3ae0344e462d816c90db8a915588c2b1d?src=pr=desc) will **increase** coverage by `0.04%`. > The diff coverage is `97.61%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=tree) ```diff @@Coverage Diff @@ ## master #600 +/- ## == + Coverage 86.39% 86.44% +0.04% == Files 90 91 +1 Lines 2049520576 +81 == + Hits1770717787 +80 - Misses 2788 2789 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.88% <100%> (+0.15%)` | :arrow_up: | | [src/router\_core/router\_core\_thread.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlX3RocmVhZC5j) | `100% <100%> (ø)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `88.53% <100%> (+0.06%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `67.16% <100%> (+0.33%)` | :arrow_up: | | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `90.58% <100%> (+0.22%)` | :arrow_up: | | [...odules/stuck\_delivery\_detection/delivery\_tracker.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvc3R1Y2tfZGVsaXZlcnlfZGV0ZWN0aW9uL2RlbGl2ZXJ5X3RyYWNrZXIuYw==) | `96.42% <96.42%> (ø)` | | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.99% <0%> (-0.4%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.86% <0%> (-0.35%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.92% <0%> (-0.12%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.02%)` | :arrow_down: | | ... and [5 more](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=footer). Last update [d37ee8c...7cbbc73](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1463) Detect deliveries that are stuck in the router for a long time
[ https://issues.apache.org/jira/browse/DISPATCH-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961076#comment-16961076 ] ASF GitHub Bot commented on DISPATCH-1463: -- codecov-io commented on issue #600: DISPATCH-1463 - Add detection for stuck deliveries URL: https://github.com/apache/qpid-dispatch/pull/600#issuecomment-546504990 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=h1) Report > Merging [#600](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/d37ee8c3ae0344e462d816c90db8a915588c2b1d?src=pr=desc) will **increase** coverage by `0.04%`. > The diff coverage is `97.61%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=tree) ```diff @@Coverage Diff @@ ## master #600 +/- ## == + Coverage 86.39% 86.44% +0.04% == Files 90 91 +1 Lines 2049520576 +81 == + Hits1770717787 +80 - Misses 2788 2789 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.88% <100%> (+0.15%)` | :arrow_up: | | [src/router\_core/router\_core\_thread.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlX3RocmVhZC5j) | `100% <100%> (ø)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `88.53% <100%> (+0.06%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `67.16% <100%> (+0.33%)` | :arrow_up: | | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `90.58% <100%> (+0.22%)` | :arrow_up: | | [...odules/stuck\_delivery\_detection/delivery\_tracker.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvc3R1Y2tfZGVsaXZlcnlfZGV0ZWN0aW9uL2RlbGl2ZXJ5X3RyYWNrZXIuYw==) | `96.42% <96.42%> (ø)` | | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.99% <0%> (-0.4%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.86% <0%> (-0.35%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.92% <0%> (-0.12%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.02%)` | :arrow_down: | | ... and [5 more](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=footer). Last update [d37ee8c...7cbbc73](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Detect deliveries that are stuck in the router for a long time > -- > > Key: DISPATCH-1463 > URL: https://issues.apache.org/jira/browse/DISPATCH-1463 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Router Node >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major >
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961035#comment-16961035 ] Ted Ross commented on DISPATCH-1439: What kind of timestamps are desired/acceptable for this feature? Do you want to correlate the time to log entries? Is it acceptable to have "seconds since connection creation" and "seconds since last transfer"? The latter is more efficient to implement. > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Priority: Major > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1409) Update qdstat -l output to include the current credit
[ https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960877#comment-16960877 ] Keith Wall commented on DISPATCH-1409: -- I think a zero credit reached timestamp would need to be exposed. That way, tools consuming the output can distinguish those links that have languished with zero credit for a long time and may signify a problem in either application or router network itself. > Update qdstat -l output to include the current credit > - > > Key: DISPATCH-1409 > URL: https://issues.apache.org/jira/browse/DISPATCH-1409 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Tools >Affects Versions: 1.8.0 >Reporter: Ken Giusti >Priority: Major > Labels: troubleshooting > > The (cap) field in the output of qdstat -l shows the configured capacity for > the link, not the current credit available/outstanding. > In order to easily detect credit stalls it would be useful to provide the > current credit for the link. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
