[jira] [Commented] (DISPATCH-1913) All system tests that run qdstat/qdmanage fail on Ubuntu
[
https://issues.apache.org/jira/browse/DISPATCH-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268293#comment-17268293
]
ASF GitHub Bot commented on DISPATCH-1913:
--
asfgit closed pull request #989:
URL: https://github.com/apache/qpid-dispatch/pull/989
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> All system tests that run qdstat/qdmanage fail on Ubuntu
>
>
> Key: DISPATCH-1913
> URL: https://issues.apache.org/jira/browse/DISPATCH-1913
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Andrew Stitcher
>Priority: Major
>
> Lots of tests fail in travis with the following error -
> {noformat}
> AttributeError: 'str' object has no attribute 'path' {noformat}
>
> For example,
> {noformat}
> 34:
> ==34:
> ERROR: test_01_link_route
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify non-terminal state and data propagates over a link route
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2034, in test_01_link_route
> 34: self.RouterA.wait_address("RoutieMcRouteFace", remotes=1, count=2)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'
> 34:
> 34: ==
> 34: ERROR: test_03_multicast
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify that disposition state set by the publisher is available to all
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2061, in test_03_multicast
> 34: self.RouterA.wait_address("multicast/thingy", subscribers=3)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1913) All system tests that run qdstat/qdmanage fail on Ubuntu
[
https://issues.apache.org/jira/browse/DISPATCH-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268292#comment-17268292
]
ASF subversion and git services commented on DISPATCH-1913:
---
Commit ec39e5ed36d71b7c4b72a4d08521f109da0f3d7f in qpid-dispatch's branch
refs/heads/master from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=ec39e5e ]
DISPATCH-1913: Fix qdstat/some system tests
The Proton.Url class has been deprecated for a while now. Specifying connection
urls has been via strings in the Proton API since the deprecation.
This change avoids using the Url class to pass connection urls and also
doesn't assume that any connection urls returned from the API use the Url class.
Closes #989
> All system tests that run qdstat/qdmanage fail on Ubuntu
>
>
> Key: DISPATCH-1913
> URL: https://issues.apache.org/jira/browse/DISPATCH-1913
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Andrew Stitcher
>Priority: Major
>
> Lots of tests fail in travis with the following error -
> {noformat}
> AttributeError: 'str' object has no attribute 'path' {noformat}
>
> For example,
> {noformat}
> 34:
> ==34:
> ERROR: test_01_link_route
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify non-terminal state and data propagates over a link route
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2034, in test_01_link_route
> 34: self.RouterA.wait_address("RoutieMcRouteFace", remotes=1, count=2)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'
> 34:
> 34: ==
> 34: ERROR: test_03_multicast
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify that disposition state set by the publisher is available to all
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2061, in test_03_multicast
> 34: self.RouterA.wait_address("multicast/thingy", subscribers=3)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #989: DISPATCH-1913: Fix command line tools
asfgit closed pull request #989: URL: https://github.com/apache/qpid-dispatch/pull/989 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1921) Skupper 0.4: malloc corrupted handling back-to-back TCP connections
[ https://issues.apache.org/jira/browse/DISPATCH-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles E. Rolke updated DISPATCH-1921: --- Attachment: DISPATCH-1921_test_runner.sh > Skupper 0.4: malloc corrupted handling back-to-back TCP connections > --- > > Key: DISPATCH-1921 > URL: https://issues.apache.org/jira/browse/DISPATCH-1921 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Reporter: Charles E. Rolke >Priority: Major > Attachments: DISPATCH-1921_router-log.txt, > DISPATCH-1921_test_runner.sh, pub1.yaml, pub2.yaml > > > Running skupper 0.4. > * one kubernetes cluster > * two namespaces > * each namespace runs an iperf3 server > * skupper connected services sharing both servers in each namespace > Router fails with *malloc(): unsorted double linked list corrupted* > Files to be attached: > * server yaml definitions > * test shell script > The router appears to fail on the second attempt to receive a TCP adaptor > proxied service connection. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1921) Skupper 0.4: malloc corrupted handling back-to-back TCP connections
[ https://issues.apache.org/jira/browse/DISPATCH-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles E. Rolke updated DISPATCH-1921: --- Attachment: pub1.yaml pub2.yaml DISPATCH-1921_router-log.txt > Skupper 0.4: malloc corrupted handling back-to-back TCP connections > --- > > Key: DISPATCH-1921 > URL: https://issues.apache.org/jira/browse/DISPATCH-1921 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Reporter: Charles E. Rolke >Priority: Major > Attachments: DISPATCH-1921_router-log.txt, pub1.yaml, pub2.yaml > > > Running skupper 0.4. > * one kubernetes cluster > * two namespaces > * each namespace runs an iperf3 server > * skupper connected services sharing both servers in each namespace > Router fails with *malloc(): unsorted double linked list corrupted* > Files to be attached: > * server yaml definitions > * test shell script > The router appears to fail on the second attempt to receive a TCP adaptor > proxied service connection. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1921) Skupper 0.4: malloc corrupted handling back-to-back TCP connections
Charles E. Rolke created DISPATCH-1921: -- Summary: Skupper 0.4: malloc corrupted handling back-to-back TCP connections Key: DISPATCH-1921 URL: https://issues.apache.org/jira/browse/DISPATCH-1921 Project: Qpid Dispatch Issue Type: Bug Components: Protocol Adaptors Reporter: Charles E. Rolke Running skupper 0.4. * one kubernetes cluster * two namespaces * each namespace runs an iperf3 server * skupper connected services sharing both servers in each namespace Router fails with *malloc(): unsorted double linked list corrupted* Files to be attached: * server yaml definitions * test shell script The router appears to fail on the second attempt to receive a TCP adaptor proxied service connection. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1920) Enable TSAN tests in travis configuration
Ken Giusti created DISPATCH-1920: Summary: Enable TSAN tests in travis configuration Key: DISPATCH-1920 URL: https://issues.apache.org/jira/browse/DISPATCH-1920 Project: Qpid Dispatch Issue Type: Bug Components: Tests Affects Versions: 1.15.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.16.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1919) Thread race accessing qdr_delivery_t->conn_id and ->link_id
Ken Giusti created DISPATCH-1919: Summary: Thread race accessing qdr_delivery_t->conn_id and ->link_id Key: DISPATCH-1919 URL: https://issues.apache.org/jira/browse/DISPATCH-1919 Project: Qpid Dispatch Issue Type: Bug Components: Router Node Affects Versions: 1.15.0 Reporter: Ken Giusti Fix For: 1.16.0 71: == 71: WARNING: ThreadSanitizer: data race (pid=70857) 71: Write of size 8 at 0x7b4800013338 by thread T1: 71: #0 qdr_link_process_initial_delivery_CT /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:1651 (libqpid-dispatch.so+0x9ff1e) 71: #1 qdr_link_inbound_first_attach_CT /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:1779 (libqpid-dispatch.so+0x9ff1e) 71: #2 router_core_thread /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239 (libqpid-dispatch.so+0xbf09d) 71: #3 _thread_init /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x8c5f2) 71: #4 (libtsan.so.0+0x2d33f) 71: 71: Previous read of size 8 at 0x7b4800013338 by thread T4: 71: #0 qdr_tcp_open_server_side_connection /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:674 (libqpid-dispatch.so+0x50ca1) 71: #1 handle_connection_event /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:524 (libqpid-dispatch.so+0x55c45) 71: #2 handle_event_with_context /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:804 (libqpid-dispatch.so+0xe025d) 71: #3 do_handle_raw_connection_event /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:810 (libqpid-dispatch.so+0xe025d) 71: #4 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1090 (libqpid-dispatch.so+0xe025d) 71: #5 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1122 (libqpid-dispatch.so+0xe2aa7) 71: #6 _thread_init /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x8c5f2) 71: #7 (libtsan.so.0+0x2d33f) 71: 71: Location is heap block of size 384 at 0x7b4800013200 allocated by thread T4: 71: #0 posix_memalign (libtsan.so.0+0x3061d) 71: #1 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:388 (libqpid-dispatch.so+0x580a4) 71: #2 new_qdr_delivery_t /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c:23 (libqpid-dispatch.so+0xa7ca1) 71: #3 qdr_link_deliver_to_routed_link /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:117 (libqpid-dispatch.so+0xc50e9) 71: #4 AMQP_rx_handler /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:480 (libqpid-dispatch.so+0xd9e25) 71: #5 do_receive /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:223 (libqpid-dispatch.so+0x6cac4) 71: #6 qd_container_handle_event /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:733 (libqpid-dispatch.so+0x6cac4) 71: #7 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1097 (libqpid-dispatch.so+0xe0211) 71: #8 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1122 (libqpid-dispatch.so+0xe2a34) 71: #9 _thread_init /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x8c5f2) 71: #10 (libtsan.so.0+0x2d33f) 71: 71: Thread T1 (tid=70859, running) created by main thread at: 71: #0 pthread_create (libtsan.so.0+0x5ec29) 71: #1 sys_thread /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x8ca8e) 71: #2 qdr_core /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:121 (libqpid-dispatch.so+0xb9b16) 71: #3 qd_router_setup_late /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1989 (libqpid-dispatch.so+0xdc0f8) 71: #4 ffi_call_unix64 (libffi.so.6+0x6aef) 71: #5 main_process /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95 (qdrouterd+0x40281c) 71: #6 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367 (qdrouterd+0x4024fc) 71: 71: Thread T4 (tid=70862, running) created by main thread at: 71: #0 pthread_create (libtsan.so.0+0x5ec29) 71: #1 sys_thread /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x8ca8e) 71: #2 qd_server_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1482 (libqpid-dispatch.so+0xe350a) 71: #3 main_process /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:113 (qdrouterd+0x40287c) 71: #4 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367 (qdrouterd+0x4024fc) 71: 71: SUMMARY: ThreadSanitizer: data race /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:1651 in qdr_link_process_initial_delivery_CT 71: == 71: == 71: WARNING: ThreadSanitizer: data race (pid=70857) 71: Read of size 8 at 0x7b4800013338 by thread T4: 71: #0
[jira] [Created] (DISPATCH-1918) Thread race between I/O and Core over link->undelivered and unsettled lists
Ken Giusti created DISPATCH-1918: Summary: Thread race between I/O and Core over link->undelivered and unsettled lists Key: DISPATCH-1918 URL: https://issues.apache.org/jira/browse/DISPATCH-1918 Project: Qpid Dispatch Issue Type: Bug Components: Router Node Affects Versions: 1.15.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.16.0 70: WARNING: ThreadSanitizer: data race (pid=70705) 70: Read of size 8 at 0x7b540008eb68 by thread T1: 70: #0 qdr_forward_balanced_CT /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/forwarder.c:778 (libqpid-dispatch.so+0xb19c9) 70: #1 qdr_forward_message_CT /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/forwarder.c:1101 (libqpid-dispatch.so+0xb5160) 70: #2 qdr_link_forward_CT /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:566 (libqpid-dispatch.so+0xc69ad) 70: #3 qdr_link_deliver_CT /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:853 (libqpid-dispatch.so+0xc7bca) 70: #4 router_core_thread /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239 (libqpid-dispatch.so+0xbf09d) 70: #5 _thread_init /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x8c5f2) 70: #6 (libtsan.so.0+0x2d33f) 70: 70: Previous write of size 8 at 0x7b540008eb68 by thread T4 (mutexes: write M348): 70: #0 qdr_link_complete_sent_message /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:289 (libqpid-dispatch.so+0xc5ce8) 70: #1 _process_request /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http1/http1_server.c:715 (libqpid-dispatch.so+0x4d568) 70: #2 _handle_connection_events /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http1/http1_server.c:615 (libqpid-dispatch.so+0x4dd9a) 70: #3 handle_event_with_context /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:804 (libqpid-dispatch.so+0xe025d) 70: #4 do_handle_raw_connection_event /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:810 (libqpid-dispatch.so+0xe025d) 70: #5 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1090 (libqpid-dispatch.so+0xe025d) 70: #6 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1122 (libqpid-dispatch.so+0xe2aa7) 70: #7 _thread_init /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x8c5f2) 70: #8 (libtsan.so.0+0x2d33f) 70: 70: Location is heap block of size 576 at 0x7b540008ea80 allocated by thread T4: 70: #0 posix_memalign (libtsan.so.0+0x3061d) 70: #1 qd_alloc /home/kgiusti/work/dispatch/qpid-dispatch/src/alloc_pool.c:388 (libqpid-dispatch.so+0x580a4) 70: #2 new_qdr_link_t /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:32 (libqpid-dispatch.so+0xb8a01) 70: #3 qdr_link_first_attach /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:580 (libqpid-dispatch.so+0x9e6a6) 70: #4 _setup_server_links /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http1/http1_server.c:305 (libqpid-dispatch.so+0x4e855) 70: #5 _handle_connection_events /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http1/http1_server.c:485 (libqpid-dispatch.so+0x4e855) 70: #6 handle_event_with_context /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:804 (libqpid-dispatch.so+0xe025d) 70: #7 do_handle_raw_connection_event /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:810 (libqpid-dispatch.so+0xe025d) 70: #8 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1090 (libqpid-dispatch.so+0xe025d) 70: #9 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1122 (libqpid-dispatch.so+0xe2aa7) 70: #10 _thread_init /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x8c5f2) 70: #11 (libtsan.so.0+0x2d33f) 70: 70: Mutex M348 (0x7b109980) created at: 70: #0 pthread_mutex_init (libtsan.so.0+0x4a7c6) 70: #1 sys_mutex /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:43 (libqpid-dispatch.so+0x8c64c) 70: #2 qdr_connection_opened /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:110 (libqpid-dispatch.so+0x9caf6) 70: #3 _create_server_connection /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http1/http1_server.c:187 (libqpid-dispatch.so+0x4f0c9) 70: #4 qd_http1_configure_connector /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http1/http1_server.c:224 (libqpid-dispatch.so+0x4f0c9) 70: #5 qd_dispatch_configure_http_connector /home/kgiusti/work/dispatch/qpid-dispatch/src/adaptors/http_common.c:169 (libqpid-dispatch.so+0x3a1cd) 70: #6 ffi_call_unix64 (libffi.so.6+0x6aef) 70: #7 main_process /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95 (qdrouterd+0x40281c) 70: #8 main
[jira] [Created] (DISPATCH-1917) Thread race accessing connector->conn_msg buffer (TSAN)
Ken Giusti created DISPATCH-1917: Summary: Thread race accessing connector->conn_msg buffer (TSAN) Key: DISPATCH-1917 URL: https://issues.apache.org/jira/browse/DISPATCH-1917 Project: Qpid Dispatch Issue Type: Bug Components: Router Node Affects Versions: 1.15.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.16.0 qd_connector_t holds a buffer for connection related mgmt messages (conn_msg[300]). One thread can read it buffer content while another thread can write it: 14: WARNING: ThreadSanitizer: data race (pid=63992) 14: Read of size 8 at 0x7b440140 by main thread (mutexes: write M13, write M312, write M9): 14: #0 strlen (libtsan.so.0+0x32c4f) 14: #1 PyUnicode_FromString (libpython3.8.so.1.0+0xf8a58) 14: #2 qd_entity_refresh_connector /home/kgiusti/work/dispatch/qpid-dispatch/src/connection_manager.c:868 (libqpid-dispatch.so+0x68522) 14: #3 ffi_call_unix64 (libffi.so.6+0x6aef) 14: #4 qdr_forward_on_message /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/forwarder.c:336 (libqpid-dispatch.so+0xb083c) 14: #5 qdr_general_handler /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core.c:887 (libqpid-dispatch.so+0xb9189) 14: #6 qd_timer_visit /home/kgiusti/work/dispatch/qpid-dispatch/src/timer.c:201 (libqpid-dispatch.so+0xe60c7) 14: #7 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1008 (libqpid-dispatch.so+0xe01ae) 14: #8 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1122 (libqpid-dispatch.so+0xe2aa7) 14: #9 qd_server_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1484 (libqpid-dispatch.so+0xe352f) 14: #10 main_process /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:113 (qdrouterd+0x40287c) 14: #11 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367 (qdrouterd+0x4024fc) 14: 14: Previous write of size 8 at 0x7b440140 by thread T3: 14: #0 strcpy (libtsan.so.0+0x45ac1) 14: #1 AMQP_opened_handler /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1241 (libqpid-dispatch.so+0xdad01) 14: #2 AMQP_outbound_opened_handler /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1402 (libqpid-dispatch.so+0xdba43) 14: #3 notify_opened /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:273 (libqpid-dispatch.so+0x69fa3) 14: #4 policy_notify_opened /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:284 (libqpid-dispatch.so+0x69fa3) 14: #5 qd_policy_amqp_open_connector /home/kgiusti/work/dispatch/qpid-dispatch/src/policy.c:1371 (libqpid-dispatch.so+0x881fa) 14: #6 qd_container_handle_event /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:511 (libqpid-dispatch.so+0x6c984) 14: #7 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1097 (libqpid-dispatch.so+0xe0211) 14: #8 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1122 (libqpid-dispatch.so+0xe2a34) 14: #9 _thread_init /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x8c5f2) 14: #10 (libtsan.so.0+0x2d33f) 14: 14: Location is heap block of size 300 at 0x7b440140 allocated by main thread: 14: #0 malloc (libtsan.so.0+0x304d3) 14: #1 qd_server_connector /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1657 (libqpid-dispatch.so+0xe49d4) 14: #2 qd_dispatch_configure_connector /home/kgiusti/work/dispatch/qpid-dispatch/src/connection_manager.c:878 (libqpid-dispatch.so+0x6856d) 14: #3 ffi_call_unix64 (libffi.so.6+0x6aef) 14: #4 main_process /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:95 (qdrouterd+0x40281c) 14: #5 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367 (qdrouterd+0x4024fc) 14: 14: Mutex M13 (0x7b100340) created at: 14: #0 pthread_mutex_init (libtsan.so.0+0x4a7c6) 14: #1 sys_mutex /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:43 (libqpid-dispatch.so+0x8c64c) 14: #2 qd_python_initialize /home/kgiusti/work/dispatch/qpid-dispatch/src/python_embedded.c:56 (libqpid-dispatch.so+0x8ebb3) 14: #3 qd_dispatch /home/kgiusti/work/dispatch/qpid-dispatch/src/dispatch.c:108 (libqpid-dispatch.so+0x6e526) 14: #4 main_process /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:90 (qdrouterd+0x4027b9) 14: #5 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:367 (qdrouterd+0x4024fc) 14: 14: Mutex M312 (0x7b103040) created at: 14: #0 pthread_mutex_init (libtsan.so.0+0x4a7c6) 14: #1 sys_mutex /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:43 (libqpid-dispatch.so+0x8c64c) 14: #2 qd_router /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1484 (libqpid-dispatch.so+0xdbdbf) 14: #3 qd_dispatch_prepare /home/kgiusti/work/dispatch/qpid-dispatch/src/dispatch.c:332 (libqpid-dispatch.so+0x6e13f) 14: #4 ffi_call_unix64 (libffi.so.6+0x6aef)
[jira] [Commented] (DISPATCH-1818) HTTP1.x raw connection buffer leak on shutdown
[ https://issues.apache.org/jira/browse/DISPATCH-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268167#comment-17268167 ] ASF GitHub Bot commented on DISPATCH-1818: -- kgiusti closed pull request #906: URL: https://github.com/apache/qpid-dispatch/pull/906 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > HTTP1.x raw connection buffer leak on shutdown > -- > > Key: DISPATCH-1818 > URL: https://issues.apache.org/jira/browse/DISPATCH-1818 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Fix For: 1.15.0 > > > During shutdown all buffers that have been given to the proton raw connection > (read and write buffers) need to be cleaned up manually since there will > never be an event indicating the buffers need freeing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1818) HTTP1.x raw connection buffer leak on shutdown
[ https://issues.apache.org/jira/browse/DISPATCH-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268168#comment-17268168 ] ASF GitHub Bot commented on DISPATCH-1818: -- kgiusti commented on pull request #906: URL: https://github.com/apache/qpid-dispatch/pull/906#issuecomment-763071635 Obsolete - abandoned This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > HTTP1.x raw connection buffer leak on shutdown > -- > > Key: DISPATCH-1818 > URL: https://issues.apache.org/jira/browse/DISPATCH-1818 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Fix For: 1.15.0 > > > During shutdown all buffers that have been given to the proton raw connection > (read and write buffers) need to be cleaned up manually since there will > never be an event indicating the buffers need freeing. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #906: DISPATCH-1818: HTTP/1.x manual buffer cleanup on shutdown
kgiusti closed pull request #906: URL: https://github.com/apache/qpid-dispatch/pull/906 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #906: DISPATCH-1818: HTTP/1.x manual buffer cleanup on shutdown
kgiusti commented on pull request #906: URL: https://github.com/apache/qpid-dispatch/pull/906#issuecomment-763071635 Obsolete - abandoned This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1916) Coverity flags use-after-free errors on delivery decref
[ https://issues.apache.org/jira/browse/DISPATCH-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268160#comment-17268160 ] ASF GitHub Bot commented on DISPATCH-1916: -- kgiusti opened a new pull request #990: URL: https://github.com/apache/qpid-dispatch/pull/990 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Coverity flags use-after-free errors on delivery decref > --- > > Key: DISPATCH-1916 > URL: https://issues.apache.org/jira/browse/DISPATCH-1916 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.15.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #990: DISPATCH-1916: fixes for coverity use-after-free errors
kgiusti opened a new pull request #990: URL: https://github.com/apache/qpid-dispatch/pull/990 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1916) Coverity flags use-after-free errors on delivery decref
Ken Giusti created DISPATCH-1916: Summary: Coverity flags use-after-free errors on delivery decref Key: DISPATCH-1916 URL: https://issues.apache.org/jira/browse/DISPATCH-1916 Project: Qpid Dispatch Issue Type: Bug Components: Router Node Affects Versions: 1.15.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 1.15.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1913) All system tests that run qdstat/qdmanage fail on Ubuntu
[
https://issues.apache.org/jira/browse/DISPATCH-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268135#comment-17268135
]
ASF GitHub Bot commented on DISPATCH-1913:
--
astitcher commented on a change in pull request #989:
URL: https://github.com/apache/qpid-dispatch/pull/989#discussion_r560401706
##
File path: tools/qdstat.in
##
@@ -44,18 +44,17 @@ from qpid_dispatch_internal.compat import UNICODE
def get(obj, attr):
return getattr(obj, attr, None)
-class BusManager(Node):
+class BusManager():
Review comment:
@jiridanek Thanks for the pointers! I was wrong about new style classes.
I did a quick grep and there are a bunch of old style classes in this code
base. For leaf classes (actually such as this one) I'm not sure it's that
important as the differences seem to mostly be about metaclass and inheritance
features.
I'll change this PR before I merge it though.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> All system tests that run qdstat/qdmanage fail on Ubuntu
>
>
> Key: DISPATCH-1913
> URL: https://issues.apache.org/jira/browse/DISPATCH-1913
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Andrew Stitcher
>Priority: Major
>
> Lots of tests fail in travis with the following error -
> {noformat}
> AttributeError: 'str' object has no attribute 'path' {noformat}
>
> For example,
> {noformat}
> 34:
> ==34:
> ERROR: test_01_link_route
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify non-terminal state and data propagates over a link route
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2034, in test_01_link_route
> 34: self.RouterA.wait_address("RoutieMcRouteFace", remotes=1, count=2)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'
> 34:
> 34: ==
> 34: ERROR: test_03_multicast
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify that disposition state set by the publisher is available to all
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2061, in test_03_multicast
> 34: self.RouterA.wait_address("multicast/thingy", subscribers=3)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
>
[GitHub] [qpid-dispatch] astitcher commented on a change in pull request #989: DISPATCH-1913: Fix command line tools
astitcher commented on a change in pull request #989: URL: https://github.com/apache/qpid-dispatch/pull/989#discussion_r560401706 ## File path: tools/qdstat.in ## @@ -44,18 +44,17 @@ from qpid_dispatch_internal.compat import UNICODE def get(obj, attr): return getattr(obj, attr, None) -class BusManager(Node): +class BusManager(): Review comment: @jiridanek Thanks for the pointers! I was wrong about new style classes. I did a quick grep and there are a bunch of old style classes in this code base. For leaf classes (actually such as this one) I'm not sure it's that important as the differences seem to mostly be about metaclass and inheritance features. I'll change this PR before I merge it though. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1913) All system tests that run qdstat/qdmanage fail on Ubuntu
[
https://issues.apache.org/jira/browse/DISPATCH-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268092#comment-17268092
]
ASF GitHub Bot commented on DISPATCH-1913:
--
jiridanek commented on a change in pull request #989:
URL: https://github.com/apache/qpid-dispatch/pull/989#discussion_r560376141
##
File path: tools/qdstat.in
##
@@ -44,18 +44,17 @@ from qpid_dispatch_internal.compat import UNICODE
def get(obj, attr):
return getattr(obj, attr, None)
-class BusManager(Node):
+class BusManager():
Review comment:
I'm with Ken here.
https://docs.python.org/2.7/glossary.html#term-new-style-class and
https://docs.python.org/2.7/reference/datamodel.html#newstyle state that you
have to inherit from _object_ to get a new-style class. That is true even in
Python 2.7.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> All system tests that run qdstat/qdmanage fail on Ubuntu
>
>
> Key: DISPATCH-1913
> URL: https://issues.apache.org/jira/browse/DISPATCH-1913
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Andrew Stitcher
>Priority: Major
>
> Lots of tests fail in travis with the following error -
> {noformat}
> AttributeError: 'str' object has no attribute 'path' {noformat}
>
> For example,
> {noformat}
> 34:
> ==34:
> ERROR: test_01_link_route
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify non-terminal state and data propagates over a link route
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2034, in test_01_link_route
> 34: self.RouterA.wait_address("RoutieMcRouteFace", remotes=1, count=2)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'
> 34:
> 34: ==
> 34: ERROR: test_03_multicast
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify that disposition state set by the publisher is available to all
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2061, in test_03_multicast
> 34: self.RouterA.wait_address("multicast/thingy", subscribers=3)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection,
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #989: DISPATCH-1913: Fix command line tools
jiridanek commented on a change in pull request #989: URL: https://github.com/apache/qpid-dispatch/pull/989#discussion_r560376141 ## File path: tools/qdstat.in ## @@ -44,18 +44,17 @@ from qpid_dispatch_internal.compat import UNICODE def get(obj, attr): return getattr(obj, attr, None) -class BusManager(Node): +class BusManager(): Review comment: I'm with Ken here. https://docs.python.org/2.7/glossary.html#term-new-style-class and https://docs.python.org/2.7/reference/datamodel.html#newstyle state that you have to inherit from _object_ to get a new-style class. That is true even in Python 2.7. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2325) Crash when closing application using Qpid Proton Cpp 0.25.0
[
https://issues.apache.org/jira/browse/PROTON-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268014#comment-17268014
]
Koen commented on PROTON-2325:
--
Hi Jiri,
Thanks for your answer. Unfortunately I don't have a minimal example to
reproduce this issue. It's also very uncommon and happens not so many times.
That makes it hard for me to actually find the bug. I'm now busy upgrading to a
newer qpid version, that also has some troubles. Still have to fix those, so
will come back to you if the problem still exists in newer versions.
> Crash when closing application using Qpid Proton Cpp 0.25.0
> ---
>
> Key: PROTON-2325
> URL: https://issues.apache.org/jira/browse/PROTON-2325
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Koen
>Priority: Major
>
> Hello,
> I'm having a problem with Qpid-proton-cpp version 0.25.0 and was wondering if
> this was already solved in a newer version.
> When I shutdown the application, it crashes sometimes (1 time in 40
> shutdown's) and generates the following stacktrace:
>
>
> {code:java}
> #0 0x in ?? ()
> #1 0xf325203e in pn_class_decref (clazz=0xee100fb0, object=0xee100738) at
> /opt/jenkins_home/workspace/Qpid_release_build/qpid-proton-src/c/src/core/object/object.c:91
> #2 0xf32522ce in pn_decref (object=0xee100738) at
> /opt/jenkins_home/workspace/Qpid_release_build/qpid-proton-src/c/src/core/object/object.c:253
> #3 0xf3ee0b50 in proton::internal::pn_ptr_base::decref (p=0xee100738) at
> /opt/jenkins_home/workspace/Qpid_release_build/qpid-proton-src/cpp/src/object.cpp:31
> #4 0x08eca58e in proton::internal::pn_ptr::~pn_ptr
> (this=0xaf5eeac, __in_chrg=) at
> /opt/qpid-itr/include/proton/internal/object.hpp:55
> #5 0x08ec7004 in proton::internal::object::~object
> (this=0xaf5eeac, __in_chrg=) at
> /opt/qpid-itr/include/proton/internal/object.hpp:86
> #6 0x08ede3be in proton::connection::~connection (this=0xaf5eea8,
> __in_chrg=) at /opt/qpid-itr/include/proton/connection.hpp:45
> #7 REST OF THE STACKTRACE
> {code}
>
> I looked through my own code and didn't find anything that would cause this
> issue so I was wondering if the stacktrace is known and fixed in newer
> version of qpid.
> I ran my application through valgrind, but valgrind didn't find the memory
> leak. That could be due to not crashing all the time.
> It looks like a double free (pni_head_t) happening inside qpid. Although I'm
> not entirely sure..
> I was also curious if the number of items in this list needs to be
> decremented every time when calling the pni_free_children destructor
> {code:java}
> Function:
> static void pni_free_children(pn_list_t *children, pn_list_t *freed)
> while (pn_list_size(children) > 0) { //added printf to print the children
> pointers and there list size.
> #pn_list_size(children) for list size
> #printing pointer = children
> Output:
> children = 0xd039d4d8, list size = 1
> children = 0xedc00a50, list size = 2568
> children = 0xedc0c938, list size = 1
> children = 0xedc00a50, list size = 2567
> children = 0xedc0f890, list size = 18
> children = 0xedc0f890, list size = 17
> children = 0xedc0f890, list size = 17 <==This would need to be 16 right?
> Received signal: Segmentation fault (11)
> STACKTRACE:
> #1 ip=0x08a5f37f sp=0xef5f0d70 backtrace::SignalHandler(int)
> + 0x7f
> #2 ip=0xf76e2410 sp=0xef5f0d80 + 0x7f
> #3 ip=0xedc01858 sp=0xef5f135c + 0x7f
> #4 ip=0x6e657264 sp=0xf34512bc + 0x7f
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2326) epoll proactor housecleaning
Clifford Jansen created PROTON-2326: --- Summary: epoll proactor housecleaning Key: PROTON-2326 URL: https://issues.apache.org/jira/browse/PROTON-2326 Project: Qpid Proton Issue Type: Improvement Components: proton-c Affects Versions: proton-c-0.33.0 Environment: Linux systems with epoll. Reporter: Clifford Jansen Assignee: Clifford Jansen Improve clarity and maintainability of code. Replace overloaded naming (i.e. "wake", "context") with less ambiguous terms. Rationalize comments over many previous internal refactors. Consolidate wake/wakeable concept at the task level rather than as separate implementations per task type. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1915) Remove deprecated Proton Url python class
Ken Giusti created DISPATCH-1915: Summary: Remove deprecated Proton Url python class Key: DISPATCH-1915 URL: https://issues.apache.org/jira/browse/DISPATCH-1915 Project: Qpid Dispatch Issue Type: Task Components: Routing Engine, Tools Affects Versions: 1.16.0 Reporter: Ken Giusti Fix For: 1.16.0 This has been deprecated since Proton 0.27.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1913) All system tests that run qdstat/qdmanage fail on Ubuntu
[
https://issues.apache.org/jira/browse/DISPATCH-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267975#comment-17267975
]
ASF GitHub Bot commented on DISPATCH-1913:
--
astitcher commented on a change in pull request #989:
URL: https://github.com/apache/qpid-dispatch/pull/989#discussion_r560273369
##
File path: tools/qdstat.in
##
@@ -44,18 +44,17 @@ from qpid_dispatch_internal.compat import UNICODE
def get(obj, attr):
return getattr(obj, attr, None)
-class BusManager(Node):
+class BusManager():
Review comment:
I guess I meant shouldn't this just be: ```class BusManager:``` - I'm
pretty sure this works even in python 2.7. What you say was true for much
earlier versions of python.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> All system tests that run qdstat/qdmanage fail on Ubuntu
>
>
> Key: DISPATCH-1913
> URL: https://issues.apache.org/jira/browse/DISPATCH-1913
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Andrew Stitcher
>Priority: Major
>
> Lots of tests fail in travis with the following error -
> {noformat}
> AttributeError: 'str' object has no attribute 'path' {noformat}
>
> For example,
> {noformat}
> 34:
> ==34:
> ERROR: test_01_link_route
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify non-terminal state and data propagates over a link route
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2034, in test_01_link_route
> 34: self.RouterA.wait_address("RoutieMcRouteFace", remotes=1, count=2)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'
> 34:
> 34: ==
> 34: ERROR: test_03_multicast
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify that disposition state set by the publisher is available to all
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2061, in test_03_multicast
> 34: self.RouterA.wait_address("multicast/thingy", subscribers=3)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'{noformat}
[GitHub] [qpid-dispatch] astitcher commented on a change in pull request #989: DISPATCH-1913: Fix command line tools
astitcher commented on a change in pull request #989: URL: https://github.com/apache/qpid-dispatch/pull/989#discussion_r560273369 ## File path: tools/qdstat.in ## @@ -44,18 +44,17 @@ from qpid_dispatch_internal.compat import UNICODE def get(obj, attr): return getattr(obj, attr, None) -class BusManager(Node): +class BusManager(): Review comment: I guess I meant shouldn't this just be: ```class BusManager:``` - I'm pretty sure this works even in python 2.7. What you say was true for much earlier versions of python. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1913) All system tests that run qdstat/qdmanage fail on Ubuntu
[
https://issues.apache.org/jira/browse/DISPATCH-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267969#comment-17267969
]
ASF GitHub Bot commented on DISPATCH-1913:
--
astitcher commented on a change in pull request #989:
URL: https://github.com/apache/qpid-dispatch/pull/989#discussion_r560264555
##
File path: tools/qdstat.in
##
@@ -44,18 +44,17 @@ from qpid_dispatch_internal.compat import UNICODE
def get(obj, attr):
return getattr(obj, attr, None)
-class BusManager(Node):
+class BusManager():
Review comment:
Is that necessary for python 3? Also might want that change consistently
through the file if you think it's necessary.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> All system tests that run qdstat/qdmanage fail on Ubuntu
>
>
> Key: DISPATCH-1913
> URL: https://issues.apache.org/jira/browse/DISPATCH-1913
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Andrew Stitcher
>Priority: Major
>
> Lots of tests fail in travis with the following error -
> {noformat}
> AttributeError: 'str' object has no attribute 'path' {noformat}
>
> For example,
> {noformat}
> 34:
> ==34:
> ERROR: test_01_link_route
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify non-terminal state and data propagates over a link route
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2034, in test_01_link_route
> 34: self.RouterA.wait_address("RoutieMcRouteFace", remotes=1, count=2)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'
> 34:
> 34: ==
> 34: ERROR: test_03_multicast
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify that disposition state set by the publisher is available to all
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2061, in test_03_multicast
> 34: self.RouterA.wait_address("multicast/thingy", subscribers=3)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [qpid-dispatch] astitcher commented on a change in pull request #989: DISPATCH-1913: Fix command line tools
astitcher commented on a change in pull request #989: URL: https://github.com/apache/qpid-dispatch/pull/989#discussion_r560264555 ## File path: tools/qdstat.in ## @@ -44,18 +44,17 @@ from qpid_dispatch_internal.compat import UNICODE def get(obj, attr): return getattr(obj, attr, None) -class BusManager(Node): +class BusManager(): Review comment: Is that necessary for python 3? Also might want that change consistently through the file if you think it's necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1829) multi-hop TCP does not seem to work
[ https://issues.apache.org/jira/browse/DISPATCH-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved DISPATCH-1829. -- Resolution: Fixed > multi-hop TCP does not seem to work > --- > > Key: DISPATCH-1829 > URL: https://issues.apache.org/jira/browse/DISPATCH-1829 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Reporter: Gordon Sim >Priority: Major > Fix For: 1.15.0 > > > Attempting to connect through a chain of three routers, > ingress->interior->egress, does not work. This seems to be independent of > whether the ingress and egress routers are edge or interior mode. However > connecting with TCP through the interior to egress does work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-1903) Remote upload of certificate files for new TLS configurations
[ https://issues.apache.org/jira/browse/DISPATCH-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross updated DISPATCH-1903: --- Fix Version/s: (was: 1.15.0) 1.16.0 > Remote upload of certificate files for new TLS configurations > - > > Key: DISPATCH-1903 > URL: https://issues.apache.org/jira/browse/DISPATCH-1903 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Container >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.16.0 > > > Currently, when using the management protocol to create new SSL-profiles, > those profiles must access certificate files that are already placed in the > file system. In other words, in order to create an SSL-profile on a running > router, files must first be placed on the file system in a location > accessible by the router. This may be problematic in cases where the router > is remote from the managing agent, or when containerization limits access to > the router's underlying file system. > This new feature allows a managing agent to remotely inject files into a > running router to be stored in temporary file storage. These files are > usable in sslProfile management entities (by specifying the files without an > absolute path). The temporary files are removed from the file system on > router shutdown. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1913) All system tests that run qdstat/qdmanage fail on Ubuntu
[
https://issues.apache.org/jira/browse/DISPATCH-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267950#comment-17267950
]
ASF GitHub Bot commented on DISPATCH-1913:
--
kgiusti commented on a change in pull request #989:
URL: https://github.com/apache/qpid-dispatch/pull/989#discussion_r560238981
##
File path: tools/qdstat.in
##
@@ -44,18 +44,17 @@ from qpid_dispatch_internal.compat import UNICODE
def get(obj, attr):
return getattr(obj, attr, None)
-class BusManager(Node):
+class BusManager():
Review comment:
make this a subclass of object: "class BusManager(object):"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> All system tests that run qdstat/qdmanage fail on Ubuntu
>
>
> Key: DISPATCH-1913
> URL: https://issues.apache.org/jira/browse/DISPATCH-1913
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Andrew Stitcher
>Priority: Major
>
> Lots of tests fail in travis with the following error -
> {noformat}
> AttributeError: 'str' object has no attribute 'path' {noformat}
>
> For example,
> {noformat}
> 34:
> ==34:
> ERROR: test_01_link_route
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify non-terminal state and data propagates over a link route
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2034, in test_01_link_route
> 34: self.RouterA.wait_address("RoutieMcRouteFace", remotes=1, count=2)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'
> 34:
> 34: ==
> 34: ERROR: test_03_multicast
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify that disposition state set by the publisher is available to all
> 34: --
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2061, in test_03_multicast
> 34: self.RouterA.wait_address("multicast/thingy", subscribers=3)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #989: DISPATCH-1913: Fix command line tools
kgiusti commented on a change in pull request #989: URL: https://github.com/apache/qpid-dispatch/pull/989#discussion_r560238981 ## File path: tools/qdstat.in ## @@ -44,18 +44,17 @@ from qpid_dispatch_internal.compat import UNICODE def get(obj, attr): return getattr(obj, attr, None) -class BusManager(Node): +class BusManager(): Review comment: make this a subclass of object: "class BusManager(object):" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
