[jira] [Resolved] (PROTON-2452) Connection Dynamic Receiver create API not applying user configuration in all cases
[ https://issues.apache.org/jira/browse/PROTON-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy A. Bish resolved PROTON-2452. - Resolution: Fixed > Connection Dynamic Receiver create API not applying user configuration in all > cases > --- > > Key: PROTON-2452 > URL: https://issues.apache.org/jira/browse/PROTON-2452 > Project: Qpid Proton > Issue Type: Bug > Components: protonj2 >Affects Versions: protonj2-1.0.0-M3 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: protonj2-1.0.0-M4 > > > Two of the three flavors of dynamic receiver creation APIs from the > connection object are not properly passing along the provided node properties > or receiver options as they should. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2452) Connection Dynamic Receiver create API not applying user configuration in all cases
[ https://issues.apache.org/jira/browse/PROTON-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436985#comment-17436985 ] ASF subversion and git services commented on PROTON-2452: - Commit aa2a538085e974240d1ffe0420e5a4ca67bf207a in qpid-protonj2's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=aa2a538 ] PROTON-2452 Pass along node properties and receiver options to create When creating a dynamic receiver with dynamic node properties or with receiver options only, ensure the values are passed along to the full fledged API that is being called to do the work. > Connection Dynamic Receiver create API not applying user configuration in all > cases > --- > > Key: PROTON-2452 > URL: https://issues.apache.org/jira/browse/PROTON-2452 > Project: Qpid Proton > Issue Type: Bug > Components: protonj2 >Affects Versions: protonj2-1.0.0-M3 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: protonj2-1.0.0-M4 > > > Two of the three flavors of dynamic receiver creation APIs from the > connection object are not properly passing along the provided node properties > or receiver options as they should. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2452) Connection Dynamic Receiver create API not applying user configuration in all cases
Timothy A. Bish created PROTON-2452: --- Summary: Connection Dynamic Receiver create API not applying user configuration in all cases Key: PROTON-2452 URL: https://issues.apache.org/jira/browse/PROTON-2452 Project: Qpid Proton Issue Type: Bug Components: protonj2 Affects Versions: protonj2-1.0.0-M3 Reporter: Timothy A. Bish Assignee: Timothy A. Bish Fix For: protonj2-1.0.0-M4 Two of the three flavors of dynamic receiver creation APIs from the connection object are not properly passing along the provided node properties or receiver options as they should. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2406) [cpp] Use of reconnect_options::failover_urls triggers -Wdeprecated-declarations in examples/cpp/reconnect_client.cpp
[
https://issues.apache.org/jira/browse/PROTON-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436982#comment-17436982
]
ASF GitHub Bot commented on PROTON-2406:
cliffjansen commented on pull request #337:
URL: https://github.com/apache/qpid-proton/pull/337#issuecomment-956502433
As I read the documentation for reconnect_url() and failover_urls() I
implicitly expect the same intention for:
- default reconnect timing options
- change via update_options()
even though it is only explicitly spelled out for the former and may not
make sense in all permutations for the latter. Perhaps the documentation
should be made explicit for failover_urls().
Regardless, I think I would expect this example to have no reference to
reconnect_options unless non-default values were being set and no call made to
connection::reconnect().
The segfault appears to be from a missing argument where argc is one short
to catch the expected number of input parameters. However, it may also be a
failing in the library to not robustly handle an empty vector properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cpp] Use of reconnect_options::failover_urls triggers
> -Wdeprecated-declarations in examples/cpp/reconnect_client.cpp
> -
>
> Key: PROTON-2406
> URL: https://issues.apache.org/jira/browse/PROTON-2406
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding, examples
>Affects Versions: proton-c-0.36.0
>Reporter: Jiri Daněk
>Assignee: Rakhi Kumari
>Priority: Minor
> Fix For: proton-c-0.37.0
>
>
> {noformat}
> [ 56%] Building CXX object
> CMakeFiles/reconnect_client.dir/reconnect_client.cpp.o
> /usr/share/proton/examples/cpp/reconnect_client.cpp: In member function
> ‘virtual void reconnect_client::on_container_start(proton::container&)’:
> /usr/share/proton/examples/cpp/reconnect_client.cpp:59:35: warning:
> ‘proton::reconnect_options& proton::reconnect_options::failover_urls(const
> std::vector >&)’ is deprecated (declared at
> /usr/include/proton/reconnect_options.hpp:82): use
> connection_options::failover_urls() [-Wdeprecated-declarations]
> ro.failover_urls(failovers);
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] cliffjansen commented on pull request #337: PROTON-2406: [cpp] Replace uses of deprecated reconnect_options::failover_urls with conn…
cliffjansen commented on pull request #337: URL: https://github.com/apache/qpid-proton/pull/337#issuecomment-956502433 As I read the documentation for reconnect_url() and failover_urls() I implicitly expect the same intention for: - default reconnect timing options - change via update_options() even though it is only explicitly spelled out for the former and may not make sense in all permutations for the latter. Perhaps the documentation should be made explicit for failover_urls(). Regardless, I think I would expect this example to have no reference to reconnect_options unless non-default values were being set and no call made to connection::reconnect(). The segfault appears to be from a missing argument where argc is one short to catch the expected number of input parameters. However, it may also be a failing in the library to not robustly handle an empty vector properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2085) system_tests_fallback_dest failure - addr_proxy.c:323: on_conn_event: Assertion `addr->edge_outlink == 0' failed
[
https://issues.apache.org/jira/browse/DISPATCH-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436970#comment-17436970
]
ASF subversion and git services commented on DISPATCH-2085:
---
Commit 7ef3387c74d1a9f3cf18161b5e78adcc86293809 in qpid-dispatch's branch
refs/heads/main from Ken Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=7ef3387 ]
DISPATCH-2085: remove bad assertion in addr_proxy connection handler
> system_tests_fallback_dest failure - addr_proxy.c:323: on_conn_event:
> Assertion `addr->edge_outlink == 0' failed
>
>
> Key: DISPATCH-2085
> URL: https://issues.apache.org/jira/browse/DISPATCH-2085
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.18.0
>
>
> First spotted on s390x,
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501153572#L6607
> {noformat}
> 62: Router EA2 output file:
> 62:
> 62: 2021-04-26 16:56:05.615255 + AGENT (warning) Attribute 'dir' of
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 62: 2021-04-26 16:56:05.615411 + AGENT (warning) Attribute 'dir' of
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 62: qdrouterd:
> /home/travis/build/apache/qpid-dispatch/src/router_core/modules/edge_router/addr_proxy.c:323:
> on_conn_event: Assertion `addr->edge_outlink == 0' failed.
> 62:
> 62:
> 62:
> 62: Router EA2 command file:
> 62:
> 62: qdrouterd -c EA2.conf -I /home/travis/build/apache/qpid-dispatch/python
> 62: pid=14036
> 62:
> 62:
> 62:
> 62: Router EA2 log file tail:
> 62:
> 62: 2021-04-26 16:58:05.686184 + ROUTER_CORE (trace) Core action
> 'link_detach'
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 62: 2021-04-26 16:58:05.686235 + ROUTER_CORE (info) [C4][L12] Link lost:
> del=1 presett=1 psdrop=0 acc=0 rej=0 rel=0 mod=0 delay1=0 delay10=0
> blocked=no
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1074)
> 62: 2021-04-26 16:58:05.686281 + ROUTER_CORE (trace) Core action
> 'connection_closed'
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 62: 2021-04-26 16:58:05.686346 + ROUTER_CORE (info) [C4] Connection
> Closed
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1557)
> 62: 2021-04-26 16:58:05.705484 + SERVER (trace) Accepting connection on
> 0.0.0.0:23020 (/home/travis/build/apache/qpid-dispatch/src/server.c:852)
> 62: 2021-04-26 16:58:05.705577 + SERVER (trace) [C5]: Accepting incoming
> connection to '0.0.0.0:23020'
> (/home/travis/build/apache/qpid-dispatch/src/server.c:606)
> 62: 2021-04-26 16:58:05.705691 + POLICY (trace) ALLOW Connection
> '127.0.0.1' based on global connection count. nConnections= 1
> (/home/travis/build/apache/qpid-dispatch/src/policy.c:271)
> 62: 2021-04-26 16:58:05.705782 + SERVER (info) [C5] Accepted connection
> to 0.0.0.0:23020 from 127.0.0.1:37922
> (/home/travis/build/apache/qpid-dispatch/src/server.c:750)
> 62: 2021-04-26 16:58:05.706152 + PROTOCOL (trace) [C5]:FRAME: <- SASL
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706180 + PROTOCOL (trace) [C5]:FRAME: -> SASL
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706590 + PROTOCOL (trace) [C5]:FRAME: 0 ->
> @sasl-mechanisms(64) [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706949 + PROTOCOL (trace) [C5]:FRAME: 0 <-
> @sasl-init(65) [mechanism=:ANONYMOUS,
> initial-response=b"anonymous@travis-job-apache-qpid-dispatch-501153572"]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707025 + PROTOCOL (trace) [C5]:FRAME: 0 ->
> @sasl-outcome(68) [code=0]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707319 + PROTOCOL (trace) [C5]:FRAME: <- AMQP
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707363 + PROTOCOL (trace) [C5]:FRAME: 0 <-
> @open(16) [container-id="ac3fab39-661e-44f4-8361-5866a600788d",
> hostname="0.0.0.0", channel-max=32767]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707432 + PROTOCOL (trace) [C5]:FRAME: 0 <-
> @begin(17) [next-outgoing-id=0, incoming-window=2147483647,
> outgoing-window=2147483647]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707500 + PROTOCOL (trace)
[jira] [Commented] (DISPATCH-2085) system_tests_fallback_dest failure - addr_proxy.c:323: on_conn_event: Assertion `addr->edge_outlink == 0' failed
[
https://issues.apache.org/jira/browse/DISPATCH-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436968#comment-17436968
]
ASF GitHub Bot commented on DISPATCH-2085:
--
kgiusti merged pull request #1415:
URL: https://github.com/apache/qpid-dispatch/pull/1415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_fallback_dest failure - addr_proxy.c:323: on_conn_event:
> Assertion `addr->edge_outlink == 0' failed
>
>
> Key: DISPATCH-2085
> URL: https://issues.apache.org/jira/browse/DISPATCH-2085
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.18.0
>
>
> First spotted on s390x,
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501153572#L6607
> {noformat}
> 62: Router EA2 output file:
> 62:
> 62: 2021-04-26 16:56:05.615255 + AGENT (warning) Attribute 'dir' of
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 62: 2021-04-26 16:56:05.615411 + AGENT (warning) Attribute 'dir' of
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 62: qdrouterd:
> /home/travis/build/apache/qpid-dispatch/src/router_core/modules/edge_router/addr_proxy.c:323:
> on_conn_event: Assertion `addr->edge_outlink == 0' failed.
> 62:
> 62:
> 62:
> 62: Router EA2 command file:
> 62:
> 62: qdrouterd -c EA2.conf -I /home/travis/build/apache/qpid-dispatch/python
> 62: pid=14036
> 62:
> 62:
> 62:
> 62: Router EA2 log file tail:
> 62:
> 62: 2021-04-26 16:58:05.686184 + ROUTER_CORE (trace) Core action
> 'link_detach'
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 62: 2021-04-26 16:58:05.686235 + ROUTER_CORE (info) [C4][L12] Link lost:
> del=1 presett=1 psdrop=0 acc=0 rej=0 rel=0 mod=0 delay1=0 delay10=0
> blocked=no
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1074)
> 62: 2021-04-26 16:58:05.686281 + ROUTER_CORE (trace) Core action
> 'connection_closed'
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 62: 2021-04-26 16:58:05.686346 + ROUTER_CORE (info) [C4] Connection
> Closed
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1557)
> 62: 2021-04-26 16:58:05.705484 + SERVER (trace) Accepting connection on
> 0.0.0.0:23020 (/home/travis/build/apache/qpid-dispatch/src/server.c:852)
> 62: 2021-04-26 16:58:05.705577 + SERVER (trace) [C5]: Accepting incoming
> connection to '0.0.0.0:23020'
> (/home/travis/build/apache/qpid-dispatch/src/server.c:606)
> 62: 2021-04-26 16:58:05.705691 + POLICY (trace) ALLOW Connection
> '127.0.0.1' based on global connection count. nConnections= 1
> (/home/travis/build/apache/qpid-dispatch/src/policy.c:271)
> 62: 2021-04-26 16:58:05.705782 + SERVER (info) [C5] Accepted connection
> to 0.0.0.0:23020 from 127.0.0.1:37922
> (/home/travis/build/apache/qpid-dispatch/src/server.c:750)
> 62: 2021-04-26 16:58:05.706152 + PROTOCOL (trace) [C5]:FRAME: <- SASL
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706180 + PROTOCOL (trace) [C5]:FRAME: -> SASL
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706590 + PROTOCOL (trace) [C5]:FRAME: 0 ->
> @sasl-mechanisms(64) [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706949 + PROTOCOL (trace) [C5]:FRAME: 0 <-
> @sasl-init(65) [mechanism=:ANONYMOUS,
> initial-response=b"anonymous@travis-job-apache-qpid-dispatch-501153572"]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707025 + PROTOCOL (trace) [C5]:FRAME: 0 ->
> @sasl-outcome(68) [code=0]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707319 + PROTOCOL (trace) [C5]:FRAME: <- AMQP
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707363 + PROTOCOL (trace) [C5]:FRAME: 0 <-
> @open(16) [container-id="ac3fab39-661e-44f4-8361-5866a600788d",
> hostname="0.0.0.0", channel-max=32767]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707432 + PROTOCOL (trace) [C5]:FRAME: 0 <-
> @begin(17) [next-outgoing-id=0, incoming-window=2147483647,
>
[jira] [Resolved] (DISPATCH-2085) system_tests_fallback_dest failure - addr_proxy.c:323: on_conn_event: Assertion `addr->edge_outlink == 0' failed
[
https://issues.apache.org/jira/browse/DISPATCH-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti resolved DISPATCH-2085.
--
Resolution: Fixed
> system_tests_fallback_dest failure - addr_proxy.c:323: on_conn_event:
> Assertion `addr->edge_outlink == 0' failed
>
>
> Key: DISPATCH-2085
> URL: https://issues.apache.org/jira/browse/DISPATCH-2085
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.18.0
>
>
> First spotted on s390x,
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501153572#L6607
> {noformat}
> 62: Router EA2 output file:
> 62:
> 62: 2021-04-26 16:56:05.615255 + AGENT (warning) Attribute 'dir' of
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 62: 2021-04-26 16:56:05.615411 + AGENT (warning) Attribute 'dir' of
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 62: qdrouterd:
> /home/travis/build/apache/qpid-dispatch/src/router_core/modules/edge_router/addr_proxy.c:323:
> on_conn_event: Assertion `addr->edge_outlink == 0' failed.
> 62:
> 62:
> 62:
> 62: Router EA2 command file:
> 62:
> 62: qdrouterd -c EA2.conf -I /home/travis/build/apache/qpid-dispatch/python
> 62: pid=14036
> 62:
> 62:
> 62:
> 62: Router EA2 log file tail:
> 62:
> 62: 2021-04-26 16:58:05.686184 + ROUTER_CORE (trace) Core action
> 'link_detach'
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 62: 2021-04-26 16:58:05.686235 + ROUTER_CORE (info) [C4][L12] Link lost:
> del=1 presett=1 psdrop=0 acc=0 rej=0 rel=0 mod=0 delay1=0 delay10=0
> blocked=no
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1074)
> 62: 2021-04-26 16:58:05.686281 + ROUTER_CORE (trace) Core action
> 'connection_closed'
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 62: 2021-04-26 16:58:05.686346 + ROUTER_CORE (info) [C4] Connection
> Closed
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1557)
> 62: 2021-04-26 16:58:05.705484 + SERVER (trace) Accepting connection on
> 0.0.0.0:23020 (/home/travis/build/apache/qpid-dispatch/src/server.c:852)
> 62: 2021-04-26 16:58:05.705577 + SERVER (trace) [C5]: Accepting incoming
> connection to '0.0.0.0:23020'
> (/home/travis/build/apache/qpid-dispatch/src/server.c:606)
> 62: 2021-04-26 16:58:05.705691 + POLICY (trace) ALLOW Connection
> '127.0.0.1' based on global connection count. nConnections= 1
> (/home/travis/build/apache/qpid-dispatch/src/policy.c:271)
> 62: 2021-04-26 16:58:05.705782 + SERVER (info) [C5] Accepted connection
> to 0.0.0.0:23020 from 127.0.0.1:37922
> (/home/travis/build/apache/qpid-dispatch/src/server.c:750)
> 62: 2021-04-26 16:58:05.706152 + PROTOCOL (trace) [C5]:FRAME: <- SASL
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706180 + PROTOCOL (trace) [C5]:FRAME: -> SASL
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706590 + PROTOCOL (trace) [C5]:FRAME: 0 ->
> @sasl-mechanisms(64) [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706949 + PROTOCOL (trace) [C5]:FRAME: 0 <-
> @sasl-init(65) [mechanism=:ANONYMOUS,
> initial-response=b"anonymous@travis-job-apache-qpid-dispatch-501153572"]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707025 + PROTOCOL (trace) [C5]:FRAME: 0 ->
> @sasl-outcome(68) [code=0]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707319 + PROTOCOL (trace) [C5]:FRAME: <- AMQP
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707363 + PROTOCOL (trace) [C5]:FRAME: 0 <-
> @open(16) [container-id="ac3fab39-661e-44f4-8361-5866a600788d",
> hostname="0.0.0.0", channel-max=32767]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707432 + PROTOCOL (trace) [C5]:FRAME: 0 <-
> @begin(17) [next-outgoing-id=0, incoming-window=2147483647,
> outgoing-window=2147483647]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707500 + PROTOCOL (trace) [C5]:FRAME: 0 <-
> @attach(18) [name="dest.32_primary_receiver", handle=0, role=true,
> snd-settle-mode=2, rcv-settle-mode=0, source=@source(40) [address="dest.32",
> durable=0, timeout=0, dynamic=false], target=@target(41) [durable=0,
> timeout=0, dynamic=false], initial-delivery-count=0,
[GitHub] [qpid-dispatch] kgiusti merged pull request #1415: DISPATCH-2085: remove bad assertion in addr_proxy connection handler
kgiusti merged pull request #1415: URL: https://github.com/apache/qpid-dispatch/pull/1415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2451) Reduce (ultimately eliminate) all use of the pn_data_t data structure in AMQP frame processing
Andrew Stitcher created PROTON-2451: --- Summary: Reduce (ultimately eliminate) all use of the pn_data_t data structure in AMQP frame processing Key: PROTON-2451 URL: https://issues.apache.org/jira/browse/PROTON-2451 Project: Qpid Proton Issue Type: Improvement Components: proton-c Reporter: Andrew Stitcher Assignee: Andrew Stitcher Fix For: proton-c-0.37.0 In current proton protocol processing code make heavy use of the pn_data_t data structure for coding and decoding AMQP frames to send and receive. Unfortunately the data structure is complex and the code which uses it is not very efficient. This means that a lot of CPU is consumed maniputing these data structures unnecessarily during the critical path operations of proton. During frame processing pn_data_t is not even really necessary as it is only used as an intermediary to extract necessary frame parameters out of the frames (or as an intermediary to construct the frames from the necessary frame parameters. This means that is entirely feasible to go directly from/to the parameters to/from the frames without using an intermediate pn_data_t at all. The most complicated aspect of this and one which will be deferred somewhat is that of using non scalar structured data as part of AMQP frames. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1966) Update top level Dockerfile to CentOS 8 / CentOS 8 Stream
[ https://issues.apache.org/jira/browse/DISPATCH-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy reassigned DISPATCH-1966: --- Assignee: Jiri Daněk (was: Ganesh Murthy) > Update top level Dockerfile to CentOS 8 / CentOS 8 Stream > - > > Key: DISPATCH-1966 > URL: https://issues.apache.org/jira/browse/DISPATCH-1966 > Project: Qpid Dispatch > Issue Type: Task >Affects Versions: 1.16.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.18.0 > > > According to CentOS pages, CentOS 8 has EOL set to the end of 2020. There are > no Docker images for CentOS 8 Stream. The page recommends using RHEL 8 UBI > instead. > Edit: the UBI recommendation was removed from the wiki page yesterday or > today. Container images are now available at > https://quay.io/repository/centos/centos?tab=tags. > [https://wiki.centos.org/FAQ/CentOSStream#What_artifacts_are_built.3F]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1966) Update top level Dockerfile to CentOS 8 / CentOS 8 Stream
[ https://issues.apache.org/jira/browse/DISPATCH-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1966. - Resolution: Fixed > Update top level Dockerfile to CentOS 8 / CentOS 8 Stream > - > > Key: DISPATCH-1966 > URL: https://issues.apache.org/jira/browse/DISPATCH-1966 > Project: Qpid Dispatch > Issue Type: Task >Affects Versions: 1.16.0 >Reporter: Jiri Daněk >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.18.0 > > > According to CentOS pages, CentOS 8 has EOL set to the end of 2020. There are > no Docker images for CentOS 8 Stream. The page recommends using RHEL 8 UBI > instead. > Edit: the UBI recommendation was removed from the wiki page yesterday or > today. Container images are now available at > https://quay.io/repository/centos/centos?tab=tags. > [https://wiki.centos.org/FAQ/CentOSStream#What_artifacts_are_built.3F]. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2117) Assertion failure outs.count("edge-downlink") != 4 in system_tests_edge_router
[
https://issues.apache.org/jira/browse/DISPATCH-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2117.
-
Fix Version/s: 1.18.0
Resolution: Fixed
This issue might get fixed by the fix for DISPATCH-2262
I am marking it as Resolved and we can open it back up again if required.
> Assertion failure outs.count("edge-downlink") != 4 in system_tests_edge_router
> --
>
> Key: DISPATCH-2117
> URL: https://issues.apache.org/jira/browse/DISPATCH-2117
> Project: Qpid Dispatch
> Issue Type: Test
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/504726978#L5835
> {noformat}
> 55: ==
> 55: FAIL: test_69_interior_qdstat_all_routers
> (system_tests_edge_router.RouterTest)
> 55: --
> 55: Traceback (most recent call last):
> 55: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_edge_router.py",
> line 1373, in test_69_interior_qdstat_all_routers
> 55: self.assertEqual(outs.count("edge-downlink"), 4)
> 55: AssertionError: 3 != 4
> 55:
> 55: --
> 55: Ran 89 tests in 401.397s
> 55:
> 55: FAILED (failures=2)
> 55/72 Test #55: system_tests_edge_router ..***Failed
> 401.56 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2247) "Received MAU from an unknown router" error message must include unknown router id
[
https://issues.apache.org/jira/browse/DISPATCH-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2247.
-
Assignee: Ganesh Murthy
Resolution: Fixed
> "Received MAU from an unknown router" error message must include unknown
> router id
> --
>
> Key: DISPATCH-2247
> URL: https://issues.apache.org/jira/browse/DISPATCH-2247
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Routing Engine
>Affects Versions: 1.17.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> Sometimes the router prints out the following error -
> {noformat}
> Received MAU from an unknown router {noformat}
> It would be nice if it print out the router id received in the MAU, like so
> {noformat}
> Received MAU from an unknown router with id QDR.A {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2247) "Received MAU from an unknown router" error message must include unknown router id
[
https://issues.apache.org/jira/browse/DISPATCH-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436915#comment-17436915
]
ASF GitHub Bot commented on DISPATCH-2247:
--
asfgit merged pull request #1414:
URL: https://github.com/apache/qpid-dispatch/pull/1414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> "Received MAU from an unknown router" error message must include unknown
> router id
> --
>
> Key: DISPATCH-2247
> URL: https://issues.apache.org/jira/browse/DISPATCH-2247
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Routing Engine
>Affects Versions: 1.17.0
>Reporter: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> Sometimes the router prints out the following error -
> {noformat}
> Received MAU from an unknown router {noformat}
> It would be nice if it print out the router id received in the MAU, like so
> {noformat}
> Received MAU from an unknown router with id QDR.A {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2247) "Received MAU from an unknown router" error message must include unknown router id
[
https://issues.apache.org/jira/browse/DISPATCH-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436914#comment-17436914
]
ASF subversion and git services commented on DISPATCH-2247:
---
Commit 5804a70ca22d4300f5c43c4bdd9cac7eeff0d27a in qpid-dispatch's branch
refs/heads/main from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=5804a70 ]
DISPATCH-2247: Added router id to log message
> "Received MAU from an unknown router" error message must include unknown
> router id
> --
>
> Key: DISPATCH-2247
> URL: https://issues.apache.org/jira/browse/DISPATCH-2247
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Routing Engine
>Affects Versions: 1.17.0
>Reporter: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> Sometimes the router prints out the following error -
> {noformat}
> Received MAU from an unknown router {noformat}
> It would be nice if it print out the router id received in the MAU, like so
> {noformat}
> Received MAU from an unknown router with id QDR.A {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit merged pull request #1414: DISPATCH-2247: Added router id to log message
asfgit merged pull request #1414: URL: https://github.com/apache/qpid-dispatch/pull/1414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Reopened] (DISPATCH-2262) Edge/Interior connections can half-fail in real multi-cloud environments
[ https://issues.apache.org/jira/browse/DISPATCH-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reopened DISPATCH-2262: -- Reopening to note comments on PR. > Edge/Interior connections can half-fail in real multi-cloud environments > > > Key: DISPATCH-2262 > URL: https://issues.apache.org/jira/browse/DISPATCH-2262 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.17.0 >Reporter: Ted Ross >Assignee: Ted Ross >Priority: Major > Fix For: 1.18.0 > > > See PROTON-2440 for context. > The configured keepalive on edge-to-interior connections can fail to provide > protection from connection loss. This results in half-failed connections > where the edge sees connection failure and re-connects and the interior sees > nothing and accumulates multiple connections from the same edge. > This is a serious problem because the interior will attempt to forward > deliveries across these dead-but-seemingly-alive connections resulting in > lack of message delivery. > The solution proposed in this issue is to work around the problem by > introducing an application-level keepalive for edge-to-interior connections. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2247) "Received MAU from an unknown router" error message must include unknown router id
[
https://issues.apache.org/jira/browse/DISPATCH-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436890#comment-17436890
]
ASF GitHub Bot commented on DISPATCH-2247:
--
ted-ross commented on a change in pull request #1414:
URL: https://github.com/apache/qpid-dispatch/pull/1414#discussion_r740289989
##
File path: src/router_core/modules/mobile_sync/mobile.c
##
@@ -690,8 +690,24 @@ static void qcm_mobile_sync_on_mau_CT(qdrm_mobile_sync_t
*msync, qd_parsed_field
// Tell the python router about the new mobile sequence
//
qdr_post_set_mobile_seq_CT(msync->core, router->mask_bit,
mobile_seq);
-} else
-qd_log(msync->log, QD_LOG_ERROR, "Received MAU from an unknown
router");
+} else {
+//
+// There is a possibility here that router_id is null but that is
fine. We want to print it out either way
+// which will help us in debugging.
+//
+char *r_id = 0;
+bool free_rid = false;
+if (id_field) {
+qd_iterator_t *id_iter = qd_parse_raw(id_field);
+if (id_iter) {
+r_id = (char *)qd_iterator_copy(id_iter);
+free_rid = true;
+}
+}
+qd_log(msync->log, QD_LOG_ERROR, "Received MAU from an unknown
router with router id %s", r_id);
Review comment:
There is a similar log for MAR messages. For completeness, you should
probably add the router_id to that one too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> "Received MAU from an unknown router" error message must include unknown
> router id
> --
>
> Key: DISPATCH-2247
> URL: https://issues.apache.org/jira/browse/DISPATCH-2247
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Routing Engine
>Affects Versions: 1.17.0
>Reporter: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> Sometimes the router prints out the following error -
> {noformat}
> Received MAU from an unknown router {noformat}
> It would be nice if it print out the router id received in the MAU, like so
> {noformat}
> Received MAU from an unknown router with id QDR.A {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #1414: DISPATCH-2247: Added router id to log message
ted-ross commented on a change in pull request #1414:
URL: https://github.com/apache/qpid-dispatch/pull/1414#discussion_r740289989
##
File path: src/router_core/modules/mobile_sync/mobile.c
##
@@ -690,8 +690,24 @@ static void qcm_mobile_sync_on_mau_CT(qdrm_mobile_sync_t
*msync, qd_parsed_field
// Tell the python router about the new mobile sequence
//
qdr_post_set_mobile_seq_CT(msync->core, router->mask_bit,
mobile_seq);
-} else
-qd_log(msync->log, QD_LOG_ERROR, "Received MAU from an unknown
router");
+} else {
+//
+// There is a possibility here that router_id is null but that is
fine. We want to print it out either way
+// which will help us in debugging.
+//
+char *r_id = 0;
+bool free_rid = false;
+if (id_field) {
+qd_iterator_t *id_iter = qd_parse_raw(id_field);
+if (id_iter) {
+r_id = (char *)qd_iterator_copy(id_iter);
+free_rid = true;
+}
+}
+qd_log(msync->log, QD_LOG_ERROR, "Received MAU from an unknown
router with router id %s", r_id);
Review comment:
There is a similar log for MAR messages. For completeness, you should
probably add the router_id to that one too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-848) Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in router_core/route_tables.c:149
[
https://issues.apache.org/jira/browse/DISPATCH-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436888#comment-17436888
]
ASF GitHub Bot commented on DISPATCH-848:
-
jiridanek commented on pull request #1052:
URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-956317441
@kgiusti No, there are CI failures (crash somewhere in the depths of Python
interpreter). I suspect it could be related to
https://issues.apache.org/jira/browse/DISPATCH-2144, but I have no proof, could
be just wild casting of blame for something I did wrong here.
There is too much undone to resolve for 1.18, I think. Also, the IoAdapter
leak is long standing, and it is small and constant amount of memory, so it
should not be a significant issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in
> router_core/route_tables.c:149
>
>
> Key: DISPATCH-848
> URL: https://issues.apache.org/jira/browse/DISPATCH-848
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.1.0
> Environment: Git tip of Proton and Dtspatch, commit hashes follow
> {noformat}
> commit aece4ad2f4e4eb2d141020c59c393a30a79f53a9 (upstream/master)
> Author: Andrew Stitcher
> PROTON-1609: Fix C++ example flags
> {noformat}
> {noformat}
> commit 18c5f8d6293de4227c8c17ef08675cb4eaef689c (HEAD -> master,
> upstream/master)
> Author: Ganesh Murthy
> NO-JIRA - Removed accidental printf inclusion
> {noformat}
>Reporter: Jiri Daněk
>Priority: Minor
> Labels: memory-bug
> Fix For: Backlog
>
> Attachments: LSan.supp
>
>
> Compile Proton and Dispatch with the Address Sanitizer option (c.f.
> DISPATCH-809) and run ctest
> {noformat}
> # proton
> cmake .. -DBUILD_GO=OFF -DENABLE_SANITIZERS=ON
> -DCMAKE_INSTALL_PREFIX=../install_asan -DCMAKE_BUILD_TYPE=Release -GNinja
> {noformat}
> {noformat}
> # dispatch
> cmake .. -DUSE_SANITIZERS=ON
> -DProton_DIR=`pwd`/../../qpid-proton/install_asan/lib64/cmake/Proton/
> -DCMAKE_BUILD_TYPE=Release -GNinja
> LD_PRELOAD=/nix/store/zahs1kwq4742f6l6h7yy4mdj44zzc1kd-gcc-7-20170409-lib/lib/libasan.so
> ASAN_OPTIONS=symbolize=1,color=always
> LSAN_OPTIONS=suppressions=`pwd`/../../qpid-proton/LSan.supp
> PYTHONPATH=`pwd`/../../qpid-proton/install_asan/lib64/proton/bindings/python
> LD_LIBRARY_PATH=`pwd`/../../qpid-proton/install_asan/lib64 ctest -VV
> {noformat}
> {noformat}
> [...]
> 9: Test Case parse_tree_tests.test_matches: PASS
> 9: Test Case parse_tree_tests.test_multiple_matches: PASS
> 9:
> 9: =
> 9: ==25904==ERROR: LeakSanitizer: detected memory leaks
> 9:
> 9: Direct leak of 48 byte(s) in 1 object(s) allocated from:
> 9: #0 0x7fb5442cb050 in __interceptor_malloc
> (/nix/store/zahs1kwq4742f6l6h7yy4mdj44zzc1kd-gcc-7-20170409-lib/lib/libasan.so+0xd9050)
> 9: #1 0x7fb543dd94fe in qdr_core_subscribe
> ../src/router_core/route_tables.c:149
> 9: #2 0x7fb543d89ff0 in IoAdapter_init ../src/python_embedded.c:548
> 9: #3 0x7fb542ba8ecd in type_call
> (/nix/store/1snk2wkpv97an87pk1842fgskl1vqhkr-python-2.7.14/lib/libpython2.7.so.1.0+0x9fecd)
> 9:
> 9: -
> 9: Suppressions used:
> 9: count bytes template
> 9:13102021760 dictresize
> 9: 204 188272 _PyObject_GC_Malloc
> 9: 45 39369 PyString_FromStringAndSize
> 9: 308 15056 list_resize
> 9: 11 9784 PyString_FromString
> 9: 2 1280 _PyObject_GC_Resize
> 9:1035 24104 PyList_New
> 9: 14672 s_init
> 9: 1 32 PyThread_allocate_lock
> 9: 11 11097 type_new
> 9: 3 3984 unicode_resize
> 9: 179 204712 _PyUnicode_New.part.8
> 9: 11 8028 PyObject_Realloc
> 9: 37120 _ctypes_alloc_format_string
> 9: 3 24576 set_table_resize
> 9: -
> 9:
> 9: SUMMARY: AddressSanitizer: 48 byte(s) leaked in 1 allocation(s).
> 9/36 Test #9: unit_tests ***Failed0.21
> sec
> {noformat}
> The relevant functions are
> {code}
> static int IoAdapter_init(IoAdapter *self, PyObject *args, PyObject *kwds)
> {
> PyObject *addr;
> char aclass= 'L';
> char phase = '0';
> int treatment = QD_TREATMENT_ANYCAST_CLOSEST;
[jira] [Commented] (DISPATCH-2247) "Received MAU from an unknown router" error message must include unknown router id
[
https://issues.apache.org/jira/browse/DISPATCH-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436889#comment-17436889
]
ASF GitHub Bot commented on DISPATCH-2247:
--
ted-ross commented on a change in pull request #1414:
URL: https://github.com/apache/qpid-dispatch/pull/1414#discussion_r740289212
##
File path: src/router_core/modules/mobile_sync/mobile.c
##
@@ -690,8 +690,24 @@ static void qcm_mobile_sync_on_mau_CT(qdrm_mobile_sync_t
*msync, qd_parsed_field
// Tell the python router about the new mobile sequence
//
qdr_post_set_mobile_seq_CT(msync->core, router->mask_bit,
mobile_seq);
-} else
-qd_log(msync->log, QD_LOG_ERROR, "Received MAU from an unknown
router");
+} else {
+//
+// There is a possibility here that router_id is null but that is
fine. We want to print it out either way
+// which will help us in debugging.
+//
+char *r_id = 0;
+bool free_rid = false;
Review comment:
You don't need the free_rid thing. It is safe to call 'free' on a null
pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> "Received MAU from an unknown router" error message must include unknown
> router id
> --
>
> Key: DISPATCH-2247
> URL: https://issues.apache.org/jira/browse/DISPATCH-2247
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Routing Engine
>Affects Versions: 1.17.0
>Reporter: Ganesh Murthy
>Priority: Major
> Fix For: 1.18.0
>
>
> Sometimes the router prints out the following error -
> {noformat}
> Received MAU from an unknown router {noformat}
> It would be nice if it print out the router id received in the MAU, like so
> {noformat}
> Received MAU from an unknown router with id QDR.A {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #1414: DISPATCH-2247: Added router id to log message
ted-ross commented on a change in pull request #1414:
URL: https://github.com/apache/qpid-dispatch/pull/1414#discussion_r740289212
##
File path: src/router_core/modules/mobile_sync/mobile.c
##
@@ -690,8 +690,24 @@ static void qcm_mobile_sync_on_mau_CT(qdrm_mobile_sync_t
*msync, qd_parsed_field
// Tell the python router about the new mobile sequence
//
qdr_post_set_mobile_seq_CT(msync->core, router->mask_bit,
mobile_seq);
-} else
-qd_log(msync->log, QD_LOG_ERROR, "Received MAU from an unknown
router");
+} else {
+//
+// There is a possibility here that router_id is null but that is
fine. We want to print it out either way
+// which will help us in debugging.
+//
+char *r_id = 0;
+bool free_rid = false;
Review comment:
You don't need the free_rid thing. It is safe to call 'free' on a null
pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1052: DISPATCH-848, DISPATCH-1962 Fix leak of IoAdapter_init
jiridanek commented on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-956317441 @kgiusti No, there are CI failures (crash somewhere in the depths of Python interpreter). I suspect it could be related to https://issues.apache.org/jira/browse/DISPATCH-2144, but I have no proof, could be just wild casting of blame for something I did wrong here. There is too much undone to resolve for 1.18, I think. Also, the IoAdapter leak is long standing, and it is small and constant amount of memory, so it should not be a significant issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2223) Incorporate pythoncapi_compat.h to keep up with CPython development
[ https://issues.apache.org/jira/browse/DISPATCH-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk resolved DISPATCH-2223. -- Resolution: Fixed > Incorporate pythoncapi_compat.h to keep up with CPython development > --- > > Key: DISPATCH-2223 > URL: https://issues.apache.org/jira/browse/DISPATCH-2223 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.18.0 > > Attachments: image-2021-08-04-17-58-13-223.png > > > The library pythoncapi_compat is a simple (so far) header file that contains > backports of Python C API utility functions, plus a script with tries to > rewrite older code constructs to use these utility functions. > https://vstinner.github.io/pythoncapi_compat.html > In Dispatch there is very few changes that would be required to adopt all the > utilities. > Having this could be useful for the future, since there were recent > developments and improvements to the C Python API in Python 3.8-3.10, and > there may be more. This way, it is possible to keep up in a compatible way. > !image-2021-08-04-17-58-13-223.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2085) system_tests_fallback_dest failure - addr_proxy.c:323: on_conn_event: Assertion `addr->edge_outlink == 0' failed
[
https://issues.apache.org/jira/browse/DISPATCH-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436881#comment-17436881
]
Ken Giusti commented on DISPATCH-2085:
--
Turns out that assert is now invalid due to the addition of the fallback
destination feature.
Links that have fallback addresses will pre-configure an outlink for the
fallback address, which means the edge_outlink pointer may be set when the
fallback address entry is checked.
We must also remove the code that forces the edge_outlink to zero - that will
un-do the fallback address setup.
> system_tests_fallback_dest failure - addr_proxy.c:323: on_conn_event:
> Assertion `addr->edge_outlink == 0' failed
>
>
> Key: DISPATCH-2085
> URL: https://issues.apache.org/jira/browse/DISPATCH-2085
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.18.0
>
>
> First spotted on s390x,
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/501153572#L6607
> {noformat}
> 62: Router EA2 output file:
> 62:
> 62: 2021-04-26 16:56:05.615255 + AGENT (warning) Attribute 'dir' of
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 62: 2021-04-26 16:56:05.615411 + AGENT (warning) Attribute 'dir' of
> entity 'autoLink' has been deprecated. Use 'direction' instead
> 62: qdrouterd:
> /home/travis/build/apache/qpid-dispatch/src/router_core/modules/edge_router/addr_proxy.c:323:
> on_conn_event: Assertion `addr->edge_outlink == 0' failed.
> 62:
> 62:
> 62:
> 62: Router EA2 command file:
> 62:
> 62: qdrouterd -c EA2.conf -I /home/travis/build/apache/qpid-dispatch/python
> 62: pid=14036
> 62:
> 62:
> 62:
> 62: Router EA2 log file tail:
> 62:
> 62: 2021-04-26 16:58:05.686184 + ROUTER_CORE (trace) Core action
> 'link_detach'
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 62: 2021-04-26 16:58:05.686235 + ROUTER_CORE (info) [C4][L12] Link lost:
> del=1 presett=1 psdrop=0 acc=0 rej=0 rel=0 mod=0 delay1=0 delay10=0
> blocked=no
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1074)
> 62: 2021-04-26 16:58:05.686281 + ROUTER_CORE (trace) Core action
> 'connection_closed'
> (/home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:238)
> 62: 2021-04-26 16:58:05.686346 + ROUTER_CORE (info) [C4] Connection
> Closed
> (/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1557)
> 62: 2021-04-26 16:58:05.705484 + SERVER (trace) Accepting connection on
> 0.0.0.0:23020 (/home/travis/build/apache/qpid-dispatch/src/server.c:852)
> 62: 2021-04-26 16:58:05.705577 + SERVER (trace) [C5]: Accepting incoming
> connection to '0.0.0.0:23020'
> (/home/travis/build/apache/qpid-dispatch/src/server.c:606)
> 62: 2021-04-26 16:58:05.705691 + POLICY (trace) ALLOW Connection
> '127.0.0.1' based on global connection count. nConnections= 1
> (/home/travis/build/apache/qpid-dispatch/src/policy.c:271)
> 62: 2021-04-26 16:58:05.705782 + SERVER (info) [C5] Accepted connection
> to 0.0.0.0:23020 from 127.0.0.1:37922
> (/home/travis/build/apache/qpid-dispatch/src/server.c:750)
> 62: 2021-04-26 16:58:05.706152 + PROTOCOL (trace) [C5]:FRAME: <- SASL
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706180 + PROTOCOL (trace) [C5]:FRAME: -> SASL
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706590 + PROTOCOL (trace) [C5]:FRAME: 0 ->
> @sasl-mechanisms(64) [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.706949 + PROTOCOL (trace) [C5]:FRAME: 0 <-
> @sasl-init(65) [mechanism=:ANONYMOUS,
> initial-response=b"anonymous@travis-job-apache-qpid-dispatch-501153572"]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707025 + PROTOCOL (trace) [C5]:FRAME: 0 ->
> @sasl-outcome(68) [code=0]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707319 + PROTOCOL (trace) [C5]:FRAME: <- AMQP
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707363 + PROTOCOL (trace) [C5]:FRAME: 0 <-
> @open(16) [container-id="ac3fab39-661e-44f4-8361-5866a600788d",
> hostname="0.0.0.0", channel-max=32767]
> (/home/travis/build/apache/qpid-dispatch/src/server.c:111)
> 62: 2021-04-26 16:58:05.707432 + PROTOCOL (trace) [C5]:FRAME: 0 <-
> @begin(17) [next-outgoing-id=0, incoming-window=2147483647,
> outgoing-window=2147483647]
>
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.18.0 release
[ https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436876#comment-17436876 ] Jiri Daněk commented on DISPATCH-2234: -- Hmm, should I do this, or leave it for next release maybe? I always planned to write some automated e2e tests for the console first, so that I can more easily check for regressions... but I never got to it, so far. > Update JavaScript console packages for the 1.18.0 release > - > > Key: DISPATCH-2234 > URL: https://issues.apache.org/jira/browse/DISPATCH-2234 > Project: Qpid Dispatch > Issue Type: Task > Components: Console >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-840) "schema.adoc" contains invalid asciidoc
[
https://issues.apache.org/jira/browse/DISPATCH-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk resolved DISPATCH-840.
-
Resolution: Fixed
> "schema.adoc" contains invalid asciidoc
> ---
>
> Key: DISPATCH-840
> URL: https://issues.apache.org/jira/browse/DISPATCH-840
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 0.8.0
>Reporter: Ben Hardesty
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
> Attachments: qdrouterd.conf.html.png
>
>
> The schema_txt.py program [1] generates schema.adoc, which is included in the
> Dispatch Router book [2]. However, there is an issue with the asciidoc that's
> generated: the attributes for each configuration and management entity are
> generated as asciidoc def lists. This is perfectly fine, but some of the
> attributes don't have descriptions. When one of these "empty" def list
> entries immediately precedes a new section, that section is not styled
> properly in the output. To see examples of this, in the Dispatch Router book,
> search for the following strings:
> * {{=== vhost}}
> * {{=== vhostStats}}
> * {{== Management Operations}}
> To fix this issue, in qdrouter.json, a {{"description": ""}}
> name-value pair should be added to each attribute that's missing one. If
> that's not feasible, an alternative would be to update schema_doc.py to
> properly handle any attribute that doesn't have a description (it looks like
> lines 70-71 should handle this, but my python's not up to snuff enough to
> figure out why it isn't).
> [1] -
> https://github.com/apache/qpid-dispatch/blob/master/doc/book/schema_txt.py
> [2] -
> https://qpid.apache.org/releases/qpid-dispatch-0.8.0/book/book.html#_configuration_entities
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-836) Source file organization suffers from include hell
[ https://issues.apache.org/jira/browse/DISPATCH-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-836: Fix Version/s: (was: 1.18.0) 1.19.0 > Source file organization suffers from include hell > -- > > Key: DISPATCH-836 > URL: https://issues.apache.org/jira/browse/DISPATCH-836 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container, Router Node, Routing Engine >Affects Versions: 0.8.0 >Reporter: Charles E. Rolke >Assignee: Jiri Daněk >Priority: Minor > Fix For: 1.19.0 > > > Adding an innocent looking #include to some module may unleash a barrage of > errors instead of simply defining the header's interface. Reordering and/or > adding more #include statements is required to get it right. > A good way to address this is to make certain that each module.h file > compiles cleanly on its own. It is tedious and pretty unrewarding to check > each file. One strategy to address this problem is for each module to > _#include module.h_ as the first include\[1\]. Then every compile checks that > the module.h files compiles cleanly. This strategy is recommended by > astitcher and used by qpid-cpp with great results. > \[1\] One exception to this rule is including the #include Python.h ahead of > all others. This is a requirement. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2121) Investigate whether there might be benefits from LTO-ing Proton into Dispatch
[ https://issues.apache.org/jira/browse/DISPATCH-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk resolved DISPATCH-2121. -- Resolution: Later There may be benefits and it is now possible to link static build of Proton into Dispatch. If there is further interest in doing this, the task can be resumed. > Investigate whether there might be benefits from LTO-ing Proton into Dispatch > - > > Key: DISPATCH-2121 > URL: https://issues.apache.org/jira/browse/DISPATCH-2121 > Project: Qpid Dispatch > Issue Type: Task >Affects Versions: 1.16.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.18.0 > > > https://stackoverflow.com/questions/25878407/how-can-i-use-lto-with-static-libraries -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2143) race getting/setting qdr_delivery_t->disposition
[
https://issues.apache.org/jira/browse/DISPATCH-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436867#comment-17436867
]
Jiri Daněk commented on DISPATCH-2143:
--
https://github.com/apache/qpid-dispatch/runs/4068760540?check_suite_focus=true#step:27:1473
{noformat}
63: WARNING: ThreadSanitizer: data race (pid=3569)
63: Read of size 1 at 0x7b4474d4 by main thread:
63: #0 qdr_connection_process
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/connections.c:403
(qdrouterd+0x492767)
63: #1 AMQP_writable_conn_handler
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:299
(qdrouterd+0x4cfc9d)
63: #2 writable_handler
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:388
(qdrouterd+0x45c260)
63: #3 qd_container_handle_event
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:744
(qdrouterd+0x45eda0)
63: #4 handle
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1108
(qdrouterd+0x4d8a51)
63: #5 thread_run
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
(qdrouterd+0x4dad94)
63: #6 qd_server_run
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1527
(qdrouterd+0x4db96c)
63: #7 main_process
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:115
(qdrouterd+0x426d6c)
63: #8 main
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
(qdrouterd+0x42624c)
63:
63: Previous write of size 1 at 0x7b4474d4 by thread T1:
63: #0 qdr_delivery_mcast_outbound_settled_CT
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:889
(qdrouterd+0x4a0697)
63: #1 qdr_delivery_mcast_outbound_update_CT
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:1020
(qdrouterd+0x4a0697)
63: #2 qdr_update_delivery_CT
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:680
(qdrouterd+0x4a12c5)
63: #3 router_core_thread
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core_thread.c:236
(qdrouterd+0x4b55fa)
63: #4 _thread_init
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
(qdrouterd+0x48162d)
63:
63: Location is heap block of size 320 at 0x7b447440 allocated by main
thread:
63: #0 posix_memalign (libtsan.so.0+0x32a23)
63: #1 qd_alloc
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/alloc_pool.c:396
(qdrouterd+0x44abd9)
63: #2 new_qdr_delivery_t
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:24
(qdrouterd+0x49d23c)
63: #3 qdr_link_deliver
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/transfer.c:47
(qdrouterd+0x4baf45)
63: #4 AMQP_rx_handler
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:877
(qdrouterd+0x4d3016)
63: #5 do_receive
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:219
(qdrouterd+0x45f064)
63: #6 qd_container_handle_event
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:734
(qdrouterd+0x45f064)
63: #7 handle
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1108
(qdrouterd+0x4d8a51)
63: #8 thread_run
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
(qdrouterd+0x4dad14)
63: #9 qd_server_run
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1527
(qdrouterd+0x4db96c)
63: #10 main_process
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:115
(qdrouterd+0x426d6c)
63: #11 main
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
(qdrouterd+0x42624c)
63:
63: Thread T1 (tid=3571, running) created by main thread at:
63: #0 pthread_create (libtsan.so.0+0x5bf45)
63: #1 sys_thread
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:181
(qdrouterd+0x481abc)
63: #2 qdr_core
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core.c:124
(qdrouterd+0x4af560)
63: #3 qd_router_setup_late
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:2127
(qdrouterd+0x4d3e28)
63: #4 ffi_call_unix64 (libffi.so.6+0x6c03)
63: #5 main_process
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:97
(qdrouterd+0x426d0c)
63: #6 main
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369
(qdrouterd+0x42624c)
63:
63: SUMMARY: ThreadSanitizer: data race
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/connections.c:403
in
[jira] [Resolved] (DISPATCH-2193) system_tests_http1_over_tcp failing in test_05_large_streaming_msg
[
https://issues.apache.org/jira/browse/DISPATCH-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2193.
-
Fix Version/s: 1.18.0
Resolution: Cannot Reproduce
> system_tests_http1_over_tcp failing in test_05_large_streaming_msg
> ---
>
> Key: DISPATCH-2193
> URL: https://issues.apache.org/jira/browse/DISPATCH-2193
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.16.1
>Reporter: Ganesh Murthy
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.18.0
>
>
> {noformat}
> 72: server11 = TestServer.new_server(self.http_server11_port,
> self.http_listener11_port, TESTS_11)
> 72: self.assertIsNotNone(server11, TEST_SERVER_ERROR %
> self.http_server11_port)
> 72: server10 = TestServer.new_server(self.http_server10_port,
> self.http_listener10_port, TESTS_10,
> 72: handler_cls=RequestHandler10)
> 72: self.assertIsNotNone(server10, TEST_SERVER_ERROR %
> self.http_server10_port)
> 72:
> 72: self.EA2.wait_connectors()
> 72:
> 72: client11 = ThreadedTestClient(TESTS_11,
> 72: self.http_listener11_port,
> 72: repeat=2)
> 72: client11.wait()
> 72: self.assertIsNone(client11.error)
> 72: > self.assertEqual(4, client11.count)
> 72: E AssertionError: 4 != 1
> 72:
> 72:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/http1_tests.py:743:
> AssertionError
> 72: - generated xml file:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_http1_over_tcp.xml
> -
> 72: === short test summary info
>
> 72: FAILED ::Http1OverTcpEdge2EdgeTest::test_05_large_streaming_msg -
> AssertionEr...
> 72: === 1 failed, 11 passed in 327.17s (0:05:27)
> ===
> 37/37 Test #72: system_tests_http1_over_tcp ...***Failed
> 327.39 sec {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2273) Remove support for Proton < 0.33 SASL extension API
[
https://issues.apache.org/jira/browse/DISPATCH-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated DISPATCH-2273:
-
Fix Version/s: 1.18.0
> Remove support for Proton < 0.33 SASL extension API
> ---
>
> Key: DISPATCH-2273
> URL: https://issues.apache.org/jira/browse/DISPATCH-2273
> Project: Qpid Dispatch
> Issue Type: Improvement
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>
> {code}
> find_package(Proton 0.34.0 REQUIRED COMPONENTS Core Proactor)
> {code}
> Dispatch currently requires Proton 0.34, meaning that compatibility code for
> the older API can be now removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2273) Remove support for Proton < 0.33 SASL extension API
[
https://issues.apache.org/jira/browse/DISPATCH-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk resolved DISPATCH-2273.
--
Resolution: Fixed
> Remove support for Proton < 0.33 SASL extension API
> ---
>
> Key: DISPATCH-2273
> URL: https://issues.apache.org/jira/browse/DISPATCH-2273
> Project: Qpid Dispatch
> Issue Type: Improvement
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>
> {code}
> find_package(Proton 0.34.0 REQUIRED COMPONENTS Core Proactor)
> {code}
> Dispatch currently requires Proton 0.34, meaning that compatibility code for
> the older API can be now removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-2273) Remove support for Proton < 0.33 SASL extension API
[
https://issues.apache.org/jira/browse/DISPATCH-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk reassigned DISPATCH-2273:
Assignee: Jiri Daněk
> Remove support for Proton < 0.33 SASL extension API
> ---
>
> Key: DISPATCH-2273
> URL: https://issues.apache.org/jira/browse/DISPATCH-2273
> Project: Qpid Dispatch
> Issue Type: Improvement
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>
> {code}
> find_package(Proton 0.34.0 REQUIRED COMPONENTS Core Proactor)
> {code}
> Dispatch currently requires Proton 0.34, meaning that compatibility code for
> the older API can be now removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2273) Remove support for Proton < 0.33 SASL extension API
[
https://issues.apache.org/jira/browse/DISPATCH-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436855#comment-17436855
]
ASF subversion and git services commented on DISPATCH-2273:
---
Commit 4f56d463d3ab7caa02ff5cfd10f6474bbc27c4c1 in qpid-dispatch's branch
refs/heads/main from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=4f56d46 ]
DISPATCH-2273 Remove compatibility for pre-PROTON-2257 SASL Extension API
needed for Proton < 0.33 (#1411)
> Remove support for Proton < 0.33 SASL extension API
> ---
>
> Key: DISPATCH-2273
> URL: https://issues.apache.org/jira/browse/DISPATCH-2273
> Project: Qpid Dispatch
> Issue Type: Improvement
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
>
> {code}
> find_package(Proton 0.34.0 REQUIRED COMPONENTS Core Proactor)
> {code}
> Dispatch currently requires Proton 0.34, meaning that compatibility code for
> the older API can be now removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2273) Remove support for Proton < 0.33 SASL extension API
[
https://issues.apache.org/jira/browse/DISPATCH-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436856#comment-17436856
]
ASF GitHub Bot commented on DISPATCH-2273:
--
jiridanek merged pull request #1411:
URL: https://github.com/apache/qpid-dispatch/pull/1411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove support for Proton < 0.33 SASL extension API
> ---
>
> Key: DISPATCH-2273
> URL: https://issues.apache.org/jira/browse/DISPATCH-2273
> Project: Qpid Dispatch
> Issue Type: Improvement
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
>
> {code}
> find_package(Proton 0.34.0 REQUIRED COMPONENTS Core Proactor)
> {code}
> Dispatch currently requires Proton 0.34, meaning that compatibility code for
> the older API can be now removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1411: DISPATCH-2273 Remove compatibility for pre-PROTON-2257 SASL Extension API needed for Proton < 0.33
jiridanek merged pull request #1411: URL: https://github.com/apache/qpid-dispatch/pull/1411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2269) warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
[
https://issues.apache.org/jira/browse/DISPATCH-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk resolved DISPATCH-2269.
--
Resolution: Fixed
> warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
> ---
>
> Key: DISPATCH-2269
> URL: https://issues.apache.org/jira/browse/DISPATCH-2269
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>
> {noformat}
> C:\Users\Vitorio\CLionProjects\qpid-dispatch\include\qpid/dispatch/container.h(251,34):
> warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
> #if ((PN_VERSION_MAJOR == 0) && (PN_VERSON_MINOR <= 30))
> {noformat}
> This is a typo in the macro variable name. I am strongly surprised that this
> compiler warning has not been seen sooner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2269) warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
[
https://issues.apache.org/jira/browse/DISPATCH-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated DISPATCH-2269:
-
Status: Reviewable (was: In Progress)
> warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
> ---
>
> Key: DISPATCH-2269
> URL: https://issues.apache.org/jira/browse/DISPATCH-2269
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>
> {noformat}
> C:\Users\Vitorio\CLionProjects\qpid-dispatch\include\qpid/dispatch/container.h(251,34):
> warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
> #if ((PN_VERSION_MAJOR == 0) && (PN_VERSON_MINOR <= 30))
> {noformat}
> This is a typo in the macro variable name. I am strongly surprised that this
> compiler warning has not been seen sooner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-2269) warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
[
https://issues.apache.org/jira/browse/DISPATCH-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk reassigned DISPATCH-2269:
Assignee: Jiri Daněk
> warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
> ---
>
> Key: DISPATCH-2269
> URL: https://issues.apache.org/jira/browse/DISPATCH-2269
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>
> {noformat}
> C:\Users\Vitorio\CLionProjects\qpid-dispatch\include\qpid/dispatch/container.h(251,34):
> warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
> #if ((PN_VERSION_MAJOR == 0) && (PN_VERSON_MINOR <= 30))
> {noformat}
> This is a typo in the macro variable name. I am strongly surprised that this
> compiler warning has not been seen sooner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2269) warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
[
https://issues.apache.org/jira/browse/DISPATCH-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436853#comment-17436853
]
ASF subversion and git services commented on DISPATCH-2269:
---
Commit e403774acd658a1e64c9334182551d297617 in qpid-dispatch's branch
refs/heads/main from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=e403774 ]
DISPATCH-2269 Remove PROTON-2184 session context workaround needed for Proton <
0.31 (#1410)
> warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
> ---
>
> Key: DISPATCH-2269
> URL: https://issues.apache.org/jira/browse/DISPATCH-2269
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
>
> {noformat}
> C:\Users\Vitorio\CLionProjects\qpid-dispatch\include\qpid/dispatch/container.h(251,34):
> warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
> #if ((PN_VERSION_MAJOR == 0) && (PN_VERSON_MINOR <= 30))
> {noformat}
> This is a typo in the macro variable name. I am strongly surprised that this
> compiler warning has not been seen sooner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2269) warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
[
https://issues.apache.org/jira/browse/DISPATCH-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436854#comment-17436854
]
ASF GitHub Bot commented on DISPATCH-2269:
--
jiridanek merged pull request #1410:
URL: https://github.com/apache/qpid-dispatch/pull/1410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
> ---
>
> Key: DISPATCH-2269
> URL: https://issues.apache.org/jira/browse/DISPATCH-2269
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
>
> {noformat}
> C:\Users\Vitorio\CLionProjects\qpid-dispatch\include\qpid/dispatch/container.h(251,34):
> warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
> #if ((PN_VERSION_MAJOR == 0) && (PN_VERSON_MINOR <= 30))
> {noformat}
> This is a typo in the macro variable name. I am strongly surprised that this
> compiler warning has not been seen sooner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2269) warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
[
https://issues.apache.org/jira/browse/DISPATCH-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated DISPATCH-2269:
-
Fix Version/s: 1.18.0
> warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
> ---
>
> Key: DISPATCH-2269
> URL: https://issues.apache.org/jira/browse/DISPATCH-2269
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>
> {noformat}
> C:\Users\Vitorio\CLionProjects\qpid-dispatch\include\qpid/dispatch/container.h(251,34):
> warning: 'PN_VERSON_MINOR' is not defined, evaluates to 0 [-Wundef]
> #if ((PN_VERSION_MAJOR == 0) && (PN_VERSON_MINOR <= 30))
> {noformat}
> This is a typo in the macro variable name. I am strongly surprised that this
> compiler warning has not been seen sooner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1410: DISPATCH-2269 Remove PROTON-2184 session context workaround needed for Proton < 0.31
jiridanek merged pull request #1410: URL: https://github.com/apache/qpid-dispatch/pull/1410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2224) system_tests_policy_oversize_compound: router_node.c:452: AMQP_rx_handler: Assertion `pn_link' failed
[
https://issues.apache.org/jira/browse/DISPATCH-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2224.
-
Fix Version/s: 1.18.0
Resolution: Cannot Reproduce
I tried running this test on my machine and could not reproduce after running
it in a loop for about an hour. For the time being, I am going to mark it as
Cannot Reproduce. We will open this back again if we hit this crash again.
> system_tests_policy_oversize_compound: router_node.c:452: AMQP_rx_handler:
> Assertion `pn_link' failed
> -
>
> Key: DISPATCH-2224
> URL: https://issues.apache.org/jira/browse/DISPATCH-2224
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>
> https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/529131824#L4093
> {noformat}
> 27: Test command: /opt/python/3.6.8/bin/python3.6
> "/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest"
> "-v" "system_tests_policy_oversize_compound"
> 27: Test timeout computed to be: 1200
> 27: test_60_block_oversize_EB1_INTB_at_INTB
> (system_tests_policy_oversize_compound.MaxMessageSizeBlockOversize) ... ok
> 27: test_61_block_oversize_EB1_EA1_at_INTB
> (system_tests_policy_oversize_compound.MaxMessageSizeBlockOversize) ... ok
> 27: test_70_block_oversize_EB1_INTB_at_both
> (system_tests_policy_oversize_compound.MaxMessageSizeBlockOversize) ... ok
> 27: test_80_block_multicast_EB1_INTB_at_INTB
> (system_tests_policy_oversize_compound.MaxMessageSizeBlockOversize) ... ok
> 27: test_81_block_multicast_EA1
> (system_tests_policy_oversize_compound.MaxMessageSizeBlockOversize) ... ok
> 27: test_82_block_multicast_INTA
> (system_tests_policy_oversize_compound.MaxMessageSizeBlockOversize) ... ok
> 27:
> 27: Router EB1 output file:
> 27:
> 27: -
> 27: Suppressions used:
> 27: count bytes template
> 27: 1 56 ^IoAdapter_init$
> 27: 1 32 ^qd_policy_c_counts_alloc$
> 27: 565 861321 /libpython3.*.so
> 27: -
> 27:
> 27:
> 27:
> 27:
> 27: Router EA1 output file:
> 27:
> 27: -
> 27: Suppressions used:
> 27: count bytes template
> 27: 1 56 ^IoAdapter_init$
> 27: 1 32 ^qd_policy_c_counts_alloc$
> 27: 565 861321 /libpython3.*.so
> 27: -
> 27:
> 27:
> 27:
> 27:
> 27: Router INT.B output file:
> 27:
> 27: -
> 27: Suppressions used:
> 27: count bytes template
> 27: 4224 ^IoAdapter_init$
> 27: 1 32 ^qd_policy_c_counts_alloc$
> 27: 649 918473 /libpython3.*.so
> 27: -
> 27:
> 27:
> 27:
> 27:
> 27: Router INT.A output file:
> 27:
> 27: -
> 27: Suppressions used:
> 27: count bytes template
> 27: 4224 ^IoAdapter_init$
> 27: 1 32 ^qd_policy_c_counts_alloc$
> 27: 644 915425 /libpython3.*.so
> 27: -
> 27:
> 27:
> 27:
> 27: test_90_block_link_route_EB1_INTB
> (system_tests_policy_oversize_compound.MaxMessageSizeLinkRouteOversize) ... ok
> 27:
> 27: Router EB1 output file:
> 27:
> 27: -
> 27: Suppressions used:
> 27: count bytes template
> 27: 1 56 ^IoAdapter_init$
> 27: 1 32 ^qd_policy_c_counts_alloc$
> 27: 568 862505 /libpython3.*.so
> 27: -
> 27:
> 27:
> 27:
> 27:
> 27: Router EA1 output file:
> 27:
> 27: -
> 27: Suppressions used:
> 27: count bytes template
> 27: 1 56 ^IoAdapter_init$
> 27: 1 32 ^qd_policy_c_counts_alloc$
> 27: 568 862505 /libpython3.*.so
> 27: -
> 27:
> 27:
> 27:
> 27:
> 27: Router INT.B output file:
> 27:
> 27: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/router_node.c:452:
> AMQP_rx_handler: Assertion `pn_link' failed.
> 27:
> 27:
> 27:
> 27: Router INT.B output file:
> 27:
> 27: qdrouterd: /home/travis/build/apache/qpid-dispatch/src/router_node.c:452:
> AMQP_rx_handler: Assertion `pn_link' failed.
> 27:
> 27:
> 27:
> 27: Router INT.B command file:
> 27:
> 27: qdrouterd -c INT.B.conf -I
[jira] [Commented] (QPID-8565) [Broker-J] Enhancement of ACL rule predicates evaluation
[ https://issues.apache.org/jira/browse/QPID-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436840#comment-17436840 ] ASF GitHub Bot commented on QPID-8565: -- alex-rufous commented on a change in pull request #113: URL: https://github.com/apache/qpid-broker-j/pull/113#discussion_r740213872 ## File path: broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/config/RulePredicate.java ## @@ -62,5 +71,16 @@ public boolean matches(LegacyOperation operation, ObjectProperties objectPropert return true; } +@Override +public RulePredicate and(RulePredicate other) Review comment: IMHO, this breaks a semantic of logical and, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Broker-J] Enhancement of ACL rule predicates evaluation > > > Key: QPID-8565 > URL: https://issues.apache.org/jira/browse/QPID-8565 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Marek Laca >Priority: Minor > Labels: Broker, Java > > The access control plugin checks the rights of the user to perform an action > on the broker's component. The access control plugin iterates through the ACL > rules and checks their predicates. The user action is denied or allowed based > on the test result. > The aim of this task are refactoring of the code that is required for the > [QPID-8487|https://issues.apache.org/jira/browse/QPID-8487] and > [QPID-8488|https://issues.apache.org/jira/browse/QPID-8488], improving the > test of the ACL rule predicates and removing useless classes. Changes should > not have any impact on the functionality of the access control plugin. > The ObjectProperties class has two responsibilities, it holds the rule > predicates and also the objects properties that are checked. The > responsibilities of ObjectProperties class should be split because the code > should honor the principle of one responsibility per class. > The Rule class is treated as immutable but the immutability is not enforce by > the code. > The Action, AclAction and ClientAction classes are only data holders that > don't have any real responsibility. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] alex-rufous commented on a change in pull request #113: QPID-8565: [Broker-J] Enhancement of ACL rule predicates evaluation
alex-rufous commented on a change in pull request #113: URL: https://github.com/apache/qpid-broker-j/pull/113#discussion_r740213872 ## File path: broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/config/RulePredicate.java ## @@ -62,5 +71,16 @@ public boolean matches(LegacyOperation operation, ObjectProperties objectPropert return true; } +@Override +public RulePredicate and(RulePredicate other) Review comment: IMHO, this breaks a semantic of logical and, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] alex-rufous commented on a change in pull request #113: QPID-8565: [Broker-J] Enhancement of ACL rule predicates evaluation
alex-rufous commented on a change in pull request #113:
URL: https://github.com/apache/qpid-broker-j/pull/113#discussion_r740212386
##
File path:
broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/config/AclRulePredicatesBuilder.java
##
@@ -123,6 +123,16 @@ else if (property == Property.ATTRIBUTES)
{
_attributeNames.addAll(splitToSet(value));
}
+else if (property == Property.CONNECTION_LIMIT)
+{
+LOGGER.warn("The ACL Rule property 'connection_limit' has been
deprecated");
Review comment:
The log message is misleading. The feature was completely removed. Only
syntax support was left behind
##
File path:
broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/config/AclRulePredicatesBuilder.java
##
@@ -123,6 +123,16 @@ else if (property == Property.ATTRIBUTES)
{
_attributeNames.addAll(splitToSet(value));
}
+else if (property == Property.CONNECTION_LIMIT)
+{
+LOGGER.warn("The ACL Rule property 'connection_limit' has been
deprecated");
+return false;
+}
+else if (property == Property.CONNECTION_FREQUENCY_LIMIT)
+{
+LOGGER.warn("The ACL Rule property 'connection_frequency_limit'
has been deprecated");
Review comment:
The log message is misleading. The feature was completely removed. Only
syntax support was left behind
##
File path:
broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/config/RulePredicate.java
##
@@ -62,5 +71,16 @@ public boolean matches(LegacyOperation operation,
ObjectProperties objectPropert
return true;
}
+@Override
+public RulePredicate and(RulePredicate other)
Review comment:
IMHO, this breaks a semantic of logical and,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8565) [Broker-J] Enhancement of ACL rule predicates evaluation
[
https://issues.apache.org/jira/browse/QPID-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436836#comment-17436836
]
ASF GitHub Bot commented on QPID-8565:
--
alex-rufous commented on a change in pull request #113:
URL: https://github.com/apache/qpid-broker-j/pull/113#discussion_r740212386
##
File path:
broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/config/AclRulePredicatesBuilder.java
##
@@ -123,6 +123,16 @@ else if (property == Property.ATTRIBUTES)
{
_attributeNames.addAll(splitToSet(value));
}
+else if (property == Property.CONNECTION_LIMIT)
+{
+LOGGER.warn("The ACL Rule property 'connection_limit' has been
deprecated");
Review comment:
The log message is misleading. The feature was completely removed. Only
syntax support was left behind
##
File path:
broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/config/AclRulePredicatesBuilder.java
##
@@ -123,6 +123,16 @@ else if (property == Property.ATTRIBUTES)
{
_attributeNames.addAll(splitToSet(value));
}
+else if (property == Property.CONNECTION_LIMIT)
+{
+LOGGER.warn("The ACL Rule property 'connection_limit' has been
deprecated");
+return false;
+}
+else if (property == Property.CONNECTION_FREQUENCY_LIMIT)
+{
+LOGGER.warn("The ACL Rule property 'connection_frequency_limit'
has been deprecated");
Review comment:
The log message is misleading. The feature was completely removed. Only
syntax support was left behind
##
File path:
broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/config/RulePredicate.java
##
@@ -62,5 +71,16 @@ public boolean matches(LegacyOperation operation,
ObjectProperties objectPropert
return true;
}
+@Override
+public RulePredicate and(RulePredicate other)
Review comment:
IMHO, this breaks a semantic of logical and,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Broker-J] Enhancement of ACL rule predicates evaluation
>
>
> Key: QPID-8565
> URL: https://issues.apache.org/jira/browse/QPID-8565
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
>Reporter: Marek Laca
>Priority: Minor
> Labels: Broker, Java
>
> The access control plugin checks the rights of the user to perform an action
> on the broker's component. The access control plugin iterates through the ACL
> rules and checks their predicates. The user action is denied or allowed based
> on the test result.
> The aim of this task are refactoring of the code that is required for the
> [QPID-8487|https://issues.apache.org/jira/browse/QPID-8487] and
> [QPID-8488|https://issues.apache.org/jira/browse/QPID-8488], improving the
> test of the ACL rule predicates and removing useless classes. Changes should
> not have any impact on the functionality of the access control plugin.
> The ObjectProperties class has two responsibilities, it holds the rule
> predicates and also the objects properties that are checked. The
> responsibilities of ObjectProperties class should be split because the code
> should honor the principle of one responsibility per class.
> The Rule class is treated as immutable but the immutability is not enforce by
> the code.
> The Action, AclAction and ClientAction classes are only data holders that
> don't have any real responsibility.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8565) [Broker-J] Enhancement of ACL rule predicates evaluation
[ https://issues.apache.org/jira/browse/QPID-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436829#comment-17436829 ] ASF GitHub Bot commented on QPID-8565: -- alex-rufous commented on pull request #113: URL: https://github.com/apache/qpid-broker-j/pull/113#issuecomment-956234276 > CONNECTION_LIMIT and CONNECTION_FREQUENCY_LIMIT properties are deprecated and they are not supported. That is not a precise statement. The support for CONNECTION_LIMIT and CONNECTION_FREQUENCY_LIMIT had been dropped a while ago. I deleted it completely as the warning was misleading. It was stating that the feature was deprecated whilst in fact it was completely removed. The deprecated feature should work as expected. > Actual implementation silently parses and adds a new predicate. This is the worst scenario because: > > 1. "CONNECTION_LIMIT" and "CONNECTION_FREQUENCY_LIMIT" are silently parsed but the code does not perform expected check. > > 2. The rule itself becomes unmatchable because any object never has the property "CONNECTION_LIMIT" or "CONNECTION_FREQUENCY_LIMIT". Hence, any object can not match with the rule. IMHO, handling CONNECTION_LIMIT and CONNECTION_FREQUENCY_LIMIT without implementation did not look right to me. Marec, are you planning to restore the behaviour behind CONNECTION_LIMIT and CONNECTION_FREQUENCY_LIMIT ? > > The main aim of this changes is performance. Hence, I would like to keep the chain of rule predicates as short as possible. The RulePredicate.Any does not perform any check and so it can be omitted in the chain. IMHO, check for "any" looked like a premature optimisation to me. Have you tested a performance impact? I anticipate that performance impact from having an extra predicate in chain should be neglectable. The code readability has improved significantly without additional "any" check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Broker-J] Enhancement of ACL rule predicates evaluation > > > Key: QPID-8565 > URL: https://issues.apache.org/jira/browse/QPID-8565 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Marek Laca >Priority: Minor > Labels: Broker, Java > > The access control plugin checks the rights of the user to perform an action > on the broker's component. The access control plugin iterates through the ACL > rules and checks their predicates. The user action is denied or allowed based > on the test result. > The aim of this task are refactoring of the code that is required for the > [QPID-8487|https://issues.apache.org/jira/browse/QPID-8487] and > [QPID-8488|https://issues.apache.org/jira/browse/QPID-8488], improving the > test of the ACL rule predicates and removing useless classes. Changes should > not have any impact on the functionality of the access control plugin. > The ObjectProperties class has two responsibilities, it holds the rule > predicates and also the objects properties that are checked. The > responsibilities of ObjectProperties class should be split because the code > should honor the principle of one responsibility per class. > The Rule class is treated as immutable but the immutability is not enforce by > the code. > The Action, AclAction and ClientAction classes are only data holders that > don't have any real responsibility. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] alex-rufous commented on pull request #113: QPID-8565: [Broker-J] Enhancement of ACL rule predicates evaluation
alex-rufous commented on pull request #113: URL: https://github.com/apache/qpid-broker-j/pull/113#issuecomment-956234276 > CONNECTION_LIMIT and CONNECTION_FREQUENCY_LIMIT properties are deprecated and they are not supported. That is not a precise statement. The support for CONNECTION_LIMIT and CONNECTION_FREQUENCY_LIMIT had been dropped a while ago. I deleted it completely as the warning was misleading. It was stating that the feature was deprecated whilst in fact it was completely removed. The deprecated feature should work as expected. > Actual implementation silently parses and adds a new predicate. This is the worst scenario because: > > 1. "CONNECTION_LIMIT" and "CONNECTION_FREQUENCY_LIMIT" are silently parsed but the code does not perform expected check. > > 2. The rule itself becomes unmatchable because any object never has the property "CONNECTION_LIMIT" or "CONNECTION_FREQUENCY_LIMIT". Hence, any object can not match with the rule. IMHO, handling CONNECTION_LIMIT and CONNECTION_FREQUENCY_LIMIT without implementation did not look right to me. Marec, are you planning to restore the behaviour behind CONNECTION_LIMIT and CONNECTION_FREQUENCY_LIMIT ? > > The main aim of this changes is performance. Hence, I would like to keep the chain of rule predicates as short as possible. The RulePredicate.Any does not perform any check and so it can be omitted in the chain. IMHO, check for "any" looked like a premature optimisation to me. Have you tested a performance impact? I anticipate that performance impact from having an extra predicate in chain should be neglectable. The code readability has improved significantly without additional "any" check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2109) Shutdown crash: member access within null pointer of type 'struct qdr_node_t'
[
https://issues.apache.org/jira/browse/DISPATCH-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2109.
-
Resolution: Fixed
> Shutdown crash: member access within null pointer of type 'struct qdr_node_t'
> -
>
> Key: DISPATCH-2109
> URL: https://issues.apache.org/jira/browse/DISPATCH-2109
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/503812980#L4578
> {code}
> 28:
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530:17:
> runtime error: member access within null pointer of type 'struct qdr_node_t'
> 28: #0 0x3ff9628d5bd in qdr_set_cost_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530
> 28: #1 0x3ff9627e7cb in qdr_core_free
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:251
> 28: #2 0x3ff962e13f9 in qd_router_free
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2160
> 28: #3 0x3ff9617979d in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:375
> 28: #4 0x3ff9617979d in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:363
> 28: #5 0x2aa23604fa9 in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:119
> 28: #6 0x2aa23604a23 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> 28: #7 0x3ff94faa5f9 in __libc_start_main
> (/lib/s390x-linux-gnu/libc.so.6+0x2a5f9)
> 28: #8 0x2aa23604d23
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x4d23)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2109) Shutdown crash: member access within null pointer of type 'struct qdr_node_t'
[
https://issues.apache.org/jira/browse/DISPATCH-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436815#comment-17436815
]
Ganesh Murthy commented on DISPATCH-2109:
-
I am going to assume that the fix for DISPATCH-2230 fixed this issue and mark
this issue as Resolved. We will reopen if this crash happens again.
> Shutdown crash: member access within null pointer of type 'struct qdr_node_t'
> -
>
> Key: DISPATCH-2109
> URL: https://issues.apache.org/jira/browse/DISPATCH-2109
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/503812980#L4578
> {code}
> 28:
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530:17:
> runtime error: member access within null pointer of type 'struct qdr_node_t'
> 28: #0 0x3ff9628d5bd in qdr_set_cost_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530
> 28: #1 0x3ff9627e7cb in qdr_core_free
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:251
> 28: #2 0x3ff962e13f9 in qd_router_free
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2160
> 28: #3 0x3ff9617979d in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:375
> 28: #4 0x3ff9617979d in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:363
> 28: #5 0x2aa23604fa9 in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:119
> 28: #6 0x2aa23604a23 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> 28: #7 0x3ff94faa5f9 in __libc_start_main
> (/lib/s390x-linux-gnu/libc.so.6+0x2a5f9)
> 28: #8 0x2aa23604d23
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x4d23)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2268) HTTP/1.x: incorrectly logs connection close as an error
[ https://issues.apache.org/jira/browse/DISPATCH-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-2268. -- Resolution: Fixed > HTTP/1.x: incorrectly logs connection close as an error > --- > > Key: DISPATCH-2268 > URL: https://issues.apache.org/jira/browse/DISPATCH-2268 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.17.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: HTTP/1.x > Fix For: 1.18.0 > > > When running aclient load the adaptor frequently generates > HTTP_ADAPTOR (error) [C4201] Connection closing: Connection: close > For what seems like normal connection close handling -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2268) HTTP/1.x: incorrectly logs connection close as an error
[ https://issues.apache.org/jira/browse/DISPATCH-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436810#comment-17436810 ] ASF GitHub Bot commented on DISPATCH-2268: -- kgiusti commented on pull request #1408: URL: https://github.com/apache/qpid-dispatch/pull/1408#issuecomment-956204998 Merged https://github.com/apache/qpid-dispatch/commit/72034876c94aee730ef5b1556f1c86c9685103f1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > HTTP/1.x: incorrectly logs connection close as an error > --- > > Key: DISPATCH-2268 > URL: https://issues.apache.org/jira/browse/DISPATCH-2268 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.17.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: HTTP/1.x > Fix For: 1.18.0 > > > When running aclient load the adaptor frequently generates > HTTP_ADAPTOR (error) [C4201] Connection closing: Connection: close > For what seems like normal connection close handling -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2268) HTTP/1.x: incorrectly logs connection close as an error
[ https://issues.apache.org/jira/browse/DISPATCH-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436811#comment-17436811 ] ASF GitHub Bot commented on DISPATCH-2268: -- kgiusti closed pull request #1408: URL: https://github.com/apache/qpid-dispatch/pull/1408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > HTTP/1.x: incorrectly logs connection close as an error > --- > > Key: DISPATCH-2268 > URL: https://issues.apache.org/jira/browse/DISPATCH-2268 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.17.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: HTTP/1.x > Fix For: 1.18.0 > > > When running aclient load the adaptor frequently generates > HTTP_ADAPTOR (error) [C4201] Connection closing: Connection: close > For what seems like normal connection close handling -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #1408: DISPATCH-2268: fix misleading log messages in the HTTP/1.x adaptor
kgiusti closed pull request #1408: URL: https://github.com/apache/qpid-dispatch/pull/1408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #1408: DISPATCH-2268: fix misleading log messages in the HTTP/1.x adaptor
kgiusti commented on pull request #1408: URL: https://github.com/apache/qpid-dispatch/pull/1408#issuecomment-956204998 Merged https://github.com/apache/qpid-dispatch/commit/72034876c94aee730ef5b1556f1c86c9685103f1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2268) HTTP/1.x: incorrectly logs connection close as an error
[ https://issues.apache.org/jira/browse/DISPATCH-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436806#comment-17436806 ] ASF subversion and git services commented on DISPATCH-2268: --- Commit 72034876c94aee730ef5b1556f1c86c9685103f1 in qpid-dispatch's branch refs/heads/main from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=7203487 ] DISPATCH-2268: fix misleading log messages in the HTTP/1.x adaptor > HTTP/1.x: incorrectly logs connection close as an error > --- > > Key: DISPATCH-2268 > URL: https://issues.apache.org/jira/browse/DISPATCH-2268 > Project: Qpid Dispatch > Issue Type: Bug > Components: Protocol Adaptors >Affects Versions: 1.17.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Labels: HTTP/1.x > Fix For: 1.18.0 > > > When running aclient load the adaptor frequently generates > HTTP_ADAPTOR (error) [C4201] Connection closing: Connection: close > For what seems like normal connection close handling -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2400) 0.36.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436804#comment-17436804 ] ASF subversion and git services commented on PROTON-2400: - Commit 75557becd4d88a3da3ee8452be30fdc1214f27ed in qpid-proton's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=75557be ] PROTON-2442, PROTON-2400: bump version to 0.37.0-SNAPSHOT > 0.36.0 release tasks > > > Key: PROTON-2400 > URL: https://issues.apache.org/jira/browse/PROTON-2400 > Project: Qpid Proton > Issue Type: Task > Components: proton-c, release >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: proton-c-0.36.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2400) 0.36.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436802#comment-17436802 ] ASF subversion and git services commented on PROTON-2400: - Commit 59dd2c171f048a15a42b5e3e82b64cbc2c0cb037 in qpid-proton's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=59dd2c1 ] PROTON-2400: update version for 0.36.0-rc1 > 0.36.0 release tasks > > > Key: PROTON-2400 > URL: https://issues.apache.org/jira/browse/PROTON-2400 > Project: Qpid Proton > Issue Type: Task > Components: proton-c, release >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: proton-c-0.36.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2442) 0.37.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436803#comment-17436803 ] ASF subversion and git services commented on PROTON-2442: - Commit 75557becd4d88a3da3ee8452be30fdc1214f27ed in qpid-proton's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=75557be ] PROTON-2442, PROTON-2400: bump version to 0.37.0-SNAPSHOT > 0.37.0 release tasks > > > Key: PROTON-2442 > URL: https://issues.apache.org/jira/browse/PROTON-2442 > Project: Qpid Proton > Issue Type: Task > Components: proton-c, release >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: proton-c-0.37.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2274) system_tests_router_mesh: ERROR: AddressSanitizer: use-after-poison in qd_link_pn container.c:1029
[
https://issues.apache.org/jira/browse/DISPATCH-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated DISPATCH-2274:
-
Environment: Aarch64 Linux, amd64 macOS (was: macOS)
> system_tests_router_mesh: ERROR: AddressSanitizer: use-after-poison in
> qd_link_pn container.c:1029
> --
>
> Key: DISPATCH-2274
> URL: https://issues.apache.org/jira/browse/DISPATCH-2274
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.18.0
> Environment: Aarch64 Linux, amd64 macOS
>Reporter: Jiri Daněk
>Priority: Major
>
> https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/545969177
> {noformat}
> 66: Create 10 senders each with a different priority. ... ERROR
> 66: ERROR
> 66:
> 66: Router RouterC output file:
> 66:
> 66: =
> 66: ==21601==ERROR: AddressSanitizer: use-after-poison on address
> 0x6137d828 at pc 0x0001064a6469 bp 0x7843bca0 sp 0x7843bc98
> 66: READ of size 8 at 0x6137d828 thread T4
> 66: #0 0x1064a6468 in qd_link_pn container.c:1029
> 66: #1 0x1066d0e37 in CORE_link_push router_node.c:1920
> 66: #2 0x106576df6 in qdr_connection_process connections.c:414
> 66: #3 0x1064956ce in writable_handler container.c:396
> 66: #4 0x1066edb36 in thread_run server.c:1149
> 66: #5 0x7fff5fa152ea in _pthread_body
> (libsystem_pthread.dylib:x86_64+0x32ea)
> 66: #6 0x7fff5fa18248 in _pthread_start
> (libsystem_pthread.dylib:x86_64+0x6248)
> 66: #7 0x7fff5fa1440c in thread_start
> (libsystem_pthread.dylib:x86_64+0x240c)
> 66:
> 66: 0x6137d828 is located 168 bytes inside of 320-byte region
> [0x6137d780,0x6137d8c0)
> 66: allocated by thread T4 here:
> 66: #0 0x106f823a7 in wrap_posix_memalign
> (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x5f3a7)
> 66: #1 0x1064555df in qd_alloc alloc_pool.c:396
> 66: #2 0x10649691a in qd_container_handle_event container.c:75
> 66: #3 0x1066f4366 in handle server.c:1108
> 66: #4 0x1066eda23 in thread_run server.c:1133
> 66: #5 0x7fff5fa152ea in _pthread_body
> (libsystem_pthread.dylib:x86_64+0x32ea)
> 66: #6 0x7fff5fa18248 in _pthread_start
> (libsystem_pthread.dylib:x86_64+0x6248)
> 66: #7 0x7fff5fa1440c in thread_start
> (libsystem_pthread.dylib:x86_64+0x240c)
> 66:
> 66: Thread T4 created by T0 here:
> 66: #0 0x106f79add in wrap_pthread_create
> (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x56add)
> 66: #1 0x106535a6d in sys_thread threading.c:181
> 66: #2 0x1066ed1af in qd_server_run server.c:1525
> 66: #3 0x1063b081e in main_process main.c:115
> 66: #4 0x1063af12b in main main.c:369
> 66: #5 0x7fff5f8213d4 in start (libdyld.dylib:x86_64+0x163d4)
> 66:
> 66: SUMMARY: AddressSanitizer: use-after-poison container.c:1029 in qd_link_pn
> 66: Shadow bytes around the buggy address:
> 66: 0x1c26fab0: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
> 66: 0x1c26fac0: 00 00 00 00 00 00 00 00 00 00 f7 f7 f7 f7 f7 f7
> 66: 0x1c26fad0: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 00 00 00 00
> 66: 0x1c26fae0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
> 66: 0x1c26faf0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 66: =>0x1c26fb00: 00 00 f7 f7 f7[f7]f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
> 66: 0x1c26fb10: f7 f7 f7 f7 00 00 00 00 fa fa fa fa fa fa fa fa
> 66: 0x1c26fb20: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
> 66: 0x1c26fb30: 00 00 00 00 00 00 00 00 00 00 f7 f7 f7 f7 f7 f7
> 66: 0x1c26fb40: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 00 00 00 00
> 66: 0x1c26fb50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
> 66: Shadow byte legend (one shadow byte represents 8 application bytes):
> 66: Addressable: 00
> 66: Partially addressable: 01 02 03 04 05 06 07
> 66: Heap left redzone: fa
> 66: Freed heap region: fd
> 66: Stack left redzone: f1
> 66: Stack mid redzone: f2
> 66: Stack right redzone: f3
> 66: Stack after return: f5
> 66: Stack use after scope: f8
> 66: Global redzone: f9
> 66: Global init order: f6
> 66: Poisoned by user:f7
> 66: Container overflow: fc
> 66: Array cookie:ac
> 66: Intra object redzone:bb
> 66: ASan internal: fe
> 66: Left alloca redzone: ca
> 66: Right alloca redzone:cb
> 66: Shadow gap: cc
> 66: ==21601==ABORTING
> {noformat}
> essentially the same stacktrace in the same job
> {noformat}
> 27: ERROR
> 27: test_90_block_link_route_EB1_INTB
> (system_tests_policy_oversize_compound.MaxMessageSizeLinkRouteOversize) ... ok
> 27:
> 27:
[jira] [Commented] (DISPATCH-2114) Leak of qdr_link_t and qdr_terminus_t in system_tests_policy
[
https://issues.apache.org/jira/browse/DISPATCH-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436785#comment-17436785
]
Jiri Daněk commented on DISPATCH-2114:
--
I saw it again on Aarch64
https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/535972344#L4331
The build is 2 months old. I haven't seen it since. Possibly because there has
been fewer builds since, due to fewer PRs being merged. Or maybe something
fixed this.
> Leak of qdr_link_t and qdr_terminus_t in system_tests_policy
>
>
> Key: DISPATCH-2114
> URL: https://issues.apache.org/jira/browse/DISPATCH-2114
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/504830788#L4341
> {noformat}
> 25: Leak: 2021-05-12 05:33:05.768941 + type: qdr_terminus_t address:
> 0x61229950
> 445125: /lib/s390x-linux-gnu/libasan.so.5(+0x87550) [0x3ff88307550]
> 445225:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0x3e2)
> [0x3ff87a9af22]
> 445325:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qdr_terminus+0x36)
> [0x3ff87c12806]
> 445425:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x6d649a)
> [0x3ff87c5649a]
> 445525:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x6ed31a)
> [0x3ff87c6d31a]
> 445625:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x6f9912)
> [0x3ff87c79912]
> 445725:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_server_run+0x2aa)
> [0x3ff87c79f1a]
> 445825: qdrouterd(+0x4f92) [0x2aa2a004f92]
> 445925: qdrouterd(main+0x274) [0x2aa2a004a24]
> 446025: /lib/s390x-linux-gnu/libc.so.6(__libc_start_main+0x10a)
> [0x3ff8692a5fa]
> {noformat}
> {noformat}
> 25: Leak: 2021-05-12 05:33:05.768903 + type: qdr_link_t address:
> 0x617b1410
> 25: /lib/s390x-linux-gnu/libasan.so.5(+0x87550) [0x3ff88307550]
> 25:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0x3e2)
> [0x3ff87a9af22]
> 25:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qdr_link_first_attach+0x78)
> [0x3ff87b8a9a8]
> 25:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x6d62a8)
> [0x3ff87c562a8]
> 25:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x6ed31a)
> [0x3ff87c6d31a]
> 25:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x6f9912)
> [0x3ff87c79912]
> 25:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_server_run+0x2aa)
> [0x3ff87c79f1a]
> 25: qdrouterd(+0x4f92) [0x2aa2a004f92]
> 25: qdrouterd(main+0x274) [0x2aa2a004a24]
> 25: /lib/s390x-linux-gnu/libc.so.6(__libc_start_main+0x10a) [0x3ff8692a5fa]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2245) [TSan] data race in qdr_link_process_deliveries during system_tests_delivery_counts
[
https://issues.apache.org/jira/browse/DISPATCH-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436784#comment-17436784
]
Jiri Daněk commented on DISPATCH-2245:
--
https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/535262591#L5564
> [TSan] data race in qdr_link_process_deliveries during
> system_tests_delivery_counts
> ---
>
> Key: DISPATCH-2245
> URL: https://issues.apache.org/jira/browse/DISPATCH-2245
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Jiri Daněk
>Priority: Major
> Labels: race-condition, tsan
>
> https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/535262591#L5625
> {noformat}
> 50: SUMMARY: ThreadSanitizer: data race
> /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:195 in
> qdr_link_process_deliveries
> 5623
> 50: SUMMARY: ThreadSanitizer: data race
> /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:212 in
> qdr_link_process_deliveries
> 5685
> {noformat}
> {noformat}
> 50: WARNING: ThreadSanitizer: data race (pid=15497)
> 50: Write of size 8 at 0x7b5400079a90 by thread T2 (mutexes: write M310):
> 50: #0 qdr_link_process_deliveries
> /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:195
> (qdrouterd+0xc6891)
> 50: #1 CORE_link_push
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:1929
> (qdrouterd+0xda247)
> 50: #2 qdr_connection_process
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:414
> (qdrouterd+0x9cf12)
> 50: #3 AMQP_writable_conn_handler
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:299
> (qdrouterd+0xd9ad1)
> 50: #4 writable_handler
> /home/travis/build/apache/qpid-dispatch/src/container.c:396
> (qdrouterd+0x697d4)
> 50: #5 qd_container_handle_event
> /home/travis/build/apache/qpid-dispatch/src/container.c:748
> (qdrouterd+0x697d4)
> 50: #6 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1108
> (qdrouterd+0xe36e1)
> 50: #7 thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1133 (qdrouterd+0xe519c)
> 50: #8 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x8b991)
> 50:
> 50: Previous read of size 8 at 0x7b5400079a90 by thread T1:
> 50: #0 qdr_agent_write_column_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/agent_link.c:177
> (qdrouterd+0x99709)
> 50: #1 qdr_agent_write_link_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/agent_link.c:302
> (qdrouterd+0x9984d)
> 50: #2 qdra_link_get_next_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/agent_link.c:382
> (qdrouterd+0x99b69)
> 50: #3 qdrh_query_get_next_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/agent.c:566
> (qdrouterd+0x90bca)
> 50: #4 router_core_thread
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:236
> (qdrouterd+0xc0180)
> 50: #5 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x8b991)
> 50:
> 50: Location is heap block of size 576 at 0x7b5400079900 allocated by
> thread T1:
> 50: #0 posix_memalign
> ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:835
> (libtsan.so.0+0x3046d)
> 50: #1 qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396
> (qdrouterd+0x543f4)
> 50: #2 new_qdr_link_t
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:35
> (qdrouterd+0xb9392)
> 50: #3 qdr_create_link_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1128
> (qdrouterd+0x9e3d1)
> 50: #4 qdr_connection_opened_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:1410
> (qdrouterd+0xa2d72)
> 50: #5 router_core_thread
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:236
> (qdrouterd+0xc0180)
> 50: #6 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x8b991)
> 50:
> 50: Mutex M310 (0x7b10eb00) created at:
> 50: #0 pthread_mutex_init
> ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:1220
> (libtsan.so.0+0x4a616)
> 50: #1 sys_mutex
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:43
> (qdrouterd+0x8b9ff)
> 50: #2 qdr_connection_opened
> /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:111
> (qdrouterd+0x9bbc7)
> 50: #3 AMQP_opened_handler
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:1391
> (qdrouterd+0xdb285)
> 50: #4 AMQP_outbound_opened_handler
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:1577
> (qdrouterd+0xdc097)
> 50:
[jira] [Commented] (PROTON-2400) 0.36.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436783#comment-17436783 ] ASF subversion and git services commented on PROTON-2400: - Commit 014fdc105ee1fd68043d8e6ac94b5ae31adfcd92 in qpid-proton's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=014fdc1 ] PROTON-2400: update .so versions following review > 0.36.0 release tasks > > > Key: PROTON-2400 > URL: https://issues.apache.org/jira/browse/PROTON-2400 > Project: Qpid Proton > Issue Type: Task > Components: proton-c, release >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: proton-c-0.36.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2109) Shutdown crash: member access within null pointer of type 'struct qdr_node_t'
[
https://issues.apache.org/jira/browse/DISPATCH-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436782#comment-17436782
]
Jiri Daněk commented on DISPATCH-2109:
--
This issue has not reappeared in a few recent builds on main. It is possible
that it was fixed by DISPATCH-2230 or some other improvement at that time.
> Shutdown crash: member access within null pointer of type 'struct qdr_node_t'
> -
>
> Key: DISPATCH-2109
> URL: https://issues.apache.org/jira/browse/DISPATCH-2109
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.18.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/503812980#L4578
> {code}
> 28:
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530:17:
> runtime error: member access within null pointer of type 'struct qdr_node_t'
> 28: #0 0x3ff9628d5bd in qdr_set_cost_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/route_tables.c:530
> 28: #1 0x3ff9627e7cb in qdr_core_free
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:251
> 28: #2 0x3ff962e13f9 in qd_router_free
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2160
> 28: #3 0x3ff9617979d in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:375
> 28: #4 0x3ff9617979d in qd_dispatch_free
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:363
> 28: #5 0x2aa23604fa9 in main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:119
> 28: #6 0x2aa23604a23 in main
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> 28: #7 0x3ff94faa5f9 in __libc_start_main
> (/lib/s390x-linux-gnu/libc.so.6+0x2a5f9)
> 28: #8 0x2aa23604d23
> (/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x4d23)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2197) Data race in system_tests_auth_service_plugin involving remote_sasl_list_mechs
[
https://issues.apache.org/jira/browse/DISPATCH-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436776#comment-17436776
]
Jiri Daněk commented on DISPATCH-2197:
--
https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/545889780#L5337
probably worth adding to suppression file, to reduce noise
> Data race in system_tests_auth_service_plugin involving remote_sasl_list_mechs
> --
>
> Key: DISPATCH-2197
> URL: https://issues.apache.org/jira/browse/DISPATCH-2197
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
> Labels: race-condition, tsan
>
> https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/524340523#L5020
> {noformat}
> 43: Process 13678 error: exit code 66, expected 0
> 43: qdrouterd -c router.conf -I /home/travis/build/apache/qpid-dispatch/python
> 43:
> /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_auth_service_plugin/AuthServicePluginTest/setUpClass/router-4.cmd
> 43:
> 43: ==
> 43: WARNING: ThreadSanitizer: data race (pid=13678)
> 43: Read of size 8 at 0x7b316250 by thread T2:
> 43: #0 remote_sasl_list_mechs
> /home/travis/build/apache/qpid-dispatch/src/remote_sasl.c:431
> (qdrouterd+0x893d2)
> 43: #1 pni_sasl_impl_list_mechs
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/sasl/sasl.c:209
> (libqpid-proton-core.so.10+0x17ac2)
> 43: #2 pni_post_sasl_frame
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/sasl/sasl.c:495
> (libqpid-proton-core.so.10+0x17ac2)
> 43: #3 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x8b231)
> 43:
> 43: Previous write of size 8 at 0x7b316250 by thread T3:
> 43: #0 remote_sasl_process_mechanisms
> /home/travis/build/apache/qpid-dispatch/src/remote_sasl.c:384
> (qdrouterd+0x89494)
> 43: #1 pni_sasl_impl_process_mechanisms
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/sasl/sasl.c:239
> (libqpid-proton-core.so.10+0x187a9)
> 43: #2 pn_do_mechanisms
> /home/travis/build/apache/qpid-dispatch/qpid-proton/c/src/sasl/sasl.c:956
> (libqpid-proton-core.so.10+0x187a9)
> 43: #3 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x8b231)
> 43:
> 43: Location is heap block of size 184 at 0x7b316200 allocated by
> thread T2:
> 43: #0 malloc
> ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:651
> (libtsan.so.0+0x30323)
> 43: #1 qd_malloc
> /home/travis/build/apache/qpid-dispatch/include/qpid/dispatch/ctools.h:229
> (qdrouterd+0x8a96a)
> 43: #2 new_qdr_sasl_relay_t
> /home/travis/build/apache/qpid-dispatch/src/remote_sasl.c:140
> (qdrouterd+0x8a96a)
> 43: #3 qdr_use_remote_authentication_service
> /home/travis/build/apache/qpid-dispatch/src/remote_sasl.c:507
> (qdrouterd+0x8a96a)
> 43: #4 on_connection_bound
> /home/travis/build/apache/qpid-dispatch/src/server.c:755 (qdrouterd+0xe28ef)
> 43: #5 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1037
> (qdrouterd+0xe28ef)
> 43: #6 thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1133 (qdrouterd+0xe46f8)
> 43: #7 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x8b231)
> 43:
> 43: Thread T2 (tid=13681, running) created by main thread at:
> 43: #0 pthread_create
> ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:962
> (libtsan.so.0+0x5ea79)
> 43: #1 sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181
> (qdrouterd+0x8b7f2)
> 43: #2 qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1522 (qdrouterd+0xe536a)
> 43: #3 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:115
> (qdrouterd+0x2dc57)
> 43: #4 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2d0b2)
> 43:
> 43: Thread T3 (tid=13682, running) created by main thread at:
> 43: #0 pthread_create
> ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:962
> (libtsan.so.0+0x5ea79)
> 43: #1 sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181
> (qdrouterd+0x8b7f2)
> 43: #2 qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1522 (qdrouterd+0xe536a)
> 43: #3 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:115
> (qdrouterd+0x2dc57)
> 43: #4 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2d0b2)
> {noformat}
> {noformat}
> 43: WARNING: ThreadSanitizer: data race (pid=13678)
> 43: Read of size 1 at 0x7b042040 by thread T2:
>
[jira] [Commented] (DISPATCH-2274) system_tests_router_mesh: ERROR: AddressSanitizer: use-after-poison in qd_link_pn container.c:1029
[
https://issues.apache.org/jira/browse/DISPATCH-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436770#comment-17436770
]
Jiri Daněk commented on DISPATCH-2274:
--
Again, this time on Arm, with a different stacktrace
https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/545967870
{noformat}
27: ==14907==ERROR: AddressSanitizer: use-after-poison on address
0x7a425a48 at pc 0x0078cf64 bp 0x768f35b0 sp 0x768f35a8
27: READ of size 8 at 0x7a425a48 thread T2
27: #0 0x78cf60 in qd_connection_invoke_deferred_impl
/home/travis/build/apache/qpid-dispatch/src/server.c:1627:26
27: #1 0x774d44 in qd_link_q2_restart_receive
/home/travis/build/apache/qpid-dispatch/src/router_node.c:2205:9
27: #2 0x5dea54 in qd_message_send
/home/travis/build/apache/qpid-dispatch/src/message.c:2024:9
27: #3 0x7741c4 in CORE_link_deliver
/home/travis/build/apache/qpid-dispatch/src/router_node.c:1994:5
27: #4 0x71ee08 in qdr_link_process_deliveries
/home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:178:32
27: #5 0x6550f4 in qdr_connection_process
/home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:414:37
27: #6 0x59a964 in writable_handler
/home/travis/build/apache/qpid-dispatch/src/container.c:396:13
27: #7 0x79134c in handle
/home/travis/build/apache/qpid-dispatch/src/server.c:1108:9
27: #8 0x78b9dc in thread_run
/home/travis/build/apache/qpid-dispatch/src/server.c:1133:23
27: #9 0x827174f8 in start_thread
(/lib/aarch64-linux-gnu/libpthread.so.0+0x84f8)
27: #10 0x81fe1f28 (/lib/aarch64-linux-gnu/libc.so.6+0xd3f28)
27:
27: 0x7a425a48 is located 456 bytes inside of 2624-byte region
[0x7a425880,0x7a4262c0)
27: allocated by thread T0 here:
27: #0 0x4b304c in posix_memalign
(/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x4b304c)
27: #1 0x565dbc in qd_alloc
/home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396:13
27: #2 0x78f5ec in new_qd_connection_t
/home/travis/build/apache/qpid-dispatch/src/server.c:82:1
27: #3 0x78f5ec in try_open_cb
/home/travis/build/apache/qpid-dispatch/src/server.c:1339:28
27: #4 0x79d130 in qd_timer_visit
/home/travis/build/apache/qpid-dispatch/src/timer.c:316:9
27: #5 0x79152c in handle
/home/travis/build/apache/qpid-dispatch/src/server.c:1018:9
27: #6 0x78b900 in thread_run
/home/travis/build/apache/qpid-dispatch/src/server.c:1133:23
27: #7 0x78b134 in qd_server_run
/home/travis/build/apache/qpid-dispatch/src/server.c:1527:5
27:
27: Thread T2 created by T0 here:
27: #0 0x49d874 in pthread_create
(/home/travis/build/apache/qpid-dispatch/build/router/qdrouterd+0x49d874)
27: #1 0x621c20 in sys_thread
/home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181:5
27: #2 0x78b0b8 in qd_server_run
/home/travis/build/apache/qpid-dispatch/src/server.c:1525:22
27:
27: SUMMARY: AddressSanitizer: use-after-poison
/home/travis/build/apache/qpid-dispatch/src/server.c:1627:26 in
qd_connection_invoke_deferred_impl
27: Shadow bytes around the buggy address:
27: 0x200fef484af0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
27: 0x200fef484b00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
27: 0x200fef484b10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
27: 0x200fef484b20: 00 00 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
27: 0x200fef484b30: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
27: =>0x200fef484b40: f7 f7 f7 f7 f7 f7 f7 f7 f7[f7]f7 f7 f7 f7 f7 f7
27: 0x200fef484b50: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
27: 0x200fef484b60: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
27: 0x200fef484b70: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
27: 0x200fef484b80: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
27: 0x200fef484b90: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
27: Shadow byte legend (one shadow byte represents 8 application bytes):
27: Addressable: 00
27: Partially addressable: 01 02 03 04 05 06 07
27: Heap left redzone: fa
27: Freed heap region: fd
27: Stack left redzone: f1
27: Stack mid redzone: f2
27: Stack right redzone: f3
27: Stack after return: f5
27: Stack use after scope: f8
27: Global redzone: f9
27: Global init order: f6
27: Poisoned by user:f7
27: Container overflow: fc
27: Array cookie:ac
27: Intra object redzone:bb
27: ASan internal: fe
27: Left alloca redzone: ca
27: Right alloca redzone:cb
27: Shadow gap: cc
27: ==14907==ABORTING
{noformat}
> system_tests_router_mesh: ERROR: AddressSanitizer: use-after-poison in
> qd_link_pn container.c:1029
> --
>
> Key: DISPATCH-2274
> URL:
[jira] [Commented] (PROTON-2441) [cpp] Crash upon reconnect when user passed empty vector to connection_options::failover_urls
[
https://issues.apache.org/jira/browse/PROTON-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436761#comment-17436761
]
ASF GitHub Bot commented on PROTON-2441:
gemmellr commented on pull request #338:
URL: https://github.com/apache/qpid-proton/pull/338#issuecomment-956139968
The change itself seems reasonable to me, it looks similar to what the other
bit a little above it is doing.
I know Jiri thought, and I agree, that ensuring a test of some kind covers
this would be good since obviously nothing existing covered this except the
example, and so still doesnt with this as-is. Plus that it might also be good
to protect the spot where the segfault actually occurred, rather than just the
outer segment where the option is passed through to it, so no other routes can
hit similar issue in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cpp] Crash upon reconnect when user passed empty vector to
> connection_options::failover_urls
> -
>
> Key: PROTON-2441
> URL: https://issues.apache.org/jira/browse/PROTON-2441
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
>Affects Versions: proton-c-0.36.0
> Environment: Linux fedora 5.11.12-300.fc34.x86_64 #1 SMP Wed Apr 7
> 16:31:13 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
> NAME=Fedora
> VERSION="34 (Workstation Edition)"
> ID=fedora
> VERSION_ID=34
> VERSION_CODENAME=""
> PLATFORM_ID="platform:f34"
>Reporter: Rakhi Kumari
>Assignee: Rakhi Kumari
>Priority: Major
> Fix For: proton-c-0.37.0
>
>
> {noformat}
> $ gdb ./reconnect_client
> (gdb) run amqp://127.0.0.1 examples 1
> Starting program:
> /home/rkumari/repos/qpid-proton/build/cpp/examples/reconnect_client
> amqp://127.0.0.1 examples 1
> Missing separate debuginfos, use: dnf debuginfo-install
> glibc-2.33-5.fc34.x86_64
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library "/lib64/libthread_db.so.1".
> Retries: 0 Delay: 0 Trying: NO URL@0 SZ: 0
> *Program received signal SIGSEGV, Segmentation fault.*
> 0x77cf1104 in std::basic_ostream >&
> std::operator<< , std::allocator
> >(std::basic_ostream >&,
> std::__cxx11::basic_string, std::allocator
> > const&) () from /lib64/libstdc++.so.6
> (gdb) backtrace
> #0 0x77cf1104 in std::basic_ostream >&
> std::operator<< , std::allocator
> >(std::basic_ostream >&,
> std::__cxx11::basic_string, std::allocator
> > const&) () from /lib64/libstdc++.so.6
> #1 0x77e984b5 in proton::container::impl::reconnect (this=0x43c640,
> pnc=0x43df10) at
> /home/rkumari/repos/qpid-proton/cpp/src/proactor_container_impl.cpp:241
> #2 0x77ead66d in std::__invoke_impl (proton::container::impl::*&)(pn_connection_t*), proton::container::impl*&,
> pn_connection_t*&> (__f=
> @0x446060: (void (proton::container::impl::*)(proton::container::impl *
> const, pn_connection_t *)) 0x77e97ed4
> , __t=@0x446078:
> 0x43c640)
> at /usr/include/c++/11/bits/invoke.h:74
> #3 0x77ead1d6 in std::__invoke (proton::container::impl::*&)(pn_connection_t*), proton::container::impl*&,
> pn_connection_t*&> (__fn=
> @0x446060: (void (proton::container::impl::*)(proton::container::impl *
> const, pn_connection_t *)) 0x77e97ed4
> ) at
> /usr/include/c++/11/bits/invoke.h:96
> #4 0x77eacd73 in std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>::__call 1ul>(std::tuple<>&&, std::_Index_tuple<0ul, 1ul>) (this=0x446060, __args=...)
> at /usr/include/c++/11/functional:420
> #5 0x77eac7a6 in std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>::operator()<, void>() (this=0x446060)
> at /usr/include/c++/11/functional:503
> #6 0x77eaba21 in std::__invoke_impl (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&>(std::__invoke_other, std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&) (__f=...) at
> /usr/include/c++/11/bits/invoke.h:61
> #7 0x77eaa497 in std::__invoke_r (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&>(std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&) (__fn=...) at
> /usr/include/c++/11/bits/invoke.h:154
> #8 0x77ea8cdf in std::_Function_handler
[GitHub] [qpid-proton] gemmellr commented on pull request #338: PROTON-2441: [cpp] Fix connection_options failover urls segfault
gemmellr commented on pull request #338: URL: https://github.com/apache/qpid-proton/pull/338#issuecomment-956139968 The change itself seems reasonable to me, it looks similar to what the other bit a little above it is doing. I know Jiri thought, and I agree, that ensuring a test of some kind covers this would be good since obviously nothing existing covered this except the example, and so still doesnt with this as-is. Plus that it might also be good to protect the spot where the segfault actually occurred, rather than just the outer segment where the option is passed through to it, so no other routes can hit similar issue in future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2441) [cpp] Crash upon reconnect when user passed empty vector to connection_options::failover_urls
[
https://issues.apache.org/jira/browse/PROTON-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell updated PROTON-2441:
---
Fix Version/s: proton-c-0.37.0
Affects Version/s: proton-c-0.36.0
> [cpp] Crash upon reconnect when user passed empty vector to
> connection_options::failover_urls
> -
>
> Key: PROTON-2441
> URL: https://issues.apache.org/jira/browse/PROTON-2441
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
>Affects Versions: proton-c-0.36.0
> Environment: Linux fedora 5.11.12-300.fc34.x86_64 #1 SMP Wed Apr 7
> 16:31:13 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
> NAME=Fedora
> VERSION="34 (Workstation Edition)"
> ID=fedora
> VERSION_ID=34
> VERSION_CODENAME=""
> PLATFORM_ID="platform:f34"
>Reporter: Rakhi Kumari
>Assignee: Rakhi Kumari
>Priority: Major
> Fix For: proton-c-0.37.0
>
>
> {noformat}
> $ gdb ./reconnect_client
> (gdb) run amqp://127.0.0.1 examples 1
> Starting program:
> /home/rkumari/repos/qpid-proton/build/cpp/examples/reconnect_client
> amqp://127.0.0.1 examples 1
> Missing separate debuginfos, use: dnf debuginfo-install
> glibc-2.33-5.fc34.x86_64
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library "/lib64/libthread_db.so.1".
> Retries: 0 Delay: 0 Trying: NO URL@0 SZ: 0
> *Program received signal SIGSEGV, Segmentation fault.*
> 0x77cf1104 in std::basic_ostream >&
> std::operator<< , std::allocator
> >(std::basic_ostream >&,
> std::__cxx11::basic_string, std::allocator
> > const&) () from /lib64/libstdc++.so.6
> (gdb) backtrace
> #0 0x77cf1104 in std::basic_ostream >&
> std::operator<< , std::allocator
> >(std::basic_ostream >&,
> std::__cxx11::basic_string, std::allocator
> > const&) () from /lib64/libstdc++.so.6
> #1 0x77e984b5 in proton::container::impl::reconnect (this=0x43c640,
> pnc=0x43df10) at
> /home/rkumari/repos/qpid-proton/cpp/src/proactor_container_impl.cpp:241
> #2 0x77ead66d in std::__invoke_impl (proton::container::impl::*&)(pn_connection_t*), proton::container::impl*&,
> pn_connection_t*&> (__f=
> @0x446060: (void (proton::container::impl::*)(proton::container::impl *
> const, pn_connection_t *)) 0x77e97ed4
> , __t=@0x446078:
> 0x43c640)
> at /usr/include/c++/11/bits/invoke.h:74
> #3 0x77ead1d6 in std::__invoke (proton::container::impl::*&)(pn_connection_t*), proton::container::impl*&,
> pn_connection_t*&> (__fn=
> @0x446060: (void (proton::container::impl::*)(proton::container::impl *
> const, pn_connection_t *)) 0x77e97ed4
> ) at
> /usr/include/c++/11/bits/invoke.h:96
> #4 0x77eacd73 in std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>::__call 1ul>(std::tuple<>&&, std::_Index_tuple<0ul, 1ul>) (this=0x446060, __args=...)
> at /usr/include/c++/11/functional:420
> #5 0x77eac7a6 in std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>::operator()<, void>() (this=0x446060)
> at /usr/include/c++/11/functional:503
> #6 0x77eaba21 in std::__invoke_impl (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&>(std::__invoke_other, std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&) (__f=...) at
> /usr/include/c++/11/bits/invoke.h:61
> #7 0x77eaa497 in std::__invoke_r (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&>(std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&) (__fn=...) at
> /usr/include/c++/11/bits/invoke.h:154
> #8 0x77ea8cdf in std::_Function_handler (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)> >::_M_invoke(std::_Any_data const&)
> (__functor=...)
> at /usr/include/c++/11/bits/std_function.h:291
> #9 0x77e9f12e in std::function::operator()() const
> (this=0x445fa8) at /usr/include/c++/11/bits/std_function.h:560
> #10 0x77e96050 in proton::internal::v11::work::operator()
> (this=0x445fa8) at
> /home/rkumari/repos/qpid-proton/cpp/include/proton/work_queue.hpp:283
> #11 0x77e9ba47 in proton::container::impl::run_timer_jobs
> (this=0x43c640) at
> /home/rkumari/repos/qpid-proton/cpp/src/proactor_container_impl.cpp:536
> #12 0x77e9be69 in proton::container::impl::dispatch (this=0x43c640,
> event=0x43f160) at
> /home/rkumari/repos/qpid-proton/cpp/src/proactor_container_impl.cpp:567
> #13 0x77e9db82 in proton::container::impl::thread (this=0x43c640) at
>
[jira] [Updated] (PROTON-2406) [cpp] Use of reconnect_options::failover_urls triggers -Wdeprecated-declarations in examples/cpp/reconnect_client.cpp
[
https://issues.apache.org/jira/browse/PROTON-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell updated PROTON-2406:
---
Affects Version/s: (was: proton-c-0.35.0)
proton-c-0.36.0
> [cpp] Use of reconnect_options::failover_urls triggers
> -Wdeprecated-declarations in examples/cpp/reconnect_client.cpp
> -
>
> Key: PROTON-2406
> URL: https://issues.apache.org/jira/browse/PROTON-2406
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding, examples
>Affects Versions: proton-c-0.36.0
>Reporter: Jiri Daněk
>Assignee: Rakhi Kumari
>Priority: Minor
> Fix For: proton-c-0.37.0
>
>
> {noformat}
> [ 56%] Building CXX object
> CMakeFiles/reconnect_client.dir/reconnect_client.cpp.o
> /usr/share/proton/examples/cpp/reconnect_client.cpp: In member function
> ‘virtual void reconnect_client::on_container_start(proton::container&)’:
> /usr/share/proton/examples/cpp/reconnect_client.cpp:59:35: warning:
> ‘proton::reconnect_options& proton::reconnect_options::failover_urls(const
> std::vector >&)’ is deprecated (declared at
> /usr/include/proton/reconnect_options.hpp:82): use
> connection_options::failover_urls() [-Wdeprecated-declarations]
> ro.failover_urls(failovers);
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2406) [cpp] Use of reconnect_options::failover_urls triggers -Wdeprecated-declarations in examples/cpp/reconnect_client.cpp
[
https://issues.apache.org/jira/browse/PROTON-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell updated PROTON-2406:
---
Fix Version/s: proton-c-0.37.0
> [cpp] Use of reconnect_options::failover_urls triggers
> -Wdeprecated-declarations in examples/cpp/reconnect_client.cpp
> -
>
> Key: PROTON-2406
> URL: https://issues.apache.org/jira/browse/PROTON-2406
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding, examples
>Affects Versions: proton-c-0.35.0
>Reporter: Jiri Daněk
>Assignee: Rakhi Kumari
>Priority: Minor
> Fix For: proton-c-0.37.0
>
>
> {noformat}
> [ 56%] Building CXX object
> CMakeFiles/reconnect_client.dir/reconnect_client.cpp.o
> /usr/share/proton/examples/cpp/reconnect_client.cpp: In member function
> ‘virtual void reconnect_client::on_container_start(proton::container&)’:
> /usr/share/proton/examples/cpp/reconnect_client.cpp:59:35: warning:
> ‘proton::reconnect_options& proton::reconnect_options::failover_urls(const
> std::vector >&)’ is deprecated (declared at
> /usr/include/proton/reconnect_options.hpp:82): use
> connection_options::failover_urls() [-Wdeprecated-declarations]
> ro.failover_urls(failovers);
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2254) Relative paths in CMake share
[
https://issues.apache.org/jira/browse/PROTON-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436736#comment-17436736
]
ASF GitHub Bot commented on PROTON-2254:
gemmellr commented on pull request #335:
URL: https://github.com/apache/qpid-proton/pull/335#issuecomment-956115988
Raised https://issues.apache.org/jira/browse/PROTON-2450 to retarget this PR
against for future release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Relative paths in CMake share
> -
>
> Key: PROTON-2254
> URL: https://issues.apache.org/jira/browse/PROTON-2254
> Project: Qpid Proton
> Issue Type: Improvement
> Components: build, cpp-binding, proton-c
>Affects Versions: proton-c-0.31.0
> Environment: Debian Linux; build Proton then Dispatch into each their
> own `DESTDIR`. This is done by our "layered build" system,
> https://gitlab.com/arpa2/mkhere/-/blob/master/qpid_proton.sh and
> https://gitlab.com/arpa2/mkhere/-/blob/master/qpid_dispatch.sh
>Reporter: Rick van Rein
>Assignee: Jiri Daněk
>Priority: Minor
> Labels: cmake, install, proton
> Fix For: proton-c-0.36.0
>
> Original Estimate: 0.25h
> Time Spent: 4h
> Remaining Estimate: 0h
>
> This sequency installs well:
> {noformat}
> cmake
> make
> make DESTDIR=/some/where install
> {noformat}
> However, further use of the installation fails, because of strict
> dependencies on the *installed* paths in files like `ProtonConfig.cmake`:
> {noformat}
> set_target_properties(Proton::core
> PROPERTIES
> IMPORTED_LOCATION "/usr/local/lib/libqpid-proton-core.so"
> IMPORTED_LOCATION_DEBUG "/usr/local/lib/libqpid-proton-core.so"
> INTERFACE_INCLUDE_DIRECTORIES "${Proton_Core_INCLUDE_DIRS}")
> {noformat}
> **What would work:** First switch to the `DESTDIR`, then continue building
> something like Qpid Dispatch Router.
> **Solution:** Use relative directories, like in:
> {noformat}
> # Compute the installation prefix relative to this file.
> get_filename_component(_IMPORT_PREFIX "${CMAKE_CURRENT_LIST_FILE}" PATH)
> get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> if(_IMPORT_PREFIX STREQUAL "/")
> set(_IMPORT_PREFIX "")
> endif()
> {noformat}
> **Work-around:** An unhappy quickfix is
> {noformat}
> find /some/where -name *.cmake -exec \
> sed -i "s+/usr/+/some/where/usr/+g" {} \;
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] gemmellr commented on pull request #335: PROTON-2254 Generate correct relocatable pc files
gemmellr commented on pull request #335: URL: https://github.com/apache/qpid-proton/pull/335#issuecomment-956115988 Raised https://issues.apache.org/jira/browse/PROTON-2450 to retarget this PR against for future release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2450) Generate correct relocatable pc files
[ https://issues.apache.org/jira/browse/PROTON-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-2450: --- Description: Offshoot from PROTON-2254 / PROTON-2433 for continuing with https://github.com/apache/qpid-proton/pull/335. See PROTON-2254 for earlier comments. (was: Offshoot from PROTON-2254 / PROTON-2433) > Generate correct relocatable pc files > - > > Key: PROTON-2450 > URL: https://issues.apache.org/jira/browse/PROTON-2450 > Project: Qpid Proton > Issue Type: Improvement > Components: build, cpp-binding, proton-c >Reporter: Robbie Gemmell >Assignee: Jiri Daněk >Priority: Minor > Fix For: proton-c-0.37.0 > > > Offshoot from PROTON-2254 / PROTON-2433 for continuing with > https://github.com/apache/qpid-proton/pull/335. See PROTON-2254 for earlier > comments. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2254) Relative paths in CMake share
[
https://issues.apache.org/jira/browse/PROTON-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436735#comment-17436735
]
Robbie Gemmell commented on PROTON-2254:
Raised PROTON-2450 for continuing with
https://github.com/apache/qpid-proton/pull/335.
> Relative paths in CMake share
> -
>
> Key: PROTON-2254
> URL: https://issues.apache.org/jira/browse/PROTON-2254
> Project: Qpid Proton
> Issue Type: Improvement
> Components: build, cpp-binding, proton-c
>Affects Versions: proton-c-0.31.0
> Environment: Debian Linux; build Proton then Dispatch into each their
> own `DESTDIR`. This is done by our "layered build" system,
> https://gitlab.com/arpa2/mkhere/-/blob/master/qpid_proton.sh and
> https://gitlab.com/arpa2/mkhere/-/blob/master/qpid_dispatch.sh
>Reporter: Rick van Rein
>Assignee: Jiri Daněk
>Priority: Minor
> Labels: cmake, install, proton
> Fix For: proton-c-0.36.0
>
> Original Estimate: 0.25h
> Time Spent: 4h
> Remaining Estimate: 0h
>
> This sequency installs well:
> {noformat}
> cmake
> make
> make DESTDIR=/some/where install
> {noformat}
> However, further use of the installation fails, because of strict
> dependencies on the *installed* paths in files like `ProtonConfig.cmake`:
> {noformat}
> set_target_properties(Proton::core
> PROPERTIES
> IMPORTED_LOCATION "/usr/local/lib/libqpid-proton-core.so"
> IMPORTED_LOCATION_DEBUG "/usr/local/lib/libqpid-proton-core.so"
> INTERFACE_INCLUDE_DIRECTORIES "${Proton_Core_INCLUDE_DIRS}")
> {noformat}
> **What would work:** First switch to the `DESTDIR`, then continue building
> something like Qpid Dispatch Router.
> **Solution:** Use relative directories, like in:
> {noformat}
> # Compute the installation prefix relative to this file.
> get_filename_component(_IMPORT_PREFIX "${CMAKE_CURRENT_LIST_FILE}" PATH)
> get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> get_filename_component(_IMPORT_PREFIX "${_IMPORT_PREFIX}" PATH)
> if(_IMPORT_PREFIX STREQUAL "/")
> set(_IMPORT_PREFIX "")
> endif()
> {noformat}
> **Work-around:** An unhappy quickfix is
> {noformat}
> find /some/where -name *.cmake -exec \
> sed -i "s+/usr/+/some/where/usr/+g" {} \;
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2450) Generate correct relocatable pc files
Robbie Gemmell created PROTON-2450: -- Summary: Generate correct relocatable pc files Key: PROTON-2450 URL: https://issues.apache.org/jira/browse/PROTON-2450 Project: Qpid Proton Issue Type: Improvement Components: build, cpp-binding, proton-c Reporter: Robbie Gemmell Assignee: Jiri Daněk Fix For: proton-c-0.37.0 Offshoot from PROTON-2254 / PROTON-2433 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-1647) [go] support for crypto.tls connections
[ https://issues.apache.org/jira/browse/PROTON-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated PROTON-1647: Fix Version/s: proton-c-future > [go] support for crypto.tls connections > --- > > Key: PROTON-1647 > URL: https://issues.apache.org/jira/browse/PROTON-1647 > Project: Qpid Proton > Issue Type: Bug > Components: go-binding >Affects Versions: proton-c-0.18.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Minor > Labels: tls > Fix For: proton-c-future > > > The electron and proton Go bindings do not expose proton's built-in SSL layer > because Go provides it's own TLS layer in the crypto.tls package which is > more portable, capable and familiar to Go programmers. > You can already use a tls.Conn with proton or electron, but there are several > points that should be cleaned up: > - when a TLS connection is in use set allow-insecure-mechs in proton-C > automatically > - make sure the AMQP virtual-host matches the TLS virtual-host by default > - provide access to the net.Conn used by an electron.Connection, which in > turn will give access to TLS details if the user needs them > - provide an example of using TLS (maybe with SASL PLAIN auth?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8565) [Broker-J] Enhancement of ACL rule predicates evaluation
[ https://issues.apache.org/jira/browse/QPID-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436732#comment-17436732 ] ASF GitHub Bot commented on QPID-8565: -- mklaca opened a new pull request #113: URL: https://github.com/apache/qpid-broker-j/pull/113 CONNECTION_LIMIT and CONNECTION_FREQUENCY_LIMIT properties are deprecated and they are not supported. Actual implementation silently parse and add a new predicate. This is the worst scenario because: 1. "CONNECTION_LIMIT" and "CONNECTION_FREQUENCY_LIMIT" are silently parsed but the code does not perform expected check. 2. The rule itself becomes unmatchable because any object never has the property "CONNECTION_LIMIT" or "CONNECTION_FREQUENCY_LIMIT". Hence, any object can not match with the rule. The main aim of this changes is performance. Hence, I would like to keep the chain of rule predicates as short as possible. The RulePredicate.Any does not perform any check and so it can be omitted in the chain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Broker-J] Enhancement of ACL rule predicates evaluation > > > Key: QPID-8565 > URL: https://issues.apache.org/jira/browse/QPID-8565 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Marek Laca >Priority: Minor > Labels: Broker, Java > > The access control plugin checks the rights of the user to perform an action > on the broker's component. The access control plugin iterates through the ACL > rules and checks their predicates. The user action is denied or allowed based > on the test result. > The aim of this task are refactoring of the code that is required for the > [QPID-8487|https://issues.apache.org/jira/browse/QPID-8487] and > [QPID-8488|https://issues.apache.org/jira/browse/QPID-8488], improving the > test of the ACL rule predicates and removing useless classes. Changes should > not have any impact on the functionality of the access control plugin. > The ObjectProperties class has two responsibilities, it holds the rule > predicates and also the objects properties that are checked. The > responsibilities of ObjectProperties class should be split because the code > should honor the principle of one responsibility per class. > The Rule class is treated as immutable but the immutability is not enforce by > the code. > The Action, AclAction and ClientAction classes are only data holders that > don't have any real responsibility. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-broker-j] mklaca opened a new pull request #113: QPID-8565: [Broker-J] Enhancement of ACL rule predicates evaluation
mklaca opened a new pull request #113: URL: https://github.com/apache/qpid-broker-j/pull/113 CONNECTION_LIMIT and CONNECTION_FREQUENCY_LIMIT properties are deprecated and they are not supported. Actual implementation silently parse and add a new predicate. This is the worst scenario because: 1. "CONNECTION_LIMIT" and "CONNECTION_FREQUENCY_LIMIT" are silently parsed but the code does not perform expected check. 2. The rule itself becomes unmatchable because any object never has the property "CONNECTION_LIMIT" or "CONNECTION_FREQUENCY_LIMIT". Hence, any object can not match with the rule. The main aim of this changes is performance. Hence, I would like to keep the chain of rule predicates as short as possible. The RulePredicate.Any does not perform any check and so it can be omitted in the chain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2376) container.listen may support amqps
[
https://issues.apache.org/jira/browse/PROTON-2376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Ross updated PROTON-2376:
Labels: tls (was: )
> container.listen may support amqps
> --
>
> Key: PROTON-2376
> URL: https://issues.apache.org/jira/browse/PROTON-2376
> Project: Qpid Proton
> Issue Type: New Feature
> Components: proton-c
>Affects Versions: proton-c-0.33.0
>Reporter: carawang
>Priority: Major
> Labels: tls
>
> Hi, Whether the container.listen support the amqps?
> see the below:
> {code:java}
> def listen(url, handler=Listener::Handler.new)
> not_stopped
> url = Qpid::Proton::uri url
> # TODO aconway 2017-11-01: amqps, SSL
> listen_io(TCPServer.new(url.host, url.port), handler)
> end
> {code}
> The broker.rb[1] of ruby example setting the ssl but seems it does not work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2122) Hardcoded limit of 16 sasl mechanisms is insufficient on macOS
[
https://issues.apache.org/jira/browse/PROTON-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Ross updated PROTON-2122:
Labels: sasl (was: )
> Hardcoded limit of 16 sasl mechanisms is insufficient on macOS
> --
>
> Key: PROTON-2122
> URL: https://issues.apache.org/jira/browse/PROTON-2122
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: proton-c-0.29.0
> Environment: macOS 10.14
>Reporter: Jiri Daněk
>Priority: Major
> Labels: sasl
>
> On macOS, any time a SASL exchange happens in tests, e.g.
> {{cpp-example-container}} or qpid dispatch tests, or when
> {{cpp/examples/simple_send}} connects to {{cpp/examples/broker}}, the broker
> crashes with the following stack trace
> {noformat}
> Thread 1 Crashed:
> 0 libsystem_kernel.dylib 0x7fff697c62c6 __pthread_kill + 10
> 1 libsystem_pthread.dylib 0x7fff69881bf1 pthread_kill + 284
> 2 libsystem_c.dylib 0x7fff69730745 __abort + 144
> 3 libsystem_c.dylib 0x7fff69730ff3 __stack_chk_fail +
> 205
> 4 libqpid-proton-core.10.dylib0x000106d81f89
> pni_post_sasl_frame + 1321
> 5 ??? 0x7fd57acb59bb 0 + 140554864908731
> {noformat}
> AddressSanitizer (Valgrind does not run on most recent macOS releases) points
> out the reason.
> {noformat}
> $ ../cmake-build-debug/cpp/examples/broker
> broker listening on 5672
> =
> ==42793==ERROR: AddressSanitizer: stack-buffer-overflow on address
> 0x7c4bcbe0 at pc 0x0001013663e1 bp 0x7c4bc830 sp 0x7c4bc828
> WRITE of size 8 at 0x7c4bcbe0 thread T3
> #0 0x1013663e0 in pni_split_mechs sasl.c:443
> #1 0x1013646ea in pni_post_sasl_frame sasl.c:480
> #2 0x101357fad in pn_output_write_sasl sasl.c:677
> #3 0x101323909 in transport_produce transport.c:2751
> #4 0x10131ffd3 in pn_transport_pending transport.c:3030
> #5 0x1012b8755 in pn_connection_driver_write_buffer
> connection_driver.c:120
> #6 0x10120240f in leader_process_pconnection libuv.c:909
> #7 0x1011f8b48 in leader_lead_lh libuv.c:1008
> #8 0x1011f94f3 in pn_proactor_wait libuv.c:1062
> #9 0x10188c55d in proton::container::impl::thread()
> proactor_container_impl.cpp:753
> #10 0x1018bca31 in void*
> std::__1::__thread_proxy std::__1::default_delete >, void
> (proton::container::impl::*)(), proton::container::impl*> >(void*) thread:352
> #11 0x7fff6987f2ea in _pthread_body
> (libsystem_pthread.dylib:x86_64+0x32ea)
> #12 0x7fff69882248 in _pthread_start
> (libsystem_pthread.dylib:x86_64+0x6248)
> #13 0x7fff6987e40c in thread_start (libsystem_pthread.dylib:x86_64+0x240c)
> Address 0x7c4bcbe0 is located in stack of thread T3 at offset 192 in frame
> #0 0x101363ccf in pni_post_sasl_frame sasl.c:462
> This frame has 3 object(s):
> [32, 48) 'out' (line 464)
> [64, 192) 'mechs' (line 475) <== Memory access at offset 192 overflows
> this variable
> [224, 228) 'count' (line 478)
> HINT: this may be a false positive if your program uses some custom stack
> unwind mechanism, swapcontext or vfork
> (longjmp and C++ exceptions *are* supported)
> Thread T3 created by T0 here:
> #0 0x101f5dadd in wrap_pthread_create
> (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x56add)
> #1 0x1018bc4ab in std::__1::thread::thread (proton::container::impl::*)(), proton::container::impl*, void>(void
> (proton::container::impl::*&&)(), proton::container::impl*&&) thread:368
> #2 0x10188da97 in proton::container::impl::run(int)
> proactor_container_impl.cpp:802
> #3 0x100f0223c in main broker.cpp:427
> #4 0x7fff6968b3d4 in start (libdyld.dylib:x86_64+0x163d4)
> SUMMARY: AddressSanitizer: stack-buffer-overflow sasl.c:443 in pni_split_mechs
> Shadow bytes around the buggy address:
> 0x1e0001897920: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x1e0001897930: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x1e0001897940: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x1e0001897950: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x1e0001897960: 00 00 00 00 f1 f1 f1 f1 00 00 f2 f2 00 00 00 00
> =>0x1e0001897970: 00 00 00 00 00 00 00 00 00 00 00 00[f2]f2 f2 f2
> 0x1e0001897980: 04 f3 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00
> 0x1e0001897990: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x1e00018979a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x1e00018979b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 0x1e00018979c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> Shadow byte legend (one shadow byte represents 8 application bytes):
> Addressable:
[jira] [Updated] (PROTON-2434) Container.connect doesn't set virtual_host by default, making peer verification harder than it should be
[
https://issues.apache.org/jira/browse/PROTON-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Ross updated PROTON-2434:
Labels: tls (was: )
> Container.connect doesn't set virtual_host by default, making peer
> verification harder than it should be
>
>
> Key: PROTON-2434
> URL: https://issues.apache.org/jira/browse/PROTON-2434
> Project: Qpid Proton
> Issue Type: Bug
>Affects Versions: proton-c-0.35.0
>Reporter: Evgeni Golov
>Priority: Major
> Labels: tls
>
> In 0.35 proton-c started to default to PN_SSL_VERIFY_PEER_NAME in client
> mode, which is good. However, it seems that it does not (by default) extract
> the peer name from the URL, so a connection can not be established, even if
> the certs and everything matches, as there is no name to verify against.
> Looking at the Ruby examples
> ([https://qpid.apache.org/releases/qpid-proton-0.35.0/proton/ruby/examples/ssl_send.rb.html),]
> you suggest to roll back the default VERIFY_PEER_NAME to ANONYMOUS_PEER:
> {code:ruby}
> ssl_domain =
> Qpid::Proton::SSLDomain.new(Qpid::Proton::SSLDomain::MODE_CLIENT)
> ssl_domain.peer_authentication(Qpid::Proton::SSLDomain::ANONYMOUS_PEER)
> c = container.connect(@url, { :ssl_domain => ssl_domain })
> {code}
> And indeed, dropping the ANONYMOUS_PEER fails the connection attempt.
> Instead, we can explicitly set the virtual_host of the connection, thus
> allowing the PEER_NAME verification to succeed:
> {code:ruby}
> ssl_domain =
> Qpid::Proton::SSLDomain.new(Qpid::Proton::SSLDomain::MODE_CLIENT)
> c = container.connect(@url, { :ssl_domain => ssl_domain, :virtual_host =>
> URI.parse(@url).host })
> {code}
> However, I think this is cumbersome and makes users lifes harder than they
> should be.
> If container.connect would automatically set the virtual_host to the host
> part of the URL (unless it was defined by the user), SSL verification would
> just work.
> FWIW, I only tested this all with the Ruby bindings on Ruby 2.7, OpenSSL
> 1.0.2k-21.el7_9.x86_64 (CentOS 7), so this might behave differently on other
> environments.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-1057) Windows SChannel SSL test failure
[ https://issues.apache.org/jira/browse/PROTON-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated PROTON-1057: Labels: tls windows (was: windows) > Windows SChannel SSL test failure > - > > Key: PROTON-1057 > URL: https://issues.apache.org/jira/browse/PROTON-1057 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-0.12.0 > Environment: Windows only. >Reporter: Clifford Jansen >Assignee: Clifford Jansen >Priority: Major > Labels: tls, windows > Fix For: proton-c-future > > > This problem started since PROTON-1048 which did not touch the Proton-C > SChannel related code - it just tweaked the test infrastructure to use > alternate certificate formats for Windows. > The proton_tests.ssl.SslTest.test_server_hostname_authentication test > randomly crashes on Windows, presumably from some memory corruption > somewhere. It often runs fine. Seems to happen more frequently on some > systems than others. Not yet seen on a 64 bit build. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-1802) Support compiling with -DSSL_IMPL=openssl on Windows
[ https://issues.apache.org/jira/browse/PROTON-1802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated PROTON-1802: Labels: tls (was: ) > Support compiling with -DSSL_IMPL=openssl on Windows > > > Key: PROTON-1802 > URL: https://issues.apache.org/jira/browse/PROTON-1802 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: proton-c-0.21.0 > Environment: OpenSSL 1.1.0-stable > qpid-proton-0.21.0 > Visual Studio 2015 > -DSSL_IMPL=openssl >Reporter: Meng Zhou >Priority: Major > Labels: tls > > I am using > OpenSSL 1.1.0-stable > qpid-proton-0.21.0 > Visual Studio 2015 > When I set SSL_IMPL=openssl the compiler report > openssl.c > \qpid-proton-0.21.0\proton-c\src\ssl\openssl.c(1540): error C2065: > 'initialize': undeclared identifier > \qpid-proton-0.21.0\proton-c\src\ssl\openssl.c(1540): error C3861: > 'InitOnceExecuteOnce': identifier not found -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2009) OpenSSL API has changed and now deprecates SSL_OP_NO_TLSv* used with SSL_CTX_set_options
[ https://issues.apache.org/jira/browse/PROTON-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated PROTON-2009: Labels: tls (was: ) > OpenSSL API has changed and now deprecates SSL_OP_NO_TLSv* used with > SSL_CTX_set_options > > > Key: PROTON-2009 > URL: https://issues.apache.org/jira/browse/PROTON-2009 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.26.0 > Environment: Fedora 29, OpenSSL 1.1.1 FIPS 11 Sep 2018 >Reporter: Charles E. Rolke >Assignee: Andrew Stitcher >Priority: Major > Labels: tls > > The OpenSSL SSL_OP_NO_TLSvxxx options are deprecated for use in > SSL_CTX_set_options(). > As of OpenSSL 1.1 way to specify TLS versions is through a min-version and > max-version scheme - this is more code future proof. > You can specify a minimum version and 0 for the maximum meaning the latest > version. > Proton's interface to this allows more than can be specified using the > min/max API as you can specify each protocol individually. > The proton code is also not future proof in that it "knows" about each TLS > protocol individually in the code. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-1864) [c] No way of indicating that a transport is ssl or encrypted or already authenticated
[ https://issues.apache.org/jira/browse/PROTON-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated PROTON-1864: Labels: tls (was: ) > [c] No way of indicating that a transport is ssl or encrypted or already > authenticated > -- > > Key: PROTON-1864 > URL: https://issues.apache.org/jira/browse/PROTON-1864 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Reporter: Gordon Sim >Priority: Major > Labels: tls > > This is needed e.g. for DISPATCH-1040 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-855) Add axTLS (embedded SSL) support to proton-c
[ https://issues.apache.org/jira/browse/PROTON-855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated PROTON-855: --- Labels: features patch tls (was: features patch) > Add axTLS (embedded SSL) support to proton-c > > > Key: PROTON-855 > URL: https://issues.apache.org/jira/browse/PROTON-855 > Project: Qpid Proton > Issue Type: New Feature > Components: proton-c >Affects Versions: proton-0.9, proton-0.9.1, proton-0.10 > Environment: Platform independent >Reporter: Tomasz Nowicki >Priority: Major > Labels: features, patch, tls > Fix For: proton-c-future > > Attachments: axtls.c, axtls_proton_example.c, qpidproton-AXTLS.patch, > ssl_io.h > > Original Estimate: 0h > Remaining Estimate: 0h > > The axTLS embedded SSL project is a highly configurable client/server > TLSv1 SSL library designed for platforms with small memory requirements. > It comes with a small HTTP/HTTPS server and additional test tools. > axTLS It's free! (BSD style licensing) > http://axtls.sourceforge.net/ > axTLS integration with proton is done on socket layer(posix layer). On the > other hand OpenSSL integration with proton is done on the transport layer. To > use both solutions we had to add two methods pn_ssl_recv i pn_ssl_send > (daclared in include/ssl_io.h) which in openssl mode, without crypting, > invoke native proton "pn_send" and "pn_receive (io.c)". In axTLS mode, those > methods are replaced with proper axtls comunication methods. Those are > defined in openssl.c, ssl_stub.c, axtls.c and located in src/ssl. > Methods pn_ssl_recv and pn_ssl_send replace original pn_send and pn_recv used > in pni_connection_writable(pn_selectable_t *sel), > pni_connection_readable(pn_selectable_t *sel) (connection.c). > Moreover we introduced new file axtls.c located in src/ssl. The file is an > equivalent of openssl.c, implementing base ssl methods: PN_EXTERN > pn_ssl_domain_t *pn_ssl_domain( pn_ssl_mode_t mode); > PN_EXTERN void pn_ssl_domain_free( pn_ssl_domain_t *domain ); etc > Example of axTLS integration with ex ActiveMQ > atatched(axtls_proton_example.c): > It's based on > http://mail-archives.us.apache.org/mod_mbox/qpid-proton/201501.mbox/%3ccacl1bnc5jerbnikd_4fgkjqh13h5nl_2z-sszp3jg2t+ywa...@mail.gmail.com%3E -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-1870) better logging for ssl
[ https://issues.apache.org/jira/browse/PROTON-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated PROTON-1870: Labels: logging tls usability (was: logging usability) > better logging for ssl > -- > > Key: PROTON-1870 > URL: https://issues.apache.org/jira/browse/PROTON-1870 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding >Affects Versions: proton-0.9.1, proton-c-0.31.0 >Reporter: Gordon Sim >Priority: Major > Labels: logging, tls, usability > > Would be nice to have better logging for ssl connections, particularly where > they fail, e.g. the sni used, the ca the peer cert is signed with etc -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2303) SSL Unknown Error
[
https://issues.apache.org/jira/browse/PROTON-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Ross updated PROTON-2303:
Labels: tls (was: )
> SSL Unknown Error
> -
>
> Key: PROTON-2303
> URL: https://issues.apache.org/jira/browse/PROTON-2303
> Project: Qpid Proton
> Issue Type: Bug
>Reporter: Angelo Mendonca
>Priority: Major
> Labels: tls
>
> ERROR - ActiveMQ connection exception, Retrying, Connection
> amqps://x...@id-1.mq.us-east-1.amazonaws.com:5671 disconnected:
> Condition('amqp:connection:framing-error', 'SSL Failure: Unknown error')
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2441) [cpp] Crash upon reconnect when user passed empty vector to connection_options::failover_urls
[
https://issues.apache.org/jira/browse/PROTON-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436672#comment-17436672
]
ASF GitHub Bot commented on PROTON-2441:
DreamPearl commented on pull request #338:
URL: https://github.com/apache/qpid-proton/pull/338#issuecomment-956023315
@gemmellr @jiridanek Can you please take a look.
The cause of segfault was that when we were passing empty vector to
connection_options::failoverurls, the current_url was getting set to 0. And on
the basis of the value of current_url i.e. 0, it was picking failover_urls
instead of reconnect_urls. As it was trying to access failover_urls which was
empty, it leads to segfault.
Deprecated code was able to handle the empty vector, non-deprecated wasn't.
Alternatively, I tried this:
https://github.com/apache/qpid-proton/commit/50d8342c4932da698389dd991760c607de7f79f5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cpp] Crash upon reconnect when user passed empty vector to
> connection_options::failover_urls
> -
>
> Key: PROTON-2441
> URL: https://issues.apache.org/jira/browse/PROTON-2441
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
> Environment: Linux fedora 5.11.12-300.fc34.x86_64 #1 SMP Wed Apr 7
> 16:31:13 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
> NAME=Fedora
> VERSION="34 (Workstation Edition)"
> ID=fedora
> VERSION_ID=34
> VERSION_CODENAME=""
> PLATFORM_ID="platform:f34"
>Reporter: Rakhi Kumari
>Assignee: Rakhi Kumari
>Priority: Major
>
> {noformat}
> $ gdb ./reconnect_client
> (gdb) run amqp://127.0.0.1 examples 1
> Starting program:
> /home/rkumari/repos/qpid-proton/build/cpp/examples/reconnect_client
> amqp://127.0.0.1 examples 1
> Missing separate debuginfos, use: dnf debuginfo-install
> glibc-2.33-5.fc34.x86_64
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library "/lib64/libthread_db.so.1".
> Retries: 0 Delay: 0 Trying: NO URL@0 SZ: 0
> *Program received signal SIGSEGV, Segmentation fault.*
> 0x77cf1104 in std::basic_ostream >&
> std::operator<< , std::allocator
> >(std::basic_ostream >&,
> std::__cxx11::basic_string, std::allocator
> > const&) () from /lib64/libstdc++.so.6
> (gdb) backtrace
> #0 0x77cf1104 in std::basic_ostream >&
> std::operator<< , std::allocator
> >(std::basic_ostream >&,
> std::__cxx11::basic_string, std::allocator
> > const&) () from /lib64/libstdc++.so.6
> #1 0x77e984b5 in proton::container::impl::reconnect (this=0x43c640,
> pnc=0x43df10) at
> /home/rkumari/repos/qpid-proton/cpp/src/proactor_container_impl.cpp:241
> #2 0x77ead66d in std::__invoke_impl (proton::container::impl::*&)(pn_connection_t*), proton::container::impl*&,
> pn_connection_t*&> (__f=
> @0x446060: (void (proton::container::impl::*)(proton::container::impl *
> const, pn_connection_t *)) 0x77e97ed4
> , __t=@0x446078:
> 0x43c640)
> at /usr/include/c++/11/bits/invoke.h:74
> #3 0x77ead1d6 in std::__invoke (proton::container::impl::*&)(pn_connection_t*), proton::container::impl*&,
> pn_connection_t*&> (__fn=
> @0x446060: (void (proton::container::impl::*)(proton::container::impl *
> const, pn_connection_t *)) 0x77e97ed4
> ) at
> /usr/include/c++/11/bits/invoke.h:96
> #4 0x77eacd73 in std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>::__call 1ul>(std::tuple<>&&, std::_Index_tuple<0ul, 1ul>) (this=0x446060, __args=...)
> at /usr/include/c++/11/functional:420
> #5 0x77eac7a6 in std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>::operator()<, void>() (this=0x446060)
> at /usr/include/c++/11/functional:503
> #6 0x77eaba21 in std::__invoke_impl (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&>(std::__invoke_other, std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&) (__f=...) at
> /usr/include/c++/11/bits/invoke.h:61
> #7 0x77eaa497 in std::__invoke_r (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&>(std::_Bind (proton::container::impl::*(proton::container::impl*,
> pn_connection_t*))(pn_connection_t*)>&) (__fn=...) at
> /usr/include/c++/11/bits/invoke.h:154
> #8 0x77ea8cdf in std::_Function_handler
[GitHub] [qpid-proton] DreamPearl commented on pull request #338: PROTON-2441: [cpp] Fix connection_options failover urls segfault
DreamPearl commented on pull request #338: URL: https://github.com/apache/qpid-proton/pull/338#issuecomment-956023315 @gemmellr @jiridanek Can you please take a look. The cause of segfault was that when we were passing empty vector to connection_options::failoverurls, the current_url was getting set to 0. And on the basis of the value of current_url i.e. 0, it was picking failover_urls instead of reconnect_urls. As it was trying to access failover_urls which was empty, it leads to segfault. Deprecated code was able to handle the empty vector, non-deprecated wasn't. Alternatively, I tried this: https://github.com/apache/qpid-proton/commit/50d8342c4932da698389dd991760c607de7f79f5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
