[jira] [Commented] (DISPATCH-1487) Improve the parsing of message annotations
[ https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461151#comment-17461151 ] ASF GitHub Bot commented on DISPATCH-1487: -- codecov-commenter commented on pull request #1466: URL: https://github.com/apache/qpid-dispatch/pull/1466#issuecomment-996358043 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1466?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1466](https://codecov.io/gh/apache/qpid-dispatch/pull/1466?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d167d87) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/2af1a676b86cfaf0880cfbfc8b72305758f75d75?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2af1a67) will **decrease** coverage by `0.19%`. > The diff coverage is `77.59%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1466 +/- ## == - Coverage 84.76% 84.57% -0.20% == Files 116 117 +1 Lines 2862328904 +281 == + Hits2426224445 +183 - Misses 4361 4459 +98 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/amqp.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FtcXAuYw==) | `100.00% <ø> (ø)` | | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.72% <20.00%> (-0.83%)` | :arrow_down: | | [tests/parse\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvcGFyc2VfdGVzdC5j) | `68.89% <56.47%> (-0.21%)` | :arrow_down: | | [tests/buffer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvYnVmZmVyX3Rlc3QuYw==) | `71.68% <62.65%> (-23.40%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.43% <85.71%> (+0.07%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `85.07% <86.30%> (-2.90%)` | :arrow_down: | | [src/buffer\_field\_api.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2J1ZmZlcl9maWVsZF9hcGkuaA==) | `100.00% <100.00%> (ø)` | | | [src/router\_config.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb25maWcuYw==) | `96.42% <100.00%> (+0.01%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `88.20% <0.00%> (-1.28%)` | :
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1466: DISPATCH-1487: remove parse turbo, refactor parsing to use buffer fields
codecov-commenter commented on pull request #1466: URL: https://github.com/apache/qpid-dispatch/pull/1466#issuecomment-996358043 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1466?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1466](https://codecov.io/gh/apache/qpid-dispatch/pull/1466?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d167d87) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/2af1a676b86cfaf0880cfbfc8b72305758f75d75?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2af1a67) will **decrease** coverage by `0.19%`. > The diff coverage is `77.59%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1466 +/- ## == - Coverage 84.76% 84.57% -0.20% == Files 116 117 +1 Lines 2862328904 +281 == + Hits2426224445 +183 - Misses 4361 4459 +98 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/amqp.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FtcXAuYw==) | `100.00% <ø> (ø)` | | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.72% <20.00%> (-0.83%)` | :arrow_down: | | [tests/parse\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvcGFyc2VfdGVzdC5j) | `68.89% <56.47%> (-0.21%)` | :arrow_down: | | [tests/buffer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvYnVmZmVyX3Rlc3QuYw==) | `71.68% <62.65%> (-23.40%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `87.43% <85.71%> (+0.07%)` | :arrow_up: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3BhcnNlLmM=) | `85.07% <86.30%> (-2.90%)` | :arrow_down: | | [src/buffer\_field\_api.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2J1ZmZlcl9maWVsZF9hcGkuaA==) | `100.00% <100.00%> (ø)` | | | [src/router\_config.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb25maWcuYw==) | `96.42% <100.00%> (+0.01%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `88.20% <0.00%> (-1.28%)` | :arrow_down: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3Jvd
[jira] [Commented] (DISPATCH-1403) Consolidate chained qd_buffer_t field handling code
[ https://issues.apache.org/jira/browse/DISPATCH-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461146#comment-17461146 ] ASF GitHub Bot commented on DISPATCH-1403: -- codecov-commenter commented on pull request #1465: URL: https://github.com/apache/qpid-dispatch/pull/1465#issuecomment-996355314 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1465](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bb4d8e9) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/2af1a676b86cfaf0880cfbfc8b72305758f75d75?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2af1a67) will **decrease** coverage by `0.07%`. > The diff coverage is `76.30%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1465 +/- ## == - Coverage 84.76% 84.69% -0.08% == Files 116 117 +1 Lines 2862328871 +248 == + Hits2426224451 +189 - Misses 4361 4420 +59 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [tests/buffer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvYnVmZmVyX3Rlc3QuYw==) | `71.68% <62.65%> (-23.40%)` | :arrow_down: | | [src/buffer\_field\_api.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2J1ZmZlcl9maWVsZF9hcGkuaA==) | `100.00% <100.00%> (ø)` | | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.09% <0.00%> (-0.95%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `92.97% <0.00%> (-0.37%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.45% <0.00%> (-0.10%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.38% <0.00%> (ø)` | | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.63% <0.00%> (+0.16%)` | :arrow_up: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85.14% <0.00%> (+0.99%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1465: DISPATCH-1403: define a common lightweight buffer field API
codecov-commenter commented on pull request #1465: URL: https://github.com/apache/qpid-dispatch/pull/1465#issuecomment-996355314 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1465](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bb4d8e9) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/2af1a676b86cfaf0880cfbfc8b72305758f75d75?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2af1a67) will **decrease** coverage by `0.07%`. > The diff coverage is `76.30%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1465 +/- ## == - Coverage 84.76% 84.69% -0.08% == Files 116 117 +1 Lines 2862328871 +248 == + Hits2426224451 +189 - Misses 4361 4420 +59 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1465?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [tests/buffer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvYnVmZmVyX3Rlc3QuYw==) | `71.68% <62.65%> (-23.40%)` | :arrow_down: | | [src/buffer\_field\_api.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2J1ZmZlcl9maWVsZF9hcGkuaA==) | `100.00% <100.00%> (ø)` | | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.09% <0.00%> (-0.95%)` | :arrow_down: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `92.97% <0.00%> (-0.37%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.45% <0.00%> (-0.10%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.38% <0.00%> (ø)` | | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.63% <0.00%> (+0.16%)` | :arrow_up: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85.14% <0.00%> (+0.99%)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1465/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `82.84% <0.00%> (+4.14%)` | :arro
[jira] [Commented] (DISPATCH-1487) Improve the parsing of message annotations
[ https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461059#comment-17461059 ] ASF GitHub Bot commented on DISPATCH-1487: -- kgiusti closed pull request #1458: URL: https://github.com/apache/qpid-dispatch/pull/1458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve the parsing of message annotations > -- > > Key: DISPATCH-1487 > URL: https://issues.apache.org/jira/browse/DISPATCH-1487 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > ToDo: Refactor inbound MA parsing on inbound inter-router links to improve > throughput and reduce latency. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1487) Improve the parsing of message annotations
[ https://issues.apache.org/jira/browse/DISPATCH-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461058#comment-17461058 ] ASF GitHub Bot commented on DISPATCH-1487: -- kgiusti commented on pull request #1458: URL: https://github.com/apache/qpid-dispatch/pull/1458#issuecomment-996221031 Nevermind - will re-submit with proper fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve the parsing of message annotations > -- > > Key: DISPATCH-1487 > URL: https://issues.apache.org/jira/browse/DISPATCH-1487 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > ToDo: Refactor inbound MA parsing on inbound inter-router links to improve > throughput and reduce latency. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #1458: DISPATCH-1487: inter-router annotations re-factor
kgiusti closed pull request #1458: URL: https://github.com/apache/qpid-dispatch/pull/1458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #1458: DISPATCH-1487: inter-router annotations re-factor
kgiusti commented on pull request #1458: URL: https://github.com/apache/qpid-dispatch/pull/1458#issuecomment-996221031 Nevermind - will re-submit with proper fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2300.
-
Fix Version/s: 1.19.0
Resolution: Fixed
> system_tests_log_level_update failing when run against latest proton master
> ---
>
> Key: DISPATCH-2300
> URL: https://issues.apache.org/jira/browse/DISPATCH-2300
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.19.0
>
>
> {noformat}
> 67: # Give some time for the MAU to go over the inter-router link
> 67: time.sleep(2)
> 67: logs = qd_manager.get_log()
> 67: mau_found = False
> 67: for log in logs:
> 67: if 'PROTOCOL' in log[0]:
> 67: if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and
> "MAU" in log[2]:
> 67: mau_found = True
> 67: break
> 67:
> 67: > self.assertTrue(mau_found)
> 67: E AssertionError: False is not true
> 67:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_log_level_update.py:288:
> AssertionError
> 67: - generated xml file:
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_log_level_update.xml
> -
> 67: === short test summary info
>
> 67: FAILED
> ::EnableConnectionLevelInterRouterTraceTest::test_inter_router_protocol_trace
> 67: = 1 failed, 7 passed in 12.90s
> =
> 33/38 Test #67: system_tests_log_level_update ...***Failed 13.18
> sec {noformat}
>
> https://github.com/ganeshmurthy/qpid-dispatch/runs/4526076646?check_suite_focus=true#step:27:4255
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461044#comment-17461044
]
ASF subversion and git services commented on DISPATCH-2300:
---
Commit 2af1a676b86cfaf0880cfbfc8b72305758f75d75 in qpid-dispatch's branch
refs/heads/main from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2af1a67 ]
DISPATCH-2300: Fixed test to not look for contents of transfer message. Also a
minor fix to the connection creation code
> system_tests_log_level_update failing when run against latest proton master
> ---
>
> Key: DISPATCH-2300
> URL: https://issues.apache.org/jira/browse/DISPATCH-2300
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 67: # Give some time for the MAU to go over the inter-router link
> 67: time.sleep(2)
> 67: logs = qd_manager.get_log()
> 67: mau_found = False
> 67: for log in logs:
> 67: if 'PROTOCOL' in log[0]:
> 67: if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and
> "MAU" in log[2]:
> 67: mau_found = True
> 67: break
> 67:
> 67: > self.assertTrue(mau_found)
> 67: E AssertionError: False is not true
> 67:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_log_level_update.py:288:
> AssertionError
> 67: - generated xml file:
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_log_level_update.xml
> -
> 67: === short test summary info
>
> 67: FAILED
> ::EnableConnectionLevelInterRouterTraceTest::test_inter_router_protocol_trace
> 67: = 1 failed, 7 passed in 12.90s
> =
> 33/38 Test #67: system_tests_log_level_update ...***Failed 13.18
> sec {noformat}
>
> https://github.com/ganeshmurthy/qpid-dispatch/runs/4526076646?check_suite_focus=true#step:27:4255
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461045#comment-17461045
]
ASF GitHub Bot commented on DISPATCH-2300:
--
asfgit merged pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_log_level_update failing when run against latest proton master
> ---
>
> Key: DISPATCH-2300
> URL: https://issues.apache.org/jira/browse/DISPATCH-2300
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 67: # Give some time for the MAU to go over the inter-router link
> 67: time.sleep(2)
> 67: logs = qd_manager.get_log()
> 67: mau_found = False
> 67: for log in logs:
> 67: if 'PROTOCOL' in log[0]:
> 67: if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and
> "MAU" in log[2]:
> 67: mau_found = True
> 67: break
> 67:
> 67: > self.assertTrue(mau_found)
> 67: E AssertionError: False is not true
> 67:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_log_level_update.py:288:
> AssertionError
> 67: - generated xml file:
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_log_level_update.xml
> -
> 67: === short test summary info
>
> 67: FAILED
> ::EnableConnectionLevelInterRouterTraceTest::test_inter_router_protocol_trace
> 67: = 1 failed, 7 passed in 12.90s
> =
> 33/38 Test #67: system_tests_log_level_update ...***Failed 13.18
> sec {noformat}
>
> https://github.com/ganeshmurthy/qpid-dispatch/runs/4526076646?check_suite_focus=true#step:27:4255
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit merged pull request #1463: DISPATCH-2300: Fixed test to not look for contents of transfer messag…
asfgit merged pull request #1463: URL: https://github.com/apache/qpid-dispatch/pull/1463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461035#comment-17461035
]
ASF GitHub Bot commented on DISPATCH-2300:
--
kgiusti commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770898797
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,72 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
-# Create a receiver and make sure the MAU update is seen on the
inter-router connection log
+inter_router_cid = "[C" + conn_id + "]"
+
+num_transfers = 0
+with open(self.routers[1].logfile_path) as router_log:
+for log_line in router_log:
+log_components = log_line.split(" ")
+if len(log_components) > 2 and 'PROTOCOL' in log_components[3]:
Review comment:
Uh, apparently my comments are in reverse order from above (?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_log_level_update failing when run against latest proton master
> ---
>
> Key: DISPATCH-2300
> URL: https://issues.apache.org/jira/browse/DISPATCH-2300
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 67: # Give some time for the MAU to go over the inter-router link
> 67: time.sleep(2)
> 67: logs = qd_manager.get_log()
> 67: mau_found = False
> 67: for log in logs:
> 67: if 'PROTOCOL' in log[0]:
> 67: if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and
> "MAU" in log[2]:
> 67: mau_found = True
> 67: break
> 67:
> 67: > self.assertTrue(mau_found)
> 67: E AssertionError: False is not true
> 67:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_log_level_update.py:288:
> AssertionError
> 67: - generated xml file:
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_log_level_update.xml
> -
> 67: === short test summary info
>
> 67: FAILED
> ::EnableConnectionLevelInterRouterTraceTest::test_inter_router_protocol_trace
> 67: = 1 failed, 7 passed in 12.90s
> =
> 33/38 Test #67: system_tests_log_level_update ...***Failed 13.18
> sec {noformat}
>
> https://github.com/ganeshmurthy/qpid-dispatch/runs/4526076646?check_suite_focus=true#step:27:4255
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1463: DISPATCH-2300: Fixed test to not look for contents of transfer messag…
kgiusti commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770898797
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,72 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
-# Create a receiver and make sure the MAU update is seen on the
inter-router connection log
+inter_router_cid = "[C" + conn_id + "]"
+
+num_transfers = 0
+with open(self.routers[1].logfile_path) as router_log:
+for log_line in router_log:
+log_components = log_line.split(" ")
+if len(log_components) > 2 and 'PROTOCOL' in log_components[3]:
Review comment:
Uh, apparently my comments are in reverse order from above (?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461034#comment-17461034
]
ASF GitHub Bot commented on DISPATCH-2300:
--
kgiusti commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770897086
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,72 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
-# Create a receiver and make sure the MAU update is seen on the
inter-router connection log
+inter_router_cid = "[C" + conn_id + "]"
+
+num_transfers = 0
+with open(self.routers[1].logfile_path) as router_log:
+for log_line in router_log:
+log_components = log_line.split(" ")
+if len(log_components) > 2 and 'PROTOCOL' in log_components[3]:
+if inter_router_cid in log_components[5] and '@transfer'
in log_components[8]:
+num_transfers += 1
+
+# Create a receiver. This will send an MAU update to the other router
but we should not see any of that
+# in the log since the trace logging for the inter-router connection
has been turned off.
TEST_ADDR_1 = "EnableConnectionLevelProtocolTraceTest1"
conn_2 = BlockingConnection(self.address)
-blocking_receiver_1 = conn_2.create_receiver(address=TEST_ADDR_1)
-
-# Give some time for the MAU to go over the inter-router link
+conn_2.create_receiver(address=TEST_ADDR_1)
+# Give some time for the MAU to go over the inter-router connection.
time.sleep(2)
-logs = qd_manager.get_log()
-mau_found = False
-for log in logs:
-if 'PROTOCOL' in log[0]:
-if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and "MAU"
in log[2]:
-mau_found = True
-break
-
-self.assertTrue(mau_found)
+num_transfers_after_update = 0
+with open(self.routers[1].logfile_path) as router_log:
+for log_line in router_log:
+log_components = log_line.split(" ")
+if len(log_components) > 2 and 'PROTOCOL' in log_components[3]:
+if inter_router_cid in log_components[5] and '@transfer'
in log_components[8]:
+num_transfers_after_update += 1
+
+# Since there will be no transfer frames printed in the log, there
should be no more new transfers in the
+# log file.
+self.assertEqual(num_transfers_after_update, num_transfers)
-# Turn off trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "no"}, identity=conn_id)
+# Turn on trace logging for the inter-router connection
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "yes"}, identity=conn_id)
# Create a receiver and make sure the MAU update is NOT seen on the
inter-router connection log
TEST_ADDR_2 = "EnableConnectionLevelProtocolTraceTest2"
conn_1 = BlockingConnection(self.address)
-blocking_receiver_2 = conn_1.create_receiver(address=TEST_ADDR_2)
+conn_1.create_receiver(address=TEST_ADDR_2)
-time.sleep(1)
+#Give time for the MAU to be generated.
+time.sleep(2)
-logs = qd_manager.get_log()
-mau_found = False
-for log in logs:
-if 'PROTOCOL' in log[0]:
-if "@transfer" in log[2] and TEST_ADDR_2 in log[2] and "MAU"
in log[2]:
-mau_found = True
-break
+num_tra
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1463: DISPATCH-2300: Fixed test to not look for contents of transfer messag…
kgiusti commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770897086
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,72 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
-# Create a receiver and make sure the MAU update is seen on the
inter-router connection log
+inter_router_cid = "[C" + conn_id + "]"
+
+num_transfers = 0
+with open(self.routers[1].logfile_path) as router_log:
+for log_line in router_log:
+log_components = log_line.split(" ")
+if len(log_components) > 2 and 'PROTOCOL' in log_components[3]:
+if inter_router_cid in log_components[5] and '@transfer'
in log_components[8]:
+num_transfers += 1
+
+# Create a receiver. This will send an MAU update to the other router
but we should not see any of that
+# in the log since the trace logging for the inter-router connection
has been turned off.
TEST_ADDR_1 = "EnableConnectionLevelProtocolTraceTest1"
conn_2 = BlockingConnection(self.address)
-blocking_receiver_1 = conn_2.create_receiver(address=TEST_ADDR_1)
-
-# Give some time for the MAU to go over the inter-router link
+conn_2.create_receiver(address=TEST_ADDR_1)
+# Give some time for the MAU to go over the inter-router connection.
time.sleep(2)
-logs = qd_manager.get_log()
-mau_found = False
-for log in logs:
-if 'PROTOCOL' in log[0]:
-if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and "MAU"
in log[2]:
-mau_found = True
-break
-
-self.assertTrue(mau_found)
+num_transfers_after_update = 0
+with open(self.routers[1].logfile_path) as router_log:
+for log_line in router_log:
+log_components = log_line.split(" ")
+if len(log_components) > 2 and 'PROTOCOL' in log_components[3]:
+if inter_router_cid in log_components[5] and '@transfer'
in log_components[8]:
+num_transfers_after_update += 1
+
+# Since there will be no transfer frames printed in the log, there
should be no more new transfers in the
+# log file.
+self.assertEqual(num_transfers_after_update, num_transfers)
-# Turn off trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "no"}, identity=conn_id)
+# Turn on trace logging for the inter-router connection
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "yes"}, identity=conn_id)
# Create a receiver and make sure the MAU update is NOT seen on the
inter-router connection log
TEST_ADDR_2 = "EnableConnectionLevelProtocolTraceTest2"
conn_1 = BlockingConnection(self.address)
-blocking_receiver_2 = conn_1.create_receiver(address=TEST_ADDR_2)
+conn_1.create_receiver(address=TEST_ADDR_2)
-time.sleep(1)
+#Give time for the MAU to be generated.
+time.sleep(2)
-logs = qd_manager.get_log()
-mau_found = False
-for log in logs:
-if 'PROTOCOL' in log[0]:
-if "@transfer" in log[2] and TEST_ADDR_2 in log[2] and "MAU"
in log[2]:
-mau_found = True
-break
+num_transfers_after_update = 0
+with open(self.routers[1].logfile_path) as router_log:
+for log_line in router_log:
+log_components = log_line.split(" ")
+if len(log_components) > 2 and 'PROTOCOL' in log_components[3]:
[jira] [Commented] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461014#comment-17461014
]
ASF GitHub Bot commented on DISPATCH-2300:
--
ganeshmurthy commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770870878
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,69 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
Review comment:
Unfortunately there is not. We could query the connection again to find
out but even if that has the correct value of enableProtocolTrace, it does not
guarantee that the action actually has executed. See here -
https://github.com/apache/qpid-dispatch/blob/main/src/router_core/agent_connection.c#L644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_log_level_update failing when run against latest proton master
> ---
>
> Key: DISPATCH-2300
> URL: https://issues.apache.org/jira/browse/DISPATCH-2300
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 67: # Give some time for the MAU to go over the inter-router link
> 67: time.sleep(2)
> 67: logs = qd_manager.get_log()
> 67: mau_found = False
> 67: for log in logs:
> 67: if 'PROTOCOL' in log[0]:
> 67: if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and
> "MAU" in log[2]:
> 67: mau_found = True
> 67: break
> 67:
> 67: > self.assertTrue(mau_found)
> 67: E AssertionError: False is not true
> 67:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_log_level_update.py:288:
> AssertionError
> 67: - generated xml file:
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_log_level_update.xml
> -
> 67: === short test summary info
>
> 67: FAILED
> ::EnableConnectionLevelInterRouterTraceTest::test_inter_router_protocol_trace
> 67: = 1 failed, 7 passed in 12.90s
> =
> 33/38 Test #67: system_tests_log_level_update ...***Failed 13.18
> sec {noformat}
>
> https://github.com/ganeshmurthy/qpid-dispatch/runs/4526076646?check_suite_focus=true#step:27:4255
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1463: DISPATCH-2300: Fixed test to not look for contents of transfer messag…
ganeshmurthy commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770870878
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,69 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
Review comment:
Unfortunately there is not. We could query the connection again to find
out but even if that has the correct value of enableProtocolTrace, it does not
guarantee that the action actually has executed. See here -
https://github.com/apache/qpid-dispatch/blob/main/src/router_core/agent_connection.c#L644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460993#comment-17460993
]
ASF GitHub Bot commented on DISPATCH-2300:
--
jiridanek commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770859406
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,69 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
-# Create a receiver and make sure the MAU update is seen on the
inter-router connection log
+inter_router_cid = "[C" + conn_id + "]"
+
+num_transfers = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
+for log_line in log_lines:
+if 'PROTOCOL' in log_line and inter_router_cid in log_line and
'@transfer' in log_line:
+num_transfers += 1
+
+# Create a receiver. This will send an MAU update to the other router
but we should not see any of that
+# in the log since the trace logging for the inter-router connection
has been turned off.
TEST_ADDR_1 = "EnableConnectionLevelProtocolTraceTest1"
conn_2 = BlockingConnection(self.address)
-blocking_receiver_1 = conn_2.create_receiver(address=TEST_ADDR_1)
-
-# Give some time for the MAU to go over the inter-router link
+conn_2.create_receiver(address=TEST_ADDR_1)
+# Give some time for the MAU to go over the inter-router connection.
time.sleep(2)
-logs = qd_manager.get_log()
-mau_found = False
-for log in logs:
-if 'PROTOCOL' in log[0]:
-if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and "MAU"
in log[2]:
-mau_found = True
-break
+num_transfers_after_update = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
+for log_line in log_lines:
+if 'PROTOCOL' in log_line and inter_router_cid in log_line and
'@transfer' in log_line:
+num_transfers_after_update += 1
-self.assertTrue(mau_found)
+# Since there will be no transfer frames printed in the log, there
should be no more new transfers in the
+# log file.
+self.assertEqual(num_transfers_after_update, num_transfers)
-# Turn off trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "no"}, identity=conn_id)
+# Turn on trace logging for the inter-router connection
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "yes"}, identity=conn_id)
# Create a receiver and make sure the MAU update is NOT seen on the
inter-router connection log
TEST_ADDR_2 = "EnableConnectionLevelProtocolTraceTest2"
conn_1 = BlockingConnection(self.address)
-blocking_receiver_2 = conn_1.create_receiver(address=TEST_ADDR_2)
+conn_1.create_receiver(address=TEST_ADDR_2)
-time.sleep(1)
+#Give time for the MAU to be generated.
+time.sleep(2)
-logs = qd_manager.get_log()
-mau_found = False
-for log in logs:
-if 'PROTOCOL' in log[0]:
-if "@transfer" in log[2] and TEST_ADDR_2 in log[2] and "MAU"
in log[2]:
-mau_found = True
-break
+num_transfers_after_update = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
Review comment:
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1463: DISPATCH-2300: Fixed test to not look for contents of transfer messag…
jiridanek commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770859406
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,69 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
-# Create a receiver and make sure the MAU update is seen on the
inter-router connection log
+inter_router_cid = "[C" + conn_id + "]"
+
+num_transfers = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
+for log_line in log_lines:
+if 'PROTOCOL' in log_line and inter_router_cid in log_line and
'@transfer' in log_line:
+num_transfers += 1
+
+# Create a receiver. This will send an MAU update to the other router
but we should not see any of that
+# in the log since the trace logging for the inter-router connection
has been turned off.
TEST_ADDR_1 = "EnableConnectionLevelProtocolTraceTest1"
conn_2 = BlockingConnection(self.address)
-blocking_receiver_1 = conn_2.create_receiver(address=TEST_ADDR_1)
-
-# Give some time for the MAU to go over the inter-router link
+conn_2.create_receiver(address=TEST_ADDR_1)
+# Give some time for the MAU to go over the inter-router connection.
time.sleep(2)
-logs = qd_manager.get_log()
-mau_found = False
-for log in logs:
-if 'PROTOCOL' in log[0]:
-if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and "MAU"
in log[2]:
-mau_found = True
-break
+num_transfers_after_update = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
+for log_line in log_lines:
+if 'PROTOCOL' in log_line and inter_router_cid in log_line and
'@transfer' in log_line:
+num_transfers_after_update += 1
-self.assertTrue(mau_found)
+# Since there will be no transfer frames printed in the log, there
should be no more new transfers in the
+# log file.
+self.assertEqual(num_transfers_after_update, num_transfers)
-# Turn off trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "no"}, identity=conn_id)
+# Turn on trace logging for the inter-router connection
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "yes"}, identity=conn_id)
# Create a receiver and make sure the MAU update is NOT seen on the
inter-router connection log
TEST_ADDR_2 = "EnableConnectionLevelProtocolTraceTest2"
conn_1 = BlockingConnection(self.address)
-blocking_receiver_2 = conn_1.create_receiver(address=TEST_ADDR_2)
+conn_1.create_receiver(address=TEST_ADDR_2)
-time.sleep(1)
+#Give time for the MAU to be generated.
+time.sleep(2)
-logs = qd_manager.get_log()
-mau_found = False
-for log in logs:
-if 'PROTOCOL' in log[0]:
-if "@transfer" in log[2] and TEST_ADDR_2 in log[2] and "MAU"
in log[2]:
-mau_found = True
-break
+num_transfers_after_update = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
Review comment:
and ditto here, if you decide to try the iterator-over-lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: d
[jira] [Commented] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460991#comment-17460991
]
ASF GitHub Bot commented on DISPATCH-2300:
--
jiridanek commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770857939
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,69 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
-# Create a receiver and make sure the MAU update is seen on the
inter-router connection log
+inter_router_cid = "[C" + conn_id + "]"
+
+num_transfers = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
+for log_line in log_lines:
+if 'PROTOCOL' in log_line and inter_router_cid in log_line and
'@transfer' in log_line:
+num_transfers += 1
+
+# Create a receiver. This will send an MAU update to the other router
but we should not see any of that
+# in the log since the trace logging for the inter-router connection
has been turned off.
TEST_ADDR_1 = "EnableConnectionLevelProtocolTraceTest1"
conn_2 = BlockingConnection(self.address)
-blocking_receiver_1 = conn_2.create_receiver(address=TEST_ADDR_1)
-
-# Give some time for the MAU to go over the inter-router link
+conn_2.create_receiver(address=TEST_ADDR_1)
+# Give some time for the MAU to go over the inter-router connection.
time.sleep(2)
-logs = qd_manager.get_log()
-mau_found = False
-for log in logs:
-if 'PROTOCOL' in log[0]:
-if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and "MAU"
in log[2]:
-mau_found = True
-break
+num_transfers_after_update = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
Review comment:
same as before, this helper variable is not necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_log_level_update failing when run against latest proton master
> ---
>
> Key: DISPATCH-2300
> URL: https://issues.apache.org/jira/browse/DISPATCH-2300
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 67: # Give some time for the MAU to go over the inter-router link
> 67: time.sleep(2)
> 67: logs = qd_manager.get_log()
> 67: mau_found = False
> 67: for log in logs:
> 67: if 'PROTOCOL' in log[0]:
> 67: if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and
> "MAU" in log[2]:
> 67: mau_found = True
> 67: break
> 67:
> 67: > self.assertTrue(mau_found)
> 67: E AssertionError: False is not true
> 67:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_log_level_update.py:288:
> AssertionError
> 67: - generated xml file:
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_log_level_update.xml
> -
> 67: === short test s
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1463: DISPATCH-2300: Fixed test to not look for contents of transfer messag…
jiridanek commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770857939
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,69 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
-# Create a receiver and make sure the MAU update is seen on the
inter-router connection log
+inter_router_cid = "[C" + conn_id + "]"
+
+num_transfers = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
+for log_line in log_lines:
+if 'PROTOCOL' in log_line and inter_router_cid in log_line and
'@transfer' in log_line:
+num_transfers += 1
+
+# Create a receiver. This will send an MAU update to the other router
but we should not see any of that
+# in the log since the trace logging for the inter-router connection
has been turned off.
TEST_ADDR_1 = "EnableConnectionLevelProtocolTraceTest1"
conn_2 = BlockingConnection(self.address)
-blocking_receiver_1 = conn_2.create_receiver(address=TEST_ADDR_1)
-
-# Give some time for the MAU to go over the inter-router link
+conn_2.create_receiver(address=TEST_ADDR_1)
+# Give some time for the MAU to go over the inter-router connection.
time.sleep(2)
-logs = qd_manager.get_log()
-mau_found = False
-for log in logs:
-if 'PROTOCOL' in log[0]:
-if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and "MAU"
in log[2]:
-mau_found = True
-break
+num_transfers_after_update = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
Review comment:
same as before, this helper variable is not necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460990#comment-17460990
]
ASF GitHub Bot commented on DISPATCH-2300:
--
jiridanek commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770857275
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,69 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
-# Create a receiver and make sure the MAU update is seen on the
inter-router connection log
+inter_router_cid = "[C" + conn_id + "]"
+
+num_transfers = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
Review comment:
```suggestion
for log_line in router_log:
```
Actually, this is what you want. Open file is an iterator over its lines, in
Python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_log_level_update failing when run against latest proton master
> ---
>
> Key: DISPATCH-2300
> URL: https://issues.apache.org/jira/browse/DISPATCH-2300
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 67: # Give some time for the MAU to go over the inter-router link
> 67: time.sleep(2)
> 67: logs = qd_manager.get_log()
> 67: mau_found = False
> 67: for log in logs:
> 67: if 'PROTOCOL' in log[0]:
> 67: if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and
> "MAU" in log[2]:
> 67: mau_found = True
> 67: break
> 67:
> 67: > self.assertTrue(mau_found)
> 67: E AssertionError: False is not true
> 67:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_log_level_update.py:288:
> AssertionError
> 67: - generated xml file:
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_log_level_update.xml
> -
> 67: === short test summary info
>
> 67: FAILED
> ::EnableConnectionLevelInterRouterTraceTest::test_inter_router_protocol_trace
> 67: = 1 failed, 7 passed in 12.90s
> =
> 33/38 Test #67: system_tests_log_level_update ...***Failed 13.18
> sec {noformat}
>
> https://github.com/ganeshmurthy/qpid-dispatch/runs/4526076646?check_suite_focus=true#step:27:4255
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1463: DISPATCH-2300: Fixed test to not look for contents of transfer messag…
jiridanek commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770857275
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,69 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
-# Create a receiver and make sure the MAU update is seen on the
inter-router connection log
+inter_router_cid = "[C" + conn_id + "]"
+
+num_transfers = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
Review comment:
```suggestion
for log_line in router_log:
```
Actually, this is what you want. Open file is an iterator over its lines, in
Python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1463: DISPATCH-2300: Fixed test to not look for contents of transfer messag…
jiridanek commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770856177
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,69 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
-# Create a receiver and make sure the MAU update is seen on the
inter-router connection log
+inter_router_cid = "[C" + conn_id + "]"
+
+num_transfers = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
Review comment:
```suggestion
log_lines = router_log.readlines()
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460987#comment-17460987
]
ASF GitHub Bot commented on DISPATCH-2300:
--
jiridanek commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770856177
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,69 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
-# Create a receiver and make sure the MAU update is seen on the
inter-router connection log
+inter_router_cid = "[C" + conn_id + "]"
+
+num_transfers = 0
+with open(self.routers[1].logfile_path) as router_log:
+log_lines = router_log.read().split("\n")
Review comment:
```suggestion
log_lines = router_log.readlines()
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_log_level_update failing when run against latest proton master
> ---
>
> Key: DISPATCH-2300
> URL: https://issues.apache.org/jira/browse/DISPATCH-2300
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 67: # Give some time for the MAU to go over the inter-router link
> 67: time.sleep(2)
> 67: logs = qd_manager.get_log()
> 67: mau_found = False
> 67: for log in logs:
> 67: if 'PROTOCOL' in log[0]:
> 67: if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and
> "MAU" in log[2]:
> 67: mau_found = True
> 67: break
> 67:
> 67: > self.assertTrue(mau_found)
> 67: E AssertionError: False is not true
> 67:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_log_level_update.py:288:
> AssertionError
> 67: - generated xml file:
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_log_level_update.xml
> -
> 67: === short test summary info
>
> 67: FAILED
> ::EnableConnectionLevelInterRouterTraceTest::test_inter_router_protocol_trace
> 67: = 1 failed, 7 passed in 12.90s
> =
> 33/38 Test #67: system_tests_log_level_update ...***Failed 13.18
> sec {noformat}
>
> https://github.com/ganeshmurthy/qpid-dispatch/runs/4526076646?check_suite_focus=true#step:27:4255
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460986#comment-17460986
]
ASF GitHub Bot commented on DISPATCH-2300:
--
jiridanek commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770855217
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,69 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
Review comment:
Is there a way to either wait for completion of the async operation or
possibly repeatedly query for the current state until the change happens? Just
asking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_log_level_update failing when run against latest proton master
> ---
>
> Key: DISPATCH-2300
> URL: https://issues.apache.org/jira/browse/DISPATCH-2300
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 67: # Give some time for the MAU to go over the inter-router link
> 67: time.sleep(2)
> 67: logs = qd_manager.get_log()
> 67: mau_found = False
> 67: for log in logs:
> 67: if 'PROTOCOL' in log[0]:
> 67: if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and
> "MAU" in log[2]:
> 67: mau_found = True
> 67: break
> 67:
> 67: > self.assertTrue(mau_found)
> 67: E AssertionError: False is not true
> 67:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_log_level_update.py:288:
> AssertionError
> 67: - generated xml file:
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_log_level_update.xml
> -
> 67: === short test summary info
>
> 67: FAILED
> ::EnableConnectionLevelInterRouterTraceTest::test_inter_router_protocol_trace
> 67: = 1 failed, 7 passed in 12.90s
> =
> 33/38 Test #67: system_tests_log_level_update ...***Failed 13.18
> sec {noformat}
>
> https://github.com/ganeshmurthy/qpid-dispatch/runs/4526076646?check_suite_focus=true#step:27:4255
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1463: DISPATCH-2300: Fixed test to not look for contents of transfer messag…
jiridanek commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770855217
##
File path: tests/system_tests_log_level_update.py
##
@@ -256,56 +256,69 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
-# Turn off trace logging on all connections for Router B.
-qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+# The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
-# Turn on trace logging for the inter-router connection
-qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+# Turn off trace logging for the inter-router connection. This update
command is run async by the router
+# so we need to sleep a bit before the operation is actually completed.
+qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+time.sleep(1)
Review comment:
Is there a way to either wait for completion of the async operation or
possibly repeatedly query for the current state until the change happens? Just
asking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[ https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460979#comment-17460979 ] ASF GitHub Bot commented on DISPATCH-2300: -- codecov-commenter commented on pull request #1463: URL: https://github.com/apache/qpid-dispatch/pull/1463#issuecomment-996102406 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1463](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c719631) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/c6d3d96ee0beb853385bb6858bb2d776e1e5f4a8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6d3d96) will **decrease** coverage by `0.05%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1463 +/- ## == - Coverage 84.82% 84.77% -0.06% == Files 116 116 Lines 2862028623 +3 == - Hits2427724265 -12 - Misses 4343 4358 +15 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.18% <100.00%> (-0.93%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `76.87% <0.00%> (-0.53%)` | :arrow_down: | | [src/hash.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2hhc2guYw==) | `79.53% <0.00%> (-0.47%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.55% <0.00%> (-0.10%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `95.03% <0.00%> (+0.43%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6d3d96...c719631](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1463: DISPATCH-2300: Fixed test to not look for contents of transfer messag…
codecov-commenter commented on pull request #1463: URL: https://github.com/apache/qpid-dispatch/pull/1463#issuecomment-996102406 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1463](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c719631) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/c6d3d96ee0beb853385bb6858bb2d776e1e5f4a8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6d3d96) will **decrease** coverage by `0.05%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1463 +/- ## == - Coverage 84.82% 84.77% -0.06% == Files 116 116 Lines 2862028623 +3 == - Hits2427724265 -12 - Misses 4343 4358 +15 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.18% <100.00%> (-0.93%)` | :arrow_down: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `76.87% <0.00%> (-0.53%)` | :arrow_down: | | [src/hash.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2hhc2guYw==) | `79.53% <0.00%> (-0.47%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.55% <0.00%> (-0.10%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `95.03% <0.00%> (+0.43%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6d3d96...c719631](https://codecov.io/gh/apache/qpid-dispatch/pull/1463?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo
[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties
[
https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460976#comment-17460976
]
ASF GitHub Bot commented on PROTON-2308:
jiridanek commented on a change in pull request #346:
URL: https://github.com/apache/qpid-proton/pull/346#discussion_r770837283
##
File path: cpp/src/link_test.cpp
##
@@ -23,9 +23,114 @@
#include
#include
#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
#include
+#include
+#include
+#include
+#include
+
+namespace {
+std::mutex m;
+std::condition_variable cv;
+bool listener_ready = false;
+int listener_port;
+} // namespace
+
+class test_recv : public proton::messaging_handler {
+ private:
+class listener_ready_handler : public proton::listen_handler {
+void on_open(proton::listener &l) override {
+{
+std::lock_guard lk(m);
+listener_port = l.port();
+listener_ready = true;
+}
+cv.notify_one();
+}
+};
+
+std::string url;
+proton::listener listener;
+listener_ready_handler listen_handler;
+
+ public:
+test_recv(const std::string &s) : url(s) {}
+
+void on_container_start(proton::container &c) override {
+listener = c.listen(url, listen_handler);
+}
+
+void on_message(proton::delivery &d, proton::message &msg) override {
+proton::symbol sym = "symbol";
+proton::value val = "value";
+std::map props =
d.receiver().target().dynamic_node_properties();
+
+ASSERT(!props.empty());
+for(auto it=props.begin(); it!=props.end(); it++) {
+ASSERT_EQUAL(sym, it->first);
+ASSERT_EQUAL(val, it->second);
+}
+d.receiver().close();
+d.connection().close();
+listener.stop();
+}
+};
+
+class test_send : public proton::messaging_handler {
+ private:
+std::string url;
+proton::sender sender;
+
+ public:
+test_send(const std::string &s) : url(s) {}
+
+void on_container_start(proton::container &c) override {
+proton::target_options opts;
+std::map m({{proton::symbol("symbol"),
proton::value("value")}});
+opts.dynamic_node_properties(m);
+sender = c.open_sender(url, proton::sender_options().target(opts));
+}
+
+void on_sendable(proton::sender &s) override {
+proton::message msg;
+msg.body("message");
+proton::tracker t = s.send(msg);
+s.connection().close();
+}
+};
+
+int test_dynamic_node_properties() {
+
+std::string recv_address("127.0.0.1:0/test");
+test_recv recv(recv_address);
+proton::container c(recv);
+std::thread thread_recv([&c]() -> void { c.run(); });
+
+// wait until listener is ready
+std::unique_lock lk(m);
+cv.wait(lk, [] { return listener_ready; });
+
+std::string send_address =
+"127.0.0.1:" + std::to_string(listener_port) + "/test";
+test_send send(send_address);
+proton::container(send).run();
+thread_recv.join();
+
+return 0;
Review comment:
there is a lot of tests that have this basic structure, but differ in
details (depending on what function of API is currently being tested). I am
wondering if they could be somehow refactored. But that is not here nor there
for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cpp] Add support for setting Dynamic Node Properties
> -
>
> Key: PROTON-2308
> URL: https://issues.apache.org/jira/browse/PROTON-2308
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
>Affects Versions: proton-c-0.33.0
>Reporter: James Henry
>Assignee: Rakhi Kumari
>Priority: Major
> Labels: api-addition
>
> Requesting support for setting the dynamic node properties be added to the
> source and target options.
> This would allow the setting of termini node properties for senders and
> receivers.
> Similar to the following request made for Python here:
> https://issues.apache.org/jira/browse/PROTON-816
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties
jiridanek commented on a change in pull request #346:
URL: https://github.com/apache/qpid-proton/pull/346#discussion_r770837283
##
File path: cpp/src/link_test.cpp
##
@@ -23,9 +23,114 @@
#include
#include
#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
#include
+#include
+#include
+#include
+#include
+
+namespace {
+std::mutex m;
+std::condition_variable cv;
+bool listener_ready = false;
+int listener_port;
+} // namespace
+
+class test_recv : public proton::messaging_handler {
+ private:
+class listener_ready_handler : public proton::listen_handler {
+void on_open(proton::listener &l) override {
+{
+std::lock_guard lk(m);
+listener_port = l.port();
+listener_ready = true;
+}
+cv.notify_one();
+}
+};
+
+std::string url;
+proton::listener listener;
+listener_ready_handler listen_handler;
+
+ public:
+test_recv(const std::string &s) : url(s) {}
+
+void on_container_start(proton::container &c) override {
+listener = c.listen(url, listen_handler);
+}
+
+void on_message(proton::delivery &d, proton::message &msg) override {
+proton::symbol sym = "symbol";
+proton::value val = "value";
+std::map props =
d.receiver().target().dynamic_node_properties();
+
+ASSERT(!props.empty());
+for(auto it=props.begin(); it!=props.end(); it++) {
+ASSERT_EQUAL(sym, it->first);
+ASSERT_EQUAL(val, it->second);
+}
+d.receiver().close();
+d.connection().close();
+listener.stop();
+}
+};
+
+class test_send : public proton::messaging_handler {
+ private:
+std::string url;
+proton::sender sender;
+
+ public:
+test_send(const std::string &s) : url(s) {}
+
+void on_container_start(proton::container &c) override {
+proton::target_options opts;
+std::map m({{proton::symbol("symbol"),
proton::value("value")}});
+opts.dynamic_node_properties(m);
+sender = c.open_sender(url, proton::sender_options().target(opts));
+}
+
+void on_sendable(proton::sender &s) override {
+proton::message msg;
+msg.body("message");
+proton::tracker t = s.send(msg);
+s.connection().close();
+}
+};
+
+int test_dynamic_node_properties() {
+
+std::string recv_address("127.0.0.1:0/test");
+test_recv recv(recv_address);
+proton::container c(recv);
+std::thread thread_recv([&c]() -> void { c.run(); });
+
+// wait until listener is ready
+std::unique_lock lk(m);
+cv.wait(lk, [] { return listener_ready; });
+
+std::string send_address =
+"127.0.0.1:" + std::to_string(listener_port) + "/test";
+test_send send(send_address);
+proton::container(send).run();
+thread_recv.join();
+
+return 0;
Review comment:
there is a lot of tests that have this basic structure, but differ in
details (depending on what function of API is currently being tested). I am
wondering if they could be somehow refactored. But that is not here nor there
for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties
[
https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460974#comment-17460974
]
ASF GitHub Bot commented on PROTON-2308:
jiridanek commented on a change in pull request #346:
URL: https://github.com/apache/qpid-proton/pull/346#discussion_r770834050
##
File path: cpp/src/link_test.cpp
##
@@ -23,9 +23,114 @@
#include
#include
#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
#include
+#include
+#include
+#include
+#include
+
+namespace {
+std::mutex m;
+std::condition_variable cv;
+bool listener_ready = false;
+int listener_port;
+} // namespace
+
+class test_recv : public proton::messaging_handler {
+ private:
+class listener_ready_handler : public proton::listen_handler {
+void on_open(proton::listener &l) override {
+{
+std::lock_guard lk(m);
+listener_port = l.port();
+listener_ready = true;
+}
+cv.notify_one();
+}
+};
+
+std::string url;
+proton::listener listener;
+listener_ready_handler listen_handler;
+
+ public:
+test_recv(const std::string &s) : url(s) {}
+
+void on_container_start(proton::container &c) override {
+listener = c.listen(url, listen_handler);
+}
+
+void on_message(proton::delivery &d, proton::message &msg) override {
+proton::symbol sym = "symbol";
+proton::value val = "value";
+std::map props =
d.receiver().target().dynamic_node_properties();
+
+ASSERT(!props.empty());
+for(auto it=props.begin(); it!=props.end(); it++) {
+ASSERT_EQUAL(sym, it->first);
+ASSERT_EQUAL(val, it->second);
+}
+d.receiver().close();
+d.connection().close();
+listener.stop();
+}
+};
+
+class test_send : public proton::messaging_handler {
+ private:
+std::string url;
+proton::sender sender;
+
+ public:
+test_send(const std::string &s) : url(s) {}
+
+void on_container_start(proton::container &c) override {
+proton::target_options opts;
+std::map m({{proton::symbol("symbol"),
proton::value("value")}});
+opts.dynamic_node_properties(m);
+sender = c.open_sender(url, proton::sender_options().target(opts));
+}
+
+void on_sendable(proton::sender &s) override {
+proton::message msg;
+msg.body("message");
+proton::tracker t = s.send(msg);
+s.connection().close();
+}
+};
+
+int test_dynamic_node_properties() {
Review comment:
This test sets properties on a sender and then reads them out from the
receiver's target. I am wondering if the other direction is also needed to be
tested: set properties on receiver and read them from sender. Possibly not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cpp] Add support for setting Dynamic Node Properties
> -
>
> Key: PROTON-2308
> URL: https://issues.apache.org/jira/browse/PROTON-2308
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
>Affects Versions: proton-c-0.33.0
>Reporter: James Henry
>Assignee: Rakhi Kumari
>Priority: Major
> Labels: api-addition
>
> Requesting support for setting the dynamic node properties be added to the
> source and target options.
> This would allow the setting of termini node properties for senders and
> receivers.
> Similar to the following request made for Python here:
> https://issues.apache.org/jira/browse/PROTON-816
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties
jiridanek commented on a change in pull request #346:
URL: https://github.com/apache/qpid-proton/pull/346#discussion_r770834050
##
File path: cpp/src/link_test.cpp
##
@@ -23,9 +23,114 @@
#include
#include
#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
#include
+#include
+#include
+#include
+#include
+
+namespace {
+std::mutex m;
+std::condition_variable cv;
+bool listener_ready = false;
+int listener_port;
+} // namespace
+
+class test_recv : public proton::messaging_handler {
+ private:
+class listener_ready_handler : public proton::listen_handler {
+void on_open(proton::listener &l) override {
+{
+std::lock_guard lk(m);
+listener_port = l.port();
+listener_ready = true;
+}
+cv.notify_one();
+}
+};
+
+std::string url;
+proton::listener listener;
+listener_ready_handler listen_handler;
+
+ public:
+test_recv(const std::string &s) : url(s) {}
+
+void on_container_start(proton::container &c) override {
+listener = c.listen(url, listen_handler);
+}
+
+void on_message(proton::delivery &d, proton::message &msg) override {
+proton::symbol sym = "symbol";
+proton::value val = "value";
+std::map props =
d.receiver().target().dynamic_node_properties();
+
+ASSERT(!props.empty());
+for(auto it=props.begin(); it!=props.end(); it++) {
+ASSERT_EQUAL(sym, it->first);
+ASSERT_EQUAL(val, it->second);
+}
+d.receiver().close();
+d.connection().close();
+listener.stop();
+}
+};
+
+class test_send : public proton::messaging_handler {
+ private:
+std::string url;
+proton::sender sender;
+
+ public:
+test_send(const std::string &s) : url(s) {}
+
+void on_container_start(proton::container &c) override {
+proton::target_options opts;
+std::map m({{proton::symbol("symbol"),
proton::value("value")}});
+opts.dynamic_node_properties(m);
+sender = c.open_sender(url, proton::sender_options().target(opts));
+}
+
+void on_sendable(proton::sender &s) override {
+proton::message msg;
+msg.body("message");
+proton::tracker t = s.send(msg);
+s.connection().close();
+}
+};
+
+int test_dynamic_node_properties() {
Review comment:
This test sets properties on a sender and then reads them out from the
receiver's target. I am wondering if the other direction is also needed to be
tested: set properties on receiver and read them from sender. Possibly not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2308) [cpp] Add support for setting Dynamic Node Properties
[
https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460969#comment-17460969
]
ASF GitHub Bot commented on PROTON-2308:
jiridanek commented on a change in pull request #346:
URL: https://github.com/apache/qpid-proton/pull/346#discussion_r770823901
##
File path: cpp/include/proton/terminus.hpp
##
@@ -103,6 +104,10 @@ class terminus {
/// Extension capabilities that are supported/requested
PN_CPP_EXTERN std::vector capabilities() const;
+/// Obtain a reference to the AMQP dynamic node properties for the
+/// terminus as a standard map.
+PN_CPP_EXTERN std::map dynamic_node_properties();
Review comment:
Comment says reference, but function returns a copy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cpp] Add support for setting Dynamic Node Properties
> -
>
> Key: PROTON-2308
> URL: https://issues.apache.org/jira/browse/PROTON-2308
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
>Affects Versions: proton-c-0.33.0
>Reporter: James Henry
>Assignee: Rakhi Kumari
>Priority: Major
> Labels: api-addition
>
> Requesting support for setting the dynamic node properties be added to the
> source and target options.
> This would allow the setting of termini node properties for senders and
> receivers.
> Similar to the following request made for Python here:
> https://issues.apache.org/jira/browse/PROTON-816
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on a change in pull request #346: PROTON-2308: Add support for setting Dynamic Node Properties
jiridanek commented on a change in pull request #346:
URL: https://github.com/apache/qpid-proton/pull/346#discussion_r770823901
##
File path: cpp/include/proton/terminus.hpp
##
@@ -103,6 +104,10 @@ class terminus {
/// Extension capabilities that are supported/requested
PN_CPP_EXTERN std::vector capabilities() const;
+/// Obtain a reference to the AMQP dynamic node properties for the
+/// terminus as a standard map.
+PN_CPP_EXTERN std::map dynamic_node_properties();
Review comment:
Comment says reference, but function returns a copy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2284) Container run exception: 'NoneType' object has no attribute 'properties'
[
https://issues.apache.org/jira/browse/DISPATCH-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460870#comment-17460870
]
Ganesh Murthy commented on DISPATCH-2284:
-
https://app.travis-ci.com/github/apache/qpid-dispatch/jobs/551423517#L7911
> Container run exception: 'NoneType' object has no attribute 'properties'
>
>
> Key: DISPATCH-2284
> URL: https://issues.apache.org/jira/browse/DISPATCH-2284
> Project: Qpid Dispatch
> Issue Type: Test
>Affects Versions: 1.18.0
>Reporter: Jiri Daněk
>Priority: Major
>
> https://github.com/jiridanek/qpid-dispatch/runs/4140877738?check_suite_focus=true#step:9:336
> {noformat}
> 27: 2021-11-09 13:00:36.803865 Waiting for router network to stabilize
> 27: 2021-11-09 13:00:36.806855 Container run exception: 'NoneType' object has
> no attribute 'properties'
> {noformat}
> {noformat}
> 27: > self.assertTrue(test.error is None)
> 27: E AssertionError: False is not true
> 27:
> 27:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_policy_oversize_compound.py:1041:
> AssertionError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #1464: Dispatch 2300 proton 0.36.0
ganeshmurthy commented on pull request #1464: URL: https://github.com/apache/qpid-dispatch/pull/1464#issuecomment-995932963 THIS IS JUST A TEST. DO NOT MERGE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460805#comment-17460805
]
ASF GitHub Bot commented on DISPATCH-2300:
--
ganeshmurthy opened a new pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463
…e. Also a minor fix to the connection creation code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_log_level_update failing when run against latest proton master
> ---
>
> Key: DISPATCH-2300
> URL: https://issues.apache.org/jira/browse/DISPATCH-2300
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 67: # Give some time for the MAU to go over the inter-router link
> 67: time.sleep(2)
> 67: logs = qd_manager.get_log()
> 67: mau_found = False
> 67: for log in logs:
> 67: if 'PROTOCOL' in log[0]:
> 67: if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and
> "MAU" in log[2]:
> 67: mau_found = True
> 67: break
> 67:
> 67: > self.assertTrue(mau_found)
> 67: E AssertionError: False is not true
> 67:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_log_level_update.py:288:
> AssertionError
> 67: - generated xml file:
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_log_level_update.xml
> -
> 67: === short test summary info
>
> 67: FAILED
> ::EnableConnectionLevelInterRouterTraceTest::test_inter_router_protocol_trace
> 67: = 1 failed, 7 passed in 12.90s
> =
> 33/38 Test #67: system_tests_log_level_update ...***Failed 13.18
> sec {noformat}
>
> https://github.com/ganeshmurthy/qpid-dispatch/runs/4526076646?check_suite_focus=true#step:27:4255
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1463: DISPATCH-2300: Fixed test to not look for contents of transfer messag…
ganeshmurthy opened a new pull request #1463: URL: https://github.com/apache/qpid-dispatch/pull/1463 …e. Also a minor fix to the connection creation code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460803#comment-17460803
]
Ganesh Murthy commented on DISPATCH-2300:
-
The test relies on the content of the transfer frames which it should not. The
test needs to be fixed.
> system_tests_log_level_update failing when run against latest proton master
> ---
>
> Key: DISPATCH-2300
> URL: https://issues.apache.org/jira/browse/DISPATCH-2300
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> 67: # Give some time for the MAU to go over the inter-router link
> 67: time.sleep(2)
> 67: logs = qd_manager.get_log()
> 67: mau_found = False
> 67: for log in logs:
> 67: if 'PROTOCOL' in log[0]:
> 67: if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and
> "MAU" in log[2]:
> 67: mau_found = True
> 67: break
> 67:
> 67: > self.assertTrue(mau_found)
> 67: E AssertionError: False is not true
> 67:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_log_level_update.py:288:
> AssertionError
> 67: - generated xml file:
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_log_level_update.xml
> -
> 67: === short test summary info
>
> 67: FAILED
> ::EnableConnectionLevelInterRouterTraceTest::test_inter_router_protocol_trace
> 67: = 1 failed, 7 passed in 12.90s
> =
> 33/38 Test #67: system_tests_log_level_update ...***Failed 13.18
> sec {noformat}
>
> https://github.com/ganeshmurthy/qpid-dispatch/runs/4526076646?check_suite_focus=true#step:27:4255
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2300) system_tests_log_level_update failing when run against latest proton master
Ganesh Murthy created DISPATCH-2300:
---
Summary: system_tests_log_level_update failing when run against
latest proton master
Key: DISPATCH-2300
URL: https://issues.apache.org/jira/browse/DISPATCH-2300
Project: Qpid Dispatch
Issue Type: Test
Components: Tests
Reporter: Ganesh Murthy
Assignee: Ganesh Murthy
{noformat}
67: # Give some time for the MAU to go over the inter-router link
67: time.sleep(2)
67: logs = qd_manager.get_log()
67: mau_found = False
67: for log in logs:
67: if 'PROTOCOL' in log[0]:
67: if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and
"MAU" in log[2]:
67: mau_found = True
67: break
67:
67: > self.assertTrue(mau_found)
67: E AssertionError: False is not true
67:
/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_log_level_update.py:288:
AssertionError
67: - generated xml file:
/__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_log_level_update.xml
-
67: === short test summary info
67: FAILED
::EnableConnectionLevelInterRouterTraceTest::test_inter_router_protocol_trace
67: = 1 failed, 7 passed in 12.90s
=
33/38 Test #67: system_tests_log_level_update ...***Failed 13.18 sec
{noformat}
https://github.com/ganeshmurthy/qpid-dispatch/runs/4526076646?check_suite_focus=true#step:27:4255
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-2299) re-enable system_tests_http delete listeners with libwebsockets >= 4.2
[ https://issues.apache.org/jira/browse/DISPATCH-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk reassigned DISPATCH-2299: Assignee: (was: Ganesh Murthy) > re-enable system_tests_http delete listeners with libwebsockets >= 4.2 > -- > > Key: DISPATCH-2299 > URL: https://issues.apache.org/jira/browse/DISPATCH-2299 > Project: Qpid Dispatch > Issue Type: Test > Components: Container >Affects Versions: 1.18.0 >Reporter: Jiri Daněk >Priority: Major > > The upstream issue in libwebsockets was fixed. The test can be reenabled > # https://libwebsockets.org/pipermail/libwebsockets/2021-January/008852.html > # https://github.com/warmcat/libwebsockets/issues/2327 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2299) re-enable system_tests_http delete listeners with libwebsockets >= 4.2
[ https://issues.apache.org/jira/browse/DISPATCH-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-2299: - Affects Version/s: 1.18.0 > re-enable system_tests_http delete listeners with libwebsockets >= 4.2 > -- > > Key: DISPATCH-2299 > URL: https://issues.apache.org/jira/browse/DISPATCH-2299 > Project: Qpid Dispatch > Issue Type: Test > Components: Container >Affects Versions: 1.18.0 >Reporter: Jiri Daněk >Assignee: Ganesh Murthy >Priority: Major > > The upstream issue in libwebsockets was fixed. The test can be reenabled > # https://libwebsockets.org/pipermail/libwebsockets/2021-January/008852.html > # https://github.com/warmcat/libwebsockets/issues/2327 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2299) re-enable system_tests_http delete listeners with libwebsockets >= 4.2
[
https://issues.apache.org/jira/browse/DISPATCH-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiri Daněk updated DISPATCH-2299:
-
Description:
The upstream issue in libwebsockets was fixed. The test can be reenabled
# https://libwebsockets.org/pipermail/libwebsockets/2021-January/008852.html
# https://github.com/warmcat/libwebsockets/issues/2327
was:
{noformat}
==
FAIL: test_http_listener_delete (system_tests_http.RouterTestHttp)
--
Traceback (most recent call last):
File "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_http.py",
line 157, in test_http_listener_delete
self.assertTrue(ret_val)
AssertionError: None is not true
==
FAIL: test_https_get (system_tests_http.RouterTestHttp)
--
Traceback (most recent call last):
File "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_http.py",
line 332, in test_https_get
self.assertTrue(ret_val)
AssertionError: None is not true
--
Ran 6 tests in 21.374sFAILED (failures=2)
[gmurthy@localhost build]$
{noformat}
> re-enable system_tests_http delete listeners with libwebsockets >= 4.2
> --
>
> Key: DISPATCH-2299
> URL: https://issues.apache.org/jira/browse/DISPATCH-2299
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Container
>Reporter: Jiri Daněk
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.15.0
>
>
> The upstream issue in libwebsockets was fixed. The test can be reenabled
> # https://libwebsockets.org/pipermail/libwebsockets/2021-January/008852.html
> # https://github.com/warmcat/libwebsockets/issues/2327
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-2299) re-enable system_tests_http delete listeners with libwebsockets >= 4.2
[ https://issues.apache.org/jira/browse/DISPATCH-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiri Daněk updated DISPATCH-2299: - Fix Version/s: (was: 1.15.0) > re-enable system_tests_http delete listeners with libwebsockets >= 4.2 > -- > > Key: DISPATCH-2299 > URL: https://issues.apache.org/jira/browse/DISPATCH-2299 > Project: Qpid Dispatch > Issue Type: Test > Components: Container >Reporter: Jiri Daněk >Assignee: Ganesh Murthy >Priority: Major > > The upstream issue in libwebsockets was fixed. The test can be reenabled > # https://libwebsockets.org/pipermail/libwebsockets/2021-January/008852.html > # https://github.com/warmcat/libwebsockets/issues/2327 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2299) re-enable system_tests_http delete listeners with libwebsockets >= 4.2
Jiri Daněk created DISPATCH-2299:
Summary: re-enable system_tests_http delete listeners with
libwebsockets >= 4.2
Key: DISPATCH-2299
URL: https://issues.apache.org/jira/browse/DISPATCH-2299
Project: Qpid Dispatch
Issue Type: Test
Components: Container
Reporter: Jiri Daněk
Assignee: Ganesh Murthy
Fix For: 1.15.0
{noformat}
==
FAIL: test_http_listener_delete (system_tests_http.RouterTestHttp)
--
Traceback (most recent call last):
File "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_http.py",
line 157, in test_http_listener_delete
self.assertTrue(ret_val)
AssertionError: None is not true
==
FAIL: test_https_get (system_tests_http.RouterTestHttp)
--
Traceback (most recent call last):
File "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_http.py",
line 332, in test_https_get
self.assertTrue(ret_val)
AssertionError: None is not true
--
Ran 6 tests in 21.374sFAILED (failures=2)
[gmurthy@localhost build]$
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
