[jira] [Commented] (DISPATCH-2280) Use setuptools instead of deprecated distutils
[
https://issues.apache.org/jira/browse/DISPATCH-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472182#comment-17472182
]
Ganesh Murthy commented on DISPATCH-2280:
-
https://www.python.org/dev/peps/pep-0632/
> Use setuptools instead of deprecated distutils
> --
>
> Key: DISPATCH-2280
> URL: https://issues.apache.org/jira/browse/DISPATCH-2280
> Project: Qpid Dispatch
> Issue Type: Sub-task
>Affects Versions: 1.17.0
>Reporter: Jiri Daněk
>Priority: Major
>
> {noformat}
> C:\Users\Vitorio\CLionProjects\qpid-dispatch\cmake-build-release-visual-studio-clang\python\setup.py:21:
> DeprecationWarning: The distutils package is deprecated and slated for
> removal in Python 3.12. Use setuptools or check PEP 632 for potential
> alternatives
> from distutils.core import setup
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1477: Bump d3 from 3.5.17 to 7.3.0 in /console/react
dependabot[bot] opened a new pull request #1477: URL: https://github.com/apache/qpid-dispatch/pull/1477 Bumps [d3](https://github.com/d3/d3) from 3.5.17 to 7.3.0. Release notes Sourced from https://github.com/d3/d3/releases";>d3's releases. v7.3.0 Add https://github.com/d3/d3-shape/blob/main/README.md#symbolsStroke";>d3.symbolsStroke. Thanks, https://github.com/hemanrobinson";>@hemanrobinson! Add https://github.com/d3/d3-shape/blob/main/README.md#symbolsFill";>d3.symbolsFill, replacing (deprecating) d3.symbols. Add https://github.com/d3/d3-shape/blob/main/README.md#symbolAsterisk";>d3.symbolAsterisk. Add https://github.com/d3/d3-shape/blob/main/README.md#symbolDiamond2";>d3.symbolDiamond2. Add https://github.com/d3/d3-shape/blob/main/README.md#symbolPlus";>d3.symbolPlus. Add https://github.com/d3/d3-shape/blob/main/README.md#symbolSquare2";>d3.symbolSquare2. Add https://github.com/d3/d3-shape/blob/main/README.md#symbolTriangle2";>d3.symbolTriangle2. Add https://github.com/d3/d3-shape/blob/main/README.md#symbolX";>d3.symbolX. Add https://github.com/d3/d3-shape/blob/main/README.md#link";>d3.link. v7.2.1 Fix stratify.path when the top-level directory is only a single character. Fix stratify.path when paths contain multiple trailing slashes. v7.2.0 Add https://github.com/d3/d3-hierarchy/blob/main/README.md#stratify_path";>stratify.path. v7.1.1 d3.rank can now take a comparator in addition to an accessor. d3.rank, d3.sort, d3.bisector, and d3.groupSort now require comparators to have exactly two arguments. v7.1.0 Add https://github.com/d3/d3-array/blob/main/README.md#rank";>d3.rank. v7.0.4 Default the base-10 log tick format to ~s (SI) instead of .0e (exponential). v7.0.3 Don’t mangle InternMap or InternSet in the generated UMD bundle. v7.0.2 Adopt https://github.com/mbostock/internmap";>interning for https://github.com/d3/d3-array/blob/main/README.md#sets";>set operations. https://github-redirect.dependabot.com/d3/d3-array/pull/231";>#231 Fix https://github.com/mbostock/internmap";>InternSet and https://github.com/mbostock/internmap";>InternMap’s delete operation. https://github.com/mbostock/internmap/releases/tag/v2.0.2";>mbostock/internmap@2.0.2 Fix https://github.com/d3/d3-scale/blob/main/README.md#log_ticks";>log.ticks to return exact values for integer bases. https://github-redirect.dependabot.com/d3/d3-scale/pull/253";>#253 Fix https://github.com/d3/d3-scale/blob/main/README.md#log_tickFormat";>log.tickFormat to trim trailing zeroes by default if no precision is specified. https://github-redirect.dependabot.com/d3/d3-scale/pull/254";>#254 v7.0.1 Fix d3.sort, d3.bisector, and related methods to handle undefined order. https://github-redirect.dependabot.com/d3/d3-array/issues/217";>#217 v7.0.0 Breaking changes: Adopt type: module. https://github-redirect.dependabot.com/d3/d3/issues/3501";>#3501 Adopt https://github.com/mbostock/internmap";>InternMap for https://github.com/d3/d3-scale/blob/main/README.md#ordinal-scales";>ordinal scale domains. https://github.com/d3/d3-array/blob/main/README.md#ascending";>d3.ascending and https://github.com/d3/d3-array/blob/main/README.md#descending";>d3.descending no longer consider null comparable. https://github.com/d3/d3-array/blob/main/README.md#bin";>d3.bin now ignores nulls. Convert array-likes (e.g., live NodeList) to arrays in https://github.com/d3/d3-selection/blob/main/README.md#selectAll";>d3.selectAll and https://github.com/d3/d3-selection/blob/main/README.md#selection_selectAll";>selection.selectAll. ... (truncated) Changelog Sourced from https://github.com/d3/d3/blob/main/CHANGES.md";>d3's changelog. Changes in D3 7.0 https://github.com/d3/d3/releases/tag/v7.0.0";>Released June 11, 2021. This document covers only major changes. For minor and patch changes, please see the https://github.com/d3/d3/releases";>release notes. D3 now ships as pure ES modules and requires Node.js 12 or higher. For more, please read https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c";>Sindre Sorhus’s FAQ. https://github.com/d3/d3-array/blob/main/README.md#bin";>d3.bin now ignores nulls. https://github.com/d3/d3-array/blob/main/README.md#ascending";>d3.ascending and https://github.com/d3/d3-array/blob/main/README.md#descending";>d3.descending no longer consider null comparable. https://github.com/d3/d3-scale/blob/main/README.md#ordinal-scales";>Ordinal scales now use https://github.com/mbostock/internmap";>InternMap for domains; domain values are now uniqued by coercing to a primitive value via object.valueOf instead of coercing to a string via object.toString. Array-likes (e.g., a live NodeList such as element.childNodes) are converted to arrays in https://github.com/d3/d
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1456: Bump d3 from 3.5.17 to 7.2.1 in /console/react
dependabot[bot] closed pull request #1456: URL: https://github.com/apache/qpid-dispatch/pull/1456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1456: Bump d3 from 3.5.17 to 7.2.1 in /console/react
dependabot[bot] commented on pull request #1456: URL: https://github.com/apache/qpid-dispatch/pull/1456#issuecomment-1009133867 Superseded by #1477. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2266) system_tests_edge_router stalls on Travis CI
[
https://issues.apache.org/jira/browse/DISPATCH-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2266.
-
Fix Version/s: 1.19.0
Resolution: Cannot Reproduce
> system_tests_edge_router stalls on Travis CI
>
>
> Key: DISPATCH-2266
> URL: https://issues.apache.org/jira/browse/DISPATCH-2266
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.17.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.19.0
>
>
> The system_tests_edge_router stalls on Travis CI intermittently
> {noformat}
> 55: test_50_link_topology (system_tests_edge_router.LinkRouteProxyTest) ... ok
> No output has been received in the last 10m0s, this potentially indicates a
> stalled build or something wrong with the build itself.
> Check the details on how to adjust your build configuration on:
> https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
> The build has been terminated
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2266) system_tests_edge_router stalls on Travis CI
[
https://issues.apache.org/jira/browse/DISPATCH-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472141#comment-17472141
]
Ganesh Murthy commented on DISPATCH-2266:
-
I have not seen this issue show up after we added a bunch of debug statements
to further understand the cause of the test stall. I am going to mark this as
Cannot Reproduce. We will reopen this if necessary.
> system_tests_edge_router stalls on Travis CI
>
>
> Key: DISPATCH-2266
> URL: https://issues.apache.org/jira/browse/DISPATCH-2266
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.17.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> The system_tests_edge_router stalls on Travis CI intermittently
> {noformat}
> 55: test_50_link_topology (system_tests_edge_router.LinkRouteProxyTest) ... ok
> No output has been received in the last 10m0s, this potentially indicates a
> stalled build or something wrong with the build itself.
> Check the details on how to adjust your build configuration on:
> https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
> The build has been terminated
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2305) policy code overrides configured connection settings by default
[
https://issues.apache.org/jira/browse/DISPATCH-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472107#comment-17472107
]
ASF GitHub Bot commented on DISPATCH-2305:
--
ganeshmurthy commented on a change in pull request #1475:
URL: https://github.com/apache/qpid-dispatch/pull/1475#discussion_r781301201
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -2358,21 +2358,18 @@
"maxFrameSize": {
"type": "integer",
"description": "The largest frame, in bytes, that may be
sent on this connection. Non-zero policy values overwrite values specified for
a listener object (AMQP Open, max-frame-size).",
-"default": 16384,
Review comment:
Good point. I did notice that maxSessionWindow is defaulted to 1638400
in vhostUserGroupSettings and is not "directly" specified anywhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> policy code overrides configured connection settings by default
> ---
>
> Key: DISPATCH-2305
> URL: https://issues.apache.org/jira/browse/DISPATCH-2305
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.18.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>
> The following connection/settings attributes may be configured via
> management/configuration file:
> * maxFrameSize
> * maxSessions
> * maxSessionFrames (session window).
> These attributes may also be configured via policy. The policy configuration
> takes precedence.
> If a policy is configured but does *not specify* override values for any of
> the above attributes, one would expect any existing configured values would
> take effect.
> However this is not the case. If you set values for the above attributes in
> the router config file, and you define a matching policy that does not
> override these values, the policy will overwrite your configured values with
> what policy thinks is the default value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1475: DISPATCH-2305: prevent policy defaults overriding configuration
ganeshmurthy commented on a change in pull request #1475:
URL: https://github.com/apache/qpid-dispatch/pull/1475#discussion_r781301201
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -2358,21 +2358,18 @@
"maxFrameSize": {
"type": "integer",
"description": "The largest frame, in bytes, that may be
sent on this connection. Non-zero policy values overwrite values specified for
a listener object (AMQP Open, max-frame-size).",
-"default": 16384,
Review comment:
Good point. I did notice that maxSessionWindow is defaulted to 1638400
in vhostUserGroupSettings and is not "directly" specified anywhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2305) policy code overrides configured connection settings by default
[
https://issues.apache.org/jira/browse/DISPATCH-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472100#comment-17472100
]
ASF GitHub Bot commented on DISPATCH-2305:
--
kgiusti commented on a change in pull request #1475:
URL: https://github.com/apache/qpid-dispatch/pull/1475#discussion_r781286944
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -2358,21 +2358,18 @@
"maxFrameSize": {
"type": "integer",
"description": "The largest frame, in bytes, that may be
sent on this connection. Non-zero policy values overwrite values specified for
a listener object (AMQP Open, max-frame-size).",
-"default": 16384,
Review comment:
Why have two sets of defaults then (one in the entity's definition in
the schema [e.g. listener], and one in the policy)? My point is defining a
policy should not force another set of defaults when the entity itself defines
its defaults.
Otherwise we're maintaining two sets of defaults which need to be kept in
sync else we trigger this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> policy code overrides configured connection settings by default
> ---
>
> Key: DISPATCH-2305
> URL: https://issues.apache.org/jira/browse/DISPATCH-2305
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.18.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>
> The following connection/settings attributes may be configured via
> management/configuration file:
> * maxFrameSize
> * maxSessions
> * maxSessionFrames (session window).
> These attributes may also be configured via policy. The policy configuration
> takes precedence.
> If a policy is configured but does *not specify* override values for any of
> the above attributes, one would expect any existing configured values would
> take effect.
> However this is not the case. If you set values for the above attributes in
> the router config file, and you define a matching policy that does not
> override these values, the policy will overwrite your configured values with
> what policy thinks is the default value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1475: DISPATCH-2305: prevent policy defaults overriding configuration
kgiusti commented on a change in pull request #1475:
URL: https://github.com/apache/qpid-dispatch/pull/1475#discussion_r781286944
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -2358,21 +2358,18 @@
"maxFrameSize": {
"type": "integer",
"description": "The largest frame, in bytes, that may be
sent on this connection. Non-zero policy values overwrite values specified for
a listener object (AMQP Open, max-frame-size).",
-"default": 16384,
Review comment:
Why have two sets of defaults then (one in the entity's definition in
the schema [e.g. listener], and one in the policy)? My point is defining a
policy should not force another set of defaults when the entity itself defines
its defaults.
Otherwise we're maintaining two sets of defaults which need to be kept in
sync else we trigger this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2305) policy code overrides configured connection settings by default
[
https://issues.apache.org/jira/browse/DISPATCH-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472086#comment-17472086
]
ASF GitHub Bot commented on DISPATCH-2305:
--
ganeshmurthy commented on a change in pull request #1475:
URL: https://github.com/apache/qpid-dispatch/pull/1475#discussion_r781266132
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -2358,21 +2358,18 @@
"maxFrameSize": {
"type": "integer",
"description": "The largest frame, in bytes, that may be
sent on this connection. Non-zero policy values overwrite values specified for
a listener object (AMQP Open, max-frame-size).",
-"default": 16384,
Review comment:
Bear with me here but when I look at this from a layman's perspective, I
like seeing the defaults in the json schema and this PR seems to remove the
defaults from the schema. Is there a way that these defaults can be still there
and if the policy does not overide these values, the defaults can be used? Is
that too much work from the policy side ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> policy code overrides configured connection settings by default
> ---
>
> Key: DISPATCH-2305
> URL: https://issues.apache.org/jira/browse/DISPATCH-2305
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.18.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
>
> The following connection/settings attributes may be configured via
> management/configuration file:
> * maxFrameSize
> * maxSessions
> * maxSessionFrames (session window).
> These attributes may also be configured via policy. The policy configuration
> takes precedence.
> If a policy is configured but does *not specify* override values for any of
> the above attributes, one would expect any existing configured values would
> take effect.
> However this is not the case. If you set values for the above attributes in
> the router config file, and you define a matching policy that does not
> override these values, the policy will overwrite your configured values with
> what policy thinks is the default value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1475: DISPATCH-2305: prevent policy defaults overriding configuration
ganeshmurthy commented on a change in pull request #1475:
URL: https://github.com/apache/qpid-dispatch/pull/1475#discussion_r781266132
##
File path: python/qpid_dispatch/management/qdrouter.json
##
@@ -2358,21 +2358,18 @@
"maxFrameSize": {
"type": "integer",
"description": "The largest frame, in bytes, that may be
sent on this connection. Non-zero policy values overwrite values specified for
a listener object (AMQP Open, max-frame-size).",
-"default": 16384,
Review comment:
Bear with me here but when I look at this from a layman's perspective, I
like seeing the defaults in the json schema and this PR seems to remove the
defaults from the schema. Is there a way that these defaults can be still there
and if the policy does not overide these values, the defaults can be used? Is
that too much work from the policy side ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2481) [cpp] Improve constructor syntax for maps
[ https://issues.apache.org/jira/browse/PROTON-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472067#comment-17472067 ] ASF GitHub Bot commented on PROTON-2481: codecov-commenter commented on pull request #353: URL: https://github.com/apache/qpid-proton/pull/353#issuecomment-1008936587 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/353?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#353](https://codecov.io/gh/apache/qpid-proton/pull/353?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad36978) into [main](https://codecov.io/gh/apache/qpid-proton/commit/a9509ed3a66370d2f27a6da12b86e3f67c353fe5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9509ed) will **decrease** coverage by `9.57%`. > The diff coverage is `n/a`. > :exclamation: Current head ad36978 differs from pull request most recent head 2392366. Consider uploading reports for the commit 2392366 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main #353 +/- ## == - Coverage 68.22% 58.64% -9.58% == Files 356 47 -309 Lines 73198 2394 -70804 == - Hits49939 1404 -48535 + Misses 23259 990 -22269 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [ruby/lib/core/container.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb250YWluZXIucmI=) | `27.35% <0.00%> (-71.75%)` | :arrow_down: | | [ruby/lib/handler/messaging\_adapter.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvaGFuZGxlci9tZXNzYWdpbmdfYWRhcHRlci5yYg==) | `28.98% <0.00%> (-68.12%)` | :arrow_down: | | [ruby/lib/core/condition.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb25kaXRpb24ucmI=) | `32.25% <0.00%> (-67.75%)` | :arrow_down: | | [ruby/lib/core/connection\_driver.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb25uZWN0aW9uX2RyaXZlci5yYg==) | `35.80% <0.00%> (-62.97%)` | :arrow_down: | | [ruby/lib/core/delivery.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9kZWxpdmVyeS5yYg==) | `33.33% <0.00%> (-60.61%)` | :arrow_down: | | [ruby/lib/handler/reactor\_messaging\_adapter.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvaGFuZGxlci9yZWFjdG9yX21lc3NhZ2luZ19hZGFwdGVyLnJi) | `32.55% <0.00%> (-58.14%)` | :arrow_down: | | [ruby/lib/core/receiver.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9yZWNlaXZlci5yYg==) | `44.00% <0.00%> (-56.00%)` | :arrow_down: | | [ruby/lib/core/connection.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_camp
[GitHub] [qpid-proton] codecov-commenter commented on pull request #353: PROTON-2481: [cpp] Improve constructor syntax for maps
codecov-commenter commented on pull request #353: URL: https://github.com/apache/qpid-proton/pull/353#issuecomment-1008936587 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/353?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#353](https://codecov.io/gh/apache/qpid-proton/pull/353?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad36978) into [main](https://codecov.io/gh/apache/qpid-proton/commit/a9509ed3a66370d2f27a6da12b86e3f67c353fe5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9509ed) will **decrease** coverage by `9.57%`. > The diff coverage is `n/a`. > :exclamation: Current head ad36978 differs from pull request most recent head 2392366. Consider uploading reports for the commit 2392366 to get more accurate results [](https://codecov.io/gh/apache/qpid-proton/pull/353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main #353 +/- ## == - Coverage 68.22% 58.64% -9.58% == Files 356 47 -309 Lines 73198 2394 -70804 == - Hits49939 1404 -48535 + Misses 23259 990 -22269 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [ruby/lib/core/container.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb250YWluZXIucmI=) | `27.35% <0.00%> (-71.75%)` | :arrow_down: | | [ruby/lib/handler/messaging\_adapter.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvaGFuZGxlci9tZXNzYWdpbmdfYWRhcHRlci5yYg==) | `28.98% <0.00%> (-68.12%)` | :arrow_down: | | [ruby/lib/core/condition.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb25kaXRpb24ucmI=) | `32.25% <0.00%> (-67.75%)` | :arrow_down: | | [ruby/lib/core/connection\_driver.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb25uZWN0aW9uX2RyaXZlci5yYg==) | `35.80% <0.00%> (-62.97%)` | :arrow_down: | | [ruby/lib/core/delivery.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9kZWxpdmVyeS5yYg==) | `33.33% <0.00%> (-60.61%)` | :arrow_down: | | [ruby/lib/handler/reactor\_messaging\_adapter.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvaGFuZGxlci9yZWFjdG9yX21lc3NhZ2luZ19hZGFwdGVyLnJi) | `32.55% <0.00%> (-58.14%)` | :arrow_down: | | [ruby/lib/core/receiver.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9yZWNlaXZlci5yYg==) | `44.00% <0.00%> (-56.00%)` | :arrow_down: | | [ruby/lib/core/connection.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9jb25uZWN0aW9uLnJi) | `41.66% <0.00%> (-51.67%)` | :arrow_down: | | [ruby/lib/util/wrapper.rb](https://codecov.io/gh/apache/qpid-proton/pull/353/diff?src=pr&el=tree&utm_medi
[jira] [Commented] (PROTON-2481) [cpp] Improve constructor syntax for maps
[ https://issues.apache.org/jira/browse/PROTON-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471962#comment-17471962 ] ASF GitHub Bot commented on PROTON-2481: DreamPearl opened a new pull request #353: URL: https://github.com/apache/qpid-proton/pull/353 - Add a copy constructor to copy from std::map - Add an initializer_list constructor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [cpp] Improve constructor syntax for maps > - > > Key: PROTON-2481 > URL: https://issues.apache.org/jira/browse/PROTON-2481 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Rakhi Kumari >Assignee: Rakhi Kumari >Priority: Major > Fix For: proton-c-0.37.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl opened a new pull request #353: PROTON-2481: [cpp] Improve constructor syntax for maps
DreamPearl opened a new pull request #353: URL: https://github.com/apache/qpid-proton/pull/353 - Add a copy constructor to copy from std::map - Add an initializer_list constructor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2481) [cpp] Improve constructor syntax for maps
Rakhi Kumari created PROTON-2481: Summary: [cpp] Improve constructor syntax for maps Key: PROTON-2481 URL: https://issues.apache.org/jira/browse/PROTON-2481 Project: Qpid Proton Issue Type: Improvement Components: cpp-binding Reporter: Rakhi Kumari Assignee: Rakhi Kumari Fix For: proton-c-0.37.0 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
