[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989905#comment-16989905 ] ASF subversion and git services commented on DISPATCH-1439: --- Commit 5739f1a819f5f696e29f52f20d71ab1b9eb55fc5 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=5739f1a ] DISPATCH-1439 - Additional fix to long running qdstat test. Check the minute value if the second value is zero and pass the test > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970572#comment-16970572 ] ASF subversion and git services commented on DISPATCH-1439: --- Commit d0f95c4f03cd053360f96cd3f1c0092915e327f1 in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=d0f95c4 ] DISPATCH-1439 - Additional fix to failing test system_test_one_router > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.10.0 > > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970487#comment-16970487 ] ASF subversion and git services commented on DISPATCH-1439: --- Commit bf6592ffbbe742ce52c8c780baf1c07299e62dec in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=bf6592f ] DISPATCH-1439 - Added two attributes to connection and one to router. 1. connection uptime - The number of seconds the connection has been up 2. connection last delivery seconds - The number of seconds since a delivery was sent on a connection 3. router uptime - the number of seconds since the router started > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Assignee: Ganesh Murthy >Priority: Major > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970488#comment-16970488 ] ASF GitHub Bot commented on DISPATCH-1439: -- ganeshmurthy commented on pull request #614: DISPATCH-1439 - Added two attributes to connection and one to router. URL: https://github.com/apache/qpid-dispatch/pull/614 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Assignee: Ganesh Murthy >Priority: Major > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[
https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969359#comment-16969359
]
ASF GitHub Bot commented on DISPATCH-1439:
--
ganeshmurthy commented on pull request #614: DISPATCH-1439 - Added two
attributes to connection and one to router.
URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343720234
##
File path: src/router_core/router_core_private.h
##
@@ -659,6 +659,9 @@ struct qdr_connection_t {
qdr_conn_admin_status_t admin_status;
qdr_error_t*error;
boolclosed; // This bit is used in the case where
a client is trying to force close this connection.
+uint32_tconn_uptime; // The number of seconds that
this connection has been up and running.
+uint32_tlast_delivery_time; // The number of seconds
since the last delivery arrived on this connection.
Review comment:
Fixed comment
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Expose create time/last transfer time through the Connection management entity
> --
>
> Key: DISPATCH-1439
> URL: https://issues.apache.org/jira/browse/DISPATCH-1439
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
>
> Having these two additional attributes:
> * connection create time
> * connection last transfer time
> would aid fault finding activities.
> It would also serve as useful input to external tooling wishing to say,
> balance connections to a router network.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969356#comment-16969356 ] ASF GitHub Bot commented on DISPATCH-1439: -- ganeshmurthy commented on pull request #614: DISPATCH-1439 - Added two attributes to connection and one to router. URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343718843 ## File path: src/router_core/agent_connection.c ## @@ -240,6 +245,17 @@ static void qdr_connection_insert_column_CT(qdr_core_t *core, qdr_connection_t * qd_compose_insert_string(body, text); break; +case QDR_CONNECTION_UPTIME_SECONDS: +qd_compose_insert_uint(body, core->uptime_ticks - conn->conn_uptime); +break; + +case QDR_CONNECTION_LAST_DLV_SECONDS: +if (conn->is_delivery_sent) +qd_compose_insert_uint(body, core->uptime_ticks - conn->last_delivery_time); +else +qd_compose_insert_string(body, "-"); Review comment: Changed this to insert null instead of "-" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Assignee: Ganesh Murthy >Priority: Major > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[
https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969355#comment-16969355
]
ASF GitHub Bot commented on DISPATCH-1439:
--
ganeshmurthy commented on pull request #614: DISPATCH-1439 - Added two
attributes to connection and one to router.
URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343718521
##
File path: src/router_core/router_core_private.h
##
@@ -659,6 +659,9 @@ struct qdr_connection_t {
qdr_conn_admin_status_t admin_status;
qdr_error_t*error;
boolclosed; // This bit is used in the case where
a client is trying to force close this connection.
+uint32_tconn_uptime; // The number of seconds that
this connection has been up and running.
+uint32_tlast_delivery_time; // The number of seconds
since the last delivery arrived on this connection.
+boolis_delivery_sent;
Review comment:
Yes, agreed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Expose create time/last transfer time through the Connection management entity
> --
>
> Key: DISPATCH-1439
> URL: https://issues.apache.org/jira/browse/DISPATCH-1439
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
>
> Having these two additional attributes:
> * connection create time
> * connection last transfer time
> would aid fault finding activities.
> It would also serve as useful input to external tooling wishing to say,
> balance connections to a router network.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[
https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969338#comment-16969338
]
ASF GitHub Bot commented on DISPATCH-1439:
--
ganeshmurthy commented on pull request #614: DISPATCH-1439 - Added two
attributes to connection and one to router.
URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343703866
##
File path: python/qpid_dispatch_internal/tools/display.py
##
@@ -45,7 +45,14 @@ def Commas(value):
sval = left
def TimeLong(value):
- return strftime("%c", gmtime(value / 10))
+ day = value // (24 * 3600)
+ time = value % (24 * 3600)
+ hour = time // 3600
+ time %= 3600
+ minutes = time // 60
+ time %= 60
+ seconds = time
+ return "%03d:%02d:%02d:%02d" % (day, hour, minutes, seconds)
Review comment:
I wanted qdstat to display in days:hours:minutes:seconds (I put a 3 digit
limit on the days). I assumed that the router (or a connection) will not be up
for more than 999 days.
That being said, strftime does not directly provide what I want. It rolls
the the day into the year after 365 days. Then I need to use the year to
calculate the days which becomes difficult if a leap year is involved. I could
do the following and display the output in years:days:hours:minutes:seconds:
value=15000
year_from_epoch = strftime("%Y", gmtime(value))
year=int(year_from_epoch) - 1970
print ("Output=%s:%s" % (str(year), strftime("%j:%X", gmtime(value
[gmurthy@localhost test]$ python strtime.py
Output=4:276:02:40:00
[gmurthy@localhost test]$
With all this in mind, I decided to write a simple custom function myself.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Expose create time/last transfer time through the Connection management entity
> --
>
> Key: DISPATCH-1439
> URL: https://issues.apache.org/jira/browse/DISPATCH-1439
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
>
> Having these two additional attributes:
> * connection create time
> * connection last transfer time
> would aid fault finding activities.
> It would also serve as useful input to external tooling wishing to say,
> balance connections to a router network.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[
https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969333#comment-16969333
]
ASF GitHub Bot commented on DISPATCH-1439:
--
ganeshmurthy commented on pull request #614: DISPATCH-1439 - Added two
attributes to connection and one to router.
URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343703866
##
File path: python/qpid_dispatch_internal/tools/display.py
##
@@ -45,7 +45,14 @@ def Commas(value):
sval = left
def TimeLong(value):
- return strftime("%c", gmtime(value / 10))
+ day = value // (24 * 3600)
+ time = value % (24 * 3600)
+ hour = time // 3600
+ time %= 3600
+ minutes = time // 60
+ time %= 60
+ seconds = time
+ return "%03d:%02d:%02d:%02d" % (day, hour, minutes, seconds)
Review comment:
I wanted qdstat to display in days:hours:minutes:seconds (we have a 3 digit
limit on the days). I assumed that the router (or a connection) will not be up
for more than 999 days.
That being said, strftime does not directly provide what I want. It rolls
the the day into the year after 365 days. Then I need to use the year to
calculate the days which becomes difficult if a leap year is involved. I could
do the following and display the output in years:days:hours:minutes:seconds:
value=15000
year_from_epoch = strftime("%Y", gmtime(value))
year=int(year_from_epoch) - 1970
print ("Output=%s:%s" % (str(year), strftime("%j:%X", gmtime(value
[gmurthy@localhost test]$ python strtime.py
Output=4:276:02:40:00
[gmurthy@localhost test]$
With all this in mind, I decided to write a simple custom function myself.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Expose create time/last transfer time through the Connection management entity
> --
>
> Key: DISPATCH-1439
> URL: https://issues.apache.org/jira/browse/DISPATCH-1439
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
>
> Having these two additional attributes:
> * connection create time
> * connection last transfer time
> would aid fault finding activities.
> It would also serve as useful input to external tooling wishing to say,
> balance connections to a router network.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[
https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969170#comment-16969170
]
ASF GitHub Bot commented on DISPATCH-1439:
--
ted-ross commented on pull request #614: DISPATCH-1439 - Added two attributes
to connection and one to router.
URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343593410
##
File path: python/qpid_dispatch_internal/tools/display.py
##
@@ -45,7 +45,14 @@ def Commas(value):
sval = left
def TimeLong(value):
- return strftime("%c", gmtime(value / 10))
+ day = value // (24 * 3600)
+ time = value % (24 * 3600)
+ hour = time // 3600
+ time %= 3600
+ minutes = time // 60
+ time %= 60
+ seconds = time
+ return "%03d:%02d:%02d:%02d" % (day, hour, minutes, seconds)
Review comment:
I'm curious as to why this was done. Does the strftime function no format
the data properly?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Expose create time/last transfer time through the Connection management entity
> --
>
> Key: DISPATCH-1439
> URL: https://issues.apache.org/jira/browse/DISPATCH-1439
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Priority: Major
>
> Having these two additional attributes:
> * connection create time
> * connection last transfer time
> would aid fault finding activities.
> It would also serve as useful input to external tooling wishing to say,
> balance connections to a router network.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[
https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969025#comment-16969025
]
ASF GitHub Bot commented on DISPATCH-1439:
--
ted-ross commented on pull request #614: DISPATCH-1439 - Added two attributes
to connection and one to router.
URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343517080
##
File path: src/router_core/router_core_private.h
##
@@ -659,6 +659,9 @@ struct qdr_connection_t {
qdr_conn_admin_status_t admin_status;
qdr_error_t*error;
boolclosed; // This bit is used in the case where
a client is trying to force close this connection.
+uint32_tconn_uptime; // The number of seconds that
this connection has been up and running.
+uint32_tlast_delivery_time; // The number of seconds
since the last delivery arrived on this connection.
+boolis_delivery_sent;
Review comment:
Couldn't this boolean be avoided by saying that last_delivery_time == 0 if
no deliveries have been sent?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Expose create time/last transfer time through the Connection management entity
> --
>
> Key: DISPATCH-1439
> URL: https://issues.apache.org/jira/browse/DISPATCH-1439
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Priority: Major
>
> Having these two additional attributes:
> * connection create time
> * connection last transfer time
> would aid fault finding activities.
> It would also serve as useful input to external tooling wishing to say,
> balance connections to a router network.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[
https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969022#comment-16969022
]
ASF GitHub Bot commented on DISPATCH-1439:
--
ted-ross commented on pull request #614: DISPATCH-1439 - Added two attributes
to connection and one to router.
URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343516762
##
File path: src/router_core/router_core_private.h
##
@@ -659,6 +659,9 @@ struct qdr_connection_t {
qdr_conn_admin_status_t admin_status;
qdr_error_t*error;
boolclosed; // This bit is used in the case where
a client is trying to force close this connection.
+uint32_tconn_uptime; // The number of seconds that
this connection has been up and running.
+uint32_tlast_delivery_time; // The number of seconds
since the last delivery arrived on this connection.
Review comment:
Both of these comments are incorrect. These are timestamps, not durations.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Expose create time/last transfer time through the Connection management entity
> --
>
> Key: DISPATCH-1439
> URL: https://issues.apache.org/jira/browse/DISPATCH-1439
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Priority: Major
>
> Having these two additional attributes:
> * connection create time
> * connection last transfer time
> would aid fault finding activities.
> It would also serve as useful input to external tooling wishing to say,
> balance connections to a router network.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969017#comment-16969017 ] ASF GitHub Bot commented on DISPATCH-1439: -- ted-ross commented on pull request #614: DISPATCH-1439 - Added two attributes to connection and one to router. URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343515001 ## File path: src/router_core/agent_router.c ## @@ -233,6 +235,13 @@ static void qdr_agent_write_column_CT(qd_composed_field_t *body, int col, qdr_co qd_compose_insert_uint(body, core->links_blocked); break; +case QDR_ROUTER_UPTIME_SECONDS: +if (core->uptime_ticks== 0) +qd_compose_insert_uint(body, 0); Review comment: This if-then-else doesn't seem to be any different from simply calling qs_compose_insert_uint. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Priority: Major > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969011#comment-16969011 ] ASF GitHub Bot commented on DISPATCH-1439: -- ted-ross commented on pull request #614: DISPATCH-1439 - Added two attributes to connection and one to router. URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343513338 ## File path: src/router_core/agent_connection.c ## @@ -240,6 +245,17 @@ static void qdr_connection_insert_column_CT(qdr_core_t *core, qdr_connection_t * qd_compose_insert_string(body, text); break; +case QDR_CONNECTION_UPTIME_SECONDS: +qd_compose_insert_uint(body, core->uptime_ticks - conn->conn_uptime); +break; + +case QDR_CONNECTION_LAST_DLV_SECONDS: +if (conn->is_delivery_sent) +qd_compose_insert_uint(body, core->uptime_ticks - conn->last_delivery_time); +else +qd_compose_insert_string(body, "-"); Review comment: Adding hyphens to fields is the job of qdstat. It should not be done here (I don't believe there is a precedent for it). A better option is to insert a null value if there is no information to send. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Priority: Major > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968832#comment-16968832 ] ASF GitHub Bot commented on DISPATCH-1439: -- codecov-io commented on issue #614: DISPATCH-1439 - Added two attributes to connection and one to router. URL: https://github.com/apache/qpid-dispatch/pull/614#issuecomment-550571158 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr=h1) Report > Merging [#614](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/2bd5061938b5ce5d59e02af6eb5f89c8862362b5?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr=tree) ```diff @@Coverage Diff @@ ## master #614 +/- ## == - Coverage 86.44% 86.43% -0.01% == Files 91 91 Lines 2061320633 +20 == + Hits1781817834 +16 - Misses 2795 2799 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.96% <100%> (+0.04%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.33% <100%> (+0.04%)` | :arrow_up: | | [src/router\_core/core\_link\_endpoint.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfbGlua19lbmRwb2ludC5j) | `97.08% <100%> (+0.08%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.97% <100%> (-0.56%)` | :arrow_down: | | [src/router\_core/agent\_connection.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2Nvbm5lY3Rpb24uYw==) | `82.12% <100%> (+0.46%)` | :arrow_up: | | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `91.2% <100%> (+0.4%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.97% <0%> (ø)` | :arrow_up: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/614/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `81.37% <0%> (+0.18%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr=footer). Last update [2bd5061...6218328](https://codecov.io/gh/apache/qpid-dispatch/pull/614?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Priority: Major > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968771#comment-16968771 ] ASF GitHub Bot commented on DISPATCH-1439: -- bhardesty commented on pull request #614: DISPATCH-1439 - Added two attributes to connection and one to router. URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343362146 ## File path: docs/man/qdstat.8.adoc ## @@ -73,6 +73,13 @@ The authentication method and user ID of the connection's authenticated user. tenant:: If the connection is to a listener using multi-tenancy, this column displays the tenant namespace for the connection. +last dlv:: +Time since the last delivery showed up on this connection. Displayed in the days:hours:minutes:seconds format. Review comment: Maybe "arrived" instead of "showed up"? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Priority: Major > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968763#comment-16968763 ] ASF GitHub Bot commented on DISPATCH-1439: -- ganeshmurthy commented on pull request #614: DISPATCH-1439 - Added two attributes to connection and one to router. URL: https://github.com/apache/qpid-dispatch/pull/614 1. connection uptime - The number of seconds the connection has been up 2. connection last delivery seconds - The number of seconds since a delivery was sent on a connection 3. router uptime - the number of seconds since the router started This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Priority: Major > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[
https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967908#comment-16967908
]
Ganesh Murthy commented on DISPATCH-1439:
-
[~kwall] [~lulf] In addition to the above 2 attributes, I am also adding
another attribute to qdstat -g called Uptime which will show the uptime of the
router. This will help you figure out when the router was started.
{noformat}
Router Statistics
attr value
=
Version 1.10.0-SNAPSHOT
Mode standalone
Router IdStandalone_nU+Mn4YFcHxAKr5
Uptime 000:00:04:38
Area 0
Link Routes 0
Auto Links 0
Links3
Nodes0
Addresses5
Connections 2
Presettled Count 0
Dropped Presettled Count 0
Accepted Count 26
Rejected Count 0
Released Count 0
Modified Count 0
Deliveries Delayed > 1sec0
Deliveries Delayed > 10sec 0
Deliveries Stuck > 10sec 0
Deliveries to Fallback 0
Links Blocked1
Ingress Count26
Egress Count 25
Transit Count0
Deliveries from Route Container 0
Deliveries to Route Container0
[gmurthy@localhost qpid-dispatch]$
{noformat}
> Expose create time/last transfer time through the Connection management entity
> --
>
> Key: DISPATCH-1439
> URL: https://issues.apache.org/jira/browse/DISPATCH-1439
> Project: Qpid Dispatch
> Issue Type: Improvement
>Reporter: Keith Wall
>Priority: Major
>
> Having these two additional attributes:
> * connection create time
> * connection last transfer time
> would aid fault finding activities.
> It would also serve as useful input to external tooling wishing to say,
> balance connections to a router network.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962098#comment-16962098 ] Ulf Lilleengen commented on DISPATCH-1439: -- [~kwall] seconds since is probably enough, as thats what we want to compute for alerts anyway I think. > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Priority: Major > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962089#comment-16962089 ] Keith Wall commented on DISPATCH-1439: -- [~tross] seconds since connection creation and seconds since last transfer would suffice. As the caller, we could use the seconds since values back into absolute time values, if we wished. [~lulf]? For background - the initial use case would be as connection statistics to be displayed in a Console application. > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Priority: Major > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1439) Expose create time/last transfer time through the Connection management entity
[ https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961035#comment-16961035 ] Ted Ross commented on DISPATCH-1439: What kind of timestamps are desired/acceptable for this feature? Do you want to correlate the time to log entries? Is it acceptable to have "seconds since connection creation" and "seconds since last transfer"? The latter is more efficient to implement. > Expose create time/last transfer time through the Connection management entity > -- > > Key: DISPATCH-1439 > URL: https://issues.apache.org/jira/browse/DISPATCH-1439 > Project: Qpid Dispatch > Issue Type: Improvement >Reporter: Keith Wall >Priority: Major > > Having these two additional attributes: > * connection create time > * connection last transfer time > would aid fault finding activities. > It would also serve as useful input to external tooling wishing to say, > balance connections to a router network. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
