Re: Review Request 57584: RANGER-1449:There is logical inconsistency for RANGER_PID_DIR_PATH in security admin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57584/
---
(Updated March 17, 2017, 3:29 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1449
https://issues.apache.org/jira/browse/RANGER-1449
Repository: ranger
Description
---
1. There is RANGER_PID_DIR_PATH parameter in install.properties. But There is
hard code at the begin of setup.sh
pidFolderName='/var/run/ranger'
mkdir -p $
{pidFolderName}
if [ ! $? = "0" ];then
log "Make $pidFolderName failure!!";
exit 1;
fi
2. The ranger-admin-services.sh will set default value and create default path
when the RANGER_PID_DIR_PATH parameter is empty. The setup.sh doesn't set
default value and create default path.
Diffs (updated)
-
security-admin/scripts/setup.sh 87be127
Diff: https://reviews.apache.org/r/57584/diff/2/
Changes: https://reviews.apache.org/r/57584/diff/1-2/
Testing
---
Thanks,
pengjianhua
Re: Review Request 57584: RANGER-1449:There is logical inconsistency for RANGER_PID_DIR_PATH in security admin
> On March 14, 2017, 12:56 p.m., Colm O hEigeartaigh wrote:
> > Looks good in general, however I think it would be a good idea to preserve
> > the "if [ ! $? = "0" ];then" statement, but move it after "mkdir -p
> > ${RANGER_PID_DIR_PATH}" on line 1369.
>
> pengjianhua wrote:
> Ok. Thanks.
I modified the patch according to your review and updated it. Thanks.
- pengjianhua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57584/#review168893
---
On March 14, 2017, 3:37 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57584/
> ---
>
> (Updated March 14, 2017, 3:37 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1449
> https://issues.apache.org/jira/browse/RANGER-1449
>
>
> Repository: ranger
>
>
> Description
> ---
>
> 1. There is RANGER_PID_DIR_PATH parameter in install.properties. But There is
> hard code at the begin of setup.sh
> pidFolderName='/var/run/ranger'
> mkdir -p $
> {pidFolderName}
>
> if [ ! $? = "0" ];then
> log "Make $pidFolderName failure!!";
> exit 1;
> fi
> 2. The ranger-admin-services.sh will set default value and create default
> path when the RANGER_PID_DIR_PATH parameter is empty. The setup.sh doesn't
> set default value and create default path.
>
>
> Diffs
> -
>
> security-admin/scripts/setup.sh 87be127
>
>
> Diff: https://reviews.apache.org/r/57584/diff/1/
>
>
> Testing
> ---
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 57587: The install program used SOLR_RANGER_COLLECTION attribute value in Install and Configure Solr for Ranger Audits. But there is no corresponding setting in install.properties.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57587/#review169253 --- Ship it! Ship It! - Qiang Zhang On 三月 14, 2017, 4:55 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57587/ > --- > > (Updated 三月 14, 2017, 4:55 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1452 > https://issues.apache.org/jira/browse/RANGER-1452 > > > Repository: ranger > > > Description > --- > > The install program used SOLR_RANGER_COLLECTION attribute value in Install > and Configure Solr for Ranger Audits. But there is no corresponding setting > in install.properties. So the user can only used fixed value during > installing. > > > Diffs > - > > security-admin/contrib/solr_for_audit_setup/install.properties f5d8cef > > > Diff: https://reviews.apache.org/r/57587/diff/1/ > > > Testing > --- > > > Thanks, > > pengjianhua > >
[jira] [Resolved] (RANGER-1415) The ranger can be opened when the user enters http://localhost:6080/ in the browser address bar. But request policy from hadoop to ranger will failed after installing h
[ https://issues.apache.org/jira/browse/RANGER-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang resolved RANGER-1415. - Resolution: Fixed Fix Version/s: 1.0.0 > The ranger can be opened when the user enters http://localhost:6080/ in the > browser address bar. But request policy from hadoop to ranger will failed > after installing hdfs plugin if we set POLICY_MGR_URL equal to > http://localhost:6080/. > > > Key: RANGER-1415 > URL: https://issues.apache.org/jira/browse/RANGER-1415 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 0.7.0 >Reporter: Qiang Zhang >Assignee: Qiang Zhang >Priority: Minor > Labels: patch > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1415-update-The-ranger-can-be-opened-when-the.patch > > > The ranger can be opened when the user enters http://localhost:6080/ in the > browser address bar. But request policy from hadoop to ranger will failed > after installing hdfs plugin if we set POLICY_MGR_URL equal to > http://localhost:6080/.The error was as following: > 2017-02-27 21:16:42,859 ERROR > org.apache.ranger.admin.client.RangerAdminRESTClient: Error getting policies; > service not found. secureMode=false, user=root (auth:SIMPLE), response=404, > serviceName=hadoopdev, lastKnownVersion=4, > lastActivationTimeInMillis=1488246663112 > 2017-02-27 21:16:42,867 ERROR org.apache.ranger.plugin.util.PolicyRefresher: > PolicyRefresher(serviceName=hadoopdev): failed to find service. Will clean up > local cache of policies (4) > org.apache.ranger.plugin.util.RangerServiceNotFoundException: hadoopdev > at > org.apache.ranger.plugin.util.RangerServiceNotFoundException.throwExceptionIfServiceNotFound(RangerServiceNotFoundException.java:35) > at > org.apache.ranger.admin.client.RangerAdminRESTClient.getServicePoliciesIfUpdated(RangerAdminRESTClient.java:145) > at > org.apache.ranger.plugin.util.PolicyRefresher.loadPolicyfromPolicyAdmin(PolicyRefresher.java:257) > at > org.apache.ranger.plugin.util.PolicyRefresher.loadPolicy(PolicyRefresher.java:201) > at > org.apache.ranger.plugin.util.PolicyRefresher.run(PolicyRefresher.java:170) > Reason: > The brower will remove the last '/' character when the user enters > http://localhost:6080/ in the browser address bar. The rest request address > will be > http://localhost:6080//service/plugins/policies/download/hadoopdev?lastKnownVersion=-1&lastActivationTime=0&pluginId=hdfs@VBoxNodeEng-1-hadoopdev > when hadoop periodically requests policy from ranger. The request will fail > because there are two '/' character after 'Http://localhost:6080' in > http://localhost:6080//service/plugins/policies/download/hadoopdev?lastKnownVersion=-1&lastActivationTime=0&pluginId=hdfs@VBoxNodeEng-1-hadoopdev. > The result is that we can't see the hdfs plugins in audit web UI. > The program should be compatible with this situation like the browser. > Scenario: > The issue can be reoccurred after we set the value of > ranger.plugin.hdfs.policy.rest.url to http://localhost:6080/ in > ../hadoop/hadoop-2.7.3/etc/hadoop/ranger-hdfs-security.xml > Test and verify: > I carefully tested and verified the patch before commit the issue. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (RANGER-1456) Fix the spelling error in HDFS plugin
[
https://issues.apache.org/jira/browse/RANGER-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qiang Zhang resolved RANGER-1456.
-
Resolution: Fixed
> Fix the spelling error in HDFS plugin
> -
>
> Key: RANGER-1456
> URL: https://issues.apache.org/jira/browse/RANGER-1456
> Project: Ranger
> Issue Type: Bug
> Components: plugins
>Affects Versions: 1.0.0
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
> Fix For: 1.0.0
>
>
> {code}
> LOG.error("Serice not found with name "+serviceName, new Throwable());
> {code}
> It should be 'service' instead of 'serice'.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (RANGER-1462) Fix the spelling error in Solr Authorization
[
https://issues.apache.org/jira/browse/RANGER-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qiang Zhang resolved RANGER-1462.
-
Resolution: Fixed
> Fix the spelling error in Solr Authorization
>
>
> Key: RANGER-1462
> URL: https://issues.apache.org/jira/browse/RANGER-1462
> Project: Ranger
> Issue Type: Bug
> Components: plugins
>Affects Versions: 1.0.0
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
> Fix For: 1.0.0
>
>
> {code}
> logger.fatal("Can't create RangerRequest oject. userName="
> + userName + ", accessType=" + accessType + ",
> ip=" + ip
> + ", collectionRequest=" + collectionRequest);
> {code}
> It should be 'object' instead of 'oject'.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Re: Re: Re: Re: Can't change the Assignee to oneself?
Ok. Thanks. 原始邮件 发件人： ＜bo...@apache.org＞ 收件人： ＜dev@ranger.apache.org＞ ＜sneet...@apache.org＞ 日 期 ：2017年03月17日 08:38 主 题 ：Re: 答复: Re: Can't change the Assignee to oneself? Jianhua I have added you as contributor… Bosco From: ＜peng.jian...@zte.com.cn＞ Reply-To: ＜dev@ranger.apache.org＞ Date: Monday, March 13, 2017 at 8:11 PM To: ＜sneet...@apache.org＞ Cc: ＜dev@ranger.apache.org＞ Subject: 答复: Re: Can't change the Assignee to oneself? Hi Selvamonhan, I can't change the Assignee to oneself also when submit the RANGER-1449.Please add me as contributor for Apache Ranger. My account is peng.jianhua. Thanks Jianhua Peng 彭建华 Jianhua Peng IT开发工程师 IT Development Engineer 网管及服务开发一部/中心研究院/系统产品 Network Management & Service Development Dept. I/Central R＆D Institute/System Product 南京市雨花台区紫荆花路68号 2期C4 4C, ZTE Corporation Nanjing R&D Center, Zijinghua Road 68, YuHua District, Nanjing, P..R.China, 210012 M: +86 18012968496 E: peng.jian...@zte.com.cn www.zte.com.cn 原始邮件 发件人： ＜sneet...@apache.org＞ 收件人： ＜dev@ranger.apache.org＞ 日 期 ：2017年03月09日 02:24 主 题 ：Re: Can't change the Assignee to oneself? Yan, I have added you as Contributor to Apache Ranger JIRA. Thanks, Selva- On 3/8/17, 1:14 PM, "Yan Zhou" ＜yzhouopensou...@gmail.com＞ wrote: Thanks Selvamohan. I have actually contributed several patches. So please add me as a contributor. On Wed, Mar 8, 2017 at 9:05 AM, Selvamohan Neethiraj ＜sneet...@apache.org＞ wrote: ＞ Hi Yan, ＞ ＞ Welcome to Ranger Dev Community …. ＞ ＞ Our Policy allows only Contributors/Committers to be able to set/modify ＞ the assignee of the JIRA. ＞ ＞ If you would like to provide patch and/or documentation for the Apache ＞ Ranger, please send a request to add yourself as a contributor in the dev ＞ mailing list. ＞ Once you are added as contributors (by the JIRA Administrators), you ＞ should be able to assign/re-assign JIRA yourself. ＞ ＞ Thanks, ＞ Selva- ＞ ＞ From: Yan Zhou ＜yzhouopensou...@gmail.com＞ ＞ Reply-To: "dev@ranger.apache.org" ＜dev@ranger.apache.org＞ ＞ Date: Wednesday, March 8, 2017 at 11:59 AM ＞ To: "dev@ranger.apache.org" ＜dev@ranger.apache.org＞, Colm O hEigeartaigh ＞ ＜cohei...@apache.org＞ ＞ Subject: Re: Can't change the Assignee to oneself? ＞ ＞ https://issues.apache.org/jira/browse/RANGER-1252, yzhou2001 ＞ ＞ A basic question is whether there is a Ranger jira policy that only allows ＞ power users to set assignee? Or a grant of right has to be given by a power ＞ user ? ＞ ＞ Thanks, ＞ ＞ On Wed, Mar 8, 2017 at 8:51 AM, Colm O hEigeartaigh ＜cohei...@apache.org＞ ＞ wrote: ＞ ＞ What JIRA number is it, and what is your JIRA account username? ＞ ＞ Colm. ＞ ＞ On Wed, Mar 8, 2017 at 4:41 PM, Yan Zhou ＜yzhouopensou...@gmail.com＞ ＞ wrote: ＞ ＞ ＞ Hi, I filed a Ranger jira and posted a patch. But it seems to me that I ＞ ＞ can't change the assignee field to myself. Is this the way that Ranger ＞ ＞ jira is supposed to work? Or do I need extra steps in order to be able ＞ to ＞ ＞ do so? ＞ ＞ ＞ ＞ Thanks! ＞ ＞ ＞ ＞ ＞ ＞ -- ＞ Colm O hEigeartaigh ＞ ＞ Talend Community Coder ＞ http://coders.talend.com ＞ ＞ ＞ ＞
Re: 答复: Re: Can't change the Assignee to oneself?
Jianhua I have added you as contributor… Bosco From: Reply-To: Date: Monday, March 13, 2017 at 8:11 PM To: Cc: Subject: 答复: Re: Can't change the Assignee to oneself? Hi Selvamonhan, I can't change the Assignee to oneself also when submit the RANGER-1449.Please add me as contributor for Apache Ranger. My account is peng.jianhua. Thanks Jianhua Peng 彭建华 Jianhua Peng IT开发工程师 IT Development Engineer 网管及服务开发一部/中心研究院/系统产品 Network Management & Service Development Dept. I/Central R＆D Institute/System Product 南京市雨花台区紫荆花路68号 2期C4 4C, ZTE Corporation Nanjing R&D Center, Zijinghua Road 68, YuHua District, Nanjing, P..R.China, 210012M: +86 18012968496 E: peng.jian...@zte.com.cn www.zte.com.cn 原始邮件 发件人： ＜sneet...@apache.org＞; 收件人： ＜dev@ranger.apache.org＞; 日 期 ：2017年03月09日 02:24 主 题 ：Re: Can't change the Assignee to oneself? Yan, I have added you as Contributor to Apache Ranger JIRA. Thanks, Selva- On 3/8/17, 1:14 PM, "Yan Zhou" ＜yzhouopensou...@gmail.com＞ wrote: Thanks Selvamohan. I have actually contributed several patches. So please add me as a contributor. On Wed, Mar 8, 2017 at 9:05 AM, Selvamohan Neethiraj ＜sneet...@apache.org＞ wrote: ＞ Hi Yan, ＞ ＞ Welcome to Ranger Dev Community …. ＞ ＞ Our Policy allows only Contributors/Committers to be able to set/modify ＞ the assignee of the JIRA. ＞ ＞ If you would like to provide patch and/or documentation for the Apache ＞ Ranger, please send a request to add yourself as a contributor in the dev ＞ mailing list. ＞ Once you are added as contributors (by the JIRA Administrators), you ＞ should be able to assign/re-assign JIRA yourself. ＞ ＞ Thanks, ＞ Selva- ＞ ＞ From: Yan Zhou ＜yzhouopensou...@gmail.com＞ ＞ Reply-To: "dev@ranger.apache.org" ＜dev@ranger.apache.org＞ ＞ Date: Wednesday, March 8, 2017 at 11:59 AM ＞ To: "dev@ranger.apache.org" ＜dev@ranger.apache.org＞, Colm O hEigeartaigh ＞ ＜cohei...@apache.org＞ ＞ Subject: Re: Can't change the Assignee to oneself? ＞ ＞ https://issues.apache.org/jira/browse/RANGER-1252, yzhou2001 ＞ ＞ A basic question is whether there is a Ranger jira policy that only allows ＞ power users to set assignee? Or a grant of right has to be given by a power ＞ user ? ＞ ＞ Thanks, ＞ ＞ On Wed, Mar 8, 2017 at 8:51 AM, Colm O hEigeartaigh ＜cohei...@apache.org＞ ＞ wrote: ＞ ＞ What JIRA number is it, and what is your JIRA account username? ＞ ＞ Colm. ＞ ＞ On Wed, Mar 8, 2017 at 4:41 PM, Yan Zhou ＜yzhouopensou...@gmail.com＞ ＞ wrote: ＞ ＞ ＞ Hi, I filed a Ranger jira and posted a patch. But it seems to me that I ＞ ＞ can't change the assignee field to myself. Is this the way that Ranger ＞ ＞ jira is supposed to work? Or do I need extra steps in order to be able ＞ to ＞ ＞ do so? ＞ ＞ ＞ ＞ Thanks! ＞ ＞ ＞ ＞ ＞ ＞ -- ＞ Colm O hEigeartaigh ＞ ＞ Talend Community Coder ＞ http://coders.talend.com ＞ ＞ ＞ ＞
Re: Review Request 57697: Good coding practice recommended by static code analysis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57697/#review169204 --- Ship it! Ship It! - Velmurugan Periasamy On March 16, 2017, 6:03 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57697/ > --- > > (Updated March 16, 2017, 6:03 p.m.) > > > Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. > > > Bugs: RANGER-1463 > https://issues.apache.org/jira/browse/RANGER-1463 > > > Repository: ranger > > > Description > --- > > Fix for potential NPE and performance issue > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java > 9955051 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 26080b5 > > > Diff: https://reviews.apache.org/r/57697/diff/2/ > > > Testing > --- > > Created Ranger service in a local VM and ensured that the default policies > are created as expected. > > > Thanks, > > Abhay Kulkarni > >
Re: Review Request 57697: Good coding practice recommended by static code analysis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57697/#review169198 --- Ship it! Ship It! - Ramesh Mani On March 16, 2017, 6:03 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57697/ > --- > > (Updated March 16, 2017, 6:03 p.m.) > > > Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. > > > Bugs: RANGER-1463 > https://issues.apache.org/jira/browse/RANGER-1463 > > > Repository: ranger > > > Description > --- > > Fix for potential NPE and performance issue > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java > 9955051 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 26080b5 > > > Diff: https://reviews.apache.org/r/57697/diff/2/ > > > Testing > --- > > Created Ranger service in a local VM and ensured that the default policies > are created as expected. > > > Thanks, > > Abhay Kulkarni > >
Re: Review Request 57697: Good coding practice recommended by static code analysis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57697/ --- (Updated March 16, 2017, 6:03 p.m.) Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. Changes --- Addressed review comment Bugs: RANGER-1463 https://issues.apache.org/jira/browse/RANGER-1463 Repository: ranger Description --- Fix for potential NPE and performance issue Diffs (updated) - agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java 9955051 security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 26080b5 Diff: https://reviews.apache.org/r/57697/diff/2/ Changes: https://reviews.apache.org/r/57697/diff/1-2/ Testing --- Created Ranger service in a local VM and ensured that the default policies are created as expected. Thanks, Abhay Kulkarni
Re: Review Request 57697: Good coding practice recommended by static code analysis
> On March 16, 2017, 5:33 p.m., Colm O hEigeartaigh wrote: > > Why maintain the "ret" variable at all? Why not just "return > > sb.toString().trim();"? Done - Abhay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57697/#review169178 --- On March 16, 2017, 5:22 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57697/ > --- > > (Updated March 16, 2017, 5:22 p.m.) > > > Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. > > > Bugs: RANGER-1463 > https://issues.apache.org/jira/browse/RANGER-1463 > > > Repository: ranger > > > Description > --- > > Fix for potential NPE and performance issue > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java > 9955051 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 26080b5 > > > Diff: https://reviews.apache.org/r/57697/diff/1/ > > > Testing > --- > > Created Ranger service in a local VM and ensured that the default policies > are created as expected. > > > Thanks, > > Abhay Kulkarni > >
[jira] [Created] (RANGER-1464) Support Atlas v2 glossary in Atlas plugin (for access control to terms etc)
Nigel Jones created RANGER-1464: --- Summary: Support Atlas v2 glossary in Atlas plugin (for access control to terms etc) Key: RANGER-1464 URL: https://issues.apache.org/jira/browse/RANGER-1464 Project: Ranger Issue Type: New Feature Components: plugins Reporter: Nigel Jones A v2 glossary is proposed in ATLAS-1410 The atlas ranger plugin should be updated to support access control of the new glossary support once/if this atlas change is completed similarly (or indeed improved over) to the v1 term/taxonomy support. Will add more details as v2 glossary evolves. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Re: Review Request 57697: Good coding practice recommended by static code analysis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57697/#review169178 --- Why maintain the "ret" variable at all? Why not just "return sb.toString().trim();"? - Colm O hEigeartaigh On March 16, 2017, 5:22 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57697/ > --- > > (Updated March 16, 2017, 5:22 p.m.) > > > Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. > > > Bugs: RANGER-1463 > https://issues.apache.org/jira/browse/RANGER-1463 > > > Repository: ranger > > > Description > --- > > Fix for potential NPE and performance issue > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java > 9955051 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 26080b5 > > > Diff: https://reviews.apache.org/r/57697/diff/1/ > > > Testing > --- > > Created Ranger service in a local VM and ensured that the default policies > are created as expected. > > > Thanks, > > Abhay Kulkarni > >
Review Request 57697: Good coding practice recommended by static code analysis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57697/ --- Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. Bugs: RANGER-1463 https://issues.apache.org/jira/browse/RANGER-1463 Repository: ranger Description --- Fix for potential NPE and performance issue Diffs - agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java 9955051 security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 26080b5 Diff: https://reviews.apache.org/r/57697/diff/1/ Testing --- Created Ranger service in a local VM and ensured that the default policies are created as expected. Thanks, Abhay Kulkarni
[jira] [Created] (RANGER-1463) Good coding practices per static code analysis
Abhay Kulkarni created RANGER-1463: -- Summary: Good coding practices per static code analysis Key: RANGER-1463 URL: https://issues.apache.org/jira/browse/RANGER-1463 Project: Ranger Issue Type: Bug Components: Ranger Affects Versions: 0.7.0, 1.0.0 Reporter: Abhay Kulkarni Assignee: Abhay Kulkarni Priority: Minor Fix For: 1.0.0, 0.7.1 Fix potential NPE and performance issue -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (RANGER-1459) Ranger update policy API is failing on Postgres / Oracle for case sensitive ACLs
[
https://issues.apache.org/jira/browse/RANGER-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928387#comment-15928387
]
Gautam Borad commented on RANGER-1459:
--
Committed to ranger-0.7 : a44c04e436caadbe391cad957e9f4d70f66eb51e
Committed to master : f310aaf6bb7b81825ce2886ba4f16c13a09c603a
> Ranger update policy API is failing on Postgres / Oracle for case sensitive
> ACLs
>
>
> Key: RANGER-1459
> URL: https://issues.apache.org/jira/browse/RANGER-1459
> Project: Ranger
> Issue Type: Bug
> Components: admin
>Affects Versions: 0.7.0
>Reporter: Mehul Parikh
>Assignee: Gautam Borad
> Fix For: 0.7.1
>
> Attachments: RANGER-1459.patch
>
>
> When user tries to disable a ranger policy via REST API with postgres DB,
> then it gives this error, it works on MySQL though :
> {code}
> {u'msgDesc': u"Create: is not a valid access-type.
> policy='cl1_hive-87808627-ac26-499a-bea8-e99677a41889' service='cl1_hive'",
> u'statusCode': 1}
> {code}
> Mainly : This is a case sensitive issue on postgres / Oracle for ACLs, need
> to keep it consistent for GET and PUT calls for policies.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Re: Review Request 57650: RANGER-1459 : Ranger update policy API is failing on Postgres / Oracle for case sensitive ACLs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57650/#review169164 --- Ship it! Ship It! - Mehul Parikh On March 15, 2017, 4:45 p.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57650/ > --- > > (Updated March 15, 2017, 4:45 p.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Mehul Parikh, > Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-1459 > https://issues.apache.org/jira/browse/RANGER-1459 > > > Repository: ranger > > > Description > --- > > Currently, GET policy call converts the ACLs to camel case. due to that when > update policy culr command is hit with same acls that GET call gives, then we > get error of invalid access type. > > > Diffs > - > > security-admin/src/main/java/org/apache/ranger/common/AppConstants.java > 7fa2292 > > > Diff: https://reviews.apache.org/r/57650/diff/1/ > > > Testing > --- > > Verified : > > # CRUD Services using UI and Curl commands > > # CRUD Policies using UI and Curl commands > # CRUD of users as well. > > > Thanks, > > Gautam Borad > >
Re: Review Request 57650: RANGER-1459 : Ranger update policy API is failing on Postgres / Oracle for case sensitive ACLs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57650/#review169158 --- Ship it! Ship It! - Velmurugan Periasamy On March 15, 2017, 4:45 p.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57650/ > --- > > (Updated March 15, 2017, 4:45 p.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Mehul Parikh, > Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-1459 > https://issues.apache.org/jira/browse/RANGER-1459 > > > Repository: ranger > > > Description > --- > > Currently, GET policy call converts the ACLs to camel case. due to that when > update policy culr command is hit with same acls that GET call gives, then we > get error of invalid access type. > > > Diffs > - > > security-admin/src/main/java/org/apache/ranger/common/AppConstants.java > 7fa2292 > > > Diff: https://reviews.apache.org/r/57650/diff/1/ > > > Testing > --- > > Verified : > > # CRUD Services using UI and Curl commands > > # CRUD Policies using UI and Curl commands > # CRUD of users as well. > > > Thanks, > > Gautam Borad > >
Re: Review Request 57127: The ranger can be opened when the user enters http://localhost:6080/ in the browser address bar. But request policy from hadoop to ranger will failed after installing hdfs pl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57127/#review169114 --- Ship it! Ship It! - Colm O hEigeartaigh On March 16, 2017, 8:01 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57127/ > --- > > (Updated March 16, 2017, 8:01 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, > Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1415 > https://issues.apache.org/jira/browse/RANGER-1415 > > > Repository: ranger > > > Description > --- > > The ranger can be opened when the user enters http://localhost:6080/ in the > browser address bar. But request policy from hadoop to ranger will failed > after installing hdfs plugin if we set POLICY_MGR_URL equal to > http://localhost:6080/.The error was as following: > 2017-02-27 21:16:42,859 ERROR > org.apache.ranger.admin.client.RangerAdminRESTClient: Error getting policies; > service not found. secureMode=false, user=root (auth:SIMPLE), response=404, > serviceName=hadoopdev, lastKnownVersion=4, > lastActivationTimeInMillis=1488246663112 > 2017-02-27 21:16:42,867 ERROR org.apache.ranger.plugin.util.PolicyRefresher: > PolicyRefresher(serviceName=hadoopdev): failed to find service. Will clean up > local cache of policies (4) > org.apache.ranger.plugin.util.RangerServiceNotFoundException: hadoopdev > at > org.apache.ranger.plugin.util.RangerServiceNotFoundException.throwExceptionIfServiceNotFound(RangerServiceNotFoundException.java:35) > at > org.apache.ranger.admin.client.RangerAdminRESTClient.getServicePoliciesIfUpdated(RangerAdminRESTClient.java:145) > at > org.apache.ranger.plugin.util.PolicyRefresher.loadPolicyfromPolicyAdmin(PolicyRefresher.java:257) > at > org.apache.ranger.plugin.util.PolicyRefresher.loadPolicy(PolicyRefresher.java:201) > at > org.apache.ranger.plugin.util.PolicyRefresher.run(PolicyRefresher.java:170) > Reason: > The brower will remove the last '/' character when the user enters > http://localhost:6080/ in the browser address bar. The rest request address > will be > http://localhost:6080//service/plugins/policies/download/hadoopdev?lastKnownVersion=-1&lastActivationTime=0&pluginId=hdfs@VBoxNodeEng-1-hadoopdev > when hadoop periodically requests policy from ranger. The request will fail > because there are two '/' character after 'Http://localhost:6080' in > http://localhost:6080//service/plugins/policies/download/hadoopdev?lastKnownVersion=-1&lastActivationTime=0&pluginId=hdfs@VBoxNodeEng-1-hadoopdev. > The result is that we can't see the hdfs plugins in audit web UI. > > The program should be compatible with this situation like the browser. > > Scenario: > The issue can be reoccurred after we set the value of > ranger.plugin.hdfs.policy.rest.url to http://localhost:6080/ in > ../hadoop/hadoop-2.7.3/etc/hadoop/ranger-hdfs-security.xml > > Test and verify: > I carefully tested and verified the patch before commit the issue. > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java > 9334607 > > > Diff: https://reviews.apache.org/r/57127/diff/8/ > > > Testing > --- > > > Thanks, > > Qiang Zhang > >
Re: Review Request 57677: The printing error of callback in ConsolePromptCallbackHandler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57677/#review169112 --- Ship it! Ship It! - Colm O hEigeartaigh On March 16, 2017, 7:21 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57677/ > --- > > (Updated March 16, 2017, 7:21 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1461 > https://issues.apache.org/jira/browse/RANGER-1461 > > > Repository: ranger > > > Description > --- > > The printing error of callback classname (both NameCallback and > PasswordCallback are Callback classs ) in ConsolePromptCallbackHandler.java > > > Diffs > - > > > unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/ConsolePromptCallbackHandler.java > 31e6ddb > > > Diff: https://reviews.apache.org/r/57677/diff/1/ > > > Testing > --- > > tested it > > > Thanks, > > Qiang Zhang > >
Re: Review Request 57634: RANGER-1456:Fix the spelling error in HDFS plugin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57634/#review169111
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 16, 2017, 1:45 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57634/
> ---
>
> (Updated March 16, 2017, 1:45 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
> Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1456
> https://issues.apache.org/jira/browse/RANGER-1456
>
>
> Repository: ranger
>
>
> Description
> ---
>
> LOG.error("Serice not found with name "+serviceName, new Throwable());
> It should be 'service' instead of 'serice'.
>
>
> Diffs
> -
>
>
> hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsConnectionMgr.java
> e1985c0
>
>
> Diff: https://reviews.apache.org/r/57634/diff/2/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 57679: RANGER-1462:Fix the spelling error in Solr Authorization
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57679/#review169110
---
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 16, 2017, 8:43 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57679/
> ---
>
> (Updated March 16, 2017, 8:43 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
> Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1462
> https://issues.apache.org/jira/browse/RANGER-1462
>
>
> Repository: ranger
>
>
> Description
> ---
>
> logger.fatal("Can't create RangerRequest oject. userName="
> + userName + ", accessType=" + accessType + ",
> ip=" + ip
> + ", collectionRequest=" + collectionRequest);
> It should be 'object' instead of 'oject'.
>
>
> Diffs
> -
>
>
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
> 6ac0a1f
>
>
> Diff: https://reviews.apache.org/r/57679/diff/1/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Qiang Zhang
>
>
Review Request 57679: RANGER-1462:Fix the spelling error in Solr Authorization
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57679/
---
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1462
https://issues.apache.org/jira/browse/RANGER-1462
Repository: ranger
Description
---
logger.fatal("Can't create RangerRequest oject. userName="
+ userName + ", accessType=" + accessType + ",
ip=" + ip
+ ", collectionRequest=" + collectionRequest);
It should be 'object' instead of 'oject'.
Diffs
-
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
6ac0a1f
Diff: https://reviews.apache.org/r/57679/diff/1/
Testing
---
Thanks,
Qiang Zhang
[jira] [Created] (RANGER-1462) Fix the spelling error in Solr Authorization
Qiang Zhang created RANGER-1462:
---
Summary: Fix the spelling error in Solr Authorization
Key: RANGER-1462
URL: https://issues.apache.org/jira/browse/RANGER-1462
Project: Ranger
Issue Type: Bug
Components: plugins
Affects Versions: 1.0.0
Reporter: Qiang Zhang
Assignee: Qiang Zhang
Fix For: 1.0.0
{code}
logger.fatal("Can't create RangerRequest oject. userName="
+ userName + ", accessType=" + accessType + ",
ip=" + ip
+ ", collectionRequest=" + collectionRequest);
{code}
It should be 'object' instead of 'oject'.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Re: Review Request 57127: The ranger can be opened when the user enters http://localhost:6080/ in the browser address bar. But request policy from hadoop to ranger will failed after installing hdfs pl
> On 三月 15, 2017, 10:33 a.m., Colm O hEigeartaigh wrote: > > Almost there...please put a space before the opening curly brackets in both > > if statements. Also, please make sure the "=" sign is aligned for the > > "String url..." and "String tmpUrl..." statements. It is offset by one tab > > from the following statements. Ok. In above patch I specifically adjusted the code format according to diff result to avoid question. In the patch I reformatted the code and updated the patch. Thanks. - Qiang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57127/#review168985 --- On 三月 16, 2017, 8:01 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57127/ > --- > > (Updated 三月 16, 2017, 8:01 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, > Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1415 > https://issues.apache.org/jira/browse/RANGER-1415 > > > Repository: ranger > > > Description > --- > > The ranger can be opened when the user enters http://localhost:6080/ in the > browser address bar. But request policy from hadoop to ranger will failed > after installing hdfs plugin if we set POLICY_MGR_URL equal to > http://localhost:6080/.The error was as following: > 2017-02-27 21:16:42,859 ERROR > org.apache.ranger.admin.client.RangerAdminRESTClient: Error getting policies; > service not found. secureMode=false, user=root (auth:SIMPLE), response=404, > serviceName=hadoopdev, lastKnownVersion=4, > lastActivationTimeInMillis=1488246663112 > 2017-02-27 21:16:42,867 ERROR org.apache.ranger.plugin.util.PolicyRefresher: > PolicyRefresher(serviceName=hadoopdev): failed to find service. Will clean up > local cache of policies (4) > org.apache.ranger.plugin.util.RangerServiceNotFoundException: hadoopdev > at > org.apache.ranger.plugin.util.RangerServiceNotFoundException.throwExceptionIfServiceNotFound(RangerServiceNotFoundException.java:35) > at > org.apache.ranger.admin.client.RangerAdminRESTClient.getServicePoliciesIfUpdated(RangerAdminRESTClient.java:145) > at > org.apache.ranger.plugin.util.PolicyRefresher.loadPolicyfromPolicyAdmin(PolicyRefresher.java:257) > at > org.apache.ranger.plugin.util.PolicyRefresher.loadPolicy(PolicyRefresher.java:201) > at > org.apache.ranger.plugin.util.PolicyRefresher.run(PolicyRefresher.java:170) > Reason: > The brower will remove the last '/' character when the user enters > http://localhost:6080/ in the browser address bar. The rest request address > will be > http://localhost:6080//service/plugins/policies/download/hadoopdev?lastKnownVersion=-1&lastActivationTime=0&pluginId=hdfs@VBoxNodeEng-1-hadoopdev > when hadoop periodically requests policy from ranger. The request will fail > because there are two '/' character after 'Http://localhost:6080' in > http://localhost:6080//service/plugins/policies/download/hadoopdev?lastKnownVersion=-1&lastActivationTime=0&pluginId=hdfs@VBoxNodeEng-1-hadoopdev. > The result is that we can't see the hdfs plugins in audit web UI. > > The program should be compatible with this situation like the browser. > > Scenario: > The issue can be reoccurred after we set the value of > ranger.plugin.hdfs.policy.rest.url to http://localhost:6080/ in > ../hadoop/hadoop-2.7.3/etc/hadoop/ranger-hdfs-security.xml > > Test and verify: > I carefully tested and verified the patch before commit the issue. > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java > 9334607 > > > Diff: https://reviews.apache.org/r/57127/diff/8/ > > > Testing > --- > > > Thanks, > > Qiang Zhang > >
Re: Review Request 57584: RANGER-1449:There is logical inconsistency for RANGER_PID_DIR_PATH in security admin
> On 三月 14, 2017, 12:56 p.m., Colm O hEigeartaigh wrote:
> > Looks good in general, however I think it would be a good idea to preserve
> > the "if [ ! $? = "0" ];then" statement, but move it after "mkdir -p
> > ${RANGER_PID_DIR_PATH}" on line 1369.
Ok. Thanks.
- pengjianhua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57584/#review168893
---
On 三月 14, 2017, 3:37 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57584/
> ---
>
> (Updated 三月 14, 2017, 3:37 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1449
> https://issues.apache.org/jira/browse/RANGER-1449
>
>
> Repository: ranger
>
>
> Description
> ---
>
> 1. There is RANGER_PID_DIR_PATH parameter in install.properties. But There is
> hard code at the begin of setup.sh
> pidFolderName='/var/run/ranger'
> mkdir -p $
> {pidFolderName}
>
> if [ ! $? = "0" ];then
> log "Make $pidFolderName failure!!";
> exit 1;
> fi
> 2. The ranger-admin-services.sh will set default value and create default
> path when the RANGER_PID_DIR_PATH parameter is empty. The setup.sh doesn't
> set default value and create default path.
>
>
> Diffs
> -
>
> security-admin/scripts/setup.sh 87be127
>
>
> Diff: https://reviews.apache.org/r/57584/diff/1/
>
>
> Testing
> ---
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 57127: The ranger can be opened when the user enters http://localhost:6080/ in the browser address bar. But request policy from hadoop to ranger will failed after installing hdfs pl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57127/ --- (Updated March 16, 2017, 8:01 a.m.) Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. Bugs: RANGER-1415 https://issues.apache.org/jira/browse/RANGER-1415 Repository: ranger Description --- The ranger can be opened when the user enters http://localhost:6080/ in the browser address bar. But request policy from hadoop to ranger will failed after installing hdfs plugin if we set POLICY_MGR_URL equal to http://localhost:6080/.The error was as following: 2017-02-27 21:16:42,859 ERROR org.apache.ranger.admin.client.RangerAdminRESTClient: Error getting policies; service not found. secureMode=false, user=root (auth:SIMPLE), response=404, serviceName=hadoopdev, lastKnownVersion=4, lastActivationTimeInMillis=1488246663112 2017-02-27 21:16:42,867 ERROR org.apache.ranger.plugin.util.PolicyRefresher: PolicyRefresher(serviceName=hadoopdev): failed to find service. Will clean up local cache of policies (4) org.apache.ranger.plugin.util.RangerServiceNotFoundException: hadoopdev at org.apache.ranger.plugin.util.RangerServiceNotFoundException.throwExceptionIfServiceNotFound(RangerServiceNotFoundException.java:35) at org.apache.ranger.admin.client.RangerAdminRESTClient.getServicePoliciesIfUpdated(RangerAdminRESTClient.java:145) at org.apache.ranger.plugin.util.PolicyRefresher.loadPolicyfromPolicyAdmin(PolicyRefresher.java:257) at org.apache.ranger.plugin.util.PolicyRefresher.loadPolicy(PolicyRefresher.java:201) at org.apache.ranger.plugin.util.PolicyRefresher.run(PolicyRefresher.java:170) Reason: The brower will remove the last '/' character when the user enters http://localhost:6080/ in the browser address bar. The rest request address will be http://localhost:6080//service/plugins/policies/download/hadoopdev?lastKnownVersion=-1&lastActivationTime=0&pluginId=hdfs@VBoxNodeEng-1-hadoopdev when hadoop periodically requests policy from ranger. The request will fail because there are two '/' character after 'Http://localhost:6080' in http://localhost:6080//service/plugins/policies/download/hadoopdev?lastKnownVersion=-1&lastActivationTime=0&pluginId=hdfs@VBoxNodeEng-1-hadoopdev. The result is that we can't see the hdfs plugins in audit web UI. The program should be compatible with this situation like the browser. Scenario: The issue can be reoccurred after we set the value of ranger.plugin.hdfs.policy.rest.url to http://localhost:6080/ in ../hadoop/hadoop-2.7.3/etc/hadoop/ranger-hdfs-security.xml Test and verify: I carefully tested and verified the patch before commit the issue. Diffs (updated) - agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java 9334607 Diff: https://reviews.apache.org/r/57127/diff/8/ Changes: https://reviews.apache.org/r/57127/diff/7-8/ Testing --- Thanks, Qiang Zhang
[jira] [Updated] (RANGER-1461) The printing error of callback in ConsolePromptCallbackHandler
[ https://issues.apache.org/jira/browse/RANGER-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1461: Affects Version/s: 1.0.0 > The printing error of callback in ConsolePromptCallbackHandler > -- > > Key: RANGER-1461 > URL: https://issues.apache.org/jira/browse/RANGER-1461 > Project: Ranger > Issue Type: Bug > Components: usersync >Affects Versions: 1.0.0 >Reporter: Qiang Zhang >Assignee: Qiang Zhang >Priority: Minor > Attachments: > 0001-RANGER-1461-The-printing-error-of-callback-in-Consol.patch > > > The printing error of callback in ConsolePromptCallbackHandler.java -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Review Request 57677: The printing error of callback in ConsolePromptCallbackHandler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57677/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. Bugs: RANGER-1461 https://issues.apache.org/jira/browse/RANGER-1461 Repository: ranger Description --- The printing error of callback classname (both NameCallback and PasswordCallback are Callback classs ) in ConsolePromptCallbackHandler.java Diffs - unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/ConsolePromptCallbackHandler.java 31e6ddb Diff: https://reviews.apache.org/r/57677/diff/1/ Testing --- tested it Thanks, Qiang Zhang
[jira] [Updated] (RANGER-1461) The printing error of callback in ConsolePromptCallbackHandler
[ https://issues.apache.org/jira/browse/RANGER-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang updated RANGER-1461: Attachment: 0001-RANGER-1461-The-printing-error-of-callback-in-Consol.patch > The printing error of callback in ConsolePromptCallbackHandler > -- > > Key: RANGER-1461 > URL: https://issues.apache.org/jira/browse/RANGER-1461 > Project: Ranger > Issue Type: Bug > Components: usersync >Reporter: Qiang Zhang >Assignee: Qiang Zhang >Priority: Minor > Attachments: > 0001-RANGER-1461-The-printing-error-of-callback-in-Consol.patch > > > The printing error of callback in ConsolePromptCallbackHandler.java -- This message was sent by Atlassian JIRA (v6.3.15#6346)
