Review Request 68226: SENTRY-2320 Refactor existing Sentry CLIs to use jcommander instead of commons-cli

2018-08-06 Thread Anthony Young-Garner via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68226/
---

Review request for sentry, Na Li, Steve Moist, and Sergio Pena.


Bugs: SENTRY-2320
https://issues.apache.org/jira/browse/SENTRY-2320


Repository: sentry


Description
---

Update of existing Sentry CLIs to use jcommander dependency rather than 
commons-cli in order to provider for a more full featured base on which to 
build new Sentry commands, in particular the proposed commands for Attribute 
Based Column Masking (see SENTRY-2227).


Diffs
-

  sentry-tools/pom.xml 05cd75c9c96b7940b759423f3c27a4bb0657001d 
  
sentry-tools/src/main/java/org/apache/sentry/cli/tools/PermissionsMigrationToolCommon.java
 bf108f4cc1d7b8949f562418e428750abf580961 
  
sentry-tools/src/main/java/org/apache/sentry/cli/tools/SentryConfigToolCommon.java
 2d4f9737062be33a224a6d25762b264b0314f710 
  
sentry-tools/src/main/java/org/apache/sentry/cli/tools/SentryConfigToolIndexer.java
 896e8530bc1311a452aeecb92a41bf4a0fa38749 
  sentry-tools/src/main/java/org/apache/sentry/cli/tools/SentrySchemaTool.java 
4c3df208de9a5d4f973061579e629b2b39f2162e 
  sentry-tools/src/main/java/org/apache/sentry/cli/tools/SentryShellCommon.java 
94800a4c512384e68de25d021fbb10c13d24ef7d 
  
sentry-tools/src/main/java/org/apache/sentry/cli/tools/SentryShellIndexer.java 
95ae0b4ecf447f847b00ef8a49e50c9e6f64a157 
  
sentry-tools/src/test/java/org/apache/sentry/cli/tools/TestPermissionsMigrationToolSolr.java
 9001a535629644946c75260ab0ec1ecd5e656ff9 
  
sentry-tools/src/test/java/org/apache/sentry/cli/tools/TestSentryShellIndexer.java
 082987df25dea8c68afb1e97f8ea032e05374475 
  
sentry-tools/src/test/java/org/apache/sentry/cli/tools/TestSentryShellKafka.java
 9a7b6f9c24e0f555a927a1fe4971edd0b1dc9aee 
  
sentry-tools/src/test/java/org/apache/sentry/cli/tools/TestSentryShellSolr.java 
b583e1b8233961e02476df11bc67b71e7fa20a34 
  
sentry-tools/src/test/java/org/apache/sentry/cli/tools/TestSentryShellSqoop.java
 1a0e0a1229773e2e6226eb388efa1f0f0c3a82ef 


Diff: https://reviews.apache.org/r/68226/diff/1/


Testing
---

mvn clean install (with particular focus on passage of existing CLI usage 
tests).


Thanks,

Anthony Young-Garner

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

2018-05-25 Thread Anthony Young-Garner via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/
---

(Updated May 25, 2018, 1:59 p.m.)


Review request for sentry.


Changes
---

Rebased patch on master.


Bugs: SENTRY-2208
https://issues.apache.org/jira/browse/SENTRY-2208


Repository: sentry


Description
---

Refactored the SentryService class and its dependencies from 
sentry-provider/sentry-provider-db into a new 
sentry-service/sentry-service-server module. In addition, refactored 
SentryServiceClientFactory into a new sentry-service/sentry-service-client 
module.

Work is based on previously completed work on SENTRY-1205.

NOTE: The diff looks large, but the overwhelming majority (9 pages) of the diff 
consists of file moves (from sentry-provider-db to sentry-service-server)

https://issues.apache.org/jira/browse/SENTRY-2208


Diffs (updated)
-

  sentry-hdfs/sentry-hdfs-service/pom.xml 
50a451d917eb7428cd71ab7cedd9c4363111c166 
  sentry-provider/sentry-provider-db/pom.xml 
48a187ae54afd435c1f3d4aa57b0d696cd634fbe 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
 876ee146ab31aaa82b83e88585c45bb2deabc0d2 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/TSentryPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provi

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

2018-05-21 Thread Anthony Young-Garner via Review Board 


> On May 21, 2018, 3:31 p.m., Na Li wrote:
> > sentry-hdfs/sentry-hdfs-service/pom.xml
> > Line 108 (original), 109 (patched)
> > 
> >
> > You have the same dependency at link 76. Do you need to declare it 
> > again?

Yes, the test-jar in test scope and the full dependency in default scope are 
both needed.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/#review203498
---


On May 21, 2018, 4:46 p.m., Anthony Young-Garner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67093/
> ---
> 
> (Updated May 21, 2018, 4:46 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-2208
> https://issues.apache.org/jira/browse/SENTRY-2208
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Refactored the SentryService class and its dependencies from 
> sentry-provider/sentry-provider-db into a new 
> sentry-service/sentry-service-server module. In addition, refactored 
> SentryServiceClientFactory into a new sentry-service/sentry-service-client 
> module.
> 
> Work is based on previously completed work on SENTRY-1205.
> 
> NOTE: The diff looks large, but the overwhelming majority (9 pages) of the 
> diff consists of file moves (from sentry-provider-db to sentry-service-server)
> 
> https://issues.apache.org/jira/browse/SENTRY-2208
> 
> 
> Diffs
> -
> 
>   sentry-hdfs/sentry-hdfs-service/pom.xml 
> 50a451d917eb7428cd71ab7cedd9c4363111c166 
>   sentry-provider/sentry-provider-db/pom.xml 
> 48a187ae54afd435c1f3d4aa57b0d696cd634fbe 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
>  876ee146ab31aaa82b83e88585c45bb2deabc0d2 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/TSentryPrivilegeConverter.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java
>   
>   
> sentry-provider/sentry-provider-db/sr

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

2018-05-21 Thread Anthony Young-Garner via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/
---

(Updated May 21, 2018, 4:46 p.m.)


Review request for sentry.


Changes
---

Added patch 007 to include some missing (not staged for commit) changes.


Bugs: SENTRY-2208
https://issues.apache.org/jira/browse/SENTRY-2208


Repository: sentry


Description
---

Refactored the SentryService class and its dependencies from 
sentry-provider/sentry-provider-db into a new 
sentry-service/sentry-service-server module. In addition, refactored 
SentryServiceClientFactory into a new sentry-service/sentry-service-client 
module.

Work is based on previously completed work on SENTRY-1205.

NOTE: The diff looks large, but the overwhelming majority (9 pages) of the diff 
consists of file moves (from sentry-provider-db to sentry-service-server)

https://issues.apache.org/jira/browse/SENTRY-2208


Diffs (updated)
-

  sentry-hdfs/sentry-hdfs-service/pom.xml 
50a451d917eb7428cd71ab7cedd9c4363111c166 
  sentry-provider/sentry-provider-db/pom.xml 
48a187ae54afd435c1f3d4aa57b0d696cd634fbe 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
 876ee146ab31aaa82b83e88585c45bb2deabc0d2 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/TSentryPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java
  
  
sentry-provider/sentry-p

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

2018-05-21 Thread Anthony Young-Garner via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/
---

(Updated May 21, 2018, 4:41 p.m.)


Review request for sentry.


Changes
---

Added patch 006 because some *.sql files in 
sentry-provider-db/src/main/resources were clobbered in the patch.


Bugs: SENTRY-2208
https://issues.apache.org/jira/browse/SENTRY-2208


Repository: sentry


Description
---

Refactored the SentryService class and its dependencies from 
sentry-provider/sentry-provider-db into a new 
sentry-service/sentry-service-server module. In addition, refactored 
SentryServiceClientFactory into a new sentry-service/sentry-service-client 
module.

Work is based on previously completed work on SENTRY-1205.

NOTE: The diff looks large, but the overwhelming majority (9 pages) of the diff 
consists of file moves (from sentry-provider-db to sentry-service-server)

https://issues.apache.org/jira/browse/SENTRY-2208


Diffs (updated)
-

  sentry-service/pom.xml 0388476f2e55dbc76262a4b0ddb597b816d8fb15 
  sentry-service/sentry-service-client/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-client/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java
 PRE-CREATION 
  sentry-service/sentry-service-server/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/tools/TSentryPrivilegeConverter.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntity

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

2018-05-21 Thread Anthony Young-Garner via Review Board 


> On May 17, 2018, 7:20 p.m., Steve Moist wrote:
> > Can't we tease apart that database models and possibly JPA layer stuff back 
> > into sentry-provider-db then have sentry-service-server depend on that?

There isn't a way to move any of the packages back to sentry-provider-db 
without introducing a circular dependency between sentry-provider-db and 
sentry-service-server. Some classes (e.g. MSentryPrivilege) in 
org.apache.sentry.provider.db.service.model package depend on classes (e.g. 
SentryStore) in the org.apache.sentry.provider.db.service.persistent package in 
the sentry-service-server module. While some classes in the 
org.apache.sentry.provider.db.service.persistent package depend on classes in 
both the org.apache.sentry.service.thrift and 
org.apache.sentry.provider.db.service.model packages. (Examples: HMSFollower 
depends on SentryStateBank. HAContext depends on JAASConfiguration and 
SentryStore depends on MSentryHmsNotification).


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/#review203363
---


On May 21, 2018, 3:01 p.m., Anthony Young-Garner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67093/
> ---
> 
> (Updated May 21, 2018, 3:01 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-2208
> https://issues.apache.org/jira/browse/SENTRY-2208
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Refactored the SentryService class and its dependencies from 
> sentry-provider/sentry-provider-db into a new 
> sentry-service/sentry-service-server module. In addition, refactored 
> SentryServiceClientFactory into a new sentry-service/sentry-service-client 
> module.
> 
> Work is based on previously completed work on SENTRY-1205.
> 
> NOTE: The diff looks large, but the overwhelming majority (9 pages) of the 
> diff consists of file moves (from sentry-provider-db to sentry-service-server)
> 
> https://issues.apache.org/jira/browse/SENTRY-2208
> 
> 
> Diffs
> -
> 
>   sentry-hdfs/sentry-hdfs-service/pom.xml 
> 50a451d917eb7428cd71ab7cedd9c4363111c166 
>   sentry-provider/sentry-provider-db/pom.xml 
> 48a187ae54afd435c1f3d4aa57b0d696cd634fbe 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
>  876ee146ab31aaa82b83e88585c45bb2deabc0d2 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
>   
>   
> sentry

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

2018-05-21 Thread Anthony Young-Garner via Review Board 


> On May 17, 2018, 7:09 p.m., Steve Moist wrote:
> > sentry-tests/sentry-tests-solr/pom.xml
> > Lines 65 (patched)
> > 
> >
> > Why is this all included.

The existing logic in the POM excluded these dependencies. I'm just trying to 
maintain the behavior.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/#review203362
---


On May 21, 2018, 3:01 p.m., Anthony Young-Garner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67093/
> ---
> 
> (Updated May 21, 2018, 3:01 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-2208
> https://issues.apache.org/jira/browse/SENTRY-2208
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Refactored the SentryService class and its dependencies from 
> sentry-provider/sentry-provider-db into a new 
> sentry-service/sentry-service-server module. In addition, refactored 
> SentryServiceClientFactory into a new sentry-service/sentry-service-client 
> module.
> 
> Work is based on previously completed work on SENTRY-1205.
> 
> NOTE: The diff looks large, but the overwhelming majority (9 pages) of the 
> diff consists of file moves (from sentry-provider-db to sentry-service-server)
> 
> https://issues.apache.org/jira/browse/SENTRY-2208
> 
> 
> Diffs
> -
> 
>   sentry-hdfs/sentry-hdfs-service/pom.xml 
> 50a451d917eb7428cd71ab7cedd9c4363111c166 
>   sentry-provider/sentry-provider-db/pom.xml 
> 48a187ae54afd435c1f3d4aa57b0d696cd634fbe 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
>  876ee146ab31aaa82b83e88585c45bb2deabc0d2 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/TSentryPrivilegeConverter.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java
>   
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/D

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

2018-05-21 Thread Anthony Young-Garner via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/
---

(Updated May 21, 2018, 3:01 p.m.)


Review request for sentry.


Changes
---

Made changes suggested in review.


Bugs: SENTRY-2208
https://issues.apache.org/jira/browse/SENTRY-2208


Repository: sentry


Description
---

Refactored the SentryService class and its dependencies from 
sentry-provider/sentry-provider-db into a new 
sentry-service/sentry-service-server module. In addition, refactored 
SentryServiceClientFactory into a new sentry-service/sentry-service-client 
module.

Work is based on previously completed work on SENTRY-1205.

NOTE: The diff looks large, but the overwhelming majority (9 pages) of the diff 
consists of file moves (from sentry-provider-db to sentry-service-server)

https://issues.apache.org/jira/browse/SENTRY-2208


Diffs (updated)
-

  sentry-hdfs/sentry-hdfs-service/pom.xml 
50a451d917eb7428cd71ab7cedd9c4363111c166 
  sentry-provider/sentry-provider-db/pom.xml 
48a187ae54afd435c1f3d4aa57b0d696cd634fbe 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
 876ee146ab31aaa82b83e88585c45bb2deabc0d2 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/TSentryPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sen

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

2018-05-15 Thread Anthony Young-Garner via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/
---

(Updated May 15, 2018, 6:47 p.m.)


Review request for sentry.


Changes
---

Removed sentry-dist/src/license/THIRD-PARTY.properties from patch.


Bugs: SENTRY-2208
https://issues.apache.org/jira/browse/SENTRY-2208


Repository: sentry


Description
---

Refactored the SentryService class and its dependencies from 
sentry-provider/sentry-provider-db into a new 
sentry-service/sentry-service-server module. In addition, refactored 
SentryServiceClientFactory into a new sentry-service/sentry-service-client 
module.

Work is based on previously completed work on SENTRY-1205.

NOTE: The diff looks large, but the overwhelming majority (9 pages) of the diff 
consists of file moves (from sentry-provider-db to sentry-service-server)

https://issues.apache.org/jira/browse/SENTRY-2208


Diffs (updated)
-

  sentry-hdfs/sentry-hdfs-service/pom.xml 
50a451d917eb7428cd71ab7cedd9c4363111c166 
  sentry-provider/sentry-provider-db/pom.xml 
48a187ae54afd435c1f3d4aa57b0d696cd634fbe 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
 876ee146ab31aaa82b83e88585c45bb2deabc0d2 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/TSentryPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java
  
  
sentry-provider/sentry-provide

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

2018-05-15 Thread Anthony Young-Garner via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/
---

(Updated May 15, 2018, 6:38 p.m.)


Review request for sentry.


Changes
---

Provided more detailed description.


Bugs: SENTRY-2208
https://issues.apache.org/jira/browse/SENTRY-2208


Repository: sentry


Description (updated)
---

Refactored the SentryService class and its dependencies from 
sentry-provider/sentry-provider-db into a new 
sentry-service/sentry-service-server module. In addition, refactored 
SentryServiceClientFactory into a new sentry-service/sentry-service-client 
module.

Work is based on previously completed work on SENTRY-1205.

NOTE: The diff looks large, but the overwhelming majority (9 pages) of the diff 
consists of file moves (from sentry-provider-db to sentry-service-server)

https://issues.apache.org/jira/browse/SENTRY-2208


Diffs
-

  sentry-dist/src/license/THIRD-PARTY.properties 
b39e1b6ca7eba8c6a7695a4238104af7cd50da32 
  sentry-hdfs/sentry-hdfs-service/pom.xml 
50a451d917eb7428cd71ab7cedd9c4363111c166 
  sentry-provider/sentry-provider-db/pom.xml 
48a187ae54afd435c1f3d4aa57b0d696cd634fbe 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
 876ee146ab31aaa82b83e88585c45bb2deabc0d2 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/TSentryPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

2018-05-15 Thread Anthony Young-Garner via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/
---

(Updated May 15, 2018, 1:21 p.m.)


Review request for sentry.


Changes
---

Rebased on master.


Bugs: SENTRY-2208
https://issues.apache.org/jira/browse/SENTRY-2208


Repository: sentry


Description
---

Refactored the SentryService class and its dependencies from 
sentry-provider/sentry-provider-db into a new 
sentry-service/sentry-service-server module. In addition, refactored 
SentryServiceClientFactory into a new sentry-service/sentry-service-client 
module.

Work is based on previously completed work on SENTRY-1205.

https://issues.apache.org/jira/browse/SENTRY-2208


Diffs (updated)
-

  sentry-dist/src/license/THIRD-PARTY.properties 
b39e1b6ca7eba8c6a7695a4238104af7cd50da32 
  sentry-hdfs/sentry-hdfs-service/pom.xml 
50a451d917eb7428cd71ab7cedd9c4363111c166 
  sentry-provider/sentry-provider-db/pom.xml 
48a187ae54afd435c1f3d4aa57b0d696cd634fbe 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
 876ee146ab31aaa82b83e88585c45bb2deabc0d2 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/TSentryPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsSnapshotId.java
  
  
sentry-provider/

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

2018-05-14 Thread Anthony Young-Garner via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/
---

(Updated May 14, 2018, 4 p.m.)


Review request for sentry.


Changes
---

Rebased on master. Verified tests pass on mvn clean install.


Bugs: SENTRY-2208
https://issues.apache.org/jira/browse/SENTRY-2208


Repository: sentry


Description
---

Refactored the SentryService class and its dependencies from 
sentry-provider/sentry-provider-db into a new 
sentry-service/sentry-service-server module. In addition, refactored 
SentryServiceClientFactory into a new sentry-service/sentry-service-client 
module.

Work is based on previously completed work on SENTRY-1205.

https://issues.apache.org/jira/browse/SENTRY-2208


Diffs (updated)
-

  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java
 ffa193f031fe75bfe1273fb9184fee42e8d647e5 
  
sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/AccessConstants.java
 a8e8bb1543041d356767818d25d7c7cb32cd909b 
  sentry-dist/src/license/THIRD-PARTY.properties 
b39e1b6ca7eba8c6a7695a4238104af7cd50da32 
  sentry-hdfs/sentry-hdfs-service/pom.xml 
50a451d917eb7428cd71ab7cedd9c4363111c166 
  sentry-provider/sentry-provider-db/pom.xml 
48a187ae54afd435c1f3d4aa57b0d696cd634fbe 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
 876ee146ab31aaa82b83e88585c45bb2deabc0d2 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/TSentryPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java
  
  
sentry-provider/sentry-provid

Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

2018-05-11 Thread Anthony Young-Garner via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67093/
---

Review request for sentry.


Bugs: SENTRY-2208
https://issues.apache.org/jira/browse/SENTRY-2208


Repository: sentry


Description
---

Refactored the SentryService class and its dependencies from 
sentry-provider/sentry-provider-db into a new 
sentry-service/sentry-service-server module. In addition, refactored 
SentryServiceClientFactory into a new sentry-service/sentry-service-client 
module.

Work is based on previously completed work on SENTRY-1205.

https://issues.apache.org/jira/browse/SENTRY-2208


Diffs
-

  sentry-hdfs/sentry-hdfs-service/pom.xml 
50a451d917eb7428cd71ab7cedd9c4363111c166 
  sentry-provider/sentry-provider-db/pom.xml 
48a187ae54afd435c1f3d4aa57b0d696cd634fbe 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/generic/thrift/SentryGenericPolicyProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryHealthCheckServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryMetricsServletContextListener.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java
 876ee146ab31aaa82b83e88585c45bb2deabc0d2 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/TSentryPrivilegeConverter.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/AuditLoggerTestAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/DBAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/GMAuditMetadataLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntity.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/JsonLogEntityFactory.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/CommandUtil.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsSnapshotId.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MPath.java
  
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/ser

Re: Review Request 66888: SENTRY-2206 Refactor out sentry api from sentry-provider-db to own module

2018-05-08 Thread Anthony Young-Garner via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66888/#review202669
---



The diff is much less forbidding than it may look based on size. The 
overwhelming majority of the changes are package name changes, moves of class 
from one module to another, and/or updates to autogenerated thrift code. With 
those changes, I think other reviewers can just say whether they agree with the 
new package names or not rather than commenting on each specific name change. 

Other than that, reviewers may want to note the new classes that aren't just 
name changes (there are only a few). Also, I've pointed out a few specific 
changes (see below) that reviewers with more experience on the project may want 
to consider more closely.

I've rebased on this diff locally and built my changes for SENTRY-2208 based 
upon it and run all unit tests.


sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java
Line 277 (original), 279 (patched)


Changing the visibility of this method is a notable change worth pointing 
out to the other reviewers.



sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
Lines 186 (patched)


Point folks in the reviews and/or on the mailing list to these changes and 
make sure there are no unintended consequences to removing these variables 
(SENTRY_REPORTER_JMX and SENTRY_REPORTER_CONSOLE).



sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/common/ThriftConstants.java
Lines 27 (patched)


Just a thought about the rename/move of constant classes: are we sure that 
no external code in other projects uses these classes? If so, doesn't mean we 
can't change them, but we need to communicate the change.

I'm guessing based on the other work (e.g. SENTRY-1205) that this isn't a 
problem but at least we should consider it.


- Anthony Young-Garner


On May 1, 2018, 7:50 p.m., Steve Moist wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66888/
> ---
> 
> (Updated May 1, 2018, 7:50 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Mainly refactored classes around to new module 
> sentry-service/sentry-service-api.  The ServiceConstants were refactored into 
> sentry-core-common as it introduced circular dependencies.  ApiConstants was 
> created to split out from ServiceConstants for the API.  A few class 
> constants were added into ApiConstants due to circular dependencies.
> 
> https://issues.apache.org/jira/browse/SENTRY-2206
> 
> 
> Diffs
> -
> 
>   pom.xml 262a9d8f 
>   
> sentry-binding/sentry-binding-hbase-indexer/src/main/java/org/apache/sentry/binding/hbaseindexer/authz/HBaseIndexerAuthzBinding.java
>  71d12253 
>   
> sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java
>  7565a34b 
>   
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java
>  1dc8f016 
>   
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java
>  13ee2cfd 
>   
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/metastore/SentryMetastorePostEventListenerBaseV2.java
>  567e9fa6 
>   
> sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/util/SentryAuthorizerUtil.java
>  35bd68ce 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java
>  21a6abf8 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java
>  3ac49fa6 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java
>  c23547a9 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java
>  24d77634 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/util/SentryAuthorizerUtil.java
>  1c416393 
>   
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/metastore/TestSentrySyncHMSNotificationsPostEventListener.java
>  cca326b3 
>   
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java
>  e4abdc71 
>   
> sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/s

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

2018-04-25 Thread Anthony Young-Garner via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66787/#review201928
---




dev-support/smart-apply-patch.sh
Line 33 (original), 32 (patched)


Will we not continue to support stdin patches? I think it can still be 
achieved with git.



dev-support/smart-apply-patch.sh
Line 44 (original)


Do we not still want to detect this situation (only new files) and try 
applying the patch at levels 0,1,2? (Lines 44 - 85)


- Anthony Young-Garner


On April 24, 2018, 9:18 p.m., Steve Moist wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66787/
> ---
> 
> (Updated April 24, 2018, 9:18 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Removed using the patch command and instead am using "git apply" for diffs.
> 
> 
> Diffs
> -
> 
>   dev-support/smart-apply-patch.sh fce27354 
> 
> 
> Diff: https://reviews.apache.org/r/66787/diff/1/
> 
> 
> Testing
> ---
> 
> Used it to apply a patch, then tested with apply a patch with conflicts, 
> doing a dry-run.  Also tested with rename/moves.
> 
> 
> Thanks,
> 
> Steve Moist
> 
>

Re: Review Request 66590: SENTRY-2201 Initial Attriubte based access control

2018-04-13 Thread Anthony Young-Garner via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66590/#review201127
---




sentry-abac/example-delta.json
Lines 1 (patched)


A file-based representation of deltas/changes may not be necessary. It is a 
simpler workflow for the user to edit the original file (e.g. 
example-definition.json) rather than provide explicit delta files. The server 
can detect changes to this file and update ingested attributes as appropriate.



sentry-abac/notes.txt
Lines 19 (patched)


Lines 19 - 20 can be removed if the example-delta.json file is removed.



sentry-abac/pom.xml
Lines 25 (patched)


Should the project version be parameterized?



sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMap.java
Lines 77 (patched)


This is a common and expected occurrence based on the implementation of the 
addEntry method. Change from warn to debug?



sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMap.java
Lines 86 (patched)


This is a common and expected occurrence based on the implementation of the 
addEntry method. Change from warn to debug?



sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMap.java
Lines 228 (patched)


Profile does not need to be maintained, managed or handled during attribute 
ingestion. Just the object is needed (not the object and the profile). See 
comments above about 'server.db.table.column' vs. 'db.table.column'.



sentry-abac/src/main/java/org/apache/sentry/abac/SentryObject.java
Lines 33 (patched)


Add field, getter and setter for descriptor (contentDescriptor). Also add a 
two-arg constructor and update toString, equals and hashCode methods.



sentry-abac/src/main/java/org/apache/sentry/abac/SentryObject.java
Lines 37 (patched)


This is just the SentryObject. Keep mention of Profile distinct; remove 
here.



sentry-abac/src/main/java/org/apache/sentry/abac/SentryObject.java
Lines 39 (patched)


I guess this string will look like "db.table.column" not 
"server.db.table.column". Where will the server value come from during 
ingestion? Also, is the multipart single string representation best or should 
we consider db, table and column, each in separate instance variables?



sentry-abac/src/main/java/org/apache/sentry/abac/SentryObject.java
Lines 43 (patched)


Remove. This will be incredibly verbose.



sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java
Lines 54 (patched)


See notes on SentryObject on server.db.table.column vs. db.table.column.



sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java
Lines 55 (patched)


Add test objects witih content descriptors also (see SentryObject class).



sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java
Lines 274 (patched)


See notes on SentryObject on server.db.table.column vs. db.table.column.



sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestAttributeMap.java
Lines 295 (patched)


See notes on SentryObject on server.db.table.column vs. db.table.column.



sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestStaticProvider.java
Lines 50 (patched)


See notes on SentryObject on server.db.table.column vs. db.table.column.



sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestStaticProvider.java
Lines 85 (patched)


See notes on SentryObject on server.db.table.column vs. db.table.column.



sentry-abac/src/test/java/org/apache/sentry/tests/abac/TestStaticProvider.java
Lines 122 (patched)


See notes on SentryObject on server.db.table.column vs. db.table.column.


- Anthony Young-Garner


On April 12, 2018, 8:45 p.m., Steve Moist wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66590/
> ---
> 
> (Updated April 12, 2018, 8:45 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Repository