subject:"Review Request 69351\: SENTRY\-2458\: Split web service from server service modules"

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-30 Thread Brian Towles via Review Board



> On Nov. 30, 2018, 11:30 a.m., Na Li wrote:
> > sentry-dist/src/license/THIRD-PARTY.properties
> > Line 34 (original)
> > 
> >
> > is this change intentially?

No this is an artifact of the dist license thing.  This needs to be fixed on 
build time.  It doesnt hurt anything and will have the same result on any build.


> On Nov. 30, 2018, 11:30 a.m., Na Li wrote:
> > sentry-dist/src/license/THIRD-PARTY.properties
> > Line 37 (original), 37 (patched)
> > 
> >
> > is this change intentially?

No this is an artifact of the dist license thing.  This needs to be fixed on 
build time.  It doesnt hurt anything and will have the same result on any build.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210982
---


On Nov. 29, 2018, 1:58 p.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 29, 2018, 1:58 p.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/license/THIRD-PARTY.properties a1084db69 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProviderFactory.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceSpi.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
>  PRE-CREATION 
>   sentry-service/sentry-service-server/pom.xml 44540ad5d 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>  862548745 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>  af81d6fce 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>  8da35f10f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>  5dc6cd6c4 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>  23121ecf5 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>  befe6c3ed 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  b3a4934df 
>   
>

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-30 Thread Na Li via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210982
---




sentry-dist/src/license/THIRD-PARTY.properties
Line 34 (original)


is this change intentially?



sentry-dist/src/license/THIRD-PARTY.properties
Line 37 (original), 37 (patched)


is this change intentially?


- Na Li


On Nov. 29, 2018, 7:58 p.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 29, 2018, 7:58 p.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/license/THIRD-PARTY.properties a1084db69 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProviderFactory.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceSpi.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
>  PRE-CREATION 
>   sentry-service/sentry-service-server/pom.xml 44540ad5d 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>  862548745 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>  af81d6fce 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>  8da35f10f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>  5dc6cd6c4 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>  23121ecf5 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>  befe6c3ed 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  b3a4934df 
>   
> sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
>  c31428b07 
>   sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
> a553c4f5e 
>   sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
>   sentry-service/sentry-service-server/src/main/webapp/sentry.png  
>   
>

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-30 Thread kalyan kumar kalvagadda via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210980
---


Ship it!




Ship It!

- kalyan kumar kalvagadda


On Nov. 29, 2018, 7:58 p.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 29, 2018, 7:58 p.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/license/THIRD-PARTY.properties a1084db69 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProviderFactory.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceSpi.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
>  PRE-CREATION 
>   sentry-service/sentry-service-server/pom.xml 44540ad5d 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>  862548745 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>  af81d6fce 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>  8da35f10f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>  5dc6cd6c4 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>  23121ecf5 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>  befe6c3ed 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  b3a4934df 
>   
> sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
>  c31428b07 
>   sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
> a553c4f5e 
>   sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
>   sentry-service/sentry-service-server/src/main/webapp/sentry.png  
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java
>  6e741e895 
>   sentry-service/sentry-service-web/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java
>  PRE-CREATION

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-29 Thread Brian Towles via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/
---

(Updated Nov. 29, 2018, 1:58 p.m.)


Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
Li, Steve Moist, and Sergio Pena.


Bugs: SENTRY-2458
https://issues.apache.org/jira/browse/SENTRY-2458


Repository: sentry


Description
---

SENTRY-2458: Split web service from server service modules

In order to additional modules to be added to Sentry there needs to be a 
separation of some of the features used by service-server into other modules.

This will allow the web server to be pulled out from the base server and allow 
for additional modules to be able to add web services and functionality to the 
web interface without depending up the whole server module.

It will use the SPI to dynamically include servlets and content from other 
modules.

It creates a sentry-service-providers to allow for Server and sub modules SPI 
providers to be defined externally and not depended on directly.


Diffs (updated)
-

  pom.xml 46ca38e9a 
  sentry-dist/pom.xml 62558d2e0 
  sentry-dist/src/license/THIRD-PARTY.properties a1084db69 
  sentry-dist/src/main/assembly/bin.xml 986530c55 
  sentry-provider/sentry-provider-db/pom.xml df569474a 
  sentry-service/pom.xml e653189eb 
  sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProviderFactory.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceSpi.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
 PRE-CREATION 
  sentry-service/sentry-service-server/pom.xml 44540ad5d 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
 862548745 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
 af81d6fce 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
 8da35f10f 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
 5dc6cd6c4 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
 23121ecf5 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
 befe6c3ed 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
 b3a4934df 
  
sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
 c31428b07 
  sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
a553c4f5e 
  sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
  sentry-service/sentry-service-server/src/main/webapp/sentry.png  
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java
 6e741e895 
  sentry-service/sentry-service-web/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java
 PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory
 PRE-CREATION 
  sentry-service/sentry-service-web/src/main/webapp/index.html PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-3.3.7.min.css
 PRE-CREATION

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-29 Thread Brian Towles via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/
---

(Updated Nov. 29, 2018, 1:57 p.m.)


Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
Li, Steve Moist, and Sergio Pena.


Bugs: SENTRY-2458
https://issues.apache.org/jira/browse/SENTRY-2458


Repository: sentry


Description
---

SENTRY-2458: Split web service from server service modules

In order to additional modules to be added to Sentry there needs to be a 
separation of some of the features used by service-server into other modules.

This will allow the web server to be pulled out from the base server and allow 
for additional modules to be able to add web services and functionality to the 
web interface without depending up the whole server module.

It will use the SPI to dynamically include servlets and content from other 
modules.

It creates a sentry-service-providers to allow for Server and sub modules SPI 
providers to be defined externally and not depended on directly.


Diffs (updated)
-

  pom.xml 46ca38e9a 
  sentry-dist/pom.xml 62558d2e0 
  sentry-dist/src/license/THIRD-PARTY.properties a1084db69 
  sentry-dist/src/main/assembly/bin.xml 986530c55 
  sentry-provider/sentry-provider-db/pom.xml df569474a 
  sentry-service/pom.xml e653189eb 
  sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProviderFactory.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceSpi.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
 PRE-CREATION 
  sentry-service/sentry-service-server/pom.xml 44540ad5d 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
 862548745 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
 af81d6fce 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
 8da35f10f 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
 5dc6cd6c4 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
 23121ecf5 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
 befe6c3ed 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
 b3a4934df 
  
sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
 c31428b07 
  sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
a553c4f5e 
  sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
  sentry-service/sentry-service-server/src/main/webapp/sentry.png  
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java
 6e741e895 
  sentry-service/sentry-service-web/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java
 PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory
 PRE-CREATION 
  sentry-service/sentry-service-web/src/main/webapp/index.html PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-3.3.7.min.css
 PRE-CREATION

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-29 Thread Brian Towles via Review Board



> On Nov. 28, 2018, 4:29 p.m., kalyan kumar kalvagadda wrote:
> > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap-3.3.7.js
> > Lines 1 (patched)
> > 
> >
> > Brian, 
> > 
> > What does this bootstrap java script do?
> 
> Brian Towles wrote:
> This is paert of the standard Bootstrap distribution 
> (https://getbootstrap.com/docs/3.3/javascript/).  It provides support for 
> Bootstrap specific UI interface components.  It is included for completness 
> and availability for future UI development.

correction https://getbootstrap.com/docs/3.3/javascript


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210939
---


On Nov. 26, 2018, 9:32 p.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 26, 2018, 9:32 p.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProviderFactory.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceSpi.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
>  PRE-CREATION 
>   sentry-service/sentry-service-server/pom.xml 44540ad5d 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>  862548745 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>  af81d6fce 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>  8da35f10f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>  5dc6cd6c4 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>  23121ecf5 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>  befe6c3ed 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  b3a4934df 
>   
> sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
>  c31428b07 
>

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-28 Thread kalyan kumar kalvagadda via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210939
---




sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap-3.3.7.js
Lines 1 (patched)


Brian, 

What does this bootstrap java script do?


- kalyan kumar kalvagadda


On Nov. 27, 2018, 3:32 a.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 27, 2018, 3:32 a.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProviderFactory.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceSpi.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
>  PRE-CREATION 
>   sentry-service/sentry-service-server/pom.xml 44540ad5d 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>  862548745 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>  af81d6fce 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>  8da35f10f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>  5dc6cd6c4 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>  23121ecf5 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>  befe6c3ed 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  b3a4934df 
>   
> sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
>  c31428b07 
>   sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
> a553c4f5e 
>   sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
>   sentry-service/sentry-service-server/src/main/webapp/sentry.png  
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java
>  6e741e895 
>   sentry-service/sentry-service-web/pom.xml

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-28 Thread Steve Moist via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210936
---


Ship it!




Ship It!

- Steve Moist


On Nov. 27, 2018, 3:32 a.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 27, 2018, 3:32 a.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProviderFactory.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceSpi.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
>  PRE-CREATION 
>   sentry-service/sentry-service-server/pom.xml 44540ad5d 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>  862548745 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>  af81d6fce 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>  8da35f10f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>  5dc6cd6c4 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>  23121ecf5 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>  befe6c3ed 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  b3a4934df 
>   
> sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
>  c31428b07 
>   sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
> a553c4f5e 
>   sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
>   sentry-service/sentry-service-server/src/main/webapp/sentry.png  
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java
>  6e741e895 
>   sentry-service/sentry-service-web/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java
>  PRE-CREATION 
>   
>

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-28 Thread Na Li via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210930
---


Ship it!




Ship It!

- Na Li


On Nov. 27, 2018, 3:32 a.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 27, 2018, 3:32 a.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProviderFactory.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceSpi.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
>  PRE-CREATION 
>   sentry-service/sentry-service-server/pom.xml 44540ad5d 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>  862548745 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>  af81d6fce 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>  8da35f10f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>  5dc6cd6c4 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>  23121ecf5 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>  befe6c3ed 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  b3a4934df 
>   
> sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
>  c31428b07 
>   sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
> a553c4f5e 
>   sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
>   sentry-service/sentry-service-server/src/main/webapp/sentry.png  
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java
>  6e741e895 
>   sentry-service/sentry-service-web/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java
>  PRE-CREATION 
>   
>

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-26 Thread Brian Towles via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/
---

(Updated Nov. 26, 2018, 9:32 p.m.)


Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
Li, Steve Moist, and Sergio Pena.


Bugs: SENTRY-2458
https://issues.apache.org/jira/browse/SENTRY-2458


Repository: sentry


Description
---

SENTRY-2458: Split web service from server service modules

In order to additional modules to be added to Sentry there needs to be a 
separation of some of the features used by service-server into other modules.

This will allow the web server to be pulled out from the base server and allow 
for additional modules to be able to add web services and functionality to the 
web interface without depending up the whole server module.

It will use the SPI to dynamically include servlets and content from other 
modules.

It creates a sentry-service-providers to allow for Server and sub modules SPI 
providers to be defined externally and not depended on directly.


Diffs (updated)
-

  pom.xml 46ca38e9a 
  sentry-dist/pom.xml 62558d2e0 
  sentry-dist/src/main/assembly/bin.xml 986530c55 
  sentry-provider/sentry-provider-db/pom.xml df569474a 
  sentry-service/pom.xml e653189eb 
  sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProviderFactory.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceSpi.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
 PRE-CREATION 
  sentry-service/sentry-service-server/pom.xml 44540ad5d 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
 862548745 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
 af81d6fce 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
 8da35f10f 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
 5dc6cd6c4 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
 23121ecf5 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
 befe6c3ed 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
 b3a4934df 
  
sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
 c31428b07 
  sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
a553c4f5e 
  sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
  sentry-service/sentry-service-server/src/main/webapp/sentry.png  
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java
 6e741e895 
  sentry-service/sentry-service-web/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java
 PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory
 PRE-CREATION 
  sentry-service/sentry-service-web/src/main/webapp/index.html PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-3.3.7.min.css
 PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-theme-3.3.7.min.css
 PRE-CREATION

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-26 Thread Brian Towles via Review Board



> On Nov. 26, 2018, 3:22 p.m., Na Li wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
> > Lines 20 (patched)
> > 
> >
> > or you should move it from under "sentry-service/sentry-service-server" 
> > to "sentry-service/sentry-service-web"

This is the config for the whole service   not just the thrift server part


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210878
---


On Nov. 26, 2018, 9:32 p.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 26, 2018, 9:32 p.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProviderFactory.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceSpi.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
>  PRE-CREATION 
>   sentry-service/sentry-service-server/pom.xml 44540ad5d 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>  862548745 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>  af81d6fce 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>  8da35f10f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>  5dc6cd6c4 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>  23121ecf5 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>  befe6c3ed 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  b3a4934df 
>   
> sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
>  c31428b07 
>   sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
> a553c4f5e 
>   sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
>

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-26 Thread Brian Towles via Review Board



> On Nov. 26, 2018, 3:02 p.m., Na Li wrote:
> > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java
> > Lines 30 (patched)
> > 
> >
> > This is interface. Should we follow the convention and call it 
> > "SentryWebServiceProviderInterface"? And its implementation as 
> > "SentryWebServiceProvider"?

Renames to WebServiceProvider and WebServiceProviderFactory


> On Nov. 26, 2018, 3:02 p.m., Na Li wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
> > Lines 20 (patched)
> > 
> >
> > should this be the same package as "RolesServlet.java"?

No, for the whole service


> On Nov. 26, 2018, 3:02 p.m., Na Li wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
> > Lines 49 (patched)
> > 
> >
> > instead of creating SentryStore directly, it would be better to use 
> > approach similar in 
> > https://github.com/apache/sentry/blob/master/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java#L187

Will open an issue for shifting it from private and we can redo it later.


> On Nov. 26, 2018, 3:02 p.m., Na Li wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
> > Lines 40 (patched)
> > 
> >
> > It is not easy to tell that SentryServiceWebServiceProvider is 
> > implementation, and  SentryWebServiceProvider is interface. 
> > 
> > It is easier to read code if we call "SentryWebServiceProvider" as 
> > "SentryWebServiceProviderInterface" and "SentryServiceWebServiceProvider " 
> > as "SentryWebServiceProvider".

Renamed


> On Nov. 26, 2018, 3:02 p.m., Na Li wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
> > Lines 64 (patched)
> > 
> >
> > it returns the same result as /admi/roles. Should we remove this line?

No this is for backwards compatability


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210877
---


On Nov. 20, 2018, 1:30 p.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 20, 2018, 1:30 p.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProviderFactory.java
>  PRE-CREATION 
>   
>

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-26 Thread Na Li via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210878
---




sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
Lines 20 (patched)


or you should move it from under "sentry-service/sentry-service-server" to 
"sentry-service/sentry-service-web"


- Na Li


On Nov. 20, 2018, 7:30 p.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 20, 2018, 7:30 p.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProviderFactory.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceSpi.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
>  PRE-CREATION 
>   sentry-service/sentry-service-server/pom.xml 44540ad5d 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>  862548745 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>  af81d6fce 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>  8da35f10f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>  5dc6cd6c4 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>  23121ecf5 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>  befe6c3ed 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  b3a4934df 
>   
> sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
>  c31428b07 
>   sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
> a553c4f5e 
>   sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
>   sentry-service/sentry-service-server/src/main/webapp/sentry.png  
>   
>

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-26 Thread Na Li via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210877
---




sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java
Lines 30 (patched)


This is interface. Should we follow the convention and call it 
"SentryWebServiceProviderInterface"? And its implementation as 
"SentryWebServiceProvider"?



sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
Lines 20 (patched)


should this be the same package as "RolesServlet.java"?



sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
Lines 49 (patched)


instead of creating SentryStore directly, it would be better to use 
approach similar in 
https://github.com/apache/sentry/blob/master/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java#L187



sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
Lines 40 (patched)


It is not easy to tell that SentryServiceWebServiceProvider is 
implementation, and  SentryWebServiceProvider is interface. 

It is easier to read code if we call "SentryWebServiceProvider" as 
"SentryWebServiceProviderInterface" and "SentryServiceWebServiceProvider " as 
"SentryWebServiceProvider".



sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
Lines 64 (patched)


it returns the same result as /admi/roles. Should we remove this line?


- Na Li


On Nov. 20, 2018, 7:30 p.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 20, 2018, 7:30 p.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProviderFactory.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceSpi.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
>  PRE-CREATION 
>   sentry-service/sentry-service-server/pom.xml 44540ad5d 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>  862548745 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>  af81d6fce 
>   
>

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-26 Thread Brian Towles via Review Board



> On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote:
> > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js
> > Lines 32 (patched)
> > 
> >
> > Why do we have 2 different copyrights?  Is this file under the MIT 
> > license?
> 
> Brian Towles wrote:
> This is a direct copy of the file.  It how they copyrighted it.
> 
> Steve Moist wrote:
> Even the apache 2 license on the top?

Belive that was a different file I already fixed.  This one doesn't have two 
apache 2 license on the top.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210669
---


On Nov. 20, 2018, 1:30 p.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 20, 2018, 1:30 p.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProviderFactory.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceSpi.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
>  PRE-CREATION 
>   sentry-service/sentry-service-server/pom.xml 44540ad5d 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>  862548745 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>  af81d6fce 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>  8da35f10f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>  5dc6cd6c4 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>  23121ecf5 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>  befe6c3ed 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  b3a4934df 
>   
> sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
>  c31428b07 
>

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-20 Thread Steve Moist via Review Board



> On Nov. 20, 2018, 6:04 p.m., Steve Moist wrote:
> > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js
> > Lines 32 (patched)
> > 
> >
> > Why do we have 2 different copyrights?  Is this file under the MIT 
> > license?
> 
> Brian Towles wrote:
> This is a direct copy of the file.  It how they copyrighted it.

Even the apache 2 license on the top?


- Steve


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210669
---


On Nov. 20, 2018, 7:30 p.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 20, 2018, 7:30 p.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProviderFactory.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceSpi.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
>  PRE-CREATION 
>   sentry-service/sentry-service-server/pom.xml 44540ad5d 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
>  862548745 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
>  af81d6fce 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
>  8da35f10f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
>  5dc6cd6c4 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
>  23121ecf5 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
>  befe6c3ed 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  b3a4934df 
>   
> sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
>  c31428b07 
>   sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
> a553c4f5e 
>   sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
>

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-20 Thread Brian Towles via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/
---

(Updated Nov. 20, 2018, 1:30 p.m.)


Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
Li, Steve Moist, and Sergio Pena.


Changes
---

Fixes for Steve


Bugs: SENTRY-2458
https://issues.apache.org/jira/browse/SENTRY-2458


Repository: sentry


Description
---

SENTRY-2458: Split web service from server service modules

In order to additional modules to be added to Sentry there needs to be a 
separation of some of the features used by service-server into other modules.

This will allow the web server to be pulled out from the base server and allow 
for additional modules to be able to add web services and functionality to the 
web interface without depending up the whole server module.

It will use the SPI to dynamically include servlets and content from other 
modules.

It creates a sentry-service-providers to allow for Server and sub modules SPI 
providers to be defined externally and not depended on directly.


Diffs (updated)
-

  pom.xml 46ca38e9a 
  sentry-dist/pom.xml 62558d2e0 
  sentry-dist/src/main/assembly/bin.xml 986530c55 
  sentry-provider/sentry-provider-db/pom.xml df569474a 
  sentry-service/pom.xml e653189eb 
  sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProviderFactory.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceSpi.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
 PRE-CREATION 
  sentry-service/sentry-service-server/pom.xml 44540ad5d 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
 862548745 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
 af81d6fce 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
 8da35f10f 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
 5dc6cd6c4 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
 23121ecf5 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
 befe6c3ed 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
 b3a4934df 
  
sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
 c31428b07 
  sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
a553c4f5e 
  sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
  sentry-service/sentry-service-server/src/main/webapp/sentry.png  
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java
 6e741e895 
  sentry-service/sentry-service-web/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java
 PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory
 PRE-CREATION 
  sentry-service/sentry-service-web/src/main/webapp/index.html PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-3.3.7.min.css
 PRE-CREATION

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-20 Thread Brian Towles via Review Board



> On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote:
> > sentry-dist/pom.xml
> > Lines 66 (patched)
> > 
> >
> > You did an exclusion of * above, why not do it again here?

It didnt work.  I ended up for some reason needing to exclude them manually.


> On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote:
> > sentry-dist/src/main/assembly/bin.xml
> > Lines 49 (patched)
> > 
> >
> > Why twice?

Because im repetative.  Also im repetative.


> On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote:
> > sentry-provider/sentry-provider-db/pom.xml
> > Lines 179 (patched)
> > 
> >
> > Is there a differnence between the long list of exclusions, * or 
> > jetty*?  Mainly asking for consistency's sake.

This worked for the local dependencies for provider-db.  sentry-dist was having 
issues which required the full list.


> On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote:
> > sentry-service/sentry-service-server/pom.xml
> > Line 235 (original)
> > 
> >
> > This was removed, is it still needed elsewhere?

It not needed anymore.  It was being used to change the version on the index 
html in the source.  But the same thing can be done with a resources filter.


> On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote:
> > sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java
> > Lines 1 (patched)
> > 
> >
> > This file has been moved, can we have git mark it as so instead of a 
> > new file.

I think the changes made to the file were significant enough that it would not 
mark it as moved.


> On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote:
> > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-theme.min.css
> > Lines 1 (patched)
> > 
> >
> > Is it worth it to add the bootstrap version info to either the file 
> > name or in a comment?

Changed


> On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote:
> > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap.min.css
> > Lines 1 (patched)
> > 
> >
> > Same comment as above about bootstrap version.

Changed


> On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote:
> > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js
> > Lines 32 (patched)
> > 
> >
> > Why do we have 2 different copyrights?  Is this file under the MIT 
> > license?

This is a direct copy of the file.  It how they copyrighted it.


> On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote:
> > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js
> > Lines 92 (patched)
> > 
> >
> > Why is there another one here?

This is a direct copy of the file.  It how they copyrighted it.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210669
---


On Nov. 15, 2018, 2:05 p.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 15, 2018, 2:05 p.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/main/assembly/bin.xml

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-20 Thread Steve Moist via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210669
---




sentry-dist/pom.xml
Lines 66 (patched)


You did an exclusion of * above, why not do it again here?



sentry-dist/src/main/assembly/bin.xml
Lines 49 (patched)


Why twice?



sentry-provider/sentry-provider-db/pom.xml
Lines 179 (patched)


Is there a differnence between the long list of exclusions, * or jetty*?  
Mainly asking for consistency's sake.



sentry-service/sentry-service-providers/pom.xml
Lines 33 (patched)


Add Name tag



sentry-service/sentry-service-server/pom.xml
Line 235 (original)


This was removed, is it still needed elsewhere?



sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java
Lines 1 (patched)


This file has been moved, can we have git mark it as so instead of a new 
file.



sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-theme.min.css
Lines 1 (patched)


Is it worth it to add the bootstrap version info to either the file name or 
in a comment?



sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap.min.css
Lines 1 (patched)


Same comment as above about bootstrap version.



sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js
Lines 1 (patched)


Version info again



sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js
Lines 32 (patched)


Why do we have 2 different copyrights?  Is this file under the MIT license?



sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js
Lines 92 (patched)


Why is there another one here?


- Steve Moist


On Nov. 15, 2018, 8:05 p.m., Brian Towles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69351/
> ---
> 
> (Updated Nov. 15, 2018, 8:05 p.m.)
> 
> 
> Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
> Li, Steve Moist, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2458
> https://issues.apache.org/jira/browse/SENTRY-2458
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-2458: Split web service from server service modules
> 
> In order to additional modules to be added to Sentry there needs to be a 
> separation of some of the features used by service-server into other modules.
> 
> This will allow the web server to be pulled out from the base server and 
> allow for additional modules to be able to add web services and functionality 
> to the web interface without depending up the whole server module.
> 
> It will use the SPI to dynamically include servlets and content from other 
> modules.
> 
> It creates a sentry-service-providers to allow for Server and sub modules SPI 
> providers to be defined externally and not depended on directly.
> 
> 
> Diffs
> -
> 
>   pom.xml 46ca38e9a 
>   sentry-dist/pom.xml 62558d2e0 
>   sentry-dist/src/main/assembly/bin.xml 986530c55 
>   sentry-provider/sentry-provider-db/pom.xml df569474a 
>   sentry-service/pom.xml e653189eb 
>   sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProviderFactory.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceSpi.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
>

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-15 Thread Brian Towles via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/
---

(Updated Nov. 15, 2018, 2:05 p.m.)


Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
Li, Steve Moist, and Sergio Pena.


Changes
---

another header cleanup


Bugs: SENTRY-2458
https://issues.apache.org/jira/browse/SENTRY-2458


Repository: sentry


Description
---

SENTRY-2458: Split web service from server service modules

In order to additional modules to be added to Sentry there needs to be a 
separation of some of the features used by service-server into other modules.

This will allow the web server to be pulled out from the base server and allow 
for additional modules to be able to add web services and functionality to the 
web interface without depending up the whole server module.

It will use the SPI to dynamically include servlets and content from other 
modules.

It creates a sentry-service-providers to allow for Server and sub modules SPI 
providers to be defined externally and not depended on directly.


Diffs (updated)
-

  pom.xml 46ca38e9a 
  sentry-dist/pom.xml 62558d2e0 
  sentry-dist/src/main/assembly/bin.xml 986530c55 
  sentry-provider/sentry-provider-db/pom.xml df569474a 
  sentry-service/pom.xml e653189eb 
  sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProviderFactory.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceSpi.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
 PRE-CREATION 
  sentry-service/sentry-service-server/pom.xml 44540ad5d 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
 862548745 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
 af81d6fce 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
 8da35f10f 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
 5dc6cd6c4 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
 23121ecf5 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
 befe6c3ed 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
 b3a4934df 
  
sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
 c31428b07 
  sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
a553c4f5e 
  sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
  sentry-service/sentry-service-server/src/main/webapp/sentry.png  
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java
 6e741e895 
  sentry-service/sentry-service-web/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java
 PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory
 PRE-CREATION 
  sentry-service/sentry-service-web/src/main/webapp/index.html PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-theme.min.css
 PRE-CREATION

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-15 Thread Brian Towles via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/
---

(Updated Nov. 15, 2018, 1:46 p.m.)


Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na 
Li, Steve Moist, and Sergio Pena.


Changes
---

fixed extra headers and rat issue


Bugs: SENTRY-2458
https://issues.apache.org/jira/browse/SENTRY-2458


Repository: sentry


Description
---

SENTRY-2458: Split web service from server service modules

In order to additional modules to be added to Sentry there needs to be a 
separation of some of the features used by service-server into other modules.

This will allow the web server to be pulled out from the base server and allow 
for additional modules to be able to add web services and functionality to the 
web interface without depending up the whole server module.

It will use the SPI to dynamically include servlets and content from other 
modules.

It creates a sentry-service-providers to allow for Server and sub modules SPI 
providers to be defined externally and not depended on directly.


Diffs (updated)
-

  pom.xml 46ca38e9a 
  sentry-dist/pom.xml 62558d2e0 
  sentry-dist/src/main/assembly/bin.xml 986530c55 
  sentry-provider/sentry-provider-db/pom.xml df569474a 
  sentry-service/pom.xml e653189eb 
  sentry-service/sentry-service-providers/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProviderFactory.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceSpi.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java
 PRE-CREATION 
  
sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi
 PRE-CREATION 
  sentry-service/sentry-service-server/pom.xml 44540ad5d 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java
 862548745 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java
 af81d6fce 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java
 8da35f10f 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java
 5dc6cd6c4 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java
 23121ecf5 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java
 befe6c3ed 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java
 b3a4934df 
  
sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css
 c31428b07 
  sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css 
a553c4f5e 
  sentry-service/sentry-service-server/src/main/webapp/css/sentry.css  
  sentry-service/sentry-service-server/src/main/webapp/sentry.png  
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java
 6e741e895 
  sentry-service/sentry-service-web/pom.xml PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java
 PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java
 PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory
 PRE-CREATION 
  sentry-service/sentry-service-web/src/main/webapp/index.html PRE-CREATION 
  
sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-theme.min.css
 PRE-CREATION

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

21 matches

Site Navigation

Mail list logo

Footer information