[GitHub] coveralls commented on issue #598: [SCB-402] normal invocation in edge use private classloader

[GitBox]

coveralls commented on issue #598: [SCB-402] normal invocation in edge use 
private classloader
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/598#issuecomment-373263713
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15986769/badge)](https://coveralls.io/builds/15986769)
   
   Coverage increased (+0.007%) to 87.222% when pulling 
**f2ab09b62cd44322b047315f624b97dd5fa59c06 on 
wujimin:normal-invocation-in-edge-use-private-classloader** into 
**2231ed6450cfe6cfe58afe6f964be8df1234080b on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin opened a new pull request #598: [SCB-402] normal invocation in edge use private classloader

[GitBox]

wujimin opened a new pull request #598: [SCB-402] normal invocation in edge use 
private classloader
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/598
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #597: [SCB-401]keep pull strategy always alive whatever watch strategy state

[GitBox]

coveralls commented on issue #597: [SCB-401]keep pull strategy always alive 
whatever watch strategy state
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/597#issuecomment-373257054
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15986407/badge)](https://coveralls.io/builds/15986407)
   
   Coverage decreased (-0.001%) to 87.214% when pulling 
**f92a771be0330ce2921e700eef01e18d2420a666 on mt-monster:master** into 
**2231ed6450cfe6cfe58afe6f964be8df1234080b on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mt-monster opened a new pull request #597: [SCB-401]keep pull strategy always alive whatever watch strategy state

[GitBox]

mt-monster opened a new pull request #597: [SCB-401]keep pull strategy always 
alive whatever watch strategy state
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/597
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   we keep pull stategy always work ,no matter watch switch open or not


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #307: [SCB-376] Optimize validate parameter log print

[GitBox]

codecov-io commented on issue #307:  [SCB-376] Optimize validate parameter log 
print
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/307#issuecomment-372928983
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=h1)
 Report
   > Merging 
[#307](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/0b7c6854f1b7b4b62c67a0048677653d0225938c?src=pr=desc)
 will **decrease** coverage by `0.02%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307/graphs/tree.svg?width=650=150=pr=GAaF7zrg8R)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #307  +/-   ##
   ==
   - Coverage   70.39%   70.36%   -0.03% 
   ==
 Files  17   17  
 Lines3455 3452   -3 
   ==
   - Hits 2432 2429   -3 
 Misses853  853  
 Partials  170  170
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/util/rule\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9ydWxlX3V0aWwuZ28=)
 | `67.5% <ø> (-0.6%)` | :arrow_down: |
   | 
[server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==)
 | `74.6% <100%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=footer).
 Last update 
[0b7c685...fc01cdf](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #307: [SCB-376] Optimize validate parameter log print

[GitBox]

coveralls commented on issue #307:  [SCB-376] Optimize validate parameter log 
print
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/307#issuecomment-372929042
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15985883/badge)](https://coveralls.io/builds/15985883)
   
   Coverage decreased (-0.09%) to 74.038% when pulling 
**fc01cdfc1fa1757a1ae259d163988acb498dca86 on aseTo2016:aseTo** into 
**0b7c6854f1b7b4b62c67a0048677653d0225938c on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] weichao666 commented on a change in pull request #591: [SCB-396] java-sdk needs to distinguish the services belongs to the devops stage(environment)

[GitBox]

weichao666 commented on a change in pull request #591: [SCB-396] java-sdk needs 
to distinguish the services belongs to the devops stage(environment)
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/591#discussion_r174663587
 
 

 ##
 File path: 
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/MicroserviceFactory.java
 ##
 @@ -60,6 +62,7 @@ private Microservice 
createMicroserviceFromDefinition(Configuration configuratio
 
microservice.setPaths(ConfigurePropertyUtils.getMicroservicePaths(configuration));
 Map propertiesMap = 
MicroservicePropertiesLoader.INSTANCE.loadProperties(configuration);
 microservice.setProperties(propertiesMap);
+microservice.setEnvironment(configuration.getString(SERVICECOMB_ENV, 
DEFAULT_SERVICECOMB_ENV));
 
 Review comment:
   
![image](https://user-images.githubusercontent.com/30716999/37441602-377a004a-283d-11e8-8406-ef38fc13714b.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] weichao666 commented on a change in pull request #591: [SCB-396] java-sdk needs to distinguish the services belongs to the devops stage(environment)

[GitBox]

weichao666 commented on a change in pull request #591: [SCB-396] java-sdk needs 
to distinguish the services belongs to the devops stage(environment)
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/591#discussion_r174663556
 
 

 ##
 File path: 
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/MicroserviceFactory.java
 ##
 @@ -60,6 +62,7 @@ private Microservice 
createMicroserviceFromDefinition(Configuration configuratio
 
microservice.setPaths(ConfigurePropertyUtils.getMicroservicePaths(configuration));
 Map propertiesMap = 
MicroservicePropertiesLoader.INSTANCE.loadProperties(configuration);
 microservice.setProperties(propertiesMap);
+microservice.setEnvironment(configuration.getString(SERVICECOMB_ENV, 
DEFAULT_SERVICECOMB_ENV));
 
 Review comment:
   
![image](https://user-images.githubusercontent.com/30716999/37441594-2c1b1068-283d-11e8-85c8-5adbade1b082.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] weichao666 commented on a change in pull request #591: [SCB-396] java-sdk needs to distinguish the services belongs to the devops stage(environment)

[GitBox]

weichao666 commented on a change in pull request #591: [SCB-396] java-sdk needs 
to distinguish the services belongs to the devops stage(environment)
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/591#discussion_r174663556
 
 

 ##
 File path: 
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/MicroserviceFactory.java
 ##
 @@ -60,6 +62,7 @@ private Microservice 
createMicroserviceFromDefinition(Configuration configuratio
 
microservice.setPaths(ConfigurePropertyUtils.getMicroservicePaths(configuration));
 Map propertiesMap = 
MicroservicePropertiesLoader.INSTANCE.loadProperties(configuration);
 microservice.setProperties(propertiesMap);
+microservice.setEnvironment(configuration.getString(SERVICECOMB_ENV, 
DEFAULT_SERVICECOMB_ENV));
 
 Review comment:
   
![image](https://user-images.githubusercontent.com/30716999/37441594-2c1b1068-283d-11e8-85c8-5adbade1b082.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on issue #594: [SCB-379] support AsyncRestTemplate

[GitBox]

liubao68 commented on issue #594: [SCB-379] support AsyncRestTemplate
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#issuecomment-373240330
 
 
   Agree with wujimin. We added RestTempalteBuilder before, after using spring 
boot and other programming practices, this will hide some information to users 
and make them misunderstanding. Let users to new a property RestTemplate 
instance is appropriate.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: servicecomb-saga的saga-demo问题

[Willem Jiang]

FYI, We have SCB-400[1] to address this issue.

[1]https://issues.apache.org/jira/browse/SCB-400


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Tue, Mar 13, 2018 at 10:22 PM, Willem Jiang 
wrote:

> 从你的描述上来，你应该是没有在 正确的目录下面启动 alpha server。
> 编译完代码之后，你可以在 /incubator-servicecomb-saga/alpha/alpha-server/target/saga
> 找到 alpha-server-xxx-exec.jar
>
> 还有就是建议你按照ReadMe的指示用docker compose来运行，后续我们会提供单独使用Java命令运行指示。
>
> Please filled a JIRA[1] for it let the user run the demo without using
> docker compose.
>
> [1]https://issues.apache.org/jira/projects/SCB
>
>
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
>   http://jnn.iteye.com  (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Tue, Mar 13, 2018 at 10:07 PM, 叶祖锋  wrote:
>
>> hi:
>> 下了https://github.com/apache/incubator-servicecomb-saga源码，在本地通过mvn clean
>> install编译成功。
>>
>> 在执行java -Dspring.profiles.active=prd -D"spring.datasource.url=jdbc:
>> postgresql://ip:5432/saga?useSSL=false" -jar
>> alpha-server-0.1.0.jar时提示“alpha-server-0.1.0.jar中没有主清单属性”。
>>
>> 然后我直接把alpha-server项目导入到eclipse中，在eclipse跑起来了。接下来导入booking这个d
>> emo，试着修改pack-car项目的application.yaml配置文件。
>> eclipse的工程列表：
>> pack-car的application.yaml文件修改如下：
>> 启动报错信息如下：
>> ---
>> [2m2018-03-13 18:51:22.731[0;39m [32m INFO[0;39m [35m28932[0;39m
>> [2m---[0;39m [2m[   main][0;39m 
>> [36mo.a.s.saga.demo.pack.car.Application
>>   [0;39m [2m:[0;39m Starting Application on joeyee with PID 28932
>> (/home/joeyee/gitlab/axon/incubator-servicecomb-saga/saga-
>> demo/booking/car/target/classes started by joeyee in
>> /home/joeyee/gitlab/axon/incubator-servicecomb-saga/saga-
>> demo/booking/car)
>> [2m2018-03-13 18:51:22.735[0;39m [32m INFO[0;39m [35m28932[0;39m
>> [2m---[0;39m [2m[   main][0;39m 
>> [36mo.a.s.saga.demo.pack.car.Application
>>   [0;39m [2m:[0;39m No active profile set, falling back to default
>> profiles: default
>> [2m2018-03-13 18:51:22.817[0;39m [32m INFO[0;39m [35m28932[0;39m
>> [2m---[0;39m [2m[   main][0;39m 
>> [36mationConfigEmbeddedWebApplicationContext[0;39m
>> [2m:[0;39m Refreshing org.springframework.boot.conte
>> xt.embedded.AnnotationConfigEmbeddedWebApplicationContext@6356695f:
>> startup date [Tue Mar 13 18:51:22 CST 2018]; root of context hierarchy
>> [2m2018-03-13 18:51:25.046[0;39m [32m INFO[0;39m [35m28932[0;39m
>> [2m---[0;39m [2m[   main][0;39m 
>> [36mtrationDelegate$BeanPostProcessorChecker[0;39m
>> [2m:[0;39m Bean 'org.apache.servicecomb.saga.o
>> mega.transaction.spring.TransactionAspectConfig' of type
>> [org.apache.servicecomb.saga.omega.transaction.spring.Transa
>> ctionAspectConfig$$EnhancerBySpringCGLIB$$453431bc] is not eligible for
>> getting processed by all BeanPostProcessors (for example: not eligible for
>> auto-proxying)
>> [2m2018-03-13 18:51:25.209[0;39m [32m INFO[0;39m [35m28932[0;39m
>> [2m---[0;39m [2m[   main][0;39m 
>> [36mtrationDelegate$BeanPostProcessorChecker[0;39m
>> [2m:[0;39m Bean 'org.apache.servicecomb.saga.omega.spring.OmegaSpringConfig'
>> of type [org.apache.servicecomb.saga.omega.spring.OmegaSpringConfig$
>> $EnhancerBySpringCGLIB$$db915c24] is not eligible for getting processed
>> by all BeanPostProcessors (for example: not eligible for auto-proxying)
>> [2m2018-03-13 18:51:25.235[0;39m [32m INFO[0;39m [35m28932[0;39m
>> [2m---[0;39m [2m[   main][0;39m 
>> [36mtrationDelegate$BeanPostProcessorChecker[0;39m
>> [2m:[0;39m Bean 'idGenerator' of type [org.apache.servicecomb.saga.o
>> mega.context.UniqueIdGenerator] is not eligible for getting processed by
>> all BeanPostProcessors (for example: not eligible for auto-proxying)
>> [2m2018-03-13 18:51:25.238[0;39m [32m INFO[0;39m [35m28932[0;39m
>> [2m---[0;39m [2m[   main][0;39m 
>> [36mtrationDelegate$BeanPostProcessorChecker[0;39m
>> [2m:[0;39m Bean 'omegaContext' of type 
>> [org.apache.servicecomb.saga.omega.context.OmegaContext]
>> is not eligible for getting processed by all BeanPostProcessors (for
>> example: not eligible for auto-proxying)
>> [2m2018-03-13 18:51:25.251[0;39m [32m INFO[0;39m [35m28932[0;39m
>> [2m---[0;39m [2m[   main][0;39m 
>> [36mtrationDelegate$BeanPostProcessorChecker[0;39m
>> [2m:[0;39m Bean 'compensationContext' of type [org.apache.servicecomb.saga.o
>> mega.context.CompensationContext] is not eligible for getting processed
>> by all BeanPostProcessors (for example: not eligible for auto-proxying)
>> [2m2018-03-13 18:51:26.149[0;39m [32m INFO[0;39m [35m28932[0;39m
>> [2m---[0;39m [2m[   main][0;39m 
>> [36ms.b.c.e.t.TomcatEmbeddedServletContainer[0;39m
>> [2m:[0;39m Tomcat initialized with port(s): 8080 (http)
>> [2m2018-03-13 18:51:26.162[0;39m [32m INFO[0;39m [35m28932[0;39m
>> [2m---[0;39m [2m[   main][0;39m 
>> [36mo.apache.catalina.core.StandardService
>> [0;39m [2m:[0;39m Starting service 

[GitHub] coveralls commented on issue #153: SCB-400 add guides to run demo without docker compose

[GitBox]

coveralls commented on issue #153: SCB-400 add guides to run demo without 
docker compose
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/153#issuecomment-372895796
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15985384/badge)](https://coveralls.io/builds/15985384)
   
   Coverage remained the same at 95.395% when pulling 
**4ed7e021938573a8dec06297ff08ee5fbf35ff17 on eric-lee-ltk:SCB-395** into 
**fc3f2ae1752e8a46d225138d80c0e92860f45363 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang closed pull request #153: SCB-400 add guides to run demo without docker compose

[GitBox]

WillemJiang closed pull request #153: SCB-400 add guides to run demo without 
docker compose
URL: https://github.com/apache/incubator-servicecomb-saga/pull/153
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/faq/cn/how_to_use_mysql_as_alpha_backend_database.md 
b/docs/faq/cn/how_to_use_mysql_as_alpha_backend_database.md
index 0ef18abf..66b2ab73 100644
--- a/docs/faq/cn/how_to_use_mysql_as_alpha_backend_database.md
+++ b/docs/faq/cn/how_to_use_mysql_as_alpha_backend_database.md
@@ -30,10 +30,13 @@
 4. 运行alpha。请确保MySQL在此前已成功启动。alpha的运行可通过docker或可执行文件的方式。
* 通过docker
   ```bash
-  docker run -d -p 8090:8090 -e "JAVA_OPTS=-Dspring.profiles.active=mysql 
-Dspring.datasource.url=jdbc:mysql://${host_address}:3306/saga?useSSL=false" 
alpha-server:${saga_version}
+  docker run -d -p 8080:8080 -p 8090:8090 -e 
"JAVA_OPTS=-Dspring.profiles.active=mysql 
-Dspring.datasource.url=jdbc:mysql://${host_address}:3306/saga?useSSL=false" 
alpha-server:${saga_version}
   ```
* 通过可执行文件
   ```bash
   java -Dspring.profiles.active=mysql 
-D"spring.datasource.url=jdbc:mysql://${host_address}:3306/saga?useSSL=false" 
-jar alpha-server-${saga_version}-exec.jar
   ```
**注意**: 请在运行命令前将`${saga_version}`和`${host_address}`更改为实际值。
+
+   **注意**: 默认情况下，8080端口用于处理omega处发起的gRPC的请求，而8090端口用于处理查询存储在alpha处的事件信息。
+
diff --git a/docs/faq/en/how_to_use_mysql_as_alpha_backend_database.md 
b/docs/faq/en/how_to_use_mysql_as_alpha_backend_database.md
index 14fd5980..c63a1de2 100644
--- a/docs/faq/en/how_to_use_mysql_as_alpha_backend_database.md
+++ b/docs/faq/en/how_to_use_mysql_as_alpha_backend_database.md
@@ -30,10 +30,14 @@
 4. Run alpha. Please make sure MySQL is up before this step. You can run alpha 
through docker or executable file.
* via docker
   ```bash
-  docker run -d -p 8090:8090 -e "JAVA_OPTS=-Dspring.profiles.active=mysql 
-Dspring.datasource.url=jdbc:mysql://${host_address}:3306/saga?useSSL=false" 
alpha-server:${saga_version}
+  docker run -d -p 8080:8080 -p 8090:8090 -e 
"JAVA_OPTS=-Dspring.profiles.active=mysql 
-Dspring.datasource.url=jdbc:mysql://${host_address}:3306/saga?useSSL=false" 
alpha-server:${saga_version}
   ```
* via executable file
   ```bash
   java -Dspring.profiles.active=mysql 
-D"spring.datasource.url=jdbc:mysql://${host_address}:3306/saga?useSSL=false" 
-jar alpha-server-${saga_version}-exec.jar
   ```
+
**Notice**: Please change `${saga_version}` and `${host_address}` to the 
actual value before you execute the command.
+
+
+   **Note**: By default, port 8080 is used to serve omega's request via gRPC 
while port 8090 is used to query the events stored in alpha.
diff --git a/docs/user_guide.md b/docs/user_guide.md
index d03ab252..4e244d36 100644
--- a/docs/user_guide.md
+++ b/docs/user_guide.md
@@ -87,6 +87,9 @@ Take a transfer money application as an example:
  repo.addBalanceByUsername(from, amount);
}
```
+
+   **Note** transactions and compensations implemented by services must be 
idempotent.
+
**Note:** By default, timeout is disable.
 
**Note:** If the starting point of global transaction and local transaction 
overlaps, both `@SagaStart` and `@Compensable` are needed.
@@ -102,14 +105,17 @@ Take a transfer money application as an example:
 2. run alpha. Before running alpha, please make sure postgreSQL is already up. 
You can run alpha through docker or executable file.
* Run alpha through docker.
   ```bash
-  docker run -d -p 8090:8090 -e "JAVA_OPTS=-Dspring.profiles.active=prd 
-Dspring.datasource.url=jdbc:postgresql://${host_address}:5432/saga?useSSL=false"
 alpha-server:${saga_version}
+  docker run -d -p 8080:8080 -p 8090:8090 -e 
"JAVA_OPTS=-Dspring.profiles.active=prd 
-Dspring.datasource.url=jdbc:postgresql://${host_address}:5432/saga?useSSL=false"
 alpha-server:${saga_version}
   ```
* Run alpha through executable file.
   ```bash
   java -Dspring.profiles.active=prd 
-D"spring.datasource.url=jdbc:postgresql://${host_address}:5432/saga?useSSL=false"
 -jar alpha-server-${saga_version}-exec.jar
   ```
+
**Note**: Please change `${saga_version}` and `${host_address}` to the 
actual value before you execute the command.
 
+   **Note**: By default, port 8080 is used to serve omega's request via gRPC 
while port 8090 is used to query the events stored in alpha.
+
 3. setup omega. Configure the following values in `application.yaml`.
```yaml
spring:
diff --git a/docs/user_guide_zh.md b/docs/user_guide_zh.md
index b33a3d52..43310012 100644
--- a/docs/user_guide_zh.md
+++ b/docs/user_guide_zh.md
@@ -87,6 +87,9 @@ Saga可通过以下任一方式进行构建：
  repo.addBalanceByUsername(from, amount);
}
```
+
+   **注意:** 

[GitHub] coveralls commented on issue #596: [SCB-399] fix incorrect file name of spring bean xml in samples

[GitBox]

coveralls commented on issue #596: [SCB-399] fix incorrect file name of spring 
bean xml in samples
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/596#issuecomment-373237314
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15985261/badge)](https://coveralls.io/builds/15985261)
   
   Coverage increased (+0.006%) to 87.221% when pulling 
**12213f8ee9b1b00a1ffc5010695ee7a122b2988e on zhengyangyong:SCB-399** into 
**2231ed6450cfe6cfe58afe6f964be8df1234080b on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhengyangyong opened a new pull request #596: [SCB-399] fix incorrect file name of spring bean xml in samples

[GitBox]

zhengyangyong opened a new pull request #596: [SCB-399] fix incorrect file name 
of spring bean xml in samples
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/596
 
 
   Signed-off-by: zhengyangyong 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   **most of them named "pojo.xxx",seems copy & paste and may make confusion**


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: A question about ACID guarantees Saga provides

[Daniel Qian]

@Willem Jiang，多谢。我回头会试试看。

2018-03-14 22:46 GMT+08:00 Willem Jiang :
> 首先应用App启动时候，如果版本信息（应用名 + 版本号）发生变化可以通过Omega通知Alpha。
> 这样就不不会出现版本执行错误的情况。
>
> 对于你举的1.0 升级到 2.0 的情况可能需要通过优雅停机的方式来解决了。
> 因为App 1.0 可能会有多个实例， Alpha在执行回滚的过程中如果只通过Omega来回调的话很难解决实例突然终止的问题，
> 我现在想到的办法是让Alpha直接调用App 1.0提供的恢复服务接口。
> 如果App1.0的服务接口是幂等的且无状态的话，那我们还是能够做到事务的最终一致。
>
>
>
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
>   http://jnn.iteye.com  (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Wed, Mar 14, 2018 at 9:20 AM, Daniel Qian  wrote:
>
>> Thanks a lot, Willem Jiang, 关于Q7我举个例子来说明我的意思：
>>
>> App version 1.0 里的Saga是这样的：call methodA, call methodB
>> App version 2.0 里的代码是这样的：call methodA, call methodC
>>
>> 把App从1.0 升级到 2.0必定需要将原1.0的App进程停止，然后启动2.0的App进程。
>> 在停止1.0的App进程的时候，可能会出现Saga只执行了一半。
>>
>> 那么启动2.0的App进程之后，会出现以下哪种情况：
>>
>> 1. 1.0 App的未执行完成的Saga永远保持未完成状态
>> 2. 会Saga Alpha会尝试使用2.0App的代码，继续执行未完成Saga
>>
>> 2018-03-13 22:52 GMT+08:00 Willem Jiang :
>> > Hi Dainiel
>> >
>> > Here are my answer to you question， we will write an english version for
>> it
>> > shortly.
>> >
>> > 1. Saga的执行是同步的还是异步的？发起Saga之后，是等所有Sub-transaction都完成才返回，还是立即返回？
>> > 目前Saga事情的执行是同步的，后续我们会提供异步方式的实现。
>> >
>> >
>> > 2. Saga是并行还是顺序执行Sub-transaction的？
>> > Saga pack 是根据调用的代码来决定Saga事件，如果Saga子事件是并行方式调用的， 那Saga协调器也是采用并行方式进行处理的。
>> >
>> > 3. Saga对于do、compenstation的实现有什么要求？
>> > 对服务调用要求是要支持幂等的。
>> >
>> > 4. Saga保证了A、C、I、D中的哪些部分？
>> > 按照前面的回复， Saga 支持 ACD。
>> >
>> > 5. Saga可以嵌套吗？
>> > Saga实现支持子事件嵌套的方式。
>> >
>> > 6. 如何水平扩展Saga Alpha？
>> > Saga Alpha在设计过程中状态信息都存储到数据库，是支持水平扩展的。
>> >
>> > 7. Saga omega 处的代码重构时需要注意什么，以保证不会破坏原Saga/还未执行完毕的Saga？
>> > Saga omega只是通过切面编程的方式获取Saga调用事件，并触发对应的处理流程。
>> > 我不太明白你说的Saga omega处的代码重构是什么意思？解释一下吗？
>> >
>> > 8. Saga omega 在执行Saga过程中如果中断，那么重启后Saga还会继续执行吗？
>> > Saga协调管理的的服务调用如果支持幂等， 调用过程完成后重启Saga协调器 Alpha之后，是可以支持Saga恢复的。
>> >
>> > 9. 对于@SagaStart，@Compensable注释的方法，对其方法参数有何要求？
>> > 因为omega将记录Compensable标注的方法的调用参数来调用Compensable里面提供的补偿方法， 这些参数需要能够序列化。
>> > 目前对于SagaStart没有什么特别的要求，
>> >
>> >
>> > Willem Jiang
>> >
>> > Blog: http://willemjiang.blogspot.com (English)
>> >   http://jnn.iteye.com  (Chinese)
>> > Twitter: willemjiang
>> > Weibo: 姜宁willem
>> >
>> > On Tue, Mar 13, 2018 at 2:33 PM, Daniel Qian 
>> wrote:
>> >
>> >> Hi Willem Jiang, thanks for your reply.
>> >>
>> >> I'd like to help listing a FAQ for this project, but for now, I can
>> >> only provide Qs not As. Here is my Qs (sorry written in Chinese to
>> >> avoid poor english obscure the meaning):
>> >>
>> >> 1. Saga的执行是同步的还是异步的？发起Saga之后，是等所有Sub-transaction都完成才返回，还是立即返回？
>> >> 2. Saga是并行还是顺序执行Sub-transaction的？
>> >> 3. Saga对于do、compenstation的实现有什么要求？
>> >> 4. Saga保证了A、C、I、D中的哪些部分？
>> >> 5. Saga可以嵌套吗？
>> >> 6. 如何水平扩展Saga Alpha？
>> >> 7. Saga omega 处的代码重构时需要注意什么，以保证不会破坏原Saga/还未执行完毕的Saga？
>> >> 8. Saga omega 在执行Saga过程中如果中断，那么重启后Saga还会继续执行吗？
>> >> 9. 对于@SagaStart，@Compensable注释的方法，对其方法参数有何要求？
>> >>
>> >> Hi  Zheng Feng, thanks for your reply, too.
>> >>
>> >> I watched Richardson's presentation
>> >> (https://www.infoq.com/presentations/saga-microservices) and he talked
>> >> about ACD:
>> >>
>> >> A：all sub-transaction are executed OR all are compensated
>> >> C：local consistency is handled by service. cross-service consistency
>> >> is handled by application
>> >> D：durability is handled by local database
>> >>
>> >> These definitions are a little different from which defined in
>> >> traditional transactions (https://en.wikipedia.org/wiki/ACID).
>> >>
>> >> So I think even though "traditional transaction" and "distributed
>> >> transaction" are all called "transactions", but they are different
>> >> things.
>> >>
>> >> Unlike traditional transaction ACID are guaranteed by techs such as JTA,
>> >> XA.
>> >>
>> >> In distributed transactions(Saga, TCC, etc) ACD are guaranteed by
>> >> service/application code.
>> >>
>> >> So this ACID is not that ACID (此ACID非彼ACID), this transaction is not
>> >> that transaction(此事务非彼事务).
>> >>
>> >> I think we can clarify that in the doc.
>> >>
>> >> 2018-03-12 18:05 GMT+08:00 Zheng Feng :
>> >> > Well, that could be an interesting question. I think it depends on how
>> >> you
>> >> > define what is "all or nothing". For a example of booking which is
>> often
>> >> > used in the Saga transaction.
>> >> > The request of the user is that "WE HAVE TO BOOKING A FLIGHT PEK-SHA
>> AND
>> >> > TWO NIGHTS IN SHANGHAI HOTEL"
>> >> >
>> >> > 1. Start a Saga transaction
>> >> > 2. booking a flight
>> >> > 3. booking a hotel
>> >> > 4a. ALL bookings are OK ( We get "all")
>> >> > 4b. booking a hotel is failed, we have to compensate to cancel the
>> flight
>> >> > (We get "nothing")
>> >> > 5. End a Saga transaction
>> >> >
>> >> > So from the user's perspective, they get "all or nothing" and from the
>> >> > database it could have something changed ( the status of the flight
>> >> booking
>> >> > order). And I 

[GitHub] coveralls commented on issue #153: SCB-395 add guides to run demo without docker compose

[GitBox]

coveralls commented on issue #153: SCB-395 add guides to run demo without 
docker compose
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/153#issuecomment-372895796
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15984656/badge)](https://coveralls.io/builds/15984656)
   
   Coverage decreased (-0.1%) to 95.285% when pulling 
**4ed7e021938573a8dec06297ff08ee5fbf35ff17 on eric-lee-ltk:SCB-395** into 
**fc3f2ae1752e8a46d225138d80c0e92860f45363 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #594: [SCB-379] support AsyncRestTemplate

[GitBox]

wujimin commented on issue #594: [SCB-379] support AsyncRestTemplate
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#issuecomment-373224531
 
 
   no need to wrap like restTemplate, just work for serviceComb  
   if someone need to work for 3rd rest server, then new a native 
AsyncRestTemplate.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #588: [SCB-394] framework version support SC which earlier than 1.0.0

[GitBox]

wujimin commented on issue #588: [SCB-394] framework version support SC which 
earlier than 1.0.0
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/588#issuecomment-373222534
 
 
   not only this one feature need compatible logic  
   there are more and more features need compatible logic in the furture  
   so we should not ask all the features to query version from SC.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #588: [SCB-394] framework version support SC which earlier than 1.0.0

[GitBox]

wujimin commented on issue #588: [SCB-394] framework version support SC which 
earlier than 1.0.0
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/588#issuecomment-37307
 
 
   oh. in pull mode, there is no "connected" event  
   and then pull from LB can not  know talking to whick one SC instance.
   
   so, maybe just make sure it's the first api send to SC


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] gupadhyaya commented on issue #298: Some questions about PACT broker in SC

[GitBox]

gupadhyaya commented on issue #298: Some questions about PACT broker in SC
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/298#issuecomment-373090348
 
 
   @little-cui @asifdxtreme 
   Regarding 1), I have provided a document explaining how to integrate the 
broker with third-party Pact JVM library. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: 关于java-chassis的Invocation实现缺陷的讨论

[Willem Jiang]

参数元数据信息可以从方法签名中获取，Invocatioon转换过程中是否可以加入一个尝试转换的逻辑。
也就是调用参数不一致的时候，看看能不能尝试一下自动转换。


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

2018-03-14 10:33 GMT+08:00 bismy :

> 目前在分析如下业务场景。
> 场景1：--
> Provider:定义一个借口
> @GetMapping
> public demo.Foo doSomething(demo.Bar request)
> Consumer: 使用RestTemplate调用接口：
> restTempalte.getForObject(url, otherDemo.Foo.class)
>
>
> java-chassis要求Foo的package名字完全一样。
>
>
> 场景2：-
> 同样是上面的代码。 Spring MVC支持GET的query参数映射到Bar的 属性, java-chassis不支持。
>
>
> 满足这些场景，需要在解析网络层的数据到Invocaton的时候(args参数），需要知道接口定义的元数据信息（
> 比如class类型），而这些在契约里面是不能体现的（因为契约和语言无关）
>
>
>
>
> 产生这种情况的本质原因是Invocation的args是语言有关的内容。
>
>
> 建议：
>
>
> Invocation的args做修改，尽可能体现一种契约描述的中立的数据结构，这个数据结构可以使用类似HttpServletRequest
> /HttpServletResponse的结构（越贴近契约越好，但要考虑网络层转换和编码层转换的性能）。
> 这样的话网络层到Invocation可以做极小的转换。
> 编码层可以结合代码的元数据和Invocation的的契约元数据将Invocation转换为args。
>
>
> 由于这个涉及到兼容性问题，针对上面的场景和实现优化， 大家有什么建议？

Re: A question about ACID guarantees Saga provides

[Willem Jiang]

首先应用App启动时候，如果版本信息（应用名 + 版本号）发生变化可以通过Omega通知Alpha。
这样就不不会出现版本执行错误的情况。

对于你举的1.0 升级到 2.0 的情况可能需要通过优雅停机的方式来解决了。
因为App 1.0 可能会有多个实例， Alpha在执行回滚的过程中如果只通过Omega来回调的话很难解决实例突然终止的问题，
我现在想到的办法是让Alpha直接调用App 1.0提供的恢复服务接口。
如果App1.0的服务接口是幂等的且无状态的话，那我们还是能够做到事务的最终一致。




Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Wed, Mar 14, 2018 at 9:20 AM, Daniel Qian  wrote:

> Thanks a lot, Willem Jiang, 关于Q7我举个例子来说明我的意思：
>
> App version 1.0 里的Saga是这样的：call methodA, call methodB
> App version 2.0 里的代码是这样的：call methodA, call methodC
>
> 把App从1.0 升级到 2.0必定需要将原1.0的App进程停止，然后启动2.0的App进程。
> 在停止1.0的App进程的时候，可能会出现Saga只执行了一半。
>
> 那么启动2.0的App进程之后，会出现以下哪种情况：
>
> 1. 1.0 App的未执行完成的Saga永远保持未完成状态
> 2. 会Saga Alpha会尝试使用2.0App的代码，继续执行未完成Saga
>
> 2018-03-13 22:52 GMT+08:00 Willem Jiang :
> > Hi Dainiel
> >
> > Here are my answer to you question， we will write an english version for
> it
> > shortly.
> >
> > 1. Saga的执行是同步的还是异步的？发起Saga之后，是等所有Sub-transaction都完成才返回，还是立即返回？
> > 目前Saga事情的执行是同步的，后续我们会提供异步方式的实现。
> >
> >
> > 2. Saga是并行还是顺序执行Sub-transaction的？
> > Saga pack 是根据调用的代码来决定Saga事件，如果Saga子事件是并行方式调用的， 那Saga协调器也是采用并行方式进行处理的。
> >
> > 3. Saga对于do、compenstation的实现有什么要求？
> > 对服务调用要求是要支持幂等的。
> >
> > 4. Saga保证了A、C、I、D中的哪些部分？
> > 按照前面的回复， Saga 支持 ACD。
> >
> > 5. Saga可以嵌套吗？
> > Saga实现支持子事件嵌套的方式。
> >
> > 6. 如何水平扩展Saga Alpha？
> > Saga Alpha在设计过程中状态信息都存储到数据库，是支持水平扩展的。
> >
> > 7. Saga omega 处的代码重构时需要注意什么，以保证不会破坏原Saga/还未执行完毕的Saga？
> > Saga omega只是通过切面编程的方式获取Saga调用事件，并触发对应的处理流程。
> > 我不太明白你说的Saga omega处的代码重构是什么意思？解释一下吗？
> >
> > 8. Saga omega 在执行Saga过程中如果中断，那么重启后Saga还会继续执行吗？
> > Saga协调管理的的服务调用如果支持幂等， 调用过程完成后重启Saga协调器 Alpha之后，是可以支持Saga恢复的。
> >
> > 9. 对于@SagaStart，@Compensable注释的方法，对其方法参数有何要求？
> > 因为omega将记录Compensable标注的方法的调用参数来调用Compensable里面提供的补偿方法， 这些参数需要能够序列化。
> > 目前对于SagaStart没有什么特别的要求，
> >
> >
> > Willem Jiang
> >
> > Blog: http://willemjiang.blogspot.com (English)
> >   http://jnn.iteye.com  (Chinese)
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Tue, Mar 13, 2018 at 2:33 PM, Daniel Qian 
> wrote:
> >
> >> Hi Willem Jiang, thanks for your reply.
> >>
> >> I'd like to help listing a FAQ for this project, but for now, I can
> >> only provide Qs not As. Here is my Qs (sorry written in Chinese to
> >> avoid poor english obscure the meaning):
> >>
> >> 1. Saga的执行是同步的还是异步的？发起Saga之后，是等所有Sub-transaction都完成才返回，还是立即返回？
> >> 2. Saga是并行还是顺序执行Sub-transaction的？
> >> 3. Saga对于do、compenstation的实现有什么要求？
> >> 4. Saga保证了A、C、I、D中的哪些部分？
> >> 5. Saga可以嵌套吗？
> >> 6. 如何水平扩展Saga Alpha？
> >> 7. Saga omega 处的代码重构时需要注意什么，以保证不会破坏原Saga/还未执行完毕的Saga？
> >> 8. Saga omega 在执行Saga过程中如果中断，那么重启后Saga还会继续执行吗？
> >> 9. 对于@SagaStart，@Compensable注释的方法，对其方法参数有何要求？
> >>
> >> Hi  Zheng Feng, thanks for your reply, too.
> >>
> >> I watched Richardson's presentation
> >> (https://www.infoq.com/presentations/saga-microservices) and he talked
> >> about ACD:
> >>
> >> A：all sub-transaction are executed OR all are compensated
> >> C：local consistency is handled by service. cross-service consistency
> >> is handled by application
> >> D：durability is handled by local database
> >>
> >> These definitions are a little different from which defined in
> >> traditional transactions (https://en.wikipedia.org/wiki/ACID).
> >>
> >> So I think even though "traditional transaction" and "distributed
> >> transaction" are all called "transactions", but they are different
> >> things.
> >>
> >> Unlike traditional transaction ACID are guaranteed by techs such as JTA,
> >> XA.
> >>
> >> In distributed transactions(Saga, TCC, etc) ACD are guaranteed by
> >> service/application code.
> >>
> >> So this ACID is not that ACID (此ACID非彼ACID), this transaction is not
> >> that transaction(此事务非彼事务).
> >>
> >> I think we can clarify that in the doc.
> >>
> >> 2018-03-12 18:05 GMT+08:00 Zheng Feng :
> >> > Well, that could be an interesting question. I think it depends on how
> >> you
> >> > define what is "all or nothing". For a example of booking which is
> often
> >> > used in the Saga transaction.
> >> > The request of the user is that "WE HAVE TO BOOKING A FLIGHT PEK-SHA
> AND
> >> > TWO NIGHTS IN SHANGHAI HOTEL"
> >> >
> >> > 1. Start a Saga transaction
> >> > 2. booking a flight
> >> > 3. booking a hotel
> >> > 4a. ALL bookings are OK ( We get "all")
> >> > 4b. booking a hotel is failed, we have to compensate to cancel the
> flight
> >> > (We get "nothing")
> >> > 5. End a Saga transaction
> >> >
> >> > So from the user's perspective, they get "all or nothing" and from the
> >> > database it could have something changed ( the status of the flight
> >> booking
> >> > order). And I think this is why the Saga pattern relax the "ISOLATION"
> >> > attribute from the ACID.
> >> >
> >> > I hope it could be helpful for you to understand the Saga transaction.
> >> >
> >> > 2018-03-12 16:47 GMT+08:00 Daniel Qian :
> 

Re: License and Notice files checking

[Willem Jiang]

FYI, We just updated the binary releases NOTICE files[1][2][3] by adding
the NOTICE of  bundled third party dependencies which use Apache License
according to the legal  suggestions [4] [5]  of Apache.

Please let us know if there is anything that we are missing.


[1]https://github.com/apache/incubator-servicecomb-service-
center/blob/master/scripts/release/NOTICE
[2]https://github.com/apache/incubator-servicecomb-java-
chassis/blob/master/java-chassis-distribution/src/release/NOTICE
[3]https://github.com/apache/incubator-servicecomb-saga/
blob/master/saga-distribution/src/release/NOTICE
[4]https://issues.apache.org/jira/browse/LEGAL-262
[5]https://issues.apache.org/jira/browse/LEGAL-354


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Tue, Mar 13, 2018 at 11:00 AM, Roman Shaposhnik 
wrote:

> These looks very reasonable to me. Of course, the ones accompanying
> binary releases
> will have to be parsed in context of what the binary release actually
> looks like.
>
> Thanks,
> Roman.
>
> On Fri, Mar 9, 2018 at 6:15 PM, Willem Jiang 
> wrote:
> > Hi Mentors,
> >
> > I just listed all the License and Notice files of the ServiceComb
> projects,
> > please have a quick look if you have time.
> >
> > 1. ServiceCenter
> > Source：
> > LICENSE
> > https://github.com/apache/incubator-servicecomb-service-
> center/blob/master/LICENSE
> > NOTICE
> > https://github.com/apache/incubator-servicecomb-service-
> center/blob/master/NOTICE
> > Binary：
> > LICENSE
> > https://github.com/apache/incubator-servicecomb-service-
> center/blob/master/scripts/release/LICENSE
> > NOTICE
> > https://github.com/apache/incubator-servicecomb-service-
> center/blob/master/scripts/release/NOTICE
> >
> > 2. JavaChassis
> > Source：
> > LICENSE
> > https://github.com/apache/incubator-servicecomb-java-
> chassis/blob/master/LICENSE
> > NOTICE
> > https://github.com/apache/incubator-servicecomb-java-
> chassis/blob/master/NOTICE
> > Binary：
> > LICENSE
> > https://github.com/apache/incubator-servicecomb-java-
> chassis/blob/master/java-chassis-distribution/src/release/LICENSE
> > NOTICE
> > https://github.com/apache/incubator-servicecomb-java-
> chassis/blob/master/java-chassis-distribution/src/release/NOTICE
> >
> > 3. Saga
> > Source：
> > LICENSE
> > https://github.com/apache/incubator-servicecomb-saga/blob/master/LICENSE
> > NOTICE
> > https://github.com/apache/incubator-servicecomb-saga/blob/master/NOTICE
> > Binary：
> > LICENSE
> > https://github.com/apache/incubator-servicecomb-saga/
> blob/master/saga-distribution/src/release/LICENSE
> > NOTICE
> > https://github.com/apache/incubator-servicecomb-saga/
> blob/master/saga-distribution/src/release/NOTICE
> >
> >
> > Willem Jiang
> >
> > Blog: http://willemjiang.blogspot.com (English)
> >   http://jnn.iteye.com  (Chinese)
> > Twitter: willemjiang
> > Weibo: 姜宁willem
>

[GitHub] wujimin commented on issue #588: [SCB-394] framework version support SC which earlier than 1.0.0

[GitBox]

wujimin commented on issue #588: [SCB-394] framework version support SC which 
earlier than 1.0.0
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/588#issuecomment-373020511
 
 
   1.save serviceCenterInfo in AbstractServiceRegistry, when connected to 
serviceCenter then fetch this information  
   2.compare version by class "Version" 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #591: [SCB-396] java-sdk needs to distinguish the instance belongs to the devops stage(environment)

[GitBox]

coveralls commented on issue #591: [SCB-396] java-sdk needs to distinguish the 
instance belongs to the devops stage(environment)
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/591#issuecomment-372568005
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15969480/badge)](https://coveralls.io/builds/15969480)
   
   Coverage increased (+0.04%) to 87.241% when pulling 
**728ec0202a48a8b329c70e175402d7eff0850235 on weichao666:qufendevops** into 
**0c2e8d55f10e55174427429f58376a06be9cf5b2 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Fw: Request the Permission using Apache ServiceCom(incubating) name in our Meetup

[Sally Khudairi]

You're most welcome. We wish you the best with your event!

If you have a link, I'll be happy to promote it in the "Apache Community
Notices" section of this week's edition of the Apache Weekly News Round-
up https://blogs.apache.org/foundation/entry/the-apache-news-round-up61
Kind regards,
Sally

- - -
Vice President Marketing & Publicity
The Apache Software Foundation

Tel +1 617 921 8656
Skype sallykhudairi


On Wed, Mar 14, 2018, at 09:00, Willem Jiang wrote:
> Hi Sally,
> 
> It's great to hear that. 
> Thanks for your help.
> 
> 
> 
> Willem Jiang
> 
> Blog: http://willemjiang.blogspot.com (English)
>http://jnn.iteye.com  (Chinese)
>  Twitter: willemjiang
>  Weibo: 姜宁willem
> 
> On Wed, Mar 14, 2018 at 5:56 PM, Sally Khudairi  wrote:>> __
>> Thank you, Willem.
>> 
>> Yes, that is permissable.
>> 
>> 
>> Kind regards,
>> Sally
>> 
>> - - -
>> Vice President Marketing & Publicity
>> The Apache Software Foundation
>> 
>> Tel +1 617 921 8656[1]
>> Skype sallykhudairi
>> 
>> 
>> 
>> - Forwarded Message - **From:** Willem Jiang
>> >> **To:** Sally Khudairi  **Cc:**
>> dev@servicecomb.apache.org; ASF ComDev ;
>> ASF Marketing & Publicity  **Sent:** Wednesday,
>> March 14, 2018 1:48 AM **Subject:** Re: Fw: Request the Permission
>> using Apache ServiceCom(incubating) name in our Meetup>> 
>>> 
>>> Hi Sally，
>>> 
>>> As 树人云 doesn't use Apache ServiceComb to build their PaaS product
>>> and we both want to build up the community about building
>>> microservice.>>> Can we change the event name to " Building Microservice 
>>> Meetup
>>> presented by Apache ServiceComb(incubating) && 树人云"?>>> 
>>> 
>>> 
>>> Willem Jiang
>>> 
>>> Blog: http://willemjiang.blogspot.com[2] (English)
>>>   http://jnn.iteye.com[3]  (Chinese)
>>> Twitter: willemjiang
>>> Weibo: 姜宁willem
>>> 
>>> On Wed, Mar 14, 2018 at 12:01 PM, Sally Khudairi 
>>> wrote: __
 Thank you, Willem.
 
 As the ASF is vendor-neutral, you may state the event as "Apache
 ServiceComb (incubating) MeetUp presented by 树人云" but they cannot
 be combined together. "Presented" is just a suggestion: it can be
 "hosted", "supported", or other such words. 
 I appreciate that you are having Apache Skywalking (incubating) at
 the event as well. I had responded to Sheng, but the email bounced: 
 >  :
 >  Sorry, I couldn't find any host named foxmail.com[4]. (#5.1.2)
 
 
 Thank you in advance for keeping us informed of your activities.
 
 Warm regards,
 Sally
 
 
 - - -
 Vice President Marketing & Publicity
 The Apache Software Foundation
 
 Tel +1 617 921 8656
 Skype sallykhudairi
 
 
 On Tue, Mar 13, 2018, at 23:40, Willem Jiang wrote:
> Hi Sally, 
> 
> Actually the meetup is holded by two community, one is "Apache
> ServiceComb(incubating)", the other is "树人云" a startup cloud
> company provides PaaS platform.> And we use  "Apache 
> ServiceComb(incubating) && 树人云 ” as the meetup
> name.> 
> BTW， We also invited "Apache Skywalking(incubating)" as a
> presenter  to join our meetup.> 
> 
> Willem Jiang
> 
> Blog: http://willemjiang.blogspot. com[5] (English)
>   http://jnn.iteye.com[6]  (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
> 
> On Wed, Mar 14, 2018 at 11:13 AM, Sally Khudairi 
> wrote:>> __
>> Hello Willem --thank you for your message.
>> 
>> There are no issues with your use of the podling name to help
>> promote your event and help build your community as long as the
>> naming is along the lines of "Apache ServiceComb (incubating)
>> MeetUp".  If you can please confirm the name of your event, we'd
>> appreciate it.>> 
>> I am copying ASF Community Development ("ComDev") here for their
>> attention and follow-up as needed.>> 
>> Welcome to the Apache family; do let me know if there's anything
>> else we can help with.>> 
>> Kind regards,
>> Sally
>> 
>> - - -
>> Vice President Marketing & Publicity
>> The Apache Software Foundation
>> 
>> Tel +1 617 921 8656
>> Skype sallykhudairi
>> 
>>
>> - Forwarded Message - **From:** Willem Jiang
>>  **To:** pr...@apache.org **Cc:**
>> dev@servicecomb.apache.org **Sent:** Tuesday, March 13, 2018
>> 10:45 PM **Subject:** Request the Permission using Apache
>> ServiceCom(incubating) name in our Meetup>>> 
>>> Hi ASF Marketing & Publicity,
>>> 
>>> We will hold a meetup in Beijing, China at March 31, 2018, by
>>> using Apache ServiceComb(incubating) as part of the event name
>>> to build up the Apache ServiceComb community.>>> 
>>> I want through 

Re: Fw: Request the Permission using Apache ServiceCom(incubating) name in our Meetup

[Willem Jiang]

Hi Sally,

It's great to hear that.
Thanks for your help.



Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Wed, Mar 14, 2018 at 5:56 PM, Sally Khudairi  wrote:

> Thank you, Willem.
>
> Yes, that is permissable.
>
> Kind regards,
> Sally
>
> - - -
> Vice President Marketing & Publicity
> The Apache Software Foundation
>
> Tel +1 617 921 8656 <(617)%20921-8656>
> Skype sallykhudairi
>
>
> - Forwarded Message -
> *From:* Willem Jiang 
> *To:* Sally Khudairi 
> *Cc:* dev@servicecomb.apache.org; ASF ComDev ;
> ASF Marketing & Publicity 
> *Sent:* Wednesday, March 14, 2018 1:48 AM
> *Subject:* Re: Fw: Request the Permission using Apache
> ServiceCom(incubating) name in our Meetup
>
>
> Hi Sally，
>
> As 树人云 doesn't use Apache ServiceComb to build their PaaS product and we
> both want to build up the community about building microservice.
> Can we change the event name to " Building Microservice Meetup presented
> by Apache ServiceComb(incubating) && 树人云"?
>
>
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
>   http://jnn.iteye.com  (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Wed, Mar 14, 2018 at 12:01 PM, Sally Khudairi  wrote:
>
>
> Thank you, Willem.
>
> As the ASF is vendor-neutral, you may state the event as "Apache
> ServiceComb (incubating) MeetUp presented by 树人云" but they cannot be
> combined together. "Presented" is just a suggestion: it can be "hosted",
> "supported", or other such words.
>
> I appreciate that you are having Apache Skywalking (incubating) at the
> event as well. I had responded to Sheng, but the email bounced:
>
> >  :
> >  Sorry, I couldn't find any host named foxmail.com. (#5.1.2)
>
>
> Thank you in advance for keeping us informed of your activities.
>
> Warm regards,
> Sally
>
>
> - - -
> Vice President Marketing & Publicity
> The Apache Software Foundation
>
> Tel +1 617 921 8656
> Skype sallykhudairi
>
>
> On Tue, Mar 13, 2018, at 23:40, Willem Jiang wrote:
>
> Hi Sally,
>
> Actually the meetup is holded by two community, one is "Apache
> ServiceComb(incubating)", the other is "树人云" a startup cloud company
> provides PaaS platform.
> And we use  "Apache ServiceComb(incubating) && 树人云 ” as the meetup name.
>
> BTW， We also invited "Apache Skywalking(incubating)" as a presenter  to
> join our meetup.
>
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot. com 
> (English)
>   http://jnn.iteye.com  (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Wed, Mar 14, 2018 at 11:13 AM, Sally Khudairi  wrote:
>
>
> Hello Willem --thank you for your message.
>
> There are no issues with your use of the podling name to help promote your
> event and help build your community as long as the naming is along the
> lines of "Apache ServiceComb (incubating) MeetUp".  If you can please
> confirm the name of your event, we'd appreciate it.
>
> I am copying ASF Community Development ("ComDev") here for their attention
> and follow-up as needed.
>
> Welcome to the Apache family; do let me know if there's anything else we
> can help with.
>
> Kind regards,
> Sally
>
> - - -
> Vice President Marketing & Publicity
> The Apache Software Foundation
>
> Tel +1 617 921 8656
> Skype sallykhudairi
>
>
> - Forwarded Message -
> *From:* Willem Jiang 
> *To:* pr...@apache.org
> *Cc:* dev@servicecomb.apache.org
> *Sent:* Tuesday, March 13, 2018 10:45 PM
> *Subject:* Request the Permission using Apache ServiceCom(incubating)
> name in our Meetup
>
>
> Hi ASF Marketing & Publicity,
>
> We will hold a meetup in Beijing, China at March 31, 2018, by using Apache
> ServiceComb(incubating) as part of the event name to build up the Apache
> ServiceComb community.
>
> I want through the document of small-events tips[1], which said we need
> approve from the PMC. As ServiceComb is in the Apache incubator,  so we
> only has PPMC for project management, and there is no detail guide for
> holding the event with project name in the incubator guide.
>
> So I just ask for permission of using the name of Apache
> ServiceComb(incubating) in this meetup.
>
> [1]http://community.apache.org /events/small-events.html
> 
>
> Thanks,
>
> Willem Jiang
>
>
>
>
>
>
>
>

[GitHub] liubao68 closed pull request #591: [SCB-396] java-sdk needs to distinguish the instance belongs to the devops stage(environment)

[GitBox]

liubao68 closed pull request #591: [SCB-396] java-sdk needs to distinguish the 
instance belongs to the devops stage(environment)
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/591
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/base/ServiceCombConstants.java
 
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/base/ServiceCombConstants.java
index e6613fa3e..22e4709cc 100644
--- 
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/base/ServiceCombConstants.java
+++ 
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/base/ServiceCombConstants.java
@@ -61,4 +61,7 @@
 
   String CONFIG_DEFAULT_REGISTER_BY = "SDK";
 
+  String SERVICECOMB_ENV = "SERVICECOMB_ENV";
+
+  String DEFAULT_SERVICECOMB_ENV = "";
 }
diff --git a/foundations/foundation-config/src/main/resources/mapping.yaml 
b/foundations/foundation-config/src/main/resources/mapping.yaml
index baac846af..0346b782e 100644
--- a/foundations/foundation-config/src/main/resources/mapping.yaml
+++ b/foundations/foundation-config/src/main/resources/mapping.yaml
@@ -19,3 +19,6 @@ eureka:
   client:
 serviceUrl:
   defaultZone: registry.client.serviceUrl.defaultZone
+
+service_description:
+  environment: SERVICECOMB_ENV
\ No newline at end of file
diff --git 
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/Microservice.java
 
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/Microservice.java
index 1694ef0cb..6e9007259 100644
--- 
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/Microservice.java
+++ 
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/Microservice.java
@@ -38,6 +38,8 @@
 
   private String registerBy;
 
+  private String environment;
+
   private String appId;
 
   private String serviceName;
@@ -209,4 +211,12 @@ public String getRegisterBy() {
   public void setRegisterBy(String registerBy) {
 this.registerBy = registerBy;
   }
+
+  public String getEnvironment() {
+return environment;
+  }
+
+  public void setEnvironment(String environment) {
+this.environment = environment;
+  }
 }
diff --git 
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/MicroserviceFactory.java
 
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/MicroserviceFactory.java
index 5c0c9735c..4e40aa10e 100644
--- 
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/MicroserviceFactory.java
+++ 
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/MicroserviceFactory.java
@@ -24,6 +24,8 @@
 import static 
org.apache.servicecomb.foundation.common.base.ServiceCombConstants.CONFIG_QUALIFIED_MICROSERVICE_ROLE_KEY;
 import static 
org.apache.servicecomb.foundation.common.base.ServiceCombConstants.CONFIG_QUALIFIED_MICROSERVICE_VERSION_KEY;
 import static 
org.apache.servicecomb.foundation.common.base.ServiceCombConstants.DEFAULT_MICROSERVICE_NAME;
+import static 
org.apache.servicecomb.foundation.common.base.ServiceCombConstants.SERVICECOMB_ENV;
+import static 
org.apache.servicecomb.foundation.common.base.ServiceCombConstants.DEFAULT_SERVICECOMB_ENV;
 import static 
org.apache.servicecomb.serviceregistry.definition.DefinitionConst.CONFIG_ALLOW_CROSS_APP_KEY;
 import static 
org.apache.servicecomb.serviceregistry.definition.DefinitionConst.DEFAULT_APPLICATION_ID;
 import static 
org.apache.servicecomb.serviceregistry.definition.DefinitionConst.DEFAULT_MICROSERVICE_VERSION;
@@ -60,6 +62,7 @@ private Microservice 
createMicroserviceFromDefinition(Configuration configuratio
 
microservice.setPaths(ConfigurePropertyUtils.getMicroservicePaths(configuration));
 Map propertiesMap = 
MicroservicePropertiesLoader.INSTANCE.loadProperties(configuration);
 microservice.setProperties(propertiesMap);
+microservice.setEnvironment(configuration.getString(SERVICECOMB_ENV, 
DEFAULT_SERVICECOMB_ENV));
 
 // set alias name when allow cross app
 if (allowCrossApp(propertiesMap)) {
diff --git 
a/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/api/registry/TestMicroService.java
 
b/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/api/registry/TestMicroService.java
index 9db34da4e..c1ef3f5ab 100644
--- 
a/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/api/registry/TestMicroService.java
+++ 

[GitHub] weichao666 opened a new pull request #591: [SCB-396] java-sdk needs to distinguish the instance belongs to the devops stage(environment)

[GitBox]

weichao666 opened a new pull request #591: [SCB-396] java-sdk needs to 
distinguish the instance belongs to the devops stage(environment)
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/591
 
 
   …evops stage(environment)
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on a change in pull request #594: [SCB-379] support AsyncRestTemplate

[GitBox]

liubao68 commented on a change in pull request #594: [SCB-379] support 
AsyncRestTemplate
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#discussion_r174441501
 
 

 ##
 File path: 
providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequest.java
 ##
 @@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.provider.springmvc.reference.async;
+
+import java.io.OutputStream;
+import java.net.URI;
+import java.util.concurrent.CompletableFuture;
+
+import org.apache.servicecomb.common.rest.RestConst;
+import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.core.invocation.InvocationFactory;
+import org.apache.servicecomb.core.provider.consumer.InvokerUtils;
+import 
org.apache.servicecomb.provider.springmvc.reference.CseClientHttpRequest;
+import 
org.apache.servicecomb.provider.springmvc.reference.CseClientHttpResponse;
+import org.apache.servicecomb.swagger.invocation.Response;
+import org.springframework.http.HttpMethod;
+import org.springframework.http.client.AsyncClientHttpRequest;
+import org.springframework.http.client.ClientHttpResponse;
+import 
org.springframework.util.concurrent.CompletableToListenableFutureAdapter;
+import org.springframework.util.concurrent.ListenableFuture;
+
+import io.netty.handler.codec.http.QueryStringDecoder;
+
+public class CseAsyncClientHttpRequest extends CseClientHttpRequest implements 
AsyncClientHttpRequest {
+
+  CseAsyncClientHttpRequest() {
+  }
+
+  CseAsyncClientHttpRequest(URI uri, HttpMethod method) {
+this.setUri(uri);
+this.setMethod(method);
+  }
+
+  @Override
+  public OutputStream getBody() {
+return null;
+  }
+
+  @SuppressWarnings("unchecked")
+  private ListenableFuture invoke(Object[] args) {
+Invocation invocation =
+
InvocationFactory.forConsumer(this.getRequestMeta().getReferenceConfig(),
+this.getRequestMeta().getOperationMeta(),
+args);
+invocation.getHandlerContext().put(RestConst.REST_CLIENT_REQUEST_PATH,
+this.getPath() + "?" + this.getURI().getRawQuery());
+
+if (this.getContext() != null) {
+  invocation.addContext(this.getContext());
+}
+invocation.getHandlerContext().put(RestConst.CONSUMER_HEADER, 
this.getHeaders());
+CompletableFuture completableFuture = new 
CompletableFuture<>();
+InvokerUtils.reactiveInvoke(invocation, (Response response) -> {
+  if (response.isSuccessed()) {
 
 Review comment:
   How about response is failed or unexpected exception happens? And can you 
please add test cases (examples) to demonstrate this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #595: [SCB-398]fix config cc do not select other instances when error happens

[GitBox]

coveralls commented on issue #595: [SCB-398]fix config cc do not select other 
instances when error happens
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/595#issuecomment-372999877
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15968738/badge)](https://coveralls.io/builds/15968738)
   
   Coverage increased (+0.02%) to 87.232% when pulling 
**a3ebb3cf271c1c72e8d33001e300a21d0cc27ea4 on liubao68:feature_get_pojo** into 
**d9ed28679f7cd87c0b4af31b385ff83d00a90249 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 opened a new pull request #595: [SCB-398]fix config cc do not select other instances when error happens

[GitBox]

liubao68 opened a new pull request #595: [SCB-398]fix config cc do not select 
other instances when error happens
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/595
 
 
   when configured multiple cc addresses and error happens, will not change an 
available one
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang closed pull request #308: [SCB-367] Add third party notices

[GitBox]

WillemJiang closed pull request #308: [SCB-367] Add third party notices
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/308
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/scripts/release/NOTICE b/scripts/release/NOTICE
index 8bbaad36..80caf98f 100644
--- a/scripts/release/NOTICE
+++ b/scripts/release/NOTICE
@@ -4,3 +4,88 @@ Copyright 2017-2018 The Apache Software Foundation
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
 
+
+
+Notice for gopkg.in/yaml.v2:
+
+See licenses/NOTICE-yamlv2
+
+
+Notice for coreos/etcd
+
+CoreOS Project
+Copyright 2014 CoreOS, Inc
+
+This product includes software developed at CoreOS, Inc.
+(http://www.coreos.com/).
+
+
+Notice for coreos/go-systemd
+
+CoreOS Project
+Copyright 2018 CoreOS, Inc
+
+This product includes software developed at CoreOS, Inc.
+(http://www.coreos.com/).
+
+
+Notice for coreos/go-semver
+
+CoreOS Project
+Copyright 2018 CoreOS, Inc
+
+This product includes software developed at CoreOS, Inc.
+(http://www.coreos.com/).
+
+
+Notice for coreos/pkg
+
+CoreOS Project
+Copyright 2014 CoreOS, Inc
+
+This product includes software developed at CoreOS, Inc.
+(http://www.coreos.com/).
+
+
+Notice for matttproud/golang_protobuf_extensions
+
+Copyright 2012 Matt T. Proud (matt.pr...@gmail.com)
+
+
+Notice for prometheus/client_golang
+
+See licenses/NOTICE-prometheus
+
+
+Notice for prometheus/client_model
+
+Data model artifacts for Prometheus.
+Copyright 2012-2015 The Prometheus Authors
+
+This product includes software developed at
+SoundCloud Ltd. (http://soundcloud.com/).
+
+
+Notice for prometheus/common
+
+Common libraries shared by Prometheus Go components.
+Copyright 2015 The Prometheus Authors
+
+This product includes software developed at
+SoundCloud Ltd. (http://soundcloud.com/).
+
+
+Notice for prometheus/procfs
+
+procfs provides functions to retrieve system, kernel and process
+metrics from the pseudo-filesystem proc.
+
+Copyright 2014-2015 The Prometheus Authors
+
+This product includes software developed at
+SoundCloud Ltd. (http://soundcloud.com/).
+
+
+Notice for cloudfoundry/lager
+
+See licenses/NOTICE-lager
diff --git a/scripts/release/licenses/NOTICE-lager 
b/scripts/release/licenses/NOTICE-lager
new file mode 100644
index ..37c2d516
--- /dev/null
+++ b/scripts/release/licenses/NOTICE-lager
@@ -0,0 +1,21 @@
+Copyright (c) 2015-Present CloudFoundry.org Foundation, Inc. All Rights 
Reserved.
+
+This project contains software that is Copyright (c) 2014-2015 Pivotal 
Software, Inc.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+
+This project may include a number of subcomponents with separate
+copyright notices and license terms. Your use of these subcomponents
+is subject to the terms and conditions of each subcomponent's license,
+as noted in the LICENSE file.
+
diff --git a/scripts/release/licenses/NOTICE-prometheus 
b/scripts/release/licenses/NOTICE-prometheus
new file mode 100644
index ..dd878a30
--- /dev/null
+++ b/scripts/release/licenses/NOTICE-prometheus
@@ -0,0 +1,23 @@
+Prometheus instrumentation library for Go applications
+Copyright 2012-2015 The Prometheus Authors
+
+This product includes software developed at
+SoundCloud Ltd. (http://soundcloud.com/).
+
+
+The following components are included in this product:
+
+perks - a fork of https://github.com/bmizerany/perks
+https://github.com/beorn7/perks
+Copyright 2013-2015 Blake Mizerany, Björn Rabenstein
+See https://github.com/beorn7/perks/blob/master/README.md for license 

[GitHub] WillemJiang commented on issue #593: [SCB-260] Add third party notice

[GitBox]

WillemJiang commented on issue #593: [SCB-260] Add third party notice
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/593#issuecomment-372965114
 
 
   We need to remove the duplicated copyright of ASF products. 
   I will commit a quick fix for it shortly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang closed pull request #593: [SCB-260] Add third party notice

[GitBox]

WillemJiang closed pull request #593: [SCB-260] Add third party notice
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/593
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/java-chassis-distribution/src/release/LICENSE 
b/java-chassis-distribution/src/release/LICENSE
index fa2dbea95..b49905d9c 100644
--- a/java-chassis-distribution/src/release/LICENSE
+++ b/java-chassis-distribution/src/release/LICENSE
@@ -327,129 +327,125 @@ This product bundles the following libraries which are 
licensed
 under the Apache License v2.
 For details, see their respective project links.
 
+Apache Commons BeanUtils (http://commons.apache.org/proper/commons-beanutils/) 
commons-beanutils:commons-beanutils:jar:1.9.2
+Apache Commons Codec (http://commons.apache.org/proper/commons-codec/) 
commons-codec:commons-codec:jar:1.10
+Apache Commons Collections (http://commons.apache.org/collections/) 
commons-collections:commons-collections:jar:3.2.2
+Apache Commons Configuration (http://commons.apache.org/configuration/) 
commons-configuration:commons-configuration:jar:1.10
+Apache Commons Lang (http://commons.apache.org/proper/commons-lang/) 
org.apache.commons:commons-lang3:jar:3.3.2
+Apache Commons Logging (http://commons.apache.org/proper/commons-logging/) 
commons-logging:commons-logging:jar:1.2
+Apache HttpClient (http://hc.apache.org/httpcomponents-client) 
org.apache.httpcomponents:httpclient:jar:4.5.2
+Apache HttpCore (http://hc.apache.org/httpcomponents-core-ga) 
org.apache.httpcomponents:httpcore:jar:4.4.6
+Apache Log4j (http://logging.apache.org/log4j/1.2/) log4j:log4j:bundle:1.2.17
+Bean Validation API (http://beanvalidation.org) 
javax.validation:validation-api:jar:1.1.0.Final
+Brave Context: Log4J 1.2 
(https://github.com/kristofa/brave/brave-context-parent/brave-context-log4j12) 
io.zipkin.brave:brave-context-log4j12:jar:4.13.1
+Brave Instrumentation: Http Adapters 
(https://github.com/kristofa/brave/brave-instrumentation-parent/brave-instrumentation-http)
 io.zipkin.brave:brave-instrumentation-http:jar:4.13.1
+Brave Instrumentation: Servlet 
(https://github.com/kristofa/brave/brave-instrumentation-parent/brave-instrumentation-servlet)
 io.zipkin.brave:brave-instrumentation-servlet:jar:4.13.1
+Brave Spring Factory Beans 
(https://github.com/kristofa/brave/brave-spring-beans) 
io.zipkin.brave:brave-spring-beans:jar:4.13.1
+ClassMate (http://github.com/cowtowncoder/java-classmate) 
com.fasterxml:classmate:bundle:1.3.3
+Commons IO (http://commons.apache.org/io/) commons-io:commons-io:jar:2.4
+Commons Lang (http://commons.apache.org/lang/) 
commons-lang:commons-lang:jar:2.6
+FindBugs-jsr305 (http://findbugs.sourceforge.net/) 
com.google.code.findbugs:jsr305:jar:3.0.1
+Guava: Google Core Libraries for Java 
(http://code.google.com/p/guava-libraries/guava) 
com.google.guava:guava:bundle:16.0.1
+Hibernate Validator Engine 
(http://hibernate.org/validator/hibernate-validator) 
org.hibernate:hibernate-validator:jar:5.2.4.Final
 JBoss Logging 3 (http://www.jboss.org) 
org.jboss.logging:jboss-logging:jar:3.3.0.Final
-swagger-core 
(https://github.com/swagger-api/swagger-core/modules/swagger-core) 
io.swagger:swagger-core:bundle:1.5.12
-swagger-models 
(https://github.com/swagger-api/swagger-core/modules/swagger-models) 
io.swagger:swagger-models:bundle:1.5.12
-swagger-annotations 
(https://github.com/swagger-api/swagger-core/modules/swagger-annotations) 
io.swagger:swagger-annotations:bundle:1.5.12
+Jackson dataformat: CBOR 
(http://github.com/FasterXML/jackson-dataformats-binary) 
com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:bundle:2.8.7
+Jackson dataformat: protobuf 
(http://github.com/FasterXML/jackson-dataformats-binary) 
com.fasterxml.jackson.dataformat:jackson-dataformat-protobuf:bundle:2.9.2
+Jackson module: Afterburner 
(https://github.com/FasterXML/jackson-modules-base) 
com.fasterxml.jackson.module:jackson-module-afterburner:bundle:2.7.5
+Jackson module: JAXB-annotations 
(http://github.com/FasterXML/jackson-module-jaxb-annotations) 
com.fasterxml.jackson.module:jackson-module-jaxb-annotations:bundle:2.8.7
+Jackson-annotations (http://github.com/FasterXML/jackson) 
com.fasterxml.jackson.core:jackson-annotations:bundle:2.9.2
+Jackson-core (https://github.com/FasterXML/jackson-core) 
com.fasterxml.jackson.core:jackson-core:bundle:2.9.2
+Jackson-dataformat-XML 
(http://wiki.fasterxml.com/JacksonExtensionXmlDataBinding) 
com.fasterxml.jackson.dataformat:jackson-dataformat-xml:bundle:2.9.2
+Jackson-dataformat-YAML 
(https://github.com/FasterXML/jackson-dataformats-text) 
com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:bundle:2.9.2
 Javassist (http://www.javassist.org/) org.javassist:javassist:bundle:3.18.1-GA
-spring-security-rsa 

Re: Fw: Request the Permission using Apache ServiceCom(incubating) name in our Meetup

[Sally Khudairi]

Thank you, Willem.

Yes, that is permissable.

Kind regards,
Sally

- - - 
Vice President Marketing & Publicity
The Apache Software Foundation

Tel +1 617 921 8656
Skype sallykhudairi


- Forwarded Message - **From:** Willem Jiang
 **To:** Sally Khudairi  **Cc:**
dev@servicecomb.apache.org; ASF ComDev ; ASF
Marketing & Publicity  **Sent:** Wednesday, March 14,
2018 1:48 AM **Subject:** Re: Fw: Request the Permission using Apache
ServiceCom(incubating) name in our Meetup> 
> Hi Sally，
> 
> As 树人云 doesn't use Apache ServiceComb to build their PaaS product and
> we both want to build up the community about building microservice.> Can we 
> change the event name to " Building Microservice Meetup
> presented by Apache ServiceComb(incubating) && 树人云"?> 
> 
> 
> Willem Jiang
> 
> Blog: http://willemjiang.blogspot.com[1] (English)
>http://jnn.iteye.com[2]  (Chinese)
>  Twitter: willemjiang
>  Weibo: 姜宁willem
> 
> On Wed, Mar 14, 2018 at 12:01 PM, Sally Khudairi
>  wrote:>> __
>> Thank you, Willem.
>> 
>> As the ASF is vendor-neutral, you may state the event as "Apache
>> ServiceComb (incubating) MeetUp presented by 树人云" but they cannot be
>> combined together. "Presented" is just a suggestion: it can be
>> "hosted", "supported", or other such words.>> 
>> I appreciate that you are having Apache Skywalking (incubating) at
>> the event as well. I had responded to Sheng, but the email bounced:>> 
>> >  :
>> >  Sorry, I couldn't find any host named foxmail.com[3]. (#5.1.2)
>> 
>> 
>> Thank you in advance for keeping us informed of your activities.
>> 
>> Warm regards,
>> Sally
>> 
>> 
>> - - -
>> Vice President Marketing & Publicity
>> The Apache Software Foundation
>> 
>> Tel +1 617 921 8656
>> Skype sallykhudairi
>> 
>> 
>> On Tue, Mar 13, 2018, at 23:40, Willem Jiang wrote:
>>> Hi Sally, 
>>> 
>>> Actually the meetup is holded by two community, one is "Apache
>>> ServiceComb(incubating)", the other is "树人云" a startup cloud company
>>> provides PaaS platform.>>> And we use  "Apache ServiceComb(incubating) && 
>>> 树人云 ” as the
>>> meetup name.>>> 
>>> BTW， We also invited "Apache Skywalking(incubating)" as a presenter
>>> to join our meetup.>>> 
>>> 
>>> Willem Jiang
>>> 
>>> Blog: http://willemjiang.blogspot. com[4] (English)
>>>   http://jnn.iteye.com[5]  (Chinese)
>>> Twitter: willemjiang
>>> Weibo: 姜宁willem
>>> 
>>> On Wed, Mar 14, 2018 at 11:13 AM, Sally Khudairi 
>>> wrote: __
 Hello Willem --thank you for your message.
 
 There are no issues with your use of the podling name to help
 promote your event and help build your community as long as the
 naming is along the lines of "Apache ServiceComb (incubating)
 MeetUp".  If you can please confirm the name of your event, we'd
 appreciate it. 
 I am copying ASF Community Development ("ComDev") here for their
 attention and follow-up as needed. 
 Welcome to the Apache family; do let me know if there's anything
 else we can help with. 
 Kind regards,
 Sally
 
 - - -
 Vice President Marketing & Publicity
 The Apache Software Foundation
 
 Tel +1 617 921 8656
 Skype sallykhudairi
 

 - Forwarded Message - **From:** Willem Jiang
  **To:** pr...@apache.org **Cc:**
 dev@servicecomb.apache.org **Sent:** Tuesday, March 13, 2018 10:45
 PM **Subject:** Request the Permission using Apache
 ServiceCom(incubating) name in our Meetup> 
> Hi ASF Marketing & Publicity,
> 
> We will hold a meetup in Beijing, China at March 31, 2018, by
> using Apache ServiceComb(incubating) as part of the event name to
> build up the Apache ServiceComb community.> 
> I want through the document of small-events tips[1], which said we
> need approve from the PMC. As ServiceComb is in the Apache
> incubator,  so we only has PPMC for project management, and there
> is no detail guide for holding the event with project name in the
> incubator guide.> 
> So I just ask for permission of using the name of Apache
> ServiceComb(incubating) in this meetup.> 
> [1]http://community.apache.org /events/small-events.html[6]
> 
> Thanks,
> 
> Willem Jiang
> 
> 
 
>> 
> 
> 


Links:

  1. http://willemjiang.blogspot.com/
  2. http://jnn.iteye.com/
  3. http://foxmail.com/
  4. http://willemjiang.blogspot.com/
  5. http://jnn.iteye.com/
  6. http://community.apache.org/events/small-events.html

Re: Fw: Request the Permission using Apache ServiceCom(incubating)namein our Meetup

[Sally Khudairi]

Thank you, Sheng :-)

Kind regards,
Sally

- - - 
Vice President Marketing & Publicity
The Apache Software Foundation

Tel +1 617 921 8656
Skype sallykhudairi


- Forwarded Message - **From:** 吴晟 Sheng Wu
 **To:** dev  **Cc:**
willem.jiang ; dev ;
dev ; press  **Sent:**
Wednesday, March 14, 2018 2:15 AM **Subject:** Re:  Fw:  Fw: Request the
Permission using Apache ServiceCom(incubating)namein our Meetup> 
> Sally
> 
> Thanks, and changed.
> 
> --
> *Sheng Wu*
> Apache SkyWalking original creator and PPMC member
>  
> 
> 
> -- Original --
> *From: * "Sally Khudairi";
> *Date: * Wed, Mar 14, 2018 11:35 AM
> *To: * "吴晟 Sheng Wu";
> *Cc: * "willem.jiang";
> "dev"; "ASF
> ComDev"; "ASF Marketing &
> Publicity";> *Subject: * Re: Fw:  Fw: Request the 
> Permission using Apache
> ServiceCom(incubating)namein our Meetup> 
> Thank you for notifying us, Sheng.
> 
> As with Apache ServiceComb, please be sure to send us the Apache
> SkyWalking naming/promotions when available.
> Also, I'm not sure if your Incubator mentor has mentioned it to
> you, but> creators/inventors of projects that are now at the ASF may be 
> referred> to as "original creator/*"; your signature below should read 
> "Original> creator of Apache SkyWalking" or "Apache SkyWalking original 
> creator".> The ASF is about highlighting projects and their communities :-)
> Kind regards,
> Sally
> 
> - - -
> Vice President Marketing & Publicity
> The Apache Software Foundation
> 
> Tel +1 617 921 8656
> Skype sallykhudairi
> 
> 
> - Forwarded Message - **From:** 吴晟 Sheng Wu
>  **To:** willem.jiang ;> dev 
> ; dev
>  **Cc:**> press  **Sent:** 
> Tuesday, March 13, 2018 11:16 PM
> **Subject:** Re:  Fw: Request the Permission using Apache
> ServiceCom(incubating) namein our Meetup> 
> > Hi Sally
> > 
> > Apache SkyWalking (incubating) project will join the meeting too. We> > 
> > will follow the rule.> 
> > 
> > --
> > *Sheng Wu*
> > Apache SkyWalking creator and PPMC member
> >  
> > 
> > 
> > -- Original --
> > *From: * "Sally Khudairi";
> > *Date: * Wed, Mar 14, 2018 11:13 AM
> > *To: * "willem.jiang";"dev" > 
> > pache.org>;"ASF ComDev";> *Cc: * "ASF
> > Marketing & Publicity";> > *Subject: * Re: Fw: Request 
> > the Permission using Apache
> > ServiceCom(incubating) namein our Meetup> 
> > Hello Willem --thank you for your message.
> > 
> > There are no issues with your use of the podling name to help
> > promote> your event and help build your community as long as the
> > naming> > is along> the lines of "Apache ServiceComb (incubating) MeetUp".  
> > If
> > you can> > please confirm the name of your event, we'd appreciate it.
> > I am copying ASF Community Development ("ComDev") here for their
> > attention and follow-up as needed.
> > Welcome to the Apache family; do let me know if there's
> > anything else we> can help with.
> > Kind regards,
> > Sally
> > 
> > - - -
> > Vice President Marketing & Publicity
> > The Apache Software Foundation
> > 
> > Tel +1 617 921 8656
> > Skype sallykhudairi
> > 
> > 
> > - Forwarded Message - **From:** Willem Jiang
> >  **To:** pr...@apache.org **Cc:**
> > dev@servicecomb.apache.org **Sent:** Tuesday, March 13, 2018 10:45
> > PM> **Subject:** Request the Permission using Apache> > 
> > ServiceCom(incubating)> name in our Meetup> 
> > > Hi ASF Marketing & Publicity,
> > > 
> > > We will hold a meetup in Beijing, China at March 31, 2018, by
> > > using> > Apache ServiceComb(incubating) as part of the event name
> > > to build up> > the Apache ServiceComb community.>> > > I want through the 
> > > document of small-events tips[1], which said we> > > need approve from 
> > > the PMC. As ServiceComb is in the Apache
> > > incubator,> > so we only has PPMC for project management, and
> > > there is no detail> > > guide for holding the event with project name in 
> > > the incubator
> > > guide.>> > So I just ask for permission of using the name of
> > > Apache> > > ServiceComb(incubating) in this meetup.> 
> > > [1]http://community.apache.org/events/small-events.html
> > > 
> > > Thanks,
> > > 
> > > Willem Jiang
> > > 
> > > 
> > 
> > 
> > 
> 
> 
> 

[GitHub] tianxiaoliang commented on issue #306: 会有nodejs的SDK吗?

[GitBox]

tianxiaoliang commented on issue #306: 会有nodejs的SDK吗?
URL: 
https://github.com/apache/incubator-servicecomb-service-center/issues/306#issuecomment-372961870
 
 
   对于多语言接入 servicecenter，有个商用的解决方案了，即service mesh模式，但是他也支持接入开源的servicecenter
   https://support.huaweicloud.com/devg-cse/cse_mesh_0002.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang closed pull request #154: [SCB-260] Add third party notices

[GitBox]

WillemJiang closed pull request #154: [SCB-260] Add third party notices
URL: https://github.com/apache/incubator-servicecomb-saga/pull/154
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/saga-distribution/src/release/NOTICE 
b/saga-distribution/src/release/NOTICE
index 8a5dba2d..7d79bfaa 100644
--- a/saga-distribution/src/release/NOTICE
+++ b/saga-distribution/src/release/NOTICE
@@ -3,3 +3,25 @@ Copyright 2017-2018 The Apache Software Foundation
 
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
+
+
+
+Notice for Apache Commons Logging
+
+Apache Commons Logging
+Copyright 2003-2016 The Apache Software Foundation
+
+
+Notice for gRPC
+
+See licenses/NOTICE-grpc
+
+
+Notice for Netty
+
+See licenses/NOTICE-netty
+
+
+Notice for Apache tomcat
+
+See licenses/NOTICE-tomcat
diff --git a/saga-distribution/src/release/licenses/NOTICE-grpc 
b/saga-distribution/src/release/licenses/NOTICE-grpc
new file mode 100644
index ..e4be9bf9
--- /dev/null
+++ b/saga-distribution/src/release/licenses/NOTICE-grpc
@@ -0,0 +1,36 @@
+Copyright 2014, gRPC Authors All rights reserved.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+
+---
+
+This product contains a modified portion of 'OkHttp', an open source
+HTTP & SPDY client for Android and Java applications, which can be obtained
+at:
+
+  * LICENSE:
+* okhttp/third_party/okhttp/LICENSE (Apache License 2.0)
+  * HOMEPAGE:
+* https://github.com/square/okhttp
+  * LOCATION_IN_GRPC:
+* okhttp/third_party/okhttp
+
+This product contains a modified portion of 'Netty', an open source
+networking library, which can be obtained at:
+
+  * LICENSE:
+* netty/third_party/netty/LICENSE.txt (Apache License 2.0)
+  * HOMEPAGE:
+* https://netty.io
+  * LOCATION_IN_GRPC:
+* netty/third_party/netty
diff --git a/saga-distribution/src/release/licenses/NOTICE-netty 
b/saga-distribution/src/release/licenses/NOTICE-netty
new file mode 100644
index ..8e31ccc6
--- /dev/null
+++ b/saga-distribution/src/release/licenses/NOTICE-netty
@@ -0,0 +1,222 @@
+The Netty Project
+=
+
+Please visit the Netty web site for more information:
+
+  * http://netty.io/
+
+Copyright 2014 The Netty Project
+
+The Netty Project licenses this file to you under the Apache License,
+version 2.0 (the "License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at:
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+License for the specific language governing permissions and limitations
+under the License.
+
+Also, please refer to each LICENSE..txt file, which is located in
+the 'license' directory of the distribution file, for the license terms of the
+components that this product depends on.
+
+---
+This product contains the extensions to Java Collections Framework which has
+been derived from the works by JSR-166 EG, Doug Lea, and Jason T. Greene:
+
+  * LICENSE:
+* license/LICENSE.jsr166y.txt (Public Domain)
+  * HOMEPAGE:
+* http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/
+* 
http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbosscache/experimental/jsr166/
+
+This product contains a modified version of Robert Harder's Public Domain
+Base64 Encoder and Decoder, which can be obtained at:
+
+  * LICENSE:
+* license/LICENSE.base64.txt (Public Domain)
+  * HOMEPAGE:
+* http://iharder.sourceforge.net/current/java/base64/
+
+This product contains a modified portion of 'Webbit', an event based
+WebSocket and HTTP server, which can be obtained at:
+
+  * LICENSE:
+* 

[GitHub] coveralls commented on issue #593: [SCB-260] Add third party notice

[GitBox]

coveralls commented on issue #593: [SCB-260] Add third party notice
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/593#issuecomment-372938691
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15965987/badge)](https://coveralls.io/builds/15965987)
   
   Coverage remained the same at 87.183% when pulling 
**41bb4119530891af68f13a82765ac234dff6d1f6 on yangbor:master** into 
**dab580c2f0b3f8b037bfaf4f1e5af19d1cf98043 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #594: [SCB-379] support AsyncRestTemplate

[GitBox]

coveralls commented on issue #594: [SCB-379] support AsyncRestTemplate
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#issuecomment-372952656
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15965974/badge)](https://coveralls.io/builds/15965974)
   
   Coverage increased (+0.05%) to 87.231% when pulling 
**16441c9de8efd3c89d4b4f8ee57d40d107fea600 on lijasonvip:async** into 
**dab580c2f0b3f8b037bfaf4f1e5af19d1cf98043 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #594: [SCB-379] support AsyncRestTemplate

[GitBox]

coveralls commented on issue #594: [SCB-379] support AsyncRestTemplate
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/594#issuecomment-372952656
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15965963/badge)](https://coveralls.io/builds/15965963)
   
   Coverage increased (+0.07%) to 87.249% when pulling 
**16441c9de8efd3c89d4b4f8ee57d40d107fea600 on lijasonvip:async** into 
**dab580c2f0b3f8b037bfaf4f1e5af19d1cf98043 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #138: [WIP] SCB-224 retry sub-transaction on failure

[GitBox]

coveralls commented on issue #138: [WIP] SCB-224 retry sub-transaction on 
failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368816986
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15965898/badge)](https://coveralls.io/builds/15965898)
   
   Coverage decreased (-0.3%) to 95.031% when pulling 
**6c34c4fea081bcf804ccad880af93a7a7566cf6b on eric-lee-ltk:SCB-224** into 
**541202272bdd5f5b76daa11c7b6cf1c1a7d9a505 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 closed pull request #578: SCB-373 change Rest args code/encoding to HttpClientFilter/HttpServer…

[GitBox]

liubao68 closed pull request #578: SCB-373 change Rest args code/encoding to 
HttpClientFilter/HttpServer…
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/578
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
 
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
index 3db387932..7d8ab2c76 100644
--- 
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
+++ 
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
@@ -27,7 +27,6 @@
 import javax.ws.rs.core.Response.Status;
 
 import org.apache.commons.lang3.StringUtils;
-import org.apache.servicecomb.common.rest.codec.RestCodec;
 import org.apache.servicecomb.common.rest.codec.produce.ProduceProcessor;
 import 
org.apache.servicecomb.common.rest.codec.produce.ProduceProcessorManager;
 import org.apache.servicecomb.common.rest.definition.RestOperationMeta;
@@ -43,15 +42,12 @@
 import org.apache.servicecomb.foundation.common.utils.JsonUtils;
 import org.apache.servicecomb.foundation.vertx.http.HttpServletRequestEx;
 import org.apache.servicecomb.foundation.vertx.http.HttpServletResponseEx;
-import org.apache.servicecomb.foundation.vertx.stream.BufferOutputStream;
 import org.apache.servicecomb.swagger.invocation.InvocationType;
 import org.apache.servicecomb.swagger.invocation.Response;
 import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import io.netty.buffer.Unpooled;
-
 public abstract class AbstractRestInvocation {
   private static final Logger LOGGER = 
LoggerFactory.getLogger(AbstractRestInvocation.class);
 
@@ -80,6 +76,7 @@ protected void findRestOperation(MicroserviceMeta 
microserviceMeta) {
 
 OperationLocator locator = locateOperation(servicePathManager);
 requestEx.setAttribute(RestConst.PATH_PARAMETERS, locator.getPathVarMap());
+requestEx.setAttribute(RestConst.OPERATION_PARAMETERS, 
locator.getOperation());
 this.restOperationMeta = locator.getOperation();
   }
 
@@ -140,8 +137,7 @@ protected void scheduleInvocation() {
   }
 
   protected void runOnExecutor(InvocationStartedEvent startedEvent) {
-Object[] args = RestCodec.restToArgs(requestEx, restOperationMeta);
-createInvocation(args);
+createInvocation(null);
 
 //立刻设置开始时间，否则Finished时无法计算TotalTime
 invocation.setStartTime(startedEvent.getStartedTime());
@@ -227,21 +223,13 @@ protected void sendResponse(Response response) throws 
Exception {
 }
 responseEx.setStatus(response.getStatusCode(), response.getReasonPhrase());
 responseEx.setContentType(produceProcessor.getName() + "; charset=utf-8");
+invocation.getHandlerContext().put(RestConst.INVOCATION_HANDLER_RESPONSE, 
response);
+invocation.getHandlerContext().put(RestConst.INVOCATION_HANDLER_PROCESSOR, 
produceProcessor);
 
-Object body = response.getResult();
-if (response.isFailed()) {
-  body = ((InvocationException) body).getErrorData();
+for (HttpServerFilter filter : httpServerFilters) {
+  filter.beforeSendResponse(invocation, responseEx);
 }
 
-try (BufferOutputStream output = new 
BufferOutputStream(Unpooled.compositeBuffer())) {
-  produceProcessor.encodeResponse(output, body);
-
-  responseEx.setBodyBuffer(output.getBuffer());
-  for (HttpServerFilter filter : httpServerFilters) {
-filter.beforeSendResponse(invocation, responseEx);
-  }
-
-  responseEx.flushBuffer();
-}
+responseEx.flushBuffer();
   }
 }
diff --git 
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/RestConst.java
 
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/RestConst.java
index 2568a8294..aa23137ca 100644
--- 
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/RestConst.java
+++ 
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/RestConst.java
@@ -34,12 +34,24 @@ private RestConst() {
   // in HttpServletRequest attribute
   public static final String PATH_PARAMETERS = "servicecomb-paths";
 
+  //in HttpServletRequest attribute
+  public static final String OPERATION_PARAMETERS = "servicecomb-operations";
+
   // in HttpServletRequest attribute
   public static final String BODY_PARAMETER = "servicecomb-body";
 
   // in HttpServletRequest attribute
   public static final String FORM_PARAMETERS = "servicecomb-forms";
 
+  //in invocation response
+  public static final String INVOCATION_HANDLER_RESPONSE = 
"servicecomb-invocation-hanlder-response";
+
+  //in invocation response
+  

[GitHub] coveralls commented on issue #154: [SCB-260] Add third party notices

[GitBox]

coveralls commented on issue #154: [SCB-260] Add third party notices
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/154#issuecomment-372934061
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15965698/badge)](https://coveralls.io/builds/15965698)
   
   Coverage remained the same at 95.285% when pulling 
**a32fcb95f954d10b47ea91a2ffaf7fffafad9a34 on yangbor:master** into 
**541202272bdd5f5b76daa11c7b6cf1c1a7d9a505 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yangbor commented on a change in pull request #593: [SCB-260] Add third party notice

[GitBox]

yangbor commented on a change in pull request #593: [SCB-260] Add third party 
notice
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/593#discussion_r174388108
 
 

 ##
 File path: java-chassis-distribution/src/release/NOTICE
 ##
 @@ -3,3 +3,48 @@ Copyright 2017-2018 The Apache Software Foundation
 
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
+
+
+
+Notice for Apache Commons Codec
+
+See licenses/NOTICE-apache-commons-codec
 
 Review comment:
   As explained in other discussion, there is no need to put up a notices 
directory which will increase end user burden on collecting legal information.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on a change in pull request #588: [SCB-394] framework version support SC which earlier than 1.0.0

[GitBox]

liubao68 commented on a change in pull request #588: [SCB-394] framework 
version support SC which earlier than 1.0.0
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/588#discussion_r174385933
 
 

 ##
 File path: 
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/FrameworkVersions.java
 ##
 @@ -22,12 +22,29 @@
 import java.util.Map.Entry;
 import java.util.ServiceLoader;
 
+import org.apache.servicecomb.serviceregistry.RegistryUtils;
 import org.apache.servicecomb.serviceregistry.api.Versions;
+import org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class FrameworkVersions {
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(FrameworkVersions.class);
   private static final ServiceLoader frameworkVersions = 
ServiceLoader.load(Versions.class);
 
   public static String allVersions() {
+ServiceRegistryClient client = RegistryUtils.getServiceRegistryClient();
+ServiceCenterInfo serviceCenterInfo = client.getServiceCenterInfo();
+if (serviceCenterInfo == null) {
+  LOGGER.error("query servicecenter version info failed.");
+}
+String scVersion = serviceCenterInfo.getVersion();
 
 Review comment:
   NPE


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lijasonvip opened a new pull request #594: [SCB-379] support AsyncRestTemplate

[GitBox]

lijasonvip opened a new pull request #594: [SCB-379] support AsyncRestTemplate
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/594
 
 
   Signed-off-by: lijasonvip 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yangbor commented on a change in pull request #154: [SCB-260] Add third party notices

[GitBox]

yangbor commented on a change in pull request #154: [SCB-260] Add third party 
notices
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/154#discussion_r174379604
 
 

 ##
 File path: saga-distribution/src/release/NOTICE
 ##
 @@ -3,3 +3,19 @@ Copyright 2017-2018 The Apache Software Foundation
 
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
+
+
+
+Notice for gRPC
+
+See licenses/NOTICE-grpc
 
 Review comment:
   From my POV it's irrelevent where we put the NOTICE-xxx files so long as the 
end user can get those files. And put them under the licenses folder have the 
advantage that the end user can get all the legal information from one place. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #593: [SCB-260] Add third party notice

[GitBox]

coveralls commented on issue #593: [SCB-260] Add third party notice
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/593#issuecomment-372938691
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15965285/badge)](https://coveralls.io/builds/15965285)
   
   Coverage remained the same at 87.183% when pulling 
**5e6dcbe7ea7af1174bbf8f9053e92b5af6c938d4 on yangbor:master** into 
**dab580c2f0b3f8b037bfaf4f1e5af19d1cf98043 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on a change in pull request #593: [SCB-260] Add third party notice

[GitBox]

WillemJiang commented on a change in pull request #593: [SCB-260] Add third 
party notice
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/593#discussion_r174379133
 
 

 ##
 File path: java-chassis-distribution/src/release/NOTICE
 ##
 @@ -3,3 +3,48 @@ Copyright 2017-2018 The Apache Software Foundation
 
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
+
+
+
+Notice for Apache Commons Codec
+
+See licenses/NOTICE-apache-commons-codec
+
+
+Notice for Apache Commons Lang
+
 
 Review comment:
   I think there is Copyright line here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on a change in pull request #154: [SCB-260] Add third party notices

[GitBox]

WillemJiang commented on a change in pull request #154: [SCB-260] Add third 
party notices
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/154#discussion_r174378839
 
 

 ##
 File path: saga-distribution/src/release/NOTICE
 ##
 @@ -3,3 +3,19 @@ Copyright 2017-2018 The Apache Software Foundation
 
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
+
+
+
+Notice for gRPC
+
+See licenses/NOTICE-grpc
 
 Review comment:
   It's better to use the notices director instead of licenses.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #154: [SCB-260] Add third party notices

[GitBox]

coveralls commented on issue #154: [SCB-260] Add third party notices
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/154#issuecomment-372934061
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15965059/badge)](https://coveralls.io/builds/15965059)
   
   Coverage remained the same at 95.285% when pulling 
**70e2d4e80e7354da95c16d7ed775351d3581a258 on yangbor:master** into 
**541202272bdd5f5b76daa11c7b6cf1c1a7d9a505 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #308: [SCB-367] Add third party notices

[GitBox]

coveralls commented on issue #308: [SCB-367] Add third party notices
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/308#issuecomment-372933123
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15965015/badge)](https://coveralls.io/builds/15965015)
   
   Coverage decreased (-0.2%) to 73.961% when pulling 
**09bda715147edc51032d8330bacb4ceb0d60ee20 on yangbor:master** into 
**0b7c6854f1b7b4b62c67a0048677653d0225938c on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #308: [SCB-367] Add third party notices

[GitBox]

codecov-io commented on issue #308: [SCB-367] Add third party notices
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/308#issuecomment-372933056
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/308?src=pr=h1)
 Report
   > Merging 
[#308](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/308?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/0b7c6854f1b7b4b62c67a0048677653d0225938c?src=pr=desc)
 will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/308/graphs/tree.svg?token=GAaF7zrg8R=pr=650=150)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/308?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #308  +/-   ##
   ==
   - Coverage   70.39%   70.36%   -0.03% 
   ==
 Files  17   17  
 Lines3455 3455  
   ==
   - Hits 2432 2431   -1 
 Misses853  853  
   - Partials  170  171   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/308?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/308/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `75.43% <0%> (-0.59%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/308?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/308?src=pr=footer).
 Last update 
[0b7c685...09bda71](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/308?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yangbor opened a new pull request #154: [SCB-260] Add third party notices

[GitBox]

yangbor opened a new pull request #154: [SCB-260] Add third party notices
URL: https://github.com/apache/incubator-servicecomb-saga/pull/154
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yangbor opened a new pull request #593: [SCB-260] Add third party notice

[GitBox]

yangbor opened a new pull request #593: [SCB-260] Add third party notice
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/593
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yangbor opened a new pull request #308: [SCB-367] Add third party notices

[GitBox]

yangbor opened a new pull request #308: [SCB-367] Add third party notices
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/308
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #307: [SCB-376] Optimize validate parameter log print

[GitBox]

coveralls commented on issue #307:  [SCB-376] Optimize validate parameter log 
print
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/307#issuecomment-372929042
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15964839/badge)](https://coveralls.io/builds/15964839)
   
   Coverage decreased (-0.2%) to 73.936% when pulling 
**a19564002db722c27f1bc45907be59aabda593b9 on aseTo2016:aseTo** into 
**0b7c6854f1b7b4b62c67a0048677653d0225938c on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #307: [SCB-376] Optimize validate parameter log print

[GitBox]

codecov-io commented on issue #307:  [SCB-376] Optimize validate parameter log 
print
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/307#issuecomment-372928983
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=h1)
 Report
   > Merging 
[#307](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/0b7c6854f1b7b4b62c67a0048677653d0225938c?src=pr=desc)
 will **decrease** coverage by `0.05%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307/graphs/tree.svg?width=650=GAaF7zrg8R=150=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #307  +/-   ##
   ==
   - Coverage   70.39%   70.33%   -0.06% 
   ==
 Files  17   17  
 Lines3455 3452   -3 
   ==
   - Hits 2432 2428   -4 
 Misses853  853  
   - Partials  170  171   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/util/rule\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9ydWxlX3V0aWwuZ28=)
 | `67.5% <ø> (-0.6%)` | :arrow_down: |
   | 
[server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==)
 | `74.6% <100%> (ø)` | :arrow_up: |
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `75.43% <0%> (-0.59%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=footer).
 Last update 
[0b7c685...a195640](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/307?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aseTo2016 opened a new pull request #307: [SCB-376] Optimize validate parameter log print

[GitBox]

aseTo2016 opened a new pull request #307:  [SCB-376] Optimize validate 
parameter log print
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/307
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Fw: Fw: Request the Permission using Apache ServiceCom(incubating)namein our Meetup

[???? Sheng Wu]

Sally


Thanks, and changed.


--
Sheng Wu
Apache SkyWalking original creator and PPMC member


 




-- Original --
From:  "Sally Khudairi";
Date:  Wed, Mar 14, 2018 11:35 AM
To:  " Sheng Wu";
Cc:  "willem.jiang"; "dev"; 
"ASF ComDev"; "ASF Marketing & 
Publicity"; 
Subject:  Re: Fw:  Fw: Request the Permission using Apache 
ServiceCom(incubating)namein our Meetup



Thank you for notifying us, Sheng.

As with Apache ServiceComb, please be sure to send us the Apache
SkyWalking naming/promotions when available.
Also, I'm not sure if your Incubator mentor has mentioned it to you, but
creators/inventors of projects that are now at the ASF may be referred
to as "original creator/*"; your signature below should read "Original
creator of Apache SkyWalking" or "Apache SkyWalking original creator".
The ASF is about highlighting projects and their communities :-)
Kind regards,
Sally

- - -
Vice President Marketing & Publicity
The Apache Software Foundation

Tel +1 617 921 8656
Skype sallykhudairi


- Forwarded Message - **From:**  Sheng Wu
 **To:** willem.jiang ;
dev ; dev  **Cc:**
press  **Sent:** Tuesday, March 13, 2018 11:16 PM
**Subject:** Re:  Fw: Request the Permission using Apache
ServiceCom(incubating) namein our Meetup> 
> Hi Sally
> 
> Apache SkyWalking (incubating) project will join the meeting too. We
> will follow the rule.> 
> 
> --
> *Sheng Wu*
> Apache SkyWalking creator and PPMC member
>  
> 
> 
> -- Original --
> *From: * "Sally Khudairi";
> *Date: * Wed, Mar 14, 2018 11:13 AM
> *To: * "willem.jiang";"dev" pache.org>;"ASF ComDev";> *Cc: * "ASF Marketing & 
> Publicity";
> *Subject: * Re: Fw: Request the Permission using Apache
> ServiceCom(incubating) namein our Meetup> 
> Hello Willem --thank you for your message.
> 
> There are no issues with your use of the podling name to help promote> your 
> event and help build your community as long as the naming
> is along> the lines of "Apache ServiceComb (incubating) MeetUp".  If you can
> please confirm the name of your event, we'd appreciate it.
> I am copying ASF Community Development ("ComDev") here for their
> attention and follow-up as needed.
> Welcome to the Apache family; do let me know if there's
> anything else we> can help with.
> Kind regards,
> Sally
> 
> - - -
> Vice President Marketing & Publicity
> The Apache Software Foundation
> 
> Tel +1 617 921 8656
> Skype sallykhudairi
> 
> 
> - Forwarded Message - **From:** Willem Jiang
>  **To:** pr...@apache.org **Cc:**
> dev@servicecomb.apache.org **Sent:** Tuesday, March 13, 2018 10:45 PM> 
> **Subject:** Request the Permission using Apache
> ServiceCom(incubating)> name in our Meetup> 
> > Hi ASF Marketing & Publicity,
> > 
> > We will hold a meetup in Beijing, China at March 31, 2018, by using> > 
> > Apache ServiceComb(incubating) as part of the event name to build up> > the 
> > Apache ServiceComb community.> 
> > I want through the document of small-events tips[1], which said we
> > need approve from the PMC. As ServiceComb is in the Apache
> > incubator,> > so we only has PPMC for project management, and there is no 
> > detail
> > guide for holding the event with project name in the incubator
> > guide.>> > So I just ask for permission of using the name of Apache
> > ServiceComb(incubating) in this meetup.> 
> > [1]http://community.apache.org/events/small-events.html
> > 
> > Thanks,
> > 
> > Willem Jiang
> > 
> > 
> 
> 
>

[GitHub] qizha commented on issue #592: 【请关注】服务消费者调用服务提供者接口时，目前缺少接口级别或者动态的超时设置能力，无法满足服务接口差异化诉求

[GitBox]

qizha commented on issue #592: 
【请关注】服务消费者调用服务提供者接口时，目前缺少接口级别或者动态的超时设置能力，无法满足服务接口差异化诉求
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/issues/592#issuecomment-372915556
 
 
   
实际上你的要求是如何在微服务之间进行异步操作。命令-等候-查询结果的方式是其中的一种解决方案。而拉大调用的超时时间并不是好的方案，因为这个操作治标不治本，并不能根本解决你异步操作的问题，一旦异步的过程时间长了，就有问题了。
   我推荐的方式是使用类似callback的方式，这个是REST的标准。可以参考OpenAPI的Specification:
   https://swagger.io/specification/#callbackObject
   也可以参考这个文章：https://dzone.com/articles/rest-callbacks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services