Re: [DISCUSS] Consider implementors of Sling API
In general I'm fine with this, however as Justin noted adding final to some of the classes might break clients of Sling. Marking an interface as ConsumerType means also we shouldn't change it, right? (i'm fine with that, just clarifying) Carsten 2013/8/5 Felix Meschberger fmesc...@adobe.com Hi Am 05.08.2013 um 19:48 schrieb Justin Edelson: Hi Felix, +1 to all of this. Out of curiosity, would adding the final keyword require a major version bump? It isn't backwards compatible, but is perhaps an interesting grey area. Yes, technically, this is binary incompatible because existing extensions will fail to load. An option would be to omit the final qualifier but add JavaDoc indicating extension is not intended. Regards Felix Justin On Mon, Aug 5, 2013 at 11:04 AM, Felix Meschberger fmesc...@adobe.com wrote: Hi all While working on SLING-2944 [1] it occurred to me that we do not currently take good care to differentiate between interfaces to be implemented by a single bundle (such as SlingHttpServletRequest) and interfaces which may be implemented by multiple bundles to extend some functionality (such as ResourceProvider). Also, we have a number of constant, helper, and utility type classes in the Sling API, which we should not make available to extensibility. I have created SLING-2993 [2] and provided a patch to the Sling API such that: * All classes intended for extension remain unchanged * All classes not intended for extension are marked final * All interfaces intended to be implemented by multiple bundles (providers) are marked @ConsumerType * All interfaces intended to be implemented by a single bundle are marked as @ProviderType This change also requires to update the Maven Bundle Plugin version in the Sling parent POM to 2.4.0. This change would prevent us from collateral damage such in the context of SLING-2944 where the Servlet Resolver, Filesystem Resource Provider, and Bundle Resource Provider bundles have to be updated just because the ResourceResolverFactory API has been extended. WDYT ? Regards Felix [1] https://issues.apache.org/jira/browse/SLING-2944 [2] https://issues.apache.org/jira/browse/SLING-2993 -- Carsten Ziegeler cziege...@apache.org
[jira] [Created] (SLING-2994) Update to latest SCR plugin
Carsten Ziegeler created SLING-2994: --- Summary: Update to latest SCR plugin Key: SLING-2994 URL: https://issues.apache.org/jira/browse/SLING-2994 Project: Sling Issue Type: Improvement Components: General Affects Versions: Parent 17 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Parent 18 A new version of the SCR plugin is out with some bug fixes, we should update to that version -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2994) Update to latest SCR plugin
[ https://issues.apache.org/jira/browse/SLING-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-2994. - Resolution: Fixed Updated to version 1.14.0 and annotations version 1.9.6 in rev 1510862 Update to latest SCR plugin --- Key: SLING-2994 URL: https://issues.apache.org/jira/browse/SLING-2994 Project: Sling Issue Type: Improvement Components: General Affects Versions: Parent 17 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Parent 18 A new version of the SCR plugin is out with some bug fixes, we should update to that version -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2995) Update Maven Plugins to latest version
Carsten Ziegeler created SLING-2995: --- Summary: Update Maven Plugins to latest version Key: SLING-2995 URL: https://issues.apache.org/jira/browse/SLING-2995 Project: Sling Issue Type: Improvement Components: General Affects Versions: Parent 17 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Parent 18 We could update the following plugins: [INFO] maven-changes-plugin . 2.8 - 2.9 [INFO] maven-dependency-plugin .. 2.6 - 2.8 [INFO] maven-javadoc-plugin ... 2.9 - 2.9.1 [INFO] maven-surefire-report-plugin . 2.12.4 - 2.15 [INFO] maven-war-plugin . 2.3 - 2.4 [INFO] org.apache.rat:apache-rat-plugin . 0.8 - 0.9 [INFO] org.codehaus.cargo:cargo-maven2-plugin ... 1.3.1 - 1.4.3 [INFO] org.codehaus.mojo:build-helper-maven-plugin .. 1.7 - 1.8 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [DISCUSS] Consider implementors of Sling API
+1 to Javadoc. I am tempted to -1 final, but I never say -1. Every framework that has final, and doesn't do quite what is required is a complete nightmare to use. I remember Hibernate in the early days when everything was final, and nothing worked properly. It was impossible to fix except by forking the entire codebase. The response from the Hibernate team was, we know better than you, which in most cases was wrong because they didn't know what the you needed to do. We don't know how all people might want to use Sling. They might want/need to extend a core service in order to cover their use cases. If we make that core service final, they have no option but to cut and paste the code. When they come to upgrade, its too hard and they fork, effectively leaving the community. Finally, ;) , last time I read the java memory management docs and hotspot description, IIRC, final can prevent hotspot optimising the code, so some versions strip it or ignore it. I would have to find the detail to be certain of that. I don't really have a problem with final as a keyword to aid the compiler, but as an architectural feature it removes freedom of expression, and as a runtime feature its arrogant. Just my 2c. Ian On 5 August 2013 20:58, Felix Meschberger fmesc...@adobe.com wrote: Hi Am 05.08.2013 um 19:48 schrieb Justin Edelson: Hi Felix, +1 to all of this. Out of curiosity, would adding the final keyword require a major version bump? It isn't backwards compatible, but is perhaps an interesting grey area. Yes, technically, this is binary incompatible because existing extensions will fail to load. An option would be to omit the final qualifier but add JavaDoc indicating extension is not intended. Regards Felix Justin On Mon, Aug 5, 2013 at 11:04 AM, Felix Meschberger fmesc...@adobe.comwrote: Hi all While working on SLING-2944 [1] it occurred to me that we do not currently take good care to differentiate between interfaces to be implemented by a single bundle (such as SlingHttpServletRequest) and interfaces which may be implemented by multiple bundles to extend some functionality (such as ResourceProvider). Also, we have a number of constant, helper, and utility type classes in the Sling API, which we should not make available to extensibility. I have created SLING-2993 [2] and provided a patch to the Sling API such that: * All classes intended for extension remain unchanged * All classes not intended for extension are marked final * All interfaces intended to be implemented by multiple bundles (providers) are marked @ConsumerType * All interfaces intended to be implemented by a single bundle are marked as @ProviderType This change also requires to update the Maven Bundle Plugin version in the Sling parent POM to 2.4.0. This change would prevent us from collateral damage such in the context of SLING-2944 where the Servlet Resolver, Filesystem Resource Provider, and Bundle Resource Provider bundles have to be updated just because the ResourceResolverFactory API has been extended. WDYT ? Regards Felix [1] https://issues.apache.org/jira/browse/SLING-2944 [2] https://issues.apache.org/jira/browse/SLING-2993
[jira] [Resolved] (SLING-2995) Update Maven Plugins to latest version
[ https://issues.apache.org/jira/browse/SLING-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-2995. - Resolution: Fixed Updated in rev 1510863 Update Maven Plugins to latest version -- Key: SLING-2995 URL: https://issues.apache.org/jira/browse/SLING-2995 Project: Sling Issue Type: Improvement Components: General Affects Versions: Parent 17 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Parent 18 We could update the following plugins: [INFO] maven-changes-plugin . 2.8 - 2.9 [INFO] maven-dependency-plugin .. 2.6 - 2.8 [INFO] maven-javadoc-plugin ... 2.9 - 2.9.1 [INFO] maven-surefire-report-plugin . 2.12.4 - 2.15 [INFO] maven-war-plugin . 2.3 - 2.4 [INFO] org.apache.rat:apache-rat-plugin . 0.8 - 0.9 [INFO] org.codehaus.cargo:cargo-maven2-plugin ... 1.3.1 - 1.4.3 [INFO] org.codehaus.mojo:build-helper-maven-plugin .. 1.7 - 1.8 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [DISCUSS] Consider implementors of Sling API
On 6 August 2013 07:14, Ian Boston i...@tfd.co.uk wrote: Finally, ;) , last time I read the java memory management docs and hotspot description, IIRC, final can prevent hotspot optimising the code, so some versions strip it or ignore it. I would have to find the detail to be certain of that. [1] Page 25 indicates the problems associated with using final on fields, not least that if it is relied upon to isolate a class during construction that can't be guaranteed. Also, don't forget, serialisation and reflection make it possible to bypass final. Also [2] which is a little old has some views on the subject as does [3], not all of the pointers are relevant to final classes and final is not all bad but as [2] says its overused and sometimes in the wrong way which can lead to problems downstream. Part of Java's speed under load is the ability to dynamically inline methods. To do that methods must be small. Putting final keywords in on methods and classes blocks extension (fields are possibly ok) which results in more, cooler spots from a hotspot point of view, resulting less efficient runtime optimisation, and relying entirely on the programmer to know everything about the runtime to deliver better than interpreted speed. But I am +1 on documentation and any other methods we can find to indicate our intention. Ian 1 http://www.cs.umd.edu/~pugh/java/memoryModel/jsr133.pdf 2 http://www.ibm.com/developerworks/java/library/j-jtp1029/index.html 3 http://www.oracle.com/technetwork/java/whitepaper-135217.html#impact
[jira] [Commented] (SLING-2944) Replace administrative login by service-based login
[ https://issues.apache.org/jira/browse/SLING-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730490#comment-13730490 ] Carsten Ziegeler commented on SLING-2944: - I'm wondering if we shouldn't remove the support for a header in the manifest and simply rely on bundle symbolic name? E.g. if a dev knows that the Sling eventing bundle uses this mechanism to get an admin session (or whatever is configured), the dev can simply use the header entry and use the symbolic name of the eventing bundle as the value, using the same configuration as the Sling eventing bundle. It's try that once a bundle can be deployed, more or less everything is possible, but still just relying on the symbolic name makes this concept a little bit easier, doesn't open the above mentioned door and doesn't make it's usage more difficult. Replace administrative login by service-based login --- Key: SLING-2944 URL: https://issues.apache.org/jira/browse/SLING-2944 Project: Sling Issue Type: New Feature Components: API, JCR, ResourceResolver, Service User Mapper Affects Versions: JCR Resource 2.2.8, JCR Jackrabbit Server 2.1.0, JCR Base 2.1.2, JCR API 2.1.0, API 2.4.2, Resource Resolver 1.0.6 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Service User Mapper 1.0.0, Servlets Resolver 2.2.6, JCR Resource 2.3.0, JCR Jackrabbit Server 2.2.0, JCR Base 2.1.4, JCR API 2.2.0, File System Resource Provider 1.1.4, Extensions Bundleresource 2.1.4, API 2.5.0, Resource Resolver 1.1.0 Attachments: serviceusermapper.tgz, SLING-2944.patch From the start Sling tried to solve the problem of providing services access to the repository and resource tree without having to hard code and configure any passwords. This was done first with the SlingRepository.loginAdministrative and later with the ResourceResolverFactory.getAdministrativeResourceResolver methods. Over time this mechanism proved to be the hammer to hit all nails. Particularly these methods while truly useful have the disadvantage of providing full administrative privileges to services where just some specific kind of privilege would be enough. For example for the JSP compiler it would be enough to be able to read the JSP source scripts and write the Java classes out to the JSP compiler's target location. Other access is not required. Similarly to manage users user management privileges are enough and no access to /content is really required. To solve this problem a new API for Service Authentication has been proposed at https://cwiki.apache.org/confluence/display/SLING/Service+Authentication. The prototype of which is implemented in http://svn.apache.org/repos/asf/sling/whiteboard/fmeschbe/deprecate_login_administrative. This issue is about merging the prototype code back into trunk and thus fully implementing the feature. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [GSoC2013] Unsatisfied dependencies.
Hi Ian, I did so. But then I am facing more dependencies to be resolved. In import package I have only *. Which means all importing (will have to change that also, but hard to figure out which can be removed.). I added hector dependency and added Transitive =true. Doesn't this Transitive =true add hector's transitive dependencies ? Import-Package * /Import-Package Embed-Transitive*true*/Embed-Transitive Embed-Dependencyhector-core/Embed-Dependency /instructions com.eaio.uuid -- Cannot be resolved com.ecyrd.speed4j -- Cannot be resolved com.google.common.base -- Cannot be resolved com.google.common.collect -- Cannot be resolved com.sun.org.apache.xerces.internal.impl.dv.util -- Cannot be resolved and overwritten by Boot Delegation com.sun.xml.fastinfoset.stax -- Cannot be resolved and overwritten by Boot Delegation javax.management from org.apache.felix.framework (0) javax.naming from org.apache.felix.framework (0) javax.naming.spi from org.apache.felix.framework (0) javax.security.auth from org.apache.felix.framework (0) javax.security.auth.callback from org.apache.felix.framework (0) javax.security.auth.login from org.apache.felix.framework (0) javax.servlet.http from org.apache.felix.http.jetty (1) javax.xml.bind from org.apache.felix.framework (0) javax.xml.stream from org.apache.felix.framework (0) org.apache.cassandra.thrift -- Cannot be resolved org.apache.commons.lang,version=[2.4,3) from org.apache.commons.lang (85) org.apache.commons.lang.builder,version=[2.4,3) from org.apache.commons.lang (85) org.apache.commons.lang.math,version=[2.4,3) from org.apache.commons.lang (85) org.apache.commons.pool.impl,version=[1.5,2) -- Cannot be resolved org.apache.sling.api.resource,version=[2.3,3) from org.apache.sling.api (98) org.apache.thrift -- Cannot be resolved org.apache.thrift.protocol -- Cannot be resolved org.apache.thrift.transport -- Cannot be resolved On Mon, Aug 5, 2013 at 1:01 PM, Ian Boston i...@tfd.co.uk wrote: Hi, Dishara Wijewardana ddwijeward...@gmail.com wrote in thread titled [Status Update] Apache Cassandra backend for Sling: Hi Ian I started Sling launchpad and Cassandra Server as well. And uploaded the bundle through management console from http://localhost:8080/system/console . When I try to start the bundle it does nothing and no error logs in the back end as well. The I noticed following where me.prettyprint.* classes cannot loaded and hence my bundle cannot start. So ideally my bundle only contains it self only. Not included its dependencies. As I feel one option is get a me.prettyprint.* jar and install that bundle (I am not sure whether it also fails due to a similar reason). So what is the best approach to this ? If there is a Hector OSGi bundle (or the standard Jar has a OSGi MANIFEST.MF) then use that. If not you will need to embed the dependencies. If you embed the dependencies, you are going to have to resolve all of Hectors dependencies, and TBH, if the Hector OSGi bundle doesnt embed its dependencies, they you will have to do that anyway. Personally, I would embed since nothing else is going to be using Hector. Have a look at ./contrib/extensions/cache/ehcache/pom.xml to see how its done. Embed-Dependencyehcache,jsr107cache,backport-util-concurrent/Embed-Dependency embeds the artefacts of the same name. Best Regards Ian Symbolic Name org.apache.sling.cassandra Version 0.0.1.SNAPSHOT Bundle Location inputstream:org.apache.sling.cassandra-0.0.1-SNAPSHOT.jar Last Modification Mon Aug 05 05:26:16 IST 2013 Description Provides a ResourceProvider implementation supporting Apache Cassandra based resources. Start Level 20 Exported Packages org.apache.sling.cassandra.resource.provider,version=0.0.1.SNAPSHOT org.apache.sling.cassandra.resource.provider.mapper,version=0.0.1.SNAPSHOT org.apache.sling.cassandra.resource.provider.util,version=0.0.1.SNAPSHOT Imported Packages com.sun.org.apache.xerces.internal.impl.dv.util -- Cannot be resolved and overwritten by Boot Delegation javax.servlet.http from org.apache.felix.http.jetty (1) me.prettyprint.cassandra.model,version=[1.0,2) -- Cannot be resolved me.prettyprint.cassandra.serializers,version=[1.0,2) -- Cannot be resolved me.prettyprint.hector.api,version=[1.0,2) -- Cannot be resolved me.prettyprint.hector.api.beans,version=[1.0,2) -- Cannot be resolved me.prettyprint.hector.api.ddl,version=[1.0,2) -- Cannot be resolved me.prettyprint.hector.api.factory,version=[1.0,2) -- Cannot be resolved me.prettyprint.hector.api.query,version=[1.0,2) -- Cannot be resolved org.apache.sling.api.resource,version=[2.3,3) from org.apache.sling.api (98) org.slf4j,version=[1.5,2) from slf4j.api (6) Manifest Headers Bnd-LastModified: 1375238009819 Build-Jdk: 1.6.0_26 Built-By: dishara Bundle-Description: Provides a ResourceProvider implementation supporting Apache Cassandra based resources.
Re: [GSoC2013] Unsatisfied dependencies.
On Tue, Aug 6, 2013 at 12:10 PM, Dishara Wijewardana ddwijeward...@gmail.com wrote: com.google.common.base -- Cannot be resolved com.google.common.collect -- Cannot be resolved These are coming from Guava and Guava is a proper OSGi bundle. Robert -- Sent from my (old) computer
Re: [GSoC2013] Unsatisfied dependencies.
Hi, On 6 August 2013 10:24, Robert Munteanu rob...@lmn.ro wrote: On Tue, Aug 6, 2013 at 12:10 PM, Dishara Wijewardana ddwijeward...@gmail.com wrote: com.google.common.base -- Cannot be resolved com.google.common.collect -- Cannot be resolved These are coming from Guava and Guava is a proper OSGi bundle. @Robert, thank you for the pointer. @Dishara Will be better to just add Guava as a bundle rathe than embed it since it uses threads to reap weak references and do clean up. Also Embed-Transitive*true*/Embed-Transitive Never been able to get Embed-Transitive to work. I have always listed each artifact Id separately. Best Regards Ian Robert -- Sent from my (old) computer
Build failed in Jenkins: sling-trunk-1.7 #163
See https://builds.apache.org/job/sling-trunk-1.7/163/changes Changes: [cziegeler] SLING-2995 : Update Maven Plugins to latest version [cziegeler] SLING-2994 : Update to latest SCR pljugin -- [...truncated 25588 lines...] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Adapter Annotations . SUCCESS [7.866s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Maven Plugin to create Jackrabbit OCM descriptors SUCCESS [7.161s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Maven Plugin for Compiling JSP Sources into Bundles SUCCESS [4.560s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Maven Plugin for Supporting Bundle Development SUCCESS [5.237s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Launchpad Maven Plugin ... SUCCESS [16.561s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Launchpad Standalone Archetype .. SUCCESS [4.776s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Launchpad Webapp Archetype .. SUCCESS [2.386s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Initial Content Archetype ... SUCCESS [3.028s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Servlet Archetype ... SUCCESS [12.984s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Bundle Archetype SUCCESS [3.600s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling JCRInstall Bundle Archetype . SUCCESS [3.175s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Taglib Archetype SUCCESS [3.592s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling API .. SUCCESS [13.175s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Service User Mapper .. SUCCESS [9.105s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Resource Resolver SUCCESS [9.481s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: Java Transaction API SUCCESS [2.549s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: XML APIs SUCCESS [2.421s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: Activation API SUCCESS [3.276s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: WS APIs . SUCCESS [2.317s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Dynamic Class Loader Support . SUCCESS [6.184s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling JSON Library . SUCCESS [9.834s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling SLF4J Implementation . SUCCESS [10.049s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling OSGi LogService Implementation ... SUCCESS [3.031s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling MIME type mapping support SUCCESS [8.717s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Commons OSGi support . SUCCESS [6.225s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Scheduler Support SUCCESS [7.924s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Testing Utilities SUCCESS [1:02.173s] Aug 06, 2013 9:58:22 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Thread Support ... SUCCESS [3.082s] Aug 06, 2013 9:58:22 AM
Build failed in Jenkins: sling-trunk-1.6 #1791
See https://builds.apache.org/job/sling-trunk-1.6/1791/changes Changes: [cziegeler] SLING-2995 : Update Maven Plugins to latest version [cziegeler] SLING-2994 : Update to latest SCR pljugin -- [...truncated 23642 lines...] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Launchpad Maven Plugin ... SUCCESS [23.347s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Launchpad Standalone Archetype .. SUCCESS [5.541s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Launchpad Webapp Archetype .. SUCCESS [3.188s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Initial Content Archetype ... SUCCESS [3.119s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Servlet Archetype ... SUCCESS [12.806s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Bundle Archetype SUCCESS [2.389s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling JCRInstall Bundle Archetype . SUCCESS [2.041s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Taglib Archetype SUCCESS [2.320s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling API .. SUCCESS [8.837s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Service User Mapper .. SUCCESS [4.954s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Resource Resolver SUCCESS [8.188s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: Java Transaction API SUCCESS [3.185s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: XML APIs SUCCESS [2.845s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: Activation API SUCCESS [2.186s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: WS APIs . SUCCESS [2.271s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Dynamic Class Loader Support . SUCCESS [12.561s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling JSON Library . SUCCESS [4.726s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling SLF4J Implementation . SUCCESS [10.102s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling OSGi LogService Implementation ... SUCCESS [2.746s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling MIME type mapping support SUCCESS [8.034s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Commons OSGi support . SUCCESS [4.313s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Scheduler Support SUCCESS [4.014s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Testing Utilities SUCCESS [31.290s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Thread Support ... SUCCESS [2.859s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Authentication Service ... SUCCESS [4.403s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling OpenID Authentication SUCCESS [6.053s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Form Based Authentication Handler SUCCESS [5.074s] Aug 6, 2013 10:19:42 AM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Authentication Selector .. SUCCESS [2.585s] Aug 6, 2013 10:19:42 AM
[jira] [Closed] (SLING-2988) Support primitive types for ValueMap.get()
[ https://issues.apache.org/jira/browse/SLING-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-2988. --- Support primitive types for ValueMap.get() -- Key: SLING-2988 URL: https://issues.apache.org/jira/browse/SLING-2988 Project: Sling Issue Type: Improvement Components: JCR Affects Versions: JCR Resource 2.1.0 Reporter: Konrad Windszus Currently the call for ValueMap.get(name, boolean.class) returns null while ValueMap.get(name, Boolean.class) returns true for a JCR property with type String having the value true. Please either throw an exception if primitive classes are given as second argument or support them as well. Just returning null is confusing, because it is not obvious from the Javadoc that no JCR attribute can be converted into a primitive. Currently the Javadoc states that this call either returns null or the value. Assigning null to a primitive would lead to an NPE. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2988) Support primitive types for ValueMap.get()
[ https://issues.apache.org/jira/browse/SLING-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-2988. - Resolution: Won't Fix Support primitive types for ValueMap.get() -- Key: SLING-2988 URL: https://issues.apache.org/jira/browse/SLING-2988 Project: Sling Issue Type: Improvement Components: JCR Affects Versions: JCR Resource 2.1.0 Reporter: Konrad Windszus Currently the call for ValueMap.get(name, boolean.class) returns null while ValueMap.get(name, Boolean.class) returns true for a JCR property with type String having the value true. Please either throw an exception if primitive classes are given as second argument or support them as well. Just returning null is confusing, because it is not obvious from the Javadoc that no JCR attribute can be converted into a primitive. Currently the Javadoc states that this call either returns null or the value. Assigning null to a primitive would lead to an NPE. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2988) Support primitive types for ValueMap.get()
[ https://issues.apache.org/jira/browse/SLING-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730645#comment-13730645 ] Carsten Ziegeler commented on SLING-2988: - We discussed this in SLING-2712, throwing an IAE would be a contract change Support primitive types for ValueMap.get() -- Key: SLING-2988 URL: https://issues.apache.org/jira/browse/SLING-2988 Project: Sling Issue Type: Improvement Components: JCR Affects Versions: JCR Resource 2.1.0 Reporter: Konrad Windszus Currently the call for ValueMap.get(name, boolean.class) returns null while ValueMap.get(name, Boolean.class) returns true for a JCR property with type String having the value true. Please either throw an exception if primitive classes are given as second argument or support them as well. Just returning null is confusing, because it is not obvious from the Javadoc that no JCR attribute can be converted into a primitive. Currently the Javadoc states that this call either returns null or the value. Assigning null to a primitive would lead to an NPE. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[RT] Logging and Logback
Hi, i've the need for a custom log append not logging into a file. This is something our current logging bundles do not support. By looking around using logback could be an answer and I also found [1] where moving to logback has already been discussed. So I'm wondering what/how to this. One solution would be to do this on our own as discussed in that thread, another solution would be to leverage other logging solutions like maybe pax logging and just providing a compatibility layer for our current configurations. WDYT? Regards Carsten [1] http://apache-sling.73963.n3.nabble.com/Trying-to-convert-Sling-Logging-gt-Logback-How-much-backwards-compatibility-do-we-need-td4020965.html -- Carsten Ziegeler cziege...@apache.org
[jira] [Updated] (SLING-2996) use project.* properties instead of pom.* properties
[ https://issues.apache.org/jira/browse/SLING-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz updated SLING-2996: Attachment: SLING-2996.patch use project.* properties instead of pom.* properties Key: SLING-2996 URL: https://issues.apache.org/jira/browse/SLING-2996 Project: Sling Issue Type: Improvement Reporter: Oliver Lietz Priority: Trivial Attachments: SLING-2996.patch pom.* properties are deprecated -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2996) use project.* properties instead of pom.* properties
Oliver Lietz created SLING-2996: --- Summary: use project.* properties instead of pom.* properties Key: SLING-2996 URL: https://issues.apache.org/jira/browse/SLING-2996 Project: Sling Issue Type: Improvement Reporter: Oliver Lietz Priority: Trivial pom.* properties are deprecated -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2996) use project.* properties instead of pom.* properties
[ https://issues.apache.org/jira/browse/SLING-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-2996: --- Assignee: Carsten Ziegeler use project.* properties instead of pom.* properties Key: SLING-2996 URL: https://issues.apache.org/jira/browse/SLING-2996 Project: Sling Issue Type: Improvement Reporter: Oliver Lietz Assignee: Carsten Ziegeler Priority: Trivial Attachments: SLING-2996.patch pom.* properties are deprecated -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2996) use project.* properties instead of pom.* properties
[ https://issues.apache.org/jira/browse/SLING-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-2996. - Resolution: Fixed Thanks for your patch, I've applied it use project.* properties instead of pom.* properties Key: SLING-2996 URL: https://issues.apache.org/jira/browse/SLING-2996 Project: Sling Issue Type: Improvement Reporter: Oliver Lietz Assignee: Carsten Ziegeler Priority: Trivial Attachments: SLING-2996.patch pom.* properties are deprecated -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: sling-samples-1.6 » Apache Sling Sample Application #426
See https://builds.apache.org/job/sling-samples-1.6/org.apache.sling.samples$org.apache.sling.samples.simple-demo/426/changes Changes: [cziegeler] SLING-2996 : use project.* properties instead of pom.* properties . Apply patch from Oliver Lietz -- Aug 6, 2013 1:54:50 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Aug 6, 2013 1:54:50 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Aug 6, 2013 1:54:50 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Building Apache Sling Sample Application 2.0.3-SNAPSHOT Aug 6, 2013 1:54:50 PM org.apache.maven.cli.event.ExecutionEventLogger projectStarted INFO: Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/maven-jspc-plugin/2.0.6/maven-jspc-plugin-2.0.6.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/maven-jspc-plugin/2.0.6/maven-jspc-plugin-2.0.6.pom (5 KB at 67.2 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/maven-jspc-plugin/2.0.6/maven-jspc-plugin-2.0.6.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/maven-jspc-plugin/2.0.6/maven-jspc-plugin-2.0.6.jar (21 KB at 318.9 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.ocm/2.0.2-incubator/org.apache.sling.jcr.ocm-2.0.2-incubator.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.ocm/2.0.2-incubator/org.apache.sling.jcr.ocm-2.0.2-incubator.pom (9 KB at 140.0 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-ocm/1.4/jackrabbit-ocm-1.4.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-ocm/1.4/jackrabbit-ocm-1.4.pom (6 KB at 76.3 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.scripting.jsp.taglib/2.0.2-incubator/org.apache.sling.scripting.jsp.taglib-2.0.2-incubator.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.scripting.jsp.taglib/2.0.2-incubator/org.apache.sling.scripting.jsp.taglib-2.0.2-incubator.pom (5 KB at 25.4 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.scripting.jsp/2.0.2-incubator/org.apache.sling.scripting.jsp-2.0.2-incubator.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.scripting.jsp/2.0.2-incubator/org.apache.sling.scripting.jsp-2.0.2-incubator.pom (7 KB at 111.0 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.classloader/2.0.2-incubator/org.apache.sling.jcr.classloader-2.0.2-incubator.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.classloader/2.0.2-incubator/org.apache.sling.jcr.classloader-2.0.2-incubator.pom (6 KB at 84.0 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-jcr-commons/1.4.2/jackrabbit-jcr-commons-1.4.2.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-jcr-commons/1.4.2/jackrabbit-jcr-commons-1.4.2.pom (4 KB at 55.0 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/tomcat/juli/6.0.14/juli-6.0.14.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/tomcat/juli/6.0.14/juli-6.0.14.pom (252 B at 3.9 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.ocm/2.0.2-incubator/org.apache.sling.jcr.ocm-2.0.2-incubator.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-ocm/1.4/jackrabbit-ocm-1.4.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.scripting.jsp.taglib/2.0.2-incubator/org.apache.sling.scripting.jsp.taglib-2.0.2-incubator.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.scripting.jsp/2.0.2-incubator/org.apache.sling.scripting.jsp-2.0.2-incubator.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.classloader/2.0.2-incubator/org.apache.sling.jcr.classloader-2.0.2-incubator.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-ocm/1.4/jackrabbit-ocm-1.4.jar (149 KB at 634.0 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-jcr-commons/1.4.2/jackrabbit-jcr-commons-1.4.2.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.classloader/2.0.2-incubator/org.apache.sling.jcr.classloader-2.0.2-incubator.jar (157 KB at 601.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/tomcat/juli/6.0.14/juli-6.0.14.jar Downloaded:
Build failed in Jenkins: sling-samples-1.6 #426
See https://builds.apache.org/job/sling-samples-1.6/426/changes Changes: [cziegeler] SLING-2996 : use project.* properties instead of pom.* properties . Apply patch from Oliver Lietz -- [...truncated 1177 lines...] Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.classloader/2.0.2-incubator/org.apache.sling.jcr.classloader-2.0.2-incubator.pom (6 KB at 84.0 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-jcr-commons/1.4.2/jackrabbit-jcr-commons-1.4.2.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-jcr-commons/1.4.2/jackrabbit-jcr-commons-1.4.2.pom (4 KB at 55.0 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/tomcat/juli/6.0.14/juli-6.0.14.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/tomcat/juli/6.0.14/juli-6.0.14.pom (252 B at 3.9 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.ocm/2.0.2-incubator/org.apache.sling.jcr.ocm-2.0.2-incubator.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-ocm/1.4/jackrabbit-ocm-1.4.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.scripting.jsp.taglib/2.0.2-incubator/org.apache.sling.scripting.jsp.taglib-2.0.2-incubator.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.scripting.jsp/2.0.2-incubator/org.apache.sling.scripting.jsp-2.0.2-incubator.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.classloader/2.0.2-incubator/org.apache.sling.jcr.classloader-2.0.2-incubator.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-ocm/1.4/jackrabbit-ocm-1.4.jar (149 KB at 634.0 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-jcr-commons/1.4.2/jackrabbit-jcr-commons-1.4.2.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.classloader/2.0.2-incubator/org.apache.sling.jcr.classloader-2.0.2-incubator.jar (157 KB at 601.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/tomcat/juli/6.0.14/juli-6.0.14.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.scripting.jsp.taglib/2.0.2-incubator/org.apache.sling.scripting.jsp.taglib-2.0.2-incubator.jar (16 KB at 56.9 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/tomcat/juli/6.0.14/juli-6.0.14.jar (18 KB at 275.8 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-jcr-commons/1.4.2/jackrabbit-jcr-commons-1.4.2.jar (162 KB at 918.3 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.jcr.ocm/2.0.2-incubator/org.apache.sling.jcr.ocm-2.0.2-incubator.jar (613 KB at 1338.4 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.scripting.jsp/2.0.2-incubator/org.apache.sling.scripting.jsp-2.0.2-incubator.jar (2131 KB at 2934.0 KB/sec) Aug 6, 2013 1:54:52 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Aug 6, 2013 1:54:52 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-clean-plugin:2.5:clean (default-clean) @ org.apache.sling.samples.simple-demo --- Aug 6, 2013 1:54:52 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Aug 6, 2013 1:54:52 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @ org.apache.sling.samples.simple-demo --- Aug 6, 2013 1:54:52 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Aug 6, 2013 1:54:52 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.samples.simple-demo --- [INFO] Executing tasks main: [INFO] Executed tasks Aug 6, 2013 1:54:52 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Aug 6, 2013 1:54:52 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-remote-resources-plugin:1.4:process (default) @ org.apache.sling.samples.simple-demo --- Aug 6, 2013 1:54:53 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Aug 6, 2013 1:54:53 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: --- maven-jcrocm-plugin:2.0.4-incubator:ocm (generate-JCR-OCM-descriptor) @ org.apache.sling.samples.simple-demo --- [INFO] Generating 2 OCM Mapping Descriptors to https://builds.apache.org/job/sling-samples-1.6/ws/samples-1.6/simple-demo/target/sling-generated/SLING-INF/mappings.xml Aug 6, 2013 1:54:53 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: Aug 6, 2013 1:54:53 PM org.apache.maven.cli.event.ExecutionEventLogger mojoStarted INFO: ---
Jenkins build became unstable: sling-contrib-1.6 » Apache Sling Launchpad Contrib Testing #1030
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.contrib-testing/1030/
Jenkins build became unstable: sling-contrib-1.6 #1030
See https://builds.apache.org/job/sling-contrib-1.6/1030/changes
[jira] [Created] (SLING-2997) ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6
Justin Edelson created SLING-2997: - Summary: ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6 Key: SLING-2997 URL: https://issues.apache.org/jira/browse/SLING-2997 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Justin Edelson Priority: Minor The class org.apache.sling.resourceaccesssecurity.impl.ResourceAccessSecurityImpl uses @Override to indicate interface implementation. This, however, is only valid on Java 6 and above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2997) ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6
[ https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-2997: - Assignee: Justin Edelson ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6 Key: SLING-2997 URL: https://issues.apache.org/jira/browse/SLING-2997 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Justin Edelson Assignee: Justin Edelson Priority: Minor Fix For: Resource Access Gate 1.0.0 The class org.apache.sling.resourceaccesssecurity.impl.ResourceAccessSecurityImpl uses @Override to indicate interface implementation. This, however, is only valid on Java 6 and above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2997) ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6
[ https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-2997: -- Fix Version/s: Resource Access Gate 1.0.0 ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6 Key: SLING-2997 URL: https://issues.apache.org/jira/browse/SLING-2997 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Justin Edelson Priority: Minor Fix For: Resource Access Gate 1.0.0 The class org.apache.sling.resourceaccesssecurity.impl.ResourceAccessSecurityImpl uses @Override to indicate interface implementation. This, however, is only valid on Java 6 and above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2997) ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6
[ https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2997. --- Resolution: Fixed fixed in 1510969 by setting sling.java.version to 6 ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6 Key: SLING-2997 URL: https://issues.apache.org/jira/browse/SLING-2997 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Justin Edelson Assignee: Justin Edelson Priority: Minor Fix For: Resource Access Gate 1.0.0 The class org.apache.sling.resourceaccesssecurity.impl.ResourceAccessSecurityImpl uses @Override to indicate interface implementation. This, however, is only valid on Java 6 and above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Adding a usage service property to BindingsValuesProvider ?
Hi, I'd like to use BindingsValuesProvider services in my health check module, to provide bindings like jmx for scripted health checks, which should be ignored for general Sling scripting (or not - some providers might apply to both general scripting and health checks). I'm thinking of adding an optional usage service property to BindingsValuesProvider services, does anyone see a problem with that? The Sling script engine would then consider only BindingsValuesProvider which have no usage property (for backwards compatibility) or which have usage=scripting. And my health checks would consider only BindingsValuesProvider which have usage=healthcheck. -Bertrand
Re: Adding a usage service property to BindingsValuesProvider ?
I'm not sure if I understand this 100% - from a scripting pov, how could I set the usage value, let's say in a JSP (or any other script)? Carsten 2013/8/6 Bertrand Delacretaz bdelacre...@apache.org Hi, I'd like to use BindingsValuesProvider services in my health check module, to provide bindings like jmx for scripted health checks, which should be ignored for general Sling scripting (or not - some providers might apply to both general scripting and health checks). I'm thinking of adding an optional usage service property to BindingsValuesProvider services, does anyone see a problem with that? The Sling script engine would then consider only BindingsValuesProvider which have no usage property (for backwards compatibility) or which have usage=scripting. And my health checks would consider only BindingsValuesProvider which have usage=healthcheck. -Bertrand -- Carsten Ziegeler cziege...@apache.org
[jira] [Created] (SLING-2998) SlingAuthenticator fails because of pathInfo being null
Oliver Lietz created SLING-2998: --- Summary: SlingAuthenticator fails because of pathInfo being null Key: SLING-2998 URL: https://issues.apache.org/jira/browse/SLING-2998 Project: Sling Issue Type: Bug Components: Authentication Affects Versions: Auth Core 1.1.2 Environment: Sling, CQ Reporter: Oliver Lietz - HttpServletRequest#getPathInfo():String returns null, use HttpServletRequest#getServletPath():String instead - path should never be changed to /, instead return anonymous credentials/false http://mail-archives.apache.org/mod_mbox/sling-users/201308.mbox/%3c201308021338.32243.apa...@oliverlietz.de%3e -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2997) ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6
[ https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730855#comment-13730855 ] Carsten Ziegeler commented on SLING-2997: - Do we really want to require java 6 just because of an annotation? I think we should rather not use the annotation and stick to java 5 unless there are good reasons ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6 Key: SLING-2997 URL: https://issues.apache.org/jira/browse/SLING-2997 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Justin Edelson Assignee: Justin Edelson Priority: Minor Fix For: Resource Access Gate 1.0.0 The class org.apache.sling.resourceaccesssecurity.impl.ResourceAccessSecurityImpl uses @Override to indicate interface implementation. This, however, is only valid on Java 6 and above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2998) SlingAuthenticator fails because of pathInfo being null
[ https://issues.apache.org/jira/browse/SLING-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz updated SLING-2998: Attachment: SLING-2998.patch SlingAuthenticator fails because of pathInfo being null --- Key: SLING-2998 URL: https://issues.apache.org/jira/browse/SLING-2998 Project: Sling Issue Type: Bug Components: Authentication Affects Versions: Auth Core 1.1.2 Environment: Sling, CQ Reporter: Oliver Lietz Labels: security Attachments: SLING-2998.patch - HttpServletRequest#getPathInfo():String returns null, use HttpServletRequest#getServletPath():String instead - path should never be changed to /, instead return anonymous credentials/false http://mail-archives.apache.org/mod_mbox/sling-users/201308.mbox/%3c201308021338.32243.apa...@oliverlietz.de%3e -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[security issue] Re: authentication with anonymous access enabled
Am Freitag, 2. August 2013 schrieb Oliver Lietz:
Am Freitag, 2. August 2013 schrieb Felix Meschberger:
Hi
hello all,
hello Felix,
I would assume the Sling Authentication Service has HTTP Basic
Authentication enabled with preemptive support. This means a 401 response
is never sent. Reconfiguring the Authentication Service to fully enable
HTTP Basic Authentication should do the trick.
it's already configured with full support. Any other idea?
I tracked it down to pathInfo always being null in SlingAuthenticator. Instead
of getPathInfo() getServletPath() should be used in all places. See
SLING-2998.
Regards,
O.
Regards,
O.
Hope this helps.
Regards
Felix
Am 02.08.2013 um 13:38 schrieb Oliver Lietz:
hello all,
I'm porting an application from Vaadin to Sling using HTML and a custom
Sling Servlet (service with property sling.servlet.paths).
This works fine, but securing this application with HTTP Basic
Authentication Handler does not work.
- Allow Anonymous Access is enabled (in Apache Sling Authentication
Service configuration)
- Authentication Requirements is empty (in Apache Sling Authentication
Service configuration)
- HTTP Basic Authentication Handler is the only handler and registered
for path /
- the custom servlet sets sling.auth.requirements to
{+/services/myservlet, +/content/myapp} (myapp contains the HTML in
JCR, no ACLs changed)
- Authenticator (slingauth) shows Authentication Required Yes for
/services/myservlet and /content/myapp and No for / (and also No for
/system/sling/logout, /system/sling/login, /server)
I expect the browser to ask for username and password when accessing
/content/myapp and /services/myservlet, but that does not happen.
What is missing? Is this intended behavior or a bug (same behavior on
current Sling and CQ 5.5)?
thanks,
O.
[jira] [Updated] (SLING-2987) Simplified health check services
[ https://issues.apache.org/jira/browse/SLING-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-2987: --- Attachment: webconsole-is-back.jpg The webconsole plugin works again at revision 1510875 in the https://svn.apache.org/repos/asf/sling/branches/SLING-2987-healthcheck-redesign - see attached webconsole-is-back.jpg screenshot. Simplified health check services Key: SLING-2987 URL: https://issues.apache.org/jira/browse/SLING-2987 Project: Sling Issue Type: Improvement Components: Health Check Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Attachments: webconsole-is-back.jpg After some prototyping, the health check tools are ready for a rewrite that will make them simpler and more OSGi friendly. The functionality will be similar but with much less code, more focused on the actual use cases that have emerged during prototyping. The new API is being discussed on list, http://markmail.org/thread/i6ib7tgax4cn2sss -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-2987) Simplified health check services
[ https://issues.apache.org/jira/browse/SLING-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730854#comment-13730854 ] Bertrand Delacretaz edited comment on SLING-2987 at 8/6/13 3:20 PM: The webconsole plugin works again at revision 1510875 in the https://svn.apache.org/repos/asf/sling/branches/SLING-2987-healthcheck-redesign - see attached webconsole-is-back.jpg screenshot. Also added the above demo configs to the https://svn.apache.org/repos/asf/sling/branches/SLING-2987-healthcheck-redesign/sling-demo module, so installing that bundle creates the demo configs. was (Author: bdelacretaz): The webconsole plugin works again at revision 1510875 in the https://svn.apache.org/repos/asf/sling/branches/SLING-2987-healthcheck-redesign - see attached webconsole-is-back.jpg screenshot. Simplified health check services Key: SLING-2987 URL: https://issues.apache.org/jira/browse/SLING-2987 Project: Sling Issue Type: Improvement Components: Health Check Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Attachments: webconsole-is-back.jpg After some prototyping, the health check tools are ready for a rewrite that will make them simpler and more OSGi friendly. The functionality will be similar but with much less code, more focused on the actual use cases that have emerged during prototyping. The new API is being discussed on list, http://markmail.org/thread/i6ib7tgax4cn2sss -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-2987) Simplified health check services
[ https://issues.apache.org/jira/browse/SLING-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13725058#comment-13725058 ] Bertrand Delacretaz edited comment on SLING-2987 at 8/6/13 3:19 PM: Starting redesigned implementation in a branch at http://svn.apache.org/repos/asf/sling/branches/SLING-2987-healthcheck-redesign/ Tagged the existing implementation, before these changes, as https://svn.apache.org/repos/asf/sling/tags/healthcheck-before-SLING-2987/ was (Author: bdelacretaz): Starting redesigned implementation in a branch at http://svn.apache.org/repos/asf/sling/branches/SLING-2987-healthcheck-redesign/ Simplified health check services Key: SLING-2987 URL: https://issues.apache.org/jira/browse/SLING-2987 Project: Sling Issue Type: Improvement Components: Health Check Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Attachments: webconsole-is-back.jpg After some prototyping, the health check tools are ready for a rewrite that will make them simpler and more OSGi friendly. The functionality will be similar but with much less code, more focused on the actual use cases that have emerged during prototyping. The new API is being discussed on list, http://markmail.org/thread/i6ib7tgax4cn2sss -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Adding a usage service property to BindingsValuesProvider ?
On Tue, Aug 6, 2013 at 5:13 PM, Carsten Ziegeler cziege...@apache.org wrote:
I'm not sure if I understand this 100% - from a scripting pov, how could I
set the usage value, let's say in a JSP (or any other script)?
You set the usage property when you create a BindingsValuesProvider,
so for my jmx example I'd do:
@Service
@Property(name=usage, value=healthcheck)
public class BindingsValuesProvider {
public void addBindings(Bindings b) {
b.put(jmx, new SomeObjectThatsSeenAsJmxFromHealthCheckScripts());
}
}
that jmx object is then available in health check scripts, but not
in general Sling rendering scripts.
-Bertrand
Build failed in Jenkins: sling-trunk-1.6 #1792
See https://builds.apache.org/job/sling-trunk-1.6/1792/changes Changes: [cziegeler] SLING-2996 : use project.* properties instead of pom.* properties . Apply patch from Oliver Lietz -- [...truncated 26767 lines...] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Launchpad Maven Plugin ... SUCCESS [7.711s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Launchpad Standalone Archetype .. SUCCESS [3.398s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Launchpad Webapp Archetype .. SUCCESS [1.536s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Initial Content Archetype ... SUCCESS [1.404s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Servlet Archetype ... SUCCESS [9.301s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Bundle Archetype SUCCESS [1.221s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling JCRInstall Bundle Archetype . SUCCESS [1.219s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Taglib Archetype SUCCESS [1.310s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling API .. SUCCESS [7.170s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Service User Mapper .. SUCCESS [3.876s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Resource Resolver SUCCESS [4.685s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: Java Transaction API SUCCESS [1.397s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: XML APIs SUCCESS [1.325s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: Activation API SUCCESS [1.372s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: WS APIs . SUCCESS [1.208s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Dynamic Class Loader Support . SUCCESS [10.191s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling JSON Library . SUCCESS [2.438s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling SLF4J Implementation . SUCCESS [5.296s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling OSGi LogService Implementation ... SUCCESS [1.532s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling MIME type mapping support SUCCESS [5.312s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Commons OSGi support . SUCCESS [2.423s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Scheduler Support SUCCESS [2.239s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Testing Utilities SUCCESS [11.847s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Thread Support ... SUCCESS [1.684s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Authentication Service ... SUCCESS [2.801s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling OpenID Authentication SUCCESS [3.752s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Form Based Authentication Handler SUCCESS [3.812s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Authentication Selector .. SUCCESS [1.782s] Aug 6, 2013 3:34:22 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache
Re: Adding a usage service property to BindingsValuesProvider ?
I guess this only works as you have a special script engine for health
check, right?
What if people want to use the same functionality if they write lets say
workflow scripts or wcm scripts etc?
As long as there is no way to make use of this in every script engine, I
don't see the point of adding it. It's a special requirement for hc, so it
should have a hc solution.
Carsten
2013/8/6 Bertrand Delacretaz bdelacre...@apache.org
On Tue, Aug 6, 2013 at 5:13 PM, Carsten Ziegeler cziege...@apache.org
wrote:
I'm not sure if I understand this 100% - from a scripting pov, how could
I
set the usage value, let's say in a JSP (or any other script)?
You set the usage property when you create a BindingsValuesProvider,
so for my jmx example I'd do:
@Service
@Property(name=usage, value=healthcheck)
public class BindingsValuesProvider {
public void addBindings(Bindings b) {
b.put(jmx, new SomeObjectThatsSeenAsJmxFromHealthCheckScripts());
}
}
that jmx object is then available in health check scripts, but not
in general Sling rendering scripts.
-Bertrand
--
Carsten Ziegeler
cziege...@apache.org
Re: Adding a usage service property to BindingsValuesProvider ?
On Tue, Aug 6, 2013 at 5:39 PM, Carsten Ziegeler cziege...@apache.org wrote: I guess this only works as you have a special script engine for health check, right? Not really a special script engine, but I'm using the ScriptEngineManager directly instead of going through SlingScript. See code at [1] where bindings are hardcoded for now - I could invent my own bindings providers interface but as we already have one why not reuse it? What if people want to use the same functionality if they write lets say workflow scripts or wcm scripts etc? The bindings service could be marked with usage=healthcheck,workflow,wcm, or the consumers could be configured to use bindings which are marked with usage=healthcheck. As long as there is no way to make use of this in every script engine, I don't see the point of adding it. It's a special requirement for hc, so it should have a hc solution. That's an option of course, that's why I'm asking for opinions. -Bertrand [1] https://svn.apache.org/repos/asf/sling/branches/SLING-2987-healthcheck-redesign/hc-core/src/main/java/org/apache/sling/hc/impl/ScriptableHealthCheck.java
Re: Adding a usage service property to BindingsValuesProvider ?
I think if we would be in the jsp world, you would do a taglib for this - of course taglibs are not usable within other scripting languages - so depending on your script language you would have to come up with the equivalent. Taglibs in JSP allow exactly what you want - the BVP is more a way to make objects always available to all script engines; so apart from adding the optional node and session objects, we don't use this in Sling at all... Carsten 2013/8/6 Bertrand Delacretaz bdelacre...@apache.org On Tue, Aug 6, 2013 at 5:39 PM, Carsten Ziegeler cziege...@apache.org wrote: I guess this only works as you have a special script engine for health check, right? Not really a special script engine, but I'm using the ScriptEngineManager directly instead of going through SlingScript. See code at [1] where bindings are hardcoded for now - I could invent my own bindings providers interface but as we already have one why not reuse it? What if people want to use the same functionality if they write lets say workflow scripts or wcm scripts etc? The bindings service could be marked with usage=healthcheck,workflow,wcm, or the consumers could be configured to use bindings which are marked with usage=healthcheck. As long as there is no way to make use of this in every script engine, I don't see the point of adding it. It's a special requirement for hc, so it should have a hc solution. That's an option of course, that's why I'm asking for opinions. -Bertrand [1] https://svn.apache.org/repos/asf/sling/branches/SLING-2987-healthcheck-redesign/hc-core/src/main/java/org/apache/sling/hc/impl/ScriptableHealthCheck.java -- Carsten Ziegeler cziege...@apache.org
[jira] [Commented] (SLING-2997) ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6
[ https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730881#comment-13730881 ] Justin Edelson commented on SLING-2997: --- I personally like having the @Override annotation for interfaces, so I'd consider this a good reason :) But I didn't write this code, so I can't speak to why it was used there. Another option would be to separate out the source vs. target version in the parent POM. Right now, there is one property which controls both. ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6 Key: SLING-2997 URL: https://issues.apache.org/jira/browse/SLING-2997 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Justin Edelson Assignee: Justin Edelson Priority: Minor Fix For: Resource Access Gate 1.0.0 The class org.apache.sling.resourceaccesssecurity.impl.ResourceAccessSecurityImpl uses @Override to indicate interface implementation. This, however, is only valid on Java 6 and above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Adding a usage service property to BindingsValuesProvider ?
And forgot to mention :) I think your current approach is fine, as these objects are special objects for health checks, you have special execution code and can handle it there. Carsten 2013/8/6 Carsten Ziegeler cziege...@apache.org I think if we would be in the jsp world, you would do a taglib for this - of course taglibs are not usable within other scripting languages - so depending on your script language you would have to come up with the equivalent. Taglibs in JSP allow exactly what you want - the BVP is more a way to make objects always available to all script engines; so apart from adding the optional node and session objects, we don't use this in Sling at all... Carsten 2013/8/6 Bertrand Delacretaz bdelacre...@apache.org On Tue, Aug 6, 2013 at 5:39 PM, Carsten Ziegeler cziege...@apache.org wrote: I guess this only works as you have a special script engine for health check, right? Not really a special script engine, but I'm using the ScriptEngineManager directly instead of going through SlingScript. See code at [1] where bindings are hardcoded for now - I could invent my own bindings providers interface but as we already have one why not reuse it? What if people want to use the same functionality if they write lets say workflow scripts or wcm scripts etc? The bindings service could be marked with usage=healthcheck,workflow,wcm, or the consumers could be configured to use bindings which are marked with usage=healthcheck. As long as there is no way to make use of this in every script engine, I don't see the point of adding it. It's a special requirement for hc, so it should have a hc solution. That's an option of course, that's why I'm asking for opinions. -Bertrand [1] https://svn.apache.org/repos/asf/sling/branches/SLING-2987-healthcheck-redesign/hc-core/src/main/java/org/apache/sling/hc/impl/ScriptableHealthCheck.java -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org
[jira] [Commented] (SLING-2997) ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6
[ https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730884#comment-13730884 ] Carsten Ziegeler commented on SLING-2997: - So could we simply set source fixed to 1.6 (for now), and by default target is 1.5 and can be changed to 1.6? ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6 Key: SLING-2997 URL: https://issues.apache.org/jira/browse/SLING-2997 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Justin Edelson Assignee: Justin Edelson Priority: Minor Fix For: Resource Access Gate 1.0.0 The class org.apache.sling.resourceaccesssecurity.impl.ResourceAccessSecurityImpl uses @Override to indicate interface implementation. This, however, is only valid on Java 6 and above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: sling-trunk-1.7 #164
See https://builds.apache.org/job/sling-trunk-1.7/164/changes Changes: [cziegeler] SLING-2996 : use project.* properties instead of pom.* properties . Apply patch from Oliver Lietz -- [...truncated 23503 lines...] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Adapter Annotations . SUCCESS [3.978s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Maven Plugin to create Jackrabbit OCM descriptors SUCCESS [5.497s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Maven Plugin for Compiling JSP Sources into Bundles SUCCESS [4.440s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Maven Plugin for Supporting Bundle Development SUCCESS [4.375s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Launchpad Maven Plugin ... SUCCESS [15.617s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Launchpad Standalone Archetype .. SUCCESS [5.298s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Launchpad Webapp Archetype .. SUCCESS [2.764s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Initial Content Archetype ... SUCCESS [2.466s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Servlet Archetype ... SUCCESS [11.062s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Bundle Archetype SUCCESS [2.675s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling JCRInstall Bundle Archetype . SUCCESS [2.683s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Taglib Archetype SUCCESS [2.703s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling API .. SUCCESS [10.399s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Service User Mapper .. SUCCESS [4.850s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Resource Resolver SUCCESS [8.483s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: Java Transaction API SUCCESS [2.402s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: XML APIs SUCCESS [2.450s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: Activation API SUCCESS [2.387s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: WS APIs . SUCCESS [2.792s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Dynamic Class Loader Support . SUCCESS [11.203s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling JSON Library . SUCCESS [6.645s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling SLF4J Implementation . SUCCESS [11.329s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling OSGi LogService Implementation ... SUCCESS [3.633s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling MIME type mapping support SUCCESS [8.385s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Commons OSGi support . SUCCESS [4.423s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Scheduler Support SUCCESS [4.259s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Testing Utilities SUCCESS [29.657s] Aug 06, 2013 4:19:35 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Thread Support ... SUCCESS [3.015s] Aug 06, 2013 4:19:35 PM
JIRA Access
All, My JIRA user 'klcodanr' does not seem to have sufficient permissions to manage versions in JIRA, can I be granted sufficient permissions? Thanks, Dan
Re: Adding a usage service property to BindingsValuesProvider ?
Hi Bertrand, FWIW, I was thinking about something very similar (although I was thinking of calling it 'scope', not 'usage'), but never got around to implementing it. +1 for me. Justin On Tue, Aug 6, 2013 at 10:58 AM, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi, I'd like to use BindingsValuesProvider services in my health check module, to provide bindings like jmx for scripted health checks, which should be ignored for general Sling scripting (or not - some providers might apply to both general scripting and health checks). I'm thinking of adding an optional usage service property to BindingsValuesProvider services, does anyone see a problem with that? The Sling script engine would then consider only BindingsValuesProvider which have no usage property (for backwards compatibility) or which have usage=scripting. And my health checks would consider only BindingsValuesProvider which have usage=healthcheck. -Bertrand
[jira] [Commented] (SLING-2997) ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6
[ https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730956#comment-13730956 ] Justin Edelson commented on SLING-2997: --- I think so, but right now the parent pom only lets you specify them with one property. And retaining Java 5 for this (new, never released) bundle doesn't really seem worth it. ResourceAccessSecurityImpl uses @Override for interface methods, but does not declare compiler version as Java 6 Key: SLING-2997 URL: https://issues.apache.org/jira/browse/SLING-2997 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Justin Edelson Assignee: Justin Edelson Priority: Minor Fix For: Resource Access Gate 1.0.0 The class org.apache.sling.resourceaccesssecurity.impl.ResourceAccessSecurityImpl uses @Override to indicate interface implementation. This, however, is only valid on Java 6 and above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Adding a usage service property to BindingsValuesProvider ?
Ok, just to make it clear, as long as there is no support in all script engines, I'm -1 Carsten 2013/8/6 Justin Edelson jus...@justinedelson.com Hi Bertrand, FWIW, I was thinking about something very similar (although I was thinking of calling it 'scope', not 'usage'), but never got around to implementing it. +1 for me. Justin On Tue, Aug 6, 2013 at 10:58 AM, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi, I'd like to use BindingsValuesProvider services in my health check module, to provide bindings like jmx for scripted health checks, which should be ignored for general Sling scripting (or not - some providers might apply to both general scripting and health checks). I'm thinking of adding an optional usage service property to BindingsValuesProvider services, does anyone see a problem with that? The Sling script engine would then consider only BindingsValuesProvider which have no usage property (for backwards compatibility) or which have usage=scripting. And my health checks would consider only BindingsValuesProvider which have usage=healthcheck. -Bertrand -- Carsten Ziegeler cziege...@apache.org
Re: JIRA Access
Hi Dan I made you an administrator of the Sling project. Should work now, I hope. Regards Felix Am 06.08.2013 um 18:33 schrieb Daniel Klco: All, My JIRA user 'klcodanr' does not seem to have sufficient permissions to manage versions in JIRA, can I be granted sufficient permissions? Thanks, Dan
Build failed in Jenkins: sling-trunk-1.6 #1793
See https://builds.apache.org/job/sling-trunk-1.6/1793/changes Changes: [justin] SLING-2997 - setting sling.java.version to 6 for resource access gate due to use of @Override -- [...truncated 23649 lines...] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Launchpad Maven Plugin ... SUCCESS [16.055s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Launchpad Standalone Archetype .. SUCCESS [4.317s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Launchpad Webapp Archetype .. SUCCESS [2.862s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Initial Content Archetype ... SUCCESS [3.401s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Servlet Archetype ... SUCCESS [10.735s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Bundle Archetype SUCCESS [3.319s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling JCRInstall Bundle Archetype . SUCCESS [3.158s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Taglib Archetype SUCCESS [3.063s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling API .. SUCCESS [10.126s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Service User Mapper .. SUCCESS [7.256s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Resource Resolver SUCCESS [8.740s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: Java Transaction API SUCCESS [3.401s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: XML APIs SUCCESS [3.125s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: Activation API SUCCESS [3.219s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: WS APIs . SUCCESS [3.103s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Dynamic Class Loader Support . SUCCESS [17.336s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling JSON Library . SUCCESS [5.546s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling SLF4J Implementation . SUCCESS [11.112s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling OSGi LogService Implementation ... SUCCESS [2.611s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling MIME type mapping support SUCCESS [8.540s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Commons OSGi support . SUCCESS [4.083s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Scheduler Support SUCCESS [4.565s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Testing Utilities SUCCESS [31.711s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Thread Support ... SUCCESS [3.801s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Authentication Service ... SUCCESS [5.634s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling OpenID Authentication SUCCESS [7.709s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Form Based Authentication Handler SUCCESS [6.375s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Authentication Selector .. SUCCESS [2.777s] Aug 6, 2013 6:09:21 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling
Re: Adding a usage service property to BindingsValuesProvider ?
Hi Carsten, I can't speak for exactly what Bertrand is thinking, but when I was thinking about it, the scope/usage was an orthogonal concern to which engine is selected. Whereas today you do: ScriptEngineManager.getEngineByExtension(ecma) You could do ScriptEngineManager.getEngineByExtension(ecma, [healthcheck, workflow]) (of course, we can't actually do that as ScriptEngineManager is a JDK class; we'd have to create an extension) Alternatively, this could be done after SlingScript object is created: SlingScript script = resource.adaptTo(SlingScript.class); script.setUsage([healthcheck]); When creating the SlingBindings for the script to execute, the following BindingsValuesProviders would be consulted (in order): * the generic BVPs (which apply to all scripting languages) * the BVPs tagged with the value of the script engine factory's compatible.javax.script.name property * the BVPs tagged with the script engine factory's name * the BVPs tagged with the scope/usage property Or something like that... The significant advantage of doing this vs. hardcoding the usage-specific bindings at the point of script engine access is that it doesn't allow for downstream customization. Which is important IMHO in the case of healthcheck - we want to enable custom hc rules which may benefit from a custom BVP. This is also true in a workflow engine. Justin On Tue, Aug 6, 2013 at 1:41 PM, Carsten Ziegeler cziege...@apache.orgwrote: Ok, just to make it clear, as long as there is no support in all script engines, I'm -1 Carsten 2013/8/6 Justin Edelson jus...@justinedelson.com Hi Bertrand, FWIW, I was thinking about something very similar (although I was thinking of calling it 'scope', not 'usage'), but never got around to implementing it. +1 for me. Justin On Tue, Aug 6, 2013 at 10:58 AM, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi, I'd like to use BindingsValuesProvider services in my health check module, to provide bindings like jmx for scripted health checks, which should be ignored for general Sling scripting (or not - some providers might apply to both general scripting and health checks). I'm thinking of adding an optional usage service property to BindingsValuesProvider services, does anyone see a problem with that? The Sling script engine would then consider only BindingsValuesProvider which have no usage property (for backwards compatibility) or which have usage=scripting. And my health checks would consider only BindingsValuesProvider which have usage=healthcheck. -Bertrand -- Carsten Ziegeler cziege...@apache.org
Build failed in Jenkins: sling-trunk-1.7 #165
See https://builds.apache.org/job/sling-trunk-1.7/165/changes Changes: [justin] SLING-2997 - setting sling.java.version to 6 for resource access gate due to use of @Override -- [...truncated 26672 lines...] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Adapter Annotations . SUCCESS [2.318s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Maven Plugin to create Jackrabbit OCM descriptors SUCCESS [3.151s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Maven Plugin for Compiling JSP Sources into Bundles SUCCESS [2.650s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Maven Plugin for Supporting Bundle Development SUCCESS [2.753s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Launchpad Maven Plugin ... SUCCESS [8.348s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Launchpad Standalone Archetype .. SUCCESS [2.929s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Launchpad Webapp Archetype .. SUCCESS [1.653s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Initial Content Archetype ... SUCCESS [1.486s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Servlet Archetype ... SUCCESS [7.352s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Bundle Archetype SUCCESS [1.469s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling JCRInstall Bundle Archetype . SUCCESS [1.317s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Sling Taglib Archetype SUCCESS [1.485s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling API .. SUCCESS [6.129s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Service User Mapper .. SUCCESS [2.957s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Resource Resolver SUCCESS [5.052s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: Java Transaction API SUCCESS [1.544s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: XML APIs SUCCESS [1.352s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: Activation API SUCCESS [1.701s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling System Bundle Extension: WS APIs . SUCCESS [1.371s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Dynamic Class Loader Support . SUCCESS [3.737s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling JSON Library . SUCCESS [2.609s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling SLF4J Implementation . SUCCESS [5.401s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling OSGi LogService Implementation ... SUCCESS [1.540s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling MIME type mapping support SUCCESS [5.299s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Commons OSGi support . SUCCESS [2.681s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Scheduler Support SUCCESS [2.606s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Testing Utilities SUCCESS [12.735s] Aug 06, 2013 6:53:06 PM org.apache.maven.cli.event.ExecutionEventLogger logReactorSummary INFO: Apache Sling Thread Support ... SUCCESS [1.698s] Aug 06, 2013 6:53:06 PM
Time to release Sling 6 update 1 ? ( Was : Re: Time to release Sling 7? )
Sorry to resurrect such an old thread, but I started this conversation 3 months ago and we aren't close to releasing Sling 7. IMO the build server flakiness contributes to this uncertainty, but so do a few or our tests, being unstable as well. What I'd like to propose now is to make a very minor, specific release of the Sling Launchpad: build it with org.apache.sling.launchpad.base 2.5.0 . This is a low-risk move - I've tested it myself and has the advantage of allowing first-time users to get on board with Java 7. Right now I fear that some of them walk away after an unsuccessful attempt of running Sling. Thoughts? Robert
Re: Adding a usage service property to BindingsValuesProvider ?
I'm not totally against this, but just adhoc adding this property without a complete concept seems wrong to me. Defining the technical selection process (e.g. as you describe it) is one part, but the other equally important part, how to select from a script dev point of view. How can I write a JSP and tag this as a healtcheck script? And how does this work for other scripting languages? Can we find a generic way that works in all / most scripting languages? Do we really have different existing use cases apart from hc or is this just a it would be nice? As said, for JSPs we have taglibs which would solve the problem and doesn't require a BVP, I think for javascript is something equivalent. Of course as a provider of such support you have to provide different implementations (a taglib, a javascript lib etc.) - and maybe we should tackle it from this angle. Carsten 2013/8/6 Justin Edelson jus...@justinedelson.com Hi Carsten, I can't speak for exactly what Bertrand is thinking, but when I was thinking about it, the scope/usage was an orthogonal concern to which engine is selected. Whereas today you do: ScriptEngineManager.getEngineByExtension(ecma) You could do ScriptEngineManager.getEngineByExtension(ecma, [healthcheck, workflow]) (of course, we can't actually do that as ScriptEngineManager is a JDK class; we'd have to create an extension) Alternatively, this could be done after SlingScript object is created: SlingScript script = resource.adaptTo(SlingScript.class); script.setUsage([healthcheck]); When creating the SlingBindings for the script to execute, the following BindingsValuesProviders would be consulted (in order): * the generic BVPs (which apply to all scripting languages) * the BVPs tagged with the value of the script engine factory's compatible.javax.script.name property * the BVPs tagged with the script engine factory's name * the BVPs tagged with the scope/usage property Or something like that... The significant advantage of doing this vs. hardcoding the usage-specific bindings at the point of script engine access is that it doesn't allow for downstream customization. Which is important IMHO in the case of healthcheck - we want to enable custom hc rules which may benefit from a custom BVP. This is also true in a workflow engine. Justin On Tue, Aug 6, 2013 at 1:41 PM, Carsten Ziegeler cziege...@apache.org wrote: Ok, just to make it clear, as long as there is no support in all script engines, I'm -1 Carsten 2013/8/6 Justin Edelson jus...@justinedelson.com Hi Bertrand, FWIW, I was thinking about something very similar (although I was thinking of calling it 'scope', not 'usage'), but never got around to implementing it. +1 for me. Justin On Tue, Aug 6, 2013 at 10:58 AM, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi, I'd like to use BindingsValuesProvider services in my health check module, to provide bindings like jmx for scripted health checks, which should be ignored for general Sling scripting (or not - some providers might apply to both general scripting and health checks). I'm thinking of adding an optional usage service property to BindingsValuesProvider services, does anyone see a problem with that? The Sling script engine would then consider only BindingsValuesProvider which have no usage property (for backwards compatibility) or which have usage=scripting. And my health checks would consider only BindingsValuesProvider which have usage=healthcheck. -Bertrand -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org
Re: Time to release Sling 6 update 1 ? ( Was : Re: Time to release Sling 7? )
I definitely agree that we should try to get Sling 6 out asap - and I think we're pretty close to that. Apart maybe from a release of one or two additional bundles, we need to release the discovery stuff (I plan to do this end of this week/early next week) and the new admin login stuff Felix is working on (hopefully this needs just a few weeks from now). Once these releases are through we can release Sling 6. So I think let's look at the snapshot dependencies in launchpad, see if these artifacts have some urgent open issues, fix them (if there are any) and then release the stuff. For the build server problems, I'm totally unhappy with the Jenkins installation (and this since years) - apart from spamming the mailing list, the value right now seems really very low. Though I have no idea how to change this... Regards Carsten 2013/8/7 Robert Munteanu romb...@apache.org Sorry to resurrect such an old thread, but I started this conversation 3 months ago and we aren't close to releasing Sling 7. IMO the build server flakiness contributes to this uncertainty, but so do a few or our tests, being unstable as well. What I'd like to propose now is to make a very minor, specific release of the Sling Launchpad: build it with org.apache.sling.launchpad.base 2.5.0 . This is a low-risk move - I've tested it myself and has the advantage of allowing first-time users to get on board with Java 7. Right now I fear that some of them walk away after an unsuccessful attempt of running Sling. Thoughts? Robert -- Carsten Ziegeler cziege...@apache.org
