[jira] [Commented] (SLING-7468) Allow to configure the Distribution Resource Provider

[Tommaso Teofili (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351293#comment-16351293
 ] 

Tommaso Teofili commented on SLING-7468:


big +1 on my side as well, and btw I would opt for configuration-less (figure 
out mappings at runtime).

> Allow to configure the Distribution Resource Provider
> -
>
> Key: SLING-7468
> URL: https://issues.apache.org/jira/browse/SLING-7468
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
>
> SCD maintain its own Resource Provider
> https://github.com/apache/sling-org-apache-sling-distribution-core/tree/master/src/main/java/org/apache/sling/distribution/resources
> The implementation maps OSGI configurations and services as sling resources.
> The implementation is not flexible to allow plugging a custom agent in the 
> resource tree.
> The mapping seems to be done currently in enums, for instance
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/component/impl/DistributionComponentKind.java
> This issue is about making the configuration flexible (OSGI properties) or 
> even configuration-less (figure out the mappings at runtime). As a side 
> effect, the implementation may be simplified. 
> [~teofili],[~simone.tripodi] FYI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: apache/sling as github landing repository

[Alexander Klimetschek]

On 31.01.2018, at 00:23, Robert Munteanu  wrote:
> Links to commits and files from the old sling repo. For example
> 
> * https://github.com/apache/sling/commit/368f5f9c9f6d4c0e2602065687d95e
> b173f94b85
> * https://github.com/apache/sling/blob/trunk/bundles/extensions/bundler
> esource/src/main/java/org/apache/sling/bundleresource/impl/BundleResour
> ce.java
> 
> These would break if we add another 'sling' repo but work since we
> renamed 'sling' to 'sling-old-svn-mirror' and Github is adding
> redirects.
> […]
> Right, but it's not about conflicts, it's about breaking old links.
> Backwards compatiblity and all that :-)

Step 2 would include the old sling repo under apache/sling again, so that all 
links work (as discussed below).

> Actually that's not a bad idea :-) The only downside would be that
> cloning the repository would be really slow due to the large size. Not
> sure if we can work around it.

Then maybe it's ok to have the aggregator list in a different repo, prominently 
linked from apache/sling, and the sling one stays as just a landing page repo, 
with mostly manually curated markdown files. Where cloning a large repo is not 
such a big deal, as it would be on people's local computer and already cloned 
(unlike the aggregator which might be cloned a lot by CI tools and new users).

Cheers,
Alex

Re: Limited search and find a file after git repo split

[Alexander Klimetschek]

On 30.01.2018, at 23:41, Robert Munteanu  wrote:
> After a quick look at the github pages my only suggestion is using the
> advanced search page
> 
>  https://github.com/search/advanced
> 
> and filling in all the sling repos in the repo field. The search would
> then be something like this
> 
>  org:apache repo:org-apache-sling-api ResourceResolver
> 
> Unfortunately it does not seem to work :-( .

Too many repos :)

The root problem I think is that all apache projects are under one github 
organization. A github org is the natural place for multi-repository projects, 
and most features like search work well across all repos in one org.

Maybe the ASF can be persuaded to support "apache-" organizations, 
with github somehow locking the "apache-*" namespace. Although I doubt this 
would ever happen.

Cheers,
Alex

[jira] [Resolved] (SLING-7470) Memory Leak for "fake" Request objects in ModelAdapterFactory

[Justin Edelson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson resolved SLING-7470.
---
Resolution: Fixed

Fixed by 
https://github.com/apache/sling-org-apache-sling-models-impl/commit/b0647a3419924c46e58b78aa6384e0f49491a0c6

> Memory Leak for "fake" Request objects in ModelAdapterFactory
> -
>
> Key: SLING-7470
> URL: https://issues.apache.org/jira/browse/SLING-7470
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Sling Models Impl 1.4.6
>Reporter: Justin Edelson
>Assignee: Justin Edelson
>Priority: Critical
> Fix For: Sling Models Impl 1.4.8
>
>
> The functionality added in SLING-5668 to dispose of OSGi services (or 
> anything else needing disposal when creating a Sling Model object) based on 
> the ServletRequest lifecycle only works if the ServletRequest object was 
> actually created by the ServletContext. In some cases, applications make 
> construct "fake" request object (primarily for use with 
> SlingRequestProcessor). In these cases, since the ServletContext didn't 
> create these requests, it won't call the requestDestroyed method when they 
> are complete.
>  
> The easiest way to resolve this is to only apply the special behavior in 
> SLING-5668 to request objects actually created by the ServletContext and use 
> the general-purpose ReferenceQueue method for all other requests (and all 
> other adaptables).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7470) Memory Leak for "fake" Request objects in ModelAdapterFactory

[Justin Edelson (JIRA)]

Justin Edelson created SLING-7470:
-

 Summary: Memory Leak for "fake" Request objects in 
ModelAdapterFactory
 Key: SLING-7470
 URL: https://issues.apache.org/jira/browse/SLING-7470
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Sling Models Impl 1.4.6
Reporter: Justin Edelson
Assignee: Justin Edelson
 Fix For: Sling Models Impl 1.4.8


The functionality added in SLING-5668 to dispose of OSGi services (or anything 
else needing disposal when creating a Sling Model object) based on the 
ServletRequest lifecycle only works if the ServletRequest object was actually 
created by the ServletContext. In some cases, applications make construct 
"fake" request object (primarily for use with SlingRequestProcessor). In these 
cases, since the ServletContext didn't create these requests, it won't call the 
requestDestroyed method when they are complete.

 

The easiest way to resolve this is to only apply the special behavior in 
SLING-5668 to request objects actually created by the ServletContext and use 
the general-purpose ReferenceQueue method for all other requests (and all other 
adaptables).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7469) Migrate to OSGi R6 annotations and use bnd Maven plugins

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7469.
-
Resolution: Done

> Migrate to OSGi R6 annotations and use bnd Maven plugins
> 
>
> Key: SLING-7469
> URL: https://issues.apache.org/jira/browse/SLING-7469
> Project: Sling
>  Issue Type: Task
>  Components: Health Check
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Health Check Core 1.2.12
>
>
> * update to Sling Parent 33
> * clean up and update dependencies



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7469) Migrate to OSGi R6 annotations and use bnd Maven plugins

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-7469:
---

 Summary: Migrate to OSGi R6 annotations and use bnd Maven plugins
 Key: SLING-7469
 URL: https://issues.apache.org/jira/browse/SLING-7469
 Project: Sling
  Issue Type: Task
  Components: Health Check
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Health Check Core 1.2.12


* update to Sling Parent 33
* clean up and update dependencies



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: release:prepare & bnd-baseline-maven-plugin

[Oliver Lietz]

On Friday 02 February 2018 22:15:58 Nicolas Peltier wrote:
> Hey,

Hi Nicolas,

> i had already bumped package-info to 2.0.0 for pipes a while ago.
> Tonight i finally try to release it, but i'm under the impression baseline
> "thinks" 2.0.0 is already out because i deployed the snapshot with that
> version, see messages below.
> 
> Is there a trick i'm not aware of? What did i do wrong?

the trick is adding

-Darguments="-Dbnd.baseline.skip=true"

to your Maven release command.

Regards,
O.

> INFO] [INFO] --- bnd-baseline-maven-plugin:3.5.0:baseline (default) @
> org.apache.sling.pipes ---
> [INFO] [INFO] Automatically determining the baseline version for
> org.apache.sling:org.apache.sling.pipes:jar:2.0.0 using repositories
> ...
> [INFO] Downloading:
> https://repository.apache.org/service/local/staging/deploy/maven2/org/apache
> /sling/org.apache.sling.pipes/maven-metadata.xml ...
> [INFO] [INFO] The baseline version was found to be 2.0.0-SNAPSHOT
> ...
> [INFO] Downloading:
> https://repository.apache.org/service/local/staging/deploy/maven2/org/apache
> /sling/org.apache.sling.pipes/2.0.0-SNAPSHOT/maven-metadata.xml ...
> [INFO] [ERROR] The bundle version change (2.0.0 to 2.0.0) is too low, the
> new version must be at least 2.0.1

release:prepare & bnd-baseline-maven-plugin

[Nicolas Peltier]

Hey,

i had already bumped package-info to 2.0.0 for pipes a while ago.
Tonight i finally try to release it, but i'm under the impression baseline
"thinks" 2.0.0 is already out because i deployed the snapshot with that
version, see messages below.

Is there a trick i'm not aware of? What did i do wrong?

INFO] [INFO] --- bnd-baseline-maven-plugin:3.5.0:baseline (default) @
org.apache.sling.pipes ---
[INFO] [INFO] Automatically determining the baseline version for
org.apache.sling:org.apache.sling.pipes:jar:2.0.0 using repositories
...
[INFO] Downloading:
https://repository.apache.org/service/local/staging/deploy/maven2/org/apache/sling/org.apache.sling.pipes/maven-metadata.xml
...
[INFO] [INFO] The baseline version was found to be 2.0.0-SNAPSHOT
...
[INFO] Downloading:
https://repository.apache.org/service/local/staging/deploy/maven2/org/apache/sling/org.apache.sling.pipes/2.0.0-SNAPSHOT/maven-metadata.xml
...
[INFO] [ERROR] The bundle version change (2.0.0 to 2.0.0) is too low, the
new version must be at least 2.0.1

[jira] [Commented] (SLING-7275) update sling pipes documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350932#comment-16350932
 ] 

ASF GitHub Bot commented on SLING-7275:
---

npeltier commented on issue #8: SLING-7275 update sling pipe documentation
URL: https://github.com/apache/sling-site/pull/8#issuecomment-362702415
 
 
   this should be merged when sling pipes 2.0.0 is out


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> update sling pipes documentation
> 
>
> Key: SLING-7275
> URL: https://issues.apache.org/jira/browse/SLING-7275
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: pipes 2.0.0
>
>
> Documentation should be much clearer (in several pages, with nested details 
> only if needed), and adapted to pipes 2.0.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7275) update sling pipes documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350931#comment-16350931
 ] 

ASF GitHub Bot commented on SLING-7275:
---

npeltier opened a new pull request #8: SLING-7275 update sling pipe 
documentation
URL: https://github.com/apache/sling-site/pull/8
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> update sling pipes documentation
> 
>
> Key: SLING-7275
> URL: https://issues.apache.org/jira/browse/SLING-7275
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: pipes 2.0.0
>
>
> Documentation should be much clearer (in several pages, with nested details 
> only if needed), and adapted to pipes 2.0.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7168) Allow to implement custom distribution agents/queues

[Timothee Maret (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350645#comment-16350645
 ] 

Timothee Maret commented on SLING-7168:
---

I renamed the next Content Distribution Core release to 0.3.0 to match the new 
package exports 

> Allow to implement custom distribution agents/queues
> 
>
> Key: SLING-7168
> URL: https://issues.apache.org/jira/browse/SLING-7168
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.8
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.3.0
>
>
> Currently, it is not possible to implements distribution agents and queues, 
> implemented in another bundle than the {{org.apache.sling.distribution.core}} 
> bundle.
> Implementing a custom distribution agent outside of the 
> {{org.apache.sling.distribution.core}} bundle is useful when leveraging an 
> ad-hoc communication layer.
> This issue is about allowing to plug an external distribution agent/queue 
> provided via a separate bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7168) Allow to implement custom distribution agents/queues

[Timothee Maret (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret resolved SLING-7168.
---
   Resolution: Fixed
Fix Version/s: (was: Content Distribution API 0.4.0)

> Allow to implement custom distribution agents/queues
> 
>
> Key: SLING-7168
> URL: https://issues.apache.org/jira/browse/SLING-7168
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.8
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.2.12
>
>
> Currently, it is not possible to implements distribution agents and queues, 
> implemented in another bundle than the {{org.apache.sling.distribution.core}} 
> bundle.
> Implementing a custom distribution agent outside of the 
> {{org.apache.sling.distribution.core}} bundle is useful when leveraging an 
> ad-hoc communication layer.
> This issue is about allowing to plug an external distribution agent/queue 
> provided via a separate bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7168) Allow to implement custom distribution agents/queues

[Timothee Maret (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350638#comment-16350638
 ] 

Timothee Maret commented on SLING-7168:
---

Thanks [~simone.tripodi] and [~teofili]! 
I have merged to master and pushed.

https://github.com/apache/sling-org-apache-sling-distribution-core/commit/7317793d754205b47c1edb24d259c725a12d4b67

> Allow to implement custom distribution agents/queues
> 
>
> Key: SLING-7168
> URL: https://issues.apache.org/jira/browse/SLING-7168
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.8
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.2.12, Content Distribution 
> API 0.4.0
>
>
> Currently, it is not possible to implements distribution agents and queues, 
> implemented in another bundle than the {{org.apache.sling.distribution.core}} 
> bundle.
> Implementing a custom distribution agent outside of the 
> {{org.apache.sling.distribution.core}} bundle is useful when leveraging an 
> ad-hoc communication layer.
> This issue is about allowing to plug an external distribution agent/queue 
> provided via a separate bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7168) Allow to implement custom distribution agents/queues

[Tommaso Teofili (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350573#comment-16350573
 ] 

Tommaso Teofili commented on SLING-7168:


+1 sounds good to me.

> Allow to implement custom distribution agents/queues
> 
>
> Key: SLING-7168
> URL: https://issues.apache.org/jira/browse/SLING-7168
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.8
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.2.12, Content Distribution 
> API 0.4.0
>
>
> Currently, it is not possible to implements distribution agents and queues, 
> implemented in another bundle than the {{org.apache.sling.distribution.core}} 
> bundle.
> Implementing a custom distribution agent outside of the 
> {{org.apache.sling.distribution.core}} bundle is useful when leveraging an 
> ad-hoc communication layer.
> This issue is about allowing to plug an external distribution agent/queue 
> provided via a separate bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling Discovery Base 2.0.8 and Discovery Support 1.0.4

[Carsten Ziegeler]

+1


Carsten Ziegeler wrote
> Hi,
> 
> We solved 1 issues in discovery base and 1 in discovery support (same
> problem):
> 
> https://issues.apache.org/jira/browse/SLING-7459
> https://issues.apache.org/jira/browse/SLING-7461
> 
> (This is take 2, I dropped the release for versions 2.0.6 and 1.0.2 and
> started this new vote with new versions)
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1872
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 1872 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards
> Carsten
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[VOTE] Release Apache Sling Discovery Base 2.0.8 and Discovery Support 1.0.4

[Carsten Ziegeler]

Hi,

We solved 1 issues in discovery base and 1 in discovery support (same
problem):

https://issues.apache.org/jira/browse/SLING-7459
https://issues.apache.org/jira/browse/SLING-7461

(This is take 2, I dropped the release for versions 2.0.6 and 1.0.2 and
started this new vote with new versions)

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1872

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1872 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Commented] (SLING-7459) Official endpoints property from Http Whiteboard should be used

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350508#comment-16350508
 ] 

Carsten Ziegeler commented on SLING-7459:
-

Corrected typo in rev cdabe0f

> Official endpoints property from Http Whiteboard should be used
> ---
>
> Key: SLING-7459
> URL: https://issues.apache.org/jira/browse/SLING-7459
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Discovery Base 2.0.4
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Discovery Base 2.0.6
>
>
> Currently the implementation uses the interims property 
> "osgi.http.service.endpoints" from the RFC. The final http whiteboard spec 
> however changed that name to "osgi.http.endpoint".
> Therefore we should use the official name (and revert back to the interims 
> one if not found)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7468) Allow to configure the Distribution Resource Provider

[Timothee Maret (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-7468:
--
Summary: Allow to configure the Distribution Resource Provider  (was: Allow 
to configure the Distribution Resource Resolver)

> Allow to configure the Distribution Resource Provider
> -
>
> Key: SLING-7468
> URL: https://issues.apache.org/jira/browse/SLING-7468
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
>
> SCD maintain its own Resource Provider
> https://github.com/apache/sling-org-apache-sling-distribution-core/tree/master/src/main/java/org/apache/sling/distribution/resources
> The implementation maps OSGI configurations and services as sling resources.
> The implementation is not flexible to allow plugging a custom agent in the 
> resource tree.
> The mapping seems to be done currently in enums, for instance
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/component/impl/DistributionComponentKind.java
> This issue is about making the configuration flexible (OSGI properties) or 
> even configuration-less (figure out the mappings at runtime). As a side 
> effect, the implementation may be simplified. 
> [~teofili],[~simone.tripodi] FYI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7468) Allow to configure the Distribution Resource Resolver

[Simone Tripodi (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350516#comment-16350516
 ] 

Simone Tripodi commented on SLING-7468:
---

I completely agree that a discussion about how to re-design and simplify all 
that part is needed, thanks [~marett] for leading that!

> Allow to configure the Distribution Resource Resolver
> -
>
> Key: SLING-7468
> URL: https://issues.apache.org/jira/browse/SLING-7468
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
>
> SCD maintain its own Resource Provider
> https://github.com/apache/sling-org-apache-sling-distribution-core/tree/master/src/main/java/org/apache/sling/distribution/resources
> The implementation maps OSGI configurations and services as sling resources.
> The implementation is not flexible to allow plugging a custom agent in the 
> resource tree.
> The mapping seems to be done currently in enums, for instance
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/component/impl/DistributionComponentKind.java
> This issue is about making the configuration flexible (OSGI properties) or 
> even configuration-less (figure out the mappings at runtime). As a side 
> effect, the implementation may be simplified. 
> [~teofili],[~simone.tripodi] FYI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7468) Allow to configure the Distribution Resource Resolver

[Timothee Maret (JIRA)]

Timothee Maret created SLING-7468:
-

 Summary: Allow to configure the Distribution Resource Resolver
 Key: SLING-7468
 URL: https://issues.apache.org/jira/browse/SLING-7468
 Project: Sling
  Issue Type: Improvement
  Components: Content Distribution
Reporter: Timothee Maret
Assignee: Timothee Maret


SCD maintain its own Resource Provider

https://github.com/apache/sling-org-apache-sling-distribution-core/tree/master/src/main/java/org/apache/sling/distribution/resources

The implementation maps OSGI configurations and services as sling resources.
The implementation is not flexible to allow plugging a custom agent in the 
resource tree.

The mapping seems to be done currently in enums, for instance

https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/component/impl/DistributionComponentKind.java

This issue is about making the configuration flexible (OSGI properties) or even 
configuration-less (figure out the mappings at runtime). As a side effect, the 
implementation may be simplified. 


[~teofili],[~simone.tripodi] FYI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7461) Official endpoints property from Http Whiteboard should be used

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350510#comment-16350510
 ] 

Carsten Ziegeler commented on SLING-7461:
-

Fixed typo in rev 0d7d4fa

> Official endpoints property from Http Whiteboard should be used
> ---
>
> Key: SLING-7461
> URL: https://issues.apache.org/jira/browse/SLING-7461
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Discovery Support 1.0.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Discovery Support 1.0.2
>
>
> Currently the implementation uses the interims property 
> "osgi.http.service.endpoints" from the RFC. The final http whiteboard spec 
> however changed that name to "osgi.http.endpoint".
> Therefore we should use the official name (and revert back to the interims 
> one if not found)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7461) Official endpoints property from Http Whiteboard should be used

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-7461:

Description: 
Currently the implementation uses the interims property 
"osgi.http.service.endpoints" from the RFC. The final http whiteboard spec 
however changed that name to "osgi.http.endpoint".

Therefore we should use the official name (and revert back to the interims one 
if not found)

  was:
Currently the implementation uses the interims property 
"osgi.http.service.endpoints" from the RFC. The final http whiteboard spec 
however changed that name to "osgi.http.endpoints".

Therefore we should use the official name (and revert back to the interims one 
if not found)


> Official endpoints property from Http Whiteboard should be used
> ---
>
> Key: SLING-7461
> URL: https://issues.apache.org/jira/browse/SLING-7461
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Discovery Support 1.0.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Discovery Support 1.0.2
>
>
> Currently the implementation uses the interims property 
> "osgi.http.service.endpoints" from the RFC. The final http whiteboard spec 
> however changed that name to "osgi.http.endpoint".
> Therefore we should use the official name (and revert back to the interims 
> one if not found)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7459) Official endpoints property from Http Whiteboard should be used

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-7459:

Description: 
Currently the implementation uses the interims property 
"osgi.http.service.endpoints" from the RFC. The final http whiteboard spec 
however changed that name to "osgi.http.endpoint".

Therefore we should use the official name (and revert back to the interims one 
if not found)

  was:
Currently the implementation uses the interims property 
"osgi.http.service.endpoints" from the RFC. The final http whiteboard spec 
however changed that name to "osgi.http.endpoints".

Therefore we should use the official name (and revert back to the interims one 
if not found)


> Official endpoints property from Http Whiteboard should be used
> ---
>
> Key: SLING-7459
> URL: https://issues.apache.org/jira/browse/SLING-7459
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Discovery Base 2.0.4
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Discovery Base 2.0.6
>
>
> Currently the implementation uses the interims property 
> "osgi.http.service.endpoints" from the RFC. The final http whiteboard spec 
> however changed that name to "osgi.http.endpoint".
> Therefore we should use the official name (and revert back to the interims 
> one if not found)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[VOTE CANCELLED] Release Apache Sling Discovery Support 1.0.2

[Carsten Ziegeler]

 I hereby cancel the vote.
Thanks Oliver for catching this!
Regards
Carsten


Oliver Lietz wrote
> On Thursday 01 February 2018 10:31:41 Carsten Ziegeler wrote:
>> Hi,
>>
>> We solved 1 issues in this release:
>>
>> https://issues.apache.org/jira/browse/SLING-7461
> 
> -1 – spec says osgi.http.endpoint (singular)
> 
> O.
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[VOTE CANCELLED] Release Apache Sling Discovery Base 2.0.6

[Carsten Ziegeler]

 I hereby cancel the vote.

Thanks Oliver for catching this!

Regards

Carsten


Oliver Lietz wrote
> On Thursday 01 February 2018 09:14:25 Carsten Ziegeler wrote:
>> Hi,
>>
>> We solved 1 issues in this release:
>>
>> https://issues.apache.org/jira/browse/SLING-7459
> 
> -1 – spec says osgi.http.endpoint (singular)
> 
> O.
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Commented] (SLING-7168) Allow to implement custom distribution agents/queues

[Simone Tripodi (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350448#comment-16350448
 ] 

Simone Tripodi commented on SLING-7168:
---

I got it, [~marett], thanks for explaining the reasons behind your choices!

I am +1, [~teofili] what do you think about it?

> Allow to implement custom distribution agents/queues
> 
>
> Key: SLING-7168
> URL: https://issues.apache.org/jira/browse/SLING-7168
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.8
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.2.12, Content Distribution 
> API 0.4.0
>
>
> Currently, it is not possible to implements distribution agents and queues, 
> implemented in another bundle than the {{org.apache.sling.distribution.core}} 
> bundle.
> Implementing a custom distribution agent outside of the 
> {{org.apache.sling.distribution.core}} bundle is useful when leveraging an 
> ad-hoc communication layer.
> This issue is about allowing to plug an external distribution agent/queue 
> provided via a separate bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7168) Allow to implement custom distribution agents/queues

[Timothee Maret (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350443#comment-16350443
 ] 

Timothee Maret commented on SLING-7168:
---

Thanks [~simone.tripodi] for your review!

I agree with you, we could move APIs in the api bundle!
However, IMO, avoiding to do so would give us some advantages when 
maintaining/evolving the "useable API" (currently in the api bundle) and the 
"technical API" (currently in the core bundle).

1. Leaving the technical APIs aside allows to provide an entirely different 
implementation of the useable API
2. It is easy, using the api controller, to restrict access to a customer to 
the technical APIs yet keep the useable API accessible. An API not accessible 
to customers, is easier to evolve.

As we are already exporting technical API from the core bundle, we would not 
turn the existing design upside down.

> Allow to implement custom distribution agents/queues
> 
>
> Key: SLING-7168
> URL: https://issues.apache.org/jira/browse/SLING-7168
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.8
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.2.12, Content Distribution 
> API 0.4.0
>
>
> Currently, it is not possible to implements distribution agents and queues, 
> implemented in another bundle than the {{org.apache.sling.distribution.core}} 
> bundle.
> Implementing a custom distribution agent outside of the 
> {{org.apache.sling.distribution.core}} bundle is useful when leveraging an 
> ad-hoc communication layer.
> This issue is about allowing to plug an external distribution agent/queue 
> provided via a separate bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling Discovery Support 1.0.2

[Oliver Lietz]

On Thursday 01 February 2018 10:31:41 Carsten Ziegeler wrote:
> Hi,
> 
> We solved 1 issues in this release:
> 
> https://issues.apache.org/jira/browse/SLING-7461

-1 – spec says osgi.http.endpoint (singular)

O.

Re: [VOTE] Release Apache Sling Discovery Base 2.0.6

[Oliver Lietz]

On Thursday 01 February 2018 09:14:25 Carsten Ziegeler wrote:
> Hi,
> 
> We solved 1 issues in this release:
> 
> https://issues.apache.org/jira/browse/SLING-7459

-1 – spec says osgi.http.endpoint (singular)

O.

[jira] [Updated] (SLING-7467) JcrInstaller fails to startup if wrong sling:OsgiConfig is present

[Lukas Kummer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lukas Kummer updated SLING-7467:

Description: 
After deploying a wrong osgi config, JcrInstaller won't get active again, if 
launchpad is restarted.

Reproduction steps:
 * start launchpad
{code:java}
java -jar org.apache.sling.launchpad-9.jar
{code}

 * create info logger for class 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller with Info Level
 * create wrong OSGi 
org.apache.felix.webconsole.plugins.event.internal.PluginServlet.config file
{code:java}
max.size=I"sfdg"
service.pid="org.apache.felix.webconsole.plugins.event.internal.PluginServlet"
{code}

 * deploy the previous created OSGi config file
{code:java}
curl -v -F 
'org.apache.felix.webconsole.plugins.event.internal.PluginServlet.config=@org.apache.felix.webconsole.plugins.event.internal.PluginServlet.config'
 \
-F "jcr:primaryType=sling:OsgiConfig" \
http://admin:admin@localhost:8080/apps/jcrtest/install
{code}

 * JcrInstaller creates log entry:
{code:java}
02.02.2018 15:17:31.872 *WARN* [JcrInstaller.2] 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller Exception in 
runOneCycle()
java.lang.NumberFormatException: For input string: "sfdg"
at 
java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
at java.lang.Integer.parseInt(Integer.java:580)
at java.lang.Integer.valueOf(Integer.java:766)
at 
org.apache.felix.cm.file.ConfigurationHandler.readSimple(ConfigurationHandler.java:457)
at 
org.apache.felix.cm.file.ConfigurationHandler.readValue(ConfigurationHandler.java:352)
at 
org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:306)
at 
org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:265)
at 
org.apache.sling.installer.core.impl.InternalResource.readDictionary(InternalResource.java:257)
at 
org.apache.sling.installer.core.impl.InternalResource.create(InternalResource.java:98)
at 
org.apache.sling.installer.core.impl.OsgiInstallerImpl.createResources(OsgiInstallerImpl.java:373)
at 
org.apache.sling.installer.core.impl.OsgiInstallerImpl.updateResources(OsgiInstallerImpl.java:413)
at 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller.runOneCycle(JcrInstaller.java:549)
at 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.run(JcrInstaller.java:322)
{code}

 * now stop launchpad instance
 * start again and check the previously created logger for JcrInstaller
 * throws following exception:
{code:java}
02.02.2018 15:35:01.210 *INFO* [pool-9-thread-1] 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller Activating Apache 
Sling JCR Installer
02.02.2018 15:35:01.211 *ERROR* [pool-9-thread-1] 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller Repository exception 
during startup - deactivating installer!
javax.jcr.LoginException: Cannot derive user name for bundle 
org.apache.sling.installer.provider.jcr [123] and sub service null
at 
org.apache.sling.jcr.base.AbstractSlingRepository2.loginService(AbstractSlingRepository2.java:311)
at 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.(JcrInstaller.java:217)
at 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller.start(JcrInstaller.java:355)
at 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller.activate(JcrInstaller.java:342)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.apache.felix.scr.impl.inject.BaseMethod.invokeMethod(BaseMethod.java:224)
at 
org.apache.felix.scr.impl.inject.BaseMethod.access$500(BaseMethod.java:39)
at 
org.apache.felix.scr.impl.inject.BaseMethod$Resolved.invoke(BaseMethod.java:617)
at 
org.apache.felix.scr.impl.inject.BaseMethod.invoke(BaseMethod.java:501)
at 
org.apache.felix.scr.impl.inject.ActivateMethod.invoke(ActivateMethod.java:302)
at 
org.apache.felix.scr.impl.inject.ActivateMethod.invoke(ActivateMethod.java:294)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:298)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:109)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:906)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:879)
at 

[jira] [Created] (SLING-7467) JcrInstaller fails to startup if wrong sling:OsgiConfig is present

[Lukas Kummer (JIRA)]

Lukas Kummer created SLING-7467:
---

 Summary: JcrInstaller fails to startup if wrong sling:OsgiConfig 
is present
 Key: SLING-7467
 URL: https://issues.apache.org/jira/browse/SLING-7467
 Project: Sling
  Issue Type: Bug
  Components: Installer
 Environment: osx
Reporter: Lukas Kummer
 Attachments: 
org.apache.felix.webconsole.plugins.event.internal.PluginServlet.config

After deploying a wrong osgi config, JcrInstaller won't get active again, if 
launchpad is restarted.

Reproduction steps:
 * start launchpad
{code:java}
java -jar org.apache.sling.launchpad-9.jar
{code}

 * create info logger for class 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller with Info Level
 * create wrong OSGi 
org.apache.felix.webconsole.plugins.event.internal.PluginServlet.config file
{code:java}
max.size=I"sfdg"
service.pid="org.apache.felix.webconsole.plugins.event.internal.PluginServlet"
{code}

 * deploy the previous created OSGi config file
{code:java}
curl -v -F 
'org.apache.felix.webconsole.plugins.event.internal.PluginServlet.config=@org.apache.felix.webconsole.plugins.event.internal.PluginServlet.config'
 \
-F "jcr:primaryType=sling:OsgiConfig" \
http://admin:admin@localhost:8080/apps/jcrtest/install
{code}

 * JcrInstaller creates log entry:
{code:java}
02.02.2018 15:17:31.872 *WARN* [JcrInstaller.2] 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller Exception in 
runOneCycle()
java.lang.NumberFormatException: For input string: "sfdg"
at 
java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
at java.lang.Integer.parseInt(Integer.java:580)
at java.lang.Integer.valueOf(Integer.java:766)
at 
org.apache.felix.cm.file.ConfigurationHandler.readSimple(ConfigurationHandler.java:457)
at 
org.apache.felix.cm.file.ConfigurationHandler.readValue(ConfigurationHandler.java:352)
at 
org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:306)
at 
org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:265)
at 
org.apache.sling.installer.core.impl.InternalResource.readDictionary(InternalResource.java:257)
at 
org.apache.sling.installer.core.impl.InternalResource.create(InternalResource.java:98)
at 
org.apache.sling.installer.core.impl.OsgiInstallerImpl.createResources(OsgiInstallerImpl.java:373)
at 
org.apache.sling.installer.core.impl.OsgiInstallerImpl.updateResources(OsgiInstallerImpl.java:413)
at 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller.runOneCycle(JcrInstaller.java:549)
at 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.run(JcrInstaller.java:322)
{code}

 * now stop launchpad instance
 * start again and check the previously created logger for JcrInstaller
 * throws following exception:
{code:java}
02.02.2018 15:35:01.210 *INFO* [pool-9-thread-1] 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller Activating Apache 
Sling JCR Installer
02.02.2018 15:35:01.211 *ERROR* [pool-9-thread-1] 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller Repository exception 
during startup - deactivating installer!
javax.jcr.LoginException: Cannot derive user name for bundle 
org.apache.sling.installer.provider.jcr [123] and sub service null
at 
org.apache.sling.jcr.base.AbstractSlingRepository2.loginService(AbstractSlingRepository2.java:311)
at 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.(JcrInstaller.java:217)
at 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller.start(JcrInstaller.java:355)
at 
org.apache.sling.installer.provider.jcr.impl.JcrInstaller.activate(JcrInstaller.java:342)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.apache.felix.scr.impl.inject.BaseMethod.invokeMethod(BaseMethod.java:224)
at 
org.apache.felix.scr.impl.inject.BaseMethod.access$500(BaseMethod.java:39)
at 
org.apache.felix.scr.impl.inject.BaseMethod$Resolved.invoke(BaseMethod.java:617)
at 
org.apache.felix.scr.impl.inject.BaseMethod.invoke(BaseMethod.java:501)
at 
org.apache.felix.scr.impl.inject.ActivateMethod.invoke(ActivateMethod.java:302)
at 
org.apache.felix.scr.impl.inject.ActivateMethod.invoke(ActivateMethod.java:294)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:298)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:109)
at 

[jira] [Commented] (SLING-7168) Allow to implement custom distribution agents/queues

[Simone Tripodi (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350399#comment-16350399
 ] 

Simone Tripodi commented on SLING-7168:
---

The patch looks great and I even think that moving interfaces to the API bundle 
shouldn't be harmful for backward compatibility... WDYT?

It would be just a matter of not mixing up stuff , would it make sense?

Anyway, I am +1 for checking-in the modifications on the repo, thanks a lot for 
your work [~marett]! :)

> Allow to implement custom distribution agents/queues
> 
>
> Key: SLING-7168
> URL: https://issues.apache.org/jira/browse/SLING-7168
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.8
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.2.12, Content Distribution 
> API 0.4.0
>
>
> Currently, it is not possible to implements distribution agents and queues, 
> implemented in another bundle than the {{org.apache.sling.distribution.core}} 
> bundle.
> Implementing a custom distribution agent outside of the 
> {{org.apache.sling.distribution.core}} bundle is useful when leveraging an 
> ad-hoc communication layer.
> This issue is about allowing to plug an external distribution agent/queue 
> provided via a separate bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SLING-7168) Allow to implement custom distribution agents/queues

[Simone Tripodi (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350399#comment-16350399
 ] 

Simone Tripodi edited comment on SLING-7168 at 2/2/18 2:30 PM:
---

The patch looks great and I even think that moving interfaces to the API bundle 
shouldn't be harmful for backward compatibility... WDYT?

It would be just a matter of not mixing up stuff , would it make sense?

Anyway, I am +1 for checking the modifications in the repo, thanks a lot for 
your work [~marett]! :)


was (Author: simone.tripodi):
The patch looks great and I even think that moving interfaces to the API bundle 
shouldn't be harmful for backward compatibility... WDYT?

It would be just a matter of not mixing up stuff , would it make sense?

Anyway, I am +1 for checking-in the modifications on the repo, thanks a lot for 
your work [~marett]! :)

> Allow to implement custom distribution agents/queues
> 
>
> Key: SLING-7168
> URL: https://issues.apache.org/jira/browse/SLING-7168
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.8
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.2.12, Content Distribution 
> API 0.4.0
>
>
> Currently, it is not possible to implements distribution agents and queues, 
> implemented in another bundle than the {{org.apache.sling.distribution.core}} 
> bundle.
> Implementing a custom distribution agent outside of the 
> {{org.apache.sling.distribution.core}} bundle is useful when leveraging an 
> ad-hoc communication layer.
> This issue is about allowing to plug an external distribution agent/queue 
> provided via a separate bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-7184) SlingOptions.slingScriptingSightly fails to

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-7184.
---

> SlingOptions.slingScriptingSightly fails to 
> 
>
> Key: SLING-7184
> URL: https://issues.apache.org/jira/browse/SLING-7184
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: Testing PaxExam 0.0.4
>Reporter: Nicolas Peltier
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 1.0.0
>
>
> trying to use SlingOptions.slingScriptingSightly  in pipes IT i get the 
> following error:
> {Code}
> org.osgi.framework.BundleException: Unable to resolve 
> org.apache.sling.scripting.sightly.js.provider [208](R 208.0): missing 
> requirement [org.apache.sling.scripting.sightly.js.provider [208](R 208.0)] 
> io.sightly; (&(version>=1.0)(!(version>=2.0))) [caused by: Unable to resolve 
> org.apache.sling.scripting.sightly [205](R 205.0): missing requirement 
> [org.apache.sling.scripting.sightly [205](R 205.0)] osgi.wiring.package; 
> (&(osgi.wiring.package=org.apache.sling.xss)(version>=1.0.0)(!(version>=2.0.0)))
>  [caused by: Unable to resolve org.apache.sling.xss [201](R 201.0): missing 
> requirement [org.apache.sling.xss [201](R 201.0)] osgi.wiring.package; 
> (osgi.wiring.package=javax.mail.internet)]] Unresolved requirements: 
> [[org.apache.sling.scripting.sightly.js.provider [208](R 208.0)] io.sightly; 
> (&(version>=1.0)(!(version>=2.0)))]
> {Code}
> "fixing" this with 
> {Code}
> SlingOptions.versionResolver.setVersion("org.apache.sling", 
> "org.apache.sling.xss", "1.0.18");
> ...
> 
> mavenBundle().groupId("javax.mail").artifactId("mail").version("1.5.0-b01"),
> {Code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-7395) Use bnd Maven plugins

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-7395.
---

> Use bnd Maven plugins
> -
>
> Key: SLING-7395
> URL: https://issues.apache.org/jira/browse/SLING-7395
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-7373) Use Handlebars for templating

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-7373.
---

> Use Handlebars for templating
> -
>
> Key: SLING-7373
> URL: https://issues.apache.org/jira/browse/SLING-7373
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Minor
> Fix For: Testing PaxExam 1.0.0
>
>
> Handlebars is OSGi-friendly and does the job in this case as well (the JavaFX 
> application using this templates is running on OSGi).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-7325) Add tests for generated options

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-7325.
---

> Add tests for generated options
> ---
>
> Key: SLING-7325
> URL: https://issues.apache.org/jira/browse/SLING-7325
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-7340) Provide Tinybundles Option

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-7340.
---

> Provide Tinybundles Option
> --
>
> Key: SLING-7340
> URL: https://issues.apache.org/jira/browse/SLING-7340
> Project: Sling
>  Issue Type: New Feature
>  Components: Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-7341) Provide BND bundle builder in TestSupport

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-7341.
---

> Provide BND bundle builder in TestSupport
> -
>
> Key: SLING-7341
> URL: https://issues.apache.org/jira/browse/SLING-7341
> Project: Sling
>  Issue Type: New Feature
>  Components: Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-7003) Update Pax Exam to 4.11

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-7003.
---

> Update Pax Exam to 4.11
> ---
>
> Key: SLING-7003
> URL: https://issues.apache.org/jira/browse/SLING-7003
> Project: Sling
>  Issue Type: Task
>  Components: Karaf, Scripting, Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting FreeMarker 1.0.0, Karaf Integration Tests 
> 0.2.0, Scripting Thymeleaf 1.1.2, Testing PaxExam 1.0.0, Karaf Launchpad 
> Integration Tests (Oak Tar) 0.0.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-6665) Provide a logging Option for Pax Exam

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-6665.
---

> Provide a logging Option for Pax Exam
> -
>
> Key: SLING-6665
> URL: https://issues.apache.org/jira/browse/SLING-6665
> Project: Sling
>  Issue Type: New Feature
>  Components: Testing
>Affects Versions: Testing PaxExam 0.0.4
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 1.0.0
>
>
> From {{ThymeleafTestSupport}}:
> {noformat}
> protected Option logging() {
> final String filename = 
> String.format("file:%s/src/test/resources/logback.xml", 
> PathUtils.getBaseDir());
> return composite(
> systemProperty("logback.configurationFile").value(filename),
> 
> mavenBundle().groupId("org.slf4j").artifactId("slf4j-api").version("1.7.21"),
> 
> mavenBundle().groupId("org.slf4j").artifactId("jcl-over-slf4j").version("1.7.21"),
> 
> mavenBundle().groupId("ch.qos.logback").artifactId("logback-core").version("1.1.7"),
> 
> mavenBundle().groupId("ch.qos.logback").artifactId("logback-classic").version("1.1.7")
> );
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-7080) Update options and versions to latest features

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-7080.
---

> Update options and versions to latest features
> --
>
> Key: SLING-7080
> URL: https://issues.apache.org/jira/browse/SLING-7080
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-6664) Move JSP and EL API to Option slingScriptingJsp

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-6664.
---

> Move JSP and EL API to Option slingScriptingJsp
> ---
>
> Key: SLING-6664
> URL: https://issues.apache.org/jira/browse/SLING-6664
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing PaxExam 0.0.4
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 1.0.0
>
>
> Moving JSP and EL API keeps Option {{http}} lean (but requires manual 
> adjustment of {{slingScriptingJsp}} when generating from Karaf features).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7466) EntityResourceList cleaning up resource instead of updating

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350327#comment-16350327
 ] 

Carsten Ziegeler commented on SLING-7466:
-

Adjusted the patch and cleary document what it handles and what not - while the 
patch does not handle all cases it's at least better than before

rev 0897a1d

> EntityResourceList cleaning up resource instead of updating
> ---
>
> Key: SLING-7466
> URL: https://issues.apache.org/jira/browse/SLING-7466
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.8.10
>Reporter: Dominik Süß
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.8.12
>
>
> In case of a replaced launchpad containing an unchanged resource the 
> EntityResourceList is called for "addOrUpdate" of this Resource - in case the 
> resource already exists but the digest differs the method currently drops the 
> new resource without updating the existing one keeping the old dataUri.
> The issue manifests if these RegisteredResources are currently in INSTALL 
> state and the INSTALLED version gets dropped subsequently.
> This isn't just a theoretical case but was observed for cases where a bundle 
> in an n-1 version was patched to the same version provided in version n of 
> launchpad and launchpad hasn't changed for n+1. If the jcr version is then 
> removed the installation of the outdated registeredResource fails because of 
> a wrong dataUri.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[RESULT] [VOTE] Release Apache Sling Testing PaxExam 1.0.0

[Oliver Lietz]

Hi,

the vote has passed with the following result:

+1 (binding): Robert Munteanu, Daniel Klco, Oliver Lietz

+1 (non-binding): Nicolas Peltier

I will copy this release to the Sling dist directory and promote the artifacts 
to the central Maven repository.

Thanks for voting!

O.

[jira] [Updated] (SLING-7168) Allow to implement custom distribution agents/queues

[Timothee Maret (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-7168:
--
Description: 
Currently, it is not possible to implements distribution agents and queues, 
implemented in another bundle than the {{org.apache.sling.distribution.core}} 
bundle.

Implementing a custom distribution agent outside of the 
{{org.apache.sling.distribution.core}} bundle is useful when leveraging an 
ad-hoc communication layer.

This issue is about allowing to plug an external distribution agent/queue 
provided via a separate bundle.

  was:
Currently, it is not possible to implements distribution agents and queues, 
implemented in another bundle than the {{org.apache.sling.distribution.core}} 
bundle.

This issue is about allowing to plug an external distribution agent/queue 
provided via a separate bundle.


> Allow to implement custom distribution agents/queues
> 
>
> Key: SLING-7168
> URL: https://issues.apache.org/jira/browse/SLING-7168
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.8
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.2.12, Content Distribution 
> API 0.4.0
>
>
> Currently, it is not possible to implements distribution agents and queues, 
> implemented in another bundle than the {{org.apache.sling.distribution.core}} 
> bundle.
> Implementing a custom distribution agent outside of the 
> {{org.apache.sling.distribution.core}} bundle is useful when leveraging an 
> ad-hoc communication layer.
> This issue is about allowing to plug an external distribution agent/queue 
> provided via a separate bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7168) Allow to implement custom distribution agents/queues

[Timothee Maret (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-7168:
--
Flags: Patch

> Allow to implement custom distribution agents/queues
> 
>
> Key: SLING-7168
> URL: https://issues.apache.org/jira/browse/SLING-7168
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.8
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.2.12, Content Distribution 
> API 0.4.0
>
>
> Currently, it is not possible to implements distribution agents and queues, 
> implemented in another bundle than the {{org.apache.sling.distribution.core}} 
> bundle.
> This issue is about allowing to plug an external distribution agent/queue 
> provided via a separate bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7466) EntityResourceList cleaning up resource instead of updating

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350291#comment-16350291
 ] 

ASF GitHub Bot commented on SLING-7466:
---

cziegeler closed pull request #1: SLING-7466 - adding update of existing 
resource to make sure datauri …
URL: https://github.com/apache/sling-org-apache-sling-installer-core/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/src/main/java/org/apache/sling/installer/core/impl/EntityResourceList.java 
b/src/main/java/org/apache/sling/installer/core/impl/EntityResourceList.java
index c61af04..e143af6 100644
--- a/src/main/java/org/apache/sling/installer/core/impl/EntityResourceList.java
+++ b/src/main/java/org/apache/sling/installer/core/impl/EntityResourceList.java
@@ -373,7 +373,20 @@ public void addOrUpdate(final RegisteredResourceImpl r) {
 if ( rr.getURL().equals(r.getURL()) ) {
 if ( 
RegisteredResourceImpl.isSameResource((RegisteredResourceImpl)rr, r) ) {
 if ( !rr.getDigest().equals(r.getDigest()) ) {
-// same resource but different digest, we need to 
remove the file
+// same resource but different digest, we need to 
to update the file
+LOGGER.debug("Updating resource with due to 
different digest: {}", r);
+try {
+   
InternalResource intRes = InternalResource.create(r.getScheme(), 
+   
new InstallableResource(r.getEntityId(), 
+   
r.getInputStream(), 
+   
r.getDictionary(),
+   
r.getDigest(), 
+   
r.getType(), 
+   
r.getPriority()));
+   
((RegisteredResourceImpl)rr).update(intRes);
+} catch (IOException e) {
+   
LOGGER.error("Failed to update resource with different digest: {}", r);
+   }
 LOGGER.debug("Cleanup duplicate resource: {}", r);
 this.cleanup(r);
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> EntityResourceList cleaning up resource instead of updating
> ---
>
> Key: SLING-7466
> URL: https://issues.apache.org/jira/browse/SLING-7466
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.8.10
>Reporter: Dominik Süß
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.8.12
>
>
> In case of a replaced launchpad containing an unchanged resource the 
> EntityResourceList is called for "addOrUpdate" of this Resource - in case the 
> resource already exists but the digest differs the method currently drops the 
> new resource without updating the existing one keeping the old dataUri.
> The issue manifests if these RegisteredResources are currently in INSTALL 
> state and the INSTALLED version gets dropped subsequently.
> This isn't just a theoretical case but was observed for cases where a bundle 
> in an n-1 version was patched to the same version provided in version n of 
> launchpad and launchpad hasn't changed for n+1. If the jcr version is then 
> removed the installation of the outdated registeredResource fails because of 
> a wrong dataUri.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7466) EntityResourceList cleaning up resource instead of updating

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350290#comment-16350290
 ] 

ASF GitHub Bot commented on SLING-7466:
---

cziegeler commented on issue #1: SLING-7466 - adding update of existing 
resource to make sure datauri …
URL: 
https://github.com/apache/sling-org-apache-sling-installer-core/pull/1#issuecomment-362581545
 
 
   Thanks for the patch. The patch only handels the use case where the artifact 
is not copied into the local cache. I'll apply it anyway and work from there


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> EntityResourceList cleaning up resource instead of updating
> ---
>
> Key: SLING-7466
> URL: https://issues.apache.org/jira/browse/SLING-7466
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.8.10
>Reporter: Dominik Süß
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.8.12
>
>
> In case of a replaced launchpad containing an unchanged resource the 
> EntityResourceList is called for "addOrUpdate" of this Resource - in case the 
> resource already exists but the digest differs the method currently drops the 
> new resource without updating the existing one keeping the old dataUri.
> The issue manifests if these RegisteredResources are currently in INSTALL 
> state and the INSTALLED version gets dropped subsequently.
> This isn't just a theoretical case but was observed for cases where a bundle 
> in an n-1 version was patched to the same version provided in version n of 
> launchpad and launchpad hasn't changed for n+1. If the jcr version is then 
> removed the installation of the outdated registeredResource fails because of 
> a wrong dataUri.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] cziegeler closed pull request #1: SLING-7466 - adding update of existing resource to make sure datauri ?

[GitBox]

cziegeler closed pull request #1: SLING-7466 - adding update of existing 
resource to make sure datauri ?
URL: https://github.com/apache/sling-org-apache-sling-installer-core/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/src/main/java/org/apache/sling/installer/core/impl/EntityResourceList.java 
b/src/main/java/org/apache/sling/installer/core/impl/EntityResourceList.java
index c61af04..e143af6 100644
--- a/src/main/java/org/apache/sling/installer/core/impl/EntityResourceList.java
+++ b/src/main/java/org/apache/sling/installer/core/impl/EntityResourceList.java
@@ -373,7 +373,20 @@ public void addOrUpdate(final RegisteredResourceImpl r) {
 if ( rr.getURL().equals(r.getURL()) ) {
 if ( 
RegisteredResourceImpl.isSameResource((RegisteredResourceImpl)rr, r) ) {
 if ( !rr.getDigest().equals(r.getDigest()) ) {
-// same resource but different digest, we need to 
remove the file
+// same resource but different digest, we need to 
to update the file
+LOGGER.debug("Updating resource with due to 
different digest: {}", r);
+try {
+   
InternalResource intRes = InternalResource.create(r.getScheme(), 
+   
new InstallableResource(r.getEntityId(), 
+   
r.getInputStream(), 
+   
r.getDictionary(),
+   
r.getDigest(), 
+   
r.getType(), 
+   
r.getPriority()));
+   
((RegisteredResourceImpl)rr).update(intRes);
+} catch (IOException e) {
+   
LOGGER.error("Failed to update resource with different digest: {}", r);
+   }
 LOGGER.debug("Cleanup duplicate resource: {}", r);
 this.cleanup(r);
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cziegeler commented on issue #1: SLING-7466 - adding update of existing resource to make sure datauri ?

[GitBox]

cziegeler commented on issue #1: SLING-7466 - adding update of existing 
resource to make sure datauri ?
URL: 
https://github.com/apache/sling-org-apache-sling-installer-core/pull/1#issuecomment-362581545
 
 
   Thanks for the patch. The patch only handels the use case where the artifact 
is not copied into the local cache. I'll apply it anyway and work from there


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Assigned] (SLING-7466) EntityResourceList cleaning up resource instead of updating

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-7466:
---

Assignee: Carsten Ziegeler

> EntityResourceList cleaning up resource instead of updating
> ---
>
> Key: SLING-7466
> URL: https://issues.apache.org/jira/browse/SLING-7466
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.8.10
>Reporter: Dominik Süß
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.8.12
>
>
> In case of a replaced launchpad containing an unchanged resource the 
> EntityResourceList is called for "addOrUpdate" of this Resource - in case the 
> resource already exists but the digest differs the method currently drops the 
> new resource without updating the existing one keeping the old dataUri.
> The issue manifests if these RegisteredResources are currently in INSTALL 
> state and the INSTALLED version gets dropped subsequently.
> This isn't just a theoretical case but was observed for cases where a bundle 
> in an n-1 version was patched to the same version provided in version n of 
> launchpad and launchpad hasn't changed for n+1. If the jcr version is then 
> removed the installation of the outdated registeredResource fails because of 
> a wrong dataUri.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7457) Poor documentation on mongoDB or other NOSQL use

[frederic rougeot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350107#comment-16350107
 ] 

frederic rougeot commented on SLING-7457:
-

Sure I will try again this afternoon (french timezone). What differs from my 
previous attempts is to restart from a fresh downloaded snapshot, not from a 
version build from the source code and previously used. I tell you once done.

 

 

> Poor documentation on mongoDB or other NOSQL use
> 
>
> Key: SLING-7457
> URL: https://issues.apache.org/jira/browse/SLING-7457
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: frederic rougeot
>Priority: Major
>
> I am evaluating sling.
> I succeed in setting it up and it works as I thought, seems to be a very 
> valuable product for those who want to rapidlly build a software that relies 
> on JCR, which is my case.
> But the next question is "Should I use a noSQL Database or not". As it may be 
> an important choice, since Sling is not really compatible with SQL database, 
> I wanted to make sling run with MongoDB.
> I read the documentation, and at first impression, it seemed quite immediate; 
> I simply have to add an option to change the mode of launching the starter 
> application, as it is said in the following documentation: 
> [https://sling.apache.org/documentation/the-sling-engine/the-sling-launchpad.html]
>  
> So I tried to launch the starter application with the following lines:
> java -Dsling.run.modes=oak,oak_mongo -jar 
> org.apache.sling.starter-10-SNAPSHOT.jar
> and checked with a mongodb client if a mongodb server was started or not ...
> As I was unable to connect to mongodb://localhost:27017 I guess something is 
> missing, maybe mongodb should be installed separetely ? 
>  
> I continue reading the documentation, and find 
> [https://sling.apache.org/documentation/bundles/nosql-resource-providers.html]
> OK, my conclusion was I missed to install the nosql-resource-providers, so I 
> installed the bundle and check again ...
> Nothing new, it seems I have done nothing.
> So, always according to 
> [https://sling.apache.org/documentation/bundles/nosql-resource-providers.html,]
>  there is another launchpad to use.
> There is the link to the source code: 
> https://github.com/apache/sling-old-svn-mirror/tree/trunk/contrib/nosql/launchpad
> But it is said that this source repository is obsolete and shall not be used.
> So I get back to apache git repository, and filtered on "sling" and "nosql", 
> I can find some code now ...
> https://github.com/apache?utf8=%E2%9C%93=sling+nosql==
> But it is absolutely not clear to me whether I have to do something with that 
> modules or not ...
> So my real problem is I can't get the right documentation on "How to setup 
> Sling 9 to work with mongodb" and there is, as far as I know, no forum where 
> I can ask this to a community to help.
> I guess sling is working well with mongoDB, but if I need 10 days to set it 
> up (I spend 1 day, maybe it is not enough) my point of view is made: I won't 
> use mongodb.
> But this maybe a terrible mistake !
>  
> So help please !
>  
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7466) EntityResourceList cleaning up resource instead of updating

[JIRA]

[ 
https://issues.apache.org/jira/browse/SLING-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350200#comment-16350200
 ] 

Dominik Süß commented on SLING-7466:


Created PR at 
https://github.com/apache/sling-org-apache-sling-installer-core/pull/1

> EntityResourceList cleaning up resource instead of updating
> ---
>
> Key: SLING-7466
> URL: https://issues.apache.org/jira/browse/SLING-7466
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.8.10
>Reporter: Dominik Süß
>Priority: Major
> Fix For: Installer Core 3.8.12
>
>
> In case of a replaced launchpad containing an unchanged resource the 
> EntityResourceList is called for "addOrUpdate" of this Resource - in case the 
> resource already exists but the digest differs the method currently drops the 
> new resource without updating the existing one keeping the old dataUri.
> The issue manifests if these RegisteredResources are currently in INSTALL 
> state and the INSTALLED version gets dropped subsequently.
> This isn't just a theoretical case but was observed for cases where a bundle 
> in an n-1 version was patched to the same version provided in version n of 
> launchpad and launchpad hasn't changed for n+1. If the jcr version is then 
> removed the installation of the outdated registeredResource fails because of 
> a wrong dataUri.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] DominikSuess opened a new pull request #1: SLING-7466 - adding update of existing resource to make sure datauri ?

[GitBox]

DominikSuess opened a new pull request #1: SLING-7466 - adding update of 
existing resource to make sure datauri ?
URL: https://github.com/apache/sling-org-apache-sling-installer-core/pull/1
 
 
   ?is clean


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-7466) EntityResourceList cleaning up resource instead of updating

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350199#comment-16350199
 ] 

ASF GitHub Bot commented on SLING-7466:
---

DominikSuess opened a new pull request #1: SLING-7466 - adding update of 
existing resource to make sure datauri …
URL: https://github.com/apache/sling-org-apache-sling-installer-core/pull/1
 
 
   …is clean


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> EntityResourceList cleaning up resource instead of updating
> ---
>
> Key: SLING-7466
> URL: https://issues.apache.org/jira/browse/SLING-7466
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.8.10
>Reporter: Dominik Süß
>Priority: Major
> Fix For: Installer Core 3.8.12
>
>
> In case of a replaced launchpad containing an unchanged resource the 
> EntityResourceList is called for "addOrUpdate" of this Resource - in case the 
> resource already exists but the digest differs the method currently drops the 
> new resource without updating the existing one keeping the old dataUri.
> The issue manifests if these RegisteredResources are currently in INSTALL 
> state and the INSTALLED version gets dropped subsequently.
> This isn't just a theoretical case but was observed for cases where a bundle 
> in an n-1 version was patched to the same version provided in version n of 
> launchpad and launchpad hasn't changed for n+1. If the jcr version is then 
> removed the installation of the outdated registeredResource fails because of 
> a wrong dataUri.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7457) Poor documentation on mongoDB or other NOSQL use

[frederic rougeot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350135#comment-16350135
 ] 

frederic rougeot commented on SLING-7457:
-

OK this kind of information is really important, and as previously said if it 
is not clearly explained in the documentation, it is very hard to guess it !

I check now !

 

> Poor documentation on mongoDB or other NOSQL use
> 
>
> Key: SLING-7457
> URL: https://issues.apache.org/jira/browse/SLING-7457
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: frederic rougeot
>Priority: Major
>
> I am evaluating sling.
> I succeed in setting it up and it works as I thought, seems to be a very 
> valuable product for those who want to rapidlly build a software that relies 
> on JCR, which is my case.
> But the next question is "Should I use a noSQL Database or not". As it may be 
> an important choice, since Sling is not really compatible with SQL database, 
> I wanted to make sling run with MongoDB.
> I read the documentation, and at first impression, it seemed quite immediate; 
> I simply have to add an option to change the mode of launching the starter 
> application, as it is said in the following documentation: 
> [https://sling.apache.org/documentation/the-sling-engine/the-sling-launchpad.html]
>  
> So I tried to launch the starter application with the following lines:
> java -Dsling.run.modes=oak,oak_mongo -jar 
> org.apache.sling.starter-10-SNAPSHOT.jar
> and checked with a mongodb client if a mongodb server was started or not ...
> As I was unable to connect to mongodb://localhost:27017 I guess something is 
> missing, maybe mongodb should be installed separetely ? 
>  
> I continue reading the documentation, and find 
> [https://sling.apache.org/documentation/bundles/nosql-resource-providers.html]
> OK, my conclusion was I missed to install the nosql-resource-providers, so I 
> installed the bundle and check again ...
> Nothing new, it seems I have done nothing.
> So, always according to 
> [https://sling.apache.org/documentation/bundles/nosql-resource-providers.html,]
>  there is another launchpad to use.
> There is the link to the source code: 
> https://github.com/apache/sling-old-svn-mirror/tree/trunk/contrib/nosql/launchpad
> But it is said that this source repository is obsolete and shall not be used.
> So I get back to apache git repository, and filtered on "sling" and "nosql", 
> I can find some code now ...
> https://github.com/apache?utf8=%E2%9C%93=sling+nosql==
> But it is absolutely not clear to me whether I have to do something with that 
> modules or not ...
> So my real problem is I can't get the right documentation on "How to setup 
> Sling 9 to work with mongodb" and there is, as far as I know, no forum where 
> I can ask this to a community to help.
> I guess sling is working well with mongoDB, but if I need 10 days to set it 
> up (I spend 1 day, maybe it is not enough) my point of view is made: I won't 
> use mongodb.
> But this maybe a terrible mistake !
>  
> So help please !
>  
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7466) EntityResourceList cleaning up resource instead of updating

[JIRA]

Dominik Süß created SLING-7466:
--

 Summary: EntityResourceList cleaning up resource instead of 
updating
 Key: SLING-7466
 URL: https://issues.apache.org/jira/browse/SLING-7466
 Project: Sling
  Issue Type: Bug
  Components: Installer
Affects Versions: Installer Core 3.8.10
Reporter: Dominik Süß
 Fix For: Installer Core 3.8.12


In case of a replaced launchpad containing an unchanged resource the 
EntityResourceList is called for "addOrUpdate" of this Resource - in case the 
resource already exists but the digest differs the method currently drops the 
new resource without updating the existing one keeping the old dataUri.

The issue manifests if these RegisteredResources are currently in INSTALL state 
and the INSTALLED version gets dropped subsequently.

This isn't just a theoretical case but was observed for cases where a bundle in 
an n-1 version was patched to the same version provided in version n of 
launchpad and launchpad hasn't changed for n+1. If the jcr version is then 
removed the installation of the outdated registeredResource fails because of a 
wrong dataUri.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7457) Poor documentation on mongoDB or other NOSQL use

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350122#comment-16350122
 ] 

Oliver Lietz commented on SLING-7457:
-

[~frougeot], you have to use a "fresh" instance if you switch between Oak 
stores (tar, mongo, ...).

> Poor documentation on mongoDB or other NOSQL use
> 
>
> Key: SLING-7457
> URL: https://issues.apache.org/jira/browse/SLING-7457
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: frederic rougeot
>Priority: Major
>
> I am evaluating sling.
> I succeed in setting it up and it works as I thought, seems to be a very 
> valuable product for those who want to rapidlly build a software that relies 
> on JCR, which is my case.
> But the next question is "Should I use a noSQL Database or not". As it may be 
> an important choice, since Sling is not really compatible with SQL database, 
> I wanted to make sling run with MongoDB.
> I read the documentation, and at first impression, it seemed quite immediate; 
> I simply have to add an option to change the mode of launching the starter 
> application, as it is said in the following documentation: 
> [https://sling.apache.org/documentation/the-sling-engine/the-sling-launchpad.html]
>  
> So I tried to launch the starter application with the following lines:
> java -Dsling.run.modes=oak,oak_mongo -jar 
> org.apache.sling.starter-10-SNAPSHOT.jar
> and checked with a mongodb client if a mongodb server was started or not ...
> As I was unable to connect to mongodb://localhost:27017 I guess something is 
> missing, maybe mongodb should be installed separetely ? 
>  
> I continue reading the documentation, and find 
> [https://sling.apache.org/documentation/bundles/nosql-resource-providers.html]
> OK, my conclusion was I missed to install the nosql-resource-providers, so I 
> installed the bundle and check again ...
> Nothing new, it seems I have done nothing.
> So, always according to 
> [https://sling.apache.org/documentation/bundles/nosql-resource-providers.html,]
>  there is another launchpad to use.
> There is the link to the source code: 
> https://github.com/apache/sling-old-svn-mirror/tree/trunk/contrib/nosql/launchpad
> But it is said that this source repository is obsolete and shall not be used.
> So I get back to apache git repository, and filtered on "sling" and "nosql", 
> I can find some code now ...
> https://github.com/apache?utf8=%E2%9C%93=sling+nosql==
> But it is absolutely not clear to me whether I have to do something with that 
> modules or not ...
> So my real problem is I can't get the right documentation on "How to setup 
> Sling 9 to work with mongodb" and there is, as far as I know, no forum where 
> I can ask this to a community to help.
> I guess sling is working well with mongoDB, but if I need 10 days to set it 
> up (I spend 1 day, maybe it is not enough) my point of view is made: I won't 
> use mongodb.
> But this maybe a terrible mistake !
>  
> So help please !
>  
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7465) Clarify licensing of fonts added to launchpad-content

[Bertrand Delacretaz (JIRA)]

Bertrand Delacretaz created SLING-7465:
--

 Summary: Clarify licensing of fonts added to launchpad-content
 Key: SLING-7465
 URL: https://issues.apache.org/jira/browse/SLING-7465
 Project: Sling
  Issue Type: Task
  Components: Launchpad
Reporter: Bertrand Delacretaz
Assignee: Dan Klco
 Fix For: Launchpad Content 2.0.14


Hi Dan, assigning this to you as it's related to your changes in SLING-7379 
(cool stuff BTW!)

Those changes have added fonts under 
[https://github.com/apache/sling-org-apache-sling-launchpad-content/tree/master/src/main/frontend/src/fonts]

Do you have licensing information for those fonts? Do we need to add a LICENSE 
to that module for them?

If that's needed I think we just need to add a license (and notice if needed) 
under appended-resources like in 
https://github.com/apache/sling-org-apache-sling-commons-log/tree/master/src/main/appended-resources/META-INF



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7457) Poor documentation on mongoDB or other NOSQL use

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350090#comment-16350090
 ] 

Robert Munteanu commented on SLING-7457:


[~frougeot] - I double-checked my steps, here's what I did to ensure this work

* ensures that no other 'sling' database exists in mongodb
* downloaded a sling starter 10-SNAPSHOT from repository.apache.org
* started the app with the proper runmodes
* validated that there are now entries in the sling.nodes collection

*MongoDB*

{noformat}
$ mongo
MongoDB shell version v3.4.10
connecting to: mongodb://127.0.0.1:27017
MongoDB server version: 3.4.10
> show dbs
admin  0.000GB
local  0.000GB
> exit
{noformat}

*Sling Starter*
{noformat}
$ wget 
https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.starter/10-SNAPSHOT/org.apache.sling.starter-10-20180131.135931-131.jar
$ java -jar org.apache.sling.starter-10-20180131.135931-131.jar 
-Dsling.run.modes=oak_mongo
{noformat}

*Verifying*

After a little time, MongoDB connection information should be printed on stdout

{noformat}INFO: Monitor thread successfully connected to server with 
description ServerDescription{address=localhost:27017, type=STANDALONE, 
state=CONNECTED, ok=true, version=ServerVersion{versionList=[3, 4, 10]}, 
minWireVersion=0, maxWireVersion=5, maxDocumentSize=16777216, 
roundTripTimeNanos=460489}{noformat}

Also, data should be in the {{nodes}} collection of the {{sling}} mongo database

{noformat}$ mongo
> use sling
> db.nodes.count();
13454{noformat}

Can you follow these steps and let me know where it stops working for you?

> Poor documentation on mongoDB or other NOSQL use
> 
>
> Key: SLING-7457
> URL: https://issues.apache.org/jira/browse/SLING-7457
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: frederic rougeot
>Priority: Major
>
> I am evaluating sling.
> I succeed in setting it up and it works as I thought, seems to be a very 
> valuable product for those who want to rapidlly build a software that relies 
> on JCR, which is my case.
> But the next question is "Should I use a noSQL Database or not". As it may be 
> an important choice, since Sling is not really compatible with SQL database, 
> I wanted to make sling run with MongoDB.
> I read the documentation, and at first impression, it seemed quite immediate; 
> I simply have to add an option to change the mode of launching the starter 
> application, as it is said in the following documentation: 
> [https://sling.apache.org/documentation/the-sling-engine/the-sling-launchpad.html]
>  
> So I tried to launch the starter application with the following lines:
> java -Dsling.run.modes=oak,oak_mongo -jar 
> org.apache.sling.starter-10-SNAPSHOT.jar
> and checked with a mongodb client if a mongodb server was started or not ...
> As I was unable to connect to mongodb://localhost:27017 I guess something is 
> missing, maybe mongodb should be installed separetely ? 
>  
> I continue reading the documentation, and find 
> [https://sling.apache.org/documentation/bundles/nosql-resource-providers.html]
> OK, my conclusion was I missed to install the nosql-resource-providers, so I 
> installed the bundle and check again ...
> Nothing new, it seems I have done nothing.
> So, always according to 
> [https://sling.apache.org/documentation/bundles/nosql-resource-providers.html,]
>  there is another launchpad to use.
> There is the link to the source code: 
> https://github.com/apache/sling-old-svn-mirror/tree/trunk/contrib/nosql/launchpad
> But it is said that this source repository is obsolete and shall not be used.
> So I get back to apache git repository, and filtered on "sling" and "nosql", 
> I can find some code now ...
> https://github.com/apache?utf8=%E2%9C%93=sling+nosql==
> But it is absolutely not clear to me whether I have to do something with that 
> modules or not ...
> So my real problem is I can't get the right documentation on "How to setup 
> Sling 9 to work with mongodb" and there is, as far as I know, no forum where 
> I can ask this to a community to help.
> I guess sling is working well with mongoDB, but if I need 10 days to set it 
> up (I spend 1 day, maybe it is not enough) my point of view is made: I won't 
> use mongodb.
> But this maybe a terrible mistake !
>  
> So help please !
>  
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Sling docker image

[Robert Munteanu]

Hi Eugen,

On Fri, 2018-02-02 at 10:28 +0200, Ioan Eugen Stan wrote:
> Hello Robert,
> 
> 
> I think taking back the name is a good idea. Maybe we could ask
> Docker
> hub if we can somehow change the name.
> 
> I would like to support deploying Sling with Docker.

Apparently this is possible, we got apache/sling

  https://hub.docker.com/r/apache/sling/

But I'm still working out the details of automated builds. In the
meantime, there is 

  https://hub.docker.com/r/apachesling/sling/

Not as nice, but just as functional :-)

Robert

> 
> 
> Regards,
> 
> 
> On 31.01.2018 17:03, Robert Munteanu wrote:
> > Hi,
> > 
> > Related to the ongoing github.com/apache/sling landing page
> > discussion,
> > I'd like to discuss our docker setup.
> > 
> > Currently we provide an apachelsling/sling [1] image, which is OK.
> > I
> > investigated setting up a build under the more official apache
> > account,
> > but unfortunately the automated docker builds picks up the image
> > name
> > from the repository, so we ended up with apache/sling-org-apache-
> > sling-
> > starter-docker, which is quite ugly.
> > 
> > If we choose automated builds, getting back the 'sling' repository
> > is
> > something we should consider.
> > 
> > Thanks,
> > 
> > Robert
> > 
> > [1]: https://hub.docker.com/r/apachesling/sling/
> > [2]: https://hub.docker.com/r/apache/sling-org-apache-sling-starter
> > -doc
> > ker/
> 
> 

Re: Sling docker image

[Ioan Eugen Stan]

Hello Robert,


I think taking back the name is a good idea. Maybe we could ask Docker
hub if we can somehow change the name.

I would like to support deploying Sling with Docker.


Regards,


On 31.01.2018 17:03, Robert Munteanu wrote:
> Hi,
>
> Related to the ongoing github.com/apache/sling landing page discussion,
> I'd like to discuss our docker setup.
>
> Currently we provide an apachelsling/sling [1] image, which is OK. I
> investigated setting up a build under the more official apache account,
> but unfortunately the automated docker builds picks up the image name
> from the repository, so we ended up with apache/sling-org-apache-sling-
> starter-docker, which is quite ugly.
>
> If we choose automated builds, getting back the 'sling' repository is
> something we should consider.
>
> Thanks,
>
> Robert
>
> [1]: https://hub.docker.com/r/apachesling/sling/
> [2]: https://hub.docker.com/r/apache/sling-org-apache-sling-starter-doc
> ker/




signature.asc
Description: OpenPGP digital signature

Re: [VOTE] Release Apache Sling File System Resource Provider version 2.1.12

[Robert Munteanu]

On Thu, 2018-02-01 at 16:30 +0100, Julian Sedding wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part