Re: [VOTE] Release Apache Sling API 2.18.0
+1 Carsten Ziegeler wrote > Hi, > > We solved 3 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12342301 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1885 > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1885 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[VOTE] Release Apache Sling API 2.18.0
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12342301 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1885 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1885 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[VOTE CANCELLED] Release Apache Sling API 2.17.0
I hereby cancel the vote as there is an unnecessary version increase of the request package. Regards Carsten Carsten Ziegeler wrote > Hi, > > We solved 3 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12342301 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1884 > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1884 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Apache Sling API 2.17.0
Hmm interesting, I can't remember to change it, but apparently it got changed by my commit. That's a mistake. I guess the best would be to revert that change and do another release WDYT? Carsten Oliver Lietz wrote > On Tuesday 13 March 2018 15:46:44 Julian Sedding wrote: >> Hi Oli >> >> I think it's ok, because ResourceResolver#getSearchPath() also returns >> String[]. So I think for consistency's sake we should leave it as-is. >> While I agree with you in principle, there are other examples where >> the singular term is used to refer to a list of paths, e.g. the java >> classpath. > > ACK, makes sense to be consistent. > > Why was package version for o.a.s.request increased? > > Thanks, Julian! > > O. > >> Regards >> Julian >> >> On Tue, Mar 13, 2018 at 3:24 PM, Oliver Lietzwrote: >>> On Tuesday 13 March 2018 08:36:14 Carsten Ziegeler wrote: Hi, >>> >>> Hi, >>> We solved 3 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12342301 >>> >>> SLING-7537: The method name should be getSearchPaths() instead of >>> getSearchPath() as it returns a list of strings (paths), no? >>> >>> Regards, >>> O. >>> >>> https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/ >>> java/org/apache/sling/api/resource/ResourceResolverFactory.java#L222 > -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: March board report draft
On Tuesday 13 March 2018 15:35:08 Robert Munteanu wrote: > Hi, Hi Robert, > Please find the draft board report below. Note that it's due tomorrow ( > sorry, dropped the ball on this one ), so please reply with any notes > today. LGTM (Sling IDE 1.20 -> 1.2.0) Regards, O. > Thanks, > > Robert > > ## Description: > > Apache Sling™ is a framework for RESTful web-applications based on an > extensible content tree. > > ## Issues: > > There are no issues requiring board attention at this time. > > ## Activity: > > Since the last board report we released Sling 10, Sling IDE Tooling for > Eclipse 1.20 and also released many other Sling modules. > > ## Health report: > > Good activity level overall, contributions from different people continue. > > ## PMC changes: > > - Currently 21 PMC members. > - No new PMC members added in the last 3 months > - Last PMC addition was Konrad Windszus on Sat Oct 01 2016 > > ## Committer base changes: > > - Currently 43 committers. > - New commmitters: > - Andreas Schaefer was added as a committer on Fri Jan 19 2018 > - Chris Millar was added as a committer on Wed Jan 24 2018 > - A. J. David Bosschaert was added as a committer on Fri Mar 09 2018 > - Jason Bailey was added as a committer on Mon Jan 22 2018 > > ## Releases: > > - Apache Sling Commons Java Compiler 2.3.6 was released on Fri Jan 19 2018 > - Apache Sling Context-Aware Configuration Impl 1.4.10 was released on Fri >Jan 19 2018 > - Apache Sling File System Resource Provider 2.1.10 was released on Tue Jan > 16 2018 > - Apache Sling File System Resource Provider 2.1.12 was released on Wed Feb > 07 2018 > - Apache Sling HTL Maven Plugin 1.1.4-1.3.1 was released on Thu Feb 01 2018 > - Apache Sling I18N Support 2.5.12 was released on Mon Jan 29 2018 - Apache > Sling IDE Tooling for Eclipse 1.2.0 was released on Sun Jan 21 2018 - > Apache Sling Installer Core 3.8.12 was released on Mon Feb 19 2018 - Apache > Sling Log Tracer 1.0.6 was released on Thu Jan 11 2018 > - Apache Sling Models Impl 1.4.8 was released on Mon Mar 05 2018 > - Apache Sling Repoinit JCR 1.1.8 was released on Mon Feb 12 2018 > - Apache Sling Repoinit Parser 1.2.2 was released on Mon Feb 12 2018 > - Apache Sling Resource Resolver 1.5.36 was released on Tue Feb 20 2018 > - Apache Sling Scripting Core 2.0.54 was released on Tue Dec 19 2017 > - Apache Sling Scripting HTL Compiler 1.0.16 was released on Tue Dec 19 > 2017 - Apache Sling Scripting HTL Compiler 1.0.20-1.3.1 was released on Thu > Feb 01 2018 > - Apache Sling Scripting HTL Engine 1.0.46 was released on Tue Dec 19 2017 > - Apache Sling Scripting HTL Engine 1.0.48-1.3.1 was released on Thu Feb 01 > 2018 > - Apache Sling Scripting HTL JS Use Provider 1.0.26 was released on Tue Dec > 19 2017 > - Apache Sling Scripting HTL Java Compiler 1.0.22-1.3.1 was released on Thu > Feb 01 2018 > - Apache Sling Scripting HTL Testing 1.0.6-1.3.1 was released on Thu Feb 01 > 2018 > - Apache Sling Scripting HTL Testing Content 1.0.8-1.3.1 was released on >Thu Feb 01 2018 > - Apache Sling Scripting JavaScript 3.0.4 was released on Tue Dec 19 2017 > - Apache Sling ServiceUser WebConsole 1.0.0 was released on Thu Jan 18 2018 > - Apache Sling Slingstart Archetype 1.0.4 was released on Wed Feb 07 2018 - > Apache Sling Starter 10 was released on Sat Feb 03 2018 > - Apache Sling Testing Sling Mock 1.9.12, Sling Mock 2.2.16 was released on > Mon Jan 29 2018 > - Apache Sling Testing Sling Mock 2.2.18, Servlet Helpers 1.1.4 was >released on Thu Mar 01 2018 > - Apache Sling Thread Support 3.2.16 was released on Wed Jan 31 2018 > - Apache Sling XSS Protection API 2.0.4 was released on Mon Jan 08 2018 > - JCR Oak Server 1.2.0 was released on Wed Mar 07 2018 > - Pipes 2.0.2 was released on Wed Feb 07 2018 > - Sling Parent 33 was released on Sat Jan 20 2018 > - Testing PaxExam 1.0.0 was released on Fri Feb 02 2018 > - Testing PaxExam 2.0.0 was released on Wed Mar 07 2018 > - org.apache.sling.serviceusermapper-1.4.0 was released on Fri Jan 19 2018 > > > ## JIRA activity: > > - 234 JIRA tickets created in the last 3 months > - 226 JIRA tickets closed/resolved in the last 3 months
Re: [VOTE] Release Apache Sling API 2.17.0
On Tuesday 13 March 2018 15:46:44 Julian Sedding wrote: > Hi Oli > > I think it's ok, because ResourceResolver#getSearchPath() also returns > String[]. So I think for consistency's sake we should leave it as-is. > While I agree with you in principle, there are other examples where > the singular term is used to refer to a list of paths, e.g. the java > classpath. ACK, makes sense to be consistent. Why was package version for o.a.s.request increased? Thanks, Julian! O. > Regards > Julian > > On Tue, Mar 13, 2018 at 3:24 PM, Oliver Lietzwrote: > > On Tuesday 13 March 2018 08:36:14 Carsten Ziegeler wrote: > >> Hi, > > > > Hi, > > > >> We solved 3 issues in this release: > >> > >> https://issues.apache.org/jira/projects/SLING/versions/12342301 > > > > SLING-7537: The method name should be getSearchPaths() instead of > > getSearchPath() as it returns a list of strings (paths), no? > > > > Regards, > > O. > > > > https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/ > > java/org/apache/sling/api/resource/ResourceResolverFactory.java#L222
Re: [VOTE] Release Apache Sling API 2.17.0
Hi Oli I think it's ok, because ResourceResolver#getSearchPath() also returns String[]. So I think for consistency's sake we should leave it as-is. While I agree with you in principle, there are other examples where the singular term is used to refer to a list of paths, e.g. the java classpath. Regards Julian On Tue, Mar 13, 2018 at 3:24 PM, Oliver Lietzwrote: > On Tuesday 13 March 2018 08:36:14 Carsten Ziegeler wrote: >> Hi, > > Hi, > >> We solved 3 issues in this release: >> >> https://issues.apache.org/jira/projects/SLING/versions/12342301 > > SLING-7537: The method name should be getSearchPaths() instead of > getSearchPath() as it returns a list of strings (paths), no? > > Regards, > O. > > https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolverFactory.java#L222 >
Re: [VOTE] Release Apache Sling API 2.17.0
On Tuesday 13 March 2018 08:36:14 Carsten Ziegeler wrote: > Hi, Hi, > We solved 3 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12342301 SLING-7537: The method name should be getSearchPaths() instead of getSearchPath() as it returns a list of strings (paths), no? Regards, O. https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolverFactory.java#L222
Re: [RT] Improvement for getting the resolver search paths
On Thu, Mar 8, 2018 at 4:52 PM, Carsten Ziegelerwrote: > The property can be set using the existing configuration (as we have the > config before we register the service). But I decided now to simply add > a message to the ResourceResolverFactory... Thanks, yes adding a method makes sense. -Bertrand
Re: [VOTE] Release Apache Sling API 2.17.0
On Tue, 2018-03-13 at 08:36 +0100, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
March board report draft
Hi, Please find the draft board report below. Note that it's due tomorrow ( sorry, dropped the ball on this one ), so please reply with any notes today. Thanks, Robert ## Description: Apache Sling™ is a framework for RESTful web-applications based on an extensible content tree. ## Issues: There are no issues requiring board attention at this time. ## Activity: Since the last board report we released Sling 10, Sling IDE Tooling for Eclipse 1.20 and also released many other Sling modules. ## Health report: Good activity level overall, contributions from different people continue. ## PMC changes: - Currently 21 PMC members. - No new PMC members added in the last 3 months - Last PMC addition was Konrad Windszus on Sat Oct 01 2016 ## Committer base changes: - Currently 43 committers. - New commmitters: - Andreas Schaefer was added as a committer on Fri Jan 19 2018 - Chris Millar was added as a committer on Wed Jan 24 2018 - A. J. David Bosschaert was added as a committer on Fri Mar 09 2018 - Jason Bailey was added as a committer on Mon Jan 22 2018 ## Releases: - Apache Sling Commons Java Compiler 2.3.6 was released on Fri Jan 19 2018 - Apache Sling Context-Aware Configuration Impl 1.4.10 was released on Fri Jan 19 2018 - Apache Sling File System Resource Provider 2.1.10 was released on Tue Jan 16 2018 - Apache Sling File System Resource Provider 2.1.12 was released on Wed Feb 07 2018 - Apache Sling HTL Maven Plugin 1.1.4-1.3.1 was released on Thu Feb 01 2018 - Apache Sling I18N Support 2.5.12 was released on Mon Jan 29 2018 - Apache Sling IDE Tooling for Eclipse 1.2.0 was released on Sun Jan 21 2018 - Apache Sling Installer Core 3.8.12 was released on Mon Feb 19 2018 - Apache Sling Log Tracer 1.0.6 was released on Thu Jan 11 2018 - Apache Sling Models Impl 1.4.8 was released on Mon Mar 05 2018 - Apache Sling Repoinit JCR 1.1.8 was released on Mon Feb 12 2018 - Apache Sling Repoinit Parser 1.2.2 was released on Mon Feb 12 2018 - Apache Sling Resource Resolver 1.5.36 was released on Tue Feb 20 2018 - Apache Sling Scripting Core 2.0.54 was released on Tue Dec 19 2017 - Apache Sling Scripting HTL Compiler 1.0.16 was released on Tue Dec 19 2017 - Apache Sling Scripting HTL Compiler 1.0.20-1.3.1 was released on Thu Feb 01 2018 - Apache Sling Scripting HTL Engine 1.0.46 was released on Tue Dec 19 2017 - Apache Sling Scripting HTL Engine 1.0.48-1.3.1 was released on Thu Feb 01 2018 - Apache Sling Scripting HTL JS Use Provider 1.0.26 was released on Tue Dec 19 2017 - Apache Sling Scripting HTL Java Compiler 1.0.22-1.3.1 was released on Thu Feb 01 2018 - Apache Sling Scripting HTL Testing 1.0.6-1.3.1 was released on Thu Feb 01 2018 - Apache Sling Scripting HTL Testing Content 1.0.8-1.3.1 was released on Thu Feb 01 2018 - Apache Sling Scripting JavaScript 3.0.4 was released on Tue Dec 19 2017 - Apache Sling ServiceUser WebConsole 1.0.0 was released on Thu Jan 18 2018 - Apache Sling Slingstart Archetype 1.0.4 was released on Wed Feb 07 2018 - Apache Sling Starter 10 was released on Sat Feb 03 2018 - Apache Sling Testing Sling Mock 1.9.12, Sling Mock 2.2.16 was released on Mon Jan 29 2018 - Apache Sling Testing Sling Mock 2.2.18, Servlet Helpers 1.1.4 was released on Thu Mar 01 2018 - Apache Sling Thread Support 3.2.16 was released on Wed Jan 31 2018 - Apache Sling XSS Protection API 2.0.4 was released on Mon Jan 08 2018 - JCR Oak Server 1.2.0 was released on Wed Mar 07 2018 - Pipes 2.0.2 was released on Wed Feb 07 2018 - Sling Parent 33 was released on Sat Jan 20 2018 - Testing PaxExam 1.0.0 was released on Fri Feb 02 2018 - Testing PaxExam 2.0.0 was released on Wed Mar 07 2018 - org.apache.sling.serviceusermapper-1.4.0 was released on Fri Jan 19 2018 ## JIRA activity: - 234 JIRA tickets created in the last 3 months - 226 JIRA tickets closed/resolved in the last 3 months
Re: [VOTE] Release Apache Sling API 2.17.0
+1 On Tue, Mar 13, 2018 at 6:58 AM, Radu Cotescuwrote: > +1 > > On Tue, 13 Mar 2018 at 08:36 Carsten Ziegeler > wrote: > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe Research Switzerland > > cziege...@apache.org > > >
[jira] [Commented] (SLING-7525) Content-Type missing after applying the ContentDispositionFilter twice
[ https://issues.apache.org/jira/browse/SLING-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396924#comment-16396924 ] Antonio Sanso commented on SLING-7525: -- I can reproduce. Thanks a lot [~orlowska] > Content-Type missing after applying the ContentDispositionFilter twice > -- > > Key: SLING-7525 > URL: https://issues.apache.org/jira/browse/SLING-7525 > Project: Sling > Issue Type: Bug >Affects Versions: Security 1.1.8, Security 1.1.10 >Reporter: Orlowska >Assignee: Antonio Sanso >Priority: Major > > The issue started with the SLING-7219. > When the {{ContentDispositionFilter}} is called twice (as a request filter > and as a forward filter) on a single request then the {{Content-Type}} is not > propagated and missing in the Response. > > On the second pass in the {{setContentType()}} the condition [1] > {code:java} > if (previousContentType != null && previousContentType.equals(type)){code} > will be fulfilled so the [2] > {code:java} > super.setContentType(type);{code} > will not be called. > > [1] > [https://github.com/apache/sling-org-apache-sling-security/blob/master/src/main/java/org/apache/sling/security/impl/ContentDispositionFilter.java#L208] > [2] > [https://github.com/apache/sling-org-apache-sling-security/blob/master/src/main/java/org/apache/sling/security/impl/ContentDispositionFilter.java#L253] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [VOTE] Release Apache Sling API 2.17.0
+1 On Tue, 13 Mar 2018 at 08:36 Carsten Ziegelerwrote: > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >
RE: [VOTE] Release Apache Sling API 2.17.0
+1
[VOTE] Release Apache Sling API 2.17.0
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12342301 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1884 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1884 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Apache Sling API 2.17.0
+1 Carsten Ziegeler wrote > Hi, > > We solved 3 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12342301 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1884 > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1884 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Updated] (SLING-7510) UriProvider throws unchecked IllegalArgumentException that must be handled by consumers
[ https://issues.apache.org/jira/browse/SLING-7510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-7510: Fix Version/s: (was: API 2.16.6) API 2.17.2 > UriProvider throws unchecked IllegalArgumentException that must be handled by > consumers > --- > > Key: SLING-7510 > URL: https://issues.apache.org/jira/browse/SLING-7510 > Project: Sling > Issue Type: Improvement > Components: API >Affects Versions: API 2.16.4 >Reporter: Alexander Klimetschek >Priority: Major > Fix For: API 2.17.2 > > > h3. Status quo > A consumer of the > [UriProvider|https://github.com/apache/sling-org-apache-sling-api/blob/dfc41640031bc87ec271c648b22073e65f4f171a/src/main/java/org/apache/sling/api/resource/external/URIProvider.java#L45] > currently is required to handle an unchecked {{IllegalArgumentException}}, > which is thrown when the provider is not able to handle the binary. Note that > it is not supposed to ever return null per the javadoc. The > [JcrNodeResource|https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/0e2ebd0f1a5c7cb2044b2d754945eb0ee7641081/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java#L233-L242] > shows a typical consumer code (although it still does do a null check). > For the use case of asking multiple providers and taking the first one that > responds it's not an optimal pattern to rely on an unchecked exception for > the expected failure case that one provider by design cannot handle a certain > binary or request. Throwing an {{IllegalArgumentException}} if there is no > problem with the argument passed from the client, but a limit or > configuration setting of the provider, is misleading. Also, given there are > multiple providers active, a client cannot know upfront which provider is the > right one for a given binary and somehow prevent the "illegal argument" call > in the first place. > h3. Suggestion > Often, {{null}} return values are used in such a case. The provider can log > any possible useful information itself, on why it could not handle it, if > needed. This would simplify the consumer code (no try/catch necessary) and > remove unnecessary cost of exception handling for normal code paths. > JcrNodeResource itself it uses a null return value to pass on the "could not > retrieve anything" state to the upper layers. > If the goal really is to use exceptions here, the API should add a > {{@Nonnull}} annotation for the return value _and_ the expected failure > exception should be a checked one such as a new {{UriProviderException}}. > Then for any unexpected faults (e.g. network error), it's fine to allow > providers to throw a unchecked runtime exception, and usually that's not > something that is explicitly mentioned in javadoc, but would definitely not > hurt. -- This message was sent by Atlassian JIRA (v7.6.3#76005)