date:20180524

[GitHub] hasinidilanka commented on issue #14: First commit for oidc handler.

2018-05-24 Thread GitBox

hasinidilanka commented on issue #14: First commit for oidc handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#issuecomment-391844968
 
 
   @rombert  Thank you for the comments, they were very helpful for me. I 
resolved some of the comments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DominikSuess commented on issue #7: SLING-7544 - fixing potential race between intialization and addition…

2018-05-24 Thread GitBox

DominikSuess commented on issue #7: SLING-7544 - fixing potential race between 
intialization and addition…
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/7#issuecomment-391835091
 
 
   @rombert initialization of aliasmap(esp. iteration over resultset) might 
race against further changes in the content that would add further entries to 
the resultset thst otherways would be missing in the aliasmap. This is now 
resolved by queueing up those changes and merging into the resultset.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hasinidilanka commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

hasinidilanka commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190706351
 
 

 ##
 File path: oidc-handler/pom.xml
 ##
 @@ -1,11 +1,35 @@
 
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+  org.apache.sling
+  org.apache.sling.oidchandler
+  1.0.0-SNAPSHOT
+  pom
+  org.apache.sling.oidchandler
 
-http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  
+admin
+admin
+  
 
-4.0.0
-org.apache.sling
-org.apache.sling.oidchandler
-1.0-SNAPSHOT
+
 
 Review comment:
   If this plugin is removed, the project cannot be implemented using mvn 
package sling:install. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Assigned] (SLING-7678) create gogo command provider for running & building pipe

2018-05-24 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7678:
--

Assignee: Nicolas Peltier

> create gogo command provider for running & building pipe
> 
>
> Key: SLING-7678
> URL: https://issues.apache.org/jira/browse/SLING-7678
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> would be nice to have gogo command to run & build pipes quickly



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7678) create gogo command provider for running & building pipe

2018-05-24 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7678:
---
Affects Version/s: (was: pipes 3.0.0)
   pipes 2.0.2

> create gogo command provider for running & building pipe
> 
>
> Key: SLING-7678
> URL: https://issues.apache.org/jira/browse/SLING-7678
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> would be nice to have gogo command to run & build pipes quickly



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7678) create gogo command provider for running & building pipe

2018-05-24 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7678:
---
Fix Version/s: pipes 3.0.0

> create gogo command provider for running & building pipe
> 
>
> Key: SLING-7678
> URL: https://issues.apache.org/jira/browse/SLING-7678
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> would be nice to have gogo command to run & build pipes quickly



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7632) Pipe Execution Result should show an error list

2018-05-24 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7632.

   Resolution: Fixed
Fix Version/s: pipes 3.0.0

> Pipe Execution Result should show an error list
> ---
>
> Key: SLING-7632
> URL: https://issues.apache.org/jira/browse/SLING-7632
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> While not breaking the pipe execution at the first issue encountered is 
> important in a production world when a content exception should/could be 
> handled separately. Errors happening are "only" happening on logs. 
> They should be tracked in the execution result as well, with path excerpt, 
> and total #, with same limit as for results. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

2018-05-24 Thread Daniel Klco

Seems sensible to me. Is there a list of the deprecated / contrib
repositories? I just pushed in the change, but haven't updated the site
since there are new releases which may not have propagated.

On Thu, May 24, 2018 at 4:20 AM, Bertrand Delacretaz  wrote:

> On Wed, May 23, 2018 at 5:56 PM, Daniel Klco 
> wrote:
> > ...Shields.io seems to be a pretty common standard for GitHub projects
> so what
> > if we just use these rather than self-hosting?...
>
> Thinking about it, I suggest using both self-hosted and dynamic
> badges, for different purposes:
>
> a) Self-hosted SVG badges under http://sling.apache.org/res/badges for
> static repository attributes like deprecated, contrib etc.
>
> AFAIK we can copy badges generated at http://shields.io/ there, that
> website doesn't seem to have any usage restrictions.
>
> Having well-known URLs that we control for those makes sure they are
> consistent and allows us to detect them in scripts. The
> http://sling.apache.org/repolist.html page for example can be improved
> to include the badges by parsing the modules README files for badges
> based on those well-known URLs. And the downloads page could also use
> that maybe instead of duplicating information by splitting modules in
> lists.
>
> b) Dynamic badges for build results etc., things that are not static
> attributes of the code repositories
>
> WDYT?
>

[jira] [Resolved] (SLING-7555) Remove ghost packages from distribution agent queue

2018-05-24 Thread Marius Petria (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marius Petria resolved SLING-7555.
--
Resolution: Fixed
  Assignee: Marius Petria

Fixed in 
https://github.com/apache/sling-org-apache-sling-distribution-core/commit/ee2c3dd0591d0f2c2a4b3a15f726f866c81e1ed3

> Remove ghost packages from distribution agent queue
> ---
>
> Key: SLING-7555
> URL: https://issues.apache.org/jira/browse/SLING-7555
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.10
>Reporter: Marius Petria
>Assignee: Marius Petria
>Priority: Major
> Fix For: Content Distribution Core 0.3.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, (see [1]) an agent exporter only logs an error when a "ghost 
> package" is encountered (a queue entry without a binary). We should log this 
> as an error and remove the item from the queue in order to avoid stuck queues.
>  
>  
> [1]https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/packaging/impl/exporter/AgentDistributionPackageExporter.java#L102



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7357) Send Content-Type header along with the DistributionPackage's content in forward distribution

2018-05-24 Thread Marius Petria (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489089#comment-16489089
 ] 

Marius Petria commented on SLING-7357:
--

This issue introduced a breaking change in {{DistributionContentSerializer}}. 
We should aim to keep backwards compatibility and I think we should revisit the 
way this was implemented. The mime type is an interoperability feature and 
could have been added as a http configuration option on the agent.

> Send Content-Type header along with the DistributionPackage's content in 
> forward distribution
> -
>
> Key: SLING-7357
> URL: https://issues.apache.org/jira/browse/SLING-7357
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Dirk Rudolph
>Assignee: Dirk Rudolph
>Priority: Minor
> Fix For: Content Distribution Core 0.3.0
>
>
> Currently SimpleHttpDistributionTransport only adds Connection and Digest 
> http header (if configured to do so) to the http request. When integrating 
> into other systems then sling the API might require the content type of the 
> package transmitted to be present. 
> I see to options to support that:
> a) implement configureable headers for the http transport similar to the 
> timeouts. This might clash with headers set by the implementation
> b) let the serializer specify the type of the content it generates. This will 
> be an API change in the core bundle.
> From my perspective b) will be simpler to implement.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7549) tag is not being treated as "self closing" when used in conjunction with HTL block statements

2018-05-24 Thread Konrad Windszus (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488975#comment-16488975
 ] 

Konrad Windszus commented on SLING-7549:


I think at least all elements listed in 
https://www.w3.org/TR/html5/syntax.html#void-elements should be accepted 
without a closing tag.

>  tag is not being treated as "self closing" when used in conjunction 
> with HTL block statements
> 
>
> Key: SLING-7549
> URL: https://issues.apache.org/jira/browse/SLING-7549
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.0.32
>Reporter: Paul Bjorkstrand
>Assignee: Radu Cotescu
>Priority: Major
>
> When using HTL block statements some tags that are assumed to be "self 
> closing" by browsers are not handled in that manner by the HTL engine. This 
> can cause hard to find problems with the rendering of the page. in this 
> example, the {{}} tag was the culprit. 
> I was diagnosing an issue where under a certain set of circumstances all of 
> my page's css was not being rendered. This happened to be due a {{}} 
> tag that was not closed, but had a block statement added to it:
> {code:java}
>  href="${metadata.prerenderUrl}">{code}
> That seemingly innocuous tag caused the HTL engine to assume that all 
> contents following, (until the the parent head closing tag), to be inside 
> that link tag.
> According to the [html5 
> spec|https://www.w3.org/TR/2014/REC-html5-20141028/document-metadata.html#the-link-element]
>  the content of the {{}} element is empty. Nearly every browser in use 
> today treats {{}} the same as {{}}. Given this, it is 
> not a stretch to assume that HTL would treat it in the same manner.
> It is my belief that HTL should mimic the html5 specification. At minimum, I 
> would hope to get a clear answer on which HTML specification it follows, or a 
> statement that HTL does not/will not follow an HTML specification.
> *Note*: I was unsure if this should be something in the HTL spec or in the 
> implementation. Since I found no reference in the specification regarding 
> html5/xhtml/html4 compliance, I came here with my request instead. Please let 
> me know if this is something that should be addressed at the specification 
> level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7549) tag is not being treated as "self closing" when used in conjunction with HTL block statements

2018-05-24 Thread Radu Cotescu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488923#comment-16488923
 ] 

Radu Cotescu commented on SLING-7549:
-

The HTL specification doesn't mention any HTML version it supports, however the 
implementation's HTML parser is lenient. In this regard I think we can just add 
some more rules for the HTML 5 void elements.

>  tag is not being treated as "self closing" when used in conjunction 
> with HTL block statements
> 
>
> Key: SLING-7549
> URL: https://issues.apache.org/jira/browse/SLING-7549
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.0.32
>Reporter: Paul Bjorkstrand
>Assignee: Radu Cotescu
>Priority: Major
>
> When using HTL block statements some tags that are assumed to be "self 
> closing" by browsers are not handled in that manner by the HTL engine. This 
> can cause hard to find problems with the rendering of the page. in this 
> example, the {{}} tag was the culprit. 
> I was diagnosing an issue where under a certain set of circumstances all of 
> my page's css was not being rendered. This happened to be due a {{}} 
> tag that was not closed, but had a block statement added to it:
> {code:java}
>  href="${metadata.prerenderUrl}">{code}
> That seemingly innocuous tag caused the HTL engine to assume that all 
> contents following, (until the the parent head closing tag), to be inside 
> that link tag.
> According to the [html5 
> spec|https://www.w3.org/TR/2014/REC-html5-20141028/document-metadata.html#the-link-element]
>  the content of the {{}} element is empty. Nearly every browser in use 
> today treats {{}} the same as {{}}. Given this, it is 
> not a stretch to assume that HTL would treat it in the same manner.
> It is my belief that HTL should mimic the html5 specification. At minimum, I 
> would hope to get a clear answer on which HTML specification it follows, or a 
> statement that HTL does not/will not follow an HTML specification.
> *Note*: I was unsure if this should be something in the HTL spec or in the 
> implementation. Since I found no reference in the specification regarding 
> html5/xhtml/html4 compliance, I came here with my request instead. Please let 
> me know if this is something that should be addressed at the specification 
> level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] mpetria closed pull request #8: SLING-7555: option to drop ghost packages from and agent exporter

2018-05-24 Thread GitBox

mpetria closed pull request #8:  SLING-7555: option to drop ghost packages from 
and agent exporter
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/8
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 123393b..8e19597 100644
--- a/pom.xml
+++ b/pom.xml
@@ -71,13 +71,7 @@
 
 org.apache.sling.distribution.util,
 org.apache.sling.distribution.common,
-org.apache.sling.distribution.serialization,
-org.apache.sling.distribution.queue.spi,
-org.apache.sling.distribution.queue,
-org.apache.sling.distribution.log.spi,
-org.apache.sling.distribution.agent,
-org.apache.sling.distribution.agent.spi,
-org.apache.sling.distribution.packaging
+org.apache.sling.distribution.serialization
 
 
 org.apache.http.nio.*;resolution:=optional,
diff --git 
a/src/main/java/org/apache/sling/distribution/packaging/impl/exporter/AgentDistributionPackageExporter.java
 
b/src/main/java/org/apache/sling/distribution/packaging/impl/exporter/AgentDistributionPackageExporter.java
index 63744a0..6662b13 100644
--- 
a/src/main/java/org/apache/sling/distribution/packaging/impl/exporter/AgentDistributionPackageExporter.java
+++ 
b/src/main/java/org/apache/sling/distribution/packaging/impl/exporter/AgentDistributionPackageExporter.java
@@ -50,15 +50,17 @@
 private final Logger log = LoggerFactory.getLogger(getClass());
 private final DistributionPackageBuilderProvider packageBuilderProvider;
 private final String name;
+private boolean dropInvalidItems;
 
 private final static String PACKAGE_TYPE = "agentexporter";
 
 private DistributionAgent agent;
 private String queueName;
 
-public AgentDistributionPackageExporter(String queueName, 
DistributionAgent agent, DistributionPackageBuilderProvider 
packageBuilderProvider, String name) {
+public AgentDistributionPackageExporter(String queueName, 
DistributionAgent agent, DistributionPackageBuilderProvider 
packageBuilderProvider, String name, boolean dropInvalidItems) {
 this.packageBuilderProvider = packageBuilderProvider;
 this.name = name;
+this.dropInvalidItems = dropInvalidItems;
 
 if (agent == null || packageBuilderProvider == null) {
 throw new IllegalArgumentException("Agent and package builder are 
required");
@@ -99,7 +101,12 @@ public void exportPackages(@Nonnull ResourceResolver 
resourceResolver, @Nonnull
 
 packageProcessor.process(new 
AgentDistributionPackage(distributionPackage, queue, entry.getId()));
 } else {
-log.warn("cannot get package {}", info);
+if (dropInvalidItems) {
+queue.remove(entry.getId());
+log.warn("ghost package: cannot get package {} 
dropping from queue", info);
+} else {
+log.warn("ghost package: cannot get package {} 
keeping in queue", info);
+}
 }
 } else {
 log.warn("cannot find package builder with type {}", 
info.getType());
diff --git 
a/src/main/java/org/apache/sling/distribution/packaging/impl/exporter/AgentDistributionPackageExporterFactory.java
 
b/src/main/java/org/apache/sling/distribution/packaging/impl/exporter/AgentDistributionPackageExporterFactory.java
index 1d6fd01..8671c0d 100644
--- 
a/src/main/java/org/apache/sling/distribution/packaging/impl/exporter/AgentDistributionPackageExporterFactory.java
+++ 
b/src/main/java/org/apache/sling/distribution/packaging/impl/exporter/AgentDistributionPackageExporterFactory.java
@@ -34,6 +34,7 @@
 import org.apache.sling.distribution.agent.spi.DistributionAgent;
 import org.apache.sling.distribution.common.DistributionException;
 import 
org.apache.sling.distribution.component.impl.DistributionComponentConstants;
+import org.apache.sling.distribution.component.impl.SettingsUtils;
 import org.apache.sling.distribution.packaging.DistributionPackage;
 import 
org.apache.sling.distribution.packaging.impl.DistributionPackageBuilderProvider;
 import 
org.apache.sling.distribution.packaging.impl.DistributionPackageExporter;
@@ -61,10 +62,14 @@
 @Property(label = "Queue", description = "The name of the queue from which 
the packages should be exported.")
 private static final String

[GitHub] mpetria opened a new pull request #8: SLING-7555: option to drop ghost packages from and agent exporter

2018-05-24 Thread GitBox

mpetria opened a new pull request #8:  SLING-7555: option to drop ghost 
packages from and agent exporter
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/8
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Assigned] (SLING-7549) tag is not being treated as "self closing" when used in conjunction with HTL block statements

2018-05-24 Thread Radu Cotescu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-7549:
---

Assignee: Radu Cotescu

>  tag is not being treated as "self closing" when used in conjunction 
> with HTL block statements
> 
>
> Key: SLING-7549
> URL: https://issues.apache.org/jira/browse/SLING-7549
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.0.32
>Reporter: Paul Bjorkstrand
>Assignee: Radu Cotescu
>Priority: Major
>
> When using HTL block statements some tags that are assumed to be "self 
> closing" by browsers are not handled in that manner by the HTL engine. This 
> can cause hard to find problems with the rendering of the page. in this 
> example, the {{}} tag was the culprit. 
> I was diagnosing an issue where under a certain set of circumstances all of 
> my page's css was not being rendered. This happened to be due a {{}} 
> tag that was not closed, but had a block statement added to it:
> {code:java}
>  href="${metadata.prerenderUrl}">{code}
> That seemingly innocuous tag caused the HTL engine to assume that all 
> contents following, (until the the parent head closing tag), to be inside 
> that link tag.
> According to the [html5 
> spec|https://www.w3.org/TR/2014/REC-html5-20141028/document-metadata.html#the-link-element]
>  the content of the {{}} element is empty. Nearly every browser in use 
> today treats {{}} the same as {{}}. Given this, it is 
> not a stretch to assume that HTL would treat it in the same manner.
> It is my belief that HTL should mimic the html5 specification. At minimum, I 
> would hope to get a clear answer on which HTML specification it follows, or a 
> statement that HTL does not/will not follow an HTML specification.
> *Note*: I was unsure if this should be something in the HTL spec or in the 
> implementation. Since I found no reference in the specification regarding 
> html5/xhtml/html4 compliance, I came here with my request instead. Please let 
> me know if this is something that should be addressed at the specification 
> level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7679) slingstart-maven-plugin: Clarify in-pom vs. external model declaration

2018-05-24 Thread Konrad Windszus (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-7679:
---
Description: 
Currently there are three different ways on how a model can be given to the 
{{slingstart-maven-plugin}}
# external in {{src/main/provisioning}}
# external in {{src/test/provisioning}}
# inline plugin configuration via parameter {{model}}

With SLING-7662 a check though was implemented that either the directory 
{{src/main/provisioning}} or {{src/test/provisioning}} must exist for the model 
to be detected (even if given inline). This is unexpected, not documented and 
should be fixed.

Also there should be a dedicated inline parameter for giving a test model, as 
the scope of those dependencies should be different.

So IMHO there should be 4 ways of giving a model:
# external in {{src/main/provisioning}}, only when the directory exists
# external in {{src/test/provisioning}}, only when the directory exists
# inline plugin configuration via parameter {{model}}, only in case element is 
not empty
# inline plugin configuration via parameter {{testModel}}, *_new_*, only in 
case element is not empty

  was:
Currently there are three different ways on how a model can be given to the 
{{slingstart-maven-plugin}}
# external in {{src/main/provisioning}}
# external in {{src/test/provisioning}}
# inline plugin configuration via parameter {{model}}

With SLING-7662 a check though was implemented that either the directory 
{{src/main/provisioning}} or {{src/test/provisioning}} must exist for the model 
to be detected (even if given inline). This is weird and should be cleaned up.

Also there should be a dedicated inline parameter for giving a test model, as 
the scope of those dependencies should be different.


> slingstart-maven-plugin: Clarify in-pom vs. external model declaration
> --
>
> Key: SLING-7679
> URL: https://issues.apache.org/jira/browse/SLING-7679
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Slingstart Maven Plugin 1.8.2
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently there are three different ways on how a model can be given to the 
> {{slingstart-maven-plugin}}
> # external in {{src/main/provisioning}}
> # external in {{src/test/provisioning}}
> # inline plugin configuration via parameter {{model}}
> With SLING-7662 a check though was implemented that either the directory 
> {{src/main/provisioning}} or {{src/test/provisioning}} must exist for the 
> model to be detected (even if given inline). This is unexpected, not 
> documented and should be fixed.
> Also there should be a dedicated inline parameter for giving a test model, as 
> the scope of those dependencies should be different.
> So IMHO there should be 4 ways of giving a model:
> # external in {{src/main/provisioning}}, only when the directory exists
> # external in {{src/test/provisioning}}, only when the directory exists
> # inline plugin configuration via parameter {{model}}, only in case element 
> is not empty
> # inline plugin configuration via parameter {{testModel}}, *_new_*, only in 
> case element is not empty



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7662) Cannot use slingstart-maven-plugin for starting a server only with referencing a launchpad by dependency due to the DependencyLifecycleParticipant

2018-05-24 Thread Konrad Windszus (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1641#comment-1641
 ] 

Konrad Windszus commented on SLING-7662:


Yes, makes sense. I created https://issues.apache.org/jira/browse/SLING-7679 
for that.

> Cannot use slingstart-maven-plugin for starting a server only with 
> referencing a launchpad by dependency due to the 
> DependencyLifecycleParticipant
> --
>
> Key: SLING-7662
> URL: https://issues.apache.org/jira/browse/SLING-7662
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Slingstart Maven Plugin 1.7.16
>Reporter: Konrad Windszus
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Slingstart Maven Plugin 1.8.2
>
>
> Whenever the slingstart-maven-plugin is only used to start a server which is 
> referenced via the parameter {{launchpadDependency}} the following error is 
> being emitted from Maven.
> {code}
> ...
> [ERROR] No model files found in 
> /Users/konradwindszus/workspaces/sling/sling-org-apache-sling-servlets-annotations/src/test/provisioning,
>  and no model inlined in POM. -> [Help 1]
> org.apache.maven.MavenExecutionException: No model files found in 
> /Users/konradwindszus/workspaces/sling/sling-org-apache-sling-servlets-annotations/src/test/provisioning,
>  and no model inlined in POM.
> at org.apache.sling.maven.slingstart.ModelPreprocessor.readLocalModel 
> (ModelPreprocessor.java:552)
> at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies 
> (ModelPreprocessor.java:131)
> at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies 
> (ModelPreprocessor.java:89)
> at 
> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.afterProjectsRead
>  (DependencyLifecycleParticipant.java:100)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:267)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
> {code}
> The pom.xml looks like this
> {code}
> ...
> 
> 
> 
> org.apache.sling
> slingstart-maven-plugin
> true
> 
> 
> start-container-before-IT
> 
> start
> 
> 
> 
> 
> org.apache.sling.launchpad
> org.apache.sling
> 9
> 
> 
> 
> 
> stop-container-after-IT
> 
> stop
> 
> 
> 
> ${keepITServerRunning}
> 
> 
> 
> 
> 
> 
> 
> singleinstance
> ${http.port}
> ${sling.vm.options}
> sling/logs/stdout.log
> 
> 
> 
> 
> 
> 
> ...
> {code}
> Actually the DependencyLifecycleParticipant is only relevant for the goals 
> {{prepare-package}} and {{package}}. When the slingstart-maven-plugin is 
>

[jira] [Updated] (SLING-7679) slingstart-maven-plugin: Clarify in-pom vs. external model declaration

2018-05-24 Thread Konrad Windszus (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-7679:
---
Summary: slingstart-maven-plugin: Clarify in-pom vs. external model 
declaration  (was: Clarify in-pom vs. external model declaration)

> slingstart-maven-plugin: Clarify in-pom vs. external model declaration
> --
>
> Key: SLING-7679
> URL: https://issues.apache.org/jira/browse/SLING-7679
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Slingstart Maven Plugin 1.8.2
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently there are three different ways on how a model can be given to the 
> {{slingstart-maven-plugin}}
> # external in {{src/main/provisioning}}
> # external in {{src/test/provisioning}}
> # inline plugin configuration via parameter {{model}}
> With SLING-7662 a check though was implemented that either the directory 
> {{src/main/provisioning}} or {{src/test/provisioning}} must exist for the 
> model to be detected (even if given inline). This is weird and should be 
> cleaned up.
> Also there should be a dedicated inline parameter for giving a test model, as 
> the scope of those dependencies should be different.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7679) Clarify in-pom vs. external model declaration

2018-05-24 Thread Konrad Windszus (JIRA)

Konrad Windszus created SLING-7679:
--

 Summary: Clarify in-pom vs. external model declaration
 Key: SLING-7679
 URL: https://issues.apache.org/jira/browse/SLING-7679
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Affects Versions: Slingstart Maven Plugin 1.8.2
Reporter: Konrad Windszus


Currently there are three different ways on how a model can be given to the 
{{slingstart-maven-plugin}}
# external in {{src/main/provisioning}}
# external in {{src/test/provisioning}}
# inline plugin configuration via parameter {{model}}

With SLING-7662 a check though was implemented that either the directory 
{{src/main/provisioning}} or {{src/test/provisioning}} must exist for the model 
to be detected (even if given inline). This is weird and should be cleaned up.

Also there should be a dedicated inline parameter for giving a test model, as 
the scope of those dependencies should be different.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7552) SlingPostServlet error handling still insufficient

2018-05-24 Thread Antonio Sanso (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488820#comment-16488820
 ] 

Antonio Sanso commented on SLING-7552:
--

[~joerghoh] maybe a less invasive solution would be to change the default for 
{{PostResponseWithErrorHandling}} to {{true}} see [0]

 

[0]https://github.com/apache/sling-org-apache-sling-servlets-post/blob/master/src/main/java/org/apache/sling/servlets/post/impl/PostResponseWithErrorHandling.java#L59

> SlingPostServlet error handling still insufficient
> --
>
> Key: SLING-7552
> URL: https://issues.apache.org/jira/browse/SLING-7552
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Post 2.3.24
>Reporter: Jörg Hoh
>Priority: Major
>  Labels: patch
> Attachments: SLING-7552-patch.diff
>
>
> At the moment the default errorhandling of Sling [1] cannot be used for 
> errors caused and handled by the SlingPostServlet itself. It will always 
> return its own custom output without the chance of customizing it. Although 
> Antonio and Justing worked in SLING-2156 to improve this situation, it still 
> requires extra work (implementing a PostResponseWithErrorHandling). It would 
> be better if the output could be customized by the "standard error handling".
>  
> How to reproduce:
>  * create an error handling script in 
> /apps/sling/servlet/errorhandler/default.jsp which creates some random output.
>  * Validate this script config by doing a request which causes some exception 
> (do not use the SlingPostServlet here)
>  * Do a POST to the Sling instance which results in an exception (e.g. due to 
> insufficient permissions.
>  * The output of the second call is completely determined by the 
> SlingPostServlet, the default error handling does not kick in.
> Proposed solution:
> * The SlingPostServlet should not swallow the exception and handle it by 
> itself, but rather re-throw it, so the standard error handling is triggered.
>  
> [1] http://sling.apache.org/documentation/the-sling-engine/errorhandling.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SLING-7552) SlingPostServlet error handling still insufficient

2018-05-24 Thread Antonio Sanso (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488820#comment-16488820
 ] 

Antonio Sanso edited comment on SLING-7552 at 5/24/18 11:30 AM:


[~joerghoh] maybe a less invasive solution would be to change the default for 
{{PostResponseWithErrorHandling}} to {{true}} see [0]

 

[0]https://github.com/apache/sling-org-apache-sling-servlets-post/blob/master/src/main/java/org/apache/sling/servlets/post/impl/PostResponseWithErrorHandling.java#L59


was (Author: asanso):
[~joerghoh] maybe a less invasive solution would be to change the default for 
{{PostResponseWithErrorHandling}} to {{true}} see [0]

 

[0]https://github.com/apache/sling-org-apache-sling-servlets-post/blob/master/src/main/java/org/apache/sling/servlets/post/impl/PostResponseWithErrorHandling.java#L59

> SlingPostServlet error handling still insufficient
> --
>
> Key: SLING-7552
> URL: https://issues.apache.org/jira/browse/SLING-7552
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Post 2.3.24
>Reporter: Jörg Hoh
>Priority: Major
>  Labels: patch
> Attachments: SLING-7552-patch.diff
>
>
> At the moment the default errorhandling of Sling [1] cannot be used for 
> errors caused and handled by the SlingPostServlet itself. It will always 
> return its own custom output without the chance of customizing it. Although 
> Antonio and Justing worked in SLING-2156 to improve this situation, it still 
> requires extra work (implementing a PostResponseWithErrorHandling). It would 
> be better if the output could be customized by the "standard error handling".
>  
> How to reproduce:
>  * create an error handling script in 
> /apps/sling/servlet/errorhandler/default.jsp which creates some random output.
>  * Validate this script config by doing a request which causes some exception 
> (do not use the SlingPostServlet here)
>  * Do a POST to the Sling instance which results in an exception (e.g. due to 
> insufficient permissions.
>  * The output of the second call is completely determined by the 
> SlingPostServlet, the default error handling does not kick in.
> Proposed solution:
> * The SlingPostServlet should not swallow the exception and handle it by 
> itself, but rather re-throw it, so the standard error handling is triggered.
>  
> [1] http://sling.apache.org/documentation/the-sling-engine/errorhandling.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[RESULT] [VOTE] Release Apache Sling Commons Log 5.1.8

2018-05-24 Thread Julian Sedding

Hi all,

The vote has passed with the following result:

+1 (binding): Daniel Klco, Chetan Mehrotra, Stefan Seifert
+1 (non binding): Julian Sedding

Thanks for voting.

I will promote the artifacts to the central Maven repository and
update the news page.

@any PMC member: please copy this release to the Sling dist directory.

Regards
Julian

[GitHub] rombert commented on issue #7: SLING-7544 - fixing potential race between intialization and addition…

2018-05-24 Thread GitBox

rombert commented on issue #7: SLING-7544 - fixing potential race between 
intialization and addition…
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/7#issuecomment-391658979
 
 
   Thanks for following-up @DominikSuess  . Can you please explain what the 
race condition is/was?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190524060
 
 

 ##
 File path: oidc-handler/ui/src/main/resources/SLING-INF/nodetypes/nodetypes.cnd
 ##
 @@ -0,0 +1,32 @@
+//
 
 Review comment:
   You're not using custom node types so you can remove it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518251
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
 
 Review comment:
   This execution should be inherited from the parent pom.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520984
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.7.0
+
+8
+8
+
+
+
+org.apache.sling
+maven-sling-plugin
+2.3.4
+
+http://localhost:8080/system/console
+admin
+admin
+
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr
+
+2.0.10
+
+provided
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr.annotations
+
+1.9.6
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.sling
+org.apache.sling.engine
+2.4.6
+provided
+
+
+
+javax.servlet
+servlet-api
+2.5
+provided
+
+
+org.osgi
+org.osgi.compendium
+4.2.0
+provided
+
+
+org.osgi
+org.osgi.core
+4.2.0
+provided
+
+
+javax.jcr
 
 Review comment:
   You should not need this now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518177
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
 
 Review comment:
   The version should be inherited from the parent POM.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522920
 
 

 ##
 File path: oidc-handler/ui/pom.xml
 ##
 @@ -0,0 +1,191 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+ui
+1.0.0-SNAPSHOT
+ui
+org.apache.sling - ui
+
+
+
+
+org.apache.felix
+maven-scr-plugin
+
+
+org.apache.felix
 
 Review comment:
   You can achieve the same with the bnd-maven-plugin, please use that instead.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190521434
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.7.0
+
+8
+8
+
+
+
+org.apache.sling
+maven-sling-plugin
+2.3.4
+
+http://localhost:8080/system/console
+admin
+admin
+
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr
+
+2.0.10
+
+provided
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr.annotations
+
+1.9.6
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.sling
+org.apache.sling.engine
+2.4.6
+provided
+
+
+
+javax.servlet
+servlet-api
+2.5
+provided
+
+
+org.osgi
+org.osgi.compendium
+4.2.0
+provided
+
+
+org.osgi
+org.osgi.core
+4.2.0
+provided
+
+
+javax.jcr
+jcr
+2.0
+provided
+
+
+org.apache.sling
+org.apache.sling.api
+2.9.0
+provided
+
+
+org.slf4j
+slf4j-api
+1.7.6
+provided
+
+
+org.osgi
+org.osgi.annotation.versioning
+1.0.0
+provided
+
+
+org.osgi
+org.osgi.service.component.annotations
+1.3.0
 
 Review comment:
   The version will not be needed once you inherit from the Sling parent pom.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522526
 
 

 ##
 File path: oidc-handler/ui/pom.xml
 ##
 @@ -0,0 +1,191 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+ui
 
 Review comment:
   We prefix the artifactId with org.apache.sling . And since the artifact id 
becomes the Bundle-SymbolicName and therefore should be representative of that 
the bundle does it should also probably include auth and/or oidc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190521558
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.7.0
+
+8
+8
+
+
+
+org.apache.sling
+maven-sling-plugin
+2.3.4
+
+http://localhost:8080/system/console
+admin
+admin
+
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr
+
+2.0.10
+
+provided
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr.annotations
+
+1.9.6
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.sling
+org.apache.sling.engine
+2.4.6
+provided
+
+
+
+javax.servlet
+servlet-api
+2.5
+provided
+
+
+org.osgi
+org.osgi.compendium
+4.2.0
+provided
+
+
+org.osgi
+org.osgi.core
+4.2.0
+provided
+
+
+javax.jcr
+jcr
+2.0
+provided
+
+
+org.apache.sling
+org.apache.sling.api
+2.9.0
+provided
+
+
+org.slf4j
+slf4j-api
+1.7.6
+provided
+
+
+org.osgi
+org.osgi.annotation.versioning
+1.0.0
+provided
+
+
+org.osgi
+org.osgi.service.component.annotations
+1.3.0
+provided
+
+
+org.osgi
+org.osgi.service.metatype.annotations
+1.3.0
+provided
+
+
+junit
+junit
+4.12
+test
+
+
+
+
+autoInstallBundle
+
+
+
+org.apache.sling
+maven-sling-plugin
+
+
+install-bundle
+
+install
+
+
+
+
+
+
+
+
+
+

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520623
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.7.0
+
+8
+8
+
+
+
+org.apache.sling
+maven-sling-plugin
+2.3.4
+
+http://localhost:8080/system/console
+admin
+admin
+
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr
+
+2.0.10
+
+provided
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr.annotations
+
+1.9.6
+
+
+
+
+
+
+
+
+
+
+
+
 
 Review comment:
   You probably don't need this right now (not 100% sure).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518810
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.7.0
+
+8
+8
+
+
+
+org.apache.sling
+maven-sling-plugin
+2.3.4
+
+http://localhost:8080/system/console
+admin
+admin
+
+
+
+
+
+
+
+
+org.apache.felix
 
 Review comment:
   Not needed if you inherit from the sling parent pom.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518767
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.7.0
+
+8
+8
+
+
+
 
 Review comment:
   Not needed if you inherit from the sling parent pom.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520244
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.7.0
+
+8
+8
+
+
+
+org.apache.sling
+maven-sling-plugin
+2.3.4
+
+http://localhost:8080/system/console
+admin
+admin
+
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr
+
+2.0.10
+
+provided
+
+
+
+
+
+
+
+org.apache.felix
 
 Review comment:
   You should use the new OSGi annotations instead of the old ones from Apache 
Felix. These were created while we waited for an official solution from the 
OSGi alliance. 
   
   The artifacts you can use (for instance) 
https://github.com/apache/sling-org-apache-sling-commons-html/blob/e9ffa3b09a170492258a8513ac0caaac8432caba/pom.xml#L106-L115


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518465
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 
 Review comment:
   This should also be removed. The bnd plugin will generate the OSGi metadata


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518373
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
 
 Review comment:
   This plugin should be removed altogether, the bnd plugin will take care of 
all the OSGi-related metadata.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522352
 
 

 ##
 File path: oidc-handler/ui/pom.xml
 ##
 @@ -0,0 +1,191 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
 
 Review comment:
   Please use the Sling parent pom.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190523934
 
 

 ##
 File path: 
oidc-handler/ui/src/main/resources/SLING-INF/content/my-first-node.xml
 ##
 @@ -0,0 +1,42 @@
+
 
 Review comment:
   This is not referenced anywhere, I don't think you need it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518625
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
 
 Review comment:
   If you inherit from the sling parent pom _and_ add a `bnd.bnd` file, this 
plugin configuration will not be necessary. A module with a `bnd.bnd` file is 
https://github.com/apache/sling-org-apache-sling-commons-html.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190521759
 
 

 ##
 File path: 
oidc-handler/core/src/main/java/org/apache/sling/oidchandler/core/SimpleDSComponent.java
 ##
 @@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.oidchandler.core;
+
+
+import org.osgi.framework.BundleContext;
+import org.osgi.service.component.ComponentContext;
+import org.osgi.service.component.annotations.Component;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * A simple DS component which is executed every 10 seconds
 
 Review comment:
   This component seems to be just for testing, I don't think it should be 
included in the PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520925
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.7.0
+
+8
+8
+
+
+
+org.apache.sling
+maven-sling-plugin
+2.3.4
+
+http://localhost:8080/system/console
+admin
+admin
+
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr
+
+2.0.10
+
+provided
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr.annotations
+
+1.9.6
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.sling
+org.apache.sling.engine
+2.4.6
+provided
+
+
+
+javax.servlet
+servlet-api
+2.5
+provided
+
+
+org.osgi
+org.osgi.compendium
+4.2.0
 
 Review comment:
   Please see the sling parent pom for a more recent version of this artifact. 
IIRC the artifactId has also changed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190521501
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.7.0
+
+8
+8
+
+
+
+org.apache.sling
+maven-sling-plugin
+2.3.4
+
+http://localhost:8080/system/console
+admin
+admin
+
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr
+
+2.0.10
+
+provided
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr.annotations
+
+1.9.6
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.sling
+org.apache.sling.engine
+2.4.6
+provided
+
+
+
+javax.servlet
+servlet-api
+2.5
+provided
+
+
+org.osgi
+org.osgi.compendium
+4.2.0
+provided
+
+
+org.osgi
+org.osgi.core
+4.2.0
+provided
+
+
+javax.jcr
+jcr
+2.0
+provided
+
+
+org.apache.sling
+org.apache.sling.api
+2.9.0
+provided
+
+
+org.slf4j
+slf4j-api
+1.7.6
+provided
+
+
+org.osgi
+org.osgi.annotation.versioning
+1.0.0
+provided
+
+
+org.osgi
+org.osgi.service.component.annotations
+1.3.0
+provided
+
+
+org.osgi
+org.osgi.service.metatype.annotations
+1.3.0
+provided
+
+
+junit
+junit
+4.12
+test
+
+
+
 
 Review comment:
   The profile will not be needed once you inherit from the Sling parent pom.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190523798
 
 

 ##
 File path: 
oidc-handler/ui/src/main/resources/SLING-INF/content/login/login.html
 ##
 @@ -0,0 +1,56 @@
+
 
 Review comment:
   This seems to have lots of extra classes which are referenced but not added 
to the page. I suggest that you start with a minimal page with no extra markup, 
we can take care of styling it later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190524124
 
 

 ##
 File path: oidc-handler/ui/src/main/resources/SLING-INF/scripts/html.esp
 ##
 @@ -0,0 +1,37 @@
+
 
 Review comment:
   This is not used anywhere so you can remove it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522141
 
 

 ##
 File path: oidc-handler/pom.xml
 ##
 @@ -1,11 +1,35 @@
 
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+  org.apache.sling
+  org.apache.sling.oidchandler
 
 Review comment:
   I think the artifactId should include 'auth' somewhere, to fall in line with 
our other modules: auth-core, auth-form, auth-xing-oauth. Same goes for the 
name.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190523010
 
 

 ##
 File path: oidc-handler/ui/pom.xml
 ##
 @@ -0,0 +1,191 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+ui
+1.0.0-SNAPSHOT
+ui
+org.apache.sling - ui
+
+
+
+
+org.apache.felix
+maven-scr-plugin
+
+
+org.apache.felix
+maven-bundle-plugin
+true
+
+
+
SLING-INF
+
+
+
+
+
+
+
+
+
+org.apache.maven.plugins
+maven-javadoc-plugin
+
+
org.apache.sling.oidchandler
+
+
+
+
+
+
+
+org.apache.sling
+org.apache.sling.api
+2.0.2-incubator
+provided
+
+
+org.apache.sling
+org.apache.sling.jcr.api
+2.0.2-incubator
+provided
+
+
+org.apache.felix
+org.osgi.compendium
+1.4.0
+provided
+
+
+org.apache.felix
+org.osgi.core
+1.4.0
+provided
+
+
+org.slf4j
+slf4j-api
+1.7.25
+provided
+
+
+
+
+
 
 Review comment:
   Please remove all commented-out code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522800
 
 

 ##
 File path: oidc-handler/ui/pom.xml
 ##
 @@ -0,0 +1,191 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+ui
+1.0.0-SNAPSHOT
+ui
+org.apache.sling - ui
+
+
+
+
 
 Review comment:
   This plugin is not needed for content projects.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190517700
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
 
 Review comment:
   We prefix the artifactId with `org.apache.sling` . And since the artifact id 
becomes the Bundle-SymbolicName and therefore should be representative of that 
the bundle does it should also probably include `auth` and/or `oidc`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518098
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
 
 Review comment:
   Unless you have something extra to add here you can probably remove this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518013
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
 
 Review comment:
   This should be "Apache Sling ..." where ... should be replaced by a compact 
name , for instance we have "Apache Sling Commons Log"


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520946
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.7.0
+
+8
+8
+
+
+
+org.apache.sling
+maven-sling-plugin
+2.3.4
+
+http://localhost:8080/system/console
+admin
+admin
+
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr
+
+2.0.10
+
+provided
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr.annotations
+
+1.9.6
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.sling
+org.apache.sling.engine
+2.4.6
+provided
+
+
+
+javax.servlet
+servlet-api
+2.5
+provided
+
+
+org.osgi
+org.osgi.compendium
+4.2.0
+provided
+
+
+org.osgi
 
 Review comment:
   Please see the sling parent pom for a more recent version of this artifact. 
IIRC the artifactId has also changed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190517370
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
 
 Review comment:
   I suggest you use the 'sling' parent pom, this will allow you to remove 
quite a number of extra configurations from the POM file. You can keep the 
reactor pom below 
https://github.com/apache/sling-whiteboard/blob/master/oidc-handler/pom.xml, 
but that one will only have the `` entry.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518736
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
 
 Review comment:
   Not needed if you inherit from the sling parent pom.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522269
 
 

 ##
 File path: oidc-handler/pom.xml
 ##
 @@ -1,11 +1,35 @@
 
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+  org.apache.sling
+  org.apache.sling.oidchandler
+  1.0.0-SNAPSHOT
+  pom
+  org.apache.sling.oidchandler
 
-http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  
+admin
+admin
+  
 
-4.0.0
-org.apache.sling
-org.apache.sling.oidchandler
-1.0-SNAPSHOT
+
 
 Review comment:
   You won't the build section anymore, this will be just a 'reactor' project.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522720
 
 

 ##
 File path: oidc-handler/ui/pom.xml
 ##
 @@ -0,0 +1,191 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+ui
+1.0.0-SNAPSHOT
+ui
+org.apache.sling - ui
 
 Review comment:
   Unless you have something extra to add here you can probably remove this.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190521339
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.7.0
+
+8
+8
+
+
+
+org.apache.sling
+maven-sling-plugin
+2.3.4
+
+http://localhost:8080/system/console
+admin
+admin
+
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr
+
+2.0.10
+
+provided
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr.annotations
+
+1.9.6
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.sling
+org.apache.sling.engine
+2.4.6
+provided
+
+
+
+javax.servlet
+servlet-api
+2.5
+provided
+
+
+org.osgi
+org.osgi.compendium
+4.2.0
+provided
+
+
+org.osgi
+org.osgi.core
+4.2.0
+provided
+
+
+javax.jcr
+jcr
+2.0
+provided
+
+
+org.apache.sling
+org.apache.sling.api
+2.9.0
+provided
+
+
+org.slf4j
+slf4j-api
+1.7.6
+provided
+
+
+org.osgi
+org.osgi.annotation.versioning
+1.0.0
 
 Review comment:
   You should not need this now - see 
https://osgi.org/javadoc/r6/annotation/index.html for details on what they do.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r19053
 
 

 ##
 File path: oidc-handler/pom.xml
 ##
 @@ -1,11 +1,35 @@
 
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+  org.apache.sling
+  org.apache.sling.oidchandler
+  1.0.0-SNAPSHOT
+  pom
+  org.apache.sling.oidchandler
 
-http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  
 
 Review comment:
   You won't need these anymore, this will be just a 'reactor' project.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190521457
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.7.0
+
+8
+8
+
+
+
+org.apache.sling
+maven-sling-plugin
+2.3.4
+
+http://localhost:8080/system/console
+admin
+admin
+
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr
+
+2.0.10
+
+provided
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr.annotations
+
+1.9.6
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.sling
+org.apache.sling.engine
+2.4.6
+provided
+
+
+
+javax.servlet
+servlet-api
+2.5
+provided
+
+
+org.osgi
+org.osgi.compendium
+4.2.0
+provided
+
+
+org.osgi
+org.osgi.core
+4.2.0
+provided
+
+
+javax.jcr
+jcr
+2.0
+provided
+
+
+org.apache.sling
+org.apache.sling.api
+2.9.0
+provided
+
+
+org.slf4j
+slf4j-api
+1.7.6
+provided
+
+
+org.osgi
+org.osgi.annotation.versioning
+1.0.0
+provided
+
+
+org.osgi
+org.osgi.service.component.annotations
+1.3.0
+provided
+
+
+org.osgi
+org.osgi.service.metatype.annotations
+1.3.0
 
 Review comment:
   The version will not be needed once you inherit from the Sling parent pom.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522618
 
 

 ##
 File path: oidc-handler/ui/pom.xml
 ##
 @@ -0,0 +1,191 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+ui
+1.0.0-SNAPSHOT
+ui
 
 Review comment:
   This should be "Apache Sling ..." where ... should be replaced by a compact 
name , for instance we have "Apache Sling Commons Log"
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on a change in pull request #14: First commit for oidc 
handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520558
 
 

 ##
 File path: oidc-handler/core/pom.xml
 ##
 @@ -0,0 +1,283 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+4.0.0
+
+org.apache.sling.oidchandler
+org.apache.sling
+1.0.0-SNAPSHOT
+  
+org.apache.sling
+core
+1.0.0-SNAPSHOT
+core
+org.apache.sling - core
+
+
+
+biz.aQute.bnd
+bnd-maven-plugin
+3.5.0
+
+
+run-bnd
+
+bnd-process
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-scr-plugin
+
+1.20.0
+
+
+
+
+
+generate-scr-scrdescriptor
+
+
+
+scr
+
+
+
+
+
+
+
+
+
+Adobe
+
+
+
+
+
+
+
+
+
+
+
+
${project.build.directory}/classes
+
+
+
+
+
+
+
+org.slf4j
+
+slf4j-simple
+
+1.5.11
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+org.apache.felix
+
+maven-bundle-plugin
+
+2.5.3
+
+true
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+2.6
+
+
+
${project.build.outputDirectory}/META-INF/MANIFEST.MF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.7.0
+
+8
+8
+
+
+
+org.apache.sling
+maven-sling-plugin
+2.3.4
+
+http://localhost:8080/system/console
+admin
+admin
+
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr
+
+2.0.10
+
+provided
+
+
+
+
+
+
+
+org.apache.felix
+
+org.apache.felix.scr.annotations
+
+1.9.6
+
+
+
+
 
 Review comment:
   Please remove commented out code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on issue #14: First commit for oidc handler.

2018-05-24 Thread GitBox

rombert commented on issue #14: First commit for oidc handler.
URL: https://github.com/apache/sling-whiteboard/pull/14#issuecomment-391646435
 
 
   Thanks for the pull request @hasinidilanka , great to see this advancing! I 
will add some inline comments soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-2463) Sling Script Console Plugin

2018-05-24 Thread Bertrand Delacretaz (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-2463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488665#comment-16488665
 ] 

Bertrand Delacretaz commented on SLING-2463:


Thanks Chetan, I forgot about that. I have now updated 
[https://github.com/apache/sling-org-apache-sling-scripting-console/blob/master/README.md]
 to point to the Felix module.

> Sling Script Console Plugin
> ---
>
> Key: SLING-2463
> URL: https://issues.apache.org/jira/browse/SLING-2463
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Reporter: Chetan Mehrotra
>Assignee: Felix Meschberger
>Priority: Minor
> Attachments: script-console.patch
>
>
> I have implemented a Felix WebConsole plugin for evaluating scripts making 
> use of existing infrastructure present in Sling. It provides support for 
> following items
> * Support evaluation of script in any language as supported by Sling e.g. 
> Groovy, JavaScript, Ruby, Python etc. You would need to ensure that relevant 
> language bundle is deployed
> * Code editor with syntax highlighting support based on CodeMirror Javascript 
> library
> * Hot key support
> * Execute remote testcase via evaluating test scripts
> The code is pushed to my forked Git repo for Sling at [1]. Complete details 
> about the plugin (with screen shots) is provided at [2].
> Comments and feedback welcome!!
> [1] https://github.com/chetanmeh/sling/tree/script-console
> [2] https://github.com/chetanmeh/c/wiki/Sling-Script-Console 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] hasinidilanka opened a new pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox

hasinidilanka opened a new pull request #14: First commit for oidc handler.
URL: https://github.com/apache/sling-whiteboard/pull/14
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (SLING-7677) FeatureJSONWriter uses isOptional instead of isRequired

2018-05-24 Thread David Bosschaert (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert resolved SLING-7677.
-
   Resolution: Fixed
Fix Version/s: Feature Model IO 0.1.2

Thanks for your fix and unit test [~andrei.tuicu]! I've merged your branch to 
main.

> FeatureJSONWriter uses isOptional instead of isRequired
> ---
>
> Key: SLING-7677
> URL: https://issues.apache.org/jira/browse/SLING-7677
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model IO 0.1.0
>Reporter: Andrei Tuicu
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Feature Model IO 0.1.2
>
>
> FeatureJSONWriter uses isOptional instead of isRequired.
> [https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/main/java/org/apache/sling/feature/io/json/JSONWriterBase.java#L221]
>  .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7677) FeatureJSONWriter uses isOptional instead of isRequired

2018-05-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488647#comment-16488647
 ] 

ASF GitHub Bot commented on SLING-7677:
---

bosschaert closed pull request #1: SLING-7677 - FeatureJSONWriter uses 
isOptional instead of isRequired
URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/main/java/org/apache/sling/feature/io/json/JSONWriterBase.java 
b/src/main/java/org/apache/sling/feature/io/json/JSONWriterBase.java
index cfb6d9b..388bc69 100644
--- a/src/main/java/org/apache/sling/feature/io/json/JSONWriterBase.java
+++ b/src/main/java/org/apache/sling/feature/io/json/JSONWriterBase.java
@@ -218,7 +218,7 @@ protected void writeExtensions(final JsonObjectBuilder ob,
 final List extensions,
 final Configurations allConfigs) {
 for(final Extension ext : extensions) {
-final String key = ext.getName() + ":" + ext.getType().name() + 
"|" + ext.isOptional();
+final String key = ext.getName() + ":" + ext.getType().name() + 
"|" + ext.isRequired();
 if ( ext.getType() == ExtensionType.JSON ) {
 final JsonStructure struct;
 try ( final StringReader reader = new 
StringReader(ext.getJSON()) ) {
diff --git 
a/src/test/java/org/apache/sling/feature/io/json/ArtifactsExtensions.java 
b/src/test/java/org/apache/sling/feature/io/json/ArtifactsExtensions.java
new file mode 100644
index 000..bdd34f1
--- /dev/null
+++ b/src/test/java/org/apache/sling/feature/io/json/ArtifactsExtensions.java
@@ -0,0 +1,56 @@
+package org.apache.sling.feature.io.json;
+
+import org.apache.sling.feature.ArtifactId;
+import org.apache.sling.feature.Extension;
+import org.apache.sling.feature.Extensions;
+import org.apache.sling.feature.Feature;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+public class ArtifactsExtensions {
+
+public static void testReadArtifactsExtensions(Feature feature) {
+Extensions extensions = feature.getExtensions();
+
+assertEquals(2, extensions.size());
+
+Extension extension1 = extensions.getByName("my-extension1");
+assertNotNull(extension1);
+assertEquals(extension1.getName(), "my-extension1");
+assertEquals(extension1.isRequired(), false);
+assertEquals(1, extension1.getArtifacts().size());
+
+ArtifactId artifactId1 = extension1.getArtifacts().get(0).getId();
+assertEquals(artifactId1.getGroupId(), "org.apache.sling");
+assertEquals(artifactId1.getArtifactId(), "my-extension1");
+assertEquals(artifactId1.getVersion(), "1.2.3");
+
+Extension extension2 = extensions.getByName("my-extension2");
+assertNotNull(extension2);
+assertEquals(extension2.getName(), "my-extension2");
+assertEquals(extension2.isRequired(), true);
+assertEquals(1, extension2.getArtifacts().size());
+
+ArtifactId artifactId2 = extension2.getArtifacts().get(0).getId();
+assertEquals(artifactId2.getGroupId(), "org.apache.sling");
+assertEquals(artifactId2.getArtifactId(), "my-extension2");
+assertEquals(artifactId2.getVersion(), "1.2.3");
+}
+}
diff --git 
a/src/test/java/org/apache/sling/feature/io/json/FeatureJSONReaderTest.java 
b/src/test/java/org/apache/sling/feature/io/json/FeatureJSONReaderTest.java
index 6acd293..aa7559c 100644
--- a/src/test/java/org/apache/sling/feature/io/json/FeatureJSONReaderTest.java
+++ b/src/test/java/org/apache/sling/feature/io/json/FeatureJSONReaderTest.java
@@ -213,6 +213,11 @@
 }
 }
 
+@Test public void testReadArtifactsExtensions() throws Exception {
+final Feature feature = U.readFeature("artifacts-extension", 
SubstituteVariables.NONE);
+

[jira] [Commented] (SLING-7677) FeatureJSONWriter uses isOptional instead of isRequired

2018-05-24 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488648#comment-16488648
 ] 

ASF GitHub Bot commented on SLING-7677:
---

bosschaert commented on issue #1: SLING-7677 - FeatureJSONWriter uses 
isOptional instead of isRequired
URL: 
https://github.com/apache/sling-org-apache-sling-feature-io/pull/1#issuecomment-391633367
 
 
   Thanks for your contribution, JIRA and tests @andreituicu ! I've applied 
your changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FeatureJSONWriter uses isOptional instead of isRequired
> ---
>
> Key: SLING-7677
> URL: https://issues.apache.org/jira/browse/SLING-7677
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model IO 0.1.0
>Reporter: Andrei Tuicu
>Assignee: David Bosschaert
>Priority: Major
>
> FeatureJSONWriter uses isOptional instead of isRequired.
> [https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/main/java/org/apache/sling/feature/io/json/JSONWriterBase.java#L221]
>  .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] bosschaert closed pull request #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired

2018-05-24 Thread GitBox

bosschaert closed pull request #1: SLING-7677 - FeatureJSONWriter uses 
isOptional instead of isRequired
URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/main/java/org/apache/sling/feature/io/json/JSONWriterBase.java 
b/src/main/java/org/apache/sling/feature/io/json/JSONWriterBase.java
index cfb6d9b..388bc69 100644
--- a/src/main/java/org/apache/sling/feature/io/json/JSONWriterBase.java
+++ b/src/main/java/org/apache/sling/feature/io/json/JSONWriterBase.java
@@ -218,7 +218,7 @@ protected void writeExtensions(final JsonObjectBuilder ob,
 final List extensions,
 final Configurations allConfigs) {
 for(final Extension ext : extensions) {
-final String key = ext.getName() + ":" + ext.getType().name() + 
"|" + ext.isOptional();
+final String key = ext.getName() + ":" + ext.getType().name() + 
"|" + ext.isRequired();
 if ( ext.getType() == ExtensionType.JSON ) {
 final JsonStructure struct;
 try ( final StringReader reader = new 
StringReader(ext.getJSON()) ) {
diff --git 
a/src/test/java/org/apache/sling/feature/io/json/ArtifactsExtensions.java 
b/src/test/java/org/apache/sling/feature/io/json/ArtifactsExtensions.java
new file mode 100644
index 000..bdd34f1
--- /dev/null
+++ b/src/test/java/org/apache/sling/feature/io/json/ArtifactsExtensions.java
@@ -0,0 +1,56 @@
+package org.apache.sling.feature.io.json;
+
+import org.apache.sling.feature.ArtifactId;
+import org.apache.sling.feature.Extension;
+import org.apache.sling.feature.Extensions;
+import org.apache.sling.feature.Feature;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+public class ArtifactsExtensions {
+
+public static void testReadArtifactsExtensions(Feature feature) {
+Extensions extensions = feature.getExtensions();
+
+assertEquals(2, extensions.size());
+
+Extension extension1 = extensions.getByName("my-extension1");
+assertNotNull(extension1);
+assertEquals(extension1.getName(), "my-extension1");
+assertEquals(extension1.isRequired(), false);
+assertEquals(1, extension1.getArtifacts().size());
+
+ArtifactId artifactId1 = extension1.getArtifacts().get(0).getId();
+assertEquals(artifactId1.getGroupId(), "org.apache.sling");
+assertEquals(artifactId1.getArtifactId(), "my-extension1");
+assertEquals(artifactId1.getVersion(), "1.2.3");
+
+Extension extension2 = extensions.getByName("my-extension2");
+assertNotNull(extension2);
+assertEquals(extension2.getName(), "my-extension2");
+assertEquals(extension2.isRequired(), true);
+assertEquals(1, extension2.getArtifacts().size());
+
+ArtifactId artifactId2 = extension2.getArtifacts().get(0).getId();
+assertEquals(artifactId2.getGroupId(), "org.apache.sling");
+assertEquals(artifactId2.getArtifactId(), "my-extension2");
+assertEquals(artifactId2.getVersion(), "1.2.3");
+}
+}
diff --git 
a/src/test/java/org/apache/sling/feature/io/json/FeatureJSONReaderTest.java 
b/src/test/java/org/apache/sling/feature/io/json/FeatureJSONReaderTest.java
index 6acd293..aa7559c 100644
--- a/src/test/java/org/apache/sling/feature/io/json/FeatureJSONReaderTest.java
+++ b/src/test/java/org/apache/sling/feature/io/json/FeatureJSONReaderTest.java
@@ -213,6 +213,11 @@
 }
 }
 
+@Test public void testReadArtifactsExtensions() throws Exception {
+final Feature feature = U.readFeature("artifacts-extension", 
SubstituteVariables.NONE);
+ArtifactsExtensions.testReadArtifactsExtensions(feature);
+}
+
 private void setPrivateField(Object obj, String name, Object value) throws 
Exception {
 Field field = obj.getClass().getDeclaredField(name);

[GitHub] bosschaert commented on issue #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired

2018-05-24 Thread GitBox

bosschaert commented on issue #1: SLING-7677 - FeatureJSONWriter uses 
isOptional instead of isRequired
URL: 
https://github.com/apache/sling-org-apache-sling-feature-io/pull/1#issuecomment-391633367
 
 
   Thanks for your contribution, JIRA and tests @andreituicu ! I've applied 
your changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

2018-05-24 Thread Bertrand Delacretaz

On Wed, May 23, 2018 at 5:56 PM, Daniel Klco  wrote:
> ...Shields.io seems to be a pretty common standard for GitHub projects so what
> if we just use these rather than self-hosting?...

Thinking about it, I suggest using both self-hosted and dynamic
badges, for different purposes:

a) Self-hosted SVG badges under http://sling.apache.org/res/badges for
static repository attributes like deprecated, contrib etc.

AFAIK we can copy badges generated at http://shields.io/ there, that
website doesn't seem to have any usage restrictions.

Having well-known URLs that we control for those makes sure they are
consistent and allows us to detect them in scripts. The
http://sling.apache.org/repolist.html page for example can be improved
to include the badges by parsing the modules README files for badges
based on those well-known URLs. And the downloads page could also use
that maybe instead of duplicating information by splitting modules in
lists.

b) Dynamic badges for build results etc., things that are not static
attributes of the code repositories

WDYT?

[jira] [Assigned] (SLING-7677) FeatureJSONWriter uses isOptional instead of isRequired

2018-05-24 Thread David Bosschaert (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert reassigned SLING-7677:
---

Assignee: David Bosschaert

> FeatureJSONWriter uses isOptional instead of isRequired
> ---
>
> Key: SLING-7677
> URL: https://issues.apache.org/jira/browse/SLING-7677
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model IO 0.1.0
>Reporter: Andrei Tuicu
>Assignee: David Bosschaert
>Priority: Major
>
> FeatureJSONWriter uses isOptional instead of isRequired.
> [https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/main/java/org/apache/sling/feature/io/json/JSONWriterBase.java#L221]
>  .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

71 matches

Mail list logo