[jira] [Resolved] (SLING-7750) Stabilize integration tests by waiting for SlingScriptAdapterFactory

2018-06-19 Thread Oliver Lietz (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7750.
-
Resolution: Done

> Stabilize integration tests by waiting for SlingScriptAdapterFactory
> 
>
> Key: SLING-7750
> URL: https://issues.apache.org/jira/browse/SLING-7750
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting Groovy 1.0.4
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7749) Stabilize integration tests by waiting for SlingScriptAdapterFactory

2018-06-19 Thread Oliver Lietz (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7749.
-
Resolution: Done

> Stabilize integration tests by waiting for SlingScriptAdapterFactory
> 
>
> Key: SLING-7749
> URL: https://issues.apache.org/jira/browse/SLING-7749
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting FreeMarker 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-7750) Stabilize integration tests by waiting for SlingScriptAdapterFactory

2018-06-19 Thread Oliver Lietz (JIRA)
Oliver Lietz created SLING-7750:
---

 Summary: Stabilize integration tests by waiting for 
SlingScriptAdapterFactory
 Key: SLING-7750
 URL: https://issues.apache.org/jira/browse/SLING-7750
 Project: Sling
  Issue Type: Improvement
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting Groovy 1.0.4






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-7749) Stabilize integration tests by waiting for SlingScriptAdapterFactory

2018-06-19 Thread Oliver Lietz (JIRA)
Oliver Lietz created SLING-7749:
---

 Summary: Stabilize integration tests by waiting for 
SlingScriptAdapterFactory
 Key: SLING-7749
 URL: https://issues.apache.org/jira/browse/SLING-7749
 Project: Sling
  Issue Type: Improvement
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting FreeMarker 1.0.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-7748) Value of Month from jcr:lastModified is INCORRECT when org.apache.sling.api.resource.Resource.getValueMap() is used

2018-06-19 Thread Suren Konathala (JIRA)
Suren Konathala created SLING-7748:
--

 Summary: Value of Month from jcr:lastModified is INCORRECT when 
org.apache.sling.api.resource.Resource.getValueMap() is used
 Key: SLING-7748
 URL: https://issues.apache.org/jira/browse/SLING-7748
 Project: Sling
  Issue Type: Bug
  Components: API
Affects Versions: API 2.16.2
Reporter: Suren Konathala
 Attachments: Screen Shot 2018-06-19 at 4.09.38 PM.png, Screen Shot 
2018-06-19 at 4.09.56 PM.png

When using *org.apache.sling.api.resource.Resource* , the method *getValueMap 
(* 
[https://sling.apache.org/apidocs/sling9/org/apache/sling/api/resource/Resource.html#getValueMap--]
 ), returns a ValueMap of all the properties. 

We observed that the "*month*" in "*jcr:lastModified*" is off by 1 month. While 
Year, Day, Hour, Min, Seconds are all correct. Please see the attachments. And 
this is the same for all Nodes.

The last date modified was 
"2018-*{color:#d04437}05{color}*-29T10:31:49.123-05:00" while the value from 
the above method returned as below:

{color:#33}jcr:lastModified\"{\"year\":2018,*{color:#d04437}\"month\":4,\{color}*"dayOfMonth\":29,\"hourOfDay\":10,\"minute\":31,\"second\":49}{color}

We did not test this on all nodes though.

 

Sample code:
{code:java}
Resource jcrdataResource = resource.getChild("jcr:content");
ValueMap jcrProperties = ResourceUtil.getValueMap(jcrdataResource);
{code}
 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: JBake Build has error java.lang.ArrayIndexOutOfBoundsException: 3 for downloads.html

2018-06-19 Thread Oliver Lietz
On Tuesday 19 June 2018 16:44:35 Konrad Windszus wrote:
> When building locally the Sling Site I get the following error:
> 
> ...
> [ERROR] Rendering
> [/Users/konradwindszus/git/sling-site/target/sling-site-0.1-SNAPSHOT/downlo
> ads.html]... failed! org.jbake.template.RenderingException:
> java.lang.ArrayIndexOutOfBoundsException: 3 at
> org.jbake.template.GroovyMarkupTemplateEngine.renderDocument
> (GroovyMarkupTemplateEngine.java:53) at
> org.jbake.template.DelegatingTemplateEngine.renderDocument
> (DelegatingTemplateEngine.java:65) at org.jbake.app.Renderer.render
> (Renderer.java:209)
> at org.jbake.render.DocumentsRenderer.render (DocumentsRenderer.java:25)
> at org.jbake.app.Oven.bake (Oven.java:151)
> at org.jbake.maven.GenerateMojo.reRender (GenerateMojo.java:95)
> at org.jbake.maven.WatchMojo.executeInternal (WatchMojo.java:87)
> at org.jbake.maven.GenerateMojo.execute (GenerateMojo.java:67)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:134) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:208) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:154) at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:146) at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117) at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81) at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBu
> ilder.build (SingleThreadedBuilder.java:51) at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute
> (DefaultMaven.java:309) at org.apache.maven.DefaultMaven.doExecute
> (DefaultMaven.java:194) at org.apache.maven.DefaultMaven.execute
> (DefaultMaven.java:107) at org.apache.maven.cli.MavenCli.execute
> (MavenCli.java:955)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62) at
> sun.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke
> (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:289) at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:229) at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:415) at
> org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 3
> at org.codehaus.groovy.runtime.BytecodeInterface8.objectArrayGet
> (BytecodeInterface8.java:363) at
> downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12$_closure31
> $_closure32$_closure33.doCall (downloads.tpl:389) at
> downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12$_closure31
> $_closure32$_closure33.call (downloads.tpl) at
> groovy.text.markup.BaseTemplate.writeBody (BaseTemplate.java:277) at
> groovy.text.markup.BaseTemplate.methodMissing (BaseTemplate.java:253) at
> downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12$_closure31
> $_closure32.doCall (downloads.tpl) at
> downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12$_closure31
> $_closure32.call (downloads.tpl) at
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each
> (DefaultGroovyMethods.java:2040) at
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each
> (DefaultGroovyMethods.java:2025) at
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each
> (DefaultGroovyMethods.java:2066) at
> downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12$_closure31
> .doCall (downloads.tpl:384) at
> downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12$_closure31
> .call (downloads.tpl) at groovy.text.markup.BaseTemplate.writeBody
> (BaseTemplate.java:277) at groovy.text.markup.BaseTemplate.methodMissing
> (BaseTemplate.java:253) at
> downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12.doCall
> (downloads.tpl:382) at
> downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12.call
> (downloads.tpl) at groovy.text.markup.BaseTemplate.writeBody
> (BaseTemplate.java:277) at groovy.text.markup.BaseTemplate.methodMissing
> (BaseTemplate.java:253) at
> downloads$_run_closure3$_closure5$_closure6$_closure7.doCall
> (downloads.tpl:380) at
> downloads$_run_closure3$_closure5$_closure6$_closure7.call (downloads.tpl)
> at groovy.text.markup.BaseTemplate.writeBody (BaseTemplate.java:277) at
> groovy.text.markup.BaseTemplate.methodMissing (BaseTemplate.java:253) at
> downloads$_run_closure3$_closure5$_closure6.doCall (downloads.tpl) at
> 

[jira] [Closed] (SLING-7624) Add OSGi7 component property annotations for Servlet and Filter

2018-06-19 Thread Konrad Windszus (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-7624.
--

> Add OSGi7 component property annotations for Servlet and Filter
> ---
>
> Key: SLING-7624
> URL: https://issues.apache.org/jira/browse/SLING-7624
> Project: Sling
>  Issue Type: New Feature
>  Components: Servlets
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Servlet Annotations 1.0.0
>
>
> Previously there were annotations hosted at Felix for Sling Servlets/Filters 
> as custom Felix SCR annotations 
> (https://github.com/apache/felix/tree/trunk/tools/org.apache.felix.scr.annotations/src/main/java/org/apache/felix/scr/annotations/sling).
>  With OSGi R7 and DS 1.4 component property annotations are specified. Sling 
> should provide those annotations in a dedicated new artifact. Compare also 
> with FELIX-5396.
> Those are supported in the upcoming bnd 4.0 
> (https://github.com/bndtools/bnd/issues/2163).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


JBake Build has error java.lang.ArrayIndexOutOfBoundsException: 3 for downloads.html

2018-06-19 Thread Konrad Windszus
When building locally the Sling Site I get the following error:

...
[ERROR] Rendering 
[/Users/konradwindszus/git/sling-site/target/sling-site-0.1-SNAPSHOT/downloads.html]...
 failed!
org.jbake.template.RenderingException: 
java.lang.ArrayIndexOutOfBoundsException: 3
at org.jbake.template.GroovyMarkupTemplateEngine.renderDocument 
(GroovyMarkupTemplateEngine.java:53)
at org.jbake.template.DelegatingTemplateEngine.renderDocument 
(DelegatingTemplateEngine.java:65)
at org.jbake.app.Renderer.render (Renderer.java:209)
at org.jbake.render.DocumentsRenderer.render (DocumentsRenderer.java:25)
at org.jbake.app.Oven.bake (Oven.java:151)
at org.jbake.maven.GenerateMojo.reRender (GenerateMojo.java:95)
at org.jbake.maven.WatchMojo.executeInternal (WatchMojo.java:87)
at org.jbake.maven.GenerateMojo.execute (GenerateMojo.java:67)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:134)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:51)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:356)
Caused by: java.lang.ArrayIndexOutOfBoundsException: 3
at org.codehaus.groovy.runtime.BytecodeInterface8.objectArrayGet 
(BytecodeInterface8.java:363)
at 
downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12$_closure31$_closure32$_closure33.doCall
 (downloads.tpl:389)
at 
downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12$_closure31$_closure32$_closure33.call
 (downloads.tpl)
at groovy.text.markup.BaseTemplate.writeBody (BaseTemplate.java:277)
at groovy.text.markup.BaseTemplate.methodMissing (BaseTemplate.java:253)
at 
downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12$_closure31$_closure32.doCall
 (downloads.tpl)
at 
downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12$_closure31$_closure32.call
 (downloads.tpl)
at org.codehaus.groovy.runtime.DefaultGroovyMethods.each 
(DefaultGroovyMethods.java:2040)
at org.codehaus.groovy.runtime.DefaultGroovyMethods.each 
(DefaultGroovyMethods.java:2025)
at org.codehaus.groovy.runtime.DefaultGroovyMethods.each 
(DefaultGroovyMethods.java:2066)
at 
downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12$_closure31.doCall
 (downloads.tpl:384)
at 
downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12$_closure31.call
 (downloads.tpl)
at groovy.text.markup.BaseTemplate.writeBody (BaseTemplate.java:277)
at groovy.text.markup.BaseTemplate.methodMissing (BaseTemplate.java:253)
at downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12.doCall 
(downloads.tpl:382)
at downloads$_run_closure3$_closure5$_closure6$_closure7$_closure12.call 
(downloads.tpl)
at groovy.text.markup.BaseTemplate.writeBody (BaseTemplate.java:277)
at groovy.text.markup.BaseTemplate.methodMissing (BaseTemplate.java:253)
at downloads$_run_closure3$_closure5$_closure6$_closure7.doCall 
(downloads.tpl:380)
at downloads$_run_closure3$_closure5$_closure6$_closure7.call 
(downloads.tpl)
at groovy.text.markup.BaseTemplate.writeBody (BaseTemplate.java:277)
at groovy.text.markup.BaseTemplate.methodMissing (BaseTemplate.java:253)
at downloads$_run_closure3$_closure5$_closure6.doCall (downloads.tpl)
at 

[GitHub] toniedzwiedz commented on issue #5: Feature/stop selector duplication

2018-06-19 Thread GitBox
toniedzwiedz commented on issue #5: Feature/stop selector duplication
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/5#issuecomment-398425159
 
 
   @rombert sounds like a plan. I'll try to update the PR by the end of the 
week.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rombert commented on issue #8: SLING-7544 Make optimized alias lookup non-blocking

2018-06-19 Thread GitBox
rombert commented on issue #8: SLING-7544 Make optimized alias lookup 
non-blocking
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/8#issuecomment-398412803
 
 
   @DominikSuess  - now I think I know what's going on.
   
   I changed the behaviour so that the `initLock` is released when the 
`aliasMap` is populated in an async manner, not when the `doInit` method exits.
   
   The `addResource` method (as intended) waits for the `initLock` to be 
available, and therefore always waits until the initialisation is complete, 
which means that the alias maps are now always populated in the test method you 
added.
   
   So my questions are:
   
   1. Is my change conceptually correct and does it still keep the optimisation?
   2. Do we need to alter the test you added in the last commit, maybe removing 
the `assertNull` call, or can we remove it altogether?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[RESULT] [VOTE] Release Apache Sling Servlet Annotations 1.0.0

2018-06-19 Thread Konrad Windszus
Hi, 
The vote has passed with the following result : 

+1 (binding): Dan, Radu, Robert

I will copy this release to the Sling dist directory and promote the artifacts 
to the central Maven repository.

Thanks for voting,
Konrad





[GitHub] rombert commented on issue #5: Feature/stop selector duplication

2018-06-19 Thread GitBox
rombert commented on issue #5: Feature/stop selector duplication
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/5#issuecomment-398399381
 
 
   The change looks good to me @toniedzwiedz ! I like the way you extracted the 
reusable logic out and made it easily testable, that's always good.
   
   One suggestion that I would make is to move the `UrlBuilder` to an 
implementation package - this way we don't have to bump exported package 
versions and the project version at all. WDYT?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: [VOTE] Release Apache Sling Servlet Annotations 1.0.0

2018-06-19 Thread Robert Munteanu
On Thu, 2018-06-14 at 18:03 +0200, Konrad Windszus wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part


[GitHub] rombert commented on issue #8: SLING-7544 Make optimized alias lookup non-blocking

2018-06-19 Thread GitBox
rombert commented on issue #8: SLING-7544 Make optimized alias lookup 
non-blocking
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/8#issuecomment-398396306
 
 
   @DominikSuess - I am curious to understand why the `assertNull` is there. 
The flow is basically the following:
   
   - initialize map entries (`mapEntries.doInit()`)
   - assert that the entries are not initialized yet
   - add a map entry (`addResource.invoke(mapEntries`...)
   - validate that the map entries contain no alias map for the parent resource 
of the one just added before
   
   I'm curious why you added the null check (last step). Does this break 
anything if we get mappings returned this early? Note that the checks are racy 
- the test seems to assume that the `aliasMap` is not initialized but this may 
not be true due to the async nature.
   
   Obviously this can also be a bug in my refactoring, so I'm eager to 
understand the reason behind this check.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Closed] (SLING-7526) NPE in DefaultThreadPool$LoggingThreadLocalChangeListener.changed

2018-06-19 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-7526.
--

> NPE in DefaultThreadPool$LoggingThreadLocalChangeListener.changed
> -
>
> Key: SLING-7526
> URL: https://issues.apache.org/jira/browse/SLING-7526
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons Threads 3.2.16
> Environment: MacOS, jdk18
> Linux, oracle-jdk18
>Reporter: Krystian Nowak
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Commons Threads 3.2.18
>
>
> Randomly a NullPointerException is happening in 
> _DefaultThreadPool$LoggingThreadLocalChangeListener.changed_:
> {noformat}
> Exception in thread "sling-oak-1" java.lang.NullPointerException
>   at 
> org.apache.sling.commons.threads.impl.DefaultThreadPool$LoggingThreadLocalChangeListener.changed(DefaultThreadPool.java:172)
>   at 
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.changed(ThreadLocalCleaner.java:210)
>   at 
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.diff(ThreadLocalCleaner.java:173)
>   at 
> org.apache.sling.commons.threads.impl.ThreadLocalCleaner.cleanup(ThreadLocalCleaner.java:148)
>   at 
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocals.afterExecute(ThreadPoolExecutorCleaningThreadLocals.java:75)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1157)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-7606) Add missing OSGi capabilities

2018-06-19 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-7606.
--

> Add missing OSGi capabilities
> -
>
> Key: SLING-7606
> URL: https://issues.apache.org/jira/browse/SLING-7606
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons Threads 3.2.18
>
>
> {noformat}
> osgi.service;objectClass=org.apache.sling.commons.threads.ThreadPoolManager   
>   
> osgi.service;objectClass=org.apache.sling.commons.threads.jmx.ThreadPoolMBean
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[RESULT] [VOTE] Release Apache Sling Thread Support 3.2.18

2018-06-19 Thread Robert Munteanu
Hi,

The vote has passed with the following result :

+1 (binding): Oliver Lietz, Konrand Windzus, Radu Cotescu, Daniel Klco
+1 (non-binding): David Bosschaert

I will copy this release to the Sling dist directory and promote the
artifacts to the central Maven repository.

Thanks for voting.

Robert


Re: [VOTE] Release Scripting HTL Compiler 1.0.22-1.4.0, Scripting HTL Java Compiler 1.0.24-1.4.0, Scripting HTL Engine 1.0.54-1.4.0, Scripting HTL Testing Content 1.0.10-1.4.0, Scripting HTL Testing 1

2018-06-19 Thread Robert Munteanu
On Tue, 2018-06-19 at 14:01 +0200, Radu Cotescu wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part


[jira] [Comment Edited] (SLING-7581) Using data-sly-use with two classes with same name will generate uncompilable code

2018-06-19 Thread Radu Cotescu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517003#comment-16517003
 ] 

Radu Cotescu edited comment on SLING-7581 at 6/19/18 12:25 PM:
---

Grrr... Wish I had seen this issue earlier - I've just started a release 
thread. Anyways, releases are cheap so expect a fix next week. :)

 

[~kwin], we don't generate servlets - in the HTL world we call them 
{{RenderUnits}}. Luckily the code change is trivial: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler-java/blob/org.apache.sling.scripting.sightly.compiler.java-1.0.24-1.4.0/src/main/java/org/apache/sling/scripting/sightly/java/compiler/impl/ExpressionTranslator.java#L155


was (Author: radu.cotescu):
Grrr... Wish I had seen this issue earlier - I've just started a release 
thread. Anyways, releases are cheap so expect a fix next week. :)

> Using data-sly-use with two classes with same name will generate uncompilable 
> code
> --
>
> Key: SLING-7581
> URL: https://issues.apache.org/jira/browse/SLING-7581
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Java Compiler 1.0.16
>Reporter: Santiago García Pimentel
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Java Compiler 1.0.26-1.4.0
>
>
> If you have an HTL file with two data-sly-use with classes with the same name 
> HTL will generate a java file which cannot be compiled.
> e.g.
> {code}
> data-sly-use.first="com.adobe.cq.wcm.core.components.models.Page"
> data-sly-use.second="com.client.project.Page"
> {code}
>  
> Will generate
> {code}
> import com.client.project.Page;
> import com.adobe.cq.wcm.core.components.models.Page;
>  ...
>  ...
>  _global_first= renderContext.call("use", Page.class.getName(), obj());
>  _global_second = renderContext.call("use", Page.class.getName(), obj());
> {code} 
> Causing a compilation error as Page is not fully qualified in the code and 
> therefore an ambiguous reference (due to the two imports of same class names)
> This seems to have been introduced by SLING-7205 .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (SLING-7581) Using data-sly-use with two classes with same name will generate uncompilable code

2018-06-19 Thread Radu Cotescu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517003#comment-16517003
 ] 

Radu Cotescu edited comment on SLING-7581 at 6/19/18 12:25 PM:
---

Grrr... Wish I had seen this issue earlier - I've just started a release 
thread. Anyways, releases are cheap so expect a fix next week. :) 

[~kwin], we don't generate servlets - in the HTL world we call them 
{{RenderUnits}}. Luckily the code change is trivial: 
[https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler-java/blob/org.apache.sling.scripting.sightly.compiler.java-1.0.24-1.4.0/src/main/java/org/apache/sling/scripting/sightly/java/compiler/impl/ExpressionTranslator.java#L155]


was (Author: radu.cotescu):
Grrr... Wish I had seen this issue earlier - I've just started a release 
thread. Anyways, releases are cheap so expect a fix next week. :)

 

[~kwin], we don't generate servlets - in the HTL world we call them 
{{RenderUnits}}. Luckily the code change is trivial: 
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler-java/blob/org.apache.sling.scripting.sightly.compiler.java-1.0.24-1.4.0/src/main/java/org/apache/sling/scripting/sightly/java/compiler/impl/ExpressionTranslator.java#L155

> Using data-sly-use with two classes with same name will generate uncompilable 
> code
> --
>
> Key: SLING-7581
> URL: https://issues.apache.org/jira/browse/SLING-7581
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Java Compiler 1.0.16
>Reporter: Santiago García Pimentel
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Java Compiler 1.0.26-1.4.0
>
>
> If you have an HTL file with two data-sly-use with classes with the same name 
> HTL will generate a java file which cannot be compiled.
> e.g.
> {code}
> data-sly-use.first="com.adobe.cq.wcm.core.components.models.Page"
> data-sly-use.second="com.client.project.Page"
> {code}
>  
> Will generate
> {code}
> import com.client.project.Page;
> import com.adobe.cq.wcm.core.components.models.Page;
>  ...
>  ...
>  _global_first= renderContext.call("use", Page.class.getName(), obj());
>  _global_second = renderContext.call("use", Page.class.getName(), obj());
> {code} 
> Causing a compilation error as Page is not fully qualified in the code and 
> therefore an ambiguous reference (due to the two imports of same class names)
> This seems to have been introduced by SLING-7205 .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7581) Using data-sly-use with two classes with same name will generate uncompilable code

2018-06-19 Thread Radu Cotescu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517003#comment-16517003
 ] 

Radu Cotescu commented on SLING-7581:
-

Grrr... Wish I had seen this issue earlier - I've just started a release 
thread. Anyways, releases are cheap so expect a fix next week. :)

> Using data-sly-use with two classes with same name will generate uncompilable 
> code
> --
>
> Key: SLING-7581
> URL: https://issues.apache.org/jira/browse/SLING-7581
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Java Compiler 1.0.16
>Reporter: Santiago García Pimentel
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Java Compiler 1.0.26-1.4.0
>
>
> If you have an HTL file with two data-sly-use with classes with the same name 
> HTL will generate a java file which cannot be compiled.
> e.g.
> {code}
> data-sly-use.first="com.adobe.cq.wcm.core.components.models.Page"
> data-sly-use.second="com.client.project.Page"
> {code}
>  
> Will generate
> {code}
> import com.client.project.Page;
> import com.adobe.cq.wcm.core.components.models.Page;
>  ...
>  ...
>  _global_first= renderContext.call("use", Page.class.getName(), obj());
>  _global_second = renderContext.call("use", Page.class.getName(), obj());
> {code} 
> Causing a compilation error as Page is not fully qualified in the code and 
> therefore an ambiguous reference (due to the two imports of same class names)
> This seems to have been introduced by SLING-7205 .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SLING-7581) Using data-sly-use with two classes with same name will generate uncompilable code

2018-06-19 Thread Radu Cotescu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-7581:
---

Assignee: Radu Cotescu

> Using data-sly-use with two classes with same name will generate uncompilable 
> code
> --
>
> Key: SLING-7581
> URL: https://issues.apache.org/jira/browse/SLING-7581
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Java Compiler 1.0.16
>Reporter: Santiago García Pimentel
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Java Compiler 1.0.26-1.4.0
>
>
> If you have an HTL file with two data-sly-use with classes with the same name 
> HTL will generate a java file which cannot be compiled.
> e.g.
> {code}
> data-sly-use.first="com.adobe.cq.wcm.core.components.models.Page"
> data-sly-use.second="com.client.project.Page"
> {code}
>  
> Will generate
> {code}
> import com.client.project.Page;
> import com.adobe.cq.wcm.core.components.models.Page;
>  ...
>  ...
>  _global_first= renderContext.call("use", Page.class.getName(), obj());
>  _global_second = renderContext.call("use", Page.class.getName(), obj());
> {code} 
> Causing a compilation error as Page is not fully qualified in the code and 
> therefore an ambiguous reference (due to the two imports of same class names)
> This seems to have been introduced by SLING-7205 .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7581) Using data-sly-use with two classes with same name will generate uncompilable code

2018-06-19 Thread Radu Cotescu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-7581:

Fix Version/s: Scripting HTL Java Compiler 1.0.26-1.4.0

> Using data-sly-use with two classes with same name will generate uncompilable 
> code
> --
>
> Key: SLING-7581
> URL: https://issues.apache.org/jira/browse/SLING-7581
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Java Compiler 1.0.16
>Reporter: Santiago García Pimentel
>Priority: Major
> Fix For: Scripting HTL Java Compiler 1.0.26-1.4.0
>
>
> If you have an HTL file with two data-sly-use with classes with the same name 
> HTL will generate a java file which cannot be compiled.
> e.g.
> {code}
> data-sly-use.first="com.adobe.cq.wcm.core.components.models.Page"
> data-sly-use.second="com.client.project.Page"
> {code}
>  
> Will generate
> {code}
> import com.client.project.Page;
> import com.adobe.cq.wcm.core.components.models.Page;
>  ...
>  ...
>  _global_first= renderContext.call("use", Page.class.getName(), obj());
>  _global_second = renderContext.call("use", Page.class.getName(), obj());
> {code} 
> Causing a compilation error as Page is not fully qualified in the code and 
> therefore an ambiguous reference (due to the two imports of same class names)
> This seems to have been introduced by SLING-7205 .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7581) Using data-sly-use with two classes with same name will generate uncompilable code

2018-06-19 Thread Radu Cotescu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-7581:

Affects Version/s: (was: Scripting HTL Compiler 1.0.16)
   Scripting HTL Java Compiler 1.0.16

> Using data-sly-use with two classes with same name will generate uncompilable 
> code
> --
>
> Key: SLING-7581
> URL: https://issues.apache.org/jira/browse/SLING-7581
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Java Compiler 1.0.16
>Reporter: Santiago García Pimentel
>Priority: Major
>
> If you have an HTL file with two data-sly-use with classes with the same name 
> HTL will generate a java file which cannot be compiled.
> e.g.
> {code}
> data-sly-use.first="com.adobe.cq.wcm.core.components.models.Page"
> data-sly-use.second="com.client.project.Page"
> {code}
>  
> Will generate
> {code}
> import com.client.project.Page;
> import com.adobe.cq.wcm.core.components.models.Page;
>  ...
>  ...
>  _global_first= renderContext.call("use", Page.class.getName(), obj());
>  _global_second = renderContext.call("use", Page.class.getName(), obj());
> {code} 
> Causing a compilation error as Page is not fully qualified in the code and 
> therefore an ambiguous reference (due to the two imports of same class names)
> This seems to have been introduced by SLING-7205 .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Copy resources request [RESULT][VOTE] Release Apache Slingstart Maven Plugin version 1.8.2

2018-06-19 Thread David Bosschaert
Hi Bertrand,

On Tue, 19 Jun 2018 at 12:17, Bertrand Delacretaz 
wrote:

> Hi David,
>
> On Mon, Jun 18, 2018 at 4:15 PM David Bosschaert
>  wrote:
> > ...Would someone have time to help me copy the resources for this
> release to
> > sling-dist?...
>
> https://repository.apache.org/content/repositories/orgapachesling-1913
> returns 404 now, can I find the release files somewhere else?
>
> -Bertrand
>

Yes, I guess that happens as soon as you promote the release in Nexus.

I'll send you the files in a separate email.

Thanks!

David


Re: Sling Karaf PR's and aggregated repo suggestion

2018-06-19 Thread Radu Cotescu
Hi,

> On 18 Jun 2018, at 14:45, Eugen Stan  wrote:
> 
> Hello Radu,
> 
> Thanks for the tip. I did not knew that. I have tried it with the full
> aggregator and the IDE is quite unresponsive and it's not for lack of
> resources. I have SSD drive and 12GB of RAM.


My instance of IntelliJ is configured to use 2GB of heap and it can handle the 
whole Sling codebase.

> 
> I will try to combine the advice Robert gave and yours and make them
> work together but the experience so far is not great.
> 
> How are you working on Sling? 

Although I work mainly on scripting, I prefer to have all the codebase 
available so that I can inspect other modules easier rather than downloading 
the sources for each dependency.
I’ve also enabled the Git + JIRA integrations for Sling, so that I can benefit 
from autogenerated commit messages - very useful when your changes span across 
different modules (this happens a lot for HTL).

> 
> 
> The question that I am looking for an answer is:
> 
> Having all of these modules requires some mental effort to navigate,
> especially for Sling beginners like me. Does a Sling developer need to
> have access to all of them all the time? I imagine the answer is No. I
> imagine things are logically grouped into related projects. Instead of
> having this flat hierarchy, can we make it more nested? I can identify
> some projects like: sling-discovery, sling-models, sling-launchpad,
> sling-karaf, sling-scripting, sling-auth , etc.
> 
> I believe grouping those modules with git-repo (and not git submodules)
> would be an improvement in being easy to work on specific area of Sling
> functionality.
> 
> I imagine that working on Sling Karaf or Sling Scripting does not
> require me to update Sling API at the same time. Even if that was the
> case, I would still have to get through the community to discuss/approve
> the changes to the lower level API.
> 
> Having those modules grouped by logical functionality into directories,
> I (a developer) can open just that part of Sling and not be bothered
> with the rest of the project. I think it reduces the mental effort that
> I have to deal with and does not lose flexibility.

Correct. You technically need only the group where your module is and I guess 
the groups the aggregator defines are more or less what we used to have before 
in SVN. The only difference now is the flat file-system structure. Several 
ideas floated around regarding how we should organise a full-checkout on the 
filesystem and IIRC two of them resonated with the developer community:

1. tree structure + autogenerated reactor POMs, that emulates the previous setup
2. flat structure + autogenerated reactor POMs

Unfortunately nobody had time to implement either of them.

> 
> 
> Regards,
> 
> Eugen

Cheers,
Radu

[VOTE] Release Scripting HTL Compiler 1.0.22-1.4.0, Scripting HTL Java Compiler 1.0.24-1.4.0, Scripting HTL Engine 1.0.54-1.4.0, Scripting HTL Testing Content 1.0.10-1.4.0, Scripting HTL Testing 1.0.1

2018-06-19 Thread Radu Cotescu
Hi,

We solved 15 issues in these releases (16 if you’re pedantic, but one of them 
is a container issue):
https://issues.apache.org/jira/browse/SLING/fixforversion/12343464 

https://issues.apache.org/jira/browse/SLING/fixforversion/12343465 

https://issues.apache.org/jira/browse/SLING/fixforversion/12342965 

https://issues.apache.org/jira/browse/SLING/fixforversion/12343074 

https://issues.apache.org/jira/browse/SLING/fixforversion/12343073 

https://issues.apache.org/jira/browse/SLING/fixforversion/12343462 

https://issues.apache.org/jira/browse/SLING/fixforversion/12343428 

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1916/ 


You can use this UNIX script to download the release and verify the signatures:
https://github.com/apache/sling-tooling-release/blob/master/check_staged_release.sh
 


Usage:
curl 
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
 | bash -s 1916

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Cheers,
Radu

[jira] [Resolved] (SLING-7747) Send a http response error code if distribution package cannot be exported

2018-06-19 Thread Marius Petria (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marius Petria resolved SLING-7747.
--
   Resolution: Fixed
Fix Version/s: Content Distribution Core 0.3.0

Fixed in  [1]

 

[1]https://github.com/apache/sling-org-apache-sling-distribution-core/commit/07a4c30adb053e8b4181736cd61ce28acf23e6e6

> Send a http response error code if distribution package cannot be exported
> --
>
> Key: SLING-7747
> URL: https://issues.apache.org/jira/browse/SLING-7747
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Content Distribution Core 0.2.10
>Reporter: Marius Petria
>Assignee: Marius Petria
>Priority: Major
> Fix For: Content Distribution Core 0.3.0
>
>
> In DistributionPackageExporterServlet [1] an error is logged if the package 
> cannot be copied but it should also be signaled to the calling party by not 
> sending 200 status code.
>  
> [1]https://github.com/apache/sling-org-apache-sling-distribution-core/blob/7317793d754205b47c1edb24d259c725a12d4b67/src/main/java/org/apache/sling/distribution/servlet/DistributionPackageExporterServlet.java#L110



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Copy resources request [RESULT][VOTE] Release Apache Slingstart Maven Plugin version 1.8.2

2018-06-19 Thread Bertrand Delacretaz
Hi David,

On Mon, Jun 18, 2018 at 4:15 PM David Bosschaert
 wrote:
> ...Would someone have time to help me copy the resources for this release to
> sling-dist?...

https://repository.apache.org/content/repositories/orgapachesling-1913
returns 404 now, can I find the release files somewhere else?

-Bertrand


[jira] [Created] (SLING-7747) Send a http response error code if distribution package cannot be exported

2018-06-19 Thread Marius Petria (JIRA)
Marius Petria created SLING-7747:


 Summary: Send a http response error code if distribution package 
cannot be exported
 Key: SLING-7747
 URL: https://issues.apache.org/jira/browse/SLING-7747
 Project: Sling
  Issue Type: Bug
Affects Versions: Content Distribution Core 0.2.10
Reporter: Marius Petria
Assignee: Marius Petria


In DistributionPackageExporterServlet [1] an error is logged if the package 
cannot be copied but it should also be signaled to the calling party by not 
sending 200 status code.

 

[1]https://github.com/apache/sling-org-apache-sling-distribution-core/blob/7317793d754205b47c1edb24d259c725a12d4b67/src/main/java/org/apache/sling/distribution/servlet/DistributionPackageExporterServlet.java#L110



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7515) ResourceRuntimeExtension: Allow to pass arbitrary options a request attributes via data-sly-resource

2018-06-19 Thread Konrad Windszus (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516698#comment-16516698
 ] 

Konrad Windszus commented on SLING-7515:


I added [https://github.com/Adobe-Marketing-Cloud/htl-spec/issues/63] for the 
Map literal support in HTL expression language.
 

> ResourceRuntimeExtension: Allow to pass arbitrary options a request 
> attributes via data-sly-resource
> 
>
> Key: SLING-7515
> URL: https://issues.apache.org/jira/browse/SLING-7515
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.0.48-1.3.1
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently it is only possible to pass parameters to another script/servlet 
> when using {{data-sly-resource}} with the options to modify the selector 
> (https://github.com/apache/sling-org-apache-sling-scripting-sightly/blob/master/src/main/java/org/apache/sling/scripting/sightly/impl/engine/extension/ResourceRuntimeExtension.java).
>  It would be good if either all unknown options or only those with a specific 
> prefix would be passed as request attributes to the other script/servlet.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7581) Using data-sly-use with two classes with same name will generate uncompilable code

2018-06-19 Thread Konrad Windszus (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516695#comment-16516695
 ] 

Konrad Windszus commented on SLING-7581:


[~radu.cotescu] Would it be possible to switch to fully-qualified class names 
in the generated servlet?
 

> Using data-sly-use with two classes with same name will generate uncompilable 
> code
> --
>
> Key: SLING-7581
> URL: https://issues.apache.org/jira/browse/SLING-7581
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Compiler 1.0.16
>Reporter: Santiago García Pimentel
>Priority: Major
>
> If you have an HTL file with two data-sly-use with classes with the same name 
> HTL will generate a java file which cannot be compiled.
> e.g.
> {code}
> data-sly-use.first="com.adobe.cq.wcm.core.components.models.Page"
> data-sly-use.second="com.client.project.Page"
> {code}
>  
> Will generate
> {code}
> import com.client.project.Page;
> import com.adobe.cq.wcm.core.components.models.Page;
>  ...
>  ...
>  _global_first= renderContext.call("use", Page.class.getName(), obj());
>  _global_second = renderContext.call("use", Page.class.getName(), obj());
> {code} 
> Causing a compilation error as Page is not fully qualified in the code and 
> therefore an ambiguous reference (due to the two imports of same class names)
> This seems to have been introduced by SLING-7205 .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)