[jira] [Resolved] (SLING-435) IE7 error when displaying SlingPostServlet result page
[ https://issues.apache.org/jira/browse/SLING-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-435. Resolution: Fixed Fix Version/s: Servlets Post 2.1.0 This seems to be fixed > IE7 error when displaying SlingPostServlet result page > -- > > Key: SLING-435 > URL: https://issues.apache.org/jira/browse/SLING-435 > Project: Sling > Issue Type: Bug > Components: Servlets > Environment: Windows, Internet Explorer 7 >Reporter: Bertrand Delacretaz >Priority: Minor > Fix For: Servlets Post 2.1.0 > > > When submitting a form that's handled by the SlingPostServlet, IE7 displays > the following error instead of showing the result page: > Parameter entity must be defined before it is used. Error processing resource > 'http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd... > %xhtml-prefw-redecl.mod; > -^ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7436) Wrong content/type in the Default JSON Renderer
[ https://issues.apache.org/jira/browse/SLING-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680989#comment-16680989 ] Carsten Ziegeler commented on SLING-7436: - [~asanso] I'm trying to figure out what the problem is we have to fix here? When I try the above example, indeed the json gets downloaded at 2 and the content type is set to application/json;charset=utf-8. So what needs to change here? > Wrong content/type in the Default JSON Renderer > > > Key: SLING-7436 > URL: https://issues.apache.org/jira/browse/SLING-7436 > Project: Sling > Issue Type: Bug > Components: Servlets >Reporter: Antonio Sanso >Priority: Major > > Steps to reproduce: > 1.Render a page (Renderer enabled) with JSON renderer. E.g: > [http://localhost.com/dir/page(selector] value).json > 2. Now, extend the url with a slash / and a name with any other extensions > e.g > [http://localhost.com/dir/page.(value).json/file.html].] > 3. Observe file.html was automatically downloaded > Credit: this issue was found by Md. Sabuktagin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-435) IE7 error when displaying SlingPostServlet result page
[ https://issues.apache.org/jira/browse/SLING-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-435. -- > IE7 error when displaying SlingPostServlet result page > -- > > Key: SLING-435 > URL: https://issues.apache.org/jira/browse/SLING-435 > Project: Sling > Issue Type: Bug > Components: Servlets > Environment: Windows, Internet Explorer 7 >Reporter: Bertrand Delacretaz >Priority: Minor > Fix For: Servlets Post 2.1.0 > > > When submitting a form that's handled by the SlingPostServlet, IE7 displays > the following error instead of showing the result page: > Parameter entity must be defined before it is used. Error processing resource > 'http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd... > %xhtml-prefw-redecl.mod; > -^ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-1916) Json renderer servlet should use a new RecursionTooDeepException.getLevel() instead of parsing the message
[ https://issues.apache.org/jira/browse/SLING-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-1916. - Resolution: Won't Fix > Json renderer servlet should use a new RecursionTooDeepException.getLevel() > instead of parsing the message > -- > > Key: SLING-1916 > URL: https://issues.apache.org/jira/browse/SLING-1916 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Get 2.1.0 >Reporter: Alexander Klimetschek >Priority: Minor > > The JsonRendererServlet together with the ResourceTraversor use the > RecursionTooDeepException in a wrong way: it sets the depth were it stopped > as exception message, whereas the message is clearly defined to be the > affected resource path instead by the javadocs. Also it leads to a > unnecessary int to string conversion plus string to int parsing. > If there already is a very specific exception class, why not simply add the > level as a member to the exception? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-77) Provide an easy-to-use Javascript API for JCR
[ https://issues.apache.org/jira/browse/SLING-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-77. --- Resolution: Won't Fix > Provide an easy-to-use Javascript API for JCR > - > > Key: SLING-77 > URL: https://issues.apache.org/jira/browse/SLING-77 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Lars Trieloff >Priority: Major > Attachments: sling-77.patch > > > As discussed here, I propose a Javascript-tailor-made wrapper API to make > JCRNodes more accessible to script and template authors > http://thread.gmane.org/gmane.comp.apache.sling.devel/491 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-5004) Improve servlet tracking by using filter
[ https://issues.apache.org/jira/browse/SLING-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-5004. - Resolution: Duplicate This has already been implemented > Improve servlet tracking by using filter > > > Key: SLING-5004 > URL: https://issues.apache.org/jira/browse/SLING-5004 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Carsten Ziegeler >Priority: Major > > Right now, the servlet resolver is tracking all servlets, examinging their > service properties and then decides whether to use the servlet. > If we create a filter expression when tracking the servlets, only servlets > for the servlet resolver will be pushed into the service. The benefit of this > is that we can change the bindServlet method to get the Servlet instance. > This will simplify the current rather complex handling/syncing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-5277) Performance: per thread script resolver (admin session) is always created even if cache is hit
[ https://issues.apache.org/jira/browse/SLING-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-5277. - Resolution: Won't Fix As the code has changed in the meantime, I'm resolving this as won't fix. If needed a new issue can be opened do address the problem based on todays situation > Performance: per thread script resolver (admin session) is always created > even if cache is hit > -- > > Key: SLING-5277 > URL: https://issues.apache.org/jira/browse/SLING-5277 > Project: Sling > Issue Type: Bug > Components: Servlets >Reporter: Alexander Klimetschek >Priority: Major > Attachments: SLING-5277-new.patch, SLING-5277.patch > > > Since SLING-3441, for every request, a new admin / privileged session is > [created in the > SlingServletResolver|https://github.com/apache/sling/blob/trunk/bundles/servlets/resolver/src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java#L532]. > It is created before the script/servlet cache is checked, so in most cases > when the cache is hit it is never used, but the cost of creating an extra > session (which can vary, especially with concurrent traffic) is incurred. > The per thread script resolver can be created lazily instead of directly in > the event to avoid this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8011) Accessing the info.sessionInfo.json endpoint always logs an error: Writer has already been closed
[
https://issues.apache.org/jira/browse/SLING-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680971#comment-16680971
]
Carsten Ziegeler commented on SLING-8011:
-
[~jebailey] It seems this has been fixed, can we resolve this issue then?
> Accessing the info.sessionInfo.json endpoint always logs an error: Writer has
> already been closed
> -
>
> Key: SLING-8011
> URL: https://issues.apache.org/jira/browse/SLING-8011
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.38
>
>
> I noticed that the Sling starter logs are full of errors regarding an already
> closed writer. Taking a closer look, I think the root cause is the fix for
> SLING-7795 - now the response writer is being and then a flush call is issues.
> {noformat}13.10.2018 01:02:12.584 *ERROR* [0:0:0:0:0:0:0:1 [1539381732583]
> GET /system/sling/info.sessionInfo.json HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl Writer has already
> been closed.
> org.apache.sling.engine.impl.SlingHttpServletResponseImpl$WriterAlreadyClosedException:
> null
> at
> org.apache.sling.engine.impl.SlingHttpServletResponseImpl$1.checkClosed(SlingHttpServletResponseImpl.java:190)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingHttpServletResponseImpl$1.flush(SlingHttpServletResponseImpl.java:227)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.servlets.get.impl.SlingInfoServlet.renderJson(SlingInfoServlet.java:122)
> [org.apache.sling.servlets.get:2.1.36]
> at
> org.apache.sling.servlets.get.impl.SlingInfoServlet.doGet(SlingInfoServlet.java:96)
> [org.apache.sling.servlets.get:2.1.36]
> at
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
> [org.apache.sling.api:2.18.4]
> at
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
> [org.apache.sling.api:2.18.4]
> at
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
> [org.apache.sling.api:2.18.4]
> at
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
> [org.apache.sling.engine:2.6.14]
> at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
> [org.apache.sling.i18n:2.5.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
> [org.apache.felix.http.jetty:4.0.6]
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
> [org.apache.felix.http.jetty:4.0.6]
> at
> org.apache.felix.http.sslfilter.internal.SslFilter.doFilter(SslFilter.java:96)
> [org.apache.felix.http.sslfilter:1.2.4]
> at
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> [org.apache.felix.http.jetty:4.0.6]
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
> [org.apache.fe
[jira] [Resolved] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)
[
https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-8084.
Resolution: Fixed
Fixed with
https://github.com/apache/sling-org-apache-sling-api/commit/aaf0a43dd7fe8d80861579b2744b045cbd6cd2e2.
> Clarify javadoc for ResourceResolver.map(...)
> -
>
> Key: SLING-8084
> URL: https://issues.apache.org/jira/browse/SLING-8084
> Project: Sling
> Issue Type: Bug
> Components: API
>Affects Versions: API 2.18.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: API 2.18.6
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the javadoc for {{ResourceResolver.map(...)}}
> (https://github.com/apache/sling-org-apache-sling-api/blob/ddeb4ec650813d816a8ffca3ac1eec92f7ea53fb/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L283)
> does not clearly state whether URI encoding is done within or not.
> If I understand
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L160
> and
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L362
> correctly it will actually do the URI encoding!
> It is important to mention that as calling {{ResourceResolver.map}} twice in
> a row might lead to a 404 in the end.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)
[
https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680934#comment-16680934
]
Carsten Ziegeler commented on SLING-8084:
-
Lgtm, thanks
> Clarify javadoc for ResourceResolver.map(...)
> -
>
> Key: SLING-8084
> URL: https://issues.apache.org/jira/browse/SLING-8084
> Project: Sling
> Issue Type: Bug
> Components: API
>Affects Versions: API 2.18.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: API 2.18.6
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the javadoc for {{ResourceResolver.map(...)}}
> (https://github.com/apache/sling-org-apache-sling-api/blob/ddeb4ec650813d816a8ffca3ac1eec92f7ea53fb/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L283)
> does not clearly state whether URI encoding is done within or not.
> If I understand
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L160
> and
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L362
> correctly it will actually do the URI encoding!
> It is important to mention that as calling {{ResourceResolver.map}} twice in
> a row might lead to a 404 in the end.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7999) Add a `length` property to the AbstractRepeatPlugin
[ https://issues.apache.org/jira/browse/SLING-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680748#comment-16680748 ] Dan Klco commented on SLING-7999: - Hey [~radu.cotescu], [~tml] reached out to me on this, it seems like a small and useful fix, but I don't know enough about the internals of HTL to really give it a thorough review, would you mind taking a look at the PR and merging? [https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/3] > Add a `length` property to the AbstractRepeatPlugin > --- > > Key: SLING-7999 > URL: https://issues.apache.org/jira/browse/SLING-7999 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting HTL Java Compiler 1.0.26-1.4.0 >Reporter: Joey Smith >Assignee: Radu Cotescu >Priority: Trivial > Fix For: Scripting HTL Java Compiler 1.1.0-1.4.0 > > > I have created a PR to add a length property to AbstractRepeatPlugin; this is > primarily intended to allow users to do things like "Item of " when > using a data-sly-list; the count/index property could already be used to > derive the X, but it seemed there was no simple way to access the Y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7999) Add a `length` property to the AbstractRepeatPlugin
[ https://issues.apache.org/jira/browse/SLING-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-7999: --- Assignee: Radu Cotescu > Add a `length` property to the AbstractRepeatPlugin > --- > > Key: SLING-7999 > URL: https://issues.apache.org/jira/browse/SLING-7999 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting HTL Java Compiler 1.0.26-1.4.0 >Reporter: Joey Smith >Assignee: Radu Cotescu >Priority: Trivial > Fix For: Scripting HTL Java Compiler 1.1.0-1.4.0 > > > I have created a PR to add a length property to AbstractRepeatPlugin; this is > primarily intended to allow users to do things like "Item of " when > using a data-sly-list; the count/index property could already be used to > derive the X, but it seemed there was no simple way to access the Y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7999) Add a `length` property to the AbstractRepeatPlugin
[ https://issues.apache.org/jira/browse/SLING-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-7999: Fix Version/s: Scripting HTL Java Compiler 1.1.0-1.4.0 > Add a `length` property to the AbstractRepeatPlugin > --- > > Key: SLING-7999 > URL: https://issues.apache.org/jira/browse/SLING-7999 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting HTL Java Compiler 1.0.26-1.4.0 >Reporter: Joey Smith >Priority: Trivial > Fix For: Scripting HTL Java Compiler 1.1.0-1.4.0 > > > I have created a PR to add a length property to AbstractRepeatPlugin; this is > primarily intended to allow users to do things like "Item of " when > using a data-sly-list; the count/index property could already be used to > derive the X, but it seemed there was no simple way to access the Y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)
[
https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-8084:
---
Affects Version/s: (was: API 2.18.6)
API 2.18.4
> Clarify javadoc for ResourceResolver.map(...)
> -
>
> Key: SLING-8084
> URL: https://issues.apache.org/jira/browse/SLING-8084
> Project: Sling
> Issue Type: Bug
> Components: API
>Affects Versions: API 2.18.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: API 2.18.6
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the javadoc for {{ResourceResolver.map(...)}}
> (https://github.com/apache/sling-org-apache-sling-api/blob/ddeb4ec650813d816a8ffca3ac1eec92f7ea53fb/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L283)
> does not clearly state whether URI encoding is done within or not.
> If I understand
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L160
> and
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L362
> correctly it will actually do the URI encoding!
> It is important to mention that as calling {{ResourceResolver.map}} twice in
> a row might lead to a 404 in the end.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679961#comment-16679961
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi closed pull request #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679561#comment-16679561
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436944950
Currently, the Schema definition is in the `org.apache.sling.feature`
module, see
https://github.com/apache/sling-org-apache-sling-feature/blob/master/schema/Feature-1.0.0.schema.json
- would it be OK to move it to the `slingfeature-maven-plugin` space?
I would suggest to have it in a single place to avoid synching multiple
sources - WDYT?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679941#comment-16679941
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437049507
Sure, just give me few minutes!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8077) Transform ContentOrderMergeProcessor into MergeHandler
[ https://issues.apache.org/jira/browse/SLING-8077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679716#comment-16679716 ] ASF GitHub Bot commented on SLING-8077: --- bosschaert commented on issue #3: SLING-8077 - adding testcoverage and processing of source & target ev… URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/3#issuecomment-436984676 Thanks for the additional tests @DominikSuess ! It's merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Transform ContentOrderMergeProcessor into MergeHandler > -- > > Key: SLING-8077 > URL: https://issues.apache.org/jira/browse/SLING-8077 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Dominik Süß >Priority: Major > > ContentOrderMergeProcessor as implemented in "Featuremodel - Content > Deployment Exension" currently postprocesses features after merge to set the > default start-order. this only works for cases where features with same order > are getting merged and mandates a sequential merge of features of different > order. > To tackle this issue the extension should take over the actual merge which > allows to preprocess the features before merging and setting the defaults > according to the defaults declared in the particular features before doing > the merge. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8083) Installer Hook: Installer events are not in all cases received
[
https://issues.apache.org/jira/browse/SLING-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679525#comment-16679525
]
ASF GitHub Bot commented on SLING-8083:
---
ghenzler opened a new pull request #1: SLING-8083 avoid
ClassNotFoundExceptions, take
infoProvider.getInstallationState().getInstalledResources() into account
URL:
https://github.com/apache/sling-org-apache-sling-installer-provider-installhook/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Installer Hook: Installer events are not in all cases received
> --
>
> Key: SLING-8083
> URL: https://issues.apache.org/jira/browse/SLING-8083
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>Priority: Major
>
> In some cases, the installer hook does not receive the events for the
> installation of the installable. This may be connected to the dynamic class
> loader (that is used to load the hook) not active anymore. To ensure this is
> not happening, classes like InstallerHookOsgiEventListener shall be loaded at
> the very beginning of the hook (before it starts registering
> InstallableResources) and
> infoProvider.getInstallationState().getInstalledResources() should be taken
> into account when waiting for the installables to be installed.
> {code}
> 02.11.2018 23:43:52.566 *ERROR* [qtp2051186638-83]
> org.apache.sling.commons.classloader.impl.ClassLoaderFacade Dynamic class
> loader has already been deactivated.
> org.apache.sling.commons.classloader.impl.ClassLoaderFacade$StackTraceProbe:
> Dynamic class loader has already been deactivated.
> at
> org.apache.sling.commons.classloader.impl.ClassLoaderFacade.checkManagerActive(ClassLoaderFacade.java:69)
> [org.apache.sling.commons.classloader:1.4.2]
> at
> org.apache.sling.commons.classloader.impl.ClassLoaderFacade.loadClass(ClassLoaderFacade.java:133)
> [org.apache.sling.commons.classloader:1.4.2]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
> at java.net.FactoryURLClassLoader.loadClass(URLClassLoader.java:814)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at
> org.apache.sling.installer.provider.installhook.OsgiInstallerHook.waitForServiceChanges(OsgiInstallerHook.java:410)
> at
> org.apache.sling.installer.provider.installhook.OsgiInstallerHook.execute(OsgiInstallerHook.java:201)
> at
> org.apache.jackrabbit.vault.packaging.impl.InstallHookProcessorImpl.execute(InstallHookProcessorImpl.java:148)
> [org.apache.jackrabbit.vault:3.1.44]
> at
> org.apache.jackrabbit.vault.packaging.impl.ZipVaultPackage.extract(ZipVaultPackage.java:241)
> [org.apache.jackrabbit.vault:3.1.44]
> at
> org.apache.jackrabbit.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:398)
> [org.apache.jackrabbit.vault:3.1.44]
> at
> org.apache.jackrabbit.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:357)
> [org.apache.jackrabbit.vault:3.1.44]
> at
> org.apache.jackrabbit.vault.packaging.impl.JcrPackageImpl.install(JcrPackageImpl.java:351)
> [org.apache.jackrabbit.vault:3.1.44]
> at
> com.day.crx.packmgr.impl.servlets.ServiceServlet.doInstall(ServiceServlet.java:437)
> [com.adobe.granite.crx-packagemgr:1.2.60]
> at
> com.day.crx.packmgr.impl.servlets.ServiceServlet.upload(ServiceServlet.java:512)
> [com.adobe.granite.crx-packagemgr:1.2.60]
> at
> com.day.crx.packmgr.impl.servlets.ServiceServlet.doService(ServiceServlet.java:180)
> [com.adobe.granite.crx-packagemgr:1.2.60]
> at
> com.day.crx.packmgr.impl.AbstractServlet.service(AbstractServlet.java:54)
> [com.adobe.granite.crx-packagemgr:1.2.60]
> at com.day.crx.packmgr.impl.MainServlet.doService(MainServlet.java:157)
> [com.adobe.granite.crx-packagemgr:1.2.60]
> at com.day.crx.packmgr.impl.MainServlet.service(MainServlet.java:134)
> [com.adobe.granite.crx-packagemgr:1.2.60]
> at
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
> [org.apache.felix.http.jetty:3.4.7.B012]
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
> [org.apache.felix.http.jetty:3.4.7.B012]
> at
> com.adobe.granite.cors.impl.CORSHandler.doFilter(CORSHandler.java:120)
> [com.adobe.granite.cors:1.0.6]
> at
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> [org.
[jira] [Commented] (SLING-7936) Execute module integration tests in the launchpad-testing module
[
https://issues.apache.org/jira/browse/SLING-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680440#comment-16680440
]
Robert Munteanu commented on SLING-7936:
Started a POC with
*
https://github.com/apache/sling-org-apache-sling-servlets-get/compare/feature/SLING-7936?expand=1
*
https://github.com/apache/sling-org-apache-sling-launchpad-testing/compare/feature/SLING-7936?expand=1
I am envisioning at least some enhancement to the {{slingstart-maven-plugin}}
which will automatically populate the test dependencies in the
launchapd-testing module's classpath.
> Execute module integration tests in the launchpad-testing module
>
>
> Key: SLING-7936
> URL: https://issues.apache.org/jira/browse/SLING-7936
> Project: Sling
> Issue Type: Improvement
> Components: Build and Source Control, Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
>
> In the last years we've decided to move integration tests closer to the
> modules they live in, which is a good thing (TM).
> There are also good things about having a central place to execute them, such
> as the ability to run those tests on multiple Java versions.
> One idea of how to approach this is to define integration tests in the
> modules, and run them during the regular build. On top of that, deploy the
> integration tests as their own artifacts (maybe same but with
> {{integration-test}} classifier ) and then execute them as part of the Sling
> ITs.
> This would get us the best of both worlds - tests living next to their
> module, and also the ability to execute "all" tests in a single unit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679695#comment-16679695
]
ASF GitHub Bot commented on SLING-8032:
---
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436978949
Yes, an invalid json can't be read anyway
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8082) Correct target filter for service user
[ https://issues.apache.org/jira/browse/SLING-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8082. - Resolution: Fixed Fixed in rev 5ac9e3b > Correct target filter for service user > -- > > Key: SLING-8082 > URL: https://issues.apache.org/jira/browse/SLING-8082 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Resolver 2.4.22 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Servlets Resolver 2.4.24 > > > The target filter for the service user mapped service is using the > subServiceName which according to SLING-4312 and the javadoc of > ServiceUserMapped should either filter for the subservicename *or* the > default mapping. The default mapping is currently missing -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679931#comment-16679931
]
ASF GitHub Bot commented on SLING-8032:
---
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437047260
Hi @simonetripodi Could you please rebase your branch against master? The
listed changes contain a lot of stuff from master
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679626#comment-16679626
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436962821
@cziegeler there is one problem on accessing to Feature files via
`ProjectHelper#getFeatures`: they are parsed. So, if our internal JSON parser
detects a violation, there will be no chance the Feature file will ever be
validated due to runtime errors, i.e.:
```
[main] [ERROR] Internal error: java.lang.RuntimeException: Unable to read
feature
/Users/stripodi/Documents/cq-workspace/sling-slingfeature-maven-plugin/target/it/schema-validation-ko/src/main/features/invalid-feature.json:
/Users/stripodi/Documents/cq-workspace/sling-slingfeature-maven-plugin/target/it/schema-validation-ko/src/main/features/invalid-feature.json
: Key model-version is not one of the allowed types [class java.lang.String] :
class java.lang.Long -> [Help 1]
org.apache.maven.InternalErrorException: Internal error:
java.lang.RuntimeException: Unable to read feature
/Users/stripodi/Documents/cq-workspace/sling-slingfeature-maven-plugin/target/it/schema-validation-ko/src/main/features/invalid-feature.json
```
Any idea on how to work around this? TIA!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679660#comment-16679660
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436972355
OK, so validation is turned _on_ by default?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8085) Incorporate layering optimizations for cross layer dependencies
[ https://issues.apache.org/jira/browse/SLING-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679818#comment-16679818 ] ASF GitHub Bot commented on SLING-8085: --- DominikSuess opened a new pull request #4: SLING-8085 - adjusting ContentHandler to properly incorporating layer… URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/4 …ing flow as implemented in JCRVLT-319 (based on SNAPSHOT for now) / adding testcoverage This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Incorporate layering optimizations for cross layer dependencies > --- > > Key: SLING-8085 > URL: https://issues.apache.org/jira/browse/SLING-8085 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Dominik Süß >Priority: Major > > In case an exeuction plan on a higher level depends on artifacts of a lower > level the exeuctionplan builder currently generates install wrong and > uncessary install tasks to fill the gap. This scenario is covered in > JCRVLT-319 and requires adoption of the consumer. > This ticket is to track incorporation of this optimization into the content > extension making use of this new mechanism. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8083) Installer Hook: Installer events are not in all cases received
[
https://issues.apache.org/jira/browse/SLING-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Georg Henzler updated SLING-8083:
-
Issue Type: Bug (was: Task)
> Installer Hook: Installer events are not in all cases received
> --
>
> Key: SLING-8083
> URL: https://issues.apache.org/jira/browse/SLING-8083
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>Priority: Major
>
> In some cases, the installer hook does not receive the events for the
> installation of the installable. This may be connected to the dynamic class
> loader (that is used to load the hook) not active anymore. To ensure this is
> not happening, classes like InstallerHookOsgiEventListener shall be loaded at
> the very beginning of the hook (before it starts registering
> InstallableResources) and
> infoProvider.getInstallationState().getInstalledResources() should be taken
> into account when waiting for the installables to be installed.
> {code}
> 02.11.2018 23:43:52.566 *ERROR* [qtp2051186638-83]
> org.apache.sling.commons.classloader.impl.ClassLoaderFacade Dynamic class
> loader has already been deactivated.
> org.apache.sling.commons.classloader.impl.ClassLoaderFacade$StackTraceProbe:
> Dynamic class loader has already been deactivated.
> at
> org.apache.sling.commons.classloader.impl.ClassLoaderFacade.checkManagerActive(ClassLoaderFacade.java:69)
> [org.apache.sling.commons.classloader:1.4.2]
> at
> org.apache.sling.commons.classloader.impl.ClassLoaderFacade.loadClass(ClassLoaderFacade.java:133)
> [org.apache.sling.commons.classloader:1.4.2]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
> at java.net.FactoryURLClassLoader.loadClass(URLClassLoader.java:814)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at
> org.apache.sling.installer.provider.installhook.OsgiInstallerHook.waitForServiceChanges(OsgiInstallerHook.java:410)
> at
> org.apache.sling.installer.provider.installhook.OsgiInstallerHook.execute(OsgiInstallerHook.java:201)
> at
> org.apache.jackrabbit.vault.packaging.impl.InstallHookProcessorImpl.execute(InstallHookProcessorImpl.java:148)
> [org.apache.jackrabbit.vault:3.1.44]
> at
> org.apache.jackrabbit.vault.packaging.impl.ZipVaultPackage.extract(ZipVaultPackage.java:241)
> [org.apache.jackrabbit.vault:3.1.44]
> at
> org.apache.jackrabbit.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:398)
> [org.apache.jackrabbit.vault:3.1.44]
> at
> org.apache.jackrabbit.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:357)
> [org.apache.jackrabbit.vault:3.1.44]
> at
> org.apache.jackrabbit.vault.packaging.impl.JcrPackageImpl.install(JcrPackageImpl.java:351)
> [org.apache.jackrabbit.vault:3.1.44]
> at
> com.day.crx.packmgr.impl.servlets.ServiceServlet.doInstall(ServiceServlet.java:437)
> [com.adobe.granite.crx-packagemgr:1.2.60]
> at
> com.day.crx.packmgr.impl.servlets.ServiceServlet.upload(ServiceServlet.java:512)
> [com.adobe.granite.crx-packagemgr:1.2.60]
> at
> com.day.crx.packmgr.impl.servlets.ServiceServlet.doService(ServiceServlet.java:180)
> [com.adobe.granite.crx-packagemgr:1.2.60]
> at
> com.day.crx.packmgr.impl.AbstractServlet.service(AbstractServlet.java:54)
> [com.adobe.granite.crx-packagemgr:1.2.60]
> at com.day.crx.packmgr.impl.MainServlet.doService(MainServlet.java:157)
> [com.adobe.granite.crx-packagemgr:1.2.60]
> at com.day.crx.packmgr.impl.MainServlet.service(MainServlet.java:134)
> [com.adobe.granite.crx-packagemgr:1.2.60]
> at
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
> [org.apache.felix.http.jetty:3.4.7.B012]
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
> [org.apache.felix.http.jetty:3.4.7.B012]
> at
> com.adobe.granite.cors.impl.CORSHandler.doFilter(CORSHandler.java:120)
> [com.adobe.granite.cors:1.0.6]
> at
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> [org.apache.felix.http.jetty:3.4.7.B012]
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
> [org.apache.felix.http.jetty:3.4.7.B012]
> at
> org.apache.sling.security.impl.ReferrerFilter.doFilter(ReferrerFilter.java:328)
> [org.apache.sling.security:1.1.12]
> at
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> [org.apache.felix.http.jetty:3.4.7.B012]
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
> [org.apache.felix.http.jet
Re: [PROPOSAL] Moving integration tests closer to the code they test
On Wednesday 07 November 2018 17:29:01 Robert Munteanu wrote: > Hi, Hi Robert, > We discussed a couple of time that it would be desireable to move tests > closer to the code they're testing. > > I wrote a proposal about how this could look like in terms of results > > https://cwiki.apache.org/confluence/display/SLING/Moving+integration+tests+c > loser+to+the+code+they+test > > I purposefully avoided looking into implementation details to avoid > doing too much work for nothing. > > What do you think about this possibility? did I get your point - we keep free-style and "managed" (using Sling Testing PaxExam) Pax Exam tests (which may also use Sling's HTTP API) as is? Thanks, O. > Thanks, > > Robert
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679332#comment-16679332
]
ASF GitHub Bot commented on SLING-8032:
---
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436885201
While a general purpose JSON schema mojo would be nice, I see at least two
problems with this:
- the configuration of where the json files are and which are included /
excluded needs to be sync'ed with the configuration of where feature files are.
Usually not a big deal as everyone uses the default configuration but as soon
as you don't it can be come a subtle problem
- the reference to the json schema needs to reference an external schema for
the general purpose (a url). This might become tricky as you make sure that
your schema is available publically in the internet and is accessible at build
time
I would rather prefer that we really only validate feature files. This way
we can leverage the ProjectHelper.getFeatures to get the features. This method
returns a map, and the key of each entry is the file path. This allows access
to the raw feature files without having to repeat the configuration and the
scanning logic. In addition if we bake in the schema for feature files we don't
have any external dependency
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SLING-7936) Execute module integration tests in the launchpad-testing module
[
https://issues.apache.org/jira/browse/SLING-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-7936:
--
Assignee: Robert Munteanu
> Execute module integration tests in the launchpad-testing module
>
>
> Key: SLING-7936
> URL: https://issues.apache.org/jira/browse/SLING-7936
> Project: Sling
> Issue Type: Improvement
> Components: Build and Source Control, Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
>
> In the last years we've decided to move integration tests closer to the
> modules they live in, which is a good thing (TM).
> There are also good things about having a central place to execute them, such
> as the ability to run those tests on multiple Java versions.
> One idea of how to approach this is to define integration tests in the
> modules, and run them during the regular build. On top of that, deploy the
> integration tests as their own artifacts (maybe same but with
> {{integration-test}} classifier ) and then execute them as part of the Sling
> ITs.
> This would get us the best of both worlds - tests living next to their
> module, and also the ability to execute "all" tests in a single unit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679610#comment-16679610
]
ASF GitHub Bot commented on SLING-8032:
---
cziegeler closed pull request #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/11
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8077) Transform ContentOrderMergeProcessor into MergeHandler
[
https://issues.apache.org/jira/browse/SLING-8077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679715#comment-16679715
]
ASF GitHub Bot commented on SLING-8077:
---
bosschaert closed pull request #3: SLING-8077 - adding testcoverage and
processing of source & target ev…
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/3
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pom.xml b/pom.xml
index f5c121d..e467dcf 100644
--- a/pom.xml
+++ b/pom.xml
@@ -192,5 +192,18 @@
1.3.1
compile
+
+
+junit
+junit
+test
+
+
+
+org.mockito
+mockito-core
+2.23.0
+test
+
diff --git
a/src/main/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessor.java
b/src/main/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessor.java
index 05b1133..9289e4c 100644
---
a/src/main/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessor.java
+++
b/src/main/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessor.java
@@ -24,13 +24,15 @@
import org.apache.sling.feature.KeyValueMap;
import org.apache.sling.feature.builder.HandlerContext;
import org.apache.sling.feature.builder.MergeHandler;
-import org.apache.sling.feature.builder.PostProcessHandler;
public class ContentOrderMergeProcessor implements MergeHandler {
-private static final String DEFAULT_CONTENT_START_ORDER =
"default.content.startorder";
+public static final String DEFAULT_CONTENT_START_ORDER =
"default.content.startorder";
-private void processFeature(HandlerContext context, Feature feature,
Extension extension) {
+private void processFeature(Feature feature, Extension extension) {
+if (feature == null) {
+return;
+}
String defaultOrder =
feature.getVariables().get(DEFAULT_CONTENT_START_ORDER);
if (defaultOrder != null) {
for (Artifact a : extension.getArtifacts()) {
@@ -51,12 +53,14 @@ public boolean canMerge(Extension extension) {
@Override
public void merge(HandlerContext context, Feature target, Feature source,
Extension targetEx, Extension sourceEx) {
+
+processFeature(target, targetEx);
+processFeature(source, sourceEx);
+
if (targetEx == null) {
target.getExtensions().add(sourceEx);
return;
}
-processFeature(context, target, targetEx);
-processFeature(context, source, sourceEx);
for (final Artifact a : sourceEx.getArtifacts()) {
boolean replace = true;
final Artifact existing =
targetEx.getArtifacts().getSame(a.getId());
diff --git
a/src/test/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessorTest.java
b/src/test/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessorTest.java
new file mode 100644
index 000..15c5b8f
--- /dev/null
+++
b/src/test/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessorTest.java
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.sling.feature.extension.content;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Set;
+
+import org.apache.sling.feature.Artifact;
+import org.apache.sling.feature.ArtifactId;
+import org.apache.sling.feature.Artifacts;
+import org.apache.sling.feature.Extension;
+import org.apache.sling.feature.ExtensionType;
+import org.apache.sling.feature.Feature;
+import org.apache.sling.feature.builder.HandlerContext;
+import org.junit.Test;
+import org.mockito.Mock;
+
+public class ContentOrderMe
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679563#comment-16679563
]
ASF GitHub Bot commented on SLING-8032:
---
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436945663
I think the schema should be part of the feature-io module as this is doing
the json handling. Totally agree with a single place. We can add the schema as
a resource to the feature-io bundle and the maven plugin can pick it up from
there
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Capabilities
On Monday 05 November 2018 11:05:19 Bertrand Delacretaz wrote: > Hi, Hi Bertrand, > On Sun, Nov 4, 2018 at 9:45 PM Oliver Lietz wrote: > > > > ...wouldn't it make sense to exploit OSGi Capabilities instead of > > > > building our own API and implementation for capabilities?... > > The goal of the Capabilities module [1] is to provide a simple HTTP > API that indicates what a Sling instance can do. why should we limit ourselves by creating a Sling-specific API? > I don't think the HTTP part of that is covered by OSGi capabilities, > and [1] really just defines a JSON format for capabilities, a way to > set up such endpoints with access control and a way to decide what's > output (via CapabilitiesSource services). > > One can very much implement a CapabilitiesSource [2] that exposes > relevant OSGi capabilities, would that work for you? > > Or do you mean that I should have used something from [3] instead of > CapabilitiesSource? In my opinion we should make capabilities (e.g. similarity search) known to the OSGi Framework first. That would mean components et al. can depend on them via requirements - much broader use. The Resolver keeps track of the capabilities and we just have to find a way to get and expose them (I'm sure there is no HTTP interface to Capabilities yet). My proposal (Resolver = "Cap. Registry"): Capabilities -> OSGi Framework <- Servlet HTTP/JSON Capabilities -> OSGi Framework <- Requirements Sling Capabilities and your proposal (CapabilitiesServlet = "Cap. Registry"): CapabilitiesSources -> CapabilitiesServlet HTTP/JSON (Cap. Registry) CapabilitiesSources -> Capabilities -> OSGi Framework <- Requirements Is it understandable? Regards, O. > -Bertrand > > [1] https://github.com/apache/sling-org-apache-sling-capabilities > [2] > https://github.com/apache/sling-org-apache-sling-capabilities/blob/master/s > rc/main/java/org/apache/sling/capabilities/CapabilitiesSource.java [3] > https://osgi.org/specification/osgi.core/7.0.0/framework.resource.html
[jira] [Created] (SLING-8082) Correct target filter for service user
Carsten Ziegeler created SLING-8082: --- Summary: Correct target filter for service user Key: SLING-8082 URL: https://issues.apache.org/jira/browse/SLING-8082 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Resolver 2.4.22 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Servlets Resolver 2.4.24 The target filter for the service user mapped service is using the subServiceName which according to SLING-4312 and the javadoc of ServiceUserMapped should either filter for the subservicename *or* the default mapping. The default mapping is currently missing -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679497#comment-16679497
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436930253
I got it, thanks @cziegeler for the feedback - I get back to work to apply
those modifications!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679969#comment-16679969
]
ASF GitHub Bot commented on SLING-8032:
---
cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO
which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231959908
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -256,6 +305,8 @@ protected void readProjectFeatures(
throw new RuntimeException("Unable to read feature " +
file.getAbsolutePath(), io);
}
+checkFeatureFileValidation(file);
+
Review comment:
If you validate the file, the validation might fail as the "id" property
might not be set, this will be set by calling the next method, so validation
should happen within that method
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679960#comment-16679960
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437055060
@cziegeler please refer to
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-8085) Incorporate layering optimizations for cross layer dependencies
Dominik Süß created SLING-8085: -- Summary: Incorporate layering optimizations for cross layer dependencies Key: SLING-8085 URL: https://issues.apache.org/jira/browse/SLING-8085 Project: Sling Issue Type: Improvement Components: Feature Model Reporter: Dominik Süß In case an exeuction plan on a higher level depends on artifacts of a lower level the exeuctionplan builder currently generates install wrong and uncessary install tasks to fill the gap. This scenario is covered in JCRVLT-319 and requires adoption of the consumer. This ticket is to track incorporation of this optimization into the content extension making use of this new mechanism. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679959#comment-16679959
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi opened a new pull request #17: SLING-8032 - Add a MOJO which is
able to validate JSON Feature file against the JSON Schema
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679582#comment-16679582
]
ASF GitHub Bot commented on SLING-8032:
---
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436951654
sounds good to me
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679968#comment-16679968
]
ASF GitHub Bot commented on SLING-8032:
---
cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO
which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231959205
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -404,6 +455,7 @@ public Feature provide(final ArtifactId id) {
// "external" dependency, we can already resolve it
final File featureFile =
ProjectHelper.getOrResolveArtifact(info.project, env.session,
env.artifactHandlerManager, env.resolver, id).getFile();
+ checkFeatureFileValidation(featureFile);
Review comment:
I think we should not validate external features as these are released in
maven already and therefore should be validated already
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8081) NoClassDefFoundError: javax/jcr/RepositoryException when using without JCR
[ https://issues.apache.org/jira/browse/SLING-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8081. - Resolution: Fixed Fixed in rev 31bd3c6 > NoClassDefFoundError: javax/jcr/RepositoryException when using without JCR > -- > > Key: SLING-8081 > URL: https://issues.apache.org/jira/browse/SLING-8081 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.36 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Servlets Get 2.1.38 > > > java.lang.NoClassDefFoundError: javax/jcr/RepositoryException > at > org.apache.sling.servlets.get.impl.DefaultGetServlet.getDefaultRenderer(DefaultGetServlet.java:212) > at > org.apache.sling.servlets.get.impl.DefaultGetServlet.init(DefaultGetServlet.java:246) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)
[
https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-8084:
---
Fix Version/s: API 2.18.6
> Clarify javadoc for ResourceResolver.map(...)
> -
>
> Key: SLING-8084
> URL: https://issues.apache.org/jira/browse/SLING-8084
> Project: Sling
> Issue Type: Bug
> Components: API
>Affects Versions: API 2.18.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: API 2.18.6
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the javadoc for {{ResourceResolver.map(...)}}
> (https://github.com/apache/sling-org-apache-sling-api/blob/ddeb4ec650813d816a8ffca3ac1eec92f7ea53fb/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L283)
> does not clearly state whether URI encoding is done within or not.
> If I understand
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L160
> and
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L362
> correctly it will actually do the URI encoding!
> It is important to mention that as calling {{ResourceResolver.map}} twice in
> a row might lead to a 404 in the end.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679602#comment-16679602
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi opened a new pull request #11: SLING-8032 - Add a MOJO which is
able to validate JSON Feature file against the JSON Schema
URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/11
schema definition moved from sling-org-apache-sling-feature to
sling-org-apache-sling-feature-io
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679926#comment-16679926
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437044956
Hi @cziegeler please check the updated branch, validation is now in the
`Preprocessor` and proposed MOJO does not exist anymore.
Any feedback will be more than appreciated :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [VOTE] Release Apache Sling Service User Mapper 1.4.4
+1 David On Wed, 7 Nov 2018 at 16:00, Karl Pauls wrote: > I would like to call a vote on the following release, > > Apache Sling Service User Mapper 1.4.4 > > We solved 1 issue in this release: > https://issues.apache.org/jira/projects/SLING/versions/12344048 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2009/ > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2009 /tmp/sling-staging > > Please vote to approve these releases: > > [ ] +1 Approve the releases > [ ] 0 Don't care > [ ] -1 Don't release, because ... >
[jira] [Created] (SLING-8083) Installer Hook: Installer events are not in all cases received
Georg Henzler created SLING-8083:
Summary: Installer Hook: Installer events are not in all cases
received
Key: SLING-8083
URL: https://issues.apache.org/jira/browse/SLING-8083
Project: Sling
Issue Type: Task
Components: Installer
Reporter: Georg Henzler
Assignee: Georg Henzler
In some cases, the installer hook does not receive the events for the
installation of the installable. This may be connected to the dynamic class
loader (that is used to load the hook) not active anymore. To ensure this is
not happening, classes like InstallerHookOsgiEventListener shall be loaded at
the very beginning of the hook (before it starts registering
InstallableResources) and
infoProvider.getInstallationState().getInstalledResources() should be taken
into account when waiting for the installables to be installed.
{code}
02.11.2018 23:43:52.566 *ERROR* [qtp2051186638-83]
org.apache.sling.commons.classloader.impl.ClassLoaderFacade Dynamic class
loader has already been deactivated.
org.apache.sling.commons.classloader.impl.ClassLoaderFacade$StackTraceProbe:
Dynamic class loader has already been deactivated.
at
org.apache.sling.commons.classloader.impl.ClassLoaderFacade.checkManagerActive(ClassLoaderFacade.java:69)
[org.apache.sling.commons.classloader:1.4.2]
at
org.apache.sling.commons.classloader.impl.ClassLoaderFacade.loadClass(ClassLoaderFacade.java:133)
[org.apache.sling.commons.classloader:1.4.2]
at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
at java.net.FactoryURLClassLoader.loadClass(URLClassLoader.java:814)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at
org.apache.sling.installer.provider.installhook.OsgiInstallerHook.waitForServiceChanges(OsgiInstallerHook.java:410)
at
org.apache.sling.installer.provider.installhook.OsgiInstallerHook.execute(OsgiInstallerHook.java:201)
at
org.apache.jackrabbit.vault.packaging.impl.InstallHookProcessorImpl.execute(InstallHookProcessorImpl.java:148)
[org.apache.jackrabbit.vault:3.1.44]
at
org.apache.jackrabbit.vault.packaging.impl.ZipVaultPackage.extract(ZipVaultPackage.java:241)
[org.apache.jackrabbit.vault:3.1.44]
at
org.apache.jackrabbit.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:398)
[org.apache.jackrabbit.vault:3.1.44]
at
org.apache.jackrabbit.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:357)
[org.apache.jackrabbit.vault:3.1.44]
at
org.apache.jackrabbit.vault.packaging.impl.JcrPackageImpl.install(JcrPackageImpl.java:351)
[org.apache.jackrabbit.vault:3.1.44]
at
com.day.crx.packmgr.impl.servlets.ServiceServlet.doInstall(ServiceServlet.java:437)
[com.adobe.granite.crx-packagemgr:1.2.60]
at
com.day.crx.packmgr.impl.servlets.ServiceServlet.upload(ServiceServlet.java:512)
[com.adobe.granite.crx-packagemgr:1.2.60]
at
com.day.crx.packmgr.impl.servlets.ServiceServlet.doService(ServiceServlet.java:180)
[com.adobe.granite.crx-packagemgr:1.2.60]
at
com.day.crx.packmgr.impl.AbstractServlet.service(AbstractServlet.java:54)
[com.adobe.granite.crx-packagemgr:1.2.60]
at com.day.crx.packmgr.impl.MainServlet.doService(MainServlet.java:157)
[com.adobe.granite.crx-packagemgr:1.2.60]
at com.day.crx.packmgr.impl.MainServlet.service(MainServlet.java:134)
[com.adobe.granite.crx-packagemgr:1.2.60]
at
org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
[org.apache.felix.http.jetty:3.4.7.B012]
at
org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
[org.apache.felix.http.jetty:3.4.7.B012]
at
com.adobe.granite.cors.impl.CORSHandler.doFilter(CORSHandler.java:120)
[com.adobe.granite.cors:1.0.6]
at
org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
[org.apache.felix.http.jetty:3.4.7.B012]
at
org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
[org.apache.felix.http.jetty:3.4.7.B012]
at
org.apache.sling.security.impl.ReferrerFilter.doFilter(ReferrerFilter.java:328)
[org.apache.sling.security:1.1.12]
at
org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
[org.apache.felix.http.jetty:3.4.7.B012]
at
org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
[org.apache.felix.http.jetty:3.4.7.B012]
at
com.adobe.granite.license.impl.LicenseCheckFilter.doFilter(LicenseCheckFilter.java:308)
[com.adobe.granite.license:1.2.6.CQ640-B0001]
at
org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
[org.apache.felix.http.jetty:3.4.7.B012]
at
org.apache.felix.http.base.interna
[jira] [Created] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)
Konrad Windszus created SLING-8084:
--
Summary: Clarify javadoc for ResourceResolver.map(...)
Key: SLING-8084
URL: https://issues.apache.org/jira/browse/SLING-8084
Project: Sling
Issue Type: Bug
Components: API
Affects Versions: API 2.18.6
Reporter: Konrad Windszus
Currently the javadoc for {{ResourceResolver.map(...)}}
(https://github.com/apache/sling-org-apache-sling-api/blob/ddeb4ec650813d816a8ffca3ac1eec92f7ea53fb/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L283)
does not clearly state whether URI encoding is done within or not.
If I understand
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L160
and
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L362
correctly it will actually do the URI encoding!
It is important to mention that as calling {{ResourceResolver.map}} twice in a
row might lead to a 404 in the end.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8077) Transform ContentOrderMergeProcessor into MergeHandler
[ https://issues.apache.org/jira/browse/SLING-8077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679650#comment-16679650 ] ASF GitHub Bot commented on SLING-8077: --- DominikSuess opened a new pull request #3: SLING-8077 - adding testcoverage and processing of source & target ev… URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/3 …en when being null This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Transform ContentOrderMergeProcessor into MergeHandler > -- > > Key: SLING-8077 > URL: https://issues.apache.org/jira/browse/SLING-8077 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Dominik Süß >Priority: Major > > ContentOrderMergeProcessor as implemented in "Featuremodel - Content > Deployment Exension" currently postprocesses features after merge to set the > default start-order. this only works for cases where features with same order > are getting merged and mandates a sequential merge of features of different > order. > To tackle this issue the extension should take over the actual merge which > allows to preprocess the features before merging and setting the defaults > according to the defaults declared in the particular features before doing > the merge. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8081) NoClassDefFoundError: javax/jcr/RepositoryException when using without JCR
Carsten Ziegeler created SLING-8081: --- Summary: NoClassDefFoundError: javax/jcr/RepositoryException when using without JCR Key: SLING-8081 URL: https://issues.apache.org/jira/browse/SLING-8081 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Get 2.1.36 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Servlets Get 2.1.38 java.lang.NoClassDefFoundError: javax/jcr/RepositoryException at org.apache.sling.servlets.get.impl.DefaultGetServlet.getDefaultRenderer(DefaultGetServlet.java:212) at org.apache.sling.servlets.get.impl.DefaultGetServlet.init(DefaultGetServlet.java:246) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679942#comment-16679942
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi edited a comment on issue #11: SLING-8032 - Add a MOJO which is
able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437049507
Sure, just give me few minutes, I'll fill a new PR from a fresh new branch!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8080) Almost all ITs fail after the Starter 11 release
[
https://issues.apache.org/jira/browse/SLING-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679780#comment-16679780
]
Robert Munteanu commented on SLING-8080:
Thanks [~cziegeler] . I am using pom dependencies for a single purpose - to tie
in projects with the same version, so in the pom the dependency version is
{{${pom.version}} - I can't see a way to do this with plain feature files.
[~sseif...@pro-vision.de] - you initially introduced support for getting
artifact versions from the POM file in SLING-4880, maybe you can suggest a fix
or at least the general version in which to investigate?
> Almost all ITs fail after the Starter 11 release
>
>
> Key: SLING-8080
> URL: https://issues.apache.org/jira/browse/SLING-8080
> Project: Sling
> Issue Type: Bug
> Components: Starter, Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Critical
>
> Almost all tests fail:
> {noformat}
> [ERROR] Tests run: 575, Failures: 561, Errors: 10, Skipped: 1
> {noformat}
> I noticed that Sling is permanently in the 'Apache Sling is starting up'
> phase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)
[
https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680336#comment-16680336
]
Stefan Seifert commented on SLING-8084:
---
i stumbled about this 8 years ago... SLING-1899
a workaround is to do a URL-decode on the result of the map method for the
further processing.
> Clarify javadoc for ResourceResolver.map(...)
> -
>
> Key: SLING-8084
> URL: https://issues.apache.org/jira/browse/SLING-8084
> Project: Sling
> Issue Type: Bug
> Components: API
>Affects Versions: API 2.18.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: API 2.18.6
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the javadoc for {{ResourceResolver.map(...)}}
> (https://github.com/apache/sling-org-apache-sling-api/blob/ddeb4ec650813d816a8ffca3ac1eec92f7ea53fb/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L283)
> does not clearly state whether URI encoding is done within or not.
> If I understand
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L160
> and
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L362
> correctly it will actually do the URI encoding!
> It is important to mention that as calling {{ResourceResolver.map}} twice in
> a row might lead to a 404 in the end.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679638#comment-16679638
]
ASF GitHub Bot commented on SLING-8032:
---
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436965172
Ah yes, you're right of course. the validation is too late.
So we should probably move the validation out of the mojo into the
Preprocessor (which reads the json files). The method preprocessFeature looks
like a good place to add the validation.
This method currently does
- variable substitution
- adds the "id" property if it is missing
So I think we should change that method to:
- add the "id" property if it is missing
- validate the feature
- variable substitution
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679571#comment-16679571
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436948124
awesome - would it be OK to have it under `META-INF/feature` or better
something else?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)
[
https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-8084:
--
Assignee: Konrad Windszus
> Clarify javadoc for ResourceResolver.map(...)
> -
>
> Key: SLING-8084
> URL: https://issues.apache.org/jira/browse/SLING-8084
> Project: Sling
> Issue Type: Bug
> Components: API
>Affects Versions: API 2.18.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: API 2.18.6
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the javadoc for {{ResourceResolver.map(...)}}
> (https://github.com/apache/sling-org-apache-sling-api/blob/ddeb4ec650813d816a8ffca3ac1eec92f7ea53fb/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L283)
> does not clearly state whether URI encoding is done within or not.
> If I understand
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L160
> and
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L362
> correctly it will actually do the URI encoding!
> It is important to mention that as calling {{ResourceResolver.map}} twice in
> a row might lead to a 404 in the end.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)
[
https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679850#comment-16679850
]
Konrad Windszus commented on SLING-8084:
PR with proposed change:
https://github.com/apache/sling-org-apache-sling-api/pull/7/files.
[~cziegeler] and [~rombert] Can you check?
> Clarify javadoc for ResourceResolver.map(...)
> -
>
> Key: SLING-8084
> URL: https://issues.apache.org/jira/browse/SLING-8084
> Project: Sling
> Issue Type: Bug
> Components: API
>Affects Versions: API 2.18.4
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: API 2.18.6
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the javadoc for {{ResourceResolver.map(...)}}
> (https://github.com/apache/sling-org-apache-sling-api/blob/ddeb4ec650813d816a8ffca3ac1eec92f7ea53fb/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L283)
> does not clearly state whether URI encoding is done within or not.
> If I understand
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L160
> and
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/e017ace802aa55805727bd6f5637939599d19ac4/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L362
> correctly it will actually do the URI encoding!
> It is important to mention that as calling {{ResourceResolver.map}} twice in
> a row might lead to a 404 in the end.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[RESULT] [VOTE] Release Apache Sling Models API 1.3.8
Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Daniel Klco, Robert Munteanu, Karl Pauls, Radu Cotescu, Georg Henzler I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. stefan
[jira] [Closed] (SLING-7863) Models API: Add missing Nullability annotations to ModelFactory interface
[
https://issues.apache.org/jira/browse/SLING-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed SLING-7863.
-
> Models API: Add missing Nullability annotations to ModelFactory interface
> -
>
> Key: SLING-7863
> URL: https://issues.apache.org/jira/browse/SLING-7863
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Sling Models API 1.3.6
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Labels: models
> Fix For: Sling Models API 1.3.8
>
>
> the interface {{org.apache.sling.models.factory.ModelFactory}} is missing
> some nullability annotations on it's method signatures.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680037#comment-16680037
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi commented on a change in pull request #17: SLING-8032 - Add a
MOJO which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231987768
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -256,6 +305,8 @@ protected void readProjectFeatures(
throw new RuntimeException("Unable to read feature " +
file.getAbsolutePath(), io);
}
+checkFeatureFileValidation(file);
+
Review comment:
I got it - please check my latest commit, validation now happens
`preprocessFeature` invocation :P
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680055#comment-16680055
]
ASF GitHub Bot commented on SLING-8032:
---
cziegeler closed pull request #17: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680023#comment-16680023
]
ASF GitHub Bot commented on SLING-8032:
---
cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO
which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231982937
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -256,6 +305,8 @@ protected void readProjectFeatures(
throw new RuntimeException("Unable to read feature " +
file.getAbsolutePath(), io);
}
+checkFeatureFileValidation(file);
+
Review comment:
The id is completely missing :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680095#comment-16680095
]
Carsten Ziegeler commented on SLING-8032:
-
[~simone.tripodi] I've added a configuration option "validateFeatures" which
defaults to true and can be set to false to disable feature validation
With this I think everything is done, thanks for the work!
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680052#comment-16680052
]
ASF GitHub Bot commented on SLING-8032:
---
cziegeler commented on issue #17: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#issuecomment-437086598
Thanks for the all the work @simonetripodi
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679975#comment-16679975
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi commented on a change in pull request #17: SLING-8032 - Add a
MOJO which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231961797
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -404,6 +455,7 @@ public Feature provide(final ArtifactId id) {
// "external" dependency, we can already resolve it
final File featureFile =
ProjectHelper.getOrResolveArtifact(info.project, env.session,
env.artifactHandlerManager, env.resolver, id).getFile();
+ checkFeatureFileValidation(featureFile);
Review comment:
makes sense, I'll drop that
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679981#comment-16679981
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi commented on a change in pull request #17: SLING-8032 - Add a
MOJO which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231964057
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -256,6 +305,8 @@ protected void readProjectFeatures(
throw new RuntimeException("Unable to read feature " +
file.getAbsolutePath(), io);
}
+checkFeatureFileValidation(file);
+
Review comment:
not yet interpolated variables in the `id` field are not an issue under
Validation point of view, the Schema Validator just checks the `id` is a String
and that looks like a MVN id/url
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema
[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680051#comment-16680051
]
ASF GitHub Bot commented on SLING-8032:
---
simonetripodi commented on a change in pull request #17: SLING-8032 - Add a
MOJO which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231987768
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -256,6 +305,8 @@ protected void readProjectFeatures(
throw new RuntimeException("Unable to read feature " +
file.getAbsolutePath(), io);
}
+checkFeatureFileValidation(file);
+
Review comment:
I got it - please check my latest commit, validation now happens over
`preprocessFeature` invocation result :P
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> --
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] simonetripodi commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
simonetripodi commented on a change in pull request #17: SLING-8032 - Add a
MOJO which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231987768
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -256,6 +305,8 @@ protected void readProjectFeatures(
throw new RuntimeException("Unable to read feature " +
file.getAbsolutePath(), io);
}
+checkFeatureFileValidation(file);
+
Review comment:
I got it - please check my latest commit, validation now happens over
`preprocessFeature` invocation result :P
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cziegeler closed pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
cziegeler closed pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cziegeler commented on issue #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
cziegeler commented on issue #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#issuecomment-437086598 Thanks for the all the work @simonetripodi This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] simonetripodi commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
simonetripodi commented on a change in pull request #17: SLING-8032 - Add a
MOJO which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231987768
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -256,6 +305,8 @@ protected void readProjectFeatures(
throw new RuntimeException("Unable to read feature " +
file.getAbsolutePath(), io);
}
+checkFeatureFileValidation(file);
+
Review comment:
I got it - please check my latest commit, validation now happens
`preprocessFeature` invocation :P
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO
which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231982937
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -256,6 +305,8 @@ protected void readProjectFeatures(
throw new RuntimeException("Unable to read feature " +
file.getAbsolutePath(), io);
}
+checkFeatureFileValidation(file);
+
Review comment:
The id is completely missing :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] simonetripodi commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
simonetripodi commented on a change in pull request #17: SLING-8032 - Add a
MOJO which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231964057
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -256,6 +305,8 @@ protected void readProjectFeatures(
throw new RuntimeException("Unable to read feature " +
file.getAbsolutePath(), io);
}
+checkFeatureFileValidation(file);
+
Review comment:
not yet interpolated variables in the `id` field are not an issue under
Validation point of view, the Schema Validator just checks the `id` is a String
and that looks like a MVN id/url
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] simonetripodi commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
simonetripodi commented on a change in pull request #17: SLING-8032 - Add a
MOJO which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231961797
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -404,6 +455,7 @@ public Feature provide(final ArtifactId id) {
// "external" dependency, we can already resolve it
final File featureFile =
ProjectHelper.getOrResolveArtifact(info.project, env.session,
env.artifactHandlerManager, env.resolver, id).getFile();
+ checkFeatureFileValidation(featureFile);
Review comment:
makes sense, I'll drop that
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO
which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231959908
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -256,6 +305,8 @@ protected void readProjectFeatures(
throw new RuntimeException("Unable to read feature " +
file.getAbsolutePath(), io);
}
+checkFeatureFileValidation(file);
+
Review comment:
If you validate the file, the validation might fail as the "id" property
might not be set, this will be set by calling the next method, so validation
should happen within that method
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO
which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231959205
##
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##
@@ -404,6 +455,7 @@ public Feature provide(final ArtifactId id) {
// "external" dependency, we can already resolve it
final File featureFile =
ProjectHelper.getOrResolveArtifact(info.project, env.session,
env.artifactHandlerManager, env.resolver, id).getFile();
+ checkFeatureFileValidation(featureFile);
Review comment:
I think we should not validate external features as these are released in
maven already and therefore should be validated already
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437055060 @cziegeler please refer to https://github.com/apache/sling-slingfeature-maven-plugin/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] simonetripodi closed pull request #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
simonetripodi closed pull request #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] simonetripodi opened a new pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
simonetripodi opened a new pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] simonetripodi edited a comment on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
simonetripodi edited a comment on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437049507 Sure, just give me few minutes, I'll fill a new PR from a fresh new branch! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437049507 Sure, just give me few minutes! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437047260 Hi @simonetripodi Could you please rebase your branch against master? The listed changes contain a lot of stuff from master This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437044956 Hi @cziegeler please check the updated branch, validation is now in the `Preprocessor` and proposed MOJO does not exist anymore. Any feedback will be more than appreciated :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DominikSuess opened a new pull request #4: SLING-8085 - adjusting ContentHandler to properly incorporating layer…
DominikSuess opened a new pull request #4: SLING-8085 - adjusting ContentHandler to properly incorporating layer… URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/4 …ing flow as implemented in JCRVLT-319 (based on SNAPSHOT for now) / adding testcoverage This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [PROPOSAL] Moving integration tests closer to the code they test
On Thu, 2018-11-08 at 14:37 +0100, Bertrand Delacretaz wrote: > Hi, > > On Wed, Nov 7, 2018 at 5:29 PM Robert Munteanu > wrote: > > ... > > https://cwiki.apache.org/confluence/display/SLING/Moving+integration+tests+closer+to+the+code+they+test > > ... > > I think it's a great idea to have tests closer to their code, while > also running a large test suite against a "complete" Sling instance. > > Not all tests might make sense in the global test suite however, but > that's easily fixable using test annotations or tags I suppose. +1 on that. FWIW, my plan would be to first move some/most of the ITs from the launchpad.integration-testing module to specific modules - e.g. servlets.get, servlets.post, resourceresolver. To keep things simple, we could create an annotation or a naming convention that would exclude certain tests that don't make sense for the launchpad IT run. Robert
Re: [PROPOSAL] Moving integration tests closer to the code they test
Hi, On Wed, Nov 7, 2018 at 5:29 PM Robert Munteanu wrote: > ... > https://cwiki.apache.org/confluence/display/SLING/Moving+integration+tests+closer+to+the+code+they+test > ... I think it's a great idea to have tests closer to their code, while also running a large test suite against a "complete" Sling instance. Not all tests might make sense in the global test suite however, but that's easily fixable using test annotations or tags I suppose. -Bertrand
Re: [PROPOSAL] Moving integration tests closer to the code they test
Hi Valentin, On Wed, 2018-11-07 at 21:05 +0100, Valentin Olteanu wrote: > I just wanted to drop [1] which can give you some guidelines on where > to > put the tests. It shows the drawbacks of having the tests in > src/test/ and > it states that the preferred way is to create a separate project. > > [1] > https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html Thanks for that link. I see that the intended drawback is Note: The downside of this solution is that you don't get the transitive test-scoped dependencies automatically. That's definitely something to keep in mind. I don't think it's a huge drawback for us since we will be reassembling multiple test artifacts with similar requirements into a single module. Actually, I would say that it's a plus since we get to control the dependencies rather than get a mess from potentially different dependencies from the test modules. Robert
[GitHub] bosschaert commented on issue #3: SLING-8077 - adding testcoverage and processing of source & target ev…
bosschaert commented on issue #3: SLING-8077 - adding testcoverage and processing of source & target ev… URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/3#issuecomment-436984676 Thanks for the additional tests @DominikSuess ! It's merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bosschaert closed pull request #3: SLING-8077 - adding testcoverage and processing of source & target ev…
bosschaert closed pull request #3: SLING-8077 - adding testcoverage and
processing of source & target ev…
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/3
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pom.xml b/pom.xml
index f5c121d..e467dcf 100644
--- a/pom.xml
+++ b/pom.xml
@@ -192,5 +192,18 @@
1.3.1
compile
+
+
+junit
+junit
+test
+
+
+
+org.mockito
+mockito-core
+2.23.0
+test
+
diff --git
a/src/main/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessor.java
b/src/main/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessor.java
index 05b1133..9289e4c 100644
---
a/src/main/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessor.java
+++
b/src/main/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessor.java
@@ -24,13 +24,15 @@
import org.apache.sling.feature.KeyValueMap;
import org.apache.sling.feature.builder.HandlerContext;
import org.apache.sling.feature.builder.MergeHandler;
-import org.apache.sling.feature.builder.PostProcessHandler;
public class ContentOrderMergeProcessor implements MergeHandler {
-private static final String DEFAULT_CONTENT_START_ORDER =
"default.content.startorder";
+public static final String DEFAULT_CONTENT_START_ORDER =
"default.content.startorder";
-private void processFeature(HandlerContext context, Feature feature,
Extension extension) {
+private void processFeature(Feature feature, Extension extension) {
+if (feature == null) {
+return;
+}
String defaultOrder =
feature.getVariables().get(DEFAULT_CONTENT_START_ORDER);
if (defaultOrder != null) {
for (Artifact a : extension.getArtifacts()) {
@@ -51,12 +53,14 @@ public boolean canMerge(Extension extension) {
@Override
public void merge(HandlerContext context, Feature target, Feature source,
Extension targetEx, Extension sourceEx) {
+
+processFeature(target, targetEx);
+processFeature(source, sourceEx);
+
if (targetEx == null) {
target.getExtensions().add(sourceEx);
return;
}
-processFeature(context, target, targetEx);
-processFeature(context, source, sourceEx);
for (final Artifact a : sourceEx.getArtifacts()) {
boolean replace = true;
final Artifact existing =
targetEx.getArtifacts().getSame(a.getId());
diff --git
a/src/test/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessorTest.java
b/src/test/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessorTest.java
new file mode 100644
index 000..15c5b8f
--- /dev/null
+++
b/src/test/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessorTest.java
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.sling.feature.extension.content;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Set;
+
+import org.apache.sling.feature.Artifact;
+import org.apache.sling.feature.ArtifactId;
+import org.apache.sling.feature.Artifacts;
+import org.apache.sling.feature.Extension;
+import org.apache.sling.feature.ExtensionType;
+import org.apache.sling.feature.Feature;
+import org.apache.sling.feature.builder.HandlerContext;
+import org.junit.Test;
+import org.mockito.Mock;
+
+public class ContentOrderMergeProcessorTest {
+
+@Mock
+HandlerContext handlerContext;
+
+@Test
+public void testMergeDifferentStartOrders() {
+final Artifacts targetArtifacts = new Artifacts();
+
+final ArtifactId tid1 = ArtifactId.fromMvnId("sling:ta
Re: [VOTE] Release Apache Sling Service User Mapper 1.4.4
+1 > On 7 Nov 2018, at 17:00, Karl Pauls wrote: > > Please vote to approve these releases: > > [ ] +1 Approve the releases > [ ] 0 Don't care > [ ] -1 Don't release, because ...
[GitHub] cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436978949 Yes, an invalid json can't be read anyway This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436972355 OK, so validation is turned _on_ by default? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DominikSuess opened a new pull request #3: SLING-8077 - adding testcoverage and processing of source & target ev…
DominikSuess opened a new pull request #3: SLING-8077 - adding testcoverage and processing of source & target ev… URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/3 …en when being null This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436965172 Ah yes, you're right of course. the validation is too late. So we should probably move the validation out of the mojo into the Preprocessor (which reads the json files). The method preprocessFeature looks like a good place to add the validation. This method currently does - variable substitution - adds the "id" property if it is missing So I think we should change that method to: - add the "id" property if it is missing - validate the feature - variable substitution This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436962821 @cziegeler there is one problem on accessing to Feature files via `ProjectHelper#getFeatures`: they are parsed. So, if our internal JSON parser detects a violation, there will be no chance the Feature file will ever be validated due to runtime errors, i.e.: ``` [main] [ERROR] Internal error: java.lang.RuntimeException: Unable to read feature /Users/stripodi/Documents/cq-workspace/sling-slingfeature-maven-plugin/target/it/schema-validation-ko/src/main/features/invalid-feature.json: /Users/stripodi/Documents/cq-workspace/sling-slingfeature-maven-plugin/target/it/schema-validation-ko/src/main/features/invalid-feature.json : Key model-version is not one of the allowed types [class java.lang.String] : class java.lang.Long -> [Help 1] org.apache.maven.InternalErrorException: Internal error: java.lang.RuntimeException: Unable to read feature /Users/stripodi/Documents/cq-workspace/sling-slingfeature-maven-plugin/target/it/schema-validation-ko/src/main/features/invalid-feature.json ``` Any idea on how to work around this? TIA! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cziegeler closed pull request #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
cziegeler closed pull request #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] simonetripodi opened a new pull request #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
simonetripodi opened a new pull request #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/11 schema definition moved from sling-org-apache-sling-feature to sling-org-apache-sling-feature-io This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache Sling Service User Mapper 1.4.4
+1 Am 07.11.2018 um 17:00 schrieb Karl Pauls: I would like to call a vote on the following release, Apache Sling Service User Mapper 1.4.4 We solved 1 issue in this release: https://issues.apache.org/jira/projects/SLING/versions/12344048 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2009/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 2009 /tmp/sling-staging Please vote to approve these releases: [ ] +1 Approve the releases [ ] 0 Don't care [ ] -1 Don't release, because ... -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[GitHub] cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436951654 sounds good to me This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
