[jira] [Updated] (SLING-8640) Add a Feature Launcher Mojo to Sling Feature Maven Plugin

[Andreas Schaefer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Schaefer updated SLING-8640:

Fix Version/s: (was: Sling Pax Exam Utilities 1.0.6)
   slingfeature-maven-plugin 1.0.8

> Add a Feature Launcher Mojo to Sling Feature Maven Plugin
> -
>
> Key: SLING-8640
> URL: https://issues.apache.org/jira/browse/SLING-8640
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.0.6
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.8
>
>
> The final step of creating a Feature Model is to launch it. As this is part 
> of that process the launching should be added to this plugin so that a 
> project can be launched from a profile or so.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-8640) Add a Feature Launcher Mojo to Sling Feature Maven Plugin

[Andreas Schaefer (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908693#comment-16908693
 ] 

Andreas Schaefer commented on SLING-8640:
-

Created a PR for this: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/35

> Add a Feature Launcher Mojo to Sling Feature Maven Plugin
> -
>
> Key: SLING-8640
> URL: https://issues.apache.org/jira/browse/SLING-8640
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.0.6
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
>
> The final step of creating a Feature Model is to launch it. As this is part 
> of that process the launching should be added to this plugin so that a 
> project can be launched from a profile or so.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [sling-slingfeature-maven-plugin] schaefa opened a new pull request #35: Created a Feature Launcher Mojo (launch-features)

[GitBox]

schaefa opened a new pull request #35: Created a Feature Launcher Mojo 
(launch-features)
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/35
 
 
   The Feature Launcher Mojo accepts all the current parameter of the Feature 
Launcher even though the documentary of the parameters is missing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (SLING-8640) Add a Feature Launcher Mojo to Sling Feature Maven Plugin

[Andreas Schaefer (JIRA)]

Andreas Schaefer created SLING-8640:
---

 Summary: Add a Feature Launcher Mojo to Sling Feature Maven Plugin
 Key: SLING-8640
 URL: https://issues.apache.org/jira/browse/SLING-8640
 Project: Sling
  Issue Type: New Feature
  Components: Feature Model
Affects Versions: slingfeature-maven-plugin 1.0.6
Reporter: Andreas Schaefer
 Fix For: Sling Pax Exam Utilities 1.0.6


The final step of creating a Feature Model is to launch it. As this is part of 
that process the launching should be added to this plugin so that a project can 
be launched from a profile or so.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Assigned] (SLING-8640) Add a Feature Launcher Mojo to Sling Feature Maven Plugin

[Andreas Schaefer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Schaefer reassigned SLING-8640:
---

Assignee: Andreas Schaefer

> Add a Feature Launcher Mojo to Sling Feature Maven Plugin
> -
>
> Key: SLING-8640
> URL: https://issues.apache.org/jira/browse/SLING-8640
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.0.6
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: Sling Pax Exam Utilities 1.0.6
>
>
> The final step of creating a Feature Model is to launch it. As this is part 
> of that process the launching should be added to this plugin so that a 
> project can be launched from a profile or so.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Re: Sling Feature Launcher: Issue with Content Packages

[Andreas Schaefer]

Could it be that the issue is with the ‘cloud launcher’ as the ‘jcrinstall’ 
works.

Here is a test project that will showcase the issue:

https://github.com/schaefa/cpconverter-ssue-fm-starter/tree/issue/cp-not-launching
 


- Andy

> On Aug 15, 2019, at 4:02 PM, Andreas Schaefer  
> wrote:
> 
> Hi
> 
> When I convert and Launch the Peregrine CMS then I see that all converted 
> Content Packages remain in ‘Untransformed Resources’ state when I look at the 
> /system/console/osgi-installer page.
> 
> Is there a way to figure out why they remain in that state?
> 
> I set the launcher to verbose but I do not see anything showing up nor do I 
> see any issues in the error.log.
> 
> Cheers - Andy Schaefer

Sling Feature Launcher: Issue with Content Packages

[Andreas Schaefer]

Hi

When I convert and Launch the Peregrine CMS then I see that all converted 
Content Packages remain in ‘Untransformed Resources’ state when I look at the 
/system/console/osgi-installer page.

Is there a way to figure out why they remain in that state?

I set the launcher to verbose but I do not see anything showing up nor do I see 
any issues in the error.log.

Cheers - Andy Schaefer

[jira] [Created] (SLING-8639) VltUtils does not escape path in when creating filter patterns

[Timothee Maret (JIRA)]

Timothee Maret created SLING-8639:
-

 Summary: VltUtils does not escape path in when creating filter 
patterns
 Key: SLING-8639
 URL: https://issues.apache.org/jira/browse/SLING-8639
 Project: Sling
  Issue Type: Bug
  Components: Content Distribution
Affects Versions: Content Distribution Core 0.4.0
Reporter: Timothee Maret
 Fix For: Content Distribution Core 0.4.2


When distributing a deep content path that includes parenthesis using 
FileVault, the content package produced does not contain content under that 
path.

As an example, consider distributing the following path
{code:java}
/content/dam/we-retail/planet(1).jpg{code}
which will yield a content package with the following filter.xml
{code:java}










{code}
The include and exclude patterns are treated by FileVault [as regular 
expression|https://github.com/apache/jackrabbit-filevault/blob/6df76ba4a45316a84ec1cd10636296d191a82260/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/filter/DefaultPathFilter.java#L84].

Thus the {{(1)}} part of the {{/content/dam/we-retail/planet(1).jpg}} and 
{{/content/dam/we-retail/planet(1).jpg/.*}} patterns is treated as a group 
rather than literally.

The path should be escaped when building the patterns, in 
https://github.com/apache/sling-org-apache-sling-distribution-core/blob/3d51ac0b09c9a057b590349727392eaedba26aea/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VltUtils.java#L84



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

RE: [VOTE] Release Apache Sling Context-Aware Configuration API 1.2.0, Context-Aware Configuration Impl 1.5.0

[Stefan Seifert]

+1

[VOTE] Release Apache Sling Context-Aware Configuration API 1.2.0, Context-Aware Configuration Impl 1.5.0

[Stefan Seifert]

Hi,

Context-Aware Configuration API 1.2.0  (2 issues)
https://issues.apache.org/jira/browse/SLING/fixforversion/12344000

Context-Aware Configuration Impl 1.5.0  (3 issues)
https://issues.apache.org/jira/browse/SLING/fixforversion/12345451

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2113/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2113 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

stefan

[jira] [Resolved] (SLING-8638) caconfig-impl: Switch from legacy commons collections 3 to commons collections 4

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-8638.
---
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-caconfig-impl/commit/60e1346f44efe72410b50f3f70938e56ea306ae4

> caconfig-impl: Switch from legacy commons collections 3 to commons 
> collections 4
> 
>
> Key: SLING-8638
> URL: https://issues.apache.org/jira/browse/SLING-8638
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Context-Aware Configuration Impl 1.4.16
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
>  Labels: contextaware-config
> Fix For: Context-Aware Configuration Impl 1.5.0
>
>
> caconfig-impl still use the legacy commons collections 3 version
> It should be updated to use commons collections 4.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (SLING-8272) ConfigurationBuilder: Add method to check for the existence of the config

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-8272:
--
Issue Type: New Feature  (was: Improvement)

> ConfigurationBuilder: Add method to check for the existence of the config
> -
>
> Key: SLING-8272
> URL: https://issues.apache.org/jira/browse/SLING-8272
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: Context-Aware Configuration API 1.1.2, Context-Aware 
> Configuration Impl 1.4.14
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Context-Aware Configuration API 1.1.4, Context-Aware 
> Configuration Impl 1.4.18
>
>  Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> Sometimes it is desirable to check if a Context Aware Configuration is there 
> at all via the high level API. Both methods {{as}} and {{asCollection}} will 
> never return null, as they will always consider the default values. All other 
> methods require to set at least a name.
> So to simply check if a CAC content resource is existing for a certain 
> annotation class (defining a Context Aware Configuration) the following code 
> is necessary:
> {code}
> ConfigurationBuilder builder = 
> contentResource.adaptTo(ConfigurationBuilder.class);
> builder.name().valueMap().isEmpty();
> {code}
> As there is no method exported to derive the name from an annotation type 
> this would require additional custom code.
> I propose to add a simple 
> {code}
> boolean has(@NotNull java.lang.Class clazz)
> {code}
> which is only then supposed to return {{true}} in case there is an underlying 
> CAC content resource which can be adapted to the given class.
> Compare also with 
> https://www.mail-archive.com/dev@sling.apache.org/msg83617.html.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (SLING-7954) Switch from legacy commons collections 3 to commons collections 4

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-7954:
--
Fix Version/s: (was: Context-Aware Configuration Impl 1.4.18)
  Description: 
The following bundles still use the legacy commons collections 3 version
They should be updated to use commons collections 4
com.composum.core.commons 
org.apache.jackrabbit.jackrabbit-spi-commons 
org.apache.jackrabbit.vault 
org.apache.sling.models.jacksonexporter
org.apache.sling.scripting.javascript 
org.apache.sling.xss 

  was:
The following bundles still use the legacy commons collections 3 version
They should be updated to use commons collections 4
com.composum.core.commons 
org.apache.jackrabbit.jackrabbit-spi-commons 
org.apache.jackrabbit.vault 
org.apache.sling.caconfig.impl 
org.apache.sling.models.jacksonexporter
org.apache.sling.scripting.javascript 
org.apache.sling.xss 


i've created a seprate issue for {{org.apache.sling.caconfig.impl}}: SLING-8638

> Switch from legacy commons collections 3 to commons collections 4
> -
>
> Key: SLING-7954
> URL: https://issues.apache.org/jira/browse/SLING-7954
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Priority: Major
> Fix For: Sling Models Jackson Exporter 1.0.10, Scripting 
> JavaScript 3.0.6, XSS Protection API 2.2.0
>
>
> The following bundles still use the legacy commons collections 3 version
> They should be updated to use commons collections 4
> com.composum.core.commons 
> org.apache.jackrabbit.jackrabbit-spi-commons 
> org.apache.jackrabbit.vault 
> org.apache.sling.models.jacksonexporter
> org.apache.sling.scripting.javascript 
> org.apache.sling.xss 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Created] (SLING-8638) caconfig-impl: Switch from legacy commons collections 3 to commons collections 4

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-8638:
-

 Summary: caconfig-impl: Switch from legacy commons collections 3 
to commons collections 4
 Key: SLING-8638
 URL: https://issues.apache.org/jira/browse/SLING-8638
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Context-Aware Configuration Impl 1.4.16
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Context-Aware Configuration Impl 1.4.18


caconfig-impl still use the legacy commons collections 3 version
It should be updated to use commons collections 4.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-8630) Converter must not replace existing POM files

[Andreas Schaefer (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908363#comment-16908363
 ] 

Andreas Schaefer commented on SLING-8630:
-

Created PR for the change in the CP Converter: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/16

> Converter must not replace existing POM files
> -
>
> Key: SLING-8630
> URL: https://issues.apache.org/jira/browse/SLING-8630
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When the output folder for the converted feature is set to the local Maven 
> repo (~/.m2/repository) then an existing POM is overwritten by the converter 
> with the generated one. This can and will change the behavior of Maven for 
> other projects. So, if a POM file exists then it should not be replaced and 
> even if the existing POM is the generated it is not necessary as this file 
> should not change otherwise the POM will be placed somewhere else.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Resolved] (SLING-8637) caconfig-impl: Lower loglevel vor warning in DefaultConfigurationResourceResolvingStrategy

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-8637.
---
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-caconfig-impl/commit/5ebaffaebab455f34e61d7caaa677406e94dacb9

> caconfig-impl: Lower loglevel vor warning in 
> DefaultConfigurationResourceResolvingStrategy
> --
>
> Key: SLING-8637
> URL: https://issues.apache.org/jira/browse/SLING-8637
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Context-Aware Configuration Impl 1.4.16
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Trivial
>  Labels: contextaware-config
> Fix For: Context-Aware Configuration Impl 1.4.18
>
>
> in 
> {{org.apache.sling.caconfig.resource.impl.def.DefaultConfigurationResourceResolvingStrategy}}
>  it happens that the following warnings are reported:
> {noformat}
> Ignoring reference to /conf.../settings from /conf/.../settings - Probably 
> misconfigured as it ends with '/settings'
> {noformat}
> the ignoring is correct, but we should log this only on DEBUG level, not at 
> WARN level.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Created] (SLING-8637) caconfig-impl: Lower loglevel vor warning in DefaultConfigurationResourceResolvingStrategy

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-8637:
-

 Summary: caconfig-impl: Lower loglevel vor warning in 
DefaultConfigurationResourceResolvingStrategy
 Key: SLING-8637
 URL: https://issues.apache.org/jira/browse/SLING-8637
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Context-Aware Configuration Impl 1.4.16
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Context-Aware Configuration Impl 1.4.18


in 
{{org.apache.sling.caconfig.resource.impl.def.DefaultConfigurationResourceResolvingStrategy}}
 it happens that the following warnings are reported:

{noformat}
Ignoring reference to /conf.../settings from /conf/.../settings - Probably 
misconfigured as it ends with '/settings'
{noformat}

the ignoring is correct, but we should log this only on DEBUG level, not at 
WARN level.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Re: Request for the Sling Feature Converter Maven Plugin to become a Sling Module

[Andreas Schaefer]

Hi Robert

I merged the branch into master and so it should show there.

I will do some more testing today but as soon as the git repo is created I will 
move the code over.

Thanks - Andy

> On Aug 15, 2019, at 2:25 AM, Robert Munteanu  wrote:
> 
> Hi Andy,
> 
> On Wed, 2019-08-14 at 18:47 -0700, Andreas Schaefer wrote:
>> Hi
>> 
>> I am aware that this is a long shot but this Maven Plugin can make
>> life easier for User that want to convert Sling into a Feature as
>> well as launching Sling FM with their Content Packages.
> 
> If you think this is useful it's reason enough to create a new
> repository :-)
> 
> Unless someone objects, I will create
> 
>  sling-feature-converter-maven-plugin
> 
> as a new git repository tomorrow.
> 
> See also
> 
>  https://cwiki.apache.org/confluence/display/SLING/Using+Git+with+Sling
> 
> especially the part about importing projects from the whiteboard. I
> would also suggest that you don't use branches for the whiteboard,
> adding changes directly to master makes them more visible and has zero
> chance of breaking anything.
> 
> Thanks,
> 
> Robert
> 
>> 
>> The ticket for this request is: 
>> https://issues.apache.org/jira/browse/SLING-8490 <
>> https://issues.apache.org/jira/browse/SLING-8490>
>> 
>> The project right now is in the Sling Whitespace under branch ‘sling-
>> feature-converter-maven-plugin’ but I will merge this into the
>> ‘master’ branch today or tomorrow.
>> 
>> I use this Plugin to evaluate issues with Content Packages (see 
>> https://github.com/schaefa/cpconverter-ssue-fm-starter/tree/issue/package-group
>> <
>> https://github.com/schaefa/cpconverter-ssue-fm-starter/tree/issue/package-group>
>> ;) which allows me to easily take a Content Package and spin up a
>> Sling FM instance.
>> 
>> This is also used for the Peregrine CMS where we create a Peregrine
>> CMS instance that is started with all content packages installed when
>> the Sling FM instances starts.
>> 
>> There is one sticky point:
>> - In order to get an End-2-End scenario working the FM instance needs
>> to be launched. I am not sure where to place it. From my point of
>> view it is better off in the Sling Feature Maven Plugin as this is
>> the final stage and it not really related to converting anything but
>> I am not sure where you want to place it.
>> 
>> Cheers - Andy Schaefer
> 

[jira] [Resolved] (SLING-8636) Set webconsole.security.provider.id property on the Sling Web Console Security Provider

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert resolved SLING-8636.
-
Resolution: Fixed

#1 merged.

> Set webconsole.security.provider.id property on the Sling Web Console 
> Security Provider
> ---
>
> Key: SLING-8636
> URL: https://issues.apache.org/jira/browse/SLING-8636
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication, Console
>Affects Versions: Web Console Security Provider 1.2.2
>Reporter: David Bosschaert
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Web Console Security Provider 1.2.4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> With FELIX-6168 the Web Console can now require security providers to be 
> present before it activates.
> We should set the service registration property 
> {{webconsole.security.provider.id}} on the security provider to identify it 
> so that it can be required using the mechanism from FELIX-6168



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (SLING-8636) Set webconsole.security.provider.id property on the Sling Web Console Security Provider

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert updated SLING-8636:

Fix Version/s: Web Console Security Provider 1.2.4

> Set webconsole.security.provider.id property on the Sling Web Console 
> Security Provider
> ---
>
> Key: SLING-8636
> URL: https://issues.apache.org/jira/browse/SLING-8636
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication, Console
>Affects Versions: Web Console Security Provider 1.2.2
>Reporter: David Bosschaert
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Web Console Security Provider 1.2.4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> With FELIX-6168 the Web Console can now require security providers to be 
> present before it activates.
> We should set the service registration property 
> {{webconsole.security.provider.id}} on the security provider to identify it 
> so that it can be required using the mechanism from FELIX-6168



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [sling-whiteboard] schaefa merged pull request #48: Feature/sling feature converter maven plugin

[GitBox]

schaefa merged pull request #48: Feature/sling feature converter maven plugin
URL: https://github.com/apache/sling-whiteboard/pull/48
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache Sling Feature Modelconverter 1.0.8 and SlingStart Maven Plugin 1.8.8

[Andreas Schaefer]

+1 (non-binding)

- Andy

> On Aug 15, 2019, at 5:29 AM, Karl Pauls  wrote:
> 
> I would like to call a vote on the following releases:
> 
> Apache Sling Feature Modelconverter 1.0.8
> 
> We solved 1 issue in this release:
> 
> https://issues.apache.org/jira/projects/SLING/versions/12345975
> 
> Apache Sling SlingStart Maven Plugin 1.8.8
> 
> We solved 1 issue in this release:
> 
> https://issues.apache.org/jira/projects/SLING/versions/12345976
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2112/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2112 /tmp/sling-staging
> 
> Please vote to approve these release:
> 
>  [ ] +1 Approve the releases
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...

[jira] [Assigned] (SLING-8636) Set webconsole.security.provider.id property on the Sling Web Console Security Provider

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert reassigned SLING-8636:
---

Assignee: David Bosschaert

> Set webconsole.security.provider.id property on the Sling Web Console 
> Security Provider
> ---
>
> Key: SLING-8636
> URL: https://issues.apache.org/jira/browse/SLING-8636
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication, Console
>Affects Versions: Web Console Security Provider 1.2.2
>Reporter: David Bosschaert
>Assignee: David Bosschaert
>Priority: Major
>
> With FELIX-6168 the Web Console can now require security providers to be 
> present before it activates.
> We should set the service registration property 
> {{webconsole.security.provider.id}} on the security provider to identify it 
> so that it can be required using the mechanism from FELIX-6168



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Created] (SLING-8636) Set webconsole.security.provider.id property on the Sling Web Console Security Provider

[David Bosschaert (JIRA)]

David Bosschaert created SLING-8636:
---

 Summary: Set webconsole.security.provider.id property on the Sling 
Web Console Security Provider
 Key: SLING-8636
 URL: https://issues.apache.org/jira/browse/SLING-8636
 Project: Sling
  Issue Type: Bug
  Components: Authentication, Console
Affects Versions: Web Console Security Provider 1.2.2
Reporter: David Bosschaert


With FELIX-6168 the Web Console can now require security providers to be 
present before it activates.
We should set the service registration property 
{{webconsole.security.provider.id}} on the security provider to identify it so 
that it can be required using the mechanism from FELIX-6168



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #274 is BROKEN

[Apache Jenkins Server]

 
- in org.apache.sling.launchpad.webapp.integrationtest.NodetypeRenderingTest
[INFO] Running org.apache.sling.launchpad.webapp.integrationtest.MkdirTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.15 s - 
in org.apache.sling.launchpad.webapp.integrationtest.MkdirTest
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   MappingEventsProxyTest.runWriteableResourcesTest:26 » JsonGeneration 
write(par...
[INFO] 
[ERROR] Tests run: 660, Failures: 0, Errors: 1, Skipped: 1
[INFO] 
[INFO] 
[INFO] --- slingstart-maven-plugin:1.7.16:stop (stop-container) @ 
org.apache.sling.launchpad.testing ---
[INFO] Stopping 1 Launchpad instances
[INFO] Stopping Launchpad '_-41000'
15.08.2019 14:56:21.941 *INFO * [Apache Sling Terminator] Java VM is shutting 
down
15.08.2019 14:56:21.942 *INFO * [Apache Sling Terminator] Stopping Apache Sling
Warning: Nashorn engine is planned to be removed from a future JDK release
Warning: Nashorn engine is planned to be removed from a future JDK release
15.08.2019 14:56:29.126 *INFO * [Sling Notifier] Apache Sling has been stopped
[INFO] 
[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
org.apache.sling.launchpad.testing ---
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by 
org.codehaus.groovy.reflection.CachedConstructor 
(file:/home/jenkins/.m2/repository/org/codehaus/groovy/groovy-all-minimal/1.5.6/groovy-all-minimal-1.5.6.jar)
 to constructor java.io.File(java.lang.String,java.io.File)
WARNING: Please consider reporting this to the maintainers of 
org.codehaus.groovy.reflection.CachedConstructor
WARNING: Use --illegal-access=warn to enable warnings of further illegal 
reflective access operations
WARNING: All illegal access operations will be denied in a future release
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-12-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-12-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- apache-rat-plugin:0.11:check (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: src/main/appended-resources/META-INF/*
[INFO] Exclude: velocity.log
[INFO] Exclude: target/*
[INFO] Exclude: README.md
[INFO] Exclude: maven-eclipse.xml
[INFO] Exclude: .*
[INFO] Exclude: .*/**
[INFO] Exclude: **/*.json
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: **/*.rej
[INFO] Exclude: hs_err_*.log
[INFO] Exclude: **/repository/index/*/index-details.txt
[INFO] Exclude: bnd.bnd
[INFO] 7 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 6 licence.
[INFO] 
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  03:48 min
[INFO] Finished at: 2019-08-15T14:56:30Z
[INFO] 
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master@tmp/withMaven1a7bdcc2/maven-spy-20190815-145241-90815768641578105131927.log
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on 
project org.apache.sling.launchpad.testing: There are test failures.
[ERROR] 
[ERROR] Please refer to 
/home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master/target/failsafe-reports
 for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[Pipeline] }
[withMaven] Publishers: Pipeline Graph Publisher: 12 ms, JGiven Publisher: 2 ms
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] stage
[Pipeline] { (Notifications)
[Pipeline] echo
Status change is BROKEN, notifications will be sent.
[Pipeline] emailext

[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #273 is FIXED

[Apache Jenkins Server]

Please see 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/273/
 for details.

No further emails will be sent until the status of the build is changed.

Re: [VOTE] Release Apache Sling Feature Modelconverter 1.0.8 and SlingStart Maven Plugin 1.8.8

[David Bosschaert]

+1

David

On Thu, 15 Aug 2019 at 13:29, Karl Pauls  wrote:

> I would like to call a vote on the following releases:
>
> Apache Sling Feature Modelconverter 1.0.8
>
> We solved 1 issue in this release:
>
> https://issues.apache.org/jira/projects/SLING/versions/12345975
>
> Apache Sling SlingStart Maven Plugin 1.8.8
>
> We solved 1 issue in this release:
>
> https://issues.apache.org/jira/projects/SLING/versions/12345976
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2112/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2112 /tmp/sling-staging
>
> Please vote to approve these release:
>
>   [ ] +1 Approve the releases
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>

Re: [RT] Support OSGi R7 Logging

[Karl Pauls]

On Thu, Aug 15, 2019 at 11:38 AM Carsten Ziegeler  wrote:
>
> Am 15.08.2019 um 11:21 schrieb Robert Munteanu:
> > On Thu, 2019-08-15 at 11:12 +0200, Carsten Ziegeler wrote:
> >> Hi Roy,
> >>
> >> I guess my mail is a little bit misleading :)
> >>
> >> It's totally fine to use SLF4J directly and we should keep doing
> >> this.
> >> Under the covers, everything you log to slf4j is routed through the
> >> LogService so other components in the system can listen to log
> >> entries etc.
> >>
> >> So this is about keeping everything as is for clients doing logging
> >> but
> >> just replace the LogService implementation with the Apache Felix one
> >> -
> >> and make sure that we still have todays features in place.
> >
> > +1 from me. I also asked about this a year ago :-)
> >
> >
> > https://lists.apache.org/thread.html/581b9ac69bfa6a8692e6bffc98fe5fdd6f5b4c35989d6b53841f7f10@%3Cdev.sling.apache.org%3E
> >
> That's actually a different ask :)
>
> We have o.a.s.commons.logservice which is an OSGi R6 LogService
> implementation *and* a log listener logging everything to slf4j. My
> suggestion is to replace the LogService impl with Apache Felix Log and
> keep the listener.

I think that would be a good start! +1

> Our logback integration is o.a.s.commons.log which I think is similar to
> the logback stuff in Apache Felix.
>
> Now maybe we can replace all of our stuff with the things from Felix?

That would be even better - but like I mentioned in thread pointed out
by Robert, I don't know enough about it to say what (or whether) that
is possible.

regards,

Karl

> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org



-- 
Karl Pauls
karlpa...@gmail.com

[jira] [Resolved] (SLING-8635) Close resource resolver at the end of each request

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-8635.
-
Resolution: Fixed

Added in rev 24e8b04

> Close resource resolver at the end of each request
> --
>
> Key: SLING-8635
> URL: https://issues.apache.org/jira/browse/SLING-8635
> Project: Sling
>  Issue Type: New Feature
>  Components: Engine
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Engine 2.6.22
>
>
> Http Whiteboard 1.1 supports to logout at the end of each request through the 
> finishSecurity method. We should leverage that and close a resource resolver



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Created] (SLING-8635) Close resource resolver at the end of each request

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-8635:
---

 Summary: Close resource resolver at the end of each request
 Key: SLING-8635
 URL: https://issues.apache.org/jira/browse/SLING-8635
 Project: Sling
  Issue Type: New Feature
  Components: Engine
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Engine 2.6.22


Http Whiteboard 1.1 supports to logout at the end of each request through the 
finishSecurity method. We should leverage that and close a resource resolver



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Re: [VOTE] Release Apache Sling Feature Modelconverter 1.0.8 and SlingStart Maven Plugin 1.8.8

[Radu Cotescu]

+1 (only checked signatures)

> On 15 Aug 2019, at 14:29, Karl Pauls  wrote:
> 
> Please vote to approve these release:
> 
>  [ ] +1 Approve the releases
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...

Re: [VOTE] Release Apache Sling Feature Modelconverter 1.0.8 and SlingStart Maven Plugin 1.8.8

[Carsten Ziegeler]

+1

Carsten

Am 15.08.2019 um 14:29 schrieb Karl Pauls:

I would like to call a vote on the following releases:

Apache Sling Feature Modelconverter 1.0.8

We solved 1 issue in this release:

https://issues.apache.org/jira/projects/SLING/versions/12345975

Apache Sling SlingStart Maven Plugin 1.8.8

We solved 1 issue in this release:

https://issues.apache.org/jira/projects/SLING/versions/12345976

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2112/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2112 /tmp/sling-staging

Please vote to approve these release:

   [ ] +1 Approve the releases
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[VOTE] Release Apache Sling Feature Modelconverter 1.0.8 and SlingStart Maven Plugin 1.8.8

[Karl Pauls]

I would like to call a vote on the following releases:

Apache Sling Feature Modelconverter 1.0.8

We solved 1 issue in this release:

https://issues.apache.org/jira/projects/SLING/versions/12345975

Apache Sling SlingStart Maven Plugin 1.8.8

We solved 1 issue in this release:

https://issues.apache.org/jira/projects/SLING/versions/12345976

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2112/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2112 /tmp/sling-staging

Please vote to approve these release:

  [ ] +1 Approve the releases
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

[jira] [Resolved] (SLING-8634) Update Sling Start Maven Plugin to latest Feature Model Converter

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-8634.
---
Resolution: Fixed

> Update Sling Start Maven Plugin to latest Feature Model Converter
> -
>
> Key: SLING-8634
> URL: https://issues.apache.org/jira/browse/SLING-8634
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Slingstart Maven Plugin 1.8.6
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Slingstart Maven Plugin 1.8.8
>
>
> We should update to the latest Feature Model Converter 1.0.8 when it is 
> released.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Created] (SLING-8634) Update Sling Start Maven Plugin to latest Feature Model Converter

[Karl Pauls (JIRA)]

Karl Pauls created SLING-8634:
-

 Summary: Update Sling Start Maven Plugin to latest Feature Model 
Converter
 Key: SLING-8634
 URL: https://issues.apache.org/jira/browse/SLING-8634
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Affects Versions: Slingstart Maven Plugin 1.8.6
Reporter: Karl Pauls
Assignee: Karl Pauls
 Fix For: Slingstart Maven Plugin 1.8.8


We should update to the latest Feature Model Converter 1.0.8 when it is 
released.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Resolved] (SLING-8633) Use start-order instead of start-level

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-8633.
---
Resolution: Fixed

> Use start-order instead of start-level
> --
>
> Key: SLING-8633
> URL: https://issues.apache.org/jira/browse/SLING-8633
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model Converter 1.0.6
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Converter 1.0.8
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> We have some confusion going on between the start-level and the start-order 
> metadata. The idea is to consolidate around start-order for now. This 
> requires to have the modelconverter read both but output start-order only.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [sling-org-apache-sling-feature-modelconverter] karlpauls merged pull request #4: SLING-8633: Use start-order instead of start-level

[GitBox]

karlpauls merged pull request #4: SLING-8633: Use start-order instead of 
start-level
URL: 
https://github.com/apache/sling-org-apache-sling-feature-modelconverter/pull/4
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-feature-modelconverter] bosschaert commented on issue #4: SLING-8633: Use start-order instead of start-level

[GitBox]

bosschaert commented on issue #4: SLING-8633: Use start-order instead of 
start-level
URL: 
https://github.com/apache/sling-org-apache-sling-feature-modelconverter/pull/4#issuecomment-521588806
 
 
   LGTM  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-feature-modelconverter] karlpauls opened a new pull request #4: SLING-8633: Use start-order instead of start-level

[GitBox]

karlpauls opened a new pull request #4: SLING-8633: Use start-order instead of 
start-level
URL: 
https://github.com/apache/sling-org-apache-sling-feature-modelconverter/pull/4
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (SLING-8632) Add a method to get a JSON object from an extension

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-8632.
-
Resolution: Fixed

Added new methods to get/set a JSON structure from an extension and adjusted IO 
to use these methods 

> Add a method to get a JSON object from an extension
> ---
>
> Key: SLING-8632
> URL: https://issues.apache.org/jira/browse/SLING-8632
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.1.0, Feature Model IO 1.1.0
>
>
> Extensions allow to store JSON objects, however, the method to retrieve that 
> object just returns a string - which in turn requires every consumer to parse 
> the string.
> Initially we wanted to avoid a dependency on JSON api/impl, however as we 
> need it for the merging of features anyway, we can safely add such a method 
> to the API



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (SLING-8632) Add a method to get a JSON object from an extension

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-8632:

Component/s: (was: Feature Flags)
 Feature Model

> Add a method to get a JSON object from an extension
> ---
>
> Key: SLING-8632
> URL: https://issues.apache.org/jira/browse/SLING-8632
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.1.0, Feature Model IO 1.1.0
>
>
> Extensions allow to store JSON objects, however, the method to retrieve that 
> object just returns a string - which in turn requires every consumer to parse 
> the string.
> Initially we wanted to avoid a dependency on JSON api/impl, however as we 
> need it for the merging of features anyway, we can safely add such a method 
> to the API



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (SLING-8632) Add a method to get a JSON object from an extension

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-8632:

Fix Version/s: Feature Model IO 1.1.0

> Add a method to get a JSON object from an extension
> ---
>
> Key: SLING-8632
> URL: https://issues.apache.org/jira/browse/SLING-8632
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Flags
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.1.0, Feature Model IO 1.1.0
>
>
> Extensions allow to store JSON objects, however, the method to retrieve that 
> object just returns a string - which in turn requires every consumer to parse 
> the string.
> Initially we wanted to avoid a dependency on JSON api/impl, however as we 
> need it for the merging of features anyway, we can safely add such a method 
> to the API



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Re: [RT] Support OSGi R7 Logging

[Carsten Ziegeler]

Am 15.08.2019 um 11:21 schrieb Robert Munteanu:

On Thu, 2019-08-15 at 11:12 +0200, Carsten Ziegeler wrote:

Hi Roy,

I guess my mail is a little bit misleading :)

It's totally fine to use SLF4J directly and we should keep doing
this.
Under the covers, everything you log to slf4j is routed through the
LogService so other components in the system can listen to log
entries etc.

So this is about keeping everything as is for clients doing logging
but
just replace the LogService implementation with the Apache Felix one
-
and make sure that we still have todays features in place.


+1 from me. I also asked about this a year ago :-)

   
https://lists.apache.org/thread.html/581b9ac69bfa6a8692e6bffc98fe5fdd6f5b4c35989d6b53841f7f10@%3Cdev.sling.apache.org%3E


That's actually a different ask :)

We have o.a.s.commons.logservice which is an OSGi R6 LogService 
implementation *and* a log listener logging everything to slf4j. My 
suggestion is to replace the LogService impl with Apache Felix Log and 
keep the listener.


Our logback integration is o.a.s.commons.log which I think is similar to 
the logback stuff in Apache Felix.


Now maybe we can replace all of our stuff with the things from Felix?

Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: Request for the Sling Feature Converter Maven Plugin to become a Sling Module

[Robert Munteanu]

Hi Andy,

On Wed, 2019-08-14 at 18:47 -0700, Andreas Schaefer wrote:
> Hi
> 
> I am aware that this is a long shot but this Maven Plugin can make
> life easier for User that want to convert Sling into a Feature as
> well as launching Sling FM with their Content Packages.

If you think this is useful it's reason enough to create a new
repository :-)

Unless someone objects, I will create

  sling-feature-converter-maven-plugin

as a new git repository tomorrow.

See also

  https://cwiki.apache.org/confluence/display/SLING/Using+Git+with+Sling

especially the part about importing projects from the whiteboard. I
would also suggest that you don't use branches for the whiteboard,
adding changes directly to master makes them more visible and has zero
chance of breaking anything.

Thanks,

Robert

> 
> The ticket for this request is: 
> https://issues.apache.org/jira/browse/SLING-8490 <
> https://issues.apache.org/jira/browse/SLING-8490>
> 
> The project right now is in the Sling Whitespace under branch ‘sling-
> feature-converter-maven-plugin’ but I will merge this into the
> ‘master’ branch today or tomorrow.
> 
> I use this Plugin to evaluate issues with Content Packages (see 
> https://github.com/schaefa/cpconverter-ssue-fm-starter/tree/issue/package-group
> <
> https://github.com/schaefa/cpconverter-ssue-fm-starter/tree/issue/package-group>
> ;) which allows me to easily take a Content Package and spin up a
> Sling FM instance.
> 
> This is also used for the Peregrine CMS where we create a Peregrine
> CMS instance that is started with all content packages installed when
> the Sling FM instances starts.
> 
> There is one sticky point:
> - In order to get an End-2-End scenario working the FM instance needs
> to be launched. I am not sure where to place it. From my point of
> view it is better off in the Sling Feature Maven Plugin as this is
> the final stage and it not really related to converting anything but
> I am not sure where you want to place it.
> 
> Cheers - Andy Schaefer

Re: [DISCUSS] Switching o.a.s.starter-content to use scripts and resources?

[Robert Munteanu]

On Thu, 2019-08-15 at 00:10 +0200, Georg Henzler wrote:
> > Replying to myself here - the /content/startup/index.html file is
> > different from the /content/starter/index.html one, so no change is
> > required here.
> 
> Sorry for the late reply - so fixed perfectly via SLING-8615. The
> file
> /content/startup/index.html used to be loaded from starter-startup
> [1],
> I only recently moved it to starter-content. 

Thanks for confirming, Georg.

> It's a good thing to have
> it closer together with the regular content, unfortunately for
> /content/starter/index.html we can still not use scripts and
> resources
> as the Sling engine is not ready yet during early startup.


Do you mean /content/startup/index.html here?

Robert


> -Georg
> 
> [1] 
> https://github.com/apache/sling-org-apache-sling-starter-startup/blob/maintenance/src/main/resources/index.html

[jira] [Created] (SLING-8633) Use start-order instead of start-level

[Karl Pauls (JIRA)]

Karl Pauls created SLING-8633:
-

 Summary: Use start-order instead of start-level
 Key: SLING-8633
 URL: https://issues.apache.org/jira/browse/SLING-8633
 Project: Sling
  Issue Type: Bug
  Components: Feature Model
Affects Versions: Feature Model Converter 1.0.6
Reporter: Karl Pauls
Assignee: Karl Pauls
 Fix For: Feature Model Converter 1.0.8


We have some confusion going on between the start-level and the start-order 
metadata. The idea is to consolidate around start-order for now. This requires 
to have the modelconverter read both but output start-order only.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Re: [RT] Support OSGi R7 Logging

[Robert Munteanu]

On Thu, 2019-08-15 at 11:12 +0200, Carsten Ziegeler wrote:
> Hi Roy,
> 
> I guess my mail is a little bit misleading :)
> 
> It's totally fine to use SLF4J directly and we should keep doing
> this. 
> Under the covers, everything you log to slf4j is routed through the 
> LogService so other components in the system can listen to log
> entries etc.
> 
> So this is about keeping everything as is for clients doing logging
> but 
> just replace the LogService implementation with the Apache Felix one
> - 
> and make sure that we still have todays features in place.

+1 from me. I also asked about this a year ago :-)

  
https://lists.apache.org/thread.html/581b9ac69bfa6a8692e6bffc98fe5fdd6f5b4c35989d6b53841f7f10@%3Cdev.sling.apache.org%3E

Robert

> Regards
> Carsten
> 
> Am 15.08.2019 um 09:22 schrieb Roy Teeuwen:
> > Hey Carsten,
> > 
> > What is the benefit of using this log service instead of just keep
> > using SLF4J which seems to have almost the exact same interface /
> > way of using?
> > 
> > Greets,
> > Roy
> > 
> > > On 14 Aug 2019, at 08:17, Carsten Ziegeler 
> > > wrote:
> > > 
> > > Hi,
> > > 
> > > the OSGi R7 specification has an update to the Log Service which
> > > we should support in some way in Sling.
> > > 
> > > Today, we have our own LogService implementation
> > > (org.apache.sling.commons.logservice). One way to implement R7
> > > could be to simply update our implementation. However logging is
> > > not our core business, so I think it makes more sense to use an
> > > existing implementation.
> > > 
> > > Fortunately, the Apache Felix project has an R7 LogService
> > > implementation. So we could replace our own implementation with
> > > that.
> > > 
> > > Unfortunately, that's not a simple replacement as our
> > > commons.logservice is also implementing slf4j support by logging
> > > every received log event to slf4j. On the other hand we have
> > > slf4j support in our org.apache.sling.commons.log bundle (it's
> > > easy to confuse these two bundles we have). So we could move the
> > > slf4j support to that bundle as well and have everything in a
> > > single place.
> > > 
> > > Or we could remove our own logservice implementation from the
> > > logservice bundle and just keep the slf4j support there. That
> > > would be a little bit more compatible.
> > > 
> > > Just for completeness, the R7 log service specification also
> > > introduces streaming support for logging. The Apache Felix
> > > implementation does not support this. But as the streaming
> > > support is additional we can use the Eclipse log stream
> > > implementation on top of Felix implementation if we want to
> > > support that, too.
> > > 
> > > WDYT?
> > > 
> > > Regards
> > > Carsten
> > > --
> > > Carsten Ziegeler
> > > Adobe Research Switzerland
> > > cziege...@apache.org

Re: [RT] Support OSGi R7 Logging

[Carsten Ziegeler]

Hi Roy,

I guess my mail is a little bit misleading :)

It's totally fine to use SLF4J directly and we should keep doing this. 
Under the covers, everything you log to slf4j is routed through the 
LogService so other components in the system can listen to log entries etc.


So this is about keeping everything as is for clients doing logging but 
just replace the LogService implementation with the Apache Felix one - 
and make sure that we still have todays features in place.


Regards
Carsten

Am 15.08.2019 um 09:22 schrieb Roy Teeuwen:

Hey Carsten,

What is the benefit of using this log service instead of just keep using SLF4J 
which seems to have almost the exact same interface / way of using?

Greets,
Roy


On 14 Aug 2019, at 08:17, Carsten Ziegeler  wrote:

Hi,

the OSGi R7 specification has an update to the Log Service which we should 
support in some way in Sling.

Today, we have our own LogService implementation 
(org.apache.sling.commons.logservice). One way to implement R7 could be to 
simply update our implementation. However logging is not our core business, so 
I think it makes more sense to use an existing implementation.

Fortunately, the Apache Felix project has an R7 LogService implementation. So 
we could replace our own implementation with that.

Unfortunately, that's not a simple replacement as our commons.logservice is 
also implementing slf4j support by logging every received log event to slf4j. 
On the other hand we have slf4j support in our org.apache.sling.commons.log 
bundle (it's easy to confuse these two bundles we have). So we could move the 
slf4j support to that bundle as well and have everything in a single place.

Or we could remove our own logservice implementation from the logservice bundle 
and just keep the slf4j support there. That would be a little bit more 
compatible.

Just for completeness, the R7 log service specification also introduces 
streaming support for logging. The Apache Felix implementation does not support 
this. But as the streaming support is additional we can use the Eclipse log 
stream implementation on top of Felix implementation if we want to support 
that, too.

WDYT?

Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org




--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Resolved] (SLING-8631) Introduce state for extensions

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-8631.
-
Resolution: Fixed

Added the new state, deprecated old methods and adjusted reader/writer

> Introduce state for extensions
> --
>
> Key: SLING-8631
> URL: https://issues.apache.org/jira/browse/SLING-8631
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.1.0, Feature Model IO 1.1.0
>
>
> Currently an extension is either required or optional. However, the 
> extensions of the feature model also allow to keep transient state like a 
> cache of calculations. For example, the result of scanning a feature could be 
> attached to a feature model to avoid rescanning of downstream users.
> Therefore we should probably add a method to get the state of an extension 
> with the values TRANSIENT,OPTIONAL,REQUIRED



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Re: [RT] Support OSGi R7 Logging

[Roy Teeuwen]

Hey Carsten,

What is the benefit of using this log service instead of just keep using SLF4J 
which seems to have almost the exact same interface / way of using?

Greets,
Roy

> On 14 Aug 2019, at 08:17, Carsten Ziegeler  wrote:
> 
> Hi,
> 
> the OSGi R7 specification has an update to the Log Service which we should 
> support in some way in Sling.
> 
> Today, we have our own LogService implementation 
> (org.apache.sling.commons.logservice). One way to implement R7 could be to 
> simply update our implementation. However logging is not our core business, 
> so I think it makes more sense to use an existing implementation.
> 
> Fortunately, the Apache Felix project has an R7 LogService implementation. So 
> we could replace our own implementation with that.
> 
> Unfortunately, that's not a simple replacement as our commons.logservice is 
> also implementing slf4j support by logging every received log event to slf4j. 
> On the other hand we have slf4j support in our org.apache.sling.commons.log 
> bundle (it's easy to confuse these two bundles we have). So we could move the 
> slf4j support to that bundle as well and have everything in a single place.
> 
> Or we could remove our own logservice implementation from the logservice 
> bundle and just keep the slf4j support there. That would be a little bit more 
> compatible.
> 
> Just for completeness, the R7 log service specification also introduces 
> streaming support for logging. The Apache Felix implementation does not 
> support this. But as the streaming support is additional we can use the 
> Eclipse log stream implementation on top of Felix implementation if we want 
> to support that, too.
> 
> WDYT?
> 
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org

[jira] [Updated] (SLING-8631) Introduce state for extensions

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-8631:

Fix Version/s: Feature Model IO 1.0.8

> Introduce state for extensions
> --
>
> Key: SLING-8631
> URL: https://issues.apache.org/jira/browse/SLING-8631
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.0.8, Feature Model IO 1.0.8
>
>
> Currently an extension is either required or optional. However, the 
> extensions of the feature model also allow to keep transient state like a 
> cache of calculations. For example, the result of scanning a feature could be 
> attached to a feature model to avoid rescanning of downstream users.
> Therefore we should probably add a method to get the state of an extension 
> with the values TRANSIENT,OPTIONAL,REQUIRED



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)