[GitHub] [sling-jspc-maven-plugin] karlpauls commented on a change in pull request #7: SLING-11099: add required dependencies in scope compile
karlpauls commented on a change in pull request #7: URL: https://github.com/apache/sling-jspc-maven-plugin/pull/7#discussion_r794920938 ## File path: pom.xml ## @@ -157,14 +174,14 @@ org.apache.felix org.apache.felix.framework -7.0.1 -provided +7.0.3 +compile Review comment: I guess you could force people to add it manually - however, I find that more unexpected than having a bit more download. Furthermore, the difference is 26mb dependencies to 23mb dependencies. Not sure it is worthwhile to make users jump through hoops just to save them some 3mb download (especially given the amount of downloading going on anyways). Anyways, I'd say this fixes the bug for now - if we want to change it we can do it in an improvement issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11100) jspc-maven-plugin: Separate OSGi metadata generation and packaging from simple compilation
[ https://issues.apache.org/jira/browse/SLING-11100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11100: Summary: jspc-maven-plugin: Separate OSGi metadata generation and packaging from simple compilation (was: Separate OSGi metadata generation and packaging from simple compilation) > jspc-maven-plugin: Separate OSGi metadata generation and packaging from > simple compilation > -- > > Key: SLING-11100 > URL: https://issues.apache.org/jira/browse/SLING-11100 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Konrad Windszus >Priority: Major > > Currently there is only one goal doing everything. It would be nice to > provide separate goals to also allow to use this plugin outside OSGi > container given that most other alternatives are no longer maintained > (https://search.maven.org/artifact/org.codehaus.mojo/jspc-maven-plugin) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11100) Separate OSGi metadata generation and packaging from simple compilation
Konrad Windszus created SLING-11100: --- Summary: Separate OSGi metadata generation and packaging from simple compilation Key: SLING-11100 URL: https://issues.apache.org/jira/browse/SLING-11100 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Konrad Windszus Currently there is only one goal doing everything. It would be nice to provide separate goals to also allow to use this plugin outside OSGi container given that most other alternatives are no longer maintained (https://search.maven.org/artifact/org.codehaus.mojo/jspc-maven-plugin) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [sling-jspc-maven-plugin] karlpauls merged pull request #7: SLING-11099: add required dependencies in scope compile
karlpauls merged pull request #7: URL: https://github.com/apache/sling-jspc-maven-plugin/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-jspc-maven-plugin] kwin commented on a change in pull request #7: SLING-11099: add required dependencies in scope compile
kwin commented on a change in pull request #7: URL: https://github.com/apache/sling-jspc-maven-plugin/pull/7#discussion_r794913806 ## File path: pom.xml ## @@ -157,14 +174,14 @@ org.apache.felix org.apache.felix.framework -7.0.1 -provided +7.0.3 +compile Review comment: this is huge and not necessary in all cases, isn't there the possibility to make the Mojo run without it? It is not really expected that a JSP Compiler Mojo always need this dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-jspc-maven-plugin] sonarcloud[bot] commented on pull request #7: SLING-11099: add required dependencies in scope compile
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-jspc-maven-plugin/pull/7#issuecomment-1024675556 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=7&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=7&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=7&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=7&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=7&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=7&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-jspc-maven-plugin&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-jspc-maven-plugin&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-jspc-maven-plugin&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=7&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=7&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-jspc-maven-plugin&pullRequest=7&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-jspc-maven-plugin&pullRequest=7&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-jspc-maven-plugin&pullRequest=7&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-jspc-maven-plugin&pullRequest=7&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-jspc-maven-plugin] kwin commented on a change in pull request #7: SLING-11099: add required dependencies in scope compile
kwin commented on a change in pull request #7: URL: https://github.com/apache/sling-jspc-maven-plugin/pull/7#discussion_r794913806 ## File path: pom.xml ## @@ -157,14 +174,14 @@ org.apache.felix org.apache.felix.framework -7.0.1 -provided +7.0.3 +compile Review comment: this is huge and not necessary in all cases, isn't there the possibility to make the Mojo run without it? It is not really expected that a JSP Compiler Mojo always need this dependency? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11099) JSPC plugin missing critical dependencies by default
[
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls resolved SLING-11099.
Resolution: Fixed
Done in https://github.com/apache/sling-jspc-maven-plugin/pull/7
> JSPC plugin missing critical dependencies by default
>
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Assignee: Karl Pauls
>Priority: Major
> Fix For: JSPC Maven Plugin 2.3.4
>
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError:
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well)
> is marked as {_}provided{_}. Adding the following two as explicit plugin
> dependencies is a workaround (and allows at least my builds to work).
> However, I do not believe that ordinary Maven users should have to do such a
> workaround.
> {{ }}
> {{ org.apache.sling}}
> {{ org.apache.sling.feature}}
> {{ 1.2.30}}
> {{ }}
> {{ }}
> {{ org.osgi}}
> {{ org.osgi.framework}}
> {{ 1.10.0}}
> {{ }}
> Note that 2.3.0 worked correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-11099) JSPC plugin missing critical dependencies by default
[
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-11099:
Fix Version/s: JSPC Maven Plugin 2.3.4
(was: JSPC Maven Plugin 2.2.4)
> JSPC plugin missing critical dependencies by default
>
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Assignee: Karl Pauls
>Priority: Major
> Fix For: JSPC Maven Plugin 2.3.4
>
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError:
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well)
> is marked as {_}provided{_}. Adding the following two as explicit plugin
> dependencies is a workaround (and allows at least my builds to work).
> However, I do not believe that ordinary Maven users should have to do such a
> workaround.
> {{ }}
> {{ org.apache.sling}}
> {{ org.apache.sling.feature}}
> {{ 1.2.30}}
> {{ }}
> {{ }}
> {{ org.osgi}}
> {{ org.osgi.framework}}
> {{ 1.10.0}}
> {{ }}
> Note that 2.3.0 worked correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-11099) JSPC plugin missing critical dependencies by default
[
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls updated SLING-11099:
---
Fix Version/s: JSPC Maven Plugin 2.2.4
> JSPC plugin missing critical dependencies by default
>
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Assignee: Karl Pauls
>Priority: Major
> Fix For: JSPC Maven Plugin 2.2.4
>
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError:
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well)
> is marked as {_}provided{_}. Adding the following two as explicit plugin
> dependencies is a workaround (and allows at least my builds to work).
> However, I do not believe that ordinary Maven users should have to do such a
> workaround.
> {{ }}
> {{ org.apache.sling}}
> {{ org.apache.sling.feature}}
> {{ 1.2.30}}
> {{ }}
> {{ }}
> {{ org.osgi}}
> {{ org.osgi.framework}}
> {{ 1.10.0}}
> {{ }}
> Note that 2.3.0 worked correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11099) JSPC plugin missing critical dependencies by default
[
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483984#comment-17483984
]
Karl Pauls commented on SLING-11099:
Yeah, looks like a bug. I guess I missed that adding an artifactid as a
property makes it need the classes even so it is not configured. I'll fix it.
> JSPC plugin missing critical dependencies by default
>
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Assignee: Karl Pauls
>Priority: Major
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError:
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well)
> is marked as {_}provided{_}. Adding the following two as explicit plugin
> dependencies is a workaround (and allows at least my builds to work).
> However, I do not believe that ordinary Maven users should have to do such a
> workaround.
> {{ }}
> {{ org.apache.sling}}
> {{ org.apache.sling.feature}}
> {{ 1.2.30}}
> {{ }}
> {{ }}
> {{ org.osgi}}
> {{ org.osgi.framework}}
> {{ 1.10.0}}
> {{ }}
> Note that 2.3.0 worked correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (SLING-11099) JSPC plugin missing critical dependencies by default
[
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls reassigned SLING-11099:
--
Assignee: Karl Pauls
> JSPC plugin missing critical dependencies by default
>
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Assignee: Karl Pauls
>Priority: Major
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError:
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well)
> is marked as {_}provided{_}. Adding the following two as explicit plugin
> dependencies is a workaround (and allows at least my builds to work).
> However, I do not believe that ordinary Maven users should have to do such a
> workaround.
> {{ }}
> {{ org.apache.sling}}
> {{ org.apache.sling.feature}}
> {{ 1.2.30}}
> {{ }}
> {{ }}
> {{ org.osgi}}
> {{ org.osgi.framework}}
> {{ 1.10.0}}
> {{ }}
> Note that 2.3.0 worked correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [sling-org-apache-sling-dynamic-include] jsedding commented on pull request #23: SLING-11087: Fix for multiple components being fetched via JSI
jsedding commented on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/23#issuecomment-1024582744 LFTM as well. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (SLING-11099) JSPC plugin missing critical dependencies by default
[
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483871#comment-17483871
]
Konrad Windszus edited comment on SLING-11099 at 1/28/22, 5:42 PM:
---
This seems to be a regression caused by SLING-10887. [~karlpauls] Can you look
into that? IMHO Sling Features should only be an optional dependency. Probably
we should also add a simple IT leveraging
https://maven.apache.org/plugins/maven-invoker-plugin/integration-test-mojo.html
to make sure it doesn't break in the future.
was (Author: kwin):
This seems to be a regression caused by SLING-10887. [~kpauls] Can you look
into that? IMHO Sling Features should only be an optional dependency. Probably
we should also add a simple IT leveraging
https://maven.apache.org/plugins/maven-invoker-plugin/integration-test-mojo.html
to make sure it doesn't break in the future.
> JSPC plugin missing critical dependencies by default
>
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Priority: Major
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError:
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well)
> is marked as {_}provided{_}. Adding the following two as explicit plugin
> dependencies is a workaround (and allows at least my builds to work).
> However, I do not believe that ordinary Maven users should have to do such a
> workaround.
> {{ }}
> {{ org.apache.sling}}
> {{ org.apache.sling.feature}}
> {{ 1.2.30}}
> {{ }}
> {{ }}
> {{ org.osgi}}
> {{ org.osgi.framework}}
> {{ 1.10.0}}
> {{ }}
> Note that 2.3.0 worked correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (SLING-11099) JSPC plugin missing critical dependencies by default
[
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483871#comment-17483871
]
Konrad Windszus edited comment on SLING-11099 at 1/28/22, 5:41 PM:
---
This seems to be a regression caused by SLING-10887. [~kpauls] Can you look
into that? IMHO Sling Features should only be an optional dependency. Probably
we should also add a simple IT leveraging
https://maven.apache.org/plugins/maven-invoker-plugin/integration-test-mojo.html
to make sure it doesn't break in the future.
was (Author: kwin):
This seems to be a regression caused by SLING-10887. [~kpauls] Can you look
into that? IMHO Sling Features should only be an optional dependency.
> JSPC plugin missing critical dependencies by default
>
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Priority: Major
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError:
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well)
> is marked as {_}provided{_}. Adding the following two as explicit plugin
> dependencies is a workaround (and allows at least my builds to work).
> However, I do not believe that ordinary Maven users should have to do such a
> workaround.
> {{ }}
> {{ org.apache.sling}}
> {{ org.apache.sling.feature}}
> {{ 1.2.30}}
> {{ }}
> {{ }}
> {{ org.osgi}}
> {{ org.osgi.framework}}
> {{ 1.10.0}}
> {{ }}
> Note that 2.3.0 worked correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11099) JSPC plugin missing critical dependencies by default
[
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483871#comment-17483871
]
Konrad Windszus commented on SLING-11099:
-
This seems to be a regression caused by SLING-10887. [~kpauls] Can you look
into that? IMHO Sling Features should only be an optional dependency.
> JSPC plugin missing critical dependencies by default
>
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Priority: Major
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError:
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well)
> is marked as {_}provided{_}. Adding the following two as explicit plugin
> dependencies is a workaround (and allows at least my builds to work).
> However, I do not believe that ordinary Maven users should have to do such a
> workaround.
> {{ }}
> {{ org.apache.sling}}
> {{ org.apache.sling.feature}}
> {{ 1.2.30}}
> {{ }}
> {{ }}
> {{ org.osgi}}
> {{ org.osgi.framework}}
> {{ 1.10.0}}
> {{ }}
> Note that 2.3.0 worked correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (SLING-11099) JSPC plugin missing critical dependencies by default
Donal Fellows created SLING-11099:
-
Summary: JSPC plugin missing critical dependencies by default
Key: SLING-11099
URL: https://issues.apache.org/jira/browse/SLING-11099
Project: Sling
Issue Type: Bug
Components: Maven Plugins and Archetypes
Affects Versions: JSPC Maven Plugin 2.3.2
Reporter: Donal Fellows
The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary
Maven plugin. The first two lines of relevance (there's a _lot_ more stack
trace, but it is really not very informative) from the build logs are:
{{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
{}}}{{{}java.lang.NoClassDefFoundError: org/apache/sling/feature/ArtifactId{}}}
The problem appears to be that the _{{org.apache.sling.feature}}_ dependency
(and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well)
is marked as {_}provided{_}. Adding the following two as explicit plugin
dependencies is a workaround (and allows at least my builds to work). However,
I do not believe that ordinary Maven users should have to do such a workaround.
{{ }}
{{ org.apache.sling}}
{{ org.apache.sling.feature}}
{{ 1.2.30}}
{{ }}
{{ }}
{{ org.osgi}}
{{ org.osgi.framework}}
{{ 1.10.0}}
{{ }}
Note that 2.3.0 worked correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-11086) Fix javadoc
[ https://issues.apache.org/jira/browse/SLING-11086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-11086. - > Fix javadoc > --- > > Key: SLING-11086 > URL: https://issues.apache.org/jira/browse/SLING-11086 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Metrics 1.2.8 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Commons Metrics 1.2.10 > > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/2 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-9268) Update Pax Exam to 4.13.3
[ https://issues.apache.org/jira/browse/SLING-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-9268. > Update Pax Exam to 4.13.3 > - > > Key: SLING-9268 > URL: https://issues.apache.org/jira/browse/SLING-9268 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Metrics 1.2.10 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10967) Improve Gauge support in metrics
[
https://issues.apache.org/jira/browse/SLING-10967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-10967.
-
> Improve Gauge support in metrics
>
>
> Key: SLING-10967
> URL: https://issues.apache.org/jira/browse/SLING-10967
> Project: Sling
> Issue Type: Improvement
> Components: Commons
>Affects Versions: Commons Metrics 1.2.8
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Commons Metrics 1.2.10
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently Sling Metrics only support Gauges via the whiteboard approach (see
> SLING-5966).
> To leverage gauges you have to register a gauge instance by yourself using
> the OSGI Framework API and also its whole livecycle. The Sling MetricsService
> should be able to handle this for you as well like it does for the other
> metric types (e.g. counter).
> I propose to extend the MetricsService by a new method:
> {code}
> Gauge registerGauge (String name, Supplier supplier);
> {code}
> which registers a Gauge which on every request to {{getValue()}} calls the
> provided supplier. In most cases the returned Gauge object is not used, but
> it is returned for consistency with other methods of the MetricsService.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-9123) Update Pax Exam to 4.13.2
[ https://issues.apache.org/jira/browse/SLING-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-9123. > Update Pax Exam to 4.13.2 > - > > Key: SLING-9123 > URL: https://issues.apache.org/jira/browse/SLING-9123 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Metrics 1.2.10 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-9267) Update to Sling Bundle Parent 38
[ https://issues.apache.org/jira/browse/SLING-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-9267. > Update to Sling Bundle Parent 38 > > > Key: SLING-9267 > URL: https://issues.apache.org/jira/browse/SLING-9267 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Commons Metrics 1.2.10 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[RESULT][VOTE] Release Apache Sling Commons Metrics 1.2.10
Hi, The vote has passed with the following result : +1 (binding): Daniel Klco, Robert Munteanu, Carsten Ziegeler I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Jörg Am Mo., 24. Jan. 2022 um 16:46 Uhr schrieb Jörg Hoh : > Hi, > > We solved 5 issues in this > release:https://issues.apache.org/jira/projects/SLING/versions/12346871 > > There is still 1 outstanding issues, which I moved to 1.2.12 > * https://issues.apache.org/jira/browse/SLING-5418 > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2588/ > > You can use this UNIX script to download the release and verify the > signatures:https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2588 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[GitHub] [sling-site] joerghoh merged pull request #78: update the contribution page
joerghoh merged pull request #78: URL: https://github.com/apache/sling-site/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-site] joerghoh commented on a change in pull request #78: update the contribution page
joerghoh commented on a change in pull request #78: URL: https://github.com/apache/sling-site/pull/78#discussion_r794330303 ## File path: src/main/jbake/content/contributing.md ## @@ -21,25 +21,20 @@ a committer. ## How to contribute -Apache Sling is a volunteer effort, so there is always plenty of work that needs to be accomplished. If you want to help supporting Apache -Sling, this page is intended as a starting point for specific contribution ideas. To further understand how the Sling community operates, -refer to the [Community Roles and Processes document](https://www.apache.org/foundation/how-it-works.html) and/or join our mailing lists. +Apache Sling is a volunteer effort, so there is always plenty of work that needs to be accomplished. If you want to help supporting Apache Sling, this page is intended as a starting point for specific contribution ideas. To further understand how the Sling community operates, refer to the [Community Roles and Processes document](https://www.apache.org/foundation/how-it-works.html) and/or join our [mailing lists](http://sling.apache.org/project-information.html#mailing-lists). + +For people who are completely new to contributing to an Apache Software Foundation project, the +[Get Involved](https://www.apache.org/foundation/getinvolved.html) page provides you with enough resources to understand how the foundation works and how its projects are structured - and don't hesitate to ask on our [mailing lists](http://sling.apache.org/project-information.html#mailing-lists)! See [Project Information](/project-information.html) for details about the tools mentioned below. -The Apache Sling project organizes its "to do" list using the Apache [JIRA issue tracking system](https://issues.apache.org/jira/browse/SLING). -No matter if you are a programmer or not, it is probably best to check JIRA first to figure out if the problem you identified is already -known. If not, please create a JIRA issue in which you try to describe to the best of your knowledge the bug that you want to fix or the -improvement that you would like to contribute. There are many recommendations on the Web on how to write a good bug report, like -[Haje Jan Kamps' How to write the perfect bug report](https://medium.com/@Haje/how-to-write-the-perfect-bug-report-6430f5a45cd) blog post. +The Apache Sling project organizes its "to do" list using the Apache [JIRA issue tracking system](https://issues.apache.org/jira/browse/SLING). No matter if you are a programmer or not, it is probably best to check JIRA first to figure out if the problem you identified is already known. If not, please create a JIRA issue in which you try to describe to the best of your knowledge the bug that you want to fix or the improvement that you would like to contribute. There are many recommendations on the Web on how to write a good bug report, like [Haje Jan Kamps' How to write the perfect bug report](https://medium.com/@Haje/how-to-write-the-perfect-bug-report-6430f5a45cd) blog post. + +If pull requests are familiar to you, the next step is to open one against [one of our modules](https://github.com/apache/?q=sling&type=all&language=&sort=). If creating a pull request from your own repository, setting the _[allow edits from maintainers](https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork)_ option is convenient as it allows us to update your fork as the pull request evolves. -If pull requests are familiar to you, the next step is to open one against one of our modules. If creating a pull request from your -own repository, setting the -_[allow edits from maintainers](https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork)_ -option is convenient as it allows us to update your fork as the pull request evolves. +More details about how the project is structured in terms of repositories can be read on the [Getting and Building Sling](/documentation/development/getting-and-building-sling.html) page. -More details about how the project is structured in terms of repositories can be read on the -[Getting and Building Sling](/documentation/development/getting-and-building-sling.html) page. +If you want to get involved into Sling development, we marked a number of issues in Jira with the label ["good-first-issue"](https://issues.apache.org/jira/browse/SLING-5767?jql=status%20%3D%20Open%20AND%20labels%20%3D%20easy-first-issue); we consider them a good starting point into Sling development. Just assign the ticket to you and create a pull request to address it. We provide you feedback and help you to get your contribution into Sling. Review comment: thank you, fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi
[jira] [Updated] (SLING-5767) Include the Illegal Argument Exception message in the logs
[
https://issues.apache.org/jira/browse/SLING-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-5767:
-
Labels: easyfix good-first-issue newbie (was: easy-first-issue easyfix
newbie)
> Include the Illegal Argument Exception message in the logs
> --
>
> Key: SLING-5767
> URL: https://issues.apache.org/jira/browse/SLING-5767
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Event 3.7.6, Event 4.0.2
>Reporter: PuzanovsP
>Priority: Trivial
> Labels: easyfix, good-first-issue, newbie
> Attachments: Utility.java
>
> Original Estimate: 1h
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Add message to notify the user why his event is invalid.
> File: org/apache/sling/event/impl/jobs/Utility.java:50
> * Change code attached.
> /**
> * Check the job topic.
> * @return null if the topic is correct, otherwise an error
> description is returned
> */
> public static String checkJobTopic(final Object jobTopic) {
> final String message;
> if ( jobTopic != null ) {
> if ( jobTopic instanceof String ) {
> boolean topicIsCorrect = false;
> String exceptionDetails = EMPTY;
> try {
> new Event((String)jobTopic, (Dictionary Object>)null);
> topicIsCorrect = true;
> } catch (final IllegalArgumentException iae) {
> exceptionDetails = iae.getLocalizedMessage();
> }
> if ( !topicIsCorrect ) {
> message = "Discarding job - job has an illegal job topic,
> due to: ".concat(exceptionDetails);
> } else {
> message = null;
> }
> } else {
> message = "Discarding job - job topic is not of type string";
> }
> } else {
> message = "Discarding job - job topic is missing";
> }
> return message;
> }
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-3743) BackgroundHttpServletResponse don't flushes the Writer
[
https://issues.apache.org/jira/browse/SLING-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-3743:
-
Labels: easyfix good-first-issue (was: easy-first-issue easyfix)
> BackgroundHttpServletResponse don't flushes the Writer
> --
>
> Key: SLING-3743
> URL: https://issues.apache.org/jira/browse/SLING-3743
> Project: Sling
> Issue Type: Bug
>Reporter: Alexander Berndt
>Priority: Minor
> Labels: easyfix, good-first-issue
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> A sling servlet request can be run as a background service, while appending a
> ?sling:bg=true to the request. This is done in the
> BackgroundServletStarterFilter.
> Unfortunatily this doesn't work for servlets, that use request.getWriter() to
> create the output. The provided BackgroundHttpServletResponse provides also a
> writer, but this isn't flushed during the clean-up.
> So the current code:
> public BackgroundHttpServletResponse(HttpServletResponse hsr, OutputStream os)
> throws IOException {
> stream = new ServletOutputStreamWrapper(os);
> writer = new PrintWriter(new OutputStreamWriter(stream));
> }
> public void cleanup() throws IOException {
> stream.flush();
> stream.close();
> }
> should be changed to:
> public void cleanup() throws IOException {
> writer.flush();
> writer.close();
> }
> as the writer also flushes and closes the underlying stream.
> kind regards,
> Alexander Berndt
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11096) resource resolver: enable sling mock testing
[
https://issues.apache.org/jira/browse/SLING-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483661#comment-17483661
]
Julian Reschke commented on SLING-11096:
FWIW, not adding org.apache.sling.testing.sling-mock.junit4 removes the
breakage.
> resource resolver: enable sling mock testing
>
>
> Key: SLING-11096
> URL: https://issues.apache.org/jira/browse/SLING-11096
> Project: Sling
> Issue Type: Task
> Components: ResourceResolver
>Reporter: Julian Reschke
>Priority: Minor
>
> I'd like to add test coverage using sling-mock.
> However, just adding the dependency:
> {noformat}
> +
> +org.apache.sling
> +
> org.apache.sling.testing.sling-mock.junit4
> +3.2.2
> +test
> +
> +
> +org.apache.sling
> +org.apache.sling.testing.sling-mock-oak
> +3.1.2-1.40.0
> +test
> +
> {noformat}
> causes test failures...:
> {noformat}
> [ERROR] Failures:
> [ERROR] ResourceMapperImplTest.mapResourceWithAliasAndEtcMap:246 All
> mappings without request
> Expected: is <[http://localhost:8080/everywhere, /alias-value-2, /somewhere]>
> but: was <[/alias-value-2, /somewhere]>
> [ERROR] ResourceMapperImplTest.mapResourceWithAliasAndEtcMap:246 All
> mappings without request
> Expected: is <[http://localhost:8080/everywhere, /alias-value-2, /somewhere]>
> but: was <[/alias-value-2, /somewhere]>
> [ERROR] ResourceMapperImplTest.mapResourceWithVanityPaths:328 All mappings
> without request
> Expected: is <[/vain, /vanity-a, /vanity-b]>
> but: was <[/vain]>
> [ERROR] ResourceMapperImplTest.mapResourceWithVanityPaths:328 All mappings
> without request
> Expected: is <[/vain, /vanity-a, /vanity-b]>
> but: was <[/vain]>
> [ERROR] ResourceMapperImplTest.priorityForVHostMappings:280 Single mapping
> without request
> Expected: is "http://virtual.host.com/foo";
> but: was "/content/virtual/foo"
> [ERROR] ResourceMapperImplTest.priorityForVHostMappings:280 Single mapping
> without request
> Expected: is "http://virtual.host.com/foo";
> but: was "/content/virtual/foo"
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
