[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on pull request #11: Issues/sling 11741
cziegeler commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#issuecomment-1726968834 @jsedding I'll have a look to see what we can do at runtime *without* creating/deleting configurations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10417) Create execution plans with "strict" import option
[ https://issues.apache.org/jira/browse/SLING-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766933#comment-17766933 ] Robert Munteanu commented on SLING-10417: - [~kwin] - I plan to release a new version of the Content Extension so we can use the latest improvements. I am a bit worried about the 'strict' option being set by default for all imports as this has the potential to break various deployments. I plan to make this behaviour opt-in for the current release and we can evaluate defaults for future versions. > Create execution plans with "strict" import option > -- > > Key: SLING-10417 > URL: https://issues.apache.org/jira/browse/SLING-10417 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Content Extension 1.0.10 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Feature Model Content Extension 1.0.12 > > > The execution plans created by the ContentHandler should enforce installation > in strict mode. This is possible since JCRVLT-511 and requires FileVault > 3.5.0 (compare with SLING-10405). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-extension-content] rombert merged pull request #19: SLING-12028 - Content Deployment Extension tests fail on Windows
rombert merged PR #19: URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-extension-content] sonarcloud[bot] commented on pull request #19: SLING-12028 - Content Deployment Extension tests fail on Windows
sonarcloud[bot] commented on PR #19: URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/19#issuecomment-1726442077 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-extension-content=19) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content=19=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content=19=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content=19=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content=19=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content=19=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content=19=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-extension-content=19=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-extension-content=19=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-extension-content=19=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content=19=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content=19=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-extension-content=19=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-content=19=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-content=19=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-content=19=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-extension-content=19=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-extension-content] rombert opened a new pull request, #19: SLING-12028 - Content Deployment Extension tests fail on Windows
rombert opened a new pull request, #19: URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/19 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12028) Content Deployment Extension tests fail on Windows
[
https://issues.apache.org/jira/browse/SLING-12028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12028:
Description:
{noformat}
[ERROR]
org.apache.sling.feature.extension.content.ContentHandlerTest.testMultipleStartOrders
Time elapsed: 0.617 s <<< FAILURE!
org.junit.ComparisonFailure:
expected:<...t5731559958083209794[\]executedplans.file> but
was:<...t5731559958083209794[/]executedplans.file>
{noformat}
was:
[ERROR]
org.apache.sling.feature.extension.content.ContentHandlerTest.testMultipleStartOrders
Time elapsed: 0.617 s <<< FAILURE!
org.junit.ComparisonFailure:
expected:<...t5731559958083209794[\]executedplans.file> but
was:<...t5731559958083209794[/]executedplans.file>
> Content Deployment Extension tests fail on Windows
> --
>
> Key: SLING-12028
> URL: https://issues.apache.org/jira/browse/SLING-12028
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Content Extension 1.0.12
>
>
> {noformat}
> [ERROR]
> org.apache.sling.feature.extension.content.ContentHandlerTest.testMultipleStartOrders
> Time elapsed: 0.617 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...t5731559958083209794[\]executedplans.file> but
> was:<...t5731559958083209794[/]executedplans.file>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12028) Content Deployment Extension tests fail on Windows
Robert Munteanu created SLING-12028: --- Summary: Content Deployment Extension tests fail on Windows Key: SLING-12028 URL: https://issues.apache.org/jira/browse/SLING-12028 Project: Sling Issue Type: Bug Components: Feature Model Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Feature Model Content Extension 1.0.12 [ERROR] org.apache.sling.feature.extension.content.ContentHandlerTest.testMultipleStartOrders Time elapsed: 0.617 s <<< FAILURE! org.junit.ComparisonFailure: expected:<...t5731559958083209794[\]executedplans.file> but was:<...t5731559958083209794[/]executedplans.file> -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-graphql-core] schaefa commented on pull request #38: SLING-12027 - GraphQL core fails to build with Java 17
schaefa commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38#issuecomment-1726383479 @rombert I will check it out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[RESULT] [VOTE] Release Apache Sling GraphQL Core version 0.0.24
Hi Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Joerg Hoh, Robert Munteanu +1 (non binding): none Can a PMC push the release to https://dist.apache.org/repos/dist/release/sling/. I will finish the rest afterwards. Cheers - Andy
Re: Vote on latest Sling GraphQL Core release 0.0.24
Hi Robert I will do that next time. Regarding Java 17 - I saw your updated the Wiki page related to that but I did not have time to check it out yet. I will try to solve this ASAP but Pax Exam so far is not cooperating. Cheers - Andy > On Sep 19, 2023, at 2:33 AM, Robert Munteanu wrote: > > Hi Andy, > > On Mon, 2023-09-18 at 09:53 -0700, Andreas Schaefer wrote: >> Hi >> >> I need one more vote to release Sling GraphQL Core 0.0.24. This has >> an important update to handle fields with the same simple name aka >> name. Right now previous fields are dropped and so I moved that to a >> Multi Value Map to avoid it and to make FQNs the unique field name. >> > > I voted on the release, thanks for the reminder. A couple of notes: > > - I find it easier to reply to the original [VOTE] email when sending > reminders, this way everyone has the context ( staging repository, > changelog, etc ) > - When bundles don't build on Java 17 I usually leave the voting to > others because I have to adjust my validation tooling for that bundle > in question. It would be great if the next version of the GraphQL > bundle would work on Java 17. I created a PR which is almost complete > [1], please look into it when you have time. > > Thanks, > Robert > > > [1]: > https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38
RE: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.4
+1 stefan
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #163: [draft] remove toobig check
sonarcloud[bot] commented on PR #163: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/163#issuecomment-1725643620 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=163) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=163=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=163=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=163=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=163=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=163=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #137: Bump gson from 2.8.6 to 2.8.9
sonarcloud[bot] commented on PR #137: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/137#issuecomment-1725636036 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=137) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=137=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=137=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=137=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=137=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.4
+1 On Tue, Sep 19, 2023 at 4:45 AM Robert Munteanu wrote: > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12353201 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2783/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2783 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu >
[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on pull request #11: Issues/sling 11741
cziegeler commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#issuecomment-1725470467 I think we have two options: we do a clever implementation like we have here which does the conversion behind the scenes and warns users to switch to the new configuration. Or we make a breaking change and provide some other means to users to change their configuration before it gets deployed into configuration admin service. As there are many different ways for the latter, we tried here the former. The goal is to eventually get rid of the support for the old format (breaking change) with some time for our users to adjust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #84: SLING-11352 - Fix parsing of path-only mappings
sonarcloud[bot] commented on PR #84: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-1725352847 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=84) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Simpler Feature flags for sling
Hi Christian, On Mon, 2023-09-18 at 16:57 +0200, Christian Schneider wrote: > I propose that we expose feature toggles using a prefix + the toggle > name. > So for example it could be "org.apache.sling.toggle.FT-SLING-1234". > > I have already experimented with this and it seems feasible. This looks like a good idea but I'm missing the concrete change you propose for Sling :-) Thanks, Robert
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #78: Various improvements for the webconsole plugin
sonarcloud[bot] commented on PR #78: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/78#issuecomment-1725350633 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=78) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=78=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=78=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=78=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=78=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=78=new_coverage=list) [2.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=78=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=78=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=78=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #101: SLING-11715 in the optimized code path avoid resource resolution
sonarcloud[bot] commented on PR #101: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/101#issuecomment-1725350231 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=101) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=101=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=101=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=101=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_coverage=list) [93.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-analyser] sonarcloud[bot] commented on pull request #41: [SECURITY] Fix Temporary File Information Disclosure Vulnerability
sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/41#issuecomment-1725349711 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=41) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=41=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=41=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=41=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=41=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=41=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=41=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-analyser=41=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-analyser=41=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-analyser=41=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=41=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=41=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=41=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=41=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=41=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=41=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11778) Test that the feature models generated by the CPConverter are deployable
[ https://issues.apache.org/jira/browse/SLING-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11778: Fix Version/s: Content-Package to Feature Model Converter 1.3.6 (was: Content-Package to Feature Model Converter 1.3.4) > Test that the feature models generated by the CPConverter are deployable > > > Key: SLING-11778 > URL: https://issues.apache.org/jira/browse/SLING-11778 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Robert Munteanu >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.6 > > > We have a set of tests in the CPConverter that validate what the output looks > like. I have a feeling that we would be better off if we would validate that > the feature models and associated artifacts can actually be installed. > We can do this by setting up a Sling application that contains the > prerequisites ( Oak/FileVault mostly ) and starting that application with the > feature models generated. The application can be parameterised to use > different FileVault versions, so we are certain that we don't run into > problems like SLING-11777 . > We can then validate that > - all bundles are started > - all content packages are installed > I think this would cover a gap that we have regarding validating the > correctness of the artifacts that we generate with the CPConverter. > We don't have to start with a lot of tests, but having 1-3 content packages > with good coverages validated as "installable" would IMO be a great step > forward. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert merged pull request #171: Update to parent version 52
rombert merged PR #171: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert commented on pull request #171: Update to parent version 52
rombert commented on PR #171: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171#issuecomment-1725175368 Thanks @kwin ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #171: Update to parent version 52
sonarcloud[bot] commented on PR #171: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171#issuecomment-1725163418 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=171) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=171=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=171=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=171=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=171=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=171=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=171=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=171=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=171=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=171=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=171=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=171=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=171=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=171=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=171=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=171=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Vote on latest Sling GraphQL Core release 0.0.24
Hi Andy, On Mon, 2023-09-18 at 09:53 -0700, Andreas Schaefer wrote: > Hi > > I need one more vote to release Sling GraphQL Core 0.0.24. This has > an important update to handle fields with the same simple name aka > name. Right now previous fields are dropped and so I moved that to a > Multi Value Map to avoid it and to make FQNs the unique field name. > I voted on the release, thanks for the reminder. A couple of notes: - I find it easier to reply to the original [VOTE] email when sending reminders, this way everyone has the context ( staging repository, changelog, etc ) - When bundles don't build on Java 17 I usually leave the voting to others because I have to adjust my validation tooling for that bundle in question. It would be great if the next version of the GraphQL bundle would work on Java 17. I created a PR which is almost complete [1], please look into it when you have time. Thanks, Robert [1]: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #171: Update to parent version 52
kwin commented on PR #171: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171#issuecomment-1725152174 @rombert Done in https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171/commits/f829e5a9d322e7029195169e761ae644026fa3c5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling GraphQL Core 0.0.24
On Mon, 2023-09-11 at 11:23 -0700, Andreas Schaefer wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[GitHub] [sling-org-apache-sling-graphql-core] rombert commented on pull request #38: SLING-12027 - GraphQL core fails to build with Java 17
rombert commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38#issuecomment-1725134314 @raducotescu @schaefa - I think this is mostly done, but one test fails and it requires more GraphQL insight > [ERROR] Failures: > [ERROR] GraphQLServletIT.testPersistingInvalidQueries:159 Did not expect to persist an invalid query. expected:<400> but was:<500> It would be great if you could look into this so we can have Java 17 compatibility for this bundle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] rombert opened a new pull request, #38: SLING-12027 - GraphQL core fails to build with Java 17
rombert opened a new pull request, #38: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-12027) GraphQL core fails to build with Java 17
[ https://issues.apache.org/jira/browse/SLING-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12027: --- Assignee: Robert Munteanu > GraphQL core fails to build with Java 17 > > > Key: SLING-12027 > URL: https://issues.apache.org/jira/browse/SLING-12027 > Project: Sling > Issue Type: Bug > Components: GraphQL >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > 1. Mockito fails to create mocks, probably due to old version > 2. Pax-Exam tests time out -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12027) GraphQL core fails to build with Java 17
Robert Munteanu created SLING-12027: --- Summary: GraphQL core fails to build with Java 17 Key: SLING-12027 URL: https://issues.apache.org/jira/browse/SLING-12027 Project: Sling Issue Type: Bug Components: GraphQL Reporter: Robert Munteanu Fix For: GraphQL Core 0.0.26 1. Mockito fails to create mocks, probably due to old version 2. Pax-Exam tests time out -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert commented on pull request #171: Update to parent version 52
rombert commented on PR #171: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171#issuecomment-1725081765 @kwin - there seems to be a conflict with Parent 52 and the changes you made in ccae72b792745600ceac75aeff444da43bb284c5 for SLING-11396. Can you please take a look on what needs to be fixed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.4
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12353201 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2783/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2783 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert opened a new pull request, #171: Update to parent version 52
rombert opened a new pull request, #171: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/171 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-11844) Index definitions must not be extracted from empty nodes
[ https://issues.apache.org/jira/browse/SLING-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11844. - Resolution: Fixed PR applied, thanks [~abhigarg]! > Index definitions must not be extracted from empty nodes > > > Key: SLING-11844 > URL: https://issues.apache.org/jira/browse/SLING-11844 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Robert Munteanu >Assignee: Abhishek Garg >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.4 > > > Under certain conditions, extracted index definitions will contain empty > nodes. These are useless and should be skipped. They can also confuse tooling > processing the index definitions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert merged pull request #170: SLING-11844 handling empty index definitions
rombert merged PR #170: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] renovate-bot opened a new pull request, #235: chore(deps): update dependency org.apache.felix:org.apache.felix.healthcheck.core to v2.2.0
renovate-bot opened a new pull request, #235: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/235 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.felix:org.apache.felix.healthcheck.core](https://felix.apache.org/) ([source](https://gitbox.apache.org/repos/asf?p=felix-dev.git)) | `2.1.0` -> `2.2.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] renovate-bot opened a new pull request, #234: chore(deps): update dependency com.h2database:h2-mvstore to v2.2.224
renovate-bot opened a new pull request, #234: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/234 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.h2database:h2-mvstore](https://h2database.com/html/mvstore.html) ([source](https://togithub.com/h2database/h2database)) | `2.2.222` -> `2.2.224` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on a diff in pull request #11: Issues/sling 11741
cziegeler commented on code in PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1329754434
##
src/main/java/org/apache/sling/jcr/base/internal/ConfigurationUpdater.java:
##
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.jcr.base.internal;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Dictionary;
+import java.util.HashMap;
+import java.util.Hashtable;
+import java.util.List;
+import java.util.Map;
+
+import org.osgi.framework.Constants;
+import org.osgi.framework.InvalidSyntaxException;
+import org.osgi.service.cm.Configuration;
+import org.osgi.service.cm.ConfigurationAdmin;
+import org.osgi.service.cm.ConfigurationEvent;
+import org.osgi.service.cm.ConfigurationListener;
+import org.osgi.service.component.annotations.Activate;
+import org.osgi.service.component.annotations.Component;
+import org.osgi.service.component.annotations.Reference;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * This class is updating configuration and configuration property names to use
+ * more inclusive language.
+ * See https://issues.apache.org/jira/browse/SLING-11741
+ */
+@Component(service = {ConfigurationListener.class, ConfigurationUpdater.class})
+public class ConfigurationUpdater implements ConfigurationListener {
Review Comment:
We hope that we don't have more of those. So for now no need to have a
generic solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-base] bdelacretaz commented on a diff in pull request #11: Issues/sling 11741
bdelacretaz commented on code in PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1329749920
##
src/main/java/org/apache/sling/jcr/base/internal/ConfigurationUpdater.java:
##
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.jcr.base.internal;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Dictionary;
+import java.util.HashMap;
+import java.util.Hashtable;
+import java.util.List;
+import java.util.Map;
+
+import org.osgi.framework.Constants;
+import org.osgi.framework.InvalidSyntaxException;
+import org.osgi.service.cm.Configuration;
+import org.osgi.service.cm.ConfigurationAdmin;
+import org.osgi.service.cm.ConfigurationEvent;
+import org.osgi.service.cm.ConfigurationListener;
+import org.osgi.service.component.annotations.Activate;
+import org.osgi.service.component.annotations.Component;
+import org.osgi.service.component.annotations.Reference;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * This class is updating configuration and configuration property names to use
+ * more inclusive language.
+ * See https://issues.apache.org/jira/browse/SLING-11741
+ */
+@Component(service = {ConfigurationListener.class, ConfigurationUpdater.class})
+public class ConfigurationUpdater implements ConfigurationListener {
Review Comment:
IIUC this updater is specific to this configuration name change, aren't we
going to have more similar cases of configuration renaming? And if yes,
shouldn't that class rather be generic in its own module?
We can always make it more generic later, but I'm curious about the
intention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-base] bdelacretaz commented on a diff in pull request #11: Issues/sling 11741
bdelacretaz commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1329745936 ## src/main/java/org/apache/sling/jcr/base/internal/AllowListFragment.java: ## @@ -32,59 +32,58 @@ import static java.util.Arrays.asList; @ObjectClassDefinition( -name = "Apache Sling Login Admin Whitelist Configuration Fragment", -description = "Whitelist configuration fragments contribute a list of whitelisted bundle symbolic " + -"names to the Login Admin Whitelist. This allows for modularisation of the whitelist." +name = "Apache Sling Login Admin Allow List Configuration Fragment", +description = "Allow list configuration fragments contribute a list of allow listed bundle symbolic " + Review Comment: I think rewording the description would make it easier to understand, just replacing "white list" with "allow list" makes it hard to read IMHO, I suggest: > This list of Bundle Symbolic Names is added to the list of bundles which are allowed to use Administrative Login. The full list is built, in a modular way, out of all such configuration fragments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-11844) Index definitions must not be extracted from empty nodes
[ https://issues.apache.org/jira/browse/SLING-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-11844: --- Assignee: Abhishek Garg > Index definitions must not be extracted from empty nodes > > > Key: SLING-11844 > URL: https://issues.apache.org/jira/browse/SLING-11844 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Reporter: Robert Munteanu >Assignee: Abhishek Garg >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.4 > > > Under certain conditions, extracted index definitions will contain empty > nodes. These are useless and should be skipped. They can also confuse tooling > processing the index definitions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12026) Check for implementation/extension of provider types
[ https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-12026: Description: OSGi distinguishes between [consumer|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ConsumerType.html] and [provider|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html] types (either interfaces or classes). Some bundles/features are only supposed to implement/extend consumer types in order to be more stable against API changes. There should be a feature model analyser enforcing this. was: OSGi distinguishes between [consumer|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ConsumerType.html] and [provider type|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html] interfaces. Some bundles/features are only supposed to implement/extend consumer type interfaces in order to be more stable against API changes. There should be a feature model analyser enforcing this. > Check for implementation/extension of provider types > > > Key: SLING-12026 > URL: https://issues.apache.org/jira/browse/SLING-12026 > Project: Sling > Issue Type: New Feature > Components: Feature Model Analyser >Affects Versions: Feature Model Analyser 2.0.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > OSGi distinguishes between > [consumer|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ConsumerType.html] > and > [provider|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html] > types (either interfaces or classes). > Some bundles/features are only supposed to implement/extend consumer types in > order to be more stable against API changes. There should be a feature model > analyser enforcing this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12026) Check for implementation/extension of provider types
[ https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-12026: Summary: Check for implementation/extension of provider types (was: Check for implementation/extension of provider type interfaces) > Check for implementation/extension of provider types > > > Key: SLING-12026 > URL: https://issues.apache.org/jira/browse/SLING-12026 > Project: Sling > Issue Type: New Feature > Components: Feature Model Analyser >Affects Versions: Feature Model Analyser 2.0.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > OSGi distinguishes between > [consumer|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ConsumerType.html] > and [provider > type|https://docs.osgi.org/javadoc/osgi.annotation/7.0.0/org/osgi/annotation/versioning/ProviderType.html] > interfaces. > Some bundles/features are only supposed to implement/extend consumer type > interfaces in order to be more stable against API changes. There should be a > feature model analyser enforcing this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: ASM library to parse class files?
I don't see any concern with using asm. However, the analyser bundle has already quiet a few dependencies (mainly due to the native support for content packages). So maybe we can add such an analyser in a separate module or at least make the dependencies optional? I think it would be great to have the content package dependencies optional as well. But that's of course a different issue. Regards Carsten On 18.09.2023 16:28, Konrad Windszus wrote: Hi, In the context of https://issues.apache.org/jira/browse/SLING-12026 I would need to parse Java class files to inspect them (on a high level only, i.e. check for implemented interfaces). I would like to use ASM for that: https://asm.ow2.io/. Its license is BSD which is compatible with ASF policies: https://www.apache.org/legal/resolved.html#category-a The library itself is pretty small (120 KB). Is there any concern with adding that dependency to https://github.com/apache/sling-org-apache-sling-feature-analyser in order to implement such an analyser (and potentially more like it in the future) or is there a recommendation for any other library? I know that simple parsing should be feasible with a JDK provided library (https://docs.oracle.com/javase/8/docs/jdk/api/javac/tree/com/sun/source/util/JavacTask.html) but its API is quite complex… Any feedback would be highly appreciated. Thanks, Konrad -- Carsten Ziegeler Adobe cziege...@apache.org
Re: Sling Feature Analyser: CLI
Hi, I think the initial version had a CLI, but it was removed and obviously the docs were not updated accordingly. Regards Carsten On 18.09.2023 19:56, Konrad Windszus wrote: Hi, Despite the fact that a CLI is mentioned in https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/master/readme.md#running-the-analyser-from-the-command-line I couldn’t find the mentioned Main class anywhere in the Git repository https://github.com/apache/sling-org-apache-sling-feature-analyser. Am I missing something here? Thanks in advance, Konrad -- Carsten Ziegeler Adobe cziege...@apache.org
