[jira] [Commented] (SQOOP-3273) Removing com.cloudera.sqoop packages

2018-11-28 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/SQOOP-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701516#comment-16701516
 ] 

ASF GitHub Bot commented on SQOOP-3273:
---

Github user szvasas closed the pull request at:

https://github.com/apache/sqoop/pull/42


> Removing com.cloudera.sqoop packages
> 
>
> Key: SQOOP-3273
> URL: https://issues.apache.org/jira/browse/SQOOP-3273
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: SQOOP-3273-final.patch, SQOOP-3273.patch, 
> SQOOP-3273.patch, SQOOP-3273.patch
>
>
> Sqoop has dozens of classes in com.cloudera.sqoop packages which most of the 
> cases just extend their corresponding class in org.apache.sqoop package 
> without adding extra functionality.
> These classes make the code harder to read and navigate, they are already 
> deprecated but because of backward compatibility considerations we have not 
> removed them yet.
> The task is to make sure that all the functionality from com.cloudera.sqoop 
> classes is available in org.apache.sqoop classes and remove the classes from 
> com.cloudera.sqoop packages.
> The tests defined in com.cloudera.sqoop packages should also be migrated to 
> org.apache.sqoop package.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 65017: Removing com.cloudera.sqoop packages

2018-01-17 Thread Fero Szabo via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/#review195572
---


Ship it!




Hi Szabi,

Thanks for removing these deprecated classes, this greatly improves quality!

I've executed a sonar run against trunk and your patch, this change gets rid of 
2.5 thousand code smells! 

Well done!

- Fero Szabo


On Jan. 9, 2018, 2:25 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65017/
> ---
> 
> (Updated Jan. 9, 2018, 2:25 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3273
> https://issues.apache.org/jira/browse/SQOOP-3273
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This patch contains all the changes related to this JIRA.
> I have also created a pull request (https://github.com/apache/sqoop/pull/42) 
> because I think it is much easier to review it there since almost all of the 
> class removals were committed separately in my own Sqoop fork.
> 
> 
> Diffs
> -
> 
>   build.xml 2094bae8dde5fdaa40a7a1f86858cc79be198363 
>   conf/sqoop-site-template.xml 2182da3c88d3c6ff7dddea9f30f363435619285c 
>   ivy.xml d1530384efdecb45bd5b8ef802b60325da1dd400 
>   src/docs/dev/api-reference.txt 80453eec537a26f65e3e24b3d4da8741aceecb5b 
>   src/docs/sip/sip-4.txt 966412577126878065308324330342c6d0666f58 
>   src/java/com/cloudera/sqoop/ConnFactory.java 
> f75cb4e97e5b2febc21e59a6a6b827af010aa003 
>   src/java/com/cloudera/sqoop/Sqoop.java 
> 8ec9f8f044d10e8e071ac8a69c5860efc891f5fb 
>   src/java/com/cloudera/sqoop/SqoopOptions.java 
> 0863ef6dd71a67a5811d73bd0ef964e65e0e7afc 
>   src/java/com/cloudera/sqoop/cli/RelatedOptions.java 
> c6453b726b55fd87e1b596c3e537390582ece0a9 
>   src/java/com/cloudera/sqoop/cli/SqoopParser.java 
> 0c6d84e04c72c832a4b7160cdfffe7ebdf0c9284 
>   src/java/com/cloudera/sqoop/cli/ToolOptions.java 
> 0b5da6c3854543ceb1f1f11448d9f9bf8cba159d 
>   src/java/com/cloudera/sqoop/config/ConfigurationConstants.java 
> 72e7df133ec8bfd7be9f9006fdf8d399885ef230 
>   src/java/com/cloudera/sqoop/config/ConfigurationHelper.java 
> 0870497754a79b54c0a9338567e9af6adf931fca 
>   src/java/com/cloudera/sqoop/hbase/HBasePutProcessor.java 
> 425b0f46be7fb396ea92837c046ed9f8fbb129b1 
>   src/java/com/cloudera/sqoop/hbase/HBaseUtil.java 
> 6f1fba7d590e02c2b5f63b6e95e1ab5ad55c2e3d 
>   src/java/com/cloudera/sqoop/hbase/PutTransformer.java 
> b8ceab7782ce7bbb5c6e27eda6619ab086a6d28c 
>   src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java 
> 0c55b21ffbe2012705714c53bd33a8e672cc5ae0 
>   src/java/com/cloudera/sqoop/hive/HiveImport.java 
> db1c1b323b782a5a7c870e9802781a73f5617079 
>   src/java/com/cloudera/sqoop/hive/HiveTypes.java 
> e67f6b890bc25c19656c6bde99aeebc592b4d45f 
>   src/java/com/cloudera/sqoop/hive/TableDefWriter.java 
> d19e01863f54f9c013e01a1f422c6dbd711ca7e0 
>   src/java/com/cloudera/sqoop/io/CodecMap.java 
> 647cedcd2d3a8e5d4836f47f779ece8a78f0bb05 
>   src/java/com/cloudera/sqoop/io/FixedLengthInputStream.java 
> 806af22c01ed93f80ee32d4b5c1c203fe2dcdb5d 
>   src/java/com/cloudera/sqoop/io/LobFile.java 
> 905c68f64fd5b45665336cc0f27c5e9ace7eacdd 
>   src/java/com/cloudera/sqoop/io/LobReaderCache.java 
> 89d31d31aaca0f60d0042a5e3472b12dac01e0c9 
>   src/java/com/cloudera/sqoop/io/NamedFifo.java 
> e27d2c4f857bb806f2686d6d447aa0eb02fc97a3 
>   src/java/com/cloudera/sqoop/io/SplittableBufferedWriter.java 
> ef9285a62c1c35f48bdfae124a22c94a4e19b6d0 
>   src/java/com/cloudera/sqoop/io/SplittingOutputStream.java 
> ab81042b48f083dc10b5b81b5b5a53505106f26e 
>   src/java/com/cloudera/sqoop/io/UnsupportedCodecException.java 
> 4d8225a3d42477a2ac8c854d6f0bd303a99c4681 
>   src/java/com/cloudera/sqoop/lib/BigDecimalSerializer.java 
> 2ae89c24f053d6176e642f547e483c6cb4cba168 
>   src/java/com/cloudera/sqoop/lib/BlobRef.java 
> b3d5341e3e29289f985d15d259a167b7b7db7002 
>   src/java/com/cloudera/sqoop/lib/BooleanParser.java 
> ab97cf0a3156f3f8f09aa2ff7c427f8014f42e21 
>   src/java/com/cloudera/sqoop/lib/ClobRef.java 
> a328f23bfee882c850a4a2aa63e3ac364307f7a9 
>   src/java/com/cloudera/sqoop/lib/DelimiterSet.java 
> 6de90ad9419610ab9e3aabe96d1a3b13ca4d768e 
>   src/java/com/cloudera/sqoop/lib/FieldFormatter.java 
> 45fb81f40d86f8a9ff8ba8f5d5334dfbe3fed644 
>   src/java/com/cloudera/sqoop/lib/FieldMapProcessor.java 
> 3f215401f91f5934e4ac6b3830b2986032e336dd 
>   src/java/com/cloudera/sqoop/lib/FieldMappable.java 
> 2067ecc813146a41e7ccbcdd5472ffb29261db77 
>   src/java/com/cloudera/sqoop/lib/JdbcWritableBridge.java 
> 316547f108762c65ec1e11a16feb76f73045314d 
>   src/java/com/cloudera/sqoop/lib/LargeObjectLoader.java 
> b51cf0cc13cdf5dbcad1061956ece07118b29dbf 
>   src/java/com/cloudera/sqoop/lib/LobRef.java 
>

Re: Review Request 65017: Removing com.cloudera.sqoop packages

2018-01-12 Thread Boglarka Egyed 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/#review195323
---


Ship it!




Hi Szabi,

Thanks for correcting my findings on the pull request!

Patch applies without any problem, unit and 3rd party tests pass.

Many thanks for this huge clean up effort!

Cheers,
Bogi

- Boglarka Egyed


On Jan. 9, 2018, 2:25 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65017/
> ---
> 
> (Updated Jan. 9, 2018, 2:25 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3273
> https://issues.apache.org/jira/browse/SQOOP-3273
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This patch contains all the changes related to this JIRA.
> I have also created a pull request (https://github.com/apache/sqoop/pull/42) 
> because I think it is much easier to review it there since almost all of the 
> class removals were committed separately in my own Sqoop fork.
> 
> 
> Diffs
> -
> 
>   build.xml 2094bae8dde5fdaa40a7a1f86858cc79be198363 
>   conf/sqoop-site-template.xml 2182da3c88d3c6ff7dddea9f30f363435619285c 
>   ivy.xml d1530384efdecb45bd5b8ef802b60325da1dd400 
>   src/docs/dev/api-reference.txt 80453eec537a26f65e3e24b3d4da8741aceecb5b 
>   src/docs/sip/sip-4.txt 966412577126878065308324330342c6d0666f58 
>   src/java/com/cloudera/sqoop/ConnFactory.java 
> f75cb4e97e5b2febc21e59a6a6b827af010aa003 
>   src/java/com/cloudera/sqoop/Sqoop.java 
> 8ec9f8f044d10e8e071ac8a69c5860efc891f5fb 
>   src/java/com/cloudera/sqoop/SqoopOptions.java 
> 0863ef6dd71a67a5811d73bd0ef964e65e0e7afc 
>   src/java/com/cloudera/sqoop/cli/RelatedOptions.java 
> c6453b726b55fd87e1b596c3e537390582ece0a9 
>   src/java/com/cloudera/sqoop/cli/SqoopParser.java 
> 0c6d84e04c72c832a4b7160cdfffe7ebdf0c9284 
>   src/java/com/cloudera/sqoop/cli/ToolOptions.java 
> 0b5da6c3854543ceb1f1f11448d9f9bf8cba159d 
>   src/java/com/cloudera/sqoop/config/ConfigurationConstants.java 
> 72e7df133ec8bfd7be9f9006fdf8d399885ef230 
>   src/java/com/cloudera/sqoop/config/ConfigurationHelper.java 
> 0870497754a79b54c0a9338567e9af6adf931fca 
>   src/java/com/cloudera/sqoop/hbase/HBasePutProcessor.java 
> 425b0f46be7fb396ea92837c046ed9f8fbb129b1 
>   src/java/com/cloudera/sqoop/hbase/HBaseUtil.java 
> 6f1fba7d590e02c2b5f63b6e95e1ab5ad55c2e3d 
>   src/java/com/cloudera/sqoop/hbase/PutTransformer.java 
> b8ceab7782ce7bbb5c6e27eda6619ab086a6d28c 
>   src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java 
> 0c55b21ffbe2012705714c53bd33a8e672cc5ae0 
>   src/java/com/cloudera/sqoop/hive/HiveImport.java 
> db1c1b323b782a5a7c870e9802781a73f5617079 
>   src/java/com/cloudera/sqoop/hive/HiveTypes.java 
> e67f6b890bc25c19656c6bde99aeebc592b4d45f 
>   src/java/com/cloudera/sqoop/hive/TableDefWriter.java 
> d19e01863f54f9c013e01a1f422c6dbd711ca7e0 
>   src/java/com/cloudera/sqoop/io/CodecMap.java 
> 647cedcd2d3a8e5d4836f47f779ece8a78f0bb05 
>   src/java/com/cloudera/sqoop/io/FixedLengthInputStream.java 
> 806af22c01ed93f80ee32d4b5c1c203fe2dcdb5d 
>   src/java/com/cloudera/sqoop/io/LobFile.java 
> 905c68f64fd5b45665336cc0f27c5e9ace7eacdd 
>   src/java/com/cloudera/sqoop/io/LobReaderCache.java 
> 89d31d31aaca0f60d0042a5e3472b12dac01e0c9 
>   src/java/com/cloudera/sqoop/io/NamedFifo.java 
> e27d2c4f857bb806f2686d6d447aa0eb02fc97a3 
>   src/java/com/cloudera/sqoop/io/SplittableBufferedWriter.java 
> ef9285a62c1c35f48bdfae124a22c94a4e19b6d0 
>   src/java/com/cloudera/sqoop/io/SplittingOutputStream.java 
> ab81042b48f083dc10b5b81b5b5a53505106f26e 
>   src/java/com/cloudera/sqoop/io/UnsupportedCodecException.java 
> 4d8225a3d42477a2ac8c854d6f0bd303a99c4681 
>   src/java/com/cloudera/sqoop/lib/BigDecimalSerializer.java 
> 2ae89c24f053d6176e642f547e483c6cb4cba168 
>   src/java/com/cloudera/sqoop/lib/BlobRef.java 
> b3d5341e3e29289f985d15d259a167b7b7db7002 
>   src/java/com/cloudera/sqoop/lib/BooleanParser.java 
> ab97cf0a3156f3f8f09aa2ff7c427f8014f42e21 
>   src/java/com/cloudera/sqoop/lib/ClobRef.java 
> a328f23bfee882c850a4a2aa63e3ac364307f7a9 
>   src/java/com/cloudera/sqoop/lib/DelimiterSet.java 
> 6de90ad9419610ab9e3aabe96d1a3b13ca4d768e 
>   src/java/com/cloudera/sqoop/lib/FieldFormatter.java 
> 45fb81f40d86f8a9ff8ba8f5d5334dfbe3fed644 
>   src/java/com/cloudera/sqoop/lib/FieldMapProcessor.java 
> 3f215401f91f5934e4ac6b3830b2986032e336dd 
>   src/java/com/cloudera/sqoop/lib/FieldMappable.java 
> 2067ecc813146a41e7ccbcdd5472ffb29261db77 
>   src/java/com/cloudera/sqoop/lib/JdbcWritableBridge.java 
> 316547f108762c65ec1e11a16feb76f73045314d 
>   src/java/com/cloudera/sqoop/lib/LargeObjectLoader.java 
> b51cf0cc13cdf5dbcad1061956ece07118b29dbf 
>   src/java/com/cloudera/sqoop/lib/LobRef.java 
>

Re: Review Request 65017: Removing com.cloudera.sqoop packages

2018-01-11 Thread Anna Szonyi via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/#review195227
---


Ship it!




Hi Szabi,

This is great, it helps a lot with the readability!

Thanks,
Anna

- Anna Szonyi


On Jan. 9, 2018, 2:25 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65017/
> ---
> 
> (Updated Jan. 9, 2018, 2:25 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3273
> https://issues.apache.org/jira/browse/SQOOP-3273
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This patch contains all the changes related to this JIRA.
> I have also created a pull request (https://github.com/apache/sqoop/pull/42) 
> because I think it is much easier to review it there since almost all of the 
> class removals were committed separately in my own Sqoop fork.
> 
> 
> Diffs
> -
> 
>   build.xml 2094bae8dde5fdaa40a7a1f86858cc79be198363 
>   conf/sqoop-site-template.xml 2182da3c88d3c6ff7dddea9f30f363435619285c 
>   ivy.xml d1530384efdecb45bd5b8ef802b60325da1dd400 
>   src/docs/dev/api-reference.txt 80453eec537a26f65e3e24b3d4da8741aceecb5b 
>   src/docs/sip/sip-4.txt 966412577126878065308324330342c6d0666f58 
>   src/java/com/cloudera/sqoop/ConnFactory.java 
> f75cb4e97e5b2febc21e59a6a6b827af010aa003 
>   src/java/com/cloudera/sqoop/Sqoop.java 
> 8ec9f8f044d10e8e071ac8a69c5860efc891f5fb 
>   src/java/com/cloudera/sqoop/SqoopOptions.java 
> 0863ef6dd71a67a5811d73bd0ef964e65e0e7afc 
>   src/java/com/cloudera/sqoop/cli/RelatedOptions.java 
> c6453b726b55fd87e1b596c3e537390582ece0a9 
>   src/java/com/cloudera/sqoop/cli/SqoopParser.java 
> 0c6d84e04c72c832a4b7160cdfffe7ebdf0c9284 
>   src/java/com/cloudera/sqoop/cli/ToolOptions.java 
> 0b5da6c3854543ceb1f1f11448d9f9bf8cba159d 
>   src/java/com/cloudera/sqoop/config/ConfigurationConstants.java 
> 72e7df133ec8bfd7be9f9006fdf8d399885ef230 
>   src/java/com/cloudera/sqoop/config/ConfigurationHelper.java 
> 0870497754a79b54c0a9338567e9af6adf931fca 
>   src/java/com/cloudera/sqoop/hbase/HBasePutProcessor.java 
> 425b0f46be7fb396ea92837c046ed9f8fbb129b1 
>   src/java/com/cloudera/sqoop/hbase/HBaseUtil.java 
> 6f1fba7d590e02c2b5f63b6e95e1ab5ad55c2e3d 
>   src/java/com/cloudera/sqoop/hbase/PutTransformer.java 
> b8ceab7782ce7bbb5c6e27eda6619ab086a6d28c 
>   src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java 
> 0c55b21ffbe2012705714c53bd33a8e672cc5ae0 
>   src/java/com/cloudera/sqoop/hive/HiveImport.java 
> db1c1b323b782a5a7c870e9802781a73f5617079 
>   src/java/com/cloudera/sqoop/hive/HiveTypes.java 
> e67f6b890bc25c19656c6bde99aeebc592b4d45f 
>   src/java/com/cloudera/sqoop/hive/TableDefWriter.java 
> d19e01863f54f9c013e01a1f422c6dbd711ca7e0 
>   src/java/com/cloudera/sqoop/io/CodecMap.java 
> 647cedcd2d3a8e5d4836f47f779ece8a78f0bb05 
>   src/java/com/cloudera/sqoop/io/FixedLengthInputStream.java 
> 806af22c01ed93f80ee32d4b5c1c203fe2dcdb5d 
>   src/java/com/cloudera/sqoop/io/LobFile.java 
> 905c68f64fd5b45665336cc0f27c5e9ace7eacdd 
>   src/java/com/cloudera/sqoop/io/LobReaderCache.java 
> 89d31d31aaca0f60d0042a5e3472b12dac01e0c9 
>   src/java/com/cloudera/sqoop/io/NamedFifo.java 
> e27d2c4f857bb806f2686d6d447aa0eb02fc97a3 
>   src/java/com/cloudera/sqoop/io/SplittableBufferedWriter.java 
> ef9285a62c1c35f48bdfae124a22c94a4e19b6d0 
>   src/java/com/cloudera/sqoop/io/SplittingOutputStream.java 
> ab81042b48f083dc10b5b81b5b5a53505106f26e 
>   src/java/com/cloudera/sqoop/io/UnsupportedCodecException.java 
> 4d8225a3d42477a2ac8c854d6f0bd303a99c4681 
>   src/java/com/cloudera/sqoop/lib/BigDecimalSerializer.java 
> 2ae89c24f053d6176e642f547e483c6cb4cba168 
>   src/java/com/cloudera/sqoop/lib/BlobRef.java 
> b3d5341e3e29289f985d15d259a167b7b7db7002 
>   src/java/com/cloudera/sqoop/lib/BooleanParser.java 
> ab97cf0a3156f3f8f09aa2ff7c427f8014f42e21 
>   src/java/com/cloudera/sqoop/lib/ClobRef.java 
> a328f23bfee882c850a4a2aa63e3ac364307f7a9 
>   src/java/com/cloudera/sqoop/lib/DelimiterSet.java 
> 6de90ad9419610ab9e3aabe96d1a3b13ca4d768e 
>   src/java/com/cloudera/sqoop/lib/FieldFormatter.java 
> 45fb81f40d86f8a9ff8ba8f5d5334dfbe3fed644 
>   src/java/com/cloudera/sqoop/lib/FieldMapProcessor.java 
> 3f215401f91f5934e4ac6b3830b2986032e336dd 
>   src/java/com/cloudera/sqoop/lib/FieldMappable.java 
> 2067ecc813146a41e7ccbcdd5472ffb29261db77 
>   src/java/com/cloudera/sqoop/lib/JdbcWritableBridge.java 
> 316547f108762c65ec1e11a16feb76f73045314d 
>   src/java/com/cloudera/sqoop/lib/LargeObjectLoader.java 
> b51cf0cc13cdf5dbcad1061956ece07118b29dbf 
>   src/java/com/cloudera/sqoop/lib/LobRef.java 
> 518b62261ebb3e6c6dc4dab269f32e98be397c4d 
>   src/java/com/cloudera/sqoop/lib/LobSerializer.java 
>

Re: Removing com.cloudera.sqoop packages

2018-01-09 Thread Szabolcs Vasas 
Hi Attila,

Thank you for reviewing this patch so quickly!
I have talked to Anna, she is going to review it very soon and post on
ReviewBoard.

Yes, I wanted to push this as one commit to trunk using the patch file, the
small commits were only for reviewing.

Szabolcs

On Tue, Jan 9, 2018 at 3:46 PM, Attila Szabó  wrote:

> Hey Szabi,
>
> Souds great!
>
> Two comments:
> AFAIR Anna Szonyi was also planning to do something similar last January
> (when she was busy around the build system, tests, gradle, etc.). It would
> make sense on my side, to reach out to her, maybe she's got some useful
> feedbacks for you too.
> I've opened an issue on the review board (which if I'm not mistaken you've
> already fixed meanwhile I've been preparing this email ;-) ).
>
> I'll give my +1 and ship it, as soon as I will be able to execute the
> test/releasenotes/etc. on my side as well!
>
> Many thanks for jumping on this initiative, it's a quite old item on my
> wishlist!
>
> Cheers,
> Attila,
>
> ps: I do not have any pros or cons on the side of Pull Request VS. Review
> Board, and I totally can understand if it's better for someone to review
> 182 commits instead of a big one. Although I would strongly advise and
> appreciate if the commits would be squashed into one before merging them to
> the trunk, b/c testing the effects of 180+ commits, one by one would
> consume tons of efforts. If the commit to the master would/will be up to
> me, I would use the patch file instead, or squash first, just for the clean
> state of the trunk as well.
>
> My2cents
>
> On Tue, Jan 9, 2018 at 11:49 AM, Ferenc Szabo  wrote:
>
> > Hi Szabi,
> >
> > I believe this is a great idea.
> >
> > By removing these packages we will get rid of a great deal of technical
> > debt that will simplify future change. I will also help to avoid
> > unnecessary conversions like the ones I had to use in my recent
> > SqoopOptions related change.
> >
> > So, also +1 from me!
> >
> > Cheers,
> > Fero
> >
> > On Mon, Jan 8, 2018 at 5:59 PM, Boglarka Egyed 
> wrote:
> >
> > > Hi Szabolcs,
> > >
> > > I really welcome this initiative, it would be a huge clean up on this
> > > project!
> > >
> > > I already took a look at your pull request and it indeed looks pretty
> > > straightforward.
> > >
> > > I will perform a deeper review and publish it on the Review Board
> > otherwise
> > > +1 from my side for the idea in general, 1.5 release would be a good
> > target
> > > for this.
> > >
> > > Thanks for taking this effort!
> > >
> > > Cheers.
> > > Bogi
> > >
> > > On Mon, Jan 8, 2018 at 2:01 PM, Szabolcs Vasas 
> wrote:
> > >
> > > > Hi All,
> > > >
> > > > As you probably know we still have dozens of classes in
> > > com.cloudera.sqoop
> > > > packages which most of the cases just extend their corresponding
> class
> > in
> > > > org.apache.sqoop package without adding extra functionality.
> > > > These classes make the code harder to read and navigate, they are
> > already
> > > > deprecated but because of backward compatibility considerations we
> were
> > > not
> > > > able to remove them.
> > > > The community was planning on a release containing breaking changes
> (we
> > > > called it 1.5) I think it would be a great candidate to include this
> > > > cleanup.
> > > > I have created a ticket  > > jira/browse/SQOOP-3273>
> > > > for doing this task and submitted a patch as well. I think the
> easiest
> > > way
> > > > to take a look at it is to review the commits in my Sqoop fork:
> > > > https://github.com/szvasas/sqoop/tree/cloudera_package_removal
> > > > Note that this is change which basically affects all of the files in
> > the
> > > > Sqoop project, but in the majority of the cases replacing the
> > > > com.cloudera.sqoop class to its corresponding org.apache.sqoop class
> > was
> > > > just a find and replace command so I consider this a relatively low
> > risk
> > > > change.
> > > > Please feel free to reply to this email with your questions and
> > concerns
> > > > and if you have some time please take a look at the changes.
> > > >
> > > > Thanks and regards,
> > > > Szabolcs
> > > >
> > >
> >
> >
> >
> > --
> > Ferenc Szabo
> > Software Engineer
> >
>



-- 
Szabolcs Vasas
Software Engineer

Re: Removing com.cloudera.sqoop packages

2018-01-09 Thread Attila Szabó 
Hey Szabi,

Souds great!

Two comments:
AFAIR Anna Szonyi was also planning to do something similar last January
(when she was busy around the build system, tests, gradle, etc.). It would
make sense on my side, to reach out to her, maybe she's got some useful
feedbacks for you too.
I've opened an issue on the review board (which if I'm not mistaken you've
already fixed meanwhile I've been preparing this email ;-) ).

I'll give my +1 and ship it, as soon as I will be able to execute the
test/releasenotes/etc. on my side as well!

Many thanks for jumping on this initiative, it's a quite old item on my
wishlist!

Cheers,
Attila,

ps: I do not have any pros or cons on the side of Pull Request VS. Review
Board, and I totally can understand if it's better for someone to review
182 commits instead of a big one. Although I would strongly advise and
appreciate if the commits would be squashed into one before merging them to
the trunk, b/c testing the effects of 180+ commits, one by one would
consume tons of efforts. If the commit to the master would/will be up to
me, I would use the patch file instead, or squash first, just for the clean
state of the trunk as well.

My2cents

On Tue, Jan 9, 2018 at 11:49 AM, Ferenc Szabo  wrote:

> Hi Szabi,
>
> I believe this is a great idea.
>
> By removing these packages we will get rid of a great deal of technical
> debt that will simplify future change. I will also help to avoid
> unnecessary conversions like the ones I had to use in my recent
> SqoopOptions related change.
>
> So, also +1 from me!
>
> Cheers,
> Fero
>
> On Mon, Jan 8, 2018 at 5:59 PM, Boglarka Egyed  wrote:
>
> > Hi Szabolcs,
> >
> > I really welcome this initiative, it would be a huge clean up on this
> > project!
> >
> > I already took a look at your pull request and it indeed looks pretty
> > straightforward.
> >
> > I will perform a deeper review and publish it on the Review Board
> otherwise
> > +1 from my side for the idea in general, 1.5 release would be a good
> target
> > for this.
> >
> > Thanks for taking this effort!
> >
> > Cheers.
> > Bogi
> >
> > On Mon, Jan 8, 2018 at 2:01 PM, Szabolcs Vasas  wrote:
> >
> > > Hi All,
> > >
> > > As you probably know we still have dozens of classes in
> > com.cloudera.sqoop
> > > packages which most of the cases just extend their corresponding class
> in
> > > org.apache.sqoop package without adding extra functionality.
> > > These classes make the code harder to read and navigate, they are
> already
> > > deprecated but because of backward compatibility considerations we were
> > not
> > > able to remove them.
> > > The community was planning on a release containing breaking changes (we
> > > called it 1.5) I think it would be a great candidate to include this
> > > cleanup.
> > > I have created a ticket  > jira/browse/SQOOP-3273>
> > > for doing this task and submitted a patch as well. I think the easiest
> > way
> > > to take a look at it is to review the commits in my Sqoop fork:
> > > https://github.com/szvasas/sqoop/tree/cloudera_package_removal
> > > Note that this is change which basically affects all of the files in
> the
> > > Sqoop project, but in the majority of the cases replacing the
> > > com.cloudera.sqoop class to its corresponding org.apache.sqoop class
> was
> > > just a find and replace command so I consider this a relatively low
> risk
> > > change.
> > > Please feel free to reply to this email with your questions and
> concerns
> > > and if you have some time please take a look at the changes.
> > >
> > > Thanks and regards,
> > > Szabolcs
> > >
> >
>
>
>
> --
> Ferenc Szabo
> Software Engineer
>

[jira] [Updated] (SQOOP-3273) Removing com.cloudera.sqoop packages

2018-01-09 Thread Szabolcs Vasas (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SQOOP-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3273:
--
Attachment: SQOOP-3273.patch

> Removing com.cloudera.sqoop packages
> 
>
> Key: SQOOP-3273
> URL: https://issues.apache.org/jira/browse/SQOOP-3273
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
> Attachments: SQOOP-3273.patch, SQOOP-3273.patch, SQOOP-3273.patch
>
>
> Sqoop has dozens of classes in com.cloudera.sqoop packages which most of the 
> cases just extend their corresponding class in org.apache.sqoop package 
> without adding extra functionality.
> These classes make the code harder to read and navigate, they are already 
> deprecated but because of backward compatibility considerations we have not 
> removed them yet.
> The task is to make sure that all the functionality from com.cloudera.sqoop 
> classes is available in org.apache.sqoop classes and remove the classes from 
> com.cloudera.sqoop packages.
> The tests defined in com.cloudera.sqoop packages should also be migrated to 
> org.apache.sqoop package.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 65017: Removing com.cloudera.sqoop packages

2018-01-09 Thread Szabolcs Vasas 


> On Jan. 9, 2018, 1:46 p.m., Attila Szabo wrote:
> > IMHO build.xml line 1098 (after this patch applied) should be also removed 
> > (this is an entry for the src/com/cloudera/sqoop directory to be included 
> > in the javadoc generation).
> > 
> > Otherwise the patch looks okay, but please let me to give a ship it after 
> > we have the required change, and I was able to execute the 
> > tests/releasenotes gen/etc. on my side as well!
> > 
> > Thanks,
> > Attila

Hi Attila,

Thank you for reviewing the patch, it's a nice catch, I have updated the diff 
with the fix.


- Szabolcs


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/#review195030
---


On Jan. 9, 2018, 2:25 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65017/
> ---
> 
> (Updated Jan. 9, 2018, 2:25 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3273
> https://issues.apache.org/jira/browse/SQOOP-3273
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This patch contains all the changes related to this JIRA.
> I have also created a pull request (https://github.com/apache/sqoop/pull/42) 
> because I think it is much easier to review it there since almost all of the 
> class removals were committed separately in my own Sqoop fork.
> 
> 
> Diffs
> -
> 
>   build.xml 2094bae8dde5fdaa40a7a1f86858cc79be198363 
>   conf/sqoop-site-template.xml 2182da3c88d3c6ff7dddea9f30f363435619285c 
>   ivy.xml d1530384efdecb45bd5b8ef802b60325da1dd400 
>   src/docs/dev/api-reference.txt 80453eec537a26f65e3e24b3d4da8741aceecb5b 
>   src/docs/sip/sip-4.txt 966412577126878065308324330342c6d0666f58 
>   src/java/com/cloudera/sqoop/ConnFactory.java 
> f75cb4e97e5b2febc21e59a6a6b827af010aa003 
>   src/java/com/cloudera/sqoop/Sqoop.java 
> 8ec9f8f044d10e8e071ac8a69c5860efc891f5fb 
>   src/java/com/cloudera/sqoop/SqoopOptions.java 
> 0863ef6dd71a67a5811d73bd0ef964e65e0e7afc 
>   src/java/com/cloudera/sqoop/cli/RelatedOptions.java 
> c6453b726b55fd87e1b596c3e537390582ece0a9 
>   src/java/com/cloudera/sqoop/cli/SqoopParser.java 
> 0c6d84e04c72c832a4b7160cdfffe7ebdf0c9284 
>   src/java/com/cloudera/sqoop/cli/ToolOptions.java 
> 0b5da6c3854543ceb1f1f11448d9f9bf8cba159d 
>   src/java/com/cloudera/sqoop/config/ConfigurationConstants.java 
> 72e7df133ec8bfd7be9f9006fdf8d399885ef230 
>   src/java/com/cloudera/sqoop/config/ConfigurationHelper.java 
> 0870497754a79b54c0a9338567e9af6adf931fca 
>   src/java/com/cloudera/sqoop/hbase/HBasePutProcessor.java 
> 425b0f46be7fb396ea92837c046ed9f8fbb129b1 
>   src/java/com/cloudera/sqoop/hbase/HBaseUtil.java 
> 6f1fba7d590e02c2b5f63b6e95e1ab5ad55c2e3d 
>   src/java/com/cloudera/sqoop/hbase/PutTransformer.java 
> b8ceab7782ce7bbb5c6e27eda6619ab086a6d28c 
>   src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java 
> 0c55b21ffbe2012705714c53bd33a8e672cc5ae0 
>   src/java/com/cloudera/sqoop/hive/HiveImport.java 
> db1c1b323b782a5a7c870e9802781a73f5617079 
>   src/java/com/cloudera/sqoop/hive/HiveTypes.java 
> e67f6b890bc25c19656c6bde99aeebc592b4d45f 
>   src/java/com/cloudera/sqoop/hive/TableDefWriter.java 
> d19e01863f54f9c013e01a1f422c6dbd711ca7e0 
>   src/java/com/cloudera/sqoop/io/CodecMap.java 
> 647cedcd2d3a8e5d4836f47f779ece8a78f0bb05 
>   src/java/com/cloudera/sqoop/io/FixedLengthInputStream.java 
> 806af22c01ed93f80ee32d4b5c1c203fe2dcdb5d 
>   src/java/com/cloudera/sqoop/io/LobFile.java 
> 905c68f64fd5b45665336cc0f27c5e9ace7eacdd 
>   src/java/com/cloudera/sqoop/io/LobReaderCache.java 
> 89d31d31aaca0f60d0042a5e3472b12dac01e0c9 
>   src/java/com/cloudera/sqoop/io/NamedFifo.java 
> e27d2c4f857bb806f2686d6d447aa0eb02fc97a3 
>   src/java/com/cloudera/sqoop/io/SplittableBufferedWriter.java 
> ef9285a62c1c35f48bdfae124a22c94a4e19b6d0 
>   src/java/com/cloudera/sqoop/io/SplittingOutputStream.java 
> ab81042b48f083dc10b5b81b5b5a53505106f26e 
>   src/java/com/cloudera/sqoop/io/UnsupportedCodecException.java 
> 4d8225a3d42477a2ac8c854d6f0bd303a99c4681 
>   src/java/com/cloudera/sqoop/lib/BigDecimalSerializer.java 
> 2ae89c24f053d6176e642f547e483c6cb4cba168 
>   src/java/com/cloudera/sqoop/lib/BlobRef.java 
> b3d5341e3e29289f985d15d259a167b7b7db7002 
>   src/java/com/cloudera/sqoop/lib/BooleanParser.java 
> ab97cf0a3156f3f8f09aa2ff7c427f8014f42e21 
>   src/java/com/cloudera/sqoop/lib/ClobRef.java 
> a328f23bfee882c850a4a2aa63e3ac364307f7a9 
>   src/java/com/cloudera/sqoop/lib/DelimiterSet.java 
> 6de90ad9419610ab9e3aabe96d1a3b13ca4d768e 
>   src/java/com/cloudera/sqoop/lib/FieldFormatter.java 
> 45fb81f40d86f8a9ff8ba8f5d5334dfbe3fed644 
>   src/java/com/cloudera/sqoop/lib/FieldMapProcessor.java 
> 3f215401f91f5934e4ac6b3830b2986032e336dd 
>

Re: Review Request 65017: Removing com.cloudera.sqoop packages

2018-01-09 Thread Szabolcs Vasas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/
---

(Updated Jan. 9, 2018, 2:25 p.m.)


Review request for Sqoop.


Changes
---

com.cloudera package is removed from the javadoc ant target.


Bugs: SQOOP-3273
https://issues.apache.org/jira/browse/SQOOP-3273


Repository: sqoop-trunk


Description
---

This patch contains all the changes related to this JIRA.
I have also created a pull request (https://github.com/apache/sqoop/pull/42) 
because I think it is much easier to review it there since almost all of the 
class removals were committed separately in my own Sqoop fork.


Diffs (updated)
-

  build.xml 2094bae8dde5fdaa40a7a1f86858cc79be198363 
  conf/sqoop-site-template.xml 2182da3c88d3c6ff7dddea9f30f363435619285c 
  ivy.xml d1530384efdecb45bd5b8ef802b60325da1dd400 
  src/docs/dev/api-reference.txt 80453eec537a26f65e3e24b3d4da8741aceecb5b 
  src/docs/sip/sip-4.txt 966412577126878065308324330342c6d0666f58 
  src/java/com/cloudera/sqoop/ConnFactory.java 
f75cb4e97e5b2febc21e59a6a6b827af010aa003 
  src/java/com/cloudera/sqoop/Sqoop.java 
8ec9f8f044d10e8e071ac8a69c5860efc891f5fb 
  src/java/com/cloudera/sqoop/SqoopOptions.java 
0863ef6dd71a67a5811d73bd0ef964e65e0e7afc 
  src/java/com/cloudera/sqoop/cli/RelatedOptions.java 
c6453b726b55fd87e1b596c3e537390582ece0a9 
  src/java/com/cloudera/sqoop/cli/SqoopParser.java 
0c6d84e04c72c832a4b7160cdfffe7ebdf0c9284 
  src/java/com/cloudera/sqoop/cli/ToolOptions.java 
0b5da6c3854543ceb1f1f11448d9f9bf8cba159d 
  src/java/com/cloudera/sqoop/config/ConfigurationConstants.java 
72e7df133ec8bfd7be9f9006fdf8d399885ef230 
  src/java/com/cloudera/sqoop/config/ConfigurationHelper.java 
0870497754a79b54c0a9338567e9af6adf931fca 
  src/java/com/cloudera/sqoop/hbase/HBasePutProcessor.java 
425b0f46be7fb396ea92837c046ed9f8fbb129b1 
  src/java/com/cloudera/sqoop/hbase/HBaseUtil.java 
6f1fba7d590e02c2b5f63b6e95e1ab5ad55c2e3d 
  src/java/com/cloudera/sqoop/hbase/PutTransformer.java 
b8ceab7782ce7bbb5c6e27eda6619ab086a6d28c 
  src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java 
0c55b21ffbe2012705714c53bd33a8e672cc5ae0 
  src/java/com/cloudera/sqoop/hive/HiveImport.java 
db1c1b323b782a5a7c870e9802781a73f5617079 
  src/java/com/cloudera/sqoop/hive/HiveTypes.java 
e67f6b890bc25c19656c6bde99aeebc592b4d45f 
  src/java/com/cloudera/sqoop/hive/TableDefWriter.java 
d19e01863f54f9c013e01a1f422c6dbd711ca7e0 
  src/java/com/cloudera/sqoop/io/CodecMap.java 
647cedcd2d3a8e5d4836f47f779ece8a78f0bb05 
  src/java/com/cloudera/sqoop/io/FixedLengthInputStream.java 
806af22c01ed93f80ee32d4b5c1c203fe2dcdb5d 
  src/java/com/cloudera/sqoop/io/LobFile.java 
905c68f64fd5b45665336cc0f27c5e9ace7eacdd 
  src/java/com/cloudera/sqoop/io/LobReaderCache.java 
89d31d31aaca0f60d0042a5e3472b12dac01e0c9 
  src/java/com/cloudera/sqoop/io/NamedFifo.java 
e27d2c4f857bb806f2686d6d447aa0eb02fc97a3 
  src/java/com/cloudera/sqoop/io/SplittableBufferedWriter.java 
ef9285a62c1c35f48bdfae124a22c94a4e19b6d0 
  src/java/com/cloudera/sqoop/io/SplittingOutputStream.java 
ab81042b48f083dc10b5b81b5b5a53505106f26e 
  src/java/com/cloudera/sqoop/io/UnsupportedCodecException.java 
4d8225a3d42477a2ac8c854d6f0bd303a99c4681 
  src/java/com/cloudera/sqoop/lib/BigDecimalSerializer.java 
2ae89c24f053d6176e642f547e483c6cb4cba168 
  src/java/com/cloudera/sqoop/lib/BlobRef.java 
b3d5341e3e29289f985d15d259a167b7b7db7002 
  src/java/com/cloudera/sqoop/lib/BooleanParser.java 
ab97cf0a3156f3f8f09aa2ff7c427f8014f42e21 
  src/java/com/cloudera/sqoop/lib/ClobRef.java 
a328f23bfee882c850a4a2aa63e3ac364307f7a9 
  src/java/com/cloudera/sqoop/lib/DelimiterSet.java 
6de90ad9419610ab9e3aabe96d1a3b13ca4d768e 
  src/java/com/cloudera/sqoop/lib/FieldFormatter.java 
45fb81f40d86f8a9ff8ba8f5d5334dfbe3fed644 
  src/java/com/cloudera/sqoop/lib/FieldMapProcessor.java 
3f215401f91f5934e4ac6b3830b2986032e336dd 
  src/java/com/cloudera/sqoop/lib/FieldMappable.java 
2067ecc813146a41e7ccbcdd5472ffb29261db77 
  src/java/com/cloudera/sqoop/lib/JdbcWritableBridge.java 
316547f108762c65ec1e11a16feb76f73045314d 
  src/java/com/cloudera/sqoop/lib/LargeObjectLoader.java 
b51cf0cc13cdf5dbcad1061956ece07118b29dbf 
  src/java/com/cloudera/sqoop/lib/LobRef.java 
518b62261ebb3e6c6dc4dab269f32e98be397c4d 
  src/java/com/cloudera/sqoop/lib/LobSerializer.java 
b8324fe261f42d32cff72f038fbaed933053f971 
  src/java/com/cloudera/sqoop/lib/ProcessingException.java 
c4216b1988bc64cc0860b7b8c19dd400d7cbf319 
  src/java/com/cloudera/sqoop/lib/RecordParser.java 
a3238e82d3c51dbffe9510bfd5d4cd8cbfb63230 
  src/java/com/cloudera/sqoop/lib/SqoopRecord.java 
7cfcbb36fb7a185bdcb037746fc47ea665b42294 
  src/java/com/cloudera/sqoop/manager/CatalogQueryManager.java 
5e6a725b8ca59aa0e716ac54c7722130305efa55 
  src/java/com/cloudera/sqoop/manager/ConnManager.java 
a4b44577b20eb014202a35d03bee00f29ba3a072

Re: Review Request 65017: Removing com.cloudera.sqoop packages

2018-01-09 Thread Attila Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/#review195030
---



IMHO build.xml line 1098 (after this patch applied) should be also removed 
(this is an entry for the src/com/cloudera/sqoop directory to be included in 
the javadoc generation).

Otherwise the patch looks okay, but please let me to give a ship it after we 
have the required change, and I was able to execute the tests/releasenotes 
gen/etc. on my side as well!

Thanks,
Attila

- Attila Szabo


On Jan. 9, 2018, 12:52 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65017/
> ---
> 
> (Updated Jan. 9, 2018, 12:52 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3273
> https://issues.apache.org/jira/browse/SQOOP-3273
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This patch contains all the changes related to this JIRA.
> I have also created a pull request (https://github.com/apache/sqoop/pull/42) 
> because I think it is much easier to review it there since almost all of the 
> class removals were committed separately in my own Sqoop fork.
> 
> 
> Diffs
> -
> 
>   build.xml 2094bae8dde5fdaa40a7a1f86858cc79be198363 
>   conf/sqoop-site-template.xml 2182da3c88d3c6ff7dddea9f30f363435619285c 
>   ivy.xml d1530384efdecb45bd5b8ef802b60325da1dd400 
>   src/docs/dev/api-reference.txt 80453eec537a26f65e3e24b3d4da8741aceecb5b 
>   src/docs/sip/sip-4.txt 966412577126878065308324330342c6d0666f58 
>   src/java/com/cloudera/sqoop/ConnFactory.java 
> f75cb4e97e5b2febc21e59a6a6b827af010aa003 
>   src/java/com/cloudera/sqoop/Sqoop.java 
> 8ec9f8f044d10e8e071ac8a69c5860efc891f5fb 
>   src/java/com/cloudera/sqoop/SqoopOptions.java 
> 0863ef6dd71a67a5811d73bd0ef964e65e0e7afc 
>   src/java/com/cloudera/sqoop/cli/RelatedOptions.java 
> c6453b726b55fd87e1b596c3e537390582ece0a9 
>   src/java/com/cloudera/sqoop/cli/SqoopParser.java 
> 0c6d84e04c72c832a4b7160cdfffe7ebdf0c9284 
>   src/java/com/cloudera/sqoop/cli/ToolOptions.java 
> 0b5da6c3854543ceb1f1f11448d9f9bf8cba159d 
>   src/java/com/cloudera/sqoop/config/ConfigurationConstants.java 
> 72e7df133ec8bfd7be9f9006fdf8d399885ef230 
>   src/java/com/cloudera/sqoop/config/ConfigurationHelper.java 
> 0870497754a79b54c0a9338567e9af6adf931fca 
>   src/java/com/cloudera/sqoop/hbase/HBasePutProcessor.java 
> 425b0f46be7fb396ea92837c046ed9f8fbb129b1 
>   src/java/com/cloudera/sqoop/hbase/HBaseUtil.java 
> 6f1fba7d590e02c2b5f63b6e95e1ab5ad55c2e3d 
>   src/java/com/cloudera/sqoop/hbase/PutTransformer.java 
> b8ceab7782ce7bbb5c6e27eda6619ab086a6d28c 
>   src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java 
> 0c55b21ffbe2012705714c53bd33a8e672cc5ae0 
>   src/java/com/cloudera/sqoop/hive/HiveImport.java 
> db1c1b323b782a5a7c870e9802781a73f5617079 
>   src/java/com/cloudera/sqoop/hive/HiveTypes.java 
> e67f6b890bc25c19656c6bde99aeebc592b4d45f 
>   src/java/com/cloudera/sqoop/hive/TableDefWriter.java 
> d19e01863f54f9c013e01a1f422c6dbd711ca7e0 
>   src/java/com/cloudera/sqoop/io/CodecMap.java 
> 647cedcd2d3a8e5d4836f47f779ece8a78f0bb05 
>   src/java/com/cloudera/sqoop/io/FixedLengthInputStream.java 
> 806af22c01ed93f80ee32d4b5c1c203fe2dcdb5d 
>   src/java/com/cloudera/sqoop/io/LobFile.java 
> 905c68f64fd5b45665336cc0f27c5e9ace7eacdd 
>   src/java/com/cloudera/sqoop/io/LobReaderCache.java 
> 89d31d31aaca0f60d0042a5e3472b12dac01e0c9 
>   src/java/com/cloudera/sqoop/io/NamedFifo.java 
> e27d2c4f857bb806f2686d6d447aa0eb02fc97a3 
>   src/java/com/cloudera/sqoop/io/SplittableBufferedWriter.java 
> ef9285a62c1c35f48bdfae124a22c94a4e19b6d0 
>   src/java/com/cloudera/sqoop/io/SplittingOutputStream.java 
> ab81042b48f083dc10b5b81b5b5a53505106f26e 
>   src/java/com/cloudera/sqoop/io/UnsupportedCodecException.java 
> 4d8225a3d42477a2ac8c854d6f0bd303a99c4681 
>   src/java/com/cloudera/sqoop/lib/BigDecimalSerializer.java 
> 2ae89c24f053d6176e642f547e483c6cb4cba168 
>   src/java/com/cloudera/sqoop/lib/BlobRef.java 
> b3d5341e3e29289f985d15d259a167b7b7db7002 
>   src/java/com/cloudera/sqoop/lib/BooleanParser.java 
> ab97cf0a3156f3f8f09aa2ff7c427f8014f42e21 
>   src/java/com/cloudera/sqoop/lib/ClobRef.java 
> a328f23bfee882c850a4a2aa63e3ac364307f7a9 
>   src/java/com/cloudera/sqoop/lib/DelimiterSet.java 
> 6de90ad9419610ab9e3aabe96d1a3b13ca4d768e 
>   src/java/com/cloudera/sqoop/lib/FieldFormatter.java 
> 45fb81f40d86f8a9ff8ba8f5d5334dfbe3fed644 
>   src/java/com/cloudera/sqoop/lib/FieldMapProcessor.java 
> 3f215401f91f5934e4ac6b3830b2986032e336dd 
>   src/java/com/cloudera/sqoop/lib/FieldMappable.java 
> 2067ecc813146a41e7ccbcdd5472ffb29261db77 
>   src/java/com/cloudera/sqoop/lib/JdbcWritableBridge.java 
> 316547f108762c65ec1e11a16feb76f73045314d

[jira] [Updated] (SQOOP-3273) Removing com.cloudera.sqoop packages

2018-01-09 Thread Szabolcs Vasas (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SQOOP-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3273:
--
Attachment: SQOOP-3273.patch

> Removing com.cloudera.sqoop packages
> 
>
> Key: SQOOP-3273
> URL: https://issues.apache.org/jira/browse/SQOOP-3273
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
> Attachments: SQOOP-3273.patch, SQOOP-3273.patch
>
>
> Sqoop has dozens of classes in com.cloudera.sqoop packages which most of the 
> cases just extend their corresponding class in org.apache.sqoop package 
> without adding extra functionality.
> These classes make the code harder to read and navigate, they are already 
> deprecated but because of backward compatibility considerations we have not 
> removed them yet.
> The task is to make sure that all the functionality from com.cloudera.sqoop 
> classes is available in org.apache.sqoop classes and remove the classes from 
> com.cloudera.sqoop packages.
> The tests defined in com.cloudera.sqoop packages should also be migrated to 
> org.apache.sqoop package.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 65017: Removing com.cloudera.sqoop packages

2018-01-09 Thread Szabolcs Vasas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/
---

(Updated Jan. 9, 2018, 12:52 p.m.)


Review request for Sqoop.


Changes
---

The patch is rebased to the latest trunk.


Bugs: SQOOP-3273
https://issues.apache.org/jira/browse/SQOOP-3273


Repository: sqoop-trunk


Description
---

This patch contains all the changes related to this JIRA.
I have also created a pull request (https://github.com/apache/sqoop/pull/42) 
because I think it is much easier to review it there since almost all of the 
class removals were committed separately in my own Sqoop fork.


Diffs (updated)
-

  build.xml 2094bae8dde5fdaa40a7a1f86858cc79be198363 
  conf/sqoop-site-template.xml 2182da3c88d3c6ff7dddea9f30f363435619285c 
  ivy.xml d1530384efdecb45bd5b8ef802b60325da1dd400 
  src/docs/dev/api-reference.txt 80453eec537a26f65e3e24b3d4da8741aceecb5b 
  src/docs/sip/sip-4.txt 966412577126878065308324330342c6d0666f58 
  src/java/com/cloudera/sqoop/ConnFactory.java 
f75cb4e97e5b2febc21e59a6a6b827af010aa003 
  src/java/com/cloudera/sqoop/Sqoop.java 
8ec9f8f044d10e8e071ac8a69c5860efc891f5fb 
  src/java/com/cloudera/sqoop/SqoopOptions.java 
0863ef6dd71a67a5811d73bd0ef964e65e0e7afc 
  src/java/com/cloudera/sqoop/cli/RelatedOptions.java 
c6453b726b55fd87e1b596c3e537390582ece0a9 
  src/java/com/cloudera/sqoop/cli/SqoopParser.java 
0c6d84e04c72c832a4b7160cdfffe7ebdf0c9284 
  src/java/com/cloudera/sqoop/cli/ToolOptions.java 
0b5da6c3854543ceb1f1f11448d9f9bf8cba159d 
  src/java/com/cloudera/sqoop/config/ConfigurationConstants.java 
72e7df133ec8bfd7be9f9006fdf8d399885ef230 
  src/java/com/cloudera/sqoop/config/ConfigurationHelper.java 
0870497754a79b54c0a9338567e9af6adf931fca 
  src/java/com/cloudera/sqoop/hbase/HBasePutProcessor.java 
425b0f46be7fb396ea92837c046ed9f8fbb129b1 
  src/java/com/cloudera/sqoop/hbase/HBaseUtil.java 
6f1fba7d590e02c2b5f63b6e95e1ab5ad55c2e3d 
  src/java/com/cloudera/sqoop/hbase/PutTransformer.java 
b8ceab7782ce7bbb5c6e27eda6619ab086a6d28c 
  src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java 
0c55b21ffbe2012705714c53bd33a8e672cc5ae0 
  src/java/com/cloudera/sqoop/hive/HiveImport.java 
db1c1b323b782a5a7c870e9802781a73f5617079 
  src/java/com/cloudera/sqoop/hive/HiveTypes.java 
e67f6b890bc25c19656c6bde99aeebc592b4d45f 
  src/java/com/cloudera/sqoop/hive/TableDefWriter.java 
d19e01863f54f9c013e01a1f422c6dbd711ca7e0 
  src/java/com/cloudera/sqoop/io/CodecMap.java 
647cedcd2d3a8e5d4836f47f779ece8a78f0bb05 
  src/java/com/cloudera/sqoop/io/FixedLengthInputStream.java 
806af22c01ed93f80ee32d4b5c1c203fe2dcdb5d 
  src/java/com/cloudera/sqoop/io/LobFile.java 
905c68f64fd5b45665336cc0f27c5e9ace7eacdd 
  src/java/com/cloudera/sqoop/io/LobReaderCache.java 
89d31d31aaca0f60d0042a5e3472b12dac01e0c9 
  src/java/com/cloudera/sqoop/io/NamedFifo.java 
e27d2c4f857bb806f2686d6d447aa0eb02fc97a3 
  src/java/com/cloudera/sqoop/io/SplittableBufferedWriter.java 
ef9285a62c1c35f48bdfae124a22c94a4e19b6d0 
  src/java/com/cloudera/sqoop/io/SplittingOutputStream.java 
ab81042b48f083dc10b5b81b5b5a53505106f26e 
  src/java/com/cloudera/sqoop/io/UnsupportedCodecException.java 
4d8225a3d42477a2ac8c854d6f0bd303a99c4681 
  src/java/com/cloudera/sqoop/lib/BigDecimalSerializer.java 
2ae89c24f053d6176e642f547e483c6cb4cba168 
  src/java/com/cloudera/sqoop/lib/BlobRef.java 
b3d5341e3e29289f985d15d259a167b7b7db7002 
  src/java/com/cloudera/sqoop/lib/BooleanParser.java 
ab97cf0a3156f3f8f09aa2ff7c427f8014f42e21 
  src/java/com/cloudera/sqoop/lib/ClobRef.java 
a328f23bfee882c850a4a2aa63e3ac364307f7a9 
  src/java/com/cloudera/sqoop/lib/DelimiterSet.java 
6de90ad9419610ab9e3aabe96d1a3b13ca4d768e 
  src/java/com/cloudera/sqoop/lib/FieldFormatter.java 
45fb81f40d86f8a9ff8ba8f5d5334dfbe3fed644 
  src/java/com/cloudera/sqoop/lib/FieldMapProcessor.java 
3f215401f91f5934e4ac6b3830b2986032e336dd 
  src/java/com/cloudera/sqoop/lib/FieldMappable.java 
2067ecc813146a41e7ccbcdd5472ffb29261db77 
  src/java/com/cloudera/sqoop/lib/JdbcWritableBridge.java 
316547f108762c65ec1e11a16feb76f73045314d 
  src/java/com/cloudera/sqoop/lib/LargeObjectLoader.java 
b51cf0cc13cdf5dbcad1061956ece07118b29dbf 
  src/java/com/cloudera/sqoop/lib/LobRef.java 
518b62261ebb3e6c6dc4dab269f32e98be397c4d 
  src/java/com/cloudera/sqoop/lib/LobSerializer.java 
b8324fe261f42d32cff72f038fbaed933053f971 
  src/java/com/cloudera/sqoop/lib/ProcessingException.java 
c4216b1988bc64cc0860b7b8c19dd400d7cbf319 
  src/java/com/cloudera/sqoop/lib/RecordParser.java 
a3238e82d3c51dbffe9510bfd5d4cd8cbfb63230 
  src/java/com/cloudera/sqoop/lib/SqoopRecord.java 
7cfcbb36fb7a185bdcb037746fc47ea665b42294 
  src/java/com/cloudera/sqoop/manager/CatalogQueryManager.java 
5e6a725b8ca59aa0e716ac54c7722130305efa55 
  src/java/com/cloudera/sqoop/manager/ConnManager.java 
a4b44577b20eb014202a35d03bee00f29ba3a072

Re: Removing com.cloudera.sqoop packages

2018-01-09 Thread Ferenc Szabo 
Hi Szabi,

I believe this is a great idea.

By removing these packages we will get rid of a great deal of technical
debt that will simplify future change. I will also help to avoid
unnecessary conversions like the ones I had to use in my recent
SqoopOptions related change.

So, also +1 from me!

Cheers,
Fero

On Mon, Jan 8, 2018 at 5:59 PM, Boglarka Egyed  wrote:

> Hi Szabolcs,
>
> I really welcome this initiative, it would be a huge clean up on this
> project!
>
> I already took a look at your pull request and it indeed looks pretty
> straightforward.
>
> I will perform a deeper review and publish it on the Review Board otherwise
> +1 from my side for the idea in general, 1.5 release would be a good target
> for this.
>
> Thanks for taking this effort!
>
> Cheers.
> Bogi
>
> On Mon, Jan 8, 2018 at 2:01 PM, Szabolcs Vasas  wrote:
>
> > Hi All,
> >
> > As you probably know we still have dozens of classes in
> com.cloudera.sqoop
> > packages which most of the cases just extend their corresponding class in
> > org.apache.sqoop package without adding extra functionality.
> > These classes make the code harder to read and navigate, they are already
> > deprecated but because of backward compatibility considerations we were
> not
> > able to remove them.
> > The community was planning on a release containing breaking changes (we
> > called it 1.5) I think it would be a great candidate to include this
> > cleanup.
> > I have created a ticket  jira/browse/SQOOP-3273>
> > for doing this task and submitted a patch as well. I think the easiest
> way
> > to take a look at it is to review the commits in my Sqoop fork:
> > https://github.com/szvasas/sqoop/tree/cloudera_package_removal
> > Note that this is change which basically affects all of the files in the
> > Sqoop project, but in the majority of the cases replacing the
> > com.cloudera.sqoop class to its corresponding org.apache.sqoop class was
> > just a find and replace command so I consider this a relatively low risk
> > change.
> > Please feel free to reply to this email with your questions and concerns
> > and if you have some time please take a look at the changes.
> >
> > Thanks and regards,
> > Szabolcs
> >
>



-- 
Ferenc Szabo
Software Engineer

Re: Removing com.cloudera.sqoop packages

2018-01-08 Thread Boglarka Egyed 
Hi Szabolcs,

I really welcome this initiative, it would be a huge clean up on this
project!

I already took a look at your pull request and it indeed looks pretty
straightforward.

I will perform a deeper review and publish it on the Review Board otherwise
+1 from my side for the idea in general, 1.5 release would be a good target
for this.

Thanks for taking this effort!

Cheers.
Bogi

On Mon, Jan 8, 2018 at 2:01 PM, Szabolcs Vasas  wrote:

> Hi All,
>
> As you probably know we still have dozens of classes in com.cloudera.sqoop
> packages which most of the cases just extend their corresponding class in
> org.apache.sqoop package without adding extra functionality.
> These classes make the code harder to read and navigate, they are already
> deprecated but because of backward compatibility considerations we were not
> able to remove them.
> The community was planning on a release containing breaking changes (we
> called it 1.5) I think it would be a great candidate to include this
> cleanup.
> I have created a ticket 
> for doing this task and submitted a patch as well. I think the easiest way
> to take a look at it is to review the commits in my Sqoop fork:
> https://github.com/szvasas/sqoop/tree/cloudera_package_removal
> Note that this is change which basically affects all of the files in the
> Sqoop project, but in the majority of the cases replacing the
> com.cloudera.sqoop class to its corresponding org.apache.sqoop class was
> just a find and replace command so I consider this a relatively low risk
> change.
> Please feel free to reply to this email with your questions and concerns
> and if you have some time please take a look at the changes.
>
> Thanks and regards,
> Szabolcs
>

Removing com.cloudera.sqoop packages

2018-01-08 Thread Szabolcs Vasas 
Hi All,

As you probably know we still have dozens of classes in com.cloudera.sqoop
packages which most of the cases just extend their corresponding class in
org.apache.sqoop package without adding extra functionality.
These classes make the code harder to read and navigate, they are already
deprecated but because of backward compatibility considerations we were not
able to remove them.
The community was planning on a release containing breaking changes (we
called it 1.5) I think it would be a great candidate to include this
cleanup.
I have created a ticket 
for doing this task and submitted a patch as well. I think the easiest way
to take a look at it is to review the commits in my Sqoop fork:
https://github.com/szvasas/sqoop/tree/cloudera_package_removal
Note that this is change which basically affects all of the files in the
Sqoop project, but in the majority of the cases replacing the
com.cloudera.sqoop class to its corresponding org.apache.sqoop class was
just a find and replace command so I consider this a relatively low risk
change.
Please feel free to reply to this email with your questions and concerns
and if you have some time please take a look at the changes.

Thanks and regards,
Szabolcs

[jira] [Updated] (SQOOP-3273) Removing com.cloudera.sqoop packages

2018-01-08 Thread Szabolcs Vasas (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SQOOP-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3273:
--
Attachment: SQOOP-3273.patch

> Removing com.cloudera.sqoop packages
> 
>
> Key: SQOOP-3273
> URL: https://issues.apache.org/jira/browse/SQOOP-3273
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
> Attachments: SQOOP-3273.patch
>
>
> Sqoop has dozens of classes in com.cloudera.sqoop packages which most of the 
> cases just extend their corresponding class in org.apache.sqoop package 
> without adding extra functionality.
> These classes make the code harder to read and navigate, they are already 
> deprecated but because of backward compatibility considerations we have not 
> removed them yet.
> The task is to make sure that all the functionality from com.cloudera.sqoop 
> classes is available in org.apache.sqoop classes and remove the classes from 
> com.cloudera.sqoop packages.
> The tests defined in com.cloudera.sqoop packages should also be migrated to 
> org.apache.sqoop package.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Review Request 65017: Removing com.cloudera.sqoop packages

2018-01-08 Thread Szabolcs Vasas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/
---

Review request for Sqoop.


Bugs: SQOOP-3273
https://issues.apache.org/jira/browse/SQOOP-3273


Repository: sqoop-trunk


Description
---

This patch contains all the changes related to this JIRA.
I have also created a pull request (https://github.com/apache/sqoop/pull/42) 
because I think it is much easier to review it there since almost all of the 
class removals were committed separately in my own Sqoop fork.


Diffs
-

  build.xml 2094bae8d 
  conf/sqoop-site-template.xml 2182da3c8 
  ivy.xml 86de94f64 
  src/docs/dev/api-reference.txt 80453eec5 
  src/docs/sip/sip-4.txt 966412577 
  src/java/com/cloudera/sqoop/ConnFactory.java f75cb4e97 
  src/java/com/cloudera/sqoop/Sqoop.java 8ec9f8f04 
  src/java/com/cloudera/sqoop/SqoopOptions.java 0863ef6dd 
  src/java/com/cloudera/sqoop/cli/RelatedOptions.java c6453b726 
  src/java/com/cloudera/sqoop/cli/SqoopParser.java 0c6d84e04 
  src/java/com/cloudera/sqoop/cli/ToolOptions.java 0b5da6c38 
  src/java/com/cloudera/sqoop/config/ConfigurationConstants.java 72e7df133 
  src/java/com/cloudera/sqoop/config/ConfigurationHelper.java 087049775 
  src/java/com/cloudera/sqoop/hbase/HBasePutProcessor.java 425b0f46b 
  src/java/com/cloudera/sqoop/hbase/HBaseUtil.java 6f1fba7d5 
  src/java/com/cloudera/sqoop/hbase/PutTransformer.java b8ceab778 
  src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java 0c55b21ff 
  src/java/com/cloudera/sqoop/hive/HiveImport.java db1c1b323 
  src/java/com/cloudera/sqoop/hive/HiveTypes.java e67f6b890 
  src/java/com/cloudera/sqoop/hive/TableDefWriter.java d19e01863 
  src/java/com/cloudera/sqoop/io/CodecMap.java 647cedcd2 
  src/java/com/cloudera/sqoop/io/FixedLengthInputStream.java 806af22c0 
  src/java/com/cloudera/sqoop/io/LobFile.java 905c68f64 
  src/java/com/cloudera/sqoop/io/LobReaderCache.java 89d31d31a 
  src/java/com/cloudera/sqoop/io/NamedFifo.java e27d2c4f8 
  src/java/com/cloudera/sqoop/io/SplittableBufferedWriter.java ef9285a62 
  src/java/com/cloudera/sqoop/io/SplittingOutputStream.java ab81042b4 
  src/java/com/cloudera/sqoop/io/UnsupportedCodecException.java 4d8225a3d 
  src/java/com/cloudera/sqoop/lib/BigDecimalSerializer.java 2ae89c24f 
  src/java/com/cloudera/sqoop/lib/BlobRef.java b3d5341e3 
  src/java/com/cloudera/sqoop/lib/BooleanParser.java ab97cf0a3 
  src/java/com/cloudera/sqoop/lib/ClobRef.java a328f23bf 
  src/java/com/cloudera/sqoop/lib/DelimiterSet.java 6de90ad94 
  src/java/com/cloudera/sqoop/lib/FieldFormatter.java 45fb81f40 
  src/java/com/cloudera/sqoop/lib/FieldMapProcessor.java 3f215401f 
  src/java/com/cloudera/sqoop/lib/FieldMappable.java 2067ecc81 
  src/java/com/cloudera/sqoop/lib/JdbcWritableBridge.java 316547f10 
  src/java/com/cloudera/sqoop/lib/LargeObjectLoader.java b51cf0cc1 
  src/java/com/cloudera/sqoop/lib/LobRef.java 518b62261 
  src/java/com/cloudera/sqoop/lib/LobSerializer.java b8324fe26 
  src/java/com/cloudera/sqoop/lib/ProcessingException.java c4216b198 
  src/java/com/cloudera/sqoop/lib/RecordParser.java a3238e82d 
  src/java/com/cloudera/sqoop/lib/SqoopRecord.java 7cfcbb36f 
  src/java/com/cloudera/sqoop/manager/CatalogQueryManager.java 5e6a725b8 
  src/java/com/cloudera/sqoop/manager/ConnManager.java a4b44577b 
  src/java/com/cloudera/sqoop/manager/Db2Manager.java dd4c74327 
  src/java/com/cloudera/sqoop/manager/DefaultManagerFactory.java c1ca763d8 
  src/java/com/cloudera/sqoop/manager/DirectMySQLManager.java e13823d42 
  src/java/com/cloudera/sqoop/manager/DirectPostgresqlManager.java 18cbe747f 
  src/java/com/cloudera/sqoop/manager/ExportJobContext.java cad63a164 
  src/java/com/cloudera/sqoop/manager/GenericJdbcManager.java 14d4554d7 
  src/java/com/cloudera/sqoop/manager/HsqldbManager.java e0a2cf9b7 
  src/java/com/cloudera/sqoop/manager/ImportJobContext.java 8eec2eb94 
  src/java/com/cloudera/sqoop/manager/InformationSchemaManager.java 056ddeab3 
  src/java/com/cloudera/sqoop/manager/ManagerFactory.java 3ffa72244 
  src/java/com/cloudera/sqoop/manager/MySQLManager.java 4c29a4c34 
  src/java/com/cloudera/sqoop/manager/MySQLUtils.java 341032465 
  src/java/com/cloudera/sqoop/manager/OracleManager.java 7beb521b9 
  src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 354d260f0 
  src/java/com/cloudera/sqoop/manager/SQLServerManager.java 2cc0458f3 
  src/java/com/cloudera/sqoop/manager/SqlManager.java 398e01b3c 
  src/java/com/cloudera/sqoop/mapreduce/AsyncSqlOutputFormat.java ccd2be5a6 
  src/java/com/cloudera/sqoop/mapreduce/AsyncSqlRecordWriter.java 265dc270d 
  src/java/com/cloudera/sqoop/mapreduce/AutoProgressMapper.java ee8ab6ddb 
  src/java/com/cloudera/sqoop/mapreduce/AvroExportMapper.java 725b9d065 
  src/java/com/cloudera/sqoop/mapreduce/AvroImportMapper.java 08b578898 
  src/java/com/cloudera/sqoop/mapreduce/AvroInputFormat.java

[jira] [Commented] (SQOOP-3273) Removing com.cloudera.sqoop packages

2018-01-08 Thread ASF GitHub Bot (JIRA) 
26:13Z

com.cloudera.sqoop.lib.ClobRef is not used anymore. It had to be commented 
out because the interface of its superclass has been changed.

commit 0a7d42d73ab699a2f9353293fccd02565eaa4605
Author: Szabolcs Vasas <vasas@...>
Date:   2017-12-18T11:30:28Z

com.cloudera.sqoop.lib.FieldFormatter is not used anymore.

commit 079c3d01d394addeb64aeee0d01ca875fe271c35
Author: Szabolcs Vasas <vasas@...>
Date:   2017-12-18T12:25:17Z

com.cloudera.sqoop.lib.FieldMappable is not used anymore.

commit 65de738b541771dcac168ece3d97d8fae6e88f12
Author: Szabolcs Vasas <vasas@...>
Date:   2017-12-18T12:26:30Z

com.cloudera.sqoop.lib.FieldMapProcessor is not used anymore.

commit 45ede417f75d339384c2545a947dfc0da9f53d46
Author: Szabolcs Vasas <vasas@...>
Date:   2017-12-18T12:31:09Z

com.cloudera.sqoop.lib.JdbcWritableBridge is not used anymore.

commit cfeb54f4e64de759cbfcbce9c186213b077bb9dd
Author: Szabolcs Vasas <vasas@...>
Date:   2017-12-18T12:40:14Z

com.cloudera.sqoop.lib.LargeObjectLoader is not used anymore.

commit 4b2c9eee01a1a5da9ba7fd09cf5371e13a2a8550
Author: Szabolcs Vasas <vasas@...>
Date:   2017-12-18T12:41:38Z

com.cloudera.sqoop.lib.LobRef is not used anymore.

commit 8ad3bc2c0f3eafb800e387b1c83d9d8061775904
Author: Szabolcs Vasas <vasas@...>
Date:   2017-12-18T12:42:12Z

com.cloudera.sqoop.lib.LobSerilaizer is not used anymore.

commit 4323d62d114c2ba85a9b7a9fc6a09b5aeffe8384
Author: Szabolcs Vasas <vasas@...>
Date:   2017-12-18T12:48:00Z

com.cloudera.sqoop.lib.RecordParser is not used anymore.

commit 406817dadebb41433bc7ae21420bc9aff30f9891
Author: Szabolcs Vasas <vasas@...>
Date:   2017-12-18T12:57:30Z

com.cloudera.sqoop.lib.SqoopRecord is not used anymore.

commit feacaf3ad09e0c33f5b2b3bc3f7dc067bf7ae50e
Author: Szabolcs Vasas <vasas@...>
Date:   2017-12-18T12:59:22Z

com.cloudera.sqoop.manager.CatalogQueryManager is not used anymore.




> Removing com.cloudera.sqoop packages
> 
>
> Key: SQOOP-3273
> URL: https://issues.apache.org/jira/browse/SQOOP-3273
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>
> Sqoop has dozens of classes in com.cloudera.sqoop packages which most of the 
> cases just extend their corresponding class in org.apache.sqoop package 
> without adding extra functionality.
> These classes make the code harder to read and navigate, they are already 
> deprecated but because of backward compatibility considerations we have not 
> removed them yet.
> The task is to make sure that all the functionality from com.cloudera.sqoop 
> classes is available in org.apache.sqoop classes and remove the classes from 
> com.cloudera.sqoop packages.
> The tests defined in com.cloudera.sqoop packages should also be migrated to 
> org.apache.sqoop package.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SQOOP-3273) Removing com.cloudera.sqoop packages

2018-01-08 Thread Szabolcs Vasas (JIRA) 
Szabolcs Vasas created SQOOP-3273:
-

 Summary: Removing com.cloudera.sqoop packages
 Key: SQOOP-3273
 URL: https://issues.apache.org/jira/browse/SQOOP-3273
 Project: Sqoop
  Issue Type: Improvement
Reporter: Szabolcs Vasas


Sqoop has dozens of classes in com.cloudera.sqoop packages which most of the 
cases just extend their corresponding class in org.apache.sqoop package without 
adding extra functionality.
These classes make the code harder to read and navigate, they are already 
deprecated but because of backward compatibility considerations we have not 
removed them yet.
The task is to make sure that all the functionality from com.cloudera.sqoop 
classes is available in org.apache.sqoop classes and remove the classes from 
com.cloudera.sqoop packages.
The tests defined in com.cloudera.sqoop packages should also be migrated to 
org.apache.sqoop package.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (SQOOP-3273) Removing com.cloudera.sqoop packages

2018-01-08 Thread Szabolcs Vasas (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SQOOP-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas reassigned SQOOP-3273:
-

Assignee: Szabolcs Vasas

> Removing com.cloudera.sqoop packages
> 
>
> Key: SQOOP-3273
> URL: https://issues.apache.org/jira/browse/SQOOP-3273
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>
> Sqoop has dozens of classes in com.cloudera.sqoop packages which most of the 
> cases just extend their corresponding class in org.apache.sqoop package 
> without adding extra functionality.
> These classes make the code harder to read and navigate, they are already 
> deprecated but because of backward compatibility considerations we have not 
> removed them yet.
> The task is to make sure that all the functionality from com.cloudera.sqoop 
> classes is available in org.apache.sqoop classes and remove the classes from 
> com.cloudera.sqoop packages.
> The tests defined in com.cloudera.sqoop packages should also be migrated to 
> org.apache.sqoop package.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)