[GitHub] [storm] srdo commented on a change in pull request #3000: STORM-3381: Exclude spotbugs-annotations from Zookeeper, regen DEPEND…
srdo commented on a change in pull request #3000: STORM-3381: Exclude spotbugs-annotations from Zookeeper, regen DEPEND… URL: https://github.com/apache/storm/pull/3000#discussion_r276365383 ## File path: DEPENDENCY-LICENSES ## @@ -584,6 +582,7 @@ List of third-party dependencies grouped by their license type. * Woodstox (org.codehaus.woodstox:woodstox-core-asl:4.4.1 - http://woodstox.codehaus.org) * Xerces2 Java Parser (xerces:xercesImpl:2.9.1 - http://xerces.apache.org/xerces2-j) * XML Commons External Components XML APIs (xml-apis:xml-apis:1.3.04 - http://xml.apache.org/commons/components/external/) +* zookeeper (org.apache.zookeeper:zookeeper:3.4.14 - no url defined) Review comment: I think we can override urls for the dependencies that are missing them. I'll check. If that works I'll put it up in a later PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] srdo commented on a change in pull request #3000: STORM-3381: Exclude spotbugs-annotations from Zookeeper, regen DEPEND…
srdo commented on a change in pull request #3000: STORM-3381: Exclude spotbugs-annotations from Zookeeper, regen DEPEND… URL: https://github.com/apache/storm/pull/3000#discussion_r276363736 ## File path: DEPENDENCY-LICENSES ## @@ -584,6 +582,7 @@ List of third-party dependencies grouped by their license type. * Woodstox (org.codehaus.woodstox:woodstox-core-asl:4.4.1 - http://woodstox.codehaus.org) * Xerces2 Java Parser (xerces:xercesImpl:2.9.1 - http://xerces.apache.org/xerces2-j) * XML Commons External Components XML APIs (xml-apis:xml-apis:1.3.04 - http://xml.apache.org/commons/components/external/) +* zookeeper (org.apache.zookeeper:zookeeper:3.4.14 - no url defined) Review comment: The file is autogenerated. It will just get overwritten. Best fix is to get Zookeeper to add an URL to their pom. As far as I can tell they're in the middle of a migration to Maven, and the new pom has an URL in the license section https://github.com/apache/zookeeper/blob/ff47fc3dfda3487ca3a5aca2ea16831b2aebc7e2/pom.xml#L54 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] hmcl commented on a change in pull request #3000: STORM-3381: Exclude spotbugs-annotations from Zookeeper, regen DEPEND…
hmcl commented on a change in pull request #3000: STORM-3381: Exclude spotbugs-annotations from Zookeeper, regen DEPEND… URL: https://github.com/apache/storm/pull/3000#discussion_r276361564 ## File path: DEPENDENCY-LICENSES ## @@ -584,6 +582,7 @@ List of third-party dependencies grouped by their license type. * Woodstox (org.codehaus.woodstox:woodstox-core-asl:4.4.1 - http://woodstox.codehaus.org) * Xerces2 Java Parser (xerces:xercesImpl:2.9.1 - http://xerces.apache.org/xerces2-j) * XML Commons External Components XML APIs (xml-apis:xml-apis:1.3.04 - http://xml.apache.org/commons/components/external/) +* zookeeper (org.apache.zookeeper:zookeeper:3.4.14 - no url defined) Review comment: NIT: missing the URL on both zk entries This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] hmcl commented on a change in pull request #3000: STORM-3381: Exclude spotbugs-annotations from Zookeeper, regen DEPEND…
hmcl commented on a change in pull request #3000: STORM-3381: Exclude spotbugs-annotations from Zookeeper, regen DEPEND… URL: https://github.com/apache/storm/pull/3000#discussion_r276361564 ## File path: DEPENDENCY-LICENSES ## @@ -584,6 +582,7 @@ List of third-party dependencies grouped by their license type. * Woodstox (org.codehaus.woodstox:woodstox-core-asl:4.4.1 - http://woodstox.codehaus.org) * Xerces2 Java Parser (xerces:xercesImpl:2.9.1 - http://xerces.apache.org/xerces2-j) * XML Commons External Components XML APIs (xml-apis:xml-apis:1.3.04 - http://xml.apache.org/commons/components/external/) +* zookeeper (org.apache.zookeeper:zookeeper:3.4.14 - no url defined) Review comment: NIT: missing the URL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] hmcl commented on issue #3000: STORM-3381: Exclude spotbugs-annotations from Zookeeper, regen DEPEND…
hmcl commented on issue #3000: STORM-3381: Exclude spotbugs-annotations from Zookeeper, regen DEPEND… URL: https://github.com/apache/storm/pull/3000#issuecomment-484194064 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache Storm 2.0.0 (rc6)
Fix at https://github.com/apache/storm/pull/3000. Den ons. 17. apr. 2019 kl. 12.51 skrev Stig Rohde Døssing < stigdoess...@gmail.com>: > -1 > > Upgrading to Zookeeper 3.4.14 added a transitive dependency on > spotbugs-annotations, which is LGPL licensed. I filed a bug for it at > https://issues.apache.org/jira/browse/STORM-3381, and a matching one for > Zookeeper https://issues.apache.org/jira/browse/ZOOKEEPER-3367. > > Sorry, should have caught this during the PR. In the longer run, I'll see > if we can automate license checking a bit more, it would be nice if Travis > failed unless the license files are up to date, so it is obvious when stuff > like this happens. > > > Den tir. 16. apr. 2019 kl. 20.42 skrev P. Taylor Goetz >: > >> This is a call to vote on releasing Apache Storm 2.0.0 (rc6) >> >> Full list of changes in this release: >> >> >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc6/RELEASE_NOTES.html >> >> The tag/commit to be voted upon is v2.0.0: >> >> >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=fb277b90c8488aec017eed066a9fd221a247e4f9;hb=ac046ee6170d982f98b66f3ed21a82f979707d68 >> >> The source archive being voted upon can be found here: >> >> >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc6/apache-storm-2.0.0-src.tar.gz >> >> Other release files, signatures and digests can be found here: >> >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc6/ >> >> The release artifacts are signed with the following key: >> >> >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd >> >> The Nexus staging repository for this release is: >> >> https://repository.apache.org/content/repositories/orgapachestorm-1077 >> >> Please vote on releasing this package as Apache Storm 2.0.0. >> >> When voting, please list the actions taken to verify the release. >> >> This vote will be open for at least 72 hours. >> >> [ ] +1 Release this package as Apache Storm 2.0.0 >> [ ] 0 No opinion >> [ ] -1 Do not release this package because... >> >> Thanks to everyone who contributed to this release. >> >> -Taylor > >
[GitHub] [storm] srdo opened a new pull request #3000: STORM-3381: Exclude spotbugs-annotations from Zookeeper, regen DEPEND…
srdo opened a new pull request #3000: STORM-3381: Exclude spotbugs-annotations from Zookeeper, regen DEPEND… URL: https://github.com/apache/storm/pull/3000 …ENCY-LICENSES https://issues.apache.org/jira/browse/STORM-3381 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache Storm 2.0.0 (rc6)
-1 Upgrading to Zookeeper 3.4.14 added a transitive dependency on spotbugs-annotations, which is LGPL licensed. I filed a bug for it at https://issues.apache.org/jira/browse/STORM-3381, and a matching one for Zookeeper https://issues.apache.org/jira/browse/ZOOKEEPER-3367. Sorry, should have caught this during the PR. In the longer run, I'll see if we can automate license checking a bit more, it would be nice if Travis failed unless the license files are up to date, so it is obvious when stuff like this happens. Den tir. 16. apr. 2019 kl. 20.42 skrev P. Taylor Goetz : > This is a call to vote on releasing Apache Storm 2.0.0 (rc6) > > Full list of changes in this release: > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc6/RELEASE_NOTES.html > > The tag/commit to be voted upon is v2.0.0: > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=fb277b90c8488aec017eed066a9fd221a247e4f9;hb=ac046ee6170d982f98b66f3ed21a82f979707d68 > > The source archive being voted upon can be found here: > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc6/apache-storm-2.0.0-src.tar.gz > > Other release files, signatures and digests can be found here: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc6/ > > The release artifacts are signed with the following key: > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > The Nexus staging repository for this release is: > > https://repository.apache.org/content/repositories/orgapachestorm-1077 > > Please vote on releasing this package as Apache Storm 2.0.0. > > When voting, please list the actions taken to verify the release. > > This vote will be open for at least 72 hours. > > [ ] +1 Release this package as Apache Storm 2.0.0 > [ ] 0 No opinion > [ ] -1 Do not release this package because... > > Thanks to everyone who contributed to this release. > > -Taylor
