Re: [VOTE] Release Apache Storm 1.2.3 (rc2)
Hello Taylor, Thank you very much for this Storm 1.2.3 release. You did a great job to make this process running smoothly for many releases; and I know that donating one's time on such large project is a huge contribution. Whatever you'll do next, may the code with be you! Alexandre Vermeerbergen Le sam. 15 juin 2019 à 18:15, P. Taylor Goetz a écrit : > > This vote is now closed and passes with 3 binding +1 votes and 1 non-binding > +1 vote. > > I will release the artifacts and create a release announcement. > > -Taylor > > > On May 10, 2019, at 12:20 PM, P. Taylor Goetz wrote: > > > > This is a call to vote on releasing Apache Storm 1.2.3 (rc2) > > > > Full list of changes in this release: > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.3-rc2/RELEASE_NOTES.html > > > > The tag/commit to be voted upon is v1.2.3: > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=ac0e39d7cad48b3ec863c8a3b711d36511d4daf6;hb=4e162a47c8219546ab9639401363a8f1b5e51119 > > > > The source archive being voted upon can be found here: > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.3-rc2/apache-storm-1.2.3-src.tar.gz > > > > Other release files, signatures and digests can be found here: > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.3-rc2/ > > > > The release artifacts are signed with the following key: > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > > > The Nexus staging repository for this release is: > > > > https://repository.apache.org/content/repositories/orgapachestorm-1081 > > > > Please vote on releasing this package as Apache Storm 1.2.3. > > > > When voting, please list the actions taken to verify the release. > > > > This vote will be open for at least 72 hours. > > > > [ ] +1 Release this package as Apache Storm 1.2.3 > > [ ] 0 No opinion > > [ ] -1 Do not release this package because... > > > > Thanks to everyone who contributed to this release. > > > > -Taylor >
[GitHub] [storm] krichter722 opened a new pull request #3027: Remove JavadocMethod checkstyle rule
krichter722 opened a new pull request #3027: Remove JavadocMethod checkstyle rule URL: https://github.com/apache/storm/pull/3027 Remove JavadocMethod checkstyle rule because it requires tons of Javadocs to be invented on files which are not touched for years and whose Javadoc can be covered with clean code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] srdo commented on issue #3025: Checkstyle jms examples
srdo commented on issue #3025: Checkstyle jms examples URL: https://github.com/apache/storm/pull/3025#issuecomment-502389017 Okay, figured out the issue. The travis script builds storm-shaded-deps first, separately from the rest of the build. This means storm-checkstyle isn't build first, which means it's using whatever version is cached. I'll fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] srdo commented on issue #3025: Checkstyle jms examples
srdo commented on issue #3025: Checkstyle jms examples URL: https://github.com/apache/storm/pull/3025#issuecomment-502388595 I think it's an issue inherited from https://github.com/apache/storm/pull/3020/files, looks like it can't find the storm/pmd-ruleset file added to config here https://github.com/apache/storm/pull/3020/files#diff-600376dffeb79835ede4a0b285078036R1257 Master may have passed because the Maven repo was cached, and contained storm-checkstyle from an earlier build. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] srdo commented on a change in pull request #3025: Checkstyle jms examples
srdo commented on a change in pull request #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#discussion_r294055492
##
File path:
examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/ExampleJmsTopology.java
##
@@ -41,7 +45,12 @@
public static final String JMS_TOPIC_SPOUT = "JMS_TOPIC_SPOUT";
public static final String ANOTHER_BOLT = "ANOTHER_BOLT";
-@SuppressWarnings("serial")
+/**
+ * The main method.
+ * @param args takes the topology name as first argument
+ * @throws Exception any expection occuring durch cluster setup or
operation
+ */
+@SuppressWarnings({"serial",
"checkstyle:VariableDeclarationUsageDistance"})
Review comment:
I agree in principle, but in this case the violation is just saying to move
the `jmsTopicProvider` declaration closer to where it is first used. I don't
think you need to break up the method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] krichter722 opened a new pull request #3026: Checkstyle jdbc examples
krichter722 opened a new pull request #3026: Checkstyle jdbc examples URL: https://github.com/apache/storm/pull/3026 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] krichter722 commented on issue #3025: Checkstyle jms examples
krichter722 commented on issue #3025: Checkstyle jms examples URL: https://github.com/apache/storm/pull/3025#issuecomment-502388069 Can anyone tell me, why master builds and this branch doesn't because of missing files in `storm-checkstyle` if nothing has been changed in the only commit of this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] srdo commented on a change in pull request #3025: Checkstyle jms examples
srdo commented on a change in pull request #3025: Checkstyle jms examples URL: https://github.com/apache/storm/pull/3025#discussion_r294055286 ## File path: examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/GenericBolt.java ## @@ -15,27 +15,28 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + package org.apache.storm.jms.example; import java.util.Map; -import org.apache.storm.topology.base.BaseRichBolt; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - import org.apache.storm.task.OutputCollector; import org.apache.storm.task.TopologyContext; import org.apache.storm.topology.OutputFieldsDeclarer; +import org.apache.storm.topology.base.BaseRichBolt; import org.apache.storm.tuple.Fields; import org.apache.storm.tuple.Tuple; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + /** * A generic org.apache.storm.topology.IRichBolt implementation * for testing/debugging the Storm JMS Spout and example topologies. - * - * For debugging purposes, set the log level of the + * + * For debugging purposes, set the log level of the * org.apache.storm.contrib.jms package to DEBUG for debugging - * output. + * output. Review comment: No, it's fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] krichter722 commented on a change in pull request #3025: Checkstyle jms examples
krichter722 commented on a change in pull request #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#discussion_r294055250
##
File path:
examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/ExampleJmsTopology.java
##
@@ -41,7 +45,12 @@
public static final String JMS_TOPIC_SPOUT = "JMS_TOPIC_SPOUT";
public static final String ANOTHER_BOLT = "ANOTHER_BOLT";
-@SuppressWarnings("serial")
+/**
+ * The main method.
+ * @param args takes the topology name as first argument
+ * @throws Exception any expection occuring durch cluster setup or
operation
+ */
+@SuppressWarnings({"serial",
"checkstyle:VariableDeclarationUsageDistance"})
Review comment:
In my opinion it's valid to make exceptions if they're thought through.
Especially is the exception is associated with concrete line of code rather
than just represented by a count.
Breaking up this method would reduce it's readability in my opinion. After
all, I don't care, but I'm starting the discussion in order to figure out
whether you're strictly against it (I might do similar work) or whether you
accept it if you agree.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] krichter722 commented on a change in pull request #3025: Checkstyle jms examples
krichter722 commented on a change in pull request #3025: Checkstyle jms examples URL: https://github.com/apache/storm/pull/3025#discussion_r294055135 ## File path: examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/GenericBolt.java ## @@ -15,27 +15,28 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + package org.apache.storm.jms.example; import java.util.Map; -import org.apache.storm.topology.base.BaseRichBolt; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - import org.apache.storm.task.OutputCollector; import org.apache.storm.task.TopologyContext; import org.apache.storm.topology.OutputFieldsDeclarer; +import org.apache.storm.topology.base.BaseRichBolt; import org.apache.storm.tuple.Fields; import org.apache.storm.tuple.Tuple; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + /** * A generic org.apache.storm.topology.IRichBolt implementation * for testing/debugging the Storm JMS Spout and example topologies. - * - * For debugging purposes, set the log level of the + * + * For debugging purposes, set the log level of the * org.apache.storm.contrib.jms package to DEBUG for debugging - * output. + * output. Review comment: They're not necessary in HTML, but possible. I don't like the idea and it's been changed in XHTML. Do you insist? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] srdo commented on issue #3020: [STORM-3000] Add missing @Override annotations
srdo commented on issue #3020: [STORM-3000] Add missing @Override annotations URL: https://github.com/apache/storm/pull/3020#issuecomment-502387374 Ah right, sorry I misunderstood. You are right, that is painful. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] srdo commented on a change in pull request #3025: Checkstyle jms examples
srdo commented on a change in pull request #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#discussion_r294054906
##
File path:
examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/ExampleJmsTopology.java
##
@@ -41,7 +45,12 @@
public static final String JMS_TOPIC_SPOUT = "JMS_TOPIC_SPOUT";
public static final String ANOTHER_BOLT = "ANOTHER_BOLT";
-@SuppressWarnings("serial")
+/**
+ * The main method.
+ * @param args takes the topology name as first argument
+ * @throws Exception any expection occuring durch cluster setup or
operation
+ */
+@SuppressWarnings({"serial",
"checkstyle:VariableDeclarationUsageDistance"})
Review comment:
This seems like a bad way to get violation count to 0. We're just hiding the
violation now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] srdo commented on a change in pull request #3025: Checkstyle jms examples
srdo commented on a change in pull request #3025: Checkstyle jms examples URL: https://github.com/apache/storm/pull/3025#discussion_r294054914 ## File path: examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/GenericBolt.java ## @@ -15,27 +15,28 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + package org.apache.storm.jms.example; import java.util.Map; -import org.apache.storm.topology.base.BaseRichBolt; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - import org.apache.storm.task.OutputCollector; import org.apache.storm.task.TopologyContext; import org.apache.storm.topology.OutputFieldsDeclarer; +import org.apache.storm.topology.base.BaseRichBolt; import org.apache.storm.tuple.Fields; import org.apache.storm.tuple.Tuple; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + /** * A generic org.apache.storm.topology.IRichBolt implementation * for testing/debugging the Storm JMS Spout and example topologies. - * - * For debugging purposes, set the log level of the + * + * For debugging purposes, set the log level of the * org.apache.storm.contrib.jms package to DEBUG for debugging - * output. + * output. Review comment: nit: I don't think p tags need to be closed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] krichter722 edited a comment on issue #3020: [STORM-3000] Add missing @Override annotations
krichter722 edited a comment on issue #3020: [STORM-3000] Add missing @Override annotations URL: https://github.com/apache/storm/pull/3020#issuecomment-502386844 Thanks. > Regarding adjusting maxAllowedViolations, I don't see why it is painful? You need to count how many violations you fixed and change the number and do that for every project, otherwise new violations can be committed. I think this requires a lot of effort on top of fixing all violations which needs to be done anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] krichter722 commented on issue #3020: [STORM-3000] Add missing @Override annotations
krichter722 commented on issue #3020: [STORM-3000] Add missing @Override annotations URL: https://github.com/apache/storm/pull/3020#issuecomment-502386844 > Regarding adjusting maxAllowedViolations, I don't see why it is painful? You need to count how many violations you fixed and change the number and do that for every project, otherwise new violations can be committed. I think this requires a lot of effort on top of fixing all violations which needs to be done anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] srdo merged pull request #3020: [STORM-3000] Add missing @Override annotations
srdo merged pull request #3020: [STORM-3000] Add missing @Override annotations URL: https://github.com/apache/storm/pull/3020 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] srdo commented on issue #3020: [STORM-3000] Add missing @Override annotations
srdo commented on issue #3020: [STORM-3000] Add missing @Override annotations URL: https://github.com/apache/storm/pull/3020#issuecomment-502386587 @krichter722 Yes, thanks for your patience. Regarding adjusting maxAllowedViolations, I don't see why it is painful? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] krichter722 edited a comment on issue #3020: [STORM-3000] Add missing @Override annotations
krichter722 edited a comment on issue #3020: [STORM-3000] Add missing @Override annotations URL: https://github.com/apache/storm/pull/3020#issuecomment-502386214 @d2r #3025 covers some of the issues. Fixing one issue (whitespace, unused variables, etc.) for all project requires the readjustment of maxAllowedViolations which is painful. I suggest pushing getting all projects to have maxAllowedViolations == 0. It's the least troublesome approach in my opinion. I enjoy doing these tasks from time to time, so if you're patient, so might see the gone step by step. This can be merged, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] krichter722 edited a comment on issue #3020: [STORM-3000] Add missing @Override annotations
krichter722 edited a comment on issue #3020: [STORM-3000] Add missing @Override annotations URL: https://github.com/apache/storm/pull/3020#issuecomment-502386214 #3025 covers some of the issues. Fixing one issue (whitespace, unused variables, etc.) for all project requires the readjustment of maxAllowedViolations which is painful. I suggest pushing getting all projects to have maxAllowedViolations == 0. It's the least troublesome approach in my opinion. This can be merged, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] krichter722 commented on issue #3020: [STORM-3000] Add missing @Override annotations
krichter722 commented on issue #3020: [STORM-3000] Add missing @Override annotations URL: https://github.com/apache/storm/pull/3020#issuecomment-502386214 #3025 covers some of the issues. Since fixing one issue for all project requires the readjustment of maxAllowedViolations which is painful. I suggest pushing getting all projects to have maxAllowedViolations == 0. It's the least troublesome approach in my opinion. This can be merged, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] krichter722 opened a new pull request #3025: Checkstyle jms examples
krichter722 opened a new pull request #3025: Checkstyle jms examples URL: https://github.com/apache/storm/pull/3025 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] d2r commented on issue #3020: [STORM-3000] Add missing @Override annotations
d2r commented on issue #3020: [STORM-3000] Add missing @Override annotations URL: https://github.com/apache/storm/pull/3020#issuecomment-502383898 > it may be that the violations weren't caught because it didn't increase the number of violations, or maybe the allowed count is too high I see you have put some thought into this already: This could be addressed by your jira issue [STORM-3071](https://issues.apache.org/jira/browse/STORM-3071). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] srdo commented on issue #2978: STORM-3311: Use Java 7 Files API for file IO
srdo commented on issue #2978: STORM-3311: Use Java 7 Files API for file IO URL: https://github.com/apache/storm/pull/2978#issuecomment-502383599 This is ready for review, since Storm 2.0.0 has released. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] srdo commented on issue #3020: [STORM-3000] Add missing @Override annotations
srdo commented on issue #3020: [STORM-3000] Add missing @Override annotations URL: https://github.com/apache/storm/pull/3020#issuecomment-502383408 @d2r The module has a number of allowed violations, it may be that the violations weren't caught because it didn't increase the number of violations, or maybe the allowed count is too high https://github.com/apache/storm/blob/master/examples/storm-jms-examples/pom.xml#L108 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] d2r commented on issue #3020: [STORM-3000] Add missing @Override annotations
d2r commented on issue #3020: [STORM-3000] Add missing @Override annotations URL: https://github.com/apache/storm/pull/3020#issuecomment-502383113 > I already did that for some projects. I'll open them soon. That would be great! I wanted to do three things: * Normalize white-space on master branch * Figure out why `mvn checkstyle:checkstyle` does not work, because it [should have caught this](https://github.com/apache/storm/blob/b9ab5e56a9ad1776022ed6d8520c0268a666fea0/storm-checkstyle/src/main/resources/storm/storm_checkstyle.xml#L56-L61) * Perhaps add an [.editorconfig](https://editorconfig.org/) to our repo, to help make it easier in avoiding these types of errors. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] krichter722 commented on issue #3020: [STORM-3000] Add missing @Override annotations
krichter722 commented on issue #3020: [STORM-3000] Add missing @Override annotations URL: https://github.com/apache/storm/pull/3020#issuecomment-502382161 > For this PR it is minor, and fixing the other white-space is out of scope anyway. I'll follow up on this white-space separately. I already did that for some projects. I'll open them soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache Storm 1.2.3 (rc2)
Thank you Taylor.. On Sat, Jun 15, 2019 at 12:15 PM P. Taylor Goetz wrote: > This vote is now closed and passes with 3 binding +1 votes and 1 > non-binding +1 vote. > > I will release the artifacts and create a release announcement. > > -Taylor > > > On May 10, 2019, at 12:20 PM, P. Taylor Goetz wrote: > > > > This is a call to vote on releasing Apache Storm 1.2.3 (rc2) > > > > Full list of changes in this release: > > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.3-rc2/RELEASE_NOTES.html > > > > The tag/commit to be voted upon is v1.2.3: > > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=ac0e39d7cad48b3ec863c8a3b711d36511d4daf6;hb=4e162a47c8219546ab9639401363a8f1b5e51119 > > > > The source archive being voted upon can be found here: > > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.3-rc2/apache-storm-1.2.3-src.tar.gz > > > > Other release files, signatures and digests can be found here: > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.3-rc2/ > > > > The release artifacts are signed with the following key: > > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > > > The Nexus staging repository for this release is: > > > > https://repository.apache.org/content/repositories/orgapachestorm-1081 > > > > Please vote on releasing this package as Apache Storm 1.2.3. > > > > When voting, please list the actions taken to verify the release. > > > > This vote will be open for at least 72 hours. > > > > [ ] +1 Release this package as Apache Storm 1.2.3 > > [ ] 0 No opinion > > [ ] -1 Do not release this package because... > > > > Thanks to everyone who contributed to this release. > > > > -Taylor > >
Re: [VOTE] Release Apache Storm 1.2.3 (rc2)
This vote is now closed and passes with 3 binding +1 votes and 1 non-binding +1 vote. I will release the artifacts and create a release announcement. -Taylor > On May 10, 2019, at 12:20 PM, P. Taylor Goetz wrote: > > This is a call to vote on releasing Apache Storm 1.2.3 (rc2) > > Full list of changes in this release: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.3-rc2/RELEASE_NOTES.html > > The tag/commit to be voted upon is v1.2.3: > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=ac0e39d7cad48b3ec863c8a3b711d36511d4daf6;hb=4e162a47c8219546ab9639401363a8f1b5e51119 > > The source archive being voted upon can be found here: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.3-rc2/apache-storm-1.2.3-src.tar.gz > > Other release files, signatures and digests can be found here: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.3-rc2/ > > The release artifacts are signed with the following key: > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > The Nexus staging repository for this release is: > > https://repository.apache.org/content/repositories/orgapachestorm-1081 > > Please vote on releasing this package as Apache Storm 1.2.3. > > When voting, please list the actions taken to verify the release. > > This vote will be open for at least 72 hours. > > [ ] +1 Release this package as Apache Storm 1.2.3 > [ ] 0 No opinion > [ ] -1 Do not release this package because... > > Thanks to everyone who contributed to this release. > > -Taylor
[GitHub] [storm] srdo commented on issue #3020: [STORM-3000] Add missing @Override annotations
srdo commented on issue #3020: [STORM-3000] Add missing @Override annotations URL: https://github.com/apache/storm/pull/3020#issuecomment-502378681 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
