[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

[Patrick Bennett (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567209#comment-15567209
 ] 

Patrick Bennett commented on THRIFT-3855:
-

Looks like this was fixed already in the latest code.  Even though it still 
shows 0.9.3 in changes and elsewhere, the latest revisions had Stop() added to 
TServerSocket.Interrupt() which fixes my problem as well.

> In the go simple server, if Stop() is called multiple times it hangs
> 
>
> Key: THRIFT-3855
> URL: https://issues.apache.org/jira/browse/THRIFT-3855
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Library
>Affects Versions: 0.9.3
>Reporter: James E. King, III
>Assignee: Paul Finkelshteyn
>Priority: Minor
> Fix For: 0.10.0
>
>
> From the submitter huaiwan:
> {quote}
> huaiyun commented 18 hours ago
> When Stop() is called twice or more, and no new connection accepted from 
> AcceptLoop(), the Stop() will be blocked because the quit channel is full.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: 0.10.0 release candidate

[BCG]

On 10/11/2016 11:13 AM, Jake Farrell wrote:

Hey Ben
THRIFT-2527 is in the 0.10.0 release candidate branch, 3rd commit in the
log from HEAD with commit hash 548403eeab40ca8c8217fce2dade26876b41b152

-Jake


My apologies, thanks Jake!

[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565717#comment-15565717
 ] 

ASF GitHub Bot commented on THRIFT-3546:


Github user jfarrell commented on the issue:

https://github.com/apache/thrift/pull/
  
at quick run through patch looks ok to me, @Jens-G @RandyAbernethy can 
either of you please review also


> NodeJS code should not be namespaced (and is currently not strict-mode 
> compliant)
> -
>
> Key: THRIFT-3546
> URL: https://issues.apache.org/jira/browse/THRIFT-3546
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Compiler
>Affects Versions: 0.9.3
>Reporter: Yunchi Luo
>
> Code generated for NodeJS, whether with a js namespace specified or not, 
> seems to fail strict mode. Specifically, it doesn't always generate "var" 
> when needed. This might not sound like a big issue but it's quite a pain to 
> deal with...
> It is standard nowadays to enable strict mode for Javascript code 
> (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode).
>  And babel, which is one of most popular ES6 => ES5 transpilers, while does 
> not force strict mode, does seem to break when you don't use "var".
> I think the best solution here is really to just stop using namespaces in 
> node code. Every type will be declared with "var", and if exported, also 
> assigned to "module.exports".
> I don't believe namespaces currently generated in the node code is directly 
> used anywhere or is even accessible outside the file?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift issue #1111: THRIFT-3546: Remove global namespace objects from nodejs...

[jfarrell]

Github user jfarrell commented on the issue:

https://github.com/apache/thrift/pull/
  
at quick run through patch looks ok to me, @Jens-G @RandyAbernethy can 
either of you please review also


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

[Patrick Bennett (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565712#comment-15565712
 ] 

Patrick Bennett commented on THRIFT-3855:
-

I just modified the generated .go code and got it working fine.  It's a very 
trivial patch (add that Close line).  I'm just surprised no one noticed this 
before?  No one tried to stop an idle server?

I was never able to get thrift building cleanly locally with the solutions or 
cmake generated files and vc14 (vs2015) so I can't test the changes locally for 
submitting a patch.  If I stay with thrift I may go back to it in earnest.  So 
far the performance is about 4-5x slower than grpc (although grpc seems 
completely broken for ruby/windows clients so thrift is only working solution 
for me at the moment).

> In the go simple server, if Stop() is called multiple times it hangs
> 
>
> Key: THRIFT-3855
> URL: https://issues.apache.org/jira/browse/THRIFT-3855
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Library
>Affects Versions: 0.9.3
>Reporter: James E. King, III
>Assignee: Paul Finkelshteyn
>Priority: Minor
> Fix For: 0.10.0
>
>
> From the submitter huaiwan:
> {quote}
> huaiyun commented 18 hours ago
> When Stop() is called twice or more, and no new connection accepted from 
> AcceptLoop(), the Stop() will be blocked because the quit channel is full.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: 0.10.0 release candidate

[Jake Farrell]

Hey Ben
THRIFT-2527 is in the 0.10.0 release candidate branch, 3rd commit in the
log from HEAD with commit hash 548403eeab40ca8c8217fce2dade26876b41b152

-Jake

On Tue, Oct 11, 2016 at 10:55 AM, BCG  wrote:

> On 10/11/2016 09:45 AM, BCG wrote:
>
>> On 10/11/2016 09:23 AM, Jake Farrell wrote:
>>
>>> Morning everyone
>>> I have a working 0.10.0 release candidate [1] which is now passing all
>>> tests [2]. All linked tickets in the 0.10.0 jira ticket [3] have been
>>> closed as well. Are there any final patches we want to see make it in, if
>>> not then I plan on branching, package and start the release candidate
>>> vote
>>> later this week
>>>
>>> -Jake
>>>
>>>
>>>
>>> Hi Jake
>>
>> I'd like to see THRIFT-3546 make it in, I have an open PR on github
>> (#) with tests passing.  This patch makes it possible to use
>> "browserified" node.js code even with "use strict" mode in the browser, and
>> also makes the generated code compatible with the "babel" compiler.
>> Additionally my patch resolves THRIFT-3735 if I am not mistaken.
>>
>> https://issues.apache.org/jira/browse/THRIFT-3546
>>
>> Thanks
>>
>> Ben
>>
>>
>> Also if possible I would like to request github PR #1112... this was
> already merged onto master a few days back.  I didn't notice initially that
> it wasn't on your release candidate branch.  These are small style changes
> to pass jshint, no changes to functionality.
>
> https://issues.apache.org/jira/browse/THRIFT-2527
>
> Thanks again
>
> Ben
>
>

Re: 0.10.0 release candidate

[BCG]

On 10/11/2016 09:45 AM, BCG wrote:

On 10/11/2016 09:23 AM, Jake Farrell wrote:

Morning everyone
I have a working 0.10.0 release candidate [1] which is now passing all
tests [2]. All linked tickets in the 0.10.0 jira ticket [3] have been
closed as well. Are there any final patches we want to see make it 
in, if
not then I plan on branching, package and start the release candidate 
vote

later this week

-Jake




Hi Jake

I'd like to see THRIFT-3546 make it in, I have an open PR on github 
(#) with tests passing.  This patch makes it possible to use 
"browserified" node.js code even with "use strict" mode in the 
browser, and also makes the generated code compatible with the "babel" 
compiler.  Additionally my patch resolves THRIFT-3735 if I am not 
mistaken.


https://issues.apache.org/jira/browse/THRIFT-3546

Thanks

Ben


Also if possible I would like to request github PR #1112... this was 
already merged onto master a few days back.  I didn't notice initially 
that it wasn't on your release candidate branch.  These are small style 
changes to pass jshint, no changes to functionality.


https://issues.apache.org/jira/browse/THRIFT-2527

Thanks again

Ben

Re: 0.10.0 release candidate

[BCG]

On 10/11/2016 09:23 AM, Jake Farrell wrote:

Morning everyone
I have a working 0.10.0 release candidate [1] which is now passing all
tests [2]. All linked tickets in the 0.10.0 jira ticket [3] have been
closed as well. Are there any final patches we want to see make it in, if
not then I plan on branching, package and start the release candidate vote
later this week

-Jake




Hi Jake

I'd like to see THRIFT-3546 make it in, I have an open PR on github 
(#) with tests passing.  This patch makes it possible to use 
"browserified" node.js code even with "use strict" mode in the browser, 
and also makes the generated code compatible with the "babel" compiler.  
Additionally my patch resolves THRIFT-3735 if I am not mistaken.


https://issues.apache.org/jira/browse/THRIFT-3546

Thanks

Ben

[jira] [Commented] (THRIFT-3775) 0.10.0 release candidate

[Jake Farrell (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565413#comment-15565413
 ] 

Jake Farrell commented on THRIFT-3775:
--

My latest pull request update [1] against trunk at d6bcb26 is now passing all 
tests[1]. final call for patches before I branch and start packaging this as 
0.10.0-rc1

[1]: https://github.com/apache/thrift/pull/1098 
[2]: https://travis-ci.org/apache/thrift/builds/166610540

> 0.10.0 release candidate
> 
>
> Key: THRIFT-3775
> URL: https://issues.apache.org/jira/browse/THRIFT-3775
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Reporter: Jake Farrell
>Assignee: Jake Farrell
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

0.10.0 release candidate

[Jake Farrell]

Morning everyone
I have a working 0.10.0 release candidate [1] which is now passing all
tests [2]. All linked tickets in the 0.10.0 jira ticket [3] have been
closed as well. Are there any final patches we want to see make it in, if
not then I plan on branching, package and start the release candidate vote
later this week

-Jake


[1]: https://github.com/apache/thrift/pull/1098
[2]: https://travis-ci.org/apache/thrift/builds/166610540
[3]: https://issues.apache.org/jira/browse/THRIFT-3775

[jira] [Assigned] (THRIFT-3835) Thrift generates javascript code for node js with error

[Benjamin Gould (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Gould reassigned THRIFT-3835:
--

Assignee: Benjamin Gould

> Thrift generates javascript code for node js with error
> ---
>
> Key: THRIFT-3835
> URL: https://issues.apache.org/jira/browse/THRIFT-3835
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Compiler
>Affects Versions: 0.9.3
>Reporter: Alexander Pertsovsky
>Assignee: Benjamin Gould
>
> Sample:
> ApplicationStateInfo = module.exports.ApplicationStateInfo = function(args) {
>   this.state = null;
>   this.substate = null;
>   if (args) {
> if (args.state !== undefined && args.state !== null) {
>   this.state = args.state;
> }
> if (args.substate !== undefined && args.substate !== null) {
>   this.substate = args.substate;
> }
>   }
>  module.exports.ApplicationStateInfo returns undefined => it cannot used with 
> e.g. babel in node js



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)

[Benjamin Gould (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565392#comment-15565392
 ] 

Benjamin Gould commented on THRIFT-3546:


Added to my PR to emit a "use strict" directive at the top of generated node.js 
files and confirmed that they work properly in Chrome and Firefox when run 
through browserify.

Additionally, I confirmed that the generated code can be used with babel.

> NodeJS code should not be namespaced (and is currently not strict-mode 
> compliant)
> -
>
> Key: THRIFT-3546
> URL: https://issues.apache.org/jira/browse/THRIFT-3546
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Compiler
>Affects Versions: 0.9.3
>Reporter: Yunchi Luo
>
> Code generated for NodeJS, whether with a js namespace specified or not, 
> seems to fail strict mode. Specifically, it doesn't always generate "var" 
> when needed. This might not sound like a big issue but it's quite a pain to 
> deal with...
> It is standard nowadays to enable strict mode for Javascript code 
> (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode).
>  And babel, which is one of most popular ES6 => ES5 transpilers, while does 
> not force strict mode, does seem to break when you don't use "var".
> I think the best solution here is really to just stop using namespaces in 
> node code. Every type will be declared with "var", and if exported, also 
> assigned to "module.exports".
> I don't believe namespaces currently generated in the node code is directly 
> used anywhere or is even accessible outside the file?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)