[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527241#comment-15527241 ] Jens Geyer commented on THRIFT-3507: As we are still below 1.0 we usually do not push commits to released branches. If someone needs them he/she is free to pick them from JIRA or Github. > THttpClient does not use proxy from http_proxy, https_proxy environment > variables > - > > Key: THRIFT-3507 > URL: https://issues.apache.org/jira/browse/THRIFT-3507 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.9.3 > Environment: Windows 7 + Cygwin x64 + Python 2.7.10 >Reporter: Fabricio Oliveira >Assignee: Martin Wilck >Priority: Critical > Fix For: 0.10.0 > > Attachments: > 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch, > THRIFT-3507-1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
AW: [jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables
No, as we are still below 1.0 we usually do not push commits to released branches. If someone needs them he/she is free to pick them from Jira. Sent from mobile device, please ignore spelling mistakes. Von: Martin Wilck (JIRA) Gesendet: 27.09.2016 08:43 An: dev@thrift.apache.org Betreff: [jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables [ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525258#comment-15525258 ] Martin Wilck commented on THRIFT-3507: -- Hello Jens, AFAICS you committed the changes only to the master branch. This issue (0.9.3) was made against 0.9.3. Are there any plans to add the proxy support to 0.9.3? Or will 3rd party projects need to update to 1.0.x to benefit from this feature? Martin > THttpClient does not use proxy from http_proxy, https_proxy environment > variables > - > > Key: THRIFT-3507 > URL: https://issues.apache.org/jira/browse/THRIFT-3507 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.9.3 > Environment: Windows 7 + Cygwin x64 + Python 2.7.10 >Reporter: Fabricio Oliveira >Assignee: Martin Wilck >Priority: Critical > Fix For: 0.10.0 > > Attachments: > 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch, > THRIFT-3507-1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525258#comment-15525258 ] Martin Wilck commented on THRIFT-3507: -- Hello Jens, AFAICS you committed the changes only to the master branch. This issue (0.9.3) was made against 0.9.3. Are there any plans to add the proxy support to 0.9.3? Or will 3rd party projects need to update to 1.0.x to benefit from this feature? Martin > THttpClient does not use proxy from http_proxy, https_proxy environment > variables > - > > Key: THRIFT-3507 > URL: https://issues.apache.org/jira/browse/THRIFT-3507 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.9.3 > Environment: Windows 7 + Cygwin x64 + Python 2.7.10 >Reporter: Fabricio Oliveira >Assignee: Martin Wilck >Priority: Critical > Fix For: 0.10.0 > > Attachments: > 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch, > THRIFT-3507-1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522369#comment-15522369 ] Martin Wilck commented on THRIFT-3507: -- 1. 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch 2. 0002-Python-THttpClient-Support-proxy-authorization.patch I just re-checked the procedure in the above file. The patches apply on current master branch. $ git clone https://github.com/apache/thrift.git $ git branch proxy origin/master $ git checkout proxy $ curl https://issues.apache.org/jira/secure/attachment/12801233/0001-python-THttpClient-Add-support-for-system-proxy-sett.patch | git am $ curl https://issues.apache.org/jira/secure/attachment/12801234/0002-Python-THttpClient-Support-proxy-authorization.patch | git am $ git status On branch proxy1 Your branch is ahead of 'origin/master' by 2 commits. $ git log --oneline origin/master.. d2bfd42 Python/THttpClient: Support proxy authorization 7ff06a1 python/THttpClient: Add support for system proxy settings > THttpClient does not use proxy from http_proxy, https_proxy environment > variables > - > > Key: THRIFT-3507 > URL: https://issues.apache.org/jira/browse/THRIFT-3507 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.9.3 > Environment: Windows 7 + Cygwin x64 + Python 2.7.10 >Reporter: Fabricio Oliveira >Priority: Critical > Attachments: > 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch, > THRIFT-3507-1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521775#comment-15521775 ] Aki Sukegawa commented on THRIFT-3507: -- Reading http_proxy without reading no_proxy would result in another surprises and inconveniences, although better in that it can be worked around in users' code. The real problem is that users have no way to use proxies in the current Thrift API. As these environment variables are only conventions, start reading them now may not be a best solution. > THttpClient does not use proxy from http_proxy, https_proxy environment > variables > - > > Key: THRIFT-3507 > URL: https://issues.apache.org/jira/browse/THRIFT-3507 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.9.3 > Environment: Windows 7 + Cygwin x64 + Python 2.7.10 >Reporter: Fabricio Oliveira >Priority: Critical > Attachments: > 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch, > THRIFT-3507-1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521391#comment-15521391 ] Jens Geyer commented on THRIFT-3507: Let's just assume, I want to apply the patches that are intended for the master branch, a.k.a developer trunk. Which files do I pick, and in what order? > THttpClient does not use proxy from http_proxy, https_proxy environment > variables > - > > Key: THRIFT-3507 > URL: https://issues.apache.org/jira/browse/THRIFT-3507 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.9.3 > Environment: Windows 7 + Cygwin x64 + Python 2.7.10 >Reporter: Fabricio Oliveira >Priority: Critical > Attachments: > 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch, > THRIFT-3507-1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517514#comment-15517514 ] Martin Wilck commented on THRIFT-3507: -- THRIFT-3507-1.patch was Fabricio. Mine is a modification of it, not meant to be applied on top. The two different tickets were meant for 0.9.3 and 1.0.0, respectively. Note that in 3798, I added the proxy-auth patch on top which I don't have here. IIRC it should apply for the 0.9.3 branch, too. Other than that, it has been a while. I know the patches applied when I tried them in April. Here is my patch recipe that used work cleanly: https://github.com/mwilck/geeknote/blob/master/proxy_support.md > THttpClient does not use proxy from http_proxy, https_proxy environment > variables > - > > Key: THRIFT-3507 > URL: https://issues.apache.org/jira/browse/THRIFT-3507 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.9.3 > Environment: Windows 7 + Cygwin x64 + Python 2.7.10 >Reporter: Fabricio Oliveira >Priority: Critical > Attachments: > 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch, > THRIFT-3507-1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables
[
https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517445#comment-15517445
]
Jens Geyer commented on THRIFT-3507:
Something is conflicting here. There are two patches named
{{0001-python-THttpClient-Add-support-for-system-proxy-sett.patch}} with
different contents changing the same source location. The result is as one
would expect:
{code}
$ git pull
Already up-to-date.
$ git apply ../py/THRIFT-3507-1.patch
error: patch failed: lib/py/src/transport/THttpClient.py:29
error: lib/py/src/transport/THttpClient.py: patch does not apply
$ git apply
../py/0001-python-THttpClient-Add-support-for-system-proxy-sett.patch
$ git apply
../py/0001-python-THttpClient-Add-support-for-system-proxy-sett-2.patch
error: patch failed: lib/py/src/transport/THttpClient.py:63
error: lib/py/src/transport/THttpClient.py: patch does not apply
$ git apply ../py/0002-Python-THttpClient-Support-proxy-authorization.patch
error: patch failed: lib/py/src/transport/THttpClient.py:93
error: lib/py/src/transport/THttpClient.py: patch does not apply
{code}
1 out of 4 Patches applied successfully, 3 failed. What do I do now? Or is that
the intended result?
Please advise.
> THttpClient does not use proxy from http_proxy, https_proxy environment
> variables
> -
>
> Key: THRIFT-3507
> URL: https://issues.apache.org/jira/browse/THRIFT-3507
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.9.3
> Environment: Windows 7 + Cygwin x64 + Python 2.7.10
>Reporter: Fabricio Oliveira
>Priority: Critical
> Attachments:
> 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch,
> THRIFT-3507-1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517380#comment-15517380 ] Jens Geyer commented on THRIFT-3507: Why do we have to tickets that seem to deal with the same issue to begin with? > THttpClient does not use proxy from http_proxy, https_proxy environment > variables > - > > Key: THRIFT-3507 > URL: https://issues.apache.org/jira/browse/THRIFT-3507 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.9.3 > Environment: Windows 7 + Cygwin x64 + Python 2.7.10 >Reporter: Fabricio Oliveira >Priority: Critical > Attachments: > 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch, > THRIFT-3507-1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515718#comment-15515718 ] Martin Wilck commented on THRIFT-3507: -- What's going on in this project? Why does it take so long to review these simple patches? > THttpClient does not use proxy from http_proxy, https_proxy environment > variables > - > > Key: THRIFT-3507 > URL: https://issues.apache.org/jira/browse/THRIFT-3507 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.9.3 > Environment: Windows 7 + Cygwin x64 + Python 2.7.10 >Reporter: Fabricio Oliveira >Priority: Critical > Attachments: > 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch, > THRIFT-3507-1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3507) THttpClient does not use proxy from http_proxy, https_proxy environment variables
[ https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259830#comment-15259830 ] Martin Wilck commented on THRIFT-3507: -- I meant to say "slightly modfified forward port" in the previous comment, sorry. > THttpClient does not use proxy from http_proxy, https_proxy environment > variables > - > > Key: THRIFT-3507 > URL: https://issues.apache.org/jira/browse/THRIFT-3507 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.9.3 > Environment: Windows 7 + Cygwin x64 + Python 2.7.10 >Reporter: Fabricio Oliveira >Priority: Critical > Attachments: > 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch, > THRIFT-3507-1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
