[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239908#comment-16239908
 ] 

ASF GitHub Bot commented on THRIFT-4350:


Github user danielcrenna commented on the issue:

https://github.com/apache/thrift/pull/1379
  
This was just an issue where I was obviously not calling `netcore` as the 
generator, where `thrift.0.10.0.exe` doesn't have that generator installed. 
When I built it myself on `master` branch it all is well. Building was a bit of 
a riddle, had to rename `version.h.in` to `version.h` and rename the `flex` and 
`bison` to `win_flex` and `win_bison` because of how aliases work in `choco`, 
but things appear to work now. Thanks for responding :)


> Update netcore build for dotnet 2.0 sdk and make cross validation
> -
>
> Key: THRIFT-4350
> URL: https://issues.apache.org/jira/browse/THRIFT-4350
> Project: Thrift
>  Issue Type: Improvement
>  Components: .NETCore - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project 
> that is checked in
> # Ensure one can build on Linux using the project that is checked in and use 
> make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239783#comment-16239783
 ] 

ASF GitHub Bot commented on THRIFT-4350:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1379
  
HI Daniel, great question - I don't have a good answer for you.  I focused 
my work on making the dotnet 2.0 conversion on the library.  Given all of the 
tests pass it would appear that the output from the compiler is compatible, at 
least, if not optimized for netcore 2.  Thoughts?


> Update netcore build for dotnet 2.0 sdk and make cross validation
> -
>
> Key: THRIFT-4350
> URL: https://issues.apache.org/jira/browse/THRIFT-4350
> Project: Thrift
>  Issue Type: Improvement
>  Components: .NETCore - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project 
> that is checked in
> # Ensure one can build on Linux using the project that is checked in and use 
> make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239756#comment-16239756
 ] 

ASF GitHub Bot commented on THRIFT-4350:


Github user danielcrenna commented on the issue:

https://github.com/apache/thrift/pull/1379
  
@jeking3 What csharp gen options are passed to produce source compatible 
with this netcore lib? Any .thrift file I pass through `csharp:async` for 
example uses old style begin/end but this netcore lib uses async/await 
patterns, but I can't find any published reference for C# option to generate 
corresponding output. Also the namespaces appear to differ. My reference point 
is thrift-0.10.0.


> Update netcore build for dotnet 2.0 sdk and make cross validation
> -
>
> Key: THRIFT-4350
> URL: https://issues.apache.org/jira/browse/THRIFT-4350
> Project: Thrift
>  Issue Type: Improvement
>  Components: .NETCore - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project 
> that is checked in
> # Ensure one can build on Linux using the project that is checked in and use 
> make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198843#comment-16198843
 ] 

ASF GitHub Bot commented on THRIFT-4350:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1379


> Update netcore build for dotnet 2.0 sdk and make cross validation
> -
>
> Key: THRIFT-4350
> URL: https://issues.apache.org/jira/browse/THRIFT-4350
> Project: Thrift
>  Issue Type: Improvement
>  Components: .NETCore - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project 
> that is checked in
> # Ensure one can build on Linux using the project that is checked in and use 
> make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

[Gideon Korir (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194764#comment-16194764
 ] 

Gideon Korir commented on THRIFT-4350:
--

[~jking] Can I help with anything related to the dotnetcore migration? I cloned 
your branch, ran the test + cross tests and they passed successfully. I'm in 
favor of not rolling back - even visual studio doesn't allow me to open the 
project without opening. 

> Update netcore build for dotnet 2.0 sdk and make cross validation
> -
>
> Key: THRIFT-4350
> URL: https://issues.apache.org/jira/browse/THRIFT-4350
> Project: Thrift
>  Issue Type: Improvement
>  Components: .NETCore - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project 
> that is checked in
> # Ensure one can build on Linux using the project that is checked in and use 
> make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192515#comment-16192515
 ] 

ASF GitHub Bot commented on THRIFT-4350:


Github user gideonkorir commented on the issue:

https://github.com/apache/thrift/pull/1386
  
Closing this in favor of [jeking3 
pr](https://github.com/apache/thrift/pull/1379/commits/23bbb439a11e90fe4ac9c6fa9037520cc45b0fe2)


> Update netcore build for dotnet 2.0 sdk and make cross validation
> -
>
> Key: THRIFT-4350
> URL: https://issues.apache.org/jira/browse/THRIFT-4350
> Project: Thrift
>  Issue Type: Improvement
>  Components: .NETCore - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project 
> that is checked in
> # Ensure one can build on Linux using the project that is checked in and use 
> make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192516#comment-16192516
 ] 

ASF GitHub Bot commented on THRIFT-4350:


Github user gideonkorir closed the pull request at:

https://github.com/apache/thrift/pull/1386


> Update netcore build for dotnet 2.0 sdk and make cross validation
> -
>
> Key: THRIFT-4350
> URL: https://issues.apache.org/jira/browse/THRIFT-4350
> Project: Thrift
>  Issue Type: Improvement
>  Components: .NETCore - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project 
> that is checked in
> # Ensure one can build on Linux using the project that is checked in and use 
> make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

[Gideon Korir (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192513#comment-16192513
 ] 

Gideon Korir commented on THRIFT-4350:
--

I've sent in a PR that upgrades the project SDK to dotnet core 2.0. The project 
now targets netstandard 1.6 & 2.0. Build + tests were successful (although ruby 
autotools.sh is broken in Travis) and I created a sample at [thrift aspnet core 
sample|https://github.com/gideonkorir/thriftnetcoresample]. I didn't change the 
code for now but upgrading the SDK allows for further improvements e.g. merging 
it with the CSharp code base

> Update netcore build for dotnet 2.0 sdk and make cross validation
> -
>
> Key: THRIFT-4350
> URL: https://issues.apache.org/jira/browse/THRIFT-4350
> Project: Thrift
>  Issue Type: Improvement
>  Components: .NETCore - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project 
> that is checked in
> # Ensure one can build on Linux using the project that is checked in and use 
> make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

[James E. King, III (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189786#comment-16189786
 ] 

James E. King, III commented on THRIFT-4350:


I'd appreciate some feedback on this pull request.  It sets the bar rather 
high, and the server based cross tests are not working, but it brings client 
tests into make cross and brings the project up to supporting the official 
dotnet 2.0 release.  I think it's a step forward overall, but I need to know if 
the step is too far forward.  I tried backing off to .NET core 1.1 but it 
wasn't trivial so that's why I left everything at the 2.0 language level in 
this PR.

> Update netcore build for dotnet 2.0 sdk and make cross validation
> -
>
> Key: THRIFT-4350
> URL: https://issues.apache.org/jira/browse/THRIFT-4350
> Project: Thrift
>  Issue Type: Improvement
>  Components: .NETCore - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project 
> that is checked in
> # Ensure one can build on Linux using the project that is checked in and use 
> make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185265#comment-16185265
 ] 

ASF GitHub Bot commented on THRIFT-4350:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1379
  
Looks like we need "publish" support or something for that last build job.


> Update netcore build for dotnet 2.0 sdk and make cross validation
> -
>
> Key: THRIFT-4350
> URL: https://issues.apache.org/jira/browse/THRIFT-4350
> Project: Thrift
>  Issue Type: Improvement
>  Components: .NETCore - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project 
> that is checked in
> # Ensure one can build on Linux using the project that is checked in and use 
> make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185053#comment-16185053
 ] 

ASF GitHub Bot commented on THRIFT-4350:


GitHub user jeking3 opened a pull request:

https://github.com/apache/thrift/pull/1379

THRIFT-4350: enable dotnet-2.0.0-sdk in ubuntu xenial

update netcore projects, get them running with make cross
Client: netcore

This is purely experimental.  I wanted to know what was involved.  I moved 
everything to the latest version which may not be useful.  I got netcore with 
dotnet-2.0.0-sdk and netcoreapp2.0 targeted applications runnign in make cross 
(as client only).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeking3/thrift THRIFT-4350-dotnetcore-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1379.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1379


commit 592d4c73107ef06355cee438fb3e326dbb43ba0f
Author: James E. King, III 
Date:   2017-09-28T11:57:42Z

THRIFT-4350: enable dotnet-2.0.0-sdk in ubuntu xenial, update netcore
projects, get them running with make cross
Client: netcore




> Update netcore build for dotnet 2.0 sdk and make cross validation
> -
>
> Key: THRIFT-4350
> URL: https://issues.apache.org/jira/browse/THRIFT-4350
> Project: Thrift
>  Issue Type: Improvement
>  Components: .NETCore - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project 
> that is checked in
> # Ensure one can build on Linux using the project that is checked in and use 
> make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)