[jira] [Closed] (TINKERPOP-1601) LazyBarrierStrategy should not check is.testing

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-1601.
---
Resolution: Won't Do

we're kinda set with {{is.testing}} now.

> LazyBarrierStrategy should not check is.testing
> ---
>
> Key: TINKERPOP-1601
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1601
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.3
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
>
> {{LazyBarrierStrategy}} should not check the value if the system variable 
> {{is.testing}} and then behave differently depending on its value. The 
> cleaner way is to just exclude {{LBS}} in {{ProfileTest}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1601) LazyBarrierStrategy should not check is.testing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681751#comment-16681751
 ] 

ASF GitHub Bot commented on TINKERPOP-1601:
---

spmallette closed pull request #535: TINKERPOP-1601 LazyBarrierStrategy should 
not check is.testing
URL: https://github.com/apache/tinkerpop/pull/535
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LazyBarrierStrategy should not check is.testing
> ---
>
> Key: TINKERPOP-1601
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1601
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.3
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
>
> {{LazyBarrierStrategy}} should not check the value if the system variable 
> {{is.testing}} and then behave differently depending on its value. The 
> cleaner way is to just exclude {{LBS}} in {{ProfileTest}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [tinkerpop] spmallette commented on issue #535: TINKERPOP-1601 LazyBarrierStrategy should not check is.testing

[GitHub]

closing - stale

[ Full content available at: https://github.com/apache/tinkerpop/pull/535 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette closed pull request #535: TINKERPOP-1601 LazyBarrierStrategy should not check is.testing

[GitHub]

[ pull request closed by spmallette ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/535 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2079) Move RemoteGraph to test package

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681725#comment-16681725
 ] 

ASF GitHub Bot commented on TINKERPOP-2079:
---

spmallette opened a new pull request #992: TINKERPOP-2079 Moved RemoteGraph to 
gremlin-test
URL: https://github.com/apache/tinkerpop/pull/992
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2079
   
   This is a breaking change as it removes the long deprecated `RemoteGraph` 
from gremlin-core. Users should not have been using this at this point, so the 
impact should be fairly limited. `RemoteGraph` is still needed as a test 
component because we need a Graph instance for the JVM test suite to run 
properly. This change required some refactoring as well in the 
`RemoteGraphProvider` so that configurations were being passed around properly 
to allow for the test suite to re-attach elements. That's yet another problem 
with the JVM test suite - it unfortunately assumes embedded Graph assertions.
   
   All tests pass with `docker/build.sh -t -i`
   
   VOTE +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move RemoteGraph to test package
> 
>
> Key: TINKERPOP-2079
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2079
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure, test-suite
>Affects Versions: 3.4.0
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
>  Labels: breaking
>
> With TINKERPOP-2078 {{RemoteGraph}} can become a test-only class. It can't be 
> removed completely because of what the test infrastructure requires to run 
> the suite, but it no longer needs to be publicly available. It's been 
> deprecated a long time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [tinkerpop] spmallette opened pull request #992: TINKERPOP-2079 Moved RemoteGraph to gremlin-test

[GitHub]

https://issues.apache.org/jira/browse/TINKERPOP-2079

This is a breaking change as it removes the long deprecated `RemoteGraph` from 
gremlin-core. Users should not have been using this at this point, so the 
impact should be fairly limited. `RemoteGraph` is still needed as a test 
component because we need a Graph instance for the JVM test suite to run 
properly. This change required some refactoring as well in the 
`RemoteGraphProvider` so that configurations were being passed around properly 
to allow for the test suite to re-attach elements. That's yet another problem 
with the JVM test suite - it unfortunately assumes embedded Graph assertions.

All tests pass with `docker/build.sh -t -i`

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/992 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2059) Modulation of valueMap()

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681699#comment-16681699
 ] 

ASF GitHub Bot commented on TINKERPOP-2059:
---

dkuppitz closed pull request #986: TINKERPOP-2059 Modulation of valueMap()
URL: https://github.com/apache/tinkerpop/pull/986
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Modulation of valueMap()
> 
>
> Key: TINKERPOP-2059
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2059
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.3.3
>Reporter: stephen mallette
>Assignee: Daniel Kuppitz
>Priority: Major
>  Labels: breaking
> Fix For: 3.4.0
>
>
> Allow for modulation of the {{valueMap()}} step with {{by()}} and possibly 
> {{with()}} to make it's usage more flexible and consistent. The problem 
> presented in relation to this change is how to easily unwrap the general 
> multi-property structure of {{valueMap()}}
> {code}
> g.V().has('person','name','marko').
>   valueMap('name','age').
> by(unfold())
> {code}
> which would yield: {{[name:marko,age:29]}} rather than: 
> {{[name:[marko],age:[29]]}}. Obviously the {{by()}} is just a map over the 
> values in the list of values returned from properties. 
> Please see the 
> [DISCUSS|https://lists.apache.org/thread.html/91a3c980b5968c78638383dfa11f44ee14fc114ddc3d29e762e56f1f@%3Cdev.tinkerpop.apache.org%3E]
>  thread for additional thoughts on the matter to consider.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (TINKERPOP-2059) Modulation of valueMap()

[Daniel Kuppitz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Kuppitz closed TINKERPOP-2059.
-
   Resolution: Fixed
Fix Version/s: 3.4.0

> Modulation of valueMap()
> 
>
> Key: TINKERPOP-2059
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2059
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.3.3
>Reporter: stephen mallette
>Assignee: Daniel Kuppitz
>Priority: Major
>  Labels: breaking
> Fix For: 3.4.0
>
>
> Allow for modulation of the {{valueMap()}} step with {{by()}} and possibly 
> {{with()}} to make it's usage more flexible and consistent. The problem 
> presented in relation to this change is how to easily unwrap the general 
> multi-property structure of {{valueMap()}}
> {code}
> g.V().has('person','name','marko').
>   valueMap('name','age').
> by(unfold())
> {code}
> which would yield: {{[name:marko,age:29]}} rather than: 
> {{[name:[marko],age:[29]]}}. Obviously the {{by()}} is just a map over the 
> values in the list of values returned from properties. 
> Please see the 
> [DISCUSS|https://lists.apache.org/thread.html/91a3c980b5968c78638383dfa11f44ee14fc114ddc3d29e762e56f1f@%3Cdev.tinkerpop.apache.org%3E]
>  thread for additional thoughts on the matter to consider.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [tinkerpop] dkuppitz closed pull request #986: TINKERPOP-2059 Modulation of valueMap()

[GitHub]

[ pull request closed by dkuppitz ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/986 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2090) After running backend for a day or so System.IO.IOException keep throwing

[Greg Pepin (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681621#comment-16681621
 ] 

Greg Pepin commented on TINKERPOP-2090:
---

[~Florian Hockmann] Is there anything on the driver side that would take 10 
minutes to respond with an error to a single request?  I don't see how that 
could be possible.  I plan on talking to Microsoft today in an attempt to get 
some better explanations and I'll post back as I learn things.

> After running backend for a day or so System.IO.IOException keep throwing
> -
>
> Key: TINKERPOP-2090
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2090
> Project: TinkerPop
>  Issue Type: Bug
>  Components: dotnet
>Affects Versions: 3.4.0
> Environment: .NET Core 2.1.5
> Microsoft Azure
>Reporter: Saber Karmous
>Priority: Critical
>
> .NET Core 2.1.5
> Gremlin.NET 3.4.0-rc2 
> We're using the latest RC of the Gremlin client. And we have a gremlin client 
> that's being injected as a singleton through out IoC container. After running 
> the backend for a day or two it keeps throwing System.IO.IOExceptions. If we 
> restart the application it works again.
> We use Polly for out retry strategy, and retrying for 9 times. But it keeps 
> failing.
> I added the stack trace below. Reproducing is a bit of a pain in the behind, 
> you have to wait for a day or two for the exception to occur.
> {noformat}
> *no* System.IO.IOException:
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable+ConfiguredValueTaskAwaiter.GetResult
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Net.Security.SslStreamInternal+d`1.MoveNext
>  (System.Net.Security, Version=4.1.1.0, Culture=neutral, 
> PublicKeyToken=b03f5f7f11d50a3a)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable+ConfiguredValueTaskAwaiter.GetResult
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Net.Security.SslStreamInternal+d`1.MoveNext
>  (System.Net.Security, Version=4.1.1.0, Culture=neutral, 
> PublicKeyToken=b03f5f7f11d50a3a)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at Gremlin.Net.Driver.WebSocketConnection+d__7.MoveNext 
> (Gremlin.Net, Version=3.4.0.0, Culture=neutral, 
> PublicKeyToken=d2035e9aa387a711)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at Gremlin.Net.Driver.Connection+d__13.MoveNext (Gremlin.Net, 
> Version=3.4.0.0, Culture=neutral, PublicKeyToken=d2035e9aa387a711)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runt

[jira] [Commented] (TINKERPOP-2090) After running backend for a day or so System.IO.IOException keep throwing

[Zaoshi (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681624#comment-16681624
 ] 

Zaoshi commented on TINKERPOP-2090:
---

{quote}Gremlin.Net already does this. After using a connection, it only returns 
it into the pool if it's still open. It also only returns a connection to be 
used for a request if the connection wasn't closed while sitting idle in the 
pool.{quote}
I am afraid this is not the case. Connection state remains Open and Gremlin.Net 
always returns broken connection into the pool. I think it will work properly 
only when connection is closed gracefully, but Cosmos DB does not do that. You 
can simulate similar behaviour by going to your network adapter settings, 
disabling it, then enabling it, and then try to do query - you will get same 
exception as reported and connection always goes back into the pool.

> After running backend for a day or so System.IO.IOException keep throwing
> -
>
> Key: TINKERPOP-2090
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2090
> Project: TinkerPop
>  Issue Type: Bug
>  Components: dotnet
>Affects Versions: 3.4.0
> Environment: .NET Core 2.1.5
> Microsoft Azure
>Reporter: Saber Karmous
>Priority: Critical
>
> .NET Core 2.1.5
> Gremlin.NET 3.4.0-rc2 
> We're using the latest RC of the Gremlin client. And we have a gremlin client 
> that's being injected as a singleton through out IoC container. After running 
> the backend for a day or two it keeps throwing System.IO.IOExceptions. If we 
> restart the application it works again.
> We use Polly for out retry strategy, and retrying for 9 times. But it keeps 
> failing.
> I added the stack trace below. Reproducing is a bit of a pain in the behind, 
> you have to wait for a day or two for the exception to occur.
> {noformat}
> *no* System.IO.IOException:
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable+ConfiguredValueTaskAwaiter.GetResult
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Net.Security.SslStreamInternal+d`1.MoveNext
>  (System.Net.Security, Version=4.1.1.0, Culture=neutral, 
> PublicKeyToken=b03f5f7f11d50a3a)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable+ConfiguredValueTaskAwaiter.GetResult
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Net.Security.SslStreamInternal+d`1.MoveNext
>  (System.Net.Security, Version=4.1.1.0, Culture=neutral, 
> PublicKeyToken=b03f5f7f11d50a3a)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at Gremlin.Net.Driver.WebSocketConnection+d__7.MoveNext 
> (Gremlin.Net, Version=3.4.0.0, Culture=neutral, 
> PublicKeyToken=d2035e9aa387a711)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (Sys

[jira] [Commented] (TINKERPOP-2090) After running backend for a day or so System.IO.IOException keep throwing

[Florian Hockmann (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681613#comment-16681613
 ] 

Florian Hockmann commented on TINKERPOP-2090:
-

[~Papapep], thanks for reaching out to Microsoft to get some input from their 
side on this.
{quote}What is generally happening is that a request is made to cosmosDb and 
1-10 minutes later this error is returned
{quote}
If you're getting this error in less than 10 minutes, then how could it be 
explained by the possibilities Microsoft mentioned? I guess they don't perform 
updates that often that require restarts of nodes or introduce new firewall 
rules which you violate.
{quote}Can the client be enhanced to check if a connection is active prior to 
using it?  Or maybe close connections on websocket errors?
{quote}
Gremlin.Net already does this. After using a connection, it only returns it 
into the pool [if it's still 
open|https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs#L79].
 It also only returns a connection to be used for a request [if the connection 
wasn't 
closed|https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs#L64]
 while sitting idle in the pool.

To me it sounds more like we need to get to the reason why the connections are 
closed by Cosmos DB before we can think about how to handle the situation in 
Gremlin.Net.

Can someone who uses Cosmos DB try out whether the same problem also occurs 
with other GLVs? (Ideally with Gremlin-Java as that's probably still the most 
advanced driver.)

> After running backend for a day or so System.IO.IOException keep throwing
> -
>
> Key: TINKERPOP-2090
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2090
> Project: TinkerPop
>  Issue Type: Bug
>  Components: dotnet
>Affects Versions: 3.4.0
> Environment: .NET Core 2.1.5
> Microsoft Azure
>Reporter: Saber Karmous
>Priority: Critical
>
> .NET Core 2.1.5
> Gremlin.NET 3.4.0-rc2 
> We're using the latest RC of the Gremlin client. And we have a gremlin client 
> that's being injected as a singleton through out IoC container. After running 
> the backend for a day or two it keeps throwing System.IO.IOExceptions. If we 
> restart the application it works again.
> We use Polly for out retry strategy, and retrying for 9 times. But it keeps 
> failing.
> I added the stack trace below. Reproducing is a bit of a pain in the behind, 
> you have to wait for a day or two for the exception to occur.
> {noformat}
> *no* System.IO.IOException:
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable+ConfiguredValueTaskAwaiter.GetResult
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Net.Security.SslStreamInternal+d`1.MoveNext
>  (System.Net.Security, Version=4.1.1.0, Culture=neutral, 
> PublicKeyToken=b03f5f7f11d50a3a)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable+ConfiguredValueTaskAwaiter.GetResult
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Net.Security.SslStreamInternal+d`1.MoveNext
>  (System.Net.Security, Version=4.1.1.0, Culture=neutral, 
> PublicKeyToken=b03f5f7f11d50a3a)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.Compil

[jira] [Commented] (TINKERPOP-2090) After running backend for a day or so System.IO.IOException keep throwing

[Greg Pepin (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681521#comment-16681521
 ] 

Greg Pepin commented on TINKERPOP-2090:
---

Here is a response I received from Microsoft regarding aborted/closed 
connections on CosmosDb:

"Please find below few scenarios when it is expected for connections to be 
aborted/closed by the Cosmos DB Gremlin server?

If connections are being established, but then being closed, then the other 
possibilities are:
 # Cosmos DB Region is being upgraded:

 * This would see connections being forcibly closed as nodes are taken down.
 * Retrying requests/connections should be successful.
 * Typically the upgrade takes 2-3hrs.

 # Idle connections disconnected:

 * This should only occur after 10hrs.
 * There is a known issue where active connections will also get terminated 
after 10 hrs.

 # Firewall/Authentication failures:

 * If a firewall rule is changed, and an existing connection violates the new 
rule, then connection will be closed.
 * If a connection was established with authentication keys which are 
invalidated by a key rotation.

 # Protocol errors:

 * If a message received is malformed or does not adhere to the expected 
Gremlin handshake protocol, then the connection may be closed."

 

It sounds like the keep-alive functionality isn't enough to handle these 
scenarios.   Can the client be enhanced to check if a connection is active 
prior to using it?  Or maybe close connections on websocket errors?

In the short term we can dispose of the client and spin up a new on when a 
websocket error is detected.  However by biggest concern is that it can take 
over 10 minutes in some scenarios for that exception to be thrown.  How can we 
make the problematic connections fail fast?

> After running backend for a day or so System.IO.IOException keep throwing
> -
>
> Key: TINKERPOP-2090
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2090
> Project: TinkerPop
>  Issue Type: Bug
>  Components: dotnet
>Affects Versions: 3.4.0
> Environment: .NET Core 2.1.5
> Microsoft Azure
>Reporter: Saber Karmous
>Priority: Critical
>
> .NET Core 2.1.5
> Gremlin.NET 3.4.0-rc2 
> We're using the latest RC of the Gremlin client. And we have a gremlin client 
> that's being injected as a singleton through out IoC container. After running 
> the backend for a day or two it keeps throwing System.IO.IOExceptions. If we 
> restart the application it works again.
> We use Polly for out retry strategy, and retrying for 9 times. But it keeps 
> failing.
> I added the stack trace below. Reproducing is a bit of a pain in the behind, 
> you have to wait for a day or two for the exception to occur.
> {noformat}
> *no* System.IO.IOException:
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable+ConfiguredValueTaskAwaiter.GetResult
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Net.Security.SslStreamInternal+d`1.MoveNext
>  (System.Net.Security, Version=4.1.1.0, Culture=neutral, 
> PublicKeyToken=b03f5f7f11d50a3a)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable+ConfiguredValueTaskAwaiter.GetResult
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Net.Security.SslStreamInternal+d`1.MoveNext
>  (System.Net.Security, Version=4.1.1.0, Culture=neutral, 
> PublicKeyToken=b03f5f7f11d50a3a)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.Compi

[GitHub] [tinkerpop] dkuppitz commented on issue #991: TINKERPOP-2010 Generate JSDoc for gremlin-javascript

[GitHub]

Looks good to me.

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/991 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2078) Hide use of EmptyGraph or RemoteGraph behind a more unified method for TraversalSource construction

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681495#comment-16681495
 ] 

ASF GitHub Bot commented on TINKERPOP-2078:
---

spmallette closed pull request #968: TINKERPOP-2078 Added 
AnonymousTraversalSource
URL: https://github.com/apache/tinkerpop/pull/968
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hide use of EmptyGraph or RemoteGraph behind a more unified method for 
> TraversalSource construction
> ---
>
> Key: TINKERPOP-2078
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2078
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.3.4
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
>  Labels: deprecation
> Fix For: 3.4.0, 3.3.5
>
>
> {{RemoteGraph}} was long ago deprecated for {{withRemote()}} typically 
> spawned from {{EmptyGraph}} which is weird. For GLVs, make sure 
> {{EmptyGraph}} didn't leak into them and deal with those issues as needed. 
> Update all docs to stop using {{EmptyGraph}}. Provide a way to unify 
> {{TraversalSource}} construction for both local and remote connected graphs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (TINKERPOP-2078) Hide use of EmptyGraph or RemoteGraph behind a more unified method for TraversalSource construction

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-2078.
---
   Resolution: Done
Fix Version/s: 3.3.5
   3.4.0

> Hide use of EmptyGraph or RemoteGraph behind a more unified method for 
> TraversalSource construction
> ---
>
> Key: TINKERPOP-2078
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2078
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.3.4
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
>  Labels: deprecation
> Fix For: 3.4.0, 3.3.5
>
>
> {{RemoteGraph}} was long ago deprecated for {{withRemote()}} typically 
> spawned from {{EmptyGraph}} which is weird. For GLVs, make sure 
> {{EmptyGraph}} didn't leak into them and deal with those issues as needed. 
> Update all docs to stop using {{EmptyGraph}}. Provide a way to unify 
> {{TraversalSource}} construction for both local and remote connected graphs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [tinkerpop] spmallette closed pull request #968: TINKERPOP-2078 Added AnonymousTraversalSource

[GitHub]

[ pull request closed by spmallette ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/968 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

Re: Uniqueness of property ids

[Stephen Mallette]

If we can, I think that we should just keep derser semantics as they are.
We've gone this long with them having null parent element ids and there
haven't been any raised complains that I'm aware of.

> I thought about skipping the parent id comparison in case one of the
elements parents is *null*

I suppose the question we need to answer stated directly is: What do we
want equals() to mean for "detached" properties? Maybe it's not wrong to
consider "detached" properties without a parent to have a form of wildcard
status. If you were to "attach" such a property then its id space would be
restricted to the element you're adding it to, so it seems safe in that
respect. In the "tree test" that's failing that you referenced, the
deserialized tree is a wildcard match for the original tree...the idea
sorta works in that capacity, but perhaps there are other scenarios where
that's a really bad thing?

Does a "null" parent element mean "detached"? I guess the answer is
"sometimes" because in some cases "detached" keeps the parent element. Are
there other scenarios though where the parent element can be null? I can't
really think of any right now.

On Thu, Nov 8, 2018 at 12:48 PM Daniel Kuppitz  wrote:

> Working on TINKERPOP-2051
> , I thought I found
> a
> pretty easy solution: In order to allow locally unique property ids, we
> only need to compare the ids of two properties as well as the ids of their
> parent elements. That was basically a one-line change and had the expected
> effect:
>
>
> gremlin> g = TinkerGraph.open().traversal()
> ==>graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
> gremlin> g.addV("person").property("name", "alice", id, "name").as("a").
> ..1>   addV("person").property("name", "bob", id, "name").
> ..2>   addE("knows").from("a")
> ==>e[2][0-knows->1]
> gremlin>
> gremlin> g.V().properties("name")
> ==>vp[name->alice]
> ==>vp[name->bob]
> gremlin> g.V().properties("name").dedup()
> ==>vp[name->alice]
> ==>vp[name->bob]
>
>
> Without the change in id comparison, the last statement would have only
> returned 1 of the properties. Looked easy enough, but - of course - it
> broke the test suite. This change had an impact on 2 types of tests:
>
>- those, that deal with serialization and deserialization
>- those, that make use of bytecode
>
> Perhaps the latter can be seen as a more specific case of the former. The
> problem is that serialized/deserialized/detached properties no longer have
> a reference to their former parent element. I thought about skipping the
> parent id comparison in case one of the elements parents is *null*, but at
> some point that just felt wrong and made me think of all kind of horror
> scenarios this could/would lead to.
>
> So my question is, what would be the smartest way to handle that? Adjust
> all test cases, so they no longer rely on full equality? Fix
> (de)serialization to include parent element ids? Something else?
>
> *Example of a failing test:*
>
> [ERROR]   SerializationTest$GryoV1d0Test.shouldSerializeTree:254 The
> objects differ
> expected:
>
> org.apache.tinkerpop.gremlin.process.traversal.step.util.Tree<{v[1]={v[2]={vp[name->vadas]={}},
> v[3]={vp[name->lop]={}}, v[4]={vp[name->josh]={>
> but was:
>
> org.apache.tinkerpop.gremlin.process.traversal.step.util.Tree<{v[1]={v[2]={vp[name->vadas]={}},
> v[3]={vp[name->lop]={}}, v[4]={vp[name->josh]={>
>
>
> Crazy thought: We could just change the tests to compare the toString()
> versions of results
>
> Cheers,
> Daniel
>